[jira] [Commented] (HBASE-13014) Java Tool For Region Moving
[ https://issues.apache.org/jira/browse/HBASE-13014?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14985674#comment-14985674 ] stack commented on HBASE-13014: --- Let me commit. TestBlockEvictionFromClient has failed at least once before: https://builds.apache.org/job/PreCommit-HBASE-Build/16345/testReport/org.apache.hadoop.hbase.client/TestBlockEvictionFromClient/testScanWithException/history/ Seems unrelated. > Java Tool For Region Moving > > > Key: HBASE-13014 > URL: https://issues.apache.org/jira/browse/HBASE-13014 > Project: HBase > Issue Type: Improvement >Reporter: Abhishek Singh Chouhan >Assignee: Abhishek Singh Chouhan > Fix For: 2.0.0 > > Attachments: HBASE-13014-master-v2.patch, HBASE-13014-master-v3 > (1).patch, HBASE-13014-master-v3 (1).patch, HBASE-13014-master-v3 (1).patch, > HBASE-13014-master-v3.patch, HBASE-13014-master-v3.patch, > HBASE-13014-master-v3.patch, HBASE-13014-master.patch, HBASE-13014-v2.patch, > HBASE-13014-v3.patch, HBASE-13014-v4.patch, HBASE-13014-v5.patch, > HBASE-13014-v6.patch, HBASE-13014.patch > > > As per discussion on HBASE-12989 we should move the functionality of > region_mover.rb into a Java tool and use region_mover.rb only only as a > wrapper around it. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-13014) Java Tool For Region Moving
[
https://issues.apache.org/jira/browse/HBASE-13014?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14985666#comment-14985666
]
Hadoop QA commented on HBASE-13014:
---
{color:green}+1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12770106/HBASE-13014-master-v3%20%281%29.patch
against master branch at commit 6c5da91b18d002888dce9d9a4e78cd395face54f.
ATTACHMENT ID: 12770106
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 2 new
or modified tests.
{color:green}+1 hadoop versions{color}. The patch compiles with all
supported hadoop versions (2.4.0 2.4.1 2.5.0 2.5.1 2.5.2 2.6.0 2.6.1 2.7.0
2.7.1)
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 protoc{color}. The applied patch does not increase the
total number of protoc compiler warnings.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 checkstyle{color}. The applied patch does not increase the
total number of checkstyle errors
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 2.0.3) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 lineLengths{color}. The patch does not introduce lines
longer than 100
{color:green}+1 site{color}. The mvn post-site goal succeeds with this patch.
{color:green}+1 core tests{color}. The patch passed unit tests in .
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/16351//testReport/
Release Findbugs (version 2.0.3)warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/16351//artifact/patchprocess/newFindbugsWarnings.html
Checkstyle Errors:
https://builds.apache.org/job/PreCommit-HBASE-Build/16351//artifact/patchprocess/checkstyle-aggregate.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/16351//console
This message is automatically generated.
> Java Tool For Region Moving
>
>
> Key: HBASE-13014
> URL: https://issues.apache.org/jira/browse/HBASE-13014
> Project: HBase
> Issue Type: Improvement
>Reporter: Abhishek Singh Chouhan
>Assignee: Abhishek Singh Chouhan
> Fix For: 2.0.0
>
> Attachments: HBASE-13014-master-v2.patch, HBASE-13014-master-v3
> (1).patch, HBASE-13014-master-v3 (1).patch, HBASE-13014-master-v3 (1).patch,
> HBASE-13014-master-v3.patch, HBASE-13014-master-v3.patch,
> HBASE-13014-master-v3.patch, HBASE-13014-master.patch, HBASE-13014-v2.patch,
> HBASE-13014-v3.patch, HBASE-13014-v4.patch, HBASE-13014-v5.patch,
> HBASE-13014-v6.patch, HBASE-13014.patch
>
>
> As per discussion on HBASE-12989 we should move the functionality of
> region_mover.rb into a Java tool and use region_mover.rb only only as a
> wrapper around it.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-13014) Java Tool For Region Moving
[
https://issues.apache.org/jira/browse/HBASE-13014?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14984883#comment-14984883
]
Hadoop QA commented on HBASE-13014:
---
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12770037/HBASE-13014-master-v3%20%281%29.patch
against master branch at commit 9c37239f582d51cb99718f5445f64b273c2251ed.
ATTACHMENT ID: 12770037
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 2 new
or modified tests.
{color:green}+1 hadoop versions{color}. The patch compiles with all
supported hadoop versions (2.4.0 2.4.1 2.5.0 2.5.1 2.5.2 2.6.0 2.6.1 2.7.0
2.7.1)
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 protoc{color}. The applied patch does not increase the
total number of protoc compiler warnings.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 checkstyle{color}. The applied patch does not increase the
total number of checkstyle errors
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 2.0.3) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 lineLengths{color}. The patch does not introduce lines
longer than 100
{color:green}+1 site{color}. The mvn post-site goal succeeds with this patch.
{color:red}-1 core tests{color}. The patch failed these unit tests:
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/16343//testReport/
Release Findbugs (version 2.0.3)warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/16343//artifact/patchprocess/newFindbugsWarnings.html
Checkstyle Errors:
https://builds.apache.org/job/PreCommit-HBASE-Build/16343//artifact/patchprocess/checkstyle-aggregate.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/16343//console
This message is automatically generated.
> Java Tool For Region Moving
>
>
> Key: HBASE-13014
> URL: https://issues.apache.org/jira/browse/HBASE-13014
> Project: HBase
> Issue Type: Improvement
>Reporter: Abhishek Singh Chouhan
>Assignee: Abhishek Singh Chouhan
> Fix For: 2.0.0
>
> Attachments: HBASE-13014-master-v2.patch, HBASE-13014-master-v3
> (1).patch, HBASE-13014-master-v3.patch, HBASE-13014-master-v3.patch,
> HBASE-13014-master-v3.patch, HBASE-13014-master.patch, HBASE-13014-v2.patch,
> HBASE-13014-v3.patch, HBASE-13014-v4.patch, HBASE-13014-v5.patch,
> HBASE-13014-v6.patch, HBASE-13014.patch
>
>
> As per discussion on HBASE-12989 we should move the functionality of
> region_mover.rb into a Java tool and use region_mover.rb only only as a
> wrapper around it.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-13014) Java Tool For Region Moving
[ https://issues.apache.org/jira/browse/HBASE-13014?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14986022#comment-14986022 ] Hudson commented on HBASE-13014: FAILURE: Integrated in HBase-TRUNK #6985 (See [https://builds.apache.org/job/HBase-TRUNK/6985/]) HBASE-13014 Java Tool For Region Moving (stack: rev a9a56ad508fa67d006df7a3b868cece04e10fc2b) * hbase-server/src/test/java/org/apache/hadoop/hbase/util/TestRegionMover.java * hbase-server/src/main/java/org/apache/hadoop/hbase/util/RegionMover.java > Java Tool For Region Moving > > > Key: HBASE-13014 > URL: https://issues.apache.org/jira/browse/HBASE-13014 > Project: HBase > Issue Type: Improvement >Reporter: Abhishek Singh Chouhan >Assignee: Abhishek Singh Chouhan > Fix For: 2.0.0 > > Attachments: HBASE-13014-master-v2.patch, HBASE-13014-master-v3 > (1).patch, HBASE-13014-master-v3 (1).patch, HBASE-13014-master-v3 (1).patch, > HBASE-13014-master-v3.patch, HBASE-13014-master-v3.patch, > HBASE-13014-master-v3.patch, HBASE-13014-master.patch, HBASE-13014-v2.patch, > HBASE-13014-v3.patch, HBASE-13014-v4.patch, HBASE-13014-v5.patch, > HBASE-13014-v6.patch, HBASE-13014.patch > > > As per discussion on HBASE-12989 we should move the functionality of > region_mover.rb into a Java tool and use region_mover.rb only only as a > wrapper around it. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-13014) Java Tool For Region Moving
[ https://issues.apache.org/jira/browse/HBASE-13014?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14986115#comment-14986115 ] stack commented on HBASE-13014: --- Ok. Reverted because it looks like I applied patch w/ v6 instead of latest for master; build was failing. I then applied the master v3. It at least compiles. > Java Tool For Region Moving > > > Key: HBASE-13014 > URL: https://issues.apache.org/jira/browse/HBASE-13014 > Project: HBase > Issue Type: Improvement >Reporter: Abhishek Singh Chouhan >Assignee: Abhishek Singh Chouhan > Fix For: 2.0.0 > > Attachments: HBASE-13014-master-v2.patch, HBASE-13014-master-v3 > (1).patch, HBASE-13014-master-v3 (1).patch, HBASE-13014-master-v3 (1).patch, > HBASE-13014-master-v3.patch, HBASE-13014-master-v3.patch, > HBASE-13014-master-v3.patch, HBASE-13014-master.patch, HBASE-13014-v2.patch, > HBASE-13014-v3.patch, HBASE-13014-v4.patch, HBASE-13014-v5.patch, > HBASE-13014-v6.patch, HBASE-13014.patch > > > As per discussion on HBASE-12989 we should move the functionality of > region_mover.rb into a Java tool and use region_mover.rb only only as a > wrapper around it. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-13014) Java Tool For Region Moving
[ https://issues.apache.org/jira/browse/HBASE-13014?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14986123#comment-14986123 ] Abhishek Singh Chouhan commented on HBASE-13014: I made the initial patches for 0.98. API differences must have led to compilation failure on master. > Java Tool For Region Moving > > > Key: HBASE-13014 > URL: https://issues.apache.org/jira/browse/HBASE-13014 > Project: HBase > Issue Type: Improvement >Reporter: Abhishek Singh Chouhan >Assignee: Abhishek Singh Chouhan > Fix For: 2.0.0 > > Attachments: HBASE-13014-master-v2.patch, HBASE-13014-master-v3 > (1).patch, HBASE-13014-master-v3 (1).patch, HBASE-13014-master-v3 (1).patch, > HBASE-13014-master-v3.patch, HBASE-13014-master-v3.patch, > HBASE-13014-master-v3.patch, HBASE-13014-master.patch, HBASE-13014-v2.patch, > HBASE-13014-v3.patch, HBASE-13014-v4.patch, HBASE-13014-v5.patch, > HBASE-13014-v6.patch, HBASE-13014.patch > > > As per discussion on HBASE-12989 we should move the functionality of > region_mover.rb into a Java tool and use region_mover.rb only only as a > wrapper around it. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-13014) Java Tool For Region Moving
[ https://issues.apache.org/jira/browse/HBASE-13014?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14984910#comment-14984910 ] Abhishek Singh Chouhan commented on HBASE-13014: Thanks!! I'll start working on the ruby changes and will get those in soon after this goes in. > Java Tool For Region Moving > > > Key: HBASE-13014 > URL: https://issues.apache.org/jira/browse/HBASE-13014 > Project: HBase > Issue Type: Improvement >Reporter: Abhishek Singh Chouhan >Assignee: Abhishek Singh Chouhan > Fix For: 2.0.0 > > Attachments: HBASE-13014-master-v2.patch, HBASE-13014-master-v3 > (1).patch, HBASE-13014-master-v3.patch, HBASE-13014-master-v3.patch, > HBASE-13014-master-v3.patch, HBASE-13014-master.patch, HBASE-13014-v2.patch, > HBASE-13014-v3.patch, HBASE-13014-v4.patch, HBASE-13014-v5.patch, > HBASE-13014-v6.patch, HBASE-13014.patch > > > As per discussion on HBASE-12989 we should move the functionality of > region_mover.rb into a Java tool and use region_mover.rb only only as a > wrapper around it. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-13014) Java Tool For Region Moving
[ https://issues.apache.org/jira/browse/HBASE-13014?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14984892#comment-14984892 ] Abhishek Singh Chouhan commented on HBASE-13014: Test run exited with "Failed to execute goal org.apache.maven.plugins:maven-surefire-plugin:2.18.1:test (secondPartTestsExecution) on project hbase-server: ExecutionException: java.lang.RuntimeException: The forked VM terminated without properly saying goodbye. VM crash or System.exit called?" almost on the edge of completion of hbase-server tests. > Java Tool For Region Moving > > > Key: HBASE-13014 > URL: https://issues.apache.org/jira/browse/HBASE-13014 > Project: HBase > Issue Type: Improvement >Reporter: Abhishek Singh Chouhan >Assignee: Abhishek Singh Chouhan > Fix For: 2.0.0 > > Attachments: HBASE-13014-master-v2.patch, HBASE-13014-master-v3 > (1).patch, HBASE-13014-master-v3.patch, HBASE-13014-master-v3.patch, > HBASE-13014-master-v3.patch, HBASE-13014-master.patch, HBASE-13014-v2.patch, > HBASE-13014-v3.patch, HBASE-13014-v4.patch, HBASE-13014-v5.patch, > HBASE-13014-v6.patch, HBASE-13014.patch > > > As per discussion on HBASE-12989 we should move the functionality of > region_mover.rb into a Java tool and use region_mover.rb only only as a > wrapper around it. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-13014) Java Tool For Region Moving
[ https://issues.apache.org/jira/browse/HBASE-13014?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14986351#comment-14986351 ] Hudson commented on HBASE-13014: SUCCESS: Integrated in HBase-TRUNK #6986 (See [https://builds.apache.org/job/HBase-TRUNK/6986/]) Revert "HBASE-13014 Java Tool For Region Moving" Breaks the build. I (stack: rev 87cc38f9ab4ca3ae6bb4104201d3824d9505e50e) * hbase-server/src/main/java/org/apache/hadoop/hbase/util/RegionMover.java * hbase-server/src/test/java/org/apache/hadoop/hbase/util/TestRegionMover.java HBASE-13014 Java Tool For Region Moving (Abhishek Singh Chouhan) (stack: rev f0176d942af26c8423d534d6b806b83817dd98e0) * hbase-server/src/test/java/org/apache/hadoop/hbase/util/TestRegionMover.java * hbase-server/src/main/java/org/apache/hadoop/hbase/util/RegionMover.java > Java Tool For Region Moving > > > Key: HBASE-13014 > URL: https://issues.apache.org/jira/browse/HBASE-13014 > Project: HBase > Issue Type: Improvement >Reporter: Abhishek Singh Chouhan >Assignee: Abhishek Singh Chouhan > Fix For: 2.0.0 > > Attachments: HBASE-13014-master-v2.patch, HBASE-13014-master-v3 > (1).patch, HBASE-13014-master-v3 (1).patch, HBASE-13014-master-v3 (1).patch, > HBASE-13014-master-v3.patch, HBASE-13014-master-v3.patch, > HBASE-13014-master-v3.patch, HBASE-13014-master.patch, HBASE-13014-v2.patch, > HBASE-13014-v3.patch, HBASE-13014-v4.patch, HBASE-13014-v5.patch, > HBASE-13014-v6.patch, HBASE-13014.patch > > > As per discussion on HBASE-12989 we should move the functionality of > region_mover.rb into a Java tool and use region_mover.rb only only as a > wrapper around it. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-13014) Java Tool For Region Moving
[ https://issues.apache.org/jira/browse/HBASE-13014?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14986180#comment-14986180 ] Hudson commented on HBASE-13014: FAILURE: Integrated in HBase-Trunk_matrix #424 (See [https://builds.apache.org/job/HBase-Trunk_matrix/424/]) HBASE-13014 Java Tool For Region Moving (stack: rev a9a56ad508fa67d006df7a3b868cece04e10fc2b) * hbase-server/src/main/java/org/apache/hadoop/hbase/util/RegionMover.java * hbase-server/src/test/java/org/apache/hadoop/hbase/util/TestRegionMover.java > Java Tool For Region Moving > > > Key: HBASE-13014 > URL: https://issues.apache.org/jira/browse/HBASE-13014 > Project: HBase > Issue Type: Improvement >Reporter: Abhishek Singh Chouhan >Assignee: Abhishek Singh Chouhan > Fix For: 2.0.0 > > Attachments: HBASE-13014-master-v2.patch, HBASE-13014-master-v3 > (1).patch, HBASE-13014-master-v3 (1).patch, HBASE-13014-master-v3 (1).patch, > HBASE-13014-master-v3.patch, HBASE-13014-master-v3.patch, > HBASE-13014-master-v3.patch, HBASE-13014-master.patch, HBASE-13014-v2.patch, > HBASE-13014-v3.patch, HBASE-13014-v4.patch, HBASE-13014-v5.patch, > HBASE-13014-v6.patch, HBASE-13014.patch > > > As per discussion on HBASE-12989 we should move the functionality of > region_mover.rb into a Java tool and use region_mover.rb only only as a > wrapper around it. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-13014) Java Tool For Region Moving
[
https://issues.apache.org/jira/browse/HBASE-13014?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14985078#comment-14985078
]
Hadoop QA commented on HBASE-13014:
---
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12770060/HBASE-13014-master-v3%20%281%29.patch
against master branch at commit 6dbb5a8052c5cbff9dfb9ebac68d3200d3543955.
ATTACHMENT ID: 12770060
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 2 new
or modified tests.
{color:green}+1 hadoop versions{color}. The patch compiles with all
supported hadoop versions (2.4.0 2.4.1 2.5.0 2.5.1 2.5.2 2.6.0 2.6.1 2.7.0
2.7.1)
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 protoc{color}. The applied patch does not increase the
total number of protoc compiler warnings.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 checkstyle{color}. The applied patch does not increase the
total number of checkstyle errors
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 2.0.3) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 lineLengths{color}. The patch does not introduce lines
longer than 100
{color:green}+1 site{color}. The mvn post-site goal succeeds with this patch.
{color:red}-1 core tests{color}. The patch failed these unit tests:
org.apache.hadoop.hbase.client.TestBlockEvictionFromClient
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/16345//testReport/
Release Findbugs (version 2.0.3)warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/16345//artifact/patchprocess/newFindbugsWarnings.html
Checkstyle Errors:
https://builds.apache.org/job/PreCommit-HBASE-Build/16345//artifact/patchprocess/checkstyle-aggregate.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/16345//console
This message is automatically generated.
> Java Tool For Region Moving
>
>
> Key: HBASE-13014
> URL: https://issues.apache.org/jira/browse/HBASE-13014
> Project: HBase
> Issue Type: Improvement
>Reporter: Abhishek Singh Chouhan
>Assignee: Abhishek Singh Chouhan
> Fix For: 2.0.0
>
> Attachments: HBASE-13014-master-v2.patch, HBASE-13014-master-v3
> (1).patch, HBASE-13014-master-v3 (1).patch, HBASE-13014-master-v3.patch,
> HBASE-13014-master-v3.patch, HBASE-13014-master-v3.patch,
> HBASE-13014-master.patch, HBASE-13014-v2.patch, HBASE-13014-v3.patch,
> HBASE-13014-v4.patch, HBASE-13014-v5.patch, HBASE-13014-v6.patch,
> HBASE-13014.patch
>
>
> As per discussion on HBASE-12989 we should move the functionality of
> region_mover.rb into a Java tool and use region_mover.rb only only as a
> wrapper around it.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-13014) Java Tool For Region Moving
[ https://issues.apache.org/jira/browse/HBASE-13014?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14985097#comment-14985097 ] Abhishek Singh Chouhan commented on HBASE-13014: Test failure is unrelated :( Want me to go for another run? [~stack] > Java Tool For Region Moving > > > Key: HBASE-13014 > URL: https://issues.apache.org/jira/browse/HBASE-13014 > Project: HBase > Issue Type: Improvement >Reporter: Abhishek Singh Chouhan >Assignee: Abhishek Singh Chouhan > Fix For: 2.0.0 > > Attachments: HBASE-13014-master-v2.patch, HBASE-13014-master-v3 > (1).patch, HBASE-13014-master-v3 (1).patch, HBASE-13014-master-v3.patch, > HBASE-13014-master-v3.patch, HBASE-13014-master-v3.patch, > HBASE-13014-master.patch, HBASE-13014-v2.patch, HBASE-13014-v3.patch, > HBASE-13014-v4.patch, HBASE-13014-v5.patch, HBASE-13014-v6.patch, > HBASE-13014.patch > > > As per discussion on HBASE-12989 we should move the functionality of > region_mover.rb into a Java tool and use region_mover.rb only only as a > wrapper around it. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-13014) Java Tool For Region Moving
[ https://issues.apache.org/jira/browse/HBASE-13014?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14986671#comment-14986671 ] Hudson commented on HBASE-13014: FAILURE: Integrated in HBase-Trunk_matrix #425 (See [https://builds.apache.org/job/HBase-Trunk_matrix/425/]) Revert "HBASE-13014 Java Tool For Region Moving" Breaks the build. I (stack: rev 87cc38f9ab4ca3ae6bb4104201d3824d9505e50e) * hbase-server/src/test/java/org/apache/hadoop/hbase/util/TestRegionMover.java * hbase-server/src/main/java/org/apache/hadoop/hbase/util/RegionMover.java HBASE-13014 Java Tool For Region Moving (Abhishek Singh Chouhan) (stack: rev f0176d942af26c8423d534d6b806b83817dd98e0) * hbase-server/src/test/java/org/apache/hadoop/hbase/util/TestRegionMover.java * hbase-server/src/main/java/org/apache/hadoop/hbase/util/RegionMover.java > Java Tool For Region Moving > > > Key: HBASE-13014 > URL: https://issues.apache.org/jira/browse/HBASE-13014 > Project: HBase > Issue Type: Improvement >Reporter: Abhishek Singh Chouhan >Assignee: Abhishek Singh Chouhan > Fix For: 2.0.0 > > Attachments: HBASE-13014-master-v2.patch, HBASE-13014-master-v3 > (1).patch, HBASE-13014-master-v3 (1).patch, HBASE-13014-master-v3 (1).patch, > HBASE-13014-master-v3.patch, HBASE-13014-master-v3.patch, > HBASE-13014-master-v3.patch, HBASE-13014-master.patch, HBASE-13014-v2.patch, > HBASE-13014-v3.patch, HBASE-13014-v4.patch, HBASE-13014-v5.patch, > HBASE-13014-v6.patch, HBASE-13014.patch > > > As per discussion on HBASE-12989 we should move the functionality of > region_mover.rb into a Java tool and use region_mover.rb only only as a > wrapper around it. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-13014) Java Tool For Region Moving
[ https://issues.apache.org/jira/browse/HBASE-13014?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14984761#comment-14984761 ] Abhishek Singh Chouhan commented on HBASE-13014: QA looks good :) Wanna give this another try ? [~stack] [~apurtell] > Java Tool For Region Moving > > > Key: HBASE-13014 > URL: https://issues.apache.org/jira/browse/HBASE-13014 > Project: HBase > Issue Type: Improvement >Reporter: Abhishek Singh Chouhan >Assignee: Abhishek Singh Chouhan > Fix For: 2.0.0 > > Attachments: HBASE-13014-master-v2.patch, > HBASE-13014-master-v3.patch, HBASE-13014-master-v3.patch, > HBASE-13014-master-v3.patch, HBASE-13014-master.patch, HBASE-13014-v2.patch, > HBASE-13014-v3.patch, HBASE-13014-v4.patch, HBASE-13014-v5.patch, > HBASE-13014-v6.patch, HBASE-13014.patch > > > As per discussion on HBASE-12989 we should move the functionality of > region_mover.rb into a Java tool and use region_mover.rb only only as a > wrapper around it. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-13014) Java Tool For Region Moving
[ https://issues.apache.org/jira/browse/HBASE-13014?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14984067#comment-14984067 ] Abhishek Singh Chouhan commented on HBASE-13014: Will paste the usage output soon. Intent is to replace the region_mover.rb script in bin (this also introduces the no-ack mode and also the timeout option) with this, the ruby script will just be used to call this. I'll create jira for that. Once this is in master and is sufficiently stable we can then replace the ruby script for good(rolling restart will also come to this then), i'll also work on putting this through to 0.98 and branch-1. > Java Tool For Region Moving > > > Key: HBASE-13014 > URL: https://issues.apache.org/jira/browse/HBASE-13014 > Project: HBase > Issue Type: Improvement >Reporter: Abhishek Singh Chouhan >Assignee: Abhishek Singh Chouhan > Fix For: 2.0.0 > > Attachments: HBASE-13014-master-v2.patch, > HBASE-13014-master-v3.patch, HBASE-13014-master-v3.patch, > HBASE-13014-master-v3.patch, HBASE-13014-master.patch, HBASE-13014-v2.patch, > HBASE-13014-v3.patch, HBASE-13014-v4.patch, HBASE-13014-v5.patch, > HBASE-13014-v6.patch, HBASE-13014.patch > > > As per discussion on HBASE-12989 we should move the functionality of > region_mover.rb into a Java tool and use region_mover.rb only only as a > wrapper around it. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-13014) Java Tool For Region Moving
[ https://issues.apache.org/jira/browse/HBASE-13014?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14984069#comment-14984069 ] Abhishek Singh Chouhan commented on HBASE-13014: Will paste the usage output soon. Intent is to replace the region_mover.rb script in bin (this also introduces the no-ack mode and also the timeout option) with this, the ruby script will just be used to call this. I'll create jira for that. Once this is in master and is sufficiently stable we can then replace the ruby script for good(rolling restart will also come to this then), i'll also work on putting this through to 0.98 and branch-1. > Java Tool For Region Moving > > > Key: HBASE-13014 > URL: https://issues.apache.org/jira/browse/HBASE-13014 > Project: HBase > Issue Type: Improvement >Reporter: Abhishek Singh Chouhan >Assignee: Abhishek Singh Chouhan > Fix For: 2.0.0 > > Attachments: HBASE-13014-master-v2.patch, > HBASE-13014-master-v3.patch, HBASE-13014-master-v3.patch, > HBASE-13014-master-v3.patch, HBASE-13014-master.patch, HBASE-13014-v2.patch, > HBASE-13014-v3.patch, HBASE-13014-v4.patch, HBASE-13014-v5.patch, > HBASE-13014-v6.patch, HBASE-13014.patch > > > As per discussion on HBASE-12989 we should move the functionality of > region_mover.rb into a Java tool and use region_mover.rb only only as a > wrapper around it. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-13014) Java Tool For Region Moving
[
https://issues.apache.org/jira/browse/HBASE-13014?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14984158#comment-14984158
]
Hadoop QA commented on HBASE-13014:
---
{color:green}+1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12769950/HBASE-13014-master-v3.patch
against master branch at commit 683f84e6a217dfd872e5f1be82c7aa4cdf232ec1.
ATTACHMENT ID: 12769950
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 2 new
or modified tests.
{color:green}+1 hadoop versions{color}. The patch compiles with all
supported hadoop versions (2.4.0 2.4.1 2.5.0 2.5.1 2.5.2 2.6.0 2.6.1 2.7.0
2.7.1)
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 protoc{color}. The applied patch does not increase the
total number of protoc compiler warnings.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 checkstyle{color}. The applied patch does not increase the
total number of checkstyle errors
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 2.0.3) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 lineLengths{color}. The patch does not introduce lines
longer than 100
{color:green}+1 site{color}. The mvn post-site goal succeeds with this patch.
{color:green}+1 core tests{color}. The patch passed unit tests in .
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/16334//testReport/
Release Findbugs (version 2.0.3)warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/16334//artifact/patchprocess/newFindbugsWarnings.html
Checkstyle Errors:
https://builds.apache.org/job/PreCommit-HBASE-Build/16334//artifact/patchprocess/checkstyle-aggregate.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/16334//console
This message is automatically generated.
> Java Tool For Region Moving
>
>
> Key: HBASE-13014
> URL: https://issues.apache.org/jira/browse/HBASE-13014
> Project: HBase
> Issue Type: Improvement
>Reporter: Abhishek Singh Chouhan
>Assignee: Abhishek Singh Chouhan
> Fix For: 2.0.0
>
> Attachments: HBASE-13014-master-v2.patch,
> HBASE-13014-master-v3.patch, HBASE-13014-master-v3.patch,
> HBASE-13014-master-v3.patch, HBASE-13014-master.patch, HBASE-13014-v2.patch,
> HBASE-13014-v3.patch, HBASE-13014-v4.patch, HBASE-13014-v5.patch,
> HBASE-13014-v6.patch, HBASE-13014.patch
>
>
> As per discussion on HBASE-12989 we should move the functionality of
> region_mover.rb into a Java tool and use region_mover.rb only only as a
> wrapper around it.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-13014) Java Tool For Region Moving
[
https://issues.apache.org/jira/browse/HBASE-13014?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14982026#comment-14982026
]
Abhishek Singh Chouhan commented on HBASE-13014:
Problem was with the test
{noformat}
LOG.info("Successfully Unloaded\nNow Loading");
rm.load();
Thread.sleep(100);
assertEquals(noRegions, regionServer.getNumberOfOnlineRegions());
{noformat}
This was failing on slow machines as the loading was taking some time. Changed
the test(and also unloadWithoutAck) to make it less strict too (since it is for
best effort mode, only checking if some regions are loaded)
{noformat}
rm.load();
TEST_UTIL.waitFor(5000, 500, new Predicate() {
@Override
public boolean evaluate() throws Exception {
return regionServer.getNumberOfOnlineRegions() > 0;
}
});
{noformat}
> Java Tool For Region Moving
>
>
> Key: HBASE-13014
> URL: https://issues.apache.org/jira/browse/HBASE-13014
> Project: HBase
> Issue Type: Improvement
>Reporter: Abhishek Singh Chouhan
>Assignee: Abhishek Singh Chouhan
> Fix For: 2.0.0
>
> Attachments: HBASE-13014-master-v2.patch, HBASE-13014-master.patch,
> HBASE-13014-v2.patch, HBASE-13014-v3.patch, HBASE-13014-v4.patch,
> HBASE-13014-v5.patch, HBASE-13014-v6.patch, HBASE-13014.patch
>
>
> As per discussion on HBASE-12989 we should move the functionality of
> region_mover.rb into a Java tool and use region_mover.rb only only as a
> wrapper around it.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-13014) Java Tool For Region Moving
[
https://issues.apache.org/jira/browse/HBASE-13014?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14982427#comment-14982427
]
Hadoop QA commented on HBASE-13014:
---
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12769709/HBASE-13014-master-v3.patch
against master branch at commit 84f4cceb485379d080ec9fb000c9ce5a77638d89.
ATTACHMENT ID: 12769709
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 2 new
or modified tests.
{color:green}+1 hadoop versions{color}. The patch compiles with all
supported hadoop versions (2.4.0 2.4.1 2.5.0 2.5.1 2.5.2 2.6.0 2.6.1 2.7.0
2.7.1)
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 protoc{color}. The applied patch does not increase the
total number of protoc compiler warnings.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 checkstyle{color}. The applied patch does not increase the
total number of checkstyle errors
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 2.0.3) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 lineLengths{color}. The patch does not introduce lines
longer than 100
{color:green}+1 site{color}. The mvn post-site goal succeeds with this patch.
{color:red}-1 core tests{color}. The patch failed these unit tests:
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/16300//testReport/
Release Findbugs (version 2.0.3)warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/16300//artifact/patchprocess/newFindbugsWarnings.html
Checkstyle Errors:
https://builds.apache.org/job/PreCommit-HBASE-Build/16300//artifact/patchprocess/checkstyle-aggregate.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/16300//console
This message is automatically generated.
> Java Tool For Region Moving
>
>
> Key: HBASE-13014
> URL: https://issues.apache.org/jira/browse/HBASE-13014
> Project: HBase
> Issue Type: Improvement
>Reporter: Abhishek Singh Chouhan
>Assignee: Abhishek Singh Chouhan
> Fix For: 2.0.0
>
> Attachments: HBASE-13014-master-v2.patch,
> HBASE-13014-master-v3.patch, HBASE-13014-master.patch, HBASE-13014-v2.patch,
> HBASE-13014-v3.patch, HBASE-13014-v4.patch, HBASE-13014-v5.patch,
> HBASE-13014-v6.patch, HBASE-13014.patch
>
>
> As per discussion on HBASE-12989 we should move the functionality of
> region_mover.rb into a Java tool and use region_mover.rb only only as a
> wrapper around it.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-13014) Java Tool For Region Moving
[
https://issues.apache.org/jira/browse/HBASE-13014?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14982767#comment-14982767
]
Hadoop QA commented on HBASE-13014:
---
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12769765/HBASE-13014-master-v3.patch
against master branch at commit 84f4cceb485379d080ec9fb000c9ce5a77638d89.
ATTACHMENT ID: 12769765
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 2 new
or modified tests.
{color:green}+1 hadoop versions{color}. The patch compiles with all
supported hadoop versions (2.4.0 2.4.1 2.5.0 2.5.1 2.5.2 2.6.0 2.6.1 2.7.0
2.7.1)
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 protoc{color}. The applied patch does not increase the
total number of protoc compiler warnings.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 checkstyle{color}. The applied patch does not increase the
total number of checkstyle errors
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 2.0.3) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 lineLengths{color}. The patch does not introduce lines
longer than 100
{color:green}+1 site{color}. The mvn post-site goal succeeds with this patch.
{color:red}-1 core tests{color}. The patch failed these unit tests:
org.apache.hadoop.hbase.thrift.TestThriftHttpServer
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/16304//testReport/
Release Findbugs (version 2.0.3)warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/16304//artifact/patchprocess/newFindbugsWarnings.html
Checkstyle Errors:
https://builds.apache.org/job/PreCommit-HBASE-Build/16304//artifact/patchprocess/checkstyle-aggregate.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/16304//console
This message is automatically generated.
> Java Tool For Region Moving
>
>
> Key: HBASE-13014
> URL: https://issues.apache.org/jira/browse/HBASE-13014
> Project: HBase
> Issue Type: Improvement
>Reporter: Abhishek Singh Chouhan
>Assignee: Abhishek Singh Chouhan
> Fix For: 2.0.0
>
> Attachments: HBASE-13014-master-v2.patch,
> HBASE-13014-master-v3.patch, HBASE-13014-master-v3.patch,
> HBASE-13014-master.patch, HBASE-13014-v2.patch, HBASE-13014-v3.patch,
> HBASE-13014-v4.patch, HBASE-13014-v5.patch, HBASE-13014-v6.patch,
> HBASE-13014.patch
>
>
> As per discussion on HBASE-12989 we should move the functionality of
> region_mover.rb into a Java tool and use region_mover.rb only only as a
> wrapper around it.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-13014) Java Tool For Region Moving
[ https://issues.apache.org/jira/browse/HBASE-13014?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14982772#comment-14982772 ] stack commented on HBASE-13014: --- [~abhishek.chouhan] Thanks for working on fix. The test run above complained: " ExecutionException Error occurred in starting fork, check output in log" Let me rerun for you. The TestThriftHttpServer usually passes: https://builds.apache.org/job/PreCommit-HBASE-Build/16304/testReport/org.apache.hadoop.hbase.thrift/TestThriftHttpServer/testRunThriftServerWithHeaderBufferLength/history/ > Java Tool For Region Moving > > > Key: HBASE-13014 > URL: https://issues.apache.org/jira/browse/HBASE-13014 > Project: HBase > Issue Type: Improvement >Reporter: Abhishek Singh Chouhan >Assignee: Abhishek Singh Chouhan > Fix For: 2.0.0 > > Attachments: HBASE-13014-master-v2.patch, > HBASE-13014-master-v3.patch, HBASE-13014-master-v3.patch, > HBASE-13014-master-v3.patch, HBASE-13014-master.patch, HBASE-13014-v2.patch, > HBASE-13014-v3.patch, HBASE-13014-v4.patch, HBASE-13014-v5.patch, > HBASE-13014-v6.patch, HBASE-13014.patch > > > As per discussion on HBASE-12989 we should move the functionality of > region_mover.rb into a Java tool and use region_mover.rb only only as a > wrapper around it. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-13014) Java Tool For Region Moving
[ https://issues.apache.org/jira/browse/HBASE-13014?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14982779#comment-14982779 ] stack commented on HBASE-13014: --- On the patch, the script looks great. Do you have examples of output you could paste in here. In particular, paste the usage output as release note? Does this subsume any of the ruby scripts in bin/*? If so, can we wholesale replace them with this script? Could do in a new patch. Can this script be used for rolling restart? Even if its just a case of the rolling restart ruby script calling through to this. Thanks for working on this. > Java Tool For Region Moving > > > Key: HBASE-13014 > URL: https://issues.apache.org/jira/browse/HBASE-13014 > Project: HBase > Issue Type: Improvement >Reporter: Abhishek Singh Chouhan >Assignee: Abhishek Singh Chouhan > Fix For: 2.0.0 > > Attachments: HBASE-13014-master-v2.patch, > HBASE-13014-master-v3.patch, HBASE-13014-master-v3.patch, > HBASE-13014-master-v3.patch, HBASE-13014-master.patch, HBASE-13014-v2.patch, > HBASE-13014-v3.patch, HBASE-13014-v4.patch, HBASE-13014-v5.patch, > HBASE-13014-v6.patch, HBASE-13014.patch > > > As per discussion on HBASE-12989 we should move the functionality of > region_mover.rb into a Java tool and use region_mover.rb only only as a > wrapper around it. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-13014) Java Tool For Region Moving
[
https://issues.apache.org/jira/browse/HBASE-13014?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14983147#comment-14983147
]
Hadoop QA commented on HBASE-13014:
---
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12769804/HBASE-13014-master-v3.patch
against master branch at commit b0ad82191cc216c65751b68cbc11280fd5d5cd47.
ATTACHMENT ID: 12769804
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 2 new
or modified tests.
{color:green}+1 hadoop versions{color}. The patch compiles with all
supported hadoop versions (2.4.0 2.4.1 2.5.0 2.5.1 2.5.2 2.6.0 2.6.1 2.7.0
2.7.1)
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 protoc{color}. The applied patch does not increase the
total number of protoc compiler warnings.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 checkstyle{color}. The applied patch does not increase the
total number of checkstyle errors
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 2.0.3) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 lineLengths{color}. The patch does not introduce lines
longer than 100
{color:green}+1 site{color}. The mvn post-site goal succeeds with this patch.
{color:red}-1 core tests{color}. The patch failed these unit tests:
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/16311//testReport/
Release Findbugs (version 2.0.3)warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/16311//artifact/patchprocess/newFindbugsWarnings.html
Checkstyle Errors:
https://builds.apache.org/job/PreCommit-HBASE-Build/16311//artifact/patchprocess/checkstyle-aggregate.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/16311//console
This message is automatically generated.
> Java Tool For Region Moving
>
>
> Key: HBASE-13014
> URL: https://issues.apache.org/jira/browse/HBASE-13014
> Project: HBase
> Issue Type: Improvement
>Reporter: Abhishek Singh Chouhan
>Assignee: Abhishek Singh Chouhan
> Fix For: 2.0.0
>
> Attachments: HBASE-13014-master-v2.patch,
> HBASE-13014-master-v3.patch, HBASE-13014-master-v3.patch,
> HBASE-13014-master-v3.patch, HBASE-13014-master.patch, HBASE-13014-v2.patch,
> HBASE-13014-v3.patch, HBASE-13014-v4.patch, HBASE-13014-v5.patch,
> HBASE-13014-v6.patch, HBASE-13014.patch
>
>
> As per discussion on HBASE-12989 we should move the functionality of
> region_mover.rb into a Java tool and use region_mover.rb only only as a
> wrapper around it.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-13014) Java Tool For Region Moving
[ https://issues.apache.org/jira/browse/HBASE-13014?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14981566#comment-14981566 ] stack commented on HBASE-13014: --- It failed again here: https://builds.apache.org/job/PreCommit-HBASE-Build/16289//console > Java Tool For Region Moving > > > Key: HBASE-13014 > URL: https://issues.apache.org/jira/browse/HBASE-13014 > Project: HBase > Issue Type: Improvement >Reporter: Abhishek Singh Chouhan >Assignee: Abhishek Singh Chouhan > Fix For: 2.0.0 > > Attachments: HBASE-13014-master-v2.patch, HBASE-13014-master.patch, > HBASE-13014-v2.patch, HBASE-13014-v3.patch, HBASE-13014-v4.patch, > HBASE-13014-v5.patch, HBASE-13014-v6.patch, HBASE-13014.patch > > > As per discussion on HBASE-12989 we should move the functionality of > region_mover.rb into a Java tool and use region_mover.rb only only as a > wrapper around it. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-13014) Java Tool For Region Moving
[
https://issues.apache.org/jira/browse/HBASE-13014?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14981571#comment-14981571
]
Andrew Purtell commented on HBASE-13014:
{noformat}
Failed tests:
org.apache.hadoop.hbase.util.TestRegionMover.testLoadWithoutAck(org.apache.hadoop.hbase.util.TestRegionMover)
Run 1: TestRegionMover.testLoadWithoutAck:106 expected:<0> but was:<1>
Run 2: TestRegionMover.testLoadWithoutAck:106 expected:<0> but was:<1>
Run 3: TestRegionMover.testLoadWithoutAck:106 expected:<0> but was:<1>
Tests run: 2448, Failures: 1, Errors: 0, Skipped: 42
{noformat}
Any idea what's going on here [~abhishek.chouhan]? We'll need to fix this, or
revert...
> Java Tool For Region Moving
>
>
> Key: HBASE-13014
> URL: https://issues.apache.org/jira/browse/HBASE-13014
> Project: HBase
> Issue Type: Improvement
>Reporter: Abhishek Singh Chouhan
>Assignee: Abhishek Singh Chouhan
> Fix For: 2.0.0
>
> Attachments: HBASE-13014-master-v2.patch, HBASE-13014-master.patch,
> HBASE-13014-v2.patch, HBASE-13014-v3.patch, HBASE-13014-v4.patch,
> HBASE-13014-v5.patch, HBASE-13014-v6.patch, HBASE-13014.patch
>
>
> As per discussion on HBASE-12989 we should move the functionality of
> region_mover.rb into a Java tool and use region_mover.rb only only as a
> wrapper around it.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-13014) Java Tool For Region Moving
[ https://issues.apache.org/jira/browse/HBASE-13014?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14981611#comment-14981611 ] Andrew Purtell commented on HBASE-13014: That's fine. It passed locally for me after 10 reps but that's not what counts. > Java Tool For Region Moving > > > Key: HBASE-13014 > URL: https://issues.apache.org/jira/browse/HBASE-13014 > Project: HBase > Issue Type: Improvement >Reporter: Abhishek Singh Chouhan >Assignee: Abhishek Singh Chouhan > Fix For: 2.0.0 > > Attachments: HBASE-13014-master-v2.patch, HBASE-13014-master.patch, > HBASE-13014-v2.patch, HBASE-13014-v3.patch, HBASE-13014-v4.patch, > HBASE-13014-v5.patch, HBASE-13014-v6.patch, HBASE-13014.patch > > > As per discussion on HBASE-12989 we should move the functionality of > region_mover.rb into a Java tool and use region_mover.rb only only as a > wrapper around it. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-13014) Java Tool For Region Moving
[ https://issues.apache.org/jira/browse/HBASE-13014?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14981594#comment-14981594 ] stack commented on HBASE-13014: --- I reverted it for now. Hope that is ok. It failed again here: https://builds.apache.org/job/PreCommit-HBASE-Build/16291//console It is holding up progress. > Java Tool For Region Moving > > > Key: HBASE-13014 > URL: https://issues.apache.org/jira/browse/HBASE-13014 > Project: HBase > Issue Type: Improvement >Reporter: Abhishek Singh Chouhan >Assignee: Abhishek Singh Chouhan > Fix For: 2.0.0 > > Attachments: HBASE-13014-master-v2.patch, HBASE-13014-master.patch, > HBASE-13014-v2.patch, HBASE-13014-v3.patch, HBASE-13014-v4.patch, > HBASE-13014-v5.patch, HBASE-13014-v6.patch, HBASE-13014.patch > > > As per discussion on HBASE-12989 we should move the functionality of > region_mover.rb into a Java tool and use region_mover.rb only only as a > wrapper around it. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-13014) Java Tool For Region Moving
[ https://issues.apache.org/jira/browse/HBASE-13014?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14981600#comment-14981600 ] stack commented on HBASE-13014: --- This patch brought on a RAT failure too? https://builds.apache.org/job/HBase-TRUNK/6980/console The header here is off ? https://github.com/apache/hbase/commit/939697b415201348ff4523321e316dfaf2206630#diff-8d72921c3cce35216808f1de02dc3b0eR2 (via [~mbertozzi]) > Java Tool For Region Moving > > > Key: HBASE-13014 > URL: https://issues.apache.org/jira/browse/HBASE-13014 > Project: HBase > Issue Type: Improvement >Reporter: Abhishek Singh Chouhan >Assignee: Abhishek Singh Chouhan > Fix For: 2.0.0 > > Attachments: HBASE-13014-master-v2.patch, HBASE-13014-master.patch, > HBASE-13014-v2.patch, HBASE-13014-v3.patch, HBASE-13014-v4.patch, > HBASE-13014-v5.patch, HBASE-13014-v6.patch, HBASE-13014.patch > > > As per discussion on HBASE-12989 we should move the functionality of > region_mover.rb into a Java tool and use region_mover.rb only only as a > wrapper around it. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-13014) Java Tool For Region Moving
[ https://issues.apache.org/jira/browse/HBASE-13014?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14981730#comment-14981730 ] Hudson commented on HBASE-13014: FAILURE: Integrated in HBase-TRUNK #6981 (See [https://builds.apache.org/job/HBase-TRUNK/6981/]) Revert "HBASE-13014 Java Tool For Region Moving (Abhishek Singh (stack: rev eb4e2ee9e2c0e52a02eecb1d7e58b124f55d38e6) * hbase-server/src/main/java/org/apache/hadoop/hbase/util/RegionMover.java * hbase-server/src/test/java/org/apache/hadoop/hbase/util/TestRegionMover.java > Java Tool For Region Moving > > > Key: HBASE-13014 > URL: https://issues.apache.org/jira/browse/HBASE-13014 > Project: HBase > Issue Type: Improvement >Reporter: Abhishek Singh Chouhan >Assignee: Abhishek Singh Chouhan > Fix For: 2.0.0 > > Attachments: HBASE-13014-master-v2.patch, HBASE-13014-master.patch, > HBASE-13014-v2.patch, HBASE-13014-v3.patch, HBASE-13014-v4.patch, > HBASE-13014-v5.patch, HBASE-13014-v6.patch, HBASE-13014.patch > > > As per discussion on HBASE-12989 we should move the functionality of > region_mover.rb into a Java tool and use region_mover.rb only only as a > wrapper around it. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-13014) Java Tool For Region Moving
[ https://issues.apache.org/jira/browse/HBASE-13014?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14976956#comment-14976956 ] Andrew Purtell commented on HBASE-13014: Let me try this again today. > Java Tool For Region Moving > > > Key: HBASE-13014 > URL: https://issues.apache.org/jira/browse/HBASE-13014 > Project: HBase > Issue Type: Improvement >Reporter: Abhishek Singh Chouhan >Assignee: Abhishek Singh Chouhan > Fix For: 2.0.0, 1.3.0, 0.98.16 > > Attachments: HBASE-13014-master-v2.patch, HBASE-13014-master.patch, > HBASE-13014-v2.patch, HBASE-13014-v3.patch, HBASE-13014-v4.patch, > HBASE-13014-v5.patch, HBASE-13014-v6.patch, HBASE-13014.patch > > > As per discussion on HBASE-12989 we should move the functionality of > region_mover.rb into a Java tool and use region_mover.rb only only as a > wrapper around it. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-13014) Java Tool For Region Moving
[ https://issues.apache.org/jira/browse/HBASE-13014?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14977698#comment-14977698 ] Hudson commented on HBASE-13014: SUCCESS: Integrated in HBase-TRUNK #6970 (See [https://builds.apache.org/job/HBase-TRUNK/6970/]) HBASE-13014 Java Tool For Region Moving (Abhishek Singh Chouhan) (apurtell: rev 939697b415201348ff4523321e316dfaf2206630) * hbase-server/src/test/java/org/apache/hadoop/hbase/util/TestRegionMover.java * hbase-server/src/main/java/org/apache/hadoop/hbase/util/RegionMover.java > Java Tool For Region Moving > > > Key: HBASE-13014 > URL: https://issues.apache.org/jira/browse/HBASE-13014 > Project: HBase > Issue Type: Improvement >Reporter: Abhishek Singh Chouhan >Assignee: Abhishek Singh Chouhan > Fix For: 2.0.0 > > Attachments: HBASE-13014-master-v2.patch, HBASE-13014-master.patch, > HBASE-13014-v2.patch, HBASE-13014-v3.patch, HBASE-13014-v4.patch, > HBASE-13014-v5.patch, HBASE-13014-v6.patch, HBASE-13014.patch > > > As per discussion on HBASE-12989 we should move the functionality of > region_mover.rb into a Java tool and use region_mover.rb only only as a > wrapper around it. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-13014) Java Tool For Region Moving
[ https://issues.apache.org/jira/browse/HBASE-13014?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14904353#comment-14904353 ] Abhishek Singh Chouhan commented on HBASE-13014: Attached a working patch for master. The tests were failing as we were trying to move regions to master also which was eventually unsuccessful.Fixed by removing master from list of RSs to move regions to. [~apurtell] > Java Tool For Region Moving > > > Key: HBASE-13014 > URL: https://issues.apache.org/jira/browse/HBASE-13014 > Project: HBase > Issue Type: Improvement >Reporter: Abhishek Singh Chouhan >Assignee: Abhishek Singh Chouhan > Fix For: 2.0.0, 1.3.0, 0.98.16 > > Attachments: HBASE-13014-master-v2.patch, HBASE-13014-master.patch, > HBASE-13014-v2.patch, HBASE-13014-v3.patch, HBASE-13014-v4.patch, > HBASE-13014-v5.patch, HBASE-13014-v6.patch, HBASE-13014.patch > > > As per discussion on HBASE-12989 we should move the functionality of > region_mover.rb into a Java tool and use region_mover.rb only only as a > wrapper around it. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-13014) Java Tool For Region Moving
[
https://issues.apache.org/jira/browse/HBASE-13014?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14904547#comment-14904547
]
Hadoop QA commented on HBASE-13014:
---
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12761870/HBASE-13014-master-v2.patch
against master branch at commit 2c83d8a263ee7c6751448bcc72868da86757f7f2.
ATTACHMENT ID: 12761870
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 2 new
or modified tests.
{color:green}+1 hadoop versions{color}. The patch compiles with all
supported hadoop versions (2.4.0 2.4.1 2.5.0 2.5.1 2.5.2 2.6.0 2.7.0 2.7.1)
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 protoc{color}. The applied patch does not increase the
total number of protoc compiler warnings.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 checkstyle{color}. The applied patch does not increase the
total number of checkstyle errors
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 2.0.3) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 lineLengths{color}. The patch does not introduce lines
longer than 100
{color:green}+1 site{color}. The mvn post-site goal succeeds with this patch.
{color:red}-1 core tests{color}. The patch failed these unit tests:
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/15691//testReport/
Release Findbugs (version 2.0.3)warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/15691//artifact/patchprocess/newFindbugsWarnings.html
Checkstyle Errors:
https://builds.apache.org/job/PreCommit-HBASE-Build/15691//artifact/patchprocess/checkstyle-aggregate.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/15691//console
This message is automatically generated.
> Java Tool For Region Moving
>
>
> Key: HBASE-13014
> URL: https://issues.apache.org/jira/browse/HBASE-13014
> Project: HBase
> Issue Type: Improvement
>Reporter: Abhishek Singh Chouhan
>Assignee: Abhishek Singh Chouhan
> Fix For: 2.0.0, 1.3.0, 0.98.16
>
> Attachments: HBASE-13014-master-v2.patch, HBASE-13014-master.patch,
> HBASE-13014-v2.patch, HBASE-13014-v3.patch, HBASE-13014-v4.patch,
> HBASE-13014-v5.patch, HBASE-13014-v6.patch, HBASE-13014.patch
>
>
> As per discussion on HBASE-12989 we should move the functionality of
> region_mover.rb into a Java tool and use region_mover.rb only only as a
> wrapper around it.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-13014) Java Tool For Region Moving
[ https://issues.apache.org/jira/browse/HBASE-13014?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14904983#comment-14904983 ] Andrew Purtell commented on HBASE-13014: Thanks [~abhishek.chouhan]. Will check out locally and commit if the test passes reliably. > Java Tool For Region Moving > > > Key: HBASE-13014 > URL: https://issues.apache.org/jira/browse/HBASE-13014 > Project: HBase > Issue Type: Improvement >Reporter: Abhishek Singh Chouhan >Assignee: Abhishek Singh Chouhan > Fix For: 2.0.0, 1.3.0, 0.98.16 > > Attachments: HBASE-13014-master-v2.patch, HBASE-13014-master.patch, > HBASE-13014-v2.patch, HBASE-13014-v3.patch, HBASE-13014-v4.patch, > HBASE-13014-v5.patch, HBASE-13014-v6.patch, HBASE-13014.patch > > > As per discussion on HBASE-12989 we should move the functionality of > region_mover.rb into a Java tool and use region_mover.rb only only as a > wrapper around it. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-13014) Java Tool For Region Moving
[
https://issues.apache.org/jira/browse/HBASE-13014?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14904993#comment-14904993
]
Andrew Purtell commented on HBASE-13014:
I get a failure running the v2 patch:
{noformat}
Tests run: 5, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 52.421 sec <<<
FAILURE! - in org.apache.hadoop.hbase.util.TestRegionMover
testLoadWithoutAck(org.apache.hadoop.hbase.util.TestRegionMover) Time elapsed:
6.626 sec <<< FAILURE!
java.lang.AssertionError: expected:<3> but was:<1>
at org.junit.Assert.fail(Assert.java:88)
at org.junit.Assert.failNotEquals(Assert.java:834)
at org.junit.Assert.assertEquals(Assert.java:645)
at org.junit.Assert.assertEquals(Assert.java:631)
at
org.apache.hadoop.hbase.util.TestRegionMover.testLoadWithoutAck(TestRegionMover.java:110)
Results :
Failed tests:
TestRegionMover.testLoadWithoutAck:110 expected:<3> but was:<1>
{noformat}
> Java Tool For Region Moving
>
>
> Key: HBASE-13014
> URL: https://issues.apache.org/jira/browse/HBASE-13014
> Project: HBase
> Issue Type: Improvement
>Reporter: Abhishek Singh Chouhan
>Assignee: Abhishek Singh Chouhan
> Fix For: 2.0.0, 1.3.0, 0.98.16
>
> Attachments: HBASE-13014-master-v2.patch, HBASE-13014-master.patch,
> HBASE-13014-v2.patch, HBASE-13014-v3.patch, HBASE-13014-v4.patch,
> HBASE-13014-v5.patch, HBASE-13014-v6.patch, HBASE-13014.patch
>
>
> As per discussion on HBASE-12989 we should move the functionality of
> region_mover.rb into a Java tool and use region_mover.rb only only as a
> wrapper around it.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-13014) Java Tool For Region Moving
[ https://issues.apache.org/jira/browse/HBASE-13014?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14903403#comment-14903403 ] Andrew Purtell commented on HBASE-13014: Unfortunately this patch is for 0.98, not trunk. In the interests of moving this forward I will make a pass at forward porting the result and post it here. > Java Tool For Region Moving > > > Key: HBASE-13014 > URL: https://issues.apache.org/jira/browse/HBASE-13014 > Project: HBase > Issue Type: Improvement >Reporter: Abhishek Singh Chouhan >Assignee: Abhishek Singh Chouhan > Fix For: 2.0.0, 1.3.0, 0.98.15 > > Attachments: HBASE-13014-v2.patch, HBASE-13014-v3.patch, > HBASE-13014-v4.patch, HBASE-13014-v5.patch, HBASE-13014-v6.patch, > HBASE-13014.patch > > > As per discussion on HBASE-12989 we should move the functionality of > region_mover.rb into a Java tool and use region_mover.rb only only as a > wrapper around it. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-13014) Java Tool For Region Moving
[ https://issues.apache.org/jira/browse/HBASE-13014?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14902853#comment-14902853 ] Andrew Purtell commented on HBASE-13014: Committing shortly unless objection. > Java Tool For Region Moving > > > Key: HBASE-13014 > URL: https://issues.apache.org/jira/browse/HBASE-13014 > Project: HBase > Issue Type: Improvement >Reporter: Abhishek Singh Chouhan >Assignee: Abhishek Singh Chouhan > Fix For: 2.0.0, 1.3.0, 0.98.15 > > Attachments: HBASE-13014-v2.patch, HBASE-13014-v3.patch, > HBASE-13014-v4.patch, HBASE-13014-v5.patch, HBASE-13014-v6.patch, > HBASE-13014.patch > > > As per discussion on HBASE-12989 we should move the functionality of > region_mover.rb into a Java tool and use region_mover.rb only only as a > wrapper around it. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-13014) Java Tool For Region Moving
[ https://issues.apache.org/jira/browse/HBASE-13014?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14699205#comment-14699205 ] Abhishek Singh Chouhan commented on HBASE-13014: Thanks for having a look :) I'll file another jira to track the changes that need to be done in the ruby file and will start working on that. Java Tool For Region Moving Key: HBASE-13014 URL: https://issues.apache.org/jira/browse/HBASE-13014 Project: HBase Issue Type: Improvement Reporter: Abhishek Singh Chouhan Assignee: Abhishek Singh Chouhan Fix For: 2.0.0, 1.3.0, 0.98.15 Attachments: HBASE-13014-v2.patch, HBASE-13014-v3.patch, HBASE-13014-v4.patch, HBASE-13014-v5.patch, HBASE-13014-v6.patch, HBASE-13014.patch As per discussion on HBASE-12989 we should move the functionality of region_mover.rb into a Java tool and use region_mover.rb only only as a wrapper around it. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-13014) Java Tool For Region Moving
[ https://issues.apache.org/jira/browse/HBASE-13014?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14697903#comment-14697903 ] Andrew Purtell commented on HBASE-13014: Haven't had time for another detailed review. Skimmed the latest patch. Looks like earlier feedback is all addressed. Will commit early next week unless objection. Java Tool For Region Moving Key: HBASE-13014 URL: https://issues.apache.org/jira/browse/HBASE-13014 Project: HBase Issue Type: Improvement Reporter: Abhishek Singh Chouhan Assignee: Abhishek Singh Chouhan Fix For: 2.0.0, 0.98.14, 1.3.0 Attachments: HBASE-13014-v2.patch, HBASE-13014-v3.patch, HBASE-13014-v4.patch, HBASE-13014-v5.patch, HBASE-13014-v6.patch, HBASE-13014.patch As per discussion on HBASE-12989 we should move the functionality of region_mover.rb into a Java tool and use region_mover.rb only only as a wrapper around it. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-13014) Java Tool For Region Moving
[ https://issues.apache.org/jira/browse/HBASE-13014?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14655070#comment-14655070 ] Abhishek Singh Chouhan commented on HBASE-13014: Ping [~lhofhansl] :) Java Tool For Region Moving Key: HBASE-13014 URL: https://issues.apache.org/jira/browse/HBASE-13014 Project: HBase Issue Type: Improvement Reporter: Abhishek Singh Chouhan Assignee: Abhishek Singh Chouhan Fix For: 2.0.0, 0.98.14, 1.3.0 Attachments: HBASE-13014-v2.patch, HBASE-13014-v3.patch, HBASE-13014-v4.patch, HBASE-13014-v5.patch, HBASE-13014-v6.patch, HBASE-13014.patch As per discussion on HBASE-12989 we should move the functionality of region_mover.rb into a Java tool and use region_mover.rb only only as a wrapper around it. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-13014) Java Tool For Region Moving
[ https://issues.apache.org/jira/browse/HBASE-13014?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14596204#comment-14596204 ] Sean Busbey commented on HBASE-13014: - is this good to go? [~lhofhansl], [~apurtell], [~haridsv]? Java Tool For Region Moving Key: HBASE-13014 URL: https://issues.apache.org/jira/browse/HBASE-13014 Project: HBase Issue Type: Improvement Reporter: Abhishek Singh Chouhan Assignee: Abhishek Singh Chouhan Fix For: 2.0.0, 0.98.14, 1.2.0 Attachments: HBASE-13014-v2.patch, HBASE-13014-v3.patch, HBASE-13014-v4.patch, HBASE-13014-v5.patch, HBASE-13014-v6.patch, HBASE-13014.patch As per discussion on HBASE-12989 we should move the functionality of region_mover.rb into a Java tool and use region_mover.rb only only as a wrapper around it. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-13014) Java Tool For Region Moving
[ https://issues.apache.org/jira/browse/HBASE-13014?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14569565#comment-14569565 ] Abhishek Singh Chouhan commented on HBASE-13014: FYI [~lhofhansl] Java Tool For Region Moving Key: HBASE-13014 URL: https://issues.apache.org/jira/browse/HBASE-13014 Project: HBase Issue Type: Improvement Reporter: Abhishek Singh Chouhan Assignee: Abhishek Singh Chouhan Fix For: 2.0.0, 0.98.14, 1.2.0 Attachments: HBASE-13014-v2.patch, HBASE-13014-v3.patch, HBASE-13014-v4.patch, HBASE-13014-v5.patch, HBASE-13014-v6.patch, HBASE-13014.patch As per discussion on HBASE-12989 we should move the functionality of region_mover.rb into a Java tool and use region_mover.rb only only as a wrapper around it. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-13014) Java Tool For Region Moving
[
https://issues.apache.org/jira/browse/HBASE-13014?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14564369#comment-14564369
]
Hadoop QA commented on HBASE-13014:
---
{color:green}+1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12735900/HBASE-13014-v6.patch
against master branch at commit 325614220f1c208b0846001f903888660096cdb1.
ATTACHMENT ID: 12735900
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 2 new
or modified tests.
{color:green}+1 hadoop versions{color}. The patch compiles with all
supported hadoop versions (2.4.1 2.5.2 2.6.0)
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 protoc{color}. The applied patch does not increase the
total number of protoc compiler warnings.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 checkstyle{color}. The applied patch does not increase the
total number of checkstyle errors
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 2.0.3) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 lineLengths{color}. The patch does not introduce lines
longer than 100
{color:green}+1 site{color}. The mvn site goal succeeds with this patch.
{color:green}+1 core tests{color}. The patch passed unit tests in .
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/14230//testReport/
Release Findbugs (version 2.0.3)warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/14230//artifact/patchprocess/newFindbugsWarnings.html
Checkstyle Errors:
https://builds.apache.org/job/PreCommit-HBASE-Build/14230//artifact/patchprocess/checkstyle-aggregate.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/14230//console
This message is automatically generated.
Java Tool For Region Moving
Key: HBASE-13014
URL: https://issues.apache.org/jira/browse/HBASE-13014
Project: HBase
Issue Type: Improvement
Reporter: Abhishek Singh Chouhan
Assignee: Abhishek Singh Chouhan
Fix For: 2.0.0, 0.98.14, 1.2.0
Attachments: HBASE-13014-v2.patch, HBASE-13014-v3.patch,
HBASE-13014-v4.patch, HBASE-13014-v5.patch, HBASE-13014-v6.patch,
HBASE-13014.patch
As per discussion on HBASE-12989 we should move the functionality of
region_mover.rb into a Java tool and use region_mover.rb only only as a
wrapper around it.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-13014) Java Tool For Region Moving
[ https://issues.apache.org/jira/browse/HBASE-13014?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14529971#comment-14529971 ] Andrew Purtell commented on HBASE-13014: We do not have have unit tests that cover the bin scripts like region_mover.rb, unfortunately, so a hard to spot typo made it in to a release before it was fixed later. It's great we can commit this tool, with new shiny unit test coverage, then once we are sure it's reliable, replace the guts of region_mover.rb with an invocation of this tool. Java Tool For Region Moving Key: HBASE-13014 URL: https://issues.apache.org/jira/browse/HBASE-13014 Project: HBase Issue Type: Improvement Reporter: Abhishek Singh Chouhan Assignee: Abhishek Singh Chouhan Fix For: 2.0.0, 0.98.13, 1.2.0 Attachments: HBASE-13014-v2.patch, HBASE-13014-v3.patch, HBASE-13014-v4.patch, HBASE-13014-v5.patch, HBASE-13014.patch As per discussion on HBASE-12989 we should move the functionality of region_mover.rb into a Java tool and use region_mover.rb only only as a wrapper around it. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-13014) Java Tool For Region Moving
[ https://issues.apache.org/jira/browse/HBASE-13014?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14526897#comment-14526897 ] Andrew Purtell commented on HBASE-13014: Can you post the latest patch to your earlier review - https://reviews.apache.org/r/31626/. Please don't open new RB reviews just for a new patch. Hari, Ted, and I commented on your earlier patch and I'd like to have this history to determine if the issues have been addressed. Java Tool For Region Moving Key: HBASE-13014 URL: https://issues.apache.org/jira/browse/HBASE-13014 Project: HBase Issue Type: Improvement Reporter: Abhishek Singh Chouhan Assignee: Abhishek Singh Chouhan Fix For: 2.0.0, 0.98.13, 1.2.0 Attachments: HBASE-13014-v2.patch, HBASE-13014-v3.patch, HBASE-13014-v4.patch, HBASE-13014-v5.patch, HBASE-13014.patch As per discussion on HBASE-12989 we should move the functionality of region_mover.rb into a Java tool and use region_mover.rb only only as a wrapper around it. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-13014) Java Tool For Region Moving
[ https://issues.apache.org/jira/browse/HBASE-13014?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14526941#comment-14526941 ] Andrew Purtell commented on HBASE-13014: [~lhofhansl] and I had a look at the latest patch and have the following suggestions: - Introduce an option which is the total time the tool should run. Don't use potentially infinite loops or APIs that do not time out. Make sure the tool can exit at the desired total execution time if that option is presented. This is for use cases where we only want the tool to be best effort. - Wait for the thread pools to finish, with timeout, using awaitTermination, instead of blocking (potentially for a very long time) on Future#get of each submitted task. - There are APIs available in HTable and HConnection for getting region locations that do not require instantiation of a ZK tracker and the other low level stuff done there. Prefer you use the former. Java Tool For Region Moving Key: HBASE-13014 URL: https://issues.apache.org/jira/browse/HBASE-13014 Project: HBase Issue Type: Improvement Reporter: Abhishek Singh Chouhan Assignee: Abhishek Singh Chouhan Fix For: 2.0.0, 0.98.13, 1.2.0 Attachments: HBASE-13014-v2.patch, HBASE-13014-v3.patch, HBASE-13014-v4.patch, HBASE-13014-v5.patch, HBASE-13014.patch As per discussion on HBASE-12989 we should move the functionality of region_mover.rb into a Java tool and use region_mover.rb only only as a wrapper around it. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-13014) Java Tool For Region Moving
[ https://issues.apache.org/jira/browse/HBASE-13014?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14526986#comment-14526986 ] Abhishek Singh Chouhan commented on HBASE-13014: Thanks [~apurtell] and [~lhofhansl]for the review.I had uploaded the latest patch to both the reviews and had marked on the issues there too. Again sorry for the confusion regarding this.Will be using only the review with all the comments for any future work on this. Will work on the suggestions and put up a new patch soon :) Java Tool For Region Moving Key: HBASE-13014 URL: https://issues.apache.org/jira/browse/HBASE-13014 Project: HBase Issue Type: Improvement Reporter: Abhishek Singh Chouhan Assignee: Abhishek Singh Chouhan Fix For: 2.0.0, 0.98.13, 1.2.0 Attachments: HBASE-13014-v2.patch, HBASE-13014-v3.patch, HBASE-13014-v4.patch, HBASE-13014-v5.patch, HBASE-13014.patch As per discussion on HBASE-12989 we should move the functionality of region_mover.rb into a Java tool and use region_mover.rb only only as a wrapper around it. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-13014) Java Tool For Region Moving
[ https://issues.apache.org/jira/browse/HBASE-13014?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14527057#comment-14527057 ] Lars Hofhansl commented on HBASE-13014: --- Thanks [~abhishek.chouhan]. Let's get this into 0.98.13. :) Java Tool For Region Moving Key: HBASE-13014 URL: https://issues.apache.org/jira/browse/HBASE-13014 Project: HBase Issue Type: Improvement Reporter: Abhishek Singh Chouhan Assignee: Abhishek Singh Chouhan Fix For: 2.0.0, 0.98.13, 1.2.0 Attachments: HBASE-13014-v2.patch, HBASE-13014-v3.patch, HBASE-13014-v4.patch, HBASE-13014-v5.patch, HBASE-13014.patch As per discussion on HBASE-12989 we should move the functionality of region_mover.rb into a Java tool and use region_mover.rb only only as a wrapper around it. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-13014) Java Tool For Region Moving
[ https://issues.apache.org/jira/browse/HBASE-13014?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14519205#comment-14519205 ] Abhishek Singh Chouhan commented on HBASE-13014: [~tedyu] [~lhofhansl] [~apurtell] Can you guys have a look at this and see if this needs any further work? https://reviews.apache.org/r/31675/diff/2/ Thanks :) Java Tool For Region Moving Key: HBASE-13014 URL: https://issues.apache.org/jira/browse/HBASE-13014 Project: HBase Issue Type: Improvement Reporter: Abhishek Singh Chouhan Assignee: Abhishek Singh Chouhan Fix For: 2.0.0, 0.98.13, 1.2.0 Attachments: HBASE-13014-v2.patch, HBASE-13014-v3.patch, HBASE-13014-v4.patch, HBASE-13014-v5.patch, HBASE-13014.patch As per discussion on HBASE-12989 we should move the functionality of region_mover.rb into a Java tool and use region_mover.rb only only as a wrapper around it. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-13014) Java Tool For Region Moving
[
https://issues.apache.org/jira/browse/HBASE-13014?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14482911#comment-14482911
]
Hadoop QA commented on HBASE-13014:
---
{color:green}+1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12723560/HBASE-13014-v5.patch
against master branch at commit 57f9c821287a3780384bcb37d764f13300c93a8d.
ATTACHMENT ID: 12723560
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 2 new
or modified tests.
{color:green}+1 hadoop versions{color}. The patch compiles with all
supported hadoop versions (2.4.1 2.5.2 2.6.0)
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 protoc{color}. The applied patch does not increase the
total number of protoc compiler warnings.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 checkstyle{color}. The applied patch does not increase the
total number of checkstyle errors
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 2.0.3) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 lineLengths{color}. The patch does not introduce lines
longer than 100
{color:green}+1 site{color}. The mvn site goal succeeds with this patch.
{color:green}+1 core tests{color}. The patch passed unit tests in .
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/13594//testReport/
Release Findbugs (version 2.0.3)warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/13594//artifact/patchprocess/newFindbugsWarnings.html
Checkstyle Errors:
https://builds.apache.org/job/PreCommit-HBASE-Build/13594//artifact/patchprocess/checkstyle-aggregate.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/13594//console
This message is automatically generated.
Java Tool For Region Moving
Key: HBASE-13014
URL: https://issues.apache.org/jira/browse/HBASE-13014
Project: HBase
Issue Type: Improvement
Reporter: Abhishek Singh Chouhan
Assignee: Abhishek Singh Chouhan
Fix For: 2.0.0, 1.1.0, 0.98.13, 1.0.2
Attachments: HBASE-13014-v2.patch, HBASE-13014-v3.patch,
HBASE-13014-v4.patch, HBASE-13014-v5.patch, HBASE-13014.patch
As per discussion on HBASE-12989 we should move the functionality of
region_mover.rb into a Java tool and use region_mover.rb only only as a
wrapper around it.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-13014) Java Tool For Region Moving
[ https://issues.apache.org/jira/browse/HBASE-13014?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14481174#comment-14481174 ] Abhishek Singh Chouhan commented on HBASE-13014: Have incorporated yours and [~tedyu]'s comments and uploaded the latest diff on the reviewboard too.Do have a look.Sorry for the confusion regarding 2 reviews.You can use anyone of them,i've updated the diff on both. Java Tool For Region Moving Key: HBASE-13014 URL: https://issues.apache.org/jira/browse/HBASE-13014 Project: HBase Issue Type: Improvement Reporter: Abhishek Singh Chouhan Assignee: Abhishek Singh Chouhan Fix For: 2.0.0, 1.1.0, 0.98.13, 1.0.2 Attachments: HBASE-13014-v2.patch, HBASE-13014-v3.patch, HBASE-13014-v4.patch, HBASE-13014-v5.patch, HBASE-13014.patch As per discussion on HBASE-12989 we should move the functionality of region_mover.rb into a Java tool and use region_mover.rb only only as a wrapper around it. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-13014) Java Tool For Region Moving
[ https://issues.apache.org/jira/browse/HBASE-13014?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14481274#comment-14481274 ] Hari Krishna Dara commented on HBASE-13014: --- [~apurtell] I can't tell if my comments are incorporated or not, the review link still shows me a number of them not addressed. I don't even see a response from [~abhishek.chouhan] so I am confused and no longer sure if I am reviewing on some wrong link :( Java Tool For Region Moving Key: HBASE-13014 URL: https://issues.apache.org/jira/browse/HBASE-13014 Project: HBase Issue Type: Improvement Reporter: Abhishek Singh Chouhan Assignee: Abhishek Singh Chouhan Fix For: 2.0.0, 1.1.0, 0.98.13, 1.0.2 Attachments: HBASE-13014-v2.patch, HBASE-13014-v3.patch, HBASE-13014-v4.patch, HBASE-13014-v5.patch, HBASE-13014.patch As per discussion on HBASE-12989 we should move the functionality of region_mover.rb into a Java tool and use region_mover.rb only only as a wrapper around it. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-13014) Java Tool For Region Moving
[
https://issues.apache.org/jira/browse/HBASE-13014?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14481271#comment-14481271
]
Hadoop QA commented on HBASE-13014:
---
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12723338/HBASE-13014-v5.patch
against master branch at commit 057499474c346b28ad5ac3ab7da420814eba547d.
ATTACHMENT ID: 12723338
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 2 new
or modified tests.
{color:green}+1 hadoop versions{color}. The patch compiles with all
supported hadoop versions (2.4.1 2.5.2 2.6.0)
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 protoc{color}. The applied patch does not increase the
total number of protoc compiler warnings.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 checkstyle{color}. The applied patch does not increase the
total number of checkstyle errors
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 2.0.3) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:red}-1 lineLengths{color}. The patch introduces the following lines
longer than 100:
+int maxWaitInSeconds =
admin.getConfiguration().getInt(SERVERSTART_WAIT_MAX_KEY,
DEFAULT_SERVERSTART_WAIT_MAX);
+ int maxWaitInSeconds =
admin.getConfiguration().getInt(MOVE_WAIT_MAX_KEY, DEFAULT_MOVE_WAIT_MAX);
++ String.format(%.3f, (float)
(EnvironmentEdgeManager.currentTimeMillis() - startTime) / 1000));
+ int maxWaitInSeconds =
admin.getConfiguration().getInt(MOVE_WAIT_MAX_KEY, DEFAULT_MOVE_WAIT_MAX);
{color:green}+1 site{color}. The mvn site goal succeeds with this patch.
{color:green}+1 core tests{color}. The patch passed unit tests in .
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/13579//testReport/
Release Findbugs (version 2.0.3)warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/13579//artifact/patchprocess/newFindbugsWarnings.html
Checkstyle Errors:
https://builds.apache.org/job/PreCommit-HBASE-Build/13579//artifact/patchprocess/checkstyle-aggregate.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/13579//console
This message is automatically generated.
Java Tool For Region Moving
Key: HBASE-13014
URL: https://issues.apache.org/jira/browse/HBASE-13014
Project: HBase
Issue Type: Improvement
Reporter: Abhishek Singh Chouhan
Assignee: Abhishek Singh Chouhan
Fix For: 2.0.0, 1.1.0, 0.98.13, 1.0.2
Attachments: HBASE-13014-v2.patch, HBASE-13014-v3.patch,
HBASE-13014-v4.patch, HBASE-13014-v5.patch, HBASE-13014.patch
As per discussion on HBASE-12989 we should move the functionality of
region_mover.rb into a Java tool and use region_mover.rb only only as a
wrapper around it.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-13014) Java Tool For Region Moving
[ https://issues.apache.org/jira/browse/HBASE-13014?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14481413#comment-14481413 ] Abhishek Singh Chouhan commented on HBASE-13014: You can have a look at the latest diff in the review.Have incorporated necessary changes. Java Tool For Region Moving Key: HBASE-13014 URL: https://issues.apache.org/jira/browse/HBASE-13014 Project: HBase Issue Type: Improvement Reporter: Abhishek Singh Chouhan Assignee: Abhishek Singh Chouhan Fix For: 2.0.0, 1.1.0, 0.98.13, 1.0.2 Attachments: HBASE-13014-v2.patch, HBASE-13014-v3.patch, HBASE-13014-v4.patch, HBASE-13014-v5.patch, HBASE-13014.patch As per discussion on HBASE-12989 we should move the functionality of region_mover.rb into a Java tool and use region_mover.rb only only as a wrapper around it. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-13014) Java Tool For Region Moving
[ https://issues.apache.org/jira/browse/HBASE-13014?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14392977#comment-14392977 ] Andrew Purtell commented on HBASE-13014: I've got you covered [~lhofhansl], you can wait for the next patch revision. :-) Java Tool For Region Moving Key: HBASE-13014 URL: https://issues.apache.org/jira/browse/HBASE-13014 Project: HBase Issue Type: Improvement Reporter: Abhishek Singh Chouhan Assignee: Abhishek Singh Chouhan Fix For: 2.0.0, 1.1.0, 0.98.13, 1.0.2 Attachments: HBASE-13014-v2.patch, HBASE-13014-v3.patch, HBASE-13014-v4.patch, HBASE-13014.patch As per discussion on HBASE-12989 we should move the functionality of region_mover.rb into a Java tool and use region_mover.rb only only as a wrapper around it. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-13014) Java Tool For Region Moving
[ https://issues.apache.org/jira/browse/HBASE-13014?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14392976#comment-14392976 ] Abhishek Singh Chouhan commented on HBASE-13014: I created a new review request.Forgot to update it here https://reviews.apache.org/r/31675/ Java Tool For Region Moving Key: HBASE-13014 URL: https://issues.apache.org/jira/browse/HBASE-13014 Project: HBase Issue Type: Improvement Reporter: Abhishek Singh Chouhan Assignee: Abhishek Singh Chouhan Fix For: 2.0.0, 1.1.0, 0.98.13, 1.0.2 Attachments: HBASE-13014-v2.patch, HBASE-13014-v3.patch, HBASE-13014-v4.patch, HBASE-13014.patch As per discussion on HBASE-12989 we should move the functionality of region_mover.rb into a Java tool and use region_mover.rb only only as a wrapper around it. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-13014) Java Tool For Region Moving
[ https://issues.apache.org/jira/browse/HBASE-13014?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14392985#comment-14392985 ] Andrew Purtell commented on HBASE-13014: Please see if any of my comments on the older review still apply. For future reference, reviewboard lets you submit updated patches on the same review. Click the 'Update diff' item from the 'Update' drop down menu (right hand side near the top of the page of your review). Java Tool For Region Moving Key: HBASE-13014 URL: https://issues.apache.org/jira/browse/HBASE-13014 Project: HBase Issue Type: Improvement Reporter: Abhishek Singh Chouhan Assignee: Abhishek Singh Chouhan Fix For: 2.0.0, 1.1.0, 0.98.13, 1.0.2 Attachments: HBASE-13014-v2.patch, HBASE-13014-v3.patch, HBASE-13014-v4.patch, HBASE-13014.patch As per discussion on HBASE-12989 we should move the functionality of region_mover.rb into a Java tool and use region_mover.rb only only as a wrapper around it. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-13014) Java Tool For Region Moving
[ https://issues.apache.org/jira/browse/HBASE-13014?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14392973#comment-14392973 ] Lars Hofhansl commented on HBASE-13014: --- I promised offline to look at this. Sorry I didn't, yet. [~abhishek.chouhan] Java Tool For Region Moving Key: HBASE-13014 URL: https://issues.apache.org/jira/browse/HBASE-13014 Project: HBase Issue Type: Improvement Reporter: Abhishek Singh Chouhan Assignee: Abhishek Singh Chouhan Fix For: 2.0.0, 1.1.0, 0.98.13, 1.0.2 Attachments: HBASE-13014-v2.patch, HBASE-13014-v3.patch, HBASE-13014-v4.patch, HBASE-13014.patch As per discussion on HBASE-12989 we should move the functionality of region_mover.rb into a Java tool and use region_mover.rb only only as a wrapper around it. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-13014) Java Tool For Region Moving
[ https://issues.apache.org/jira/browse/HBASE-13014?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14392993#comment-14392993 ] Hari Krishna Dara commented on HBASE-13014: --- Andrew, it seems like you missed to see the comments I already left, since some of the comments you added are for exactly the same reason :) Java Tool For Region Moving Key: HBASE-13014 URL: https://issues.apache.org/jira/browse/HBASE-13014 Project: HBase Issue Type: Improvement Reporter: Abhishek Singh Chouhan Assignee: Abhishek Singh Chouhan Fix For: 2.0.0, 1.1.0, 0.98.13, 1.0.2 Attachments: HBASE-13014-v2.patch, HBASE-13014-v3.patch, HBASE-13014-v4.patch, HBASE-13014.patch As per discussion on HBASE-12989 we should move the functionality of region_mover.rb into a Java tool and use region_mover.rb only only as a wrapper around it. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-13014) Java Tool For Region Moving
[
https://issues.apache.org/jira/browse/HBASE-13014?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14345058#comment-14345058
]
Hadoop QA commented on HBASE-13014:
---
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12702151/HBASE-13014-v4.patch
against master branch at commit daed00fc98167870463e77b620e9adb6ce9b204d.
ATTACHMENT ID: 12702151
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 2 new
or modified tests.
{color:green}+1 hadoop versions{color}. The patch compiles with all
supported hadoop versions (2.4.1 2.5.2 2.6.0)
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 checkstyle{color}. The applied patch does not increase the
total number of checkstyle errors
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 2.0.3) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 lineLengths{color}. The patch does not introduce lines
longer than 100
{color:green}+1 site{color}. The mvn site goal succeeds with this patch.
{color:red}-1 core tests{color}. The patch failed these unit tests:
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/13063//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/13063//artifact/patchprocess/newPatchFindbugsWarningshbase-rest.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/13063//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/13063//artifact/patchprocess/newPatchFindbugsWarningshbase-annotations.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/13063//artifact/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/13063//artifact/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/13063//artifact/patchprocess/newPatchFindbugsWarningshbase-thrift.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/13063//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/13063//artifact/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/13063//artifact/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/13063//artifact/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/13063//artifact/patchprocess/newPatchFindbugsWarningshbase-client.html
Checkstyle Errors:
https://builds.apache.org/job/PreCommit-HBASE-Build/13063//artifact/patchprocess/checkstyle-aggregate.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/13063//console
This message is automatically generated.
Java Tool For Region Moving
Key: HBASE-13014
URL: https://issues.apache.org/jira/browse/HBASE-13014
Project: HBase
Issue Type: Improvement
Reporter: Abhishek Singh Chouhan
Assignee: Abhishek Singh Chouhan
Attachments: HBASE-13014-v2.patch, HBASE-13014-v3.patch,
HBASE-13014-v4.patch, HBASE-13014.patch
As per discussion on HBASE-12989 we should move the functionality of
region_mover.rb into a Java tool and use region_mover.rb only only as a
wrapper around it.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-13014) Java Tool For Region Moving
[ https://issues.apache.org/jira/browse/HBASE-13014?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14343216#comment-14343216 ] Ted Yu commented on HBASE-13014: Please create new review request on https://reviews.apache.org Java Tool For Region Moving Key: HBASE-13014 URL: https://issues.apache.org/jira/browse/HBASE-13014 Project: HBase Issue Type: Improvement Reporter: Abhishek Singh Chouhan Assignee: Abhishek Singh Chouhan Attachments: HBASE-13014-v2.patch, HBASE-13014-v3.patch, HBASE-13014.patch As per discussion on HBASE-12989 we should move the functionality of region_mover.rb into a Java tool and use region_mover.rb only only as a wrapper around it. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-13014) Java Tool For Region Moving
[
https://issues.apache.org/jira/browse/HBASE-13014?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14343042#comment-14343042
]
Abhishek Singh Chouhan commented on HBASE-13014:
Thanks for the review.
I've incorporated most of the comments.
private String stripServer(ArrayListString regionServers, String hostname,
int port)
throws Exception {
String server = hostname+ServerName.SERVERNAME_SEPARATOR+port;
if (! regionServers.remove(server)) {
throw new Exception(Server: + server + is not Online);
}
return regionServers;
}
won't work as each regionServer in ArrayListString regionServers has
hostname,port and startcode hence comparing only the first two (host and
port).Have closed all file handlers in the finally blocks and otherwise the
tool will exit with proper exceptions in case any (admin and others)close
operation fails.
Java Tool For Region Moving
Key: HBASE-13014
URL: https://issues.apache.org/jira/browse/HBASE-13014
Project: HBase
Issue Type: Improvement
Reporter: Abhishek Singh Chouhan
Assignee: Abhishek Singh Chouhan
Attachments: HBASE-13014-v2.patch, HBASE-13014-v3.patch,
HBASE-13014.patch
As per discussion on HBASE-12989 we should move the functionality of
region_mover.rb into a Java tool and use region_mover.rb only only as a
wrapper around it.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-13014) Java Tool For Region Moving
[
https://issues.apache.org/jira/browse/HBASE-13014?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14343138#comment-14343138
]
Hadoop QA commented on HBASE-13014:
---
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12701863/HBASE-13014-v3.patch
against master branch at commit 4fb6f91cbad7d9b3c18f897ee3a4f70dc7c21595.
ATTACHMENT ID: 12701863
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 2 new
or modified tests.
{color:green}+1 hadoop versions{color}. The patch compiles with all
supported hadoop versions (2.4.1 2.5.2 2.6.0)
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 checkstyle{color}. The applied patch does not increase the
total number of checkstyle errors
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 2.0.3) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 lineLengths{color}. The patch does not introduce lines
longer than 100
{color:green}+1 site{color}. The mvn site goal succeeds with this patch.
{color:red}-1 core tests{color}. The patch failed these unit tests:
{color:red}-1 core zombie tests{color}. There are 1 zombie test(s):
at
org.apache.hadoop.hdfs.tools.TestDFSHAAdmin.testFailoverWithFencerConfigured(TestDFSHAAdmin.java:267)
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/13035//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/13035//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/13035//artifact/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/13035//artifact/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/13035//artifact/patchprocess/newPatchFindbugsWarningshbase-rest.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/13035//artifact/patchprocess/newPatchFindbugsWarningshbase-thrift.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/13035//artifact/patchprocess/newPatchFindbugsWarningshbase-annotations.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/13035//artifact/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/13035//artifact/patchprocess/newPatchFindbugsWarningshbase-client.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/13035//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/13035//artifact/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/13035//artifact/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Checkstyle Errors:
https://builds.apache.org/job/PreCommit-HBASE-Build/13035//artifact/patchprocess/checkstyle-aggregate.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/13035//console
This message is automatically generated.
Java Tool For Region Moving
Key: HBASE-13014
URL: https://issues.apache.org/jira/browse/HBASE-13014
Project: HBase
Issue Type: Improvement
Reporter: Abhishek Singh Chouhan
Assignee: Abhishek Singh Chouhan
Attachments: HBASE-13014-v2.patch, HBASE-13014-v3.patch,
HBASE-13014.patch
As per discussion on HBASE-12989 we should move the functionality of
region_mover.rb into a Java tool and use region_mover.rb only only as a
wrapper around it.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-13014) Java Tool For Region Moving
[ https://issues.apache.org/jira/browse/HBASE-13014?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14343034#comment-14343034 ] Abhishek Singh Chouhan commented on HBASE-13014: Thanks for reviewing.I've incorporated the comments and attached v3.Didn't know about the reviewboard,will keep in mind. Java Tool For Region Moving Key: HBASE-13014 URL: https://issues.apache.org/jira/browse/HBASE-13014 Project: HBase Issue Type: Improvement Reporter: Abhishek Singh Chouhan Assignee: Abhishek Singh Chouhan Attachments: HBASE-13014-v2.patch, HBASE-13014-v3.patch, HBASE-13014.patch As per discussion on HBASE-12989 we should move the functionality of region_mover.rb into a Java tool and use region_mover.rb only only as a wrapper around it. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-13014) Java Tool For Region Moving
[ https://issues.apache.org/jira/browse/HBASE-13014?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14343274#comment-14343274 ] Abhishek Singh Chouhan commented on HBASE-13014: Created https://reviews.apache.org/r/31626/ Java Tool For Region Moving Key: HBASE-13014 URL: https://issues.apache.org/jira/browse/HBASE-13014 Project: HBase Issue Type: Improvement Reporter: Abhishek Singh Chouhan Assignee: Abhishek Singh Chouhan Attachments: HBASE-13014-v2.patch, HBASE-13014-v3.patch, HBASE-13014.patch As per discussion on HBASE-12989 we should move the functionality of region_mover.rb into a Java tool and use region_mover.rb only only as a wrapper around it. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-13014) Java Tool For Region Moving
[ https://issues.apache.org/jira/browse/HBASE-13014?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14342767#comment-14342767 ] Lars Hofhansl commented on HBASE-13014: --- I'll take a look tomorrow. Java Tool For Region Moving Key: HBASE-13014 URL: https://issues.apache.org/jira/browse/HBASE-13014 Project: HBase Issue Type: Improvement Reporter: Abhishek Singh Chouhan Assignee: Abhishek Singh Chouhan Attachments: HBASE-13014-v2.patch, HBASE-13014.patch As per discussion on HBASE-12989 we should move the functionality of region_mover.rb into a Java tool and use region_mover.rb only only as a wrapper around it. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-13014) Java Tool For Region Moving
[
https://issues.apache.org/jira/browse/HBASE-13014?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14342677#comment-14342677
]
Hari Krishna Dara commented on HBASE-13014:
---
+1 for using a proper review tool, it is too painful to have to copy paste the
code snippets here.
A quick look at the 2nd patch shows more {{close()}} calls outside finally
blocks. I see {{stripServer()}} is still the same, I recommend simplifying it
for the sake of better understanding and maintainability. There are others that
haven't changed like {{new String()}}. It is getting difficult to track which
review comments have been incorporated and which haven't been.
Java Tool For Region Moving
Key: HBASE-13014
URL: https://issues.apache.org/jira/browse/HBASE-13014
Project: HBase
Issue Type: Improvement
Reporter: Abhishek Singh Chouhan
Assignee: Abhishek Singh Chouhan
Attachments: HBASE-13014-v2.patch, HBASE-13014.patch
As per discussion on HBASE-12989 we should move the functionality of
region_mover.rb into a Java tool and use region_mover.rb only only as a
wrapper around it.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-13014) Java Tool For Region Moving
[
https://issues.apache.org/jira/browse/HBASE-13014?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14341561#comment-14341561
]
Ted Yu commented on HBASE-13014:
{code}
56 public class RegionMover extends AbstractHBaseTool {
{code}
Please add annotation for audience.
{code}
571* @return
572* @throws Exception
573*/
574 private String stripServer(ArrayListString regionServers, String
hostname, int port)
{code}
{code}
596* @return
597* @throws IOException
598*/
599 private ArrayListString getServers(HBaseAdmin admin) throws
IOException {
{code}
Please fill out javadoc what return value means for above methods (there're
other methods where @return javadoc is incomplete).
{code}
if (splitServer[0].equals(hostname)
splitServer[1].equals(Integer.toString(port))) {
{code}
Integer.toString(port) can be assigned to a variable outside the while loop.
{code}
617* Trys to scan a row from passed region
{code}
Typo: Trys
{code}
647* Returns true if passed region is still on serverName when we look
at .META.
{code}
.META. - hbase:meta
{code}
656 String serverForRegion = getServerNameForRegion(admin, region);
657 if (serverForRegion.equals(serverName)) {
{code}
If getServerNameForRegion() returns null, line 657 would produce NPE.
{code}
658 return true;
659 } else return false;
{code}
'else' keyword can be omitted. Move 'return false;' to next line.
Putting patch on reviewboard would make reviewing easier.
Java Tool For Region Moving
Key: HBASE-13014
URL: https://issues.apache.org/jira/browse/HBASE-13014
Project: HBase
Issue Type: Improvement
Reporter: Abhishek Singh Chouhan
Assignee: Abhishek Singh Chouhan
Attachments: HBASE-13014-v2.patch, HBASE-13014.patch
As per discussion on HBASE-12989 we should move the functionality of
region_mover.rb into a Java tool and use region_mover.rb only only as a
wrapper around it.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-13014) Java Tool For Region Moving
[
https://issues.apache.org/jira/browse/HBASE-13014?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14341642#comment-14341642
]
Hadoop QA commented on HBASE-13014:
---
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12701114/HBASE-13014-v2.patch
against master branch at commit fdb48a7bbeecf891a0fc74171961901fbfdb5664.
ATTACHMENT ID: 12701114
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 2 new
or modified tests.
{color:green}+1 hadoop versions{color}. The patch compiles with all
supported hadoop versions (2.4.1 2.5.2 2.6.0)
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 checkstyle{color}. The applied patch does not increase the
total number of checkstyle errors
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 2.0.3) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:red}-1 lineLengths{color}. The patch introduces the following lines
longer than 100:
+ File with hostname:port per line to exclude as unload targets;
default excludes only target host; useful for rack decommisioning.);
+ File to save regions list into unloading, or read from loading; default
/tmp/usernamehostname:port);
+ * We test for the number of regions on Excluded server and also test that
regions are unloaded successfully
+RegionMoverBuilder rmBuilder = new
RegionMoverBuilder(rs).ack(true).excludeFile(/tmp/exclude_file);
+LOG.info(Before: + regionsExcludeServer + After: +
cluster.getRegionServer(1).getNumberOfOnlineRegions());
{color:green}+1 site{color}. The mvn site goal succeeds with this patch.
{color:red}-1 core tests{color}. The patch failed these unit tests:
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/13016//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/13016//artifact/patchprocess/newPatchFindbugsWarningshbase-rest.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/13016//artifact/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/13016//artifact/patchprocess/newPatchFindbugsWarningshbase-client.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/13016//artifact/patchprocess/newPatchFindbugsWarningshbase-annotations.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/13016//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/13016//artifact/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/13016//artifact/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/13016//artifact/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/13016//artifact/patchprocess/newPatchFindbugsWarningshbase-thrift.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/13016//artifact/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/13016//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Checkstyle Errors:
https://builds.apache.org/job/PreCommit-HBASE-Build/13016//artifact/patchprocess/checkstyle-aggregate.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/13016//console
This message is automatically generated.
Java Tool For Region Moving
Key: HBASE-13014
URL: https://issues.apache.org/jira/browse/HBASE-13014
Project: HBase
Issue Type: Improvement
Reporter: Abhishek Singh Chouhan
Assignee: Abhishek Singh Chouhan
Attachments: HBASE-13014-v2.patch, HBASE-13014.patch
As per discussion on HBASE-12989 we should move the functionality of
region_mover.rb into a Java tool and use region_mover.rb only only as a
wrapper around it.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-13014) Java Tool For Region Moving
[
https://issues.apache.org/jira/browse/HBASE-13014?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14338342#comment-14338342
]
Hari Krishna Dara commented on HBASE-13014:
---
Some comments on {{readExcludes()}} method:
* The {{close()}} calls should be in a finally block.
* The below line doesn't need an initializer:
{code}
+ String line = new String();
{code}
* Replace the below block:
{code}
+ FileInputStream fis = new FileInputStream(f);
+ BufferedReader br = new BufferedReader(new InputStreamReader(fis));
{code}
with the below and just call {{br.close()}} (it will internally {[close()}} the
underlying readers and streams).
{code}
+ BufferedReader br = new BufferedReader(new FileReader(f));
{code}
* Support comment lines (skip lines starting with #).
* You should use {{equals()}} in the below code:
{code}
+if (line != ) {
{code}
like this:
{code}
+if (line.equals()) {
{code}
Better yet, use the {{StringUtils.isEmpty()}} from commons.
You can simplify the whole logic of {{stripServers()}}, if you just
preconstruct the {{host:port}} combination, something like this:
{code}
private String stripServer(ArrayListString regionServers, String hostname,
int port)
throws Exception {
String server = hostname+ServerName.SERVERNAME_SEPARATOR+port;
if (! regionServers.remove(server)) {
throw new Exception(Server: + server + is not Online);
}
return regionServers;
}
{code}
Couple of {{close()}} calls in {{isSuccessfulScan()}} method that are not in
{{finally}} block.
Some comments on {{getServerNameForRegion()}}
* A few {{close()}} calls not in {{finally}} block
* Returning {{null}} would be clearer here:
{code}
+ return server;
{code}
* Do you really intend to wait on {{tracker.isLocationAvailable()}} for ever?
Is there a reason for sleeping outside in {{Thread.sleep()}} instead of letting
the tracker do the wait? I recommend just using
{{tracker.waitMetaRegionLocation()}} with an upper bound on {{timeout}} and
fail the operation if a {{null}} is returned, and this method can be
interrupted too, if that is what you were looking for.
* The outer {{new String()}} is not needed here:
{code}
+ new String(Bytes.toString(servername).replaceFirst(:, ,) +
,
+ + Bytes.toLong(startcode));
{code}
Misc. others
* You have a couple of {{System.out.println()}}, you might want to replace with
{{LOG}} calls.
* The below message could get misleading, since it could catch any unchecked
exceptions also. Better to create an exception type, or may be even just use
the return value of {{stripServer()}} to signal the error condition
{code}
+ } catch (Exception e) {
+LOG.info(hostname= + hostname + is not up yet, waiting, e);
+ }
{code}
* Consider calling {{ExecutorService.shutdown()}} after adding all the tasks.
The way it is right now, we have the pool leaking (applies to both {{load()}}
and {{unload()}}).
Java Tool For Region Moving
Key: HBASE-13014
URL: https://issues.apache.org/jira/browse/HBASE-13014
Project: HBase
Issue Type: Improvement
Reporter: Abhishek Singh Chouhan
Assignee: Abhishek Singh Chouhan
Attachments: HBASE-13014.patch
As per discussion on HBASE-12989 we should move the functionality of
region_mover.rb into a Java tool and use region_mover.rb only only as a
wrapper around it.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-13014) Java Tool For Region Moving
[ https://issues.apache.org/jira/browse/HBASE-13014?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14338139#comment-14338139 ] Abhishek Singh Chouhan commented on HBASE-13014: [~apurtell] [~lhofhansl] [~vik.karma] Java Tool For Region Moving Key: HBASE-13014 URL: https://issues.apache.org/jira/browse/HBASE-13014 Project: HBase Issue Type: Improvement Reporter: Abhishek Singh Chouhan Assignee: Abhishek Singh Chouhan Attachments: HBASE-13014.patch As per discussion on HBASE-12989 we should move the functionality of region_mover.rb into a Java tool and use region_mover.rb only only as a wrapper around it. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
