[jira] [Commented] (HBASE-14261) Enhance Chaos Monkey framework by adding zookeeper and datanode fault injections.
[ https://issues.apache.org/jira/browse/HBASE-14261?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14954244#comment-14954244 ] Hudson commented on HBASE-14261: FAILURE: Integrated in HBase-TRUNK #6898 (See [https://builds.apache.org/job/HBase-TRUNK/6898/]) HBASE-14558 Documenmt ChaosMonkey enhancements from HBASE-14261 (mstanleyjones: rev 397bc555e300b6c528008e6122d489792786b559) * src/main/asciidoc/_chapters/developer.adoc > Enhance Chaos Monkey framework by adding zookeeper and datanode fault > injections. > - > > Key: HBASE-14261 > URL: https://issues.apache.org/jira/browse/HBASE-14261 > Project: HBase > Issue Type: Improvement >Reporter: Srikanth Srungarapu >Assignee: Srikanth Srungarapu > Fix For: 2.0.0, 1.2.0, 1.3.0, 0.98.15, 1.0.3, 1.1.3 > > Attachments: HBASE-14261-0.98-addendum.patch, > HBASE-14261-addendum.patch, HBASE-14261-branch-1.patch, > HBASE-14261-branch-1_v3.patch, HBASE-14261-branch-1_v4.patch, > HBASE-14261.branch-1_v2.patch, HBASE-14261.patch > > > One of the shortcomings of existing ChaosMonkey framework is lack of fault > injections for hbase dependencies like zookeeper, hdfs etc. This patch > attempts to solve this problem partially by adding datanode and zk node fault > injections. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-14261) Enhance Chaos Monkey framework by adding zookeeper and datanode fault injections.
[ https://issues.apache.org/jira/browse/HBASE-14261?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14741962#comment-14741962 ] Hudson commented on HBASE-14261: FAILURE: Integrated in HBase-0.98-on-Hadoop-1.1 #1074 (See [https://builds.apache.org/job/HBase-0.98-on-Hadoop-1.1/1074/]) Amend HBASE-14261 Enhance Chaos Monkey framework by adding zookeeper and datanode fault injections (apurtell: rev 334c716ae349a212103af3bdf1edc706a3b9faad) * hbase-hadoop2-compat/pom.xml * hbase-hadoop2-compat/src/test/java/org/apache/hadoop/hbase/HadoopShimsImpl.java * hbase-hadoop1-compat/src/test/java/org/apache/hadoop/hbase/HadoopShimsImpl.java * hbase-it/src/test/java/org/apache/hadoop/hbase/chaos/actions/RestartRandomDataNodeAction.java * hbase-hadoop-compat/src/test/java/org/apache/hadoop/hbase/HadoopShims.java > Enhance Chaos Monkey framework by adding zookeeper and datanode fault > injections. > - > > Key: HBASE-14261 > URL: https://issues.apache.org/jira/browse/HBASE-14261 > Project: HBase > Issue Type: Improvement >Reporter: Srikanth Srungarapu >Assignee: Srikanth Srungarapu > Fix For: 2.0.0, 1.2.0, 1.3.0, 0.98.15, 1.0.3, 1.1.3 > > Attachments: HBASE-14261-0.98-addendum.patch, > HBASE-14261-addendum.patch, HBASE-14261-branch-1.patch, > HBASE-14261-branch-1_v3.patch, HBASE-14261-branch-1_v4.patch, > HBASE-14261.branch-1_v2.patch, HBASE-14261.patch > > > One of the shortcomings of existing ChaosMonkey framework is lack of fault > injections for hbase dependencies like zookeeper, hdfs etc. This patch > attempts to solve this problem partially by adding datanode and zk node fault > injections. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-14261) Enhance Chaos Monkey framework by adding zookeeper and datanode fault injections.
[ https://issues.apache.org/jira/browse/HBASE-14261?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14741964#comment-14741964 ] Hudson commented on HBASE-14261: FAILURE: Integrated in HBase-0.98 #1121 (See [https://builds.apache.org/job/HBase-0.98/1121/]) Amend HBASE-14261 Enhance Chaos Monkey framework by adding zookeeper and datanode fault injections (apurtell: rev 334c716ae349a212103af3bdf1edc706a3b9faad) * hbase-it/src/test/java/org/apache/hadoop/hbase/chaos/actions/RestartRandomDataNodeAction.java * hbase-hadoop2-compat/src/test/java/org/apache/hadoop/hbase/HadoopShimsImpl.java * hbase-hadoop1-compat/src/test/java/org/apache/hadoop/hbase/HadoopShimsImpl.java * hbase-hadoop2-compat/pom.xml * hbase-hadoop-compat/src/test/java/org/apache/hadoop/hbase/HadoopShims.java > Enhance Chaos Monkey framework by adding zookeeper and datanode fault > injections. > - > > Key: HBASE-14261 > URL: https://issues.apache.org/jira/browse/HBASE-14261 > Project: HBase > Issue Type: Improvement >Reporter: Srikanth Srungarapu >Assignee: Srikanth Srungarapu > Fix For: 2.0.0, 1.2.0, 1.3.0, 0.98.15, 1.0.3, 1.1.3 > > Attachments: HBASE-14261-0.98-addendum.patch, > HBASE-14261-addendum.patch, HBASE-14261-branch-1.patch, > HBASE-14261-branch-1_v3.patch, HBASE-14261-branch-1_v4.patch, > HBASE-14261.branch-1_v2.patch, HBASE-14261.patch > > > One of the shortcomings of existing ChaosMonkey framework is lack of fault > injections for hbase dependencies like zookeeper, hdfs etc. This patch > attempts to solve this problem partially by adding datanode and zk node fault > injections. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-14261) Enhance Chaos Monkey framework by adding zookeeper and datanode fault injections.
[
https://issues.apache.org/jira/browse/HBASE-14261?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14741290#comment-14741290
]
Ted Yu commented on HBASE-14261:
The following compilation error is reproducible on Mac and Linux for hadoop-1.1:
{code}
[ERROR] Failed to execute goal
org.apache.maven.plugins:maven-compiler-plugin:2.5.1:testCompile
(default-testCompile) on project hbase-it: Compilation failure: Compilation
failure:
[ERROR]
/Users/tyu/98/hbase-it/src/test/java/org/apache/hadoop/hbase/chaos/actions/RestartRandomDataNodeAction.java:[27,38]
error: cannot find symbol
[ERROR] symbol: class HdfsConstants
[ERROR] location: package org.apache.hadoop.hdfs.protocol
[ERROR]
/Users/tyu/98/hbase-it/src/test/java/org/apache/hadoop/hbase/chaos/actions/RestartRandomDataNodeAction.java:[53,70]
error: package HdfsConstants does not exist
{code}
> Enhance Chaos Monkey framework by adding zookeeper and datanode fault
> injections.
> -
>
> Key: HBASE-14261
> URL: https://issues.apache.org/jira/browse/HBASE-14261
> Project: HBase
> Issue Type: Improvement
>Reporter: Srikanth Srungarapu
>Assignee: Srikanth Srungarapu
> Fix For: 2.0.0, 1.2.0, 1.3.0, 0.98.15, 1.0.3, 1.1.3
>
> Attachments: HBASE-14261-addendum.patch, HBASE-14261-branch-1.patch,
> HBASE-14261-branch-1_v3.patch, HBASE-14261-branch-1_v4.patch,
> HBASE-14261.branch-1_v2.patch, HBASE-14261.patch
>
>
> One of the shortcomings of existing ChaosMonkey framework is lack of fault
> injections for hbase dependencies like zookeeper, hdfs etc. This patch
> attempts to solve this problem partially by adding datanode and zk node fault
> injections.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-14261) Enhance Chaos Monkey framework by adding zookeeper and datanode fault injections.
[ https://issues.apache.org/jira/browse/HBASE-14261?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14741333#comment-14741333 ] Ted Yu commented on HBASE-14261: My hands are full at the moment. > Enhance Chaos Monkey framework by adding zookeeper and datanode fault > injections. > - > > Key: HBASE-14261 > URL: https://issues.apache.org/jira/browse/HBASE-14261 > Project: HBase > Issue Type: Improvement >Reporter: Srikanth Srungarapu >Assignee: Srikanth Srungarapu > Fix For: 2.0.0, 1.2.0, 1.3.0, 0.98.15, 1.0.3, 1.1.3 > > Attachments: HBASE-14261-addendum.patch, HBASE-14261-branch-1.patch, > HBASE-14261-branch-1_v3.patch, HBASE-14261-branch-1_v4.patch, > HBASE-14261.branch-1_v2.patch, HBASE-14261.patch > > > One of the shortcomings of existing ChaosMonkey framework is lack of fault > injections for hbase dependencies like zookeeper, hdfs etc. This patch > attempts to solve this problem partially by adding datanode and zk node fault > injections. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-14261) Enhance Chaos Monkey framework by adding zookeeper and datanode fault injections.
[ https://issues.apache.org/jira/browse/HBASE-14261?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14741346#comment-14741346 ] Andrew Purtell commented on HBASE-14261: Ok, I'll fix it > Enhance Chaos Monkey framework by adding zookeeper and datanode fault > injections. > - > > Key: HBASE-14261 > URL: https://issues.apache.org/jira/browse/HBASE-14261 > Project: HBase > Issue Type: Improvement >Reporter: Srikanth Srungarapu >Assignee: Srikanth Srungarapu > Fix For: 2.0.0, 1.2.0, 1.3.0, 0.98.15, 1.0.3, 1.1.3 > > Attachments: HBASE-14261-addendum.patch, HBASE-14261-branch-1.patch, > HBASE-14261-branch-1_v3.patch, HBASE-14261-branch-1_v4.patch, > HBASE-14261.branch-1_v2.patch, HBASE-14261.patch > > > One of the shortcomings of existing ChaosMonkey framework is lack of fault > injections for hbase dependencies like zookeeper, hdfs etc. This patch > attempts to solve this problem partially by adding datanode and zk node fault > injections. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-14261) Enhance Chaos Monkey framework by adding zookeeper and datanode fault injections.
[ https://issues.apache.org/jira/browse/HBASE-14261?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14741372#comment-14741372 ] Srikanth Srungarapu commented on HBASE-14261: - Thanks! > Enhance Chaos Monkey framework by adding zookeeper and datanode fault > injections. > - > > Key: HBASE-14261 > URL: https://issues.apache.org/jira/browse/HBASE-14261 > Project: HBase > Issue Type: Improvement >Reporter: Srikanth Srungarapu >Assignee: Srikanth Srungarapu > Fix For: 2.0.0, 1.2.0, 1.3.0, 0.98.15, 1.0.3, 1.1.3 > > Attachments: HBASE-14261-addendum.patch, HBASE-14261-branch-1.patch, > HBASE-14261-branch-1_v3.patch, HBASE-14261-branch-1_v4.patch, > HBASE-14261.branch-1_v2.patch, HBASE-14261.patch > > > One of the shortcomings of existing ChaosMonkey framework is lack of fault > injections for hbase dependencies like zookeeper, hdfs etc. This patch > attempts to solve this problem partially by adding datanode and zk node fault > injections. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-14261) Enhance Chaos Monkey framework by adding zookeeper and datanode fault injections.
[ https://issues.apache.org/jira/browse/HBASE-14261?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14741295#comment-14741295 ] Andrew Purtell commented on HBASE-14261: Interested in making an addendum? If not I'll do it. > Enhance Chaos Monkey framework by adding zookeeper and datanode fault > injections. > - > > Key: HBASE-14261 > URL: https://issues.apache.org/jira/browse/HBASE-14261 > Project: HBase > Issue Type: Improvement >Reporter: Srikanth Srungarapu >Assignee: Srikanth Srungarapu > Fix For: 2.0.0, 1.2.0, 1.3.0, 0.98.15, 1.0.3, 1.1.3 > > Attachments: HBASE-14261-addendum.patch, HBASE-14261-branch-1.patch, > HBASE-14261-branch-1_v3.patch, HBASE-14261-branch-1_v4.patch, > HBASE-14261.branch-1_v2.patch, HBASE-14261.patch > > > One of the shortcomings of existing ChaosMonkey framework is lack of fault > injections for hbase dependencies like zookeeper, hdfs etc. This patch > attempts to solve this problem partially by adding datanode and zk node fault > injections. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-14261) Enhance Chaos Monkey framework by adding zookeeper and datanode fault injections.
[ https://issues.apache.org/jira/browse/HBASE-14261?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14738443#comment-14738443 ] Hudson commented on HBASE-14261: SUCCESS: Integrated in HBase-1.2-IT #134 (See [https://builds.apache.org/job/HBase-1.2-IT/134/]) HBASE-14261 Enhance Chaos Monkey framework by adding zookeeper and datanode fault injections. (ssrungarapu: rev 42ded3a1f91f380e02f9b63cccf5f566e44c4120) * hbase-it/src/test/java/org/apache/hadoop/hbase/HBaseClusterManager.java * hbase-it/src/test/java/org/apache/hadoop/hbase/chaos/factories/ServerAndDependenciesKillingMonkeyFactory.java * hbase-it/src/test/java/org/apache/hadoop/hbase/chaos/factories/MonkeyFactory.java * hbase-server/src/test/java/org/apache/hadoop/hbase/HBaseCluster.java * hbase-it/src/test/java/org/apache/hadoop/hbase/ClusterManager.java * hbase-it/src/test/java/org/apache/hadoop/hbase/RESTApiClusterManager.java * hbase-it/src/test/java/org/apache/hadoop/hbase/chaos/actions/RestartRandomDataNodeAction.java * hbase-it/src/test/java/org/apache/hadoop/hbase/chaos/actions/Action.java * hbase-server/src/main/java/org/apache/hadoop/hbase/zookeeper/ZKServerTool.java * hbase-it/src/test/java/org/apache/hadoop/hbase/chaos/actions/RestartActionBaseAction.java * hbase-it/src/test/java/org/apache/hadoop/hbase/DistributedHBaseCluster.java * hbase-server/src/test/java/org/apache/hadoop/hbase/MiniHBaseCluster.java * hbase-it/src/test/java/org/apache/hadoop/hbase/chaos/actions/RestartRandomZKNodeAction.java > Enhance Chaos Monkey framework by adding zookeeper and datanode fault > injections. > - > > Key: HBASE-14261 > URL: https://issues.apache.org/jira/browse/HBASE-14261 > Project: HBase > Issue Type: Improvement >Reporter: Srikanth Srungarapu >Assignee: Srikanth Srungarapu > Fix For: 2.0.0, 1.2.0, 1.3.0, 0.98.15, 1.0.3, 1.1.3 > > Attachments: HBASE-14261-addendum.patch, HBASE-14261-branch-1.patch, > HBASE-14261-branch-1_v3.patch, HBASE-14261-branch-1_v4.patch, > HBASE-14261.branch-1_v2.patch, HBASE-14261.patch > > > One of the shortcomings of existing ChaosMonkey framework is lack of fault > injections for hbase dependencies like zookeeper, hdfs etc. This patch > attempts to solve this problem partially by adding datanode and zk node fault > injections. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-14261) Enhance Chaos Monkey framework by adding zookeeper and datanode fault injections.
[ https://issues.apache.org/jira/browse/HBASE-14261?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14738527#comment-14738527 ] Hudson commented on HBASE-14261: FAILURE: Integrated in HBase-1.2 #158 (See [https://builds.apache.org/job/HBase-1.2/158/]) HBASE-14261 Enhance Chaos Monkey framework by adding zookeeper and datanode fault injections. (ssrungarapu: rev 42ded3a1f91f380e02f9b63cccf5f566e44c4120) * hbase-it/src/test/java/org/apache/hadoop/hbase/DistributedHBaseCluster.java * hbase-server/src/test/java/org/apache/hadoop/hbase/MiniHBaseCluster.java * hbase-it/src/test/java/org/apache/hadoop/hbase/HBaseClusterManager.java * hbase-it/src/test/java/org/apache/hadoop/hbase/chaos/actions/RestartActionBaseAction.java * hbase-it/src/test/java/org/apache/hadoop/hbase/ClusterManager.java * hbase-server/src/test/java/org/apache/hadoop/hbase/HBaseCluster.java * hbase-it/src/test/java/org/apache/hadoop/hbase/chaos/factories/ServerAndDependenciesKillingMonkeyFactory.java * hbase-it/src/test/java/org/apache/hadoop/hbase/chaos/factories/MonkeyFactory.java * hbase-it/src/test/java/org/apache/hadoop/hbase/chaos/actions/RestartRandomDataNodeAction.java * hbase-it/src/test/java/org/apache/hadoop/hbase/RESTApiClusterManager.java * hbase-it/src/test/java/org/apache/hadoop/hbase/chaos/actions/Action.java * hbase-it/src/test/java/org/apache/hadoop/hbase/chaos/actions/RestartRandomZKNodeAction.java * hbase-server/src/main/java/org/apache/hadoop/hbase/zookeeper/ZKServerTool.java > Enhance Chaos Monkey framework by adding zookeeper and datanode fault > injections. > - > > Key: HBASE-14261 > URL: https://issues.apache.org/jira/browse/HBASE-14261 > Project: HBase > Issue Type: Improvement >Reporter: Srikanth Srungarapu >Assignee: Srikanth Srungarapu > Fix For: 2.0.0, 1.2.0, 1.3.0, 0.98.15, 1.0.3, 1.1.3 > > Attachments: HBASE-14261-addendum.patch, HBASE-14261-branch-1.patch, > HBASE-14261-branch-1_v3.patch, HBASE-14261-branch-1_v4.patch, > HBASE-14261.branch-1_v2.patch, HBASE-14261.patch > > > One of the shortcomings of existing ChaosMonkey framework is lack of fault > injections for hbase dependencies like zookeeper, hdfs etc. This patch > attempts to solve this problem partially by adding datanode and zk node fault > injections. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-14261) Enhance Chaos Monkey framework by adding zookeeper and datanode fault injections.
[ https://issues.apache.org/jira/browse/HBASE-14261?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14738583#comment-14738583 ] Hudson commented on HBASE-14261: FAILURE: Integrated in HBase-1.0 #1042 (See [https://builds.apache.org/job/HBase-1.0/1042/]) HBASE-14261 Enhance Chaos Monkey framework by adding zookeeper and datanode fault injections. (ssrungarapu: rev 5412619659a8bb65ee606d612f72fa7d648ae3fe) * hbase-it/src/test/java/org/apache/hadoop/hbase/chaos/actions/Action.java * hbase-it/src/test/java/org/apache/hadoop/hbase/DistributedHBaseCluster.java * hbase-it/src/test/java/org/apache/hadoop/hbase/chaos/actions/RestartActionBaseAction.java * hbase-it/src/test/java/org/apache/hadoop/hbase/chaos/factories/MonkeyFactory.java * hbase-it/src/test/java/org/apache/hadoop/hbase/chaos/factories/ServerAndDependenciesKillingMonkeyFactory.java * hbase-it/src/test/java/org/apache/hadoop/hbase/RESTApiClusterManager.java * hbase-server/src/test/java/org/apache/hadoop/hbase/MiniHBaseCluster.java * hbase-it/src/test/java/org/apache/hadoop/hbase/HBaseClusterManager.java * hbase-server/src/test/java/org/apache/hadoop/hbase/HBaseCluster.java * hbase-it/src/test/java/org/apache/hadoop/hbase/ClusterManager.java * hbase-it/src/test/java/org/apache/hadoop/hbase/chaos/actions/RestartRandomDataNodeAction.java * hbase-server/src/main/java/org/apache/hadoop/hbase/zookeeper/ZKServerTool.java * hbase-it/src/test/java/org/apache/hadoop/hbase/chaos/actions/RestartRandomZKNodeAction.java > Enhance Chaos Monkey framework by adding zookeeper and datanode fault > injections. > - > > Key: HBASE-14261 > URL: https://issues.apache.org/jira/browse/HBASE-14261 > Project: HBase > Issue Type: Improvement >Reporter: Srikanth Srungarapu >Assignee: Srikanth Srungarapu > Fix For: 2.0.0, 1.2.0, 1.3.0, 0.98.15, 1.0.3, 1.1.3 > > Attachments: HBASE-14261-addendum.patch, HBASE-14261-branch-1.patch, > HBASE-14261-branch-1_v3.patch, HBASE-14261-branch-1_v4.patch, > HBASE-14261.branch-1_v2.patch, HBASE-14261.patch > > > One of the shortcomings of existing ChaosMonkey framework is lack of fault > injections for hbase dependencies like zookeeper, hdfs etc. This patch > attempts to solve this problem partially by adding datanode and zk node fault > injections. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-14261) Enhance Chaos Monkey framework by adding zookeeper and datanode fault injections.
[ https://issues.apache.org/jira/browse/HBASE-14261?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14738719#comment-14738719 ] Hudson commented on HBASE-14261: FAILURE: Integrated in HBase-0.98-on-Hadoop-1.1 #1066 (See [https://builds.apache.org/job/HBase-0.98-on-Hadoop-1.1/1066/]) HBASE-14261 Enhance Chaos Monkey framework by adding zookeeper and datanode fault injections. (ssrungarapu: rev b400b8572f1ff07a6d66f9fd980796081742e302) * hbase-server/src/test/java/org/apache/hadoop/hbase/HBaseCluster.java * hbase-it/src/test/java/org/apache/hadoop/hbase/ClusterManager.java * hbase-it/src/test/java/org/apache/hadoop/hbase/chaos/actions/RestartActionBaseAction.java * hbase-it/src/test/java/org/apache/hadoop/hbase/DistributedHBaseCluster.java * hbase-it/src/test/java/org/apache/hadoop/hbase/chaos/factories/MonkeyFactory.java * hbase-server/src/test/java/org/apache/hadoop/hbase/MiniHBaseCluster.java * hbase-it/src/test/java/org/apache/hadoop/hbase/RESTApiClusterManager.java * hbase-it/src/test/java/org/apache/hadoop/hbase/chaos/actions/RestartRandomZKNodeAction.java * hbase-it/src/test/java/org/apache/hadoop/hbase/chaos/actions/Action.java * hbase-it/src/test/java/org/apache/hadoop/hbase/chaos/actions/RestartRandomDataNodeAction.java * hbase-it/src/test/java/org/apache/hadoop/hbase/HBaseClusterManager.java * hbase-it/src/test/java/org/apache/hadoop/hbase/chaos/factories/ServerAndDependenciesKillingMonkeyFactory.java * hbase-server/src/main/java/org/apache/hadoop/hbase/zookeeper/ZKServerTool.java > Enhance Chaos Monkey framework by adding zookeeper and datanode fault > injections. > - > > Key: HBASE-14261 > URL: https://issues.apache.org/jira/browse/HBASE-14261 > Project: HBase > Issue Type: Improvement >Reporter: Srikanth Srungarapu >Assignee: Srikanth Srungarapu > Fix For: 2.0.0, 1.2.0, 1.3.0, 0.98.15, 1.0.3, 1.1.3 > > Attachments: HBASE-14261-addendum.patch, HBASE-14261-branch-1.patch, > HBASE-14261-branch-1_v3.patch, HBASE-14261-branch-1_v4.patch, > HBASE-14261.branch-1_v2.patch, HBASE-14261.patch > > > One of the shortcomings of existing ChaosMonkey framework is lack of fault > injections for hbase dependencies like zookeeper, hdfs etc. This patch > attempts to solve this problem partially by adding datanode and zk node fault > injections. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-14261) Enhance Chaos Monkey framework by adding zookeeper and datanode fault injections.
[ https://issues.apache.org/jira/browse/HBASE-14261?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14738609#comment-14738609 ] Hudson commented on HBASE-14261: FAILURE: Integrated in HBase-1.1 #653 (See [https://builds.apache.org/job/HBase-1.1/653/]) HBASE-14261 Enhance Chaos Monkey framework by adding zookeeper and datanode fault injections. (ssrungarapu: rev 95425c44c06684ff29a0984fdda15e2b4165008f) * hbase-it/src/test/java/org/apache/hadoop/hbase/chaos/actions/Action.java * hbase-server/src/test/java/org/apache/hadoop/hbase/HBaseCluster.java * hbase-server/src/main/java/org/apache/hadoop/hbase/zookeeper/ZKServerTool.java * hbase-it/src/test/java/org/apache/hadoop/hbase/chaos/factories/MonkeyFactory.java * hbase-it/src/test/java/org/apache/hadoop/hbase/chaos/actions/RestartActionBaseAction.java * hbase-it/src/test/java/org/apache/hadoop/hbase/DistributedHBaseCluster.java * hbase-it/src/test/java/org/apache/hadoop/hbase/chaos/actions/RestartRandomZKNodeAction.java * hbase-it/src/test/java/org/apache/hadoop/hbase/HBaseClusterManager.java * hbase-it/src/test/java/org/apache/hadoop/hbase/chaos/actions/RestartRandomDataNodeAction.java * hbase-it/src/test/java/org/apache/hadoop/hbase/chaos/factories/ServerAndDependenciesKillingMonkeyFactory.java * hbase-it/src/test/java/org/apache/hadoop/hbase/ClusterManager.java * hbase-server/src/test/java/org/apache/hadoop/hbase/MiniHBaseCluster.java * hbase-it/src/test/java/org/apache/hadoop/hbase/RESTApiClusterManager.java > Enhance Chaos Monkey framework by adding zookeeper and datanode fault > injections. > - > > Key: HBASE-14261 > URL: https://issues.apache.org/jira/browse/HBASE-14261 > Project: HBase > Issue Type: Improvement >Reporter: Srikanth Srungarapu >Assignee: Srikanth Srungarapu > Fix For: 2.0.0, 1.2.0, 1.3.0, 0.98.15, 1.0.3, 1.1.3 > > Attachments: HBASE-14261-addendum.patch, HBASE-14261-branch-1.patch, > HBASE-14261-branch-1_v3.patch, HBASE-14261-branch-1_v4.patch, > HBASE-14261.branch-1_v2.patch, HBASE-14261.patch > > > One of the shortcomings of existing ChaosMonkey framework is lack of fault > injections for hbase dependencies like zookeeper, hdfs etc. This patch > attempts to solve this problem partially by adding datanode and zk node fault > injections. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-14261) Enhance Chaos Monkey framework by adding zookeeper and datanode fault injections.
[ https://issues.apache.org/jira/browse/HBASE-14261?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14738641#comment-14738641 ] Hudson commented on HBASE-14261: FAILURE: Integrated in HBase-0.98 #1113 (See [https://builds.apache.org/job/HBase-0.98/1113/]) HBASE-14261 Enhance Chaos Monkey framework by adding zookeeper and datanode fault injections. (ssrungarapu: rev b400b8572f1ff07a6d66f9fd980796081742e302) * hbase-server/src/main/java/org/apache/hadoop/hbase/zookeeper/ZKServerTool.java * hbase-it/src/test/java/org/apache/hadoop/hbase/chaos/actions/Action.java * hbase-it/src/test/java/org/apache/hadoop/hbase/RESTApiClusterManager.java * hbase-it/src/test/java/org/apache/hadoop/hbase/ClusterManager.java * hbase-server/src/test/java/org/apache/hadoop/hbase/MiniHBaseCluster.java * hbase-server/src/test/java/org/apache/hadoop/hbase/HBaseCluster.java * hbase-it/src/test/java/org/apache/hadoop/hbase/chaos/factories/ServerAndDependenciesKillingMonkeyFactory.java * hbase-it/src/test/java/org/apache/hadoop/hbase/chaos/factories/MonkeyFactory.java * hbase-it/src/test/java/org/apache/hadoop/hbase/chaos/actions/RestartRandomZKNodeAction.java * hbase-it/src/test/java/org/apache/hadoop/hbase/chaos/actions/RestartRandomDataNodeAction.java * hbase-it/src/test/java/org/apache/hadoop/hbase/DistributedHBaseCluster.java * hbase-it/src/test/java/org/apache/hadoop/hbase/chaos/actions/RestartActionBaseAction.java * hbase-it/src/test/java/org/apache/hadoop/hbase/HBaseClusterManager.java > Enhance Chaos Monkey framework by adding zookeeper and datanode fault > injections. > - > > Key: HBASE-14261 > URL: https://issues.apache.org/jira/browse/HBASE-14261 > Project: HBase > Issue Type: Improvement >Reporter: Srikanth Srungarapu >Assignee: Srikanth Srungarapu > Fix For: 2.0.0, 1.2.0, 1.3.0, 0.98.15, 1.0.3, 1.1.3 > > Attachments: HBASE-14261-addendum.patch, HBASE-14261-branch-1.patch, > HBASE-14261-branch-1_v3.patch, HBASE-14261-branch-1_v4.patch, > HBASE-14261.branch-1_v2.patch, HBASE-14261.patch > > > One of the shortcomings of existing ChaosMonkey framework is lack of fault > injections for hbase dependencies like zookeeper, hdfs etc. This patch > attempts to solve this problem partially by adding datanode and zk node fault > injections. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-14261) Enhance Chaos Monkey framework by adding zookeeper and datanode fault injections.
[ https://issues.apache.org/jira/browse/HBASE-14261?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14732055#comment-14732055 ] Andrew Purtell commented on HBASE-14261: I think this could go back to 0.98 too. Unless I hear otherwise I'll expect to be the one fixing up a cherry pick to there. > Enhance Chaos Monkey framework by adding zookeeper and datanode fault > injections. > - > > Key: HBASE-14261 > URL: https://issues.apache.org/jira/browse/HBASE-14261 > Project: HBase > Issue Type: Improvement >Reporter: Srikanth Srungarapu >Assignee: Srikanth Srungarapu > Fix For: 2.0.0, 1.3.0 > > Attachments: HBASE-14261-addendum.patch, HBASE-14261-branch-1.patch, > HBASE-14261-branch-1_v3.patch, HBASE-14261-branch-1_v4.patch, > HBASE-14261.branch-1_v2.patch, HBASE-14261.patch > > > One of the shortcomings of existing ChaosMonkey framework is lack of fault > injections for hbase dependencies like zookeeper, hdfs etc. This patch > attempts to solve this problem partially by adding datanode and zk node fault > injections. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-14261) Enhance Chaos Monkey framework by adding zookeeper and datanode fault injections.
[ https://issues.apache.org/jira/browse/HBASE-14261?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14731284#comment-14731284 ] Srikanth Srungarapu commented on HBASE-14261: - Sure, this change warrants one. Will add it soon. Thanks for bringing this up. > Enhance Chaos Monkey framework by adding zookeeper and datanode fault > injections. > - > > Key: HBASE-14261 > URL: https://issues.apache.org/jira/browse/HBASE-14261 > Project: HBase > Issue Type: Improvement >Reporter: Srikanth Srungarapu >Assignee: Srikanth Srungarapu > Fix For: 2.0.0, 1.3.0 > > Attachments: HBASE-14261-branch-1.patch, > HBASE-14261-branch-1_v3.patch, HBASE-14261-branch-1_v4.patch, > HBASE-14261.branch-1_v2.patch, HBASE-14261.patch > > > One of the shortcomings of existing ChaosMonkey framework is lack of fault > injections for hbase dependencies like zookeeper, hdfs etc. This patch > attempts to solve this problem partially by adding datanode and zk node fault > injections. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-14261) Enhance Chaos Monkey framework by adding zookeeper and datanode fault injections.
[ https://issues.apache.org/jira/browse/HBASE-14261?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14731339#comment-14731339 ] Matteo Bertozzi commented on HBASE-14261: - +1 on addendum, but on commit you should add a comment like // bin/zookeeper.sh relies on the "ZK host" string also we should have another jira to have testing for that zookeer.sh or change that in grep insensitive > Enhance Chaos Monkey framework by adding zookeeper and datanode fault > injections. > - > > Key: HBASE-14261 > URL: https://issues.apache.org/jira/browse/HBASE-14261 > Project: HBase > Issue Type: Improvement >Reporter: Srikanth Srungarapu >Assignee: Srikanth Srungarapu > Fix For: 2.0.0, 1.3.0 > > Attachments: HBASE-14261-addendum.patch, HBASE-14261-branch-1.patch, > HBASE-14261-branch-1_v3.patch, HBASE-14261-branch-1_v4.patch, > HBASE-14261.branch-1_v2.patch, HBASE-14261.patch > > > One of the shortcomings of existing ChaosMonkey framework is lack of fault > injections for hbase dependencies like zookeeper, hdfs etc. This patch > attempts to solve this problem partially by adding datanode and zk node fault > injections. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-14261) Enhance Chaos Monkey framework by adding zookeeper and datanode fault injections.
[ https://issues.apache.org/jira/browse/HBASE-14261?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14731615#comment-14731615 ] Hudson commented on HBASE-14261: FAILURE: Integrated in HBase-1.3 #150 (See [https://builds.apache.org/job/HBase-1.3/150/]) HBASE-14261 Enhance Chaos Monkey framework by adding zookeeper and datanode fault injections; ADDENDUM (ssrungarapu: rev b84908857e562fad6ef7d7151990ab0206e40133) * hbase-server/src/main/java/org/apache/hadoop/hbase/zookeeper/ZKServerTool.java > Enhance Chaos Monkey framework by adding zookeeper and datanode fault > injections. > - > > Key: HBASE-14261 > URL: https://issues.apache.org/jira/browse/HBASE-14261 > Project: HBase > Issue Type: Improvement >Reporter: Srikanth Srungarapu >Assignee: Srikanth Srungarapu > Fix For: 2.0.0, 1.3.0 > > Attachments: HBASE-14261-addendum.patch, HBASE-14261-branch-1.patch, > HBASE-14261-branch-1_v3.patch, HBASE-14261-branch-1_v4.patch, > HBASE-14261.branch-1_v2.patch, HBASE-14261.patch > > > One of the shortcomings of existing ChaosMonkey framework is lack of fault > injections for hbase dependencies like zookeeper, hdfs etc. This patch > attempts to solve this problem partially by adding datanode and zk node fault > injections. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-14261) Enhance Chaos Monkey framework by adding zookeeper and datanode fault injections.
[ https://issues.apache.org/jira/browse/HBASE-14261?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14731703#comment-14731703 ] Hudson commented on HBASE-14261: FAILURE: Integrated in HBase-TRUNK #6783 (See [https://builds.apache.org/job/HBase-TRUNK/6783/]) HBASE-14261 Enhance Chaos Monkey framework by adding zookeeper and datanode fault injections; ADDENDUM (ssrungarapu: rev 2969093b5b39cb950d8710cfffa7e55484d40259) * hbase-server/src/main/java/org/apache/hadoop/hbase/zookeeper/ZKServerTool.java > Enhance Chaos Monkey framework by adding zookeeper and datanode fault > injections. > - > > Key: HBASE-14261 > URL: https://issues.apache.org/jira/browse/HBASE-14261 > Project: HBase > Issue Type: Improvement >Reporter: Srikanth Srungarapu >Assignee: Srikanth Srungarapu > Fix For: 2.0.0, 1.3.0 > > Attachments: HBASE-14261-addendum.patch, HBASE-14261-branch-1.patch, > HBASE-14261-branch-1_v3.patch, HBASE-14261-branch-1_v4.patch, > HBASE-14261.branch-1_v2.patch, HBASE-14261.patch > > > One of the shortcomings of existing ChaosMonkey framework is lack of fault > injections for hbase dependencies like zookeeper, hdfs etc. This patch > attempts to solve this problem partially by adding datanode and zk node fault > injections. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-14261) Enhance Chaos Monkey framework by adding zookeeper and datanode fault injections.
[ https://issues.apache.org/jira/browse/HBASE-14261?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14731690#comment-14731690 ] Hudson commented on HBASE-14261: SUCCESS: Integrated in HBase-1.3-IT #134 (See [https://builds.apache.org/job/HBase-1.3-IT/134/]) HBASE-14261 Enhance Chaos Monkey framework by adding zookeeper and datanode fault injections; ADDENDUM (ssrungarapu: rev b84908857e562fad6ef7d7151990ab0206e40133) * hbase-server/src/main/java/org/apache/hadoop/hbase/zookeeper/ZKServerTool.java > Enhance Chaos Monkey framework by adding zookeeper and datanode fault > injections. > - > > Key: HBASE-14261 > URL: https://issues.apache.org/jira/browse/HBASE-14261 > Project: HBase > Issue Type: Improvement >Reporter: Srikanth Srungarapu >Assignee: Srikanth Srungarapu > Fix For: 2.0.0, 1.3.0 > > Attachments: HBASE-14261-addendum.patch, HBASE-14261-branch-1.patch, > HBASE-14261-branch-1_v3.patch, HBASE-14261-branch-1_v4.patch, > HBASE-14261.branch-1_v2.patch, HBASE-14261.patch > > > One of the shortcomings of existing ChaosMonkey framework is lack of fault > injections for hbase dependencies like zookeeper, hdfs etc. This patch > attempts to solve this problem partially by adding datanode and zk node fault > injections. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-14261) Enhance Chaos Monkey framework by adding zookeeper and datanode fault injections.
[
https://issues.apache.org/jira/browse/HBASE-14261?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14729543#comment-14729543
]
Matteo Bertozzi commented on HBASE-14261:
-
+1
wrong message, you can fix it on commit
{code}
+++ b/hbase-server/src/test/java/org/apache/hadoop/hbase/MiniHBaseCluster.java
+ @Override
+ public void stopDataNode(ServerName serverName) throws IOException {
+LOG.warn("Aborting datanodes on mini cluster is not supported");
+ }
{code}
> Enhance Chaos Monkey framework by adding zookeeper and datanode fault
> injections.
> -
>
> Key: HBASE-14261
> URL: https://issues.apache.org/jira/browse/HBASE-14261
> Project: HBase
> Issue Type: Improvement
>Reporter: Srikanth Srungarapu
>Assignee: Srikanth Srungarapu
> Attachments: HBASE-14261-branch-1.patch,
> HBASE-14261-branch-1_v3.patch, HBASE-14261-branch-1_v4.patch,
> HBASE-14261.branch-1_v2.patch, HBASE-14261.patch
>
>
> One of the shortcomings of existing ChaosMonkey framework is lack of fault
> injections for hbase dependencies like zookeeper, hdfs etc. This patch
> attempts to solve this problem partially by adding datanode and zk node fault
> injections.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-14261) Enhance Chaos Monkey framework by adding zookeeper and datanode fault injections.
[
https://issues.apache.org/jira/browse/HBASE-14261?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14728674#comment-14728674
]
Hadoop QA commented on HBASE-14261:
---
{color:green}+1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12753910/HBASE-14261.patch
against master branch at commit 3341f13e71a25bf3f8eb5a6a57ce330b3d8a3495.
ATTACHMENT ID: 12753910
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 33 new
or modified tests.
{color:green}+1 hadoop versions{color}. The patch compiles with all
supported hadoop versions (2.4.0 2.4.1 2.5.0 2.5.1 2.5.2 2.6.0 2.7.0 2.7.1)
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 protoc{color}. The applied patch does not increase the
total number of protoc compiler warnings.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 checkstyle{color}. The applied patch does not increase the
total number of checkstyle errors
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 2.0.3) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 lineLengths{color}. The patch does not introduce lines
longer than 100
{color:green}+1 site{color}. The mvn post-site goal succeeds with this patch.
{color:green}+1 core tests{color}. The patch passed unit tests in .
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/15400//testReport/
Release Findbugs (version 2.0.3)warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/15400//artifact/patchprocess/newFindbugsWarnings.html
Checkstyle Errors:
https://builds.apache.org/job/PreCommit-HBASE-Build/15400//artifact/patchprocess/checkstyle-aggregate.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/15400//console
This message is automatically generated.
> Enhance Chaos Monkey framework by adding zookeeper and datanode fault
> injections.
> -
>
> Key: HBASE-14261
> URL: https://issues.apache.org/jira/browse/HBASE-14261
> Project: HBase
> Issue Type: Improvement
>Reporter: Srikanth Srungarapu
>Assignee: Srikanth Srungarapu
> Attachments: HBASE-14261-branch-1.patch,
> HBASE-14261-branch-1_v3.patch, HBASE-14261-branch-1_v4.patch,
> HBASE-14261.branch-1_v2.patch, HBASE-14261.patch
>
>
> One of the shortcomings of existing ChaosMonkey framework is lack of fault
> injections for hbase dependencies like zookeeper, hdfs etc. This patch
> attempts to solve this problem partially by adding datanode and zk node fault
> injections.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-14261) Enhance Chaos Monkey framework by adding zookeeper and datanode fault injections.
[ https://issues.apache.org/jira/browse/HBASE-14261?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14729998#comment-14729998 ] Hudson commented on HBASE-14261: SUCCESS: Integrated in HBase-1.3-IT #130 (See [https://builds.apache.org/job/HBase-1.3-IT/130/]) HBASE-14261 Enhance Chaos Monkey framework by adding zookeeper and datanode fault injections. (ssrungarapu: rev 1717de65a49f0ae4885be29c888712010aaff506) * hbase-it/src/test/java/org/apache/hadoop/hbase/chaos/factories/ServerAndDependenciesKillingMonkeyFactory.java * hbase-server/src/test/java/org/apache/hadoop/hbase/MiniHBaseCluster.java * hbase-it/src/test/java/org/apache/hadoop/hbase/chaos/factories/MonkeyFactory.java * hbase-it/src/test/java/org/apache/hadoop/hbase/DistributedHBaseCluster.java * hbase-it/src/test/java/org/apache/hadoop/hbase/chaos/actions/RestartRandomDataNodeAction.java * hbase-it/src/test/java/org/apache/hadoop/hbase/chaos/actions/Action.java * hbase-server/src/test/java/org/apache/hadoop/hbase/HBaseCluster.java * hbase-server/src/main/java/org/apache/hadoop/hbase/zookeeper/ZKServerTool.java * hbase-it/src/test/java/org/apache/hadoop/hbase/HBaseClusterManager.java * hbase-it/src/test/java/org/apache/hadoop/hbase/chaos/actions/RestartRandomZKNodeAction.java * hbase-it/src/test/java/org/apache/hadoop/hbase/RESTApiClusterManager.java * hbase-it/src/test/java/org/apache/hadoop/hbase/ClusterManager.java * hbase-it/src/test/java/org/apache/hadoop/hbase/chaos/actions/RestartActionBaseAction.java > Enhance Chaos Monkey framework by adding zookeeper and datanode fault > injections. > - > > Key: HBASE-14261 > URL: https://issues.apache.org/jira/browse/HBASE-14261 > Project: HBase > Issue Type: Improvement >Reporter: Srikanth Srungarapu >Assignee: Srikanth Srungarapu > Fix For: 2.0.0, 1.3.0 > > Attachments: HBASE-14261-branch-1.patch, > HBASE-14261-branch-1_v3.patch, HBASE-14261-branch-1_v4.patch, > HBASE-14261.branch-1_v2.patch, HBASE-14261.patch > > > One of the shortcomings of existing ChaosMonkey framework is lack of fault > injections for hbase dependencies like zookeeper, hdfs etc. This patch > attempts to solve this problem partially by adding datanode and zk node fault > injections. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-14261) Enhance Chaos Monkey framework by adding zookeeper and datanode fault injections.
[ https://issues.apache.org/jira/browse/HBASE-14261?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14729936#comment-14729936 ] Hudson commented on HBASE-14261: FAILURE: Integrated in HBase-TRUNK #6776 (See [https://builds.apache.org/job/HBase-TRUNK/6776/]) HBASE-14261 Enhance Chaos Monkey framework by adding zookeeper and datanode fault injections. (ssrungarapu: rev e48991970d3d584db8716ceaf9b186c46dce34b4) * hbase-server/src/test/java/org/apache/hadoop/hbase/HBaseCluster.java * hbase-it/src/test/java/org/apache/hadoop/hbase/chaos/actions/RestartActionBaseAction.java * hbase-it/src/test/java/org/apache/hadoop/hbase/chaos/actions/Action.java * hbase-it/src/test/java/org/apache/hadoop/hbase/ClusterManager.java * hbase-it/src/test/java/org/apache/hadoop/hbase/chaos/factories/ServerAndDependenciesKillingMonkeyFactory.java * hbase-it/src/test/java/org/apache/hadoop/hbase/HBaseClusterManager.java * hbase-it/src/test/java/org/apache/hadoop/hbase/DistributedHBaseCluster.java * hbase-server/src/main/java/org/apache/hadoop/hbase/zookeeper/ZKServerTool.java * hbase-it/src/test/java/org/apache/hadoop/hbase/chaos/actions/RestartRandomZKNodeAction.java * hbase-it/src/test/java/org/apache/hadoop/hbase/RESTApiClusterManager.java * hbase-it/src/test/java/org/apache/hadoop/hbase/chaos/factories/MonkeyFactory.java * hbase-it/src/test/java/org/apache/hadoop/hbase/chaos/actions/RestartRandomDataNodeAction.java * hbase-server/src/test/java/org/apache/hadoop/hbase/MiniHBaseCluster.java > Enhance Chaos Monkey framework by adding zookeeper and datanode fault > injections. > - > > Key: HBASE-14261 > URL: https://issues.apache.org/jira/browse/HBASE-14261 > Project: HBase > Issue Type: Improvement >Reporter: Srikanth Srungarapu >Assignee: Srikanth Srungarapu > Fix For: 2.0.0, 1.3.0 > > Attachments: HBASE-14261-branch-1.patch, > HBASE-14261-branch-1_v3.patch, HBASE-14261-branch-1_v4.patch, > HBASE-14261.branch-1_v2.patch, HBASE-14261.patch > > > One of the shortcomings of existing ChaosMonkey framework is lack of fault > injections for hbase dependencies like zookeeper, hdfs etc. This patch > attempts to solve this problem partially by adding datanode and zk node fault > injections. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-14261) Enhance Chaos Monkey framework by adding zookeeper and datanode fault injections.
[ https://issues.apache.org/jira/browse/HBASE-14261?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14729947#comment-14729947 ] Hudson commented on HBASE-14261: FAILURE: Integrated in HBase-1.3 #147 (See [https://builds.apache.org/job/HBase-1.3/147/]) HBASE-14261 Enhance Chaos Monkey framework by adding zookeeper and datanode fault injections. (ssrungarapu: rev 1717de65a49f0ae4885be29c888712010aaff506) * hbase-it/src/test/java/org/apache/hadoop/hbase/DistributedHBaseCluster.java * hbase-it/src/test/java/org/apache/hadoop/hbase/chaos/actions/RestartRandomZKNodeAction.java * hbase-it/src/test/java/org/apache/hadoop/hbase/chaos/actions/Action.java * hbase-it/src/test/java/org/apache/hadoop/hbase/RESTApiClusterManager.java * hbase-it/src/test/java/org/apache/hadoop/hbase/chaos/actions/RestartActionBaseAction.java * hbase-it/src/test/java/org/apache/hadoop/hbase/chaos/actions/RestartRandomDataNodeAction.java * hbase-it/src/test/java/org/apache/hadoop/hbase/chaos/factories/MonkeyFactory.java * hbase-server/src/test/java/org/apache/hadoop/hbase/MiniHBaseCluster.java * hbase-server/src/main/java/org/apache/hadoop/hbase/zookeeper/ZKServerTool.java * hbase-it/src/test/java/org/apache/hadoop/hbase/HBaseClusterManager.java * hbase-server/src/test/java/org/apache/hadoop/hbase/HBaseCluster.java * hbase-it/src/test/java/org/apache/hadoop/hbase/ClusterManager.java * hbase-it/src/test/java/org/apache/hadoop/hbase/chaos/factories/ServerAndDependenciesKillingMonkeyFactory.java > Enhance Chaos Monkey framework by adding zookeeper and datanode fault > injections. > - > > Key: HBASE-14261 > URL: https://issues.apache.org/jira/browse/HBASE-14261 > Project: HBase > Issue Type: Improvement >Reporter: Srikanth Srungarapu >Assignee: Srikanth Srungarapu > Fix For: 2.0.0, 1.3.0 > > Attachments: HBASE-14261-branch-1.patch, > HBASE-14261-branch-1_v3.patch, HBASE-14261-branch-1_v4.patch, > HBASE-14261.branch-1_v2.patch, HBASE-14261.patch > > > One of the shortcomings of existing ChaosMonkey framework is lack of fault > injections for hbase dependencies like zookeeper, hdfs etc. This patch > attempts to solve this problem partially by adding datanode and zk node fault > injections. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-14261) Enhance Chaos Monkey framework by adding zookeeper and datanode fault injections.
[ https://issues.apache.org/jira/browse/HBASE-14261?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14729978#comment-14729978 ] Srikanth Srungarapu commented on HBASE-14261: - Can I also backport this to other 1.x branches? > Enhance Chaos Monkey framework by adding zookeeper and datanode fault > injections. > - > > Key: HBASE-14261 > URL: https://issues.apache.org/jira/browse/HBASE-14261 > Project: HBase > Issue Type: Improvement >Reporter: Srikanth Srungarapu >Assignee: Srikanth Srungarapu > Fix For: 2.0.0, 1.3.0 > > Attachments: HBASE-14261-branch-1.patch, > HBASE-14261-branch-1_v3.patch, HBASE-14261-branch-1_v4.patch, > HBASE-14261.branch-1_v2.patch, HBASE-14261.patch > > > One of the shortcomings of existing ChaosMonkey framework is lack of fault > injections for hbase dependencies like zookeeper, hdfs etc. This patch > attempts to solve this problem partially by adding datanode and zk node fault > injections. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-14261) Enhance Chaos Monkey framework by adding zookeeper and datanode fault injections.
[
https://issues.apache.org/jira/browse/HBASE-14261?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14729984#comment-14729984
]
Enis Soztutar commented on HBASE-14261:
---
We should at least put this to 1.2 branch. Since this is a testability
improvement, this can go in to 1.x IMO. For 1.1 and 1.0, the only concerning
change is the extra {{sudo -u}} in the command line for the SSH command. It
might be fine, since most deployments might already be configuring it for their
IT setup.
> Enhance Chaos Monkey framework by adding zookeeper and datanode fault
> injections.
> -
>
> Key: HBASE-14261
> URL: https://issues.apache.org/jira/browse/HBASE-14261
> Project: HBase
> Issue Type: Improvement
>Reporter: Srikanth Srungarapu
>Assignee: Srikanth Srungarapu
> Fix For: 2.0.0, 1.3.0
>
> Attachments: HBASE-14261-branch-1.patch,
> HBASE-14261-branch-1_v3.patch, HBASE-14261-branch-1_v4.patch,
> HBASE-14261.branch-1_v2.patch, HBASE-14261.patch
>
>
> One of the shortcomings of existing ChaosMonkey framework is lack of fault
> injections for hbase dependencies like zookeeper, hdfs etc. This patch
> attempts to solve this problem partially by adding datanode and zk node fault
> injections.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-14261) Enhance Chaos Monkey framework by adding zookeeper and datanode fault injections.
[ https://issues.apache.org/jira/browse/HBASE-14261?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14730290#comment-14730290 ] stack commented on HBASE-14261: --- [~srikanth235] Any chance of a release note with example of how to use this fancy new feature! > Enhance Chaos Monkey framework by adding zookeeper and datanode fault > injections. > - > > Key: HBASE-14261 > URL: https://issues.apache.org/jira/browse/HBASE-14261 > Project: HBase > Issue Type: Improvement >Reporter: Srikanth Srungarapu >Assignee: Srikanth Srungarapu > Fix For: 2.0.0, 1.3.0 > > Attachments: HBASE-14261-branch-1.patch, > HBASE-14261-branch-1_v3.patch, HBASE-14261-branch-1_v4.patch, > HBASE-14261.branch-1_v2.patch, HBASE-14261.patch > > > One of the shortcomings of existing ChaosMonkey framework is lack of fault > injections for hbase dependencies like zookeeper, hdfs etc. This patch > attempts to solve this problem partially by adding datanode and zk node fault > injections. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-14261) Enhance Chaos Monkey framework by adding zookeeper and datanode fault injections.
[
https://issues.apache.org/jira/browse/HBASE-14261?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14726914#comment-14726914
]
Srikanth Srungarapu commented on HBASE-14261:
-
bq. Did you test the patch?
Yeah, I did today [~enis]. Had to tweak {{ZookeeperShellCommandProvider}} to
make things happen as expected.
> Enhance Chaos Monkey framework by adding zookeeper and datanode fault
> injections.
> -
>
> Key: HBASE-14261
> URL: https://issues.apache.org/jira/browse/HBASE-14261
> Project: HBase
> Issue Type: Improvement
>Reporter: Srikanth Srungarapu
>Assignee: Srikanth Srungarapu
> Attachments: HBASE-14261-branch-1.patch,
> HBASE-14261-branch-1_v3.patch, HBASE-14261-branch-1_v4.patch,
> HBASE-14261.branch-1_v2.patch
>
>
> One of the shortcomings of existing ChaosMonkey framework is lack of fault
> injections for hbase dependencies like zookeeper, hdfs etc. This patch
> attempts to solve this problem partially by adding datanode and zk node fault
> injections.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-14261) Enhance Chaos Monkey framework by adding zookeeper and datanode fault injections.
[
https://issues.apache.org/jira/browse/HBASE-14261?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14726902#comment-14726902
]
Srikanth Srungarapu commented on HBASE-14261:
-
bq. Any reason that DistributedHBaseCluster (and HBaseCluster) now has
waitForZkNodeToStart and waitForDataNodeToStart? I see that there were
previously just wait... methods for stopping, so I'm wondering if the wait
shouldn't just be implicit for starts (i.e. do we ever envision wanting to not
wait for the service to be started before doing things?).
We do have {{waitForRegionServerToStart}} and {{waitForActiveAndReadyMaster}}.
So, I followed the same pattern here too.
bq. Just as a general best practices question, in HBaseClusterManager, you
throw an IOException if hbase.it.clustermanager. {zookeeper,hadoop}.home isn't
set. Does not passing a correct config qualify as an IOException, or should
this just be a more general Exception?
I agree that IOException is not the most appropriate object to use here.
Hopefully HBASE-13936 will help us in handling misappropriate configurations
more appropriately. In the meanwhile, if you have something else in mind, I'd
be happy to incorporate into the patch.
Addressed all other issues in the latest patch.
> Enhance Chaos Monkey framework by adding zookeeper and datanode fault
> injections.
> -
>
> Key: HBASE-14261
> URL: https://issues.apache.org/jira/browse/HBASE-14261
> Project: HBase
> Issue Type: Improvement
>Reporter: Srikanth Srungarapu
>Assignee: Srikanth Srungarapu
> Attachments: HBASE-14261-branch-1.patch,
> HBASE-14261-branch-1_v3.patch, HBASE-14261-branch-1_v4.patch,
> HBASE-14261.branch-1_v2.patch
>
>
> One of the shortcomings of existing ChaosMonkey framework is lack of fault
> injections for hbase dependencies like zookeeper, hdfs etc. This patch
> attempts to solve this problem partially by adding datanode and zk node fault
> injections.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-14261) Enhance Chaos Monkey framework by adding zookeeper and datanode fault injections.
[ https://issues.apache.org/jira/browse/HBASE-14261?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14727794#comment-14727794 ] Srikanth Srungarapu commented on HBASE-14261: - Thanks, [~dimaspivak]. [~enis], you okay with the latest draft? > Enhance Chaos Monkey framework by adding zookeeper and datanode fault > injections. > - > > Key: HBASE-14261 > URL: https://issues.apache.org/jira/browse/HBASE-14261 > Project: HBase > Issue Type: Improvement >Reporter: Srikanth Srungarapu >Assignee: Srikanth Srungarapu > Attachments: HBASE-14261-branch-1.patch, > HBASE-14261-branch-1_v3.patch, HBASE-14261-branch-1_v4.patch, > HBASE-14261.branch-1_v2.patch > > > One of the shortcomings of existing ChaosMonkey framework is lack of fault > injections for hbase dependencies like zookeeper, hdfs etc. This patch > attempts to solve this problem partially by adding datanode and zk node fault > injections. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-14261) Enhance Chaos Monkey framework by adding zookeeper and datanode fault injections.
[ https://issues.apache.org/jira/browse/HBASE-14261?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14728383#comment-14728383 ] Enis Soztutar commented on HBASE-14261: --- bq. Enis Soztutar, you okay with the latest draft? Yes. Can you please provide a patch for master? > Enhance Chaos Monkey framework by adding zookeeper and datanode fault > injections. > - > > Key: HBASE-14261 > URL: https://issues.apache.org/jira/browse/HBASE-14261 > Project: HBase > Issue Type: Improvement >Reporter: Srikanth Srungarapu >Assignee: Srikanth Srungarapu > Attachments: HBASE-14261-branch-1.patch, > HBASE-14261-branch-1_v3.patch, HBASE-14261-branch-1_v4.patch, > HBASE-14261.branch-1_v2.patch > > > One of the shortcomings of existing ChaosMonkey framework is lack of fault > injections for hbase dependencies like zookeeper, hdfs etc. This patch > attempts to solve this problem partially by adding datanode and zk node fault > injections. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-14261) Enhance Chaos Monkey framework by adding zookeeper and datanode fault injections.
[ https://issues.apache.org/jira/browse/HBASE-14261?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14728448#comment-14728448 ] Srikanth Srungarapu commented on HBASE-14261: - Attached the patch for master branch. > Enhance Chaos Monkey framework by adding zookeeper and datanode fault > injections. > - > > Key: HBASE-14261 > URL: https://issues.apache.org/jira/browse/HBASE-14261 > Project: HBase > Issue Type: Improvement >Reporter: Srikanth Srungarapu >Assignee: Srikanth Srungarapu > Attachments: HBASE-14261-branch-1.patch, > HBASE-14261-branch-1_v3.patch, HBASE-14261-branch-1_v4.patch, > HBASE-14261.branch-1_v2.patch, HBASE-14261.patch > > > One of the shortcomings of existing ChaosMonkey framework is lack of fault > injections for hbase dependencies like zookeeper, hdfs etc. This patch > attempts to solve this problem partially by adding datanode and zk node fault > injections. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-14261) Enhance Chaos Monkey framework by adding zookeeper and datanode fault injections.
[
https://issues.apache.org/jira/browse/HBASE-14261?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14727772#comment-14727772
]
Srikanth Srungarapu commented on HBASE-14261:
-
The test {{TestStochasticBalancerJmxMetrics}} is passing locally on my box.
> Enhance Chaos Monkey framework by adding zookeeper and datanode fault
> injections.
> -
>
> Key: HBASE-14261
> URL: https://issues.apache.org/jira/browse/HBASE-14261
> Project: HBase
> Issue Type: Improvement
>Reporter: Srikanth Srungarapu
>Assignee: Srikanth Srungarapu
> Attachments: HBASE-14261-branch-1.patch,
> HBASE-14261-branch-1_v3.patch, HBASE-14261-branch-1_v4.patch,
> HBASE-14261.branch-1_v2.patch
>
>
> One of the shortcomings of existing ChaosMonkey framework is lack of fault
> injections for hbase dependencies like zookeeper, hdfs etc. This patch
> attempts to solve this problem partially by adding datanode and zk node fault
> injections.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-14261) Enhance Chaos Monkey framework by adding zookeeper and datanode fault injections.
[ https://issues.apache.org/jira/browse/HBASE-14261?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14727779#comment-14727779 ] Dima Spivak commented on HBASE-14261: - That's just [a flaky|https://builds.apache.org/job/HBase-TRUNK/lastCompletedBuild/testReport/org.apache.hadoop.hbase/TestStochasticBalancerJmxMetrics/history/], Srikanth. Your latest patch gets a +1 from me. > Enhance Chaos Monkey framework by adding zookeeper and datanode fault > injections. > - > > Key: HBASE-14261 > URL: https://issues.apache.org/jira/browse/HBASE-14261 > Project: HBase > Issue Type: Improvement >Reporter: Srikanth Srungarapu >Assignee: Srikanth Srungarapu > Attachments: HBASE-14261-branch-1.patch, > HBASE-14261-branch-1_v3.patch, HBASE-14261-branch-1_v4.patch, > HBASE-14261.branch-1_v2.patch > > > One of the shortcomings of existing ChaosMonkey framework is lack of fault > injections for hbase dependencies like zookeeper, hdfs etc. This patch > attempts to solve this problem partially by adding datanode and zk node fault > injections. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-14261) Enhance Chaos Monkey framework by adding zookeeper and datanode fault injections.
[
https://issues.apache.org/jira/browse/HBASE-14261?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14727150#comment-14727150
]
Hadoop QA commented on HBASE-14261:
---
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12753707/HBASE-14261-branch-1_v4.patch
against branch-1 branch at commit f8dd99d7380e5eafae62a9f0c526ba24f98eb2e5.
ATTACHMENT ID: 12753707
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 33 new
or modified tests.
{color:green}+1 hadoop versions{color}. The patch compiles with all
supported hadoop versions (2.4.0 2.4.1 2.5.0 2.5.1 2.5.2 2.6.0 2.7.0 2.7.1)
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 protoc{color}. The applied patch does not increase the
total number of protoc compiler warnings.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 checkstyle{color}. The applied patch does not increase the
total number of checkstyle errors
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 2.0.3) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 lineLengths{color}. The patch does not introduce lines
longer than 100
{color:green}+1 site{color}. The mvn post-site goal succeeds with this patch.
{color:red}-1 core tests{color}. The patch failed these unit tests:
org.apache.hadoop.hbase.TestStochasticBalancerJmxMetrics
{color:red}-1 core zombie tests{color}. There are 4 zombie test(s):
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/15389//testReport/
Release Findbugs (version 2.0.3)warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/15389//artifact/patchprocess/newFindbugsWarnings.html
Checkstyle Errors:
https://builds.apache.org/job/PreCommit-HBASE-Build/15389//artifact/patchprocess/checkstyle-aggregate.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/15389//console
This message is automatically generated.
> Enhance Chaos Monkey framework by adding zookeeper and datanode fault
> injections.
> -
>
> Key: HBASE-14261
> URL: https://issues.apache.org/jira/browse/HBASE-14261
> Project: HBase
> Issue Type: Improvement
>Reporter: Srikanth Srungarapu
>Assignee: Srikanth Srungarapu
> Attachments: HBASE-14261-branch-1.patch,
> HBASE-14261-branch-1_v3.patch, HBASE-14261-branch-1_v4.patch,
> HBASE-14261.branch-1_v2.patch
>
>
> One of the shortcomings of existing ChaosMonkey framework is lack of fault
> injections for hbase dependencies like zookeeper, hdfs etc. This patch
> attempts to solve this problem partially by adding datanode and zk node fault
> injections.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-14261) Enhance Chaos Monkey framework by adding zookeeper and datanode fault injections.
[
https://issues.apache.org/jira/browse/HBASE-14261?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14725752#comment-14725752
]
Dima Spivak commented on HBASE-14261:
-
Sorry for being so late to the party here, but some comments about the latest
patch (which looks awesome, [~srikanth235]):
- I agree with Enis, the HDFS user should default to hdfs instead of hadoop.
- Any reason that DistributedHBaseCluster (and HBaseCluster) now has
waitForZkNodeToStart and waitForDataNodeToStart? I see that there were
previously just wait... methods for stopping, so I'm wondering if the wait
shouldn't just be implicit for starts (i.e. do we ever envision wanting to not
wait for the service to be started before doing things?).
- Nit: "LOG.info("Waiting for service:" + service + " to stop: " +
serverName.getServerName());" could use a space after the colon in a couple of
places. There are a few other instances of this where we should probably have a
space between colons and service names for the sake of readability in the logs
later.
- Super nit: a few comments in your new
ServerAndDependenciesKillingMonkeyFactory.java are missing trailing periods.
- Just as a general best practices question, in HBaseClusterManager, you throw
an IOException if hbase.it.clustermanager.{zookeeper,hadoop}.home isn't set.
Does not passing a correct config qualify as an IOException, or should this
just be a more general Exception?
- Do you mind adding a TODO to RestApiClusterManager to add this same ZK/HDFS
functionality? I can get to it eventually. :)
- In HBaseMinCluster, the message you log at waitForDataNodeToStop doesn't
match the method.
Great work, Awesome. ;)
> Enhance Chaos Monkey framework by adding zookeeper and datanode fault
> injections.
> -
>
> Key: HBASE-14261
> URL: https://issues.apache.org/jira/browse/HBASE-14261
> Project: HBase
> Issue Type: Improvement
>Reporter: Srikanth Srungarapu
>Assignee: Srikanth Srungarapu
> Attachments: HBASE-14261-branch-1.patch,
> HBASE-14261-branch-1_v3.patch, HBASE-14261.branch-1_v2.patch
>
>
> One of the shortcomings of existing ChaosMonkey framework is lack of fault
> injections for hbase dependencies like zookeeper, hdfs etc. This patch
> attempts to solve this problem partially by adding datanode and zk node fault
> injections.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-14261) Enhance Chaos Monkey framework by adding zookeeper and datanode fault injections.
[
https://issues.apache.org/jira/browse/HBASE-14261?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14724710#comment-14724710
]
Hadoop QA commented on HBASE-14261:
---
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12753421/HBASE-14261-branch-1_v3.patch
against branch-1 branch at commit 498c1845ab7b01710955153c27501fdc7492849d.
ATTACHMENT ID: 12753421
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 30 new
or modified tests.
{color:green}+1 hadoop versions{color}. The patch compiles with all
supported hadoop versions (2.4.0 2.4.1 2.5.0 2.5.1 2.5.2 2.6.0 2.7.0 2.7.1)
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 protoc{color}. The applied patch does not increase the
total number of protoc compiler warnings.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 checkstyle{color}. The applied patch does not increase the
total number of checkstyle errors
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 2.0.3) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:red}-1 lineLengths{color}. The patch introduces the following lines
longer than 100:
+throw new IOException("Hadoop home configuration parameter i.e.
'hbase.it.clustermanager.hadoop.home' " +
+throw new IOException("Zookeeper home configuration parameter i.e.
'hbase.it.clustermanager.zookeeper.home' " +
+ private Pair exec(String hostname, ServiceType service,
String... cmd) throws IOException {
+String ret = execWithRetries(hostname, service,
getCommandProvider(service).isRunningCommand(service))
+ public static final String KILL_ZK_NODE_TIMEOUT_KEY =
"hbase.chaosmonkey.action.killzknodetimeout";
+ public static final String START_ZK_NODE_TIMEOUT_KEY =
"hbase.chaosmonkey.action.startzknodetimeout";
+ public static final String KILL_DATANODE_TIMEOUT_KEY =
"hbase.chaosmonkey.action.killdatanodetimeout";
+ public static final String START_DATANODE_TIMEOUT_KEY =
"hbase.chaosmonkey.action.startdatanodetimeout";
+killZkNodeTimeout = cluster.getConf().getLong(KILL_ZK_NODE_TIMEOUT_KEY,
KILL_ZK_NODE_TIMEOUT_DEFAULT);
+startZkNodeTimeout = cluster.getConf().getLong(START_ZK_NODE_TIMEOUT_KEY,
START_ZK_NODE_TIMEOUT_DEFAULT);
{color:green}+1 site{color}. The mvn post-site goal succeeds with this patch.
{color:red}-1 core tests{color}. The patch failed these unit tests:
{color:red}-1 core zombie tests{color}. There are 4 zombie test(s):
at
org.apache.hadoop.hbase.security.access.TestCellACLs.testCoveringCheck(TestCellACLs.java:405)
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/15372//testReport/
Release Findbugs (version 2.0.3)warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/15372//artifact/patchprocess/newFindbugsWarnings.html
Checkstyle Errors:
https://builds.apache.org/job/PreCommit-HBASE-Build/15372//artifact/patchprocess/checkstyle-aggregate.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/15372//console
This message is automatically generated.
> Enhance Chaos Monkey framework by adding zookeeper and datanode fault
> injections.
> -
>
> Key: HBASE-14261
> URL: https://issues.apache.org/jira/browse/HBASE-14261
> Project: HBase
> Issue Type: Improvement
>Reporter: Srikanth Srungarapu
>Assignee: Srikanth Srungarapu
> Attachments: HBASE-14261-branch-1.patch,
> HBASE-14261-branch-1_v3.patch, HBASE-14261.branch-1_v2.patch
>
>
> One of the shortcomings of existing ChaosMonkey framework is lack of fault
> injections for hbase dependencies like zookeeper, hdfs etc. This patch
> attempts to solve this problem partially by adding datanode and zk node fault
> injections.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-14261) Enhance Chaos Monkey framework by adding zookeeper and datanode fault injections.
[
https://issues.apache.org/jira/browse/HBASE-14261?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14724588#comment-14724588
]
Enis Soztutar commented on HBASE-14261:
---
LGTM, depending on hadoopqa. Did you test the patch?
Not sure whether {{hadoop}} or {{hdfs}} would be a better default. At least it
is configurable.
{code}
return conf.get("hbase.it.clustermanager.hadoop.hdfs.user", "hadoop");
{code}
> Enhance Chaos Monkey framework by adding zookeeper and datanode fault
> injections.
> -
>
> Key: HBASE-14261
> URL: https://issues.apache.org/jira/browse/HBASE-14261
> Project: HBase
> Issue Type: Improvement
>Reporter: Srikanth Srungarapu
>Assignee: Srikanth Srungarapu
> Attachments: HBASE-14261-branch-1.patch,
> HBASE-14261-branch-1_v3.patch, HBASE-14261.branch-1_v2.patch
>
>
> One of the shortcomings of existing ChaosMonkey framework is lack of fault
> injections for hbase dependencies like zookeeper, hdfs etc. This patch
> attempts to solve this problem partially by adding datanode and zk node fault
> injections.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-14261) Enhance Chaos Monkey framework by adding zookeeper and datanode fault injections.
[
https://issues.apache.org/jira/browse/HBASE-14261?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14724439#comment-14724439
]
Srikanth Srungarapu commented on HBASE-14261:
-
Attached patch which addresses the feedback.
Thanks [~mbertozzi] for helping with {{DFSClient}} related api discovery.
> Enhance Chaos Monkey framework by adding zookeeper and datanode fault
> injections.
> -
>
> Key: HBASE-14261
> URL: https://issues.apache.org/jira/browse/HBASE-14261
> Project: HBase
> Issue Type: Improvement
>Reporter: Srikanth Srungarapu
>Assignee: Srikanth Srungarapu
> Attachments: HBASE-14261-branch-1.patch,
> HBASE-14261-branch-1_v3.patch, HBASE-14261.branch-1_v2.patch
>
>
> One of the shortcomings of existing ChaosMonkey framework is lack of fault
> injections for hbase dependencies like zookeeper, hdfs etc. This patch
> attempts to solve this problem partially by adding datanode and zk node fault
> injections.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-14261) Enhance Chaos Monkey framework by adding zookeeper and datanode fault injections.
[
https://issues.apache.org/jira/browse/HBASE-14261?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14718186#comment-14718186
]
Hadoop QA commented on HBASE-14261:
---
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12752938/HBASE-14261.branch-1_v2.patch
against branch-1 branch at commit cc1542828de93b8d54cc14497fd5937989ea1b6d.
ATTACHMENT ID: 12752938
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 30 new
or modified tests.
{color:green}+1 hadoop versions{color}. The patch compiles with all
supported hadoop versions (2.4.0 2.4.1 2.5.0 2.5.1 2.5.2 2.6.0 2.7.0 2.7.1)
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 protoc{color}. The applied patch does not increase the
total number of protoc compiler warnings.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:red}-1 checkstyle{color}. The applied patch generated
3816 checkstyle errors (more than the master's current 3815 errors).
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 2.0.3) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:red}-1 lineLengths{color}. The patch introduces the following lines
longer than 100:
+clusterManager.kill(ServiceType.HBASE_REGIONSERVER,
serverName.getHostname(), serverName.getPort());
+clusterManager.stop(ServiceType.HBASE_REGIONSERVER,
serverName.getHostname(), serverName.getPort());
+clusterManager.kill(ServiceType.HBASE_ZOOKEEPER, serverName.getHostname(),
serverName.getPort());
+clusterManager.stop(ServiceType.HBASE_ZOOKEEPER, serverName.getHostname(),
serverName.getPort());
+clusterManager.start(ServiceType.HADOOP_DATANODE,
serverName.getHostname(), serverName.getPort());
+clusterManager.kill(ServiceType.HADOOP_DATANODE, serverName.getHostname(),
serverName.getPort());
+clusterManager.stop(ServiceType.HADOOP_DATANODE, serverName.getHostname(),
serverName.getPort());
+ * 1 SSH options, 2 user name , 3 @ if username is set, 4 host, 5 original
command, 6 service user.
+ private static final String DEFAULT_TUNNEL_CMD = /usr/bin/ssh %1$s
%2$s%3$s%4$s \sudo -u %6$s %5$s\;
+ String cmd = String.format(tunnelCmd, sshOptions, sshUserName, at,
hostname, remoteCmd, getServiceUser());
{color:green}+1 site{color}. The mvn post-site goal succeeds with this patch.
{color:red}-1 core tests{color}. The patch failed these unit tests:
{color:red}-1 core zombie tests{color}. There are 5 zombie test(s):
at
org.apache.cloudstack.GetServiceProviderMetaDataCmdTest.testAuthenticate(GetServiceProviderMetaDataCmdTest.java:83)
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/15314//testReport/
Release Findbugs (version 2.0.3)warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/15314//artifact/patchprocess/newFindbugsWarnings.html
Checkstyle Errors:
https://builds.apache.org/job/PreCommit-HBASE-Build/15314//artifact/patchprocess/checkstyle-aggregate.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/15314//console
This message is automatically generated.
Enhance Chaos Monkey framework by adding zookeeper and datanode fault
injections.
-
Key: HBASE-14261
URL: https://issues.apache.org/jira/browse/HBASE-14261
Project: HBase
Issue Type: Improvement
Reporter: Srikanth Srungarapu
Assignee: Srikanth Srungarapu
Attachments: HBASE-14261-branch-1.patch, HBASE-14261.branch-1_v2.patch
One of the shortcomings of existing ChaosMonkey framework is lack of fault
injections for hbase dependencies like zookeeper, hdfs etc. This patch
attempts to solve this problem partially by adding datanode and zk node fault
injections.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-14261) Enhance Chaos Monkey framework by adding zookeeper and datanode fault injections.
[
https://issues.apache.org/jira/browse/HBASE-14261?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14720761#comment-14720761
]
Enis Soztutar commented on HBASE-14261:
---
Thanks Srikanth. The patch looks almost there. Some more comments:
bq. Currently, zk nodes are being read using ZKServerTool and the actions get
triggered on those nodes pointed to by the output. Not sure what exactly was
being pointed to here.
Sorry I missed this part in the first patch.
This still prints to the System.out and creates a new Configuration. We want to
pass the conf and only print out to system.out when ZkServerTool.main() is
called.
{code}
+ public static ServerName[] readZKNodes() {
{code}
This should be ZOOKEEPER_SERVER since it is not a daemon of HBase.
{code}
HBASE_ZOOKEEPER(zookeeper)
{code}
Is there a way to ask NN the list of datanodes instead of reading {{slaves}}
file? In my deployment, the slaves files is under {{$HADOOP_CONF_DIR}}.
{code}
+ for (String line: FileUtils.readLines(new File(hadoopHome +
/etc/hadoop/slaves))) {
{code}
This should default to hbase rather than root:
{code}
+ return conf.get(hbase.it.clustermanager.hbase.user, root);
{code}
In deployments I have seen, hdfs daemons and mapred daemons are run as
different users (hdfs and mapred typically). We are only interested in killing
hdfs datanodes for now. So maybe {{hbase.it.clustermanager.hadoop.hdfs.user}}?
{code}
+ return conf.get(hbase.it.clustermanager.hadoop.user, hadoop);
{code}
This does not belong in RemoteShell IMO. Passing the user directly is better.
{code}
+private String getServiceUser() {
{code}
Better to sleep 100ms rather than 1sec.
{code}
+ Threads.sleep(1000);
{code}
Some lines are using 4 instead of 2 spaces as indentation.
Enhance Chaos Monkey framework by adding zookeeper and datanode fault
injections.
-
Key: HBASE-14261
URL: https://issues.apache.org/jira/browse/HBASE-14261
Project: HBase
Issue Type: Improvement
Reporter: Srikanth Srungarapu
Assignee: Srikanth Srungarapu
Attachments: HBASE-14261-branch-1.patch, HBASE-14261.branch-1_v2.patch
One of the shortcomings of existing ChaosMonkey framework is lack of fault
injections for hbase dependencies like zookeeper, hdfs etc. This patch
attempts to solve this problem partially by adding datanode and zk node fault
injections.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-14261) Enhance Chaos Monkey framework by adding zookeeper and datanode fault injections.
[
https://issues.apache.org/jira/browse/HBASE-14261?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14718077#comment-14718077
]
Srikanth Srungarapu commented on HBASE-14261:
-
bq. Zookeeper is usually not started by the hbase scripts. At least in our
deployment and testing, it is always the zkServer that is starting the
zookeeper.
Addressed.
bq. I think we can add a concept of service user, and have it as the 6th
argument to the ssh.cmd so that, one can configure the service user per ssh
depending on the service type.
Done.
bq. We have to make killing of datanodes and zk servers optional. Not all
testing needs that.
Introduced {{ServerAndDependenciesKillingMonkeyFactory}} in case if you want to
include zk and datanode related faults.
bq. This assumes that the zookeeper cluster is on the same nodes as the hbase
cluster which won't work for cluster sizes 3.
Currently, zk nodes are being read using {{ZKServerTool}} and the actions get
triggered on those nodes pointed to by the output. Not sure what exactly was
being pointed to here.
Enhance Chaos Monkey framework by adding zookeeper and datanode fault
injections.
-
Key: HBASE-14261
URL: https://issues.apache.org/jira/browse/HBASE-14261
Project: HBase
Issue Type: Improvement
Reporter: Srikanth Srungarapu
Assignee: Srikanth Srungarapu
Attachments: HBASE-14261-branch-1.patch, HBASE-14261.branch-1_v2.patch
One of the shortcomings of existing ChaosMonkey framework is lack of fault
injections for hbase dependencies like zookeeper, hdfs etc. This patch
attempts to solve this problem partially by adding datanode and zk node fault
injections.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-14261) Enhance Chaos Monkey framework by adding zookeeper and datanode fault injections.
[ https://issues.apache.org/jira/browse/HBASE-14261?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14705879#comment-14705879 ] Enis Soztutar commented on HBASE-14261: --- I forgot to add one more comment. This assumes that the zookeeper cluster is on the same nodes as the hbase cluster which won't work for cluster sizes 3. The zookeeper nodes and hdfs nodes have to be discovered separately than the hbase nodes. Enhance Chaos Monkey framework by adding zookeeper and datanode fault injections. - Key: HBASE-14261 URL: https://issues.apache.org/jira/browse/HBASE-14261 Project: HBase Issue Type: Improvement Reporter: Srikanth Srungarapu Assignee: Srikanth Srungarapu Attachments: HBASE-14261-branch-1.patch One of the shortcomings of existing ChaosMonkey framework is lack of fault injections for hbase dependencies like zookeeper, hdfs etc. This patch attempts to solve this problem partially by adding datanode and zk node fault injections. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-14261) Enhance Chaos Monkey framework by adding zookeeper and datanode fault injections.
[ https://issues.apache.org/jira/browse/HBASE-14261?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14705891#comment-14705891 ] Srikanth Srungarapu commented on HBASE-14261: - Thanks [~enis] for the review. I'll post the new patch soon. Enhance Chaos Monkey framework by adding zookeeper and datanode fault injections. - Key: HBASE-14261 URL: https://issues.apache.org/jira/browse/HBASE-14261 Project: HBase Issue Type: Improvement Reporter: Srikanth Srungarapu Assignee: Srikanth Srungarapu Attachments: HBASE-14261-branch-1.patch One of the shortcomings of existing ChaosMonkey framework is lack of fault injections for hbase dependencies like zookeeper, hdfs etc. This patch attempts to solve this problem partially by adding datanode and zk node fault injections. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-14261) Enhance Chaos Monkey framework by adding zookeeper and datanode fault injections.
[
https://issues.apache.org/jira/browse/HBASE-14261?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14704207#comment-14704207
]
Enis Soztutar commented on HBASE-14261:
---
This is good. However a couple of things:
- Zookeeper is usually not started by the hbase scripts. At least in our
deployment and testing, it is always the zkServer that is starting the
zookeeper.
- Hadoop daemons are started with a different user than the hbase user, which
is also possibly different than the test user who is running the CM. Also the
zookeeper user is usually different. Current code base uses a combination of
{{hbase.it.clustermanager.ssh.user}} and {{hbase.it.clustermanager.ssh.cmd}} as
a way to configure the ssh user, and if needed run the command as a different
user. Our test env uses something like this:
{code}
property
namehbase.it.clustermanager.ssh.cmd/name
value/usr/bin/ssh %1$s %2$s%3$s%4$s sudo su - hbase -c \%5$s\/value
/property
{code}.
I think we can add a concept of service user, and have it as the 6th argument
to the {{ssh.cmd}} so that, one can configure the service user per ssh
depending on the service type.
- We have to make killing of datanodes and zk servers optional. Not all
testing needs that.
Enhance Chaos Monkey framework by adding zookeeper and datanode fault
injections.
-
Key: HBASE-14261
URL: https://issues.apache.org/jira/browse/HBASE-14261
Project: HBase
Issue Type: Improvement
Reporter: Srikanth Srungarapu
Assignee: Srikanth Srungarapu
Attachments: HBASE-14261-branch-1.patch
One of the shortcomings of existing ChaosMonkey framework is lack of fault
injections for hbase dependencies like zookeeper, hdfs etc. This patch
attempts to solve this problem partially by adding datanode and zk node fault
injections.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
