subject:"\[jira\] \[Commented\] \(HBASE\-16308\) Contain protobuf references"

[jira] [Commented] (HBASE-16308) Contain protobuf references

2016-09-30 Thread stack (JIRA)


[ 
https://issues.apache.org/jira/browse/HBASE-16308?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15537150#comment-15537150
 ] 

stack commented on HBASE-16308:
---

Just to say that I have now gone back some from this idea of moving all to do 
with protobuf back into one module.

Rather, protobufs should be packaged with the module that uses them in the case 
of coprocessor endpoints or say for REST. This issue made sense at one time 
when trying to sort out our protobuf mess but now we have a clue and a 
separation between 'internal' protobuf use and external -- e.g. CPEP -- we can 
get back to good module encapsulation. I'll write up 'rules' in a new protobuf 
chapter in book.

> Contain protobuf references
> ---
>
> Key: HBASE-16308
> URL: https://issues.apache.org/jira/browse/HBASE-16308
> Project: HBase
>  Issue Type: Sub-task
>  Components: Protobufs
>Reporter: stack
>Assignee: stack
> Fix For: 2.0.0
>
> Attachments: HBASE-16308.master.001.patch, 
> HBASE-16308.master.002.patch, HBASE-16308.master.003.patch, 
> HBASE-16308.master.004.patch, HBASE-16308.master.005.patch, 
> HBASE-16308.master.006.patch, HBASE-16308.master.006.patch, 
> HBASE-16308.master.007.patch, HBASE-16308.master.008.patch, 
> HBASE-16308.master.009.patch, HBASE-16308.master.010.patch, 
> HBASE-16308.master.011.patch, HBASE-16308.master.012.patch, 
> HBASE-16308.master.013.patch, HBASE-16308.master.014.patch, 
> HBASE-16308.master.015.patch, HBASE-16308.master.015.patch
>
>
> Clean up our protobuf references so contained to just a few classes rather 
> than being spread about the codebase. Doing this work will make it easier 
> landing the parent issue and will make it more clear where the division 
> between shaded protobuf and unshaded protobuf lies (we need to continue with 
> unshaded protobuf for HDFS references by AsyncWAL and probably EndPoint 
> Coprocessors)



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (HBASE-16308) Contain protobuf references

2016-08-10 Thread Hudson (JIRA)


[ 
https://issues.apache.org/jira/browse/HBASE-16308?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15415682#comment-15415682
 ] 

Hudson commented on HBASE-16308:


FAILURE: Integrated in HBase-Trunk_matrix #1391 (See 
[https://builds.apache.org/job/HBase-Trunk_matrix/1391/])
REVERT of revert of "HBASE-16308 Contain protobuf references Gather up (stack: 
rev 45bb6180a3b8d915d8db88b8edf420cdbdcb4c21)
* 
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/RSRpcServices.java
* 
hbase-server/src/main/java/org/apache/hadoop/hbase/mob/ExpiredMobFileCleaner.java
* hbase-client/src/main/java/org/apache/hadoop/hbase/client/ScannerCallable.java
* 
hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestHRegionServerBulkLoadWithOldClient.java
* 
hbase-client/src/main/java/org/apache/hadoop/hbase/client/RpcRetryingCallable.java
* hbase-common/src/main/java/org/apache/hadoop/hbase/HBaseIOException.java
* 
hbase-client/src/main/java/org/apache/hadoop/hbase/client/RpcRetryingCallerWithReadReplicas.java
* 
hbase-client/src/main/java/org/apache/hadoop/hbase/ipc/PayloadCarryingRpcController.java
* 
hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestReplicaWithCluster.java
* 
hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/RegionReplicaReplicationEndpoint.java
* hbase-server/src/main/java/org/apache/hadoop/hbase/master/ServerManager.java
* 
hbase-server/src/test/java/org/apache/hadoop/hbase/master/balancer/TestRegionLocationFinder.java
* 
hbase-client/src/main/java/org/apache/hadoop/hbase/client/MasterKeepAliveConnection.java
* hbase-client/src/main/java/org/apache/hadoop/hbase/client/HTable.java
* 
hbase-client/src/main/java/org/apache/hadoop/hbase/client/ConnectionCallable.java
* hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestHCM.java
* 
hbase-client/src/main/java/org/apache/hadoop/hbase/client/RetryingCallable.java
* 
hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestHRegionServerBulkLoad.java
* 
hbase-spark/src/main/java/org/apache/hadoop/hbase/spark/SparkSQLPushDownFilter.java
* hbase-server/src/main/java/org/apache/hadoop/hbase/tool/Canary.java
* 
hbase-server/src/test/java/org/apache/hadoop/hbase/mob/mapreduce/TestMobSweepMapper.java
* 
hbase-client/src/main/java/org/apache/hadoop/hbase/client/RpcRetryingCallerFactory.java
* 
hbase-client/src/main/java/org/apache/hadoop/hbase/ipc/MasterCoprocessorRpcChannel.java
* 
hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestClientTimeouts.java
* 
hbase-client/src/main/java/org/apache/hadoop/hbase/client/RetryingTimeTracker.java
* hbase-server/src/test/java/org/apache/hadoop/hbase/TestNamespace.java
* 
hbase-client/src/main/java/org/apache/hadoop/hbase/client/ClientSmallScanner.java
* 
hbase-client/src/main/java/org/apache/hadoop/hbase/client/CancellableRegionServerCallable.java
* hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestAdmin2.java
* 
hbase-client/src/main/java/org/apache/hadoop/hbase/ipc/TimeLimitedRpcController.java
* 
hbase-client/src/main/java/org/apache/hadoop/hbase/client/FlushRegionCallable.java
* hbase-common/src/main/java/org/apache/hadoop/hbase/util/ExceptionUtil.java
* 
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/WALEditsReplaySink.java
* hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/RpcServer.java
* 
hbase-client/src/main/java/org/apache/hadoop/hbase/client/RpcRetryingCaller.java
* 
hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestReplicasClient.java
* 
hbase-client/src/main/java/org/apache/hadoop/hbase/client/SecureBulkLoadClient.java
* hbase-server/src/main/java/org/apache/hadoop/hbase/util/Merge.java
* 
hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestHRegionServerBulkLoadWithOldSecureEndpoint.java
* 
hbase-client/src/main/java/org/apache/hadoop/hbase/ipc/RegionCoprocessorRpcChannel.java
* 
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java
* 
hbase-client/src/main/java/org/apache/hadoop/hbase/client/NoncedRegionServerCallable.java
* hbase-client/src/main/java/org/apache/hadoop/hbase/client/HBaseAdmin.java
* hbase-client/src/main/java/org/apache/hadoop/hbase/client/MasterCallable.java
* 
hbase-client/src/main/java/org/apache/hadoop/hbase/client/MultiServerCallable.java
* 
hbase-server/src/main/java/org/apache/hadoop/hbase/master/TableStateManager.java
* 
hbase-server/src/main/java/org/apache/hadoop/hbase/master/MasterRpcServices.java
* 
hbase-client/src/main/java/org/apache/hadoop/hbase/client/ScannerCallableWithReplicas.java
* 
hbase-client/src/main/java/org/apache/hadoop/hbase/client/RegionAdminServiceCallable.java
* 
hbase-client/src/main/java/org/apache/hadoop/hbase/client/ConnectionImplementation.java
* 
hbase-client/src/main/java/org/apache/hadoop/hbase/client/PayloadCarryingServerCallable.java
*

[jira] [Commented] (HBASE-16308) Contain protobuf references

2016-08-10 Thread Hadoop QA (JIRA)


[ 
https://issues.apache.org/jira/browse/HBASE-16308?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15415611#comment-15415611
 ] 

Hadoop QA commented on HBASE-16308:
---

| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m 14s 
{color} | {color:blue} Docker mode activated. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s 
{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m 
0s {color} | {color:green} The patch appears to include 14 new or modified test 
files. {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 10s 
{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 3m 
6s {color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m 57s 
{color} | {color:green} master passed with JDK v1.8.0_101 {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 2m 15s 
{color} | {color:green} master passed with JDK v1.7.0_101 {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m 
28s {color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m 
59s {color} | {color:green} master passed {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 2m 6s 
{color} | {color:red} hbase-server in master has 1 extant Findbugs warnings. 
{color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m 10s 
{color} | {color:green} master passed with JDK v1.8.0_101 {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m 24s 
{color} | {color:green} master passed with JDK v1.7.0_101 {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 10s 
{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 2m 
32s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m 52s 
{color} | {color:green} the patch passed with JDK v1.8.0_101 {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 1m 52s 
{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 2m 15s 
{color} | {color:green} the patch passed with JDK v1.7.0_101 {color} |
| {color:red}-1{color} | {color:red} javac {color} | {color:red} 0m 35s {color} 
| {color:red} hbase-server-jdk1.7.0_101 with JDK v1.7.0_101 generated 2 new + 4 
unchanged - 2 fixed = 6 total (was 6) {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m 
25s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m 
54s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 
0s {color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green} 
27m 56s {color} | {color:green} Patch does not cause any errors with Hadoop 
2.4.0 2.4.1 2.5.0 2.5.1 2.5.2 2.6.1 2.6.2 2.6.3 2.7.1. {color} |
| {color:green}+1{color} | {color:green} hbaseprotoc {color} | {color:green} 0m 
53s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 0m 
58s {color} | {color:green} hbase-common in the patch passed. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 1m 
12s {color} | {color:green} hbase-client in the patch passed. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 2m 
13s {color} | {color:green} hbase-server generated 0 new + 0 unchanged - 1 
fixed = 0 total (was 1) {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 0m 
57s {color} | {color:green} hbase-spark in the patch passed. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m 12s 
{color} | {color:green} the patch passed with JDK v1.8.0_101 {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m 31s 
{color} | {color:green} the patch passed with JDK v1.7.0_101 {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 1m 45s 
{color} | {color:green} hbase-common in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 1m 4s 
{color} | {color:green} hbase-client in

[jira] [Commented] (HBASE-16308) Contain protobuf references

2016-08-10 Thread Hadoop QA (JIRA)


[ 
https://issues.apache.org/jira/browse/HBASE-16308?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15415590#comment-15415590
 ] 

Hadoop QA commented on HBASE-16308:
---

| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m 15s 
{color} | {color:blue} Docker mode activated. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s 
{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m 
0s {color} | {color:green} The patch appears to include 14 new or modified test 
files. {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 10s 
{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 3m 
4s {color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m 46s 
{color} | {color:green} master passed with JDK v1.8.0_101 {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 2m 16s 
{color} | {color:green} master passed with JDK v1.7.0_101 {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m 
28s {color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m 
56s {color} | {color:green} master passed {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 1m 58s 
{color} | {color:red} hbase-server in master has 1 extant Findbugs warnings. 
{color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m 4s 
{color} | {color:green} master passed with JDK v1.8.0_101 {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m 23s 
{color} | {color:green} master passed with JDK v1.7.0_101 {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 11s 
{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 2m 
32s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m 50s 
{color} | {color:green} the patch passed with JDK v1.8.0_101 {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 1m 50s 
{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 2m 16s 
{color} | {color:green} the patch passed with JDK v1.7.0_101 {color} |
| {color:red}-1{color} | {color:red} javac {color} | {color:red} 0m 35s {color} 
| {color:red} hbase-server-jdk1.7.0_101 with JDK v1.7.0_101 generated 2 new + 4 
unchanged - 2 fixed = 6 total (was 6) {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m 
28s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m 
55s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 
0s {color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green} 
27m 23s {color} | {color:green} Patch does not cause any errors with Hadoop 
2.4.0 2.4.1 2.5.0 2.5.1 2.5.2 2.6.1 2.6.2 2.6.3 2.7.1. {color} |
| {color:green}+1{color} | {color:green} hbaseprotoc {color} | {color:green} 0m 
51s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 0m 
58s {color} | {color:green} hbase-common in the patch passed. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 1m 9s 
{color} | {color:green} hbase-client in the patch passed. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 2m 
11s {color} | {color:green} hbase-server generated 0 new + 0 unchanged - 1 
fixed = 0 total (was 1) {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 0m 
56s {color} | {color:green} hbase-spark in the patch passed. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m 4s 
{color} | {color:green} the patch passed with JDK v1.8.0_101 {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m 23s 
{color} | {color:green} the patch passed with JDK v1.7.0_101 {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 1m 41s 
{color} | {color:green} hbase-common in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 1m 0s 
{color} | {color:green} hbase-client in

[jira] [Commented] (HBASE-16308) Contain protobuf references

2016-08-10 Thread stack (JIRA)


[ 
https://issues.apache.org/jira/browse/HBASE-16308?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15415336#comment-15415336
 ] 

stack commented on HBASE-16308:
---

In last patch, undid the addition of retries in Admin. The code says they are 
needed in comment but opens new can of worms. The server needs review changing 
IOEs to DoNotRetryIOEs else things like bad column family gets stuck retrying 
when should fail.

> Contain protobuf references
> ---
>
> Key: HBASE-16308
> URL: https://issues.apache.org/jira/browse/HBASE-16308
> Project: HBase
>  Issue Type: Sub-task
>  Components: Protobufs
>Reporter: stack
>Assignee: stack
> Fix For: 2.0.0
>
> Attachments: HBASE-16308.master.001.patch, 
> HBASE-16308.master.002.patch, HBASE-16308.master.003.patch, 
> HBASE-16308.master.004.patch, HBASE-16308.master.005.patch, 
> HBASE-16308.master.006.patch, HBASE-16308.master.006.patch, 
> HBASE-16308.master.007.patch, HBASE-16308.master.008.patch, 
> HBASE-16308.master.009.patch, HBASE-16308.master.010.patch, 
> HBASE-16308.master.011.patch, HBASE-16308.master.012.patch, 
> HBASE-16308.master.013.patch, HBASE-16308.master.014.patch
>
>
> Clean up our protobuf references so contained to just a few classes rather 
> than being spread about the codebase. Doing this work will make it easier 
> landing the parent issue and will make it more clear where the division 
> between shaded protobuf and unshaded protobuf lies (we need to continue with 
> unshaded protobuf for HDFS references by AsyncWAL and probably EndPoint 
> Coprocessors)



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (HBASE-16308) Contain protobuf references

2016-08-10 Thread Hadoop QA (JIRA)


[ 
https://issues.apache.org/jira/browse/HBASE-16308?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15415332#comment-15415332
 ] 

Hadoop QA commented on HBASE-16308:
---

| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m 0s 
{color} | {color:blue} Docker mode activated. {color} |
| {color:red}-1{color} | {color:red} patch {color} | {color:red} 0m 4s {color} 
| {color:red} HBASE-16308 does not apply to master. Rebase required? Wrong 
Branch? See https://yetus.apache.org/documentation/0.3.0/precommit-patchnames 
for help. {color} |
\\
\\
|| Subsystem || Report/Notes ||
| JIRA Patch URL | 
https://issues.apache.org/jira/secure/attachment/12823035/HBASE-16308.master.014.patch
 |
| JIRA Issue | HBASE-16308 |
| Console output | 
https://builds.apache.org/job/PreCommit-HBASE-Build/3051/console |
| Powered by | Apache Yetus 0.3.0   http://yetus.apache.org |


This message was automatically generated.



> Contain protobuf references
> ---
>
> Key: HBASE-16308
> URL: https://issues.apache.org/jira/browse/HBASE-16308
> Project: HBase
>  Issue Type: Sub-task
>  Components: Protobufs
>Reporter: stack
>Assignee: stack
> Fix For: 2.0.0
>
> Attachments: HBASE-16308.master.001.patch, 
> HBASE-16308.master.002.patch, HBASE-16308.master.003.patch, 
> HBASE-16308.master.004.patch, HBASE-16308.master.005.patch, 
> HBASE-16308.master.006.patch, HBASE-16308.master.006.patch, 
> HBASE-16308.master.007.patch, HBASE-16308.master.008.patch, 
> HBASE-16308.master.009.patch, HBASE-16308.master.010.patch, 
> HBASE-16308.master.011.patch, HBASE-16308.master.012.patch, 
> HBASE-16308.master.013.patch, HBASE-16308.master.014.patch
>
>
> Clean up our protobuf references so contained to just a few classes rather 
> than being spread about the codebase. Doing this work will make it easier 
> landing the parent issue and will make it more clear where the division 
> between shaded protobuf and unshaded protobuf lies (we need to continue with 
> unshaded protobuf for HDFS references by AsyncWAL and probably EndPoint 
> Coprocessors)



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (HBASE-16308) Contain protobuf references

2016-08-10 Thread Hadoop QA (JIRA)


[ 
https://issues.apache.org/jira/browse/HBASE-16308?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15414921#comment-15414921
 ] 

Hadoop QA commented on HBASE-16308:
---

| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m 16s 
{color} | {color:blue} Docker mode activated. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s 
{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m 
0s {color} | {color:green} The patch appears to include 14 new or modified test 
files. {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 29s 
{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 3m 
16s {color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m 47s 
{color} | {color:green} master passed with JDK v1.8.0_101 {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 2m 14s 
{color} | {color:green} master passed with JDK v1.7.0_101 {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m 
30s {color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m 
56s {color} | {color:green} master passed {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 1m 55s 
{color} | {color:red} hbase-server in master has 1 extant Findbugs warnings. 
{color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m 5s 
{color} | {color:green} master passed with JDK v1.8.0_101 {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m 24s 
{color} | {color:green} master passed with JDK v1.7.0_101 {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 11s 
{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 2m 
31s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m 47s 
{color} | {color:green} the patch passed with JDK v1.8.0_101 {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 1m 47s 
{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 2m 16s 
{color} | {color:green} the patch passed with JDK v1.7.0_101 {color} |
| {color:red}-1{color} | {color:red} javac {color} | {color:red} 0m 35s {color} 
| {color:red} hbase-server-jdk1.7.0_101 with JDK v1.7.0_101 generated 2 new + 4 
unchanged - 2 fixed = 6 total (was 6) {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m 
29s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m 
57s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 
0s {color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green} 
27m 14s {color} | {color:green} Patch does not cause any errors with Hadoop 
2.4.0 2.4.1 2.5.0 2.5.1 2.5.2 2.6.1 2.6.2 2.6.3 2.7.1. {color} |
| {color:green}+1{color} | {color:green} hbaseprotoc {color} | {color:green} 0m 
52s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 0m 
55s {color} | {color:green} hbase-common in the patch passed. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 1m 
10s {color} | {color:green} hbase-client in the patch passed. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 2m 
10s {color} | {color:green} hbase-server generated 0 new + 0 unchanged - 1 
fixed = 0 total (was 1) {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 0m 
55s {color} | {color:green} hbase-spark in the patch passed. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m 4s 
{color} | {color:green} the patch passed with JDK v1.8.0_101 {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m 25s 
{color} | {color:green} the patch passed with JDK v1.7.0_101 {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 1m 41s 
{color} | {color:green} hbase-common in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m 59s 
{color} | {color:green} hbase-client

[jira] [Commented] (HBASE-16308) Contain protobuf references

2016-08-09 Thread stack (JIRA)


[ 
https://issues.apache.org/jira/browse/HBASE-16308?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15414766#comment-15414766
 ] 

stack commented on HBASE-16308:
---

v13 Fix fact that I was not initializing RpcController in ScannerCallable.

> Contain protobuf references
> ---
>
> Key: HBASE-16308
> URL: https://issues.apache.org/jira/browse/HBASE-16308
> Project: HBase
>  Issue Type: Sub-task
>  Components: Protobufs
>Reporter: stack
>Assignee: stack
> Fix For: 2.0.0
>
> Attachments: HBASE-16308.master.001.patch, 
> HBASE-16308.master.002.patch, HBASE-16308.master.003.patch, 
> HBASE-16308.master.004.patch, HBASE-16308.master.005.patch, 
> HBASE-16308.master.006.patch, HBASE-16308.master.006.patch, 
> HBASE-16308.master.007.patch, HBASE-16308.master.008.patch, 
> HBASE-16308.master.009.patch, HBASE-16308.master.010.patch, 
> HBASE-16308.master.011.patch, HBASE-16308.master.012.patch, 
> HBASE-16308.master.013.patch
>
>
> Clean up our protobuf references so contained to just a few classes rather 
> than being spread about the codebase. Doing this work will make it easier 
> landing the parent issue and will make it more clear where the division 
> between shaded protobuf and unshaded protobuf lies (we need to continue with 
> unshaded protobuf for HDFS references by AsyncWAL and probably EndPoint 
> Coprocessors)



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (HBASE-16308) Contain protobuf references

2016-08-09 Thread Hadoop QA (JIRA)


[ 
https://issues.apache.org/jira/browse/HBASE-16308?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15414410#comment-15414410
 ] 

Hadoop QA commented on HBASE-16308:
---

| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m 12s 
{color} | {color:blue} Docker mode activated. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s 
{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m 
0s {color} | {color:green} The patch appears to include 14 new or modified test 
files. {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 9s 
{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 3m 
3s {color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m 46s 
{color} | {color:green} master passed with JDK v1.8.0_101 {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 2m 15s 
{color} | {color:green} master passed with JDK v1.7.0_101 {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m 
29s {color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m 
55s {color} | {color:green} master passed {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 1m 56s 
{color} | {color:red} hbase-server in master has 1 extant Findbugs warnings. 
{color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m 5s 
{color} | {color:green} master passed with JDK v1.8.0_101 {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m 23s 
{color} | {color:green} master passed with JDK v1.7.0_101 {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 12s 
{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 2m 
28s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m 47s 
{color} | {color:green} the patch passed with JDK v1.8.0_101 {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 1m 47s 
{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 2m 16s 
{color} | {color:green} the patch passed with JDK v1.7.0_101 {color} |
| {color:red}-1{color} | {color:red} javac {color} | {color:red} 0m 34s {color} 
| {color:red} hbase-server-jdk1.7.0_101 with JDK v1.7.0_101 generated 2 new + 4 
unchanged - 2 fixed = 6 total (was 6) {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m 
28s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m 
55s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 
0s {color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green} 
27m 24s {color} | {color:green} Patch does not cause any errors with Hadoop 
2.4.0 2.4.1 2.5.0 2.5.1 2.5.2 2.6.1 2.6.2 2.6.3 2.7.1. {color} |
| {color:green}+1{color} | {color:green} hbaseprotoc {color} | {color:green} 0m 
51s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 0m 
56s {color} | {color:green} hbase-common in the patch passed. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 1m 
11s {color} | {color:green} hbase-client in the patch passed. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 2m 
14s {color} | {color:green} hbase-server generated 0 new + 0 unchanged - 1 
fixed = 0 total (was 1) {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 0m 
56s {color} | {color:green} hbase-spark in the patch passed. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m 3s 
{color} | {color:green} the patch passed with JDK v1.8.0_101 {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m 23s 
{color} | {color:green} the patch passed with JDK v1.7.0_101 {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 1m 42s 
{color} | {color:green} hbase-common in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 1m 0s 
{color} | {color:green} hbase-client in

[jira] [Commented] (HBASE-16308) Contain protobuf references

2016-08-09 Thread Hadoop QA (JIRA)


[ 
https://issues.apache.org/jira/browse/HBASE-16308?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15414073#comment-15414073
 ] 

Hadoop QA commented on HBASE-16308:
---

| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m 12s 
{color} | {color:blue} Docker mode activated. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s 
{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m 
0s {color} | {color:green} The patch appears to include 14 new or modified test 
files. {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 21s 
{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 3m 
23s {color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m 57s 
{color} | {color:green} master passed with JDK v1.8.0_101 {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 2m 27s 
{color} | {color:green} master passed with JDK v1.7.0_101 {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m 
32s {color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m 
59s {color} | {color:green} master passed {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 2m 9s 
{color} | {color:red} hbase-server in master has 1 extant Findbugs warnings. 
{color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m 13s 
{color} | {color:green} master passed with JDK v1.8.0_101 {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m 24s 
{color} | {color:green} master passed with JDK v1.7.0_101 {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 11s 
{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 2m 
35s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m 44s 
{color} | {color:green} the patch passed with JDK v1.8.0_101 {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 1m 44s 
{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 2m 13s 
{color} | {color:green} the patch passed with JDK v1.7.0_101 {color} |
| {color:red}-1{color} | {color:red} javac {color} | {color:red} 0m 35s {color} 
| {color:red} hbase-server-jdk1.7.0_101 with JDK v1.7.0_101 generated 2 new + 4 
unchanged - 2 fixed = 6 total (was 6) {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m 
25s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m 
55s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 
0s {color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green} 
28m 7s {color} | {color:green} Patch does not cause any errors with Hadoop 
2.4.0 2.4.1 2.5.0 2.5.1 2.5.2 2.6.1 2.6.2 2.6.3 2.7.1. {color} |
| {color:green}+1{color} | {color:green} hbaseprotoc {color} | {color:green} 0m 
52s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 1m 0s 
{color} | {color:green} hbase-common in the patch passed. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 1m 
15s {color} | {color:green} hbase-client in the patch passed. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 2m 
25s {color} | {color:green} hbase-server generated 0 new + 0 unchanged - 1 
fixed = 0 total (was 1) {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 1m 4s 
{color} | {color:green} hbase-spark in the patch passed. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m 19s 
{color} | {color:green} the patch passed with JDK v1.8.0_101 {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m 29s 
{color} | {color:green} the patch passed with JDK v1.7.0_101 {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 1m 49s 
{color} | {color:green} hbase-common in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 1m 6s 
{color} | {color:green} hbase-client in

[jira] [Commented] (HBASE-16308) Contain protobuf references

2016-08-09 Thread Hadoop QA (JIRA)


[ 
https://issues.apache.org/jira/browse/HBASE-16308?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15413798#comment-15413798
 ] 

Hadoop QA commented on HBASE-16308:
---

| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m 12s 
{color} | {color:blue} Docker mode activated. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s 
{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m 
0s {color} | {color:green} The patch appears to include 14 new or modified test 
files. {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 10s 
{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 3m 
6s {color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m 49s 
{color} | {color:green} master passed with JDK v1.8.0_101 {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 2m 15s 
{color} | {color:green} master passed with JDK v1.7.0_101 {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m 
28s {color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m 
55s {color} | {color:green} master passed {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 1m 57s 
{color} | {color:red} hbase-server in master has 1 extant Findbugs warnings. 
{color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m 5s 
{color} | {color:green} master passed with JDK v1.8.0_101 {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m 24s 
{color} | {color:green} master passed with JDK v1.7.0_101 {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 10s 
{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 2m 
30s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m 47s 
{color} | {color:green} the patch passed with JDK v1.8.0_101 {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 1m 47s 
{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 2m 15s 
{color} | {color:green} the patch passed with JDK v1.7.0_101 {color} |
| {color:red}-1{color} | {color:red} javac {color} | {color:red} 0m 35s {color} 
| {color:red} hbase-server-jdk1.7.0_101 with JDK v1.7.0_101 generated 2 new + 4 
unchanged - 2 fixed = 6 total (was 6) {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m 
28s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m 
55s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 
0s {color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green} 
27m 31s {color} | {color:green} Patch does not cause any errors with Hadoop 
2.4.0 2.4.1 2.5.0 2.5.1 2.5.2 2.6.1 2.6.2 2.6.3 2.7.1. {color} |
| {color:green}+1{color} | {color:green} hbaseprotoc {color} | {color:green} 0m 
51s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 0m 
58s {color} | {color:green} hbase-common in the patch passed. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 1m 9s 
{color} | {color:green} hbase-client in the patch passed. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 2m 
10s {color} | {color:green} hbase-server generated 0 new + 0 unchanged - 1 
fixed = 0 total (was 1) {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 0m 
55s {color} | {color:green} hbase-spark in the patch passed. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m 4s 
{color} | {color:green} the patch passed with JDK v1.8.0_101 {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m 23s 
{color} | {color:green} the patch passed with JDK v1.7.0_101 {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 1m 42s 
{color} | {color:green} hbase-common in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m 59s 
{color} | {color:green} hbase-client in

[jira] [Commented] (HBASE-16308) Contain protobuf references

2016-08-08 Thread stack (JIRA)


[ 
https://issues.apache.org/jira/browse/HBASE-16308?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15412925#comment-15412925
 ] 

stack commented on HBASE-16308:
---

Fix the findbugs (not mine) and a NPE. There are still some weird failures in 
here. Digging but get a run in in the meantime.

> Contain protobuf references
> ---
>
> Key: HBASE-16308
> URL: https://issues.apache.org/jira/browse/HBASE-16308
> Project: HBase
>  Issue Type: Sub-task
>  Components: Protobufs
>Reporter: stack
>Assignee: stack
> Fix For: 2.0.0
>
> Attachments: HBASE-16308.master.001.patch, 
> HBASE-16308.master.002.patch, HBASE-16308.master.003.patch, 
> HBASE-16308.master.004.patch, HBASE-16308.master.005.patch, 
> HBASE-16308.master.006.patch, HBASE-16308.master.006.patch, 
> HBASE-16308.master.007.patch, HBASE-16308.master.008.patch, 
> HBASE-16308.master.009.patch
>
>
> Clean up our protobuf references so contained to just a few classes rather 
> than being spread about the codebase. Doing this work will make it easier 
> landing the parent issue and will make it more clear where the division 
> between shaded protobuf and unshaded protobuf lies (we need to continue with 
> unshaded protobuf for HDFS references by AsyncWAL and probably EndPoint 
> Coprocessors)



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (HBASE-16308) Contain protobuf references

2016-08-08 Thread Hadoop QA (JIRA)


[ 
https://issues.apache.org/jira/browse/HBASE-16308?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15412753#comment-15412753
 ] 

Hadoop QA commented on HBASE-16308:
---

| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 13m 31s 
{color} | {color:blue} Docker mode activated. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s 
{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m 
0s {color} | {color:green} The patch appears to include 11 new or modified test 
files. {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 3m 48s 
{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 8m 
23s {color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m 58s 
{color} | {color:green} master passed with JDK v1.8.0_101 {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 2m 17s 
{color} | {color:green} master passed with JDK v1.7.0_101 {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 2m 
46s {color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 1m 
43s {color} | {color:green} master passed {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 2m 2s 
{color} | {color:red} hbase-server in master has 1 extant Findbugs warnings. 
{color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m 28s 
{color} | {color:green} master passed with JDK v1.8.0_101 {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m 27s 
{color} | {color:green} master passed with JDK v1.7.0_101 {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 11s 
{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 2m 
32s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m 56s 
{color} | {color:green} the patch passed with JDK v1.8.0_101 {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 1m 56s 
{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 2m 16s 
{color} | {color:green} the patch passed with JDK v1.7.0_101 {color} |
| {color:red}-1{color} | {color:red} javac {color} | {color:red} 0m 35s {color} 
| {color:red} hbase-server-jdk1.7.0_101 with JDK v1.7.0_101 generated 2 new + 4 
unchanged - 2 fixed = 6 total (was 6) {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m 
28s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m 
55s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 
0s {color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green} 
28m 2s {color} | {color:green} Patch does not cause any errors with Hadoop 
2.4.0 2.4.1 2.5.0 2.5.1 2.5.2 2.6.1 2.6.2 2.6.3 2.7.1. {color} |
| {color:green}+1{color} | {color:green} hbaseprotoc {color} | {color:green} 0m 
58s {color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 1m 14s 
{color} | {color:red} hbase-client generated 1 new + 0 unchanged - 0 fixed = 1 
total (was 0) {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m 7s 
{color} | {color:green} the patch passed with JDK v1.8.0_101 {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m 26s 
{color} | {color:green} the patch passed with JDK v1.7.0_101 {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 1m 42s 
{color} | {color:green} hbase-common in the patch passed. {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 8m 15s {color} 
| {color:red} hbase-client in the patch failed. {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 24m 56s {color} 
| {color:red} hbase-server in the patch failed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 1m 8s 
{color} | {color:green} hbase-spark in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m 
42s {color} | {color:green} The patch does not generate ASF License

[jira] [Commented] (HBASE-16308) Contain protobuf references

2016-08-08 Thread stack (JIRA)


[ 
https://issues.apache.org/jira/browse/HBASE-16308?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15411913#comment-15411913
 ] 

stack commented on HBASE-16308:
---

That'd be great [~zghaobac]. In next version of this patch is a 
'NoncedRegionRetryCallable' that does the Nonce thing. I'd imagine reusing 
that... but let me land this first. It is taking a while getting it all right. 
Thanks.

> Contain protobuf references
> ---
>
> Key: HBASE-16308
> URL: https://issues.apache.org/jira/browse/HBASE-16308
> Project: HBase
>  Issue Type: Sub-task
>  Components: Protobufs
>Reporter: stack
>Assignee: stack
> Fix For: 2.0.0
>
> Attachments: HBASE-16308.master.001.patch, 
> HBASE-16308.master.002.patch, HBASE-16308.master.003.patch, 
> HBASE-16308.master.004.patch, HBASE-16308.master.005.patch, 
> HBASE-16308.master.006.patch, HBASE-16308.master.006.patch, 
> HBASE-16308.master.007.patch
>
>
> Clean up our protobuf references so contained to just a few classes rather 
> than being spread about the codebase. Doing this work will make it easier 
> landing the parent issue and will make it more clear where the division 
> between shaded protobuf and unshaded protobuf lies (we need to continue with 
> unshaded protobuf for HDFS references by AsyncWAL and probably EndPoint 
> Coprocessors)



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (HBASE-16308) Contain protobuf references

2016-08-08 Thread Guanghao Zhang (JIRA)


[ 
https://issues.apache.org/jira/browse/HBASE-16308?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15411599#comment-15411599
 ] 

Guanghao Zhang commented on HBASE-16308:


I will pick up HBASE-15588 to add nonce for checkAnd* operations.

> Contain protobuf references
> ---
>
> Key: HBASE-16308
> URL: https://issues.apache.org/jira/browse/HBASE-16308
> Project: HBase
>  Issue Type: Sub-task
>  Components: Protobufs
>Reporter: stack
>Assignee: stack
> Fix For: 2.0.0
>
> Attachments: HBASE-16308.master.001.patch, 
> HBASE-16308.master.002.patch, HBASE-16308.master.003.patch, 
> HBASE-16308.master.004.patch, HBASE-16308.master.005.patch, 
> HBASE-16308.master.006.patch, HBASE-16308.master.006.patch, 
> HBASE-16308.master.007.patch
>
>
> Clean up our protobuf references so contained to just a few classes rather 
> than being spread about the codebase. Doing this work will make it easier 
> landing the parent issue and will make it more clear where the division 
> between shaded protobuf and unshaded protobuf lies (we need to continue with 
> unshaded protobuf for HDFS references by AsyncWAL and probably EndPoint 
> Coprocessors)



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (HBASE-16308) Contain protobuf references

2016-08-07 Thread Hadoop QA (JIRA)


[ 
https://issues.apache.org/jira/browse/HBASE-16308?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15411163#comment-15411163
 ] 

Hadoop QA commented on HBASE-16308:
---

| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m 11s 
{color} | {color:blue} Docker mode activated. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s 
{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m 
0s {color} | {color:green} The patch appears to include 9 new or modified test 
files. {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 10s 
{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 3m 
19s {color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m 47s 
{color} | {color:green} master passed with JDK v1.8.0_101 {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 2m 16s 
{color} | {color:green} master passed with JDK v1.7.0_101 {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m 
28s {color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m 
56s {color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 4m 
18s {color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m 4s 
{color} | {color:green} master passed with JDK v1.8.0_101 {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m 23s 
{color} | {color:green} master passed with JDK v1.7.0_101 {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 11s 
{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 2m 
32s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m 46s 
{color} | {color:green} the patch passed with JDK v1.8.0_101 {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 1m 46s 
{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 2m 16s 
{color} | {color:green} the patch passed with JDK v1.7.0_101 {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 2m 16s 
{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m 
28s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m 
55s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 
0s {color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green} 
27m 26s {color} | {color:green} Patch does not cause any errors with Hadoop 
2.4.0 2.4.1 2.5.0 2.5.1 2.5.2 2.6.1 2.6.2 2.6.3 2.7.1. {color} |
| {color:green}+1{color} | {color:green} hbaseprotoc {color} | {color:green} 0m 
52s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 5m 
11s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m 21s 
{color} | {color:green} the patch passed with JDK v1.8.0_101 {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m 24s 
{color} | {color:green} the patch passed with JDK v1.7.0_101 {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 1m 42s 
{color} | {color:green} hbase-common in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m 59s 
{color} | {color:green} hbase-client in the patch passed. {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 95m 4s {color} 
| {color:red} hbase-server in the patch failed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 1m 16s 
{color} | {color:green} hbase-spark in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 1m 
5s {color} | {color:green} The patch does not generate ASF License warnings. 
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 163m 41s {color} 
| {color:black} {color} |
\\
\\
|| Reason || Tests ||
|

[jira] [Commented] (HBASE-16308) Contain protobuf references

2016-08-07 Thread stack (JIRA)


[ 
https://issues.apache.org/jira/browse/HBASE-16308?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15411107#comment-15411107
 ] 

stack commented on HBASE-16308:
---

New patch fixes the increment nonce issue. The test is new.  It came in with 
the HBASE_9899 commit. Came at about same time that this patch was going in so 
it did not show during qa builds. The test found a legit issue w/ my 
refactoring of nonce around increment. We need the [~zghaobac] fixup done below 
for append and increment done for all checkAnd* operations... its a nice one:

commit 975f0dd958debcdd842a95f8e9f7458689414fbf
Author: stack 
Date:   Thu Aug 4 12:40:19 2016 -0700

HBASE-9899 for idempotent operation dups, return the result instead of 
throwing conflict exception (Guanghao Zhang)

Lets see how the new patch does.

> Contain protobuf references
> ---
>
> Key: HBASE-16308
> URL: https://issues.apache.org/jira/browse/HBASE-16308
> Project: HBase
>  Issue Type: Sub-task
>  Components: Protobufs
>Reporter: stack
>Assignee: stack
> Fix For: 2.0.0
>
> Attachments: HBASE-16308.master.001.patch, 
> HBASE-16308.master.002.patch, HBASE-16308.master.003.patch, 
> HBASE-16308.master.004.patch, HBASE-16308.master.005.patch, 
> HBASE-16308.master.006.patch, HBASE-16308.master.006.patch, 
> HBASE-16308.master.007.patch
>
>
> Clean up our protobuf references so contained to just a few classes rather 
> than being spread about the codebase. Doing this work will make it easier 
> landing the parent issue and will make it more clear where the division 
> between shaded protobuf and unshaded protobuf lies (we need to continue with 
> unshaded protobuf for HDFS references by AsyncWAL and probably EndPoint 
> Coprocessors)



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (HBASE-16308) Contain protobuf references

2016-08-05 Thread Hudson (JIRA)


[ 
https://issues.apache.org/jira/browse/HBASE-16308?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15410421#comment-15410421
 ] 

Hudson commented on HBASE-16308:


FAILURE: Integrated in HBase-Trunk_matrix #1362 (See 
[https://builds.apache.org/job/HBase-Trunk_matrix/1362/])
Revert "HBASE-16308 Contain protobuf references Gather up the pb (stack: rev 
0206dc67d643e4a248a319c724cd6e58f0e77603)
* 
hbase-client/src/main/java/org/apache/hadoop/hbase/client/MasterKeepAliveConnection.java
* 
hbase-client/src/main/java/org/apache/hadoop/hbase/client/RetryingTimeTracker.java
* 
hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestClientTimeouts.java
* 
hbase-server/src/main/java/org/apache/hadoop/hbase/mob/ExpiredMobFileCleaner.java
* hbase-server/src/main/java/org/apache/hadoop/hbase/master/ServerManager.java
* 
hbase-client/src/main/java/org/apache/hadoop/hbase/client/RegionServerCallable.java
* 
hbase-server/src/main/java/org/apache/hadoop/hbase/mapreduce/LoadIncrementalHFiles.java
* 
hbase-client/src/main/java/org/apache/hadoop/hbase/client/MultiServerCallable.java
* 
hbase-client/src/main/java/org/apache/hadoop/hbase/client/RpcRetryingCaller.java
* 
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/RSRpcServices.java
* 
hbase-client/src/main/java/org/apache/hadoop/hbase/ipc/TimeLimitedRpcController.java
* 
hbase-client/src/main/java/org/apache/hadoop/hbase/client/ConnectionCallable.java
* 
hbase-client/src/main/java/org/apache/hadoop/hbase/client/PayloadCarryingServerCallable.java
* 
hbase-client/src/main/java/org/apache/hadoop/hbase/client/RpcRetryingCallable.java
* hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestAdmin2.java
* 
hbase-client/src/test/java/org/apache/hadoop/hbase/client/TestClientScanner.java
* 
hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestHRegionServerBulkLoad.java
* hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/RpcServer.java
* hbase-server/src/main/java/org/apache/hadoop/hbase/util/Merge.java
* hbase-server/src/main/java/org/apache/hadoop/hbase/mob/mapreduce/Sweeper.java
* 
hbase-client/src/main/java/org/apache/hadoop/hbase/client/ConnectionImplementation.java
* hbase-client/src/main/java/org/apache/hadoop/hbase/client/ClientScanner.java
* 
hbase-client/src/main/java/org/apache/hadoop/hbase/client/ReversedScannerCallable.java
* 
hbase-spark/src/main/java/org/apache/hadoop/hbase/spark/SparkSQLPushDownFilter.java
* 
hbase-client/src/main/java/org/apache/hadoop/hbase/client/ClientSimpleScanner.java
* 
hbase-client/src/main/java/org/apache/hadoop/hbase/client/RegionAdminServiceCallable.java
* 
hbase-client/src/main/java/org/apache/hadoop/hbase/ipc/MasterCoprocessorRpcChannel.java
* 
hbase-client/src/main/java/org/apache/hadoop/hbase/client/AbstractRegionServerCallable.java
* 
hbase-client/src/main/java/org/apache/hadoop/hbase/client/FlushRegionCallable.java
* 
hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestHRegionServerBulkLoadWithOldSecureEndpoint.java
* hbase-client/src/main/java/org/apache/hadoop/hbase/client/MasterCallable.java
* 
hbase-client/src/main/java/org/apache/hadoop/hbase/client/SecureBulkLoadClient.java
* hbase-client/src/main/java/org/apache/hadoop/hbase/protobuf/ProtobufUtil.java
* 
hbase-server/src/main/java/org/apache/hadoop/hbase/master/ExpiredMobFileCleanerChore.java
* hbase-client/src/main/java/org/apache/hadoop/hbase/client/HBaseAdmin.java
* hbase-common/src/main/java/org/apache/hadoop/hbase/util/ExceptionUtil.java
* hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestHCM.java
* 
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/WALEditsReplaySink.java
* 
hbase-client/src/main/java/org/apache/hadoop/hbase/client/RpcRetryingCallerWithReadReplicas.java
* 
hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestReplicaWithCluster.java
* 
hbase-client/src/main/java/org/apache/hadoop/hbase/ipc/PayloadCarryingRpcController.java
* 
hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestHRegionServerBulkLoadWithOldClient.java
* hbase-common/src/main/java/org/apache/hadoop/hbase/HBaseIOException.java
* 
hbase-client/src/main/java/org/apache/hadoop/hbase/ipc/RegionCoprocessorRpcChannel.java
* hbase-client/src/main/java/org/apache/hadoop/hbase/client/HTable.java
* 
hbase-client/src/main/java/org/apache/hadoop/hbase/client/RpcRetryingCallerFactory.java
* hbase-server/src/test/java/org/apache/hadoop/hbase/TestNamespace.java
* 
hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/RegionReplicaReplicationEndpoint.java
* 
hbase-client/src/main/java/org/apache/hadoop/hbase/client/ClientSmallScanner.java
* hbase-client/src/main/java/org/apache/hadoop/hbase/client/ScannerCallable.java


> Contain protobuf references
> ---
>
> Key: HBASE-16308
> URL: https://issues.apache.org/jira/browse/HBASE-16308
>

[jira] [Commented] (HBASE-16308) Contain protobuf references

2016-08-05 Thread stack (JIRA)


[ 
https://issues.apache.org/jira/browse/HBASE-16308?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15410176#comment-15410176
 ] 

stack commented on HBASE-16308:
---

Sorry about that [~apurtell]. Let me revert till I figure the failing test. 
Looked good in the test runs above. Must have skipped a bunch. Will look.

> Contain protobuf references
> ---
>
> Key: HBASE-16308
> URL: https://issues.apache.org/jira/browse/HBASE-16308
> Project: HBase
>  Issue Type: Sub-task
>  Components: Protobufs
>Reporter: stack
>Assignee: stack
> Fix For: 2.0.0
>
> Attachments: HBASE-16308.master.001.patch, 
> HBASE-16308.master.002.patch, HBASE-16308.master.003.patch, 
> HBASE-16308.master.004.patch, HBASE-16308.master.005.patch, 
> HBASE-16308.master.006.patch, HBASE-16308.master.006.patch
>
>
> Clean up our protobuf references so contained to just a few classes rather 
> than being spread about the codebase. Doing this work will make it easier 
> landing the parent issue and will make it more clear where the division 
> between shaded protobuf and unshaded protobuf lies (we need to continue with 
> unshaded protobuf for HDFS references by AsyncWAL and probably EndPoint 
> Coprocessors)



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (HBASE-16308) Contain protobuf references

2016-08-05 Thread Andrew Purtell (JIRA)


[ 
https://issues.apache.org/jira/browse/HBASE-16308?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15410169#comment-15410169
 ] 

Andrew Purtell commented on HBASE-16308:


If I go one rev back from this change, it's good. At this change, it's bad

> Contain protobuf references
> ---
>
> Key: HBASE-16308
> URL: https://issues.apache.org/jira/browse/HBASE-16308
> Project: HBase
>  Issue Type: Sub-task
>  Components: Protobufs
>Reporter: stack
>Assignee: stack
> Fix For: 2.0.0
>
> Attachments: HBASE-16308.master.001.patch, 
> HBASE-16308.master.002.patch, HBASE-16308.master.003.patch, 
> HBASE-16308.master.004.patch, HBASE-16308.master.005.patch, 
> HBASE-16308.master.006.patch, HBASE-16308.master.006.patch
>
>
> Clean up our protobuf references so contained to just a few classes rather 
> than being spread about the codebase. Doing this work will make it easier 
> landing the parent issue and will make it more clear where the division 
> between shaded protobuf and unshaded protobuf lies (we need to continue with 
> unshaded protobuf for HDFS references by AsyncWAL and probably EndPoint 
> Coprocessors)



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (HBASE-16308) Contain protobuf references

2016-08-05 Thread Hudson (JIRA)


[ 
https://issues.apache.org/jira/browse/HBASE-16308?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15409936#comment-15409936
 ] 

Hudson commented on HBASE-16308:


FAILURE: Integrated in HBase-Trunk_matrix #1360 (See 
[https://builds.apache.org/job/HBase-Trunk_matrix/1360/])
HBASE-16308 Contain protobuf references Gather up the pb references into 
(stack: rev ed87a81b4b61c4842c12572a47c97ae23773012f)
* 
hbase-client/src/main/java/org/apache/hadoop/hbase/ipc/RegionCoprocessorRpcChannel.java
* 
hbase-client/src/main/java/org/apache/hadoop/hbase/ipc/TimeLimitedRpcController.java
* 
hbase-server/src/main/java/org/apache/hadoop/hbase/mob/ExpiredMobFileCleaner.java
* 
hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestHRegionServerBulkLoadWithOldClient.java
* hbase-client/src/main/java/org/apache/hadoop/hbase/protobuf/ProtobufUtil.java
* hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/RpcServer.java
* hbase-client/src/main/java/org/apache/hadoop/hbase/client/HBaseAdmin.java
* 
hbase-client/src/main/java/org/apache/hadoop/hbase/client/AbstractRegionServerCallable.java
* 
hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestClientTimeouts.java
* 
hbase-server/src/main/java/org/apache/hadoop/hbase/mapreduce/LoadIncrementalHFiles.java
* 
hbase-client/src/main/java/org/apache/hadoop/hbase/client/RpcRetryingCallerFactory.java
* 
hbase-client/src/main/java/org/apache/hadoop/hbase/client/MultiServerCallable.java
* 
hbase-client/src/main/java/org/apache/hadoop/hbase/client/ClientSimpleScanner.java
* hbase-client/src/main/java/org/apache/hadoop/hbase/client/ScannerCallable.java
* 
hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestHRegionServerBulkLoadWithOldSecureEndpoint.java
* 
hbase-client/src/main/java/org/apache/hadoop/hbase/client/SecureBulkLoadClient.java
* hbase-server/src/main/java/org/apache/hadoop/hbase/util/Merge.java
* 
hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/RegionReplicaReplicationEndpoint.java
* 
hbase-client/src/main/java/org/apache/hadoop/hbase/client/RpcRetryingCaller.java
* 
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/RSRpcServices.java
* 
hbase-server/src/main/java/org/apache/hadoop/hbase/master/ExpiredMobFileCleanerChore.java
* hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestHCM.java
* 
hbase-client/src/main/java/org/apache/hadoop/hbase/client/ClientSmallScanner.java
* hbase-client/src/main/java/org/apache/hadoop/hbase/client/ClientScanner.java
* 
hbase-spark/src/main/java/org/apache/hadoop/hbase/spark/SparkSQLPushDownFilter.java
* 
hbase-client/src/main/java/org/apache/hadoop/hbase/ipc/MasterCoprocessorRpcChannel.java
* 
hbase-client/src/main/java/org/apache/hadoop/hbase/client/ConnectionImplementation.java
* hbase-client/src/main/java/org/apache/hadoop/hbase/client/MasterCallable.java
* 
hbase-client/src/main/java/org/apache/hadoop/hbase/client/RegionAdminServiceCallable.java
* hbase-server/src/test/java/org/apache/hadoop/hbase/TestNamespace.java
* 
hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestHRegionServerBulkLoad.java
* 
hbase-client/src/main/java/org/apache/hadoop/hbase/ipc/PayloadCarryingRpcController.java
* 
hbase-client/src/test/java/org/apache/hadoop/hbase/client/TestClientScanner.java
* 
hbase-client/src/main/java/org/apache/hadoop/hbase/client/RpcRetryingCallable.java
* 
hbase-client/src/main/java/org/apache/hadoop/hbase/client/RegionServerCallable.java
* 
hbase-client/src/main/java/org/apache/hadoop/hbase/client/RpcRetryingCallerWithReadReplicas.java
* hbase-client/src/main/java/org/apache/hadoop/hbase/client/HTable.java
* 
hbase-client/src/main/java/org/apache/hadoop/hbase/client/FlushRegionCallable.java
* 
hbase-client/src/main/java/org/apache/hadoop/hbase/client/ConnectionCallable.java
* hbase-common/src/main/java/org/apache/hadoop/hbase/HBaseIOException.java
* hbase-server/src/main/java/org/apache/hadoop/hbase/master/ServerManager.java
* hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestAdmin2.java
* 
hbase-client/src/main/java/org/apache/hadoop/hbase/client/RetryingTimeTracker.java
* hbase-common/src/main/java/org/apache/hadoop/hbase/util/ExceptionUtil.java
* 
hbase-client/src/main/java/org/apache/hadoop/hbase/client/ReversedScannerCallable.java
* 
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/WALEditsReplaySink.java
* 
hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestReplicaWithCluster.java
* hbase-server/src/main/java/org/apache/hadoop/hbase/mob/mapreduce/Sweeper.java
* 
hbase-client/src/main/java/org/apache/hadoop/hbase/client/MasterKeepAliveConnection.java
* 
hbase-client/src/main/java/org/apache/hadoop/hbase/client/PayloadCarryingServerCallable.java


> Contain protobuf references
> ---
>
> Key: HBASE-16308
> URL: https://issues.apache.org/jira/browse/HBASE-16308
>

[jira] [Commented] (HBASE-16308) Contain protobuf references

2016-08-05 Thread Anoop Sam John (JIRA)


[ 
https://issues.apache.org/jira/browse/HBASE-16308?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15408931#comment-15408931
 ] 

Anoop Sam John commented on HBASE-16308:


Started going through the patch. It is big. :-)  Wl finish soon Stack

> Contain protobuf references
> ---
>
> Key: HBASE-16308
> URL: https://issues.apache.org/jira/browse/HBASE-16308
> Project: HBase
>  Issue Type: Sub-task
>  Components: Protobufs
>Reporter: stack
>Assignee: stack
> Attachments: HBASE-16308.master.001.patch, 
> HBASE-16308.master.002.patch, HBASE-16308.master.003.patch, 
> HBASE-16308.master.004.patch, HBASE-16308.master.005.patch, 
> HBASE-16308.master.006.patch, HBASE-16308.master.006.patch
>
>
> Clean up our protobuf references so contained to just a few classes rather 
> than being spread about the codebase. Doing this work will make it easier 
> landing the parent issue and will make it more clear where the division 
> between shaded protobuf and unshaded protobuf lies (we need to continue with 
> unshaded protobuf for HDFS references by AsyncWAL and probably EndPoint 
> Coprocessors)



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (HBASE-16308) Contain protobuf references

2016-08-04 Thread stack (JIRA)


[ 
https://issues.apache.org/jira/browse/HBASE-16308?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15408423#comment-15408423
 ] 

stack commented on HBASE-16308:
---

Yeah, TestLogLevel is unrelated. Reviews? You good w/ this [~anoop.hbase] and 
[~ram_krish].

Will work on the parent issue now again.

> Contain protobuf references
> ---
>
> Key: HBASE-16308
> URL: https://issues.apache.org/jira/browse/HBASE-16308
> Project: HBase
>  Issue Type: Sub-task
>  Components: Protobufs
>Reporter: stack
>Assignee: stack
> Attachments: HBASE-16308.master.001.patch, 
> HBASE-16308.master.002.patch, HBASE-16308.master.003.patch, 
> HBASE-16308.master.004.patch, HBASE-16308.master.005.patch, 
> HBASE-16308.master.006.patch, HBASE-16308.master.006.patch
>
>
> Clean up our protobuf references so contained to just a few classes rather 
> than being spread about the codebase. Doing this work will make it easier 
> landing the parent issue and will make it more clear where the division 
> between shaded protobuf and unshaded protobuf lies (we need to continue with 
> unshaded protobuf for HDFS references by AsyncWAL and probably EndPoint 
> Coprocessors)



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (HBASE-16308) Contain protobuf references

2016-08-04 Thread stack (JIRA)


[ 
https://issues.apache.org/jira/browse/HBASE-16308?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15408204#comment-15408204
 ] 

stack commented on HBASE-16308:
---

Stuff passes locally of course. It started failing for all recent trunk builds. 
Seems to have started here:

Failed Build #1351 (Aug 4, 2016 5:25:17 AM)

add description
Build Artifacts
Changes
HBASE-16350 Undo server abort from HBASE-14968 (detail)
HBASE-16317 revert all ESAPI changes (detail)
HBASE-15574 Fix typo in HRegionServerCommandLine (detail)

Started by upstream project HBase-Trunk_matrix build number 1351
originally caused by:

Started by timer

This run spent:

1 hr 7 min waiting in the queue;
32 min building on an executor;
1 hr 40 min total from scheduled to completion.
Revision: 0eaf3edc3acee3273126bd9a575401fcf85971b8
refs/remotes/origin/master
Test Result (1 failure / ±0)
org.apache.hadoop.hbase.http.log.TestLogLevel.testDynamicLogLevel

I can look at this separately.

> Contain protobuf references
> ---
>
> Key: HBASE-16308
> URL: https://issues.apache.org/jira/browse/HBASE-16308
> Project: HBase
>  Issue Type: Sub-task
>  Components: Protobufs
>Reporter: stack
>Assignee: stack
> Attachments: HBASE-16308.master.001.patch, 
> HBASE-16308.master.002.patch, HBASE-16308.master.003.patch, 
> HBASE-16308.master.004.patch, HBASE-16308.master.005.patch, 
> HBASE-16308.master.006.patch
>
>
> Clean up our protobuf references so contained to just a few classes rather 
> than being spread about the codebase. Doing this work will make it easier 
> landing the parent issue and will make it more clear where the division 
> between shaded protobuf and unshaded protobuf lies (we need to continue with 
> unshaded protobuf for HDFS references by AsyncWAL and probably EndPoint 
> Coprocessors)



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (HBASE-16308) Contain protobuf references

2016-08-04 Thread stack (JIRA)


[ 
https://issues.apache.org/jira/browse/HBASE-16308?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15408194#comment-15408194
 ] 

stack commented on HBASE-16308:
---

This is interesting failure:

Caused by: java.lang.ClassNotFoundException: 
org.apache.commons.httpclient.URIException
at java.net.URLClassLoader$1.run(URLClassLoader.java:366)
at java.net.URLClassLoader$1.run(URLClassLoader.java:355)
at java.security.AccessController.doPrivileged(Native Method)
at java.net.URLClassLoader.findClass(URLClassLoader.java:354)
at java.lang.ClassLoader.loadClass(ClassLoader.java:425)
at sun.misc.Launcher$AppClassLoader.loadClass(Launcher.java:308)
at java.lang.ClassLoader.loadClass(ClassLoader.java:358)
... 26 more

Looking for changes to httpserver .

> Contain protobuf references
> ---
>
> Key: HBASE-16308
> URL: https://issues.apache.org/jira/browse/HBASE-16308
> Project: HBase
>  Issue Type: Sub-task
>  Components: Protobufs
>Reporter: stack
>Assignee: stack
> Attachments: HBASE-16308.master.001.patch, 
> HBASE-16308.master.002.patch, HBASE-16308.master.003.patch, 
> HBASE-16308.master.004.patch, HBASE-16308.master.005.patch, 
> HBASE-16308.master.006.patch
>
>
> Clean up our protobuf references so contained to just a few classes rather 
> than being spread about the codebase. Doing this work will make it easier 
> landing the parent issue and will make it more clear where the division 
> between shaded protobuf and unshaded protobuf lies (we need to continue with 
> unshaded protobuf for HDFS references by AsyncWAL and probably EndPoint 
> Coprocessors)



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (HBASE-16308) Contain protobuf references

2016-08-04 Thread Hadoop QA (JIRA)


[ 
https://issues.apache.org/jira/browse/HBASE-16308?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15408161#comment-15408161
 ] 

Hadoop QA commented on HBASE-16308:
---

| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m 
0s {color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s 
{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m 
0s {color} | {color:green} The patch appears to include 9 new or modified test 
files. {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 10s 
{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 3m 
29s {color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 2m 26s 
{color} | {color:green} master passed with JDK v1.8.0 {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 2m 21s 
{color} | {color:green} master passed with JDK v1.7.0_80 {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m 
30s {color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 1m 
5s {color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 4m 
29s {color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m 28s 
{color} | {color:green} master passed with JDK v1.8.0 {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m 23s 
{color} | {color:green} master passed with JDK v1.7.0_80 {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 10s 
{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 2m 
35s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 2m 33s 
{color} | {color:green} the patch passed with JDK v1.8.0 {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 2m 33s 
{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 2m 21s 
{color} | {color:green} the patch passed with JDK v1.7.0_80 {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 2m 21s 
{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m 
31s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 1m 
5s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 
0s {color} | {color:green} Patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green} 
32m 6s {color} | {color:green} Patch does not cause any errors with Hadoop 
2.4.0 2.4.1 2.5.0 2.5.1 2.5.2 2.6.1 2.6.2 2.6.3 2.7.1. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 5m 
32s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m 19s 
{color} | {color:green} the patch passed with JDK v1.8.0 {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m 23s 
{color} | {color:green} the patch passed with JDK v1.7.0_80 {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 1m 48s 
{color} | {color:green} hbase-common in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 1m 1s 
{color} | {color:green} hbase-client in the patch passed. {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 16m 17s {color} 
| {color:red} hbase-server in the patch failed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 1m 15s 
{color} | {color:green} hbase-spark in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m 
36s {color} | {color:green} Patch does not generate ASF License warnings. 
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 91m 12s {color} 
| {color:black} {color} |
\\
\\
|| Reason || Tests ||
| Failed junit tests | hadoop.hbase.http.log.TestLogLevel |
\\
\\
|| Subsystem || Report/Notes ||
| JIRA Patch URL |

[jira] [Commented] (HBASE-16308) Contain protobuf references

2016-08-04 Thread stack (JIRA)


[ 
https://issues.apache.org/jira/browse/HBASE-16308?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15407973#comment-15407973
 ] 

stack commented on HBASE-16308:
---

The TestLogLevel failure is because httpserver did not deploy. The 
TestClient... failure is real (failed to handle a mocked usage).

This is ready for review. It is mostly applying a boring pattern. Thanks.

> Contain protobuf references
> ---
>
> Key: HBASE-16308
> URL: https://issues.apache.org/jira/browse/HBASE-16308
> Project: HBase
>  Issue Type: Sub-task
>  Components: Protobufs
>Reporter: stack
>Assignee: stack
> Attachments: HBASE-16308.master.001.patch, 
> HBASE-16308.master.002.patch, HBASE-16308.master.003.patch, 
> HBASE-16308.master.004.patch, HBASE-16308.master.005.patch, 
> HBASE-16308.master.006.patch
>
>
> Clean up our protobuf references so contained to just a few classes rather 
> than being spread about the codebase. Doing this work will make it easier 
> landing the parent issue and will make it more clear where the division 
> between shaded protobuf and unshaded protobuf lies (we need to continue with 
> unshaded protobuf for HDFS references by AsyncWAL and probably EndPoint 
> Coprocessors)



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (HBASE-16308) Contain protobuf references

2016-08-04 Thread Hadoop QA (JIRA)


[ 
https://issues.apache.org/jira/browse/HBASE-16308?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15407428#comment-15407428
 ] 

Hadoop QA commented on HBASE-16308:
---

| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m 
0s {color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s 
{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m 
0s {color} | {color:green} The patch appears to include 8 new or modified test 
files. {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 36s 
{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 3m 
41s {color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 2m 35s 
{color} | {color:green} master passed with JDK v1.8.0 {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 2m 25s 
{color} | {color:green} master passed with JDK v1.7.0_80 {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m 
31s {color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 1m 
6s {color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 4m 
37s {color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m 38s 
{color} | {color:green} master passed with JDK v1.8.0 {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m 23s 
{color} | {color:green} master passed with JDK v1.7.0_80 {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 9s 
{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 2m 
39s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 2m 35s 
{color} | {color:green} the patch passed with JDK v1.8.0 {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 2m 35s 
{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 2m 23s 
{color} | {color:green} the patch passed with JDK v1.7.0_80 {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 2m 23s 
{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m 
30s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 1m 
6s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 
0s {color} | {color:green} Patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green} 
31m 54s {color} | {color:green} Patch does not cause any errors with Hadoop 
2.4.0 2.4.1 2.5.0 2.5.1 2.5.2 2.6.1 2.6.2 2.6.3 2.7.1. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 5m 
25s {color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} javadoc {color} | {color:red} 2m 36s 
{color} | {color:red} hbase-client-jdk1.8.0 with JDK v1.8.0 generated 2 new + 
13 unchanged - 0 fixed = 15 total (was 13) {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m 37s 
{color} | {color:green} the patch passed with JDK v1.8.0 {color} |
| {color:red}-1{color} | {color:red} javadoc {color} | {color:red} 3m 58s 
{color} | {color:red} hbase-client-jdk1.7.0_80 with JDK v1.7.0_80 generated 2 
new + 13 unchanged - 0 fixed = 15 total (was 13) {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m 22s 
{color} | {color:green} the patch passed with JDK v1.7.0_80 {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 1m 49s 
{color} | {color:green} hbase-common in the patch passed. {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 1m 5s {color} | 
{color:red} hbase-client in the patch failed. {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 17m 22s {color} 
| {color:red} hbase-server in the patch failed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 1m 13s 
{color} | {color:green} hbase-spark in the patch passed. {color} |
| {color:green}+1{color} |

[jira] [Commented] (HBASE-16308) Contain protobuf references

2016-08-04 Thread stack (JIRA)


[ 
https://issues.apache.org/jira/browse/HBASE-16308?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15407229#comment-15407229
 ] 

stack commented on HBASE-16308:
---

Fix findbugs and fix that should take care of failing tests (I forgot to handle 
ServiceException in handleException in ProtobufUtil

> Contain protobuf references
> ---
>
> Key: HBASE-16308
> URL: https://issues.apache.org/jira/browse/HBASE-16308
> Project: HBase
>  Issue Type: Sub-task
>  Components: Protobufs
>Reporter: stack
>Assignee: stack
> Attachments: HBASE-16308.master.001.patch, 
> HBASE-16308.master.002.patch, HBASE-16308.master.003.patch, 
> HBASE-16308.master.004.patch, HBASE-16308.master.005.patch
>
>
> Clean up our protobuf references so contained to just a few classes rather 
> than being spread about the codebase. Doing this work will make it easier 
> landing the parent issue and will make it more clear where the division 
> between shaded protobuf and unshaded protobuf lies (we need to continue with 
> unshaded protobuf for HDFS references by AsyncWAL and probably EndPoint 
> Coprocessors)



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (HBASE-16308) Contain protobuf references

2016-08-03 Thread Hadoop QA (JIRA)


[ 
https://issues.apache.org/jira/browse/HBASE-16308?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15407055#comment-15407055
 ] 

Hadoop QA commented on HBASE-16308:
---

| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m 
0s {color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s 
{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m 
0s {color} | {color:green} The patch appears to include 7 new or modified test 
files. {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 30s 
{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 3m 
56s {color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 2m 29s 
{color} | {color:green} master passed with JDK v1.8.0 {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 2m 22s 
{color} | {color:green} master passed with JDK v1.7.0_80 {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m 
49s {color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 1m 
24s {color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 4m 
33s {color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m 39s 
{color} | {color:green} master passed with JDK v1.8.0 {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m 22s 
{color} | {color:green} master passed with JDK v1.7.0_80 {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 10s 
{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 2m 
36s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 2m 28s 
{color} | {color:green} the patch passed with JDK v1.8.0 {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 2m 28s 
{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 2m 23s 
{color} | {color:green} the patch passed with JDK v1.7.0_80 {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 2m 23s 
{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m 
31s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 1m 
7s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 
0s {color} | {color:green} Patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green} 
31m 44s {color} | {color:green} Patch does not cause any errors with Hadoop 
2.4.0 2.4.1 2.5.0 2.5.1 2.5.2 2.6.1 2.6.2 2.6.3 2.7.1. {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 1m 12s 
{color} | {color:red} hbase-client generated 1 new + 0 unchanged - 0 fixed = 1 
total (was 0) {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m 25s 
{color} | {color:green} the patch passed with JDK v1.8.0 {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m 22s 
{color} | {color:green} the patch passed with JDK v1.7.0_80 {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 1m 46s 
{color} | {color:green} hbase-common in the patch passed. {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 0m 58s {color} 
| {color:red} hbase-client in the patch failed. {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 96m 7s {color} 
| {color:red} hbase-server in the patch failed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 2m 11s 
{color} | {color:green} hbase-spark in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 1m 
10s {color} | {color:green} Patch does not generate ASF License warnings. 
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 173m 48s {color} 
| {color:black} {color} |
\\
\\
|| Reason || Tests ||
| FindBugs | module:hbase-client |
|  |  Switch statement found in

[jira] [Commented] (HBASE-16308) Contain protobuf references

2016-07-31 Thread stack (JIRA)


[ 
https://issues.apache.org/jira/browse/HBASE-16308?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15401445#comment-15401445
 ] 

stack commented on HBASE-16308:
---

Uploaded a partially done patch. Patch includes refactor of 
RegionServerCallable that allows me clean up a bunch of boilerplate in HTable 
([~mbertozzi] helped me come up w/ the pattern subsequently applied in HTable). 
Patch is not finished. Need to do same elsewhere.

> Contain protobuf references
> ---
>
> Key: HBASE-16308
> URL: https://issues.apache.org/jira/browse/HBASE-16308
> Project: HBase
>  Issue Type: Sub-task
>  Components: Protobufs
>Reporter: stack
>Assignee: stack
> Attachments: HBASE-16308.master.001.patch
>
>
> Clean up our protobuf references so contained to just a few classes rather 
> than being spread about the codebase. Doing this work will make it easier 
> landing the parent issue and will make it more clear where the division 
> between shaded protobuf and unshaded protobuf lies (we need to continue with 
> unshaded protobuf for HDFS references by AsyncWAL and probably EndPoint 
> Coprocessors)



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (HBASE-16308) Contain protobuf references

[jira] [Commented] (HBASE-16308) Contain protobuf references

[jira] [Commented] (HBASE-16308) Contain protobuf references

[jira] [Commented] (HBASE-16308) Contain protobuf references

[jira] [Commented] (HBASE-16308) Contain protobuf references

[jira] [Commented] (HBASE-16308) Contain protobuf references

[jira] [Commented] (HBASE-16308) Contain protobuf references

[jira] [Commented] (HBASE-16308) Contain protobuf references

[jira] [Commented] (HBASE-16308) Contain protobuf references

[jira] [Commented] (HBASE-16308) Contain protobuf references

[jira] [Commented] (HBASE-16308) Contain protobuf references

[jira] [Commented] (HBASE-16308) Contain protobuf references

[jira] [Commented] (HBASE-16308) Contain protobuf references

[jira] [Commented] (HBASE-16308) Contain protobuf references

[jira] [Commented] (HBASE-16308) Contain protobuf references

[jira] [Commented] (HBASE-16308) Contain protobuf references

[jira] [Commented] (HBASE-16308) Contain protobuf references

[jira] [Commented] (HBASE-16308) Contain protobuf references

[jira] [Commented] (HBASE-16308) Contain protobuf references

[jira] [Commented] (HBASE-16308) Contain protobuf references

[jira] [Commented] (HBASE-16308) Contain protobuf references

[jira] [Commented] (HBASE-16308) Contain protobuf references

[jira] [Commented] (HBASE-16308) Contain protobuf references

[jira] [Commented] (HBASE-16308) Contain protobuf references

[jira] [Commented] (HBASE-16308) Contain protobuf references

[jira] [Commented] (HBASE-16308) Contain protobuf references

[jira] [Commented] (HBASE-16308) Contain protobuf references

[jira] [Commented] (HBASE-16308) Contain protobuf references

[jira] [Commented] (HBASE-16308) Contain protobuf references

[jira] [Commented] (HBASE-16308) Contain protobuf references

[jira] [Commented] (HBASE-16308) Contain protobuf references

31 matches

Site Navigation

Mail list logo

Footer information