[jira] [Commented] (HBASE-19057) Fix other code review comments about FilterList Improvement
[ https://issues.apache.org/jira/browse/HBASE-19057?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16219072#comment-16219072 ] Hudson commented on HBASE-19057: FAILURE: Integrated in Jenkins build HBase-2.0 #748 (See [https://builds.apache.org/job/HBase-2.0/748/]) HBASE-19057 Fix other code review comments about FilterList improvement (zhangduo: rev c2dbef1465de18767948a092f26d836e45d91ded) * (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/filter/TestFilterList.java * (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/filter/FilterListWithOR.java * (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/filter/FilterListBase.java * (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/filter/FilterList.java * (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/filter/FilterListWithAND.java > Fix other code review comments about FilterList Improvement > --- > > Key: HBASE-19057 > URL: https://issues.apache.org/jira/browse/HBASE-19057 > Project: HBase > Issue Type: Sub-task > Components: Filters >Reporter: Zheng Hu >Assignee: Zheng Hu >Priority: Blocker > Fix For: 2.0.0-alpha-4 > > Attachments: HBASE-19057-HBASE-18410.v1.patch, > HBASE-19057-HBASE-18410.v2.patch, HBASE-19057-HBASE-18410.v3.patch, > HBASE-19057-HBASE-18410.v4.patch, HBASE-19057-HBASE-18410.v4.patch, > HBASE-19057-HBASE-18410.v4.patch, HBASE-19057-HBASE-18410.v5.patch, > HBASE-19057-HBASE-18410.v5.patch, HBASE-19057-HBASE-18410.v5.patch, > HBASE-19057-HBASE-18410.v5.patch > > > Open this issue to fix conflict , run HadoopQA and gather other feedback. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-19057) Fix other code review comments about FilterList Improvement
[ https://issues.apache.org/jira/browse/HBASE-19057?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16218503#comment-16218503 ] Duo Zhang commented on HBASE-19057: --- Just done a rebase. It is clean so I think it is safe to just merge it back to master? Thanks. > Fix other code review comments about FilterList Improvement > --- > > Key: HBASE-19057 > URL: https://issues.apache.org/jira/browse/HBASE-19057 > Project: HBase > Issue Type: Sub-task > Components: Filters >Reporter: Zheng Hu >Assignee: Zheng Hu >Priority: Blocker > Fix For: 2.0.0-alpha-4 > > Attachments: HBASE-19057-HBASE-18410.v1.patch, > HBASE-19057-HBASE-18410.v2.patch, HBASE-19057-HBASE-18410.v3.patch, > HBASE-19057-HBASE-18410.v4.patch, HBASE-19057-HBASE-18410.v4.patch, > HBASE-19057-HBASE-18410.v4.patch, HBASE-19057-HBASE-18410.v5.patch, > HBASE-19057-HBASE-18410.v5.patch, HBASE-19057-HBASE-18410.v5.patch, > HBASE-19057-HBASE-18410.v5.patch > > > Open this issue to fix conflict , run HadoopQA and gather other feedback. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-19057) Fix other code review comments about FilterList Improvement
[
https://issues.apache.org/jira/browse/HBASE-19057?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16218168#comment-16218168
]
Hadoop QA commented on HBASE-19057:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
18s{color} | {color:blue} Docker mode activated. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 1 new or modified test
files. {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 1m
36s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 5m
57s{color} | {color:green} HBASE-18410 passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
51s{color} | {color:green} HBASE-18410 passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
49s{color} | {color:green} HBASE-18410 passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
36s{color} | {color:green} HBASE-18410 passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 5m
4s{color} | {color:green} branch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 3m
3s{color} | {color:green} HBASE-18410 passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
47s{color} | {color:green} HBASE-18410 passed {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
17s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 3m
44s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
54s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
53s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
45s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
25s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 3m
43s{color} | {color:green} patch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
37m 59s{color} | {color:green} Patch does not cause any errors with Hadoop
2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3 or 3.0.0-alpha4. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 3m
32s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
40s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 2m
40s{color} | {color:green} hbase-client in the patch passed. {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red}126m 48s{color}
| {color:red} hbase-server in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 1m
35s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}197m 52s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:cb5c477 |
| JIRA Issue | HBASE-19057 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12893858/HBASE-19057-HBASE-18410.v5.patch
|
| Optional Tests | asflicense javac javadoc unit findbugs shadedjars
hadoopcheck hbaseanti checkstyle compile |
| uname | Linux 16524649a124 4.4.0-43-generic #63-Ubuntu SMP Wed Oct 12
13:48:03 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh
|
| git revision | HBASE-18410 / b
[jira] [Commented] (HBASE-19057) Fix other code review comments about FilterList Improvement
[ https://issues.apache.org/jira/browse/HBASE-19057?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16218163#comment-16218163 ] Zheng Hu commented on HBASE-19057: -- [~Apache9], I've committed this patch into branch HBASE-18410, you can do the rebase now .. > Fix other code review comments about FilterList Improvement > --- > > Key: HBASE-19057 > URL: https://issues.apache.org/jira/browse/HBASE-19057 > Project: HBase > Issue Type: Sub-task > Components: Filters >Reporter: Zheng Hu >Assignee: Zheng Hu >Priority: Blocker > Fix For: 2.0.0-alpha-4 > > Attachments: HBASE-19057-HBASE-18410.v1.patch, > HBASE-19057-HBASE-18410.v2.patch, HBASE-19057-HBASE-18410.v3.patch, > HBASE-19057-HBASE-18410.v4.patch, HBASE-19057-HBASE-18410.v4.patch, > HBASE-19057-HBASE-18410.v4.patch, HBASE-19057-HBASE-18410.v5.patch, > HBASE-19057-HBASE-18410.v5.patch, HBASE-19057-HBASE-18410.v5.patch, > HBASE-19057-HBASE-18410.v5.patch > > > Open this issue to fix conflict , run HadoopQA and gather other feedback. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-19057) Fix other code review comments about FilterList Improvement
[ https://issues.apache.org/jira/browse/HBASE-19057?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16218058#comment-16218058 ] stack commented on HBASE-19057: --- bq. I've updated the release note with more details about the bug fix, I think it's enough. It looks good. bq. So let's commit the latest patch.v5 into branch HBASE-18410, and do the rebase ... Yes. No harm in doing concurrently what [~Apache9] said of hacking up a patch of all here to run against master in the mean time (I think thats what he suggests above). > Fix other code review comments about FilterList Improvement > --- > > Key: HBASE-19057 > URL: https://issues.apache.org/jira/browse/HBASE-19057 > Project: HBase > Issue Type: Sub-task > Components: Filters >Reporter: Zheng Hu >Assignee: Zheng Hu >Priority: Blocker > Fix For: 2.0.0-alpha-4 > > Attachments: HBASE-19057-HBASE-18410.v1.patch, > HBASE-19057-HBASE-18410.v2.patch, HBASE-19057-HBASE-18410.v3.patch, > HBASE-19057-HBASE-18410.v4.patch, HBASE-19057-HBASE-18410.v4.patch, > HBASE-19057-HBASE-18410.v4.patch, HBASE-19057-HBASE-18410.v5.patch, > HBASE-19057-HBASE-18410.v5.patch, HBASE-19057-HBASE-18410.v5.patch, > HBASE-19057-HBASE-18410.v5.patch > > > Open this issue to fix conflict , run HadoopQA and gather other feedback. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-19057) Fix other code review comments about FilterList Improvement
[ https://issues.apache.org/jira/browse/HBASE-19057?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16218055#comment-16218055 ] Zheng Hu commented on HBASE-19057: -- bq. Can fix the mis-comment on commit. I've fixed the comment what Ted point out in the latest patch.v5 , you can see that. bq. Does the release note here have enough on what is different between hbase1 and hbase2? I've updated the release note with more details about the bug fix, I think it's enough. So let's commit the latest patch.v5 into branch HBASE-18410, and do the rebase ... > Fix other code review comments about FilterList Improvement > --- > > Key: HBASE-19057 > URL: https://issues.apache.org/jira/browse/HBASE-19057 > Project: HBase > Issue Type: Sub-task > Components: Filters >Reporter: Zheng Hu >Assignee: Zheng Hu >Priority: Blocker > Fix For: 2.0.0-alpha-4 > > Attachments: HBASE-19057-HBASE-18410.v1.patch, > HBASE-19057-HBASE-18410.v2.patch, HBASE-19057-HBASE-18410.v3.patch, > HBASE-19057-HBASE-18410.v4.patch, HBASE-19057-HBASE-18410.v4.patch, > HBASE-19057-HBASE-18410.v4.patch, HBASE-19057-HBASE-18410.v5.patch, > HBASE-19057-HBASE-18410.v5.patch, HBASE-19057-HBASE-18410.v5.patch, > HBASE-19057-HBASE-18410.v5.patch > > > Open this issue to fix conflict , run HadoopQA and gather other feedback. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-19057) Fix other code review comments about FilterList Improvement
[ https://issues.apache.org/jira/browse/HBASE-19057?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16218020#comment-16218020 ] stack commented on HBASE-19057: --- Don't bother with the VOTE thread. Let me add to the end of the DISCUSS that we'll just merge, not VOTE. > Fix other code review comments about FilterList Improvement > --- > > Key: HBASE-19057 > URL: https://issues.apache.org/jira/browse/HBASE-19057 > Project: HBase > Issue Type: Sub-task > Components: Filters >Reporter: Zheng Hu >Assignee: Zheng Hu >Priority: Blocker > Fix For: 2.0.0-alpha-4 > > Attachments: HBASE-19057-HBASE-18410.v1.patch, > HBASE-19057-HBASE-18410.v2.patch, HBASE-19057-HBASE-18410.v3.patch, > HBASE-19057-HBASE-18410.v4.patch, HBASE-19057-HBASE-18410.v4.patch, > HBASE-19057-HBASE-18410.v4.patch, HBASE-19057-HBASE-18410.v5.patch, > HBASE-19057-HBASE-18410.v5.patch, HBASE-19057-HBASE-18410.v5.patch, > HBASE-19057-HBASE-18410.v5.patch > > > Open this issue to fix conflict , run HadoopQA and gather other feedback. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-19057) Fix other code review comments about FilterList Improvement
[ https://issues.apache.org/jira/browse/HBASE-19057?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16218015#comment-16218015 ] Duo Zhang commented on HBASE-19057: --- [~openinx] Let's commit the patch here. And then I will do a final rebase. We can then attach a dumb patch here to just trigger a pre commit to see if everything is OK.Then we can start the vote thread in the dev list to see if we can get enough +1s. I think it is enough, [~stack] [~anoopsamjohn] [~tedyu] and me. Thanks. > Fix other code review comments about FilterList Improvement > --- > > Key: HBASE-19057 > URL: https://issues.apache.org/jira/browse/HBASE-19057 > Project: HBase > Issue Type: Sub-task > Components: Filters >Reporter: Zheng Hu >Assignee: Zheng Hu >Priority: Blocker > Fix For: 2.0.0-alpha-4 > > Attachments: HBASE-19057-HBASE-18410.v1.patch, > HBASE-19057-HBASE-18410.v2.patch, HBASE-19057-HBASE-18410.v3.patch, > HBASE-19057-HBASE-18410.v4.patch, HBASE-19057-HBASE-18410.v4.patch, > HBASE-19057-HBASE-18410.v4.patch, HBASE-19057-HBASE-18410.v5.patch, > HBASE-19057-HBASE-18410.v5.patch, HBASE-19057-HBASE-18410.v5.patch, > HBASE-19057-HBASE-18410.v5.patch > > > Open this issue to fix conflict , run HadoopQA and gather other feedback. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-19057) Fix other code review comments about FilterList Improvement
[ https://issues.apache.org/jira/browse/HBASE-19057?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16218012#comment-16218012 ] stack commented on HBASE-19057: --- [~openinx] Push. Can fix the mis-comment on commit. If [~Apache9] can't do it, just say and I can. When we going to do the merge! Thanks. > Fix other code review comments about FilterList Improvement > --- > > Key: HBASE-19057 > URL: https://issues.apache.org/jira/browse/HBASE-19057 > Project: HBase > Issue Type: Sub-task > Components: Filters >Reporter: Zheng Hu >Assignee: Zheng Hu >Priority: Blocker > Fix For: 2.0.0-alpha-4 > > Attachments: HBASE-19057-HBASE-18410.v1.patch, > HBASE-19057-HBASE-18410.v2.patch, HBASE-19057-HBASE-18410.v3.patch, > HBASE-19057-HBASE-18410.v4.patch, HBASE-19057-HBASE-18410.v4.patch, > HBASE-19057-HBASE-18410.v4.patch, HBASE-19057-HBASE-18410.v5.patch, > HBASE-19057-HBASE-18410.v5.patch, HBASE-19057-HBASE-18410.v5.patch, > HBASE-19057-HBASE-18410.v5.patch > > > Open this issue to fix conflict , run HadoopQA and gather other feedback. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-19057) Fix other code review comments about FilterList Improvement
[ https://issues.apache.org/jira/browse/HBASE-19057?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16218004#comment-16218004 ] Ted Yu commented on HBASE-19057: I have no other comment for this JIRA. > Fix other code review comments about FilterList Improvement > --- > > Key: HBASE-19057 > URL: https://issues.apache.org/jira/browse/HBASE-19057 > Project: HBase > Issue Type: Sub-task > Components: Filters >Reporter: Zheng Hu >Assignee: Zheng Hu >Priority: Blocker > Fix For: 2.0.0-alpha-4 > > Attachments: HBASE-19057-HBASE-18410.v1.patch, > HBASE-19057-HBASE-18410.v2.patch, HBASE-19057-HBASE-18410.v3.patch, > HBASE-19057-HBASE-18410.v4.patch, HBASE-19057-HBASE-18410.v4.patch, > HBASE-19057-HBASE-18410.v4.patch, HBASE-19057-HBASE-18410.v5.patch, > HBASE-19057-HBASE-18410.v5.patch, HBASE-19057-HBASE-18410.v5.patch, > HBASE-19057-HBASE-18410.v5.patch > > > Open this issue to fix conflict , run HadoopQA and gather other feedback. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-19057) Fix other code review comments about FilterList Improvement
[
https://issues.apache.org/jira/browse/HBASE-19057?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16217993#comment-16217993
]
Zheng Hu commented on HBASE-19057:
--
[~tedyu]
bq. Can you add comment explaining why NEXT_ROW would be treated the same as
NEXT_COL ?
I think the javadoc of FilterListWithOR#mergeReturnCode have a good explanation
about this.
{code}
* FilterList with MUST_PASS_ONE choose the minimal forward step among
sub-filter in filter list.
* Let's call it: The Minimal Step Rule. So if filter-A in filter list return
INCLUDE and filter-B
* in filter list return INCLUDE_AND_NEXT_COL, then the filter list should
return INCLUDE. For
* SEEK_NEXT_USING_HINT, it's more special, because we do not know how far it
will forward, so we
* use SKIP by default.
{code}
bq. Comment w.r.t. return value doesn't match the actual value.
Thanks for the check, Will update it in patch.v5, just typo fix, no other code
change.
So if no other concerns, Can I commit it to branch HBASE-18410 ? after that,
we can rebase master ...
> Fix other code review comments about FilterList Improvement
> ---
>
> Key: HBASE-19057
> URL: https://issues.apache.org/jira/browse/HBASE-19057
> Project: HBase
> Issue Type: Sub-task
> Components: Filters
>Reporter: Zheng Hu
>Assignee: Zheng Hu
>Priority: Blocker
> Fix For: 2.0.0-alpha-4
>
> Attachments: HBASE-19057-HBASE-18410.v1.patch,
> HBASE-19057-HBASE-18410.v2.patch, HBASE-19057-HBASE-18410.v3.patch,
> HBASE-19057-HBASE-18410.v4.patch, HBASE-19057-HBASE-18410.v4.patch,
> HBASE-19057-HBASE-18410.v4.patch, HBASE-19057-HBASE-18410.v5.patch,
> HBASE-19057-HBASE-18410.v5.patch, HBASE-19057-HBASE-18410.v5.patch
>
>
> Open this issue to fix conflict , run HadoopQA and gather other feedback.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-19057) Fix other code review comments about FilterList Improvement
[ https://issues.apache.org/jira/browse/HBASE-19057?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16217820#comment-16217820 ] stack commented on HBASE-19057: --- That looks good. > Fix other code review comments about FilterList Improvement > --- > > Key: HBASE-19057 > URL: https://issues.apache.org/jira/browse/HBASE-19057 > Project: HBase > Issue Type: Sub-task > Components: Filters >Reporter: Zheng Hu >Assignee: Zheng Hu >Priority: Blocker > Fix For: 2.0.0-alpha-4 > > Attachments: HBASE-19057-HBASE-18410.v1.patch, > HBASE-19057-HBASE-18410.v2.patch, HBASE-19057-HBASE-18410.v3.patch, > HBASE-19057-HBASE-18410.v4.patch, HBASE-19057-HBASE-18410.v4.patch, > HBASE-19057-HBASE-18410.v4.patch, HBASE-19057-HBASE-18410.v5.patch, > HBASE-19057-HBASE-18410.v5.patch, HBASE-19057-HBASE-18410.v5.patch > > > Open this issue to fix conflict , run HadoopQA and gather other feedback. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-19057) Fix other code review comments about FilterList Improvement
[
https://issues.apache.org/jira/browse/HBASE-19057?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16217818#comment-16217818
]
Hadoop QA commented on HBASE-19057:
---
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 19m
32s{color} | {color:blue} Docker mode activated. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 1 new or modified test
files. {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 1m
46s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 5m
57s{color} | {color:green} HBASE-18410 passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
57s{color} | {color:green} HBASE-18410 passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
58s{color} | {color:green} HBASE-18410 passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
38s{color} | {color:green} HBASE-18410 passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 5m
34s{color} | {color:green} branch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 3m
23s{color} | {color:green} HBASE-18410 passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
52s{color} | {color:green} HBASE-18410 passed {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
19s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 3m
52s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
4s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 1m
4s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m
4s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
27s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 3m
54s{color} | {color:green} patch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
38m 36s{color} | {color:green} Patch does not cause any errors with Hadoop
2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3 or 3.0.0-alpha4. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 3m
22s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
43s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 2m
28s{color} | {color:green} hbase-client in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green}127m
24s{color} | {color:green} hbase-server in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
33s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}218m 30s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:cb5c477 |
| JIRA Issue | HBASE-19057 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12893771/HBASE-19057-HBASE-18410.v5.patch
|
| Optional Tests | asflicense javac javadoc unit findbugs shadedjars
hadoopcheck hbaseanti checkstyle compile |
| uname | Linux af118bd980e6 3.13.0-123-generic #172-Ubuntu SMP Mon Jun 26
18:04:35 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh
|
| git revision | HB
[jira] [Commented] (HBASE-19057) Fix other code review comments about FilterList Improvement
[
https://issues.apache.org/jira/browse/HBASE-19057?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16217341#comment-16217341
]
Ted Yu commented on HBASE-19057:
For FilterListWithOR :
{code}
+ if (isInReturnCodes(rc, ReturnCode.NEXT_COL, ReturnCode.NEXT_ROW)) {
+return ReturnCode.NEXT_COL;
+ }
{code}
Can you add comment explaining why NEXT_ROW would be treated the same as
NEXT_COL ?
{code}
+// Can't just return true here, because there are some filters (such
as PrefixFilter) which
+// will catch the row changed event by filterRowKey(). If we return
early here, those
+// filters will have no chance to update their row state.
retVal = false;
{code}
Comment w.r.t. return value doesn't match the actual value.
> Fix other code review comments about FilterList Improvement
> ---
>
> Key: HBASE-19057
> URL: https://issues.apache.org/jira/browse/HBASE-19057
> Project: HBase
> Issue Type: Sub-task
> Components: Filters
>Reporter: Zheng Hu
>Assignee: Zheng Hu
>Priority: Blocker
> Fix For: 2.0.0-alpha-4
>
> Attachments: HBASE-19057-HBASE-18410.v1.patch,
> HBASE-19057-HBASE-18410.v2.patch, HBASE-19057-HBASE-18410.v3.patch,
> HBASE-19057-HBASE-18410.v4.patch, HBASE-19057-HBASE-18410.v4.patch,
> HBASE-19057-HBASE-18410.v4.patch, HBASE-19057-HBASE-18410.v5.patch,
> HBASE-19057-HBASE-18410.v5.patch, HBASE-19057-HBASE-18410.v5.patch
>
>
> Open this issue to fix conflict , run HadoopQA and gather other feedback.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-19057) Fix other code review comments about FilterList Improvement
[
https://issues.apache.org/jira/browse/HBASE-19057?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16217227#comment-16217227
]
Hadoop QA commented on HBASE-19057:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
12s{color} | {color:blue} Docker mode activated. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 1 new or modified test
files. {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 1m
46s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 5m
35s{color} | {color:green} HBASE-18410 passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
55s{color} | {color:green} HBASE-18410 passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
52s{color} | {color:green} HBASE-18410 passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
35s{color} | {color:green} HBASE-18410 passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 5m
25s{color} | {color:green} branch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 4m
45s{color} | {color:green} HBASE-18410 passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m
5s{color} | {color:green} HBASE-18410 passed {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
22s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m
37s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
17s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 1m
17s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m
0s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
41s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 5m
40s{color} | {color:green} patch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
69m 21s{color} | {color:green} Patch does not cause any errors with Hadoop
2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3 or 3.0.0-alpha4. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 7m
8s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m
47s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 4m
26s{color} | {color:green} hbase-client in the patch passed. {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red}180m 56s{color}
| {color:red} hbase-server in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 1m
16s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}293m 57s{color} |
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| Timed out junit tests |
org.apache.hadoop.hbase.master.TestMasterRestartAfterDisablingTable |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:cb5c477 |
| JIRA Issue | HBASE-19057 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12893720/HBASE-19057-HBASE-18410.v5.patch
|
| Optional Tests | asflicense javac javadoc unit findbugs shadedjars
hadoopcheck hbaseanti checkstyle compile |
| uname | Linux ddbc5a9f9287 3.13.0-123-generic #172-Ubuntu SMP Mon Jun 26
18:04:35 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/home/jenk
[jira] [Commented] (HBASE-19057) Fix other code review comments about FilterList Improvement
[ https://issues.apache.org/jira/browse/HBASE-19057?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16217216#comment-16217216 ] stack commented on HBASE-19057: --- builds.apache.org is borked (broke). Not working. FYI. I'll try and get this run while you all are sleeping > Fix other code review comments about FilterList Improvement > --- > > Key: HBASE-19057 > URL: https://issues.apache.org/jira/browse/HBASE-19057 > Project: HBase > Issue Type: Sub-task > Components: Filters >Reporter: Zheng Hu >Assignee: Zheng Hu >Priority: Blocker > Fix For: 2.0.0-alpha-4 > > Attachments: HBASE-19057-HBASE-18410.v1.patch, > HBASE-19057-HBASE-18410.v2.patch, HBASE-19057-HBASE-18410.v3.patch, > HBASE-19057-HBASE-18410.v4.patch, HBASE-19057-HBASE-18410.v4.patch, > HBASE-19057-HBASE-18410.v4.patch, HBASE-19057-HBASE-18410.v5.patch, > HBASE-19057-HBASE-18410.v5.patch > > > Open this issue to fix conflict , run HadoopQA and gather other feedback. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-19057) Fix other code review comments about FilterList Improvement
[ https://issues.apache.org/jira/browse/HBASE-19057?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16216659#comment-16216659 ] Zheng Hu commented on HBASE-19057: -- The last UT failed because of H5 is offlined. https://builds.apache.org/job/PreCommit-HBASE-Build/9375/console Let's run Again. > Fix other code review comments about FilterList Improvement > --- > > Key: HBASE-19057 > URL: https://issues.apache.org/jira/browse/HBASE-19057 > Project: HBase > Issue Type: Sub-task > Components: Filters >Reporter: Zheng Hu >Assignee: Zheng Hu >Priority: Blocker > Fix For: 2.0.0-alpha-4 > > Attachments: HBASE-19057-HBASE-18410.v1.patch, > HBASE-19057-HBASE-18410.v2.patch, HBASE-19057-HBASE-18410.v3.patch, > HBASE-19057-HBASE-18410.v4.patch, HBASE-19057-HBASE-18410.v4.patch, > HBASE-19057-HBASE-18410.v4.patch, HBASE-19057-HBASE-18410.v5.patch, > HBASE-19057-HBASE-18410.v5.patch > > > Open this issue to fix conflict , run HadoopQA and gather other feedback. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-19057) Fix other code review comments about FilterList Improvement
[ https://issues.apache.org/jira/browse/HBASE-19057?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16216456#comment-16216456 ] Zheng Hu commented on HBASE-19057: -- Thanks Duo's careful work. I checked the code, no other errors except that we introduced some redundancy imported packages. I've removed them in the rebased patch.v5 . > Fix other code review comments about FilterList Improvement > --- > > Key: HBASE-19057 > URL: https://issues.apache.org/jira/browse/HBASE-19057 > Project: HBase > Issue Type: Sub-task > Components: Filters >Reporter: Zheng Hu >Assignee: Zheng Hu >Priority: Blocker > Fix For: 2.0.0-alpha-4 > > Attachments: HBASE-19057-HBASE-18410.v1.patch, > HBASE-19057-HBASE-18410.v2.patch, HBASE-19057-HBASE-18410.v3.patch, > HBASE-19057-HBASE-18410.v4.patch, HBASE-19057-HBASE-18410.v4.patch, > HBASE-19057-HBASE-18410.v4.patch > > > Open this issue to fix conflict , run HadoopQA and gather other feedback. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-19057) Fix other code review comments about FilterList Improvement
[
https://issues.apache.org/jira/browse/HBASE-19057?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16216322#comment-16216322
]
Hadoop QA commented on HBASE-19057:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
0s{color} | {color:blue} Docker mode activated. {color} |
| {color:red}-1{color} | {color:red} patch {color} | {color:red} 0m 5s{color}
| {color:red} HBASE-19057 does not apply to HBASE-18410. Rebase required? Wrong
Branch? See https://yetus.apache.org/documentation/0.4.0/precommit-patchnames
for help. {color} |
\\
\\
|| Subsystem || Report/Notes ||
| JIRA Issue | HBASE-19057 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12893635/HBASE-19057-HBASE-18410.v4.patch
|
| Console output |
https://builds.apache.org/job/PreCommit-HBASE-Build/9363/console |
| Powered by | Apache Yetus 0.4.0 http://yetus.apache.org |
This message was automatically generated.
> Fix other code review comments about FilterList Improvement
> ---
>
> Key: HBASE-19057
> URL: https://issues.apache.org/jira/browse/HBASE-19057
> Project: HBase
> Issue Type: Sub-task
> Components: Filters
>Reporter: Zheng Hu
>Assignee: Zheng Hu
>Priority: Blocker
> Fix For: 2.0.0-alpha-4
>
> Attachments: HBASE-19057-HBASE-18410.v1.patch,
> HBASE-19057-HBASE-18410.v2.patch, HBASE-19057-HBASE-18410.v3.patch,
> HBASE-19057-HBASE-18410.v4.patch, HBASE-19057-HBASE-18410.v4.patch,
> HBASE-19057-HBASE-18410.v4.patch
>
>
> Open this issue to fix conflict , run HadoopQA and gather other feedback.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-19057) Fix other code review comments about FilterList Improvement
[ https://issues.apache.org/jira/browse/HBASE-19057?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16216254#comment-16216254 ] Duo Zhang commented on HBASE-19057: --- Done a rebase and force push. There are conflicts, mainly because the patches committed to master and HBASE-18410 are different for HBASE-15410. [~openinx] Please also rebase your patch, and check carefully if there are errors of what I've done to resolve conflicts. I ran TestFilterList and TestFilterListOnMini, they passed. Thanks. > Fix other code review comments about FilterList Improvement > --- > > Key: HBASE-19057 > URL: https://issues.apache.org/jira/browse/HBASE-19057 > Project: HBase > Issue Type: Sub-task > Components: Filters >Reporter: Zheng Hu >Assignee: Zheng Hu >Priority: Blocker > Fix For: 2.0.0-alpha-4 > > Attachments: HBASE-19057-HBASE-18410.v1.patch, > HBASE-19057-HBASE-18410.v2.patch, HBASE-19057-HBASE-18410.v3.patch, > HBASE-19057-HBASE-18410.v4.patch, HBASE-19057-HBASE-18410.v4.patch, > HBASE-19057-HBASE-18410.v4.patch > > > Open this issue to fix conflict , run HadoopQA and gather other feedback. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-19057) Fix other code review comments about FilterList Improvement
[ https://issues.apache.org/jira/browse/HBASE-19057?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16216221#comment-16216221 ] Duo Zhang commented on HBASE-19057: --- OK, let me rebase first. > Fix other code review comments about FilterList Improvement > --- > > Key: HBASE-19057 > URL: https://issues.apache.org/jira/browse/HBASE-19057 > Project: HBase > Issue Type: Sub-task > Components: Filters >Reporter: Zheng Hu >Assignee: Zheng Hu >Priority: Blocker > Fix For: 2.0.0-alpha-4 > > Attachments: HBASE-19057-HBASE-18410.v1.patch, > HBASE-19057-HBASE-18410.v2.patch, HBASE-19057-HBASE-18410.v3.patch, > HBASE-19057-HBASE-18410.v4.patch, HBASE-19057-HBASE-18410.v4.patch, > HBASE-19057-HBASE-18410.v4.patch > > > Open this issue to fix conflict , run HadoopQA and gather other feedback. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-19057) Fix other code review comments about FilterList Improvement
[
https://issues.apache.org/jira/browse/HBASE-19057?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16216076#comment-16216076
]
Hadoop QA commented on HBASE-19057:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 13m
37s{color} | {color:blue} Docker mode activated. {color} |
| {color:blue}0{color} | {color:blue} shelldocs {color} | {color:blue} 0m
5s{color} | {color:blue} Shelldocs was not available. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 1 new or modified test
files. {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 1m
46s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 5m
46s{color} | {color:green} HBASE-18410 passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 4m
23s{color} | {color:green} HBASE-18410 passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m
20s{color} | {color:green} HBASE-18410 passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 2m
37s{color} | {color:green} HBASE-18410 passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 3m
55s{color} | {color:green} branch has no errors when building our shaded
downstream artifacts. {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m
0s{color} | {color:blue} Skipped patched modules with no Java source: . {color}
|
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 3m
10s{color} | {color:green} HBASE-18410 passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 3m
30s{color} | {color:green} HBASE-18410 passed {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
19s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m
42s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 4m
21s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 4m
21s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m
19s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 2m
26s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} shellcheck {color} | {color:green} 0m
5s{color} | {color:green} There were no new shellcheck issues. {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 3m
54s{color} | {color:green} patch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
37m 55s{color} | {color:green} Patch does not cause any errors with Hadoop
2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3 or 3.0.0-alpha4. {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m
0s{color} | {color:blue} Skipped patched modules with no Java source: . {color}
|
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 3m
52s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 3m
45s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 2m
33s{color} | {color:green} hbase-client in the patch passed. {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 71m 15s{color}
| {color:red} hbase-server in the patch failed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green}153m
13s{color} | {color:green} root in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
55s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:bla
[jira] [Commented] (HBASE-19057) Fix other code review comments about FilterList Improvement
[ https://issues.apache.org/jira/browse/HBASE-19057?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16215606#comment-16215606 ] stack commented on HBASE-19057: --- On patch, yeah, be careful with those Docker file changes... Make sure you pick up latest. > Fix other code review comments about FilterList Improvement > --- > > Key: HBASE-19057 > URL: https://issues.apache.org/jira/browse/HBASE-19057 > Project: HBase > Issue Type: Sub-task > Components: Filters >Reporter: Zheng Hu >Assignee: Zheng Hu >Priority: Blocker > Fix For: HBASE-18410 > > Attachments: HBASE-19057-HBASE-18410.v1.patch, > HBASE-19057-HBASE-18410.v2.patch, HBASE-19057-HBASE-18410.v3.patch, > HBASE-19057-HBASE-18410.v4.patch, HBASE-19057-HBASE-18410.v4.patch > > > Open this issue to fix conflict , run HadoopQA and gather other feedback. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-19057) Fix other code review comments about FilterList Improvement
[ https://issues.apache.org/jira/browse/HBASE-19057?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16215595#comment-16215595 ] stack commented on HBASE-19057: --- bq. So what is a typical way of merging back a feature branch sir stack? Sounds right [~Apache9] Just be careful what you push (smile). > Fix other code review comments about FilterList Improvement > --- > > Key: HBASE-19057 > URL: https://issues.apache.org/jira/browse/HBASE-19057 > Project: HBase > Issue Type: Sub-task > Components: Filters >Reporter: Zheng Hu >Assignee: Zheng Hu >Priority: Blocker > Fix For: HBASE-18410 > > Attachments: HBASE-19057-HBASE-18410.v1.patch, > HBASE-19057-HBASE-18410.v2.patch, HBASE-19057-HBASE-18410.v3.patch, > HBASE-19057-HBASE-18410.v4.patch, HBASE-19057-HBASE-18410.v4.patch > > > Open this issue to fix conflict , run HadoopQA and gather other feedback. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-19057) Fix other code review comments about FilterList Improvement
[ https://issues.apache.org/jira/browse/HBASE-19057?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16215574#comment-16215574 ] Hadoop QA commented on HBASE-19057: --- (!) A patch to the testing environment has been detected. Re-executing against the patched versions to perform further tests. The console is at https://builds.apache.org/job/PreCommit-HBASE-Build/9355/console in case of problems. > Fix other code review comments about FilterList Improvement > --- > > Key: HBASE-19057 > URL: https://issues.apache.org/jira/browse/HBASE-19057 > Project: HBase > Issue Type: Sub-task > Components: Filters >Reporter: Zheng Hu >Assignee: Zheng Hu >Priority: Blocker > Fix For: HBASE-18410 > > Attachments: HBASE-19057-HBASE-18410.v1.patch, > HBASE-19057-HBASE-18410.v2.patch, HBASE-19057-HBASE-18410.v3.patch, > HBASE-19057-HBASE-18410.v4.patch, HBASE-19057-HBASE-18410.v4.patch > > > Open this issue to fix conflict , run HadoopQA and gather other feedback. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-19057) Fix other code review comments about FilterList Improvement
[
https://issues.apache.org/jira/browse/HBASE-19057?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16215470#comment-16215470
]
Hadoop QA commented on HBASE-19057:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 15m
3s{color} | {color:blue} Docker mode activated. {color} |
| {color:blue}0{color} | {color:blue} shelldocs {color} | {color:blue} 0m
5s{color} | {color:blue} Shelldocs was not available. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 1 new or modified test
files. {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 1m
48s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 5m
54s{color} | {color:green} HBASE-18410 passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 4m
30s{color} | {color:green} HBASE-18410 passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m
20s{color} | {color:green} HBASE-18410 passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 2m
35s{color} | {color:green} HBASE-18410 passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 3m
55s{color} | {color:green} branch has no errors when building our shaded
downstream artifacts. {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m
0s{color} | {color:blue} Skipped patched modules with no Java source: . {color}
|
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 3m
8s{color} | {color:green} HBASE-18410 passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 3m
21s{color} | {color:green} HBASE-18410 passed {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
17s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m
34s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 4m
17s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 4m
17s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m
19s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 2m
22s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} shellcheck {color} | {color:green} 0m
4s{color} | {color:green} There were no new shellcheck issues. {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 3m
47s{color} | {color:green} patch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
36m 18s{color} | {color:green} Patch does not cause any errors with Hadoop
2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3 or 3.0.0-alpha4. {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m
0s{color} | {color:blue} Skipped patched modules with no Java source: . {color}
|
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 3m
31s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 3m
43s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 2m
36s{color} | {color:green} hbase-client in the patch passed. {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red}109m 6s{color}
| {color:red} hbase-server in the patch failed. {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 91m 4s{color}
| {color:red} root in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 1m
56s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {col
[jira] [Commented] (HBASE-19057) Fix other code review comments about FilterList Improvement
[ https://issues.apache.org/jira/browse/HBASE-19057?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16215043#comment-16215043 ] Duo Zhang commented on HBASE-19057: --- Hey [~anoopsamjohn], do we need a rebase and force push on HBASE-18410 first? Thanks. > Fix other code review comments about FilterList Improvement > --- > > Key: HBASE-19057 > URL: https://issues.apache.org/jira/browse/HBASE-19057 > Project: HBase > Issue Type: Sub-task > Components: Filters >Reporter: Zheng Hu >Assignee: Zheng Hu >Priority: Blocker > Fix For: 2.0.0-alpha-4 > > Attachments: HBASE-19057-HBASE-18410.v1.patch, > HBASE-19057-HBASE-18410.v2.patch, HBASE-19057-HBASE-18410.v3.patch, > HBASE-19057-HBASE-18410.v4.patch > > > Open this issue to fix conflict , run HadoopQA and gather other feedback. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-19057) Fix other code review comments about FilterList Improvement
[ https://issues.apache.org/jira/browse/HBASE-19057?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16215033#comment-16215033 ] Zheng Hu commented on HBASE-19057: -- bq. Change in docket file is as per the recent change in trunk? Yes, It's a change after our branch HBASE-18410 created. > Fix other code review comments about FilterList Improvement > --- > > Key: HBASE-19057 > URL: https://issues.apache.org/jira/browse/HBASE-19057 > Project: HBase > Issue Type: Sub-task > Components: Filters >Reporter: Zheng Hu >Assignee: Zheng Hu >Priority: Blocker > Fix For: 2.0.0-alpha-4 > > Attachments: HBASE-19057-HBASE-18410.v1.patch, > HBASE-19057-HBASE-18410.v2.patch, HBASE-19057-HBASE-18410.v3.patch, > HBASE-19057-HBASE-18410.v4.patch > > > Open this issue to fix conflict , run HadoopQA and gather other feedback. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-19057) Fix other code review comments about FilterList Improvement
[ https://issues.apache.org/jira/browse/HBASE-19057?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16215028#comment-16215028 ] Anoop Sam John commented on HBASE-19057: Change in docket file is as per the recent change in trunk? > Fix other code review comments about FilterList Improvement > --- > > Key: HBASE-19057 > URL: https://issues.apache.org/jira/browse/HBASE-19057 > Project: HBase > Issue Type: Sub-task > Components: Filters >Reporter: Zheng Hu >Assignee: Zheng Hu >Priority: Blocker > Fix For: 2.0.0-alpha-4 > > Attachments: HBASE-19057-HBASE-18410.v1.patch, > HBASE-19057-HBASE-18410.v2.patch, HBASE-19057-HBASE-18410.v3.patch, > HBASE-19057-HBASE-18410.v4.patch > > > Open this issue to fix conflict , run HadoopQA and gather other feedback. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-19057) Fix other code review comments about FilterList Improvement
[ https://issues.apache.org/jira/browse/HBASE-19057?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16215025#comment-16215025 ] Hadoop QA commented on HBASE-19057: --- (!) A patch to the testing environment has been detected. Re-executing against the patched versions to perform further tests. The console is at https://builds.apache.org/job/PreCommit-HBASE-Build/9347/console in case of problems. > Fix other code review comments about FilterList Improvement > --- > > Key: HBASE-19057 > URL: https://issues.apache.org/jira/browse/HBASE-19057 > Project: HBase > Issue Type: Sub-task > Components: Filters >Reporter: Zheng Hu >Assignee: Zheng Hu >Priority: Blocker > Fix For: 2.0.0-alpha-4 > > Attachments: HBASE-19057-HBASE-18410.v1.patch, > HBASE-19057-HBASE-18410.v2.patch, HBASE-19057-HBASE-18410.v3.patch, > HBASE-19057-HBASE-18410.v4.patch > > > Open this issue to fix conflict , run HadoopQA and gather other feedback. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-19057) Fix other code review comments about FilterList Improvement
[ https://issues.apache.org/jira/browse/HBASE-19057?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16214990#comment-16214990 ] Anoop Sam John commented on HBASE-19057: As discussed above, better we keep the original way of filterRowKey() for the AND filter also.. We were not having the short circuit return even there. So OR case, we follow same even now. For AND also better we dont do short circuit. Pls add fat comments in both these places abt why we dont do short circuit returns. Else patch LGTM > Fix other code review comments about FilterList Improvement > --- > > Key: HBASE-19057 > URL: https://issues.apache.org/jira/browse/HBASE-19057 > Project: HBase > Issue Type: Sub-task > Components: Filters >Reporter: Zheng Hu >Assignee: Zheng Hu >Priority: Blocker > Fix For: 2.0.0-alpha-4 > > Attachments: HBASE-19057-HBASE-18410.v1.patch, > HBASE-19057-HBASE-18410.v2.patch > > > Open this issue to fix conflict , run HadoopQA and gather other feedback. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-19057) Fix other code review comments about FilterList Improvement
[ https://issues.apache.org/jira/browse/HBASE-19057?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16214988#comment-16214988 ] Zheng Hu commented on HBASE-19057: -- The failed Hadoop QA is caused by downloading Oracle JDK, I'll upload patch.v3 with the diff of HBASE-19042, If the ut pass, the we can commit the patch.v2 to branch HBASE-18410, because there's no diff between patch.v3 and patch.v2 about FilterList. > Fix other code review comments about FilterList Improvement > --- > > Key: HBASE-19057 > URL: https://issues.apache.org/jira/browse/HBASE-19057 > Project: HBase > Issue Type: Sub-task > Components: Filters >Reporter: Zheng Hu >Assignee: Zheng Hu >Priority: Blocker > Fix For: 2.0.0-alpha-4 > > Attachments: HBASE-19057-HBASE-18410.v1.patch, > HBASE-19057-HBASE-18410.v2.patch > > > Open this issue to fix conflict , run HadoopQA and gather other feedback. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
