[jira] [Commented] (HBASE-6669) Add BigDecimalColumnInterpreter for doing aggregations using AggregationClient
[ https://issues.apache.org/jira/browse/HBASE-6669?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13589257#comment-13589257 ] Hudson commented on HBASE-6669: --- Integrated in hbase-0.95 #7 (See [https://builds.apache.org/job/hbase-0.95/7/]) HBASE-7641 Port HBASE-6669 'Add BigDecimalColumnInterpreter for doing aggregations using AggregationClient' to trunk (Julian Wissman) (Revision 1451038) Result = FAILURE tedyu : Files : * /hbase/branches/0.95/hbase-protocol/src/main/java/org/apache/hadoop/hbase/protobuf/generated/HBaseProtos.java * /hbase/branches/0.95/hbase-protocol/src/main/protobuf/hbase.proto * /hbase/branches/0.95/hbase-server/src/main/java/org/apache/hadoop/hbase/client/coprocessor/BigDecimalColumnInterpreter.java * /hbase/branches/0.95/hbase-server/src/test/java/org/apache/hadoop/hbase/coprocessor/TestBigDecimalColumnInterpreter.java > Add BigDecimalColumnInterpreter for doing aggregations using AggregationClient > -- > > Key: HBASE-6669 > URL: https://issues.apache.org/jira/browse/HBASE-6669 > Project: HBase > Issue Type: New Feature > Components: Client, Coprocessors >Affects Versions: 0.94.3, 0.96.0 >Reporter: Anil Gupta >Assignee: Anil Gupta >Priority: Minor > Labels: client, coprocessors > Fix For: 0.94.5 > > Attachments: 6669-0.94-v4.txt, 6669-0.94-v5.txt, > BigDecimalColumnInterpreter.java, BigDecimalColumnInterpreter.patch, > BigDecimalColumnInterpreter.patch, HBASE-6669.patch, HBASE-6669-v2.patch, > HBASE-6669-v3.patch, TestBDAggregateProtocol.patch, > TestBigDecimalColumnInterpreter.java > > > I recently created a Class for doing aggregations(sum,min,max,std) on values > stored as BigDecimal in HBase. I would like to commit the > BigDecimalColumnInterpreter into HBase. In my opinion this class can be used > by a wide variety of users. Please let me know if its not appropriate to add > this class in HBase. > Thanks, > Anil Gupta > Software Engineer II, Intuit, Inc -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6669) Add BigDecimalColumnInterpreter for doing aggregations using AggregationClient
[ https://issues.apache.org/jira/browse/HBASE-6669?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13589210#comment-13589210 ] Hudson commented on HBASE-6669: --- Integrated in hbase-0.95-on-hadoop2 #3 (See [https://builds.apache.org/job/hbase-0.95-on-hadoop2/3/]) HBASE-7641 Port HBASE-6669 'Add BigDecimalColumnInterpreter for doing aggregations using AggregationClient' to trunk (Julian Wissman) (Revision 1451038) Result = FAILURE tedyu : Files : * /hbase/branches/0.95/hbase-protocol/src/main/java/org/apache/hadoop/hbase/protobuf/generated/HBaseProtos.java * /hbase/branches/0.95/hbase-protocol/src/main/protobuf/hbase.proto * /hbase/branches/0.95/hbase-server/src/main/java/org/apache/hadoop/hbase/client/coprocessor/BigDecimalColumnInterpreter.java * /hbase/branches/0.95/hbase-server/src/test/java/org/apache/hadoop/hbase/coprocessor/TestBigDecimalColumnInterpreter.java > Add BigDecimalColumnInterpreter for doing aggregations using AggregationClient > -- > > Key: HBASE-6669 > URL: https://issues.apache.org/jira/browse/HBASE-6669 > Project: HBase > Issue Type: New Feature > Components: Client, Coprocessors >Affects Versions: 0.94.3, 0.96.0 >Reporter: Anil Gupta >Assignee: Anil Gupta >Priority: Minor > Labels: client, coprocessors > Fix For: 0.94.5 > > Attachments: 6669-0.94-v4.txt, 6669-0.94-v5.txt, > BigDecimalColumnInterpreter.java, BigDecimalColumnInterpreter.patch, > BigDecimalColumnInterpreter.patch, HBASE-6669.patch, HBASE-6669-v2.patch, > HBASE-6669-v3.patch, TestBDAggregateProtocol.patch, > TestBigDecimalColumnInterpreter.java > > > I recently created a Class for doing aggregations(sum,min,max,std) on values > stored as BigDecimal in HBase. I would like to commit the > BigDecimalColumnInterpreter into HBase. In my opinion this class can be used > by a wide variety of users. Please let me know if its not appropriate to add > this class in HBase. > Thanks, > Anil Gupta > Software Engineer II, Intuit, Inc -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6669) Add BigDecimalColumnInterpreter for doing aggregations using AggregationClient
[ https://issues.apache.org/jira/browse/HBASE-6669?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13589194#comment-13589194 ] Hudson commented on HBASE-6669: --- Integrated in HBase-TRUNK-on-Hadoop-2.0.0 #423 (See [https://builds.apache.org/job/HBase-TRUNK-on-Hadoop-2.0.0/423/]) HBASE-7641 Port HBASE-6669 'Add BigDecimalColumnInterpreter for doing aggregations using AggregationClient' to trunk (Julian Wissman) (Revision 1451037) Result = FAILURE tedyu : Files : * /hbase/trunk/hbase-protocol/src/main/java/org/apache/hadoop/hbase/protobuf/generated/HBaseProtos.java * /hbase/trunk/hbase-protocol/src/main/protobuf/hbase.proto * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/client/coprocessor/BigDecimalColumnInterpreter.java * /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/coprocessor/TestBigDecimalColumnInterpreter.java > Add BigDecimalColumnInterpreter for doing aggregations using AggregationClient > -- > > Key: HBASE-6669 > URL: https://issues.apache.org/jira/browse/HBASE-6669 > Project: HBase > Issue Type: New Feature > Components: Client, Coprocessors >Affects Versions: 0.94.3, 0.96.0 >Reporter: Anil Gupta >Assignee: Anil Gupta >Priority: Minor > Labels: client, coprocessors > Fix For: 0.94.5 > > Attachments: 6669-0.94-v4.txt, 6669-0.94-v5.txt, > BigDecimalColumnInterpreter.java, BigDecimalColumnInterpreter.patch, > BigDecimalColumnInterpreter.patch, HBASE-6669.patch, HBASE-6669-v2.patch, > HBASE-6669-v3.patch, TestBDAggregateProtocol.patch, > TestBigDecimalColumnInterpreter.java > > > I recently created a Class for doing aggregations(sum,min,max,std) on values > stored as BigDecimal in HBase. I would like to commit the > BigDecimalColumnInterpreter into HBase. In my opinion this class can be used > by a wide variety of users. Please let me know if its not appropriate to add > this class in HBase. > Thanks, > Anil Gupta > Software Engineer II, Intuit, Inc -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6669) Add BigDecimalColumnInterpreter for doing aggregations using AggregationClient
[ https://issues.apache.org/jira/browse/HBASE-6669?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13589041#comment-13589041 ] Hudson commented on HBASE-6669: --- Integrated in HBase-TRUNK #3904 (See [https://builds.apache.org/job/HBase-TRUNK/3904/]) HBASE-7641 Port HBASE-6669 'Add BigDecimalColumnInterpreter for doing aggregations using AggregationClient' to trunk (Julian Wissman) (Revision 1451037) Result = FAILURE tedyu : Files : * /hbase/trunk/hbase-protocol/src/main/java/org/apache/hadoop/hbase/protobuf/generated/HBaseProtos.java * /hbase/trunk/hbase-protocol/src/main/protobuf/hbase.proto * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/client/coprocessor/BigDecimalColumnInterpreter.java * /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/coprocessor/TestBigDecimalColumnInterpreter.java > Add BigDecimalColumnInterpreter for doing aggregations using AggregationClient > -- > > Key: HBASE-6669 > URL: https://issues.apache.org/jira/browse/HBASE-6669 > Project: HBase > Issue Type: New Feature > Components: Client, Coprocessors >Affects Versions: 0.94.3, 0.96.0 >Reporter: Anil Gupta >Assignee: Anil Gupta >Priority: Minor > Labels: client, coprocessors > Fix For: 0.94.5 > > Attachments: 6669-0.94-v4.txt, 6669-0.94-v5.txt, > BigDecimalColumnInterpreter.java, BigDecimalColumnInterpreter.patch, > BigDecimalColumnInterpreter.patch, HBASE-6669.patch, HBASE-6669-v2.patch, > HBASE-6669-v3.patch, TestBDAggregateProtocol.patch, > TestBigDecimalColumnInterpreter.java > > > I recently created a Class for doing aggregations(sum,min,max,std) on values > stored as BigDecimal in HBase. I would like to commit the > BigDecimalColumnInterpreter into HBase. In my opinion this class can be used > by a wide variety of users. Please let me know if its not appropriate to add > this class in HBase. > Thanks, > Anil Gupta > Software Engineer II, Intuit, Inc -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6669) Add BigDecimalColumnInterpreter for doing aggregations using AggregationClient
[ https://issues.apache.org/jira/browse/HBASE-6669?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13570973#comment-13570973 ] Hudson commented on HBASE-6669: --- Integrated in HBase-0.94-security-on-Hadoop-23 #11 (See [https://builds.apache.org/job/HBase-0.94-security-on-Hadoop-23/11/]) HBASE-6669 Add BigDecimalColumnInterpreter for doing aggregations using AggregationClient (Anil Gupta) (Revision 1436726) Result = FAILURE tedyu : Files : * /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/client/coprocessor/BigDecimalColumnInterpreter.java * /hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/coprocessor/TestBigDecimalColumnInterpreter.java > Add BigDecimalColumnInterpreter for doing aggregations using AggregationClient > -- > > Key: HBASE-6669 > URL: https://issues.apache.org/jira/browse/HBASE-6669 > Project: HBase > Issue Type: New Feature > Components: Client, Coprocessors >Affects Versions: 0.94.3, 0.96.0 >Reporter: Anil Gupta >Assignee: Anil Gupta >Priority: Minor > Labels: client, coprocessors > Fix For: 0.94.5 > > Attachments: 6669-0.94-v4.txt, 6669-0.94-v5.txt, > BigDecimalColumnInterpreter.java, BigDecimalColumnInterpreter.patch, > BigDecimalColumnInterpreter.patch, HBASE-6669.patch, HBASE-6669-v2.patch, > HBASE-6669-v3.patch, TestBDAggregateProtocol.patch, > TestBigDecimalColumnInterpreter.java > > > I recently created a Class for doing aggregations(sum,min,max,std) on values > stored as BigDecimal in HBase. I would like to commit the > BigDecimalColumnInterpreter into HBase. In my opinion this class can be used > by a wide variety of users. Please let me know if its not appropriate to add > this class in HBase. > Thanks, > Anil Gupta > Software Engineer II, Intuit, Inc -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6669) Add BigDecimalColumnInterpreter for doing aggregations using AggregationClient
[ https://issues.apache.org/jira/browse/HBASE-6669?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13569601#comment-13569601 ] Lars Hofhansl commented on HBASE-6669: -- Agreed. > Add BigDecimalColumnInterpreter for doing aggregations using AggregationClient > -- > > Key: HBASE-6669 > URL: https://issues.apache.org/jira/browse/HBASE-6669 > Project: HBase > Issue Type: New Feature > Components: Client, Coprocessors >Affects Versions: 0.94.3, 0.96.0 >Reporter: Anil Gupta >Assignee: Anil Gupta >Priority: Minor > Labels: client, coprocessors > Fix For: 0.94.5 > > Attachments: 6669-0.94-v4.txt, 6669-0.94-v5.txt, > BigDecimalColumnInterpreter.java, BigDecimalColumnInterpreter.patch, > BigDecimalColumnInterpreter.patch, HBASE-6669.patch, HBASE-6669-v2.patch, > HBASE-6669-v3.patch, TestBDAggregateProtocol.patch, > TestBigDecimalColumnInterpreter.java > > > I recently created a Class for doing aggregations(sum,min,max,std) on values > stored as BigDecimal in HBase. I would like to commit the > BigDecimalColumnInterpreter into HBase. In my opinion this class can be used > by a wide variety of users. Please let me know if its not appropriate to add > this class in HBase. > Thanks, > Anil Gupta > Software Engineer II, Intuit, Inc -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6669) Add BigDecimalColumnInterpreter for doing aggregations using AggregationClient
[ https://issues.apache.org/jira/browse/HBASE-6669?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13569472#comment-13569472 ] Andrew Purtell commented on HBASE-6669: --- Not worth holding up a release of course, but its not a good idea to have things on a branch with promises to port to trunk of indeterminate timeframe. Makes it difficult to reason about what features may be in what, as time goes on. Really should be avoided. > Add BigDecimalColumnInterpreter for doing aggregations using AggregationClient > -- > > Key: HBASE-6669 > URL: https://issues.apache.org/jira/browse/HBASE-6669 > Project: HBase > Issue Type: New Feature > Components: Client, Coprocessors >Affects Versions: 0.94.3, 0.96.0 >Reporter: Anil Gupta >Assignee: Anil Gupta >Priority: Minor > Labels: client, coprocessors > Fix For: 0.94.5 > > Attachments: 6669-0.94-v4.txt, 6669-0.94-v5.txt, > BigDecimalColumnInterpreter.java, BigDecimalColumnInterpreter.patch, > BigDecimalColumnInterpreter.patch, HBASE-6669.patch, HBASE-6669-v2.patch, > HBASE-6669-v3.patch, TestBDAggregateProtocol.patch, > TestBigDecimalColumnInterpreter.java > > > I recently created a Class for doing aggregations(sum,min,max,std) on values > stored as BigDecimal in HBase. I would like to commit the > BigDecimalColumnInterpreter into HBase. In my opinion this class can be used > by a wide variety of users. Please let me know if its not appropriate to add > this class in HBase. > Thanks, > Anil Gupta > Software Engineer II, Intuit, Inc -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6669) Add BigDecimalColumnInterpreter for doing aggregations using AggregationClient
[ https://issues.apache.org/jira/browse/HBASE-6669?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13569067#comment-13569067 ] Anil Gupta commented on HBASE-6669: --- Yes, i can create the patch for 0.96. But, i wont be able to do it today. Hope that's fine. If yes, I'll take care of HBASE-7641. > Add BigDecimalColumnInterpreter for doing aggregations using AggregationClient > -- > > Key: HBASE-6669 > URL: https://issues.apache.org/jira/browse/HBASE-6669 > Project: HBase > Issue Type: New Feature > Components: Client, Coprocessors >Affects Versions: 0.94.3, 0.96.0 >Reporter: Anil Gupta >Assignee: Anil Gupta >Priority: Minor > Labels: client, coprocessors > Fix For: 0.94.5 > > Attachments: 6669-0.94-v4.txt, 6669-0.94-v5.txt, > BigDecimalColumnInterpreter.java, BigDecimalColumnInterpreter.patch, > BigDecimalColumnInterpreter.patch, HBASE-6669.patch, HBASE-6669-v2.patch, > HBASE-6669-v3.patch, TestBDAggregateProtocol.patch, > TestBigDecimalColumnInterpreter.java > > > I recently created a Class for doing aggregations(sum,min,max,std) on values > stored as BigDecimal in HBase. I would like to commit the > BigDecimalColumnInterpreter into HBase. In my opinion this class can be used > by a wide variety of users. Please let me know if its not appropriate to add > this class in HBase. > Thanks, > Anil Gupta > Software Engineer II, Intuit, Inc -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6669) Add BigDecimalColumnInterpreter for doing aggregations using AggregationClient
[ https://issues.apache.org/jira/browse/HBASE-6669?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13569056#comment-13569056 ] Lars Hofhansl commented on HBASE-6669: -- [~anilgupta84] Are you volunteering a 0.96 patch? If we cannot do this today, then let's close this and do the work as part of (one of) the forward porting issue(s), so that I can cut 0.94.5RC0. > Add BigDecimalColumnInterpreter for doing aggregations using AggregationClient > -- > > Key: HBASE-6669 > URL: https://issues.apache.org/jira/browse/HBASE-6669 > Project: HBase > Issue Type: New Feature > Components: Client, Coprocessors >Affects Versions: 0.94.3, 0.96.0 >Reporter: Anil Gupta >Assignee: Anil Gupta >Priority: Minor > Labels: client, coprocessors > Fix For: 0.94.5 > > Attachments: 6669-0.94-v4.txt, 6669-0.94-v5.txt, > BigDecimalColumnInterpreter.java, BigDecimalColumnInterpreter.patch, > BigDecimalColumnInterpreter.patch, HBASE-6669.patch, HBASE-6669-v2.patch, > HBASE-6669-v3.patch, TestBDAggregateProtocol.patch, > TestBigDecimalColumnInterpreter.java > > > I recently created a Class for doing aggregations(sum,min,max,std) on values > stored as BigDecimal in HBase. I would like to commit the > BigDecimalColumnInterpreter into HBase. In my opinion this class can be used > by a wide variety of users. Please let me know if its not appropriate to add > this class in HBase. > Thanks, > Anil Gupta > Software Engineer II, Intuit, Inc -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6669) Add BigDecimalColumnInterpreter for doing aggregations using AggregationClient
[ https://issues.apache.org/jira/browse/HBASE-6669?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13569054#comment-13569054 ] Lars Hofhansl commented on HBASE-6669: -- bq. We should follow the Hadoop practice of requiring all new features or cross-version common bugfixes to go through trunk first. I think there is no hard rule around this, neither should there be (IMHO). For simple issues (like this one) as long as we keep an issue open about the forward port that is OK (again IMHO). Agree 100% that bigger changes must go into trunk first. Regarding this particular issue: I'm generating the release notes from jira now. So as long as this issue is not marked as fixed I can't do that. > Add BigDecimalColumnInterpreter for doing aggregations using AggregationClient > -- > > Key: HBASE-6669 > URL: https://issues.apache.org/jira/browse/HBASE-6669 > Project: HBase > Issue Type: New Feature > Components: Client, Coprocessors >Affects Versions: 0.94.3, 0.96.0 >Reporter: Anil Gupta >Assignee: Anil Gupta >Priority: Minor > Labels: client, coprocessors > Fix For: 0.94.5 > > Attachments: 6669-0.94-v4.txt, 6669-0.94-v5.txt, > BigDecimalColumnInterpreter.java, BigDecimalColumnInterpreter.patch, > BigDecimalColumnInterpreter.patch, HBASE-6669.patch, HBASE-6669-v2.patch, > HBASE-6669-v3.patch, TestBDAggregateProtocol.patch, > TestBigDecimalColumnInterpreter.java > > > I recently created a Class for doing aggregations(sum,min,max,std) on values > stored as BigDecimal in HBase. I would like to commit the > BigDecimalColumnInterpreter into HBase. In my opinion this class can be used > by a wide variety of users. Please let me know if its not appropriate to add > this class in HBase. > Thanks, > Anil Gupta > Software Engineer II, Intuit, Inc -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6669) Add BigDecimalColumnInterpreter for doing aggregations using AggregationClient
[ https://issues.apache.org/jira/browse/HBASE-6669?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13569053#comment-13569053 ] Andrew Purtell commented on HBASE-6669: --- :-) > Add BigDecimalColumnInterpreter for doing aggregations using AggregationClient > -- > > Key: HBASE-6669 > URL: https://issues.apache.org/jira/browse/HBASE-6669 > Project: HBase > Issue Type: New Feature > Components: Client, Coprocessors >Affects Versions: 0.94.3, 0.96.0 >Reporter: Anil Gupta >Assignee: Anil Gupta >Priority: Minor > Labels: client, coprocessors > Fix For: 0.94.5 > > Attachments: 6669-0.94-v4.txt, 6669-0.94-v5.txt, > BigDecimalColumnInterpreter.java, BigDecimalColumnInterpreter.patch, > BigDecimalColumnInterpreter.patch, HBASE-6669.patch, HBASE-6669-v2.patch, > HBASE-6669-v3.patch, TestBDAggregateProtocol.patch, > TestBigDecimalColumnInterpreter.java > > > I recently created a Class for doing aggregations(sum,min,max,std) on values > stored as BigDecimal in HBase. I would like to commit the > BigDecimalColumnInterpreter into HBase. In my opinion this class can be used > by a wide variety of users. Please let me know if its not appropriate to add > this class in HBase. > Thanks, > Anil Gupta > Software Engineer II, Intuit, Inc -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6669) Add BigDecimalColumnInterpreter for doing aggregations using AggregationClient
[ https://issues.apache.org/jira/browse/HBASE-6669?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13569052#comment-13569052 ] Lars Hofhansl commented on HBASE-6669: -- Wait, there's HBASE-7641 and HBASE-7736. > Add BigDecimalColumnInterpreter for doing aggregations using AggregationClient > -- > > Key: HBASE-6669 > URL: https://issues.apache.org/jira/browse/HBASE-6669 > Project: HBase > Issue Type: New Feature > Components: Client, Coprocessors >Affects Versions: 0.94.3, 0.96.0 >Reporter: Anil Gupta >Assignee: Anil Gupta >Priority: Minor > Labels: client, coprocessors > Fix For: 0.94.5 > > Attachments: 6669-0.94-v4.txt, 6669-0.94-v5.txt, > BigDecimalColumnInterpreter.java, BigDecimalColumnInterpreter.patch, > BigDecimalColumnInterpreter.patch, HBASE-6669.patch, HBASE-6669-v2.patch, > HBASE-6669-v3.patch, TestBDAggregateProtocol.patch, > TestBigDecimalColumnInterpreter.java > > > I recently created a Class for doing aggregations(sum,min,max,std) on values > stored as BigDecimal in HBase. I would like to commit the > BigDecimalColumnInterpreter into HBase. In my opinion this class can be used > by a wide variety of users. Please let me know if its not appropriate to add > this class in HBase. > Thanks, > Anil Gupta > Software Engineer II, Intuit, Inc -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6669) Add BigDecimalColumnInterpreter for doing aggregations using AggregationClient
[ https://issues.apache.org/jira/browse/HBASE-6669?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13568993#comment-13568993 ] Ted Yu commented on HBASE-6669: --- @Anil: Take a look at LongColumnInterpreter in trunk as an example. There're a few methods to be implemented for BigDecimalColumnInterpreter. If you have questions, feel free to ask. > Add BigDecimalColumnInterpreter for doing aggregations using AggregationClient > -- > > Key: HBASE-6669 > URL: https://issues.apache.org/jira/browse/HBASE-6669 > Project: HBase > Issue Type: New Feature > Components: Client, Coprocessors >Affects Versions: 0.94.3, 0.96.0 >Reporter: Anil Gupta >Assignee: Anil Gupta >Priority: Minor > Labels: client, coprocessors > Fix For: 0.94.5 > > Attachments: 6669-0.94-v4.txt, 6669-0.94-v5.txt, > BigDecimalColumnInterpreter.java, BigDecimalColumnInterpreter.patch, > BigDecimalColumnInterpreter.patch, HBASE-6669.patch, HBASE-6669-v2.patch, > HBASE-6669-v3.patch, TestBDAggregateProtocol.patch, > TestBigDecimalColumnInterpreter.java > > > I recently created a Class for doing aggregations(sum,min,max,std) on values > stored as BigDecimal in HBase. I would like to commit the > BigDecimalColumnInterpreter into HBase. In my opinion this class can be used > by a wide variety of users. Please let me know if its not appropriate to add > this class in HBase. > Thanks, > Anil Gupta > Software Engineer II, Intuit, Inc -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6669) Add BigDecimalColumnInterpreter for doing aggregations using AggregationClient
[ https://issues.apache.org/jira/browse/HBASE-6669?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13568886#comment-13568886 ] Anil Gupta commented on HBASE-6669: --- [~lhofhansl] Yes, i would like to port it to 0.96 as well. I haven't looked into changes required for porting. I'll try to look into it. > Add BigDecimalColumnInterpreter for doing aggregations using AggregationClient > -- > > Key: HBASE-6669 > URL: https://issues.apache.org/jira/browse/HBASE-6669 > Project: HBase > Issue Type: New Feature > Components: Client, Coprocessors >Affects Versions: 0.94.3 >Reporter: Anil Gupta >Assignee: Anil Gupta >Priority: Minor > Labels: client, coprocessors > Fix For: 0.94.5 > > Attachments: 6669-0.94-v4.txt, 6669-0.94-v5.txt, > BigDecimalColumnInterpreter.java, BigDecimalColumnInterpreter.patch, > BigDecimalColumnInterpreter.patch, HBASE-6669.patch, HBASE-6669-v2.patch, > HBASE-6669-v3.patch, TestBDAggregateProtocol.patch, > TestBigDecimalColumnInterpreter.java > > > I recently created a Class for doing aggregations(sum,min,max,std) on values > stored as BigDecimal in HBase. I would like to commit the > BigDecimalColumnInterpreter into HBase. In my opinion this class can be used > by a wide variety of users. Please let me know if its not appropriate to add > this class in HBase. > Thanks, > Anil Gupta > Software Engineer II, Intuit, Inc -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6669) Add BigDecimalColumnInterpreter for doing aggregations using AggregationClient
[ https://issues.apache.org/jira/browse/HBASE-6669?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13568819#comment-13568819 ] Lars Hofhansl commented on HBASE-6669: -- So this in only in 0.94. I assume we want this in 0.96 as well? > Add BigDecimalColumnInterpreter for doing aggregations using AggregationClient > -- > > Key: HBASE-6669 > URL: https://issues.apache.org/jira/browse/HBASE-6669 > Project: HBase > Issue Type: New Feature > Components: Client, Coprocessors >Affects Versions: 0.94.3 >Reporter: Anil Gupta >Assignee: Anil Gupta >Priority: Minor > Labels: client, coprocessors > Fix For: 0.94.5 > > Attachments: 6669-0.94-v4.txt, 6669-0.94-v5.txt, > BigDecimalColumnInterpreter.java, BigDecimalColumnInterpreter.patch, > BigDecimalColumnInterpreter.patch, HBASE-6669.patch, HBASE-6669-v2.patch, > HBASE-6669-v3.patch, TestBDAggregateProtocol.patch, > TestBigDecimalColumnInterpreter.java > > > I recently created a Class for doing aggregations(sum,min,max,std) on values > stored as BigDecimal in HBase. I would like to commit the > BigDecimalColumnInterpreter into HBase. In my opinion this class can be used > by a wide variety of users. Please let me know if its not appropriate to add > this class in HBase. > Thanks, > Anil Gupta > Software Engineer II, Intuit, Inc -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6669) Add BigDecimalColumnInterpreter for doing aggregations using AggregationClient
[ https://issues.apache.org/jira/browse/HBASE-6669?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13561707#comment-13561707 ] Hudson commented on HBASE-6669: --- Integrated in HBase-0.94-security #96 (See [https://builds.apache.org/job/HBase-0.94-security/96/]) HBASE-6669 Add BigDecimalColumnInterpreter for doing aggregations using AggregationClient (Anil Gupta) (Revision 1436726) Result = FAILURE tedyu : Files : * /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/client/coprocessor/BigDecimalColumnInterpreter.java * /hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/coprocessor/TestBigDecimalColumnInterpreter.java > Add BigDecimalColumnInterpreter for doing aggregations using AggregationClient > -- > > Key: HBASE-6669 > URL: https://issues.apache.org/jira/browse/HBASE-6669 > Project: HBase > Issue Type: New Feature > Components: Client, Coprocessors >Affects Versions: 0.94.3 >Reporter: Anil Gupta >Priority: Minor > Labels: client, coprocessors > Fix For: 0.94.5 > > Attachments: 6669-0.94-v4.txt, 6669-0.94-v5.txt, > BigDecimalColumnInterpreter.java, BigDecimalColumnInterpreter.patch, > BigDecimalColumnInterpreter.patch, HBASE-6669.patch, HBASE-6669-v2.patch, > HBASE-6669-v3.patch, TestBDAggregateProtocol.patch, > TestBigDecimalColumnInterpreter.java > > > I recently created a Class for doing aggregations(sum,min,max,std) on values > stored as BigDecimal in HBase. I would like to commit the > BigDecimalColumnInterpreter into HBase. In my opinion this class can be used > by a wide variety of users. Please let me know if its not appropriate to add > this class in HBase. > Thanks, > Anil Gupta > Software Engineer II, Intuit, Inc -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6669) Add BigDecimalColumnInterpreter for doing aggregations using AggregationClient
[ https://issues.apache.org/jira/browse/HBASE-6669?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13559391#comment-13559391 ] Hudson commented on HBASE-6669: --- Integrated in HBase-0.94 #750 (See [https://builds.apache.org/job/HBase-0.94/750/]) HBASE-6669 Add BigDecimalColumnInterpreter for doing aggregations using AggregationClient (Anil Gupta) (Revision 1436726) Result = SUCCESS tedyu : Files : * /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/client/coprocessor/BigDecimalColumnInterpreter.java * /hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/coprocessor/TestBigDecimalColumnInterpreter.java > Add BigDecimalColumnInterpreter for doing aggregations using AggregationClient > -- > > Key: HBASE-6669 > URL: https://issues.apache.org/jira/browse/HBASE-6669 > Project: HBase > Issue Type: New Feature > Components: Client, Coprocessors >Affects Versions: 0.94.3 >Reporter: Anil Gupta >Priority: Minor > Labels: client, coprocessors > Fix For: 0.94.5 > > Attachments: 6669-0.94-v4.txt, 6669-0.94-v5.txt, > BigDecimalColumnInterpreter.java, BigDecimalColumnInterpreter.patch, > BigDecimalColumnInterpreter.patch, HBASE-6669.patch, HBASE-6669-v2.patch, > HBASE-6669-v3.patch, TestBDAggregateProtocol.patch, > TestBigDecimalColumnInterpreter.java > > > I recently created a Class for doing aggregations(sum,min,max,std) on values > stored as BigDecimal in HBase. I would like to commit the > BigDecimalColumnInterpreter into HBase. In my opinion this class can be used > by a wide variety of users. Please let me know if its not appropriate to add > this class in HBase. > Thanks, > Anil Gupta > Software Engineer II, Intuit, Inc -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6669) Add BigDecimalColumnInterpreter for doing aggregations using AggregationClient
[ https://issues.apache.org/jira/browse/HBASE-6669?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13559295#comment-13559295 ] Ted Yu commented on HBASE-6669: --- Integrated to 0.94 branch. Thanks for the patch, Anil. Thanks for the review, Lars. > Add BigDecimalColumnInterpreter for doing aggregations using AggregationClient > -- > > Key: HBASE-6669 > URL: https://issues.apache.org/jira/browse/HBASE-6669 > Project: HBase > Issue Type: New Feature > Components: Client, Coprocessors >Affects Versions: 0.94.3 >Reporter: Anil Gupta >Priority: Minor > Labels: client, coprocessors > Fix For: 0.94.5 > > Attachments: 6669-0.94-v4.txt, 6669-0.94-v5.txt, > BigDecimalColumnInterpreter.java, BigDecimalColumnInterpreter.patch, > BigDecimalColumnInterpreter.patch, HBASE-6669.patch, HBASE-6669-v2.patch, > HBASE-6669-v3.patch, TestBDAggregateProtocol.patch, > TestBigDecimalColumnInterpreter.java > > > I recently created a Class for doing aggregations(sum,min,max,std) on values > stored as BigDecimal in HBase. I would like to commit the > BigDecimalColumnInterpreter into HBase. In my opinion this class can be used > by a wide variety of users. Please let me know if its not appropriate to add > this class in HBase. > Thanks, > Anil Gupta > Software Engineer II, Intuit, Inc -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6669) Add BigDecimalColumnInterpreter for doing aggregations using AggregationClient
[ https://issues.apache.org/jira/browse/HBASE-6669?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13559286#comment-13559286 ] Lars Hofhansl commented on HBASE-6669: -- Awesome, thanks Ted! +1 on commit. > Add BigDecimalColumnInterpreter for doing aggregations using AggregationClient > -- > > Key: HBASE-6669 > URL: https://issues.apache.org/jira/browse/HBASE-6669 > Project: HBase > Issue Type: New Feature > Components: Client, Coprocessors >Affects Versions: 0.94.3 >Reporter: Anil Gupta >Priority: Minor > Labels: client, coprocessors > Fix For: 0.94.5 > > Attachments: 6669-0.94-v4.txt, 6669-0.94-v5.txt, > BigDecimalColumnInterpreter.java, BigDecimalColumnInterpreter.patch, > BigDecimalColumnInterpreter.patch, HBASE-6669.patch, HBASE-6669-v2.patch, > HBASE-6669-v3.patch, TestBDAggregateProtocol.patch, > TestBigDecimalColumnInterpreter.java > > > I recently created a Class for doing aggregations(sum,min,max,std) on values > stored as BigDecimal in HBase. I would like to commit the > BigDecimalColumnInterpreter into HBase. In my opinion this class can be used > by a wide variety of users. Please let me know if its not appropriate to add > this class in HBase. > Thanks, > Anil Gupta > Software Engineer II, Intuit, Inc -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6669) Add BigDecimalColumnInterpreter for doing aggregations using AggregationClient
[ https://issues.apache.org/jira/browse/HBASE-6669?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13558519#comment-13558519 ] Anil Gupta commented on HBASE-6669: --- [~lhofhansl] Thanks for extending your support. This trivial patch took me a lot of time/effort in formatting due to unknown reasons. I hope that same doesn't happens in HBASE-7474. Let me know if i need to do anything further in this. Ecstatic to get my first patch in HBase.YAY!! :D > Add BigDecimalColumnInterpreter for doing aggregations using AggregationClient > -- > > Key: HBASE-6669 > URL: https://issues.apache.org/jira/browse/HBASE-6669 > Project: HBase > Issue Type: New Feature > Components: Client, Coprocessors >Affects Versions: 0.94.3 >Reporter: Anil Gupta >Priority: Minor > Labels: client, coprocessors > Fix For: 0.94.5 > > Attachments: 6669-0.94-v4.txt, BigDecimalColumnInterpreter.java, > BigDecimalColumnInterpreter.patch, BigDecimalColumnInterpreter.patch, > HBASE-6669.patch, HBASE-6669-v2.patch, HBASE-6669-v3.patch, > TestBDAggregateProtocol.patch, TestBigDecimalColumnInterpreter.java > > > I recently created a Class for doing aggregations(sum,min,max,std) on values > stored as BigDecimal in HBase. I would like to commit the > BigDecimalColumnInterpreter into HBase. In my opinion this class can be used > by a wide variety of users. Please let me know if its not appropriate to add > this class in HBase. > Thanks, > Anil Gupta > Software Engineer II, Intuit, Inc -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6669) Add BigDecimalColumnInterpreter for doing aggregations using AggregationClient
[ https://issues.apache.org/jira/browse/HBASE-6669?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13558499#comment-13558499 ] Lars Hofhansl commented on HBASE-6669: -- Let's get this in. And let's please not argue about empty line. :) I'll format the patch according to our guidelines and will attach a new version soon. > Add BigDecimalColumnInterpreter for doing aggregations using AggregationClient > -- > > Key: HBASE-6669 > URL: https://issues.apache.org/jira/browse/HBASE-6669 > Project: HBase > Issue Type: New Feature > Components: Client, Coprocessors >Affects Versions: 0.94.3 >Reporter: Anil Gupta >Priority: Minor > Labels: client, coprocessors > Fix For: 0.94.5 > > Attachments: 6669-0.94-v4.txt, BigDecimalColumnInterpreter.java, > BigDecimalColumnInterpreter.patch, BigDecimalColumnInterpreter.patch, > HBASE-6669.patch, HBASE-6669-v2.patch, HBASE-6669-v3.patch, > TestBDAggregateProtocol.patch, TestBigDecimalColumnInterpreter.java > > > I recently created a Class for doing aggregations(sum,min,max,std) on values > stored as BigDecimal in HBase. I would like to commit the > BigDecimalColumnInterpreter into HBase. In my opinion this class can be used > by a wide variety of users. Please let me know if its not appropriate to add > this class in HBase. > Thanks, > Anil Gupta > Software Engineer II, Intuit, Inc -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6669) Add BigDecimalColumnInterpreter for doing aggregations using AggregationClient
[
https://issues.apache.org/jira/browse/HBASE-6669?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13544045#comment-13544045
]
Ted Yu commented on HBASE-6669:
---
{code}
+ public void testMaxWithValidRange() throws Throwable {
{code}
Do you specify range in the above method ? Range is specified in
testMaxWithValidRange2
{code}
+ public void testMaxWithValidRangeWithNoCQ() throws Throwable {
{code}
Rename the method testMaxWithValidRangeWithoutCQ
{code}
+log.debug("Inside readFields method of DoubleColumnInterpreter");^M
{code}
Please remove unnecessary debug logs.
{code}
+ public BigDecimal getValue(byte[] paramArrayOfByte1, byte[]
paramArrayOfByte2, KeyValue kv)^M
{code}
The first two parameters are family and qualifier. Please name them accordingly.
{code}
+if val1 == null) ? 1 : 0) ^ ((val2 == null) ? 1 : 0)) != 0) return
((val1 == null) ? val2^M
+: val1);^M
{code}
Since the if statement spans two lines, use curly braces to surround the return
statement.
I don't know where the ^M came from. It would be nice to remove them (using
tool such as dos2unix).
> Add BigDecimalColumnInterpreter for doing aggregations using AggregationClient
> --
>
> Key: HBASE-6669
> URL: https://issues.apache.org/jira/browse/HBASE-6669
> Project: HBase
> Issue Type: New Feature
> Components: Client, Coprocessors
>Affects Versions: 0.94.3
>Reporter: Anil Gupta
>Priority: Minor
> Labels: client, coprocessors
> Fix For: 0.94.5
>
> Attachments: 6669-0.94-v4.txt, BigDecimalColumnInterpreter.java,
> BigDecimalColumnInterpreter.patch, BigDecimalColumnInterpreter.patch,
> HBASE-6669.patch, HBASE-6669-v2.patch, HBASE-6669-v3.patch,
> TestBDAggregateProtocol.patch, TestBigDecimalColumnInterpreter.java
>
>
> I recently created a Class for doing aggregations(sum,min,max,std) on values
> stored as BigDecimal in HBase. I would like to commit the
> BigDecimalColumnInterpreter into HBase. In my opinion this class can be used
> by a wide variety of users. Please let me know if its not appropriate to add
> this class in HBase.
> Thanks,
> Anil Gupta
> Software Engineer II, Intuit, Inc
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6669) Add BigDecimalColumnInterpreter for doing aggregations using AggregationClient
[ https://issues.apache.org/jira/browse/HBASE-6669?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13543498#comment-13543498 ] Anil Gupta commented on HBASE-6669: --- anil_gupta:~ anil$ svn --version svn, version 1.6.17 (r1128011) compiled Nov 8 2011, 18:14:46 anil_gupta:0.94.3 anil$ svn diff | grep 'Index:' svn: The path '.' appears to be part of a Subversion 1.7 or greater working copy. Please upgrade your Subversion client to use this working copy. It seems like a minor update is making a big difference. :( > Add BigDecimalColumnInterpreter for doing aggregations using AggregationClient > -- > > Key: HBASE-6669 > URL: https://issues.apache.org/jira/browse/HBASE-6669 > Project: HBase > Issue Type: New Feature > Components: Client, Coprocessors >Affects Versions: 0.94.3 >Reporter: Anil Gupta >Priority: Minor > Labels: client, coprocessors > Fix For: 0.94.5 > > Attachments: 6669-0.94-v4.txt, BigDecimalColumnInterpreter.java, > BigDecimalColumnInterpreter.patch, BigDecimalColumnInterpreter.patch, > HBASE-6669.patch, HBASE-6669-v2.patch, HBASE-6669-v3.patch, > TestBDAggregateProtocol.patch, TestBigDecimalColumnInterpreter.java > > > I recently created a Class for doing aggregations(sum,min,max,std) on values > stored as BigDecimal in HBase. I would like to commit the > BigDecimalColumnInterpreter into HBase. In my opinion this class can be used > by a wide variety of users. Please let me know if its not appropriate to add > this class in HBase. > Thanks, > Anil Gupta > Software Engineer II, Intuit, Inc -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6669) Add BigDecimalColumnInterpreter for doing aggregations using AggregationClient
[ https://issues.apache.org/jira/browse/HBASE-6669?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13543420#comment-13543420 ] Ted Yu commented on HBASE-6669: --- If patch v4 still contains empty line, you can attach the two new files to this JIRA. > Add BigDecimalColumnInterpreter for doing aggregations using AggregationClient > -- > > Key: HBASE-6669 > URL: https://issues.apache.org/jira/browse/HBASE-6669 > Project: HBase > Issue Type: New Feature > Components: Client, Coprocessors >Affects Versions: 0.94.3 >Reporter: Anil Gupta >Priority: Minor > Labels: client, coprocessors > Fix For: 0.94.5 > > Attachments: BigDecimalColumnInterpreter.java, > BigDecimalColumnInterpreter.patch, BigDecimalColumnInterpreter.patch, > HBASE-6669.patch, HBASE-6669-v2.patch, HBASE-6669-v3.patch, > TestBDAggregateProtocol.patch > > > I recently created a Class for doing aggregations(sum,min,max,std) on values > stored as BigDecimal in HBase. I would like to commit the > BigDecimalColumnInterpreter into HBase. In my opinion this class can be used > by a wide variety of users. Please let me know if its not appropriate to add > this class in HBase. > Thanks, > Anil Gupta > Software Engineer II, Intuit, Inc -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6669) Add BigDecimalColumnInterpreter for doing aggregations using AggregationClient
[
https://issues.apache.org/jira/browse/HBASE-6669?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13543323#comment-13543323
]
Hadoop QA commented on HBASE-6669:
--
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12563143/HBASE-6669-v3.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 3 new
or modified tests.
{color:red}-1 patch{color}. The patch command could not apply the patch.
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/3837//console
This message is automatically generated.
> Add BigDecimalColumnInterpreter for doing aggregations using AggregationClient
> --
>
> Key: HBASE-6669
> URL: https://issues.apache.org/jira/browse/HBASE-6669
> Project: HBase
> Issue Type: New Feature
> Components: Client, Coprocessors
>Affects Versions: 0.94.3
>Reporter: Anil Gupta
>Priority: Minor
> Labels: client, coprocessors
> Fix For: 0.94.5
>
> Attachments: BigDecimalColumnInterpreter.java,
> BigDecimalColumnInterpreter.patch, BigDecimalColumnInterpreter.patch,
> HBASE-6669.patch, HBASE-6669-v2.patch, HBASE-6669-v3.patch,
> TestBDAggregateProtocol.patch
>
>
> I recently created a Class for doing aggregations(sum,min,max,std) on values
> stored as BigDecimal in HBase. I would like to commit the
> BigDecimalColumnInterpreter into HBase. In my opinion this class can be used
> by a wide variety of users. Please let me know if its not appropriate to add
> this class in HBase.
> Thanks,
> Anil Gupta
> Software Engineer II, Intuit, Inc
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6669) Add BigDecimalColumnInterpreter for doing aggregations using AggregationClient
[ https://issues.apache.org/jira/browse/HBASE-6669?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13543269#comment-13543269 ] Ted Yu commented on HBASE-6669: --- There is still empty line in patch v3. I use the following alias to obtain list of files modified locally: alias slst="svn diff | grep 'Index:'" Once you have the list, you can use the following to generate patch: svn diff 'path-to-file1' > 6669-0.94.txt svn diff 'path-to-file2' >> 6669-0.94.txt > Add BigDecimalColumnInterpreter for doing aggregations using AggregationClient > -- > > Key: HBASE-6669 > URL: https://issues.apache.org/jira/browse/HBASE-6669 > Project: HBase > Issue Type: New Feature > Components: Client, Coprocessors >Affects Versions: 0.94.3 >Reporter: Anil Gupta >Priority: Minor > Labels: client, coprocessors > Fix For: 0.94.5 > > Attachments: BigDecimalColumnInterpreter.java, > BigDecimalColumnInterpreter.patch, BigDecimalColumnInterpreter.patch, > HBASE-6669.patch, HBASE-6669-v2.patch, HBASE-6669-v3.patch, > TestBDAggregateProtocol.patch > > > I recently created a Class for doing aggregations(sum,min,max,std) on values > stored as BigDecimal in HBase. I would like to commit the > BigDecimalColumnInterpreter into HBase. In my opinion this class can be used > by a wide variety of users. Please let me know if its not appropriate to add > this class in HBase. > Thanks, > Anil Gupta > Software Engineer II, Intuit, Inc -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6669) Add BigDecimalColumnInterpreter for doing aggregations using AggregationClient
[
https://issues.apache.org/jira/browse/HBASE-6669?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13543199#comment-13543199
]
Ted Yu commented on HBASE-6669:
---
There're empty lines in BigDecimalColumnInterpreter.java but not in
TestBigDecimalColumnInterpreter.java
The license headers in both files don't look the same as in other source files.
When I tried to apply the patch:
{code}
p0 6669-v2.patch
patching file
src/main/java/org/apache/hadoop/hbase/client/coprocessor/BigDecimalColumnInterpreter.java
patch: malformed patch at line 7:
{code}
Have you tried using svn command to generate patch ?
Please remove the empty lines in patch.
> Add BigDecimalColumnInterpreter for doing aggregations using AggregationClient
> --
>
> Key: HBASE-6669
> URL: https://issues.apache.org/jira/browse/HBASE-6669
> Project: HBase
> Issue Type: New Feature
> Components: Client, Coprocessors
>Affects Versions: 0.94.3
>Reporter: Anil Gupta
>Priority: Minor
> Labels: client, coprocessors
> Fix For: 0.94.5
>
> Attachments: BigDecimalColumnInterpreter.java,
> BigDecimalColumnInterpreter.patch, BigDecimalColumnInterpreter.patch,
> HBASE-6669.patch, HBASE-6669-v2.patch, TestBDAggregateProtocol.patch
>
>
> I recently created a Class for doing aggregations(sum,min,max,std) on values
> stored as BigDecimal in HBase. I would like to commit the
> BigDecimalColumnInterpreter into HBase. In my opinion this class can be used
> by a wide variety of users. Please let me know if its not appropriate to add
> this class in HBase.
> Thanks,
> Anil Gupta
> Software Engineer II, Intuit, Inc
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6669) Add BigDecimalColumnInterpreter for doing aggregations using AggregationClient
[ https://issues.apache.org/jira/browse/HBASE-6669?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13543198#comment-13543198 ] Anil Gupta commented on HBASE-6669: --- Can someone tell me what's wrong with the patch now? I followed the instructions to create then also it didn't go through. Thanks in advance. > Add BigDecimalColumnInterpreter for doing aggregations using AggregationClient > -- > > Key: HBASE-6669 > URL: https://issues.apache.org/jira/browse/HBASE-6669 > Project: HBase > Issue Type: New Feature > Components: Client, Coprocessors >Affects Versions: 0.94.3 >Reporter: Anil Gupta >Priority: Minor > Labels: client, coprocessors > Fix For: 0.94.5 > > Attachments: BigDecimalColumnInterpreter.java, > BigDecimalColumnInterpreter.patch, BigDecimalColumnInterpreter.patch, > HBASE-6669.patch, HBASE-6669-v2.patch, TestBDAggregateProtocol.patch > > > I recently created a Class for doing aggregations(sum,min,max,std) on values > stored as BigDecimal in HBase. I would like to commit the > BigDecimalColumnInterpreter into HBase. In my opinion this class can be used > by a wide variety of users. Please let me know if its not appropriate to add > this class in HBase. > Thanks, > Anil Gupta > Software Engineer II, Intuit, Inc -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6669) Add BigDecimalColumnInterpreter for doing aggregations using AggregationClient
[
https://issues.apache.org/jira/browse/HBASE-6669?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13543195#comment-13543195
]
Hadoop QA commented on HBASE-6669:
--
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12563128/HBASE-6669-v2.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 3 new
or modified tests.
{color:red}-1 patch{color}. The patch command could not apply the patch.
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/3830//console
This message is automatically generated.
> Add BigDecimalColumnInterpreter for doing aggregations using AggregationClient
> --
>
> Key: HBASE-6669
> URL: https://issues.apache.org/jira/browse/HBASE-6669
> Project: HBase
> Issue Type: New Feature
> Components: Client, Coprocessors
>Affects Versions: 0.94.3
>Reporter: Anil Gupta
>Priority: Minor
> Labels: client, coprocessors
> Fix For: 0.94.5
>
> Attachments: BigDecimalColumnInterpreter.java,
> BigDecimalColumnInterpreter.patch, BigDecimalColumnInterpreter.patch,
> HBASE-6669.patch, HBASE-6669-v2.patch, TestBDAggregateProtocol.patch
>
>
> I recently created a Class for doing aggregations(sum,min,max,std) on values
> stored as BigDecimal in HBase. I would like to commit the
> BigDecimalColumnInterpreter into HBase. In my opinion this class can be used
> by a wide variety of users. Please let me know if its not appropriate to add
> this class in HBase.
> Thanks,
> Anil Gupta
> Software Engineer II, Intuit, Inc
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6669) Add BigDecimalColumnInterpreter for doing aggregations using AggregationClient
[ https://issues.apache.org/jira/browse/HBASE-6669?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13542589#comment-13542589 ] Ted Yu commented on HBASE-6669: --- @Anil: The formatter wouldn't remove empty lines. Do you see empty lines in Eclipse ? > Add BigDecimalColumnInterpreter for doing aggregations using AggregationClient > -- > > Key: HBASE-6669 > URL: https://issues.apache.org/jira/browse/HBASE-6669 > Project: HBase > Issue Type: New Feature > Components: Client, Coprocessors >Affects Versions: 0.94.3 >Reporter: Anil Gupta >Priority: Minor > Labels: client, coprocessors > Fix For: 0.94.5 > > Attachments: BigDecimalColumnInterpreter.java, > BigDecimalColumnInterpreter.patch, BigDecimalColumnInterpreter.patch, > HBASE-6669.patch, TestBDAggregateProtocol.patch > > > I recently created a Class for doing aggregations(sum,min,max,std) on values > stored as BigDecimal in HBase. I would like to commit the > BigDecimalColumnInterpreter into HBase. In my opinion this class can be used > by a wide variety of users. Please let me know if its not appropriate to add > this class in HBase. > Thanks, > Anil Gupta > Software Engineer II, Intuit, Inc -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6669) Add BigDecimalColumnInterpreter for doing aggregations using AggregationClient
[ https://issues.apache.org/jira/browse/HBASE-6669?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13541981#comment-13541981 ] Anil Gupta commented on HBASE-6669: --- Hi Ted, I've already used the HBase Formatter in the current patch. Does the formatter removes empty lines? > Add BigDecimalColumnInterpreter for doing aggregations using AggregationClient > -- > > Key: HBASE-6669 > URL: https://issues.apache.org/jira/browse/HBASE-6669 > Project: HBase > Issue Type: New Feature > Components: Client, Coprocessors >Affects Versions: 0.94.3 >Reporter: Anil Gupta >Priority: Minor > Labels: client, coprocessors > Fix For: 0.94.3, 0.94.4 > > Attachments: BigDecimalColumnInterpreter.java, > BigDecimalColumnInterpreter.patch, BigDecimalColumnInterpreter.patch, > HBASE-6669.patch, TestBDAggregateProtocol.patch > > > I recently created a Class for doing aggregations(sum,min,max,std) on values > stored as BigDecimal in HBase. I would like to commit the > BigDecimalColumnInterpreter into HBase. In my opinion this class can be used > by a wide variety of users. Please let me know if its not appropriate to add > this class in HBase. > Thanks, > Anil Gupta > Software Engineer II, Intuit, Inc -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6669) Add BigDecimalColumnInterpreter for doing aggregations using AggregationClient
[ https://issues.apache.org/jira/browse/HBASE-6669?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13541962#comment-13541962 ] Ted Yu commented on HBASE-6669: --- Take a look at http://hbase.apache.org/book.html#submitting.patches In trunk, you can import dev-support/hbase_eclipse_formatter.xml to Eclipse. In your recent patch, there are empty lines between code. Those empty lines should be removed. > Add BigDecimalColumnInterpreter for doing aggregations using AggregationClient > -- > > Key: HBASE-6669 > URL: https://issues.apache.org/jira/browse/HBASE-6669 > Project: HBase > Issue Type: New Feature > Components: Client, Coprocessors >Affects Versions: 0.94.3 >Reporter: Anil Gupta >Priority: Minor > Labels: client, coprocessors > Fix For: 0.94.3, 0.94.4 > > Attachments: BigDecimalColumnInterpreter.java, > BigDecimalColumnInterpreter.patch, BigDecimalColumnInterpreter.patch, > HBASE-6669.patch, TestBDAggregateProtocol.patch > > > I recently created a Class for doing aggregations(sum,min,max,std) on values > stored as BigDecimal in HBase. I would like to commit the > BigDecimalColumnInterpreter into HBase. In my opinion this class can be used > by a wide variety of users. Please let me know if its not appropriate to add > this class in HBase. > Thanks, > Anil Gupta > Software Engineer II, Intuit, Inc -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6669) Add BigDecimalColumnInterpreter for doing aggregations using AggregationClient
[ https://issues.apache.org/jira/browse/HBASE-6669?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13541940#comment-13541940 ] Anil Gupta commented on HBASE-6669: --- Can anyone tell me how to create the patch in the correct way from eclipse? or svn command? Thanks, Anil Gupta Software Engineer II, Intuit, inc > Add BigDecimalColumnInterpreter for doing aggregations using AggregationClient > -- > > Key: HBASE-6669 > URL: https://issues.apache.org/jira/browse/HBASE-6669 > Project: HBase > Issue Type: New Feature > Components: Client, Coprocessors >Affects Versions: 0.94.3 >Reporter: Anil Gupta >Priority: Minor > Labels: client, coprocessors > Fix For: 0.94.3, 0.94.4 > > Attachments: BigDecimalColumnInterpreter.java, > BigDecimalColumnInterpreter.patch, BigDecimalColumnInterpreter.patch, > HBASE-6669.patch, TestBDAggregateProtocol.patch > > > I recently created a Class for doing aggregations(sum,min,max,std) on values > stored as BigDecimal in HBase. I would like to commit the > BigDecimalColumnInterpreter into HBase. In my opinion this class can be used > by a wide variety of users. Please let me know if its not appropriate to add > this class in HBase. > Thanks, > Anil Gupta > Software Engineer II, Intuit, Inc -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6669) Add BigDecimalColumnInterpreter for doing aggregations using AggregationClient
[
https://issues.apache.org/jira/browse/HBASE-6669?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13541921#comment-13541921
]
Hadoop QA commented on HBASE-6669:
--
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12562860/HBASE-6669.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 3 new
or modified tests.
{color:red}-1 patch{color}. The patch command could not apply the patch.
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/3797//console
This message is automatically generated.
> Add BigDecimalColumnInterpreter for doing aggregations using AggregationClient
> --
>
> Key: HBASE-6669
> URL: https://issues.apache.org/jira/browse/HBASE-6669
> Project: HBase
> Issue Type: New Feature
> Components: Client, Coprocessors
>Affects Versions: 0.94.3
>Reporter: Anil Gupta
>Priority: Minor
> Labels: client, coprocessors
> Fix For: 0.94.3, 0.94.4
>
> Attachments: BigDecimalColumnInterpreter.java,
> BigDecimalColumnInterpreter.patch, BigDecimalColumnInterpreter.patch,
> HBASE-6669.patch, TestBDAggregateProtocol.patch
>
>
> I recently created a Class for doing aggregations(sum,min,max,std) on values
> stored as BigDecimal in HBase. I would like to commit the
> BigDecimalColumnInterpreter into HBase. In my opinion this class can be used
> by a wide variety of users. Please let me know if its not appropriate to add
> this class in HBase.
> Thanks,
> Anil Gupta
> Software Engineer II, Intuit, Inc
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6669) Add BigDecimalColumnInterpreter for doing aggregations using AggregationClient
[ https://issues.apache.org/jira/browse/HBASE-6669?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13459787#comment-13459787 ] Anil Gupta commented on HBASE-6669: --- Hi Julian, I am curious to know whether you got the opportunity to test BDCI utility i sent(on hbase user list) last week along with some suggestions on using it? Did it run successfully? I will try to have a look at your unit test over weekend. Thanks, Anil Gupta Software Engineer II, Intuit, Inc > Add BigDecimalColumnInterpreter for doing aggregations using AggregationClient > -- > > Key: HBASE-6669 > URL: https://issues.apache.org/jira/browse/HBASE-6669 > Project: HBase > Issue Type: New Feature > Components: client, coprocessors >Reporter: Anil Gupta >Priority: Minor > Labels: client, coprocessors > Attachments: BigDecimalColumnInterpreter.java, > BigDecimalColumnInterpreter.patch, BigDecimalColumnInterpreter.patch > > > I recently created a Class for doing aggregations(sum,min,max,std) on values > stored as BigDecimal in HBase. I would like to commit the > BigDecimalColumnInterpreter into HBase. In my opinion this class can be used > by a wide variety of users. Please let me know if its not appropriate to add > this class in HBase. > Thanks, > Anil Gupta > Software Engineer II, Intuit, Inc -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6669) Add BigDecimalColumnInterpreter for doing aggregations using AggregationClient
[ https://issues.apache.org/jira/browse/HBASE-6669?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13459648#comment-13459648 ] Julian Wissmann commented on HBASE-6669: I've written a Test for BDColumnInterpreter, however, all Medium Tests requiring MiniDFSCluster fail on my machine: --- Test set: org.apache.hadoop.hbase.coprocessor.TestAggregateProtocol --- Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 3.239 sec <<< FAILURE! org.apache.hadoop.hbase.coprocessor.TestAggregateProtocol Time elapsed: 0.001 sec <<< ERROR! java.lang.NullPointerException at org.apache.hadoop.hdfs.MiniDFSCluster.startDataNodes(MiniDFSCluster.java:422) at org.apache.hadoop.hdfs.MiniDFSCluster.(MiniDFSCluster.java:280) at org.apache.hadoop.hbase.HBaseTestingUtility.startMiniDFSCluster(HBaseTestingUtility.java:433) at org.apache.hadoop.hbase.HBaseTestingUtility.startMiniCluster(HBaseTestingUtility.java:653) at org.apache.hadoop.hbase.HBaseTestingUtility.startMiniCluster(HBaseTestingUtility.java:603) at org.apache.hadoop.hbase.HBaseTestingUtility.startMiniCluster(HBaseTestingUtility.java:590) at org.apache.hadoop.hbase.coprocessor.TestAggregateProtocol.setupBeforeClass(TestAggregateProtocol.java:77) at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25) at java.lang.reflect.Method.invoke(Method.java:597) at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:45) at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:15) at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:42) at org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:27) at org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:30) at org.junit.runners.ParentRunner.run(ParentRunner.java:300) at org.junit.runners.Suite.runChild(Suite.java:128) at org.junit.runners.Suite.runChild(Suite.java:24) at org.junit.runners.ParentRunner$3.run(ParentRunner.java:231) at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:441) at java.util.concurrent.FutureTask$Sync.innerRun(FutureTask.java:303) at java.util.concurrent.FutureTask.run(FutureTask.java:138) at java.util.concurrent.ThreadPoolExecutor$Worker.runTask(ThreadPoolExecutor.java:886) at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:908) at java.lang.Thread.run(Thread.java:662) Therefor I have not been able to do a run of my test, so far. I can however attach it here, if someone who does not run into this problem is willing to give it a try. > Add BigDecimalColumnInterpreter for doing aggregations using AggregationClient > -- > > Key: HBASE-6669 > URL: https://issues.apache.org/jira/browse/HBASE-6669 > Project: HBase > Issue Type: New Feature > Components: client, coprocessors >Reporter: Anil Gupta >Priority: Minor > Labels: client, coprocessors > Attachments: BigDecimalColumnInterpreter.java, > BigDecimalColumnInterpreter.patch, BigDecimalColumnInterpreter.patch > > > I recently created a Class for doing aggregations(sum,min,max,std) on values > stored as BigDecimal in HBase. I would like to commit the > BigDecimalColumnInterpreter into HBase. In my opinion this class can be used > by a wide variety of users. Please let me know if its not appropriate to add > this class in HBase. > Thanks, > Anil Gupta > Software Engineer II, Intuit, Inc -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6669) Add BigDecimalColumnInterpreter for doing aggregations using AggregationClient
[ https://issues.apache.org/jira/browse/HBASE-6669?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13449067#comment-13449067 ] Ted Yu commented on HBASE-6669: --- Since there're two BigDecimal fields in BigDecimalColumnInterpreter, you need to implement readFields() and write() for serialization. > Add BigDecimalColumnInterpreter for doing aggregations using AggregationClient > -- > > Key: HBASE-6669 > URL: https://issues.apache.org/jira/browse/HBASE-6669 > Project: HBase > Issue Type: New Feature > Components: client, coprocessors >Reporter: Anil Gupta >Priority: Minor > Labels: client, coprocessors > Attachments: BigDecimalColumnInterpreter.java, > BigDecimalColumnInterpreter.patch, BigDecimalColumnInterpreter.patch > > > I recently created a Class for doing aggregations(sum,min,max,std) on values > stored as BigDecimal in HBase. I would like to commit the > BigDecimalColumnInterpreter into HBase. In my opinion this class can be used > by a wide variety of users. Please let me know if its not appropriate to add > this class in HBase. > Thanks, > Anil Gupta > Software Engineer II, Intuit, Inc -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6669) Add BigDecimalColumnInterpreter for doing aggregations using AggregationClient
[
https://issues.apache.org/jira/browse/HBASE-6669?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13448142#comment-13448142
]
Ted Yu commented on HBASE-6669:
---
To generate patch, from the root of your workspace, type:
{code}
svn diff
hbase-server/src/main/java/org/apache/hadoop/hbase/client/coprocessor/BigDecimalColumnInterpreter.java
{code}
Year is not needed for license:
{code}
+ * Copyright 2011 The Apache Software Foundation
{code}
Remove the following comment:
{code}
+// TODO Auto-generated method stub
{code}
Either move the return statement to the end of if statement or enclose it in
curly braces:
{code}
+if (val1 == null)
+ return null;
{code}
The rest looks fine.
TestAggregateProtocol tests LongColumnInterpreter. You should create a new test
file to test your class.
Thanks
> Add BigDecimalColumnInterpreter for doing aggregations using AggregationClient
> --
>
> Key: HBASE-6669
> URL: https://issues.apache.org/jira/browse/HBASE-6669
> Project: HBase
> Issue Type: New Feature
> Components: client, coprocessors
>Reporter: Anil Gupta
>Priority: Minor
> Labels: client, coprocessors
> Attachments: BigDecimalColumnInterpreter.java,
> BigDecimalColumnInterpreter.patch, BigDecimalColumnInterpreter.patch
>
>
> I recently created a Class for doing aggregations(sum,min,max,std) on values
> stored as BigDecimal in HBase. I would like to commit the
> BigDecimalColumnInterpreter into HBase. In my opinion this class can be used
> by a wide variety of users. Please let me know if its not appropriate to add
> this class in HBase.
> Thanks,
> Anil Gupta
> Software Engineer II, Intuit, Inc
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6669) Add BigDecimalColumnInterpreter for doing aggregations using AggregationClient
[ https://issues.apache.org/jira/browse/HBASE-6669?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13448126#comment-13448126 ] Anil Gupta commented on HBASE-6669: --- [~ted_yu] This time i created the patch from "hbase-server"->"src/main/java". I hope it's ok this time. Sorry, this is the first time i am submitting patch. I changed 0.0D/0.0D to "Double.NaN" in divideForAvg(). Is this fine? Should i create a separate class for Unit Tests or put my test cases in TestAggregateProtocol? Thanks, Anil Gupta Software Engineer II, Intuit, Inc > Add BigDecimalColumnInterpreter for doing aggregations using AggregationClient > -- > > Key: HBASE-6669 > URL: https://issues.apache.org/jira/browse/HBASE-6669 > Project: HBase > Issue Type: New Feature > Components: client, coprocessors >Reporter: Anil Gupta >Priority: Minor > Labels: client, coprocessors > Attachments: BigDecimalColumnInterpreter.java, > BigDecimalColumnInterpreter.patch > > > I recently created a Class for doing aggregations(sum,min,max,std) on values > stored as BigDecimal in HBase. I would like to commit the > BigDecimalColumnInterpreter into HBase. In my opinion this class can be used > by a wide variety of users. Please let me know if its not appropriate to add > this class in HBase. > Thanks, > Anil Gupta > Software Engineer II, Intuit, Inc -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6669) Add BigDecimalColumnInterpreter for doing aggregations using AggregationClient
[
https://issues.apache.org/jira/browse/HBASE-6669?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13447983#comment-13447983
]
Ted Yu commented on HBASE-6669:
---
@Anil:
Can you attach patch for trunk where BigDeciamlColumnInterpreter resides in
hbase-server module ?
Please add following annotation to BigDeciamlColumnInterpreter class:
{code}
@InterfaceAudience.Public
@InterfaceStability.Evolving
{code}
Why did you choose 0.0D / 0.0D in divideForAvg() ?
{code}
+ public double divideForAvg(BigDecimal val1, Long paramLong) {
+ return (((paramLong == null) || (val1 == null)) ? (0.0D / 0.0D) :
val1.doubleValue()/paramLong.doubleValue());
{code}
See HBASE-3678 for an Eclipse formatter.
Limit line length to 100 characters.
Thanks
> Add BigDecimalColumnInterpreter for doing aggregations using AggregationClient
> --
>
> Key: HBASE-6669
> URL: https://issues.apache.org/jira/browse/HBASE-6669
> Project: HBase
> Issue Type: New Feature
> Components: client, coprocessors
>Reporter: Anil Gupta
>Priority: Minor
> Labels: client, coprocessors
> Attachments: BigDecimalColumnInterpreter.java,
> BigDecimalColumnInterpreter.patch
>
>
> I recently created a Class for doing aggregations(sum,min,max,std) on values
> stored as BigDecimal in HBase. I would like to commit the
> BigDecimalColumnInterpreter into HBase. In my opinion this class can be used
> by a wide variety of users. Please let me know if its not appropriate to add
> this class in HBase.
> Thanks,
> Anil Gupta
> Software Engineer II, Intuit, Inc
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6669) Add BigDecimalColumnInterpreter for doing aggregations using AggregationClient
[ https://issues.apache.org/jira/browse/HBASE-6669?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13447967#comment-13447967 ] Anil Gupta commented on HBASE-6669: --- [~v.himanshu] Please find attached the patch for BigDeciamlColumnInterpreter for review. I haven't worked on Unit Test and formatting the source code yet. I hope it's ok for reviewing the code. @Julian Wissmann, I am attaching the java file for BigDeciamlColumnInterpreter file. You wont need to recompile HBase since you can use it directly at client side. Let me know if you face any problem. Thanks, Anil Gupta Software Engineer II, Intuit, Inc > Add BigDecimalColumnInterpreter for doing aggregations using AggregationClient > -- > > Key: HBASE-6669 > URL: https://issues.apache.org/jira/browse/HBASE-6669 > Project: HBase > Issue Type: New Feature > Components: client, coprocessors >Reporter: Anil Gupta >Priority: Minor > Labels: client, coprocessors > Attachments: BigDecimalColumnInterpreter.patch > > > I recently created a Class for doing aggregations(sum,min,max,std) on values > stored as BigDecimal in HBase. I would like to commit the > BigDecimalColumnInterpreter into HBase. In my opinion this class can be used > by a wide variety of users. Please let me know if its not appropriate to add > this class in HBase. > Thanks, > Anil Gupta > Software Engineer II, Intuit, Inc -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6669) Add BigDecimalColumnInterpreter for doing aggregations using AggregationClient
[ https://issues.apache.org/jira/browse/HBASE-6669?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13442981#comment-13442981 ] Anil Gupta commented on HBASE-6669: --- Hi Himanshu, I don't have the Hbase source set-up on my eclipse yet so it might take me little more time than usual to upload the batch. Thanks, Anil Gupta Software Engineer II, Intuit, Inc > Add BigDecimalColumnInterpreter for doing aggregations using AggregationClient > -- > > Key: HBASE-6669 > URL: https://issues.apache.org/jira/browse/HBASE-6669 > Project: HBase > Issue Type: New Feature > Components: client, coprocessors >Reporter: Anil Gupta >Priority: Minor > Labels: client, coprocessors > > I recently created a Class for doing aggregations(sum,min,max,std) on values > stored as BigDecimal in HBase. I would like to commit the > BigDecimalColumnInterpreter into HBase. In my opinion this class can be used > by a wide variety of users. Please let me know if its not appropriate to add > this class in HBase. > Thanks, > Anil Gupta > Software Engineer II, Intuit, Inc -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6669) Add BigDecimalColumnInterpreter for doing aggregations using AggregationClient
[ https://issues.apache.org/jira/browse/HBASE-6669?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13442394#comment-13442394 ] Himanshu Vashishtha commented on HBASE-6669: Please upload the patch :) > Add BigDecimalColumnInterpreter for doing aggregations using AggregationClient > -- > > Key: HBASE-6669 > URL: https://issues.apache.org/jira/browse/HBASE-6669 > Project: HBase > Issue Type: New Feature > Components: client, coprocessors >Reporter: Anil Gupta >Priority: Minor > Labels: client, coprocessors > > I recently created a Class for doing aggregations(sum,min,max,std) on values > stored as BigDecimal in HBase. I would like to commit the > BigDecimalColumnInterpreter into HBase. In my opinion this class can be used > by a wide variety of users. Please let me know if its not appropriate to add > this class in HBase. > Thanks, > Anil Gupta > Software Engineer II, Intuit, Inc -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
