[jira] [Commented] (HBASE-7503) Add exists(List) in HTableInterface to allow multiple parallel exists at one time
[
https://issues.apache.org/jira/browse/HBASE-7503?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13566499#comment-13566499
]
Hadoop QA commented on HBASE-7503:
--
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12567134/HBASE-7503-v15-trunk.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 6 new
or modified tests.
{color:green}+1 hadoop2.0{color}. The patch compiles against the hadoop
2.0 profile.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:red}-1 lineLengths{color}. The patch introduces lines longer than
100
{color:green}+1 core tests{color}. The patch passed unit tests in .
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/4250//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/4250//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/4250//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/4250//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/4250//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/4250//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/4250//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/4250//console
This message is automatically generated.
Add exists(List) in HTableInterface to allow multiple parallel exists at one
time
-
Key: HBASE-7503
URL: https://issues.apache.org/jira/browse/HBASE-7503
Project: HBase
Issue Type: Improvement
Reporter: Jean-Marc Spaggiari
Assignee: Jean-Marc Spaggiari
Priority: Minor
Fix For: 0.96.0
Attachments: 7503-v14-trunk.patch, HBASE-7503-v0-trunk.patch,
HBASE-7503-v10-trunk.patch, HBASE-7503-v11-trunk.patch,
HBASE-7503-v12-trunk.patch, HBASE-7503-v13-trunk.patch,
HBASE-7503-v13-trunk.patch, HBASE-7503-v14-trunk.patch,
HBASE-7503-v15-trunk.patch, HBASE-7503-v1-trunk.patch,
HBASE-7503-v2-trunk.patch, HBASE-7503-v2-trunk.patch,
HBASE-7503-v3-trunk.patch, HBASE-7503-v4-trunk.patch,
HBASE-7503-v5-trunk.patch, HBASE-7503-v7-trunk.patch,
HBASE-7503-v8-trunk.patch, HBASE-7503-v9-trunk.patch
Original Estimate: 5m
Remaining Estimate: 5m
We need to have a Boolean[] exists(ListGet gets) throws IOException method
implemented in HTableInterface.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7503) Add exists(List) in HTableInterface to allow multiple parallel exists at one time
[ https://issues.apache.org/jira/browse/HBASE-7503?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13566695#comment-13566695 ] Hudson commented on HBASE-7503: --- Integrated in HBase-TRUNK #3827 (See [https://builds.apache.org/job/HBase-TRUNK/3827/]) HBASE-7503 Add exists(List) in HTableInterface to allow multiple parallel exists at one time (Jean-Marc) (Revision 1440454) Result = FAILURE tedyu : Files : * /hbase/trunk/hbase-protocol/src/main/java/org/apache/hadoop/hbase/protobuf/generated/ClientProtos.java * /hbase/trunk/hbase-protocol/src/main/protobuf/Client.proto * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/client/HTable.java * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/client/HTableInterface.java * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/client/HTablePool.java * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/coprocessor/CoprocessorHost.java * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/protobuf/RequestConverter.java * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/rest/client/RemoteHTable.java * /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestFromClientSide3.java * /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/master/MockRegionServer.java Add exists(List) in HTableInterface to allow multiple parallel exists at one time - Key: HBASE-7503 URL: https://issues.apache.org/jira/browse/HBASE-7503 Project: HBase Issue Type: Improvement Reporter: Jean-Marc Spaggiari Assignee: Jean-Marc Spaggiari Priority: Minor Fix For: 0.96.0 Attachments: 7503-v14-trunk.patch, HBASE-7503-v0-trunk.patch, HBASE-7503-v10-trunk.patch, HBASE-7503-v11-trunk.patch, HBASE-7503-v12-trunk.patch, HBASE-7503-v13-trunk.patch, HBASE-7503-v13-trunk.patch, HBASE-7503-v14-trunk.patch, HBASE-7503-v15-trunk.patch, HBASE-7503-v1-trunk.patch, HBASE-7503-v2-trunk.patch, HBASE-7503-v2-trunk.patch, HBASE-7503-v3-trunk.patch, HBASE-7503-v4-trunk.patch, HBASE-7503-v5-trunk.patch, HBASE-7503-v7-trunk.patch, HBASE-7503-v8-trunk.patch, HBASE-7503-v9-trunk.patch Original Estimate: 5m Remaining Estimate: 5m We need to have a Boolean[] exists(ListGet gets) throws IOException method implemented in HTableInterface. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7503) Add exists(List) in HTableInterface to allow multiple parallel exists at one time
[ https://issues.apache.org/jira/browse/HBASE-7503?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13567264#comment-13567264 ] Hudson commented on HBASE-7503: --- Integrated in HBase-TRUNK-on-Hadoop-2.0.0 #385 (See [https://builds.apache.org/job/HBase-TRUNK-on-Hadoop-2.0.0/385/]) HBASE-7503 Add exists(List) in HTableInterface to allow multiple parallel exists at one time (Jean-Marc) (Revision 1440454) Result = FAILURE tedyu : Files : * /hbase/trunk/hbase-protocol/src/main/java/org/apache/hadoop/hbase/protobuf/generated/ClientProtos.java * /hbase/trunk/hbase-protocol/src/main/protobuf/Client.proto * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/client/HTable.java * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/client/HTableInterface.java * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/client/HTablePool.java * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/coprocessor/CoprocessorHost.java * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/protobuf/RequestConverter.java * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/rest/client/RemoteHTable.java * /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestFromClientSide3.java * /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/master/MockRegionServer.java Add exists(List) in HTableInterface to allow multiple parallel exists at one time - Key: HBASE-7503 URL: https://issues.apache.org/jira/browse/HBASE-7503 Project: HBase Issue Type: Improvement Reporter: Jean-Marc Spaggiari Assignee: Jean-Marc Spaggiari Priority: Minor Fix For: 0.96.0 Attachments: 7503-v14-trunk.patch, HBASE-7503-v0-trunk.patch, HBASE-7503-v10-trunk.patch, HBASE-7503-v11-trunk.patch, HBASE-7503-v12-trunk.patch, HBASE-7503-v13-trunk.patch, HBASE-7503-v13-trunk.patch, HBASE-7503-v14-trunk.patch, HBASE-7503-v15-trunk.patch, HBASE-7503-v1-trunk.patch, HBASE-7503-v2-trunk.patch, HBASE-7503-v2-trunk.patch, HBASE-7503-v3-trunk.patch, HBASE-7503-v4-trunk.patch, HBASE-7503-v5-trunk.patch, HBASE-7503-v7-trunk.patch, HBASE-7503-v8-trunk.patch, HBASE-7503-v9-trunk.patch Original Estimate: 5m Remaining Estimate: 5m We need to have a Boolean[] exists(ListGet gets) throws IOException method implemented in HTableInterface. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7503) Add exists(List) in HTableInterface to allow multiple parallel exists at one time
[ https://issues.apache.org/jira/browse/HBASE-7503?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13565767#comment-13565767 ] Sergey Shelukhin commented on HBASE-7503: - +1 Add exists(List) in HTableInterface to allow multiple parallel exists at one time - Key: HBASE-7503 URL: https://issues.apache.org/jira/browse/HBASE-7503 Project: HBase Issue Type: Improvement Reporter: Jean-Marc Spaggiari Assignee: Jean-Marc Spaggiari Priority: Minor Fix For: 0.96.0 Attachments: HBASE-7503-v0-trunk.patch, HBASE-7503-v10-trunk.patch, HBASE-7503-v11-trunk.patch, HBASE-7503-v12-trunk.patch, HBASE-7503-v13-trunk.patch, HBASE-7503-v13-trunk.patch, HBASE-7503-v14-trunk.patch, HBASE-7503-v1-trunk.patch, HBASE-7503-v2-trunk.patch, HBASE-7503-v2-trunk.patch, HBASE-7503-v3-trunk.patch, HBASE-7503-v4-trunk.patch, HBASE-7503-v5-trunk.patch, HBASE-7503-v7-trunk.patch, HBASE-7503-v8-trunk.patch, HBASE-7503-v9-trunk.patch Original Estimate: 5m Remaining Estimate: 5m We need to have a Boolean[] exists(ListGet gets) throws IOException method implemented in HTableInterface. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7503) Add exists(List) in HTableInterface to allow multiple parallel exists at one time
[ https://issues.apache.org/jira/browse/HBASE-7503?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13565866#comment-13565866 ] Ted Yu commented on HBASE-7503: --- TestAdmin failed in the last QA run. Mind attaching the patch again, @Jean-Marc ? Add exists(List) in HTableInterface to allow multiple parallel exists at one time - Key: HBASE-7503 URL: https://issues.apache.org/jira/browse/HBASE-7503 Project: HBase Issue Type: Improvement Reporter: Jean-Marc Spaggiari Assignee: Jean-Marc Spaggiari Priority: Minor Fix For: 0.96.0 Attachments: HBASE-7503-v0-trunk.patch, HBASE-7503-v10-trunk.patch, HBASE-7503-v11-trunk.patch, HBASE-7503-v12-trunk.patch, HBASE-7503-v13-trunk.patch, HBASE-7503-v13-trunk.patch, HBASE-7503-v14-trunk.patch, HBASE-7503-v1-trunk.patch, HBASE-7503-v2-trunk.patch, HBASE-7503-v2-trunk.patch, HBASE-7503-v3-trunk.patch, HBASE-7503-v4-trunk.patch, HBASE-7503-v5-trunk.patch, HBASE-7503-v7-trunk.patch, HBASE-7503-v8-trunk.patch, HBASE-7503-v9-trunk.patch Original Estimate: 5m Remaining Estimate: 5m We need to have a Boolean[] exists(ListGet gets) throws IOException method implemented in HTableInterface. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7503) Add exists(List) in HTableInterface to allow multiple parallel exists at one time
[
https://issues.apache.org/jira/browse/HBASE-7503?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13566057#comment-13566057
]
Hadoop QA commented on HBASE-7503:
--
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12567084/7503-v14-trunk.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 6 new
or modified tests.
{color:green}+1 hadoop2.0{color}. The patch compiles against the hadoop
2.0 profile.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:red}-1 findbugs{color}. The patch appears to introduce 3 new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:red}-1 lineLengths{color}. The patch introduces lines longer than
100
{color:green}+1 core tests{color}. The patch passed unit tests in .
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/4243//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/4243//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/4243//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/4243//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/4243//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/4243//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/4243//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/4243//console
This message is automatically generated.
Add exists(List) in HTableInterface to allow multiple parallel exists at one
time
-
Key: HBASE-7503
URL: https://issues.apache.org/jira/browse/HBASE-7503
Project: HBase
Issue Type: Improvement
Reporter: Jean-Marc Spaggiari
Assignee: Jean-Marc Spaggiari
Priority: Minor
Fix For: 0.96.0
Attachments: 7503-v14-trunk.patch, HBASE-7503-v0-trunk.patch,
HBASE-7503-v10-trunk.patch, HBASE-7503-v11-trunk.patch,
HBASE-7503-v12-trunk.patch, HBASE-7503-v13-trunk.patch,
HBASE-7503-v13-trunk.patch, HBASE-7503-v14-trunk.patch,
HBASE-7503-v1-trunk.patch, HBASE-7503-v2-trunk.patch,
HBASE-7503-v2-trunk.patch, HBASE-7503-v3-trunk.patch,
HBASE-7503-v4-trunk.patch, HBASE-7503-v5-trunk.patch,
HBASE-7503-v7-trunk.patch, HBASE-7503-v8-trunk.patch,
HBASE-7503-v9-trunk.patch
Original Estimate: 5m
Remaining Estimate: 5m
We need to have a Boolean[] exists(ListGet gets) throws IOException method
implemented in HTableInterface.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7503) Add exists(List) in HTableInterface to allow multiple parallel exists at one time
[ https://issues.apache.org/jira/browse/HBASE-7503?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13566082#comment-13566082 ] Ted Yu commented on HBASE-7503: --- We're really close. @Jean-Marc: If you can find out the 3 new Findbugs warnings, that would be great. You can use https://builds.apache.org/job/PreCommit-HBASE-Build/4240/artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.xml as the basis where no new findbugs warning was reported. Add exists(List) in HTableInterface to allow multiple parallel exists at one time - Key: HBASE-7503 URL: https://issues.apache.org/jira/browse/HBASE-7503 Project: HBase Issue Type: Improvement Reporter: Jean-Marc Spaggiari Assignee: Jean-Marc Spaggiari Priority: Minor Fix For: 0.96.0 Attachments: 7503-v14-trunk.patch, HBASE-7503-v0-trunk.patch, HBASE-7503-v10-trunk.patch, HBASE-7503-v11-trunk.patch, HBASE-7503-v12-trunk.patch, HBASE-7503-v13-trunk.patch, HBASE-7503-v13-trunk.patch, HBASE-7503-v14-trunk.patch, HBASE-7503-v1-trunk.patch, HBASE-7503-v2-trunk.patch, HBASE-7503-v2-trunk.patch, HBASE-7503-v3-trunk.patch, HBASE-7503-v4-trunk.patch, HBASE-7503-v5-trunk.patch, HBASE-7503-v7-trunk.patch, HBASE-7503-v8-trunk.patch, HBASE-7503-v9-trunk.patch Original Estimate: 5m Remaining Estimate: 5m We need to have a Boolean[] exists(ListGet gets) throws IOException method implemented in HTableInterface. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7503) Add exists(List) in HTableInterface to allow multiple parallel exists at one time
[
https://issues.apache.org/jira/browse/HBASE-7503?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13564725#comment-13564725
]
Sergey Shelukhin commented on HBASE-7503:
-
bq. MapInteger, ListGet getsByRegion = new HashMapInteger, ListGet();
Can be done with just an array :)
bq.if (index == null) {
bq.index = 0;
bq. }
What's this for?
Otherwise looks good.
Add exists(List) in HTableInterface to allow multiple parallel exists at one
time
-
Key: HBASE-7503
URL: https://issues.apache.org/jira/browse/HBASE-7503
Project: HBase
Issue Type: Improvement
Reporter: Jean-Marc Spaggiari
Assignee: Jean-Marc Spaggiari
Priority: Minor
Fix For: 0.96.0
Attachments: HBASE-7503-v0-trunk.patch, HBASE-7503-v10-trunk.patch,
HBASE-7503-v11-trunk.patch, HBASE-7503-v12-trunk.patch,
HBASE-7503-v13-trunk.patch, HBASE-7503-v13-trunk.patch,
HBASE-7503-v14-trunk.patch, HBASE-7503-v1-trunk.patch,
HBASE-7503-v2-trunk.patch, HBASE-7503-v2-trunk.patch,
HBASE-7503-v3-trunk.patch, HBASE-7503-v4-trunk.patch,
HBASE-7503-v5-trunk.patch, HBASE-7503-v7-trunk.patch,
HBASE-7503-v8-trunk.patch, HBASE-7503-v9-trunk.patch
Original Estimate: 5m
Remaining Estimate: 5m
We need to have a Boolean[] exists(ListGet gets) throws IOException method
implemented in HTableInterface.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7503) Add exists(List) in HTableInterface to allow multiple parallel exists at one time
[ https://issues.apache.org/jira/browse/HBASE-7503?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13564729#comment-13564729 ] Sergey Shelukhin commented on HBASE-7503: - Actually, nevermind about the array, I see these are region indices, not get indices. Add exists(List) in HTableInterface to allow multiple parallel exists at one time - Key: HBASE-7503 URL: https://issues.apache.org/jira/browse/HBASE-7503 Project: HBase Issue Type: Improvement Reporter: Jean-Marc Spaggiari Assignee: Jean-Marc Spaggiari Priority: Minor Fix For: 0.96.0 Attachments: HBASE-7503-v0-trunk.patch, HBASE-7503-v10-trunk.patch, HBASE-7503-v11-trunk.patch, HBASE-7503-v12-trunk.patch, HBASE-7503-v13-trunk.patch, HBASE-7503-v13-trunk.patch, HBASE-7503-v14-trunk.patch, HBASE-7503-v1-trunk.patch, HBASE-7503-v2-trunk.patch, HBASE-7503-v2-trunk.patch, HBASE-7503-v3-trunk.patch, HBASE-7503-v4-trunk.patch, HBASE-7503-v5-trunk.patch, HBASE-7503-v7-trunk.patch, HBASE-7503-v8-trunk.patch, HBASE-7503-v9-trunk.patch Original Estimate: 5m Remaining Estimate: 5m We need to have a Boolean[] exists(ListGet gets) throws IOException method implemented in HTableInterface. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7503) Add exists(List) in HTableInterface to allow multiple parallel exists at one time
[ https://issues.apache.org/jira/browse/HBASE-7503?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13562663#comment-13562663 ] Jean-Marc Spaggiari commented on HBASE-7503: Hi Ted, To detect the complexiti and go without the sorting option, this will add almost the same effort are simply always sorting. Sorting the regions will take R x log(R). Sorting the gets will take G x log(g). Looping through the sorting lists will take max (G, R). So basically, at the end, the complexity will be close to n.log(n) Not doing the sort will always give is something like n² because of the nested loop... I will change the implementation. In Sergey's example above, even if we are setting the gets to null to skip them faster, we are still doing the entire loop2. It's a bit more optimal than what I did, but we still have n². Let me think about that and I will come back with a proposal. Add exists(List) in HTableInterface to allow multiple parallel exists at one time - Key: HBASE-7503 URL: https://issues.apache.org/jira/browse/HBASE-7503 Project: HBase Issue Type: Improvement Reporter: Jean-Marc Spaggiari Assignee: Jean-Marc Spaggiari Priority: Minor Fix For: 0.96.0 Attachments: HBASE-7503-v0-trunk.patch, HBASE-7503-v10-trunk.patch, HBASE-7503-v11-trunk.patch, HBASE-7503-v12-trunk.patch, HBASE-7503-v13-trunk.patch, HBASE-7503-v13-trunk.patch, HBASE-7503-v1-trunk.patch, HBASE-7503-v2-trunk.patch, HBASE-7503-v2-trunk.patch, HBASE-7503-v3-trunk.patch, HBASE-7503-v4-trunk.patch, HBASE-7503-v5-trunk.patch, HBASE-7503-v7-trunk.patch, HBASE-7503-v8-trunk.patch, HBASE-7503-v9-trunk.patch Original Estimate: 5m Remaining Estimate: 5m We need to have a Boolean[] exists(ListGet gets) throws IOException method implemented in HTableInterface. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7503) Add exists(List) in HTableInterface to allow multiple parallel exists at one time
[ https://issues.apache.org/jira/browse/HBASE-7503?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13562674#comment-13562674 ] Ted Yu commented on HBASE-7503: --- You don't need to sort the regions in the table. The start and end keys are sorted already. What does n represent above ? Add exists(List) in HTableInterface to allow multiple parallel exists at one time - Key: HBASE-7503 URL: https://issues.apache.org/jira/browse/HBASE-7503 Project: HBase Issue Type: Improvement Reporter: Jean-Marc Spaggiari Assignee: Jean-Marc Spaggiari Priority: Minor Fix For: 0.96.0 Attachments: HBASE-7503-v0-trunk.patch, HBASE-7503-v10-trunk.patch, HBASE-7503-v11-trunk.patch, HBASE-7503-v12-trunk.patch, HBASE-7503-v13-trunk.patch, HBASE-7503-v13-trunk.patch, HBASE-7503-v1-trunk.patch, HBASE-7503-v2-trunk.patch, HBASE-7503-v2-trunk.patch, HBASE-7503-v3-trunk.patch, HBASE-7503-v4-trunk.patch, HBASE-7503-v5-trunk.patch, HBASE-7503-v7-trunk.patch, HBASE-7503-v8-trunk.patch, HBASE-7503-v9-trunk.patch Original Estimate: 5m Remaining Estimate: 5m We need to have a Boolean[] exists(ListGet gets) throws IOException method implemented in HTableInterface. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7503) Add exists(List) in HTableInterface to allow multiple parallel exists at one time
[ https://issues.apache.org/jira/browse/HBASE-7503?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13562680#comment-13562680 ] Jean-Marc Spaggiari commented on HBASE-7503: I was wondering for the regions :) I was looking at the code while our comment arrived ;) Ok. One less. n represent any value. It's just giving an idea of the overall complexity. Here, at the end, the call will cost something like O(n log n). It's given to compare against O(n²) or O(log n). It's not a specific value. So if the regions are already sorted, then the overall complexity will be G log (G) which we can write also as O(n log n) where n here reprensent the number of gets in the request. Add exists(List) in HTableInterface to allow multiple parallel exists at one time - Key: HBASE-7503 URL: https://issues.apache.org/jira/browse/HBASE-7503 Project: HBase Issue Type: Improvement Reporter: Jean-Marc Spaggiari Assignee: Jean-Marc Spaggiari Priority: Minor Fix For: 0.96.0 Attachments: HBASE-7503-v0-trunk.patch, HBASE-7503-v10-trunk.patch, HBASE-7503-v11-trunk.patch, HBASE-7503-v12-trunk.patch, HBASE-7503-v13-trunk.patch, HBASE-7503-v13-trunk.patch, HBASE-7503-v1-trunk.patch, HBASE-7503-v2-trunk.patch, HBASE-7503-v2-trunk.patch, HBASE-7503-v3-trunk.patch, HBASE-7503-v4-trunk.patch, HBASE-7503-v5-trunk.patch, HBASE-7503-v7-trunk.patch, HBASE-7503-v8-trunk.patch, HBASE-7503-v9-trunk.patch Original Estimate: 5m Remaining Estimate: 5m We need to have a Boolean[] exists(ListGet gets) throws IOException method implemented in HTableInterface. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7503) Add exists(List) in HTableInterface to allow multiple parallel exists at one time
[ https://issues.apache.org/jira/browse/HBASE-7503?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13562950#comment-13562950 ] Ted Yu commented on HBASE-7503: --- @Jean-Marc: Can you attach latest patch here ? Add exists(List) in HTableInterface to allow multiple parallel exists at one time - Key: HBASE-7503 URL: https://issues.apache.org/jira/browse/HBASE-7503 Project: HBase Issue Type: Improvement Reporter: Jean-Marc Spaggiari Assignee: Jean-Marc Spaggiari Priority: Minor Fix For: 0.96.0 Attachments: HBASE-7503-v0-trunk.patch, HBASE-7503-v10-trunk.patch, HBASE-7503-v11-trunk.patch, HBASE-7503-v12-trunk.patch, HBASE-7503-v13-trunk.patch, HBASE-7503-v13-trunk.patch, HBASE-7503-v14-trunk.patch, HBASE-7503-v1-trunk.patch, HBASE-7503-v2-trunk.patch, HBASE-7503-v2-trunk.patch, HBASE-7503-v3-trunk.patch, HBASE-7503-v4-trunk.patch, HBASE-7503-v5-trunk.patch, HBASE-7503-v7-trunk.patch, HBASE-7503-v8-trunk.patch, HBASE-7503-v9-trunk.patch Original Estimate: 5m Remaining Estimate: 5m We need to have a Boolean[] exists(ListGet gets) throws IOException method implemented in HTableInterface. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7503) Add exists(List) in HTableInterface to allow multiple parallel exists at one time
[
https://issues.apache.org/jira/browse/HBASE-7503?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13563007#comment-13563007
]
Hadoop QA commented on HBASE-7503:
--
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12566540/HBASE-7503-v14-trunk.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 6 new
or modified tests.
{color:green}+1 hadoop2.0{color}. The patch compiles against the hadoop
2.0 profile.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:red}-1 findbugs{color}. The patch appears to introduce 3 new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:red}-1 lineLengths{color}. The patch introduces lines longer than
100
{color:red}-1 core tests{color}. The patch failed these unit tests:
org.apache.hadoop.hbase.client.TestAdmin
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/4183//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/4183//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/4183//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/4183//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/4183//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/4183//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/4183//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/4183//console
This message is automatically generated.
Add exists(List) in HTableInterface to allow multiple parallel exists at one
time
-
Key: HBASE-7503
URL: https://issues.apache.org/jira/browse/HBASE-7503
Project: HBase
Issue Type: Improvement
Reporter: Jean-Marc Spaggiari
Assignee: Jean-Marc Spaggiari
Priority: Minor
Fix For: 0.96.0
Attachments: HBASE-7503-v0-trunk.patch, HBASE-7503-v10-trunk.patch,
HBASE-7503-v11-trunk.patch, HBASE-7503-v12-trunk.patch,
HBASE-7503-v13-trunk.patch, HBASE-7503-v13-trunk.patch,
HBASE-7503-v14-trunk.patch, HBASE-7503-v1-trunk.patch,
HBASE-7503-v2-trunk.patch, HBASE-7503-v2-trunk.patch,
HBASE-7503-v3-trunk.patch, HBASE-7503-v4-trunk.patch,
HBASE-7503-v5-trunk.patch, HBASE-7503-v7-trunk.patch,
HBASE-7503-v8-trunk.patch, HBASE-7503-v9-trunk.patch
Original Estimate: 5m
Remaining Estimate: 5m
We need to have a Boolean[] exists(ListGet gets) throws IOException method
implemented in HTableInterface.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7503) Add exists(List) in HTableInterface to allow multiple parallel exists at one time
[
https://issues.apache.org/jira/browse/HBASE-7503?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13561667#comment-13561667
]
Hadoop QA commented on HBASE-7503:
--
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12566309/HBASE-7503-v13-trunk.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 6 new
or modified tests.
{color:green}+1 hadoop2.0{color}. The patch compiles against the hadoop
2.0 profile.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:red}-1 findbugs{color}. The patch appears to introduce 2 new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:red}-1 lineLengths{color}. The patch introduces lines longer than
100
{color:red}-1 core tests{color}. The patch failed these unit tests:
org.apache.hadoop.hbase.security.access.TestZKPermissionsWatcher
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/4160//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/4160//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/4160//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/4160//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/4160//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/4160//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/4160//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/4160//console
This message is automatically generated.
Add exists(List) in HTableInterface to allow multiple parallel exists at one
time
-
Key: HBASE-7503
URL: https://issues.apache.org/jira/browse/HBASE-7503
Project: HBase
Issue Type: Improvement
Reporter: Jean-Marc Spaggiari
Assignee: Jean-Marc Spaggiari
Priority: Minor
Fix For: 0.96.0
Attachments: HBASE-7503-v0-trunk.patch, HBASE-7503-v10-trunk.patch,
HBASE-7503-v11-trunk.patch, HBASE-7503-v12-trunk.patch,
HBASE-7503-v13-trunk.patch, HBASE-7503-v1-trunk.patch,
HBASE-7503-v2-trunk.patch, HBASE-7503-v2-trunk.patch,
HBASE-7503-v3-trunk.patch, HBASE-7503-v4-trunk.patch,
HBASE-7503-v5-trunk.patch, HBASE-7503-v7-trunk.patch,
HBASE-7503-v8-trunk.patch, HBASE-7503-v9-trunk.patch
Original Estimate: 5m
Remaining Estimate: 5m
We need to have a Boolean[] exists(ListGet gets) throws IOException method
implemented in HTableInterface.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7503) Add exists(List) in HTableInterface to allow multiple parallel exists at one time
[
https://issues.apache.org/jira/browse/HBASE-7503?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13561671#comment-13561671
]
Jean-Marc Spaggiari commented on HBASE-7503:
I ran org.apache.hadoop.hbase.client.TestFromClientSide3 and it's working fine
locally.
Hadoop QA failed on
org.apache.hadoop.hbase.security.access.TestZKPermissionsWatcher.testPermissionsWatcher
which seems not related to this patch.
{code}
---
T E S T S
---
Running org.apache.hadoop.hbase.client.TestFromClientSide3
Tests run: 5, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 131.651 sec
Results :
Tests run: 5, Failures: 0, Errors: 0, Skipped: 0
{code}
{code}
[INFO]
[INFO] Reactor Summary:
[INFO]
[INFO] HBase . SUCCESS [4.311s]
[INFO] HBase - Common SUCCESS [4.439s]
[INFO] HBase - Protocol .. SUCCESS [9.436s]
[INFO] HBase - Client SUCCESS [0.309s]
[INFO] HBase - Hadoop Compatibility .. SUCCESS [0.222s]
[INFO] HBase - Hadoop One Compatibility .. SUCCESS [0.678s]
[INFO] HBase - Server SUCCESS [2:26.146s]
[INFO] HBase - Integration Tests . SUCCESS [4.427s]
[INFO] HBase - Examples .. SUCCESS [2.638s]
[INFO]
[INFO] BUILD SUCCESS
[INFO]
{code}
Add exists(List) in HTableInterface to allow multiple parallel exists at one
time
-
Key: HBASE-7503
URL: https://issues.apache.org/jira/browse/HBASE-7503
Project: HBase
Issue Type: Improvement
Reporter: Jean-Marc Spaggiari
Assignee: Jean-Marc Spaggiari
Priority: Minor
Fix For: 0.96.0
Attachments: HBASE-7503-v0-trunk.patch, HBASE-7503-v10-trunk.patch,
HBASE-7503-v11-trunk.patch, HBASE-7503-v12-trunk.patch,
HBASE-7503-v13-trunk.patch, HBASE-7503-v1-trunk.patch,
HBASE-7503-v2-trunk.patch, HBASE-7503-v2-trunk.patch,
HBASE-7503-v3-trunk.patch, HBASE-7503-v4-trunk.patch,
HBASE-7503-v5-trunk.patch, HBASE-7503-v7-trunk.patch,
HBASE-7503-v8-trunk.patch, HBASE-7503-v9-trunk.patch
Original Estimate: 5m
Remaining Estimate: 5m
We need to have a Boolean[] exists(ListGet gets) throws IOException method
implemented in HTableInterface.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7503) Add exists(List) in HTableInterface to allow multiple parallel exists at one time
[ https://issues.apache.org/jira/browse/HBASE-7503?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13561689#comment-13561689 ] Ted Yu commented on HBASE-7503: --- @Jean-Marc: Mind attaching your patch again ? Add exists(List) in HTableInterface to allow multiple parallel exists at one time - Key: HBASE-7503 URL: https://issues.apache.org/jira/browse/HBASE-7503 Project: HBase Issue Type: Improvement Reporter: Jean-Marc Spaggiari Assignee: Jean-Marc Spaggiari Priority: Minor Fix For: 0.96.0 Attachments: HBASE-7503-v0-trunk.patch, HBASE-7503-v10-trunk.patch, HBASE-7503-v11-trunk.patch, HBASE-7503-v12-trunk.patch, HBASE-7503-v13-trunk.patch, HBASE-7503-v1-trunk.patch, HBASE-7503-v2-trunk.patch, HBASE-7503-v2-trunk.patch, HBASE-7503-v3-trunk.patch, HBASE-7503-v4-trunk.patch, HBASE-7503-v5-trunk.patch, HBASE-7503-v7-trunk.patch, HBASE-7503-v8-trunk.patch, HBASE-7503-v9-trunk.patch Original Estimate: 5m Remaining Estimate: 5m We need to have a Boolean[] exists(ListGet gets) throws IOException method implemented in HTableInterface. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7503) Add exists(List) in HTableInterface to allow multiple parallel exists at one time
[ https://issues.apache.org/jira/browse/HBASE-7503?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13561693#comment-13561693 ] Jean-Marc Spaggiari commented on HBASE-7503: The same version? Or should I increment the version to get it processed? Add exists(List) in HTableInterface to allow multiple parallel exists at one time - Key: HBASE-7503 URL: https://issues.apache.org/jira/browse/HBASE-7503 Project: HBase Issue Type: Improvement Reporter: Jean-Marc Spaggiari Assignee: Jean-Marc Spaggiari Priority: Minor Fix For: 0.96.0 Attachments: HBASE-7503-v0-trunk.patch, HBASE-7503-v10-trunk.patch, HBASE-7503-v11-trunk.patch, HBASE-7503-v12-trunk.patch, HBASE-7503-v13-trunk.patch, HBASE-7503-v1-trunk.patch, HBASE-7503-v2-trunk.patch, HBASE-7503-v2-trunk.patch, HBASE-7503-v3-trunk.patch, HBASE-7503-v4-trunk.patch, HBASE-7503-v5-trunk.patch, HBASE-7503-v7-trunk.patch, HBASE-7503-v8-trunk.patch, HBASE-7503-v9-trunk.patch Original Estimate: 5m Remaining Estimate: 5m We need to have a Boolean[] exists(ListGet gets) throws IOException method implemented in HTableInterface. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7503) Add exists(List) in HTableInterface to allow multiple parallel exists at one time
[ https://issues.apache.org/jira/browse/HBASE-7503?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13561703#comment-13561703 ] Ted Yu commented on HBASE-7503: --- Hadoop QA looks at attachment Id, not file name. Meaning, attaching same file would do. Add exists(List) in HTableInterface to allow multiple parallel exists at one time - Key: HBASE-7503 URL: https://issues.apache.org/jira/browse/HBASE-7503 Project: HBase Issue Type: Improvement Reporter: Jean-Marc Spaggiari Assignee: Jean-Marc Spaggiari Priority: Minor Fix For: 0.96.0 Attachments: HBASE-7503-v0-trunk.patch, HBASE-7503-v10-trunk.patch, HBASE-7503-v11-trunk.patch, HBASE-7503-v12-trunk.patch, HBASE-7503-v13-trunk.patch, HBASE-7503-v1-trunk.patch, HBASE-7503-v2-trunk.patch, HBASE-7503-v2-trunk.patch, HBASE-7503-v3-trunk.patch, HBASE-7503-v4-trunk.patch, HBASE-7503-v5-trunk.patch, HBASE-7503-v7-trunk.patch, HBASE-7503-v8-trunk.patch, HBASE-7503-v9-trunk.patch Original Estimate: 5m Remaining Estimate: 5m We need to have a Boolean[] exists(ListGet gets) throws IOException method implemented in HTableInterface. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7503) Add exists(List) in HTableInterface to allow multiple parallel exists at one time
[
https://issues.apache.org/jira/browse/HBASE-7503?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13561777#comment-13561777
]
Hadoop QA commented on HBASE-7503:
--
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12566322/HBASE-7503-v13-trunk.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 6 new
or modified tests.
{color:green}+1 hadoop2.0{color}. The patch compiles against the hadoop
2.0 profile.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:red}-1 findbugs{color}. The patch appears to introduce 2 new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:red}-1 lineLengths{color}. The patch introduces lines longer than
100
{color:green}+1 core tests{color}. The patch passed unit tests in .
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/4161//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/4161//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/4161//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/4161//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/4161//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/4161//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/4161//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/4161//console
This message is automatically generated.
Add exists(List) in HTableInterface to allow multiple parallel exists at one
time
-
Key: HBASE-7503
URL: https://issues.apache.org/jira/browse/HBASE-7503
Project: HBase
Issue Type: Improvement
Reporter: Jean-Marc Spaggiari
Assignee: Jean-Marc Spaggiari
Priority: Minor
Fix For: 0.96.0
Attachments: HBASE-7503-v0-trunk.patch, HBASE-7503-v10-trunk.patch,
HBASE-7503-v11-trunk.patch, HBASE-7503-v12-trunk.patch,
HBASE-7503-v13-trunk.patch, HBASE-7503-v13-trunk.patch,
HBASE-7503-v1-trunk.patch, HBASE-7503-v2-trunk.patch,
HBASE-7503-v2-trunk.patch, HBASE-7503-v3-trunk.patch,
HBASE-7503-v4-trunk.patch, HBASE-7503-v5-trunk.patch,
HBASE-7503-v7-trunk.patch, HBASE-7503-v8-trunk.patch,
HBASE-7503-v9-trunk.patch
Original Estimate: 5m
Remaining Estimate: 5m
We need to have a Boolean[] exists(ListGet gets) throws IOException method
implemented in HTableInterface.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7503) Add exists(List) in HTableInterface to allow multiple parallel exists at one time
[ https://issues.apache.org/jira/browse/HBASE-7503?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13561832#comment-13561832 ] Sergey Shelukhin commented on HBASE-7503: - +1 on latest patch... Add exists(List) in HTableInterface to allow multiple parallel exists at one time - Key: HBASE-7503 URL: https://issues.apache.org/jira/browse/HBASE-7503 Project: HBase Issue Type: Improvement Reporter: Jean-Marc Spaggiari Assignee: Jean-Marc Spaggiari Priority: Minor Fix For: 0.96.0 Attachments: HBASE-7503-v0-trunk.patch, HBASE-7503-v10-trunk.patch, HBASE-7503-v11-trunk.patch, HBASE-7503-v12-trunk.patch, HBASE-7503-v13-trunk.patch, HBASE-7503-v13-trunk.patch, HBASE-7503-v1-trunk.patch, HBASE-7503-v2-trunk.patch, HBASE-7503-v2-trunk.patch, HBASE-7503-v3-trunk.patch, HBASE-7503-v4-trunk.patch, HBASE-7503-v5-trunk.patch, HBASE-7503-v7-trunk.patch, HBASE-7503-v8-trunk.patch, HBASE-7503-v9-trunk.patch Original Estimate: 5m Remaining Estimate: 5m We need to have a Boolean[] exists(ListGet gets) throws IOException method implemented in HTableInterface. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7503) Add exists(List) in HTableInterface to allow multiple parallel exists at one time
[
https://issues.apache.org/jira/browse/HBASE-7503?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13562124#comment-13562124
]
Ted Yu commented on HBASE-7503:
---
{code}
+for (final Get get : gets) {
+ Integer startKeyIndex = null;
+ // Search which region this get is related to by comparing start and end
keys.
+ for (int i = 0; i startEndKeys.getFirst().length; ++i) {
{code}
When the number of Get's is high, the above nested loop is not efficient.
Sergey suggested sorting the Get's so that you can traverse sorted Get's and
startEndKeys in tandem.
Can you do that ?
Thanks
Add exists(List) in HTableInterface to allow multiple parallel exists at one
time
-
Key: HBASE-7503
URL: https://issues.apache.org/jira/browse/HBASE-7503
Project: HBase
Issue Type: Improvement
Reporter: Jean-Marc Spaggiari
Assignee: Jean-Marc Spaggiari
Priority: Minor
Fix For: 0.96.0
Attachments: HBASE-7503-v0-trunk.patch, HBASE-7503-v10-trunk.patch,
HBASE-7503-v11-trunk.patch, HBASE-7503-v12-trunk.patch,
HBASE-7503-v13-trunk.patch, HBASE-7503-v13-trunk.patch,
HBASE-7503-v1-trunk.patch, HBASE-7503-v2-trunk.patch,
HBASE-7503-v2-trunk.patch, HBASE-7503-v3-trunk.patch,
HBASE-7503-v4-trunk.patch, HBASE-7503-v5-trunk.patch,
HBASE-7503-v7-trunk.patch, HBASE-7503-v8-trunk.patch,
HBASE-7503-v9-trunk.patch
Original Estimate: 5m
Remaining Estimate: 5m
We need to have a Boolean[] exists(ListGet gets) throws IOException method
implemented in HTableInterface.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7503) Add exists(List) in HTableInterface to allow multiple parallel exists at one time
[ https://issues.apache.org/jira/browse/HBASE-7503?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13562205#comment-13562205 ] Ted Yu commented on HBASE-7503: --- Suppose there're G Get's and R regions in the table, the complexity for current approach is G x R If we sort first, complexity is G x log(G) + G + R. Add exists(List) in HTableInterface to allow multiple parallel exists at one time - Key: HBASE-7503 URL: https://issues.apache.org/jira/browse/HBASE-7503 Project: HBase Issue Type: Improvement Reporter: Jean-Marc Spaggiari Assignee: Jean-Marc Spaggiari Priority: Minor Fix For: 0.96.0 Attachments: HBASE-7503-v0-trunk.patch, HBASE-7503-v10-trunk.patch, HBASE-7503-v11-trunk.patch, HBASE-7503-v12-trunk.patch, HBASE-7503-v13-trunk.patch, HBASE-7503-v13-trunk.patch, HBASE-7503-v1-trunk.patch, HBASE-7503-v2-trunk.patch, HBASE-7503-v2-trunk.patch, HBASE-7503-v3-trunk.patch, HBASE-7503-v4-trunk.patch, HBASE-7503-v5-trunk.patch, HBASE-7503-v7-trunk.patch, HBASE-7503-v8-trunk.patch, HBASE-7503-v9-trunk.patch Original Estimate: 5m Remaining Estimate: 5m We need to have a Boolean[] exists(ListGet gets) throws IOException method implemented in HTableInterface. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7503) Add exists(List) in HTableInterface to allow multiple parallel exists at one time
[ https://issues.apache.org/jira/browse/HBASE-7503?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13562294#comment-13562294 ] Jean-Marc Spaggiari commented on HBASE-7503: I totally agree with your comment. Worst case can be bad. If all gets are in the first region, it will be faster than the sort ;) I will re-look at Sergey's solution and try to implement it shortly. Add exists(List) in HTableInterface to allow multiple parallel exists at one time - Key: HBASE-7503 URL: https://issues.apache.org/jira/browse/HBASE-7503 Project: HBase Issue Type: Improvement Reporter: Jean-Marc Spaggiari Assignee: Jean-Marc Spaggiari Priority: Minor Fix For: 0.96.0 Attachments: HBASE-7503-v0-trunk.patch, HBASE-7503-v10-trunk.patch, HBASE-7503-v11-trunk.patch, HBASE-7503-v12-trunk.patch, HBASE-7503-v13-trunk.patch, HBASE-7503-v13-trunk.patch, HBASE-7503-v1-trunk.patch, HBASE-7503-v2-trunk.patch, HBASE-7503-v2-trunk.patch, HBASE-7503-v3-trunk.patch, HBASE-7503-v4-trunk.patch, HBASE-7503-v5-trunk.patch, HBASE-7503-v7-trunk.patch, HBASE-7503-v8-trunk.patch, HBASE-7503-v9-trunk.patch Original Estimate: 5m Remaining Estimate: 5m We need to have a Boolean[] exists(ListGet gets) throws IOException method implemented in HTableInterface. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7503) Add exists(List) in HTableInterface to allow multiple parallel exists at one time
[ https://issues.apache.org/jira/browse/HBASE-7503?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13562306#comment-13562306 ] Ted Yu commented on HBASE-7503: --- @Jean-Marc: As you said, we don't always need to sort. A comparison between the two complexities should be done at the beginning to decide which way to go. Add exists(List) in HTableInterface to allow multiple parallel exists at one time - Key: HBASE-7503 URL: https://issues.apache.org/jira/browse/HBASE-7503 Project: HBase Issue Type: Improvement Reporter: Jean-Marc Spaggiari Assignee: Jean-Marc Spaggiari Priority: Minor Fix For: 0.96.0 Attachments: HBASE-7503-v0-trunk.patch, HBASE-7503-v10-trunk.patch, HBASE-7503-v11-trunk.patch, HBASE-7503-v12-trunk.patch, HBASE-7503-v13-trunk.patch, HBASE-7503-v13-trunk.patch, HBASE-7503-v1-trunk.patch, HBASE-7503-v2-trunk.patch, HBASE-7503-v2-trunk.patch, HBASE-7503-v3-trunk.patch, HBASE-7503-v4-trunk.patch, HBASE-7503-v5-trunk.patch, HBASE-7503-v7-trunk.patch, HBASE-7503-v8-trunk.patch, HBASE-7503-v9-trunk.patch Original Estimate: 5m Remaining Estimate: 5m We need to have a Boolean[] exists(ListGet gets) throws IOException method implemented in HTableInterface. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7503) Add exists(List) in HTableInterface to allow multiple parallel exists at one time
[ https://issues.apache.org/jira/browse/HBASE-7503?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13559835#comment-13559835 ] Sergey Shelukhin commented on HBASE-7503: - Btw my above comments (other than on closestRowBefore) are a nit, shouldn't block. Add exists(List) in HTableInterface to allow multiple parallel exists at one time - Key: HBASE-7503 URL: https://issues.apache.org/jira/browse/HBASE-7503 Project: HBase Issue Type: Improvement Reporter: Jean-Marc Spaggiari Assignee: Jean-Marc Spaggiari Priority: Minor Fix For: 0.96.0 Attachments: HBASE-7503-v0-trunk.patch, HBASE-7503-v10-trunk.patch, HBASE-7503-v11-trunk.patch, HBASE-7503-v1-trunk.patch, HBASE-7503-v2-trunk.patch, HBASE-7503-v2-trunk.patch, HBASE-7503-v3-trunk.patch, HBASE-7503-v4-trunk.patch, HBASE-7503-v5-trunk.patch, HBASE-7503-v7-trunk.patch, HBASE-7503-v8-trunk.patch, HBASE-7503-v9-trunk.patch Original Estimate: 5m Remaining Estimate: 5m We need to have a Boolean[] exists(ListGet gets) throws IOException method implemented in HTableInterface. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7503) Add exists(List) in HTableInterface to allow multiple parallel exists at one time
[ https://issues.apache.org/jira/browse/HBASE-7503?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13560200#comment-13560200 ] Ted Yu commented on HBASE-7503: --- From https://builds.apache.org/job/PreCommit-HBASE-Build/4134/console , looks like there was compilation error. Add exists(List) in HTableInterface to allow multiple parallel exists at one time - Key: HBASE-7503 URL: https://issues.apache.org/jira/browse/HBASE-7503 Project: HBase Issue Type: Improvement Reporter: Jean-Marc Spaggiari Assignee: Jean-Marc Spaggiari Priority: Minor Fix For: 0.96.0 Attachments: HBASE-7503-v0-trunk.patch, HBASE-7503-v10-trunk.patch, HBASE-7503-v11-trunk.patch, HBASE-7503-v12-trunk.patch, HBASE-7503-v1-trunk.patch, HBASE-7503-v2-trunk.patch, HBASE-7503-v2-trunk.patch, HBASE-7503-v3-trunk.patch, HBASE-7503-v4-trunk.patch, HBASE-7503-v5-trunk.patch, HBASE-7503-v7-trunk.patch, HBASE-7503-v8-trunk.patch, HBASE-7503-v9-trunk.patch Original Estimate: 5m Remaining Estimate: 5m We need to have a Boolean[] exists(ListGet gets) throws IOException method implemented in HTableInterface. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7503) Add exists(List) in HTableInterface to allow multiple parallel exists at one time
[ https://issues.apache.org/jira/browse/HBASE-7503?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13560206#comment-13560206 ] Sergey Shelukhin commented on HBASE-7503: - Can closestRowBefore then be added to RequestConverter? Add exists(List) in HTableInterface to allow multiple parallel exists at one time - Key: HBASE-7503 URL: https://issues.apache.org/jira/browse/HBASE-7503 Project: HBase Issue Type: Improvement Reporter: Jean-Marc Spaggiari Assignee: Jean-Marc Spaggiari Priority: Minor Fix For: 0.96.0 Attachments: HBASE-7503-v0-trunk.patch, HBASE-7503-v10-trunk.patch, HBASE-7503-v11-trunk.patch, HBASE-7503-v12-trunk.patch, HBASE-7503-v1-trunk.patch, HBASE-7503-v2-trunk.patch, HBASE-7503-v2-trunk.patch, HBASE-7503-v3-trunk.patch, HBASE-7503-v4-trunk.patch, HBASE-7503-v5-trunk.patch, HBASE-7503-v7-trunk.patch, HBASE-7503-v8-trunk.patch, HBASE-7503-v9-trunk.patch Original Estimate: 5m Remaining Estimate: 5m We need to have a Boolean[] exists(ListGet gets) throws IOException method implemented in HTableInterface. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7503) Add exists(List) in HTableInterface to allow multiple parallel exists at one time
[ https://issues.apache.org/jira/browse/HBASE-7503?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13560208#comment-13560208 ] Sergey Shelukhin commented on HBASE-7503: - Btw, I mentioned working patch because I started writing comment when the patch was broken (e.g. in Hadoop QA), then got distracted and finished the comment when there was already a good patch :). Sorry for that. Add exists(List) in HTableInterface to allow multiple parallel exists at one time - Key: HBASE-7503 URL: https://issues.apache.org/jira/browse/HBASE-7503 Project: HBase Issue Type: Improvement Reporter: Jean-Marc Spaggiari Assignee: Jean-Marc Spaggiari Priority: Minor Fix For: 0.96.0 Attachments: HBASE-7503-v0-trunk.patch, HBASE-7503-v10-trunk.patch, HBASE-7503-v11-trunk.patch, HBASE-7503-v12-trunk.patch, HBASE-7503-v1-trunk.patch, HBASE-7503-v2-trunk.patch, HBASE-7503-v2-trunk.patch, HBASE-7503-v3-trunk.patch, HBASE-7503-v4-trunk.patch, HBASE-7503-v5-trunk.patch, HBASE-7503-v7-trunk.patch, HBASE-7503-v8-trunk.patch, HBASE-7503-v9-trunk.patch Original Estimate: 5m Remaining Estimate: 5m We need to have a Boolean[] exists(ListGet gets) throws IOException method implemented in HTableInterface. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7503) Add exists(List) in HTableInterface to allow multiple parallel exists at one time
[ https://issues.apache.org/jira/browse/HBASE-7503?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13560233#comment-13560233 ] Jean-Marc Spaggiari commented on HBASE-7503: @Sergey, do you mean something like public static MultiGetRequest buildMultiGetRowOrBeforeRequest(final byte[] regionName, final byte[] row, final byte[] family) built like buildGetRowOrBeforeRequest? If so, I will add it. @Ted, how can I see what the compilation issue is? I have updated my workspace and it's working fine. So I'm wondering what the issue is. Is there a way to see it? Add exists(List) in HTableInterface to allow multiple parallel exists at one time - Key: HBASE-7503 URL: https://issues.apache.org/jira/browse/HBASE-7503 Project: HBase Issue Type: Improvement Reporter: Jean-Marc Spaggiari Assignee: Jean-Marc Spaggiari Priority: Minor Fix For: 0.96.0 Attachments: HBASE-7503-v0-trunk.patch, HBASE-7503-v10-trunk.patch, HBASE-7503-v11-trunk.patch, HBASE-7503-v12-trunk.patch, HBASE-7503-v1-trunk.patch, HBASE-7503-v2-trunk.patch, HBASE-7503-v2-trunk.patch, HBASE-7503-v3-trunk.patch, HBASE-7503-v4-trunk.patch, HBASE-7503-v5-trunk.patch, HBASE-7503-v7-trunk.patch, HBASE-7503-v8-trunk.patch, HBASE-7503-v9-trunk.patch Original Estimate: 5m Remaining Estimate: 5m We need to have a Boolean[] exists(ListGet gets) throws IOException method implemented in HTableInterface. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7503) Add exists(List) in HTableInterface to allow multiple parallel exists at one time
[
https://issues.apache.org/jira/browse/HBASE-7503?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13560242#comment-13560242
]
Ted Yu commented on HBASE-7503:
---
Patch v12 is of 815KB which is significantly larger than the other patches.
{code}
---
hbase-protocol/src/main/java/org/apache/hadoop/hbase/protobuf/generated/ClientProtos.java
(revision 1437181)
+++
hbase-protocol/src/main/java/org/apache/hadoop/hbase/protobuf/generated/ClientProtos.java
(working copy)
@@ -1,19678 +0,0 @@
-// Generated by the protocol buffer compiler. DO NOT EDIT!
-// source: Client.proto
-
-package org.apache.hadoop.hbase.protobuf.generated;
{code}
ClientProtos.java was removed, resulting in compilation error.
Add exists(List) in HTableInterface to allow multiple parallel exists at one
time
-
Key: HBASE-7503
URL: https://issues.apache.org/jira/browse/HBASE-7503
Project: HBase
Issue Type: Improvement
Reporter: Jean-Marc Spaggiari
Assignee: Jean-Marc Spaggiari
Priority: Minor
Fix For: 0.96.0
Attachments: HBASE-7503-v0-trunk.patch, HBASE-7503-v10-trunk.patch,
HBASE-7503-v11-trunk.patch, HBASE-7503-v12-trunk.patch,
HBASE-7503-v1-trunk.patch, HBASE-7503-v2-trunk.patch,
HBASE-7503-v2-trunk.patch, HBASE-7503-v3-trunk.patch,
HBASE-7503-v4-trunk.patch, HBASE-7503-v5-trunk.patch,
HBASE-7503-v7-trunk.patch, HBASE-7503-v8-trunk.patch,
HBASE-7503-v9-trunk.patch
Original Estimate: 5m
Remaining Estimate: 5m
We need to have a Boolean[] exists(ListGet gets) throws IOException method
implemented in HTableInterface.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7503) Add exists(List) in HTableInterface to allow multiple parallel exists at one time
[ https://issues.apache.org/jira/browse/HBASE-7503?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13557615#comment-13557615 ] Ted Yu commented on HBASE-7503: --- From https://builds.apache.org/job/PreCommit-HBASE-Build/4089/console, it looks like patch v10 doesn't compile (against hadoop 2.0) Add exists(List) in HTableInterface to allow multiple parallel exists at one time - Key: HBASE-7503 URL: https://issues.apache.org/jira/browse/HBASE-7503 Project: HBase Issue Type: Improvement Reporter: Jean-Marc Spaggiari Assignee: Jean-Marc Spaggiari Priority: Minor Fix For: 0.96.0 Attachments: HBASE-7503-v0-trunk.patch, HBASE-7503-v10-trunk.patch, HBASE-7503-v1-trunk.patch, HBASE-7503-v2-trunk.patch, HBASE-7503-v2-trunk.patch, HBASE-7503-v3-trunk.patch, HBASE-7503-v4-trunk.patch, HBASE-7503-v5-trunk.patch, HBASE-7503-v7-trunk.patch, HBASE-7503-v8-trunk.patch, HBASE-7503-v9-trunk.patch Original Estimate: 5m Remaining Estimate: 5m We need to have a Boolean[] exists(ListGet gets) throws IOException method implemented in HTableInterface. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7503) Add exists(List) in HTableInterface to allow multiple parallel exists at one time
[ https://issues.apache.org/jira/browse/HBASE-7503?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13557633#comment-13557633 ] Jean-Marc Spaggiari commented on HBASE-7503: I forgot the ClientProto.java :( Will re-submit in a minute :( Add exists(List) in HTableInterface to allow multiple parallel exists at one time - Key: HBASE-7503 URL: https://issues.apache.org/jira/browse/HBASE-7503 Project: HBase Issue Type: Improvement Reporter: Jean-Marc Spaggiari Assignee: Jean-Marc Spaggiari Priority: Minor Fix For: 0.96.0 Attachments: HBASE-7503-v0-trunk.patch, HBASE-7503-v10-trunk.patch, HBASE-7503-v1-trunk.patch, HBASE-7503-v2-trunk.patch, HBASE-7503-v2-trunk.patch, HBASE-7503-v3-trunk.patch, HBASE-7503-v4-trunk.patch, HBASE-7503-v5-trunk.patch, HBASE-7503-v7-trunk.patch, HBASE-7503-v8-trunk.patch, HBASE-7503-v9-trunk.patch Original Estimate: 5m Remaining Estimate: 5m We need to have a Boolean[] exists(ListGet gets) throws IOException method implemented in HTableInterface. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7503) Add exists(List) in HTableInterface to allow multiple parallel exists at one time
[ https://issues.apache.org/jira/browse/HBASE-7503?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13557650#comment-13557650 ] Jean-Marc Spaggiari commented on HBASE-7503: Will take a bit more time. Eclipse is not exporting anymore the ClientProvo.java file in the .patch even if I select it. That's where the issue is coming from. I need to figure why first. Don't know how long this will take. Add exists(List) in HTableInterface to allow multiple parallel exists at one time - Key: HBASE-7503 URL: https://issues.apache.org/jira/browse/HBASE-7503 Project: HBase Issue Type: Improvement Reporter: Jean-Marc Spaggiari Assignee: Jean-Marc Spaggiari Priority: Minor Fix For: 0.96.0 Attachments: HBASE-7503-v0-trunk.patch, HBASE-7503-v10-trunk.patch, HBASE-7503-v1-trunk.patch, HBASE-7503-v2-trunk.patch, HBASE-7503-v2-trunk.patch, HBASE-7503-v3-trunk.patch, HBASE-7503-v4-trunk.patch, HBASE-7503-v5-trunk.patch, HBASE-7503-v7-trunk.patch, HBASE-7503-v8-trunk.patch, HBASE-7503-v9-trunk.patch Original Estimate: 5m Remaining Estimate: 5m We need to have a Boolean[] exists(ListGet gets) throws IOException method implemented in HTableInterface. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7503) Add exists(List) in HTableInterface to allow multiple parallel exists at one time
[
https://issues.apache.org/jira/browse/HBASE-7503?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13557732#comment-13557732
]
Hadoop QA commented on HBASE-7503:
--
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12565566/HBASE-7503-v11-trunk.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 6 new
or modified tests.
{color:green}+1 hadoop2.0{color}. The patch compiles against the hadoop
2.0 profile.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:red}-1 lineLengths{color}. The patch introduces lines longer than
100
{color:red}-1 core tests{color}. The patch failed these unit tests:
org.apache.hadoop.hbase.TestZooKeeper
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/4095//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/4095//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/4095//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/4095//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/4095//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/4095//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/4095//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/4095//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/4095//console
This message is automatically generated.
Add exists(List) in HTableInterface to allow multiple parallel exists at one
time
-
Key: HBASE-7503
URL: https://issues.apache.org/jira/browse/HBASE-7503
Project: HBase
Issue Type: Improvement
Reporter: Jean-Marc Spaggiari
Assignee: Jean-Marc Spaggiari
Priority: Minor
Fix For: 0.96.0
Attachments: HBASE-7503-v0-trunk.patch, HBASE-7503-v10-trunk.patch,
HBASE-7503-v11-trunk.patch, HBASE-7503-v1-trunk.patch,
HBASE-7503-v2-trunk.patch, HBASE-7503-v2-trunk.patch,
HBASE-7503-v3-trunk.patch, HBASE-7503-v4-trunk.patch,
HBASE-7503-v5-trunk.patch, HBASE-7503-v7-trunk.patch,
HBASE-7503-v8-trunk.patch, HBASE-7503-v9-trunk.patch
Original Estimate: 5m
Remaining Estimate: 5m
We need to have a Boolean[] exists(ListGet gets) throws IOException method
implemented in HTableInterface.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7503) Add exists(List) in HTableInterface to allow multiple parallel exists at one time
[
https://issues.apache.org/jira/browse/HBASE-7503?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13557736#comment-13557736
]
Sergey Shelukhin commented on HBASE-7503:
-
It's still not clear if closestRowBefore is needed. And if yes, why is it not
in RequestConverter?
Otherwise (and assuming a working patch :)) +1.
Wrt structures and lists, the pseudocode of what I had in mind.
First loop can be optimized by sorting gets by rowkey first and traversing in
parallel with startEndKeys, that improves O over both this and the patch, but
may not necessarily be important.
Input: ListGet gets; ListKeyPair startEndKeys = ...;
ListRequest requests = [];
Listint[] getIndexesPerRequest = [];
for {s,e} in startEndKeys {
Request request = null
for i in [0, gets.length) {
if (gets[i] != null and gets[i].rowKey is in [s,e)) {
if (request == null) {
request = new Request()
requests.add(request)
getIndexesPerRequest.add(new int[])
}
request.addGet(gets[i]);
getIndexesPerRequest[requests.length - 1] = i;
gets[i] = null;
}
}
}
optionally check that gets are all nulls
send and wait for requests (or could be sent inline after internal for-loop
above).
Listblah results = new Listblah(gets.length)
for i in [0, responses.length) {
if error do error stuff, otherwise {
assert response[i].results.length == getIndexesPerRequest[i].length;
for j in [0, response[i].results.length) {
results[getIndexesPerRequest[i][j]] = response.results[j]
}
}
return results;
Add exists(List) in HTableInterface to allow multiple parallel exists at one
time
-
Key: HBASE-7503
URL: https://issues.apache.org/jira/browse/HBASE-7503
Project: HBase
Issue Type: Improvement
Reporter: Jean-Marc Spaggiari
Assignee: Jean-Marc Spaggiari
Priority: Minor
Fix For: 0.96.0
Attachments: HBASE-7503-v0-trunk.patch, HBASE-7503-v10-trunk.patch,
HBASE-7503-v11-trunk.patch, HBASE-7503-v1-trunk.patch,
HBASE-7503-v2-trunk.patch, HBASE-7503-v2-trunk.patch,
HBASE-7503-v3-trunk.patch, HBASE-7503-v4-trunk.patch,
HBASE-7503-v5-trunk.patch, HBASE-7503-v7-trunk.patch,
HBASE-7503-v8-trunk.patch, HBASE-7503-v9-trunk.patch
Original Estimate: 5m
Remaining Estimate: 5m
We need to have a Boolean[] exists(ListGet gets) throws IOException method
implemented in HTableInterface.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7503) Add exists(List) in HTableInterface to allow multiple parallel exists at one time
[
https://issues.apache.org/jira/browse/HBASE-7503?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13557738#comment-13557738
]
Sergey Shelukhin commented on HBASE-7503:
-
{code}
Input: ListGet gets; ListKeyPair startEndKeys = ...;
ListRequest requests = [];
Listint[] getIndexesPerRequest = [];
for {s,e} in startEndKeys {
Request request = null
for i in [0, gets.length) {
if (gets[i] != null and gets[i].rowKey is in [s,e)) {
if (request == null) {
request = new Request()
requests.add(request)
getIndexesPerRequest.add(new int[])
}
request.addGet(gets[i]);
getIndexesPerRequest[requests.length - 1] = i;
gets[i] = null;
}
}
}
optionally check that gets are all nulls
send and wait for requests (or could be sent inline after internal for-loop
above).
Listblah results = new Listblah(gets.length)
for i in [0, responses.length) {
if error do error stuff, otherwise {
assert response[i].results.length == getIndexesPerRequest[i].length;
for j in [0, response[i].results.length) {
results[getIndexesPerRequest[i][j]] = response.results[j]
}
}
return results;
{code}
Add exists(List) in HTableInterface to allow multiple parallel exists at one
time
-
Key: HBASE-7503
URL: https://issues.apache.org/jira/browse/HBASE-7503
Project: HBase
Issue Type: Improvement
Reporter: Jean-Marc Spaggiari
Assignee: Jean-Marc Spaggiari
Priority: Minor
Fix For: 0.96.0
Attachments: HBASE-7503-v0-trunk.patch, HBASE-7503-v10-trunk.patch,
HBASE-7503-v11-trunk.patch, HBASE-7503-v1-trunk.patch,
HBASE-7503-v2-trunk.patch, HBASE-7503-v2-trunk.patch,
HBASE-7503-v3-trunk.patch, HBASE-7503-v4-trunk.patch,
HBASE-7503-v5-trunk.patch, HBASE-7503-v7-trunk.patch,
HBASE-7503-v8-trunk.patch, HBASE-7503-v9-trunk.patch
Original Estimate: 5m
Remaining Estimate: 5m
We need to have a Boolean[] exists(ListGet gets) throws IOException method
implemented in HTableInterface.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7503) Add exists(List) in HTableInterface to allow multiple parallel exists at one time
[ https://issues.apache.org/jira/browse/HBASE-7503?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13557745#comment-13557745 ] Sergey Shelukhin commented on HBASE-7503: - also, = i should be .add(i) Add exists(List) in HTableInterface to allow multiple parallel exists at one time - Key: HBASE-7503 URL: https://issues.apache.org/jira/browse/HBASE-7503 Project: HBase Issue Type: Improvement Reporter: Jean-Marc Spaggiari Assignee: Jean-Marc Spaggiari Priority: Minor Fix For: 0.96.0 Attachments: HBASE-7503-v0-trunk.patch, HBASE-7503-v10-trunk.patch, HBASE-7503-v11-trunk.patch, HBASE-7503-v1-trunk.patch, HBASE-7503-v2-trunk.patch, HBASE-7503-v2-trunk.patch, HBASE-7503-v3-trunk.patch, HBASE-7503-v4-trunk.patch, HBASE-7503-v5-trunk.patch, HBASE-7503-v7-trunk.patch, HBASE-7503-v8-trunk.patch, HBASE-7503-v9-trunk.patch Original Estimate: 5m Remaining Estimate: 5m We need to have a Boolean[] exists(ListGet gets) throws IOException method implemented in HTableInterface. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7503) Add exists(List) in HTableInterface to allow multiple parallel exists at one time
[ https://issues.apache.org/jira/browse/HBASE-7503?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13554978#comment-13554978 ] Jean-Marc Spaggiari commented on HBASE-7503: I will update the proposed patch and use getStartEndKeys. I will also add some regions on the test table to make sure this region-sorted approach is tested correctly... Add exists(List) in HTableInterface to allow multiple parallel exists at one time - Key: HBASE-7503 URL: https://issues.apache.org/jira/browse/HBASE-7503 Project: HBase Issue Type: Improvement Reporter: Jean-Marc Spaggiari Assignee: Jean-Marc Spaggiari Priority: Minor Fix For: 0.96.0 Attachments: HBASE-7503-v0-trunk.patch, HBASE-7503-v1-trunk.patch, HBASE-7503-v2-trunk.patch, HBASE-7503-v2-trunk.patch, HBASE-7503-v3-trunk.patch, HBASE-7503-v4-trunk.patch, HBASE-7503-v5-trunk.patch Original Estimate: 5m Remaining Estimate: 5m We need to have a Boolean[] exists(ListGet gets) throws IOException method implemented in HTableInterface. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7503) Add exists(List) in HTableInterface to allow multiple parallel exists at one time
[
https://issues.apache.org/jira/browse/HBASE-7503?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13555072#comment-13555072
]
Hadoop QA commented on HBASE-7503:
--
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12565120/HBASE-7503-v7-trunk.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 6 new
or modified tests.
{color:green}+1 hadoop2.0{color}. The patch compiles against the hadoop
2.0 profile.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:red}-1 findbugs{color}. The patch appears to introduce 2 new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:red}-1 lineLengths{color}. The patch introduces lines longer than
100
{color:red}-1 core tests{color}. The patch failed these unit tests:
org.apache.hadoop.hbase.security.access.TestAccessController
org.apache.hadoop.hbase.TestLocalHBaseCluster
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/4045//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/4045//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/4045//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/4045//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/4045//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/4045//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/4045//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/4045//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/4045//console
This message is automatically generated.
Add exists(List) in HTableInterface to allow multiple parallel exists at one
time
-
Key: HBASE-7503
URL: https://issues.apache.org/jira/browse/HBASE-7503
Project: HBase
Issue Type: Improvement
Reporter: Jean-Marc Spaggiari
Assignee: Jean-Marc Spaggiari
Priority: Minor
Fix For: 0.96.0
Attachments: HBASE-7503-v0-trunk.patch, HBASE-7503-v1-trunk.patch,
HBASE-7503-v2-trunk.patch, HBASE-7503-v2-trunk.patch,
HBASE-7503-v3-trunk.patch, HBASE-7503-v4-trunk.patch,
HBASE-7503-v5-trunk.patch, HBASE-7503-v7-trunk.patch
Original Estimate: 5m
Remaining Estimate: 5m
We need to have a Boolean[] exists(ListGet gets) throws IOException method
implemented in HTableInterface.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7503) Add exists(List) in HTableInterface to allow multiple parallel exists at one time
[
https://issues.apache.org/jira/browse/HBASE-7503?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13555380#comment-13555380
]
Hadoop QA commented on HBASE-7503:
--
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12565155/HBASE-7503-v8-trunk.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 6 new
or modified tests.
{color:green}+1 hadoop2.0{color}. The patch compiles against the hadoop
2.0 profile.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:red}-1 findbugs{color}. The patch appears to introduce 2 new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:red}-1 lineLengths{color}. The patch introduces lines longer than
100
{color:red}-1 core tests{color}. The patch failed these unit tests:
org.apache.hadoop.hbase.regionserver.TestColumnSeeking
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/4052//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/4052//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/4052//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/4052//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/4052//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/4052//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/4052//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/4052//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/4052//console
This message is automatically generated.
Add exists(List) in HTableInterface to allow multiple parallel exists at one
time
-
Key: HBASE-7503
URL: https://issues.apache.org/jira/browse/HBASE-7503
Project: HBase
Issue Type: Improvement
Reporter: Jean-Marc Spaggiari
Assignee: Jean-Marc Spaggiari
Priority: Minor
Fix For: 0.96.0
Attachments: HBASE-7503-v0-trunk.patch, HBASE-7503-v1-trunk.patch,
HBASE-7503-v2-trunk.patch, HBASE-7503-v2-trunk.patch,
HBASE-7503-v3-trunk.patch, HBASE-7503-v4-trunk.patch,
HBASE-7503-v5-trunk.patch, HBASE-7503-v7-trunk.patch,
HBASE-7503-v8-trunk.patch
Original Estimate: 5m
Remaining Estimate: 5m
We need to have a Boolean[] exists(ListGet gets) throws IOException method
implemented in HTableInterface.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7503) Add exists(List) in HTableInterface to allow multiple parallel exists at one time
[ https://issues.apache.org/jira/browse/HBASE-7503?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13555443#comment-13555443 ] Jean-Marc Spaggiari commented on HBASE-7503: I ran TestColumnSeeking locally and it passed successfully. Maybe we should try to re-run it by hadoop QA? Add exists(List) in HTableInterface to allow multiple parallel exists at one time - Key: HBASE-7503 URL: https://issues.apache.org/jira/browse/HBASE-7503 Project: HBase Issue Type: Improvement Reporter: Jean-Marc Spaggiari Assignee: Jean-Marc Spaggiari Priority: Minor Fix For: 0.96.0 Attachments: HBASE-7503-v0-trunk.patch, HBASE-7503-v1-trunk.patch, HBASE-7503-v2-trunk.patch, HBASE-7503-v2-trunk.patch, HBASE-7503-v3-trunk.patch, HBASE-7503-v4-trunk.patch, HBASE-7503-v5-trunk.patch, HBASE-7503-v7-trunk.patch, HBASE-7503-v8-trunk.patch Original Estimate: 5m Remaining Estimate: 5m We need to have a Boolean[] exists(ListGet gets) throws IOException method implemented in HTableInterface. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7503) Add exists(List) in HTableInterface to allow multiple parallel exists at one time
[ https://issues.apache.org/jira/browse/HBASE-7503?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13555448#comment-13555448 ] Ted Yu commented on HBASE-7503: --- You can wait for more review comments. Then you would have a new patch. Add exists(List) in HTableInterface to allow multiple parallel exists at one time - Key: HBASE-7503 URL: https://issues.apache.org/jira/browse/HBASE-7503 Project: HBase Issue Type: Improvement Reporter: Jean-Marc Spaggiari Assignee: Jean-Marc Spaggiari Priority: Minor Fix For: 0.96.0 Attachments: HBASE-7503-v0-trunk.patch, HBASE-7503-v1-trunk.patch, HBASE-7503-v2-trunk.patch, HBASE-7503-v2-trunk.patch, HBASE-7503-v3-trunk.patch, HBASE-7503-v4-trunk.patch, HBASE-7503-v5-trunk.patch, HBASE-7503-v7-trunk.patch, HBASE-7503-v8-trunk.patch Original Estimate: 5m Remaining Estimate: 5m We need to have a Boolean[] exists(ListGet gets) throws IOException method implemented in HTableInterface. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7503) Add exists(List) in HTableInterface to allow multiple parallel exists at one time
[ https://issues.apache.org/jira/browse/HBASE-7503?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=1304#comment-1304 ] Jean-Marc Spaggiari commented on HBASE-7503: Ok. Thanks. I will wait and see. JM Add exists(List) in HTableInterface to allow multiple parallel exists at one time - Key: HBASE-7503 URL: https://issues.apache.org/jira/browse/HBASE-7503 Project: HBase Issue Type: Improvement Reporter: Jean-Marc Spaggiari Assignee: Jean-Marc Spaggiari Priority: Minor Fix For: 0.96.0 Attachments: HBASE-7503-v0-trunk.patch, HBASE-7503-v1-trunk.patch, HBASE-7503-v2-trunk.patch, HBASE-7503-v2-trunk.patch, HBASE-7503-v3-trunk.patch, HBASE-7503-v4-trunk.patch, HBASE-7503-v5-trunk.patch, HBASE-7503-v7-trunk.patch, HBASE-7503-v8-trunk.patch Original Estimate: 5m Remaining Estimate: 5m We need to have a Boolean[] exists(ListGet gets) throws IOException method implemented in HTableInterface. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7503) Add exists(List) in HTableInterface to allow multiple parallel exists at one time
[ https://issues.apache.org/jira/browse/HBASE-7503?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13555695#comment-13555695 ] Sergey Shelukhin commented on HBASE-7503: - bq. optional bool closestRowBefore = 3; What's this for? This is not used anywhere; in fact it's not even set in request converter. bq. If specified, closestRowBefore will be ignored HRegionServer checks closestRowBefore flag first so existence flag will be ignored instead if both are specified. bq. MapGet, Integer reference = new HashMapGet, Integer(); needs better name. bq. Bytes.compareTo(get.getRow(), startEndKeys.getSecond()[i]) = 0) Just checking; are region boundaries in HBase [] or [)? It would seem that this needs to be if the latter is the case. While mapping regions to servers, it may be faster/simpler to sort the input list, and traverse it in parallel with region start key list. Or to make a copy, traverse keys list removing gets for each region from gets list. And in each case, sending the request immediately. Probably doesn't matter. bq. LOG.debug(Failed for gets on region: + sortedGetEntry.getKey()); warn, like below? Code for mapping things to stuff (references/indexes/...) is hard to grasp, at least to me. Maybe it's possible to have array, where for each request there'd be array of ints w/number of elements equal to the number of gets in the request. Then one can simply iterate thru responses and insert into corresponding indices in result. E.g. if gets are [region1-row1, region2-row1, region3-row1, region2-row2] there'd be 3 requests, and arrays would be [ [ 0 ], [ 1, 3 ], [ 2 ] ] bq. testHTableExists Misleading name too. I'd split the test into smaller tests too (approximately on comment boundaries :)) but that's a matter of personal preference. Add exists(List) in HTableInterface to allow multiple parallel exists at one time - Key: HBASE-7503 URL: https://issues.apache.org/jira/browse/HBASE-7503 Project: HBase Issue Type: Improvement Reporter: Jean-Marc Spaggiari Assignee: Jean-Marc Spaggiari Priority: Minor Fix For: 0.96.0 Attachments: HBASE-7503-v0-trunk.patch, HBASE-7503-v1-trunk.patch, HBASE-7503-v2-trunk.patch, HBASE-7503-v2-trunk.patch, HBASE-7503-v3-trunk.patch, HBASE-7503-v4-trunk.patch, HBASE-7503-v5-trunk.patch, HBASE-7503-v7-trunk.patch, HBASE-7503-v8-trunk.patch Original Estimate: 5m Remaining Estimate: 5m We need to have a Boolean[] exists(ListGet gets) throws IOException method implemented in HTableInterface. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7503) Add exists(List) in HTableInterface to allow multiple parallel exists at one time
[ https://issues.apache.org/jira/browse/HBASE-7503?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13555718#comment-13555718 ] Ted Yu commented on HBASE-7503: --- bq. are region boundaries in HBase [] or [)? It would seem that this needs to be if the latter is the case. Good finding. The test should cover rows sitting on region boundaries. Add exists(List) in HTableInterface to allow multiple parallel exists at one time - Key: HBASE-7503 URL: https://issues.apache.org/jira/browse/HBASE-7503 Project: HBase Issue Type: Improvement Reporter: Jean-Marc Spaggiari Assignee: Jean-Marc Spaggiari Priority: Minor Fix For: 0.96.0 Attachments: HBASE-7503-v0-trunk.patch, HBASE-7503-v1-trunk.patch, HBASE-7503-v2-trunk.patch, HBASE-7503-v2-trunk.patch, HBASE-7503-v3-trunk.patch, HBASE-7503-v4-trunk.patch, HBASE-7503-v5-trunk.patch, HBASE-7503-v7-trunk.patch, HBASE-7503-v8-trunk.patch Original Estimate: 5m Remaining Estimate: 5m We need to have a Boolean[] exists(ListGet gets) throws IOException method implemented in HTableInterface. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7503) Add exists(List) in HTableInterface to allow multiple parallel exists at one time
[ https://issues.apache.org/jira/browse/HBASE-7503?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13555747#comment-13555747 ] Jean-Marc Spaggiari commented on HBASE-7503: Thanks for the comments/review. Is the end key = next region start key? If so then yes it should be . But I tought the end key of a region was lower than the start key of the next region. This surprised me I agree because I know we only store the start key for a region... I will apply those comments shortly: qt. MapGet, Integer reference = new HashMapGet, Integer(); qt. needs better name. qt. LOG.debug(Failed for gets on region: + sortedGetEntry.getKey()); qt. warn, like below? qt. testHTableExists qt. Misleading name too. qt. I'd split the test into smaller tests too (approximately on comment boundaries ) but that's a matter of personal preference. I will also rename references. I'm not sure for the comment about While mapping... and Maybe it's possible to have array, ... I will have to read them again to make sure I get the suggestion correctly. Add exists(List) in HTableInterface to allow multiple parallel exists at one time - Key: HBASE-7503 URL: https://issues.apache.org/jira/browse/HBASE-7503 Project: HBase Issue Type: Improvement Reporter: Jean-Marc Spaggiari Assignee: Jean-Marc Spaggiari Priority: Minor Fix For: 0.96.0 Attachments: HBASE-7503-v0-trunk.patch, HBASE-7503-v1-trunk.patch, HBASE-7503-v2-trunk.patch, HBASE-7503-v2-trunk.patch, HBASE-7503-v3-trunk.patch, HBASE-7503-v4-trunk.patch, HBASE-7503-v5-trunk.patch, HBASE-7503-v7-trunk.patch, HBASE-7503-v8-trunk.patch Original Estimate: 5m Remaining Estimate: 5m We need to have a Boolean[] exists(ListGet gets) throws IOException method implemented in HTableInterface. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7503) Add exists(List) in HTableInterface to allow multiple parallel exists at one time
[
https://issues.apache.org/jira/browse/HBASE-7503?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13554403#comment-13554403
]
Jean-Marc Spaggiari commented on HBASE-7503:
Hi Ted,
I have some time to spend on that today and make good progress.
I have one question. If we have MultiGetRequest we might have to build
MultiGetResponse...
It should look something like that if you agree:
{code}
message MultiGetResponse {
repeated Result result = 1;
// used for Get to check existence only
repeated bool exists = 2;
}
{code}
Is there a way to put repeated optionnal? Or does repeated mean = 0?
Also, sound a bit to easy... Am I missing something? Anyway, I will post the
next patch most probably today or tomorrow. Almost done.
Add exists(List) in HTableInterface to allow multiple parallel exists at one
time
-
Key: HBASE-7503
URL: https://issues.apache.org/jira/browse/HBASE-7503
Project: HBase
Issue Type: Improvement
Reporter: Jean-Marc Spaggiari
Assignee: Jean-Marc Spaggiari
Priority: Minor
Fix For: 0.96.0
Attachments: HBASE-7503-v0-trunk.patch, HBASE-7503-v1-trunk.patch
Original Estimate: 5m
Remaining Estimate: 5m
We need to have a Boolean[] exists(ListGet gets) throws IOException method
implemented in HTableInterface.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7503) Add exists(List) in HTableInterface to allow multiple parallel exists at one time
[ https://issues.apache.org/jira/browse/HBASE-7503?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13554424#comment-13554424 ] Ted Yu commented on HBASE-7503: --- I once tried 'repeated optionnal' but protoc wouldn't compile. So I think 'repeated' should be good. Add exists(List) in HTableInterface to allow multiple parallel exists at one time - Key: HBASE-7503 URL: https://issues.apache.org/jira/browse/HBASE-7503 Project: HBase Issue Type: Improvement Reporter: Jean-Marc Spaggiari Assignee: Jean-Marc Spaggiari Priority: Minor Fix For: 0.96.0 Attachments: HBASE-7503-v0-trunk.patch, HBASE-7503-v1-trunk.patch Original Estimate: 5m Remaining Estimate: 5m We need to have a Boolean[] exists(ListGet gets) throws IOException method implemented in HTableInterface. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7503) Add exists(List) in HTableInterface to allow multiple parallel exists at one time
[ https://issues.apache.org/jira/browse/HBASE-7503?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13554449#comment-13554449 ] Devaraj Das commented on HBASE-7503: bq. Is there a way to put repeated optionnal? Or does repeated mean = 0? Repeated means greater-than or equal to 0.. (in the code you could check whether the count of the field is 0 by looking at the corresponding list size or the count). Add exists(List) in HTableInterface to allow multiple parallel exists at one time - Key: HBASE-7503 URL: https://issues.apache.org/jira/browse/HBASE-7503 Project: HBase Issue Type: Improvement Reporter: Jean-Marc Spaggiari Assignee: Jean-Marc Spaggiari Priority: Minor Fix For: 0.96.0 Attachments: HBASE-7503-v0-trunk.patch, HBASE-7503-v1-trunk.patch Original Estimate: 5m Remaining Estimate: 5m We need to have a Boolean[] exists(ListGet gets) throws IOException method implemented in HTableInterface. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7503) Add exists(List) in HTableInterface to allow multiple parallel exists at one time
[ https://issues.apache.org/jira/browse/HBASE-7503?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13554515#comment-13554515 ] Ted Yu commented on HBASE-7503: --- @Jean-Marc: You need to run protoc and include the diff for generated files in your patch. Add exists(List) in HTableInterface to allow multiple parallel exists at one time - Key: HBASE-7503 URL: https://issues.apache.org/jira/browse/HBASE-7503 Project: HBase Issue Type: Improvement Reporter: Jean-Marc Spaggiari Assignee: Jean-Marc Spaggiari Priority: Minor Fix For: 0.96.0 Attachments: HBASE-7503-v0-trunk.patch, HBASE-7503-v1-trunk.patch, HBASE-7503-v2-trunk.patch, HBASE-7503-v2-trunk.patch, HBASE-7503-v3-trunk.patch Original Estimate: 5m Remaining Estimate: 5m We need to have a Boolean[] exists(ListGet gets) throws IOException method implemented in HTableInterface. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7503) Add exists(List) in HTableInterface to allow multiple parallel exists at one time
[
https://issues.apache.org/jira/browse/HBASE-7503?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13554529#comment-13554529
]
Ted Yu commented on HBASE-7503:
---
{code}
+ * @param regionName the name of the region to get
{code}
'to get' - 'to get from'
{code}
+ * @param get the client Gets
{code}
parameter name doesn't match: get - gets
{code}
+MapHRegionInfo, ListGet sortedGets = new HashMapHRegionInfo,
ListGet();
{code}
Would getsByRegion be better name for the above variable ?
{code}
+ HRegionInfo regionInfo = connection.getRegionLocation(tableName,
get.getRow(), true).getRegionInfo();
{code}
Wrap long line above. The third parameter is true, I think false should be
passed so that locateRegion(name, row) is called:
{code}
return reload? relocateRegion(name, row): locateRegion(name, row);
...
public HRegionLocation locateRegion(final byte [] tableName,
final byte [] row)
throws IOException{
return locateRegion(tableName, row, true, true);
{code}
Note the second last parameter is useCache. The rationale is to reduce query to
.META.
{code}
public Pairbyte[][],byte[][] getStartEndKeys() throws IOException {
{code}
An alternative is to call the above method and put each Get into corresponding
bucket.
{code}
+ * exists(List) is really a list of get() calls. Just us get().
{code}
typo: us - use
Putting patch on review board would help reviewers.
Add exists(List) in HTableInterface to allow multiple parallel exists at one
time
-
Key: HBASE-7503
URL: https://issues.apache.org/jira/browse/HBASE-7503
Project: HBase
Issue Type: Improvement
Reporter: Jean-Marc Spaggiari
Assignee: Jean-Marc Spaggiari
Priority: Minor
Fix For: 0.96.0
Attachments: HBASE-7503-v0-trunk.patch, HBASE-7503-v1-trunk.patch,
HBASE-7503-v2-trunk.patch, HBASE-7503-v2-trunk.patch,
HBASE-7503-v3-trunk.patch, HBASE-7503-v4-trunk.patch,
HBASE-7503-v5-trunk.patch
Original Estimate: 5m
Remaining Estimate: 5m
We need to have a Boolean[] exists(ListGet gets) throws IOException method
implemented in HTableInterface.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7503) Add exists(List) in HTableInterface to allow multiple parallel exists at one time
[ https://issues.apache.org/jira/browse/HBASE-7503?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13554607#comment-13554607 ] Jean-Marc Spaggiari commented on HBASE-7503: I never heard about the Review Board site before. I found it on google and just pushed my patch there. Seems that I did not select the right group since to many people got the feedback. I have applied your comments below, also fixed some other too long lines and some comments in other methods I did not modified (typos). Add exists(List) in HTableInterface to allow multiple parallel exists at one time - Key: HBASE-7503 URL: https://issues.apache.org/jira/browse/HBASE-7503 Project: HBase Issue Type: Improvement Reporter: Jean-Marc Spaggiari Assignee: Jean-Marc Spaggiari Priority: Minor Fix For: 0.96.0 Attachments: HBASE-7503-v0-trunk.patch, HBASE-7503-v1-trunk.patch, HBASE-7503-v2-trunk.patch, HBASE-7503-v2-trunk.patch, HBASE-7503-v3-trunk.patch, HBASE-7503-v4-trunk.patch, HBASE-7503-v5-trunk.patch Original Estimate: 5m Remaining Estimate: 5m We need to have a Boolean[] exists(ListGet gets) throws IOException method implemented in HTableInterface. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7503) Add exists(List) in HTableInterface to allow multiple parallel exists at one time
[ https://issues.apache.org/jira/browse/HBASE-7503?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13554671#comment-13554671 ] Ted Yu commented on HBASE-7503: --- Here is the review request: https://reviews.apache.org/r/8966/ Add exists(List) in HTableInterface to allow multiple parallel exists at one time - Key: HBASE-7503 URL: https://issues.apache.org/jira/browse/HBASE-7503 Project: HBase Issue Type: Improvement Reporter: Jean-Marc Spaggiari Assignee: Jean-Marc Spaggiari Priority: Minor Fix For: 0.96.0 Attachments: HBASE-7503-v0-trunk.patch, HBASE-7503-v1-trunk.patch, HBASE-7503-v2-trunk.patch, HBASE-7503-v2-trunk.patch, HBASE-7503-v3-trunk.patch, HBASE-7503-v4-trunk.patch, HBASE-7503-v5-trunk.patch Original Estimate: 5m Remaining Estimate: 5m We need to have a Boolean[] exists(ListGet gets) throws IOException method implemented in HTableInterface. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7503) Add exists(List) in HTableInterface to allow multiple parallel exists at one time
[ https://issues.apache.org/jira/browse/HBASE-7503?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13554678#comment-13554678 ] Ted Yu commented on HBASE-7503: --- There is compilation error for latest patch: [ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:2.5.1:compile (default-compile) on project hbase-server: Compilation failure [ERROR] /Users/tyu/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java:[227,7] error: HRegionServer is not abstract and does not override abstract method multiGet(RpcController,MultiGetRequest) in BlockingInterface Can you use getStartEndKeys() in place of connection.getRegionLocation() ? Add exists(List) in HTableInterface to allow multiple parallel exists at one time - Key: HBASE-7503 URL: https://issues.apache.org/jira/browse/HBASE-7503 Project: HBase Issue Type: Improvement Reporter: Jean-Marc Spaggiari Assignee: Jean-Marc Spaggiari Priority: Minor Fix For: 0.96.0 Attachments: HBASE-7503-v0-trunk.patch, HBASE-7503-v1-trunk.patch, HBASE-7503-v2-trunk.patch, HBASE-7503-v2-trunk.patch, HBASE-7503-v3-trunk.patch, HBASE-7503-v4-trunk.patch, HBASE-7503-v5-trunk.patch Original Estimate: 5m Remaining Estimate: 5m We need to have a Boolean[] exists(ListGet gets) throws IOException method implemented in HTableInterface. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7503) Add exists(List) in HTableInterface to allow multiple parallel exists at one time
[
https://issues.apache.org/jira/browse/HBASE-7503?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13552094#comment-13552094
]
Jean-Marc Spaggiari commented on HBASE-7503:
About the Client.proto, should it not be:
{code}
repeated GetRequest get = 2;
{code}
instead of Get get = 2; ?
Also, should we add
{code}
message MultiGetResponse {
repeated GetResponse = 2;
}
{code}
too?
Add exists(List) in HTableInterface to allow multiple parallel exists at one
time
-
Key: HBASE-7503
URL: https://issues.apache.org/jira/browse/HBASE-7503
Project: HBase
Issue Type: Improvement
Reporter: Jean-Marc Spaggiari
Assignee: Jean-Marc Spaggiari
Priority: Minor
Fix For: 0.96.0
Attachments: HBASE-7503-v0-trunk.patch, HBASE-7503-v1-trunk.patch
Original Estimate: 5m
Remaining Estimate: 5m
We need to have a Boolean[] exists(ListGet gets) throws IOException method
implemented in HTableInterface.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7503) Add exists(List) in HTableInterface to allow multiple parallel exists at one time
[
https://issues.apache.org/jira/browse/HBASE-7503?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13552102#comment-13552102
]
Hadoop QA commented on HBASE-7503:
--
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12564596/HBASE-7503-v1-trunk.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 3 new
or modified tests.
{color:green}+1 hadoop2.0{color}. The patch compiles against the hadoop
2.0 profile.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:red}-1 findbugs{color}. The patch appears to introduce 1 new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 lineLengths{color}. The patch does not introduce lines
longer than 100
{color:red}-1 core tests{color}. The patch failed these unit tests:
org.apache.hadoop.hbase.TestLocalHBaseCluster
{color:red}-1 core zombie tests{color}. There are 3 zombie test(s):
at
org.apache.hadoop.hdfs.server.balancer.TestBalancerWithNodeGroup.testBalancerWithRackLocality(TestBalancerWithNodeGroup.java:220)
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/3992//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/3992//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/3992//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/3992//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/3992//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/3992//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/3992//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/3992//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/3992//console
This message is automatically generated.
Add exists(List) in HTableInterface to allow multiple parallel exists at one
time
-
Key: HBASE-7503
URL: https://issues.apache.org/jira/browse/HBASE-7503
Project: HBase
Issue Type: Improvement
Reporter: Jean-Marc Spaggiari
Assignee: Jean-Marc Spaggiari
Priority: Minor
Fix For: 0.96.0
Attachments: HBASE-7503-v0-trunk.patch, HBASE-7503-v1-trunk.patch
Original Estimate: 5m
Remaining Estimate: 5m
We need to have a Boolean[] exists(ListGet gets) throws IOException method
implemented in HTableInterface.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7503) Add exists(List) in HTableInterface to allow multiple parallel exists at one time
[
https://issues.apache.org/jira/browse/HBASE-7503?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13552109#comment-13552109
]
Ted Yu commented on HBASE-7503:
---
For the following:
{code}
repeated GetRequest get = 2;
{code}
Were you suggesting that MultiGetReuqest include multiple GetRequest's ?
I think the formation from my comment @ 07/Jan/13 02:32 was correct.
Add exists(List) in HTableInterface to allow multiple parallel exists at one
time
-
Key: HBASE-7503
URL: https://issues.apache.org/jira/browse/HBASE-7503
Project: HBase
Issue Type: Improvement
Reporter: Jean-Marc Spaggiari
Assignee: Jean-Marc Spaggiari
Priority: Minor
Fix For: 0.96.0
Attachments: HBASE-7503-v0-trunk.patch, HBASE-7503-v1-trunk.patch
Original Estimate: 5m
Remaining Estimate: 5m
We need to have a Boolean[] exists(ListGet gets) throws IOException method
implemented in HTableInterface.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7503) Add exists(List) in HTableInterface to allow multiple parallel exists at one time
[
https://issues.apache.org/jira/browse/HBASE-7503?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13552124#comment-13552124
]
Jean-Marc Spaggiari commented on HBASE-7503:
The idea is the following.
We have 2 options. We can build the MultiGetRequest or re-use the GetRequest.
If we re-use the GetRequest we might have some duplicates on the region field,
but that will allow to have different requests bundled togehter (some with
existenceOnly, some without, etc.) If we build the MultiGetRequest on repeated
Get, that reduce the size of the data, but that reduce also the usecases.
{code}
message MultiGetRequest {
required RegionSpecifier region = 1;
repeated Get get = 2;
// If the row to get doesn't exist, return the
// closest row before.
optional bool closestRowBefore = 3;
// The result isn't asked for, just check for
// the existence. If specified, closestRowBefore
// will be ignored
optional bool existenceOnly = 4;
}
{code}
or
{code}
message MultiGetRequest {
repeated GetRequest get = 1;
}
{code}
I see pros and cons for both solutions. But I might be missing the overall
picture...
Add exists(List) in HTableInterface to allow multiple parallel exists at one
time
-
Key: HBASE-7503
URL: https://issues.apache.org/jira/browse/HBASE-7503
Project: HBase
Issue Type: Improvement
Reporter: Jean-Marc Spaggiari
Assignee: Jean-Marc Spaggiari
Priority: Minor
Fix For: 0.96.0
Attachments: HBASE-7503-v0-trunk.patch, HBASE-7503-v1-trunk.patch
Original Estimate: 5m
Remaining Estimate: 5m
We need to have a Boolean[] exists(ListGet gets) throws IOException method
implemented in HTableInterface.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7503) Add exists(List) in HTableInterface to allow multiple parallel exists at one time
[ https://issues.apache.org/jira/browse/HBASE-7503?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13552126#comment-13552126 ] Ted Yu commented on HBASE-7503: --- For the implementation I was thinking of, MultiGetRequest would be composed by client by criteria of residing in same region. So I would choose option #1. Add exists(List) in HTableInterface to allow multiple parallel exists at one time - Key: HBASE-7503 URL: https://issues.apache.org/jira/browse/HBASE-7503 Project: HBase Issue Type: Improvement Reporter: Jean-Marc Spaggiari Assignee: Jean-Marc Spaggiari Priority: Minor Fix For: 0.96.0 Attachments: HBASE-7503-v0-trunk.patch, HBASE-7503-v1-trunk.patch Original Estimate: 5m Remaining Estimate: 5m We need to have a Boolean[] exists(ListGet gets) throws IOException method implemented in HTableInterface. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7503) Add exists(List) in HTableInterface to allow multiple parallel exists at one time
[ https://issues.apache.org/jira/browse/HBASE-7503?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13545870#comment-13545870 ] Jean-Marc Spaggiari commented on HBASE-7503: Hi Ted, Thanks for your comments. 2 questions. 1) What do you mean by Restore interrupt status? Should I throw it back? (and then add throws InterruptedException on the methode signature) 2) Regarding MultiGetRequest, just to make sure, that will also mean to add a ServerCallable constructor which can take a list of get? Then we need to give it only gets who are relying on the same region? But what if in the meantime the region split and the gets are no more all on the same region? Should we manage retries there too? This last point is making the modification way bigger and there will be a need of some design thinking. Add exists(List) in HTableInterface to allow multiple parallel exists at one time - Key: HBASE-7503 URL: https://issues.apache.org/jira/browse/HBASE-7503 Project: HBase Issue Type: Improvement Reporter: Jean-Marc Spaggiari Assignee: Jean-Marc Spaggiari Priority: Minor Fix For: 0.96.0 Attachments: HBASE-7503-v0-trunk.patch Original Estimate: 5m Remaining Estimate: 5m We need to have a Boolean[] exists(ListGet gets) throws IOException method implemented in HTableInterface. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7503) Add exists(List) in HTableInterface to allow multiple parallel exists at one time
[
https://issues.apache.org/jira/browse/HBASE-7503?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13545962#comment-13545962
]
Ted Yu commented on HBASE-7503:
---
For #1, I meant adding the following call:
{code}
Thread.currentThread().interrupt();
{code}
For #2, we do need to find a good design. ProtobufUtil.getRemoteException() can
be used to examine the cause of failure so that we take proper action
accordingly.
Add exists(List) in HTableInterface to allow multiple parallel exists at one
time
-
Key: HBASE-7503
URL: https://issues.apache.org/jira/browse/HBASE-7503
Project: HBase
Issue Type: Improvement
Reporter: Jean-Marc Spaggiari
Assignee: Jean-Marc Spaggiari
Priority: Minor
Fix For: 0.96.0
Attachments: HBASE-7503-v0-trunk.patch
Original Estimate: 5m
Remaining Estimate: 5m
We need to have a Boolean[] exists(ListGet gets) throws IOException method
implemented in HTableInterface.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7503) Add exists(List) in HTableInterface to allow multiple parallel exists at one time
[
https://issues.apache.org/jira/browse/HBASE-7503?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13545581#comment-13545581
]
Hadoop QA commented on HBASE-7503:
--
{color:green}+1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12563510/HBASE-7503-v0-trunk.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 3 new
or modified tests.
{color:green}+1 hadoop2.0{color}. The patch compiles against the hadoop
2.0 profile.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 lineLengths{color}. The patch does not introduce lines
longer than 100
{color:green}+1 core tests{color}. The patch passed unit tests in .
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/3882//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/3882//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/3882//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/3882//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/3882//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/3882//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/3882//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/3882//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/3882//console
This message is automatically generated.
Add exists(List) in HTableInterface to allow multiple parallel exists at one
time
-
Key: HBASE-7503
URL: https://issues.apache.org/jira/browse/HBASE-7503
Project: HBase
Issue Type: Improvement
Reporter: Jean-Marc Spaggiari
Assignee: Jean-Marc Spaggiari
Priority: Minor
Fix For: 0.96.0
Attachments: HBASE-7503-v0-trunk.patch
Original Estimate: 5m
Remaining Estimate: 5m
We need to have a Boolean[] exists(ListGet gets) throws IOException method
implemented in HTableInterface.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7503) Add exists(List) in HTableInterface to allow multiple parallel exists at one time
[
https://issues.apache.org/jira/browse/HBASE-7503?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13545586#comment-13545586
]
Ted Yu commented on HBASE-7503:
---
Consider adding the new test to TestFromClientSide3.java - TestFromClientSide
is getting quite big.
{code}
+LOG.warn(exists(ListGet) is really list of get() calls, just use
get());
{code}
Did you intend to put the above in javadoc ?
{code}
+ * @return Array of true if the specified Get matches one or more keys,
false if not
{code}
'Array of' - 'Array of Boolean'
{code}
+ } catch (InterruptedException e) {
+LOG.warn(Failed for get: + gets.get(i).toString(), e);
{code}
Restore interrupt status.
Currently we have GetRequest in Client.proto. I wonder whether it is worth
introducing MultiGetReuqest where we have:
{code}
repeated Get get = 2;
{code}
This way we can group Gets by region and make fewer calls to server.
Add exists(List) in HTableInterface to allow multiple parallel exists at one
time
-
Key: HBASE-7503
URL: https://issues.apache.org/jira/browse/HBASE-7503
Project: HBase
Issue Type: Improvement
Reporter: Jean-Marc Spaggiari
Assignee: Jean-Marc Spaggiari
Priority: Minor
Fix For: 0.96.0
Attachments: HBASE-7503-v0-trunk.patch
Original Estimate: 5m
Remaining Estimate: 5m
We need to have a Boolean[] exists(ListGet gets) throws IOException method
implemented in HTableInterface.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
