[jira] [Commented] (IGNITE-12108) [IEP-35] Migrate Communication Metrics.
[ https://issues.apache.org/jira/browse/IGNITE-12108?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17015105#comment-17015105 ] Nikolay Izhikov commented on IGNITE-12108: -- *Results:* |*US*|*master*|*IGNITE-12108*|*Comparsion*| |*Operations/sec* *(more is better), AVG*|*Latency, nsec* *(less is better), AVG*|*Operations/sec* *(more is better), AVG*|*Latency, nsec* *(less is better), AVG*|*Operations/sec* *(more is better), AVG*|*Latency* *(less is better), AVG*| |IgnitePutBenchmark|234723,5|273524|241243|265166|3%|-3%| |IgniteGetBenchmark|413882,5|154788|420116,5|152044,5|2%|-2%| |IgnitePutAllBenchmark|52166,5|1230246|49916,5|1286488|-4%|5%| |IgniteGetTxBenchmark|417712,5|152979|417583,5|153018|0%|0%| |IgnitePutTxBenchmark|71293|903559|70409|921153,5|1%|2%| |IgniteSqlMergeQueryBenchmark|110548,5|579658|109350,5|587350|-1%|1%| > [IEP-35] Migrate Communication Metrics. > --- > > Key: IGNITE-12108 > URL: https://issues.apache.org/jira/browse/IGNITE-12108 > Project: Ignite > Issue Type: New Feature >Reporter: Ivan Bessonov >Assignee: Ivan Bessonov >Priority: Major > Labels: IEP-35, await > Fix For: 2.8 > > Time Spent: 9h > Remaining Estimate: 0h > > ||*Name*||*Description*|| > |communication.tcp.outboundMessagesQueueSize|Number of messages waiting to be > sent| > |communication.tcp.sentBytes|Total number of bytes received by current node| > |communication.tcp.receivedBytes|Total number of bytes sent by current node| > |communication.tcp.sentMessagesCount|Total number of messages sent by current > node| > |communication.tcp.receivedMessagesCount|Total number of messages received by > current node| > |communication.tcp.sentMessagesByType.|Total number of messages > with given type sent by current node| > |communication.tcp.receivedMessagesByType.|Total number of > messages with given type received by current node| > |communication.tcp..sentMessagesToNode|Total number of messages sent > by current node to the given node| > |communication.tcp..receivedMessagesFromNode|Total number of messages > received by current node from the given node| > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (IGNITE-12108) [IEP-35] Migrate Communication Metrics.
[ https://issues.apache.org/jira/browse/IGNITE-12108?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17012598#comment-17012598 ] Nikolay Izhikov commented on IGNITE-12108: -- LGTM. Thank you, so much for the valuable contribution! I will gather performance tests results and merge this patch if everything is OK. > [IEP-35] Migrate Communication Metrics. > --- > > Key: IGNITE-12108 > URL: https://issues.apache.org/jira/browse/IGNITE-12108 > Project: Ignite > Issue Type: New Feature >Reporter: Ivan Bessonov >Assignee: Ivan Bessonov >Priority: Major > Labels: IEP-35, await > Fix For: 2.8 > > Time Spent: 9h > Remaining Estimate: 0h > > ||*Name*||*Description*|| > |communication.tcp.outboundMessagesQueueSize|Number of messages waiting to be > sent| > |communication.tcp.sentBytes|Total number of bytes received by current node| > |communication.tcp.receivedBytes|Total number of bytes sent by current node| > |communication.tcp.sentMessagesCount|Total number of messages sent by current > node| > |communication.tcp.receivedMessagesCount|Total number of messages received by > current node| > |communication.tcp.sentMessagesByType.|Total number of messages > with given type sent by current node| > |communication.tcp.receivedMessagesByType.|Total number of > messages with given type received by current node| > |communication.tcp..sentMessagesToNode|Total number of messages sent > by current node to the given node| > |communication.tcp..receivedMessagesFromNode|Total number of messages > received by current node from the given node| > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (IGNITE-12108) [IEP-35] Migrate Communication Metrics.
[
https://issues.apache.org/jira/browse/IGNITE-12108?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17002755#comment-17002755
]
Ignite TC Bot commented on IGNITE-12108:
{panel:title=Branch: [pull/6814/head] Base: [master] : No blockers
found!|borderStyle=dashed|borderColor=#ccc|titleBGColor=#D6F7C1}{panel}
[TeamCity *-- Run :: All*
Results|https://ci.ignite.apache.org/viewLog.html?buildId=4869116buildTypeId=IgniteTests24Java8_RunAll]
> [IEP-35] Migrate Communication Metrics.
> ---
>
> Key: IGNITE-12108
> URL: https://issues.apache.org/jira/browse/IGNITE-12108
> Project: Ignite
> Issue Type: New Feature
>Reporter: Ivan Bessonov
>Assignee: Ivan Bessonov
>Priority: Major
> Labels: IEP-35, await
> Fix For: 2.8
>
> Time Spent: 7h 40m
> Remaining Estimate: 0h
>
> ||*Name*||*Description*||
> |communication.tcp.outboundMessagesQueueSize|Number of messages waiting to be
> sent|
> |communication.tcp.sentBytes|Total number of bytes received by current node|
> |communication.tcp.receivedBytes|Total number of bytes sent by current node|
> |communication.tcp.sentMessagesCount|Total number of messages sent by current
> node|
> |communication.tcp.receivedMessagesCount|Total number of messages received by
> current node|
> |communication.tcp.sentMessagesByType.|Total number of messages
> with given type sent by current node|
> |communication.tcp.receivedMessagesByType.|Total number of
> messages with given type received by current node|
> |communication.tcp..sentMessagesToNode|Total number of messages sent
> by current node to the given node|
> |communication.tcp..receivedMessagesFromNode|Total number of messages
> received by current node from the given node|
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (IGNITE-12108) [IEP-35] Migrate Communication Metrics.
[ https://issues.apache.org/jira/browse/IGNITE-12108?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16988621#comment-16988621 ] Ivan Bessonov commented on IGNITE-12108: [~nizhikov] I hope I addressed everything, please take a look at the code and my comments one more time. Thank you! > [IEP-35] Migrate Communication Metrics. > --- > > Key: IGNITE-12108 > URL: https://issues.apache.org/jira/browse/IGNITE-12108 > Project: Ignite > Issue Type: New Feature >Reporter: Ivan Bessonov >Assignee: Ivan Bessonov >Priority: Major > Labels: IEP-35, await > Fix For: 2.8 > > Time Spent: 7h 10m > Remaining Estimate: 0h > > ||*Name*||*Description*|| > |communication.tcp.outboundMessagesQueueSize|Number of messages waiting to be > sent| > |communication.tcp.sentBytes|Total number of bytes received by current node| > |communication.tcp.receivedBytes|Total number of bytes sent by current node| > |communication.tcp.sentMessagesCount|Total number of messages sent by current > node| > |communication.tcp.receivedMessagesCount|Total number of messages received by > current node| > |communication.tcp.sentMessagesByType.|Total number of messages > with given type sent by current node| > |communication.tcp.receivedMessagesByType.|Total number of > messages with given type received by current node| > |communication.tcp..sentMessagesToNode|Total number of messages sent > by current node to the given node| > |communication.tcp..receivedMessagesFromNode|Total number of messages > received by current node from the given node| > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (IGNITE-12108) [IEP-35] Migrate Communication Metrics.
[ https://issues.apache.org/jira/browse/IGNITE-12108?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16981127#comment-16981127 ] Nikolay Izhikov commented on IGNITE-12108: -- [~ibessonov] Thanks for the PR update. Looks much better now! Please, take a look at my comments on github. > [IEP-35] Migrate Communication Metrics. > --- > > Key: IGNITE-12108 > URL: https://issues.apache.org/jira/browse/IGNITE-12108 > Project: Ignite > Issue Type: New Feature >Reporter: Ivan Bessonov >Assignee: Ivan Bessonov >Priority: Major > Labels: IEP-35, await > Fix For: 2.8 > > Time Spent: 6h 10m > Remaining Estimate: 0h > > ||*Name*||*Description*|| > |communication.tcp.outboundMessagesQueueSize|Number of messages waiting to be > sent| > |communication.tcp.sentBytes|Total number of bytes received by current node| > |communication.tcp.receivedBytes|Total number of bytes sent by current node| > |communication.tcp.sentMessagesCount|Total number of messages sent by current > node| > |communication.tcp.receivedMessagesCount|Total number of messages received by > current node| > |communication.tcp.sentMessagesByType.|Total number of messages > with given type sent by current node| > |communication.tcp.receivedMessagesByType.|Total number of > messages with given type received by current node| > |communication.tcp..sentMessagesToNode|Total number of messages sent > by current node to the given node| > |communication.tcp..receivedMessagesFromNode|Total number of messages > received by current node from the given node| > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (IGNITE-12108) [IEP-35] Migrate Communication Metrics.
[
https://issues.apache.org/jira/browse/IGNITE-12108?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16975053#comment-16975053
]
Ignite TC Bot commented on IGNITE-12108:
{panel:title=Branch: [pull/6814/head] Base: [master] : No blockers
found!|borderStyle=dashed|borderColor=#ccc|titleBGColor=#D6F7C1}{panel}
[TeamCity *-- Run :: All*
Results|https://ci.ignite.apache.org/viewLog.html?buildId=4768125buildTypeId=IgniteTests24Java8_RunAll]
> [IEP-35] Migrate Communication Metrics.
> ---
>
> Key: IGNITE-12108
> URL: https://issues.apache.org/jira/browse/IGNITE-12108
> Project: Ignite
> Issue Type: New Feature
>Reporter: Ivan Bessonov
>Assignee: Ivan Bessonov
>Priority: Major
> Labels: IEP-35, await
> Fix For: 2.8
>
> Time Spent: 4h 40m
> Remaining Estimate: 0h
>
> ||*Name*||*Description*||
> |communication.tcp.outboundMessagesQueueSize|Number of messages waiting to be
> sent|
> |communication.tcp.sentBytes|Total number of bytes received by current node|
> |communication.tcp.receivedBytes|Total number of bytes sent by current node|
> |communication.tcp.sentMessagesCount|Total number of messages sent by current
> node|
> |communication.tcp.receivedMessagesCount|Total number of messages received by
> current node|
> |communication.tcp.sentMessagesByType.|Total number of messages
> with given type sent by current node|
> |communication.tcp.receivedMessagesByType.|Total number of
> messages with given type received by current node|
> |communication.tcp..sentMessagesToNode|Total number of messages sent
> by current node to the given node|
> |communication.tcp..receivedMessagesFromNode|Total number of messages
> received by current node from the given node|
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (IGNITE-12108) [IEP-35] Migrate Communication Metrics.
[ https://issues.apache.org/jira/browse/IGNITE-12108?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16975052#comment-16975052 ] Ivan Bessonov commented on IGNITE-12108: [~nizhikov] sorry for a delay, I fixed everything from your last comments except for the one. I commented it in PR, please check it, I hope it's fine now. > [IEP-35] Migrate Communication Metrics. > --- > > Key: IGNITE-12108 > URL: https://issues.apache.org/jira/browse/IGNITE-12108 > Project: Ignite > Issue Type: New Feature >Reporter: Ivan Bessonov >Assignee: Ivan Bessonov >Priority: Major > Labels: IEP-35, await > Fix For: 2.8 > > Time Spent: 4h 40m > Remaining Estimate: 0h > > ||*Name*||*Description*|| > |communication.tcp.outboundMessagesQueueSize|Number of messages waiting to be > sent| > |communication.tcp.sentBytes|Total number of bytes received by current node| > |communication.tcp.receivedBytes|Total number of bytes sent by current node| > |communication.tcp.sentMessagesCount|Total number of messages sent by current > node| > |communication.tcp.receivedMessagesCount|Total number of messages received by > current node| > |communication.tcp.sentMessagesByType.|Total number of messages > with given type sent by current node| > |communication.tcp.receivedMessagesByType.|Total number of > messages with given type received by current node| > |communication.tcp..sentMessagesToNode|Total number of messages sent > by current node to the given node| > |communication.tcp..receivedMessagesFromNode|Total number of messages > received by current node from the given node| > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (IGNITE-12108) [IEP-35] Migrate Communication Metrics.
[ https://issues.apache.org/jira/browse/IGNITE-12108?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16962949#comment-16962949 ] Ivan Bessonov commented on IGNITE-12108: >> I'll commit that changes soon. >I think we should come to a consensus here before the merge. I meant the ignite-12108 branch with fixed review remarks, I have no permissions to commit to master :) > [IEP-35] Migrate Communication Metrics. > --- > > Key: IGNITE-12108 > URL: https://issues.apache.org/jira/browse/IGNITE-12108 > Project: Ignite > Issue Type: New Feature >Reporter: Ivan Bessonov >Assignee: Ivan Bessonov >Priority: Major > Labels: IEP-35, await > Fix For: 2.8 > > Time Spent: 4h 20m > Remaining Estimate: 0h > > ||*Name*||*Description*|| > |communication.tcp.outboundMessagesQueueSize|Number of messages waiting to be > sent| > |communication.tcp.sentBytes|Total number of bytes received by current node| > |communication.tcp.receivedBytes|Total number of bytes sent by current node| > |communication.tcp.sentMessagesCount|Total number of messages sent by current > node| > |communication.tcp.receivedMessagesCount|Total number of messages received by > current node| > |communication.tcp.sentMessagesByType.|Total number of messages > with given type sent by current node| > |communication.tcp.receivedMessagesByType.|Total number of > messages with given type received by current node| > |communication.tcp..sentMessagesToNode|Total number of messages sent > by current node to the given node| > |communication.tcp..receivedMessagesFromNode|Total number of messages > received by current node from the given node| > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (IGNITE-12108) [IEP-35] Migrate Communication Metrics.
[
https://issues.apache.org/jira/browse/IGNITE-12108?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16962894#comment-16962894
]
Nikolay Izhikov commented on IGNITE-12108:
--
[~ibessonov]
First of all, thanks for working on this.
> One of those constructors (GridNioServer) already had nullable parameter,
> should I eliminate it as well?
Yes. I think we should do it.
As I can see, there is only one place in the source, where we pass null as
{MetricRegistry}
{code:java}
public GridTcpNioCommunicationClient(
int connIdx,
GridNioSession ses,
IgniteLogger log
) {
super(connIdx, null);
assert ses != null;
assert log != null;
this.ses = ses;
this.log = log;
}
{code}
It's not clear for me, why we do it.
We can do one of following improvements:
1. Provide corresponding {MetricRegistry} in {GridTcpNioCommunicationClient}
and collect metrics for it.
2. Eliminate {MetricRegistry} from {GridAbstractCommunicationClient} and store
it directly in {GridShmemCommunicationClient} - only usage of it.
> I'll commit that changes soon.
I think we should come to a consensus here before the merge.
> [IEP-35] Migrate Communication Metrics.
> ---
>
> Key: IGNITE-12108
> URL: https://issues.apache.org/jira/browse/IGNITE-12108
> Project: Ignite
> Issue Type: New Feature
>Reporter: Ivan Bessonov
>Assignee: Ivan Bessonov
>Priority: Major
> Labels: IEP-35, await
> Fix For: 2.8
>
> Time Spent: 4h 20m
> Remaining Estimate: 0h
>
> ||*Name*||*Description*||
> |communication.tcp.outboundMessagesQueueSize|Number of messages waiting to be
> sent|
> |communication.tcp.sentBytes|Total number of bytes received by current node|
> |communication.tcp.receivedBytes|Total number of bytes sent by current node|
> |communication.tcp.sentMessagesCount|Total number of messages sent by current
> node|
> |communication.tcp.receivedMessagesCount|Total number of messages received by
> current node|
> |communication.tcp.sentMessagesByType.|Total number of messages
> with given type sent by current node|
> |communication.tcp.receivedMessagesByType.|Total number of
> messages with given type received by current node|
> |communication.tcp..sentMessagesToNode|Total number of messages sent
> by current node to the given node|
> |communication.tcp..receivedMessagesFromNode|Total number of messages
> received by current node from the given node|
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (IGNITE-12108) [IEP-35] Migrate Communication Metrics.
[ https://issues.apache.org/jira/browse/IGNITE-12108?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16962828#comment-16962828 ] Ivan Bessonov commented on IGNITE-12108: [~nizhikov] > All I ask you regarding this PR is to avoid Nullable constructor params. One of those constructors (GridNioServer) already had nullable parameter, should I eliminate it as well? And what's the point of having two constructors instead of one in abstract class (GridAbstractCommunicationClient)? It won't make the code more readable. Everything else is fine, I'll commit that changes soon. > [IEP-35] Migrate Communication Metrics. > --- > > Key: IGNITE-12108 > URL: https://issues.apache.org/jira/browse/IGNITE-12108 > Project: Ignite > Issue Type: New Feature >Reporter: Ivan Bessonov >Assignee: Ivan Bessonov >Priority: Major > Labels: IEP-35, await > Fix For: 2.8 > > Time Spent: 4h 20m > Remaining Estimate: 0h > > ||*Name*||*Description*|| > |communication.tcp.outboundMessagesQueueSize|Number of messages waiting to be > sent| > |communication.tcp.sentBytes|Total number of bytes received by current node| > |communication.tcp.receivedBytes|Total number of bytes sent by current node| > |communication.tcp.sentMessagesCount|Total number of messages sent by current > node| > |communication.tcp.receivedMessagesCount|Total number of messages received by > current node| > |communication.tcp.sentMessagesByType.|Total number of messages > with given type sent by current node| > |communication.tcp.receivedMessagesByType.|Total number of > messages with given type received by current node| > |communication.tcp..sentMessagesToNode|Total number of messages sent > by current node to the given node| > |communication.tcp..receivedMessagesFromNode|Total number of messages > received by current node from the given node| > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (IGNITE-12108) [IEP-35] Migrate Communication Metrics.
[
https://issues.apache.org/jira/browse/IGNITE-12108?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16960838#comment-16960838
]
Nikolay Izhikov commented on IGNITE-12108:
--
> I wanted to introduce metrics for Communication SPI
All I ask you regarding this PR is to avoid Nullable constructor params.
Can we do it?
> That method is deprecated and invoked in JMX only, should I really care about
> rare single get operation?
1.. Yes you should, because, many existing deployments use existing metrics.
It takes time for it to migrate on the new framework.
2. It's easy to fix, please, do it.
> What was the motivation behind your comment?
You should avoid any unnecessary changes in the codebase for the sake of review
simplicity.
{this} fixes are unnecessary. Please, revert them in this PR.
If you want to refactor it I propose the better way:
1. Discuss this code style point on the dev-list.
2. Find checkstyle rule to automatically check it.
3. Refactor all Ignite codebase in single commit to the preferred assignment
style
WDYT?
> [IEP-35] Migrate Communication Metrics.
> ---
>
> Key: IGNITE-12108
> URL: https://issues.apache.org/jira/browse/IGNITE-12108
> Project: Ignite
> Issue Type: New Feature
>Reporter: Ivan Bessonov
>Assignee: Ivan Bessonov
>Priority: Major
> Labels: IEP-35, await
> Fix For: 2.8
>
> Time Spent: 4h 20m
> Remaining Estimate: 0h
>
> ||*Name*||*Description*||
> |communication.tcp.outboundMessagesQueueSize|Number of messages waiting to be
> sent|
> |communication.tcp.sentBytes|Total number of bytes received by current node|
> |communication.tcp.receivedBytes|Total number of bytes sent by current node|
> |communication.tcp.sentMessagesCount|Total number of messages sent by current
> node|
> |communication.tcp.receivedMessagesCount|Total number of messages received by
> current node|
> |communication.tcp.sentMessagesByType.|Total number of messages
> with given type sent by current node|
> |communication.tcp.receivedMessagesByType.|Total number of
> messages with given type received by current node|
> |communication.tcp..sentMessagesToNode|Total number of messages sent
> by current node to the given node|
> |communication.tcp..receivedMessagesFromNode|Total number of messages
> received by current node from the given node|
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (IGNITE-12108) [IEP-35] Migrate Communication Metrics.
[
https://issues.apache.org/jira/browse/IGNITE-12108?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16960818#comment-16960818
]
Ivan Bessonov commented on IGNITE-12108:
[~nizhikov] can you please explain why it's a poor design and why it has to be
fixed in this particular issue?
I wanted to introduce metrics for Communication SPI, not for every other
component that uses NIO server. If you want me to do it then please create
separate issue.
> It's about unnecessary {{Map#get}} operation.
That method is deprecated and invoked in JMX only, should I really care about
rare single get operation? I don't think so.
> Please, revert unnecessary changes.
Do we have any strict rules about removing unnecessary "this." references in
code?
I mean, it's not hard for me to return everything back, but how should I
initialize new field, "this.ctx = ...;" or "ctx = ...;"? What was the
motivation behind your comment?
Please reply, thank you!
> [IEP-35] Migrate Communication Metrics.
> ---
>
> Key: IGNITE-12108
> URL: https://issues.apache.org/jira/browse/IGNITE-12108
> Project: Ignite
> Issue Type: New Feature
>Reporter: Ivan Bessonov
>Assignee: Ivan Bessonov
>Priority: Major
> Labels: IEP-35, await
> Fix For: 2.8
>
> Time Spent: 4h 20m
> Remaining Estimate: 0h
>
> ||*Name*||*Description*||
> |communication.tcp.outboundMessagesQueueSize|Number of messages waiting to be
> sent|
> |communication.tcp.sentBytes|Total number of bytes received by current node|
> |communication.tcp.receivedBytes|Total number of bytes sent by current node|
> |communication.tcp.sentMessagesCount|Total number of messages sent by current
> node|
> |communication.tcp.receivedMessagesCount|Total number of messages received by
> current node|
> |communication.tcp.sentMessagesByType.|Total number of messages
> with given type sent by current node|
> |communication.tcp.receivedMessagesByType.|Total number of
> messages with given type received by current node|
> |communication.tcp..sentMessagesToNode|Total number of messages sent
> by current node to the given node|
> |communication.tcp..receivedMessagesFromNode|Total number of messages
> received by current node from the given node|
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (IGNITE-12108) [IEP-35] Migrate Communication Metrics.
[ https://issues.apache.org/jira/browse/IGNITE-12108?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16959580#comment-16959580 ] Nikolay Izhikov commented on IGNITE-12108: -- My other comments on the PR not fixed, also. I think, this patch should be improved to be able to merge. Right now, I'm -1 to merge it. > [IEP-35] Migrate Communication Metrics. > --- > > Key: IGNITE-12108 > URL: https://issues.apache.org/jira/browse/IGNITE-12108 > Project: Ignite > Issue Type: New Feature >Reporter: Ivan Bessonov >Assignee: Ivan Bessonov >Priority: Major > Labels: IEP-35, await > Fix For: 2.8 > > Time Spent: 3h 50m > Remaining Estimate: 0h > > ||*Name*||*Description*|| > |communication.tcp.outboundMessagesQueueSize|Number of messages waiting to be > sent| > |communication.tcp.sentBytes|Total number of bytes received by current node| > |communication.tcp.receivedBytes|Total number of bytes sent by current node| > |communication.tcp.sentMessagesCount|Total number of messages sent by current > node| > |communication.tcp.receivedMessagesCount|Total number of messages received by > current node| > |communication.tcp.sentMessagesByType.|Total number of messages > with given type sent by current node| > |communication.tcp.receivedMessagesByType.|Total number of > messages with given type received by current node| > |communication.tcp..sentMessagesToNode|Total number of messages sent > by current node to the given node| > |communication.tcp..receivedMessagesFromNode|Total number of messages > received by current node from the given node| > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (IGNITE-12108) [IEP-35] Migrate Communication Metrics.
[ https://issues.apache.org/jira/browse/IGNITE-12108?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16959578#comment-16959578 ] Nikolay Izhikov commented on IGNITE-12108: -- [~DmitriyGovorukhin] [~ibessonov] As I can see, we still have nullable MetricRegistry in the constructor. Not clear why it's happening. It looks like a poor design, for me, so we should avoid such use-cases. I'm not OK with it. Can we fix it? > [IEP-35] Migrate Communication Metrics. > --- > > Key: IGNITE-12108 > URL: https://issues.apache.org/jira/browse/IGNITE-12108 > Project: Ignite > Issue Type: New Feature >Reporter: Ivan Bessonov >Assignee: Ivan Bessonov >Priority: Major > Labels: IEP-35, await > Fix For: 2.8 > > Time Spent: 3h 50m > Remaining Estimate: 0h > > ||*Name*||*Description*|| > |communication.tcp.outboundMessagesQueueSize|Number of messages waiting to be > sent| > |communication.tcp.sentBytes|Total number of bytes received by current node| > |communication.tcp.receivedBytes|Total number of bytes sent by current node| > |communication.tcp.sentMessagesCount|Total number of messages sent by current > node| > |communication.tcp.receivedMessagesCount|Total number of messages received by > current node| > |communication.tcp.sentMessagesByType.|Total number of messages > with given type sent by current node| > |communication.tcp.receivedMessagesByType.|Total number of > messages with given type received by current node| > |communication.tcp..sentMessagesToNode|Total number of messages sent > by current node to the given node| > |communication.tcp..receivedMessagesFromNode|Total number of messages > received by current node from the given node| > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (IGNITE-12108) [IEP-35] Migrate Communication Metrics.
[ https://issues.apache.org/jira/browse/IGNITE-12108?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16959571#comment-16959571 ] Dmitriy Govorukhin commented on IGNITE-12108: - [~nizhikov] Do you have any objections? As I can see, Ivan fixed all comments. > [IEP-35] Migrate Communication Metrics. > --- > > Key: IGNITE-12108 > URL: https://issues.apache.org/jira/browse/IGNITE-12108 > Project: Ignite > Issue Type: New Feature >Reporter: Ivan Bessonov >Assignee: Ivan Bessonov >Priority: Major > Labels: IEP-35, await > Fix For: 2.8 > > Time Spent: 3h 50m > Remaining Estimate: 0h > > ||*Name*||*Description*|| > |communication.tcp.outboundMessagesQueueSize|Number of messages waiting to be > sent| > |communication.tcp.sentBytes|Total number of bytes received by current node| > |communication.tcp.receivedBytes|Total number of bytes sent by current node| > |communication.tcp.sentMessagesCount|Total number of messages sent by current > node| > |communication.tcp.receivedMessagesCount|Total number of messages received by > current node| > |communication.tcp.sentMessagesByType.|Total number of messages > with given type sent by current node| > |communication.tcp.receivedMessagesByType.|Total number of > messages with given type received by current node| > |communication.tcp..sentMessagesToNode|Total number of messages sent > by current node to the given node| > |communication.tcp..receivedMessagesFromNode|Total number of messages > received by current node from the given node| > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (IGNITE-12108) [IEP-35] Migrate Communication Metrics.
[
https://issues.apache.org/jira/browse/IGNITE-12108?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16938572#comment-16938572
]
Ignite TC Bot commented on IGNITE-12108:
{panel:title=Branch: [pull/6814/head] Base: [master] : No blockers
found!|borderStyle=dashed|borderColor=#ccc|titleBGColor=#D6F7C1}{panel}
[TeamCity *-- Run :: All*
Results|https://ci.ignite.apache.org/viewLog.html?buildId=4634554buildTypeId=IgniteTests24Java8_RunAll]
> [IEP-35] Migrate Communication Metrics.
> ---
>
> Key: IGNITE-12108
> URL: https://issues.apache.org/jira/browse/IGNITE-12108
> Project: Ignite
> Issue Type: New Feature
>Reporter: Ivan Bessonov
>Assignee: Ivan Bessonov
>Priority: Major
> Labels: IEP-35
> Fix For: 2.8
>
> Time Spent: 3h 50m
> Remaining Estimate: 0h
>
> ||*Name*||*Description*||
> |communication.tcp.outboundMessagesQueueSize|Number of messages waiting to be
> sent|
> |communication.tcp.sentBytes|Total number of bytes received by current node|
> |communication.tcp.receivedBytes|Total number of bytes sent by current node|
> |communication.tcp.sentMessagesCount|Total number of messages sent by current
> node|
> |communication.tcp.receivedMessagesCount|Total number of messages received by
> current node|
> |communication.tcp.sentMessagesByType.|Total number of messages
> with given type sent by current node|
> |communication.tcp.receivedMessagesByType.|Total number of
> messages with given type received by current node|
> |communication.tcp..sentMessagesToNode|Total number of messages sent
> by current node to the given node|
> |communication.tcp..receivedMessagesFromNode|Total number of messages
> received by current node from the given node|
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (IGNITE-12108) [IEP-35] Migrate Communication Metrics.
[ https://issues.apache.org/jira/browse/IGNITE-12108?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16937804#comment-16937804 ] Ivan Bessonov commented on IGNITE-12108: Hello [~NIzhikov], I updated the code according to your suggestions, please check it one more time. > [IEP-35] Migrate Communication Metrics. > --- > > Key: IGNITE-12108 > URL: https://issues.apache.org/jira/browse/IGNITE-12108 > Project: Ignite > Issue Type: New Feature >Reporter: Ivan Bessonov >Assignee: Ivan Bessonov >Priority: Major > Labels: IEP-35 > Fix For: 2.8 > > Time Spent: 3h 50m > Remaining Estimate: 0h > > ||*Name*||*Description*|| > |communication.tcp.outboundMessagesQueueSize|Number of messages waiting to be > sent| > |communication.tcp.sentBytes|Total number of bytes received by current node| > |communication.tcp.receivedBytes|Total number of bytes sent by current node| > |communication.tcp.sentMessagesCount|Total number of messages sent by current > node| > |communication.tcp.receivedMessagesCount|Total number of messages received by > current node| > |communication.tcp.sentMessagesByType.|Total number of messages > with given type sent by current node| > |communication.tcp.receivedMessagesByType.|Total number of > messages with given type received by current node| > |communication.tcp..sentMessagesToNode|Total number of messages sent > by current node to the given node| > |communication.tcp..receivedMessagesFromNode|Total number of messages > received by current node from the given node| > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (IGNITE-12108) [IEP-35] Migrate Communication Metrics.
[ https://issues.apache.org/jira/browse/IGNITE-12108?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16927602#comment-16927602 ] Nikolay Izhikov commented on IGNITE-12108: -- Hello, [~ibessonov] Thanks, for the contribution. I left some comments in pull request. Please, resolve them prior merge. > [IEP-35] Migrate Communication Metrics. > --- > > Key: IGNITE-12108 > URL: https://issues.apache.org/jira/browse/IGNITE-12108 > Project: Ignite > Issue Type: New Feature >Reporter: Ivan Bessonov >Assignee: Ivan Bessonov >Priority: Major > Labels: IEP-35 > Fix For: 2.8 > > Time Spent: 2h > Remaining Estimate: 0h > > ||*Name*||*Description*|| > |communication.tcp.outboundMessagesQueueSize|Number of messages waiting to be > sent| > |communication.tcp.sentBytes|Total number of bytes received by current node| > |communication.tcp.receivedBytes|Total number of bytes sent by current node| > |communication.tcp.sentMessagesCount|Total number of messages sent by current > node| > |communication.tcp.receivedMessagesCount|Total number of messages received by > current node| > |communication.tcp.sentMessagesByType.|Total number of messages > with given type sent by current node| > |communication.tcp.receivedMessagesByType.|Total number of > messages with given type received by current node| > |communication.tcp..sentMessagesToNode|Total number of messages sent > by current node to the given node| > |communication.tcp..receivedMessagesFromNode|Total number of messages > received by current node from the given node| > -- This message was sent by Atlassian Jira (v8.3.2#803003)
[jira] [Commented] (IGNITE-12108) [IEP-35] Migrate Communication Metrics.
[
https://issues.apache.org/jira/browse/IGNITE-12108?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16918319#comment-16918319
]
Ignite TC Bot commented on IGNITE-12108:
{panel:title=Branch: [pull/6814/head] Base: [master] : No blockers
found!|borderStyle=dashed|borderColor=#ccc|titleBGColor=#D6F7C1}{panel}
[TeamCity *-- Run :: All*
Results|https://ci.ignite.apache.org/viewLog.html?buildId=4541128buildTypeId=IgniteTests24Java8_RunAll]
> [IEP-35] Migrate Communication Metrics.
> ---
>
> Key: IGNITE-12108
> URL: https://issues.apache.org/jira/browse/IGNITE-12108
> Project: Ignite
> Issue Type: New Feature
>Reporter: Ivan Bessonov
>Assignee: Ivan Bessonov
>Priority: Major
> Labels: IEP-35
> Fix For: 2.8
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> ||*Name*||*Description*||
> |communication.tcp.outboundMessagesQueueSize|Number of messages waiting to be
> sent|
> |communication.tcp.sentBytes|Total number of bytes received by current node|
> |communication.tcp.receivedBytes|Total number of bytes sent by current node|
> |communication.tcp.sentMessagesCount|Total number of messages sent by current
> node|
> |communication.tcp.receivedMessagesCount|Total number of messages received by
> current node|
> |communication.tcp.sentMessagesByType.|Total number of messages
> with given type sent by current node|
> |communication.tcp.receivedMessagesByType.|Total number of
> messages with given type received by current node|
> |communication.tcp..sentMessagesToNode|Total number of messages sent
> by current node to the given node|
> |communication.tcp..receivedMessagesFromNode|Total number of messages
> received by current node from the given node|
>
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
