[jira] [Commented] (MRESOLVER-7) Download dependency POMs in parallel
[ https://issues.apache.org/jira/browse/MRESOLVER-7?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17171271#comment-17171271 ] Michael Osipov commented on MRESOLVER-7: [~rajjaiswalsaumya], when you provide a decent PR. > Download dependency POMs in parallel > > > Key: MRESOLVER-7 > URL: https://issues.apache.org/jira/browse/MRESOLVER-7 > Project: Maven Resolver > Issue Type: Improvement >Affects Versions: Aether 1.0.2 >Reporter: Harald Wellmann >Priority: Major > Time Spent: 40m > Remaining Estimate: 0h > > h3. Background > When building a project with dependencies not yet available in the local > repository, I noticed that Maven 3.3.9/Aether 1.0.2 first downloads the > dependency POMs _sequentially_ and then proceeds downloading the dependency > JARs with up to 5 threads _in parallel_. > Due to this, when first building a project with a large number of > dependencies, downloading a large number of small POMs may take a lot longer > than downloading the much larger JARs, or even longer than building the > project itself, especially when a repository manager is used which increases > the download latency. > h3. Enhancement > Download POMs of (transitive) dependencies in parallel to significantly speed > up initial builds of large projects. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [maven-script-interpreter] dependabot[bot] opened a new pull request #18: Bump maven-shared-utils from 3.2.1 to 3.3.3
dependabot[bot] opened a new pull request #18: URL: https://github.com/apache/maven-script-interpreter/pull/18 Bumps [maven-shared-utils](https://github.com/apache/maven-shared-utils) from 3.2.1 to 3.3.3. Commits https://github.com/apache/maven-shared-utils/commit/cc010396156386d95e2acbc28f7aba32590243a2;>cc01039 [maven-release-plugin] prepare release maven-shared-utils-3.3.3 https://github.com/apache/maven-shared-utils/commit/abdc90ccc36326dc6ee61ac497d2005e9e6637ef;>abdc90c [maven-release-plugin] prepare for next development iteration https://github.com/apache/maven-shared-utils/commit/5460b13f6f4230d5ddce3fe8ffb241ab42254346;>5460b13 [maven-release-plugin] prepare release maven-shared-utils-3.3.2 https://github.com/apache/maven-shared-utils/commit/60d005240b324e08661471fe6b0db981e2a0bd58;>60d0052 [maven-release-plugin] prepare for next development iteration https://github.com/apache/maven-shared-utils/commit/b3f78c16715d237b2d915d5cb963eef18b0d9fd2;>b3f78c1 [maven-release-plugin] prepare release maven-shared-utils-3.3.1 https://github.com/apache/maven-shared-utils/commit/d1acca0bfaa7eda578f522f8d7851af074dbaa1c;>d1acca0 Bump version to 3.3.1 in preparation for release. https://github.com/apache/maven-shared-utils/commit/5ff997cac035ac7d2ab84bbd2c695c6e60798400;>5ff997c [MSHARED-848] deprecate XmlStreamReader (https://github-redirect.dependabot.com/apache/maven-shared-utils/issues/59;>#59) https://github.com/apache/maven-shared-utils/commit/914d9755b157f337dfb76e90f6b0331f834096d6;>914d975 remove call to deprecated method (https://github-redirect.dependabot.com/apache/maven-shared-utils/issues/58;>#58) https://github.com/apache/maven-shared-utils/commit/dda9e1480f4f51120f619dfd302ed0d10807dfa5;>dda9e14 [MSHARED-904] update test dependencies for Maven 3.1 (https://github-redirect.dependabot.com/apache/maven-shared-utils/issues/57;>#57) https://github.com/apache/maven-shared-utils/commit/6798f3033c3c5144e52c5aa8e1be584ea97527d2;>6798f30 [MSHARED-297] - Minor code cleanup Additional commits viewable in https://github.com/apache/maven-shared-utils/compare/maven-shared-utils-3.2.1...maven-shared-utils-3.3.3;>compare view [](https://help.github.com/articles/configuring-automated-security-fixes) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-dependency-plugin] dependabot[bot] opened a new pull request #93: Bump maven-shared-utils from 3.2.1 to 3.3.3
dependabot[bot] opened a new pull request #93: URL: https://github.com/apache/maven-dependency-plugin/pull/93 Bumps [maven-shared-utils](https://github.com/apache/maven-shared-utils) from 3.2.1 to 3.3.3. Commits https://github.com/apache/maven-shared-utils/commit/cc010396156386d95e2acbc28f7aba32590243a2;>cc01039 [maven-release-plugin] prepare release maven-shared-utils-3.3.3 https://github.com/apache/maven-shared-utils/commit/abdc90ccc36326dc6ee61ac497d2005e9e6637ef;>abdc90c [maven-release-plugin] prepare for next development iteration https://github.com/apache/maven-shared-utils/commit/5460b13f6f4230d5ddce3fe8ffb241ab42254346;>5460b13 [maven-release-plugin] prepare release maven-shared-utils-3.3.2 https://github.com/apache/maven-shared-utils/commit/60d005240b324e08661471fe6b0db981e2a0bd58;>60d0052 [maven-release-plugin] prepare for next development iteration https://github.com/apache/maven-shared-utils/commit/b3f78c16715d237b2d915d5cb963eef18b0d9fd2;>b3f78c1 [maven-release-plugin] prepare release maven-shared-utils-3.3.1 https://github.com/apache/maven-shared-utils/commit/d1acca0bfaa7eda578f522f8d7851af074dbaa1c;>d1acca0 Bump version to 3.3.1 in preparation for release. https://github.com/apache/maven-shared-utils/commit/5ff997cac035ac7d2ab84bbd2c695c6e60798400;>5ff997c [MSHARED-848] deprecate XmlStreamReader (https://github-redirect.dependabot.com/apache/maven-shared-utils/issues/59;>#59) https://github.com/apache/maven-shared-utils/commit/914d9755b157f337dfb76e90f6b0331f834096d6;>914d975 remove call to deprecated method (https://github-redirect.dependabot.com/apache/maven-shared-utils/issues/58;>#58) https://github.com/apache/maven-shared-utils/commit/dda9e1480f4f51120f619dfd302ed0d10807dfa5;>dda9e14 [MSHARED-904] update test dependencies for Maven 3.1 (https://github-redirect.dependabot.com/apache/maven-shared-utils/issues/57;>#57) https://github.com/apache/maven-shared-utils/commit/6798f3033c3c5144e52c5aa8e1be584ea97527d2;>6798f30 [MSHARED-297] - Minor code cleanup Additional commits viewable in https://github.com/apache/maven-shared-utils/compare/maven-shared-utils-3.2.1...maven-shared-utils-3.3.3;>compare view [](https://help.github.com/articles/configuring-automated-security-fixes) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MRESOLVER-7) Download dependency POMs in parallel
[ https://issues.apache.org/jira/browse/MRESOLVER-7?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17171245#comment-17171245 ] Rohit Gupta commented on MRESOLVER-7: - When this will make way in maven ? > Download dependency POMs in parallel > > > Key: MRESOLVER-7 > URL: https://issues.apache.org/jira/browse/MRESOLVER-7 > Project: Maven Resolver > Issue Type: Improvement >Affects Versions: Aether 1.0.2 >Reporter: Harald Wellmann >Priority: Major > Time Spent: 40m > Remaining Estimate: 0h > > h3. Background > When building a project with dependencies not yet available in the local > repository, I noticed that Maven 3.3.9/Aether 1.0.2 first downloads the > dependency POMs _sequentially_ and then proceeds downloading the dependency > JARs with up to 5 threads _in parallel_. > Due to this, when first building a project with a large number of > dependencies, downloading a large number of small POMs may take a lot longer > than downloading the much larger JARs, or even longer than building the > project itself, especially when a repository manager is used which increases > the download latency. > h3. Enhancement > Download POMs of (transitive) dependencies in parallel to significantly speed > up initial builds of large projects. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (MNG-6972) Allow access to org.apache.maven.graph
[
https://issues.apache.org/jira/browse/MNG-6972?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17171113#comment-17171113
]
Hudson commented on MNG-6972:
-
Build unstable in Jenkins: Maven » Maven TLP » maven » Bananeweizen-MNG-6907 #5
See
https://ci-builds.apache.org/job/Maven/job/maven-box/job/maven/job/Bananeweizen-MNG-6907/5/
> Allow access to org.apache.maven.graph
> --
>
> Key: MNG-6972
> URL: https://issues.apache.org/jira/browse/MNG-6972
> Project: Maven
> Issue Type: Improvement
> Components: Class Loading, Plugin API
>Affects Versions: 3.6.3
>Reporter: Michael Kroll
>Assignee: Michael Osipov
>Priority: Major
> Labels: easyfix, pull-request-available
> Fix For: 3.7.0
>
>
> Hi
> maven doesn't export org.apache.maven.graph package in
> maven-core/src/main/resources/META-INF/maven/extension.xml so the
> GraphBuilder is not usable in extensions.
> {code:java}
> // leads to java.lang.NoClassDefFoundError:
> Lorg/apache/maven/graph/GraphBuilder;
> @Requirement( hint = GraphBuilder.HINT )
> private GraphBuilder graphBuilder;
> {code}
> Background: if one build extension adds dependencies and another build
> extension uses {{session.getProjectDependencyGraph()}}, then the dependency
> graph is out of date. This is because the graph is only rebuilt after
> executing _all_ extensions. One solution to this would be to update the
> {{MavenSession}} and setting the new dependency graph in the first extension,
> but for this we need access to the {{GraphBuilder}}.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (MNG-6974) IT for MNG-5175 (Wagon HTTP) fails with JDK 14
[ https://issues.apache.org/jira/browse/MNG-6974?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1717#comment-1717 ] Hudson commented on MNG-6974: - Build unstable in Jenkins: Maven » Maven TLP » maven » Bananeweizen-MNG-6907 #5 See https://ci-builds.apache.org/job/Maven/job/maven-box/job/maven/job/Bananeweizen-MNG-6907/5/ > IT for MNG-5175 (Wagon HTTP) fails with JDK 14 > -- > > Key: MNG-6974 > URL: https://issues.apache.org/jira/browse/MNG-6974 > Project: Maven > Issue Type: Bug > Components: Integration Tests >Reporter: Michael Kroll >Assignee: Michael Osipov >Priority: Major > Labels: pull-request-available, test > > [ERROR] Tests run: 846, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: > 210.078 s <<< FAILURE! - in org.apache.maven.it.IntegrationTestSuite > [ERROR] > testmng5175_ReadTimeOutFromSettings(org.apache.maven.it.MavenITmng5175WagonHttpTest) > Time elapsed: 0.166 s <<< ERROR! > org.apache.maven.it.VerificationException: Text not found in log: Could not > transfer artifact > org.apache.maven.its.mng5175:fake-dependency:pom:1.0-SNAPSHOT > at > org.apache.maven.it.MavenITmng5175WagonHttpTest.testmng5175_ReadTimeOutFromSettings(MavenITmng5175WagonHttpTest.java:128) > https://github.com/apache/maven/pull/368/checks?check_run_id=941247515 -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (MDEP-645) List classes in a given artifact
[
https://issues.apache.org/jira/browse/MDEP-645?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17171073#comment-17171073
]
Hudson commented on MDEP-645:
-
Build succeeded in Jenkins: Maven TLP » maven-dependency-plugin » master #123
See
https://builds.apache.org/job/maven-box/job/maven-dependency-plugin/job/master/123/
> List classes in a given artifact
>
>
> Key: MDEP-645
> URL: https://issues.apache.org/jira/browse/MDEP-645
> Project: Maven Dependency Plugin
> Issue Type: New Feature
>Affects Versions: 3.1.3
>Reporter: John Lin
>Assignee: Elliotte Rusty Harold
>Priority: Minor
> Labels: intern
> Fix For: 3.1.3
>
>
> When I want to list all the classes in a given artifact, I have to use
> {{jar}} command to show files in the corresponding .jar file.
> For example, I want to list all the classes in the artifact
> {code}
> org.apache.commons:commons-lang3:3.6
> {code}
> I have to run
> {code}
> jar tf
> ~/.m2/repository/org/apache/commons/commons-lang3/3.6/commons-lang3-3.6.jar
> {code}
> This method has some disadvantages:
> # The jar file may not be downloaded, so it may not be in
> {{~/.m2/repository}}.
> # It's kind of tedious to type such a long filename.
> # The output is shown in raw filenames, e.g.,
> {{org/apache/commons/lang3/SystemUtils.class}}, but I generally want a
> package + class name {{org.apache.commons.lang3.SystemUtils}}.
> So I would expect a goal called {{show}} with an argument {{artifact}}, so I
> can type
> {code}
> mvn dependency:show -Dartifact=org.apache.commons:commons-lang3:3.6
> {code}
> to show
> {code}
> org.apache.commons.lang3.CharUtils
> org.apache.commons.lang3.RandomStringUtils
> ...
> {code}
> What do you guys think? Thanks.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (MDEP-645) List classes in a given artifact
[
https://issues.apache.org/jira/browse/MDEP-645?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17171064#comment-17171064
]
Hudson commented on MDEP-645:
-
Build succeeded in Jenkins: Maven » Maven TLP » maven-dependency-plugin »
master #11
See
https://ci-builds.apache.org/job/Maven/job/maven-box/job/maven-dependency-plugin/job/master/11/
> List classes in a given artifact
>
>
> Key: MDEP-645
> URL: https://issues.apache.org/jira/browse/MDEP-645
> Project: Maven Dependency Plugin
> Issue Type: New Feature
>Affects Versions: 3.1.3
>Reporter: John Lin
>Assignee: Elliotte Rusty Harold
>Priority: Minor
> Labels: intern
> Fix For: 3.1.3
>
>
> When I want to list all the classes in a given artifact, I have to use
> {{jar}} command to show files in the corresponding .jar file.
> For example, I want to list all the classes in the artifact
> {code}
> org.apache.commons:commons-lang3:3.6
> {code}
> I have to run
> {code}
> jar tf
> ~/.m2/repository/org/apache/commons/commons-lang3/3.6/commons-lang3-3.6.jar
> {code}
> This method has some disadvantages:
> # The jar file may not be downloaded, so it may not be in
> {{~/.m2/repository}}.
> # It's kind of tedious to type such a long filename.
> # The output is shown in raw filenames, e.g.,
> {{org/apache/commons/lang3/SystemUtils.class}}, but I generally want a
> package + class name {{org.apache.commons.lang3.SystemUtils}}.
> So I would expect a goal called {{show}} with an argument {{artifact}}, so I
> can type
> {code}
> mvn dependency:show -Dartifact=org.apache.commons:commons-lang3:3.6
> {code}
> to show
> {code}
> org.apache.commons.lang3.CharUtils
> org.apache.commons.lang3.RandomStringUtils
> ...
> {code}
> What do you guys think? Thanks.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [maven-dependency-plugin] elharo merged pull request #60: [MDEP-645] update docs to reflect new target
elharo merged pull request #60: URL: https://github.com/apache/maven-dependency-plugin/pull/60 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-dependency-plugin] elharo commented on pull request #92: [MDEP-644] Reintroduce the verbose option for dependency:tree
elharo commented on pull request #92: URL: https://github.com/apache/maven-dependency-plugin/pull/92#issuecomment-668760436 CI running here: https://builds.apache.org/job/maven-box/job/maven-dependency-plugin/job/te/ This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-dependency-plugin] elharo commented on pull request #60: [MDEP-645] update docs to reflect new target
elharo commented on pull request #60: URL: https://github.com/apache/maven-dependency-plugin/pull/60#issuecomment-668758909 Ping @michael-o Since you requested changes on this, your approval is required This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-dependency-plugin] elharo commented on a change in pull request #92: [MDEP-644] Reintroduce the verbose option for dependency:tree
elharo commented on a change in pull request #92:
URL:
https://github.com/apache/maven-dependency-plugin/pull/92#discussion_r465241721
##
File path: pom.xml
##
@@ -320,6 +311,27 @@ under the License.
+
Review comment:
I wouldn't include this comment since these are not the artifacts where
those classes are found.
##
File path: src/it/projects/tree-verbose-small/verify.bsh
##
@@ -0,0 +1,39 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+import java.io.*;
+
+import org.codehaus.plexus.util.*;
+
+System.out.println( "Basedir is " + basedir );
+
+String actual = FileUtils.fileRead( new File( basedir, "target/tree.txt" ) );
+String expected = FileUtils.fileRead( new File( basedir, "expected.txt" ) );
+
+actual = actual.replaceAll( "[\n\r]+", "\n" );
+expected = expected.replaceAll( "[\n\r]+", "\n" );
+
+System.out.println( "Checking dependency tree..." );
+
+if ( !actual.equals( expected ) )
+{
+throw new Exception( "Unexpected dependency tree" );
Review comment:
It helps if a test failure can indicate why it failed; in this case what
was expected and what did it actually get. Or if those two are large, then
what's the difference?
Might not be worth doing here unless there's a good utility method for this
we can call to calculate the diff.
##
File path: src/it/projects/tree-verbose-small/verify.bsh
##
@@ -0,0 +1,39 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+import java.io.*;
+
+import org.codehaus.plexus.util.*;
+
+System.out.println( "Basedir is " + basedir );
Review comment:
This might be something Maven commonly does in integration tests, but
the general principle is that a passing test generates no output.
##
File path:
src/main/java/org/apache/maven/plugins/dependency/tree/verbose/RepositoryUtility.java
##
@@ -0,0 +1,216 @@
+package org.apache.maven.plugins.dependency.tree.verbose;
+
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+
+import org.apache.maven.repository.internal.MavenRepositorySystemUtils;
+import org.eclipse.aether.DefaultRepositorySystemSession;
+import org.eclipse.aether.RepositorySystem;
+import org.eclipse.aether.RepositorySystemSession;
+import org.eclipse.aether.artifact.Artifact;
+import org.eclipse.aether.artifact.DefaultArtifact;
+import org.eclipse.aether.collection.DependencySelector;
+import org.eclipse.aether.repository.LocalRepository;
+import org.eclipse.aether.repository.RemoteRepository;
+import org.eclipse.aether.resolution.VersionRangeRequest;
+import org.eclipse.aether.resolution.VersionRangeResolutionException;
[jira] [Commented] (MNG-6974) IT for MNG-5175 (Wagon HTTP) fails with JDK 14
[ https://issues.apache.org/jira/browse/MNG-6974?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17171008#comment-17171008 ] Hudson commented on MNG-6974: - Build succeeded in Jenkins: Maven » Maven TLP » maven » master #7 See https://ci-builds.apache.org/job/Maven/job/maven-box/job/maven/job/master/7/ > IT for MNG-5175 (Wagon HTTP) fails with JDK 14 > -- > > Key: MNG-6974 > URL: https://issues.apache.org/jira/browse/MNG-6974 > Project: Maven > Issue Type: Bug > Components: Integration Tests >Reporter: Michael Kroll >Assignee: Michael Osipov >Priority: Major > Labels: pull-request-available, test > > [ERROR] Tests run: 846, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: > 210.078 s <<< FAILURE! - in org.apache.maven.it.IntegrationTestSuite > [ERROR] > testmng5175_ReadTimeOutFromSettings(org.apache.maven.it.MavenITmng5175WagonHttpTest) > Time elapsed: 0.166 s <<< ERROR! > org.apache.maven.it.VerificationException: Text not found in log: Could not > transfer artifact > org.apache.maven.its.mng5175:fake-dependency:pom:1.0-SNAPSHOT > at > org.apache.maven.it.MavenITmng5175WagonHttpTest.testmng5175_ReadTimeOutFromSettings(MavenITmng5175WagonHttpTest.java:128) > https://github.com/apache/maven/pull/368/checks?check_run_id=941247515 -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (MNG-6972) Allow access to org.apache.maven.graph
[
https://issues.apache.org/jira/browse/MNG-6972?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17171007#comment-17171007
]
Hudson commented on MNG-6972:
-
Build succeeded in Jenkins: Maven » Maven TLP » maven » master #7
See https://ci-builds.apache.org/job/Maven/job/maven-box/job/maven/job/master/7/
> Allow access to org.apache.maven.graph
> --
>
> Key: MNG-6972
> URL: https://issues.apache.org/jira/browse/MNG-6972
> Project: Maven
> Issue Type: Improvement
> Components: Class Loading, Plugin API
>Affects Versions: 3.6.3
>Reporter: Michael Kroll
>Assignee: Michael Osipov
>Priority: Major
> Labels: easyfix, pull-request-available
> Fix For: 3.7.0
>
>
> Hi
> maven doesn't export org.apache.maven.graph package in
> maven-core/src/main/resources/META-INF/maven/extension.xml so the
> GraphBuilder is not usable in extensions.
> {code:java}
> // leads to java.lang.NoClassDefFoundError:
> Lorg/apache/maven/graph/GraphBuilder;
> @Requirement( hint = GraphBuilder.HINT )
> private GraphBuilder graphBuilder;
> {code}
> Background: if one build extension adds dependencies and another build
> extension uses {{session.getProjectDependencyGraph()}}, then the dependency
> graph is out of date. This is because the graph is only rebuilt after
> executing _all_ extensions. One solution to this would be to update the
> {{MavenSession}} and setting the new dependency graph in the first extension,
> but for this we need access to the {{GraphBuilder}}.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Closed] (MNGSITE-423) When building an application with the help of java language, I have a problem connecting maven plugins.
[ https://issues.apache.org/jira/browse/MNGSITE-423?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov closed MNGSITE-423. -- Resolution: Invalid Use the mailing list. > When building an application with the help of java language, I have a problem > connecting maven plugins. > --- > > Key: MNGSITE-423 > URL: https://issues.apache.org/jira/browse/MNGSITE-423 > Project: Maven Project Web Site > Issue Type: Bug >Reporter: CecilFitzgerald >Priority: Minor > > Hello to all developers, who make desktop applications with the help of Java > language. > I am building my Java desktop application with the help of Spring Boot. My > Java desktop application is for companies, which propose essay writing > services, [cheap custom research > papers|https://buypapercheap.net/custom-research-papers-for-sale.html] > writing services and other paper writing services. My Java desktop > application is for organizing payment and ordering system on these sites. I > want to pull up some plugins in order to simplicate my work on this Java > desktop application, but I have problems with some plugins. I can't pull up > some of the Maven's plugins. I know, that problem is because of Maven, not > because of plugins. I know, that there aren't problems with plugins and with > connecting these plugins. Have you had problems starting up / running Maven? > What have you done? What should I do? > Thank you very much for helping everyone who will write comments under this > post. > I hope that we can solve this problem together. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (MNG-6974) IT for MNG-5175 (Wagon HTTP) fails with JDK 14
[ https://issues.apache.org/jira/browse/MNG-6974?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17170994#comment-17170994 ] Hudson commented on MNG-6974: - Build succeeded in Jenkins: Maven TLP » maven » master #451 See https://builds.apache.org/job/maven-box/job/maven/job/master/451/ > IT for MNG-5175 (Wagon HTTP) fails with JDK 14 > -- > > Key: MNG-6974 > URL: https://issues.apache.org/jira/browse/MNG-6974 > Project: Maven > Issue Type: Bug > Components: Integration Tests >Reporter: Michael Kroll >Assignee: Michael Osipov >Priority: Major > Labels: pull-request-available, test > > [ERROR] Tests run: 846, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: > 210.078 s <<< FAILURE! - in org.apache.maven.it.IntegrationTestSuite > [ERROR] > testmng5175_ReadTimeOutFromSettings(org.apache.maven.it.MavenITmng5175WagonHttpTest) > Time elapsed: 0.166 s <<< ERROR! > org.apache.maven.it.VerificationException: Text not found in log: Could not > transfer artifact > org.apache.maven.its.mng5175:fake-dependency:pom:1.0-SNAPSHOT > at > org.apache.maven.it.MavenITmng5175WagonHttpTest.testmng5175_ReadTimeOutFromSettings(MavenITmng5175WagonHttpTest.java:128) > https://github.com/apache/maven/pull/368/checks?check_run_id=941247515 -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (MNG-6972) Allow access to org.apache.maven.graph
[
https://issues.apache.org/jira/browse/MNG-6972?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17170993#comment-17170993
]
Hudson commented on MNG-6972:
-
Build succeeded in Jenkins: Maven TLP » maven » master #451
See https://builds.apache.org/job/maven-box/job/maven/job/master/451/
> Allow access to org.apache.maven.graph
> --
>
> Key: MNG-6972
> URL: https://issues.apache.org/jira/browse/MNG-6972
> Project: Maven
> Issue Type: Improvement
> Components: Class Loading, Plugin API
>Affects Versions: 3.6.3
>Reporter: Michael Kroll
>Assignee: Michael Osipov
>Priority: Major
> Labels: easyfix, pull-request-available
> Fix For: 3.7.0
>
>
> Hi
> maven doesn't export org.apache.maven.graph package in
> maven-core/src/main/resources/META-INF/maven/extension.xml so the
> GraphBuilder is not usable in extensions.
> {code:java}
> // leads to java.lang.NoClassDefFoundError:
> Lorg/apache/maven/graph/GraphBuilder;
> @Requirement( hint = GraphBuilder.HINT )
> private GraphBuilder graphBuilder;
> {code}
> Background: if one build extension adds dependencies and another build
> extension uses {{session.getProjectDependencyGraph()}}, then the dependency
> graph is out of date. This is because the graph is only rebuilt after
> executing _all_ extensions. One solution to this would be to update the
> {{MavenSession}} and setting the new dependency graph in the first extension,
> but for this we need access to the {{GraphBuilder}}.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (MRESOLVER-123) Provide a global locking sync context by default
[
https://issues.apache.org/jira/browse/MRESOLVER-123?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17170991#comment-17170991
]
Michael Osipov commented on MRESOLVER-123:
--
I agree that people simply did not understand the problem. The PR has been
merged manually and closed. All changes are in master and tagged as 1.5.0.
Unfortunately, I started the vote, but no one voted for 1.5.0 and did started
additional discussions on the PR:
[http://mail-archives.apache.org/mod_mbox/maven-dev/202007.mbox/%3C0f5c4620-b3da-0d73-9a87-e054672fa6ca%40apache.org%3E]
For now, I cannot tell whether Maven 3.7.0 will include 1.5.0+. If you like,
raise a discussion on dev@.
> Provide a global locking sync context by default
>
>
> Key: MRESOLVER-123
> URL: https://issues.apache.org/jira/browse/MRESOLVER-123
> Project: Maven Resolver
> Issue Type: New Feature
> Components: resolver
>Affects Versions: 1.4.2
>Reporter: Michael Osipov
>Assignee: Michael Osipov
>Priority: Critical
> Fix For: 1.5.0
>
> Attachments: checksum-error-debug.log, mvn-debug-1.4.3-123.txt.gz
>
>
> This is an umbrella ticket for a long standing issue with Maven Resolver: Our
> concurrency support is mediocre in a way that if two or more threads try to
> download the same file and fail to queue those write actions nicely. The
> problem is that The {{SyncContext}} and the its factory provided by Maven
> Resolver does not employ any locking at all. As layed out in detail in
> MRESOLVER-114 we need striped read write locks on artifacts and its metadata.
> This issue shall track progress on it. Even Takari Concurrent Repository
> extension does not help because it is only intended to synchronize concurrent
> access by multple JVMs and not threads.
> This improvement will provide solely a global locking sync context which will
> work in *single* JVM. It is a non-goal to make it work with mulitple JVMs. A
> downside of this solution is that is coarse, possible degregation of
> performance for the sake of stability.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Closed] (MNG-6972) Allow access to org.apache.maven.graph
[
https://issues.apache.org/jira/browse/MNG-6972?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Osipov closed MNG-6972.
---
Fix Version/s: (was: 3.7.0-candidate)
3.7.0
Resolution: Fixed
Fixed with
[60873012842b80a60fb257e291df922371ca|https://gitbox.apache.org/repos/asf?p=maven.git;a=commit;h=60873012842b80a60fb257e291df922371ca]
and
[5cfcdbcda0ff9081dbb51bb162c2fd70fc177a9a|https://gitbox.apache.org/repos/asf?p=maven-integration-testing.git;a=commit;h=5cfcdbcda0ff9081dbb51bb162c2fd70fc177a9a].
> Allow access to org.apache.maven.graph
> --
>
> Key: MNG-6972
> URL: https://issues.apache.org/jira/browse/MNG-6972
> Project: Maven
> Issue Type: Improvement
> Components: Class Loading, Plugin API
>Affects Versions: 3.6.3
>Reporter: Michael Kroll
>Assignee: Michael Osipov
>Priority: Major
> Labels: easyfix, pull-request-available
> Fix For: 3.7.0
>
>
> Hi
> maven doesn't export org.apache.maven.graph package in
> maven-core/src/main/resources/META-INF/maven/extension.xml so the
> GraphBuilder is not usable in extensions.
> {code:java}
> // leads to java.lang.NoClassDefFoundError:
> Lorg/apache/maven/graph/GraphBuilder;
> @Requirement( hint = GraphBuilder.HINT )
> private GraphBuilder graphBuilder;
> {code}
> Background: if one build extension adds dependencies and another build
> extension uses {{session.getProjectDependencyGraph()}}, then the dependency
> graph is out of date. This is because the graph is only rebuilt after
> executing _all_ extensions. One solution to this would be to update the
> {{MavenSession}} and setting the new dependency graph in the first extension,
> but for this we need access to the {{GraphBuilder}}.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [maven-integration-testing] asfgit closed pull request #69: [MNG-6972] add test for successful graphbuilder injection
asfgit closed pull request #69: URL: https://github.com/apache/maven-integration-testing/pull/69 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven] asfgit closed pull request #368: [MNG-6972] allow access to org.apache.maven.graph
asfgit closed pull request #368: URL: https://github.com/apache/maven/pull/368 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-dependency-plugin] ian-lavallee commented on a change in pull request #92: [MDEP-644] Reintroduce the verbose option for dependency:tree
ian-lavallee commented on a change in pull request #92:
URL:
https://github.com/apache/maven-dependency-plugin/pull/92#discussion_r465194646
##
File path:
src/main/java/org/apache/maven/plugins/dependency/tree/verbose/VerboseGraphSerializer.java
##
@@ -0,0 +1,323 @@
+package org.apache.maven.plugins.dependency.tree.verbose;
+
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+import org.eclipse.aether.artifact.Artifact;
+import org.eclipse.aether.graph.DependencyNode;
+
+import java.util.ArrayList;
+import java.util.Arrays;
+import java.util.HashMap;
+import java.util.HashSet;
+import java.util.LinkedList;
+import java.util.List;
+import java.util.Map;
+import java.util.Queue;
+import java.util.Set;
+
+/**
+ * Parses dependency graph and outputs in text format for end user to review.
+ */
+public final class VerboseGraphSerializer
+{
+private static final String LINE_START_LAST_CHILD = "\\- ";
+private static final String LINE_START_CHILD = "+- ";
+
+public String serialize( DependencyNode root )
+{
+Set coordinateStrings = new HashSet<>();
+Map coordinateVersionMap = new HashMap<>();
+StringBuilder builder = new StringBuilder();
+
+// Use BFS to mirror how Maven resolves dependencies and use DFS to
print the tree easily
+Map nodeErrors = getNodeConflictMessagesBfs(
root, coordinateStrings,
+coordinateVersionMap );
+
+// deal with root first
+Artifact rootArtifact = root.getArtifact();
+builder.append( rootArtifact.getGroupId() ).append( ":" ).append(
rootArtifact.getArtifactId() ).append( ":" )
+.append( rootArtifact.getExtension() ).append( ":" ).append(
rootArtifact.getVersion() ).append(
+System.lineSeparator() );
+
+for ( int i = 0; i < root.getChildren().size(); i++ )
+{
+if ( i == root.getChildren().size() - 1 )
+{
+dfsPrint( root.getChildren().get( i ), LINE_START_LAST_CHILD,
false, builder, nodeErrors );
+}
+else
+{
+dfsPrint( root.getChildren().get( i ), LINE_START_CHILD,
false, builder, nodeErrors );
+}
+}
+return builder.toString();
+}
+
+private static String getDependencyCoordinate( DependencyNode node )
+{
+Artifact artifact = node.getArtifact();
+
+if ( node.getDependency() == null )
+{
+// should only get here if node is root
+return artifact.getGroupId() + ":" + artifact.getArtifactId() +
":" + artifact.getExtension() + ":"
++ artifact.getVersion();
+}
+
+String scope;
+if ( artifact.getProperties().containsKey( "managedScope" ) )
+{
+scope = artifact.getProperties().get( "managedScope" );
+}
+else
+{
+scope = node.getDependency().getScope();
+}
+
+String coords = artifact.getGroupId() + ":" + artifact.getArtifactId()
+ ":" + artifact.getExtension() + ":"
++ artifact.getVersion();
+
+if ( scope != null && !scope.isEmpty() )
+{
+coords = coords.concat( ":" + scope );
+}
+return coords;
+}
+
+private static String getVersionlessScopelessCoordinate( DependencyNode
node )
+{
+Artifact artifact = node.getArtifact();
+// scope not included because we check for scope conflicts separately
+return artifact.getGroupId() + ":" + artifact.getArtifactId() + ":" +
artifact.getExtension();
+}
+
+private static boolean isDuplicateDependencyCoordinate( DependencyNode
node, Set coordinateStrings )
+{
+return coordinateStrings.contains( getDependencyCoordinate( node ) );
+}
+
+private static String versionConflict( DependencyNode node, Map coordinateVersionMap )
+{
+if ( coordinateVersionMap.containsKey(
getVersionlessScopelessCoordinate( node ) ) )
+{
+return coordinateVersionMap.get(
getVersionlessScopelessCoordinate( node ) );
+}
+return null;
+}
+
+private static String scopeConflict(
[jira] [Updated] (MNG-6974) IT for MNG-5175 (Wagon HTTP) fails with JDK 14
[ https://issues.apache.org/jira/browse/MNG-6974?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov updated MNG-6974: Affects Version/s: (was: 3.6.3) > IT for MNG-5175 (Wagon HTTP) fails with JDK 14 > -- > > Key: MNG-6974 > URL: https://issues.apache.org/jira/browse/MNG-6974 > Project: Maven > Issue Type: Bug > Components: Integration Tests >Reporter: Michael Kroll >Assignee: Michael Osipov >Priority: Major > Labels: pull-request-available, test > > [ERROR] Tests run: 846, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: > 210.078 s <<< FAILURE! - in org.apache.maven.it.IntegrationTestSuite > [ERROR] > testmng5175_ReadTimeOutFromSettings(org.apache.maven.it.MavenITmng5175WagonHttpTest) > Time elapsed: 0.166 s <<< ERROR! > org.apache.maven.it.VerificationException: Text not found in log: Could not > transfer artifact > org.apache.maven.its.mng5175:fake-dependency:pom:1.0-SNAPSHOT > at > org.apache.maven.it.MavenITmng5175WagonHttpTest.testmng5175_ReadTimeOutFromSettings(MavenITmng5175WagonHttpTest.java:128) > https://github.com/apache/maven/pull/368/checks?check_run_id=941247515 -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (MSHARED-937) Demote log statement to debug
[
https://issues.apache.org/jira/browse/MSHARED-937?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17170922#comment-17170922
]
Elliotte Rusty Harold commented on MSHARED-937:
---
YAGNI. When's the last time you read and acted on one of these messages? For me
the answer is never.
Logging everything that someone might perhaps need sometime is an antipattern
that obscures genuinely useful and important information. In extreme cases,
I've seen CI builds that simply died because the logs exceeded some size limit.
> Demote log statement to debug
> -
>
> Key: MSHARED-937
> URL: https://issues.apache.org/jira/browse/MSHARED-937
> Project: Maven Shared Components
> Issue Type: Improvement
> Components: maven-filtering
>Reporter: Elliotte Rusty Harold
>Priority: Minor
>
> In line 144 of DefaultMavenResourcesFiltering we have:
> {{else
> {
> getLogger().info( "Using '" +
> mavenResourcesExecution.getEncoding()
> + "' encoding to copy filtered resources." );
> }}}
> This produces a lot of log junk and is inconsistent with most other locations
> in the file such as line 237 where similar messages are logged at DEBUG
> level. This message should be debug too.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [maven-surefire] winglam commented on a change in pull request #309: [SUREFIRE-756] Allow ability to capture executed random runOrder for re-play purposes
winglam commented on a change in pull request #309:
URL: https://github.com/apache/maven-surefire/pull/309#discussion_r465161332
##
File path:
maven-failsafe-plugin/src/main/java/org/apache/maven/plugin/failsafe/IntegrationTestMojo.java
##
@@ -310,6 +310,22 @@
@Parameter( property = "failsafe.runOrder", defaultValue = "filesystem" )
private String runOrder;
+/**
+ * Sets the random seed that will be used to order the tests if {@code
failsafe.runOrder} is set to {@code random}.
+ *
+ *
+ * If no seeds are set and {@code failsafe.runOrder} is set to {@code
random}, then the seed used will be
+ * outputted (search for "To reproduce ordering use flag -Dfailsafe.seed").
+ *
+ *
+ * To deterministically reproduce any random test order that was run
before, simply set the seed to
+ * be the same value.
+ *
+ * @since 3.0.0-M6
+ */
+@Parameter( property = "failsafe.seed" )
+private Long randomSeed;
Review comment:
> capture the test order and replay it explicitly (a runOrder=fromFile
and runOrderFile=/path would be more relevant there)
I actually have some changes (in a separate local branch) that would
accomplish this as well and plan to submit it after this PR is merged. I could
still use some help/advice on how to capture the test order (with or without
running tests). The goal of my changes would be to empower runOrder to be more
customizable and deterministic with seeds, passing in a file, controlling not
just test class order but also test method order, etc.
I have the changes for merging `failsafe.seed` and `surefire.seed` with the
`runOrder` parameter ready, but will leave those unpushed for now as I am fine
with merging them or keep them separate (as they are now or moving it, etc.).
##
File path:
maven-failsafe-plugin/src/main/java/org/apache/maven/plugin/failsafe/IntegrationTestMojo.java
##
@@ -310,6 +310,22 @@
@Parameter( property = "failsafe.runOrder", defaultValue = "filesystem" )
private String runOrder;
+/**
+ * Sets the random seed that will be used to order the tests if {@code
failsafe.runOrder} is set to {@code random}.
+ *
+ *
+ * If no seeds are set and {@code failsafe.runOrder} is set to {@code
random}, then the seed used will be
+ * outputted (search for "To reproduce ordering use flag -Dfailsafe.seed").
+ *
+ *
+ * To deterministically reproduce any random test order that was run
before, simply set the seed to
+ * be the same value.
+ *
+ * @since 3.0.0-M6
+ */
+@Parameter( property = "failsafe.seed" )
+private Long randomSeed;
Review comment:
> capture the test order and replay it explicitly (a runOrder=fromFile
and runOrderFile=/path would be more relevant there)
I actually have some changes (in a separate local branch) that would
accomplish this as well and plan to submit it after this PR is merged. I could
still use some help/advice on how to capture the test order (with or without
running tests). The goal of my changes would be to empower runOrder to be more
customizable and deterministic with seeds, passing in a file, controlling not
just test class order but also test method order, etc.
I have the changes for merging `failsafe.seed` and `surefire.seed` with the
`runOrder` parameter ready, but will leave those unpushed for now as I am fine
with merging them or keep them separate (as they are now or moving it, etc.).
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [maven-dependency-plugin] bimargulies-google commented on a change in pull request #92: [MDEP-644] Reintroduce the verbose option for dependency:tree
bimargulies-google commented on a change in pull request #92: URL: https://github.com/apache/maven-dependency-plugin/pull/92#discussion_r465139379 ## File path: src/it/projects/analyze-testDependencyWithNonTestScope/src/main/java/hello/Hello.java ## @@ -0,0 +1,24 @@ +package hello; + +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +public class Hello Review comment: Comment why you have a an empty class? ## File path: src/it/projects/tree-verbose-small/pom.xml ## @@ -0,0 +1,64 @@ + + + +http://maven.apache.org/POM/4.0.0; + xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance; + xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd;> + 4.0.0 + + org.apache.maven.its.dependency + tree-verbose2 + 1.0-SNAPSHOT + + VerboseTest2 + +Test2 verbose dependency:tree with actual Maven version. Review comment: Can you clarify this comment; what do we mean by 'actual maven version'? ## File path: src/main/java/org/apache/maven/plugins/dependency/tree/verbose/RepositoryUtility.java ## @@ -0,0 +1,221 @@ +package org.apache.maven.plugins.dependency.tree.verbose; + +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + + +import org.apache.maven.repository.internal.MavenRepositorySystemUtils; +import org.eclipse.aether.DefaultRepositorySystemSession; +import org.eclipse.aether.RepositorySystem; +import org.eclipse.aether.RepositorySystemSession; +import org.eclipse.aether.artifact.Artifact; +import org.eclipse.aether.artifact.DefaultArtifact; +import org.eclipse.aether.collection.DependencySelector; +import org.eclipse.aether.repository.LocalRepository; +import org.eclipse.aether.repository.RemoteRepository; +import org.eclipse.aether.resolution.VersionRangeRequest; +import org.eclipse.aether.resolution.VersionRangeResolutionException; +import org.eclipse.aether.resolution.VersionRangeResult; +import org.eclipse.aether.util.graph.selector.AndDependencySelector; +import org.eclipse.aether.util.graph.selector.ExclusionDependencySelector; +import org.eclipse.aether.util.graph.selector.ScopeDependencySelector; +import org.eclipse.aether.util.graph.transformer.ChainedDependencyGraphTransformer; +import org.eclipse.aether.util.graph.transformer.JavaDependencyContextRefiner; +import org.eclipse.aether.version.Version; + +import java.io.File; +import java.io.IOException; +import java.net.URI; +import java.net.URISyntaxException; +import java.nio.file.Files; +import java.nio.file.Path; +import java.nio.file.Paths; +import java.util.Arrays; +import java.util.HashSet; +import java.util.Set; + + +/** + * Aether initialization. This is based on Apache Maven Resolver 1.4.2 or later. There are many other versions of Aether Review comment: Does 'base on' means 'works with'? ## File path: src/main/java/org/apache/maven/plugins/dependency/tree/verbose/VerboseDependencyGraphBuilder.java ## @@ -0,0 +1,329 @@ +package org.apache.maven.plugins.dependency.tree.verbose; + +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the
[jira] [Commented] (MRESOLVER-123) Provide a global locking sync context by default
[
https://issues.apache.org/jira/browse/MRESOLVER-123?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17170909#comment-17170909
]
Rainer Reich commented on MRESOLVER-123:
Hi Michael. Sorry, been on vacation. I would also say most of the commenters
didn't understand the problem at all - but it's closed, so I don't think I'm
gonna start a new "discussion" there now. Thanks for fighting!
I'm a little bit confused about the state of this, though: Your change is in
1.5.0, right? This ticket is closed, but the PR isn't "merged" but only
"closed". How is that?
And what vote has been cancelled? One for a new Maven Release (resolver
obviously has been released)? Will the next Maven Release use 1.5.0 of
maven-resolver or will the stick to an older version?
> Provide a global locking sync context by default
>
>
> Key: MRESOLVER-123
> URL: https://issues.apache.org/jira/browse/MRESOLVER-123
> Project: Maven Resolver
> Issue Type: New Feature
> Components: resolver
>Affects Versions: 1.4.2
>Reporter: Michael Osipov
>Assignee: Michael Osipov
>Priority: Critical
> Fix For: 1.5.0
>
> Attachments: checksum-error-debug.log, mvn-debug-1.4.3-123.txt.gz
>
>
> This is an umbrella ticket for a long standing issue with Maven Resolver: Our
> concurrency support is mediocre in a way that if two or more threads try to
> download the same file and fail to queue those write actions nicely. The
> problem is that The {{SyncContext}} and the its factory provided by Maven
> Resolver does not employ any locking at all. As layed out in detail in
> MRESOLVER-114 we need striped read write locks on artifacts and its metadata.
> This issue shall track progress on it. Even Takari Concurrent Repository
> extension does not help because it is only intended to synchronize concurrent
> access by multple JVMs and not threads.
> This improvement will provide solely a global locking sync context which will
> work in *single* JVM. It is a non-goal to make it work with mulitple JVMs. A
> downside of this solution is that is coarse, possible degregation of
> performance for the sake of stability.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [maven] rfscholte commented on pull request #368: [MNG-6972] allow access to org.apache.maven.graph
rfscholte commented on pull request #368: URL: https://github.com/apache/maven/pull/368#issuecomment-668653535 LGTM This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MSHARED-937) Demote log statement to debug
[
https://issues.apache.org/jira/browse/MSHARED-937?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17170839#comment-17170839
]
Dennis Lundberg commented on MSHARED-937:
-
I have a different opinion on this.
The first line (143-144) is done once for each build/resources/resource, so for
a normal project it would be once or twice for main and maybe once for test. I
don't think that is a lot. This is also useful information to the user, so that
they know which encoding is being used.
The other line (which is now at 260) is done once for each filtered resource
file. So it makes sense to log that at the DEBUG level, instead of INFO level,
because there could be a lot of resource files in a project.
> Demote log statement to debug
> -
>
> Key: MSHARED-937
> URL: https://issues.apache.org/jira/browse/MSHARED-937
> Project: Maven Shared Components
> Issue Type: Improvement
> Components: maven-filtering
>Reporter: Elliotte Rusty Harold
>Priority: Minor
>
> In line 144 of DefaultMavenResourcesFiltering we have:
> {{else
> {
> getLogger().info( "Using '" +
> mavenResourcesExecution.getEncoding()
> + "' encoding to copy filtered resources." );
> }}}
> This produces a lot of log junk and is inconsistent with most other locations
> in the file such as line 237 where similar messages are logged at DEBUG
> level. This message should be debug too.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (MSHARED-946) Update to maven-shared-utils 3.3.3
[ https://issues.apache.org/jira/browse/MSHARED-946?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17170831#comment-17170831 ] Hudson commented on MSHARED-946: Build succeeded in Jenkins: Maven » Maven TLP » maven-filtering » master #5 See https://ci-builds.apache.org/job/Maven/job/maven-box/job/maven-filtering/job/master/5/ > Update to maven-shared-utils 3.3.3 > -- > > Key: MSHARED-946 > URL: https://issues.apache.org/jira/browse/MSHARED-946 > Project: Maven Shared Components > Issue Type: Improvement > Components: maven-filtering >Reporter: Dennis Lundberg >Assignee: Dennis Lundberg >Priority: Major > Fix For: maven-filtering-3.2.0 > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (MSHARED-946) Update to maven-shared-utils 3.3.3
[ https://issues.apache.org/jira/browse/MSHARED-946?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17170830#comment-17170830 ] Hudson commented on MSHARED-946: Build succeeded in Jenkins: Maven TLP » maven-filtering » master #57 See https://builds.apache.org/job/maven-box/job/maven-filtering/job/master/57/ > Update to maven-shared-utils 3.3.3 > -- > > Key: MSHARED-946 > URL: https://issues.apache.org/jira/browse/MSHARED-946 > Project: Maven Shared Components > Issue Type: Improvement > Components: maven-filtering >Reporter: Dennis Lundberg >Assignee: Dennis Lundberg >Priority: Major > Fix For: maven-filtering-3.2.0 > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Closed] (MSHARED-946) Update to maven-shared-utils 3.3.3
[ https://issues.apache.org/jira/browse/MSHARED-946?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dennis Lundberg closed MSHARED-946. --- Resolution: Fixed > Update to maven-shared-utils 3.3.3 > -- > > Key: MSHARED-946 > URL: https://issues.apache.org/jira/browse/MSHARED-946 > Project: Maven Shared Components > Issue Type: Improvement > Components: maven-filtering >Reporter: Dennis Lundberg >Assignee: Dennis Lundberg >Priority: Major > Fix For: maven-filtering-3.2.0 > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (MSHARED-946) Update to maven-shared-utils 3.3.3
Dennis Lundberg created MSHARED-946: --- Summary: Update to maven-shared-utils 3.3.3 Key: MSHARED-946 URL: https://issues.apache.org/jira/browse/MSHARED-946 Project: Maven Shared Components Issue Type: Improvement Components: maven-filtering Reporter: Dennis Lundberg Assignee: Dennis Lundberg Fix For: maven-filtering-3.2.0 -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (MNGSITE-423) When building an application with the help of java language, I have a problem connecting maven plugins.
CecilFitzgerald created MNGSITE-423: --- Summary: When building an application with the help of java language, I have a problem connecting maven plugins. Key: MNGSITE-423 URL: https://issues.apache.org/jira/browse/MNGSITE-423 Project: Maven Project Web Site Issue Type: Bug Reporter: CecilFitzgerald Hello to all developers, who make desktop applications with the help of Java language. I am building my Java desktop application with the help of Spring Boot. My Java desktop application is for companies, which propose essay writing services, [cheap custom research papers|https://buypapercheap.net/custom-research-papers-for-sale.html] writing services and other paper writing services. My Java desktop application is for organizing payment and ordering system on these sites. I want to pull up some plugins in order to simplicate my work on this Java desktop application, but I have problems with some plugins. I can't pull up some of the Maven's plugins. I know, that problem is because of Maven, not because of plugins. I know, that there aren't problems with plugins and with connecting these plugins. Have you had problems starting up / running Maven? What have you done? What should I do? Thank you very much for helping everyone who will write comments under this post. I hope that we can solve this problem together. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Comment Edited] (MNG-6974) IT for MNG-5175 (Wagon HTTP) fails with JDK 14
[ https://issues.apache.org/jira/browse/MNG-6974?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17170778#comment-17170778 ] Michael Osipov edited comment on MNG-6974 at 8/4/20, 12:51 PM: --- Fixed with [fb120a1c28cd3feb53d9175594b12aecd74d70fb|https://gitbox.apache.org/repos/asf?p=maven-integration-testing.git;a=commit;h=fb120a1c28cd3feb53d9175594b12aecd74d70fb]. (hopefully) was (Author: michael-o): Fixed with [fb120a1c28cd3feb53d9175594b12aecd74d70fb|[https://gitbox.apache.org/repos/asf?p=maven-integration-testing.git;a=commit;h=fb120a1c28cd3feb53d9175594b12aecd74d70fb].] (hopefully) > IT for MNG-5175 (Wagon HTTP) fails with JDK 14 > -- > > Key: MNG-6974 > URL: https://issues.apache.org/jira/browse/MNG-6974 > Project: Maven > Issue Type: Bug > Components: Integration Tests >Affects Versions: 3.6.3 >Reporter: Michael Kroll >Assignee: Michael Osipov >Priority: Major > Labels: pull-request-available, test > > [ERROR] Tests run: 846, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: > 210.078 s <<< FAILURE! - in org.apache.maven.it.IntegrationTestSuite > [ERROR] > testmng5175_ReadTimeOutFromSettings(org.apache.maven.it.MavenITmng5175WagonHttpTest) > Time elapsed: 0.166 s <<< ERROR! > org.apache.maven.it.VerificationException: Text not found in log: Could not > transfer artifact > org.apache.maven.its.mng5175:fake-dependency:pom:1.0-SNAPSHOT > at > org.apache.maven.it.MavenITmng5175WagonHttpTest.testmng5175_ReadTimeOutFromSettings(MavenITmng5175WagonHttpTest.java:128) > https://github.com/apache/maven/pull/368/checks?check_run_id=941247515 -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Closed] (MNG-6974) IT for MNG-5175 (Wagon HTTP) fails with JDK 14
[ https://issues.apache.org/jira/browse/MNG-6974?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov closed MNG-6974. --- Resolution: Fixed Fixed with [fb120a1c28cd3feb53d9175594b12aecd74d70fb|[https://gitbox.apache.org/repos/asf?p=maven-integration-testing.git;a=commit;h=fb120a1c28cd3feb53d9175594b12aecd74d70fb].] (hopefully) > IT for MNG-5175 (Wagon HTTP) fails with JDK 14 > -- > > Key: MNG-6974 > URL: https://issues.apache.org/jira/browse/MNG-6974 > Project: Maven > Issue Type: Bug > Components: Integration Tests >Affects Versions: 3.6.3 >Reporter: Michael Kroll >Assignee: Michael Osipov >Priority: Major > Labels: pull-request-available, test > > [ERROR] Tests run: 846, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: > 210.078 s <<< FAILURE! - in org.apache.maven.it.IntegrationTestSuite > [ERROR] > testmng5175_ReadTimeOutFromSettings(org.apache.maven.it.MavenITmng5175WagonHttpTest) > Time elapsed: 0.166 s <<< ERROR! > org.apache.maven.it.VerificationException: Text not found in log: Could not > transfer artifact > org.apache.maven.its.mng5175:fake-dependency:pom:1.0-SNAPSHOT > at > org.apache.maven.it.MavenITmng5175WagonHttpTest.testmng5175_ReadTimeOutFromSettings(MavenITmng5175WagonHttpTest.java:128) > https://github.com/apache/maven/pull/368/checks?check_run_id=941247515 -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [maven-integration-testing] asfgit closed pull request #70: [MNG-6974] fix mng5175 by waiting longer for read timeout to happen
asfgit closed pull request #70: URL: https://github.com/apache/maven-integration-testing/pull/70 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (MNGSITE-422) Sending announcement using Maven Changes Plugin fails when promoting a Maven release
Dennis Lundberg created MNGSITE-422: --- Summary: Sending announcement using Maven Changes Plugin fails when promoting a Maven release Key: MNGSITE-422 URL: https://issues.apache.org/jira/browse/MNGSITE-422 Project: Maven Project Web Site Issue Type: Improvement Reporter: Dennis Lundberg While releasing Maven Shared Utils 3.3.3 I followed the instructions at: https://maven.apache.org/developers/release/maven-project-release-procedure.html When doing the announcement a 5.a. it failed for me with this error: Failed to execute goal org.apache.maven.plugins:maven-changes-plugin:2.12.1:announcement-generate (announcement-generate) on project maven-shared-utils: Failed to extract issues from JIRA. Invalid browse URL -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Assigned] (MNG-6974) IT for MNG-5175 (Wagon HTTP) fails with JDK 14
[ https://issues.apache.org/jira/browse/MNG-6974?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov reassigned MNG-6974: --- Assignee: Michael Osipov > IT for MNG-5175 (Wagon HTTP) fails with JDK 14 > -- > > Key: MNG-6974 > URL: https://issues.apache.org/jira/browse/MNG-6974 > Project: Maven > Issue Type: Bug > Components: Integration Tests >Affects Versions: 3.6.3 >Reporter: Michael Kroll >Assignee: Michael Osipov >Priority: Major > Labels: pull-request-available, test > > [ERROR] Tests run: 846, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: > 210.078 s <<< FAILURE! - in org.apache.maven.it.IntegrationTestSuite > [ERROR] > testmng5175_ReadTimeOutFromSettings(org.apache.maven.it.MavenITmng5175WagonHttpTest) > Time elapsed: 0.166 s <<< ERROR! > org.apache.maven.it.VerificationException: Text not found in log: Could not > transfer artifact > org.apache.maven.its.mng5175:fake-dependency:pom:1.0-SNAPSHOT > at > org.apache.maven.it.MavenITmng5175WagonHttpTest.testmng5175_ReadTimeOutFromSettings(MavenITmng5175WagonHttpTest.java:128) > https://github.com/apache/maven/pull/368/checks?check_run_id=941247515 -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (MNG-6974) IT for MNG-5175 (Wagon HTTP) fails with JDK 14
[ https://issues.apache.org/jira/browse/MNG-6974?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov updated MNG-6974: Summary: IT for MNG-5175 (Wagon HTTP) fails with JDK 14 (was: IT 5175 (wagon http) fails for JDK 14) > IT for MNG-5175 (Wagon HTTP) fails with JDK 14 > -- > > Key: MNG-6974 > URL: https://issues.apache.org/jira/browse/MNG-6974 > Project: Maven > Issue Type: Bug > Components: Integration Tests >Affects Versions: 3.6.3 >Reporter: Michael Kroll >Priority: Major > Labels: pull-request-available, test > > [ERROR] Tests run: 846, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: > 210.078 s <<< FAILURE! - in org.apache.maven.it.IntegrationTestSuite > [ERROR] > testmng5175_ReadTimeOutFromSettings(org.apache.maven.it.MavenITmng5175WagonHttpTest) > Time elapsed: 0.166 s <<< ERROR! > org.apache.maven.it.VerificationException: Text not found in log: Could not > transfer artifact > org.apache.maven.its.mng5175:fake-dependency:pom:1.0-SNAPSHOT > at > org.apache.maven.it.MavenITmng5175WagonHttpTest.testmng5175_ReadTimeOutFromSettings(MavenITmng5175WagonHttpTest.java:128) > https://github.com/apache/maven/pull/368/checks?check_run_id=941247515 -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (MNG-6972) Allow access to org.apache.maven.graph
[
https://issues.apache.org/jira/browse/MNG-6972?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Osipov updated MNG-6972:
Summary: Allow access to org.apache.maven.graph (was: Maven doesn't export
org.apache.maven.graph)
> Allow access to org.apache.maven.graph
> --
>
> Key: MNG-6972
> URL: https://issues.apache.org/jira/browse/MNG-6972
> Project: Maven
> Issue Type: Improvement
> Components: Class Loading, Plugin API
>Affects Versions: 3.6.3
>Reporter: Michael Kroll
>Assignee: Michael Osipov
>Priority: Major
> Labels: easyfix, pull-request-available
> Fix For: 3.7.0-candidate
>
>
> Hi
> maven doesn't export org.apache.maven.graph package in
> maven-core/src/main/resources/META-INF/maven/extension.xml so the
> GraphBuilder is not usable in extensions.
> {code:java}
> // leads to java.lang.NoClassDefFoundError:
> Lorg/apache/maven/graph/GraphBuilder;
> @Requirement( hint = GraphBuilder.HINT )
> private GraphBuilder graphBuilder;
> {code}
> Background: if one build extension adds dependencies and another build
> extension uses {{session.getProjectDependencyGraph()}}, then the dependency
> graph is out of date. This is because the graph is only rebuilt after
> executing _all_ extensions. One solution to this would be to update the
> {{MavenSession}} and setting the new dependency graph in the first extension,
> but for this we need access to the {{GraphBuilder}}.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (MNG-6972) Maven doesn't export org.apache.maven.graph
[
https://issues.apache.org/jira/browse/MNG-6972?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Osipov updated MNG-6972:
Issue Type: Improvement (was: Bug)
> Maven doesn't export org.apache.maven.graph
> ---
>
> Key: MNG-6972
> URL: https://issues.apache.org/jira/browse/MNG-6972
> Project: Maven
> Issue Type: Improvement
> Components: Class Loading, Plugin API
>Affects Versions: 3.6.3
>Reporter: Michael Kroll
>Assignee: Michael Osipov
>Priority: Major
> Labels: easyfix, pull-request-available
> Fix For: 3.7.0-candidate
>
>
> Hi
> maven doesn't export org.apache.maven.graph package in
> maven-core/src/main/resources/META-INF/maven/extension.xml so the
> GraphBuilder is not usable in extensions.
> {code:java}
> // leads to java.lang.NoClassDefFoundError:
> Lorg/apache/maven/graph/GraphBuilder;
> @Requirement( hint = GraphBuilder.HINT )
> private GraphBuilder graphBuilder;
> {code}
> Background: if one build extension adds dependencies and another build
> extension uses {{session.getProjectDependencyGraph()}}, then the dependency
> graph is out of date. This is because the graph is only rebuilt after
> executing _all_ extensions. One solution to this would be to update the
> {{MavenSession}} and setting the new dependency graph in the first extension,
> but for this we need access to the {{GraphBuilder}}.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [maven-surefire] rmannibucau commented on a change in pull request #309: [SUREFIRE-756] Allow ability to capture executed random runOrder for re-play purposes
rmannibucau commented on a change in pull request #309:
URL: https://github.com/apache/maven-surefire/pull/309#discussion_r464988133
##
File path:
maven-failsafe-plugin/src/main/java/org/apache/maven/plugin/failsafe/IntegrationTestMojo.java
##
@@ -310,6 +310,22 @@
@Parameter( property = "failsafe.runOrder", defaultValue = "filesystem" )
private String runOrder;
+/**
+ * Sets the random seed that will be used to order the tests if {@code
failsafe.runOrder} is set to {@code random}.
+ *
+ *
+ * If no seeds are set and {@code failsafe.runOrder} is set to {@code
random}, then the seed used will be
+ * outputted (search for "To reproduce ordering use flag -Dfailsafe.seed").
+ *
+ *
+ * To deterministically reproduce any random test order that was run
before, simply set the seed to
+ * be the same value.
+ *
+ * @since 3.0.0-M6
+ */
+@Parameter( property = "failsafe.seed" )
+private Long randomSeed;
Review comment:
@Tibor17 fact it creates less parameters is irrelevant - in particular
today we have a tons of parameters. Fact it makes it harder to use, integrate
and is more error prone for end users is what counts at the end and here having
a dedicated variable for the replay is highly relevant IMHO. Also note that
having the seed is not always enough to replay a test suite (in particular in
random mode) so you can just need to capture the test order and replay it
explicitly (a runOrder=fromFile and runOrderFile=/path would be more relevant
there).
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Commented] (MNG-6455) ci-friendly version in parent pom displays build warning in child project
[
https://issues.apache.org/jira/browse/MNG-6455?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17170736#comment-17170736
]
Johan Backlund commented on MNG-6455:
-
Brilliant, [~khmarbaise], thank you!
Sorry for not seeing this in the documentation, but googled and got this
reopened issue high in the list, thinking it was the actual problem.
> ci-friendly version in parent pom displays build warning in child project
> -
>
> Key: MNG-6455
> URL: https://issues.apache.org/jira/browse/MNG-6455
> Project: Maven
> Issue Type: Bug
>Reporter: Robert Thornton
>Priority: Minor
> Attachments: mng-6455.zip
>
>
> I have a project that is using a parent project with ci-friendly versions,
> but while Maven is scanning for projects, it is looking for
> "my-parent-$%7Brevision%7D.pom" instead of "my-parent-1.0-a8e435". The
> project builds, but a warning is printed which confuses some of the teams
> using my parent pom.
> {{[INFO] Scanning for projects...}}
> {{Downloading from mvn-lds:
> https://code.myserver.org/artifactory/mvn-repo/my/stack/platform/my-parent/$%7Brevision%7D/my-parent-$%7Brevision%7D.pom}}
> {{[WARNING] Failed to build parent project for
> my.stack.platform:my-project:pom:4.8.2.RELEASE}}
>
> I've tracked the issue down to DefaultProjectBuilder, line 671 where
> `project.getParentArtifact()` is returning an Artifact object with the
> unresolved version.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (MNG-6966) Maven scope test not active in pre/post-integration
[
https://issues.apache.org/jira/browse/MNG-6966?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17170728#comment-17170728
]
Karl Heinz Marbaise commented on MNG-6966:
--
Please make a full working example which shows the problem...
> Maven scope test not active in pre/post-integration
> ---
>
> Key: MNG-6966
> URL: https://issues.apache.org/jira/browse/MNG-6966
> Project: Maven
> Issue Type: Bug
> Components: core
>Affects Versions: 3.6.0
> Environment: Windows, Cygwin, Maven 3.6.0, Java 1.8.0, Spring-Boot
> 2.2.6.RELEASE.
>Reporter: Y. Gablin
>Priority: Minor
>
> First, the relevant part of my {{pom.xml}} file:
> {code:xml}
>
>
> org.postgresql
> postgresql
>
>
> org.springframework.boot
> spring-boot-starter-test
> test
>
>
> com.h2database
> h2
> test
>
>
>
>
>
> org.apache.maven.plugins
> maven-surefire-plugin
>
>
> org.apache.maven.plugins
> maven-failsafe-plugin
>
>
>
> integration-test
> verify
>
>
>
>
>
>
> {code}
> I have Spring-Boot-2 validation tests, testing the full application stack
> (annotated with {{SpringBootTest}}), from the (mock-)MVC layer to the JPA
> layer (backed by an H2 in-memory database).
> All is fine, because I have the Maven H2 dependency as
> {{test}}, and the validation tests, ran by the failsafe plugin
> in the {{integration-test}} phase, do benefit from having H2 in the
> classpath, which implies that Spring-Boot generates the required
> {{DataSource}}, and so on.
> Now, I have new tests to run in the {{integration-test}} phase, that need to
> have the embedded Tomcat actually running, which is precisely what this
> additional fragment is made for:
> {code:xml}
>
> org.springframework.boot
> spring-boot-maven-plugin
>
>
> pre-integration-test
>
> start
>
>
>
> post-integration-test
>
> stop
>
>
>
>
> {code}
> The [documentation for this
> plugin|https://docs.spring.io/autorepo/docs/spring-boot/2.1.4.RELEASE/maven-plugin/plugin-info.html]
> tells us, that those goals are respectively attached to phases
> {{pre-integration-test}} and {{post-integration-test}}.
> My problem is that, when the application starts, Spring Boot does *not* find
> H2 in the classpath, and thus does not create a {{DataSource}}, which my
> application, _and tests from the {{integration-test}} phase_, require!
> I conclude from that, that the Maven {{test}} scope does _not_ apply to the
> {{pre-integration-test}} and {{post-integration-test}} phases, which does not
> seem logical / consistent to me.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (MNG-6455) ci-friendly version in parent pom displays build warning in child project
[
https://issues.apache.org/jira/browse/MNG-6455?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17170724#comment-17170724
]
Karl Heinz Marbaise commented on MNG-6455:
--
Based on the given example you are using {{mvn install}} where [in the
documentation|https://maven.apache.org/maven-ci-friendly.html#install-deploy]
explicitly stated that if you use {{install/deploy}} you *have to* configure
the {{flatten-maven-plugin}} which is responsible to resolve the special
properties. Otherwise it will not work.
The example for {{parent-pom}} does not contain a configuration for
{{flatten-maven-plugin}} which will result in such issues.
If you have *not* configured {{flatten-maven-plugin}} you can take a look into
the installed {{parent-pom.xml}} which looks like this:
{code:xml}
http://maven.apache.org/POM/4.0.0;
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance;
xsi:schemaLocation="http://maven.apache.org/POM/4.0.0
http://maven.apache.org/xsd/maven-4.0.0.xsd;>
4.0.0
com.example
parent-pom
${revision}
pom
1.0.0-SNAPSHOT
...
{code}
If you have configured {{flatten-maven-plugin}} the result in the
{{parent-pom.xml}} you have installed looks like this:
{code:xml}
http://maven.apache.org/POM/4.0.0
https://maven.apache.org/xsd/maven-4.0.0.xsd;
xmlns="http://maven.apache.org/POM/4.0.0;
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance;>
4.0.0
com.example
parent-pom
1.0.0-SNAPSHOT
pom
1.0.0-SNAPSHOT
..
{code}
> ci-friendly version in parent pom displays build warning in child project
> -
>
> Key: MNG-6455
> URL: https://issues.apache.org/jira/browse/MNG-6455
> Project: Maven
> Issue Type: Bug
>Reporter: Robert Thornton
>Priority: Minor
> Attachments: mng-6455.zip
>
>
> I have a project that is using a parent project with ci-friendly versions,
> but while Maven is scanning for projects, it is looking for
> "my-parent-$%7Brevision%7D.pom" instead of "my-parent-1.0-a8e435". The
> project builds, but a warning is printed which confuses some of the teams
> using my parent pom.
> {{[INFO] Scanning for projects...}}
> {{Downloading from mvn-lds:
> https://code.myserver.org/artifactory/mvn-repo/my/stack/platform/my-parent/$%7Brevision%7D/my-parent-$%7Brevision%7D.pom}}
> {{[WARNING] Failed to build parent project for
> my.stack.platform:my-project:pom:4.8.2.RELEASE}}
>
> I've tracked the issue down to DefaultProjectBuilder, line 671 where
> `project.getParentArtifact()` is returning an Artifact object with the
> unresolved version.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Closed] (MNG-6455) ci-friendly version in parent pom displays build warning in child project
[
https://issues.apache.org/jira/browse/MNG-6455?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Karl Heinz Marbaise closed MNG-6455.
Resolution: Not A Problem
> ci-friendly version in parent pom displays build warning in child project
> -
>
> Key: MNG-6455
> URL: https://issues.apache.org/jira/browse/MNG-6455
> Project: Maven
> Issue Type: Bug
>Reporter: Robert Thornton
>Priority: Minor
> Attachments: mng-6455.zip
>
>
> I have a project that is using a parent project with ci-friendly versions,
> but while Maven is scanning for projects, it is looking for
> "my-parent-$%7Brevision%7D.pom" instead of "my-parent-1.0-a8e435". The
> project builds, but a warning is printed which confuses some of the teams
> using my parent pom.
> {{[INFO] Scanning for projects...}}
> {{Downloading from mvn-lds:
> https://code.myserver.org/artifactory/mvn-repo/my/stack/platform/my-parent/$%7Brevision%7D/my-parent-$%7Brevision%7D.pom}}
> {{[WARNING] Failed to build parent project for
> my.stack.platform:my-project:pom:4.8.2.RELEASE}}
>
> I've tracked the issue down to DefaultProjectBuilder, line 671 where
> `project.getParentArtifact()` is returning an Artifact object with the
> unresolved version.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (MNG-6972) Maven doesn't export org.apache.maven.graph
[
https://issues.apache.org/jira/browse/MNG-6972?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Osipov updated MNG-6972:
Fix Version/s: 3.7.0-candidate
> Maven doesn't export org.apache.maven.graph
> ---
>
> Key: MNG-6972
> URL: https://issues.apache.org/jira/browse/MNG-6972
> Project: Maven
> Issue Type: Bug
> Components: Class Loading, Plugin API
>Affects Versions: 3.6.3
>Reporter: Michael Kroll
>Assignee: Michael Osipov
>Priority: Major
> Labels: easyfix, pull-request-available
> Fix For: 3.7.0-candidate
>
>
> Hi
> maven doesn't export org.apache.maven.graph package in
> maven-core/src/main/resources/META-INF/maven/extension.xml so the
> GraphBuilder is not usable in extensions.
> {code:java}
> // leads to java.lang.NoClassDefFoundError:
> Lorg/apache/maven/graph/GraphBuilder;
> @Requirement( hint = GraphBuilder.HINT )
> private GraphBuilder graphBuilder;
> {code}
> Background: if one build extension adds dependencies and another build
> extension uses {{session.getProjectDependencyGraph()}}, then the dependency
> graph is out of date. This is because the graph is only rebuilt after
> executing _all_ extensions. One solution to this would be to update the
> {{MavenSession}} and setting the new dependency graph in the first extension,
> but for this we need access to the {{GraphBuilder}}.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Assigned] (MNG-6972) Maven doesn't export org.apache.maven.graph
[
https://issues.apache.org/jira/browse/MNG-6972?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Osipov reassigned MNG-6972:
---
Assignee: Michael Osipov
> Maven doesn't export org.apache.maven.graph
> ---
>
> Key: MNG-6972
> URL: https://issues.apache.org/jira/browse/MNG-6972
> Project: Maven
> Issue Type: Bug
> Components: Class Loading, Plugin API
>Affects Versions: 3.6.3
>Reporter: Michael Kroll
>Assignee: Michael Osipov
>Priority: Major
> Labels: easyfix, pull-request-available
>
> Hi
> maven doesn't export org.apache.maven.graph package in
> maven-core/src/main/resources/META-INF/maven/extension.xml so the
> GraphBuilder is not usable in extensions.
> {code:java}
> // leads to java.lang.NoClassDefFoundError:
> Lorg/apache/maven/graph/GraphBuilder;
> @Requirement( hint = GraphBuilder.HINT )
> private GraphBuilder graphBuilder;
> {code}
> Background: if one build extension adds dependencies and another build
> extension uses {{session.getProjectDependencyGraph()}}, then the dependency
> graph is out of date. This is because the graph is only rebuilt after
> executing _all_ extensions. One solution to this would be to update the
> {{MavenSession}} and setting the new dependency graph in the first extension,
> but for this we need access to the {{GraphBuilder}}.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (MNG-6455) ci-friendly version in parent pom displays build warning in child project
[
https://issues.apache.org/jira/browse/MNG-6455?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17170712#comment-17170712
]
Johan Backlund commented on MNG-6455:
-
I have got the same issue here using
3.6.3 (cecedd343002696d0abb50b32b541b8a6ba2883f)
To me, the steps to reproduce as described by [~rptmaestro] demonstrates the
issue very well. I can confirm that the issue is appearing when using a
standalone parent with . And from the symptoms described by
[~Kiemes], he is probably experiencing the very same issue.
I am willing to assist if anything else is needed.
> ci-friendly version in parent pom displays build warning in child project
> -
>
> Key: MNG-6455
> URL: https://issues.apache.org/jira/browse/MNG-6455
> Project: Maven
> Issue Type: Bug
>Reporter: Robert Thornton
>Priority: Minor
> Attachments: mng-6455.zip
>
>
> I have a project that is using a parent project with ci-friendly versions,
> but while Maven is scanning for projects, it is looking for
> "my-parent-$%7Brevision%7D.pom" instead of "my-parent-1.0-a8e435". The
> project builds, but a warning is printed which confuses some of the teams
> using my parent pom.
> {{[INFO] Scanning for projects...}}
> {{Downloading from mvn-lds:
> https://code.myserver.org/artifactory/mvn-repo/my/stack/platform/my-parent/$%7Brevision%7D/my-parent-$%7Brevision%7D.pom}}
> {{[WARNING] Failed to build parent project for
> my.stack.platform:my-project:pom:4.8.2.RELEASE}}
>
> I've tracked the issue down to DefaultProjectBuilder, line 671 where
> `project.getParentArtifact()` is returning an Artifact object with the
> unresolved version.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (MNG-6974) IT 5175 (wagon http) fails for JDK 14
[ https://issues.apache.org/jira/browse/MNG-6974?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17170711#comment-17170711 ] Michael Osipov commented on MNG-6974: - I assume that the test was designed to run as fast as possible and w/o reliability in mind. Let me run a few test on my box and then we will try the PR. > IT 5175 (wagon http) fails for JDK 14 > - > > Key: MNG-6974 > URL: https://issues.apache.org/jira/browse/MNG-6974 > Project: Maven > Issue Type: Bug > Components: Integration Tests >Affects Versions: 3.6.3 >Reporter: Michael Kroll >Priority: Major > Labels: pull-request-available, test > > [ERROR] Tests run: 846, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: > 210.078 s <<< FAILURE! - in org.apache.maven.it.IntegrationTestSuite > [ERROR] > testmng5175_ReadTimeOutFromSettings(org.apache.maven.it.MavenITmng5175WagonHttpTest) > Time elapsed: 0.166 s <<< ERROR! > org.apache.maven.it.VerificationException: Text not found in log: Could not > transfer artifact > org.apache.maven.its.mng5175:fake-dependency:pom:1.0-SNAPSHOT > at > org.apache.maven.it.MavenITmng5175WagonHttpTest.testmng5175_ReadTimeOutFromSettings(MavenITmng5175WagonHttpTest.java:128) > https://github.com/apache/maven/pull/368/checks?check_run_id=941247515 -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [maven-surefire] Tibor17 commented on a change in pull request #309: [SUREFIRE-756] Allow ability to capture executed random runOrder for re-play purposes
Tibor17 commented on a change in pull request #309:
URL: https://github.com/apache/maven-surefire/pull/309#discussion_r464949748
##
File path:
maven-failsafe-plugin/src/main/java/org/apache/maven/plugin/failsafe/IntegrationTestMojo.java
##
@@ -310,6 +310,22 @@
@Parameter( property = "failsafe.runOrder", defaultValue = "filesystem" )
private String runOrder;
+/**
+ * Sets the random seed that will be used to order the tests if {@code
failsafe.runOrder} is set to {@code random}.
+ *
+ *
+ * If no seeds are set and {@code failsafe.runOrder} is set to {@code
random}, then the seed used will be
+ * outputted (search for "To reproduce ordering use flag -Dfailsafe.seed").
+ *
+ *
+ * To deterministically reproduce any random test order that was run
before, simply set the seed to
+ * be the same value.
+ *
+ * @since 3.0.0-M6
+ */
+@Parameter( property = "failsafe.seed" )
+private Long randomSeed;
Review comment:
@rmannibucau This way we would have too many config params. Having it in
one means that it is about the same business. Here you are setting only run
order and so that you say "random" is the same business value with the "seed".
Alternatively it can be done another way with the extensions where this
parameter may become an interface. It means that the parameter "runOrder" would
become an element what is called complexType in the XML and it may have
specific nested elements for the concrete implementation of the interface, and
the "seed" would be only for the "random".
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [maven-surefire] Tibor17 commented on a change in pull request #309: [SUREFIRE-756] Allow ability to capture executed random runOrder for re-play purposes
Tibor17 commented on a change in pull request #309:
URL: https://github.com/apache/maven-surefire/pull/309#discussion_r464949748
##
File path:
maven-failsafe-plugin/src/main/java/org/apache/maven/plugin/failsafe/IntegrationTestMojo.java
##
@@ -310,6 +310,22 @@
@Parameter( property = "failsafe.runOrder", defaultValue = "filesystem" )
private String runOrder;
+/**
+ * Sets the random seed that will be used to order the tests if {@code
failsafe.runOrder} is set to {@code random}.
+ *
+ *
+ * If no seeds are set and {@code failsafe.runOrder} is set to {@code
random}, then the seed used will be
+ * outputted (search for "To reproduce ordering use flag -Dfailsafe.seed").
+ *
+ *
+ * To deterministically reproduce any random test order that was run
before, simply set the seed to
+ * be the same value.
+ *
+ * @since 3.0.0-M6
+ */
+@Parameter( property = "failsafe.seed" )
+private Long randomSeed;
Review comment:
@rmannibucau This was we would have too many config params. Having it in
one means that it is about the same business. Here you are setting only run
order and so that you say "random" is the same business value with the "seed".
Alternatively it can be done another way with the extensions where this
parameter may become an interface. It means that the parameter "runOrder" would
become an element what is called complexType in the XML and it may have
specific nested elements for the concrete implementation of the interface, and
the "seed" would be only for the "random".
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [maven-integration-testing] mickroll removed a comment on pull request #70: [MNG-6974] fix mng5175 by waiting longer for read timeout to happen
mickroll removed a comment on pull request #70: URL: https://github.com/apache/maven-integration-testing/pull/70#issuecomment-668420409 This PR should fix build stability problems in https://github.com/apache/maven/pull/368 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-integration-testing] mickroll commented on pull request #70: [MNG-6974] fix mng5175 by waiting longer for read timeout to happen
mickroll commented on pull request #70: URL: https://github.com/apache/maven-integration-testing/pull/70#issuecomment-668420409 This PR should fix build stability problems in https://github.com/apache/maven/pull/368 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Comment Edited] (MNG-6974) IT 5175 (wagon http) fails for JDK 14
[ https://issues.apache.org/jira/browse/MNG-6974?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17170596#comment-17170596 ] Michael Kroll edited comment on MNG-6974 at 8/4/20, 7:03 AM: - [~michael-o]: good catch! some mote details when the test failed: build: # [https://github.com/apache/maven/actions/runs/193482983] # [https://github.com/apache/maven/actions/runs/193452873] # [https://github.com/apache/maven/actions/runs/193305706] # [https://github.com/apache/maven/actions/runs/193177159] # [https://github.com/apache/maven/actions/runs/193525582] test failures marked with an x: ||build||1||2||3||4||5|| |ubuntu, java 8| | | | | | |ubuntu, java 11| | | | | | |ubuntu, java 14| | |x|x|x| |windows, java 8| | | | | | |windows, java 11| | | | | | |windows, java 14| | | | | | |macos, java 8|x| | |x| | |macos, java 11|x| | | | | |macos, java 14| |x| | |x| This doesn't look stable. Reminder: the only change was an additional package-export in extension.xml, the test that fails is about a http read timeout. There should be no interference. was (Author: mickroll): [~michael-o]: good catch! some mote details when the test failed: build: # https://github.com/apache/maven/actions/runs/193482983 # https://github.com/apache/maven/actions/runs/193452873 # https://github.com/apache/maven/actions/runs/193305706 # https://github.com/apache/maven/actions/runs/193177159 # https://github.com/apache/maven/actions/runs/193525582 test failures marked with an x: || build|| 1 || 2 || 3 || 4 || 5 || | ubuntu, java 8 | | | | | | | ubuntu, java 11 | | | | | | | ubuntu, java 14 | | | x | x | x | | windows, java 8 | | | | | | | windows, java 11 | | | | | | | windows, java 14 | | | | | | | macos, java 8| x | | | x | | | macos, java 11 | x | | | | | | macos, java 14 | | x | | | x | This doesn't look stable. Reminder: the only change was an additional package-export in extension.xml! > IT 5175 (wagon http) fails for JDK 14 > - > > Key: MNG-6974 > URL: https://issues.apache.org/jira/browse/MNG-6974 > Project: Maven > Issue Type: Bug > Components: Integration Tests >Affects Versions: 3.6.3 >Reporter: Michael Kroll >Priority: Major > Labels: pull-request-available, test > > [ERROR] Tests run: 846, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: > 210.078 s <<< FAILURE! - in org.apache.maven.it.IntegrationTestSuite > [ERROR] > testmng5175_ReadTimeOutFromSettings(org.apache.maven.it.MavenITmng5175WagonHttpTest) > Time elapsed: 0.166 s <<< ERROR! > org.apache.maven.it.VerificationException: Text not found in log: Could not > transfer artifact > org.apache.maven.its.mng5175:fake-dependency:pom:1.0-SNAPSHOT > at > org.apache.maven.it.MavenITmng5175WagonHttpTest.testmng5175_ReadTimeOutFromSettings(MavenITmng5175WagonHttpTest.java:128) > https://github.com/apache/maven/pull/368/checks?check_run_id=941247515 -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (MNG-6974) IT 5175 (wagon http) fails for JDK 14
[ https://issues.apache.org/jira/browse/MNG-6974?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Kroll updated MNG-6974: --- Labels: pull-request-available test (was: test) > IT 5175 (wagon http) fails for JDK 14 > - > > Key: MNG-6974 > URL: https://issues.apache.org/jira/browse/MNG-6974 > Project: Maven > Issue Type: Bug > Components: Integration Tests >Affects Versions: 3.6.3 >Reporter: Michael Kroll >Priority: Major > Labels: pull-request-available, test > > [ERROR] Tests run: 846, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: > 210.078 s <<< FAILURE! - in org.apache.maven.it.IntegrationTestSuite > [ERROR] > testmng5175_ReadTimeOutFromSettings(org.apache.maven.it.MavenITmng5175WagonHttpTest) > Time elapsed: 0.166 s <<< ERROR! > org.apache.maven.it.VerificationException: Text not found in log: Could not > transfer artifact > org.apache.maven.its.mng5175:fake-dependency:pom:1.0-SNAPSHOT > at > org.apache.maven.it.MavenITmng5175WagonHttpTest.testmng5175_ReadTimeOutFromSettings(MavenITmng5175WagonHttpTest.java:128) > https://github.com/apache/maven/pull/368/checks?check_run_id=941247515 -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [maven-integration-testing] mickroll opened a new pull request #70: [MNG-6974] fix mng5175 by waiting longer for read timeout to happen
mickroll opened a new pull request #70: URL: https://github.com/apache/maven-integration-testing/pull/70 spotted by @michael-o: > the thread sleeps for 15 ms and the read timeout is set to 10 ms. I consider this is to be a racing condition fixes MNG-6974 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MNG-6974) IT 5175 (wagon http) fails for JDK 14
[ https://issues.apache.org/jira/browse/MNG-6974?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17170596#comment-17170596 ] Michael Kroll commented on MNG-6974: [~michael-o]: good catch! some mote details when the test failed: build: # https://github.com/apache/maven/actions/runs/193482983 # https://github.com/apache/maven/actions/runs/193452873 # https://github.com/apache/maven/actions/runs/193305706 # https://github.com/apache/maven/actions/runs/193177159 # https://github.com/apache/maven/actions/runs/193525582 test failures marked with an x: || build|| 1 || 2 || 3 || 4 || 5 || | ubuntu, java 8 | | | | | | | ubuntu, java 11 | | | | | | | ubuntu, java 14 | | | x | x | x | | windows, java 8 | | | | | | | windows, java 11 | | | | | | | windows, java 14 | | | | | | | macos, java 8| x | | | x | | | macos, java 11 | x | | | | | | macos, java 14 | | x | | | x | This doesn't look stable. Reminder: the only change was an additional package-export in extension.xml! > IT 5175 (wagon http) fails for JDK 14 > - > > Key: MNG-6974 > URL: https://issues.apache.org/jira/browse/MNG-6974 > Project: Maven > Issue Type: Bug > Components: Integration Tests >Affects Versions: 3.6.3 >Reporter: Michael Kroll >Priority: Major > Labels: test > > [ERROR] Tests run: 846, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: > 210.078 s <<< FAILURE! - in org.apache.maven.it.IntegrationTestSuite > [ERROR] > testmng5175_ReadTimeOutFromSettings(org.apache.maven.it.MavenITmng5175WagonHttpTest) > Time elapsed: 0.166 s <<< ERROR! > org.apache.maven.it.VerificationException: Text not found in log: Could not > transfer artifact > org.apache.maven.its.mng5175:fake-dependency:pom:1.0-SNAPSHOT > at > org.apache.maven.it.MavenITmng5175WagonHttpTest.testmng5175_ReadTimeOutFromSettings(MavenITmng5175WagonHttpTest.java:128) > https://github.com/apache/maven/pull/368/checks?check_run_id=941247515 -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (MNG-6974) IT 5175 (wagon http) fails for JDK 14
[ https://issues.apache.org/jira/browse/MNG-6974?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17170582#comment-17170582 ] Michael Osipov commented on MNG-6974: - When you look at the test you'll see that the thread sleeps for 15 ms and the read timeout is set to 10 ms. I consider this is to be a racing condition or ephemeral behavior on that runner. At best, times are increased to solve this. > IT 5175 (wagon http) fails for JDK 14 > - > > Key: MNG-6974 > URL: https://issues.apache.org/jira/browse/MNG-6974 > Project: Maven > Issue Type: Bug > Components: Integration Tests >Affects Versions: 3.6.3 >Reporter: Michael Kroll >Priority: Major > Labels: test > > [ERROR] Tests run: 846, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: > 210.078 s <<< FAILURE! - in org.apache.maven.it.IntegrationTestSuite > [ERROR] > testmng5175_ReadTimeOutFromSettings(org.apache.maven.it.MavenITmng5175WagonHttpTest) > Time elapsed: 0.166 s <<< ERROR! > org.apache.maven.it.VerificationException: Text not found in log: Could not > transfer artifact > org.apache.maven.its.mng5175:fake-dependency:pom:1.0-SNAPSHOT > at > org.apache.maven.it.MavenITmng5175WagonHttpTest.testmng5175_ReadTimeOutFromSettings(MavenITmng5175WagonHttpTest.java:128) > https://github.com/apache/maven/pull/368/checks?check_run_id=941247515 -- This message was sent by Atlassian Jira (v8.3.4#803005)
