[GitHub] [maven-ear-plugin] mabrarov commented on pull request #24: [MEAR-153] skinnyModules option
mabrarov commented on pull request #24: URL: https://github.com/apache/maven-ear-plugin/pull/24#issuecomment-710698558 @elharo, could you please trigger Jenkins build for this pull request? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-ear-plugin] mabrarov commented on pull request #22: [MEAR-216] Handling test JARs as regular JARs
mabrarov commented on pull request #22: URL: https://github.com/apache/maven-ear-plugin/pull/22#issuecomment-710698128 It looks like Jenkins build passed successfully. What needs to be done to merge this pull request and close MEAR-216? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-resolver] michaelboyles commented on pull request #76: [MRESOLVER-141] - Review index-based access to collections
michaelboyles commented on pull request #76: URL: https://github.com/apache/maven-resolver/pull/76#issuecomment-710697704 Thanks for reviewing This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-ear-plugin] mabrarov commented on pull request #23: [MEAR-288] Check timestamp file name when removing JARs and modifying manifest
mabrarov commented on pull request #23: URL: https://github.com/apache/maven-ear-plugin/pull/23#issuecomment-710697763 Jenkins build passed successfully. Refer to https://ci-builds.apache.org/job/Maven/job/maven-box/job/maven-ear-plugin/job/mear-288. What needs to be done to merge this pull request and close MEAR-288? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Closed] (MRESOLVER-141) Review index-based access to collections
[ https://issues.apache.org/jira/browse/MRESOLVER-141?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov closed MRESOLVER-141. Resolution: Fixed Fixed with [a932eacf6ccad6db1f8b1b39b7f769bb858fa46f|https://gitbox.apache.org/repos/asf?p=maven-resolver-ant-tasks.git;a=commit;h=a932eacf6ccad6db1f8b1b39b7f769bb858fa46f]. > Review index-based access to collections > > > Key: MRESOLVER-141 > URL: https://issues.apache.org/jira/browse/MRESOLVER-141 > Project: Maven Resolver > Issue Type: Task > Components: resolver >Affects Versions: 1.6.1 >Reporter: Michael Osipov >Assignee: Michael Osipov >Priority: Major > Fix For: version-next > > Attachments: image-2020-10-10-00-17-38-120.png > > > At some posts collections are accessed like arrays: > !image-2020-10-10-00-17-38-120.png|thumbnail! > This may import performance penalties. Review them and use enhanced for loops > or iterators. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [maven-resolver] asfgit closed pull request #76: [MRESOLVER-141] - Review index-based access to collections
asfgit closed pull request #76: URL: https://github.com/apache/maven-resolver/pull/76 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (MRESOLVER-141) Review index-based access to collections
[ https://issues.apache.org/jira/browse/MRESOLVER-141?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov updated MRESOLVER-141: - Fix Version/s: version-next > Review index-based access to collections > > > Key: MRESOLVER-141 > URL: https://issues.apache.org/jira/browse/MRESOLVER-141 > Project: Maven Resolver > Issue Type: Task > Components: resolver >Affects Versions: 1.6.1 >Reporter: Michael Osipov >Assignee: Michael Osipov >Priority: Major > Fix For: version-next > > Attachments: image-2020-10-10-00-17-38-120.png > > > At some posts collections are accessed like arrays: > !image-2020-10-10-00-17-38-120.png|thumbnail! > This may import performance penalties. Review them and use enhanced for loops > or iterators. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Assigned] (MRESOLVER-141) Review index-based access to collections
[ https://issues.apache.org/jira/browse/MRESOLVER-141?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov reassigned MRESOLVER-141: Assignee: Michael Osipov > Review index-based access to collections > > > Key: MRESOLVER-141 > URL: https://issues.apache.org/jira/browse/MRESOLVER-141 > Project: Maven Resolver > Issue Type: Task > Components: resolver >Affects Versions: 1.6.1 >Reporter: Michael Osipov >Assignee: Michael Osipov >Priority: Major > Attachments: image-2020-10-10-00-17-38-120.png > > > At some posts collections are accessed like arrays: > !image-2020-10-10-00-17-38-120.png|thumbnail! > This may import performance penalties. Review them and use enhanced for loops > or iterators. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [maven-resolver] michael-o commented on pull request #76: [MRESOLVER-141] - Review index-based access to collections
michael-o commented on pull request #76: URL: https://github.com/apache/maven-resolver/pull/76#issuecomment-710692030 Agreed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MNG-6135) Maven plugins and core extensions are not dependencies, they should be resolved the same way as projects.
[
https://issues.apache.org/jira/browse/MNG-6135?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17215686#comment-17215686
]
Michael Osipov commented on MNG-6135:
-
[~bondolo], because this is a lot of work? Do you want to give it a try?
> Maven plugins and core extensions are not dependencies, they should be
> resolved the same way as projects.
> -
>
> Key: MNG-6135
> URL: https://issues.apache.org/jira/browse/MNG-6135
> Project: Maven
> Issue Type: Bug
>Reporter: Christian Schulte
>Priority: Critical
> Fix For: 3.7.x-candidate
>
>
> Due to a bug in the Maven resolver, plugin and core extensions were resolved
> incorrectly: the direct {{test}} and {{provided}} dependencies were ignored.
> Ironically, this fix breaks some plugins because direct {{test}} dependencies
> now take precedence over transitive {{compile}} one: see MNG-5739
> (we know only one case where {{provided}} case has an impact: MPLUGIN-296,
> and in this only case, the new behaviour is more consistent than the previous)
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (MRESOLVER-142) maven does not honour configured in some cases
[
https://issues.apache.org/jira/browse/MRESOLVER-142?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17215684#comment-17215684
]
Michael Osipov commented on MRESOLVER-142:
--
I had to apply the following patch to make the project run:
{noformat}
diff --git a/module-a/pom.xml b/module-a/pom.xml
index 6c1144b..8fd4fa1 100644
--- a/module-a/pom.xml
+++ b/module-a/pom.xml
@@ -8,7 +8,7 @@
- dependency-parent
+ dependency
dependency
0.0.1
diff --git a/module-b/pom.xml b/module-b/pom.xml
index 19045cb..a30b049 100644
--- a/module-b/pom.xml
+++ b/module-b/pom.xml
@@ -8,7 +8,7 @@
- dependency-parent
+ dependency
dependency
0.0.1
{noformat}
It is not fully clear to me what the bug is. You understanding is that the repo
which loaded dependency-parent for module a should not be visible to module b
under no circumstances?
> maven does not honour configured in some cases
> -
>
> Key: MRESOLVER-142
> URL: https://issues.apache.org/jira/browse/MRESOLVER-142
> Project: Maven Resolver
> Issue Type: Bug
> Components: resolver
>Reporter: Igor Fedorenko
>Priority: Major
>
> There appear to be a bug in artifact descriptor cache implemented in aether
> DefaultDependencyCollector. The cache allows use of cached descriptors when
> descriptor parent(s) are not accessible from any enabled repository.
> This is particularly problematic during multithreaded builds, where timing of
> individual module project builds is not guaranteed, and the invalid artifact
> descriptor cache implementation can result in infrequent and hard to
> troubleshoot dependency resolution failures.
> I'll provide small standalone example project that demonstrates the problem
> shortly.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [maven-resolver-ant-tasks] michael-o commented on pull request #2: [MRESOLVER-98] resolver ant task doesn't obey dependencyManagement
michael-o commented on pull request #2: URL: https://github.com/apache/maven-resolver-ant-tasks/pull/2#issuecomment-710679536 @lwr Can you rebase on top of master? I'd like to pick this up. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MRESOLVER-66) Settings task does not load active profile repositories defined in settings.xml
[
https://issues.apache.org/jira/browse/MRESOLVER-66?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17215680#comment-17215680
]
Michael Osipov commented on MRESOLVER-66:
-
Branch MRESOLVER-66 has been pushed, have a look.
> Settings task does not load active profile repositories defined in
> settings.xml
> ---
>
> Key: MRESOLVER-66
> URL: https://issues.apache.org/jira/browse/MRESOLVER-66
> Project: Maven Resolver
> Issue Type: Bug
> Components: ant tasks
>Affects Versions: ant-tasks-1.2.1
>Reporter: lefebvre
>Assignee: Michael Osipov
>Priority: Major
> Fix For: ant-tasks-1.3.0
>
> Attachments: MRESOLVER-66.log, MRESOLVER-66.xml
>
>
> my-settings.xml :
> {code:xml}
>
> http://maven.apache.org/SETTINGS/1.0.0;
> xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance;
> xsi:schemaLocation="http://maven.apache.org/SETTINGS/1.0.0
> http://maven.apache.org/xsd/settings-1.0.0.xsd;>
> false
>
>
> my-repo
>
>
>
> Private-Token
> XXX
>
>
>
>
>
>
>
> enable-repos
>
>
> central
> central
> http://repo1.maven.org/maven2
>
>
> my-repo
> my repository
> XXX
>
>
>
>
>
> enable-repos
>
>
> {code}
>
> {{}}
>
> The resolver task does not try to resolve artifacts using "my-repo".
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (MRESOLVER-66) Settings task does not load active profile repositories defined in settings.xml
[
https://issues.apache.org/jira/browse/MRESOLVER-66?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17215681#comment-17215681
]
Michael Osipov commented on MRESOLVER-66:
-
Branch MRESOLVER-66 has been pushed, have a look.
> Settings task does not load active profile repositories defined in
> settings.xml
> ---
>
> Key: MRESOLVER-66
> URL: https://issues.apache.org/jira/browse/MRESOLVER-66
> Project: Maven Resolver
> Issue Type: Bug
> Components: ant tasks
>Affects Versions: ant-tasks-1.2.1
>Reporter: lefebvre
>Assignee: Michael Osipov
>Priority: Major
> Fix For: ant-tasks-1.3.0
>
> Attachments: MRESOLVER-66.log, MRESOLVER-66.xml
>
>
> my-settings.xml :
> {code:xml}
>
> http://maven.apache.org/SETTINGS/1.0.0;
> xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance;
> xsi:schemaLocation="http://maven.apache.org/SETTINGS/1.0.0
> http://maven.apache.org/xsd/settings-1.0.0.xsd;>
> false
>
>
> my-repo
>
>
>
> Private-Token
> XXX
>
>
>
>
>
>
>
> enable-repos
>
>
> central
> central
> http://repo1.maven.org/maven2
>
>
> my-repo
> my repository
> XXX
>
>
>
>
>
> enable-repos
>
>
> {code}
>
> {{}}
>
> The resolver task does not try to resolve artifacts using "my-repo".
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [maven-resolver-ant-tasks] michael-o opened a new pull request #4: [MRESOLVER-66] Settings task does not load active profile repositorie…
michael-o opened a new pull request #4: URL: https://github.com/apache/maven-resolver-ant-tasks/pull/4 …s defined in settings.xml This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (MRESOLVER-66) Settings task does not load active profile repositories defined in settings.xml
[
https://issues.apache.org/jira/browse/MRESOLVER-66?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Osipov updated MRESOLVER-66:
Affects Version/s: (was: 1.3.1)
ant-tasks-1.2.1
> Settings task does not load active profile repositories defined in
> settings.xml
> ---
>
> Key: MRESOLVER-66
> URL: https://issues.apache.org/jira/browse/MRESOLVER-66
> Project: Maven Resolver
> Issue Type: Bug
> Components: ant tasks
>Affects Versions: ant-tasks-1.2.1
>Reporter: lefebvre
>Assignee: Michael Osipov
>Priority: Major
> Fix For: ant-tasks-1.3.0
>
> Attachments: MRESOLVER-66.log, MRESOLVER-66.xml
>
>
> my-settings.xml :
> {code:xml}
>
> http://maven.apache.org/SETTINGS/1.0.0;
> xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance;
> xsi:schemaLocation="http://maven.apache.org/SETTINGS/1.0.0
> http://maven.apache.org/xsd/settings-1.0.0.xsd;>
> false
>
>
> my-repo
>
>
>
> Private-Token
> XXX
>
>
>
>
>
>
>
> enable-repos
>
>
> central
> central
> http://repo1.maven.org/maven2
>
>
> my-repo
> my repository
> XXX
>
>
>
>
>
> enable-repos
>
>
> {code}
>
> {{}}
>
> The resolver task does not try to resolve artifacts using "my-repo".
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (MRESOLVER-66) Settings task does not load active profile repositories defined in settings.xml
[
https://issues.apache.org/jira/browse/MRESOLVER-66?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Osipov updated MRESOLVER-66:
Fix Version/s: ant-tasks-1.3.0
> Settings task does not load active profile repositories defined in
> settings.xml
> ---
>
> Key: MRESOLVER-66
> URL: https://issues.apache.org/jira/browse/MRESOLVER-66
> Project: Maven Resolver
> Issue Type: Bug
> Components: ant tasks
>Affects Versions: 1.3.1
>Reporter: lefebvre
>Assignee: Michael Osipov
>Priority: Major
> Fix For: ant-tasks-1.3.0
>
> Attachments: MRESOLVER-66.log, MRESOLVER-66.xml
>
>
> my-settings.xml :
> {code:xml}
>
> http://maven.apache.org/SETTINGS/1.0.0;
> xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance;
> xsi:schemaLocation="http://maven.apache.org/SETTINGS/1.0.0
> http://maven.apache.org/xsd/settings-1.0.0.xsd;>
> false
>
>
> my-repo
>
>
>
> Private-Token
> XXX
>
>
>
>
>
>
>
> enable-repos
>
>
> central
> central
> http://repo1.maven.org/maven2
>
>
> my-repo
> my repository
> XXX
>
>
>
>
>
> enable-repos
>
>
> {code}
>
> {{}}
>
> The resolver task does not try to resolve artifacts using "my-repo".
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (MRESOLVER-66) Settings task does not load active profile repositories defined in settings.xml
[
https://issues.apache.org/jira/browse/MRESOLVER-66?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Osipov updated MRESOLVER-66:
Summary: Settings task does not load active profile repositories defined in
settings.xml (was: settings task does not load repositories defined into
settings.xml)
> Settings task does not load active profile repositories defined in
> settings.xml
> ---
>
> Key: MRESOLVER-66
> URL: https://issues.apache.org/jira/browse/MRESOLVER-66
> Project: Maven Resolver
> Issue Type: Bug
> Components: ant tasks
>Affects Versions: 1.3.1
>Reporter: lefebvre
>Assignee: Michael Osipov
>Priority: Major
> Attachments: MRESOLVER-66.log, MRESOLVER-66.xml
>
>
> my-settings.xml :
> {code:xml}
>
> http://maven.apache.org/SETTINGS/1.0.0;
> xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance;
> xsi:schemaLocation="http://maven.apache.org/SETTINGS/1.0.0
> http://maven.apache.org/xsd/settings-1.0.0.xsd;>
> false
>
>
> my-repo
>
>
>
> Private-Token
> XXX
>
>
>
>
>
>
>
> enable-repos
>
>
> central
> central
> http://repo1.maven.org/maven2
>
>
> my-repo
> my repository
> XXX
>
>
>
>
>
> enable-repos
>
>
> {code}
>
> {{}}
>
> The resolver task does not try to resolve artifacts using "my-repo".
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Assigned] (MRESOLVER-66) settings task does not load repositories defined into settings.xml
[
https://issues.apache.org/jira/browse/MRESOLVER-66?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Osipov reassigned MRESOLVER-66:
---
Assignee: Michael Osipov
> settings task does not load repositories defined into settings.xml
> --
>
> Key: MRESOLVER-66
> URL: https://issues.apache.org/jira/browse/MRESOLVER-66
> Project: Maven Resolver
> Issue Type: Bug
> Components: ant tasks
>Affects Versions: 1.3.1
>Reporter: lefebvre
>Assignee: Michael Osipov
>Priority: Major
> Attachments: MRESOLVER-66.log, MRESOLVER-66.xml
>
>
> my-settings.xml :
> {code:xml}
>
> http://maven.apache.org/SETTINGS/1.0.0;
> xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance;
> xsi:schemaLocation="http://maven.apache.org/SETTINGS/1.0.0
> http://maven.apache.org/xsd/settings-1.0.0.xsd;>
> false
>
>
> my-repo
>
>
>
> Private-Token
> XXX
>
>
>
>
>
>
>
> enable-repos
>
>
> central
> central
> http://repo1.maven.org/maven2
>
>
> my-repo
> my repository
> XXX
>
>
>
>
>
> enable-repos
>
>
> {code}
>
> {{}}
>
> The resolver task does not try to resolve artifacts using "my-repo".
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (MRESOLVER-66) settings task does not load repositories defined into settings.xml
[
https://issues.apache.org/jira/browse/MRESOLVER-66?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17215660#comment-17215660
]
Michael Osipov commented on MRESOLVER-66:
-
So, I went through the PR and the issue itself. The PR is useless because this
is not a local repo issue. The repos from settings are never read because the
settings file is used for almost everything, but the profiles. The profile are
only used when a model is loaded and processed by {{resolver:install}} or
{{resolver:deploy}}. If you look closely into the code you see in
{{org.apache.maven.resolver.internal.ant.AntRepoSys.collectDependencies(Task,
Dependencies, LocalRepository, RemoteRepositories)}} that
{{AetherUtils.getDefaultRepositories( project )}} is performed which in turn
does {{project.getReference( Names.ID_DEFAULT_REPOS )}}. What does that
basically mean? One needs to inject the repos from settings somewhere. Which
{{initDefaults()}} this is not possible cause the setter for settings file does
call this init method. This will result in a chicken-and-egg problem.
How does that look to you?
{noformat}
D:\Entwicklung\Projekte\MRESOLVER-66> ant test -verbose
Listening for transport dt_socket at address: 5432
Apache Ant(TM) version 1.10.5 compiled on July 10 2018
Trying the default build file: build.xml
Buildfile: D:\Entwicklung\Projekte\MRESOLVER-66\build.xml
Detected Java version: 1.8 in: C:\Program
Files\AdoptOpenJDK\jdk-8.0.265.01-hotspot\jre
Detected OS: Windows 10
parsing buildfile D:\Entwicklung\Projekte\MRESOLVER-66\build.xml with URI =
file:/D:/Entwicklung/Projekte/MRESOLVER-66/build.xml
Project base dir set to: D:\Entwicklung\Projekte\MRESOLVER-66
parsing buildfile
jar:file:/D:/Entwicklung/Programme/apache-ant-1.10.5/lib/ant.jar!/org/apache/tools/ant/antlib.xml
with URI =
jar:file:/D:/Entwicklung/Programme/apache-ant-1.10.5/lib/ant.jar!/org/apache/tools/ant/antlib.xml
from a zip file
parsing buildfile
jar:file:/D:/Entwicklung/Projekte/MRESOLVER-66/lib/maven-resolver-ant-tasks-1.2.2-SNAPSHOT-uber.jar!/org/apache/maven/resolver/ant/antlib.xml
with URI =
jar:file:/D:/Entwicklung/Projekte/MRESOLVER-66/lib/maven-resolver-ant-tasks-1.2.2-SNAPSHOT-uber.jar!/org/apache/maven/resolver/ant/antlib.xml
from a zip file
[antlib:org.apache.maven.resolver.ant] Could not load definitions from resource
org/apache/maven/resolver/ant/antlib.xml. It could not be found.
Build sequence for target(s) `test' is [test]
Complete build sequence is [test, ]
test:
[echo] Resolving a 'my-repo' artifact
[resolver:resolve] Using local repository C:\Users\mosipov\.m2\repository
(enhanced)
Using remote repository central (https://repo1.maven.org/maven2/, default,
releases)
Using remote repository my-repo (file:///D:/Repo, default, releases+snapshots)
Collecting dependencies
[resolver:resolve] Downloading
file:///D:/Repo/com/httpclient-retry/0.0.1-SNAPSHOT/maven-metadata.xml
[resolver:resolve] Downloaded
file:///D:/Repo/com/httpclient-retry/0.0.1-SNAPSHOT/maven-metadata.xml (769 B
at 28.9 KB/sec)
[resolver:resolve] Downloading
file:///D:/Repo/com/httpclient-retry/0.0.1-SNAPSHOT/httpclient-retry-0.0.1-20201016.190157-1.pom
[resolver:resolve] Downloaded
file:///D:/Repo/com/httpclient-retry/0.0.1-SNAPSHOT/httpclient-retry-0.0.1-20201016.190157-1.pom
(2 KB at 149.6 KB/sec)
[resolver:resolve] Downloading
file:///D:/Repo/org/apache/httpcomponents/client5/httpclient5/5.0.2-SNAPSHOT/maven-metadata.xml
[resolver:resolve] Downloading
file:///D:/Repo/org/apache/httpcomponents/client5/httpclient5-parent/5.0.2-SNAPSHOT/maven-metadata.xml
[resolver:resolve] Resolved Dependency Graph:
[resolver:resolve]com:httpclient-retry:jar:0.0.1-SNAPSHOT:compile
[resolver:resolve] org.apache.httpcomponents:httpclient:jar:4.5.11:compile
[resolver:resolve]
org.apache.httpcomponents:httpcore:jar:4.4.13:compile
[resolver:resolve] commons-codec:commons-codec:jar:1.11:compile
[resolver:resolve] org.slf4j:slf4j-simple:jar:1.7.30:runtime
[resolver:resolve] org.slf4j:slf4j-api:jar:1.7.30:compile
[resolver:resolve] org.slf4j:jcl-over-slf4j:jar:1.7.30:runtime
[resolver:resolve]
org.apache.httpcomponents.client5:httpclient5:jar:5.0.2-SNAPSHOT:compile
[resolver:resolve]
org.apache.httpcomponents.core5:httpcore5:jar:5.0.2:compile
[resolver:resolve]
org.apache.httpcomponents.core5:httpcore5-h2:jar:5.0.2:compile
[resolver:resolve] org.redisson:redisson:jar:3.13.3:compile
[resolver:resolve] io.netty:netty-common:jar:4.1.51.Final:compile
[resolver:resolve] io.netty:netty-codec:jar:4.1.51.Final:compile
[resolver:resolve] io.netty:netty-buffer:jar:4.1.51.Final:compile
[resolver:resolve] io.netty:netty-transport:jar:4.1.51.Final:compile
[resolver:resolve] io.netty:netty-resolver:jar:4.1.51.Final:compile
[resolver:resolve]
[GitHub] [maven-resolver-ant-tasks] michael-o closed pull request #3: [MRESOLVER-66] settings task does not load repositories defined into settings.xml
michael-o closed pull request #3: URL: https://github.com/apache/maven-resolver-ant-tasks/pull/3 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-resolver-ant-tasks] michael-o commented on pull request #3: [MRESOLVER-66] settings task does not load repositories defined into settings.xml
michael-o commented on pull request #3: URL: https://github.com/apache/maven-resolver-ant-tasks/pull/3#issuecomment-710664165 Does not work This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MCOMPILER-436) Cannot compile code that depends on on Apache Mina SSH due to JPMS error
[ https://issues.apache.org/jira/browse/MCOMPILER-436?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17215649#comment-17215649 ] Gili commented on MCOMPILER-436: Got it. So let's leave things as-is. For future reference (in case someone else runs across this issue) it looks like this logic is happening at https://github.com/codehaus-plexus/plexus-languages/blob/15031cc226516d0fa30a43aa38d8159e6e2e9115/plexus-java/src/main/java/org/codehaus/plexus/languages/java/jpms/LocationManager.java#L201 which invokes https://github.com/codehaus-plexus/plexus-languages/blob/15031cc226516d0fa30a43aa38d8159e6e2e9115/plexus-java/src/main/java/org/codehaus/plexus/languages/java/jpms/LocationManager.java#L357 which invokes https://github.com/codehaus-plexus/plexus-languages/blob/dc2d4d45edb7b63de7575fe10bd2af4a6b577e4b/plexus-java/src/main/java9/org/codehaus/plexus/languages/java/jpms/CmdModuleNameExtractor.java#L90 > Cannot compile code that depends on on Apache Mina SSH due to JPMS error > > > Key: MCOMPILER-436 > URL: https://issues.apache.org/jira/browse/MCOMPILER-436 > Project: Maven Compiler Plugin > Issue Type: Bug >Affects Versions: 3.8.1 >Reporter: Gili >Priority: Major > Attachments: extract-module-name.zip > > > 1. Extract Testcase > 2. Run "mvn clean install" > 3. Build fails with: > [WARNING] Can't extract module name from sshd-core-2.5.1.jar: Provider class > org.apache.sshd.common.file.root.RootedFileSystemProvider not in module > [ERROR] module not found: sshd.core > Expected behavior: The plugin should be able to extract the module name given > that sshd-core depends on sshd-commons which contains the aforementioned > provider and automatic modules can access classes outside their module. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [maven-resolver] michaelboyles commented on pull request #76: [MRESOLVER-141] - Review index-based access to collections
michaelboyles commented on pull request #76: URL: https://github.com/apache/maven-resolver/pull/76#issuecomment-710431377 I didn't miss them. I decided not to change them. **DefaultDependencyCollector partially (line 758)** It's a NodeStack. A custom class which does not support iterators. It only has size() and get(). I could add an iterator method, but its backed by an array, so already has constant time random access. Wouldn't give any performance benefit **PathRecordingDependencyVisitor** Again, custom class backed by an array, this time Stack. Could change to this ``` List path = new ArrayList<>( this.parents ); Collections.reverse( path ); paths.add( path ); ``` which I think is the same result but more expressive. Probably actually slower because of the copy-then-reverse. Or at least, no performance benefit ***GenericVersion*** As far as I can tell, the index is necessary This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (MDEP-725) excludeGroupIds, excludeArtifactIds not working for go-offline goal
[
https://issues.apache.org/jira/browse/MDEP-725?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Maarten Mulders updated MDEP-725:
-
Description:
When applying {{-DexcludeGroupIds}} or {{-DexcludeArtifactIds}} to exclude
project dependencies from resolution, they still get resolved and downloaded by
{{go-offline}}:
{code}
mvn dependency:go-offline -DexcludeArtifactIds=example-core
...
[INFO] — maven-dependency-plugin:3.1.1:go-offline (default-cli) @ rest-example —
...
[INFO] Resolved: example-core-1.0.jar
{code}
Also reported in
[https://stackoverflow.com/questions/51113813/mvn-dependencygo-offline-how-do-you-set-params-on-the-command-line-or-at-all]
was:
When applying {{-DexcludeGroupIds}} or {{-DexcludeArtifactIds}} to exclude
project dependencies from resolution, they still get resolved and downloaded by
`go-offline`:
mvn dependency:go-offline -DexcludeArtifactIds=example-core
[INFO] — maven-dependency-plugin:3.1.1:go-offline (default-cli) @ rest-example —
...
[INFO] Resolved: example-core-1.0.jar
Also reported in
[https://stackoverflow.com/questions/51113813/mvn-dependencygo-offline-how-do-you-set-params-on-the-command-line-or-at-all]
> excludeGroupIds, excludeArtifactIds not working for go-offline goal
> ---
>
> Key: MDEP-725
> URL: https://issues.apache.org/jira/browse/MDEP-725
> Project: Maven Dependency Plugin
> Issue Type: Bug
> Components: go-offline
>Affects Versions: 3.1.1
>Reporter: Mahmoud Anouti
>Priority: Major
>
> When applying {{-DexcludeGroupIds}} or {{-DexcludeArtifactIds}} to exclude
> project dependencies from resolution, they still get resolved and downloaded
> by {{go-offline}}:
>
> {code}
> mvn dependency:go-offline -DexcludeArtifactIds=example-core
> ...
> [INFO] — maven-dependency-plugin:3.1.1:go-offline (default-cli) @
> rest-example —
> ...
> [INFO] Resolved: example-core-1.0.jar
> {code}
> Also reported in
> [https://stackoverflow.com/questions/51113813/mvn-dependencygo-offline-how-do-you-set-params-on-the-command-line-or-at-all]
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (MDEP-725) excludeGroupIds, excludeArtifactIds not working for go-offline goal
[
https://issues.apache.org/jira/browse/MDEP-725?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Maarten Mulders updated MDEP-725:
-
Description:
When applying {{-DexcludeGroupIds}} or {{-DexcludeArtifactIds}} to exclude
project dependencies from resolution, they still get resolved and downloaded by
`go-offline`:
mvn dependency:go-offline -DexcludeArtifactIds=example-core
[INFO] — maven-dependency-plugin:3.1.1:go-offline (default-cli) @ rest-example —
...
[INFO] Resolved: example-core-1.0.jar
Also reported in
[https://stackoverflow.com/questions/51113813/mvn-dependencygo-offline-how-do-you-set-params-on-the-command-line-or-at-all]
was:
When applying -DexcludeGroupIds or -DexcludeArtifactIds to exclude project
dependencies from resolution, they still get resolved and downloaded by
`go-offline`:
mvn dependency:go-offline -DexcludeArtifactIds=example-core
[INFO] — maven-dependency-plugin:3.1.1:go-offline (default-cli) @ rest-example —
...
[INFO] Resolved: example-core-1.0.jar
Also reported in
[https://stackoverflow.com/questions/51113813/mvn-dependencygo-offline-how-do-you-set-params-on-the-command-line-or-at-all]
> excludeGroupIds, excludeArtifactIds not working for go-offline goal
> ---
>
> Key: MDEP-725
> URL: https://issues.apache.org/jira/browse/MDEP-725
> Project: Maven Dependency Plugin
> Issue Type: Bug
> Components: go-offline
>Affects Versions: 3.1.1
>Reporter: Mahmoud Anouti
>Priority: Major
>
> When applying {{-DexcludeGroupIds}} or {{-DexcludeArtifactIds}} to exclude
> project dependencies from resolution, they still get resolved and downloaded
> by `go-offline`:
> mvn dependency:go-offline -DexcludeArtifactIds=example-core
>
> [INFO] — maven-dependency-plugin:3.1.1:go-offline (default-cli) @
> rest-example —
> ...
> [INFO] Resolved: example-core-1.0.jar
> Also reported in
> [https://stackoverflow.com/questions/51113813/mvn-dependencygo-offline-how-do-you-set-params-on-the-command-line-or-at-all]
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (MRESOLVER-143) Upgrade Maven Resolver to 1.6.1
[ https://issues.apache.org/jira/browse/MRESOLVER-143?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17215604#comment-17215604 ] Hudson commented on MRESOLVER-143: -- Build succeeded in Jenkins: Maven » Maven TLP » maven-resolver-ant-tasks » master #17 See https://ci-builds.apache.org/job/Maven/job/maven-box/job/maven-resolver-ant-tasks/job/master/17/ > Upgrade Maven Resolver to 1.6.1 > --- > > Key: MRESOLVER-143 > URL: https://issues.apache.org/jira/browse/MRESOLVER-143 > Project: Maven Resolver > Issue Type: Dependency upgrade > Components: ant tasks >Affects Versions: ant-tasks-1.2.1 >Reporter: Michael Osipov >Assignee: Michael Osipov >Priority: Major > Fix For: ant-tasks-1.3.0 > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Closed] (MRESOLVER-89) Cannot use SystemProxies
[ https://issues.apache.org/jira/browse/MRESOLVER-89?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov closed MRESOLVER-89. --- Fix Version/s: (was: waiting-for-feedback) ant-tasks-1.2.1 Assignee: Michael Osipov Resolution: Fixed If I understood you correctly, upgrade to Maven 3.6.0 solves the issue. This was done with version 1.2.1. Closing this as fixed. Reopen if you think different. > Cannot use SystemProxies > > > Key: MRESOLVER-89 > URL: https://issues.apache.org/jira/browse/MRESOLVER-89 > Project: Maven Resolver > Issue Type: Bug > Components: ant tasks >Affects Versions: ant-tasks-1.2.0 >Reporter: lefebvre >Assignee: Michael Osipov >Priority: Major > Fix For: ant-tasks-1.2.1 > > > Behind a proxy, if proxy configuration is not set cannot resolve artifacts. > > I have tried to set java.net.useSystemProxies to true and start ANT with > -autoproxy argument but no effect. Both case, resolution failed. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (MDEP-725) excludeGroupIds, excludeArtifactIds not working for go-offline goal
[
https://issues.apache.org/jira/browse/MDEP-725?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17215600#comment-17215600
]
Maarten Mulders commented on MDEP-725:
--
Oh, of course, that makes perfect sense. Indeed, using {{excludedArtifactIds}}
should not be needed to exclude dependencies that are available in the Reactor.
Maybe the exclusion is not working at all, let's say for dependencies outside
the Reactor. If that is the case, I'd say that is a bug indeed. It is not what
this ticket says explicitly, but the [answer by the OP on
StackOverflow|https://stackoverflow.com/a/64241726/1523342] suggests that is
the case.
> excludeGroupIds, excludeArtifactIds not working for go-offline goal
> ---
>
> Key: MDEP-725
> URL: https://issues.apache.org/jira/browse/MDEP-725
> Project: Maven Dependency Plugin
> Issue Type: Bug
> Components: go-offline
>Affects Versions: 3.1.1
>Reporter: Mahmoud Anouti
>Priority: Major
>
> When applying -DexcludeGroupIds or -DexcludeArtifactIds to exclude project
> dependencies from resolution, they still get resolved and downloaded by
> `go-offline`:
> mvn dependency:go-offline -DexcludeArtifactIds=example-core
>
> [INFO] — maven-dependency-plugin:3.1.1:go-offline (default-cli) @
> rest-example —
> ...
> [INFO] Resolved: example-core-1.0.jar
> Also reported in
> [https://stackoverflow.com/questions/51113813/mvn-dependencygo-offline-how-do-you-set-params-on-the-command-line-or-at-all]
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Closed] (MRESOLVER-143) Upgrade Maven Resolver to 1.6.1
[ https://issues.apache.org/jira/browse/MRESOLVER-143?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov closed MRESOLVER-143. Resolution: Fixed Fixed with [f33bed5264b406b05e04b0a31b686d0f035063ae|https://gitbox.apache.org/repos/asf?p=maven-resolver-ant-tasks.git;a=commit;h=f33bed5264b406b05e04b0a31b686d0f035063ae]. > Upgrade Maven Resolver to 1.6.1 > --- > > Key: MRESOLVER-143 > URL: https://issues.apache.org/jira/browse/MRESOLVER-143 > Project: Maven Resolver > Issue Type: Dependency upgrade > Components: ant tasks >Affects Versions: ant-tasks-1.2.1 >Reporter: Michael Osipov >Assignee: Michael Osipov >Priority: Major > Fix For: ant-tasks-1.3.0 > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (MRESOLVER-143) Upgrade Maven Resolver to 1.6.1
Michael Osipov created MRESOLVER-143: Summary: Upgrade Maven Resolver to 1.6.1 Key: MRESOLVER-143 URL: https://issues.apache.org/jira/browse/MRESOLVER-143 Project: Maven Resolver Issue Type: Dependency upgrade Components: ant tasks Affects Versions: ant-tasks-1.2.1 Reporter: Michael Osipov Assignee: Michael Osipov Fix For: ant-tasks-1.3.0 -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Comment Edited] (MDEP-725) excludeGroupIds, excludeArtifactIds not working for go-offline goal
[ https://issues.apache.org/jira/browse/MDEP-725?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17215596#comment-17215596 ] Robert Scholte edited comment on MDEP-725 at 10/16/20, 6:31 PM: I was thinking of MDEP-204, which was fixed in 3.1.2 (reporter was using 3.1.1) was (Author: rfscholte): I was thinking of MDEP-204 > excludeGroupIds, excludeArtifactIds not working for go-offline goal > --- > > Key: MDEP-725 > URL: https://issues.apache.org/jira/browse/MDEP-725 > Project: Maven Dependency Plugin > Issue Type: Bug > Components: go-offline >Affects Versions: 3.1.1 >Reporter: Mahmoud Anouti >Priority: Major > > When applying -DexcludeGroupIds or -DexcludeArtifactIds to exclude project > dependencies from resolution, they still get resolved and downloaded by > `go-offline`: > mvn dependency:go-offline -DexcludeArtifactIds=example-core > > [INFO] — maven-dependency-plugin:3.1.1:go-offline (default-cli) @ > rest-example — > ... > [INFO] Resolved: example-core-1.0.jar > Also reported in > [https://stackoverflow.com/questions/51113813/mvn-dependencygo-offline-how-do-you-set-params-on-the-command-line-or-at-all] > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (MDEP-725) excludeGroupIds, excludeArtifactIds not working for go-offline goal
[ https://issues.apache.org/jira/browse/MDEP-725?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17215596#comment-17215596 ] Robert Scholte commented on MDEP-725: - I was thinking of MDEP-204 > excludeGroupIds, excludeArtifactIds not working for go-offline goal > --- > > Key: MDEP-725 > URL: https://issues.apache.org/jira/browse/MDEP-725 > Project: Maven Dependency Plugin > Issue Type: Bug > Components: go-offline >Affects Versions: 3.1.2 >Reporter: Mahmoud Anouti >Priority: Major > > When applying -DexcludeGroupIds or -DexcludeArtifactIds to exclude project > dependencies from resolution, they still get resolved and downloaded by > `go-offline`: > mvn dependency:go-offline -DexcludeArtifactIds=example-core > > [INFO] — maven-dependency-plugin:3.1.1:go-offline (default-cli) @ > rest-example — > ... > [INFO] Resolved: example-core-1.0.jar > Also reported in > [https://stackoverflow.com/questions/51113813/mvn-dependencygo-offline-how-do-you-set-params-on-the-command-line-or-at-all] > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (MDEP-725) excludeGroupIds, excludeArtifactIds not working for go-offline goal
[ https://issues.apache.org/jira/browse/MDEP-725?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Scholte updated MDEP-725: Affects Version/s: (was: 3.1.2) 3.1.1 > excludeGroupIds, excludeArtifactIds not working for go-offline goal > --- > > Key: MDEP-725 > URL: https://issues.apache.org/jira/browse/MDEP-725 > Project: Maven Dependency Plugin > Issue Type: Bug > Components: go-offline >Affects Versions: 3.1.1 >Reporter: Mahmoud Anouti >Priority: Major > > When applying -DexcludeGroupIds or -DexcludeArtifactIds to exclude project > dependencies from resolution, they still get resolved and downloaded by > `go-offline`: > mvn dependency:go-offline -DexcludeArtifactIds=example-core > > [INFO] — maven-dependency-plugin:3.1.1:go-offline (default-cli) @ > rest-example — > ... > [INFO] Resolved: example-core-1.0.jar > Also reported in > [https://stackoverflow.com/questions/51113813/mvn-dependencygo-offline-how-do-you-set-params-on-the-command-line-or-at-all] > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (MRESOLVER-104) maven-resolver-demo-maven-plugin uses reserved groupId
[ https://issues.apache.org/jira/browse/MRESOLVER-104?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17215591#comment-17215591 ] Hudson commented on MRESOLVER-104: -- Build succeeded in Jenkins: Maven » Maven TLP » maven-resolver » master #33 See https://ci-builds.apache.org/job/Maven/job/maven-box/job/maven-resolver/job/master/33/ > maven-resolver-demo-maven-plugin uses reserved groupId > -- > > Key: MRESOLVER-104 > URL: https://issues.apache.org/jira/browse/MRESOLVER-104 > Project: Maven Resolver > Issue Type: Improvement >Reporter: Elliotte Rusty Harold >Assignee: Michael Osipov >Priority: Minor > Fix For: version-next > > > [INFO] --- maven-plugin-plugin:3.5.2:descriptor (default-descriptor) @ > maven-resolver-demo-maven-plugin --- > [ERROR] > Artifact Ids of the format maven-___-plugin are reserved for > plugins in the Group Id org.apache.maven.plugins > Please change your artifactId to the format ___-maven-plugin > In the future this error will break the build. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Closed] (MRESOLVER-104) maven-resolver-demo-maven-plugin uses reserved groupId
[ https://issues.apache.org/jira/browse/MRESOLVER-104?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov closed MRESOLVER-104. Resolution: Fixed Fixed with [28e4ec02dc94690828c0abcaaf8686c9e080f182|https://gitbox.apache.org/repos/asf?p=maven-resolver.git;a=commit;h=28e4ec02dc94690828c0abcaaf8686c9e080f182]. > maven-resolver-demo-maven-plugin uses reserved groupId > -- > > Key: MRESOLVER-104 > URL: https://issues.apache.org/jira/browse/MRESOLVER-104 > Project: Maven Resolver > Issue Type: Improvement >Reporter: Elliotte Rusty Harold >Assignee: Michael Osipov >Priority: Minor > Fix For: version-next > > > [INFO] --- maven-plugin-plugin:3.5.2:descriptor (default-descriptor) @ > maven-resolver-demo-maven-plugin --- > [ERROR] > Artifact Ids of the format maven-___-plugin are reserved for > plugins in the Group Id org.apache.maven.plugins > Please change your artifactId to the format ___-maven-plugin > In the future this error will break the build. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [maven-resolver] asfgit closed pull request #73: [MRESOLVER-104] - maven-resolver-demo-maven-plugin uses reserved artifactId
asfgit closed pull request #73: URL: https://github.com/apache/maven-resolver/pull/73 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-resolver] michael-o commented on pull request #73: [MRESOLVER-104] - maven-resolver-demo-maven-plugin uses reserved artifactId
michael-o commented on pull request #73: URL: https://github.com/apache/maven-resolver/pull/73#issuecomment-710349271 I have applied a minimal version of the patch because only the artifact id is problematic and it is a demo after all. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (MCOMPILER-438) Chained (consumer) XMLFilters can result in "floating" comments
Robert Scholte created MCOMPILER-438:
Summary: Chained (consumer) XMLFilters can result in "floating"
comments
Key: MCOMPILER-438
URL: https://issues.apache.org/jira/browse/MCOMPILER-438
Project: Maven Compiler Plugin
Issue Type: Bug
Reporter: Robert Scholte
Assignee: Robert Scholte
Discovered while working on MNG-6957: I wanted to do the following:
{code:xml}
Z
A
{code}
The ModulesXMLFilterTest contains tests related to comments, but when filters
are changed, the lexicalHandlers are not chained correctly.
The result: cleaned up modules, but leaving a comment behind.
{code:xml}
{code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Moved] (MNG-6999) Chained (consumer) XMLFilters can result in "floating" comments
[
https://issues.apache.org/jira/browse/MNG-6999?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Robert Scholte moved MCOMPILER-438 to MNG-6999:
---
Key: MNG-6999 (was: MCOMPILER-438)
Project: Maven (was: Maven Compiler Plugin)
> Chained (consumer) XMLFilters can result in "floating" comments
> ---
>
> Key: MNG-6999
> URL: https://issues.apache.org/jira/browse/MNG-6999
> Project: Maven
> Issue Type: Bug
>Reporter: Robert Scholte
>Assignee: Robert Scholte
>Priority: Major
>
> Discovered while working on MNG-6957: I wanted to do the following:
> {code:xml}
>
> Z
> A
>
> {code}
> The ModulesXMLFilterTest contains tests related to comments, but when filters
> are changed, the lexicalHandlers are not chained correctly.
> The result: cleaned up modules, but leaving a comment behind.
> {code:xml}
>
> {code}
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (MDEP-725) excludeGroupIds, excludeArtifactIds not working for go-offline goal
[
https://issues.apache.org/jira/browse/MDEP-725?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17215576#comment-17215576
]
Maarten Mulders commented on MDEP-725:
--
{quote}
[~mthmulders] there's no need to exclude reactor modules anymore, right?
{quote}
If you mean, because of the recent improvements in resolving dependencies that
reside elsewhere in the reactor (such as
[MNG-4660|https://issues.apache.org/jira/browse/MNG-4660]) - then indeed, it
shouldn't be necessary to exclude them for {{go-offline}} since they are always
available. That is Mavens own dependency resolution. If I'm not mistaken, the
M-D-P uses that mechanism, so using a 3.7.0 SNAPSHOT build of Maven it might
turn out to work as expected.
> excludeGroupIds, excludeArtifactIds not working for go-offline goal
> ---
>
> Key: MDEP-725
> URL: https://issues.apache.org/jira/browse/MDEP-725
> Project: Maven Dependency Plugin
> Issue Type: Bug
> Components: go-offline
>Affects Versions: 3.1.2
>Reporter: Mahmoud Anouti
>Priority: Major
>
> When applying -DexcludeGroupIds or -DexcludeArtifactIds to exclude project
> dependencies from resolution, they still get resolved and downloaded by
> `go-offline`:
> mvn dependency:go-offline -DexcludeArtifactIds=example-core
>
> [INFO] — maven-dependency-plugin:3.1.1:go-offline (default-cli) @
> rest-example —
> ...
> [INFO] Resolved: example-core-1.0.jar
> Also reported in
> [https://stackoverflow.com/questions/51113813/mvn-dependencygo-offline-how-do-you-set-params-on-the-command-line-or-at-all]
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (MCOMPILER-436) Cannot compile code that depends on on Apache Mina SSH due to JPMS error
[ https://issues.apache.org/jira/browse/MCOMPILER-436?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17215565#comment-17215565 ] Robert Scholte commented on MCOMPILER-436: -- No, step one is read the module descriptor based the single line of code I gave you before. If that fails, the rest will fail too. > Cannot compile code that depends on on Apache Mina SSH due to JPMS error > > > Key: MCOMPILER-436 > URL: https://issues.apache.org/jira/browse/MCOMPILER-436 > Project: Maven Compiler Plugin > Issue Type: Bug >Affects Versions: 3.8.1 >Reporter: Gili >Priority: Major > Attachments: extract-module-name.zip > > > 1. Extract Testcase > 2. Run "mvn clean install" > 3. Build fails with: > [WARNING] Can't extract module name from sshd-core-2.5.1.jar: Provider class > org.apache.sshd.common.file.root.RootedFileSystemProvider not in module > [ERROR] module not found: sshd.core > Expected behavior: The plugin should be able to extract the module name given > that sshd-core depends on sshd-commons which contains the aforementioned > provider and automatic modules can access classes outside their module. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (MPMD-290) Add CPD example for C#
[ https://issues.apache.org/jira/browse/MPMD-290?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17215559#comment-17215559 ] Hudson commented on MPMD-290: - Build succeeded in Jenkins: Maven » Maven TLP » maven-pmd-plugin » master #24 See https://ci-builds.apache.org/job/Maven/job/maven-box/job/maven-pmd-plugin/job/master/24/ > Add CPD example for C# > -- > > Key: MPMD-290 > URL: https://issues.apache.org/jira/browse/MPMD-290 > Project: Maven PMD Plugin > Issue Type: Improvement > Components: CPD >Affects Versions: 3.12.0 >Reporter: QualiteSys QualiteSys >Assignee: Andreas Dangel >Priority: Major > Fix For: 3.14.0 > > > I wish to analyze C# source code with CPD, with no success > Looking to the CpdReport.java MOJO, it seams that the language is not > extracted from either the pom.xml file or the CLI options. > Line 76 : > @Parameter( defaultValue = "java" ) > private String language; > property = "language" is missing, so the language is always forced to java > Is it possible to fix this bug, and add the missing languages CPD is > supporting ? > Thanks > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (MRESOLVER-104) maven-resolver-demo-maven-plugin uses reserved groupId
[ https://issues.apache.org/jira/browse/MRESOLVER-104?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov updated MRESOLVER-104: - Fix Version/s: version-next > maven-resolver-demo-maven-plugin uses reserved groupId > -- > > Key: MRESOLVER-104 > URL: https://issues.apache.org/jira/browse/MRESOLVER-104 > Project: Maven Resolver > Issue Type: Improvement >Reporter: Elliotte Rusty Harold >Assignee: Michael Osipov >Priority: Minor > Fix For: version-next > > > [INFO] --- maven-plugin-plugin:3.5.2:descriptor (default-descriptor) @ > maven-resolver-demo-maven-plugin --- > [ERROR] > Artifact Ids of the format maven-___-plugin are reserved for > plugins in the Group Id org.apache.maven.plugins > Please change your artifactId to the format ___-maven-plugin > In the future this error will break the build. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Assigned] (MRESOLVER-104) maven-resolver-demo-maven-plugin uses reserved groupId
[ https://issues.apache.org/jira/browse/MRESOLVER-104?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov reassigned MRESOLVER-104: Assignee: Michael Osipov > maven-resolver-demo-maven-plugin uses reserved groupId > -- > > Key: MRESOLVER-104 > URL: https://issues.apache.org/jira/browse/MRESOLVER-104 > Project: Maven Resolver > Issue Type: Improvement >Reporter: Elliotte Rusty Harold >Assignee: Michael Osipov >Priority: Minor > > [INFO] --- maven-plugin-plugin:3.5.2:descriptor (default-descriptor) @ > maven-resolver-demo-maven-plugin --- > [ERROR] > Artifact Ids of the format maven-___-plugin are reserved for > plugins in the Group Id org.apache.maven.plugins > Please change your artifactId to the format ___-maven-plugin > In the future this error will break the build. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [maven-resolver] asfgit closed pull request #75: Remove unused parameters and local variables
asfgit closed pull request #75: URL: https://github.com/apache/maven-resolver/pull/75 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MCOMPILER-436) Cannot compile code that depends on on Apache Mina SSH due to JPMS error
[ https://issues.apache.org/jira/browse/MCOMPILER-436?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17215505#comment-17215505 ] Gili commented on MCOMPILER-436: Looking at https://github.com/codehaus-plexus/plexus-languages/blob/master/plexus-java/src/main/java/org/codehaus/plexus/languages/java/jpms/LocationManager.java it seems that the module name *can* be extracted. The problem is that LocationManager.resolvePaths() does a lot more than extracting the module name. It tries resolving all line entries inside module-info.java. If we were to tease apart the different functionality, what would happen? Would we get past the module name extraction but at runtime the JRE would fail with a module load error? From a user perspective I think this would be a much nicer experience. I just don't know how much extra work will be involved to make this happen. > Cannot compile code that depends on on Apache Mina SSH due to JPMS error > > > Key: MCOMPILER-436 > URL: https://issues.apache.org/jira/browse/MCOMPILER-436 > Project: Maven Compiler Plugin > Issue Type: Bug >Affects Versions: 3.8.1 >Reporter: Gili >Priority: Major > Attachments: extract-module-name.zip > > > 1. Extract Testcase > 2. Run "mvn clean install" > 3. Build fails with: > [WARNING] Can't extract module name from sshd-core-2.5.1.jar: Provider class > org.apache.sshd.common.file.root.RootedFileSystemProvider not in module > [ERROR] module not found: sshd.core > Expected behavior: The plugin should be able to extract the module name given > that sshd-core depends on sshd-commons which contains the aforementioned > provider and automatic modules can access classes outside their module. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (MENFORCER-361) Introduce RequireTextFileChecksum with line separator normalization
[ https://issues.apache.org/jira/browse/MENFORCER-361?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17215475#comment-17215475 ] Hudson commented on MENFORCER-361: -- Build succeeded in Jenkins: Maven » Maven TLP » maven-enforcer » master #26 See https://ci-builds.apache.org/job/Maven/job/maven-box/job/maven-enforcer/job/master/26/ > Introduce RequireTextFileChecksum with line separator normalization > --- > > Key: MENFORCER-361 > URL: https://issues.apache.org/jira/browse/MENFORCER-361 > Project: Maven Enforcer Plugin > Issue Type: New Feature > Components: Standard Rules >Affects Versions: 3.0.0-M3 >Reporter: Konrad Windszus >Assignee: Michael Osipov >Priority: Major > Fix For: 3.0.0-M4 > > > Often text files differ by line separator. Therefore before calculating the > checksum it should be possible to normalize the line separator to either Unix > (LF) or Windows (CRLF) so that the same checksum works on all platforms. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [maven-enforcer] kwin commented on pull request #79: [MENFORCER-361] optionally normalize line separators prior to checksum calculation
kwin commented on pull request #79: URL: https://github.com/apache/maven-enforcer/pull/79#issuecomment-710142339 @michael-o Thanks for merging. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-resolver] michael-o commented on pull request #75: Remove unused parameters and local variables
michael-o commented on pull request #75: URL: https://github.com/apache/maven-resolver/pull/75#issuecomment-710132069 Going through... This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Closed] (MENFORCER-361) Introduce RequireTextFileChecksum with line separator normalization
[ https://issues.apache.org/jira/browse/MENFORCER-361?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov closed MENFORCER-361. Resolution: Fixed Fixed with [2babf83f8cb03b8565fa48fe429dbdd8f9fccee4|https://gitbox.apache.org/repos/asf?p=maven-enforcer.git;a=commit;h=2babf83f8cb03b8565fa48fe429dbdd8f9fccee4]. > Introduce RequireTextFileChecksum with line separator normalization > --- > > Key: MENFORCER-361 > URL: https://issues.apache.org/jira/browse/MENFORCER-361 > Project: Maven Enforcer Plugin > Issue Type: New Feature > Components: Standard Rules >Affects Versions: 3.0.0-M3 >Reporter: Konrad Windszus >Assignee: Michael Osipov >Priority: Major > Fix For: 3.0.0-M4 > > > Often text files differ by line separator. Therefore before calculating the > checksum it should be possible to normalize the line separator to either Unix > (LF) or Windows (CRLF) so that the same checksum works on all platforms. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [maven-enforcer] asfgit closed pull request #79: [MENFORCER-361] optionally normalize line separators prior to checksum calculation
asfgit closed pull request #79: URL: https://github.com/apache/maven-enforcer/pull/79 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Closed] (MNG-6998) POM parser returns jar packaging when pom contains war packaging entry
[ https://issues.apache.org/jira/browse/MNG-6998?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov closed MNG-6998. --- Fix Version/s: (was: waiting-for-feedback) Resolution: Not A Problem > POM parser returns jar packaging when pom contains war packaging entry > -- > > Key: MNG-6998 > URL: https://issues.apache.org/jira/browse/MNG-6998 > Project: Maven > Issue Type: Bug > Components: POM >Affects Versions: 3.6.3 > Environment: Windows 10 64 bit, Eclipse Juno Service Release 2, > maven-model-3.6.3.jar >Reporter: Paul C Brown >Priority: Minor > Attachments: image-2020-10-15-16-36-42-820.png, > image-2020-10-15-16-38-09-442.png > > > The read() method on the MavenXpp3Reader returns a model whose packaging > entry has the value of "jar" when the source document has the value of "war". > Source view: > !image-2020-10-15-16-38-09-442.png! > > Parsed model (output of read() method): > !image-2020-10-15-16-36-42-820.png! -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (MPMD-304) maven-pmd-plugin should be toolchains-aware
[ https://issues.apache.org/jira/browse/MPMD-304?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17215432#comment-17215432 ] Hudson commented on MPMD-304: - Build failed in Jenkins: Maven » Maven TLP » maven-pmd-plugin » master #23 See https://ci-builds.apache.org/job/Maven/job/maven-box/job/maven-pmd-plugin/job/master/23/ > maven-pmd-plugin should be toolchains-aware > --- > > Key: MPMD-304 > URL: https://issues.apache.org/jira/browse/MPMD-304 > Project: Maven PMD Plugin > Issue Type: Improvement > Components: CPD, PMD >Affects Versions: 3.13.0 > Environment: maven 3.6.3 > JDK 1.8 (maven) > JDK 11 (toolchains.xml) >Reporter: Ed Randall >Assignee: Andreas Dangel >Priority: Major > Fix For: 3.14.0 > > > maven-pmd-plugin should be > [toolchains-aware|https://maven.apache.org/guides/mini/guide-using-toolchains.html] > and pick up the correct JDK used for compilation. If toolchains is in use, > it should select that one, not use the same JDK that maven is running. > > We have an enterprise build system which runs maven under JDK 1.8. Some > projects target 1.8, others target 11. The switch is handled using > toolchains.xml. > PMD seemingly cannot cope with 11 code when maven is running under 1.8. We > are forced to set `pmd.typeResolution=false` to avoid all sorts of strange > errors (eg. 'unused private method' despite it being used 28 times in the > same class). > We do have `targetJdk=11`. > These false errors do not occur when maven itself runs under JDK 11, with > `pmd.typeResolution=true`. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (MPMD-290) Add CPD example for C#
[ https://issues.apache.org/jira/browse/MPMD-290?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17215431#comment-17215431 ] Hudson commented on MPMD-290: - Build failed in Jenkins: Maven » Maven TLP » maven-pmd-plugin » master #23 See https://ci-builds.apache.org/job/Maven/job/maven-box/job/maven-pmd-plugin/job/master/23/ > Add CPD example for C# > -- > > Key: MPMD-290 > URL: https://issues.apache.org/jira/browse/MPMD-290 > Project: Maven PMD Plugin > Issue Type: Improvement > Components: CPD >Affects Versions: 3.12.0 >Reporter: QualiteSys QualiteSys >Assignee: Andreas Dangel >Priority: Major > Fix For: 3.14.0 > > > I wish to analyze C# source code with CPD, with no success > Looking to the CpdReport.java MOJO, it seams that the language is not > extracted from either the pom.xml file or the CLI options. > Line 76 : > @Parameter( defaultValue = "java" ) > private String language; > property = "language" is missing, so the language is always forced to java > Is it possible to fix this bug, and add the missing languages CPD is > supporting ? > Thanks > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (MNG-6998) POM parser returns jar packaging when pom contains war packaging entry
[ https://issues.apache.org/jira/browse/MNG-6998?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17215420#comment-17215420 ] Paul C Brown commented on MNG-6998: --- My sincere apologies - I had an error in my code. There is no issue here. Please close this issue. > POM parser returns jar packaging when pom contains war packaging entry > -- > > Key: MNG-6998 > URL: https://issues.apache.org/jira/browse/MNG-6998 > Project: Maven > Issue Type: Bug > Components: POM >Affects Versions: 3.6.3 > Environment: Windows 10 64 bit, Eclipse Juno Service Release 2, > maven-model-3.6.3.jar >Reporter: Paul C Brown >Priority: Minor > Fix For: waiting-for-feedback > > Attachments: image-2020-10-15-16-36-42-820.png, > image-2020-10-15-16-38-09-442.png > > > The read() method on the MavenXpp3Reader returns a model whose packaging > entry has the value of "jar" when the source document has the value of "war". > Source view: > !image-2020-10-15-16-38-09-442.png! > > Parsed model (output of read() method): > !image-2020-10-15-16-36-42-820.png! -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (MENFORCER-361) RequireFileChecksum should support line separator normalization
[ https://issues.apache.org/jira/browse/MENFORCER-361?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov updated MENFORCER-361: - Issue Type: New Feature (was: Improvement) > RequireFileChecksum should support line separator normalization > --- > > Key: MENFORCER-361 > URL: https://issues.apache.org/jira/browse/MENFORCER-361 > Project: Maven Enforcer Plugin > Issue Type: New Feature > Components: Standard Rules >Affects Versions: 3.0.0-M3 >Reporter: Konrad Windszus >Assignee: Michael Osipov >Priority: Major > Fix For: 3.0.0-M4 > > > Often text files differ by line separator. Therefore before calculating the > checksum it should be possible to normalize the line separator to either Unix > (LF) or Windows (CRLF) so that the same checksum works on all platforms. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (MENFORCER-361) Introduce RequireTextFileChecksum with line separator normalization
[ https://issues.apache.org/jira/browse/MENFORCER-361?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov updated MENFORCER-361: - Summary: Introduce RequireTextFileChecksum with line separator normalization (was: RequireFileChecksum should support line separator normalization) > Introduce RequireTextFileChecksum with line separator normalization > --- > > Key: MENFORCER-361 > URL: https://issues.apache.org/jira/browse/MENFORCER-361 > Project: Maven Enforcer Plugin > Issue Type: New Feature > Components: Standard Rules >Affects Versions: 3.0.0-M3 >Reporter: Konrad Windszus >Assignee: Michael Osipov >Priority: Major > Fix For: 3.0.0-M4 > > > Often text files differ by line separator. Therefore before calculating the > checksum it should be possible to normalize the line separator to either Unix > (LF) or Windows (CRLF) so that the same checksum works on all platforms. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (MJARSIGNER-63) certchain should be supported by default
Manfred Koch created MJARSIGNER-63: -- Summary: certchain should be supported by default Key: MJARSIGNER-63 URL: https://issues.apache.org/jira/browse/MJARSIGNER-63 Project: Maven Jar Signer Plugin Issue Type: Improvement Affects Versions: 3.0.0 Reporter: Manfred Koch The certchain parameter of the jarsigne should be also supported by the Maven plugin. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (MJARSIGNER-62) additionalArguments should not have double quotes
Manfred Koch created MJARSIGNER-62:
--
Summary: additionalArguments should not have double quotes
Key: MJARSIGNER-62
URL: https://issues.apache.org/jira/browse/MJARSIGNER-62
Project: Maven Jar Signer Plugin
Issue Type: Bug
Affects Versions: 3.0.0
Environment: Windows
Reporter: Manfred Koch
Adding additional arguments to the jarsigner with the arguments option will be
double qouted in the command line. That causes errors and should be avoided.
*Example:*
{code:java}
-certchain c:\chain.crt
{code}
Results in
{noformat}
c:\Jenkins\tools\hudson.model.JDK\jdk-1.8.0_144-windows-x64\jre\..\bin\jarsigner.exe
-keystore NONE -storepass *** -storetype PKCS11 -providerClass
sun.security.pkcs11.SunPKCS11 -providerArg C:\config.conf "-certchain
c:\chain.crt" -tsa http://timestamp.digicert.com library.jar alias{noformat}
That can't be executed. I check that manually on the system.
But without double qoutes
{noformat}
c:\Jenkins\tools\hudson.model.JDK\jdk-1.8.0_144-windows-x64\jre\..\bin\jarsigner.exe
-keystore NONE -storepass *** -storetype PKCS11 -providerClass
sun.security.pkcs11.SunPKCS11 -providerArg C:\config.conf -certchain
c:\chain.crt -tsa http://timestamp.digicert.com library.jar alias{noformat}
it is possible to execute the command. I have checked the source code of the
*AbstractJarsignerMojo.* All *additionalArguments* should not be double quoted.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (MENFORCER-361) RequireFileChecksum should support line separator normalization
[
https://issues.apache.org/jira/browse/MENFORCER-361?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Osipov updated MENFORCER-361:
-
Description: Often text files differ by line separator. Therefore before
calculating the checksum it should be possible to normalize the line separator
to either Unix (LF) or Windows (CRLF) so that the same checksum works on all
platforms. (was: Often text files differ by line separator. Therefore before
calculating the checksum it should be possible to normalize the line separator
to either Unix (`/n`) or Windows ('/r/n') so that the same checksum works on
all platforms.)
> RequireFileChecksum should support line separator normalization
> ---
>
> Key: MENFORCER-361
> URL: https://issues.apache.org/jira/browse/MENFORCER-361
> Project: Maven Enforcer Plugin
> Issue Type: Improvement
> Components: Standard Rules
>Affects Versions: 3.0.0-M3
>Reporter: Konrad Windszus
>Assignee: Michael Osipov
>Priority: Major
> Fix For: 3.0.0-M4
>
>
> Often text files differ by line separator. Therefore before calculating the
> checksum it should be possible to normalize the line separator to either Unix
> (LF) or Windows (CRLF) so that the same checksum works on all platforms.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Assigned] (MENFORCER-361) RequireFileChecksum should support line separator normalization
[
https://issues.apache.org/jira/browse/MENFORCER-361?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Osipov reassigned MENFORCER-361:
Assignee: Michael Osipov
> RequireFileChecksum should support line separator normalization
> ---
>
> Key: MENFORCER-361
> URL: https://issues.apache.org/jira/browse/MENFORCER-361
> Project: Maven Enforcer Plugin
> Issue Type: Improvement
> Components: Standard Rules
>Affects Versions: 3.0.0-M3
>Reporter: Konrad Windszus
>Assignee: Michael Osipov
>Priority: Major
>
> Often text files differ by line separator. Therefore before calculating the
> checksum it should be possible to normalize the line separator to either Unix
> (`/n`) or Windows ('/r/n') so that the same checksum works on all platforms.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (MENFORCER-361) RequireFileChecksum should support line separator normalization
[
https://issues.apache.org/jira/browse/MENFORCER-361?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Osipov updated MENFORCER-361:
-
Fix Version/s: 3.0.0-M4
> RequireFileChecksum should support line separator normalization
> ---
>
> Key: MENFORCER-361
> URL: https://issues.apache.org/jira/browse/MENFORCER-361
> Project: Maven Enforcer Plugin
> Issue Type: Improvement
> Components: Standard Rules
>Affects Versions: 3.0.0-M3
>Reporter: Konrad Windszus
>Assignee: Michael Osipov
>Priority: Major
> Fix For: 3.0.0-M4
>
>
> Often text files differ by line separator. Therefore before calculating the
> checksum it should be possible to normalize the line separator to either Unix
> (`/n`) or Windows ('/r/n') so that the same checksum works on all platforms.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [maven-release] nfalco79 commented on a change in pull request #56: [MRELEASE-1042] releaseProfiles get overriden by activeProfiles
nfalco79 commented on a change in pull request #56:
URL: https://github.com/apache/maven-release/pull/56#discussion_r506370075
##
File path:
maven-release-manager/src/main/java/org/apache/maven/shared/release/DefaultReleaseManager.java
##
@@ -304,21 +305,26 @@ private void perform( ReleasePerformRequest
performRequest, ReleaseResult result
ReleaseUtils.buildReleaseDescriptor(
performRequest.getReleaseDescriptorBuilder() )
.getActivateProfiles();
-ReleaseDescriptor releaseDescriptor =
-loadReleaseDescriptor(
performRequest.getReleaseDescriptorBuilder(),
- performRequest.getReleaseManagerListener()
);
+ReleaseDescriptorBuilder builder =
+loadReleaseDescriptorBuilder(
performRequest.getReleaseDescriptorBuilder(),
+
performRequest.getReleaseManagerListener() );
if ( specificProfiles != null && !specificProfiles.isEmpty() )
{
+List allProfiles = new ArrayList<>();
Review comment:
Yes I remember the discussion. @rfscholte you wanted by design that the
state of descriptor is immutable
([link](https://github.com/apache/maven-release/pull/56#discussion_r427064656)).
The test case use a new arraylist that is mutable but this is not at
runtime. I know because we was forced to fork this repo and make our version of
release plugin with a issue (1 year ago!).
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Commented] (MPMD-290) Add CPD example for C#
[ https://issues.apache.org/jira/browse/MPMD-290?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17215345#comment-17215345 ] Andreas Dangel commented on MPMD-290: - Fixed with [597d4cb712|https://gitbox.apache.org/repos/asf?p=maven-pmd-plugin.git;a=commit;h=597d4cb712cf63a17daf67e6f0c0516fe1643e69] > Add CPD example for C# > -- > > Key: MPMD-290 > URL: https://issues.apache.org/jira/browse/MPMD-290 > Project: Maven PMD Plugin > Issue Type: Improvement > Components: CPD >Affects Versions: 3.12.0 >Reporter: QualiteSys QualiteSys >Assignee: Andreas Dangel >Priority: Major > Fix For: 3.14.0 > > > I wish to analyze C# source code with CPD, with no success > Looking to the CpdReport.java MOJO, it seams that the language is not > extracted from either the pom.xml file or the CLI options. > Line 76 : > @Parameter( defaultValue = "java" ) > private String language; > property = "language" is missing, so the language is always forced to java > Is it possible to fix this bug, and add the missing languages CPD is > supporting ? > Thanks > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Resolved] (MPMD-290) Add CPD example for C#
[ https://issues.apache.org/jira/browse/MPMD-290?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andreas Dangel resolved MPMD-290. - Resolution: Fixed > Add CPD example for C# > -- > > Key: MPMD-290 > URL: https://issues.apache.org/jira/browse/MPMD-290 > Project: Maven PMD Plugin > Issue Type: Improvement > Components: CPD >Affects Versions: 3.12.0 >Reporter: QualiteSys QualiteSys >Assignee: Andreas Dangel >Priority: Major > Fix For: 3.14.0 > > > I wish to analyze C# source code with CPD, with no success > Looking to the CpdReport.java MOJO, it seams that the language is not > extracted from either the pom.xml file or the CLI options. > Line 76 : > @Parameter( defaultValue = "java" ) > private String language; > property = "language" is missing, so the language is always forced to java > Is it possible to fix this bug, and add the missing languages CPD is > supporting ? > Thanks > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Resolved] (MPMD-304) maven-pmd-plugin should be toolchains-aware
[ https://issues.apache.org/jira/browse/MPMD-304?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andreas Dangel resolved MPMD-304. - Resolution: Fixed > maven-pmd-plugin should be toolchains-aware > --- > > Key: MPMD-304 > URL: https://issues.apache.org/jira/browse/MPMD-304 > Project: Maven PMD Plugin > Issue Type: Improvement > Components: CPD, PMD >Affects Versions: 3.13.0 > Environment: maven 3.6.3 > JDK 1.8 (maven) > JDK 11 (toolchains.xml) >Reporter: Ed Randall >Assignee: Andreas Dangel >Priority: Major > Fix For: 3.14.0 > > > maven-pmd-plugin should be > [toolchains-aware|https://maven.apache.org/guides/mini/guide-using-toolchains.html] > and pick up the correct JDK used for compilation. If toolchains is in use, > it should select that one, not use the same JDK that maven is running. > > We have an enterprise build system which runs maven under JDK 1.8. Some > projects target 1.8, others target 11. The switch is handled using > toolchains.xml. > PMD seemingly cannot cope with 11 code when maven is running under 1.8. We > are forced to set `pmd.typeResolution=false` to avoid all sorts of strange > errors (eg. 'unused private method' despite it being used 28 times in the > same class). > We do have `targetJdk=11`. > These false errors do not occur when maven itself runs under JDK 11, with > `pmd.typeResolution=true`. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (MPMD-304) maven-pmd-plugin should be toolchains-aware
[ https://issues.apache.org/jira/browse/MPMD-304?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17215346#comment-17215346 ] Andreas Dangel commented on MPMD-304: - Fixed with [f39c0018e6|https://gitbox.apache.org/repos/asf?p=maven-pmd-plugin.git;a=commit;h=f39c0018e622e6c12a3a3df3a2a92bfb0ceeab44] > maven-pmd-plugin should be toolchains-aware > --- > > Key: MPMD-304 > URL: https://issues.apache.org/jira/browse/MPMD-304 > Project: Maven PMD Plugin > Issue Type: Improvement > Components: CPD, PMD >Affects Versions: 3.13.0 > Environment: maven 3.6.3 > JDK 1.8 (maven) > JDK 11 (toolchains.xml) >Reporter: Ed Randall >Assignee: Andreas Dangel >Priority: Major > Fix For: 3.14.0 > > > maven-pmd-plugin should be > [toolchains-aware|https://maven.apache.org/guides/mini/guide-using-toolchains.html] > and pick up the correct JDK used for compilation. If toolchains is in use, > it should select that one, not use the same JDK that maven is running. > > We have an enterprise build system which runs maven under JDK 1.8. Some > projects target 1.8, others target 11. The switch is handled using > toolchains.xml. > PMD seemingly cannot cope with 11 code when maven is running under 1.8. We > are forced to set `pmd.typeResolution=false` to avoid all sorts of strange > errors (eg. 'unused private method' despite it being used 28 times in the > same class). > We do have `targetJdk=11`. > These false errors do not occur when maven itself runs under JDK 11, with > `pmd.typeResolution=true`. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [maven-pmd-plugin] adangel closed pull request #31: [MPMD-304] - maven-pmd-plugin should be toolchains-aware
adangel closed pull request #31: URL: https://github.com/apache/maven-pmd-plugin/pull/31 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-pmd-plugin] adangel closed pull request #32: [MPMD-290] - Add integration test for CPD for C#
adangel closed pull request #32: URL: https://github.com/apache/maven-pmd-plugin/pull/32 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (MPMD-290) Add CPD example for C#
[ https://issues.apache.org/jira/browse/MPMD-290?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andreas Dangel updated MPMD-290: Issue Type: Improvement (was: Bug) > Add CPD example for C# > -- > > Key: MPMD-290 > URL: https://issues.apache.org/jira/browse/MPMD-290 > Project: Maven PMD Plugin > Issue Type: Improvement > Components: CPD >Affects Versions: 3.12.0 >Reporter: QualiteSys QualiteSys >Assignee: Andreas Dangel >Priority: Major > Fix For: 3.14.0 > > > I wish to analyze C# source code with CPD, with no success > Looking to the CpdReport.java MOJO, it seams that the language is not > extracted from either the pom.xml file or the CLI options. > Line 76 : > @Parameter( defaultValue = "java" ) > private String language; > property = "language" is missing, so the language is always forced to java > Is it possible to fix this bug, and add the missing languages CPD is > supporting ? > Thanks > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (MPMD-290) Add CPD example for C#
[ https://issues.apache.org/jira/browse/MPMD-290?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andreas Dangel updated MPMD-290: Summary: Add CPD example for C# (was: CPD ignores the specified language) > Add CPD example for C# > -- > > Key: MPMD-290 > URL: https://issues.apache.org/jira/browse/MPMD-290 > Project: Maven PMD Plugin > Issue Type: Bug > Components: CPD >Affects Versions: 3.12.0 >Reporter: QualiteSys QualiteSys >Assignee: Andreas Dangel >Priority: Major > Fix For: 3.14.0 > > > I wish to analyze C# source code with CPD, with no success > Looking to the CpdReport.java MOJO, it seams that the language is not > extracted from either the pom.xml file or the CLI options. > Line 76 : > @Parameter( defaultValue = "java" ) > private String language; > property = "language" is missing, so the language is always forced to java > Is it possible to fix this bug, and add the missing languages CPD is > supporting ? > Thanks > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (MDEP-725) excludeGroupIds, excludeArtifactIds not working for go-offline goal
[ https://issues.apache.org/jira/browse/MDEP-725?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17215318#comment-17215318 ] Robert Scholte commented on MDEP-725: - [~mthmulders] there's no need to exclude reactor modules anymore, right? > excludeGroupIds, excludeArtifactIds not working for go-offline goal > --- > > Key: MDEP-725 > URL: https://issues.apache.org/jira/browse/MDEP-725 > Project: Maven Dependency Plugin > Issue Type: Bug > Components: go-offline >Affects Versions: 3.1.2 >Reporter: Mahmoud Anouti >Priority: Major > > When applying -DexcludeGroupIds or -DexcludeArtifactIds to exclude project > dependencies from resolution, they still get resolved and downloaded by > `go-offline`: > mvn dependency:go-offline -DexcludeArtifactIds=example-core > > [INFO] — maven-dependency-plugin:3.1.1:go-offline (default-cli) @ > rest-example — > ... > [INFO] Resolved: example-core-1.0.jar > Also reported in > [https://stackoverflow.com/questions/51113813/mvn-dependencygo-offline-how-do-you-set-params-on-the-command-line-or-at-all] > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [maven-release] bguerin commented on a change in pull request #56: [MRELEASE-1042] releaseProfiles get overriden by activeProfiles
bguerin commented on a change in pull request #56:
URL: https://github.com/apache/maven-release/pull/56#discussion_r506256133
##
File path:
maven-release-manager/src/main/java/org/apache/maven/shared/release/DefaultReleaseManager.java
##
@@ -304,21 +305,26 @@ private void perform( ReleasePerformRequest
performRequest, ReleaseResult result
ReleaseUtils.buildReleaseDescriptor(
performRequest.getReleaseDescriptorBuilder() )
.getActivateProfiles();
-ReleaseDescriptor releaseDescriptor =
-loadReleaseDescriptor(
performRequest.getReleaseDescriptorBuilder(),
- performRequest.getReleaseManagerListener()
);
+ReleaseDescriptorBuilder builder =
+loadReleaseDescriptorBuilder(
performRequest.getReleaseDescriptorBuilder(),
+
performRequest.getReleaseManagerListener() );
if ( specificProfiles != null && !specificProfiles.isEmpty() )
{
+List allProfiles = new ArrayList<>();
Review comment:
Some background is in
https://issues.apache.org/jira/browse/MRELEASE-1042 also ...
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [maven-release] bguerin commented on a change in pull request #56: [MRELEASE-1042] releaseProfiles get overriden by activeProfiles
bguerin commented on a change in pull request #56:
URL: https://github.com/apache/maven-release/pull/56#discussion_r506256133
##
File path:
maven-release-manager/src/main/java/org/apache/maven/shared/release/DefaultReleaseManager.java
##
@@ -304,21 +305,26 @@ private void perform( ReleasePerformRequest
performRequest, ReleaseResult result
ReleaseUtils.buildReleaseDescriptor(
performRequest.getReleaseDescriptorBuilder() )
.getActivateProfiles();
-ReleaseDescriptor releaseDescriptor =
-loadReleaseDescriptor(
performRequest.getReleaseDescriptorBuilder(),
- performRequest.getReleaseManagerListener()
);
+ReleaseDescriptorBuilder builder =
+loadReleaseDescriptorBuilder(
performRequest.getReleaseDescriptorBuilder(),
+
performRequest.getReleaseManagerListener() );
if ( specificProfiles != null && !specificProfiles.isEmpty() )
{
+List allProfiles = new ArrayList<>();
Review comment:
Some backgroud is in https://issues.apache.org/jira/browse/MRELEASE-1042
also ...
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [maven-release] bguerin commented on a change in pull request #56: [MRELEASE-1042] releaseProfiles get overriden by activeProfiles
bguerin commented on a change in pull request #56:
URL: https://github.com/apache/maven-release/pull/56#discussion_r506255109
##
File path:
maven-release-manager/src/main/java/org/apache/maven/shared/release/DefaultReleaseManager.java
##
@@ -304,21 +305,26 @@ private void perform( ReleasePerformRequest
performRequest, ReleaseResult result
ReleaseUtils.buildReleaseDescriptor(
performRequest.getReleaseDescriptorBuilder() )
.getActivateProfiles();
-ReleaseDescriptor releaseDescriptor =
-loadReleaseDescriptor(
performRequest.getReleaseDescriptorBuilder(),
- performRequest.getReleaseManagerListener()
);
+ReleaseDescriptorBuilder builder =
+loadReleaseDescriptorBuilder(
performRequest.getReleaseDescriptorBuilder(),
+
performRequest.getReleaseManagerListener() );
if ( specificProfiles != null && !specificProfiles.isEmpty() )
{
+List allProfiles = new ArrayList<>();
Review comment:
the current build is green because of the `new ArrayList( ... )` in the
unit test :
```secondBuilder.setActivateProfiles( new ArrayList(
Arrays.asList("aProfile", "bProfile") ) );```
Remove it and the build will become red. And IT WAS a MISTAKE to add it, it
is false comparing to what happens when using the plugin
This PR fix the code so that this `new ArrayList( ... )` is not needed
anymore, and the unit test is representative of the plugin usage
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Closed] (MDEP-707) Upgrade maven-dependency-analyzer to 1.11.2
[ https://issues.apache.org/jira/browse/MDEP-707?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Scholte closed MDEP-707. --- Fix Version/s: (was: 3.1.3) 3.1.2 Assignee: Elliotte Rusty Harold Resolution: Fixed Fixed in [af98e585a57d5405902b32a722f91a2073971cd5|https://gitbox.apache.org/repos/asf?p=maven-dependency-plugin.git;a=commit;h=af98e585a57d5405902b32a722f91a2073971cd5] > Upgrade maven-dependency-analyzer to 1.11.2 > --- > > Key: MDEP-707 > URL: https://issues.apache.org/jira/browse/MDEP-707 > Project: Maven Dependency Plugin > Issue Type: Dependency upgrade > Components: analyze >Affects Versions: 3.1.2 >Reporter: Andreas Dangel >Assignee: Elliotte Rusty Harold >Priority: Major > Fix For: 3.1.2 > > > In order to analyze projects with newer java versions, MSHARED-870 needs to > be completed. > Just updating asm version (as in MDEP-682) is not enough. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (MDEP-707) Upgrade maven-dependency-analyzer to 1.11.3
[ https://issues.apache.org/jira/browse/MDEP-707?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Scholte updated MDEP-707: Summary: Upgrade maven-dependency-analyzer to 1.11.3 (was: Upgrade maven-dependency-analyzer to 1.11.2) > Upgrade maven-dependency-analyzer to 1.11.3 > --- > > Key: MDEP-707 > URL: https://issues.apache.org/jira/browse/MDEP-707 > Project: Maven Dependency Plugin > Issue Type: Dependency upgrade > Components: analyze >Affects Versions: 3.1.2 >Reporter: Andreas Dangel >Assignee: Elliotte Rusty Harold >Priority: Major > Fix For: 3.1.2 > > > In order to analyze projects with newer java versions, MSHARED-870 needs to > be completed. > Just updating asm version (as in MDEP-682) is not enough. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [maven-release] rfscholte commented on a change in pull request #56: [MRELEASE-1042] releaseProfiles get overriden by activeProfiles
rfscholte commented on a change in pull request #56:
URL: https://github.com/apache/maven-release/pull/56#discussion_r506198790
##
File path:
maven-release-manager/src/main/java/org/apache/maven/shared/release/DefaultReleaseManager.java
##
@@ -304,21 +305,26 @@ private void perform( ReleasePerformRequest
performRequest, ReleaseResult result
ReleaseUtils.buildReleaseDescriptor(
performRequest.getReleaseDescriptorBuilder() )
.getActivateProfiles();
-ReleaseDescriptor releaseDescriptor =
-loadReleaseDescriptor(
performRequest.getReleaseDescriptorBuilder(),
- performRequest.getReleaseManagerListener()
);
+ReleaseDescriptorBuilder builder =
+loadReleaseDescriptorBuilder(
performRequest.getReleaseDescriptorBuilder(),
+
performRequest.getReleaseManagerListener() );
if ( specificProfiles != null && !specificProfiles.isEmpty() )
{
+List allProfiles = new ArrayList<>();
Review comment:
But if the current build is green, then there is no need to merge this.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [maven-resolver] michael-o commented on pull request #75: Remove unused parameters and local variables
michael-o commented on pull request #75: URL: https://github.com/apache/maven-resolver/pull/75#issuecomment-709920357 Will do later this day. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-release] bguerin commented on a change in pull request #56: [MRELEASE-1042] releaseProfiles get overriden by activeProfiles
bguerin commented on a change in pull request #56:
URL: https://github.com/apache/maven-release/pull/56#discussion_r506185320
##
File path:
maven-release-manager/src/main/java/org/apache/maven/shared/release/DefaultReleaseManager.java
##
@@ -304,21 +305,26 @@ private void perform( ReleasePerformRequest
performRequest, ReleaseResult result
ReleaseUtils.buildReleaseDescriptor(
performRequest.getReleaseDescriptorBuilder() )
.getActivateProfiles();
-ReleaseDescriptor releaseDescriptor =
-loadReleaseDescriptor(
performRequest.getReleaseDescriptorBuilder(),
- performRequest.getReleaseManagerListener()
);
+ReleaseDescriptorBuilder builder =
+loadReleaseDescriptorBuilder(
performRequest.getReleaseDescriptorBuilder(),
+
performRequest.getReleaseManagerListener() );
if ( specificProfiles != null && !specificProfiles.isEmpty() )
{
+List allProfiles = new ArrayList<>();
Review comment:
once again ... this PR fix my previous one, where a Unit Test WAS ADDED
https://github.com/apache/maven-release/pull/50/files#diff-c4d606c66477b937977eccf603f2f04a7b87f464b7439bcb8e4576307792ff2cR709
and this PR changes a little bit this test
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Created] (SUREFIRE-1854) Support include/exclude junit test engine
Adam created SUREFIRE-1854: -- Summary: Support include/exclude junit test engine Key: SUREFIRE-1854 URL: https://issues.apache.org/jira/browse/SUREFIRE-1854 Project: Maven Surefire Issue Type: New Feature Components: JUnit 5.x support, Maven Surefire Plugin Affects Versions: 2.22.2 Reporter: Adam It could be very important for my project to support include/exclude junit test engine by Maven Surefire Plugin. Junit Console Launcher have existing support for this: [https://junit.org/junit5/docs/current/user-guide/#running-tests-console-launcher-options] Similar solution exists for Gradle: https://junit.org/junit5/docs/current/user-guide/#running-tests-build-gradle -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (MNGSITE-388) Need to change "property" to "system property" in POM Reference
[ https://issues.apache.org/jira/browse/MNGSITE-388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17215265#comment-17215265 ] Hudson commented on MNGSITE-388: Build succeeded in Jenkins: Maven » Maven TLP » maven-site » master #66 See https://ci-builds.apache.org/job/Maven/job/maven-box/job/maven-site/job/master/66/ > Need to change "property" to "system property" in POM Reference > --- > > Key: MNGSITE-388 > URL: https://issues.apache.org/jira/browse/MNGSITE-388 > Project: Maven Project Web Site > Issue Type: Bug >Reporter: Jiahongchao >Priority: Minor > Time Spent: 20m > Remaining Estimate: 0h > > In "Profiles" section, it says "The profile will activate if Maven detects a > property". > > I think it's better to change "property" to "system property" since project > property can not activate profile -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [maven-release] rfscholte commented on a change in pull request #56: [MRELEASE-1042] releaseProfiles get overriden by activeProfiles
rfscholte commented on a change in pull request #56:
URL: https://github.com/apache/maven-release/pull/56#discussion_r506167903
##
File path:
maven-release-manager/src/main/java/org/apache/maven/shared/release/DefaultReleaseManager.java
##
@@ -304,21 +305,26 @@ private void perform( ReleasePerformRequest
performRequest, ReleaseResult result
ReleaseUtils.buildReleaseDescriptor(
performRequest.getReleaseDescriptorBuilder() )
.getActivateProfiles();
-ReleaseDescriptor releaseDescriptor =
-loadReleaseDescriptor(
performRequest.getReleaseDescriptorBuilder(),
- performRequest.getReleaseManagerListener()
);
+ReleaseDescriptorBuilder builder =
+loadReleaseDescriptorBuilder(
performRequest.getReleaseDescriptorBuilder(),
+
performRequest.getReleaseManagerListener() );
if ( specificProfiles != null && !specificProfiles.isEmpty() )
{
+List allProfiles = new ArrayList<>();
Review comment:
I guess this part can result is a different set of activated profiles,
but it is not covered by a test. Currently, the build is green and we've seen
issues with profiles before, so we really need a higher code coverage here.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [maven-integration-testing] rfscholte commented on pull request #71: [MNG-6981] Include child projects of projects selected with --pl
rfscholte commented on pull request #71: URL: https://github.com/apache/maven-integration-testing/pull/71#issuecomment-709901869 LGTM This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MNG-6998) POM parser returns jar packaging when pom contains war packaging entry
[ https://issues.apache.org/jira/browse/MNG-6998?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17215254#comment-17215254 ] Michael Osipov commented on MNG-6998: - So am I confused. Please create a sample project which shows the erratic behavior. > POM parser returns jar packaging when pom contains war packaging entry > -- > > Key: MNG-6998 > URL: https://issues.apache.org/jira/browse/MNG-6998 > Project: Maven > Issue Type: Bug > Components: POM >Affects Versions: 3.6.3 > Environment: Windows 10 64 bit, Eclipse Juno Service Release 2, > maven-model-3.6.3.jar >Reporter: Paul C Brown >Priority: Minor > Fix For: waiting-for-feedback > > Attachments: image-2020-10-15-16-36-42-820.png, > image-2020-10-15-16-38-09-442.png > > > The read() method on the MavenXpp3Reader returns a model whose packaging > entry has the value of "jar" when the source document has the value of "war". > Source view: > !image-2020-10-15-16-38-09-442.png! > > Parsed model (output of read() method): > !image-2020-10-15-16-36-42-820.png! -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (MCOMPILER-436) Cannot compile code that depends on on Apache Mina SSH due to JPMS error
[ https://issues.apache.org/jira/browse/MCOMPILER-436?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17215253#comment-17215253 ] Robert Scholte commented on MCOMPILER-436: -- This is just one edge case, there are other cases where the exception is clear enough. [https://github.com/apache/maven-compiler-plugin/blob/master/src/main/java/org/apache/maven/plugin/compiler/CompilerMojo.java#L238-L247] builds the error message. You can't now for sure that the loading of the file was the issue, unless you analyze the exception. I've tried to keep it as simple as possible, but if you think that handling the InvalidModuleDescriptorException deserves a special message, I suggest to provide a PR. > Cannot compile code that depends on on Apache Mina SSH due to JPMS error > > > Key: MCOMPILER-436 > URL: https://issues.apache.org/jira/browse/MCOMPILER-436 > Project: Maven Compiler Plugin > Issue Type: Bug >Affects Versions: 3.8.1 >Reporter: Gili >Priority: Major > Attachments: extract-module-name.zip > > > 1. Extract Testcase > 2. Run "mvn clean install" > 3. Build fails with: > [WARNING] Can't extract module name from sshd-core-2.5.1.jar: Provider class > org.apache.sshd.common.file.root.RootedFileSystemProvider not in module > [ERROR] module not found: sshd.core > Expected behavior: The plugin should be able to extract the module name given > that sshd-core depends on sshd-commons which contains the aforementioned > provider and automatic modules can access classes outside their module. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [maven-resolver] pzygielo commented on pull request #75: Remove unused parameters and local variables
pzygielo commented on pull request #75: URL: https://github.com/apache/maven-resolver/pull/75#issuecomment-709898196 May I ask for review, please? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (MNG-6998) POM parser returns jar packaging when pom contains war packaging entry
[ https://issues.apache.org/jira/browse/MNG-6998?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov updated MNG-6998: Fix Version/s: waiting-for-feedback > POM parser returns jar packaging when pom contains war packaging entry > -- > > Key: MNG-6998 > URL: https://issues.apache.org/jira/browse/MNG-6998 > Project: Maven > Issue Type: Bug > Components: POM >Affects Versions: 3.6.3 > Environment: Windows 10 64 bit, Eclipse Juno Service Release 2, > maven-model-3.6.3.jar >Reporter: Paul C Brown >Priority: Minor > Fix For: waiting-for-feedback > > Attachments: image-2020-10-15-16-36-42-820.png, > image-2020-10-15-16-38-09-442.png > > > The read() method on the MavenXpp3Reader returns a model whose packaging > entry has the value of "jar" when the source document has the value of "war". > Source view: > !image-2020-10-15-16-38-09-442.png! > > Parsed model (output of read() method): > !image-2020-10-15-16-36-42-820.png! -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Closed] (MSHADE-379) Support Java 16 - upgrade ASM to 9.0
[ https://issues.apache.org/jira/browse/MSHADE-379?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sylwester Lachiewicz closed MSHADE-379. --- Resolution: Fixed > Support Java 16 - upgrade ASM to 9.0 > > > Key: MSHADE-379 > URL: https://issues.apache.org/jira/browse/MSHADE-379 > Project: Maven Shade Plugin > Issue Type: Dependency upgrade >Reporter: Sylwester Lachiewicz >Assignee: Sylwester Lachiewicz >Priority: Major > Fix For: 3.3.0 > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Closed] (MNGSITE-388) Need to change "property" to "system property" in POM Reference
[ https://issues.apache.org/jira/browse/MNGSITE-388?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sylwester Lachiewicz closed MNGSITE-388. Resolution: Fixed > Need to change "property" to "system property" in POM Reference > --- > > Key: MNGSITE-388 > URL: https://issues.apache.org/jira/browse/MNGSITE-388 > Project: Maven Project Web Site > Issue Type: Bug >Reporter: Jiahongchao >Priority: Minor > Time Spent: 20m > Remaining Estimate: 0h > > In "Profiles" section, it says "The profile will activate if Maven detects a > property". > > I think it's better to change "property" to "system property" since project > property can not activate profile -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [maven-release] bguerin commented on pull request #56: [MRELEASE-1042] releaseProfiles get overriden by activeProfiles
bguerin commented on pull request #56: URL: https://github.com/apache/maven-release/pull/56#issuecomment-709878608 Hello, Any chance to get this merged ? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MNGSITE-430) Clarify remote repository resolution order
[
https://issues.apache.org/jira/browse/MNGSITE-430?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17215213#comment-17215213
]
Hudson commented on MNGSITE-430:
Build succeeded in Jenkins: Maven » Maven TLP » maven-site » master #65
See
https://ci-builds.apache.org/job/Maven/job/maven-box/job/maven-site/job/master/65/
> Clarify remote repository resolution order
> --
>
> Key: MNGSITE-430
> URL: https://issues.apache.org/jira/browse/MNGSITE-430
> Project: Maven Project Web Site
> Issue Type: Improvement
>Reporter: Konrad Windszus
>Assignee: Sylwester Lachiewicz
>Priority: Major
>
> It is possible to declare remote repositories in {{settings.xml}} and
> {{pom.xml}}. While for the {{settings.xml}} it has to be given in a profile,
> for {{pom.xml}} it can be given in the top-level {{repositories}} element as
> well as in profiles. The order in which an artifact is tried to be resolved
> from the different remote repo is sometimes crucial to know (e.g. to speed up
> build times by first checking against remote repos having most of the
> artifacts like Maven Central)
> It would be nice to document this in
> https://maven.apache.org/guides/introduction/introduction-to-repositories.html
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (MCOMPILER-436) Cannot compile code that depends on on Apache Mina SSH due to JPMS error
[ https://issues.apache.org/jira/browse/MCOMPILER-436?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17215209#comment-17215209 ] Gili commented on MCOMPILER-436: [~rfscholte] I see your point but I still feel that the error message is missing an important line of reasoning. >From the perspective of someone who is not familiar with the implementation >details of Java Modules, one would think that you should be able to extract >the module name for the aforementioned case. I mean, there is a well-defined >algorithm for converting the filenames into automatic module names. There is >also an Automatic-Module-Name entry in the manifest file. So from the user's >perspective you have everything you need to extract a module name. What the error message fails to explain is that although we can theoretically extract a module name, we can't in fact load the JAR file as a module. > Cannot compile code that depends on on Apache Mina SSH due to JPMS error > > > Key: MCOMPILER-436 > URL: https://issues.apache.org/jira/browse/MCOMPILER-436 > Project: Maven Compiler Plugin > Issue Type: Bug >Affects Versions: 3.8.1 >Reporter: Gili >Priority: Major > Attachments: extract-module-name.zip > > > 1. Extract Testcase > 2. Run "mvn clean install" > 3. Build fails with: > [WARNING] Can't extract module name from sshd-core-2.5.1.jar: Provider class > org.apache.sshd.common.file.root.RootedFileSystemProvider not in module > [ERROR] module not found: sshd.core > Expected behavior: The plugin should be able to extract the module name given > that sshd-core depends on sshd-commons which contains the aforementioned > provider and automatic modules can access classes outside their module. -- This message was sent by Atlassian Jira (v8.3.4#803005)
