[GitHub] nifi issue #2180: Added GetMongoAggregation to support running Mongo aggrega...
Github user joewitt commented on the issue: https://github.com/apache/nifi/pull/2180 @MikeThomsen just as a headsup we've not forgotten about this. Mattyb picked up the flu thing that seems to be running wild. ---
[jira] [Updated] (NIFI-4515) Enable EL on keytab/principal properties in Kafka processors
[ https://issues.apache.org/jira/browse/NIFI-4515?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joseph Witt updated NIFI-4515: -- Resolution: Fixed Status: Resolved (was: Patch Available) +1 merged to master > Enable EL on keytab/principal properties in Kafka processors > > > Key: NIFI-4515 > URL: https://issues.apache.org/jira/browse/NIFI-4515 > Project: Apache NiFi > Issue Type: Improvement > Components: Extensions >Reporter: Pierre Villard >Assignee: Pierre Villard > Fix For: 1.5.0 > > > Since it's now possible to specify principal and keytab for Kerberos > configuration in Kafka processors (0.10 and 0.11), it'd be useful to enable > EL to ease template promotion between environments when users are relying on > variable registry. > I know there are on-going developments to provide a way to externalize > Kerberos configuration in a controller service object but, in the meantime, > enabling EL on the properties could be appreciated. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (NIFI-4515) Enable EL on keytab/principal properties in Kafka processors
[ https://issues.apache.org/jira/browse/NIFI-4515?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joseph Witt updated NIFI-4515: -- Fix Version/s: 1.5.0 > Enable EL on keytab/principal properties in Kafka processors > > > Key: NIFI-4515 > URL: https://issues.apache.org/jira/browse/NIFI-4515 > Project: Apache NiFi > Issue Type: Improvement > Components: Extensions >Reporter: Pierre Villard >Assignee: Pierre Villard > Fix For: 1.5.0 > > > Since it's now possible to specify principal and keytab for Kerberos > configuration in Kafka processors (0.10 and 0.11), it'd be useful to enable > EL to ease template promotion between environments when users are relying on > variable registry. > I know there are on-going developments to provide a way to externalize > Kerberos configuration in a controller service object but, in the meantime, > enabling EL on the properties could be appreciated. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (NIFI-4515) Enable EL on keytab/principal properties in Kafka processors
[ https://issues.apache.org/jira/browse/NIFI-4515?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16317727#comment-16317727 ] ASF GitHub Bot commented on NIFI-4515: -- Github user asfgit closed the pull request at: https://github.com/apache/nifi/pull/2224 > Enable EL on keytab/principal properties in Kafka processors > > > Key: NIFI-4515 > URL: https://issues.apache.org/jira/browse/NIFI-4515 > Project: Apache NiFi > Issue Type: Improvement > Components: Extensions >Reporter: Pierre Villard >Assignee: Pierre Villard > Fix For: 1.5.0 > > > Since it's now possible to specify principal and keytab for Kerberos > configuration in Kafka processors (0.10 and 0.11), it'd be useful to enable > EL to ease template promotion between environments when users are relying on > variable registry. > I know there are on-going developments to provide a way to externalize > Kerberos configuration in a controller service object but, in the meantime, > enabling EL on the properties could be appreciated. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (NIFI-4515) Enable EL on keytab/principal properties in Kafka processors
[ https://issues.apache.org/jira/browse/NIFI-4515?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16317726#comment-16317726 ] ASF subversion and git services commented on NIFI-4515: --- Commit 10e3b14433fecc91a6f51ab0459adbc8f93f18ad in nifi's branch refs/heads/master from [~pvillard] [ https://git-wip-us.apache.org/repos/asf?p=nifi.git;h=10e3b14 ] NIFI-4515 - This closes #2224. Enabled EL on Kerberos properties for Kafka 0.10 & 0.11 & 1.0 processors Signed-off-by: joewitt> Enable EL on keytab/principal properties in Kafka processors > > > Key: NIFI-4515 > URL: https://issues.apache.org/jira/browse/NIFI-4515 > Project: Apache NiFi > Issue Type: Improvement > Components: Extensions >Reporter: Pierre Villard >Assignee: Pierre Villard > Fix For: 1.5.0 > > > Since it's now possible to specify principal and keytab for Kerberos > configuration in Kafka processors (0.10 and 0.11), it'd be useful to enable > EL to ease template promotion between environments when users are relying on > variable registry. > I know there are on-going developments to provide a way to externalize > Kerberos configuration in a controller service object but, in the meantime, > enabling EL on the properties could be appreciated. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[GitHub] nifi pull request #2224: NIFI-4515 - Enabled EL on Kerberos properties for K...
Github user asfgit closed the pull request at: https://github.com/apache/nifi/pull/2224 ---
[jira] [Commented] (NIFI-4715) ListS3 produces duplicates in frequently updated buckets
[ https://issues.apache.org/jira/browse/NIFI-4715?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16317720#comment-16317720 ] ASF GitHub Bot commented on NIFI-4715: -- Github user ijokarumawak commented on the issue: https://github.com/apache/nifi/pull/2361 @adamlamar How is it going? Looking forward to review the updated PR. Just wanted to check if you have any issues. Thanks! > ListS3 produces duplicates in frequently updated buckets > > > Key: NIFI-4715 > URL: https://issues.apache.org/jira/browse/NIFI-4715 > Project: Apache NiFi > Issue Type: Bug > Components: Core Framework >Affects Versions: 1.2.0, 1.3.0, 1.4.0 > Environment: All >Reporter: Milan Das > Attachments: List-S3-dup-issue.xml, screenshot-1.png > > > ListS3 state is implemented using HashSet. HashSet is not thread safe. When > ListS3 operates in multi threaded mode, sometimes it tries to list same > file from S3 bucket. Seems like HashSet data is getting corrupted. > currentKeys = new HashSet<>(); // need to be implemented Thread Safe like > currentKeys = //ConcurrentHashMap.newKeySet(); > *{color:red}+Update+{color}*: > This is not a HashSet issue: > Root cause is: > When the file gets uploaded to S3 simultaneously when List S3 is in progress. > onTrigger--> maxTimestamp is initiated as 0L. > This is clearing keys as per the code below > When lastModifiedTime on S3 object is same as currentTimestamp for the listed > key it should be skipped. As the key is cleared, it is loading the same file > again. > I think fix should be to initiate the maxTimestamp with currentTimestamp not > 0L. > {code} > long maxTimestamp = currentTimestamp; > {code} > Following block is clearing keys. > {code:title=org.apache.nifi.processors.aws.s3.ListS3.java|borderStyle=solid} > if (lastModified > maxTimestamp) { > maxTimestamp = lastModified; > currentKeys.clear(); > getLogger().debug("clearing keys"); > } > {code} > Update: 01/03/2018 > There is one more flavor of same defect. > Suppose: file1 is modified at 1514987611000 on S3 and currentTimestamp = > 1514987311000 on state. > 1. File will be picked up time current state will be updated to > currentTimestamp=1514987311000 (but OS System time is 1514987611000) > 2. next cycle for file2 with lastmodified: 1514987611000 : keys will be > cleared because lastModified > maxTimeStamp > (=currentTimestamp=1514987311000). > CurrentTimeStamp will saved as 1514987611000 > 3. next cycle: currentTimestamp=1514987611000 , "file1 modified at > 1514987611000" will be picked up again because file1 is no longer in the keys. > I think solution is currentTimeStamp need to persisted current system time > stamp. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[GitHub] nifi issue #2361: NIFI-4715: ListS3 produces duplicates in frequently update...
Github user ijokarumawak commented on the issue: https://github.com/apache/nifi/pull/2361 @adamlamar How is it going? Looking forward to review the updated PR. Just wanted to check if you have any issues. Thanks! ---
[jira] [Updated] (NIFI-4697) PostHTTP: correct documentation
[ https://issues.apache.org/jira/browse/NIFI-4697?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joseph Witt updated NIFI-4697: -- Resolution: Fixed Status: Resolved (was: Patch Available) +1 merged to master > PostHTTP: correct documentation > --- > > Key: NIFI-4697 > URL: https://issues.apache.org/jira/browse/NIFI-4697 > Project: Apache NiFi > Issue Type: Improvement >Affects Versions: 1.4.0 >Reporter: Brandon DeVries >Assignee: Michael Moser >Priority: Minor > Fix For: 1.5.0 > > > The description of the URL property of PostHTTP says > "The URL to POST to. The first part of the URL must be static. However, the > path of the URL may be defined using the Attribute Expression Language. " > This does not appear to be true. We should modify to something like "The URL > to POST to." > ...or, someone can point out to me why I'm wrong in saying it's wrong... -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (NIFI-4697) PostHTTP: correct documentation
[ https://issues.apache.org/jira/browse/NIFI-4697?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16317701#comment-16317701 ] ASF subversion and git services commented on NIFI-4697: --- Commit 6e7544bd3786fa829fedf1e284488e6756664f2c in nifi's branch refs/heads/master from [~boardm26] [ https://git-wip-us.apache.org/repos/asf?p=nifi.git;h=6e7544b ] NIFI-4697 This closes #2381. clarified some PostHTTP documentation Signed-off-by: joewitt> PostHTTP: correct documentation > --- > > Key: NIFI-4697 > URL: https://issues.apache.org/jira/browse/NIFI-4697 > Project: Apache NiFi > Issue Type: Improvement >Affects Versions: 1.4.0 >Reporter: Brandon DeVries >Assignee: Michael Moser >Priority: Minor > Fix For: 1.5.0 > > > The description of the URL property of PostHTTP says > "The URL to POST to. The first part of the URL must be static. However, the > path of the URL may be defined using the Attribute Expression Language. " > This does not appear to be true. We should modify to something like "The URL > to POST to." > ...or, someone can point out to me why I'm wrong in saying it's wrong... -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (NIFI-4697) PostHTTP: correct documentation
[ https://issues.apache.org/jira/browse/NIFI-4697?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16317702#comment-16317702 ] ASF GitHub Bot commented on NIFI-4697: -- Github user asfgit closed the pull request at: https://github.com/apache/nifi/pull/2381 > PostHTTP: correct documentation > --- > > Key: NIFI-4697 > URL: https://issues.apache.org/jira/browse/NIFI-4697 > Project: Apache NiFi > Issue Type: Improvement >Affects Versions: 1.4.0 >Reporter: Brandon DeVries >Assignee: Michael Moser >Priority: Minor > Fix For: 1.5.0 > > > The description of the URL property of PostHTTP says > "The URL to POST to. The first part of the URL must be static. However, the > path of the URL may be defined using the Attribute Expression Language. " > This does not appear to be true. We should modify to something like "The URL > to POST to." > ...or, someone can point out to me why I'm wrong in saying it's wrong... -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[GitHub] nifi pull request #2381: NIFI-4697 clarified some PostHTTP documentation
Github user asfgit closed the pull request at: https://github.com/apache/nifi/pull/2381 ---
[jira] [Updated] (NIFI-4708) Add support for NiFi Registry to the encrypt-config tool in NiFi Toolkit
[ https://issues.apache.org/jira/browse/NIFI-4708?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joseph Witt updated NIFI-4708: -- Resolution: Fixed Status: Resolved (was: Patch Available) +1 merged to master. Travis-CI and local builds good again. thanks > Add support for NiFi Registry to the encrypt-config tool in NiFi Toolkit > > > Key: NIFI-4708 > URL: https://issues.apache.org/jira/browse/NIFI-4708 > Project: Apache NiFi > Issue Type: Improvement >Reporter: Kevin Doran >Assignee: Kevin Doran > Fix For: 1.5.0 > > > NiFi Registry now supports loading encrypted config files (e.g., > nifi-registry.properties, authorizers.xml, login-identity-providers.xml). > These files are very difficult to encrypt by hand, and is not recommended. > Because NiFi Registry utilizes the same encryption algorithms supported by > NiFi, the easiest way to build a tool for encrypting NiFi Registry config > properties is to extend the the encrypt-config tool in NiFi Toolkit to > support NiFi Registry as well. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (NIFI-4708) Add support for NiFi Registry to the encrypt-config tool in NiFi Toolkit
[ https://issues.apache.org/jira/browse/NIFI-4708?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16317696#comment-16317696 ] ASF GitHub Bot commented on NIFI-4708: -- Github user asfgit closed the pull request at: https://github.com/apache/nifi/pull/2389 > Add support for NiFi Registry to the encrypt-config tool in NiFi Toolkit > > > Key: NIFI-4708 > URL: https://issues.apache.org/jira/browse/NIFI-4708 > Project: Apache NiFi > Issue Type: Improvement >Reporter: Kevin Doran >Assignee: Kevin Doran > Fix For: 1.5.0 > > > NiFi Registry now supports loading encrypted config files (e.g., > nifi-registry.properties, authorizers.xml, login-identity-providers.xml). > These files are very difficult to encrypt by hand, and is not recommended. > Because NiFi Registry utilizes the same encryption algorithms supported by > NiFi, the easiest way to build a tool for encrypting NiFi Registry config > properties is to extend the the encrypt-config tool in NiFi Toolkit to > support NiFi Registry as well. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (NIFI-4747) GetHDFS Scheduling via CRON shows an error before it is scheduled
[ https://issues.apache.org/jira/browse/NIFI-4747?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16317694#comment-16317694 ] Pierre Villard commented on NIFI-4747: -- Yes, agree [~joewitt]. [~jugi], do you want to submit a PR for that? If not, I can probably have something later this week. > GetHDFS Scheduling via CRON shows an error before it is scheduled > - > > Key: NIFI-4747 > URL: https://issues.apache.org/jira/browse/NIFI-4747 > Project: Apache NiFi > Issue Type: Bug > Components: Core Framework >Affects Versions: 1.2.0, 1.4.0 > Environment: Linux, Windows >Reporter: Julian Gimbel >Priority: Blocker > Attachments: gethdfs_cron_scheduling.PNG, > gethdfs_cron_scheduling_error.png > > > We schedule a getHDFS Processor CRON driven at "0 0 15 * * ?" so that it > should run at 15:00:00 every day. If we start the processor it gives an error > message even before CRON should have triggered the Processor as shown below. > The question is why that is happening and how can it be fixed? > 2018-01-08 14:43:01,242 ERROR [StandardProcessScheduler Thread-5] > o.a.n.controller.StandardProcessorNode Failed to invoke @OnScheduled method > due to java.lang.RuntimeException: Failed while executing one of processor's > OnScheduled task. > java.lang.RuntimeException: Failed while executing one of processor's > OnScheduled task. > at > org.apache.nifi.controller.StandardProcessorNode.invokeTaskAsCancelableFuture(StandardProcessorNode.java:1483) > at > org.apache.nifi.controller.StandardProcessorNode.access$000(StandardProcessorNode.java:103) > at > org.apache.nifi.controller.StandardProcessorNode$1.run(StandardProcessorNode.java:1302) > at > java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511) > at java.util.concurrent.FutureTask.run(FutureTask.java:266) > at > java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.access$201(ScheduledThreadPoolExecutor.java:180) > at > java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:293) > at > java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142) > at > java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617) > at java.lang.Thread.run(Thread.java:745) > Caused by: java.util.concurrent.ExecutionException: > java.lang.reflect.InvocationTargetException > at java.util.concurrent.FutureTask.report(FutureTask.java:122) > at java.util.concurrent.FutureTask.get(FutureTask.java:206) > at > org.apache.nifi.controller.StandardProcessorNode.invokeTaskAsCancelableFuture(StandardProcessorNode.java:1466) > ... 9 common frames omitted > Caused by: java.lang.reflect.InvocationTargetException: null > at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) > at > sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) > at > sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) > at java.lang.reflect.Method.invoke(Method.java:498) > at > org.apache.nifi.util.ReflectionUtils.invokeMethodsWithAnnotations(ReflectionUtils.java:137) > at > org.apache.nifi.util.ReflectionUtils.invokeMethodsWithAnnotations(ReflectionUtils.java:125) > at > org.apache.nifi.util.ReflectionUtils.invokeMethodsWithAnnotations(ReflectionUtils.java:70) > at > org.apache.nifi.util.ReflectionUtils.invokeMethodsWithAnnotation(ReflectionUtils.java:47) > at > org.apache.nifi.controller.StandardProcessorNode$1$1.call(StandardProcessorNode.java:1306) > at > org.apache.nifi.controller.StandardProcessorNode$1$1.call(StandardProcessorNode.java:1302) > ... 6 common frames omitted > Caused by: java.io.IOException: PropertyDescriptor > PropertyDescriptor[Directory] has invalid value > /nifi/pele/pele2rtdp/20180108. The directory does not exist. > at > org.apache.nifi.processors.hadoop.GetHDFS.onScheduled(GetHDFS.java:242) -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (NIFI-4708) Add support for NiFi Registry to the encrypt-config tool in NiFi Toolkit
[ https://issues.apache.org/jira/browse/NIFI-4708?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16317695#comment-16317695 ] ASF subversion and git services commented on NIFI-4708: --- Commit 182e2c6e94a4b1f225ff1902f048e9cb5c3c400c in nifi's branch refs/heads/master from [~kdoran] [ https://git-wip-us.apache.org/repos/asf?p=nifi.git;h=182e2c6 ] NIFI-4708 This closes #2389. Fixes encrypt-config log4j configuration Signed-off-by: joewitt> Add support for NiFi Registry to the encrypt-config tool in NiFi Toolkit > > > Key: NIFI-4708 > URL: https://issues.apache.org/jira/browse/NIFI-4708 > Project: Apache NiFi > Issue Type: Improvement >Reporter: Kevin Doran >Assignee: Kevin Doran > Fix For: 1.5.0 > > > NiFi Registry now supports loading encrypted config files (e.g., > nifi-registry.properties, authorizers.xml, login-identity-providers.xml). > These files are very difficult to encrypt by hand, and is not recommended. > Because NiFi Registry utilizes the same encryption algorithms supported by > NiFi, the easiest way to build a tool for encrypting NiFi Registry config > properties is to extend the the encrypt-config tool in NiFi Toolkit to > support NiFi Registry as well. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[GitHub] nifi pull request #2389: NIFI-4708 Fixes encrypt-config log4j configuration
Github user asfgit closed the pull request at: https://github.com/apache/nifi/pull/2389 ---
[jira] [Commented] (NIFI-4751) Release Management for Apache NiFi 1.5.0 RC
[ https://issues.apache.org/jira/browse/NIFI-4751?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16317675#comment-16317675 ] ASF subversion and git services commented on NIFI-4751: --- Commit 3157b00a7a4c2e85cf109f833e9603919812717f in nifi's branch refs/heads/master from [~joewitt] [ https://git-wip-us.apache.org/repos/asf?p=nifi.git;h=3157b00 ] NIFI-4751 correcting extranous NOTICE entries for MIT License and fixed the cassandra nar LandN > Release Management for Apache NiFi 1.5.0 RC > --- > > Key: NIFI-4751 > URL: https://issues.apache.org/jira/browse/NIFI-4751 > Project: Apache NiFi > Issue Type: Bug > Components: Tools and Build >Affects Versions: 1.5.0 >Reporter: Joseph Witt >Assignee: Joseph Witt > Fix For: 1.5.0 > > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (NIFI-4708) Add support for NiFi Registry to the encrypt-config tool in NiFi Toolkit
[ https://issues.apache.org/jira/browse/NIFI-4708?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kevin Doran updated NIFI-4708: -- Status: Patch Available (was: Reopened) > Add support for NiFi Registry to the encrypt-config tool in NiFi Toolkit > > > Key: NIFI-4708 > URL: https://issues.apache.org/jira/browse/NIFI-4708 > Project: Apache NiFi > Issue Type: Improvement >Reporter: Kevin Doran >Assignee: Kevin Doran > Fix For: 1.5.0 > > > NiFi Registry now supports loading encrypted config files (e.g., > nifi-registry.properties, authorizers.xml, login-identity-providers.xml). > These files are very difficult to encrypt by hand, and is not recommended. > Because NiFi Registry utilizes the same encryption algorithms supported by > NiFi, the easiest way to build a tool for encrypting NiFi Registry config > properties is to extend the the encrypt-config tool in NiFi Toolkit to > support NiFi Registry as well. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (NIFI-4726) Concurrency issue with JoltTransformJson
[ https://issues.apache.org/jira/browse/NIFI-4726?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16317665#comment-16317665 ] ASF GitHub Bot commented on NIFI-4726: -- Github user joewitt commented on a diff in the pull request: https://github.com/apache/nifi/pull/2363#discussion_r160315696 --- Diff: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/util/JsonUtilsPool.java --- @@ -0,0 +1,87 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.nifi.processors.standard.util; + +import com.bazaarvoice.jolt.JsonUtil; +import com.bazaarvoice.jolt.JsonUtilImpl; +import org.apache.commons.pool.PoolableObjectFactory; +import org.apache.commons.pool.impl.GenericObjectPool; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; + +public class JsonUtilsPool { +private final static Logger LOG = LoggerFactory.getLogger(JsonUtilsPool.class); +static private GenericObjectPool pool; --- End diff -- dont believe we would want a static pool instance. We can just make the pool a member of the processor. > Concurrency issue with JoltTransformJson > > > Key: NIFI-4726 > URL: https://issues.apache.org/jira/browse/NIFI-4726 > Project: Apache NiFi > Issue Type: Bug >Reporter: Marco Gaido >Assignee: Marco Gaido > Fix For: 1.5.0 > > > JoltTransformJson uses under the hood Jackson to parse JSONs. On heavy > multithreading workloads, Jackson can have concurrency problem, as also > described in this Stackoverflow thread > https://stackoverflow.com/questions/17924865/jsonmappingexception-was-java-lang-arrayindexoutofboundsexception. > This can cause all the parsing to fail when this problem occurs. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[GitHub] nifi pull request #2363: NIFI-4726: Avoid concurrency issues in JoltTransfor...
Github user joewitt commented on a diff in the pull request: https://github.com/apache/nifi/pull/2363#discussion_r160315696 --- Diff: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/util/JsonUtilsPool.java --- @@ -0,0 +1,87 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.nifi.processors.standard.util; + +import com.bazaarvoice.jolt.JsonUtil; +import com.bazaarvoice.jolt.JsonUtilImpl; +import org.apache.commons.pool.PoolableObjectFactory; +import org.apache.commons.pool.impl.GenericObjectPool; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; + +public class JsonUtilsPool { +private final static Logger LOG = LoggerFactory.getLogger(JsonUtilsPool.class); +static private GenericObjectPool pool; --- End diff -- dont believe we would want a static pool instance. We can just make the pool a member of the processor. ---
[GitHub] nifi issue #2363: NIFI-4726: Avoid concurrency issues in JoltTransformJSON
Github user joewitt commented on the issue: https://github.com/apache/nifi/pull/2363 Based on Koji's findings for the JIRA this appears to be resolved already by upgrading dependencies. I recommend we close this @mgaido91 ---
[jira] [Commented] (NIFI-4726) Concurrency issue with JoltTransformJson
[ https://issues.apache.org/jira/browse/NIFI-4726?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16317663#comment-16317663 ] ASF GitHub Bot commented on NIFI-4726: -- Github user joewitt commented on the issue: https://github.com/apache/nifi/pull/2363 Based on Koji's findings for the JIRA this appears to be resolved already by upgrading dependencies. I recommend we close this @mgaido91 > Concurrency issue with JoltTransformJson > > > Key: NIFI-4726 > URL: https://issues.apache.org/jira/browse/NIFI-4726 > Project: Apache NiFi > Issue Type: Bug >Reporter: Marco Gaido >Assignee: Marco Gaido > Fix For: 1.5.0 > > > JoltTransformJson uses under the hood Jackson to parse JSONs. On heavy > multithreading workloads, Jackson can have concurrency problem, as also > described in this Stackoverflow thread > https://stackoverflow.com/questions/17924865/jsonmappingexception-was-java-lang-arrayindexoutofboundsexception. > This can cause all the parsing to fail when this problem occurs. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (NIFI-4726) Concurrency issue with JoltTransformJson
[ https://issues.apache.org/jira/browse/NIFI-4726?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joseph Witt updated NIFI-4726: -- Resolution: Fixed Status: Resolved (was: Patch Available) > Concurrency issue with JoltTransformJson > > > Key: NIFI-4726 > URL: https://issues.apache.org/jira/browse/NIFI-4726 > Project: Apache NiFi > Issue Type: Bug >Reporter: Marco Gaido >Assignee: Marco Gaido > > JoltTransformJson uses under the hood Jackson to parse JSONs. On heavy > multithreading workloads, Jackson can have concurrency problem, as also > described in this Stackoverflow thread > https://stackoverflow.com/questions/17924865/jsonmappingexception-was-java-lang-arrayindexoutofboundsexception. > This can cause all the parsing to fail when this problem occurs. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (NIFI-4726) Concurrency issue with JoltTransformJson
[ https://issues.apache.org/jira/browse/NIFI-4726?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joseph Witt updated NIFI-4726: -- Fix Version/s: 1.5.0 > Concurrency issue with JoltTransformJson > > > Key: NIFI-4726 > URL: https://issues.apache.org/jira/browse/NIFI-4726 > Project: Apache NiFi > Issue Type: Bug >Reporter: Marco Gaido >Assignee: Marco Gaido > Fix For: 1.5.0 > > > JoltTransformJson uses under the hood Jackson to parse JSONs. On heavy > multithreading workloads, Jackson can have concurrency problem, as also > described in this Stackoverflow thread > https://stackoverflow.com/questions/17924865/jsonmappingexception-was-java-lang-arrayindexoutofboundsexception. > This can cause all the parsing to fail when this problem occurs. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (NIFI-4726) Concurrency issue with JoltTransformJson
[ https://issues.apache.org/jira/browse/NIFI-4726?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16317657#comment-16317657 ] Joseph Witt commented on NIFI-4726: --- [~ijokarumawak] that is excellent! So we can avoid making further changes then in my view. I'll close it as OBE based on this analysis and if marco or anyone feels differently we can revisit. thanks > Concurrency issue with JoltTransformJson > > > Key: NIFI-4726 > URL: https://issues.apache.org/jira/browse/NIFI-4726 > Project: Apache NiFi > Issue Type: Bug >Reporter: Marco Gaido >Assignee: Marco Gaido > > JoltTransformJson uses under the hood Jackson to parse JSONs. On heavy > multithreading workloads, Jackson can have concurrency problem, as also > described in this Stackoverflow thread > https://stackoverflow.com/questions/17924865/jsonmappingexception-was-java-lang-arrayindexoutofboundsexception. > This can cause all the parsing to fail when this problem occurs. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (NIFI-4726) Concurrency issue with JoltTransformJson
[ https://issues.apache.org/jira/browse/NIFI-4726?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16317649#comment-16317649 ] ASF GitHub Bot commented on NIFI-4726: -- Github user ijokarumawak commented on the issue: https://github.com/apache/nifi/pull/2363 Hi @mgaido91 @joewitt , I was investigating the root cause of the issue. Finally, I think I was able to reproduce the ArrayIndexOutOfBoundsException with JoltTransformJson processor. You can find details in this Gist with a reproducible NiFi flow template. NOTE, this is not reproducible anymore with current NiFi 1.5.0 snapshot, you need to test it with older version of NiFi. https://gist.github.com/ijokarumawak/65f51ea49029c1eafcc62c39e1a606bc Does it seem reasonable? If that is the root cause we're looking for, then it doesn't caused by concurrent use of JsonUtils. > Concurrency issue with JoltTransformJson > > > Key: NIFI-4726 > URL: https://issues.apache.org/jira/browse/NIFI-4726 > Project: Apache NiFi > Issue Type: Bug >Reporter: Marco Gaido >Assignee: Marco Gaido > > JoltTransformJson uses under the hood Jackson to parse JSONs. On heavy > multithreading workloads, Jackson can have concurrency problem, as also > described in this Stackoverflow thread > https://stackoverflow.com/questions/17924865/jsonmappingexception-was-java-lang-arrayindexoutofboundsexception. > This can cause all the parsing to fail when this problem occurs. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[GitHub] nifi issue #2363: NIFI-4726: Avoid concurrency issues in JoltTransformJSON
Github user ijokarumawak commented on the issue: https://github.com/apache/nifi/pull/2363 Hi @mgaido91 @joewitt , I was investigating the root cause of the issue. Finally, I think I was able to reproduce the ArrayIndexOutOfBoundsException with JoltTransformJson processor. You can find details in this Gist with a reproducible NiFi flow template. NOTE, this is not reproducible anymore with current NiFi 1.5.0 snapshot, you need to test it with older version of NiFi. https://gist.github.com/ijokarumawak/65f51ea49029c1eafcc62c39e1a606bc Does it seem reasonable? If that is the root cause we're looking for, then it doesn't caused by concurrent use of JsonUtils. ---
[jira] [Assigned] (NIFI-4726) Concurrency issue with JoltTransformJson
[ https://issues.apache.org/jira/browse/NIFI-4726?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Koji Kawamura reassigned NIFI-4726: --- Assignee: Marco Gaido > Concurrency issue with JoltTransformJson > > > Key: NIFI-4726 > URL: https://issues.apache.org/jira/browse/NIFI-4726 > Project: Apache NiFi > Issue Type: Bug >Reporter: Marco Gaido >Assignee: Marco Gaido > > JoltTransformJson uses under the hood Jackson to parse JSONs. On heavy > multithreading workloads, Jackson can have concurrency problem, as also > described in this Stackoverflow thread > https://stackoverflow.com/questions/17924865/jsonmappingexception-was-java-lang-arrayindexoutofboundsexception. > This can cause all the parsing to fail when this problem occurs. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (NIFI-4708) Add support for NiFi Registry to the encrypt-config tool in NiFi Toolkit
[ https://issues.apache.org/jira/browse/NIFI-4708?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16317646#comment-16317646 ] ASF GitHub Bot commented on NIFI-4708: -- GitHub user kevdoran opened a pull request: https://github.com/apache/nifi/pull/2389 NIFI-4708 Fixes encrypt-config log4j configuration Thank you for submitting a contribution to Apache NiFi. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all changes: - [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [ ] Does your PR title start with NIFI- where is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character. - [ ] Has your PR been rebased against the latest commit within the target branch (typically master)? - [ ] Is your initial contribution a single, squashed commit? ### For code changes: - [ ] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder? - [ ] Have you written or updated unit tests to verify your changes? - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? - [ ] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly? - [ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly? - [ ] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties? ### For documentation related changes: - [ ] Have you ensured that format looks appropriate for the output in which it is rendered? ### Note: Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible. You can merge this pull request into a Git repository by running: $ git pull https://github.com/kevdoran/nifi NIFI-4708-fix-travis-build Alternatively you can review and apply these changes as the patch at: https://github.com/apache/nifi/pull/2389.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #2389 commit 6105bc99e2af49e7193ce10a41096b57ab1d8c94 Author: Kevin DoranDate: 2018-01-09T03:28:08Z NIFI-4708 Fixes encrypt-config log4j configuration > Add support for NiFi Registry to the encrypt-config tool in NiFi Toolkit > > > Key: NIFI-4708 > URL: https://issues.apache.org/jira/browse/NIFI-4708 > Project: Apache NiFi > Issue Type: Improvement >Reporter: Kevin Doran >Assignee: Kevin Doran > Fix For: 1.5.0 > > > NiFi Registry now supports loading encrypted config files (e.g., > nifi-registry.properties, authorizers.xml, login-identity-providers.xml). > These files are very difficult to encrypt by hand, and is not recommended. > Because NiFi Registry utilizes the same encryption algorithms supported by > NiFi, the easiest way to build a tool for encrypting NiFi Registry config > properties is to extend the the encrypt-config tool in NiFi Toolkit to > support NiFi Registry as well. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (NIFI-4708) Add support for NiFi Registry to the encrypt-config tool in NiFi Toolkit
[ https://issues.apache.org/jira/browse/NIFI-4708?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16317644#comment-16317644 ] Kevin Doran commented on NIFI-4708: --- [~joewitt] Yes, I agree the Travis-CI failures are related to these tests. I'll submit a patch momentarily that resolves this. > Add support for NiFi Registry to the encrypt-config tool in NiFi Toolkit > > > Key: NIFI-4708 > URL: https://issues.apache.org/jira/browse/NIFI-4708 > Project: Apache NiFi > Issue Type: Improvement >Reporter: Kevin Doran >Assignee: Kevin Doran > Fix For: 1.5.0 > > > NiFi Registry now supports loading encrypted config files (e.g., > nifi-registry.properties, authorizers.xml, login-identity-providers.xml). > These files are very difficult to encrypt by hand, and is not recommended. > Because NiFi Registry utilizes the same encryption algorithms supported by > NiFi, the easiest way to build a tool for encrypting NiFi Registry config > properties is to extend the the encrypt-config tool in NiFi Toolkit to > support NiFi Registry as well. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (NIFI-4697) PostHTTP: correct documentation
[ https://issues.apache.org/jira/browse/NIFI-4697?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16317643#comment-16317643 ] Michael Hogue commented on NIFI-4697: - No problem, [~mosermw]! Thanks for picking it up. > PostHTTP: correct documentation > --- > > Key: NIFI-4697 > URL: https://issues.apache.org/jira/browse/NIFI-4697 > Project: Apache NiFi > Issue Type: Improvement >Affects Versions: 1.4.0 >Reporter: Brandon DeVries >Assignee: Michael Moser >Priority: Minor > > The description of the URL property of PostHTTP says > "The URL to POST to. The first part of the URL must be static. However, the > path of the URL may be defined using the Attribute Expression Language. " > This does not appear to be true. We should modify to something like "The URL > to POST to." > ...or, someone can point out to me why I'm wrong in saying it's wrong... -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Assigned] (NIFI-4697) PostHTTP: correct documentation
[ https://issues.apache.org/jira/browse/NIFI-4697?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Hogue reassigned NIFI-4697: --- Assignee: Michael Moser (was: Michael Hogue) > PostHTTP: correct documentation > --- > > Key: NIFI-4697 > URL: https://issues.apache.org/jira/browse/NIFI-4697 > Project: Apache NiFi > Issue Type: Improvement >Affects Versions: 1.4.0 >Reporter: Brandon DeVries >Assignee: Michael Moser >Priority: Minor > > The description of the URL property of PostHTTP says > "The URL to POST to. The first part of the URL must be static. However, the > path of the URL may be defined using the Attribute Expression Language. " > This does not appear to be true. We should modify to something like "The URL > to POST to." > ...or, someone can point out to me why I'm wrong in saying it's wrong... -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Reopened] (NIFI-4708) Add support for NiFi Registry to the encrypt-config tool in NiFi Toolkit
[ https://issues.apache.org/jira/browse/NIFI-4708?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joseph Witt reopened NIFI-4708: --- Travis-CI failures appear to be related to the encrypt-config tests. > Add support for NiFi Registry to the encrypt-config tool in NiFi Toolkit > > > Key: NIFI-4708 > URL: https://issues.apache.org/jira/browse/NIFI-4708 > Project: Apache NiFi > Issue Type: Improvement >Reporter: Kevin Doran >Assignee: Kevin Doran > Fix For: 1.5.0 > > > NiFi Registry now supports loading encrypted config files (e.g., > nifi-registry.properties, authorizers.xml, login-identity-providers.xml). > These files are very difficult to encrypt by hand, and is not recommended. > Because NiFi Registry utilizes the same encryption algorithms supported by > NiFi, the easiest way to build a tool for encrypting NiFi Registry config > properties is to extend the the encrypt-config tool in NiFi Toolkit to > support NiFi Registry as well. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (NIFI-4708) Add support for NiFi Registry to the encrypt-config tool in NiFi Toolkit
[ https://issues.apache.org/jira/browse/NIFI-4708?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joseph Witt updated NIFI-4708: -- Resolution: Fixed Status: Resolved (was: Patch Available) +1 merged to master > Add support for NiFi Registry to the encrypt-config tool in NiFi Toolkit > > > Key: NIFI-4708 > URL: https://issues.apache.org/jira/browse/NIFI-4708 > Project: Apache NiFi > Issue Type: Improvement >Reporter: Kevin Doran >Assignee: Kevin Doran > Fix For: 1.5.0 > > > NiFi Registry now supports loading encrypted config files (e.g., > nifi-registry.properties, authorizers.xml, login-identity-providers.xml). > These files are very difficult to encrypt by hand, and is not recommended. > Because NiFi Registry utilizes the same encryption algorithms supported by > NiFi, the easiest way to build a tool for encrypting NiFi Registry config > properties is to extend the the encrypt-config tool in NiFi Toolkit to > support NiFi Registry as well. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (NIFI-4708) Add support for NiFi Registry to the encrypt-config tool in NiFi Toolkit
[ https://issues.apache.org/jira/browse/NIFI-4708?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16317629#comment-16317629 ] ASF subversion and git services commented on NIFI-4708: --- Commit 08c391067980d745fb823cb7c5a1d02eb1423304 in nifi's branch refs/heads/master from [~bbende] [ https://git-wip-us.apache.org/repos/asf?p=nifi.git;h=08c3910 ] NIFI-4708 This closes #2388. Correcting logic for determining decryption key in NiFiRegistryMode.groovy Signed-off-by: joewitt> Add support for NiFi Registry to the encrypt-config tool in NiFi Toolkit > > > Key: NIFI-4708 > URL: https://issues.apache.org/jira/browse/NIFI-4708 > Project: Apache NiFi > Issue Type: Improvement >Reporter: Kevin Doran >Assignee: Kevin Doran > Fix For: 1.5.0 > > > NiFi Registry now supports loading encrypted config files (e.g., > nifi-registry.properties, authorizers.xml, login-identity-providers.xml). > These files are very difficult to encrypt by hand, and is not recommended. > Because NiFi Registry utilizes the same encryption algorithms supported by > NiFi, the easiest way to build a tool for encrypting NiFi Registry config > properties is to extend the the encrypt-config tool in NiFi Toolkit to > support NiFi Registry as well. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (NIFI-4708) Add support for NiFi Registry to the encrypt-config tool in NiFi Toolkit
[ https://issues.apache.org/jira/browse/NIFI-4708?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16317630#comment-16317630 ] ASF GitHub Bot commented on NIFI-4708: -- Github user asfgit closed the pull request at: https://github.com/apache/nifi/pull/2388 > Add support for NiFi Registry to the encrypt-config tool in NiFi Toolkit > > > Key: NIFI-4708 > URL: https://issues.apache.org/jira/browse/NIFI-4708 > Project: Apache NiFi > Issue Type: Improvement >Reporter: Kevin Doran >Assignee: Kevin Doran > Fix For: 1.5.0 > > > NiFi Registry now supports loading encrypted config files (e.g., > nifi-registry.properties, authorizers.xml, login-identity-providers.xml). > These files are very difficult to encrypt by hand, and is not recommended. > Because NiFi Registry utilizes the same encryption algorithms supported by > NiFi, the easiest way to build a tool for encrypting NiFi Registry config > properties is to extend the the encrypt-config tool in NiFi Toolkit to > support NiFi Registry as well. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[GitHub] nifi pull request #2388: NIFI-4708 Correcting logic for determining decrypti...
Github user asfgit closed the pull request at: https://github.com/apache/nifi/pull/2388 ---
[jira] [Resolved] (NIFI-4749) QueryRecord throws NPE when selecting complex objects if writer inherits schema
[ https://issues.apache.org/jira/browse/NIFI-4749?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joseph Witt resolved NIFI-4749. --- Resolution: Fixed +1 merged to master. Verified issue+fix. thanks > QueryRecord throws NPE when selecting complex objects if writer inherits > schema > --- > > Key: NIFI-4749 > URL: https://issues.apache.org/jira/browse/NIFI-4749 > Project: Apache NiFi > Issue Type: Bug >Affects Versions: 1.4.0 >Reporter: Mark Payne >Assignee: Mark Payne > Fix For: 1.5.0 > > Attachments: NIFI-4749.xml > > > If we create a QueryRecord processor and choose a Record Writer that has a > Schema Write Strategy of "Inherit Record," all works okay if the data being > queried is 'flat' data. But if the data is hierarchical it can fail when > attempting to write out the data, throwing a NullPointerException: > {code} > 2018-01-08 15:15:07,645 ERROR [NiFi logging handler] org.apache.nifi.StdErr > java.lang.NullPointerException > 2018-01-08 15:15:07,648 ERROR [NiFi logging handler] org.apache.nifi.StdErr > at > org.apache.nifi.json.WriteJsonResult.writeRecord(WriteJsonResult.java:167) > 2018-01-08 15:15:07,648 ERROR [NiFi logging handler] org.apache.nifi.StdErr > at org.apache.nifi.json.WriteJsonResult.writeValue(WriteJsonResult.java:348) > 2018-01-08 15:15:07,648 ERROR [NiFi logging handler] org.apache.nifi.StdErr > at org.apache.nifi.json.WriteJsonResult.writeArray(WriteJsonResult.java:385) > 2018-01-08 15:15:07,649 ERROR [NiFi logging handler] org.apache.nifi.StdErr > at org.apache.nifi.json.WriteJsonResult.writeValue(WriteJsonResult.java:372) > 2018-01-08 15:15:07,649 ERROR [NiFi logging handler] org.apache.nifi.StdErr > at > org.apache.nifi.json.WriteJsonResult.writeRecord(WriteJsonResult.java:181) > 2018-01-08 15:15:07,649 ERROR [NiFi logging handler] org.apache.nifi.StdErr > at > org.apache.nifi.json.WriteJsonResult.writeRecord(WriteJsonResult.java:128) > 2018-01-08 15:15:07,649 ERROR [NiFi logging handler] org.apache.nifi.StdErr > at > org.apache.nifi.serialization.AbstractRecordSetWriter.write(AbstractRecordSetWriter.java:59) > 2018-01-08 15:15:07,649 ERROR [NiFi logging handler] org.apache.nifi.StdErr > at > org.apache.nifi.serialization.AbstractRecordSetWriter.write(AbstractRecordSetWriter.java:52) > 2018-01-08 15:15:07,649 ERROR [NiFi logging handler] org.apache.nifi.StdErr > at > org.apache.nifi.processors.standard.QueryRecord$1.process(QueryRecord.java:305) > 2018-01-08 15:15:07,649 ERROR [NiFi logging handler] org.apache.nifi.StdErr > at > org.apache.nifi.controller.repository.StandardProcessSession.write(StandardProcessSession.java:2571) > 2018-01-08 15:15:07,649 ERROR [NiFi logging handler] org.apache.nifi.StdErr > at > org.apache.nifi.processors.standard.QueryRecord.onTrigger(QueryRecord.java:290) > 2018-01-08 15:15:07,649 ERROR [NiFi logging handler] org.apache.nifi.StdErr > at > org.apache.nifi.processor.AbstractProcessor.onTrigger(AbstractProcessor.java:27) > 2018-01-08 15:15:07,649 ERROR [NiFi logging handler] org.apache.nifi.StdErr > at > org.apache.nifi.controller.StandardProcessorNode.onTrigger(StandardProcessorNode.java:1122) > 2018-01-08 15:15:07,649 ERROR [NiFi logging handler] org.apache.nifi.StdErr > at > org.apache.nifi.controller.tasks.ContinuallyRunProcessorTask.call(ContinuallyRunProcessorTask.java:147) > 2018-01-08 15:15:07,649 ERROR [NiFi logging handler] org.apache.nifi.StdErr > at > org.apache.nifi.controller.tasks.ContinuallyRunProcessorTask.call(ContinuallyRunProcessorTask.java:47) > 2018-01-08 15:15:07,649 ERROR [NiFi logging handler] org.apache.nifi.StdErr > at > org.apache.nifi.controller.scheduling.TimerDrivenSchedulingAgent$1.run(TimerDrivenSchedulingAgent.java:128) > 2018-01-08 15:15:07,649 ERROR [NiFi logging handler] org.apache.nifi.StdErr > at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511) > 2018-01-08 15:15:07,649 ERROR [NiFi logging handler] org.apache.nifi.StdErr > at java.util.concurrent.FutureTask.runAndReset(FutureTask.java:308) > 2018-01-08 15:15:07,649 ERROR [NiFi logging handler] org.apache.nifi.StdErr > at > java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.access$301(ScheduledThreadPoolExecutor.java:180) > 2018-01-08 15:15:07,649 ERROR [NiFi logging handler] org.apache.nifi.StdErr > at > java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:294) > 2018-01-08 15:15:07,649 ERROR [NiFi logging handler] org.apache.nifi.StdErr > at > java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142) > 2018-01-08 15:15:07,649 ERROR [NiFi logging handler] org.apache.nifi.StdErr >
[jira] [Commented] (NIFI-4749) QueryRecord throws NPE when selecting complex objects if writer inherits schema
[ https://issues.apache.org/jira/browse/NIFI-4749?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16317603#comment-16317603 ] ASF GitHub Bot commented on NIFI-4749: -- Github user asfgit closed the pull request at: https://github.com/apache/nifi/pull/2386 > QueryRecord throws NPE when selecting complex objects if writer inherits > schema > --- > > Key: NIFI-4749 > URL: https://issues.apache.org/jira/browse/NIFI-4749 > Project: Apache NiFi > Issue Type: Bug >Affects Versions: 1.4.0 >Reporter: Mark Payne >Assignee: Mark Payne > Fix For: 1.5.0 > > Attachments: NIFI-4749.xml > > > If we create a QueryRecord processor and choose a Record Writer that has a > Schema Write Strategy of "Inherit Record," all works okay if the data being > queried is 'flat' data. But if the data is hierarchical it can fail when > attempting to write out the data, throwing a NullPointerException: > {code} > 2018-01-08 15:15:07,645 ERROR [NiFi logging handler] org.apache.nifi.StdErr > java.lang.NullPointerException > 2018-01-08 15:15:07,648 ERROR [NiFi logging handler] org.apache.nifi.StdErr > at > org.apache.nifi.json.WriteJsonResult.writeRecord(WriteJsonResult.java:167) > 2018-01-08 15:15:07,648 ERROR [NiFi logging handler] org.apache.nifi.StdErr > at org.apache.nifi.json.WriteJsonResult.writeValue(WriteJsonResult.java:348) > 2018-01-08 15:15:07,648 ERROR [NiFi logging handler] org.apache.nifi.StdErr > at org.apache.nifi.json.WriteJsonResult.writeArray(WriteJsonResult.java:385) > 2018-01-08 15:15:07,649 ERROR [NiFi logging handler] org.apache.nifi.StdErr > at org.apache.nifi.json.WriteJsonResult.writeValue(WriteJsonResult.java:372) > 2018-01-08 15:15:07,649 ERROR [NiFi logging handler] org.apache.nifi.StdErr > at > org.apache.nifi.json.WriteJsonResult.writeRecord(WriteJsonResult.java:181) > 2018-01-08 15:15:07,649 ERROR [NiFi logging handler] org.apache.nifi.StdErr > at > org.apache.nifi.json.WriteJsonResult.writeRecord(WriteJsonResult.java:128) > 2018-01-08 15:15:07,649 ERROR [NiFi logging handler] org.apache.nifi.StdErr > at > org.apache.nifi.serialization.AbstractRecordSetWriter.write(AbstractRecordSetWriter.java:59) > 2018-01-08 15:15:07,649 ERROR [NiFi logging handler] org.apache.nifi.StdErr > at > org.apache.nifi.serialization.AbstractRecordSetWriter.write(AbstractRecordSetWriter.java:52) > 2018-01-08 15:15:07,649 ERROR [NiFi logging handler] org.apache.nifi.StdErr > at > org.apache.nifi.processors.standard.QueryRecord$1.process(QueryRecord.java:305) > 2018-01-08 15:15:07,649 ERROR [NiFi logging handler] org.apache.nifi.StdErr > at > org.apache.nifi.controller.repository.StandardProcessSession.write(StandardProcessSession.java:2571) > 2018-01-08 15:15:07,649 ERROR [NiFi logging handler] org.apache.nifi.StdErr > at > org.apache.nifi.processors.standard.QueryRecord.onTrigger(QueryRecord.java:290) > 2018-01-08 15:15:07,649 ERROR [NiFi logging handler] org.apache.nifi.StdErr > at > org.apache.nifi.processor.AbstractProcessor.onTrigger(AbstractProcessor.java:27) > 2018-01-08 15:15:07,649 ERROR [NiFi logging handler] org.apache.nifi.StdErr > at > org.apache.nifi.controller.StandardProcessorNode.onTrigger(StandardProcessorNode.java:1122) > 2018-01-08 15:15:07,649 ERROR [NiFi logging handler] org.apache.nifi.StdErr > at > org.apache.nifi.controller.tasks.ContinuallyRunProcessorTask.call(ContinuallyRunProcessorTask.java:147) > 2018-01-08 15:15:07,649 ERROR [NiFi logging handler] org.apache.nifi.StdErr > at > org.apache.nifi.controller.tasks.ContinuallyRunProcessorTask.call(ContinuallyRunProcessorTask.java:47) > 2018-01-08 15:15:07,649 ERROR [NiFi logging handler] org.apache.nifi.StdErr > at > org.apache.nifi.controller.scheduling.TimerDrivenSchedulingAgent$1.run(TimerDrivenSchedulingAgent.java:128) > 2018-01-08 15:15:07,649 ERROR [NiFi logging handler] org.apache.nifi.StdErr > at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511) > 2018-01-08 15:15:07,649 ERROR [NiFi logging handler] org.apache.nifi.StdErr > at java.util.concurrent.FutureTask.runAndReset(FutureTask.java:308) > 2018-01-08 15:15:07,649 ERROR [NiFi logging handler] org.apache.nifi.StdErr > at > java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.access$301(ScheduledThreadPoolExecutor.java:180) > 2018-01-08 15:15:07,649 ERROR [NiFi logging handler] org.apache.nifi.StdErr > at > java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:294) > 2018-01-08 15:15:07,649 ERROR [NiFi logging handler] org.apache.nifi.StdErr > at > java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142) > 2018-01-08
[GitHub] nifi pull request #2386: NIFI-4749: Pass the record reader's schema along to...
Github user asfgit closed the pull request at: https://github.com/apache/nifi/pull/2386 ---
[jira] [Commented] (NIFI-4749) QueryRecord throws NPE when selecting complex objects if writer inherits schema
[ https://issues.apache.org/jira/browse/NIFI-4749?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16317602#comment-16317602 ] ASF subversion and git services commented on NIFI-4749: --- Commit 953e922d324d37c3771f46a2f371026814d92282 in nifi's branch refs/heads/master from [~markap14] [ https://git-wip-us.apache.org/repos/asf?p=nifi.git;h=953e922 ] NIFI-4749: This closes #2386. Pass the record reader's schema along to the ResultSetRecordSet so that it is able to resolve the schema for Record fields Signed-off-by: joewitt> QueryRecord throws NPE when selecting complex objects if writer inherits > schema > --- > > Key: NIFI-4749 > URL: https://issues.apache.org/jira/browse/NIFI-4749 > Project: Apache NiFi > Issue Type: Bug >Affects Versions: 1.4.0 >Reporter: Mark Payne >Assignee: Mark Payne > Fix For: 1.5.0 > > Attachments: NIFI-4749.xml > > > If we create a QueryRecord processor and choose a Record Writer that has a > Schema Write Strategy of "Inherit Record," all works okay if the data being > queried is 'flat' data. But if the data is hierarchical it can fail when > attempting to write out the data, throwing a NullPointerException: > {code} > 2018-01-08 15:15:07,645 ERROR [NiFi logging handler] org.apache.nifi.StdErr > java.lang.NullPointerException > 2018-01-08 15:15:07,648 ERROR [NiFi logging handler] org.apache.nifi.StdErr > at > org.apache.nifi.json.WriteJsonResult.writeRecord(WriteJsonResult.java:167) > 2018-01-08 15:15:07,648 ERROR [NiFi logging handler] org.apache.nifi.StdErr > at org.apache.nifi.json.WriteJsonResult.writeValue(WriteJsonResult.java:348) > 2018-01-08 15:15:07,648 ERROR [NiFi logging handler] org.apache.nifi.StdErr > at org.apache.nifi.json.WriteJsonResult.writeArray(WriteJsonResult.java:385) > 2018-01-08 15:15:07,649 ERROR [NiFi logging handler] org.apache.nifi.StdErr > at org.apache.nifi.json.WriteJsonResult.writeValue(WriteJsonResult.java:372) > 2018-01-08 15:15:07,649 ERROR [NiFi logging handler] org.apache.nifi.StdErr > at > org.apache.nifi.json.WriteJsonResult.writeRecord(WriteJsonResult.java:181) > 2018-01-08 15:15:07,649 ERROR [NiFi logging handler] org.apache.nifi.StdErr > at > org.apache.nifi.json.WriteJsonResult.writeRecord(WriteJsonResult.java:128) > 2018-01-08 15:15:07,649 ERROR [NiFi logging handler] org.apache.nifi.StdErr > at > org.apache.nifi.serialization.AbstractRecordSetWriter.write(AbstractRecordSetWriter.java:59) > 2018-01-08 15:15:07,649 ERROR [NiFi logging handler] org.apache.nifi.StdErr > at > org.apache.nifi.serialization.AbstractRecordSetWriter.write(AbstractRecordSetWriter.java:52) > 2018-01-08 15:15:07,649 ERROR [NiFi logging handler] org.apache.nifi.StdErr > at > org.apache.nifi.processors.standard.QueryRecord$1.process(QueryRecord.java:305) > 2018-01-08 15:15:07,649 ERROR [NiFi logging handler] org.apache.nifi.StdErr > at > org.apache.nifi.controller.repository.StandardProcessSession.write(StandardProcessSession.java:2571) > 2018-01-08 15:15:07,649 ERROR [NiFi logging handler] org.apache.nifi.StdErr > at > org.apache.nifi.processors.standard.QueryRecord.onTrigger(QueryRecord.java:290) > 2018-01-08 15:15:07,649 ERROR [NiFi logging handler] org.apache.nifi.StdErr > at > org.apache.nifi.processor.AbstractProcessor.onTrigger(AbstractProcessor.java:27) > 2018-01-08 15:15:07,649 ERROR [NiFi logging handler] org.apache.nifi.StdErr > at > org.apache.nifi.controller.StandardProcessorNode.onTrigger(StandardProcessorNode.java:1122) > 2018-01-08 15:15:07,649 ERROR [NiFi logging handler] org.apache.nifi.StdErr > at > org.apache.nifi.controller.tasks.ContinuallyRunProcessorTask.call(ContinuallyRunProcessorTask.java:147) > 2018-01-08 15:15:07,649 ERROR [NiFi logging handler] org.apache.nifi.StdErr > at > org.apache.nifi.controller.tasks.ContinuallyRunProcessorTask.call(ContinuallyRunProcessorTask.java:47) > 2018-01-08 15:15:07,649 ERROR [NiFi logging handler] org.apache.nifi.StdErr > at > org.apache.nifi.controller.scheduling.TimerDrivenSchedulingAgent$1.run(TimerDrivenSchedulingAgent.java:128) > 2018-01-08 15:15:07,649 ERROR [NiFi logging handler] org.apache.nifi.StdErr > at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511) > 2018-01-08 15:15:07,649 ERROR [NiFi logging handler] org.apache.nifi.StdErr > at java.util.concurrent.FutureTask.runAndReset(FutureTask.java:308) > 2018-01-08 15:15:07,649 ERROR [NiFi logging handler] org.apache.nifi.StdErr > at > java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.access$301(ScheduledThreadPoolExecutor.java:180) > 2018-01-08 15:15:07,649 ERROR [NiFi logging handler] org.apache.nifi.StdErr >
[jira] [Commented] (NIFI-4708) Add support for NiFi Registry to the encrypt-config tool in NiFi Toolkit
[ https://issues.apache.org/jira/browse/NIFI-4708?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16317588#comment-16317588 ] Joseph Witt commented on NIFI-4708: --- rgr that -will review > Add support for NiFi Registry to the encrypt-config tool in NiFi Toolkit > > > Key: NIFI-4708 > URL: https://issues.apache.org/jira/browse/NIFI-4708 > Project: Apache NiFi > Issue Type: Improvement >Reporter: Kevin Doran >Assignee: Kevin Doran > Fix For: 1.5.0 > > > NiFi Registry now supports loading encrypted config files (e.g., > nifi-registry.properties, authorizers.xml, login-identity-providers.xml). > These files are very difficult to encrypt by hand, and is not recommended. > Because NiFi Registry utilizes the same encryption algorithms supported by > NiFi, the easiest way to build a tool for encrypting NiFi Registry config > properties is to extend the the encrypt-config tool in NiFi Toolkit to > support NiFi Registry as well. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Reopened] (NIFI-4708) Add support for NiFi Registry to the encrypt-config tool in NiFi Toolkit
[ https://issues.apache.org/jira/browse/NIFI-4708?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bryan Bende reopened NIFI-4708: --- I noticed a minor issue when running the encrypt config a second time after the configuration is initially encrypted. Basically the --oldPassword doesn't seem to be honored and it fails to decrypt the properties. Was able to identify the issue so going to re-open this JIRA and submit a small fix. > Add support for NiFi Registry to the encrypt-config tool in NiFi Toolkit > > > Key: NIFI-4708 > URL: https://issues.apache.org/jira/browse/NIFI-4708 > Project: Apache NiFi > Issue Type: Improvement >Reporter: Kevin Doran >Assignee: Kevin Doran > Fix For: 1.5.0 > > > NiFi Registry now supports loading encrypted config files (e.g., > nifi-registry.properties, authorizers.xml, login-identity-providers.xml). > These files are very difficult to encrypt by hand, and is not recommended. > Because NiFi Registry utilizes the same encryption algorithms supported by > NiFi, the easiest way to build a tool for encrypting NiFi Registry config > properties is to extend the the encrypt-config tool in NiFi Toolkit to > support NiFi Registry as well. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (NIFI-4708) Add support for NiFi Registry to the encrypt-config tool in NiFi Toolkit
[ https://issues.apache.org/jira/browse/NIFI-4708?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16317586#comment-16317586 ] ASF GitHub Bot commented on NIFI-4708: -- GitHub user bbende opened a pull request: https://github.com/apache/nifi/pull/2388 NIFI-4708 Correcting logic for determining decryption key in NiFiRegi… …stryMode.groovy Thank you for submitting a contribution to Apache NiFi. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all changes: - [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [ ] Does your PR title start with NIFI- where is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character. - [ ] Has your PR been rebased against the latest commit within the target branch (typically master)? - [ ] Is your initial contribution a single, squashed commit? ### For code changes: - [ ] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder? - [ ] Have you written or updated unit tests to verify your changes? - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? - [ ] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly? - [ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly? - [ ] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties? ### For documentation related changes: - [ ] Have you ensured that format looks appropriate for the output in which it is rendered? ### Note: Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible. You can merge this pull request into a Git repository by running: $ git pull https://github.com/bbende/nifi NIFI-4708 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/nifi/pull/2388.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #2388 commit e558027c5d7cc9be806d987381ff96c2d3c6ce5b Author: Bryan BendeDate: 2018-01-09T02:44:04Z NIFI-4708 Correcting logic for determining decryption key in NiFiRegistryMode.groovy > Add support for NiFi Registry to the encrypt-config tool in NiFi Toolkit > > > Key: NIFI-4708 > URL: https://issues.apache.org/jira/browse/NIFI-4708 > Project: Apache NiFi > Issue Type: Improvement >Reporter: Kevin Doran >Assignee: Kevin Doran > Fix For: 1.5.0 > > > NiFi Registry now supports loading encrypted config files (e.g., > nifi-registry.properties, authorizers.xml, login-identity-providers.xml). > These files are very difficult to encrypt by hand, and is not recommended. > Because NiFi Registry utilizes the same encryption algorithms supported by > NiFi, the easiest way to build a tool for encrypting NiFi Registry config > properties is to extend the the encrypt-config tool in NiFi Toolkit to > support NiFi Registry as well. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (NIFI-4708) Add support for NiFi Registry to the encrypt-config tool in NiFi Toolkit
[ https://issues.apache.org/jira/browse/NIFI-4708?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bryan Bende updated NIFI-4708: -- Status: Patch Available (was: Reopened) > Add support for NiFi Registry to the encrypt-config tool in NiFi Toolkit > > > Key: NIFI-4708 > URL: https://issues.apache.org/jira/browse/NIFI-4708 > Project: Apache NiFi > Issue Type: Improvement >Reporter: Kevin Doran >Assignee: Kevin Doran > Fix For: 1.5.0 > > > NiFi Registry now supports loading encrypted config files (e.g., > nifi-registry.properties, authorizers.xml, login-identity-providers.xml). > These files are very difficult to encrypt by hand, and is not recommended. > Because NiFi Registry utilizes the same encryption algorithms supported by > NiFi, the easiest way to build a tool for encrypting NiFi Registry config > properties is to extend the the encrypt-config tool in NiFi Toolkit to > support NiFi Registry as well. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[GitHub] nifi pull request #2388: NIFI-4708 Correcting logic for determining decrypti...
GitHub user bbende opened a pull request: https://github.com/apache/nifi/pull/2388 NIFI-4708 Correcting logic for determining decryption key in NiFiRegi⦠â¦stryMode.groovy Thank you for submitting a contribution to Apache NiFi. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all changes: - [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [ ] Does your PR title start with NIFI- where is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character. - [ ] Has your PR been rebased against the latest commit within the target branch (typically master)? - [ ] Is your initial contribution a single, squashed commit? ### For code changes: - [ ] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder? - [ ] Have you written or updated unit tests to verify your changes? - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? - [ ] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly? - [ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly? - [ ] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties? ### For documentation related changes: - [ ] Have you ensured that format looks appropriate for the output in which it is rendered? ### Note: Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible. You can merge this pull request into a Git repository by running: $ git pull https://github.com/bbende/nifi NIFI-4708 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/nifi/pull/2388.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #2388 commit e558027c5d7cc9be806d987381ff96c2d3c6ce5b Author: Bryan BendeDate: 2018-01-09T02:44:04Z NIFI-4708 Correcting logic for determining decryption key in NiFiRegistryMode.groovy ---
[jira] [Updated] (MINIFICPP-37) Create scripts to get information from the controller API
[ https://issues.apache.org/jira/browse/MINIFICPP-37?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] marco polo updated MINIFICPP-37: Fix Version/s: 0.4.0 > Create scripts to get information from the controller API > - > > Key: MINIFICPP-37 > URL: https://issues.apache.org/jira/browse/MINIFICPP-37 > Project: NiFi MiNiFi C++ > Issue Type: Sub-task >Reporter: marco polo >Priority: Minor > Labels: Durability, Reliability > Fix For: 0.4.0 > > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Comment Edited] (NIFI-4751) Release Management for Apache NiFi 1.5.0 RC
[ https://issues.apache.org/jira/browse/NIFI-4751?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16317421#comment-16317421 ] Joseph Witt edited comment on NIFI-4751 at 1/9/18 12:34 AM: Need to fix NOTICE file which somehow has MIT License references in it for a couple libraries https://github.com/apache/nifi/blob/master/nifi-assembly/NOTICE#L1680-L1687 https://github.com/apache/nifi/commit/b7cdc6b382b09d601b1e9ecf81ef16b9246309b3 https://github.com/apache/nifi/commit/3386839ebc4a16029fc40a1b2702017b1ab39fa3 was (Author: joewitt): Need to fix NOTICE file which somehow has MIT License references in it for a couple libraries https://github.com/apache/nifi/blob/master/nifi-assembly/NOTICE#L1680-L1687 > Release Management for Apache NiFi 1.5.0 RC > --- > > Key: NIFI-4751 > URL: https://issues.apache.org/jira/browse/NIFI-4751 > Project: Apache NiFi > Issue Type: Bug > Components: Tools and Build >Affects Versions: 1.5.0 >Reporter: Joseph Witt >Assignee: Joseph Witt > Fix For: 1.5.0 > > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (NIFI-4751) Release Management for Apache NiFi 1.5.0 RC
[ https://issues.apache.org/jira/browse/NIFI-4751?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16317421#comment-16317421 ] Joseph Witt commented on NIFI-4751: --- Need to fix NOTICE file which somehow has MIT License references in it for a couple libraries https://github.com/apache/nifi/blob/master/nifi-assembly/NOTICE#L1680-L1687 > Release Management for Apache NiFi 1.5.0 RC > --- > > Key: NIFI-4751 > URL: https://issues.apache.org/jira/browse/NIFI-4751 > Project: Apache NiFi > Issue Type: Bug > Components: Tools and Build >Affects Versions: 1.5.0 >Reporter: Joseph Witt >Assignee: Joseph Witt > Fix For: 1.5.0 > > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (NIFI-4650) Add Hadoop HttpCore property independent of the HttpClient property
[ https://issues.apache.org/jira/browse/NIFI-4650?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joseph Witt updated NIFI-4650: -- Resolution: Fixed Status: Resolved (was: Patch Available) > Add Hadoop HttpCore property independent of the HttpClient property > --- > > Key: NIFI-4650 > URL: https://issues.apache.org/jira/browse/NIFI-4650 > Project: Apache NiFi > Issue Type: Improvement >Reporter: Joey Frazee >Assignee: Joey Frazee >Priority: Minor > Fix For: 1.5.0 > > > Apache HttpComponents versions HttpClient and HttpCore independently (e.g., > 4.5.2 and 4.4.4 used in Hadoop 2.8.x) so overriding > hadoop.http.client.version with certain versions of HttpClient or HttpCore > isn't currently possible. We should add a separate hadoop.http.core.version > to pom.xml and nifi-nar-bundles/nifi-hadoop-libraries-bundle/pom.xml. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Created] (NIFI-4751) Release Management for Apache NiFi 1.5.0 RC
Joseph Witt created NIFI-4751: - Summary: Release Management for Apache NiFi 1.5.0 RC Key: NIFI-4751 URL: https://issues.apache.org/jira/browse/NIFI-4751 Project: Apache NiFi Issue Type: Bug Components: Tools and Build Affects Versions: 1.5.0 Reporter: Joseph Witt Assignee: Joseph Witt Fix For: 1.5.0 -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (NIFI-4421) Clone Issues with ProcessGroupStatus
[ https://issues.apache.org/jira/browse/NIFI-4421?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joseph Witt updated NIFI-4421: -- Fix Version/s: (was: 1.5.0) > Clone Issues with ProcessGroupStatus > > > Key: NIFI-4421 > URL: https://issues.apache.org/jira/browse/NIFI-4421 > Project: Apache NiFi > Issue Type: Bug > Components: Core Framework >Affects Versions: 1.3.0, 1.4.0 >Reporter: Rob Leimbach >Priority: Minor > Attachments: NIFI-4421.patch > > > An HP Fortify scan of > nifi-api/src/main/java/org/apache/nifi/controller/status/ProcessGroupStatus.java > reports the following issues with the use of the clone method. > 1) The clone() method calls a function that can be overridden by an attacker. > This may cause the clone to be left in a partially initialized state, or > become corrupted. > Functions that clone objects and make calls to functions that can be > overridden should specify these functions as final or specify the class as > final. Alternatively, if this code is only needed in the clone() function, > the private access specifier can be used, or the logic could be placed > directly into the clone itself. > 2) When implementing clone(), one should call super.clone() to obtain a new > object. If a class fails to follow this convention, a subclass's clone() > method will return an object of the wrong type. By calling super.clone(), the > java.lang.Object implementation of clone() will always return an object of > the correct type. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (NIFI-4289) Implement put processor for InfluxDB
[ https://issues.apache.org/jira/browse/NIFI-4289?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16317418#comment-16317418 ] ASF GitHub Bot commented on NIFI-4289: -- Github user joewitt commented on a diff in the pull request: https://github.com/apache/nifi/pull/2101#discussion_r160293228 --- Diff: nifi-nar-bundles/nifi-influxdb-bundle/nifi-influxdb-nar/src/main/resources/META-INF/NOTICE --- @@ -0,0 +1,28 @@ +nifi-influxdb-nar +Copyright 2017 The Apache Software Foundation + +This product includes software developed at +The Apache Software Foundation (http://www.apache.org/). + +=== +MIT License +=== + +The following binary components are provided under the MIT License + + The MIT License (MIT) --- End diff -- same comment as before. No MIT license section belongs in NOTICE. Only LICENSE. thanks > Implement put processor for InfluxDB > > > Key: NIFI-4289 > URL: https://issues.apache.org/jira/browse/NIFI-4289 > Project: Apache NiFi > Issue Type: New Feature > Components: Extensions >Affects Versions: 1.3.0 > Environment: All >Reporter: Mans Singh >Assignee: Mans Singh >Priority: Minor > Labels: insert, measurements,, put, timeseries > > Support inserting time series measurements into InfluxDB. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[GitHub] nifi pull request #2101: NIFI-4289 - InfluxDB put processor
Github user joewitt commented on a diff in the pull request: https://github.com/apache/nifi/pull/2101#discussion_r160293228 --- Diff: nifi-nar-bundles/nifi-influxdb-bundle/nifi-influxdb-nar/src/main/resources/META-INF/NOTICE --- @@ -0,0 +1,28 @@ +nifi-influxdb-nar +Copyright 2017 The Apache Software Foundation + +This product includes software developed at +The Apache Software Foundation (http://www.apache.org/). + +=== +MIT License +=== + +The following binary components are provided under the MIT License + + The MIT License (MIT) --- End diff -- same comment as before. No MIT license section belongs in NOTICE. Only LICENSE. thanks ---
[GitHub] nifi pull request #2101: NIFI-4289 - InfluxDB put processor
Github user joewitt commented on a diff in the pull request: https://github.com/apache/nifi/pull/2101#discussion_r160293115 --- Diff: nifi-assembly/NOTICE --- @@ -1543,6 +1543,7 @@ The following binary components are provided under the MIT License. See project (MIT License) EWS Java API (com.microsoft.ews-java-api:ews-java-api:2.0 - https://github.com/OfficeDev/ews-java-api) (MIT License) libffi (libffi-3.2.1 - http://sourceware.org/libffi/) + (MIT License) InfluxDB (org.influxdb:influxdb-java:2.7 https://github.com/influxdata/influxdb-java/) --- End diff -- there should not be any (MIT License) section in our NOTICE. These all belong in the LICENSE. I will move these other ones in the current master though ---
[jira] [Commented] (NIFI-4289) Implement put processor for InfluxDB
[ https://issues.apache.org/jira/browse/NIFI-4289?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16317417#comment-16317417 ] ASF GitHub Bot commented on NIFI-4289: -- Github user joewitt commented on a diff in the pull request: https://github.com/apache/nifi/pull/2101#discussion_r160293115 --- Diff: nifi-assembly/NOTICE --- @@ -1543,6 +1543,7 @@ The following binary components are provided under the MIT License. See project (MIT License) EWS Java API (com.microsoft.ews-java-api:ews-java-api:2.0 - https://github.com/OfficeDev/ews-java-api) (MIT License) libffi (libffi-3.2.1 - http://sourceware.org/libffi/) + (MIT License) InfluxDB (org.influxdb:influxdb-java:2.7 https://github.com/influxdata/influxdb-java/) --- End diff -- there should not be any (MIT License) section in our NOTICE. These all belong in the LICENSE. I will move these other ones in the current master though > Implement put processor for InfluxDB > > > Key: NIFI-4289 > URL: https://issues.apache.org/jira/browse/NIFI-4289 > Project: Apache NiFi > Issue Type: New Feature > Components: Extensions >Affects Versions: 1.3.0 > Environment: All >Reporter: Mans Singh >Assignee: Mans Singh >Priority: Minor > Labels: insert, measurements,, put, timeseries > > Support inserting time series measurements into InfluxDB. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (NIFI-4289) Implement put processor for InfluxDB
[ https://issues.apache.org/jira/browse/NIFI-4289?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joseph Witt updated NIFI-4289: -- Fix Version/s: (was: 1.5.0) > Implement put processor for InfluxDB > > > Key: NIFI-4289 > URL: https://issues.apache.org/jira/browse/NIFI-4289 > Project: Apache NiFi > Issue Type: New Feature > Components: Extensions >Affects Versions: 1.3.0 > Environment: All >Reporter: Mans Singh >Assignee: Mans Singh >Priority: Minor > Labels: insert, measurements,, put, timeseries > > Support inserting time series measurements into InfluxDB. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (NIFI-4625) Add External Versioning to PutElasticSearch5 Processor
[ https://issues.apache.org/jira/browse/NIFI-4625?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16317406#comment-16317406 ] Joseph Witt commented on NIFI-4625: --- lets set the fix version once review wraps up. [~mattyb149] you still looking at this one? > Add External Versioning to PutElasticSearch5 Processor > -- > > Key: NIFI-4625 > URL: https://issues.apache.org/jira/browse/NIFI-4625 > Project: Apache NiFi > Issue Type: Improvement > Components: Core Framework >Affects Versions: 1.3.0 > Environment: All >Reporter: Pedro Gomes >Assignee: Pedro Gomes > Labels: elasticsearch, processor > Original Estimate: 48h > Remaining Estimate: 48h > > Currently the PutElasticSearch5 processor does not support external > versioning. > The idea would be to add a property that follows the same logic as the Id > property, and allows index documents with an externally controlled version. > I've changed the code already and added some tests. Right now the changes > proposed are: > - Add a new property Version in the processor block. > - Change the Index operation to support the versioning number and versioning > type = external > - Check if the versioning is used with other operation types, fail if so. > (Idea behind this is that the bulk api doest not support external versioning > for any other operation except Index) -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (NIFI-4625) Add External Versioning to PutElasticSearch5 Processor
[ https://issues.apache.org/jira/browse/NIFI-4625?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joseph Witt updated NIFI-4625: -- Fix Version/s: (was: 1.5.0) > Add External Versioning to PutElasticSearch5 Processor > -- > > Key: NIFI-4625 > URL: https://issues.apache.org/jira/browse/NIFI-4625 > Project: Apache NiFi > Issue Type: Improvement > Components: Core Framework >Affects Versions: 1.3.0 > Environment: All >Reporter: Pedro Gomes >Assignee: Pedro Gomes > Labels: elasticsearch, processor > Original Estimate: 48h > Remaining Estimate: 48h > > Currently the PutElasticSearch5 processor does not support external > versioning. > The idea would be to add a property that follows the same logic as the Id > property, and allows index documents with an externally controlled version. > I've changed the code already and added some tests. Right now the changes > proposed are: > - Add a new property Version in the processor block. > - Change the Index operation to support the versioning number and versioning > type = external > - Check if the versioning is used with other operation types, fail if so. > (Idea behind this is that the bulk api doest not support external versioning > for any other operation except Index) -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (NIFI-4540) Support for AWS SQS FIFO message queue
[ https://issues.apache.org/jira/browse/NIFI-4540?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joseph Witt updated NIFI-4540: -- Fix Version/s: (was: 1.5.0) > Support for AWS SQS FIFO message queue > -- > > Key: NIFI-4540 > URL: https://issues.apache.org/jira/browse/NIFI-4540 > Project: Apache NiFi > Issue Type: Improvement > Components: Core Framework >Affects Versions: 1.4.0 >Reporter: Dorian Bugeja > Labels: easyfix, features, newbie > Attachments: NIFI-4540 - Support for AWS SQS FIFO message queue.patch > > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (NIFI-4651) PutSQL should return error messages and error codes in an attribute
[ https://issues.apache.org/jira/browse/NIFI-4651?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joseph Witt updated NIFI-4651: -- Fix Version/s: (was: 1.5.0) > PutSQL should return error messages and error codes in an attribute > --- > > Key: NIFI-4651 > URL: https://issues.apache.org/jira/browse/NIFI-4651 > Project: Apache NiFi > Issue Type: Improvement >Affects Versions: 1.4.0 >Reporter: Kay-Uwe Moosheimer > > In case of an error PutSQL should return the error messages and the error > code in attributes to be able to edit each FlowFile manually or automatically > according to the error. > A selection "Return errors" -> "Yes/No" and the possibility to specify two > attribute names (one for error message and one for error code) would be > helpful for postprocessing. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (NIFI-4698) Nifi Open ID Connect with Azure Active Directory fails to extract email from UserInfoToken
[ https://issues.apache.org/jira/browse/NIFI-4698?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joseph Witt updated NIFI-4698: -- Fix Version/s: (was: 1.5.0) > Nifi Open ID Connect with Azure Active Directory fails to extract email from > UserInfoToken > -- > > Key: NIFI-4698 > URL: https://issues.apache.org/jira/browse/NIFI-4698 > Project: Apache NiFi > Issue Type: Improvement > Components: Core Framework >Affects Versions: 1.4.0 > Environment: Microsoft Azure >Reporter: Raghu Somasundaram > > While integrating with Microsoft Azure Active Directory through > OpenIDConnect, Azure AD sends back Json response without "email" attribute. > This causes Nifi to throw following exception: > 2017-12-12 16:34:20,442 ERROR [NiFi Web Server-67] > org.apache.nifi.web.api.AccessResource Unable to exchange authorization for > ID token: Unable to extract email from the UserInfo token. > java.lang.IllegalStateException: Unable to extract email from the UserInfo > token. > at > org.apache.nifi.web.security.oidc.StandardOidcIdentityProvider.lookupEmail(StandardOidcIdentityProvider.java:352) > at > org.apache.nifi.web.security.oidc.StandardOidcIdentityProvider.exchangeAuthorizationCode(StandardOidcIdentityProvider.java:306) > at > org.apache.nifi.web.security.oidc.OidcService.exchangeAuthorizationCode(OidcService.java:192) > at > org.apache.nifi.web.api.AccessResource.oidcCallback(AccessResource.java:256) > at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) > at > sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) > at > sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) > at java.lang.reflect.Method.invoke(Method.java:498) > at > com.sun.jersey.spi.container.JavaMethodInvokerFactory$1.invoke(JavaMethodInvokerFactory.java:60) > at > com.sun.jersey.server.impl.model.method.dispatch.AbstractResourceMethodDispatchProvider$VoidOutInvoker._dispatch(AbstractResourceMethodDispatchProvider.java:167) > at > com.sun.jersey.server.impl.model.method.dispatch.ResourceJavaMethodDispatcher.dispatch(ResourceJavaMethodDispatcher.java:75) > The workaround is to extract "upn" attribute for email. This code fix checks > the json response for "email" attribute. If email is empty, it returns "upn" > value as email. If both email and upn are empty, we thrown the same exception > as above. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Resolved] (NIFI-4435) Update NiFi UI to include Registry integration
[ https://issues.apache.org/jira/browse/NIFI-4435?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joseph Witt resolved NIFI-4435. --- Resolution: Fixed > Update NiFi UI to include Registry integration > -- > > Key: NIFI-4435 > URL: https://issues.apache.org/jira/browse/NIFI-4435 > Project: Apache NiFi > Issue Type: New Feature > Components: Core Framework, Core UI >Reporter: Matt Gilman >Assignee: Matt Gilman >Priority: Critical > Fix For: 1.5.0 > > > NiFi UI and Web API need to be updated to support controls for versioning > dataflows. This JIRA will act as a parent ticket for the various tasks > required for this integration. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (NIFI-4420) On startup the component selection should take into account all known coordinates
[ https://issues.apache.org/jira/browse/NIFI-4420?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joseph Witt updated NIFI-4420: -- Fix Version/s: (was: 1.5.0) > On startup the component selection should take into account all known > coordinates > - > > Key: NIFI-4420 > URL: https://issues.apache.org/jira/browse/NIFI-4420 > Project: Apache NiFi > Issue Type: Bug > Components: Core Framework >Affects Versions: 1.4.0 >Reporter: Joseph Witt > > During the RC1 vote for Apache NiFi 1.4.0 there were some mistakenly > duplicated LookupService/Controller services. That was wrong and needs to be > fixed. It did, however, expose a condition we should be able to handle > easily. > The case was a user with Apache NiFi 1.3.0 flow using > nar1:LookupService:1.3.0 upgraded to NiFi 1.4.0 which contained both a > nar1:LookupService:1.4.0 and nar2:LookupService:1.4.0. > His flow did not automatically upgrade nicely and instead he had to either > delete and recreate the component or change its version. This is because > right now on startup nifi notices the version that was being used is no > longer available and it sees two different versions available so it doesn't > know which one to select. However, that is only because it was not taking > advantage of the group (nar1) and instead only used the class name. If it > had used both the class name AND the group name it would have seen there is > still only one version available and automatically chosen it. > So we should take advantage of the group information when > selecting/determining which version to automatically select during an upgrade. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (NIFI-4502) Create UI for registering registry clients
[ https://issues.apache.org/jira/browse/NIFI-4502?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joseph Witt updated NIFI-4502: -- Resolution: Fixed Status: Resolved (was: Patch Available) > Create UI for registering registry clients > -- > > Key: NIFI-4502 > URL: https://issues.apache.org/jira/browse/NIFI-4502 > Project: Apache NiFi > Issue Type: Sub-task > Components: Core Framework, Core UI >Reporter: Matt Gilman >Assignee: Matt Gilman > Fix For: 1.5.0 > > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (MINIFICPP-359) Support anonymous connections in config.yml
[ https://issues.apache.org/jira/browse/MINIFICPP-359?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16317399#comment-16317399 ] ASF GitHub Bot commented on MINIFICPP-359: -- Github user phrocker commented on a diff in the pull request: https://github.com/apache/nifi-minifi-cpp/pull/231#discussion_r160290778 --- Diff: libminifi/include/core/yaml/YamlConfiguration.h --- @@ -245,11 +245,11 @@ class YamlConfiguration : public FlowConfiguration { * * @param yamlNode a pointer to the YAML::Node that will be checked for the * presence of an idField - * @param idField the string of the name of the idField to check for. This + * @param field the string of the name of the idField to check for. This * is optional and defaults to 'id' * @return the parsed or generated UUID string */ - std::string getOrGenerateId(YAML::Node *yamlNode, const std::string = "id"); + std::string getOrGenerateField(YAML::Node *yamlNode, const std::string = "id"); --- End diff -- What is the end goal of this PR? It seems that you want to generalize the function name to eventually be used elsewhere. > Support anonymous connections in config.yml > --- > > Key: MINIFICPP-359 > URL: https://issues.apache.org/jira/browse/MINIFICPP-359 > Project: NiFi MiNiFi C++ > Issue Type: Improvement >Reporter: Andrew Christianson >Assignee: Andrew Christianson >Priority: Minor > > Since connections are rarely, if ever, referenced by name or ID in a typical > config.yml, allow for anonymous (no ID and no name) connections. MiNiFi will > generate IDs for anonymous connections. This will make writing config.yml a > little simpler. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (NIFI-4487) ConsumerKafka V10 should write Kafka Timestamp attribute
[ https://issues.apache.org/jira/browse/NIFI-4487?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joseph Witt updated NIFI-4487: -- Fix Version/s: (was: 1.5.0) (was: 1.4.0) > ConsumerKafka V10 should write Kafka Timestamp attribute > > > Key: NIFI-4487 > URL: https://issues.apache.org/jira/browse/NIFI-4487 > Project: Apache NiFi > Issue Type: Improvement > Components: Extensions >Affects Versions: 1.4.0, 1.5.0 >Reporter: Pawel Niezgoda > Original Estimate: 1h > Remaining Estimate: 1h > > Starting from kafka v10 kafka provides info about message timestamp. > We should expose that data together with other attributes (like topic, > partition, offset). > We should add: > @WritesAttribute(attribute = KafkaProcessorUtils.KAFKA_TIMESTAMP, description > = "Kafka message timestamp"), > @WritesAttribute(attribute = > KafkaProcessorUtils.KAFKA_TIMESTAMP_TYPE, description = "Kafka message > timestamp type") -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[GitHub] nifi-minifi-cpp pull request #231: MINIFICPP-359 Generate connection name fi...
Github user phrocker commented on a diff in the pull request: https://github.com/apache/nifi-minifi-cpp/pull/231#discussion_r160290778 --- Diff: libminifi/include/core/yaml/YamlConfiguration.h --- @@ -245,11 +245,11 @@ class YamlConfiguration : public FlowConfiguration { * * @param yamlNode a pointer to the YAML::Node that will be checked for the * presence of an idField - * @param idField the string of the name of the idField to check for. This + * @param field the string of the name of the idField to check for. This * is optional and defaults to 'id' * @return the parsed or generated UUID string */ - std::string getOrGenerateId(YAML::Node *yamlNode, const std::string = "id"); + std::string getOrGenerateField(YAML::Node *yamlNode, const std::string = "id"); --- End diff -- What is the end goal of this PR? It seems that you want to generalize the function name to eventually be used elsewhere. ---
[jira] [Commented] (MINIFICPP-362) Handle case where no content exists for flow file.
[ https://issues.apache.org/jira/browse/MINIFICPP-362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16317385#comment-16317385 ] ASF GitHub Bot commented on MINIFICPP-362: -- GitHub user phrocker opened a pull request: https://github.com/apache/nifi-minifi-cpp/pull/233 MINIFICPP-362: Prevent segfault is there is no content for a flow file Thank you for submitting a contribution to Apache NiFi - MiNiFi C++. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all changes: - [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [ ] Does your PR title start with MINIFI- where is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character. - [ ] Has your PR been rebased against the latest commit within the target branch (typically master)? - [ ] Is your initial contribution a single, squashed commit? ### For code changes: - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? - [ ] If applicable, have you updated the LICENSE file? - [ ] If applicable, have you updated the NOTICE file? ### For documentation related changes: - [ ] Have you ensured that format looks appropriate for the output in which it is rendered? ### Note: Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible. You can merge this pull request into a Git repository by running: $ git pull https://github.com/phrocker/nifi-minifi-cpp MINIFI-362 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/nifi-minifi-cpp/pull/233.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #233 commit e52b1bc65b94787a883f33117e540ef1025c8d56 Author: Marc ParisiDate: 2018-01-09T00:05:11Z MINIFICPP-362: Prevent segfault is there is no content for a flow file > Handle case where no content exists for flow file. > --- > > Key: MINIFICPP-362 > URL: https://issues.apache.org/jira/browse/MINIFICPP-362 > Project: NiFi MiNiFi C++ > Issue Type: Bug >Reporter: marco polo >Assignee: marco polo > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[GitHub] nifi-minifi-cpp pull request #233: MINIFICPP-362: Prevent segfault is there ...
GitHub user phrocker opened a pull request: https://github.com/apache/nifi-minifi-cpp/pull/233 MINIFICPP-362: Prevent segfault is there is no content for a flow file Thank you for submitting a contribution to Apache NiFi - MiNiFi C++. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all changes: - [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [ ] Does your PR title start with MINIFI- where is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character. - [ ] Has your PR been rebased against the latest commit within the target branch (typically master)? - [ ] Is your initial contribution a single, squashed commit? ### For code changes: - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? - [ ] If applicable, have you updated the LICENSE file? - [ ] If applicable, have you updated the NOTICE file? ### For documentation related changes: - [ ] Have you ensured that format looks appropriate for the output in which it is rendered? ### Note: Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible. You can merge this pull request into a Git repository by running: $ git pull https://github.com/phrocker/nifi-minifi-cpp MINIFI-362 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/nifi-minifi-cpp/pull/233.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #233 commit e52b1bc65b94787a883f33117e540ef1025c8d56 Author: Marc ParisiDate: 2018-01-09T00:05:11Z MINIFICPP-362: Prevent segfault is there is no content for a flow file ---
[jira] [Commented] (NIFI-4747) GetHDFS Scheduling via CRON shows an error before it is scheduled
[ https://issues.apache.org/jira/browse/NIFI-4747?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16317369#comment-16317369 ] Joseph Witt commented on NIFI-4747: --- [~pvillard] [~jugi] I do agree with Julien that we should find a way to relax the constraint. We'd basically NOT validate that the given directory exists and instead at runtime find out whether the current directory exists or not. If not then we yield and warn and if yes we go for it. Validation for things like this (directory existence) are, speaking in hindsight terms, probably a mistake anyway. > GetHDFS Scheduling via CRON shows an error before it is scheduled > - > > Key: NIFI-4747 > URL: https://issues.apache.org/jira/browse/NIFI-4747 > Project: Apache NiFi > Issue Type: Bug > Components: Core Framework >Affects Versions: 1.2.0, 1.4.0 > Environment: Linux, Windows >Reporter: Julian Gimbel >Priority: Blocker > Attachments: gethdfs_cron_scheduling.PNG, > gethdfs_cron_scheduling_error.png > > > We schedule a getHDFS Processor CRON driven at "0 0 15 * * ?" so that it > should run at 15:00:00 every day. If we start the processor it gives an error > message even before CRON should have triggered the Processor as shown below. > The question is why that is happening and how can it be fixed? > 2018-01-08 14:43:01,242 ERROR [StandardProcessScheduler Thread-5] > o.a.n.controller.StandardProcessorNode Failed to invoke @OnScheduled method > due to java.lang.RuntimeException: Failed while executing one of processor's > OnScheduled task. > java.lang.RuntimeException: Failed while executing one of processor's > OnScheduled task. > at > org.apache.nifi.controller.StandardProcessorNode.invokeTaskAsCancelableFuture(StandardProcessorNode.java:1483) > at > org.apache.nifi.controller.StandardProcessorNode.access$000(StandardProcessorNode.java:103) > at > org.apache.nifi.controller.StandardProcessorNode$1.run(StandardProcessorNode.java:1302) > at > java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511) > at java.util.concurrent.FutureTask.run(FutureTask.java:266) > at > java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.access$201(ScheduledThreadPoolExecutor.java:180) > at > java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:293) > at > java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142) > at > java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617) > at java.lang.Thread.run(Thread.java:745) > Caused by: java.util.concurrent.ExecutionException: > java.lang.reflect.InvocationTargetException > at java.util.concurrent.FutureTask.report(FutureTask.java:122) > at java.util.concurrent.FutureTask.get(FutureTask.java:206) > at > org.apache.nifi.controller.StandardProcessorNode.invokeTaskAsCancelableFuture(StandardProcessorNode.java:1466) > ... 9 common frames omitted > Caused by: java.lang.reflect.InvocationTargetException: null > at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) > at > sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) > at > sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) > at java.lang.reflect.Method.invoke(Method.java:498) > at > org.apache.nifi.util.ReflectionUtils.invokeMethodsWithAnnotations(ReflectionUtils.java:137) > at > org.apache.nifi.util.ReflectionUtils.invokeMethodsWithAnnotations(ReflectionUtils.java:125) > at > org.apache.nifi.util.ReflectionUtils.invokeMethodsWithAnnotations(ReflectionUtils.java:70) > at > org.apache.nifi.util.ReflectionUtils.invokeMethodsWithAnnotation(ReflectionUtils.java:47) > at > org.apache.nifi.controller.StandardProcessorNode$1$1.call(StandardProcessorNode.java:1306) > at > org.apache.nifi.controller.StandardProcessorNode$1$1.call(StandardProcessorNode.java:1302) > ... 6 common frames omitted > Caused by: java.io.IOException: PropertyDescriptor > PropertyDescriptor[Directory] has invalid value > /nifi/pele/pele2rtdp/20180108. The directory does not exist. > at > org.apache.nifi.processors.hadoop.GetHDFS.onScheduled(GetHDFS.java:242) -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (NIFI-4747) GetHDFS Scheduling via CRON shows an error before it is scheduled
[ https://issues.apache.org/jira/browse/NIFI-4747?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16317359#comment-16317359 ] Pierre Villard commented on NIFI-4747: -- Changing the whole validation mechanism and when validation is performed would be a massive change at framework level and it would have a lot of implications. I think, however, that we can question the need to validate the directory existence during the validation process instead of only doing it in the trigger execution. I just had a look at the ListHDFS processor and it does not seem to perform this directory validation. I'd suggest you considering the List/Fetch HDFS couple of processors to perform your task. I'll let others chime in to decide if we should remove this part in the custom validate method of GetHDFS. > GetHDFS Scheduling via CRON shows an error before it is scheduled > - > > Key: NIFI-4747 > URL: https://issues.apache.org/jira/browse/NIFI-4747 > Project: Apache NiFi > Issue Type: Bug > Components: Core Framework >Affects Versions: 1.2.0, 1.4.0 > Environment: Linux, Windows >Reporter: Julian Gimbel >Priority: Blocker > Attachments: gethdfs_cron_scheduling.PNG, > gethdfs_cron_scheduling_error.png > > > We schedule a getHDFS Processor CRON driven at "0 0 15 * * ?" so that it > should run at 15:00:00 every day. If we start the processor it gives an error > message even before CRON should have triggered the Processor as shown below. > The question is why that is happening and how can it be fixed? > 2018-01-08 14:43:01,242 ERROR [StandardProcessScheduler Thread-5] > o.a.n.controller.StandardProcessorNode Failed to invoke @OnScheduled method > due to java.lang.RuntimeException: Failed while executing one of processor's > OnScheduled task. > java.lang.RuntimeException: Failed while executing one of processor's > OnScheduled task. > at > org.apache.nifi.controller.StandardProcessorNode.invokeTaskAsCancelableFuture(StandardProcessorNode.java:1483) > at > org.apache.nifi.controller.StandardProcessorNode.access$000(StandardProcessorNode.java:103) > at > org.apache.nifi.controller.StandardProcessorNode$1.run(StandardProcessorNode.java:1302) > at > java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511) > at java.util.concurrent.FutureTask.run(FutureTask.java:266) > at > java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.access$201(ScheduledThreadPoolExecutor.java:180) > at > java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:293) > at > java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142) > at > java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617) > at java.lang.Thread.run(Thread.java:745) > Caused by: java.util.concurrent.ExecutionException: > java.lang.reflect.InvocationTargetException > at java.util.concurrent.FutureTask.report(FutureTask.java:122) > at java.util.concurrent.FutureTask.get(FutureTask.java:206) > at > org.apache.nifi.controller.StandardProcessorNode.invokeTaskAsCancelableFuture(StandardProcessorNode.java:1466) > ... 9 common frames omitted > Caused by: java.lang.reflect.InvocationTargetException: null > at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) > at > sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) > at > sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) > at java.lang.reflect.Method.invoke(Method.java:498) > at > org.apache.nifi.util.ReflectionUtils.invokeMethodsWithAnnotations(ReflectionUtils.java:137) > at > org.apache.nifi.util.ReflectionUtils.invokeMethodsWithAnnotations(ReflectionUtils.java:125) > at > org.apache.nifi.util.ReflectionUtils.invokeMethodsWithAnnotations(ReflectionUtils.java:70) > at > org.apache.nifi.util.ReflectionUtils.invokeMethodsWithAnnotation(ReflectionUtils.java:47) > at > org.apache.nifi.controller.StandardProcessorNode$1$1.call(StandardProcessorNode.java:1306) > at > org.apache.nifi.controller.StandardProcessorNode$1$1.call(StandardProcessorNode.java:1302) > ... 6 common frames omitted > Caused by: java.io.IOException: PropertyDescriptor > PropertyDescriptor[Directory] has invalid value > /nifi/pele/pele2rtdp/20180108. The directory does not exist. > at > org.apache.nifi.processors.hadoop.GetHDFS.onScheduled(GetHDFS.java:242) -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Resolved] (NIFI-4727) Create text count processor
[ https://issues.apache.org/jira/browse/NIFI-4727?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andy LoPresto resolved NIFI-4727. - Resolution: Fixed Fix Version/s: 1.5.0 > Create text count processor > --- > > Key: NIFI-4727 > URL: https://issues.apache.org/jira/browse/NIFI-4727 > Project: Apache NiFi > Issue Type: New Feature > Components: Extensions >Affects Versions: 1.4.0 >Reporter: Andy LoPresto >Assignee: Andy LoPresto > Labels: processor, text > Fix For: 1.5.0 > > > A frequent community request is to count (lines/words/characters) in > arbitrary text. A {{CountTextProcessor}} would provide this functionality > natively and with solid performance, rather than abusing the {{SplitText}} or > {{ExecuteScript}} processors. > It should provide the following functionality (simultaneously, given options): > * Line count > * Non-empty line count > * Word count > * Character count > The flowfile content should remain unchanged, and each of the above (if > indicated) should be added as an attribute. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (NIFI-4727) Create text count processor
[ https://issues.apache.org/jira/browse/NIFI-4727?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16317236#comment-16317236 ] ASF GitHub Bot commented on NIFI-4727: -- Github user asfgit closed the pull request at: https://github.com/apache/nifi/pull/2371 > Create text count processor > --- > > Key: NIFI-4727 > URL: https://issues.apache.org/jira/browse/NIFI-4727 > Project: Apache NiFi > Issue Type: New Feature > Components: Extensions >Affects Versions: 1.4.0 >Reporter: Andy LoPresto >Assignee: Andy LoPresto > Labels: processor, text > > A frequent community request is to count (lines/words/characters) in > arbitrary text. A {{CountTextProcessor}} would provide this functionality > natively and with solid performance, rather than abusing the {{SplitText}} or > {{ExecuteScript}} processors. > It should provide the following functionality (simultaneously, given options): > * Line count > * Non-empty line count > * Word count > * Character count > The flowfile content should remain unchanged, and each of the above (if > indicated) should be added as an attribute. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (NIFI-4727) Create text count processor
[ https://issues.apache.org/jira/browse/NIFI-4727?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16317235#comment-16317235 ] ASF subversion and git services commented on NIFI-4727: --- Commit a7f1eb89c23e90f813be12adc4dca99de36c7c15 in nifi's branch refs/heads/master from [~alopresto] [ https://git-wip-us.apache.org/repos/asf?p=nifi.git;h=a7f1eb8 ] NIFI-4727 Added CountText processor and unit test. This closes #2371. Signed-off-by: Kevin Doran> Create text count processor > --- > > Key: NIFI-4727 > URL: https://issues.apache.org/jira/browse/NIFI-4727 > Project: Apache NiFi > Issue Type: New Feature > Components: Extensions >Affects Versions: 1.4.0 >Reporter: Andy LoPresto >Assignee: Andy LoPresto > Labels: processor, text > > A frequent community request is to count (lines/words/characters) in > arbitrary text. A {{CountTextProcessor}} would provide this functionality > natively and with solid performance, rather than abusing the {{SplitText}} or > {{ExecuteScript}} processors. > It should provide the following functionality (simultaneously, given options): > * Line count > * Non-empty line count > * Word count > * Character count > The flowfile content should remain unchanged, and each of the above (if > indicated) should be added as an attribute. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[GitHub] nifi pull request #2371: NIFI-4727 Add CountText processor
Github user asfgit closed the pull request at: https://github.com/apache/nifi/pull/2371 ---
[jira] [Commented] (MINIFICPP-357) Upgrade YAML parsing to support version 3 of the config schema and work with later toolkits
[ https://issues.apache.org/jira/browse/MINIFICPP-357?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16317210#comment-16317210 ] ASF GitHub Bot commented on MINIFICPP-357: -- Github user apiri commented on the issue: https://github.com/apache/nifi-minifi-cpp/pull/230 Overall this looks okay but uncovered a wrong assumption in the MiNiFi Toolkit that does YAML transformations. I am looking into that a bit to verify a couple of things but can likely move this one ahead. Will follow up and thanks! > Upgrade YAML parsing to support version 3 of the config schema and work with > later toolkits > --- > > Key: MINIFICPP-357 > URL: https://issues.apache.org/jira/browse/MINIFICPP-357 > Project: NiFi MiNiFi C++ > Issue Type: Improvement >Reporter: Aldrin Piri >Assignee: Andrew Christianson > Fix For: 0.4.0 > > Attachments: 1.4-Template.xml, 1.5-Template.xml > > > Currently minificpp makes use of what is effectively YAML, v1 and requires > the usage of the 0.0.1 toolkit to perform transformations. We should get > these in sync across agent implementations and allow users to make use of one > toolkit for performing transformations. > Scope involves mapping v3 config to what is currently supported. Not all > features in reference config files (e.g. dynamic properties) are yet > supported in MiNiFi. Support of those features is out of scope. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[GitHub] nifi-minifi-cpp issue #230: MINIFICPP-357 Added support for config YAML v3.
Github user apiri commented on the issue: https://github.com/apache/nifi-minifi-cpp/pull/230 Overall this looks okay but uncovered a wrong assumption in the MiNiFi Toolkit that does YAML transformations. I am looking into that a bit to verify a couple of things but can likely move this one ahead. Will follow up and thanks! ---
[jira] [Commented] (MINIFICPP-358) Implement TFExtractTopLabels
[ https://issues.apache.org/jira/browse/MINIFICPP-358?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16317201#comment-16317201 ] ASF GitHub Bot commented on MINIFICPP-358: -- GitHub user achristianson opened a pull request: https://github.com/apache/nifi-minifi-cpp/pull/232 MINIFICPP-358 Added TFExtractTopLabels Thank you for submitting a contribution to Apache NiFi - MiNiFi C++. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all changes: - [x] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [x] Does your PR title start with MINIFI- where is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character. - [x] Has your PR been rebased against the latest commit within the target branch (typically master)? - [x] Is your initial contribution a single, squashed commit? ### For code changes: - [x] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? - [x] If applicable, have you updated the LICENSE file? - [x] If applicable, have you updated the NOTICE file? ### For documentation related changes: - [x] Have you ensured that format looks appropriate for the output in which it is rendered? ### Note: Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible. You can merge this pull request into a Git repository by running: $ git pull https://github.com/achristianson/nifi-minifi-cpp MINIFICPP-358 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/nifi-minifi-cpp/pull/232.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #232 commit 5deea0dcae2fbf98d9537249a72762dc18229bff Author: Andy I. ChristiansonDate: 2018-01-08T22:13:27Z MINIFICPP-358 Added TFExtractTopLabels > Implement TFExtractTopLabels > > > Key: MINIFICPP-358 > URL: https://issues.apache.org/jira/browse/MINIFICPP-358 > Project: NiFi MiNiFi C++ > Issue Type: Improvement >Reporter: Andrew Christianson > > Add support for interpreting output tensors which represent labels with > scores. A list of labels in index order is passed in with attribute tf.type > == "labels". The top N labels are extracted into attributes tf.label. and > tf.score.. The tf.label.0 attribute represents the highest-scoring label > and can be used, for example, to route FlowFiles based on model inferences. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[GitHub] nifi-minifi-cpp pull request #232: MINIFICPP-358 Added TFExtractTopLabels
GitHub user achristianson opened a pull request: https://github.com/apache/nifi-minifi-cpp/pull/232 MINIFICPP-358 Added TFExtractTopLabels Thank you for submitting a contribution to Apache NiFi - MiNiFi C++. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all changes: - [x] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [x] Does your PR title start with MINIFI- where is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character. - [x] Has your PR been rebased against the latest commit within the target branch (typically master)? - [x] Is your initial contribution a single, squashed commit? ### For code changes: - [x] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? - [x] If applicable, have you updated the LICENSE file? - [x] If applicable, have you updated the NOTICE file? ### For documentation related changes: - [x] Have you ensured that format looks appropriate for the output in which it is rendered? ### Note: Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible. You can merge this pull request into a Git repository by running: $ git pull https://github.com/achristianson/nifi-minifi-cpp MINIFICPP-358 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/nifi-minifi-cpp/pull/232.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #232 commit 5deea0dcae2fbf98d9537249a72762dc18229bff Author: Andy I. ChristiansonDate: 2018-01-08T22:13:27Z MINIFICPP-358 Added TFExtractTopLabels ---
[jira] [Commented] (MINIFICPP-357) Upgrade YAML parsing to support version 3 of the config schema and work with later toolkits
[ https://issues.apache.org/jira/browse/MINIFICPP-357?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16317185#comment-16317185 ] ASF GitHub Bot commented on MINIFICPP-357: -- Github user achristianson commented on a diff in the pull request: https://github.com/apache/nifi-minifi-cpp/pull/230#discussion_r160269055 --- Diff: libminifi/include/core/yaml/YamlConfiguration.h --- @@ -40,13 +40,18 @@ namespace core { #define CONFIG_YAML_CONNECTIONS_KEY "Connections" #define CONFIG_YAML_CONTROLLER_SERVICES_KEY "Controller Services" #define CONFIG_YAML_REMOTE_PROCESS_GROUP_KEY "Remote Processing Groups" +#define CONFIG_YAML_REMOTE_PROCESS_GROUP_KEY_V3 "Remote Process Groups" #define CONFIG_YAML_PROVENANCE_REPORT_KEY "Provenance Reporting" class YamlConfiguration : public FlowConfiguration { public: - explicit YamlConfiguration(std::shared_ptr repo, std::shared_ptr flow_file_repo, std::shared_ptr content_repo, - std::shared_ptr stream_factory, std::shared_ptr configuration, const std::string path = DEFAULT_FLOW_YAML_FILE_NAME) + explicit YamlConfiguration(std::shared_ptr repo, --- End diff -- Will fix. > Upgrade YAML parsing to support version 3 of the config schema and work with > later toolkits > --- > > Key: MINIFICPP-357 > URL: https://issues.apache.org/jira/browse/MINIFICPP-357 > Project: NiFi MiNiFi C++ > Issue Type: Improvement >Reporter: Aldrin Piri >Assignee: Andrew Christianson > Fix For: 0.4.0 > > Attachments: 1.4-Template.xml, 1.5-Template.xml > > > Currently minificpp makes use of what is effectively YAML, v1 and requires > the usage of the 0.0.1 toolkit to perform transformations. We should get > these in sync across agent implementations and allow users to make use of one > toolkit for performing transformations. > Scope involves mapping v3 config to what is currently supported. Not all > features in reference config files (e.g. dynamic properties) are yet > supported in MiNiFi. Support of those features is out of scope. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[GitHub] nifi-minifi-cpp pull request #230: MINIFICPP-357 Added support for config YA...
Github user achristianson commented on a diff in the pull request: https://github.com/apache/nifi-minifi-cpp/pull/230#discussion_r160269055 --- Diff: libminifi/include/core/yaml/YamlConfiguration.h --- @@ -40,13 +40,18 @@ namespace core { #define CONFIG_YAML_CONNECTIONS_KEY "Connections" #define CONFIG_YAML_CONTROLLER_SERVICES_KEY "Controller Services" #define CONFIG_YAML_REMOTE_PROCESS_GROUP_KEY "Remote Processing Groups" +#define CONFIG_YAML_REMOTE_PROCESS_GROUP_KEY_V3 "Remote Process Groups" #define CONFIG_YAML_PROVENANCE_REPORT_KEY "Provenance Reporting" class YamlConfiguration : public FlowConfiguration { public: - explicit YamlConfiguration(std::shared_ptr repo, std::shared_ptr flow_file_repo, std::shared_ptr content_repo, - std::shared_ptr stream_factory, std::shared_ptr configuration, const std::string path = DEFAULT_FLOW_YAML_FILE_NAME) + explicit YamlConfiguration(std::shared_ptr repo, --- End diff -- Will fix. ---
[GitHub] nifi-minifi-cpp pull request #230: MINIFICPP-357 Added support for config YA...
Github user phrocker commented on a diff in the pull request: https://github.com/apache/nifi-minifi-cpp/pull/230#discussion_r160268671 --- Diff: libminifi/include/core/yaml/YamlConfiguration.h --- @@ -40,13 +40,18 @@ namespace core { #define CONFIG_YAML_CONNECTIONS_KEY "Connections" #define CONFIG_YAML_CONTROLLER_SERVICES_KEY "Controller Services" #define CONFIG_YAML_REMOTE_PROCESS_GROUP_KEY "Remote Processing Groups" +#define CONFIG_YAML_REMOTE_PROCESS_GROUP_KEY_V3 "Remote Process Groups" #define CONFIG_YAML_PROVENANCE_REPORT_KEY "Provenance Reporting" class YamlConfiguration : public FlowConfiguration { public: - explicit YamlConfiguration(std::shared_ptr repo, std::shared_ptr flow_file_repo, std::shared_ptr content_repo, - std::shared_ptr stream_factory, std::shared_ptr configuration, const std::string path = DEFAULT_FLOW_YAML_FILE_NAME) + explicit YamlConfiguration(std::shared_ptr repo, --- End diff -- Did you shorten the line length? I think we abide by 200 characters as per nifi. ---
[jira] [Commented] (MINIFICPP-357) Upgrade YAML parsing to support version 3 of the config schema and work with later toolkits
[ https://issues.apache.org/jira/browse/MINIFICPP-357?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16317183#comment-16317183 ] ASF GitHub Bot commented on MINIFICPP-357: -- Github user phrocker commented on a diff in the pull request: https://github.com/apache/nifi-minifi-cpp/pull/230#discussion_r160268671 --- Diff: libminifi/include/core/yaml/YamlConfiguration.h --- @@ -40,13 +40,18 @@ namespace core { #define CONFIG_YAML_CONNECTIONS_KEY "Connections" #define CONFIG_YAML_CONTROLLER_SERVICES_KEY "Controller Services" #define CONFIG_YAML_REMOTE_PROCESS_GROUP_KEY "Remote Processing Groups" +#define CONFIG_YAML_REMOTE_PROCESS_GROUP_KEY_V3 "Remote Process Groups" #define CONFIG_YAML_PROVENANCE_REPORT_KEY "Provenance Reporting" class YamlConfiguration : public FlowConfiguration { public: - explicit YamlConfiguration(std::shared_ptr repo, std::shared_ptr flow_file_repo, std::shared_ptr content_repo, - std::shared_ptr stream_factory, std::shared_ptr configuration, const std::string path = DEFAULT_FLOW_YAML_FILE_NAME) + explicit YamlConfiguration(std::shared_ptr repo, --- End diff -- Did you shorten the line length? I think we abide by 200 characters as per nifi. > Upgrade YAML parsing to support version 3 of the config schema and work with > later toolkits > --- > > Key: MINIFICPP-357 > URL: https://issues.apache.org/jira/browse/MINIFICPP-357 > Project: NiFi MiNiFi C++ > Issue Type: Improvement >Reporter: Aldrin Piri >Assignee: Andrew Christianson > Fix For: 0.4.0 > > Attachments: 1.4-Template.xml, 1.5-Template.xml > > > Currently minificpp makes use of what is effectively YAML, v1 and requires > the usage of the 0.0.1 toolkit to perform transformations. We should get > these in sync across agent implementations and allow users to make use of one > toolkit for performing transformations. > Scope involves mapping v3 config to what is currently supported. Not all > features in reference config files (e.g. dynamic properties) are yet > supported in MiNiFi. Support of those features is out of scope. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Created] (NIFIREG-107) "Add Users to Group" dialog should have text in title case
Andrew Lim created NIFIREG-107: -- Summary: "Add Users to Group" dialog should have text in title case Key: NIFIREG-107 URL: https://issues.apache.org/jira/browse/NIFIREG-107 Project: NiFi Registry Issue Type: Improvement Affects Versions: 0.1.0 Reporter: Andrew Lim Priority: Trivial As shown in the attached screenshot, the dialog text should be changed from "Add users to group" to "Add Users to Group". -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Resolved] (MINIFICPP-312) Resolve CompressContentsTest by installing xz with brew
[ https://issues.apache.org/jira/browse/MINIFICPP-312?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aldrin Piri resolved MINIFICPP-312. --- Resolution: Fixed Assignee: marco polo Fix Version/s: 0.4.0 > Resolve CompressContentsTest by installing xz with brew > --- > > Key: MINIFICPP-312 > URL: https://issues.apache.org/jira/browse/MINIFICPP-312 > Project: NiFi MiNiFi C++ > Issue Type: Bug >Reporter: marco polo >Assignee: marco polo >Priority: Minor > Fix For: 0.4.0 > > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Resolved] (NIFI-4750) Authorizer not properly shutting down
[ https://issues.apache.org/jira/browse/NIFI-4750?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matt Gilman resolved NIFI-4750. --- Resolution: Fixed Fix Version/s: 1.5.0 > Authorizer not properly shutting down > - > > Key: NIFI-4750 > URL: https://issues.apache.org/jira/browse/NIFI-4750 > Project: Apache NiFi > Issue Type: Bug >Affects Versions: 1.4.0 >Reporter: Bryan Bende >Assignee: Bryan Bende >Priority: Minor > Fix For: 1.5.0 > > > I was running a NiFi instance configured with the StandardManagedAuthorizer, > using a file-based policy provider, and a composite user-group-provider > (file-based and ldap providers). > Whenever I shutdown I noticed it was taking a long time and forcibly shutting > down. A thread dump showed that the Ldap sync thread was still running which > led me to look at how the auhorizers shutdown. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (NIFIREG-106) The "y" in Identity appears to be cut off at the bottom in several places in the UI
[ https://issues.apache.org/jira/browse/NIFIREG-106?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Lim updated NIFIREG-106: --- Attachment: edit_user_panel.png add_user_dialog.png edit_bucket_pane.png > The "y" in Identity appears to be cut off at the bottom in several places in > the UI > --- > > Key: NIFIREG-106 > URL: https://issues.apache.org/jira/browse/NIFIREG-106 > Project: NiFi Registry > Issue Type: Improvement >Affects Versions: 0.1.0 >Reporter: Andrew Lim >Priority: Trivial > Attachments: add_user_dialog.png, edit_bucket_pane.png, > edit_user_panel.png > > > Attaching screenshots for the places I've noticed: > * Add User dialog > * Edit User panel > * Edit Bucket panel -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (NIFI-4750) Authorizer not properly shutting down
[ https://issues.apache.org/jira/browse/NIFI-4750?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16317135#comment-16317135 ] ASF GitHub Bot commented on NIFI-4750: -- Github user mcgilman commented on the issue: https://github.com/apache/nifi/pull/2387 Looks great @bbende! I have merged this to master. Just a heads up... made a minor tweak to your PR to ensure all each provider has a chance to clean up when an exceptional case occurs. > Authorizer not properly shutting down > - > > Key: NIFI-4750 > URL: https://issues.apache.org/jira/browse/NIFI-4750 > Project: Apache NiFi > Issue Type: Bug >Affects Versions: 1.4.0 >Reporter: Bryan Bende >Assignee: Bryan Bende >Priority: Minor > > I was running a NiFi instance configured with the StandardManagedAuthorizer, > using a file-based policy provider, and a composite user-group-provider > (file-based and ldap providers). > Whenever I shutdown I noticed it was taking a long time and forcibly shutting > down. A thread dump showed that the Ldap sync thread was still running which > led me to look at how the auhorizers shutdown. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (NIFI-4750) Authorizer not properly shutting down
[ https://issues.apache.org/jira/browse/NIFI-4750?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16317132#comment-16317132 ] ASF GitHub Bot commented on NIFI-4750: -- Github user asfgit closed the pull request at: https://github.com/apache/nifi/pull/2387 > Authorizer not properly shutting down > - > > Key: NIFI-4750 > URL: https://issues.apache.org/jira/browse/NIFI-4750 > Project: Apache NiFi > Issue Type: Bug >Affects Versions: 1.4.0 >Reporter: Bryan Bende >Assignee: Bryan Bende >Priority: Minor > > I was running a NiFi instance configured with the StandardManagedAuthorizer, > using a file-based policy provider, and a composite user-group-provider > (file-based and ldap providers). > Whenever I shutdown I noticed it was taking a long time and forcibly shutting > down. A thread dump showed that the Ldap sync thread was still running which > led me to look at how the auhorizers shutdown. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Created] (NIFIREG-106) The "y" in Identity appears to be cut off at the bottom in several places in the UI
Andrew Lim created NIFIREG-106: -- Summary: The "y" in Identity appears to be cut off at the bottom in several places in the UI Key: NIFIREG-106 URL: https://issues.apache.org/jira/browse/NIFIREG-106 Project: NiFi Registry Issue Type: Improvement Affects Versions: 0.1.0 Reporter: Andrew Lim Priority: Trivial Attachments: add_user_dialog.png, edit_bucket_pane.png, edit_user_panel.png Attaching screenshots for the places I've noticed: * Add User dialog * Edit User panel * Edit Bucket panel -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[GitHub] nifi issue #2387: NIFI-4750 Ensuring preDestruction is called on authorizer ...
Github user mcgilman commented on the issue: https://github.com/apache/nifi/pull/2387 Looks great @bbende! I have merged this to master. Just a heads up... made a minor tweak to your PR to ensure all each provider has a chance to clean up when an exceptional case occurs. ---
[jira] [Commented] (NIFI-4750) Authorizer not properly shutting down
[ https://issues.apache.org/jira/browse/NIFI-4750?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16317131#comment-16317131 ] ASF subversion and git services commented on NIFI-4750: --- Commit 4196140e4c36a56957ea3c3bd3b5423f0731eda6 in nifi's branch refs/heads/master from [~bbende] [ https://git-wip-us.apache.org/repos/asf?p=nifi.git;h=4196140 ] NIFI-4750 Ensuring preDestruction is called on authorizer and appropriate policy/user-group providers. This closes #2387 > Authorizer not properly shutting down > - > > Key: NIFI-4750 > URL: https://issues.apache.org/jira/browse/NIFI-4750 > Project: Apache NiFi > Issue Type: Bug >Affects Versions: 1.4.0 >Reporter: Bryan Bende >Assignee: Bryan Bende >Priority: Minor > > I was running a NiFi instance configured with the StandardManagedAuthorizer, > using a file-based policy provider, and a composite user-group-provider > (file-based and ldap providers). > Whenever I shutdown I noticed it was taking a long time and forcibly shutting > down. A thread dump showed that the Ldap sync thread was still running which > led me to look at how the auhorizers shutdown. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[GitHub] nifi pull request #2387: NIFI-4750 Ensuring preDestruction is called on auth...
Github user asfgit closed the pull request at: https://github.com/apache/nifi/pull/2387 ---
[jira] [Commented] (NIFI-4750) Authorizer not properly shutting down
[ https://issues.apache.org/jira/browse/NIFI-4750?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16317101#comment-16317101 ] ASF GitHub Bot commented on NIFI-4750: -- Github user mcgilman commented on the issue: https://github.com/apache/nifi/pull/2387 Will review... > Authorizer not properly shutting down > - > > Key: NIFI-4750 > URL: https://issues.apache.org/jira/browse/NIFI-4750 > Project: Apache NiFi > Issue Type: Bug >Affects Versions: 1.4.0 >Reporter: Bryan Bende >Assignee: Bryan Bende >Priority: Minor > > I was running a NiFi instance configured with the StandardManagedAuthorizer, > using a file-based policy provider, and a composite user-group-provider > (file-based and ldap providers). > Whenever I shutdown I noticed it was taking a long time and forcibly shutting > down. A thread dump showed that the Ldap sync thread was still running which > led me to look at how the auhorizers shutdown. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[GitHub] nifi issue #2387: NIFI-4750 Ensuring preDestruction is called on authorizer ...
Github user mcgilman commented on the issue: https://github.com/apache/nifi/pull/2387 Will review... ---
[jira] [Commented] (NIFI-4750) Authorizer not properly shutting down
[ https://issues.apache.org/jira/browse/NIFI-4750?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16317098#comment-16317098 ] ASF GitHub Bot commented on NIFI-4750: -- GitHub user bbende opened a pull request: https://github.com/apache/nifi/pull/2387 NIFI-4750 Ensuring preDestruction is called on authorizer and appropr… …iate policy/user-group providers Thank you for submitting a contribution to Apache NiFi. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all changes: - [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [ ] Does your PR title start with NIFI- where is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character. - [ ] Has your PR been rebased against the latest commit within the target branch (typically master)? - [ ] Is your initial contribution a single, squashed commit? ### For code changes: - [ ] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder? - [ ] Have you written or updated unit tests to verify your changes? - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? - [ ] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly? - [ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly? - [ ] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties? ### For documentation related changes: - [ ] Have you ensured that format looks appropriate for the output in which it is rendered? ### Note: Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible. You can merge this pull request into a Git repository by running: $ git pull https://github.com/bbende/nifi NIFI-4750 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/nifi/pull/2387.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #2387 commit f9d1faeca4c42246595e85e5202ae7c484182ca2 Author: Bryan BendeDate: 2018-01-08T21:21:03Z NIFI-4750 Ensuring preDestruction is called on authorizer and appropriate policy/user-group providers > Authorizer not properly shutting down > - > > Key: NIFI-4750 > URL: https://issues.apache.org/jira/browse/NIFI-4750 > Project: Apache NiFi > Issue Type: Bug >Affects Versions: 1.4.0 >Reporter: Bryan Bende >Assignee: Bryan Bende >Priority: Minor > > I was running a NiFi instance configured with the StandardManagedAuthorizer, > using a file-based policy provider, and a composite user-group-provider > (file-based and ldap providers). > Whenever I shutdown I noticed it was taking a long time and forcibly shutting > down. A thread dump showed that the Ldap sync thread was still running which > led me to look at how the auhorizers shutdown. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[GitHub] nifi pull request #2387: NIFI-4750 Ensuring preDestruction is called on auth...
GitHub user bbende opened a pull request: https://github.com/apache/nifi/pull/2387 NIFI-4750 Ensuring preDestruction is called on authorizer and appropr⦠â¦iate policy/user-group providers Thank you for submitting a contribution to Apache NiFi. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all changes: - [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [ ] Does your PR title start with NIFI- where is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character. - [ ] Has your PR been rebased against the latest commit within the target branch (typically master)? - [ ] Is your initial contribution a single, squashed commit? ### For code changes: - [ ] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder? - [ ] Have you written or updated unit tests to verify your changes? - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? - [ ] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly? - [ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly? - [ ] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties? ### For documentation related changes: - [ ] Have you ensured that format looks appropriate for the output in which it is rendered? ### Note: Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible. You can merge this pull request into a Git repository by running: $ git pull https://github.com/bbende/nifi NIFI-4750 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/nifi/pull/2387.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #2387 commit f9d1faeca4c42246595e85e5202ae7c484182ca2 Author: Bryan BendeDate: 2018-01-08T21:21:03Z NIFI-4750 Ensuring preDestruction is called on authorizer and appropriate policy/user-group providers ---
[jira] [Commented] (NIFI-4749) QueryRecord throws NPE when selecting complex objects if writer inherits schema
[ https://issues.apache.org/jira/browse/NIFI-4749?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16317092#comment-16317092 ] ASF GitHub Bot commented on NIFI-4749: -- GitHub user markap14 opened a pull request: https://github.com/apache/nifi/pull/2386 NIFI-4749: Pass the record reader's schema along to the ResultSetReco… …rdSet so that it is able to resolve the schema for Record fields Thank you for submitting a contribution to Apache NiFi. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all changes: - [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [ ] Does your PR title start with NIFI- where is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character. - [ ] Has your PR been rebased against the latest commit within the target branch (typically master)? - [ ] Is your initial contribution a single, squashed commit? ### For code changes: - [ ] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder? - [ ] Have you written or updated unit tests to verify your changes? - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? - [ ] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly? - [ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly? - [ ] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties? ### For documentation related changes: - [ ] Have you ensured that format looks appropriate for the output in which it is rendered? ### Note: Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible. You can merge this pull request into a Git repository by running: $ git pull https://github.com/markap14/nifi NIFI-4749 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/nifi/pull/2386.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #2386 commit 5d36c49133e8bd2b205eaf9538f5cd9305d3e920 Author: Mark PayneDate: 2018-01-08T21:18:34Z NIFI-4749: Pass the record reader's schema along to the ResultSetRecordSet so that it is able to resolve the schema for Record fields > QueryRecord throws NPE when selecting complex objects if writer inherits > schema > --- > > Key: NIFI-4749 > URL: https://issues.apache.org/jira/browse/NIFI-4749 > Project: Apache NiFi > Issue Type: Bug >Affects Versions: 1.4.0 >Reporter: Mark Payne >Assignee: Mark Payne > Fix For: 1.5.0 > > Attachments: NIFI-4749.xml > > > If we create a QueryRecord processor and choose a Record Writer that has a > Schema Write Strategy of "Inherit Record," all works okay if the data being > queried is 'flat' data. But if the data is hierarchical it can fail when > attempting to write out the data, throwing a NullPointerException: > {code} > 2018-01-08 15:15:07,645 ERROR [NiFi logging handler] org.apache.nifi.StdErr > java.lang.NullPointerException > 2018-01-08 15:15:07,648 ERROR [NiFi logging handler] org.apache.nifi.StdErr > at > org.apache.nifi.json.WriteJsonResult.writeRecord(WriteJsonResult.java:167) > 2018-01-08 15:15:07,648 ERROR [NiFi logging handler] org.apache.nifi.StdErr > at org.apache.nifi.json.WriteJsonResult.writeValue(WriteJsonResult.java:348) > 2018-01-08 15:15:07,648 ERROR [NiFi logging handler] org.apache.nifi.StdErr > at org.apache.nifi.json.WriteJsonResult.writeArray(WriteJsonResult.java:385) > 2018-01-08 15:15:07,649 ERROR [NiFi logging handler] org.apache.nifi.StdErr > at org.apache.nifi.json.WriteJsonResult.writeValue(WriteJsonResult.java:372) > 2018-01-08 15:15:07,649 ERROR [NiFi logging handler] org.apache.nifi.StdErr > at > org.apache.nifi.json.WriteJsonResult.writeRecord(WriteJsonResult.java:181) > 2018-01-08 15:15:07,649 ERROR [NiFi logging handler] org.apache.nifi.StdErr > at > org.apache.nifi.json.WriteJsonResult.writeRecord(WriteJsonResult.java:128) > 2018-01-08 15:15:07,649 ERROR [NiFi logging handler] org.apache.nifi.StdErr > at >