[jira] [Commented] (NIFI-4904) PutElasticSearch5 should support higher than elasticsearch 5.0.0
[
https://issues.apache.org/jira/browse/NIFI-4904?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16543941#comment-16543941
]
Mike Thomsen commented on NIFI-4904:
The new processors defined in 5248 will make this OBE by offloading the work of
supporting new ES versions to their client service.
> PutElasticSearch5 should support higher than elasticsearch 5.0.0
>
>
> Key: NIFI-4904
> URL: https://issues.apache.org/jira/browse/NIFI-4904
> Project: Apache NiFi
> Issue Type: Improvement
> Components: Extensions
>Affects Versions: 1.5.0
> Environment: Ubuntu
>Reporter: Dye357
>Priority: Trivial
> Original Estimate: 2h
> Remaining Estimate: 2h
>
> Currently the PutElasticSearch5 component is using the following transport
> artifact
>
> org.elasticsearch.client
> transport
> ${es.version}
>
> Where es.version is 5.0.1. Upgrading to the highest 5.x dependency would
> enable this component to be compatible with later 5.x versions of elastic
> search as well as early versions of elastic search 6.x.
> Here is Nifi 1.5.0 connecting to ES 6.2.1 on port 9300:
> [2018-02-23T01:41:04,162][WARN ][o.e.t.n.Netty4Transport ] [uQSW8O8]
> exception caught on transport layer
> [NettyTcpChannel\{localAddress=/127.0.0.1:9300,
> remoteAddress=/127.0.0.1:57457}], closing connection
> java.lang.IllegalStateException: Received message from unsupported version:
> [5.0.0] minimal compatible version is: [5.6.0]
> at
> org.elasticsearch.transport.TcpTransport.ensureVersionCompatibility(TcpTransport.java:1430)
> ~[elasticsearch-6.2.1.jar:6.2.1]
> at
> org.elasticsearch.transport.TcpTransport.messageReceived(TcpTransport.java:1377)
> ~[elasticsearch-6.2.1.jar:6.2.1]
> at
> org.elasticsearch.transport.netty4.Netty4MessageChannelHandler.channelRead(Netty4MessageChannelHandler.java:64)
> ~[transport-netty4-6.2.1.jar:6.2.1]
> at
> io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:362)
> [netty-transport-4.1.16.Final.jar:4.1.16.Final]
> at
> io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:348)
> [netty-transport-4.1.16.Final.jar:4.1.16.Final]
> at
> io.netty.channel.AbstractChannelHandlerContext.fireChannelRead(AbstractChannelHandlerContext.java:340)
> [netty-transport-4.1.16.Final.jar:4.1.16.Final]
> at
> io.netty.handler.codec.ByteToMessageDecoder.fireChannelRead(ByteToMessageDecoder.java:310)
> [netty-codec-4.1.16.Final.jar:4.1.16.Final]
> at
> io.netty.handler.codec.ByteToMessageDecoder.fireChannelRead(ByteToMessageDecoder.java:297)
> [netty-codec-4.1.16.Final.jar:4.1.16.Final]
> at
> io.netty.handler.codec.ByteToMessageDecoder.callDecode(ByteToMessageDecoder.java:413)
> [netty-codec-4.1.16.Final.jar:4.1.16.Final]
> at
> io.netty.handler.codec.ByteToMessageDecoder.channelRead(ByteToMessageDecoder.java:265)
> [netty-codec-4.1.16.Final.jar:4.1.16.Final]
> at
> io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:362)
> [netty-transport-4.1.16.Final.jar:4.1.16.Final]
> at
> io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:348)
> [netty-transport-4.1.16.Final.jar:4.1.16.Final]
> at
> io.netty.channel.AbstractChannelHandlerContext.fireChannelRead(AbstractChannelHandlerContext.java:340)
> [netty-transport-4.1.16.Final.jar:4.1.16.Final]
> at
> io.netty.handler.logging.LoggingHandler.channelRead(LoggingHandler.java:241)
> [netty-handler-4.1.16.Final.jar:4.1.16.Final]
> at
> io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:362)
> [netty-transport-4.1.16.Final.jar:4.1.16.Final]
> at
> io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:348)
> [netty-transport-4.1.16.Final.jar:4.1.16.Final]
> at
> io.netty.channel.AbstractChannelHandlerContext.fireChannelRead(AbstractChannelHandlerContext.java:340)
> [netty-transport-4.1.16.Final.jar:4.1.16.Final]
> at
> io.netty.channel.DefaultChannelPipeline$HeadContext.channelRead(DefaultChannelPipeline.java:1359)
> [netty-transport-4.1.16.Final.jar:4.1.16.Final]
> at
> io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:362)
> [netty-transport-4.1.16.Final.jar:4.1.16.Final]
> at
> io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:348)
> [netty-transport-4.1.16.Final.jar:4.1.16.Final]
> at
> io.netty.channel.DefaultChannelPipeline.fireChannelRead(DefaultChannelPipeline.java:935)
> [netty-transport-4.1.16.Final.jar:4.1.16.Final]
> at
>
[jira] [Commented] (NIFI-3124) Test code cleanup in ElasticSearch (2.x API) processors
[ https://issues.apache.org/jira/browse/NIFI-3124?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16543940#comment-16543940 ] Mike Thomsen commented on NIFI-3124: I found a Maven plugin that loads Elastic for us in cases like this. We already use it with the elasticsearch restapi bundle. I think it'll be a good fit here assuming it supports 2.X. > Test code cleanup in ElasticSearch (2.x API) processors > --- > > Key: NIFI-3124 > URL: https://issues.apache.org/jira/browse/NIFI-3124 > Project: Apache NiFi > Issue Type: Improvement > Components: Extensions >Reporter: Jeff Storck >Assignee: Mike Thomsen >Priority: Minor > > Tests that are marked with @Ignore due to their integration nature should be > moved into integration tests classes. > Also, the current integration tests in ITQueryElasticsearchHttp and > ITScrollElasticsearchHttp should be updated to not assume hostnames and > existing data. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Assigned] (NIFI-3124) Test code cleanup in ElasticSearch (2.x API) processors
[ https://issues.apache.org/jira/browse/NIFI-3124?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mike Thomsen reassigned NIFI-3124: -- Assignee: Mike Thomsen > Test code cleanup in ElasticSearch (2.x API) processors > --- > > Key: NIFI-3124 > URL: https://issues.apache.org/jira/browse/NIFI-3124 > Project: Apache NiFi > Issue Type: Improvement > Components: Extensions >Reporter: Jeff Storck >Assignee: Mike Thomsen >Priority: Minor > > Tests that are marked with @Ignore due to their integration nature should be > moved into integration tests classes. > Also, the current integration tests in ITQueryElasticsearchHttp and > ITScrollElasticsearchHttp should be updated to not assume hostnames and > existing data. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (NIFI-5081) Lack of guidance and inability to deal with ISO-8601 dates
[
https://issues.apache.org/jira/browse/NIFI-5081?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16543934#comment-16543934
]
Mike Thomsen commented on NIFI-5081:
[~forbesmyester] you should be able to use PutMongoRecord for this. What you do
is you fill out the "timestamp" property of the record reader (ex
JsonTreeReader) to use the proper date parsing syntax for reading an ISO8601
string. There's an example somewhere on the Record API document that you can
lift for some flavors of ISO8601. Then in the Avro schema you declare the field
to be a long with a logicalType ([Avro
documentation|https://avro.apache.org/docs/1.8.0/spec.html#Timestamp+%28millisecond+precision%29])
> Lack of guidance and inability to deal with ISO-8601 dates
> --
>
> Key: NIFI-5081
> URL: https://issues.apache.org/jira/browse/NIFI-5081
> Project: Apache NiFi
> Issue Type: Improvement
> Components: Documentation Website
>Affects Versions: 1.6.0
> Environment: Ubuntu / Chromeium
>Reporter: Matt Forrester
>Priority: Minor
> Attachments: y.xml
>
>
> I've got a Node process that outputs in JSON onto an SQS queue. The dates it
> spits out are ISO-8601 dates within a string, which is the normal, default
> and best way to do this in JSON.
> I tried putting them into MongoDB with PutMongo and they go in as strings,
> which is not good ( https://issues.apache.org/jira/browse/NIFI-2079 ).
> Gave up on Mongo and tried PostgreSQL...
> Figuring I was in Java land I used an esoteric path of GetSQS >
> EvaluateJsonPath > UpdateAttribute [
> "$\{time:toDate("-MM-dd'T'HH:mm:ss.SSS'Z'", "GMT") ] > PutSQL to get it
> into what I assume is a java.lang.Date, it took me forever to find the
> sql.args.N.type's required but for some reason PutSQL does not like
> java.util.Dates.
> Eventually found the ConvertJSONToSQL processor and this created my SQL for
> me, but it doesn't work as it leaves ISO-8601 dates as ISO-8601 dates, which
> don't seem to work.
> Eventually found this
> [https://community.hortonworks.com/questions/84772/putsql-with-date-as-argument.html]
> and now I have something working, but I'm using my esoteric GetSQS ->
> EvaluateJsonPath -> UpdateAttribute -> PutSQL path again.
> Think there should be some documentation around this at least because it's
> very non-obvious.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Resolved] (NIFI-2135) PutMongo replacing document instead of updating document
[
https://issues.apache.org/jira/browse/NIFI-2135?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mike Thomsen resolved NIFI-2135.
Resolution: Fixed
[~bende] doing a little cleanup on our Mongo backlog and noticed that 4588
appears to settle the issue. Feel free to reopen if you disagree.
> PutMongo replacing document instead of updating document
>
>
> Key: NIFI-2135
> URL: https://issues.apache.org/jira/browse/NIFI-2135
> Project: Apache NiFi
> Issue Type: Bug
>Affects Versions: 0.6.1
>Reporter: Bryan Bende
>Priority: Minor
> Attachments:
> 0001-NIFI-2135-PutMongo-will-now-update-using-a-set-and-r.patch,
> 0002-Verified-insert-update-and-replace.-Fixed-a-minor-lo.patch,
> nifi-mongodb-nar-0.7.0.nar
>
>
> How can I use put mongo processor to add a new key value pair to an existing
> document? The flow file contains the document object Id. I have set 'mode'
> property to 'update' and 'upsert' property to false and 'update query key'
> property to '_id'. Flow file content is something like this.
> {
> _id:ObjectId(577216f0154b943fe8068079)
> expired:true
> }
> Without inserting the 'expired:true', it replaces the whole document with the
> given one. So is there a way to insert the new key value pair to collection
> without replacing the whole collection in MongoDB using putmongo processor?
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Resolved] (NIFI-2079) Cannot insert ISO dates correctly
[ https://issues.apache.org/jira/browse/NIFI-2079?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mike Thomsen resolved NIFI-2079. Resolution: Won't Fix I am closing this for a few reasons: # We can insert dates properly using PutMongoRecord. # Given the nature of Mongo itself, we cannot blithely assume that a user really intended a date string to be automagically parsed into a date object. If someone has a compelling reason to turn this into a feature request w/ a good and intuitive way to let the user determine when to convert and when not to, then we can reopen/revisit this. > Cannot insert ISO dates correctly > - > > Key: NIFI-2079 > URL: https://issues.apache.org/jira/browse/NIFI-2079 > Project: Apache NiFi > Issue Type: Bug >Affects Versions: 0.6.1 >Reporter: asanka sanjaya >Priority: Major > > When try to insert an ISO date to a mongo collection, it always saved as a > String instead of ISODate object. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (NIFI-5305) Parameterized collection name fails with dynamic params
[
https://issues.apache.org/jira/browse/NIFI-5305?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16543920#comment-16543920
]
Mike Thomsen commented on NIFI-5305:
[~calderonmluis] Your stacktrace shows no value for the collection name. See:
> 'Invalid namespace specified 'my-schema.'' on server mongodb:22277
> com.mongodb.MongoQueryException: Query failed with error code 73 and error
> message 'Invalid namespace specified 'my-schema.''
So, as far as I can tell, it should be failing here. If you look at the setup
method of GetMongoIT in GitHub, you'll see that we actually start with an
expression language statement like this:
{code:java}
runner = TestRunners.newTestRunner(GetMongo.class);
runner.setVariable("uri", MONGO_URI);
runner.setVariable("db", DB_NAME);
runner.setVariable("collection", COLLECTION_NAME);
runner.setProperty(AbstractMongoProcessor.URI, "${uri}");
runner.setProperty(AbstractMongoProcessor.DATABASE_NAME, "${db}");
runner.setProperty(AbstractMongoProcessor.COLLECTION_NAME, "${collection}");
runner.setProperty(GetMongo.USE_PRETTY_PRINTING, GetMongo.YES_PP);
runner.setIncomingConnection(false);
{code}
Can you provide more details about your particular use?
> Parameterized collection name fails with dynamic params
> ---
>
> Key: NIFI-5305
> URL: https://issues.apache.org/jira/browse/NIFI-5305
> Project: Apache NiFi
> Issue Type: Bug
>Affects Versions: 1.6.0
>Reporter: Luis M Calderon
>Assignee: Mike Thomsen
>Priority: Major
> Attachments: getmongo_error.txt
>
>
> When using a dynamic property for collection name, the creation of the full
> query reference name is not working as expected. The reference name seems to
> be the concatenation of the namespace and collection name. i.e.
> _.)_
> The following parameters are those which are provided to the GetMongo
> Processor:
> Param Definitions:
> my_schema = 'my_schema'
> collection_name =
> {code:java}
> Mongo Database Name: ${my_schema}
> Mongo Collection Name: ${collection_name}{code}
>
> Attached is a text file containing the NiFi log for this error.
>
> _There is no namespace error when the same values are hard coded._
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (NIFI-5196) AbstractJMSProcessor can leave connection hanging open
[
https://issues.apache.org/jira/browse/NIFI-5196?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16543862#comment-16543862
]
Nick Coleman commented on NIFI-5196:
[~mosermw] - this would satisfy the original issue of needing to reboot the
server knowing that the admin has to stop and restart the processor. It's also
a cleaner code change
> AbstractJMSProcessor can leave connection hanging open
> --
>
> Key: NIFI-5196
> URL: https://issues.apache.org/jira/browse/NIFI-5196
> Project: Apache NiFi
> Issue Type: Bug
> Components: Extensions
>Affects Versions: 1.6.0
>Reporter: Nick Coleman
>Assignee: Sivaprasanna Sethuraman
>Priority: Major
> Labels: JMS
>
> ConsumeJMS and PublishJMS are based on AbstractJMSProcessor. They can cause
> a connection to the MQ Server to be opened and not be closed until the NiFi
> server is rebooted.
> This can create a problem for an MQ when the initial setup entered is wrong
> for an IBM MQ system that only allows one connection per user. Subsequent
> connections are blocked as the first remains open. Another potential problem
> even if the subsequent connection works is the original connection is still
> open and taking up resources.
> A simple change to the AbstractJMSProcessor would be in the onTrigger()
> function:
>
> {code:java}
> @Override
> public void onTrigger(ProcessContext context, ProcessSession session) throws
> ProcessException {
> T worker = workerPool.poll();
> if (worker == null) {
> worker = buildTargetResource(context);
> }
> boolean offered = false;
> try {
> rendezvousWithJms(context, session, worker);
> offered = workerPool.offer(worker);
> }
> finally {
> if (!offered) {
> worker.shutdown();
> }
> }
> }{code}
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (NIFI-3672) Older versions of IBM MQ allowed integer value to be set as String
[
https://issues.apache.org/jira/browse/NIFI-3672?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16543624#comment-16543624
]
Michael Moser commented on NIFI-3672:
-
+1 for adding this feature to PublishJMS.
The deprecated PutJMS processor supported the {{javax.jms.Message}} methods
{{setIntProperty}}, {{setBooleanProperty}}, {{setShortProperty}},
{{setLongProperty}}, {{setByteProperty}}, {{setDouleProperty}} and
{{setFloatProperty}}. PublishJMS could also support them.
> Older versions of IBM MQ allowed integer value to be set as String
> --
>
> Key: NIFI-3672
> URL: https://issues.apache.org/jira/browse/NIFI-3672
> Project: Apache NiFi
> Issue Type: Bug
> Components: Extensions
>Affects Versions: 1.1.1
>Reporter: Andy LoPresto
>Priority: Minor
> Labels: beginner, jms, third-party
>
> As reported in this [Stack Overflow
> question|https://stackoverflow.com/questions/43213416/publishjms-processor-failing-for-writing-message-to-ibm-websphere-mq],
> the {{PublishJMS}} processor was failing to connect to an IBM MQ JMS server
> with the exception {{com.ibm.msg.client.jms.DetailedMessageFormatException:
> JMSCC0051: The property 'JMS_IBM_MsgType' should be set using type
> 'java.lang.Integer', not 'java.lang.String'.}} As noted in the answer, this
> is a [known IBM issue
> IT02814|https://www-01.ibm.com/support/docview.wss?uid=swg1IT02814] in which
> older (pre-7.0) versions allowed integer properties to be set as a
> {{java.lang.String}} but new versions require it to be a
> {{java.lang.Integer}}. The property descriptor should be changed to validate
> an integer value and return it with the correct type when setting the
> configuration.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (NIFI-4535) Set the Page Title to the name of the Root Process Group
[ https://issues.apache.org/jira/browse/NIFI-4535?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16543600#comment-16543600 ] Peter Wicks commented on NIFI-4535: --- Thanks, I'll fix it. > Set the Page Title to the name of the Root Process Group > > > Key: NIFI-4535 > URL: https://issues.apache.org/jira/browse/NIFI-4535 > Project: Apache NiFi > Issue Type: Improvement > Components: Core UI >Reporter: Peter Wicks >Assignee: Peter Wicks >Priority: Minor > Fix For: 1.8.0 > > > NiFi's UI has a hard coded page title of NiFi. I have many servers and it's > hard to keep track of the tabs in Chrome. > Please change the Title of the page so it matches the name of the Root > processor group. This way I can name the root group by server/instance, and > easily identify the right tab/window. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (NIFI-5429) Improve failure monitoring
[
https://issues.apache.org/jira/browse/NIFI-5429?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Andy LoPresto updated NIFI-5429:
Attachment: asf_hc_failure_reporting.txt
> Improve failure monitoring
> --
>
> Key: NIFI-5429
> URL: https://issues.apache.org/jira/browse/NIFI-5429
> Project: Apache NiFi
> Issue Type: Improvement
> Components: Core Framework
>Affects Versions: 1.7.0
>Reporter: Andy LoPresto
>Priority: Major
> Labels: failure, monitoring, provenance, reporting
> Attachments: asf_hc_failure_reporting.001.jpeg,
> asf_hc_failure_reporting.002.jpeg, asf_hc_failure_reporting.003.jpeg,
> asf_hc_failure_reporting.txt
>
>
> A user in the ASF HipChat room and I discussed the following scenario:
> {quote}
> With N processors in a flow, I want to send a notification on any failure
> event to a remote monitoring system. For this example, let the remote
> monitoring system be Elasticsearch. Currently, I need N unique
> PutElasticsearch processors to uniquely identify the processor which has the
> failure.
> {quote}
> I created some diagrams showing the existing setup and desired setup (one
> with direct to reporting; one with an {{ExecuteScript}} processor for
> metadata enrichment (i.e. if the component {{UUID}} is available, use {{ES}}
> to resolve the human-friendly {{name}} and processor group nesting to be
> persisted)).
> There are concerns about exposing component ID to flowfiles and how this can
> be misused, but there needs to be a better solution for how to monitor flow
> failures without 1:1 processors for monitoring.
> I have also attached the conversation.
> cc: [~markap14] [~joewitt]
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (NIFI-5429) Improve failure monitoring
[
https://issues.apache.org/jira/browse/NIFI-5429?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Andy LoPresto updated NIFI-5429:
Attachment: asf_hc_failure_reporting.003.jpeg
asf_hc_failure_reporting.002.jpeg
asf_hc_failure_reporting.001.jpeg
> Improve failure monitoring
> --
>
> Key: NIFI-5429
> URL: https://issues.apache.org/jira/browse/NIFI-5429
> Project: Apache NiFi
> Issue Type: Improvement
> Components: Core Framework
>Affects Versions: 1.7.0
>Reporter: Andy LoPresto
>Priority: Major
> Labels: failure, monitoring, provenance, reporting
> Attachments: asf_hc_failure_reporting.001.jpeg,
> asf_hc_failure_reporting.002.jpeg, asf_hc_failure_reporting.003.jpeg
>
>
> A user in the ASF HipChat room and I discussed the following scenario:
> {quote}
> With N processors in a flow, I want to send a notification on any failure
> event to a remote monitoring system. For this example, let the remote
> monitoring system be Elasticsearch. Currently, I need N unique
> PutElasticsearch processors to uniquely identify the processor which has the
> failure.
> {quote}
> I created some diagrams showing the existing setup and desired setup (one
> with direct to reporting; one with an {{ExecuteScript}} processor for
> metadata enrichment (i.e. if the component {{UUID}} is available, use {{ES}}
> to resolve the human-friendly {{name}} and processor group nesting to be
> persisted)).
> There are concerns about exposing component ID to flowfiles and how this can
> be misused, but there needs to be a better solution for how to monitor flow
> failures without 1:1 processors for monitoring.
> I have also attached the conversation.
> cc: [~markap14] [~joewitt]
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Created] (NIFI-5429) Improve failure monitoring
Andy LoPresto created NIFI-5429:
---
Summary: Improve failure monitoring
Key: NIFI-5429
URL: https://issues.apache.org/jira/browse/NIFI-5429
Project: Apache NiFi
Issue Type: Improvement
Components: Core Framework
Affects Versions: 1.7.0
Reporter: Andy LoPresto
A user in the ASF HipChat room and I discussed the following scenario:
{quote}
With N processors in a flow, I want to send a notification on any failure event
to a remote monitoring system. For this example, let the remote monitoring
system be Elasticsearch. Currently, I need N unique PutElasticsearch processors
to uniquely identify the processor which has the failure.
{quote}
I created some diagrams showing the existing setup and desired setup (one with
direct to reporting; one with an {{ExecuteScript}} processor for metadata
enrichment (i.e. if the component {{UUID}} is available, use {{ES}} to resolve
the human-friendly {{name}} and processor group nesting to be persisted)).
There are concerns about exposing component ID to flowfiles and how this can be
misused, but there needs to be a better solution for how to monitor flow
failures without 1:1 processors for monitoring.
I have also attached the conversation.
cc: [~markap14] [~joewitt]
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (NIFI-4535) Set the Page Title to the name of the Root Process Group
[
https://issues.apache.org/jira/browse/NIFI-4535?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16543589#comment-16543589
]
Matt Gilman commented on NIFI-4535:
---
In the same place where the document title was being set, we have similar code
to set the current group name.
{code:java}
if (breadcrumb.permissions.canRead) {
nfCanvas.setGroupName(breadcrumb.breadcrumb.name);
} else {
nfCanvas.setGroupName(breadcrumb.id);
}
{code}
> Set the Page Title to the name of the Root Process Group
>
>
> Key: NIFI-4535
> URL: https://issues.apache.org/jira/browse/NIFI-4535
> Project: Apache NiFi
> Issue Type: Improvement
> Components: Core UI
>Reporter: Peter Wicks
>Assignee: Peter Wicks
>Priority: Minor
> Fix For: 1.8.0
>
>
> NiFi's UI has a hard coded page title of NiFi. I have many servers and it's
> hard to keep track of the tabs in Chrome.
> Please change the Title of the page so it matches the name of the Root
> processor group. This way I can name the root group by server/instance, and
> easily identify the right tab/window.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (NIFI-4889) Logout not working properly with OIDC
[ https://issues.apache.org/jira/browse/NIFI-4889?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16543572#comment-16543572 ] ASF GitHub Bot commented on NIFI-4889: -- Github user mcgilman commented on the issue: https://github.com/apache/nifi/pull/2830 @Trojan295 Thanks for the PR! The code looks good but I ran into an issue when attempting to log out. Despite being a required field in the openid spec [1], it appears that at least in practice [2] the `end_session_endpoint` field is not guaranteed to be present. I think we may need to account for this possibility in the logout endpoint. [1] https://openid.net/specs/openid-connect-session-1_0.html#OPMetadata [2] https://accounts.google.com/.well-known/openid-configuration > Logout not working properly with OIDC > - > > Key: NIFI-4889 > URL: https://issues.apache.org/jira/browse/NIFI-4889 > Project: Apache NiFi > Issue Type: Bug > Components: Core UI >Affects Versions: 1.5.0 > Environment: Browser: Chrome / Firefox > Configuration of NiFi: > - SSL certificate for the server (no client auth) > - OIDC configuration including end_session_endpoint (see the link > https://auth.s.orchestracities.com/auth/realms/default/.well-known/openid-configuration) >Reporter: Federico Michele Facca >Priority: Critical > > Click on logout, i would expect to logout and getting redirect to the auth > page. But given that the session is not closed on the oauth provider, i get > logged in again. > I suppose the solution would be to invoke the end_session_endpoint provided > in the openid discovery configuration. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] nifi issue #2830: NIFI-4889: Logout not working properly with OIDC
Github user mcgilman commented on the issue: https://github.com/apache/nifi/pull/2830 @Trojan295 Thanks for the PR! The code looks good but I ran into an issue when attempting to log out. Despite being a required field in the openid spec [1], it appears that at least in practice [2] the `end_session_endpoint` field is not guaranteed to be present. I think we may need to account for this possibility in the logout endpoint. [1] https://openid.net/specs/openid-connect-session-1_0.html#OPMetadata [2] https://accounts.google.com/.well-known/openid-configuration ---
[jira] [Commented] (NIFI-4535) Set the Page Title to the name of the Root Process Group
[ https://issues.apache.org/jira/browse/NIFI-4535?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16543568#comment-16543568 ] Matt Gilman commented on NIFI-4535: --- [~patricker] I just ran into an issue that I think is related to this PR. If the user doesn't have permissions to a group, the BreadcrumbDTO on the BreadcrumbEntity is not populated. As a result, we hit a JS error that prevents the page from loading. I'm thinking the page name detection needs to be updated to account for this. > Set the Page Title to the name of the Root Process Group > > > Key: NIFI-4535 > URL: https://issues.apache.org/jira/browse/NIFI-4535 > Project: Apache NiFi > Issue Type: Improvement > Components: Core UI >Reporter: Peter Wicks >Assignee: Peter Wicks >Priority: Minor > Fix For: 1.8.0 > > > NiFi's UI has a hard coded page title of NiFi. I have many servers and it's > hard to keep track of the tabs in Chrome. > Please change the Title of the page so it matches the name of the Root > processor group. This way I can name the root group by server/instance, and > easily identify the right tab/window. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Reopened] (NIFI-4535) Set the Page Title to the name of the Root Process Group
[ https://issues.apache.org/jira/browse/NIFI-4535?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matt Gilman reopened NIFI-4535: --- > Set the Page Title to the name of the Root Process Group > > > Key: NIFI-4535 > URL: https://issues.apache.org/jira/browse/NIFI-4535 > Project: Apache NiFi > Issue Type: Improvement > Components: Core UI >Reporter: Peter Wicks >Assignee: Peter Wicks >Priority: Minor > Fix For: 1.8.0 > > > NiFi's UI has a hard coded page title of NiFi. I have many servers and it's > hard to keep track of the tabs in Chrome. > Please change the Title of the page so it matches the name of the Root > processor group. This way I can name the root group by server/instance, and > easily identify the right tab/window. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (NIFI-5426) Use NIO.2 API for ListFile to avoid multiple disk reads
[ https://issues.apache.org/jira/browse/NIFI-5426?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16543520#comment-16543520 ] Mark Payne commented on NIFI-5426: -- [~mgaido] thanks for knocking that out! I was able to test and verify that things appear to work well on my system. Code review all looks good as well. +1 merged to master. Thanks again! > Use NIO.2 API for ListFile to avoid multiple disk reads > --- > > Key: NIFI-5426 > URL: https://issues.apache.org/jira/browse/NIFI-5426 > Project: Apache NiFi > Issue Type: Improvement > Components: Extensions >Reporter: Mark Payne >Priority: Major > Fix For: 1.8.0 > > > NIFI-4631 attempted to do something similar but had issues when running > against CIFS mounts, reportedly. However, I think the issue was not the use > necessarily of NIO.2 but the way in which it was used. It attempted to use > walkTree and did did not appear to follow symlinks. As a result, this caused > failures in some scenarios. We should look at using NIO.2 and probably obtain > a Stream. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (NIFI-5426) Use NIO.2 API for ListFile to avoid multiple disk reads
[ https://issues.apache.org/jira/browse/NIFI-5426?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mark Payne updated NIFI-5426: - Fix Version/s: 1.8.0 Status: Patch Available (was: Open) > Use NIO.2 API for ListFile to avoid multiple disk reads > --- > > Key: NIFI-5426 > URL: https://issues.apache.org/jira/browse/NIFI-5426 > Project: Apache NiFi > Issue Type: Improvement > Components: Extensions >Reporter: Mark Payne >Priority: Major > Fix For: 1.8.0 > > > NIFI-4631 attempted to do something similar but had issues when running > against CIFS mounts, reportedly. However, I think the issue was not the use > necessarily of NIO.2 but the way in which it was used. It attempted to use > walkTree and did did not appear to follow symlinks. As a result, this caused > failures in some scenarios. We should look at using NIO.2 and probably obtain > a Stream. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (NIFI-5426) Use NIO.2 API for ListFile to avoid multiple disk reads
[ https://issues.apache.org/jira/browse/NIFI-5426?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16543519#comment-16543519 ] ASF subversion and git services commented on NIFI-5426: --- Commit 31bb89514cfa0e5df9db578387d566c7b5117c45 in nifi's branch refs/heads/master from [~mgaido] [ https://git-wip-us.apache.org/repos/asf?p=nifi.git;h=31bb895 ] NIFI-5426: Use NIO.2 API for ListFile > Use NIO.2 API for ListFile to avoid multiple disk reads > --- > > Key: NIFI-5426 > URL: https://issues.apache.org/jira/browse/NIFI-5426 > Project: Apache NiFi > Issue Type: Improvement > Components: Extensions >Reporter: Mark Payne >Priority: Major > > NIFI-4631 attempted to do something similar but had issues when running > against CIFS mounts, reportedly. However, I think the issue was not the use > necessarily of NIO.2 but the way in which it was used. It attempted to use > walkTree and did did not appear to follow symlinks. As a result, this caused > failures in some scenarios. We should look at using NIO.2 and probably obtain > a Stream. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (NIFI-5196) AbstractJMSProcessor can leave connection hanging open
[
https://issues.apache.org/jira/browse/NIFI-5196?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16543485#comment-16543485
]
Michael Moser commented on NIFI-5196:
-
I have another scenario when this happens. If the framework throws an
exception from the ProcessSession commit() method, then that exception
propagates out of rendezvousWithJms() and the AbstractJMSProcessor
onTrigger(). Situations like an OutOfMemoryError or IOException: No space left
on device can cause this.
In this situation, I don't think we should close and reopen connections to the
JMS hub in each onTrigger. So I propose a solution like this:
{code:java}
@Override
public void onTrigger(ProcessContext context, ProcessSession session) throws
ProcessException {
T worker = workerPool.poll();
if (worker == null) {
worker = buildTargetResource(context);
}
try {
rendezvousWithJms(context, session, worker);
}
finally {
workerPool.offer(worker);
}
}
{code}
In the case where OOM or out of disk space occurs, the valid connection simply
remains open. In the case where the connection configuration is wrong, the NiFi
manager should be able to notice the problem and stop the processor, which will
call the @OnStopped method and close the bad connection.
How does this sound?
> AbstractJMSProcessor can leave connection hanging open
> --
>
> Key: NIFI-5196
> URL: https://issues.apache.org/jira/browse/NIFI-5196
> Project: Apache NiFi
> Issue Type: Bug
> Components: Extensions
>Affects Versions: 1.6.0
>Reporter: Nick Coleman
>Assignee: Sivaprasanna Sethuraman
>Priority: Major
> Labels: JMS
>
> ConsumeJMS and PublishJMS are based on AbstractJMSProcessor. They can cause
> a connection to the MQ Server to be opened and not be closed until the NiFi
> server is rebooted.
> This can create a problem for an MQ when the initial setup entered is wrong
> for an IBM MQ system that only allows one connection per user. Subsequent
> connections are blocked as the first remains open. Another potential problem
> even if the subsequent connection works is the original connection is still
> open and taking up resources.
> A simple change to the AbstractJMSProcessor would be in the onTrigger()
> function:
>
> {code:java}
> @Override
> public void onTrigger(ProcessContext context, ProcessSession session) throws
> ProcessException {
> T worker = workerPool.poll();
> if (worker == null) {
> worker = buildTargetResource(context);
> }
> boolean offered = false;
> try {
> rendezvousWithJms(context, session, worker);
> offered = workerPool.offer(worker);
> }
> finally {
> if (!offered) {
> worker.shutdown();
> }
> }
> }{code}
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[GitHub] nifi issue #2884: NIFI-3993 Updated the ZooKeeper version to 3.4.10
Github user jtstorck commented on the issue: https://github.com/apache/nifi/pull/2884 @joewitt I brought up the upgrade a while ago, but many of the services/components we integrate with are using Zookeeper 3.4.6. Originally I wanted to use a newer version that did not explicitly depend on log4j, because it was causing some issues with the NiFi Toolkit. Since we were able to work around the dependency issue, we didn't upgrade the version. ---
[jira] [Commented] (NIFI-3993) Upgrade embedded ZooKeeper version
[ https://issues.apache.org/jira/browse/NIFI-3993?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16543452#comment-16543452 ] ASF GitHub Bot commented on NIFI-3993: -- Github user jtstorck commented on the issue: https://github.com/apache/nifi/pull/2884 @joewitt I brought up the upgrade a while ago, but many of the services/components we integrate with are using Zookeeper 3.4.6. Originally I wanted to use a newer version that did not explicitly depend on log4j, because it was causing some issues with the NiFi Toolkit. Since we were able to work around the dependency issue, we didn't upgrade the version. > Upgrade embedded ZooKeeper version > -- > > Key: NIFI-3993 > URL: https://issues.apache.org/jira/browse/NIFI-3993 > Project: Apache NiFi > Issue Type: Bug > Components: Core Framework >Affects Versions: 1.2.0 >Reporter: Mark Bean >Priority: Major > > In a Cluster configuration, Nodes are periodically disconnected from the > Cluster, and then reconnected. These events correspond to the following error: > ERROR [CommitProcessor:1] o.apache.zookeeper.server.NIOServerCnxn Unexpected > Exception: > java.nio.channels.CancelledKeyException: null > at sun.nio.ch.SelectionKeyImpl.ensureValid(SectionKeyImpl.java:73) > at sun.nio.ch.SelectionKeyImpl.interestOps(SelctionKeyImpl.java:77) > at > org.apache.zookeeper.server.NIOServerCnxn.sendBuffer(NIOServerCnxn.java:151) > at > org.apache.zookeeper.server.NIOServerCnXn.sendResopnse(NIOServerCnxn.java:1081) > at > org.apache.zookeeper.server.FinalRequestProcessor.processRequest(FinalRequestProcessor.java:404) > at > org.apache.zookeeper.server.quorum.CommitProcessor.run(CommitProcessor.java:74) > This error was reported in ZooKeeper JIRA [1], and reported as fixed in > version 3.4.10, the current stable build. As additional confirmation, when > using a stand-alone ZK, 3.4.10, rather than the embedded ZK, the above error > was no longer observed. > Update NiFi to use ZK 3.4.10 > [1] https://issues.apache.org/jira/browse/ZOOKEEPER-2044 -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (NIFI-5428) Add documentation for S2S and Flow Analyzer tools
Andrew Lim created NIFI-5428: Summary: Add documentation for S2S and Flow Analyzer tools Key: NIFI-5428 URL: https://issues.apache.org/jira/browse/NIFI-5428 Project: Apache NiFi Issue Type: Improvement Components: Documentation Website Reporter: Andrew Lim I noticed that these two Admin toolkit tools are not documented. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Assigned] (NIFI-5305) Parameterized collection name fails with dynamic params
[
https://issues.apache.org/jira/browse/NIFI-5305?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mike Thomsen reassigned NIFI-5305:
--
Assignee: Mike Thomsen
> Parameterized collection name fails with dynamic params
> ---
>
> Key: NIFI-5305
> URL: https://issues.apache.org/jira/browse/NIFI-5305
> Project: Apache NiFi
> Issue Type: Bug
>Affects Versions: 1.6.0
>Reporter: Luis M Calderon
>Assignee: Mike Thomsen
>Priority: Major
> Attachments: getmongo_error.txt
>
>
> When using a dynamic property for collection name, the creation of the full
> query reference name is not working as expected. The reference name seems to
> be the concatenation of the namespace and collection name. i.e.
> _.)_
> The following parameters are those which are provided to the GetMongo
> Processor:
> Param Definitions:
> my_schema = 'my_schema'
> collection_name =
> {code:java}
> Mongo Database Name: ${my_schema}
> Mongo Collection Name: ${collection_name}{code}
>
> Attached is a text file containing the NiFi log for this error.
>
> _There is no namespace error when the same values are hard coded._
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (NIFI-5427) ScrollElasticsearchHttp breaks with Elasticsearch 6
[ https://issues.apache.org/jira/browse/NIFI-5427?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16543416#comment-16543416 ] Joseph Gresock commented on NIFI-5427: -- I have tested this in a live 1.6.0 nifi instance. > ScrollElasticsearchHttp breaks with Elasticsearch 6 > --- > > Key: NIFI-5427 > URL: https://issues.apache.org/jira/browse/NIFI-5427 > Project: Apache NiFi > Issue Type: Bug >Affects Versions: 1.4.0, 1.5.0, 1.6.0, 1.7.0 >Reporter: Joseph Gresock >Assignee: Joseph Gresock >Priority: Minor > > The Elasticsearch 6 Scroll API uses scroll IDs that are nearly 10,000 > characters long. Since the ScrollElasticsearchHttp processor uses a GET > request for scrolling, this breaks the processor after the first scroll call. > > The solution is fairly simple: use a POST instead of a GET for the scroll > calls. This is backwards compatible down to Elasticsearch 2.X. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (NIFI-5427) ScrollElasticsearchHttp breaks with Elasticsearch 6
[ https://issues.apache.org/jira/browse/NIFI-5427?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16543414#comment-16543414 ] ASF GitHub Bot commented on NIFI-5427: -- GitHub user gresockj opened a pull request: https://github.com/apache/nifi/pull/2890 NIFI-5427: Updating ScrollElasticsearchHttp to use POST, supporting ES6 Thank you for submitting a contribution to Apache NiFi. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all changes: - [x] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [x] Does your PR title start with NIFI- where is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character. - [x] Has your PR been rebased against the latest commit within the target branch (typically master)? - [x] Is your initial contribution a single, squashed commit? ### For code changes: - [x] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder? - [x] Have you written or updated unit tests to verify your changes? - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? - [ ] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly? - [ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly? - [ ] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties? ### For documentation related changes: - [ ] Have you ensured that format looks appropriate for the output in which it is rendered? ### Note: Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible. You can merge this pull request into a Git repository by running: $ git pull https://github.com/gresockj/nifi NIFI-5427 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/nifi/pull/2890.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #2890 commit 2b15a7ac2e91b8bf6d922cb3c7e9eb682bc7b3ff Author: Joe Gresock Date: 2018-07-13T16:29:45Z NIFI-5427: Updating ScrollElasticsearchHttp to use POST, supporting ES6 > ScrollElasticsearchHttp breaks with Elasticsearch 6 > --- > > Key: NIFI-5427 > URL: https://issues.apache.org/jira/browse/NIFI-5427 > Project: Apache NiFi > Issue Type: Bug >Affects Versions: 1.4.0, 1.5.0, 1.6.0, 1.7.0 >Reporter: Joseph Gresock >Assignee: Joseph Gresock >Priority: Minor > > The Elasticsearch 6 Scroll API uses scroll IDs that are nearly 10,000 > characters long. Since the ScrollElasticsearchHttp processor uses a GET > request for scrolling, this breaks the processor after the first scroll call. > > The solution is fairly simple: use a POST instead of a GET for the scroll > calls. This is backwards compatible down to Elasticsearch 2.X. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] nifi pull request #2890: NIFI-5427: Updating ScrollElasticsearchHttp to use ...
GitHub user gresockj opened a pull request: https://github.com/apache/nifi/pull/2890 NIFI-5427: Updating ScrollElasticsearchHttp to use POST, supporting ES6 Thank you for submitting a contribution to Apache NiFi. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all changes: - [x] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [x] Does your PR title start with NIFI- where is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character. - [x] Has your PR been rebased against the latest commit within the target branch (typically master)? - [x] Is your initial contribution a single, squashed commit? ### For code changes: - [x] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder? - [x] Have you written or updated unit tests to verify your changes? - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? - [ ] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly? - [ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly? - [ ] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties? ### For documentation related changes: - [ ] Have you ensured that format looks appropriate for the output in which it is rendered? ### Note: Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible. You can merge this pull request into a Git repository by running: $ git pull https://github.com/gresockj/nifi NIFI-5427 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/nifi/pull/2890.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #2890 commit 2b15a7ac2e91b8bf6d922cb3c7e9eb682bc7b3ff Author: Joe Gresock Date: 2018-07-13T16:29:45Z NIFI-5427: Updating ScrollElasticsearchHttp to use POST, supporting ES6 ---
[jira] [Commented] (NIFI-4889) Logout not working properly with OIDC
[ https://issues.apache.org/jira/browse/NIFI-4889?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16543388#comment-16543388 ] ASF GitHub Bot commented on NIFI-4889: -- Github user mcgilman commented on the issue: https://github.com/apache/nifi/pull/2830 Will review... > Logout not working properly with OIDC > - > > Key: NIFI-4889 > URL: https://issues.apache.org/jira/browse/NIFI-4889 > Project: Apache NiFi > Issue Type: Bug > Components: Core UI >Affects Versions: 1.5.0 > Environment: Browser: Chrome / Firefox > Configuration of NiFi: > - SSL certificate for the server (no client auth) > - OIDC configuration including end_session_endpoint (see the link > https://auth.s.orchestracities.com/auth/realms/default/.well-known/openid-configuration) >Reporter: Federico Michele Facca >Priority: Critical > > Click on logout, i would expect to logout and getting redirect to the auth > page. But given that the session is not closed on the oauth provider, i get > logged in again. > I suppose the solution would be to invoke the end_session_endpoint provided > in the openid discovery configuration. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] nifi issue #2830: NIFI-4889: Logout not working properly with OIDC
Github user mcgilman commented on the issue: https://github.com/apache/nifi/pull/2830 Will review... ---
[jira] [Created] (NIFI-5427) ScrollElasticsearchHttp breaks with Elasticsearch 6
Joseph Gresock created NIFI-5427: Summary: ScrollElasticsearchHttp breaks with Elasticsearch 6 Key: NIFI-5427 URL: https://issues.apache.org/jira/browse/NIFI-5427 Project: Apache NiFi Issue Type: Bug Affects Versions: 1.7.0, 1.6.0, 1.5.0, 1.4.0 Reporter: Joseph Gresock Assignee: Joseph Gresock The Elasticsearch 6 Scroll API uses scroll IDs that are nearly 10,000 characters long. Since the ScrollElasticsearchHttp processor uses a GET request for scrolling, this breaks the processor after the first scroll call. The solution is fairly simple: use a POST instead of a GET for the scroll calls. This is backwards compatible down to Elasticsearch 2.X. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (MINIFICPP-556) Create snap build
[ https://issues.apache.org/jira/browse/MINIFICPP-556?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16543329#comment-16543329 ] ASF GitHub Bot commented on MINIFICPP-556: -- GitHub user achristianson opened a pull request: https://github.com/apache/nifi-minifi-cpp/pull/371 MINIFICPP-556 Added initial snapcraft build This wouldn't have been possible without the help of Jeremy Dyer. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all changes: - [x] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [x] Does your PR title start with MINIFI- where is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character. - [x] Has your PR been rebased against the latest commit within the target branch (typically master)? - [x] Is your initial contribution a single, squashed commit? ### For code changes: - [x] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? - [x] If applicable, have you updated the LICENSE file? - [x] If applicable, have you updated the NOTICE file? ### For documentation related changes: - [x] Have you ensured that format looks appropriate for the output in which it is rendered? ### Note: Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible. You can merge this pull request into a Git repository by running: $ git pull https://github.com/achristianson/nifi-minifi-cpp MINIFICPP-556 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/nifi-minifi-cpp/pull/371.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #371 commit 4c5481aa0c44cf08786326407598659b9f3576c7 Author: Andrew I. Christianson Date: 2018-07-13T15:17:37Z MINIFICPP-556 Added initial snapcraft build > Create snap build > - > > Key: MINIFICPP-556 > URL: https://issues.apache.org/jira/browse/MINIFICPP-556 > Project: NiFi MiNiFi C++ > Issue Type: Improvement >Reporter: Andrew Christianson >Assignee: Andrew Christianson >Priority: Major > > Package nifi-minifi-cpp into a snap package for easy distribution to users > who use snap. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] nifi-minifi-cpp pull request #371: MINIFICPP-556 Added initial snapcraft bui...
GitHub user achristianson opened a pull request: https://github.com/apache/nifi-minifi-cpp/pull/371 MINIFICPP-556 Added initial snapcraft build This wouldn't have been possible without the help of Jeremy Dyer. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all changes: - [x] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [x] Does your PR title start with MINIFI- where is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character. - [x] Has your PR been rebased against the latest commit within the target branch (typically master)? - [x] Is your initial contribution a single, squashed commit? ### For code changes: - [x] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? - [x] If applicable, have you updated the LICENSE file? - [x] If applicable, have you updated the NOTICE file? ### For documentation related changes: - [x] Have you ensured that format looks appropriate for the output in which it is rendered? ### Note: Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible. You can merge this pull request into a Git repository by running: $ git pull https://github.com/achristianson/nifi-minifi-cpp MINIFICPP-556 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/nifi-minifi-cpp/pull/371.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #371 commit 4c5481aa0c44cf08786326407598659b9f3576c7 Author: Andrew I. Christianson Date: 2018-07-13T15:17:37Z MINIFICPP-556 Added initial snapcraft build ---
[jira] [Updated] (MINIFICPP-557) Segfault when including C2 AgentInformation in Alpine
[ https://issues.apache.org/jira/browse/MINIFICPP-557?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aldrin Piri updated MINIFICPP-557: -- Attachment: minifi-app.log > Segfault when including C2 AgentInformation in Alpine > - > > Key: MINIFICPP-557 > URL: https://issues.apache.org/jira/browse/MINIFICPP-557 > Project: NiFi MiNiFi C++ > Issue Type: Bug >Reporter: Aldrin Piri >Priority: Major > Attachments: minifi-app.log > > > When running an instance with AgentInformation of one of the > nifi.c2.root.classes, the instance fails to startup with a segfault. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (MINIFICPP-557) Segfault when including C2 AgentInformation in Alpine
[ https://issues.apache.org/jira/browse/MINIFICPP-557?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16543268#comment-16543268 ] Aldrin Piri commented on MINIFICPP-557: --- Debug log attached. This is for an empty configuration. > Segfault when including C2 AgentInformation in Alpine > - > > Key: MINIFICPP-557 > URL: https://issues.apache.org/jira/browse/MINIFICPP-557 > Project: NiFi MiNiFi C++ > Issue Type: Bug >Reporter: Aldrin Piri >Priority: Major > Attachments: minifi-app.log > > > When running an instance with AgentInformation of one of the > nifi.c2.root.classes, the instance fails to startup with a segfault. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (MINIFICPP-557) Segfault when including C2 AgentInformation in Alpine
Aldrin Piri created MINIFICPP-557: - Summary: Segfault when including C2 AgentInformation in Alpine Key: MINIFICPP-557 URL: https://issues.apache.org/jira/browse/MINIFICPP-557 Project: NiFi MiNiFi C++ Issue Type: Bug Reporter: Aldrin Piri When running an instance with AgentInformation of one of the nifi.c2.root.classes, the instance fails to startup with a segfault. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (NIFI-5426) Use NIO.2 API for ListFile to avoid multiple disk reads
[ https://issues.apache.org/jira/browse/NIFI-5426?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16543221#comment-16543221 ] ASF GitHub Bot commented on NIFI-5426: -- GitHub user mgaido91 opened a pull request: https://github.com/apache/nifi/pull/2889 NIFI-5426: Use NIO.2 API for ListFile Thank you for submitting a contribution to Apache NiFi. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all changes: - [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [ ] Does your PR title start with NIFI- where is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character. - [ ] Has your PR been rebased against the latest commit within the target branch (typically master)? - [ ] Is your initial contribution a single, squashed commit? ### For code changes: - [ ] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder? - [ ] Have you written or updated unit tests to verify your changes? - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? - [ ] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly? - [ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly? - [ ] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties? ### For documentation related changes: - [ ] Have you ensured that format looks appropriate for the output in which it is rendered? ### Note: Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible. You can merge this pull request into a Git repository by running: $ git pull https://github.com/mgaido91/nifi NIFI-5426 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/nifi/pull/2889.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #2889 commit 1ce4b51d91d7101d40f59f462929d637adb2c84d Author: Marco Gaido Date: 2018-07-13T14:00:02Z NIFI-5426: Use NIO.2 API for ListFile > Use NIO.2 API for ListFile to avoid multiple disk reads > --- > > Key: NIFI-5426 > URL: https://issues.apache.org/jira/browse/NIFI-5426 > Project: Apache NiFi > Issue Type: Improvement > Components: Extensions >Reporter: Mark Payne >Priority: Major > > NIFI-4631 attempted to do something similar but had issues when running > against CIFS mounts, reportedly. However, I think the issue was not the use > necessarily of NIO.2 but the way in which it was used. It attempted to use > walkTree and did did not appear to follow symlinks. As a result, this caused > failures in some scenarios. We should look at using NIO.2 and probably obtain > a Stream. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] nifi pull request #2889: NIFI-5426: Use NIO.2 API for ListFile
GitHub user mgaido91 opened a pull request: https://github.com/apache/nifi/pull/2889 NIFI-5426: Use NIO.2 API for ListFile Thank you for submitting a contribution to Apache NiFi. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all changes: - [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [ ] Does your PR title start with NIFI- where is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character. - [ ] Has your PR been rebased against the latest commit within the target branch (typically master)? - [ ] Is your initial contribution a single, squashed commit? ### For code changes: - [ ] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder? - [ ] Have you written or updated unit tests to verify your changes? - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? - [ ] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly? - [ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly? - [ ] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties? ### For documentation related changes: - [ ] Have you ensured that format looks appropriate for the output in which it is rendered? ### Note: Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible. You can merge this pull request into a Git repository by running: $ git pull https://github.com/mgaido91/nifi NIFI-5426 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/nifi/pull/2889.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #2889 commit 1ce4b51d91d7101d40f59f462929d637adb2c84d Author: Marco Gaido Date: 2018-07-13T14:00:02Z NIFI-5426: Use NIO.2 API for ListFile ---
[jira] [Updated] (NIFI-5415) Renamed ListenSyslogGroovyTest to ITListenSyslogGroovy
[
https://issues.apache.org/jira/browse/NIFI-5415?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Matt Burgess updated NIFI-5415:
---
Resolution: Fixed
Status: Resolved (was: Patch Available)
> Renamed ListenSyslogGroovyTest to ITListenSyslogGroovy
> --
>
> Key: NIFI-5415
> URL: https://issues.apache.org/jira/browse/NIFI-5415
> Project: Apache NiFi
> Issue Type: Bug
> Components: Tools and Build
>Affects Versions: 1.7.0
>Reporter: Andy LoPresto
>Assignee: Andy LoPresto
>Priority: Blocker
> Labels: groovy, integration-test, maven, syslog, test
> Fix For: 1.8.0, 1.7.1
>
>
> [~joewitt] made an effort to move inconsistent and network/timing-dependent
> unit tests to integration tests via NIFI-4659, NIFI-4660, NIFI-4662, and
> NIFI-4664.
> This file was renamed (from {{ListenSyslogGroovyTest.groovy}} to
> {{ITListenSyslogGroovy.groovy}}) but the class name inside was not changed. I
> believe the maven filter is on the class name, not the file name, because
> this test still runs in normal builds. It breaks inconsistently on my
> machine, so I renamed the class to ensure it is not run as part of the usual
> unit test battery. This is required for 1.7.1 to be released.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (NIFI-5415) Renamed ListenSyslogGroovyTest to ITListenSyslogGroovy
[
https://issues.apache.org/jira/browse/NIFI-5415?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16543220#comment-16543220
]
ASF GitHub Bot commented on NIFI-5415:
--
Github user asfgit closed the pull request at:
https://github.com/apache/nifi/pull/2883
> Renamed ListenSyslogGroovyTest to ITListenSyslogGroovy
> --
>
> Key: NIFI-5415
> URL: https://issues.apache.org/jira/browse/NIFI-5415
> Project: Apache NiFi
> Issue Type: Bug
> Components: Tools and Build
>Affects Versions: 1.7.0
>Reporter: Andy LoPresto
>Assignee: Andy LoPresto
>Priority: Blocker
> Labels: groovy, integration-test, maven, syslog, test
> Fix For: 1.8.0, 1.7.1
>
>
> [~joewitt] made an effort to move inconsistent and network/timing-dependent
> unit tests to integration tests via NIFI-4659, NIFI-4660, NIFI-4662, and
> NIFI-4664.
> This file was renamed (from {{ListenSyslogGroovyTest.groovy}} to
> {{ITListenSyslogGroovy.groovy}}) but the class name inside was not changed. I
> believe the maven filter is on the class name, not the file name, because
> this test still runs in normal builds. It breaks inconsistently on my
> machine, so I renamed the class to ensure it is not run as part of the usual
> unit test battery. This is required for 1.7.1 to be released.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[GitHub] nifi pull request #2883: NIFI-5415 Renamed ListenSyslogGroovyTest to ITListe...
Github user asfgit closed the pull request at: https://github.com/apache/nifi/pull/2883 ---
[jira] [Updated] (NIFI-5415) Renamed ListenSyslogGroovyTest to ITListenSyslogGroovy
[
https://issues.apache.org/jira/browse/NIFI-5415?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Matt Burgess updated NIFI-5415:
---
Fix Version/s: 1.8.0
> Renamed ListenSyslogGroovyTest to ITListenSyslogGroovy
> --
>
> Key: NIFI-5415
> URL: https://issues.apache.org/jira/browse/NIFI-5415
> Project: Apache NiFi
> Issue Type: Bug
> Components: Tools and Build
>Affects Versions: 1.7.0
>Reporter: Andy LoPresto
>Assignee: Andy LoPresto
>Priority: Blocker
> Labels: groovy, integration-test, maven, syslog, test
> Fix For: 1.8.0, 1.7.1
>
>
> [~joewitt] made an effort to move inconsistent and network/timing-dependent
> unit tests to integration tests via NIFI-4659, NIFI-4660, NIFI-4662, and
> NIFI-4664.
> This file was renamed (from {{ListenSyslogGroovyTest.groovy}} to
> {{ITListenSyslogGroovy.groovy}}) but the class name inside was not changed. I
> believe the maven filter is on the class name, not the file name, because
> this test still runs in normal builds. It breaks inconsistently on my
> machine, so I renamed the class to ensure it is not run as part of the usual
> unit test battery. This is required for 1.7.1 to be released.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (NIFI-5415) Renamed ListenSyslogGroovyTest to ITListenSyslogGroovy
[
https://issues.apache.org/jira/browse/NIFI-5415?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16543217#comment-16543217
]
ASF GitHub Bot commented on NIFI-5415:
--
Github user mattyb149 commented on the issue:
https://github.com/apache/nifi/pull/2883
+1 LGTM, ran with and without the change, verified the test was still being
run as a unit test without the change, and doesn't run as a unit test with the
change. Thanks for the fix! Merging to master
> Renamed ListenSyslogGroovyTest to ITListenSyslogGroovy
> --
>
> Key: NIFI-5415
> URL: https://issues.apache.org/jira/browse/NIFI-5415
> Project: Apache NiFi
> Issue Type: Bug
> Components: Tools and Build
>Affects Versions: 1.7.0
>Reporter: Andy LoPresto
>Assignee: Andy LoPresto
>Priority: Blocker
> Labels: groovy, integration-test, maven, syslog, test
> Fix For: 1.8.0, 1.7.1
>
>
> [~joewitt] made an effort to move inconsistent and network/timing-dependent
> unit tests to integration tests via NIFI-4659, NIFI-4660, NIFI-4662, and
> NIFI-4664.
> This file was renamed (from {{ListenSyslogGroovyTest.groovy}} to
> {{ITListenSyslogGroovy.groovy}}) but the class name inside was not changed. I
> believe the maven filter is on the class name, not the file name, because
> this test still runs in normal builds. It breaks inconsistently on my
> machine, so I renamed the class to ensure it is not run as part of the usual
> unit test battery. This is required for 1.7.1 to be released.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (NIFI-5415) Renamed ListenSyslogGroovyTest to ITListenSyslogGroovy
[
https://issues.apache.org/jira/browse/NIFI-5415?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16543218#comment-16543218
]
ASF subversion and git services commented on NIFI-5415:
---
Commit ffbff42421c285400f4425206490faba07036946 in nifi's branch
refs/heads/master from [~alopresto]
[ https://git-wip-us.apache.org/repos/asf?p=nifi.git;h=ffbff42 ]
NIFI-5415 Renamed ListenSyslogGroovyTest to ITListenSyslogGroovy.
Signed-off-by: Matthew Burgess
This closes #2883
> Renamed ListenSyslogGroovyTest to ITListenSyslogGroovy
> --
>
> Key: NIFI-5415
> URL: https://issues.apache.org/jira/browse/NIFI-5415
> Project: Apache NiFi
> Issue Type: Bug
> Components: Tools and Build
>Affects Versions: 1.7.0
>Reporter: Andy LoPresto
>Assignee: Andy LoPresto
>Priority: Blocker
> Labels: groovy, integration-test, maven, syslog, test
> Fix For: 1.8.0, 1.7.1
>
>
> [~joewitt] made an effort to move inconsistent and network/timing-dependent
> unit tests to integration tests via NIFI-4659, NIFI-4660, NIFI-4662, and
> NIFI-4664.
> This file was renamed (from {{ListenSyslogGroovyTest.groovy}} to
> {{ITListenSyslogGroovy.groovy}}) but the class name inside was not changed. I
> believe the maven filter is on the class name, not the file name, because
> this test still runs in normal builds. It breaks inconsistently on my
> machine, so I renamed the class to ensure it is not run as part of the usual
> unit test battery. This is required for 1.7.1 to be released.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[GitHub] nifi issue #2883: NIFI-5415 Renamed ListenSyslogGroovyTest to ITListenSyslog...
Github user mattyb149 commented on the issue: https://github.com/apache/nifi/pull/2883 +1 LGTM, ran with and without the change, verified the test was still being run as a unit test without the change, and doesn't run as a unit test with the change. Thanks for the fix! Merging to master ---
[jira] [Commented] (NIFI-5426) Use NIO.2 API for ListFile to avoid multiple disk reads
[ https://issues.apache.org/jira/browse/NIFI-5426?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16543212#comment-16543212 ] Mark Payne commented on NIFI-5426: -- To clarify, the benefit here of NIO.2 is that when a listing is obtained, the Path objects are able (at least in many circumstances) to cache the basic file attributes. However, when using the File API, a listing contains only the list of filenames, and we then have to ask the File System again about the basic attributes such as "is this a directory?" "last mod time". While this is still fast in most scenarios, for a network-mounted drive, this can sometimes lead to many minutes to list just a couple thousand files. > Use NIO.2 API for ListFile to avoid multiple disk reads > --- > > Key: NIFI-5426 > URL: https://issues.apache.org/jira/browse/NIFI-5426 > Project: Apache NiFi > Issue Type: Improvement > Components: Extensions >Reporter: Mark Payne >Priority: Major > > NIFI-4631 attempted to do something similar but had issues when running > against CIFS mounts, reportedly. However, I think the issue was not the use > necessarily of NIO.2 but the way in which it was used. It attempted to use > walkTree and did did not appear to follow symlinks. As a result, this caused > failures in some scenarios. We should look at using NIO.2 and probably obtain > a Stream. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (NIFI-5426) Use NIO.2 API for ListFile to avoid multiple disk reads
Mark Payne created NIFI-5426: Summary: Use NIO.2 API for ListFile to avoid multiple disk reads Key: NIFI-5426 URL: https://issues.apache.org/jira/browse/NIFI-5426 Project: Apache NiFi Issue Type: Improvement Components: Extensions Reporter: Mark Payne NIFI-4631 attempted to do something similar but had issues when running against CIFS mounts, reportedly. However, I think the issue was not the use necessarily of NIO.2 but the way in which it was used. It attempted to use walkTree and did did not appear to follow symlinks. As a result, this caused failures in some scenarios. We should look at using NIO.2 and probably obtain a Stream. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Resolved] (NIFIREG-185) Add element id's for User testing
[ https://issues.apache.org/jira/browse/NIFIREG-185?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Scott Aslan resolved NIFIREG-185. - Resolution: Fixed > Add element id's for User testing > - > > Key: NIFIREG-185 > URL: https://issues.apache.org/jira/browse/NIFIREG-185 > Project: NiFi Registry > Issue Type: Task >Reporter: Andrew Lim >Assignee: Andrew Lim >Priority: Minor > > I need some element id's added to perform some automated UI testing around > User test cases (User creation/deletion/duplicates etc.). -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (NIFIREG-185) Add element id's for User testing
[ https://issues.apache.org/jira/browse/NIFIREG-185?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16543185#comment-16543185 ] ASF GitHub Bot commented on NIFIREG-185: Github user scottyaslan commented on the issue: https://github.com/apache/nifi-registry/pull/130 Thanks @andrewmlim this has been merged to master > Add element id's for User testing > - > > Key: NIFIREG-185 > URL: https://issues.apache.org/jira/browse/NIFIREG-185 > Project: NiFi Registry > Issue Type: Task >Reporter: Andrew Lim >Assignee: Andrew Lim >Priority: Minor > > I need some element id's added to perform some automated UI testing around > User test cases (User creation/deletion/duplicates etc.). -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] nifi-registry issue #130: NIFIREG-185 Added element id's to facilitate User ...
Github user scottyaslan commented on the issue: https://github.com/apache/nifi-registry/pull/130 Thanks @andrewmlim this has been merged to master ---
[GitHub] nifi-registry pull request #130: NIFIREG-185 Added element id's to facilitat...
Github user asfgit closed the pull request at: https://github.com/apache/nifi-registry/pull/130 ---
[jira] [Commented] (NIFI-5425) Remove dependency duplication of nifi-utils and nifi-processor-utils
[
https://issues.apache.org/jira/browse/NIFI-5425?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16543034#comment-16543034
]
ASF GitHub Bot commented on NIFI-5425:
--
GitHub user HorizonNet opened a pull request:
https://github.com/apache/nifi/pull/2888
NIFI-5425 Removed duplicated declaration of nifi-utils and
nifi-processor-utils
Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [x] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [x] Does your PR title start with NIFI- where is the JIRA number
you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [x] Has your PR been rebased against the latest commit within the target
branch (typically master)?
- [x] Is your initial contribution a single, squashed commit?
### For code changes:
- [x] Have you ensured that the full suite of tests is executed via mvn
-Pcontrib-check clean install at the root nifi folder?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the LICENSE file, including the main
LICENSE file under nifi-assembly?
- [ ] If applicable, have you updated the NOTICE file, including the main
NOTICE file found under nifi-assembly?
- [ ] If adding new Properties, have you added .displayName in addition to
.name (programmatic access) for each of the new properties?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in
which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build
issues and submit an update to your PR as soon as possible.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ultratendency/nifi NIFI-5425
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi/pull/2888.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2888
commit 2ac2c37afa169cf0272c70d51744481619f58582
Author: Jan Hentschel
Date: 2018-07-13T13:05:30Z
NIFI-5425 Removed duplicated declaration of nifi-utils and
nifi-processor-utils
> Remove dependency duplication of nifi-utils and nifi-processor-utils
>
>
> Key: NIFI-5425
> URL: https://issues.apache.org/jira/browse/NIFI-5425
> Project: Apache NiFi
> Issue Type: Improvement
>Reporter: Jan Hentschel
>Priority: Trivial
>
> The dependencies {{nifi-utils}} and {{nifi-processor-utils}} are declared
> twice (through inheritance) in some modules. The declarations in the
> sub-modules can be removed.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[GitHub] nifi pull request #2888: NIFI-5425 Removed duplicated declaration of nifi-ut...
GitHub user HorizonNet opened a pull request: https://github.com/apache/nifi/pull/2888 NIFI-5425 Removed duplicated declaration of nifi-utils and nifi-processor-utils Thank you for submitting a contribution to Apache NiFi. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all changes: - [x] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [x] Does your PR title start with NIFI- where is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character. - [x] Has your PR been rebased against the latest commit within the target branch (typically master)? - [x] Is your initial contribution a single, squashed commit? ### For code changes: - [x] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder? - [ ] Have you written or updated unit tests to verify your changes? - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? - [ ] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly? - [ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly? - [ ] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties? ### For documentation related changes: - [ ] Have you ensured that format looks appropriate for the output in which it is rendered? ### Note: Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible. You can merge this pull request into a Git repository by running: $ git pull https://github.com/ultratendency/nifi NIFI-5425 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/nifi/pull/2888.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #2888 commit 2ac2c37afa169cf0272c70d51744481619f58582 Author: Jan Hentschel Date: 2018-07-13T13:05:30Z NIFI-5425 Removed duplicated declaration of nifi-utils and nifi-processor-utils ---
[jira] [Created] (NIFI-5425) Remove dependency duplication of nifi-utils and nifi-processor-utils
Jan Hentschel created NIFI-5425:
---
Summary: Remove dependency duplication of nifi-utils and
nifi-processor-utils
Key: NIFI-5425
URL: https://issues.apache.org/jira/browse/NIFI-5425
Project: Apache NiFi
Issue Type: Improvement
Reporter: Jan Hentschel
The dependencies {{nifi-utils}} and {{nifi-processor-utils}} are declared twice
(through inheritance) in some modules. The declarations in the sub-modules can
be removed.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (NIFI-5424) Addition of a dark mode
[ https://issues.apache.org/jira/browse/NIFI-5424?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Richard Midwinter updated NIFI-5424: Description: I've got a partial dark theme available for NiFi. Screenshot attached. Known missing items in rough order of severity - * There are various iframes in dialog boxes, none of these inherit any styling. * Needs review to see if there's a better way of including it (and potentially other themes) * The styling could do with applying, or improving in minor areas; dialog close buttons, sliders. Work in progress is here: https://github.com/richmidwinter/nifi/commits/nifi-5424 was: I've got a partial dark theme available for NiFi. Screenshot attached. Known missing items in rough order of severity - * There are various iframes in dialog boxes, none of these inherit any styling. * Needs review to see if there's a better way of including it (and potentially other themes) * The styling could do with applying, or improving in minor areas; dialog close buttons, sliders. > Addition of a dark mode > --- > > Key: NIFI-5424 > URL: https://issues.apache.org/jira/browse/NIFI-5424 > Project: Apache NiFi > Issue Type: New Feature > Components: Core UI >Affects Versions: 1.7.0 >Reporter: Richard Midwinter >Priority: Major > Attachments: lSofSq5.jpg > > > I've got a partial dark theme available for NiFi. > Screenshot attached. > Known missing items in rough order of severity - > * There are various iframes in dialog boxes, none of these inherit any > styling. > * Needs review to see if there's a better way of including it (and > potentially other themes) > * The styling could do with applying, or improving in minor areas; dialog > close buttons, sliders. > Work in progress is here: > https://github.com/richmidwinter/nifi/commits/nifi-5424 -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (NIFI-5424) Addition of a dark mode
[ https://issues.apache.org/jira/browse/NIFI-5424?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Richard Midwinter updated NIFI-5424: Priority: Minor (was: Major) > Addition of a dark mode > --- > > Key: NIFI-5424 > URL: https://issues.apache.org/jira/browse/NIFI-5424 > Project: Apache NiFi > Issue Type: New Feature > Components: Core UI >Affects Versions: 1.7.0 >Reporter: Richard Midwinter >Priority: Minor > Attachments: lSofSq5.jpg > > > I've got a partial dark theme available for NiFi. > Screenshot attached. > Known missing items in rough order of severity - > * There are various iframes in dialog boxes, none of these inherit any > styling. > * Needs review to see if there's a better way of including it (and > potentially other themes) > * The styling could do with applying, or improving in minor areas; dialog > close buttons, sliders. > Work in progress is here: > https://github.com/richmidwinter/nifi/commits/nifi-5424 -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (NIFI-5424) Addition of a dark mode
[ https://issues.apache.org/jira/browse/NIFI-5424?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Richard Midwinter updated NIFI-5424: Summary: Addition of a dark mode (was: Add dark mode) > Addition of a dark mode > --- > > Key: NIFI-5424 > URL: https://issues.apache.org/jira/browse/NIFI-5424 > Project: Apache NiFi > Issue Type: New Feature > Components: Core UI >Affects Versions: 1.7.0 >Reporter: Richard Midwinter >Priority: Major > Attachments: lSofSq5.jpg > > > I've got a partial dark theme available for NiFi. > Screenshot attached. > Known missing items in rough order of severity - > * There are various iframes in dialog boxes, none of these inherit any > styling. > * Needs review to see if there's a better way of including it (and > potentially other themes) > * The styling could do with applying, or improving in minor areas; dialog > close buttons, sliders. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (NIFI-5424) Add dark mode
Richard Midwinter created NIFI-5424: --- Summary: Add dark mode Key: NIFI-5424 URL: https://issues.apache.org/jira/browse/NIFI-5424 Project: Apache NiFi Issue Type: New Feature Components: Core UI Affects Versions: 1.7.0 Reporter: Richard Midwinter Attachments: lSofSq5.jpg I've got a partial dark theme available for NiFi. Screenshot attached. Known missing items in rough order of severity - * There are various iframes in dialog boxes, none of these inherit any styling. * Needs review to see if there's a better way of including it (and potentially other themes) * The styling could do with applying, or improving in minor areas; dialog close buttons, sliders. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (NIFI-3993) Upgrade embedded ZooKeeper version
[ https://issues.apache.org/jira/browse/NIFI-3993?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16542949#comment-16542949 ] ASF GitHub Bot commented on NIFI-3993: -- Github user joewitt commented on the issue: https://github.com/apache/nifi/pull/2884 @jtstorck @YolandaMDavis and others interested - i recall some comments about holding off on updating zookeeper because of compatibility, etc.. Is that right? @HorizonNet did you test the migrator and cluster functions with these changes including secure/unsecure settings by chance? > Upgrade embedded ZooKeeper version > -- > > Key: NIFI-3993 > URL: https://issues.apache.org/jira/browse/NIFI-3993 > Project: Apache NiFi > Issue Type: Bug > Components: Core Framework >Affects Versions: 1.2.0 >Reporter: Mark Bean >Priority: Major > > In a Cluster configuration, Nodes are periodically disconnected from the > Cluster, and then reconnected. These events correspond to the following error: > ERROR [CommitProcessor:1] o.apache.zookeeper.server.NIOServerCnxn Unexpected > Exception: > java.nio.channels.CancelledKeyException: null > at sun.nio.ch.SelectionKeyImpl.ensureValid(SectionKeyImpl.java:73) > at sun.nio.ch.SelectionKeyImpl.interestOps(SelctionKeyImpl.java:77) > at > org.apache.zookeeper.server.NIOServerCnxn.sendBuffer(NIOServerCnxn.java:151) > at > org.apache.zookeeper.server.NIOServerCnXn.sendResopnse(NIOServerCnxn.java:1081) > at > org.apache.zookeeper.server.FinalRequestProcessor.processRequest(FinalRequestProcessor.java:404) > at > org.apache.zookeeper.server.quorum.CommitProcessor.run(CommitProcessor.java:74) > This error was reported in ZooKeeper JIRA [1], and reported as fixed in > version 3.4.10, the current stable build. As additional confirmation, when > using a stand-alone ZK, 3.4.10, rather than the embedded ZK, the above error > was no longer observed. > Update NiFi to use ZK 3.4.10 > [1] https://issues.apache.org/jira/browse/ZOOKEEPER-2044 -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] nifi issue #2884: NIFI-3993 Updated the ZooKeeper version to 3.4.10
Github user joewitt commented on the issue: https://github.com/apache/nifi/pull/2884 @jtstorck @YolandaMDavis and others interested - i recall some comments about holding off on updating zookeeper because of compatibility, etc.. Is that right? @HorizonNet did you test the migrator and cluster functions with these changes including secure/unsecure settings by chance? ---
[jira] [Commented] (NIFI-5423) junit and slf4j-simple dependencies duplicated in sub-modules
[
https://issues.apache.org/jira/browse/NIFI-5423?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16542947#comment-16542947
]
ASF GitHub Bot commented on NIFI-5423:
--
GitHub user HorizonNet opened a pull request:
https://github.com/apache/nifi/pull/2887
NIFI-5423 Removed duplicated dependencies in sub-modules
Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [x] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [x] Does your PR title start with NIFI- where is the JIRA number
you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [x] Has your PR been rebased against the latest commit within the target
branch (typically master)?
- [x] Is your initial contribution a single, squashed commit?
### For code changes:
- [x] Have you ensured that the full suite of tests is executed via mvn
-Pcontrib-check clean install at the root nifi folder?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the LICENSE file, including the main
LICENSE file under nifi-assembly?
- [ ] If applicable, have you updated the NOTICE file, including the main
NOTICE file found under nifi-assembly?
- [ ] If adding new Properties, have you added .displayName in addition to
.name (programmatic access) for each of the new properties?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in
which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build
issues and submit an update to your PR as soon as possible.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ultratendency/nifi NIFI-5423
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi/pull/2887.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2887
commit d0a710d1630d8bdca643d770b8ee8c768c089eda
Author: Jan Hentschel
Date: 2018-07-13T11:51:14Z
NIFI-5423 Removed duplicated dependencies in sub-modules
> junit and slf4j-simple dependencies duplicated in sub-modules
> -
>
> Key: NIFI-5423
> URL: https://issues.apache.org/jira/browse/NIFI-5423
> Project: Apache NiFi
> Issue Type: Improvement
>Reporter: Jan Hentschel
>Priority: Minor
>
> {{junit}} and {{slf4j-simple}} are declared in the root POM, but some
> sub-modules duplicate them in their definition. The duplicated definitions in
> the sub-modules should be removed.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[GitHub] nifi pull request #2887: NIFI-5423 Removed duplicated dependencies in sub-mo...
GitHub user HorizonNet opened a pull request: https://github.com/apache/nifi/pull/2887 NIFI-5423 Removed duplicated dependencies in sub-modules Thank you for submitting a contribution to Apache NiFi. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all changes: - [x] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [x] Does your PR title start with NIFI- where is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character. - [x] Has your PR been rebased against the latest commit within the target branch (typically master)? - [x] Is your initial contribution a single, squashed commit? ### For code changes: - [x] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder? - [ ] Have you written or updated unit tests to verify your changes? - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? - [ ] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly? - [ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly? - [ ] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties? ### For documentation related changes: - [ ] Have you ensured that format looks appropriate for the output in which it is rendered? ### Note: Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible. You can merge this pull request into a Git repository by running: $ git pull https://github.com/ultratendency/nifi NIFI-5423 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/nifi/pull/2887.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #2887 commit d0a710d1630d8bdca643d770b8ee8c768c089eda Author: Jan Hentschel Date: 2018-07-13T11:51:14Z NIFI-5423 Removed duplicated dependencies in sub-modules ---
[jira] [Created] (NIFI-5423) junit and slf4j-simple dependencies duplicated in sub-modules
Jan Hentschel created NIFI-5423:
---
Summary: junit and slf4j-simple dependencies duplicated in
sub-modules
Key: NIFI-5423
URL: https://issues.apache.org/jira/browse/NIFI-5423
Project: Apache NiFi
Issue Type: Improvement
Reporter: Jan Hentschel
{{junit}} and {{slf4j-simple}} are declared in the root POM, but some
sub-modules duplicate them in their definition. The duplicated definitions in
the sub-modules should be removed.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (NIFI-5422) Make ExecuteScript thread safe & use CompiledScript where possible
[ https://issues.apache.org/jira/browse/NIFI-5422?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ramon Havermans updated NIFI-5422: -- Description: In ExcuteScript Bindings are reused, which makes it non thread safe. Most engines can use a Compiled version of the engine, which makes it faster. Pull request will follow. was:In ExcuteScript Bindings are reused, which makes it non thread safe. Most engines can use a Compiled version of the engine, which makes it faster. > Make ExecuteScript thread safe & use CompiledScript where possible > -- > > Key: NIFI-5422 > URL: https://issues.apache.org/jira/browse/NIFI-5422 > Project: Apache NiFi > Issue Type: Improvement > Components: Core Framework >Reporter: Ramon Havermans >Priority: Major > > In ExcuteScript Bindings are reused, which makes it non thread safe. Most > engines can use a Compiled version of the engine, which makes it faster. > Pull request will follow. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (NIFI-5422) Make ExecuteScript thread safe & use CompiledScript where possible
Ramon Havermans created NIFI-5422: - Summary: Make ExecuteScript thread safe & use CompiledScript where possible Key: NIFI-5422 URL: https://issues.apache.org/jira/browse/NIFI-5422 Project: Apache NiFi Issue Type: Improvement Components: Core Framework Reporter: Ramon Havermans In ExcuteScript Bindings are reused, which makes it non thread safe. Most engines can use a Compiled version of the engine, which makes it faster. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (NIFI-5421) Provide support for Kerberized zookeeper in docker instances
[ https://issues.apache.org/jira/browse/NIFI-5421?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sarthak updated NIFI-5421: -- Description: We should make the Docker image configurable to support Kerberized zookeeper in NiFi (was: We should make the Docker image configurable to support all of the common security options available in NiFi) > Provide support for Kerberized zookeeper in docker instances > > > Key: NIFI-5421 > URL: https://issues.apache.org/jira/browse/NIFI-5421 > Project: Apache NiFi > Issue Type: Improvement > Components: Docker >Affects Versions: 1.7.0 >Reporter: Sarthak >Priority: Major > > We should make the Docker image configurable to support Kerberized zookeeper > in NiFi -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Assigned] (NIFI-5421) Provide support for Kerberized zookeeper in docker instances
[ https://issues.apache.org/jira/browse/NIFI-5421?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sarthak reassigned NIFI-5421: - Assignee: Sarthak > Provide support for Kerberized zookeeper in docker instances > > > Key: NIFI-5421 > URL: https://issues.apache.org/jira/browse/NIFI-5421 > Project: Apache NiFi > Issue Type: Improvement > Components: Docker >Affects Versions: 1.7.0 >Reporter: Sarthak >Assignee: Sarthak >Priority: Major > > We should make the Docker image configurable to support Kerberized zookeeper > in NiFi -- This message was sent by Atlassian JIRA (v7.6.3#76005)
