[jira] [Commented] (TRAFODION-2873) LOB:Cleanup usage of LOBLoad which si deprecated and LobGlobals
[ https://issues.apache.org/jira/browse/TRAFODION-2873?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16331830#comment-16331830 ] ASF GitHub Bot commented on TRAFODION-2873: --- Github user asfgit closed the pull request at: https://github.com/apache/trafodion/pull/1405 > LOB:Cleanup usage of LOBLoad which si deprecated and LobGlobals > --- > > Key: TRAFODION-2873 > URL: https://issues.apache.org/jira/browse/TRAFODION-2873 > Project: Apache Trafodion > Issue Type: Bug > Components: sql-exe >Affects Versions: 2.3 >Reporter: Sandhya Sundaresan >Assignee: Sandhya Sundaresan >Priority: Major > > The LOBGlobals structure contains information relevant to LOBLoad which was > an operator initially designed to operate at the disk level. It is no longer > needed/relevant so cleaning up that code and simplifying the LOBGlobals > sturcture as well to keep only the relevant data members. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (TRAFODION-2873) LOB:Cleanup usage of LOBLoad which si deprecated and LobGlobals
[ https://issues.apache.org/jira/browse/TRAFODION-2873?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16331822#comment-16331822 ] ASF GitHub Bot commented on TRAFODION-2873: --- Github user sandhyasun commented on a diff in the pull request: https://github.com/apache/trafodion/pull/1405#discussion_r162546998 --- Diff: core/sql/exp/ExpLOBprocess.cpp --- @@ -575,7 +575,7 @@ Lng32 main(Lng32 argc, char *argv[]) // setup log4cxx QRLogger::initLog4cxx(QRLogger::QRL_LOB); // initialize lob globals -lobGlobals = new ExLobGlobals(); +lobGlobals = new ExLobGlobals(NULL); --- End diff -- The ExpLOBprocess.cpp is dormant code for now. If we enable it and create a LOB process to offload some operations like GC etc, we will need to create and setup globals , send messages form the master process to it etc . For now I just had to ensure it compiled. > LOB:Cleanup usage of LOBLoad which si deprecated and LobGlobals > --- > > Key: TRAFODION-2873 > URL: https://issues.apache.org/jira/browse/TRAFODION-2873 > Project: Apache Trafodion > Issue Type: Bug > Components: sql-exe >Affects Versions: 2.3 >Reporter: Sandhya Sundaresan >Assignee: Sandhya Sundaresan >Priority: Major > > The LOBGlobals structure contains information relevant to LOBLoad which was > an operator initially designed to operate at the disk level. It is no longer > needed/relevant so cleaning up that code and simplifying the LOBGlobals > sturcture as well to keep only the relevant data members. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (TRAFODION-2873) LOB:Cleanup usage of LOBLoad which si deprecated and LobGlobals
[ https://issues.apache.org/jira/browse/TRAFODION-2873?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16331772#comment-16331772 ] ASF GitHub Bot commented on TRAFODION-2873: --- Github user selvaganesang commented on a diff in the pull request: https://github.com/apache/trafodion/pull/1405#discussion_r162542021 --- Diff: core/sql/exp/ExpLOBprocess.cpp --- @@ -575,7 +575,7 @@ Lng32 main(Lng32 argc, char *argv[]) // setup log4cxx QRLogger::initLog4cxx(QRLogger::QRL_LOB); // initialize lob globals -lobGlobals = new ExLobGlobals(); +lobGlobals = new ExLobGlobals(NULL); --- End diff -- Thanks for avoiding the default value for the param. But, I think sending heap as NULL might make this program to fail. Have you tested this program? If you have tested this program already, then this PR is ready to be merged. > LOB:Cleanup usage of LOBLoad which si deprecated and LobGlobals > --- > > Key: TRAFODION-2873 > URL: https://issues.apache.org/jira/browse/TRAFODION-2873 > Project: Apache Trafodion > Issue Type: Bug > Components: sql-exe >Affects Versions: 2.3 >Reporter: Sandhya Sundaresan >Assignee: Sandhya Sundaresan >Priority: Major > > The LOBGlobals structure contains information relevant to LOBLoad which was > an operator initially designed to operate at the disk level. It is no longer > needed/relevant so cleaning up that code and simplifying the LOBGlobals > sturcture as well to keep only the relevant data members. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (TRAFODION-2873) LOB:Cleanup usage of LOBLoad which si deprecated and LobGlobals
[
https://issues.apache.org/jira/browse/TRAFODION-2873?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16331388#comment-16331388
]
ASF GitHub Bot commented on TRAFODION-2873:
---
Github user sandhyasun commented on a diff in the pull request:
https://github.com/apache/trafodion/pull/1405#discussion_r162494316
--- Diff: core/sql/exp/ExpLOBaccess.h ---
@@ -589,7 +589,7 @@ class ExLobGlobals
{
public :
-ExLobGlobals();
+ExLobGlobals(NAHeap *lobHeap=NULL);
--- End diff --
Sure that's another way. Will do that.
> LOB:Cleanup usage of LOBLoad which si deprecated and LobGlobals
> ---
>
> Key: TRAFODION-2873
> URL: https://issues.apache.org/jira/browse/TRAFODION-2873
> Project: Apache Trafodion
> Issue Type: Bug
> Components: sql-exe
>Affects Versions: 2.3
>Reporter: Sandhya Sundaresan
>Assignee: Sandhya Sundaresan
>Priority: Major
>
> The LOBGlobals structure contains information relevant to LOBLoad which was
> an operator initially designed to operate at the disk level. It is no longer
> needed/relevant so cleaning up that code and simplifying the LOBGlobals
> sturcture as well to keep only the relevant data members.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (TRAFODION-2873) LOB:Cleanup usage of LOBLoad which si deprecated and LobGlobals
[
https://issues.apache.org/jira/browse/TRAFODION-2873?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16331375#comment-16331375
]
ASF GitHub Bot commented on TRAFODION-2873:
---
Github user DaveBirdsall commented on a diff in the pull request:
https://github.com/apache/trafodion/pull/1405#discussion_r162492297
--- Diff: core/sql/cli/Cli.cpp ---
@@ -9726,10 +9742,26 @@ Lng32 SQLCLI_LOBddlInterface
//lob data files. Note that if there is an error in the drop of
the
//descriptor tables above , the transaction will restore each of
the
//above tables .
+//Initialize LOB interface
+
+Int32 rc=
ExpLOBoper::initLOBglobal(exLobGlob,currContext.exHeap(),,hdfsServer,hdfsPort);
+if (rc)
+ {
+{
--- End diff --
Same comment here
> LOB:Cleanup usage of LOBLoad which si deprecated and LobGlobals
> ---
>
> Key: TRAFODION-2873
> URL: https://issues.apache.org/jira/browse/TRAFODION-2873
> Project: Apache Trafodion
> Issue Type: Bug
> Components: sql-exe
>Affects Versions: 2.3
>Reporter: Sandhya Sundaresan
>Assignee: Sandhya Sundaresan
>Priority: Major
>
> The LOBGlobals structure contains information relevant to LOBLoad which was
> an operator initially designed to operate at the disk level. It is no longer
> needed/relevant so cleaning up that code and simplifying the LOBGlobals
> sturcture as well to keep only the relevant data members.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (TRAFODION-2873) LOB:Cleanup usage of LOBLoad which si deprecated and LobGlobals
[
https://issues.apache.org/jira/browse/TRAFODION-2873?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16331374#comment-16331374
]
ASF GitHub Bot commented on TRAFODION-2873:
---
Github user DaveBirdsall commented on a diff in the pull request:
https://github.com/apache/trafodion/pull/1405#discussion_r162492341
--- Diff: core/sql/cli/Cli.cpp ---
@@ -9765,12 +9797,27 @@ Lng32 SQLCLI_LOBddlInterface
goto error_return;
}
-
+ //Initialize LOB interface
+
+Int32 rc=
ExpLOBoper::initLOBglobal(exLobGlob,currContext.exHeap(),,hdfsServer,hdfsPort);
+if (rc)
+ {
+{
--- End diff --
And here
> LOB:Cleanup usage of LOBLoad which si deprecated and LobGlobals
> ---
>
> Key: TRAFODION-2873
> URL: https://issues.apache.org/jira/browse/TRAFODION-2873
> Project: Apache Trafodion
> Issue Type: Bug
> Components: sql-exe
>Affects Versions: 2.3
>Reporter: Sandhya Sundaresan
>Assignee: Sandhya Sundaresan
>Priority: Major
>
> The LOBGlobals structure contains information relevant to LOBLoad which was
> an operator initially designed to operate at the disk level. It is no longer
> needed/relevant so cleaning up that code and simplifying the LOBGlobals
> sturcture as well to keep only the relevant data members.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (TRAFODION-2873) LOB:Cleanup usage of LOBLoad which si deprecated and LobGlobals
[
https://issues.apache.org/jira/browse/TRAFODION-2873?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16331373#comment-16331373
]
ASF GitHub Bot commented on TRAFODION-2873:
---
Github user DaveBirdsall commented on a diff in the pull request:
https://github.com/apache/trafodion/pull/1405#discussion_r162492113
--- Diff: core/sql/cli/Cli.cpp ---
@@ -9611,12 +9611,28 @@ Lng32 SQLCLI_LOBddlInterface
} // for
+//Initialize LOB interface
+
+Int32 rc=
ExpLOBoper::initLOBglobal(exLobGlob,currContext.exHeap(),,hdfsServer,hdfsPort);
+if (rc)
+ {
+{
--- End diff --
It doesn't hurt anything, but I'm curious: Why two sets of braces? Looks
like one would do?
> LOB:Cleanup usage of LOBLoad which si deprecated and LobGlobals
> ---
>
> Key: TRAFODION-2873
> URL: https://issues.apache.org/jira/browse/TRAFODION-2873
> Project: Apache Trafodion
> Issue Type: Bug
> Components: sql-exe
>Affects Versions: 2.3
>Reporter: Sandhya Sundaresan
>Assignee: Sandhya Sundaresan
>Priority: Major
>
> The LOBGlobals structure contains information relevant to LOBLoad which was
> an operator initially designed to operate at the disk level. It is no longer
> needed/relevant so cleaning up that code and simplifying the LOBGlobals
> sturcture as well to keep only the relevant data members.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (TRAFODION-2873) LOB:Cleanup usage of LOBLoad which si deprecated and LobGlobals
[
https://issues.apache.org/jira/browse/TRAFODION-2873?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16331064#comment-16331064
]
ASF GitHub Bot commented on TRAFODION-2873:
---
Github user sandhyasun commented on a diff in the pull request:
https://github.com/apache/trafodion/pull/1405#discussion_r162448037
--- Diff: core/sql/exp/ExpLOBaccess.h ---
@@ -589,7 +589,7 @@ class ExLobGlobals
{
public :
-ExLobGlobals();
+ExLobGlobals(NAHeap *lobHeap=NULL);
--- End diff --
Yes this was only done to be able to compile the call in ExpLobProcess.cpp.
Currently this code is unused and is kept around in case we need to offload any
processing to another process. This code, invokes LobGlobals and there is no
heap available. So I had to make it default just for this unused code. WIll
put a comment that it shoudl always pass a heap. In anycase a caller cannot
initialize the LobGlobals without passing in a caller's heap - i.e the only way
to initialize is by calling ExpLOBinterfaceInit or ExpLOBoper::initLobGlobal.
Both require a heap to get passed in.
> LOB:Cleanup usage of LOBLoad which si deprecated and LobGlobals
> ---
>
> Key: TRAFODION-2873
> URL: https://issues.apache.org/jira/browse/TRAFODION-2873
> Project: Apache Trafodion
> Issue Type: Bug
> Components: sql-exe
>Affects Versions: 2.3
>Reporter: Sandhya Sundaresan
>Assignee: Sandhya Sundaresan
>Priority: Major
>
> The LOBGlobals structure contains information relevant to LOBLoad which was
> an operator initially designed to operate at the disk level. It is no longer
> needed/relevant so cleaning up that code and simplifying the LOBGlobals
> sturcture as well to keep only the relevant data members.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (TRAFODION-2873) LOB:Cleanup usage of LOBLoad which si deprecated and LobGlobals
[
https://issues.apache.org/jira/browse/TRAFODION-2873?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16331018#comment-16331018
]
ASF GitHub Bot commented on TRAFODION-2873:
---
Github user selvaganesang commented on a diff in the pull request:
https://github.com/apache/trafodion/pull/1405#discussion_r162442989
--- Diff: core/sql/exp/ExpLOBaccess.h ---
@@ -589,7 +589,7 @@ class ExLobGlobals
{
public :
-ExLobGlobals();
+ExLobGlobals(NAHeap *lobHeap=NULL);
--- End diff --
It is better to avoid the default value for this parameter.
> LOB:Cleanup usage of LOBLoad which si deprecated and LobGlobals
> ---
>
> Key: TRAFODION-2873
> URL: https://issues.apache.org/jira/browse/TRAFODION-2873
> Project: Apache Trafodion
> Issue Type: Bug
> Components: sql-exe
>Affects Versions: 2.3
>Reporter: Sandhya Sundaresan
>Assignee: Sandhya Sundaresan
>Priority: Major
>
> The LOBGlobals structure contains information relevant to LOBLoad which was
> an operator initially designed to operate at the disk level. It is no longer
> needed/relevant so cleaning up that code and simplifying the LOBGlobals
> sturcture as well to keep only the relevant data members.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (TRAFODION-2873) LOB:Cleanup usage of LOBLoad which si deprecated and LobGlobals
[ https://issues.apache.org/jira/browse/TRAFODION-2873?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16311808#comment-16311808 ] ASF GitHub Bot commented on TRAFODION-2873: --- Github user asfgit closed the pull request at: https://github.com/apache/trafodion/pull/1365 > LOB:Cleanup usage of LOBLoad which si deprecated and LobGlobals > --- > > Key: TRAFODION-2873 > URL: https://issues.apache.org/jira/browse/TRAFODION-2873 > Project: Apache Trafodion > Issue Type: Bug > Components: sql-exe >Affects Versions: 2.3 >Reporter: Sandhya Sundaresan >Assignee: Sandhya Sundaresan > > The LOBGlobals structure contains information relevant to LOBLoad which was > an operator initially designed to operate at the disk level. It is no longer > needed/relevant so cleaning up that code and simplifying the LOBGlobals > sturcture as well to keep only the relevant data members. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
