Re[2]: [JBoss-dev] Deployers lifecycle/logging question
Hello Tobias, good question. I'd like to know too. Friday, May 24, 2002, 1:55:26 PM, you wrote: TF Hi Alex! TF Does log4j guarantee to display the log messages in the order they TF timely occured ? TF With the old logging that wasn't the case (it was NOT guaranteed). It do TF not know for log4j. TF Just a thought, TF Tobias TF Alex Loubyansky wrote: Hello, I am now testing FoeDeployer and have a question that, probably, affects behaviour of other deployers too. Suppose we have deployment units in the deploy dir waiting for the deployer. And the deployer is at last deployed. I expect the following sequence of calls on the deployer: createService(), startService and then start to deploy utnits waiting for the deployer (done in MainDeployer.addDeployer()). The code proves it but logging doesn't. Here is the log: INFO [org.jboss.deployment.MainDeployer] Starting deployment of package: file:/C:/CVSROOT/jboss-all/build/output/jboss-3.1.0alpha/server/default/deploy/wlar-examples.wlar INFO [org.jboss.deployment.MainDeployer] Deployment of package: file:/C:/CVSROOT/jboss-all/build/output/jboss-3.1.0alpha/server/default/deploy/wlar-examples.wlar is waiting for an appropriate deployer. INFO [org.jboss.deployment.MainDeployer] Starting deployment of package: file:/C:/CVSROOT/jboss-all/build/output/jboss-3.1.0alpha/server/default/deploy/foe-deployer.sar INFO [org.jboss.deployment.SARDeployer] Created ServiceModule: jboss.management.single:J2EEServer=Single,j2eeType=ServiceModule,name=foe-deployer.sar INFO [org.jboss.varia.deployment.FoeDeployer] Creating INFO [org.jboss.varia.deployment.FoeDeployer] Created INFO [org.jboss.varia.deployment.convertor.WebLogicConvertor] Creating INFO [org.jboss.varia.deployment.convertor.WebLogicConvertor] Created INFO [org.jboss.deployment.SARDeployer] Create MBean, name: jboss:service=FoeDeployer, SAR Module: jboss.management.single:J2EEServer=Single,j2eeType=ServiceModule,name=foe-deployer.sar INFO [org.jboss.deployment.SARDeployer] Create MBean, name: jboss:service=Convertor,type=WebLogic, SAR Module: jboss.management.single:J2EEServer=Single,j2eeType=ServiceModule,name=foe-deployer.sar INFO [org.jboss.varia.deployment.FoeDeployer] Starting INFO [org.jboss.deployment.MainDeployer] Adding deployer: org.jboss.varia.deployment.FoeDeployer@e8606c INFO [org.jboss.deployment.MainDeployer] Starting deployment of package: file:/C:/CVSROOT/jboss-all/build/output/jboss-3.1.0alpha/server/default/deploy/wlar-examples.wlar DEBUG [org.jboss.varia.deployment.FoeDeployer] create(), got info: org.jboss.deployment.DeploymentInfo@ee07486d{ url=file:/C:/CVSROOT/jboss-all/build/output/jboss-3.1.0alpha/server/default/deploy/wlar-examples.wlar } DEBUG [org.jboss.varia.deployment.FoeDeployer] undeploying document file:/C:/CVSROOT/jboss-all/build/output/jboss-3.1.0alpha/server/default/deploy/wlar-examples.wlar INFO [org.jboss.deployment.MainDeployer] Successfully completed deployment of package: file:/C:/CVSROOT/jboss-all/build/output/jboss-3.1.0alpha/server/default/deploy/wlar-examples.wlar INFO [org.jboss.varia.deployment.FoeDeployer] Started INFO [org.jboss.varia.deployment.convertor.WebLogicConvertor] Starting INFO [org.jboss.varia.deployment.convertor.WebLogicConvertor] Started INFO [org.jboss.deployment.MainDeployer] Successfully completed deployment of package: file:/C:/CVSROOT/jboss-all/build/output/jboss-3.1.0alpha/server/default/deploy/foe-deployer.sar INFO [org.jboss.deployment.MainDeployer] Starting deployment of package: file:/C:/CVSROOT/jboss-all/build/output/jboss-3.1.0alpha/server/default/deploy/wlar-examples.jar ... So, the log says that waiting for the deployer units (wlar-examples.wlar) are deployed before the deployer (FoeDeployer) is actually started. And WebLogicConverter isn't started at all by the time of successful deployment of wlar. In FoeDeployer super.startService() is the last line in method startService(). And converters (WebLogicConverter) are invoked in FoeDeployer.create() method. Could someone clarify it, please? Is it just logging? -- Best regards, Alex Loubyansky ___ Don't miss the 2002 Sprint PCS Application Developer's Conference August 25-28 in Las Vegas -- http://devcon.sprintpcs.com/adp/index.cfm ___ Jboss-development mailing list [EMAIL PROTECTED] https://lists.sourceforge.net/lists/listinfo/jboss-development
Re[2]: [JBoss-dev] Deployers lifecycle/logging question
Hello David, I asked that because I found it strange that the deployer not being started already deploys some units, if the log is right. So, the log is like: [FoeDeployer] Starting [MainDeployer] Adding deployer: [MainDeployer] Starting deployment of package: waitinig unit [FoeDeployer] create() ... [FoeDeployer] Started when I expected it like this: [FoeDeployer] Starting [FoeDeployer] Started [MainDeployer] Adding deployer: [MainDeployer] Starting deployment of package: waitinig unit [FoeDeployer] create() ... Am I wrong? Friday, May 24, 2002, 4:20:33 PM, you wrote: DJ From your description below I think FoeDeployer depends on DJ WebLogicConverter. If you explicitly state this dependency with a depends DJ tag the deployment system will create WLC before FD and start WLC before DJ FD. If FD is designed to accept lots of converters you can use a DJ depends-list element. DJ How does FD know about WLC now? I'd recommend using an ObjectName and DJ calling through the mbean server. DJ If you want to allow dynamically adding converters you will have to make FD DJ keep a list of undeployables that it tries to deploy whenever a new DJ converter is registered. I don't think I recommend this. DJ david jencks -- Best regards, Alex Loubyansky ___ Don't miss the 2002 Sprint PCS Application Developer's Conference August 25-28 in Las Vegas -- http://devcon.sprintpcs.com/adp/index.cfm ___ Jboss-development mailing list [EMAIL PROTECTED] https://lists.sourceforge.net/lists/listinfo/jboss-development
Re[2]: [JBoss-dev] Deployers lifecycle/logging question
Hello David, Friday, May 24, 2002, 4:20:33 PM, you wrote: DJ From your description below I think FoeDeployer depends on DJ WebLogicConverter. If you explicitly state this dependency with a depends DJ tag the deployment system will create WLC before FD and start WLC before DJ FD. If FD is designed to accept lots of converters you can use a DJ depends-list element. No. WebLogicConvertor depends on FoeDeployer. And it's expressed with a depends element. In the architecture as it is exists for now I think it's the right choice. Because WLC has a deployer's name and in startService() it's added to it's deployer (FD) which contains the list of convertors. DJ How does FD know about WLC now? I'd recommend using an ObjectName and DJ calling through the mbean server. Actually, already answered. It's done this way. DJ If you want to allow dynamically adding converters you will have to make FD DJ keep a list of undeployables that it tries to deploy whenever a new DJ converter is registered. I don't think I recommend this. Do you have other remarks? Please, let me know. I am becoming crazy of it but feel have to learn more :) alex ___ Don't miss the 2002 Sprint PCS Application Developer's Conference August 25-28 in Las Vegas -- http://devcon.sprintpcs.com/adp/index.cfm ___ Jboss-development mailing list [EMAIL PROTECTED] https://lists.sourceforge.net/lists/listinfo/jboss-development
Re: Re[2]: [JBoss-dev] Deployers lifecycle/logging question
The FoeDeployer should register with MainDeployer as the last thing it does in startService(), when it is in fact usable. So at least you should move super.startService() to the end. I just looked at the code and think that a simpler design would be to simply have the WLC be a SubDeployer. You can make a common superclass with utility methods all the foe deployers will need. Otherwise you will have to either give foedeployer a list of all the converters it will get, which is kind of silly, or implement another layer of waiting behavior in FoeDeployer, which is even sillier. As far as I can tell from a quick glance, FoeDeployer doesn't do anything that couldn't be done at least as well in a superclass of WLC. Also I thought some of the file manipulation methods were already in SubDeployerSupport?? I havne't looked at it for a while though. thanks david jencks On 2002.05.24 09:53:33 -0400 Alex Loubyansky wrote: Hello David, I asked that because I found it strange that the deployer not being started already deploys some units, if the log is right. So, the log is like: [FoeDeployer] Starting [MainDeployer] Adding deployer: [MainDeployer] Starting deployment of package: waitinig unit [FoeDeployer] create() ... [FoeDeployer] Started when I expected it like this: [FoeDeployer] Starting [FoeDeployer] Started [MainDeployer] Adding deployer: [MainDeployer] Starting deployment of package: waitinig unit [FoeDeployer] create() ... Am I wrong? Friday, May 24, 2002, 4:20:33 PM, you wrote: DJ From your description below I think FoeDeployer depends on DJ WebLogicConverter. If you explicitly state this dependency with a depends DJ tag the deployment system will create WLC before FD and start WLC before DJ FD. If FD is designed to accept lots of converters you can use a DJ depends-list element. DJ How does FD know about WLC now? I'd recommend using an ObjectName and DJ calling through the mbean server. DJ If you want to allow dynamically adding converters you will have to make FD DJ keep a list of undeployables that it tries to deploy whenever a new DJ converter is registered. I don't think I recommend this. DJ david jencks -- Best regards, Alex Loubyansky ___ Don't miss the 2002 Sprint PCS Application Developer's Conference August 25-28 in Las Vegas -- http://devcon.sprintpcs.com/adp/index.cfm ___ Jboss-development mailing list [EMAIL PROTECTED] https://lists.sourceforge.net/lists/listinfo/jboss-development
Re: Re[2]: [JBoss-dev] Deployers lifecycle/logging question
On 2002.05.24 10:02:08 -0400 Alex Loubyansky wrote: Hello David, Friday, May 24, 2002, 4:20:33 PM, you wrote: DJ From your description below I think FoeDeployer depends on DJ WebLogicConverter. If you explicitly state this dependency with a depends DJ tag the deployment system will create WLC before FD and start WLC before DJ FD. If FD is designed to accept lots of converters you can use a DJ depends-list element. No. WebLogicConvertor depends on FoeDeployer. And it's expressed with a depends element. In the architecture as it is exists for now I think it's the right choice. Because WLC has a deployer's name and in startService() it's added to it's deployer (FD) which contains the list of convertors. OK, this means FoeDeployer is started before WLC, guaranteed. If you want this design then you will have to make foedeployer keep a list of undeployables and check any time a new converter is registered. As I indicated in another message I think you should eliminate foedeployer and just have converters. DJ How does FD know about WLC now? I'd recommend using an ObjectName and DJ calling through the mbean server. Actually, already answered. It's done this way. DJ If you want to allow dynamically adding converters you will have to make FD DJ keep a list of undeployables that it tries to deploy whenever a new DJ converter is registered. I don't think I recommend this. Do you have other remarks? Please, let me know. I am becoming crazy of it but feel have to learn more :) alex ___ Don't miss the 2002 Sprint PCS Application Developer's Conference August 25-28 in Las Vegas -- http://devcon.sprintpcs.com/adp/index.cfm ___ Jboss-development mailing list [EMAIL PROTECTED] https://lists.sourceforge.net/lists/listinfo/jboss-development
Re: Re[2]: [JBoss-dev] Deployers lifecycle/logging question
Hi David The FoeDeployer should register with MainDeployer as the last thing it does in startService(), when it is in fact usable. So at least you should move super.startService() to the end. Done. I just looked at the code and think that a simpler design would be to simply have the WLC be a SubDeployer. You can make a common superclass with utility methods all the foe deployers will need. Maybe that is the way to go. I think before we make that decision we have to decide on how the Convetor is chosen to deploy/convert because I don't like the idea of the .wlar extension. This was just a wor-around to go on now. Otherwise you will have to either give foedeployer a list of all the converters it will get, which is kind of silly, or implement another layer of waiting behavior in FoeDeployer, which is even sillier. As far as I can tell from a quick glance, FoeDeployer doesn't do anything that couldn't be done at least as well in a superclass of WLC. Agreed. Also I thought some of the file manipulation methods were already in SubDeployerSupport?? I havne't looked at it for a while though. I didn't found any. Andy ___ Don't miss the 2002 Sprint PCS Application Developer's Conference August 25-28 in Las Vegas -- http://devcon.sprintpcs.com/adp/index.cfm ___ Jboss-development mailing list [EMAIL PROTECTED] https://lists.sourceforge.net/lists/listinfo/jboss-development