[Differential] [Commented On] D3091: Windows: Don't display error dialogs

[kfunk (Kevin Funk)]

kfunk added a comment.


  In https://phabricator.kde.org/D3091#57279, @nalvarez wrote:
  
  > Meanwhile I'm skeptical of the need to "set it back". Is there any case 
where such error dialog boxes would be desirable? It seems like their existence 
is an ancient-app-compatibility thing. The documentation for `SetErrorMode` 
recommends setting `SEM_FAILCRITICALERRORS` at app startup and leaving it that 
way.
  
  
  I'm using a similar approach as Qt does. If some application decides to use a 
different "global" error mode, we should not interfere with it just because 
Solid wants to. This is a general purpose library after all.

REVISION DETAIL
  https://phabricator.kde.org/D3091

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: kfunk, #frameworks, brauch
Cc: nalvarez, broulik

[Differential] [Commented On] D3091: Windows: Don't display error dialogs

[kfunk (Kevin Funk)]

kfunk added a comment.


  In https://phabricator.kde.org/D3091#57277, @broulik wrote:
  
  > Can't really comment on this, though.
  
  
  
  
  > While I'm a huge fan of RAII you don't seem to be returning early from that 
function
  
  RAII is not only useful for cases where you return early.
  
  > ..., can't you just set the value and set it back at the end without this 
new class?
  
  I'm fairly sure, we'll need to guard other WinAPI calls as well. QStorageInfo 
from qtbase uses `SetErrorMode/GetErrorMode` a lot

REVISION DETAIL
  https://phabricator.kde.org/D3091

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: kfunk, #frameworks, brauch
Cc: nalvarez, broulik

[Differential] [Updated, 70 lines] D3091: Windows: Don't display error dialogs

[kfunk (Kevin Funk)]

kfunk updated this revision to Diff 7476.
kfunk added a comment.


  SetErrorMode -> SetThreadErrorMode (thread-safe)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D3091?vs=7475=7476

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D3091

AFFECTED FILES
  src/solid/devices/backends/win/winstoragevolume.cpp
  src/solid/devices/backends/win/winutils_p.h

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: kfunk, #frameworks, brauch
Cc: nalvarez, broulik

[Differential] [Updated] D3091: Windows: Don't display error dialogs

[brauch (Sven Brauch)]

brauch added a comment.


  The other interesting question is why we even query for free disk space on 
all drives, but I guess this patch still makes sense in any case.

REVISION DETAIL
  https://phabricator.kde.org/D3091

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: kfunk, #frameworks, brauch
Cc: nalvarez, broulik

[Differential] [Commented On] D3091: Windows: Don't display error dialogs

[Nicolás Alvarez]

nalvarez added a comment.


  Meanwhile I'm skeptical of the need to "set it back". Is there any case where 
such error dialog boxes would be desirable? It seems like their existence is an 
ancient-app-compatibility thing. The documentation for `SetErrorMode` 
recommends setting `SEM_FAILCRITICALERRORS` at app startup and leaving it that 
way.

REVISION DETAIL
  https://phabricator.kde.org/D3091

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: kfunk, #frameworks, brauch
Cc: nalvarez, broulik

[Differential] [Commented On] D3091: Windows: Don't display error dialogs

[broulik (Kai Uwe Broulik)]

broulik added a comment.


  Can't really comment on this, though.
  While I'm a huge fan of RAII you don't seem to be returning early from that 
function, can't you just set the value and set it back at the end without this 
new class?

REVISION DETAIL
  https://phabricator.kde.org/D3091

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: kfunk, #frameworks, brauch
Cc: broulik

[Differential] [Updated] D3091: Windows: Don't display error dialogs

[kfunk (Kevin Funk)]

kfunk added reviewers: Frameworks, brauch.

REVISION DETAIL
  https://phabricator.kde.org/D3091

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: kfunk, #frameworks, brauch

Jenkins-kde-ci: plasma-framework master kf5-qt5 » Linux,NoX11,gcc - Build # 226 - Failure!

[no-reply]

GENERAL INFO

BUILD FAILURE
Build URL: 
https://build.kde.org/job/plasma-framework%20master%20kf5-qt5/PLATFORM=Linux,Variation=NoX11,compiler=gcc/226/
Project: PLATFORM=Linux,Variation=NoX11,compiler=gcc
Date of build: Mon, 17 Oct 2016 16:18:31 +
Build duration: 4 min 14 sec

CHANGE SET
Revision acd7ab7815a2a1f9a65f1dbf2cb53123c86da58b by Marco Martin: (port all 
output to QCDebug/QCWarning)
  change: edit src/declarativeimports/plasmacomponents/fullscreenwindow.cpp
  change: edit src/plasmapkg/plasmapkg.cpp
  change: edit src/plasmaquick/dialogshadows.cpp
  change: edit src/declarativeimports/core/iconitem.cpp
  change: edit autotests/sortfiltermodeltest.cpp
  change: edit src/declarativeimports/plasmacomponents/CMakeLists.txt
  change: edit autotests/CMakeLists.txt
  change: edit src/plasmaquick/containmentview.cpp
  change: edit src/scriptengines/qml/CMakeLists.txt
  change: edit src/scriptengines/qml/plasmoid/wallpaperinterface.cpp
  change: edit src/declarativeimports/core/datamodel.cpp
  change: edit src/declarativeimports/platformcomponents/CMakeLists.txt
  change: edit src/declarativeimports/platformcomponents/application.cpp
  change: edit src/declarativeimports/core/framesvgitem.cpp
  change: edit src/declarativeimports/calendar/eventpluginsmanager.cpp
  change: edit src/plasmaquick/configview.cpp
  change: edit src/plasmaquick/dialog.cpp
  change: edit src/declarativeimports/core/datasource.cpp
  change: edit src/declarativeimports/plasmacomponents/qmenu.cpp
  change: edit src/plasmaquick/view.cpp
  change: edit src/plasmaquick/CMakeLists.txt
  change: edit src/scriptengines/qml/plasmoid/containmentinterface.cpp
  change: edit src/declarativeimports/core/CMakeLists.txt
  change: edit src/plasmaquick/configmodel.cpp
  change: edit src/declarativeimports/calendar/CMakeLists.txt
  change: edit src/plasmaquick/packageurlinterceptor.cpp
  change: edit src/plasmapkg/CMakeLists.txt
  change: edit 
src/declarativeimports/plasmacomponents/plasmacomponentsplugin.cpp
  change: edit src/declarativeimports/calendar/calendar.cpp
  change: edit src/declarativeimports/core/windowthumbnail.cpp

Jenkins-kde-ci: plasma-framework master kf5-qt5 » Linux,All,gcc - Build # 226 - Failure!

[no-reply]

GENERAL INFO

BUILD FAILURE
Build URL: 
https://build.kde.org/job/plasma-framework%20master%20kf5-qt5/PLATFORM=Linux,Variation=All,compiler=gcc/226/
Project: PLATFORM=Linux,Variation=All,compiler=gcc
Date of build: Mon, 17 Oct 2016 16:18:31 +
Build duration: 1 min 53 sec

CHANGE SET
Revision acd7ab7815a2a1f9a65f1dbf2cb53123c86da58b by Marco Martin: (port all 
output to QCDebug/QCWarning)
  change: edit src/declarativeimports/calendar/eventpluginsmanager.cpp
  change: edit src/declarativeimports/calendar/CMakeLists.txt
  change: edit src/plasmaquick/packageurlinterceptor.cpp
  change: edit src/declarativeimports/platformcomponents/CMakeLists.txt
  change: edit src/plasmaquick/view.cpp
  change: edit src/declarativeimports/plasmacomponents/CMakeLists.txt
  change: edit src/declarativeimports/core/framesvgitem.cpp
  change: edit src/scriptengines/qml/CMakeLists.txt
  change: edit src/plasmaquick/containmentview.cpp
  change: edit src/declarativeimports/calendar/calendar.cpp
  change: edit autotests/sortfiltermodeltest.cpp
  change: edit src/declarativeimports/plasmacomponents/qmenu.cpp
  change: edit src/plasmaquick/configview.cpp
  change: edit src/plasmapkg/CMakeLists.txt
  change: edit src/declarativeimports/core/datamodel.cpp
  change: edit autotests/CMakeLists.txt
  change: edit src/plasmaquick/CMakeLists.txt
  change: edit src/declarativeimports/core/CMakeLists.txt
  change: edit src/declarativeimports/core/iconitem.cpp
  change: edit src/declarativeimports/core/datasource.cpp
  change: edit src/plasmaquick/dialog.cpp
  change: edit src/scriptengines/qml/plasmoid/wallpaperinterface.cpp
  change: edit src/plasmapkg/plasmapkg.cpp
  change: edit src/plasmaquick/configmodel.cpp
  change: edit src/plasmaquick/dialogshadows.cpp
  change: edit 
src/declarativeimports/plasmacomponents/plasmacomponentsplugin.cpp
  change: edit src/scriptengines/qml/plasmoid/containmentinterface.cpp
  change: edit src/declarativeimports/core/windowthumbnail.cpp
  change: edit src/declarativeimports/plasmacomponents/fullscreenwindow.cpp
  change: edit src/declarativeimports/platformcomponents/application.cpp

Jenkins-kde-ci: plasma-framework master stable-kf5-qt5 » Linux,NoX11,gcc - Build # 226 - Failure!

[no-reply]

GENERAL INFO

BUILD FAILURE
Build URL: 
https://build.kde.org/job/plasma-framework%20master%20stable-kf5-qt5/PLATFORM=Linux,Variation=NoX11,compiler=gcc/226/
Project: PLATFORM=Linux,Variation=NoX11,compiler=gcc
Date of build: Mon, 17 Oct 2016 16:18:31 +
Build duration: 1 min 44 sec

CHANGE SET
Revision acd7ab7815a2a1f9a65f1dbf2cb53123c86da58b by Marco Martin: (port all 
output to QCDebug/QCWarning)
  change: edit src/declarativeimports/plasmacomponents/qmenu.cpp
  change: edit src/declarativeimports/calendar/eventpluginsmanager.cpp
  change: edit src/scriptengines/qml/plasmoid/containmentinterface.cpp
  change: edit src/plasmaquick/CMakeLists.txt
  change: edit src/plasmaquick/configmodel.cpp
  change: edit src/plasmaquick/packageurlinterceptor.cpp
  change: edit src/declarativeimports/plasmacomponents/CMakeLists.txt
  change: edit src/declarativeimports/calendar/CMakeLists.txt
  change: edit autotests/CMakeLists.txt
  change: edit autotests/sortfiltermodeltest.cpp
  change: edit src/declarativeimports/platformcomponents/application.cpp
  change: edit src/declarativeimports/platformcomponents/CMakeLists.txt
  change: edit src/declarativeimports/core/windowthumbnail.cpp
  change: edit src/declarativeimports/core/CMakeLists.txt
  change: edit src/plasmaquick/containmentview.cpp
  change: edit src/scriptengines/qml/CMakeLists.txt
  change: edit src/scriptengines/qml/plasmoid/wallpaperinterface.cpp
  change: edit src/plasmaquick/dialogshadows.cpp
  change: edit 
src/declarativeimports/plasmacomponents/plasmacomponentsplugin.cpp
  change: edit src/declarativeimports/core/iconitem.cpp
  change: edit src/plasmaquick/dialog.cpp
  change: edit src/plasmaquick/configview.cpp
  change: edit src/declarativeimports/core/framesvgitem.cpp
  change: edit src/declarativeimports/plasmacomponents/fullscreenwindow.cpp
  change: edit src/plasmaquick/view.cpp
  change: edit src/plasmapkg/CMakeLists.txt
  change: edit src/declarativeimports/core/datasource.cpp
  change: edit src/plasmapkg/plasmapkg.cpp
  change: edit src/declarativeimports/calendar/calendar.cpp
  change: edit src/declarativeimports/core/datamodel.cpp

Jenkins-kde-ci: plasma-framework master stable-kf5-qt5 » Linux,All,gcc - Build # 226 - Failure!

[no-reply]

GENERAL INFO

BUILD FAILURE
Build URL: 
https://build.kde.org/job/plasma-framework%20master%20stable-kf5-qt5/PLATFORM=Linux,Variation=All,compiler=gcc/226/
Project: PLATFORM=Linux,Variation=All,compiler=gcc
Date of build: Mon, 17 Oct 2016 16:18:31 +
Build duration: 1 min 42 sec

CHANGE SET
Revision acd7ab7815a2a1f9a65f1dbf2cb53123c86da58b by Marco Martin: (port all 
output to QCDebug/QCWarning)
  change: edit src/plasmaquick/dialogshadows.cpp
  change: edit src/declarativeimports/plasmacomponents/fullscreenwindow.cpp
  change: edit src/declarativeimports/core/CMakeLists.txt
  change: edit autotests/sortfiltermodeltest.cpp
  change: edit src/declarativeimports/core/windowthumbnail.cpp
  change: edit src/declarativeimports/core/datamodel.cpp
  change: edit src/plasmaquick/CMakeLists.txt
  change: edit src/plasmaquick/packageurlinterceptor.cpp
  change: edit src/plasmaquick/dialog.cpp
  change: edit src/plasmapkg/plasmapkg.cpp
  change: edit src/declarativeimports/plasmacomponents/CMakeLists.txt
  change: edit src/declarativeimports/core/framesvgitem.cpp
  change: edit src/declarativeimports/calendar/calendar.cpp
  change: edit src/plasmapkg/CMakeLists.txt
  change: edit src/scriptengines/qml/plasmoid/containmentinterface.cpp
  change: edit src/plasmaquick/configmodel.cpp
  change: edit src/declarativeimports/plasmacomponents/qmenu.cpp
  change: edit src/scriptengines/qml/plasmoid/wallpaperinterface.cpp
  change: edit src/plasmaquick/configview.cpp
  change: edit src/plasmaquick/view.cpp
  change: edit 
src/declarativeimports/plasmacomponents/plasmacomponentsplugin.cpp
  change: edit src/scriptengines/qml/CMakeLists.txt
  change: edit src/plasmaquick/containmentview.cpp
  change: edit autotests/CMakeLists.txt
  change: edit src/declarativeimports/calendar/CMakeLists.txt
  change: edit src/declarativeimports/platformcomponents/application.cpp
  change: edit src/declarativeimports/core/datasource.cpp
  change: edit src/declarativeimports/platformcomponents/CMakeLists.txt
  change: edit src/declarativeimports/calendar/eventpluginsmanager.cpp
  change: edit src/declarativeimports/core/iconitem.cpp

Re: Review Request 129210: port everything to QCDebug/QCWarning

[Marco Martin]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129210/
---

(Updated Oct. 17, 2016, 6:18 p.m.)


Status
--

This change has been marked as submitted.


Review request for KDE Frameworks and Plasma.


Changes
---

Submitted with commit acd7ab7815a2a1f9a65f1dbf2cb53123c86da58b by Marco Martin 
to branch master.


Repository: plasma-framework


Description
---

mostly janitorial patch: port every terminal output to appropriate 
QCdebug/QCwarning, each different binary has its own logging category now, so 
it's possible to enable/disable them selectively.
this should also make plasmashell a bit more quiet on terminal by default


Diffs
-

  autotests/CMakeLists.txt d6ed24d 
  autotests/sortfiltermodeltest.cpp da0e393 
  src/declarativeimports/calendar/CMakeLists.txt 93d9c14 
  src/declarativeimports/calendar/calendar.cpp 790833b 
  src/declarativeimports/calendar/eventpluginsmanager.cpp bcc6177 
  src/declarativeimports/core/CMakeLists.txt 689a4b6 
  src/declarativeimports/core/datamodel.cpp 06b64e4 
  src/declarativeimports/core/datasource.cpp f60e2cc 
  src/declarativeimports/core/framesvgitem.cpp bc8d45a6 
  src/declarativeimports/core/iconitem.cpp 8f29ee2 
  src/declarativeimports/core/windowthumbnail.cpp 0453c09 
  src/declarativeimports/plasmacomponents/CMakeLists.txt 8e5ca90 
  src/declarativeimports/plasmacomponents/fullscreenwindow.cpp 05da708 
  src/declarativeimports/plasmacomponents/plasmacomponentsplugin.cpp 83016c2 
  src/declarativeimports/plasmacomponents/qmenu.cpp c6b59a8 
  src/declarativeimports/platformcomponents/CMakeLists.txt 4cce385 
  src/declarativeimports/platformcomponents/application.cpp 1326a7b 
  src/plasmapkg/CMakeLists.txt 7d3df5d 
  src/plasmapkg/plasmapkg.cpp 3724ae8 
  src/plasmaquick/CMakeLists.txt 8aaa77a 
  src/plasmaquick/configmodel.cpp 03beac7 
  src/plasmaquick/configview.cpp e8627c9 
  src/plasmaquick/containmentview.cpp 309a2cb 
  src/plasmaquick/dialog.cpp 9afdf60 
  src/plasmaquick/dialogshadows.cpp 10b5ed9 
  src/plasmaquick/packageurlinterceptor.cpp 4aa5c3a 
  src/plasmaquick/view.cpp ca6ae6f 
  src/scriptengines/qml/CMakeLists.txt fd953d6 
  src/scriptengines/qml/plasmoid/containmentinterface.cpp d0dbda9 
  src/scriptengines/qml/plasmoid/wallpaperinterface.cpp 9ef2d03 

Diff: https://git.reviewboard.kde.org/r/129210/diff/


Testing
---

builds, still works


Thanks,

Marco Martin

Re: Review Request 129210: port everything to QCDebug/QCWarning

[Marco Martin]

> On Oct. 17, 2016, 4:07 p.m., David Edmundson wrote:
> > Though in future, I wouldn't bother putting a logging category on an 
> > autotest.

that was done because the aytotest statically links to a model from imports, so 
it needs it in order to still link correctly


- Marco


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129210/#review100103
---


On Oct. 17, 2016, 3:28 p.m., Marco Martin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129210/
> ---
> 
> (Updated Oct. 17, 2016, 3:28 p.m.)
> 
> 
> Review request for KDE Frameworks and Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> mostly janitorial patch: port every terminal output to appropriate 
> QCdebug/QCwarning, each different binary has its own logging category now, so 
> it's possible to enable/disable them selectively.
> this should also make plasmashell a bit more quiet on terminal by default
> 
> 
> Diffs
> -
> 
>   autotests/CMakeLists.txt d6ed24d 
>   autotests/sortfiltermodeltest.cpp da0e393 
>   src/declarativeimports/calendar/CMakeLists.txt 93d9c14 
>   src/declarativeimports/calendar/calendar.cpp 790833b 
>   src/declarativeimports/calendar/eventpluginsmanager.cpp bcc6177 
>   src/declarativeimports/core/CMakeLists.txt 689a4b6 
>   src/declarativeimports/core/datamodel.cpp 06b64e4 
>   src/declarativeimports/core/datasource.cpp f60e2cc 
>   src/declarativeimports/core/framesvgitem.cpp bc8d45a6 
>   src/declarativeimports/core/iconitem.cpp 8f29ee2 
>   src/declarativeimports/core/windowthumbnail.cpp 0453c09 
>   src/declarativeimports/plasmacomponents/CMakeLists.txt 8e5ca90 
>   src/declarativeimports/plasmacomponents/fullscreenwindow.cpp 05da708 
>   src/declarativeimports/plasmacomponents/plasmacomponentsplugin.cpp 83016c2 
>   src/declarativeimports/plasmacomponents/qmenu.cpp c6b59a8 
>   src/declarativeimports/platformcomponents/CMakeLists.txt 4cce385 
>   src/declarativeimports/platformcomponents/application.cpp 1326a7b 
>   src/plasmapkg/CMakeLists.txt 7d3df5d 
>   src/plasmapkg/plasmapkg.cpp 3724ae8 
>   src/plasmaquick/CMakeLists.txt 8aaa77a 
>   src/plasmaquick/configmodel.cpp 03beac7 
>   src/plasmaquick/configview.cpp e8627c9 
>   src/plasmaquick/containmentview.cpp 309a2cb 
>   src/plasmaquick/dialog.cpp 9afdf60 
>   src/plasmaquick/dialogshadows.cpp 10b5ed9 
>   src/plasmaquick/packageurlinterceptor.cpp 4aa5c3a 
>   src/plasmaquick/view.cpp ca6ae6f 
>   src/scriptengines/qml/CMakeLists.txt fd953d6 
>   src/scriptengines/qml/plasmoid/containmentinterface.cpp d0dbda9 
>   src/scriptengines/qml/plasmoid/wallpaperinterface.cpp 9ef2d03 
> 
> Diff: https://git.reviewboard.kde.org/r/129210/diff/
> 
> 
> Testing
> ---
> 
> builds, still works
> 
> 
> Thanks,
> 
> Marco Martin
> 
>

Re: Review Request 129210: port everything to QCDebug/QCWarning

[David Edmundson]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129210/#review100103
---


Ship it!




Though in future, I wouldn't bother putting a logging category on an autotest.

- David Edmundson


On Oct. 17, 2016, 3:28 p.m., Marco Martin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129210/
> ---
> 
> (Updated Oct. 17, 2016, 3:28 p.m.)
> 
> 
> Review request for KDE Frameworks and Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> mostly janitorial patch: port every terminal output to appropriate 
> QCdebug/QCwarning, each different binary has its own logging category now, so 
> it's possible to enable/disable them selectively.
> this should also make plasmashell a bit more quiet on terminal by default
> 
> 
> Diffs
> -
> 
>   autotests/CMakeLists.txt d6ed24d 
>   autotests/sortfiltermodeltest.cpp da0e393 
>   src/declarativeimports/calendar/CMakeLists.txt 93d9c14 
>   src/declarativeimports/calendar/calendar.cpp 790833b 
>   src/declarativeimports/calendar/eventpluginsmanager.cpp bcc6177 
>   src/declarativeimports/core/CMakeLists.txt 689a4b6 
>   src/declarativeimports/core/datamodel.cpp 06b64e4 
>   src/declarativeimports/core/datasource.cpp f60e2cc 
>   src/declarativeimports/core/framesvgitem.cpp bc8d45a6 
>   src/declarativeimports/core/iconitem.cpp 8f29ee2 
>   src/declarativeimports/core/windowthumbnail.cpp 0453c09 
>   src/declarativeimports/plasmacomponents/CMakeLists.txt 8e5ca90 
>   src/declarativeimports/plasmacomponents/fullscreenwindow.cpp 05da708 
>   src/declarativeimports/plasmacomponents/plasmacomponentsplugin.cpp 83016c2 
>   src/declarativeimports/plasmacomponents/qmenu.cpp c6b59a8 
>   src/declarativeimports/platformcomponents/CMakeLists.txt 4cce385 
>   src/declarativeimports/platformcomponents/application.cpp 1326a7b 
>   src/plasmapkg/CMakeLists.txt 7d3df5d 
>   src/plasmapkg/plasmapkg.cpp 3724ae8 
>   src/plasmaquick/CMakeLists.txt 8aaa77a 
>   src/plasmaquick/configmodel.cpp 03beac7 
>   src/plasmaquick/configview.cpp e8627c9 
>   src/plasmaquick/containmentview.cpp 309a2cb 
>   src/plasmaquick/dialog.cpp 9afdf60 
>   src/plasmaquick/dialogshadows.cpp 10b5ed9 
>   src/plasmaquick/packageurlinterceptor.cpp 4aa5c3a 
>   src/plasmaquick/view.cpp ca6ae6f 
>   src/scriptengines/qml/CMakeLists.txt fd953d6 
>   src/scriptengines/qml/plasmoid/containmentinterface.cpp d0dbda9 
>   src/scriptengines/qml/plasmoid/wallpaperinterface.cpp 9ef2d03 
> 
> Diff: https://git.reviewboard.kde.org/r/129210/diff/
> 
> 
> Testing
> ---
> 
> builds, still works
> 
> 
> Thanks,
> 
> Marco Martin
> 
>

Re: Review Request 129209: Rename subdir kcontrol to kcontrol5

[Luigi Toscano]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129209/#review100102
---



Fine by me. As discussed on IRC, we need to keep track of the required changes 
when this lands.

- Luigi Toscano


On Oct. 17, 2016, 4:31 p.m., Burkhard Lück wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129209/
> ---
> 
> (Updated Oct. 17, 2016, 4:31 p.m.)
> 
> 
> Review request for Documentation and KDE Frameworks.
> 
> 
> Repository: kdelibs4support
> 
> 
> Description
> ---
> 
> in distributions the doc packages for kdelibs4support and kde-runtime are 
> usually designed to be co-installable, 
> but this fails in some distributions due to conflicting file paths, therefore:
>  
> * subdir kcontrol is renamed to kcontrol5
> * install target for kcm_ssl docbook changed to kcontrol5
> * X-DocPath changed to kcontrol5/kcm_ssl/index.html
> 
> 
> Diffs
> -
> 
>   docs/CMakeLists.txt f90fa81 
>   docs/kcontrol/CMakeLists.txt  
>   docs/kcontrol/kcm_ssl/CMakeLists.txt  
>   docs/kcontrol/kcm_ssl/details.png  
>   docs/kcontrol/kcm_ssl/index.docbook  
>   docs/kcontrol/kcm_ssl/module.png  
>   docs/kcontrol5/kcm_ssl/CMakeLists.txt 4d3bc75 
>   src/kssl/kcm/kcm_ssl.desktop 6ec8be6 
> 
> Diff: https://git.reviewboard.kde.org/r/129209/diff/
> 
> 
> Testing
> ---
> 
> builds and installs properly
> 
> 
> Thanks,
> 
> Burkhard Lück
> 
>

Re: Review Request 129065: Fix frameworks compilation with Qt < 5.6

[David Edmundson]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129065/
---

(Updated Oct. 17, 2016, 3:46 p.m.)


Status
--

This change has been marked as submitted.


Review request for KDE Frameworks and Plasma.


Changes
---

Submitted with commit f82d76eb2b915d5097f41a22a9f218e0bb23bb03 by David 
Edmundson on behalf of Alberto Curro to branch master.


Repository: plasma-framework


Description
---

QQuickWindow::NoStage was new in Qt5.6. This uses a value that's valid
in earlier Qt.

This shouldn't have any behavioural effect.


Diffs
-

  src/declarativeimports/core/windowthumbnail.cpp 
0453c092f7a7144f04fdacc81b031e8c352fa23b 

Diff: https://git.reviewboard.kde.org/r/129065/diff/


Testing
---

Ran on my nvidia machine and moused over the taskbar.

I got thumbnails as expected, but also Nvidia-settings shows "user dedicated 
memory" remaining constant


Thanks,

David Edmundson

Re: Review Request 129104: Remove unused member var

[David Edmundson]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129104/
---

(Updated Oct. 17, 2016, 3:45 p.m.)


Status
--

This change has been marked as submitted.


Review request for KDE Frameworks and Plasma.


Changes
---

Submitted with commit 07c978f6198feb2a4296f27951b74d1d79603816 by David 
Edmundson to branch master.


Repository: plasma-framework


Description
---

Remove unused member var


Diffs
-

  src/plasma/pluginloader.cpp db2b2c91d7b313053811583cf41bcdf0e1e141ce 

Diff: https://git.reviewboard.kde.org/r/129104/diff/


Testing
---

compiles.


Thanks,

David Edmundson

Review Request 129210: port everything to QCDebug/QCWarning

[Marco Martin]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129210/
---

Review request for KDE Frameworks and Plasma.


Repository: plasma-framework


Description
---

mostly janitorial patch: port every terminal output to appropriate 
QCdebug/QCwarning, each different binary has its own logging category now, so 
it's possible to enable/disable them selectively.
this should also make plasmashell a bit more quiet on terminal by default


Diffs
-

  autotests/CMakeLists.txt d6ed24d 
  autotests/sortfiltermodeltest.cpp da0e393 
  src/declarativeimports/calendar/CMakeLists.txt 93d9c14 
  src/declarativeimports/calendar/calendar.cpp 790833b 
  src/declarativeimports/calendar/eventpluginsmanager.cpp bcc6177 
  src/declarativeimports/core/CMakeLists.txt 689a4b6 
  src/declarativeimports/core/datamodel.cpp 06b64e4 
  src/declarativeimports/core/datasource.cpp f60e2cc 
  src/declarativeimports/core/framesvgitem.cpp bc8d45a6 
  src/declarativeimports/core/iconitem.cpp 8f29ee2 
  src/declarativeimports/core/windowthumbnail.cpp 0453c09 
  src/declarativeimports/plasmacomponents/CMakeLists.txt 8e5ca90 
  src/declarativeimports/plasmacomponents/fullscreenwindow.cpp 05da708 
  src/declarativeimports/plasmacomponents/plasmacomponentsplugin.cpp 83016c2 
  src/declarativeimports/plasmacomponents/qmenu.cpp c6b59a8 
  src/declarativeimports/platformcomponents/CMakeLists.txt 4cce385 
  src/declarativeimports/platformcomponents/application.cpp 1326a7b 
  src/plasmapkg/CMakeLists.txt 7d3df5d 
  src/plasmapkg/plasmapkg.cpp 3724ae8 
  src/plasmaquick/CMakeLists.txt 8aaa77a 
  src/plasmaquick/configmodel.cpp 03beac7 
  src/plasmaquick/configview.cpp e8627c9 
  src/plasmaquick/containmentview.cpp 309a2cb 
  src/plasmaquick/dialog.cpp 9afdf60 
  src/plasmaquick/dialogshadows.cpp 10b5ed9 
  src/plasmaquick/packageurlinterceptor.cpp 4aa5c3a 
  src/plasmaquick/view.cpp ca6ae6f 
  src/scriptengines/qml/CMakeLists.txt fd953d6 
  src/scriptengines/qml/plasmoid/containmentinterface.cpp d0dbda9 
  src/scriptengines/qml/plasmoid/wallpaperinterface.cpp 9ef2d03 

Diff: https://git.reviewboard.kde.org/r/129210/diff/


Testing
---

builds, still works


Thanks,

Marco Martin

Review Request 129209: Rename subdir kcontrol to kcontrol5

[Burkhard Lück]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129209/
---

Review request for Documentation and KDE Frameworks.


Repository: kdelibs4support


Description
---

in distributions the doc packages for kdelibs4support and kde-runtime are 
usually designed to be co-installable, 
but this fails in some distributions due to conflicting file paths, therefore:
 
* subdir kcontrol is renamed to kcontrol5
* install target for kcm_ssl docbook changed to kcontrol5
* X-DocPath changed to kcontrol5/kcm_ssl/index.html


Diffs
-

  docs/CMakeLists.txt f90fa81 
  docs/kcontrol/CMakeLists.txt  
  docs/kcontrol/kcm_ssl/CMakeLists.txt  
  docs/kcontrol/kcm_ssl/details.png  
  docs/kcontrol/kcm_ssl/index.docbook  
  docs/kcontrol/kcm_ssl/module.png  
  docs/kcontrol5/kcm_ssl/CMakeLists.txt 4d3bc75 
  src/kssl/kcm/kcm_ssl.desktop 6ec8be6 

Diff: https://git.reviewboard.kde.org/r/129209/diff/


Testing
---

builds and installs properly


Thanks,

Burkhard Lück

Jenkins-kde-ci: plasma-framework master kf5-qt5 » Linux,All,gcc - Build # 223 - Fixed!

[no-reply]

GENERAL INFO

BUILD SUCCESS
Build URL: 
https://build.kde.org/job/plasma-framework%20master%20kf5-qt5/PLATFORM=Linux,Variation=All,compiler=gcc/223/
Project: PLATFORM=Linux,Variation=All,compiler=gcc
Date of build: Mon, 17 Oct 2016 12:58:49 +
Build duration: 9 min 14 sec

CHANGE SET
Revision 2b68e076587b3e326abc453db8de95e78db8c1e5 by Marco Martin: (make it 
actually build without kwayland)
  change: edit src/plasmaquick/dialogshadows.cpp
  change: edit src/plasmaquick/dialog.cpp


JUNIT RESULTS

Name: (root) Failed: 0 test(s), Passed: 16 test(s), Skipped: 0 test(s), Total: 
16 test(s)

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 9/9 (100%)FILES 81/119 (68%)CLASSES 81/119 (68%)LINE 4935/11736 
(42%)CONDITIONAL 2658/8858 (30%)

By packages
  
autotests
FILES 28/28 (100%)CLASSES 28/28 (100%)LINE 1004/1050 
(96%)CONDITIONAL 633/1238 (51%)
src.declarativeimports.core
FILES 10/18 (56%)CLASSES 10/18 (56%)LINE 648/2128 
(30%)CONDITIONAL 300/1308 (23%)
src.plasma
FILES 14/20 (70%)CLASSES 14/20 (70%)LINE 1660/3606 
(46%)CONDITIONAL 961/2705 (36%)
src.plasma.packagestructure
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 54/66 (82%)CONDITIONAL 
7/22 (32%)
src.plasma.private
FILES 14/24 (58%)CLASSES 14/24 (58%)LINE 927/1639 
(57%)CONDITIONAL 431/1068 (40%)
src.plasma.scripting
FILES 2/3 (67%)CLASSES 2/3 (67%)LINE 36/180 (20%)CONDITIONAL 
14/106 (13%)
src.plasmaquick
FILES 6/12 (50%)CLASSES 6/12 (50%)LINE 564/1818 
(31%)CONDITIONAL 305/1415 (22%)
src.plasmaquick.private
FILES 1/3 (33%)CLASSES 1/3 (33%)LINE 31/113 (27%)CONDITIONAL 
6/22 (27%)
src.scriptengines.qml.plasmoid
FILES 2/7 (29%)CLASSES 2/7 (29%)LINE 11/1136 (1%)CONDITIONAL 
1/974 (0%)

Jenkins-kde-ci: plasma-framework master kf5-qt5 » Linux,All,gcc - Build # 223 - Fixed!

[no-reply]

GENERAL INFO

BUILD SUCCESS
Build URL: 
https://build.kde.org/job/plasma-framework%20master%20kf5-qt5/PLATFORM=Linux,Variation=All,compiler=gcc/223/
Project: PLATFORM=Linux,Variation=All,compiler=gcc
Date of build: Mon, 17 Oct 2016 12:58:49 +
Build duration: 9 min 14 sec

CHANGE SET
Revision 2b68e076587b3e326abc453db8de95e78db8c1e5 by Marco Martin: (make it 
actually build without kwayland)
  change: edit src/plasmaquick/dialogshadows.cpp
  change: edit src/plasmaquick/dialog.cpp


JUNIT RESULTS

Name: (root) Failed: 0 test(s), Passed: 16 test(s), Skipped: 0 test(s), Total: 
16 test(s)

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 9/9 (100%)FILES 81/119 (68%)CLASSES 81/119 (68%)LINE 4935/11736 
(42%)CONDITIONAL 2658/8858 (30%)

By packages
  
autotests
FILES 28/28 (100%)CLASSES 28/28 (100%)LINE 1004/1050 
(96%)CONDITIONAL 633/1238 (51%)
src.declarativeimports.core
FILES 10/18 (56%)CLASSES 10/18 (56%)LINE 648/2128 
(30%)CONDITIONAL 300/1308 (23%)
src.plasma
FILES 14/20 (70%)CLASSES 14/20 (70%)LINE 1660/3606 
(46%)CONDITIONAL 961/2705 (36%)
src.plasma.packagestructure
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 54/66 (82%)CONDITIONAL 
7/22 (32%)
src.plasma.private
FILES 14/24 (58%)CLASSES 14/24 (58%)LINE 927/1639 
(57%)CONDITIONAL 431/1068 (40%)
src.plasma.scripting
FILES 2/3 (67%)CLASSES 2/3 (67%)LINE 36/180 (20%)CONDITIONAL 
14/106 (13%)
src.plasmaquick
FILES 6/12 (50%)CLASSES 6/12 (50%)LINE 564/1818 
(31%)CONDITIONAL 305/1415 (22%)
src.plasmaquick.private
FILES 1/3 (33%)CLASSES 1/3 (33%)LINE 31/113 (27%)CONDITIONAL 
6/22 (27%)
src.scriptengines.qml.plasmoid
FILES 2/7 (29%)CLASSES 2/7 (29%)LINE 11/1136 (1%)CONDITIONAL 
1/974 (0%)

Jenkins-kde-ci: plasma-framework master kf5-qt5 » Linux,NoX11,gcc - Build # 223 - Fixed!

[no-reply]

GENERAL INFO

BUILD SUCCESS
Build URL: 
https://build.kde.org/job/plasma-framework%20master%20kf5-qt5/PLATFORM=Linux,Variation=NoX11,compiler=gcc/223/
Project: PLATFORM=Linux,Variation=NoX11,compiler=gcc
Date of build: Mon, 17 Oct 2016 12:58:49 +
Build duration: 8 min 11 sec

CHANGE SET
Revision 2b68e076587b3e326abc453db8de95e78db8c1e5 by Marco Martin: (make it 
actually build without kwayland)
  change: edit src/plasmaquick/dialog.cpp
  change: edit src/plasmaquick/dialogshadows.cpp


JUNIT RESULTS

Name: (root) Failed: 0 test(s), Passed: 15 test(s), Skipped: 0 test(s), Total: 
15 test(s)

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 9/9 (100%)FILES 78/115 (68%)CLASSES 78/115 (68%)LINE 4497/11219 
(40%)CONDITIONAL 2358/8454 (28%)

By packages
  
autotests
FILES 26/26 (100%)CLASSES 26/26 (100%)LINE 935/979 
(96%)CONDITIONAL 596/1162 (51%)
src.declarativeimports.core
FILES 10/18 (56%)CLASSES 10/18 (56%)LINE 561/1880 
(30%)CONDITIONAL 217/1152 (19%)
src.plasma
FILES 14/20 (70%)CLASSES 14/20 (70%)LINE 1658/3606 
(46%)CONDITIONAL 953/2705 (35%)
src.plasma.packagestructure
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 54/66 (82%)CONDITIONAL 
7/22 (32%)
src.plasma.private
FILES 13/22 (59%)CLASSES 13/22 (59%)LINE 877/1566 
(56%)CONDITIONAL 408/1022 (40%)
src.plasma.scripting
FILES 2/3 (67%)CLASSES 2/3 (67%)LINE 36/180 (20%)CONDITIONAL 
14/106 (13%)
src.plasmaquick
FILES 6/12 (50%)CLASSES 6/12 (50%)LINE 334/1693 
(20%)CONDITIONAL 156/1289 (12%)
src.plasmaquick.private
FILES 1/3 (33%)CLASSES 1/3 (33%)LINE 31/113 (27%)CONDITIONAL 
6/22 (27%)
src.scriptengines.qml.plasmoid
FILES 2/7 (29%)CLASSES 2/7 (29%)LINE 11/1136 (1%)CONDITIONAL 
1/974 (0%)

Jenkins-kde-ci: plasma-framework master kf5-qt5 » Linux,NoX11,gcc - Build # 223 - Fixed!

[no-reply]

GENERAL INFO

BUILD SUCCESS
Build URL: 
https://build.kde.org/job/plasma-framework%20master%20kf5-qt5/PLATFORM=Linux,Variation=NoX11,compiler=gcc/223/
Project: PLATFORM=Linux,Variation=NoX11,compiler=gcc
Date of build: Mon, 17 Oct 2016 12:58:49 +
Build duration: 8 min 11 sec

CHANGE SET
Revision 2b68e076587b3e326abc453db8de95e78db8c1e5 by Marco Martin: (make it 
actually build without kwayland)
  change: edit src/plasmaquick/dialog.cpp
  change: edit src/plasmaquick/dialogshadows.cpp


JUNIT RESULTS

Name: (root) Failed: 0 test(s), Passed: 15 test(s), Skipped: 0 test(s), Total: 
15 test(s)

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 9/9 (100%)FILES 78/115 (68%)CLASSES 78/115 (68%)LINE 4497/11219 
(40%)CONDITIONAL 2358/8454 (28%)

By packages
  
autotests
FILES 26/26 (100%)CLASSES 26/26 (100%)LINE 935/979 
(96%)CONDITIONAL 596/1162 (51%)
src.declarativeimports.core
FILES 10/18 (56%)CLASSES 10/18 (56%)LINE 561/1880 
(30%)CONDITIONAL 217/1152 (19%)
src.plasma
FILES 14/20 (70%)CLASSES 14/20 (70%)LINE 1658/3606 
(46%)CONDITIONAL 953/2705 (35%)
src.plasma.packagestructure
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 54/66 (82%)CONDITIONAL 
7/22 (32%)
src.plasma.private
FILES 13/22 (59%)CLASSES 13/22 (59%)LINE 877/1566 
(56%)CONDITIONAL 408/1022 (40%)
src.plasma.scripting
FILES 2/3 (67%)CLASSES 2/3 (67%)LINE 36/180 (20%)CONDITIONAL 
14/106 (13%)
src.plasmaquick
FILES 6/12 (50%)CLASSES 6/12 (50%)LINE 334/1693 
(20%)CONDITIONAL 156/1289 (12%)
src.plasmaquick.private
FILES 1/3 (33%)CLASSES 1/3 (33%)LINE 31/113 (27%)CONDITIONAL 
6/22 (27%)
src.scriptengines.qml.plasmoid
FILES 2/7 (29%)CLASSES 2/7 (29%)LINE 11/1136 (1%)CONDITIONAL 
1/974 (0%)

Jenkins-kde-ci: plasma-framework master stable-kf5-qt5 » Linux,All,gcc - Build # 223 - Fixed!

[no-reply]

GENERAL INFO

BUILD SUCCESS
Build URL: 
https://build.kde.org/job/plasma-framework%20master%20stable-kf5-qt5/PLATFORM=Linux,Variation=All,compiler=gcc/223/
Project: PLATFORM=Linux,Variation=All,compiler=gcc
Date of build: Mon, 17 Oct 2016 12:58:49 +
Build duration: 9 min 27 sec

CHANGE SET
Revision 2b68e076587b3e326abc453db8de95e78db8c1e5 by Marco Martin: (make it 
actually build without kwayland)
  change: edit src/plasmaquick/dialog.cpp
  change: edit src/plasmaquick/dialogshadows.cpp


JUNIT RESULTS

Name: (root) Failed: 0 test(s), Passed: 16 test(s), Skipped: 0 test(s), Total: 
16 test(s)

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 9/9 (100%)FILES 81/119 (68%)CLASSES 81/119 (68%)LINE 4936/11736 
(42%)CONDITIONAL 2659/8858 (30%)

By packages
  
autotests
FILES 28/28 (100%)CLASSES 28/28 (100%)LINE 1005/1050 
(96%)CONDITIONAL 634/1238 (51%)
src.declarativeimports.core
FILES 10/18 (56%)CLASSES 10/18 (56%)LINE 648/2128 
(30%)CONDITIONAL 300/1308 (23%)
src.plasma
FILES 14/20 (70%)CLASSES 14/20 (70%)LINE 1660/3606 
(46%)CONDITIONAL 961/2705 (36%)
src.plasma.packagestructure
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 54/66 (82%)CONDITIONAL 
7/22 (32%)
src.plasma.private
FILES 14/24 (58%)CLASSES 14/24 (58%)LINE 927/1639 
(57%)CONDITIONAL 431/1068 (40%)
src.plasma.scripting
FILES 2/3 (67%)CLASSES 2/3 (67%)LINE 36/180 (20%)CONDITIONAL 
14/106 (13%)
src.plasmaquick
FILES 6/12 (50%)CLASSES 6/12 (50%)LINE 564/1818 
(31%)CONDITIONAL 305/1415 (22%)
src.plasmaquick.private
FILES 1/3 (33%)CLASSES 1/3 (33%)LINE 31/113 (27%)CONDITIONAL 
6/22 (27%)
src.scriptengines.qml.plasmoid
FILES 2/7 (29%)CLASSES 2/7 (29%)LINE 11/1136 (1%)CONDITIONAL 
1/974 (0%)

Jenkins-kde-ci: plasma-framework master stable-kf5-qt5 » Linux,All,gcc - Build # 223 - Fixed!

[no-reply]

GENERAL INFO

BUILD SUCCESS
Build URL: 
https://build.kde.org/job/plasma-framework%20master%20stable-kf5-qt5/PLATFORM=Linux,Variation=All,compiler=gcc/223/
Project: PLATFORM=Linux,Variation=All,compiler=gcc
Date of build: Mon, 17 Oct 2016 12:58:49 +
Build duration: 9 min 27 sec

CHANGE SET
Revision 2b68e076587b3e326abc453db8de95e78db8c1e5 by Marco Martin: (make it 
actually build without kwayland)
  change: edit src/plasmaquick/dialog.cpp
  change: edit src/plasmaquick/dialogshadows.cpp


JUNIT RESULTS

Name: (root) Failed: 0 test(s), Passed: 16 test(s), Skipped: 0 test(s), Total: 
16 test(s)

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 9/9 (100%)FILES 81/119 (68%)CLASSES 81/119 (68%)LINE 4936/11736 
(42%)CONDITIONAL 2659/8858 (30%)

By packages
  
autotests
FILES 28/28 (100%)CLASSES 28/28 (100%)LINE 1005/1050 
(96%)CONDITIONAL 634/1238 (51%)
src.declarativeimports.core
FILES 10/18 (56%)CLASSES 10/18 (56%)LINE 648/2128 
(30%)CONDITIONAL 300/1308 (23%)
src.plasma
FILES 14/20 (70%)CLASSES 14/20 (70%)LINE 1660/3606 
(46%)CONDITIONAL 961/2705 (36%)
src.plasma.packagestructure
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 54/66 (82%)CONDITIONAL 
7/22 (32%)
src.plasma.private
FILES 14/24 (58%)CLASSES 14/24 (58%)LINE 927/1639 
(57%)CONDITIONAL 431/1068 (40%)
src.plasma.scripting
FILES 2/3 (67%)CLASSES 2/3 (67%)LINE 36/180 (20%)CONDITIONAL 
14/106 (13%)
src.plasmaquick
FILES 6/12 (50%)CLASSES 6/12 (50%)LINE 564/1818 
(31%)CONDITIONAL 305/1415 (22%)
src.plasmaquick.private
FILES 1/3 (33%)CLASSES 1/3 (33%)LINE 31/113 (27%)CONDITIONAL 
6/22 (27%)
src.scriptengines.qml.plasmoid
FILES 2/7 (29%)CLASSES 2/7 (29%)LINE 11/1136 (1%)CONDITIONAL 
1/974 (0%)

Jenkins-kde-ci: plasma-framework master stable-kf5-qt5 » Linux,NoX11,gcc - Build # 223 - Fixed!

[no-reply]

GENERAL INFO

BUILD SUCCESS
Build URL: 
https://build.kde.org/job/plasma-framework%20master%20stable-kf5-qt5/PLATFORM=Linux,Variation=NoX11,compiler=gcc/223/
Project: PLATFORM=Linux,Variation=NoX11,compiler=gcc
Date of build: Mon, 17 Oct 2016 12:58:49 +
Build duration: 2 min 22 sec

CHANGE SET
Revision 2b68e076587b3e326abc453db8de95e78db8c1e5 by Marco Martin: (make it 
actually build without kwayland)
  change: edit src/plasmaquick/dialog.cpp
  change: edit src/plasmaquick/dialogshadows.cpp


JUNIT RESULTS

Name: (root) Failed: 0 test(s), Passed: 15 test(s), Skipped: 0 test(s), Total: 
15 test(s)

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 9/9 (100%)FILES 78/115 (68%)CLASSES 78/115 (68%)LINE 4487/11219 
(40%)CONDITIONAL 2355/8454 (28%)

By packages
  
autotests
FILES 26/26 (100%)CLASSES 26/26 (100%)LINE 935/979 
(96%)CONDITIONAL 596/1162 (51%)
src.declarativeimports.core
FILES 10/18 (56%)CLASSES 10/18 (56%)LINE 561/1880 
(30%)CONDITIONAL 217/1152 (19%)
src.plasma
FILES 14/20 (70%)CLASSES 14/20 (70%)LINE 1658/3606 
(46%)CONDITIONAL 953/2705 (35%)
src.plasma.packagestructure
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 54/66 (82%)CONDITIONAL 
7/22 (32%)
src.plasma.private
FILES 13/22 (59%)CLASSES 13/22 (59%)LINE 867/1566 
(55%)CONDITIONAL 405/1022 (40%)
src.plasma.scripting
FILES 2/3 (67%)CLASSES 2/3 (67%)LINE 36/180 (20%)CONDITIONAL 
14/106 (13%)
src.plasmaquick
FILES 6/12 (50%)CLASSES 6/12 (50%)LINE 334/1693 
(20%)CONDITIONAL 156/1289 (12%)
src.plasmaquick.private
FILES 1/3 (33%)CLASSES 1/3 (33%)LINE 31/113 (27%)CONDITIONAL 
6/22 (27%)
src.scriptengines.qml.plasmoid
FILES 2/7 (29%)CLASSES 2/7 (29%)LINE 11/1136 (1%)CONDITIONAL 
1/974 (0%)

Jenkins-kde-ci: plasma-framework master stable-kf5-qt5 » Linux,NoX11,gcc - Build # 223 - Fixed!

[no-reply]

GENERAL INFO

BUILD SUCCESS
Build URL: 
https://build.kde.org/job/plasma-framework%20master%20stable-kf5-qt5/PLATFORM=Linux,Variation=NoX11,compiler=gcc/223/
Project: PLATFORM=Linux,Variation=NoX11,compiler=gcc
Date of build: Mon, 17 Oct 2016 12:58:49 +
Build duration: 2 min 22 sec

CHANGE SET
Revision 2b68e076587b3e326abc453db8de95e78db8c1e5 by Marco Martin: (make it 
actually build without kwayland)
  change: edit src/plasmaquick/dialog.cpp
  change: edit src/plasmaquick/dialogshadows.cpp


JUNIT RESULTS

Name: (root) Failed: 0 test(s), Passed: 15 test(s), Skipped: 0 test(s), Total: 
15 test(s)

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 9/9 (100%)FILES 78/115 (68%)CLASSES 78/115 (68%)LINE 4487/11219 
(40%)CONDITIONAL 2355/8454 (28%)

By packages
  
autotests
FILES 26/26 (100%)CLASSES 26/26 (100%)LINE 935/979 
(96%)CONDITIONAL 596/1162 (51%)
src.declarativeimports.core
FILES 10/18 (56%)CLASSES 10/18 (56%)LINE 561/1880 
(30%)CONDITIONAL 217/1152 (19%)
src.plasma
FILES 14/20 (70%)CLASSES 14/20 (70%)LINE 1658/3606 
(46%)CONDITIONAL 953/2705 (35%)
src.plasma.packagestructure
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 54/66 (82%)CONDITIONAL 
7/22 (32%)
src.plasma.private
FILES 13/22 (59%)CLASSES 13/22 (59%)LINE 867/1566 
(55%)CONDITIONAL 405/1022 (40%)
src.plasma.scripting
FILES 2/3 (67%)CLASSES 2/3 (67%)LINE 36/180 (20%)CONDITIONAL 
14/106 (13%)
src.plasmaquick
FILES 6/12 (50%)CLASSES 6/12 (50%)LINE 334/1693 
(20%)CONDITIONAL 156/1289 (12%)
src.plasmaquick.private
FILES 1/3 (33%)CLASSES 1/3 (33%)LINE 31/113 (27%)CONDITIONAL 
6/22 (27%)
src.scriptengines.qml.plasmoid
FILES 2/7 (29%)CLASSES 2/7 (29%)LINE 11/1136 (1%)CONDITIONAL 
1/974 (0%)

Re: Review Request 129205: [kcoredirlister] Ability to watch files changes

[Anthony Fieroni]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129205/
---

(Updated Oct. 17, 2016, 3:25 p.m.)


Review request for KDE Frameworks and David Faure.


Changes
---

Correct diff


Repository: kio


Description
---

David, i will discard review if you don't like it, cause watching files changes 
can be *really* expensive. I try to:
1. to not break abi compability
2. to extend filenamesearch with this option
3. to fix https://git.reviewboard.kde.org/r/129141/


Diffs (updated)
-

  src/core/kcoredirlister.h e6ba2ac 
  src/core/kcoredirlister.cpp 508516e 
  src/core/kcoredirlister_p.h 9a3cc7b 

Diff: https://git.reviewboard.kde.org/r/129205/diff/


Testing
---

For 3. i still can't figure out why in filenamesearch signal for delete item(s) 
is not triggered.
1. Search for file (by name) in dolphin
2. When appear in view delete him
3. Signal ItemsDeleted is not triggered, file stays in the view even if new 
search is performed and reload is needed. The cache look good, tests pass, 
works but in filenamesearch.


Thanks,

Anthony Fieroni

Re: Scrap Baloo Thread Feedback

[Vishesh Handa]

On Sun, Oct 16, 2016 at 2:16 PM, Christoph Cullmann  wrote:
> Hi,
>
> (evil top posting)
>
> given the silence, I assume any interest in baloo has stopped once more, or?
> Or are there any plans how to fixup the current situation?

I'm not going to be very involved with this.

I've already expressed my opinion. You all are free to make a decision.

--
Vishesh Handa

Re: Scrap Baloo Thread Feedback

[Vishesh Handa]

On Fri, Oct 7, 2016 at 8:08 PM, Christoph Cullmann  wrote:
>
> I did experiments and search works with tracker, but yes, a problem is 
> tagging,+
> which ATM doesn't work. Nor do I say that is a ready solution now, just a 
> possibility
> to avoid having to maintain low level code with at most 1 person (how it 
> looks ATM).
>
> And I don't propose to go that road now, but ATM I see nobody doing any other 
> experiments.
>
> Besides, tracker is constantly maintained and used since >> 5 years:
>
> https://github.com/GNOME/tracker/graphs/contributors

ok. Baloo clearly isn't being maintained.

>
>>
>>>
>>> => That is good that we agree, but I find it very astonishing that we use 
>>> baloo
>>> in its
>>> current state more or less mandatory on all that systems were it by design 
>>> will
>>> fail.
>>>
>>> (and it fails if you read the bugs)
>>>
>>
>> There is a certain amount of failure, but it's not "by-design". But
>> maybe I'm not seeing things clearly.
> You yourself stated that neither 32-bit issues nor NFS nor > 32-bit inodes 
> have any
> error handling. And that seems to have been known even during design and still
> we have this now as a framework per default used by any Plasma installation on
> systems exactly featuring that without error checking.
>
>>

>>
>> How about requirements such as resource consumption, ease of
>> integration, search speed are taken into consideration? Come on guys.
>> We're engineers over here.
>>
> What is the argument here? If you take a look at bugs.kde.org, you see 
> that
> people are complaining about all
> of that with baloo. I see no evidence nowhere that e.g. baloo is 
> "superior" to
> what GNOME uses
> or any other solution (perhaps beside nepomuk, ok...).
>>
>> What tests have been to obtain the evidence?
> What tests have been done to obtain the inverse evidence? I only hear here 
> the complaint
> about not taking requirements like resource consumption or speed into 
> account, but
> there is ATM zero evidence that e.g. tracker is slower.
>

I did do a lot of tests during the design of Baloo. I don't have hard numbers.

Even if I didn't, that doesn't mean a decision should be made without
gathering proper data.

> And the typical error check is:
>
> void MTimeDB::put(quint32 mtime, quint64 docId)
> {
> Q_ASSERT(mtime > 0);
> Q_ASSERT(docId > 0);
>
> MDB_val key;
> key.mv_size = sizeof(quint32);
> key.mv_data = static_cast();
>
> MDB_val val;
> val.mv_size = sizeof(quint64);
> val.mv_data = static_cast();
>
> int rc = mdb_put(m_txn, m_dbi, , , 0);
> Q_ASSERT_X(rc == 0, "MTimeDB::put", mdb_strerror(rc));
> }
>
> without any way to pass an error to the outside, nor any error handling code 
> at the outside,
> as no error can ever occur that is non-fatal.
>

ok. The API isn't exported. It can be changed.

But we both seem to have different opinions of how much work this would be.

>
> Besides I don't see any documentation of the DB format, but I could miss that.
> (at least not in the git nor https://community.kde.org/Baloo)
>

There isn't any.

>
> What would be highly appreciated would be a bit of documentation what the
> different pieces do and stuff like that, even if you have no time to code.
>

If you can send me specific questions about different parts I can
answer them. For "general documentation", I don't know where to start.
I usually much prefer just going through the code.


> Greetings
> Christoph
>

Jenkins-kde-ci: plasma-framework master kf5-qt5 » Linux,All,gcc - Build # 222 - Still Failing!

[no-reply]

GENERAL INFO

BUILD FAILURE
Build URL: 
https://build.kde.org/job/plasma-framework%20master%20kf5-qt5/PLATFORM=Linux,Variation=All,compiler=gcc/222/
Project: PLATFORM=Linux,Variation=All,compiler=gcc
Date of build: Mon, 17 Oct 2016 11:48:36 +
Build duration: 5 min 48 sec

CHANGE SET
Revision 9e54853ac89f3eb0e0f71d4a0491ba83db0c7709 by aleixpol: (Use less 
deprecated API)
  change: edit src/scriptengines/qml/plasmoid/containmentinterface.cpp
  change: edit src/plasmaquick/view.cpp
  change: edit src/scriptengines/qml/plasmoid/declarativeappletscript.cpp
  change: edit src/plasmaquick/appletquickitem.cpp
  change: edit src/plasma/scripting/appletscript.cpp
  change: edit src/plasma/containment.cpp
  change: edit src/plasmaquick/configview.cpp
  change: edit src/plasmaquick/containmentview.cpp

Jenkins-kde-ci: plasma-framework master kf5-qt5 » Linux,NoX11,gcc - Build # 222 - Still Failing!

[no-reply]

GENERAL INFO

BUILD FAILURE
Build URL: 
https://build.kde.org/job/plasma-framework%20master%20kf5-qt5/PLATFORM=Linux,Variation=NoX11,compiler=gcc/222/
Project: PLATFORM=Linux,Variation=NoX11,compiler=gcc
Date of build: Mon, 17 Oct 2016 11:48:36 +
Build duration: 5 min 39 sec

CHANGE SET
Revision 9e54853ac89f3eb0e0f71d4a0491ba83db0c7709 by aleixpol: (Use less 
deprecated API)
  change: edit src/plasma/scripting/appletscript.cpp
  change: edit src/plasmaquick/appletquickitem.cpp
  change: edit src/plasma/containment.cpp
  change: edit src/scriptengines/qml/plasmoid/containmentinterface.cpp
  change: edit src/plasmaquick/view.cpp
  change: edit src/scriptengines/qml/plasmoid/declarativeappletscript.cpp
  change: edit src/plasmaquick/configview.cpp
  change: edit src/plasmaquick/containmentview.cpp

Jenkins-kde-ci: plasma-framework master stable-kf5-qt5 » Linux,All,gcc - Build # 222 - Still Failing!

[no-reply]

GENERAL INFO

BUILD FAILURE
Build URL: 
https://build.kde.org/job/plasma-framework%20master%20stable-kf5-qt5/PLATFORM=Linux,Variation=All,compiler=gcc/222/
Project: PLATFORM=Linux,Variation=All,compiler=gcc
Date of build: Mon, 17 Oct 2016 11:48:36 +
Build duration: 3 min 8 sec

CHANGE SET
Revision 9e54853ac89f3eb0e0f71d4a0491ba83db0c7709 by aleixpol: (Use less 
deprecated API)
  change: edit src/plasmaquick/appletquickitem.cpp
  change: edit src/plasma/containment.cpp
  change: edit src/plasmaquick/view.cpp
  change: edit src/plasma/scripting/appletscript.cpp
  change: edit src/scriptengines/qml/plasmoid/declarativeappletscript.cpp
  change: edit src/plasmaquick/configview.cpp
  change: edit src/scriptengines/qml/plasmoid/containmentinterface.cpp
  change: edit src/plasmaquick/containmentview.cpp

Re: Review Request 129150: Use less deprecated API

[Aleix Pol Gonzalez]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129150/
---

(Updated Oct. 17, 2016, 11:48 a.m.)


Status
--

This change has been marked as submitted.


Review request for KDE Frameworks and Plasma.


Changes
---

Submitted with commit 9e54853ac89f3eb0e0f71d4a0491ba83db0c7709 by Aleix Pol on 
behalf of Aleix Pol Gonzalez to branch master.


Repository: plasma-framework


Description
---

Make it easier to look at the compilation output.


Diffs
-

  src/plasma/containment.cpp 1c49f05 
  src/plasma/scripting/appletscript.cpp a2342a3 
  src/plasmaquick/appletquickitem.cpp 2f100b8 
  src/plasmaquick/configview.cpp 73e4974 
  src/plasmaquick/containmentview.cpp 43f0fdd 
  src/plasmaquick/view.cpp 6ab0012 
  src/scriptengines/qml/plasmoid/containmentinterface.cpp 160cdd7 
  src/scriptengines/qml/plasmoid/declarativeappletscript.cpp 173573e 

Diff: https://git.reviewboard.kde.org/r/129150/diff/


Testing
---


Thanks,

Aleix Pol Gonzalez

Re: Review Request 129103: Generate metadata.json file at build time

[Marco Martin]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129103/#review100089
---


Ship it!




Ship It!

- Marco Martin


On Oct. 4, 2016, 11:31 p.m., Aleix Pol Gonzalez wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129103/
> ---
> 
> (Updated Oct. 4, 2016, 11:31 p.m.)
> 
> 
> Review request for KDE Frameworks and Plasma.
> 
> 
> Repository: kpackage
> 
> 
> Description
> ---
> 
> In plasma-framework internally we use a QJsonObject for reading the metadata. 
> Providing the metadata in desktop only makes the system have to parse 
> metadata.desktop and then convert it internally into a QJsonObject. 
> Furthermore, to do so we use a desktop file parser that is not very 
> performant (at least in comparison to KConfig's).
> 
> As part of #129102, we made sure that plasma supports `metadata.json`. This 
> patch leverages it moving the weight of converting desktop to json at compile 
> time.
> 
> It could even make sense to convert to binary json as well, I wonder whether 
> that would improve at all.
> 
> 
> Diffs
> -
> 
>   KF5PackageMacros.cmake 335fc81 
> 
> Diff: https://git.reviewboard.kde.org/r/129103/diff/
> 
> 
> Testing
> ---
> 
> Ran RR 129102 without any metdata.desktop files on my system.
> 
> Nope, hold the ship its, still needs work.
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

Re: Review Request 129065: Fix frameworks compilation with Qt < 5.6

[Marco Martin]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129065/#review100087
---


Ship it!




Ship It!

- Marco Martin


On Sept. 29, 2016, 11:50 p.m., David Edmundson wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129065/
> ---
> 
> (Updated Sept. 29, 2016, 11:50 p.m.)
> 
> 
> Review request for KDE Frameworks and Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> QQuickWindow::NoStage was new in Qt5.6. This uses a value that's valid
> in earlier Qt.
> 
> This shouldn't have any behavioural effect.
> 
> 
> Diffs
> -
> 
>   src/declarativeimports/core/windowthumbnail.cpp 
> 0453c092f7a7144f04fdacc81b031e8c352fa23b 
> 
> Diff: https://git.reviewboard.kde.org/r/129065/diff/
> 
> 
> Testing
> ---
> 
> Ran on my nvidia machine and moused over the taskbar.
> 
> I got thumbnails as expected, but also Nvidia-settings shows "user dedicated 
> memory" remaining constant
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

Re: Review Request 129150: Use less deprecated API

[Marco Martin]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129150/#review100081
---


Ship it!




Ship It!

- Marco Martin


On Oct. 11, 2016, 1:48 p.m., Aleix Pol Gonzalez wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129150/
> ---
> 
> (Updated Oct. 11, 2016, 1:48 p.m.)
> 
> 
> Review request for KDE Frameworks and Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> Make it easier to look at the compilation output.
> 
> 
> Diffs
> -
> 
>   src/plasma/containment.cpp 1c49f05 
>   src/plasma/scripting/appletscript.cpp a2342a3 
>   src/plasmaquick/appletquickitem.cpp 2f100b8 
>   src/plasmaquick/configview.cpp 73e4974 
>   src/plasmaquick/containmentview.cpp 43f0fdd 
>   src/plasmaquick/view.cpp 6ab0012 
>   src/scriptengines/qml/plasmoid/containmentinterface.cpp 160cdd7 
>   src/scriptengines/qml/plasmoid/declarativeappletscript.cpp 173573e 
> 
> Diff: https://git.reviewboard.kde.org/r/129150/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

Re: Review Request 128912: Import kcontrol docbooks for code in kio from kde-runtime master

[Luigi Toscano]

> On Sept. 15, 2016, 9:28 a.m., Luigi Toscano wrote:
> > Can they be made co-installable with the ones with kde-runtime, as both 
> > modules can be available at the same time? This is the problem of the 
> > missing support for kcontrol5
> > 
> > It was already done some time ago and I had to revert it:
> > https://marc.info/?t=14207454037=1=1
> > https://marc.info/?l=kde-i18n-doc=142076318528227=1
> 
> Burkhard Lück wrote:
> Sure we can make them co-installable, we just need to decide how to do it
> so far in kf5 we install to ${HTML_INSTALL_DIR}/en SUBDIR kcontrol/ = 
> same subdir as kde4/kde-runtime
> all kcontrol docbooks have the same name in kf5 + kde4 except for 
> cddbretrieval (kde4) / cddbretrieval5 (kf5) and ebrowsing (kde4) / 
> webshortcuts (kf5)
> 
> Options for co-installable:
> 
> 1) append a "5" to every kcm docbook name
> 2) install every kcm docbook to SUBDIR kcontrol5
> 
> Both options require mass renaming X-DocPath, CMakeLists.txt, translation 
> catalogs etc.
> 
> For kioslave docbooks we already use SUBDIR kioslave5, so we should use 
> SUBDIR kcontrol5 to keep consistency
> 
> Burkhard Lück wrote:
> Regarding co-installable:
> 
> frameworks/kdelibs4support has docs/kcontrol/kcm_ssl/index.docbook since 
> 5.0.0
> debian testing (stretch) and ubuntu 16.10 (yakkety) install 
> kcm_ssl/index.docbook in
> /usr/share/doc/kde/HTML/en/kcontrol/ from package kde-runtime-data
> and
> /usr/share/doc/HTML/en/kcontrol/ from package libkf5kdelibs4support-data
> i.e. distinguished using an additional subdir "kde" in the install path 
> from package kde-runtime-data
> 
> So we have apparently no conflict in debian based distributions and 
> apparently no conflict in builds from sources (no one complained since 
> frameworks 5.0.0)
> 
> Is this really a conflict in rpm based systems e.g. SuSe, RedHat ?

Yes, it is. Other distributions used the default value, which is 
/usr/share/doc/HTML/.


- Luigi


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128912/#review99183
---


On Sept. 15, 2016, 11:09 a.m., Burkhard Lück wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128912/
> ---
> 
> (Updated Sept. 15, 2016, 11:09 a.m.)
> 
> 
> Review request for Documentation, KDE Frameworks and Plasma.
> 
> 
> Repository: kio
> 
> 
> Description
> ---
> 
> doc/kcontrol/cache doc/kcontrol/proxy doc/kcontrol/useragent 
> doc/kcontrol/cookies/ doc/kcontrol/useragent/ doc/kcontrol/netpref/ 
> doc/kcontrol/ebrowsing/ doc/kcontrol/smb/
> splitted from kde-runtime master using https://github.com/ajdruff/git-splits
> 
> Not included in build so far, the docbooks are imported as they were splitted
> 
> To be done next:
> Move to existing subdir docs, adapt CMakeLists.txt, change dtd to kf5, 
> rename ebrowsing to webshortcuts
> reapply a few updates done in plasma-desktop
> remove these imported kcontrol docbooks from plasma-desktop
> adapt scripty to these changes
> 
> 
> Diffs
> -
> 
>   doc/kcontrol/cache/CMakeLists.txt PRE-CREATION 
>   doc/kcontrol/cache/index.docbook PRE-CREATION 
>   doc/kcontrol/cookies/CMakeLists.txt PRE-CREATION 
>   doc/kcontrol/cookies/index.docbook PRE-CREATION 
>   doc/kcontrol/ebrowsing/CMakeLists.txt PRE-CREATION 
>   doc/kcontrol/ebrowsing/index.docbook PRE-CREATION 
>   doc/kcontrol/netpref/CMakeLists.txt PRE-CREATION 
>   doc/kcontrol/netpref/index.docbook PRE-CREATION 
>   doc/kcontrol/proxy/CMakeLists.txt PRE-CREATION 
>   doc/kcontrol/proxy/index.docbook PRE-CREATION 
>   doc/kcontrol/smb/CMakeLists.txt PRE-CREATION 
>   doc/kcontrol/smb/index.docbook PRE-CREATION 
>   doc/kcontrol/useragent/CMakeLists.txt PRE-CREATION 
>   doc/kcontrol/useragent/index.docbook PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/128912/diff/
> 
> 
> Testing
> ---
> 
> history looks good, see git-log-doc-kcontrol.output, same log in kde-runtime 
> master
> 
> 
> File Attachments
> 
> 
> git-log-doc-kcontrol.output
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/09/15/94d16f46-6d99-4597-b7a4-3ba4add1dee0__git-log-doc-kcontrol.output
> 
> 
> Thanks,
> 
> Burkhard Lück
> 
>

Re: Review Request 128912: Import kcontrol docbooks for code in kio from kde-runtime master

[Marco Martin]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128912/#review100078
---


Ship it!




Ship It!

- Marco Martin


On Sept. 15, 2016, 9:09 a.m., Burkhard Lück wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128912/
> ---
> 
> (Updated Sept. 15, 2016, 9:09 a.m.)
> 
> 
> Review request for Documentation, KDE Frameworks and Plasma.
> 
> 
> Repository: kio
> 
> 
> Description
> ---
> 
> doc/kcontrol/cache doc/kcontrol/proxy doc/kcontrol/useragent 
> doc/kcontrol/cookies/ doc/kcontrol/useragent/ doc/kcontrol/netpref/ 
> doc/kcontrol/ebrowsing/ doc/kcontrol/smb/
> splitted from kde-runtime master using https://github.com/ajdruff/git-splits
> 
> Not included in build so far, the docbooks are imported as they were splitted
> 
> To be done next:
> Move to existing subdir docs, adapt CMakeLists.txt, change dtd to kf5, 
> rename ebrowsing to webshortcuts
> reapply a few updates done in plasma-desktop
> remove these imported kcontrol docbooks from plasma-desktop
> adapt scripty to these changes
> 
> 
> Diffs
> -
> 
>   doc/kcontrol/cache/CMakeLists.txt PRE-CREATION 
>   doc/kcontrol/cache/index.docbook PRE-CREATION 
>   doc/kcontrol/cookies/CMakeLists.txt PRE-CREATION 
>   doc/kcontrol/cookies/index.docbook PRE-CREATION 
>   doc/kcontrol/ebrowsing/CMakeLists.txt PRE-CREATION 
>   doc/kcontrol/ebrowsing/index.docbook PRE-CREATION 
>   doc/kcontrol/netpref/CMakeLists.txt PRE-CREATION 
>   doc/kcontrol/netpref/index.docbook PRE-CREATION 
>   doc/kcontrol/proxy/CMakeLists.txt PRE-CREATION 
>   doc/kcontrol/proxy/index.docbook PRE-CREATION 
>   doc/kcontrol/smb/CMakeLists.txt PRE-CREATION 
>   doc/kcontrol/smb/index.docbook PRE-CREATION 
>   doc/kcontrol/useragent/CMakeLists.txt PRE-CREATION 
>   doc/kcontrol/useragent/index.docbook PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/128912/diff/
> 
> 
> Testing
> ---
> 
> history looks good, see git-log-doc-kcontrol.output, same log in kde-runtime 
> master
> 
> 
> File Attachments
> 
> 
> git-log-doc-kcontrol.output
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/09/15/94d16f46-6d99-4597-b7a4-3ba4add1dee0__git-log-doc-kcontrol.output
> 
> 
> Thanks,
> 
> Burkhard Lück
> 
>

Jenkins-kde-ci: breeze-icons master stable-kf5-qt5 » Linux,gcc - Build # 339 - Still Unstable!

[no-reply]

GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/breeze-icons%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/339/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Mon, 17 Oct 2016 09:30:01 +
Build duration: 7 min 1 sec

CHANGE SET
Revision f946dfdd83a6ebf6cb45c8add19758183a5487fa by scripty: (SVN_SILENT made 
messages (.desktop file) - always resolve ours)
  change: edit icons-dark/index.theme


JUNIT RESULTS

Name: (root) Failed: 1 test(s), Passed: 3 test(s), Skipped: 0 test(s), Total: 4 
test(s)Failed: TestSuite.dupe

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 2/2 (100%)FILES 5/5 (100%)CLASSES 5/5 (100%)LINE 105/132 
(80%)CONDITIONAL 45/78 (58%)

By packages
  
default>
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 42/57 (74%)CONDITIONAL 
14/26 (54%)
autotests
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 63/75 (84%)CONDITIONAL 
31/52 (60%)

Jenkins-kde-ci: plasma-framework master stable-kf5-qt5 » Linux,All,gcc - Build # 221 - Still Failing!

[no-reply]

GENERAL INFO

BUILD FAILURE
Build URL: 
https://build.kde.org/job/plasma-framework%20master%20stable-kf5-qt5/PLATFORM=Linux,Variation=All,compiler=gcc/221/
Project: PLATFORM=Linux,Variation=All,compiler=gcc
Date of build: Mon, 17 Oct 2016 09:30:41 +
Build duration: 6 min 45 sec

CHANGE SET
Revision 05e86467c430178f7f3287bfade7f057be60c4e2 by scripty: (SVN_SILENT made 
messages (.desktop file) - always resolve ours)
  change: edit templates/cpp-plasmoid/cpp-plasmoid.kdevtemplate
  change: edit src/plasma/packagestructure/dataengine-packagestructure.json
  change: edit templates/plasma-wallpaper/plasma-wallpaper.kdevtemplate
  change: edit src/plasma/packagestructure/plasmageneric-packagestructure.json
  change: edit templates/qml-plasmoid/qml-plasmoid.kdevtemplate
  change: edit 
src/plasma/packagestructure/containmentactions-packagestructure.json

Jenkins-kde-ci: plasma-framework master kf5-qt5 » Linux,All,gcc - Build # 221 - Still Failing!

[no-reply]

GENERAL INFO

BUILD FAILURE
Build URL: 
https://build.kde.org/job/plasma-framework%20master%20kf5-qt5/PLATFORM=Linux,Variation=All,compiler=gcc/221/
Project: PLATFORM=Linux,Variation=All,compiler=gcc
Date of build: Mon, 17 Oct 2016 09:30:41 +
Build duration: 2 min 23 sec

CHANGE SET
Revision 05e86467c430178f7f3287bfade7f057be60c4e2 by scripty: (SVN_SILENT made 
messages (.desktop file) - always resolve ours)
  change: edit src/plasma/packagestructure/plasmageneric-packagestructure.json
  change: edit templates/plasma-wallpaper/plasma-wallpaper.kdevtemplate
  change: edit templates/cpp-plasmoid/cpp-plasmoid.kdevtemplate
  change: edit 
src/plasma/packagestructure/containmentactions-packagestructure.json
  change: edit templates/qml-plasmoid/qml-plasmoid.kdevtemplate
  change: edit src/plasma/packagestructure/dataengine-packagestructure.json

Jenkins-kde-ci: breeze-icons master kf5-qt5 » Linux,gcc - Build # 341 - Still Unstable!

[no-reply]

GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/breeze-icons%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/341/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Mon, 17 Oct 2016 09:30:01 +
Build duration: 6 min 50 sec

CHANGE SET
Revision f946dfdd83a6ebf6cb45c8add19758183a5487fa by scripty: (SVN_SILENT made 
messages (.desktop file) - always resolve ours)
  change: edit icons-dark/index.theme


JUNIT RESULTS

Name: (root) Failed: 1 test(s), Passed: 3 test(s), Skipped: 0 test(s), Total: 4 
test(s)Failed: TestSuite.dupe

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 2/2 (100%)FILES 5/5 (100%)CLASSES 5/5 (100%)LINE 105/132 
(80%)CONDITIONAL 45/78 (58%)

By packages
  
default>
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 42/57 (74%)CONDITIONAL 
14/26 (54%)
autotests
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 63/75 (84%)CONDITIONAL 
31/52 (60%)

Jenkins-kde-ci: plasma-framework master stable-kf5-qt5 » Linux,NoX11,gcc - Build # 221 - Still Failing!

[no-reply]

GENERAL INFO

BUILD FAILURE
Build URL: 
https://build.kde.org/job/plasma-framework%20master%20stable-kf5-qt5/PLATFORM=Linux,Variation=NoX11,compiler=gcc/221/
Project: PLATFORM=Linux,Variation=NoX11,compiler=gcc
Date of build: Mon, 17 Oct 2016 09:30:41 +
Build duration: 2 min 12 sec

CHANGE SET
Revision 05e86467c430178f7f3287bfade7f057be60c4e2 by scripty: (SVN_SILENT made 
messages (.desktop file) - always resolve ours)
  change: edit templates/qml-plasmoid/qml-plasmoid.kdevtemplate
  change: edit templates/plasma-wallpaper/plasma-wallpaper.kdevtemplate
  change: edit src/plasma/packagestructure/dataengine-packagestructure.json
  change: edit templates/cpp-plasmoid/cpp-plasmoid.kdevtemplate
  change: edit src/plasma/packagestructure/plasmageneric-packagestructure.json
  change: edit 
src/plasma/packagestructure/containmentactions-packagestructure.json

Jenkins-kde-ci: plasma-framework master kf5-qt5 » Linux,NoX11,gcc - Build # 221 - Still Failing!

[no-reply]

GENERAL INFO

BUILD FAILURE
Build URL: 
https://build.kde.org/job/plasma-framework%20master%20kf5-qt5/PLATFORM=Linux,Variation=NoX11,compiler=gcc/221/
Project: PLATFORM=Linux,Variation=NoX11,compiler=gcc
Date of build: Mon, 17 Oct 2016 09:30:41 +
Build duration: 1 min 11 sec

CHANGE SET
Revision 05e86467c430178f7f3287bfade7f057be60c4e2 by scripty: (SVN_SILENT made 
messages (.desktop file) - always resolve ours)
  change: edit src/plasma/packagestructure/dataengine-packagestructure.json
  change: edit templates/qml-plasmoid/qml-plasmoid.kdevtemplate
  change: edit templates/plasma-wallpaper/plasma-wallpaper.kdevtemplate
  change: edit src/plasma/packagestructure/plasmageneric-packagestructure.json
  change: edit templates/cpp-plasmoid/cpp-plasmoid.kdevtemplate
  change: edit 
src/plasma/packagestructure/containmentactions-packagestructure.json

Re: Review Request 128912: Import kcontrol docbooks for code in kio from kde-runtime master

[Burkhard Lück]

> On Sept. 15, 2016, 7:28 vorm., Luigi Toscano wrote:
> > Can they be made co-installable with the ones with kde-runtime, as both 
> > modules can be available at the same time? This is the problem of the 
> > missing support for kcontrol5
> > 
> > It was already done some time ago and I had to revert it:
> > https://marc.info/?t=14207454037=1=1
> > https://marc.info/?l=kde-i18n-doc=142076318528227=1
> 
> Burkhard Lück wrote:
> Sure we can make them co-installable, we just need to decide how to do it
> so far in kf5 we install to ${HTML_INSTALL_DIR}/en SUBDIR kcontrol/ = 
> same subdir as kde4/kde-runtime
> all kcontrol docbooks have the same name in kf5 + kde4 except for 
> cddbretrieval (kde4) / cddbretrieval5 (kf5) and ebrowsing (kde4) / 
> webshortcuts (kf5)
> 
> Options for co-installable:
> 
> 1) append a "5" to every kcm docbook name
> 2) install every kcm docbook to SUBDIR kcontrol5
> 
> Both options require mass renaming X-DocPath, CMakeLists.txt, translation 
> catalogs etc.
> 
> For kioslave docbooks we already use SUBDIR kioslave5, so we should use 
> SUBDIR kcontrol5 to keep consistency

Regarding co-installable:

frameworks/kdelibs4support has docs/kcontrol/kcm_ssl/index.docbook since 5.0.0
debian testing (stretch) and ubuntu 16.10 (yakkety) install 
kcm_ssl/index.docbook in
/usr/share/doc/kde/HTML/en/kcontrol/ from package kde-runtime-data
and
/usr/share/doc/HTML/en/kcontrol/ from package libkf5kdelibs4support-data
i.e. distinguished using an additional subdir "kde" in the install path from 
package kde-runtime-data

So we have apparently no conflict in debian based distributions and apparently 
no conflict in builds from sources (no one complained since frameworks 5.0.0)

Is this really a conflict in rpm based systems e.g. SuSe, RedHat ?


- Burkhard


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128912/#review99183
---


On Sept. 15, 2016, 9:09 vorm., Burkhard Lück wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128912/
> ---
> 
> (Updated Sept. 15, 2016, 9:09 vorm.)
> 
> 
> Review request for Documentation, KDE Frameworks and Plasma.
> 
> 
> Repository: kio
> 
> 
> Description
> ---
> 
> doc/kcontrol/cache doc/kcontrol/proxy doc/kcontrol/useragent 
> doc/kcontrol/cookies/ doc/kcontrol/useragent/ doc/kcontrol/netpref/ 
> doc/kcontrol/ebrowsing/ doc/kcontrol/smb/
> splitted from kde-runtime master using https://github.com/ajdruff/git-splits
> 
> Not included in build so far, the docbooks are imported as they were splitted
> 
> To be done next:
> Move to existing subdir docs, adapt CMakeLists.txt, change dtd to kf5, 
> rename ebrowsing to webshortcuts
> reapply a few updates done in plasma-desktop
> remove these imported kcontrol docbooks from plasma-desktop
> adapt scripty to these changes
> 
> 
> Diffs
> -
> 
>   doc/kcontrol/cache/CMakeLists.txt PRE-CREATION 
>   doc/kcontrol/cache/index.docbook PRE-CREATION 
>   doc/kcontrol/cookies/CMakeLists.txt PRE-CREATION 
>   doc/kcontrol/cookies/index.docbook PRE-CREATION 
>   doc/kcontrol/ebrowsing/CMakeLists.txt PRE-CREATION 
>   doc/kcontrol/ebrowsing/index.docbook PRE-CREATION 
>   doc/kcontrol/netpref/CMakeLists.txt PRE-CREATION 
>   doc/kcontrol/netpref/index.docbook PRE-CREATION 
>   doc/kcontrol/proxy/CMakeLists.txt PRE-CREATION 
>   doc/kcontrol/proxy/index.docbook PRE-CREATION 
>   doc/kcontrol/smb/CMakeLists.txt PRE-CREATION 
>   doc/kcontrol/smb/index.docbook PRE-CREATION 
>   doc/kcontrol/useragent/CMakeLists.txt PRE-CREATION 
>   doc/kcontrol/useragent/index.docbook PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/128912/diff/
> 
> 
> Testing
> ---
> 
> history looks good, see git-log-doc-kcontrol.output, same log in kde-runtime 
> master
> 
> 
> File Attachments
> 
> 
> git-log-doc-kcontrol.output
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/09/15/94d16f46-6d99-4597-b7a4-3ba4add1dee0__git-log-doc-kcontrol.output
> 
> 
> Thanks,
> 
> Burkhard Lück
> 
>

Review Request 129205: [kcoredirlister] Ability to watch files changes

[Anthony Fieroni]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129205/
---

Review request for KDE Frameworks and David Faure.


Repository: kio


Description
---

David, i will discard review if you don't like it, cause watching files changes 
can be *really* expensive. I try to:
1. to not break abi compability
2. to extend filenamesearch with this option
3. to fix https://git.reviewboard.kde.org/r/129141/


Diffs
-

  src/core/kcoredirlister.h e6ba2ac 
  src/core/kcoredirlister.cpp 508516e 
  src/core/kcoredirlister_p.h 9a3cc7b 

Diff: https://git.reviewboard.kde.org/r/129205/diff/


Testing
---

For 3. i still can't figure out why in filenamesearch signal for delete item(s) 
is not triggered.
1. Search for file (by name) in dolphin
2. When appear in view delete him
3. Signal ItemsDeleted is not triggered, file stays in the view even if new 
search is performed and reload is needed. The cache look good, tests pass, 
works but in filenamesearch.


Thanks,

Anthony Fieroni

Re: Review Request 129202: Handle faulty provider as initialized

[Aleix Pol Gonzalez]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129202/#review100066
---



+1 LGTM, unsure of the implications.

- Aleix Pol Gonzalez


On Oct. 16, 2016, 7:50 p.m., Andreas Cord-Landwehr wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129202/
> ---
> 
> (Updated Oct. 16, 2016, 7:50 p.m.)
> 
> 
> Review request for KDE Frameworks, Aleix Pol Gonzalez, Dan Leinir Turthra 
> Jensen, and Jeremy Whiting.
> 
> 
> Repository: knewstuff
> 
> 
> Description
> ---
> 
> Always mark a provider as initialized when all initializion steps
> are performed, in particularly when an error occured. This ensures
> that the UI is correctly updated when the initialization steps finished.
> 
> 
> Diffs
> -
> 
>   src/attica/atticaprovider.cpp bc590ce2a2170f69d0b6d8049f7d5da5d0c1d0cd 
> 
> Diff: https://git.reviewboard.kde.org/r/129202/diff/
> 
> 
> Testing
> ---
> 
> manual testing
> 
> 
> Thanks,
> 
> Andreas Cord-Landwehr
> 
>