D12320: add ability to read embedded cover files

[Matthieu Gallien]

mgallien added a comment.


  Thanks a lot to continue to push this work.
  
  In D12320#249433 , @bruns wrote:
  
  > Baloos DBs should only contain searchable data. So until someone teaches 
baloo how to compare images, it should be kept separate.
  
  
  I am also not convinced that Baloo should index the cover images. They are 
quite a lot of data. At the same time, I am really happy to have support for it 
in KFileMetaData.
  
  It should then be easy to add support in a file preview or in applications.

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D12320

To: astippich, mgallien, michaelh
Cc: bruns, #frameworks, ashaposhnikov, michaelh, astippich, spoorun

KDE CI: Frameworks kconfig kf5-qt5 FreeBSDQt5.9 - Build # 21 - Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kconfig%20kf5-qt5%20FreeBSDQt5.9/21/
 Project:
Frameworks kconfig kf5-qt5 FreeBSDQt5.9
 Date of build:
Thu, 19 Apr 2018 05:47:12 +
 Build duration:
1 min 9 sec and counting
   JUnit Tests
  Name: (root) Failed: 2 test(s), Passed: 33 test(s), Skipped: 0 test(s), Total: 35 test(s)Failed: TestSuite.kconfigcore-kconfigtestFailed: TestSuite.kconfigcore-test_kconf_update

D12326: [WIP/open dependencies] In Short View, display icons on top and increase icon size

[Nathaniel Graham]

ngraham edited the summary of this revision.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D12326

To: ngraham
Cc: anemeth, #frameworks, michaelh, bruns

D12333: Put the open/save dialog's toolbar above all other widgets, like Dolphin does

[Nathaniel Graham]

ngraham edited the summary of this revision.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D12333

To: ngraham, #frameworks, #dolphin, #vdg
Cc: anemeth, rkflx, michaelh, bruns

D12337: Give the file dialogs a "Sort by" menu button on the toolbar

[Nathaniel Graham]

ngraham edited the test plan for this revision.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D12337

To: ngraham, #frameworks, #dolphin, #vdg, rkflx
Cc: anemeth, michaelh, bruns

D12333: Put the open/save dialog's toolbar above all other widgets, like Dolphin does

[Nathaniel Graham]

ngraham added a task: T8552: Polish Open/Save dialogs.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D12333

To: ngraham, #frameworks, #dolphin, #vdg
Cc: anemeth, rkflx, michaelh, bruns

D12337: Give the file dialogs a "Sort by" menu button on the toolbar

[Nathaniel Graham]

ngraham added a task: T8552: Polish Open/Save dialogs.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D12337

To: ngraham, #frameworks, #dolphin, #vdg, rkflx
Cc: anemeth, michaelh, bruns

D12333: Put the open/save dialog's toolbar above all other widgets, like Dolphin does

[Nathaniel Graham]

ngraham added a dependent revision: D12337: Give the file dialogs a "Sort by" 
menu button on the toolbar.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D12333

To: ngraham, #frameworks, #dolphin, #vdg
Cc: anemeth, rkflx, michaelh, bruns

D12337: Give the file dialogs a "Sort by" menu button on the toolbar

[Nathaniel Graham]

ngraham edited the summary of this revision.
ngraham edited the test plan for this revision.
ngraham set the repository for this revision to R241 KIO.
ngraham added a dependency: D12333: Put the open/save dialog's toolbar above 
all other widgets, like Dolphin does.
Restricted Application added a project: Frameworks.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D12337

To: ngraham, #frameworks, #dolphin, #vdg, rkflx
Cc: anemeth, michaelh, bruns

D12337: Give the file dialogs a "Sort by" menu button on the toolbar

[Nathaniel Graham]

ngraham updated this revision to Diff 32533.
ngraham added a comment.


  Improve a comment

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D12337?vs=32532&id=32533

BRANCH
  move-sort-order-chooser-to-toolbar (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D12337

AFFECTED FILES
  src/filewidgets/kdiroperator.cpp
  src/filewidgets/kfilewidget.cpp

To: ngraham, #frameworks, #dolphin, #vdg, rkflx
Cc: anemeth

D12337: Give the file dialogs a "Sort by" menu button on the toolbar

[Nathaniel Graham]

ngraham created this revision.
ngraham added reviewers: Frameworks, Dolphin, VDG, rkflx.
ngraham requested review of this revision.

REVISION SUMMARY
  This patch moves the sort order chooser and options out of the somewhat 
hidden Settings menu and onto the main toolbar, in conjunction with a few 
string and icon changes to improve the look and feel.

TEST PLAN
  Menu being used in Short view:
  
  Menu being used in Detailed Tree View:
  
  Settings menu no longer has (or needs) it:
  
  It's still there in the contect menu, fully accessible for `KDirOperator` 
clients:

BRANCH
  move-sort-order-chooser-to-toolbar (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D12337

AFFECTED FILES
  src/filewidgets/kdiroperator.cpp
  src/filewidgets/kfilewidget.cpp

To: ngraham, #frameworks, #dolphin, #vdg, rkflx
Cc: anemeth

D12077: Show view mode buttons in the open/save dialog's toolbar

[Andres Betts]

abetts added a comment.


  In D12077#249447 , @ngraham wrote:
  
  > In D12077#249446 , @abetts wrote:
  >
  > > Somewhat related, why does the Size header have a number of items listed 
and not the size in bytes for all the items inside the folder?
  > >
  > > size
  > >
  > > 0 items
  > >  2 items
  > >
  > > Shouldn't it be:
  > >
  > > size
  > >  1 kb
  > >  3 Mb
  > >
  > > ??
  >
  >
  > It's like that in Dolphin too. The reason is because it out to be tricky to 
implement See https://bugs.kde.org/show_bug.cgi?id=158090. I tried last year 
but ran into a bunch of issues that I wasn't a good enough programmer to 
resolve.
  
  
  Awesome, just wondering. Don't mean to derail the conversation. Food for 
thought!

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D12077

To: ngraham, #frameworks, rkflx, #vdg, abetts
Cc: sharvey, rkflx, mmustac, broulik, michaelh, bruns

D12077: Show view mode buttons in the open/save dialog's toolbar

[Nathaniel Graham]

ngraham added a comment.


  In D12077#249446 , @abetts wrote:
  
  > Somewhat related, why does the Size header have a number of items listed 
and not the size in bytes for all the items inside the folder?
  >
  > size
  >
  > 0 items
  >  2 items
  >
  > Shouldn't it be:
  >
  > size
  >  1 kb
  >  3 Mb
  >
  > ??
  
  
  It's like that in Dolphin too. The reason is because it out to be tricky to 
implement See https://bugs.kde.org/show_bug.cgi?id=158090. I tried last year 
but ran into a bunch of issues that I wasn't a good enough programmer to 
resolve.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D12077

To: ngraham, #frameworks, rkflx, #vdg, abetts
Cc: sharvey, rkflx, mmustac, broulik, michaelh, bruns

D12077: Show view mode buttons in the open/save dialog's toolbar

[Andres Betts]

abetts added a comment.


  Somewhat related, why does the Size header have a number of items listed and 
not the size in bytes for all the items inside the folder?
  
  size
  
  0 items
  2 items
  
  Shouldn't it be:
  
  size
  1 kb
  3 Mb
  
  ??

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D12077

To: ngraham, #frameworks, rkflx, #vdg, abetts
Cc: sharvey, rkflx, mmustac, broulik, michaelh, bruns

KDE CI: Frameworks plasma-framework kf5-qt5 SUSEQt5.10 - Build # 134 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20SUSEQt5.10/134/
 Project:
Frameworks plasma-framework kf5-qt5 SUSEQt5.10
 Date of build:
Thu, 19 Apr 2018 03:18:21 +
 Build duration:
4 min 50 sec and counting
   JUnit Tests
  Name: (root) Failed: 7 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 15 test(s)Failed: TestSuite.dialognativetestFailed: TestSuite.plasma-configmodeltestFailed: TestSuite.plasma-dialogqmltestFailed: TestSuite.plasma-fallbackpackagetestFailed: TestSuite.plasma-iconitemtestFailed: TestSuite.plasma-packagestructuretestFailed: TestSuite.plasma-storagetest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report33%
(6/18)35%
(55/159)35%
(55/159)26%
(3558/13511)19%
(1978/10689)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests85%
(22/26)85%
(22/26)53%
(609/1140)28%
(421/1492)src.declarativeimports.calendar0%
(0/11)0%
(0/11)0%
(0/452)0%
(0/241)src.declarativeimports.core22%
(4/18)22%
(4/18)11%
(253/2314)7%
(102/1552)src.declarativeimports.plasmacomponents0%
(0/9)0%
(0/9)0%
(0/525)0%
(0/214)src.declarativeimports.plasmaextracomponents0%
(0/5)0%
(0/5)0%
(0/44)0%
(0/27)src.declarativeimports.platformcomponents0%
(0/4)0%
(0/4)0%
(0/60)0%
(0/14)src.declarativeimports.platformcomponents.utils0%
(0/2)0%
(0/2)0%
(0/15)0%
(0/4)src.plasma55%
(12/22)55%
(12/22)41%
(1442/3532)28%
(827/2965)src.plasma.packagestructure0%
(0/7)0%
(0/7)0%
(0/141)0%
(0/14)src.plasma.private46%
(11/24)46%
(11/24)41%
(671/1621)28%
(318/1121)src.plasma.scripting0%
(0/3)0%
(0/3)0%
(0/162)0%
(0/132)src.plasmapkg0%
(0/1)0%
(0/1)0%
(0/45)0%
(0/40)src.plasmaquick42%
(5/12)42%
(5/12)27%
(552/2015)17%
(305/1779)src.plasmaquick.private33%
(1/3)33%
(1/3)28%
(31/110)36%
(5/14)src.scriptengines.qml.plasmoid0%
(0/6)0%
(0/6)0%
(0/1177)0%
(0/1056)tests.dpi0%
(0/2)0%
(0/2)0%
(0/22)0%
(0/2)tests.kplugins0%
 

KDE CI: Frameworks plasma-framework kf5-qt5 FreeBSDQt5.9 - Build # 109 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20FreeBSDQt5.9/109/
 Project:
Frameworks plasma-framework kf5-qt5 FreeBSDQt5.9
 Date of build:
Thu, 19 Apr 2018 03:18:21 +
 Build duration:
2 min 54 sec and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 13 test(s), Skipped: 0 test(s), Total: 14 test(s)Failed: TestSuite.plasma-packagestructuretest

D12321: Hide file preview when icon is too small

[Nathaniel Graham]

ngraham added a reviewer: Dolphin.
ngraham added a subscriber: sharvey.
ngraham added a comment.


  In D12321#249367 , @rkflx wrote:
  
  > The relation between the Preview and the Zoom slider is now a bit weird: 
You can override with the button, but once you move the slider the setting will 
be gone again. Also, when showing the dialog after closing it, the slider has 
preference over the button. In addition, even though the button says "enabled", 
users will wonder why no thumbnails are showing!
  >
  > Would it make sense to both:
  >
  > - Set the button state to "off" once the icons are too small, to make it 
clear that no previews are to be expected.
  > - Disable the button, so manually toggling thumbnails only works if icons 
are big enough.
  
  
  Something like this might be nice, but as you observed, it'll get real 
complicated real fast. And as @sharvey discovered in D12094 
, trying to coerce a KToggleAction into 
doing something it doesn't want to do can be daunting. My vote gots to 
disabling the button at small sizes, if that's easily possible.
  
  In D12321#249367 , @rkflx wrote:
  
  > Also, before this goes in I'd like to see a similar patch for Dolphin. Not 
so much because of any implemention issue, but to get the (not quite 
uncontroversial) idea more exposure and to agree on a common vision for how 
thumbnails should behave everywhere.
  
  
  Agreed. Let's also invite #dolphin  
into this discussion too. It's a shame the same view widget isn't used in 
both...

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D12321

To: anemeth, #vdg, #frameworks, ngraham, rkflx, #dolphin
Cc: sharvey, rkflx, ngraham, #frameworks, michaelh, bruns

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.10 - Build # 220 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.10/220/
 Project:
Frameworks kio kf5-qt5 SUSEQt5.10
 Date of build:
Thu, 19 Apr 2018 02:18:41 +
 Build duration:
16 min and counting
   JUnit Tests
  Name: (root) Failed: 3 test(s), Passed: 55 test(s), Skipped: 0 test(s), Total: 58 test(s)Failed: TestSuite.kiocore-jobtestFailed: TestSuite.kiofilewidgets-kfileplacesmodeltestFailed: TestSuite.kiofilewidgets-kfileplacesviewtest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report64%
(23/36)65%
(286/442)65%
(286/442)50%
(29947/59678)36%
(17681/48987)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests97%
(71/73)97%
(71/73)81%
(7405/9134)42%
(4568/10857)autotests.http100%
(9/9)100%
(9/9)100%
(586/587)59%
(217/368)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(180/198)67%
(63/94)src100%
(1/1)100%
(1/1)100%
(5/5)75%
(3/4)src.core79%
(94/119)79%
(94/119)55%
(7910/14348)48%
(4676/9747)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets79%
(31/39)79%
(31/39)49%
(3871/7855)33%
(1634/4934)src.gui100%
(2/2)100%
(2/2)95%
(104/110)77%
(57/74)src.ioslaves.file100%
(5/5)100%
(5/5)52%
(521/1008)42%
(417/1004)src.ioslaves.file.kauth0%
(0/3)0%
(0/3)0%
(0/104)0%
(0/75)src.ioslaves.ftp0%
(0/2)0%
(0/2)0%
(0/1365)0%
(0/1515)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/247)0%
(0/184)src.ioslaves.http89%
(8/9)89%
(8/9)41%
(1783/4338)35%
(1375/3979)src.ioslaves.http.kcookiejar33%
(2/6)33%
(2/6)47%
(631/1333)55%
(649/1174)src.ioslaves.remote100%
(2/2)100%
(2/2)28%
(72/258)8%
(19/242)src.ioslaves.remote.kdedmodule0%
(0/4)0%
(0/4)0%
(0/14)100%
(0/0)src.ioslaves.telnet0%
(0/1)0%
(0/1)0%
(0/43)0%
(0/30)src.ioslaves.trash64%
  

KDE CI: Frameworks kio kf5-qt5 FreeBSDQt5.9 - Build # 199 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20FreeBSDQt5.9/199/
 Project:
Frameworks kio kf5-qt5 FreeBSDQt5.9
 Date of build:
Thu, 19 Apr 2018 02:18:41 +
 Build duration:
15 min and counting
   JUnit Tests
  Name: (root) Failed: 7 test(s), Passed: 50 test(s), Skipped: 0 test(s), Total: 57 test(s)Failed: TestSuite.kiocore-jobtestFailed: TestSuite.kiocore-kmountpointtestFailed: TestSuite.kiocore-threadtestFailed: TestSuite.kiofilewidgets-kfileplacesmodeltestFailed: TestSuite.kiofilewidgets-kfileplacesviewtestFailed: TestSuite.kiowidgets-kdirlistertestFailed: TestSuite.kiowidgets-kdirmodeltest

D12328: Enable preview by default in the filepicker dialog

[Nathaniel Graham]

ngraham added a comment.


  This depends on D12321  and enables 
D12326 ; there are a lot of changes in 
flight here. But the overall goal here is explained in T8552 
: we want to make Short View display large 
icons with previews, and Detailed Tree View show a list with detail columns.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D12328

To: anemeth, #frameworks, #vdg, rkflx
Cc: abetts, rkflx, ngraham, #frameworks, michaelh, bruns

D12326: [WIP/open dependencies] In Short View, display icons on top and increase icon size

[Nathaniel Graham]

ngraham updated this revision to Diff 32531.
ngraham added a comment.


  Rebase on current master

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D12326?vs=32508&id=32531

BRANCH
  short-view-has-icons-on-top-by-default (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D12326

AFFECTED FILES
  src/filewidgets/kdiroperator.cpp

To: ngraham
Cc: anemeth, #frameworks, michaelh, bruns

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.9 - Build # 69 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.9/69/
 Project:
Frameworks kio kf5-qt5 SUSEQt5.9
 Date of build:
Thu, 19 Apr 2018 02:18:41 +
 Build duration:
7 min 4 sec and counting
   JUnit Tests
  Name: (root) Failed: 3 test(s), Passed: 55 test(s), Skipped: 0 test(s), Total: 58 test(s)Failed: TestSuite.kiocore-jobtestFailed: TestSuite.kiofilewidgets-kfileplacesmodeltestFailed: TestSuite.kiofilewidgets-kfileplacesviewtest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report64%
(23/36)65%
(286/442)65%
(286/442)50%
(29978/59679)36%
(17696/48983)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests97%
(71/73)97%
(71/73)81%
(7407/9134)42%
(4571/10857)autotests.http100%
(9/9)100%
(9/9)100%
(586/587)59%
(217/368)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(180/198)67%
(63/94)src100%
(1/1)100%
(1/1)100%
(5/5)75%
(3/4)src.core79%
(94/119)79%
(94/119)55%
(7960/14349)48%
(4697/9751)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets79%
(31/39)79%
(31/39)49%
(3872/7855)33%
(1635/4934)src.gui100%
(2/2)100%
(2/2)95%
(104/110)77%
(57/74)src.ioslaves.file100%
(5/5)100%
(5/5)52%
(521/1008)42%
(417/1004)src.ioslaves.file.kauth0%
(0/3)0%
(0/3)0%
(0/104)0%
(0/75)src.ioslaves.ftp0%
(0/2)0%
(0/2)0%
(0/1365)0%
(0/1515)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/247)0%
(0/184)src.ioslaves.http89%
(8/9)89%
(8/9)41%
(1783/4338)35%
(1373/3979)src.ioslaves.http.kcookiejar33%
(2/6)33%
(2/6)47%
(630/1333)55%
(648/1174)src.ioslaves.remote100%
(2/2)100%
(2/2)28%
(72/258)8%
(19/242)src.ioslaves.remote.kdedmodule0%
(0/4)0%
(0/4)0%
(0/14)100%
(0/0)src.ioslaves.telnet0%
(0/1)0%
(0/1)0%
(0/43)0%
(0/30)src.ioslaves.trash64%

D12320: add ability to read embedded cover files

[Stefan Brüns]

bruns added a comment.


  Baloos DBs should only contain searchable data. So until someone teaches 
baloo how to compare images, it should be kept separate.

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D12320

To: astippich, mgallien, michaelh
Cc: bruns, #frameworks, ashaposhnikov, michaelh, astippich, spoorun

D12077: Show view mode buttons in the open/save dialog's toolbar

[Nathaniel Graham]

ngraham closed this revision.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D12077

To: ngraham, #frameworks, rkflx, #vdg, abetts
Cc: sharvey, rkflx, mmustac, broulik, michaelh, bruns

D12077: Show view mode buttons in the open/save dialog's toolbar

[Nathaniel Graham]

ngraham added a comment.


  Asking around on IRC and Telegram, I haven't found anyone who objects to 
this. Landing it.

REPOSITORY
  R241 KIO

BRANCH
  arcpatch-D12077

REVISION DETAIL
  https://phabricator.kde.org/D12077

To: ngraham, #frameworks, rkflx, #vdg, abetts
Cc: sharvey, rkflx, mmustac, broulik, michaelh, bruns

D12197: autotests: Test for multiple values

[Stefan Brüns]

bruns added inline comments.

INLINE COMMENTS

> multivaluetest.cpp:90
> +<< QStringLiteral("application/epub+zip")
> +<< Property::Subject
> +<< QVariantList{QVariant(QStringLiteral("Baloo KFileMetaData"))}

Here you use the property value directly, while in other places you use the 
`property` variable - I think using the value directly is much easier to read.

> multivaluetest.cpp:91
> +<< Property::Subject
> +<< QVariantList{QVariant(QStringLiteral("Baloo KFileMetaData"))}
> +<< QString()

Again, I prefer this notation versus `expectedresult`
You can make this somewhat shorter by using  
`QVariantList{QStringLiteral{"Baloo KFileMetaData"}}`, i.e. omit the extra 
`QVariant`

REPOSITORY
  R286 KFileMetaData

BRANCH
  multi-value-test

REVISION DETAIL
  https://phabricator.kde.org/D12197

To: michaelh, #baloo, #frameworks, mgallien
Cc: bruns, ashaposhnikov, michaelh, astippich, spoorun

D12336: Replace several Q_ASSERTs with proper checks

[Stefan Brüns]

bruns created this revision.
bruns added reviewers: Baloo, michaelh.
Restricted Application added projects: Frameworks, Baloo.
Restricted Application added a subscriber: Frameworks.
bruns requested review of this revision.

REVISION SUMMARY
  The code has some preconditions on supplied values when interacting
  with the DB. Instead of silently corrupting the DB with bogus values
  when using non-debug builds, check any provided arguments.

REPOSITORY
  R293 Baloo

BRANCH
  db_robustness2

REVISION DETAIL
  https://phabricator.kde.org/D12336

AFFECTED FILES
  src/engine/documenturldb.cpp

To: bruns, #baloo, michaelh
Cc: #frameworks, ashaposhnikov, michaelh, astippich, spoorun, bruns

D12335: Avoid infinite loops when fetching the URL from DocumentUrlDB

[Stefan Brüns]

bruns created this revision.
bruns added reviewers: Baloo, michaelh.
Restricted Application added projects: Frameworks, Baloo.
Restricted Application added a subscriber: Frameworks.
bruns requested review of this revision.

REVISION SUMMARY
  Some users apparently have DBs which contain infinite loops in the idTree
  (a parentId pointing to itself or one of its children). This manifests in
  either crashes due to exhausted memory and/or the process being stuck
  with 100% CPU load.
  
  The problem can only be completely solved by either recreating the DB, or
  by cleaning the DB from any problematic records. As in interim solution,
  stop the code from crashing.
  
  BUG: 378754
  CCBUG: 385846
  CCBUG: 391258
  CCBUG: 393181

REPOSITORY
  R293 Baloo

BRANCH
  db_robustness

REVISION DETAIL
  https://phabricator.kde.org/D12335

AFFECTED FILES
  src/engine/documenturldb.cpp

To: bruns, #baloo, michaelh
Cc: #frameworks, ashaposhnikov, michaelh, astippich, spoorun, bruns

D12251: Integrate with androiddeployqt dependencies files

[Aleix Pol Gonzalez]

apol added a comment.


  I don't really see why we need a special path for parts.
  
  > I understand you're doing it to be able to just get everything from that 
folder and then put it on the apk
  > 
  > Now without knowing anything about cmake, wouldn't it make more sense put 
on the apk every single thing i'm installing?
  > 
  > I mean if i do
  > 
  > add_library(okularpart SHARED ${okularpart_SRCS})
  >  install(TARGETS okularpart DESTINATION ${KDE_INSTALL_PLUGINDIR})
  >  it's surely because i'm interesting in having okularpart in my apk, 
otherwise why would i spend precious time compiling and installing it?
  
  That's not a bad point, I think having all plugins in the same subdirectory 
is a good idea because it simplifies the process of looking for them. Instead 
of having a complex cache such as sycoca that knows about all the desktop 
files, we can embed the plugin metadata in them. It's what we do with most 
plugin systems in KDE in fact, and we've ported some this way. It's not the 
case for all such as kparts.
  
  Regarding pulling everything, I don't necessarily disagree, I already 
proposed it on D12172 . I do agree though 
that having some kind of control over what goes in can be useful, especially if 
we can include this information.
  
  In case you are curious, after building kf5 and okular (we are using 
kde-build-metadata information to bring dependencies which include kf5umbrella) 
these are the contents of the plugins folder:
  
/opt/kdeandroid-deps/plugins/kcm_webshortcuts.so
/opt/kdeandroid-deps/plugins/kauth/helper/kauth_helper_plugin.so
/opt/kdeandroid-deps/plugins/kcm_kio.so
/opt/kdeandroid-deps/plugins/okular/generators/okularGenerator_comicbook.so
/opt/kdeandroid-deps/plugins/okular/generators/okularGenerator_txt.so
/opt/kdeandroid-deps/plugins/okular/generators/okularGenerator_ooo.so
/opt/kdeandroid-deps/plugins/okular/generators/okularGenerator_dvi.so
/opt/kdeandroid-deps/plugins/okular/generators/okularGenerator_fb.so
/opt/kdeandroid-deps/plugins/okular/generators/okularGenerator_fax.so
/opt/kdeandroid-deps/plugins/okular/generators/okularGenerator_xps.so
/opt/kdeandroid-deps/plugins/krossmodulekdetranslation.so
/opt/kdeandroid-deps/plugins/krossmoduleforms.so
/opt/kdeandroid-deps/plugins/kf5/urifilters/localdomainurifilter.so
/opt/kdeandroid-deps/plugins/kf5/urifilters/kuriikwsfilter.so
/opt/kdeandroid-deps/plugins/kf5/urifilters/kurisearchfilter.so
/opt/kdeandroid-deps/plugins/kf5/urifilters/fixhosturifilter.so
/opt/kdeandroid-deps/plugins/kf5/urifilters/kshorturifilter.so
/opt/kdeandroid-deps/plugins/kf5/kirigami/org.kde.desktop.so
/opt/kdeandroid-deps/plugins/kf5/ktranscript.so
/opt/kdeandroid-deps/plugins/kf5/parts/katepart.so
/opt/kdeandroid-deps/plugins/kf5/kio/trash.so
/opt/kdeandroid-deps/plugins/kf5/kio/http.so
/opt/kdeandroid-deps/plugins/kf5/kio/ftp.so
/opt/kdeandroid-deps/plugins/kf5/kio/file.so
/opt/kdeandroid-deps/plugins/kf5/kio/remote.so
/opt/kdeandroid-deps/plugins/kf5/emoticonsthemes/kde.so
/opt/kdeandroid-deps/plugins/kf5/emoticonsthemes/xmpp.so
/opt/kdeandroid-deps/plugins/kf5/emoticonsthemes/adium.so
/opt/kdeandroid-deps/plugins/kf5/emoticonsthemes/pidgin.so
/opt/kdeandroid-deps/plugins/kf5/kded/kcookiejar.so
/opt/kdeandroid-deps/plugins/kf5/kded/remotenotifier.so

/opt/kdeandroid-deps/plugins/kf5/org.kde.kwindowsystem.platforms/KF5WindowSystemWaylandPlugin.so
/opt/kdeandroid-deps/plugins/kf5/kiod/kssld.so
/opt/kdeandroid-deps/plugins/kf5/kiod/kpasswdserver.so
/opt/kdeandroid-deps/plugins/kf5/kiod/kioexecd.so
/opt/kdeandroid-deps/plugins/kf5/KEmoticonsIntegrationPlugin.so
/opt/kdeandroid-deps/plugins/kf5/FrameworkIntegrationPlugin.so
/opt/kdeandroid-deps/plugins/kcm_trash.so
/opt/kdeandroid-deps/plugins/imageformats/kimg_ras.so
/opt/kdeandroid-deps/plugins/imageformats/kimg_psd.so
/opt/kdeandroid-deps/plugins/imageformats/kimg_kra.so
/opt/kdeandroid-deps/plugins/imageformats/kimg_xcf.so
/opt/kdeandroid-deps/plugins/imageformats/kimg_eps.so
/opt/kdeandroid-deps/plugins/imageformats/kimg_tga.so
/opt/kdeandroid-deps/plugins/imageformats/kimg_pcx.so
/opt/kdeandroid-deps/plugins/imageformats/kimg_ora.so
/opt/kdeandroid-deps/plugins/imageformats/kimg_rgb.so
/opt/kdeandroid-deps/plugins/imageformats/kimg_pic.so
/opt/kdeandroid-deps/plugins/krossqts.so
/opt/kdeandroid-deps/plugins/script/krossqtsplugin.so
/opt/kdeandroid-deps/plugins/okularpart.so
  
  So yes, it could be an over-kill. Maybe not.

REPOSITORY
  R306 KParts

REVISION DETAIL
  https://phabricator.kde.org/D12251

To: apol, #frameworks, vkrause, aacid
Cc: michaelh, bruns

D12328: Enable preview by default in the filepicker dialog

[Andres Betts]

abetts added a comment.


  What would it look like if it was enabled by default? Screenshot?

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D12328

To: anemeth, #frameworks, #vdg, rkflx
Cc: abetts, rkflx, ngraham, #frameworks, michaelh, bruns

D12328: Enable preview by default in the filepicker dialog

[Henrik Fehlauer]

rkflx requested changes to this revision.
rkflx added a comment.
This revision now requires changes to proceed.


  > This also enables it for users who previously disabled it.
  
  Hm, normally changing a default is allowed, while overriding custom user 
settings is discouraged. However, for a `bool` it does not make a difference, 
really ;)
  
  For KConfigXT settings, changing a default is easy, because defaults are not 
repeated in the config file, so it's enough to change the default in the code. 
Here, it's more complicated, as you had to change the name to get that effect.
  
  However, the old key should not stay around in the config file, it should be 
removed. We have `kconf_update` 
 for that. Could 
you provide or update such a script for `~/.config/kdeglobals`?

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D12328

To: anemeth, #frameworks, #vdg, rkflx
Cc: rkflx, ngraham, #frameworks, michaelh, bruns

D12321: Hide file preview when icon is too small

[Henrik Fehlauer]

rkflx requested changes to this revision.
rkflx added a comment.
This revision now requires changes to proceed.


  The relation between the Preview and the Zoom slider is now a bit weird: You 
can override with the button, but once you move the slider the setting will be 
gone again. Also, when showing the dialog after closing it, the slider has 
preference over the button. In addition, even though the button says "enabled", 
users will wonder why no thumbnails are showing!
  
  Would it make sense to both:
  
  - Set the button state to "off" once the icons are too small, to make it 
clear that no previews are to be expected.
  - Disable the button, so manually toggling thumbnails only works if icons are 
big enough.
  
  Allowing to override even for small images would quickly lead to some kind of 
manual vs. automatic setting, but this would be even more confusing, so I'd 
rather not go in that direction.
  
  ---
  
  Also, before this goes in I'd like to see a similar patch for Dolphin. Not so 
much because of any implemention issue, but to get the (not quite 
uncontroversial) idea more exposure and to agree on a common vision for how 
thumbnails should behave everywhere.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D12321

To: anemeth, #vdg, #frameworks, ngraham, rkflx
Cc: rkflx, ngraham, #frameworks, michaelh, bruns

D12077: Show view mode buttons in the open/save dialog's toolbar

[Scott Harvey]

sharvey added a comment.


  +1 for making things easier and prettier.

REPOSITORY
  R241 KIO

BRANCH
  arcpatch-D12077

REVISION DETAIL
  https://phabricator.kde.org/D12077

To: ngraham, #frameworks, rkflx, #vdg, abetts
Cc: sharvey, rkflx, mmustac, broulik, michaelh, bruns

D12333: Put the open/save dialog's toolbar above all other widgets, like Dolphin does

[Henrik Fehlauer]

rkflx added a comment.


  Please add a mockup of how your final vision of the dialog looks like after 
all changes in  T8552  are done, in 
particular "Move the File Name field to the top of the window" and any toolbar 
additions. Otherwise it's really hard to judge an individual change like this.
  
  Also, as more and more things are added to the places panel, it might get a 
bit too short in the end, requiring too much scrolling?
  
  Another point would be to research why it looks like it does today. After 
all, in KDE3 we already had something like you are proposing right now, so 
changing it back yet again should come with a good reason.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D12333

To: ngraham, #frameworks, #dolphin, #vdg
Cc: anemeth, rkflx, michaelh, bruns

D12333: Put the open/save dialog's toolbar above all other widgets, like Dolphin does

[Nathaniel Graham]

ngraham edited the test plan for this revision.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D12333

To: ngraham, #frameworks, #dolphin, #vdg
Cc: anemeth, rkflx, michaelh, bruns

D12333: Put the open/save dialog's toolbar above all other widgets, like Dolphin does

[Nathaniel Graham]

ngraham created this revision.
ngraham added reviewers: Frameworks, Dolphin, VDG.
Restricted Application added a project: Frameworks.
ngraham requested review of this revision.

REVISION SUMMARY
  This patch adopts Dolphin's location for the toolbar: above all other 
widgets. This improves consistency as well as freeing up precious horizontal 
space on the toolbar for additional items of betterm padding and sizing.

TEST PLAN
  [image goes here]

REPOSITORY
  R241 KIO

BRANCH
  toolbar-above-all-widgets (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D12333

AFFECTED FILES
  src/filewidgets/kfilewidget.cpp

To: ngraham, #frameworks, #dolphin, #vdg
Cc: anemeth, rkflx, michaelh, bruns

D11685: Implement single click on line number to select line of text

[Nathaniel Graham]

ngraham added a subscriber: dhaumann.
ngraham added a comment.


  @cullmann @dhaumann ping? I'm quite fond of this, myself.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D11685

To: rkron, #frameworks, #kate, #ktexteditor, ngraham, cullmann
Cc: dhaumann, rkron, mwolff, ngraham, #ktexteditor, #kate, #frameworks, 
michaelh, kevinapavew, bruns, demsking, cullmann, sars

D12311: Align lock icon with bold message text; reduce overall size of dialog

[Nathaniel Graham]

ngraham added a comment.


  In D12311#249270 , @sharvey wrote:
  
  > F5812033: Screenshot_20180418_161500.png 

  >  The good news is that it still behaves properly with a scaled display.
  >
  > The bad news is that, due to the `minimumSize` we configured for System 
Settings, I can't get back to the bottom of the Display KCM to reset my screen 
scale. Had to set `QT_SCALE_FACTOR=0.5` and launch `systemsettings5` directly. 
Never a dull moment!
  
  
  Ouch, that's pretty bad. Perhaps we should move the button up higher in the 
window so you'll always be able to reach it no matter what weird state you find 
yourself in.

REPOSITORY
  R121 Policykit (Polkit) KDE Agent

BRANCH
  align-lock-icon (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D12311

To: sharvey, davidedmundson, ngraham, abetts, #frameworks
Cc: broulik, davidedmundson, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D12311: Align lock icon with bold message text; reduce overall size of dialog

[Scott Harvey]

sharvey added a comment.


  F5812033: Screenshot_20180418_161500.png 

  The good news is that it still behaves properly with a scaled display.
  
  The bad news is that, due to the `minimumSize` we configured for System 
Settings, I can't get back to the bottom of the Display KCM to reset my screen 
scale. Had to set `QT_SCALE_FACTOR=0.5` and launch `systemsettings5` directly. 
Never a dull moment!

REPOSITORY
  R121 Policykit (Polkit) KDE Agent

BRANCH
  align-lock-icon (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D12311

To: sharvey, davidedmundson, ngraham, abetts, #frameworks
Cc: broulik, davidedmundson, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D12311: Align lock icon with bold message text; reduce overall size of dialog

[Nathaniel Graham]

ngraham added a comment.


  I think it would be worth it! It's definitely not a crown jewel of polished 
UI design, that's for sure.
  
  To test scaling, try setting a systemwide scale factor in System Settings > 
Display and Monitor > Displays > Scale Display, then logging out and back in, 
then doing it again,

REPOSITORY
  R121 Policykit (Polkit) KDE Agent

BRANCH
  align-lock-icon (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D12311

To: sharvey, davidedmundson, ngraham, abetts, #frameworks
Cc: broulik, davidedmundson, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D12311: Align lock icon with bold message text; reduce overall size of dialog

[Scott Harvey]

sharvey added a comment.


  F5812014: Screenshot_20180418_155156.png 

  The dialog seems immune to QT_SCALE_FACTOR=2.0 (because it's launched from a 
separate process?). I don't have a HiDPI display to test on.
  
  I tried different fonts up to 15pt and all is okay. I even tried the nasty 
Windows-style widgets and it's still okay.
  
  I agree the layout is kind of a mess. I can take a shot at reworking it if 
the reviewers think it's worth the effort.

REPOSITORY
  R121 Policykit (Polkit) KDE Agent

BRANCH
  align-lock-icon (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D12311

To: sharvey, davidedmundson, ngraham, abetts, #frameworks
Cc: broulik, davidedmundson, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D12108: ffmpegextractor: Silence deprecation warnings

[Matthieu Gallien]

mgallien accepted this revision.
mgallien added a comment.
This revision is now accepted and ready to land.


  Thanks.
  
  I did try to fix it some months ago but did not finished however I noticed 
that there is no automatic tests for it. Do you have time to work on some ?

REPOSITORY
  R286 KFileMetaData

BRANCH
  ffmpeg_deprecated (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D12108

To: michaelh, #baloo, #frameworks, mgallien
Cc: mgallien, bruns, ashaposhnikov, michaelh, astippich, spoorun

D12251: Integrate with androiddeployqt dependencies files

[Albert Astals Cid]

aacid added inline comments.

INLINE COMMENTS

> part.h:69
> + * This KPart will be exported as a plugin. It requires a desktop file that
> + * needs to be installed to be installed to ${KDE_INSTALL_KSERVICES5DIR} with
> + * its exposed interfaces (e.g. 
> X-KDE-ServiceTypes=KParts/ReadOnlyPart,KParts/ReadWritePart)

"to be installed to be installed " <-- dupe

> part.h:72
> + * and its plugin with the logic that we recommend installing to
> + * ${KDE_INSTALL_PLUGINDIR}/kf5/parts
> + *

I don't really see why we need a special path for parts.

I understand you're doing it to be able to just get everything from that folder 
and then put it on the apk

Now without knowing anything about cmake, wouldn't it make more sense put on 
the apk every single thing i'm installing?

I mean if i do

  add_library(okularpart SHARED ${okularpart_SRCS})
  install(TARGETS okularpart DESTINATION ${KDE_INSTALL_PLUGINDIR})

it's surely because i'm interesting in having okularpart in my apk, otherwise 
why would i spend precious time compiling and installing it?

REPOSITORY
  R306 KParts

REVISION DETAIL
  https://phabricator.kde.org/D12251

To: apol, #frameworks, vkrause, aacid
Cc: michaelh, bruns

D12156: implement reading of rating tag

[Matthieu Gallien]

mgallien requested changes to this revision.
This revision now requires changes to proceed.

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D12156

To: astippich, mgallien, michaelh
Cc: #frameworks, ashaposhnikov, michaelh, astippich, spoorun, bruns

D12156: implement reading of rating tag

[Matthieu Gallien]

mgallien added a comment.


  Thanks.
  Fix one issue and we should be good to go.
  Another nice thing is that we should have a portable way to have ratings in 
Elisa that could be read or write somewhere else.

INLINE COMMENTS

> taglibextractor.cpp:222-234
> +if (temp == 0) {
> +data.rating = 0;
> +} else if (temp >= 1 && temp <= 31) {
> +data.rating = 2;
> +} else if (temp >= 32 && temp <= 95) {
> +data.rating = 4;
> +} else if (temp >= 96 && temp <= 159) {

You can and should be using all intermediate values. If I remember correctly, 
in dolphin, you can set all values between 0 and 10. This is done by half blue 
stars.
Can you use modulo instead of embedded if ?

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D12156

To: astippich, mgallien, michaelh
Cc: #frameworks, ashaposhnikov, michaelh, astippich, spoorun, bruns

D12327: [WIP/open dependencies] Show Detailed Tree View by default

[Nathaniel Graham]

ngraham edited the summary of this revision.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D12327

To: ngraham
Cc: #frameworks, michaelh, bruns

D11489: Make concatenated strings wrappable

[Matthieu Gallien]

mgallien accepted this revision.
mgallien added a comment.
This revision is now accepted and ready to land.


  You could even push directly for this kind of changes.

REPOSITORY
  R286 KFileMetaData

BRANCH
  wrappable

REVISION DETAIL
  https://phabricator.kde.org/D11489

To: michaelh, mgallien, #baloo, #frameworks
Cc: ashaposhnikov, michaelh, astippich, spoorun, bruns

D12240: Save the dialog view settings when closing the dialog without hitting the cancel button

[Nathaniel Graham]

ngraham added a task: T8552: Polish Open/Save dialogs.

REPOSITORY
  R135 Integration for Qt applications in Plasma

REVISION DETAIL
  https://phabricator.kde.org/D12240

To: ngraham, #frameworks, davidedmundson
Cc: anthonyfieroni, elvisangelaccio, plasma-devel, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D12215: Add a "Reload" menu item to KDirOperator's context menu

[Nathaniel Graham]

ngraham added a task: T8552: Polish Open/Save dialogs.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D12215

To: ngraham, #frameworks
Cc: dhaumann, rkflx, michaelh, bruns

D12227: Save the dialog view settings even when canceling

[Nathaniel Graham]

ngraham added a task: T8552: Polish Open/Save dialogs.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D12227

To: ngraham, #frameworks, davidedmundson
Cc: michaelh, bruns

D11993: Tweak column widths in tree view of file open/save dialogs

[Nathaniel Graham]

ngraham added a task: T8552: Polish Open/Save dialogs.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D11993

To: sharvey, ngraham, dfaure, #frameworks, broulik
Cc: #dolphin, cfeck, fabiank, broulik, michaelh, bruns

D12077: Show view mode buttons in the open/save dialog's toolbar

[Nathaniel Graham]

ngraham added a task: T8552: Polish Open/Save dialogs.

REPOSITORY
  R241 KIO

BRANCH
  arcpatch-D12077

REVISION DETAIL
  https://phabricator.kde.org/D12077

To: ngraham, #frameworks, rkflx, #vdg, abetts
Cc: rkflx, mmustac, broulik, michaelh, bruns

D12306: Filepicker dialog proper grid icon layout

[Nathaniel Graham]

ngraham added a task: T8552: Polish Open/Save dialogs.

REPOSITORY
  R241 KIO

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D12306

To: anemeth, #frameworks, #vdg, ngraham
Cc: abetts, rkflx, ngraham, #frameworks, michaelh, bruns

D12328: Enable preview by default in the filepicker dialog

[Nathaniel Graham]

ngraham added a task: T8552: Polish Open/Save dialogs.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D12328

To: anemeth, #frameworks, #vdg
Cc: ngraham, #frameworks, michaelh, bruns

D12197: autotests: Test for multiple values

[Matthieu Gallien]

mgallien accepted this revision.
mgallien added a comment.
This revision is now accepted and ready to land.


  Sorry, that was a local problem.

REPOSITORY
  R286 KFileMetaData

BRANCH
  multi-value-test

REVISION DETAIL
  https://phabricator.kde.org/D12197

To: michaelh, #baloo, #frameworks, mgallien
Cc: bruns, ashaposhnikov, michaelh, astippich, spoorun

D12328: Enable preview by default in the filepicker dialog

[Nathaniel Graham]

ngraham edited the summary of this revision.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D12328

To: anemeth, #frameworks, #vdg
Cc: ngraham, #frameworks, michaelh, bruns

D12328: Enable preview by default in the filepicker dialog

[Nathaniel Graham]

ngraham added a dependent revision: D12326: [WIP/open dependencies] In Short 
View, display icons on top and increase icon size.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D12328

To: anemeth, #frameworks, #vdg
Cc: ngraham, #frameworks, michaelh, bruns

D12326: [WIP/open dependencies] In Short View, display icons on top and increase icon size

[Nathaniel Graham]

ngraham edited the summary of this revision.
ngraham added a dependency: D12328: Enable preview by default in the filepicker 
dialog.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D12326

To: ngraham
Cc: anemeth, #frameworks, michaelh, bruns

D12328: Enable preview by default in the filepicker dialog

[Alex Nemeth]

anemeth edited the summary of this revision.
anemeth edited the test plan for this revision.
anemeth added reviewers: Frameworks, VDG.
anemeth added a subscriber: ngraham.
anemeth added a dependency: D12321: Hide file preview when icon is too small.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D12328

To: anemeth, #frameworks, #vdg
Cc: ngraham, #frameworks, michaelh, bruns

D12321: Hide file preview when icon is too small

[Alex Nemeth]

anemeth added a dependent revision: D12328: Enable preview by default in the 
filepicker dialog.

REPOSITORY
  R241 KIO

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D12321

To: anemeth, #vdg, #frameworks, ngraham, rkflx
Cc: rkflx, ngraham, #frameworks, michaelh, bruns

D12197: autotests: Test for multiple values

[Matthieu Gallien]

mgallien requested changes to this revision.
mgallien added a comment.
This revision now requires changes to proceed.


  The test for mp3 is failing to complete. I am investigating.

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D12197

To: michaelh, #baloo, #frameworks, mgallien
Cc: bruns, ashaposhnikov, michaelh, astippich, spoorun

D12311: Align lock icon with bold message text; reduce overall size of dialog

[Kai Uwe Broulik]

broulik added a comment.


  I think there's something severly wrong with the dialog's size hints if we 
need to add arbitrary numbers all over the place. Can you make sure this 
doesn't break with
  
  - different font
  - larger font
  - screen scaling
  - different widget style
  - ...

REPOSITORY
  R121 Policykit (Polkit) KDE Agent

BRANCH
  align-lock-icon (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D12311

To: sharvey, davidedmundson, ngraham, abetts, #frameworks
Cc: broulik, davidedmundson, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D12328: Enable preview by default in the filepicker dialog

[Alex Nemeth]

anemeth created this revision.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
anemeth requested review of this revision.

REPOSITORY
  R241 KIO

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D12328

AFFECTED FILES
  src/filewidgets/kdiroperator.cpp

To: anemeth
Cc: #frameworks, michaelh, bruns

D12327: [WIP/open dependencies] Show Detailed Tree View by default

[Nathaniel Graham]

ngraham edited the test plan for this revision.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D12327

To: ngraham
Cc: #frameworks, michaelh, bruns

D12327: [WIP/open dependencies] Show Detailed Tree View by default

[Nathaniel Graham]

ngraham edited the summary of this revision.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D12327

To: ngraham
Cc: #frameworks, michaelh, bruns

D12327: [WIP/open dependencies] Show Detailed Tree View by default

[Nathaniel Graham]

ngraham added a task: T8552: Polish Open/Save dialogs.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D12327

To: ngraham
Cc: #frameworks, michaelh, bruns

D12327: [WIP/open dependencies] Show Detailed Tree View by default

[Nathaniel Graham]

ngraham created this revision.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
ngraham requested review of this revision.

REVISION SUMMARY
  Show Detailed Tree View by default in KDirOperator. This primarily affects 
the file open/save dialogs, because other clients generally set their preferred 
view mode manually.
  
  This change will result in Open & Save dialogs displaying Detailed Tree View 
by default instead of Simple View (which is being transformed into a primarily 
visual view mode; see T8552: Polish Open/Save dialogs 
). Detailed Tree View is better for content 
that is best located by its filename or metadata, which I would wager is more 
common. Also, bandwagon argument: Windows and GNOME both display the same view 
by default in their open/save dialogs now (macOS displays the 
navigation-friendly {Column View} by default, which sadly lacks a KDE 
equivalent).

TEST PLAN
  Tested in a new user account and opened an Open dialog from Kate:
  
  Checked lxr to make sure that all clients specify a non-default view mode. 
Some need patching; those patches will be mentioned here:

REPOSITORY
  R241 KIO

BRANCH
  detailed-tree-view-by-default (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D12327

AFFECTED FILES
  src/filewidgets/kdiroperator.cpp

To: ngraham
Cc: #frameworks, michaelh, bruns

D12326: [WIP/open dependencies] In Short View, display icons on top and increase icon size

[Nathaniel Graham]

ngraham added inline comments.

INLINE COMMENTS

> anemeth wrote in kdiroperator.cpp:2605
> What is the relation between 43 and 64px?
> Does this hardcoded number also work when scaled?

The number is a 0-100 scale, with 0 corresponding to 16px, and 100 
corresponding to 128px, and all other numbers corresponding to in-between sized 
along that same linear scale. It's a bit odd, and not the way I would have 
implemented it, but that's what we've got, so I decided to work with it and 
just add comments to improve the comprehensibility.

And yeah, it works fine with a HiDPI scale factor.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D12326

To: ngraham
Cc: anemeth, #frameworks, michaelh, bruns

D10694: epubextractor: Handle multiple subjects better

[Matthieu Gallien]

mgallien accepted this revision.
mgallien added a comment.
This revision is now accepted and ready to land.


  Thanks

REPOSITORY
  R286 KFileMetaData

BRANCH
  multi-subject

REVISION DETAIL
  https://phabricator.kde.org/D10694

To: michaelh, mgallien, dfaure
Cc: bruns, astippich, #frameworks, ashaposhnikov, michaelh, spoorun, 
navarromorales, isidorov, firef, andrebarros, emmanuelp

D12197: autotests: Test for multiple values

[Matthieu Gallien]

mgallien accepted this revision.
mgallien added a comment.
This revision is now accepted and ready to land.


  Thanks

REPOSITORY
  R286 KFileMetaData

BRANCH
  multi-value-test

REVISION DETAIL
  https://phabricator.kde.org/D12197

To: michaelh, #baloo, #frameworks, mgallien
Cc: bruns, ashaposhnikov, michaelh, astippich, spoorun

D12326: [WIP/open dependencies] In Short View, display icons on top and increase icon size

[Alex Nemeth]

anemeth added inline comments.

INLINE COMMENTS

> kdiroperator.cpp:2605
> +// "43" Corresponds to a default size of 64px
> +return configGroup->readEntry("listViewIconSize", 43);
>  } else {

What is the relation between 43 and 64px?
Does this hardcoded number also work when scaled?

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D12326

To: ngraham
Cc: anemeth, #frameworks, michaelh, bruns

D12326: [WIP/open dependencies] In Short View, display icons on top and increase icon size

[Nathaniel Graham]

ngraham edited the summary of this revision.
ngraham added a dependency: D12306: Filepicker dialog proper grid icon layout.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D12326

To: ngraham
Cc: #frameworks, michaelh, bruns

D12306: Filepicker dialog proper grid icon layout

[Nathaniel Graham]

ngraham added a dependent revision: D12326: [WIP/open dependencies] In Short 
View, display icons on top and increase icon size.

REPOSITORY
  R241 KIO

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D12306

To: anemeth, #frameworks, #vdg, ngraham
Cc: abetts, rkflx, ngraham, #frameworks, michaelh, bruns

D12326: [WIP/open dependencies] In Short View, display icons on top and increase icon size

[Nathaniel Graham]

ngraham added a task: T8552: Polish Open/Save dialogs.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D12326

To: ngraham
Cc: #frameworks, michaelh, bruns

D12326: [WIP/open dependencies] In Short View, display icons on top and increase icon size

[Nathaniel Graham]

ngraham created this revision.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
ngraham requested review of this revision.

REVISION SUMMARY
  This patch increases the default size of the icons in Short View to 64px, to 
facilitate using them along with previews to see the content of predominately 
visual files. This patch makes Short View usable by default as the preferred 
mode for finding visual content.
  
  For content that is best found via filename or metadata, or for long lists, 
Detailed Tree View is a better view, and D12077: Show view mode buttons in the 
open/save dialog's toolbar  makes it easy 
to switch.
  
  This patch has many prerequisites before it makes sense:
  
  - D12306: Filepicker dialog proper grid icon layout 

  - [turn previews on by default]
  - [Make all KDirOperator clients set a non-default view mode]

TEST PLAN
  [video will go here]

REPOSITORY
  R241 KIO

BRANCH
  short-view-has-icons-on-top-by-default (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D12326

AFFECTED FILES
  src/filewidgets/kdiroperator.cpp

To: ngraham
Cc: #frameworks, michaelh, bruns

D12321: Hide file preview when icon is too small

[Nathaniel Graham]

ngraham added a comment.


  (BTW the visible flickering when you resize the icons using the slider is a 
pre-existing issue. We should fix that though. Something else to add to the 
workboard...)

REPOSITORY
  R241 KIO

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D12321

To: anemeth, #vdg, #frameworks, ngraham, rkflx
Cc: rkflx, ngraham, #frameworks, michaelh, bruns

D12321: Hide file preview when icon is too small

[Nathaniel Graham]

ngraham added a task: T8552: Polish Open/Save dialogs.

REPOSITORY
  R241 KIO

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D12321

To: anemeth, #vdg, #frameworks, ngraham, rkflx
Cc: rkflx, ngraham, #frameworks, michaelh, bruns

D12321: Hide file preview when icon is too small

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a reviewer: rkflx.
ngraham added a subscriber: rkflx.
ngraham added a comment.
This revision is now accepted and ready to land.


  Very nice, works great for me. Once this goes in, I think we can safely turn 
on previews by default, because we won't regress anything for people who prefer 
small icons who don't need (and probably don't like) previews. Adding @rkflx as 
a reviewer since I know he feels strongly about previews. :)
  
  In fact, we should really do this for Dolphin too, as currently previews are 
on by default but uselessly apply to tiny icons just like in the file dialogs 
before this patch. Wanna have a crack at that?

REPOSITORY
  R241 KIO

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D12321

To: anemeth, #vdg, #frameworks, ngraham, rkflx
Cc: rkflx, ngraham, #frameworks, michaelh, bruns

D12306: Filepicker dialog proper grid icon layout

[Nathaniel Graham]

ngraham accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R241 KIO

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D12306

To: anemeth, #frameworks, #vdg, ngraham
Cc: abetts, rkflx, ngraham, #frameworks, michaelh, bruns

D12306: Filepicker dialog proper grid icon layout

[Alex Nemeth]

anemeth added inline comments.

INLINE COMMENTS

> ngraham wrote in kdiroperator.cpp:2253
> Why is this needed?

Without this the icon grid gets only updated when the zoom slider is moved, and 
it needs to get updated when the window is resized as well.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D12306

To: anemeth, #frameworks, #vdg
Cc: abetts, rkflx, ngraham, #frameworks, michaelh, bruns

D12306: Filepicker dialog proper grid icon layout

[Nathaniel Graham]

ngraham added a comment.


  This is great! Much better than my patch. I tested it six ways to Sunday and 
couldn't break it. One comment:

INLINE COMMENTS

> kdiroperator.cpp:2253
> +
> +d->updateListViewGrid();
>  }

Why is this needed?

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D12306

To: anemeth, #frameworks, #vdg
Cc: abetts, rkflx, ngraham, #frameworks, michaelh, bruns

D12311: Align lock icon with bold message text; reduce overall size of dialog

[Nathaniel Graham]

ngraham added a reviewer: Frameworks.
ngraham accepted this revision.
ngraham added a comment.


  Much better! I'd still prefer less whitespace, but this is already an 
improvement. But now that I'm staring at this dialog over and over again, I'm 
wondering if we even need the non-bold caption text at all. It just repeats the 
bold text in a slightly more awkward and more wordy fashion. What do you think?

REPOSITORY
  R121 Policykit (Polkit) KDE Agent

BRANCH
  align-lock-icon (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D12311

To: sharvey, davidedmundson, ngraham, abetts, #frameworks
Cc: davidedmundson, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D12321: Hide file preview when icon is too small

[Alex Nemeth]

anemeth updated this revision to Diff 32500.
anemeth added a comment.


  Apply to all type of views

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D12321?vs=32495&id=32500

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D12321

AFFECTED FILES
  src/filewidgets/kdiroperator.cpp

To: anemeth, #vdg, #frameworks
Cc: ngraham, #frameworks, michaelh, bruns

D12321: Hide file preview when icon is too small

[Alex Nemeth]

anemeth edited the summary of this revision.
anemeth edited the test plan for this revision.
anemeth added reviewers: VDG, Frameworks.
anemeth added a subscriber: ngraham.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D12321

To: anemeth, #vdg, #frameworks
Cc: ngraham, #frameworks, michaelh, bruns

D12321: Hide file preview when icon is too small

[Alex Nemeth]

anemeth updated this revision to Diff 32495.
anemeth added a comment.


  Remove accidental white space

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D12321?vs=32494&id=32495

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D12321

AFFECTED FILES
  src/filewidgets/kdiroperator.cpp

To: anemeth
Cc: #frameworks, michaelh, bruns

D12321: Hide file preview when icon is too small

[Alex Nemeth]

anemeth created this revision.
anemeth added a project: Frameworks.
anemeth requested review of this revision.

REVISION SUMMARY
  file preview

REPOSITORY
  R241 KIO

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D12321

AFFECTED FILES
  src/filewidgets/kdiroperator.cpp

To: anemeth
Cc: #frameworks, michaelh, bruns

D12320: add ability to read embedded cover files

[Alexander Stippich]

astippich added a comment.


  This revision is only one possibility and is mainly there to start the 
discussion again on how to read the embedded picture data from e.g. audio 
files. Before this can land, Baloo has to be patched in order to cope with 
binary data.
  I think for Baloo there are two possibilities: (a) Put it in the database 
same as all other data or (b) ignore the binary data. In the latter case, 
applications would have to query the metadata separately in order to get the 
cover.
  For KFileMetaData I also see two possible implementation: Either in the 
taglibextractor, or in a completely new extractor that only reads the cover 
files (may be also useful for ebooks, but I don't know if such things exist 
there). If we agree on (a), I would opt to implement it in taglibextractor, if 
we chose (b) I think a new extractor makes sense such that applications would 
not have to read all the metadata again with the taglibextractor, but could 
specifically just read the picture data and get the rest from Baloo.
  
  Any other suggestions? Opinions?

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D12320

To: astippich, mgallien, michaelh
Cc: #frameworks, ashaposhnikov, michaelh, astippich, spoorun, bruns

D12320: add ability to read embedded cover files

[Alexander Stippich]

astippich created this revision.
astippich added reviewers: mgallien, michaelh.
Restricted Application added projects: Frameworks, Baloo.
Restricted Application added a subscriber: Frameworks.
astippich requested review of this revision.

REVISION SUMMARY
  read the embedded image of audio files as binary data

REPOSITORY
  R286 KFileMetaData

BRANCH
  cover

REVISION DETAIL
  https://phabricator.kde.org/D12320

AFFECTED FILES
  autotests/samplefiles/no-meta/test.m4a
  autotests/taglibextractortest.cpp
  src/extractors/taglibextractor.cpp
  src/extractors/taglibextractor.h
  src/properties.h
  src/propertyinfo.cpp

To: astippich, mgallien, michaelh
Cc: #frameworks, ashaposhnikov, michaelh, astippich, spoorun, bruns

D12306: Filepicker dialog proper grid icon layout

[Alex Nemeth]

anemeth added a comment.


  F5811818: a1.PNG 

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D12306

To: anemeth, #frameworks, #vdg
Cc: abetts, rkflx, ngraham, #frameworks, michaelh, bruns

D12306: Filepicker dialog proper grid icon layout

[Alex Nemeth]

anemeth updated this revision to Diff 32488.
anemeth added a comment.


  Reduced vertical spacing.

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D12306?vs=32472&id=32488

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D12306

AFFECTED FILES
  src/filewidgets/kdiroperator.cpp

To: anemeth, #frameworks, #vdg
Cc: abetts, rkflx, ngraham, #frameworks, michaelh, bruns

D12283: Allow to load dictionaries form a rcc

[Laurent Montel]

mlaurent added inline comments.

INLINE COMMENTS

> hunspelldict.cpp:104
>  delete m_speller;
> +if (m_tempDir) {
> +delete m_tempDir;

not necessary to check pointer here.

REPOSITORY
  R246 Sonnet

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D12283

To: vonreth, mlaurent
Cc: #frameworks, michaelh, bruns

D12306: Filepicker dialog proper grid icon layout

[Nathaniel Graham]

ngraham added a comment.


  In D12306#248869 , @abetts wrote:
  
  > I also vote for a little more vertical spacing. Maybe in similar ways to 
what Marco Martin did recently for spacing in System Settings.
  
  
  Did you mean a little less? @rkflx is objecting that the vertical spacing is 
too //high// in this patch compared to mine. I rather agree, and think that 2 
rows for the filename is just fine--especially for reasonable icon sizes 
(icons-on-top mode is only really useful with large icons and previews enabled).

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D12306

To: anemeth, #frameworks, #vdg
Cc: abetts, rkflx, ngraham, #frameworks, michaelh, bruns

D12306: Filepicker dialog proper grid icon layout

[Andres Betts]

abetts added a comment.


  I also vote for a little more vertical spacing. Maybe in similar ways to what 
Marco Martin did recently for spacing in System Settings.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D12306

To: anemeth, #frameworks, #vdg
Cc: abetts, rkflx, ngraham, #frameworks, michaelh, bruns

D12306: Filepicker dialog proper grid icon layout

[Nathaniel Graham]

ngraham edited the summary of this revision.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D12306

To: anemeth, #frameworks, #vdg
Cc: rkflx, ngraham, #frameworks, michaelh, bruns

D12306: Filepicker dialog proper grid icon layout

[Henrik Fehlauer]

rkflx added a comment.


  Cool! Can you also tweak the vertical spacing a bit? Currently Nate displays 
2 rows of text (left), while your patch shows 3 (right), resulting in fewer 
items visible at once. Of course the best course of action would be to make 
this adapt dynamically to the filename like in Dolphin, but if that is too 
complicated for now, I think we should go with 2 rows, because that seems to 
fit most situations:
  
  F5811757: KIO-vertical-spacing.png 
  
  ---
  
  One more thing:
  
  In D10672#209864 , @rkflx wrote:
  
  > Do you plan to submit more patches to KDE in the coming months?
  
  
  
  
  In D10672#209876 , @anemeth wrote:
  
  > @rkflx I'm not sure...
  
  
  I think you should definitely think about applying for a developer account 
 ;)

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D12306

To: anemeth, #frameworks, #vdg
Cc: rkflx, ngraham, #frameworks, michaelh, bruns

D12149: Improve grid spacing in icons-on-top mode for open/save dialogs

[Nathaniel Graham]

ngraham abandoned this revision.
ngraham added a subscriber: anemeth.
ngraham added a comment.


  Abandoning this revision in favor of the superior one that @anemeth 
submitted: D12306 

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D12149

To: ngraham, #frameworks, #vdg, rkflx, abetts
Cc: anemeth, abetts, cfeck, alexeymin, michaelh, bruns

D12077: Show view mode buttons in the open/save dialog's toolbar

[Nathaniel Graham]

ngraham added a comment.


  Ping. Any objections from #frameworks 
 people?

REPOSITORY
  R241 KIO

BRANCH
  arcpatch-D12077

REVISION DETAIL
  https://phabricator.kde.org/D12077

To: ngraham, #frameworks, rkflx, #vdg, abetts
Cc: rkflx, mmustac, broulik, michaelh, bruns

D12306: Filepicker dialog proper grid icon layout

[Alex Nemeth]

anemeth added a comment.


  F5811675: tiny_icons.webm 

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D12306

To: anemeth, #frameworks, #vdg
Cc: rkflx, ngraham, #frameworks, michaelh, bruns

D12306: Filepicker dialog proper grid icon layout

[Alex Nemeth]

anemeth updated this revision to Diff 32472.
anemeth added a comment.


  Fixed icon spacing when icons are small.

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D12306?vs=32470&id=32472

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D12306

AFFECTED FILES
  src/filewidgets/kdiroperator.cpp

To: anemeth, #frameworks, #vdg
Cc: rkflx, ngraham, #frameworks, michaelh, bruns

D12306: Filepicker dialog proper grid icon layout

[Alex Nemeth]

anemeth marked 2 inline comments as done.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D12306

To: anemeth, #frameworks, #vdg
Cc: rkflx, ngraham, #frameworks, michaelh, bruns