D22617: Add icons for pagelayout options, as needed in Okular

[Noah Davis]

ndavis requested changes to this revision.
ndavis added a comment.
This revision now requires changes to proceed.


  Nice work!
  
  I know a lot of monochrome icons currently use the bottom right position for 
the folded corner, but I think we should start using the top right. The bottom 
right clashes with our convention of putting additional symbols in the bottom 
right and all of our color icons use the top right for the corner fold.
  
  There are some additional changes I would like to see.
  
  Naming scheme:
  Since this is changing the view, the naming scheme should be something like 
`view-pages-*` rather than `pagelayout-*`
  
  `pagelayout-single`: 
  This should be a symlink to `snap-page.svg` since they're the same icon.
  
  `pagelayout-facing`:
  The 16px version is good, but the larger versions don't use up enough of the 
available canvas. In general, aim to use 100% of the allowed vertical space 
(16px in height with 3px top/bottom margins for 22px) unless that would force 
you to squish the symbols in an unattractive way.
  
  `pagelayout-facing-first-centered`: 
  The top page should be centered to reflect how the view mode works. I think 
the top page shouldn't be cut off, but that means you'll need to shrink the 
size of the pages overall. This will be particularly difficult for the 16px 
version. If you can't get the 16px version to look right with a 2px margin on 
the top and bottom, I'll accept it with a 1px margin even though that goes 
against the HIG.
  
  `pagelayout-overview`: 
  It should represent pages laid out in a 2x2 grid rather than a stack since 
Overview mode has a grid layout.
  
  ---
  
  I don't think it's necessary to do 24px versions of these icons, but there's 
no harm in doing them. It's just more work.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D22617

To: davidhurka, #vdg, ndavis
Cc: #okular, kde-frameworks-devel, ngraham, LeGast00n, sbergeron, michaelh, 
bruns

D22105: Fix SFTP Plugin of KIO for Windows

[Piyush Aggarwal]

brute4s99 retitled this revision from "WIP : Fix SFTP Plugin of KIO for 
Windows" to "Fix SFTP Plugin of KIO for Windows".

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D22105

To: brute4s99, albertvaka, vonreth, sredman, sitter, dfaure
Cc: pino, andriusr, kde-frameworks-devel, kfm-devel, aprcela, fprice, 
LeGast00n, sbergeron, fbampaloukas, alexde, feverfew, meven, michaelh, spoorun, 
navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp, mikesomov

D22105: WIP : Fix SFTP Plugin of KIO for Windows

[Piyush Aggarwal]

brute4s99 marked 2 inline comments as done.
brute4s99 added a comment.


  I'll not leave it like this from next time, that's for sure. :p

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D22105

To: brute4s99, albertvaka, vonreth, sredman, sitter, dfaure
Cc: pino, andriusr, kde-frameworks-devel, kfm-devel, aprcela, fprice, 
LeGast00n, sbergeron, fbampaloukas, alexde, feverfew, meven, michaelh, spoorun, 
navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp, mikesomov

D22105: Fix SFTP Plugin of KIO for Windows

[Piyush Aggarwal]

brute4s99 added a comment.


  :p

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D22105

To: brute4s99, albertvaka, vonreth, sredman, sitter, dfaure
Cc: pino, andriusr, kde-frameworks-devel, kfm-devel, aprcela, fprice, 
LeGast00n, sbergeron, fbampaloukas, alexde, feverfew, meven, michaelh, spoorun, 
navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp, mikesomov

D22105: WIP : Fix SFTP Plugin of KIO for Windows

[David Faure]

dfaure added a comment.


  Indeed. I assumed it wasn't in your actual commit log (bad idea, for this 
exact reason). Phabricator often shows outdated descriptions compared to the 
commit log (unless people use `arc diff --verbatim`) so I stopped complaining 
about the description Clearly I should have done it anyway :)

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D22105

To: brute4s99, albertvaka, vonreth, sredman, sitter, dfaure
Cc: pino, andriusr, kde-frameworks-devel, kfm-devel, aprcela, fprice, 
LeGast00n, sbergeron, fbampaloukas, alexde, feverfew, meven, michaelh, spoorun, 
navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp, mikesomov

D22105: WIP : Fix SFTP Plugin of KIO for Windows

[Piyush Aggarwal]

This revision was automatically updated to reflect the committed changes.
Closed by commit R320:d6d724b9d4b9: WIP : Fix SFTP Plugin of KIO for Windows 
(authored by brute4s99).

REPOSITORY
  R320 KIO Extras

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22105?vs=62254=62255

REVISION DETAIL
  https://phabricator.kde.org/D22105

AFFECTED FILES
  CMakeLists.txt
  sftp/CMakeLists.txt
  sftp/kio_sftp.cpp

To: brute4s99, albertvaka, vonreth, sredman, sitter, dfaure
Cc: pino, andriusr, kde-frameworks-devel, kfm-devel, aprcela, fprice, 
LeGast00n, sbergeron, fbampaloukas, alexde, feverfew, meven, michaelh, spoorun, 
navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp, mikesomov

D22105: WIP : Fix SFTP Plugin of KIO for Windows

[Piyush Aggarwal]

brute4s99 added a comment.


  should've removed WIP before landing 

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D22105

To: brute4s99, albertvaka, vonreth, sredman, sitter, dfaure
Cc: pino, andriusr, kde-frameworks-devel, kfm-devel, aprcela, fprice, 
LeGast00n, sbergeron, fbampaloukas, alexde, feverfew, meven, michaelh, spoorun, 
navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp, mikesomov

D22105: WIP : Fix SFTP Plugin of KIO for Windows

[Piyush Aggarwal]

brute4s99 added a comment.


  yeah I can push! I'm a GSoCer lol

REPOSITORY
  R320 KIO Extras

BRANCH
  arcpatch-D22105

REVISION DETAIL
  https://phabricator.kde.org/D22105

To: brute4s99, albertvaka, vonreth, sredman, sitter, dfaure
Cc: pino, andriusr, kde-frameworks-devel, kfm-devel, aprcela, fprice, 
LeGast00n, sbergeron, fbampaloukas, alexde, feverfew, meven, michaelh, spoorun, 
navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp, mikesomov

D22105: WIP : Fix SFTP Plugin of KIO for Windows

[David Faure]

dfaure accepted this revision.
dfaure added a comment.
This revision is now accepted and ready to land.


  Thanks for your persistence :-)
  
  Do you have commit access? Otherwise can I have your name and email, for the 
git author information?

REPOSITORY
  R320 KIO Extras

BRANCH
  arcpatch-D22105

REVISION DETAIL
  https://phabricator.kde.org/D22105

To: brute4s99, albertvaka, vonreth, sredman, sitter, dfaure
Cc: pino, andriusr, kde-frameworks-devel, kfm-devel, aprcela, fprice, 
LeGast00n, sbergeron, fbampaloukas, alexde, feverfew, meven, michaelh, spoorun, 
navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp, mikesomov

D22105: WIP : Fix SFTP Plugin of KIO for Windows

[Piyush Aggarwal]

brute4s99 marked an inline comment as done.

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D22105

To: brute4s99, albertvaka, vonreth, sredman, sitter, dfaure
Cc: pino, andriusr, kde-frameworks-devel, kfm-devel, aprcela, fprice, 
LeGast00n, sbergeron, fbampaloukas, alexde, feverfew, meven, michaelh, spoorun, 
navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp, mikesomov

D22105: WIP : Fix SFTP Plugin of KIO for Windows

[Piyush Aggarwal]

brute4s99 updated this revision to Diff 62254.
brute4s99 marked an inline comment as done.
brute4s99 added a comment.


  updated!

REPOSITORY
  R320 KIO Extras

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22105?vs=62237=62254

BRANCH
  arcpatch-D22105

REVISION DETAIL
  https://phabricator.kde.org/D22105

AFFECTED FILES
  CMakeLists.txt
  sftp/CMakeLists.txt
  sftp/kio_sftp.cpp

To: brute4s99, albertvaka, vonreth, sredman, sitter, dfaure
Cc: pino, andriusr, kde-frameworks-devel, kfm-devel, aprcela, fprice, 
LeGast00n, sbergeron, fbampaloukas, alexde, feverfew, meven, michaelh, spoorun, 
navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp, mikesomov

D22105: WIP : Fix SFTP Plugin of KIO for Windows

[David Faure]

dfaure requested changes to this revision.
dfaure added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> kio_sftp.cpp:2028
>  }
> -else if (QT_STAT( QFile::encodeName(sPart),  ) == 0) { // 
> should a very small ".part" be deleted?
> +else if (partFile.exists()) { // should a very small ".part" be 
> deleted?
>  const int size = config()->readEntry("MinimumKeepSize", 
> DEFAULT_MINIMUM_KEEP_SIZE);

Better not do refresh on success, it slows things down for no purpose.

  else {
  partFile.refresh();
  const int size = ...;
  if (partFile.exists() && partFile.size() < size) {
  partFile.remove();
  }
  }

> kio_sftp.cpp:2045
> +}
> +else {
> +receivedFile.setFileTime(dt, 
> QFileDevice::FileModificationTime);

coding style: join with previous line

  } else {

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D22105

To: brute4s99, albertvaka, vonreth, sredman, sitter, dfaure
Cc: pino, andriusr, kde-frameworks-devel, kfm-devel, aprcela, fprice, 
LeGast00n, sbergeron, fbampaloukas, alexde, feverfew, meven, michaelh, spoorun, 
navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp, mikesomov

D22617: Add icons for pagelayout options, as needed in Okular

[Nathaniel Graham]

ngraham added a reviewer: ndavis.
ngraham added a comment.


  The 16px version is used in menus. The 22px version is used in toolbar 
buttons. 24px is unnecessary; it's only used by some 3rd-party apps I think. 
The ones that are already in there at that size are legacy and maybe we should 
just delete them? 32px is used for category icons and should be colorized. In 
general there isn't a reason to create monochrome 24x or 32px icons (and the 
few places where we are actually using 32px monochrome icons should be changed 
IMO; see T10165 ). When in doubt, if it's a 
monochrome action icon, you can safely make 16px and 22px versions and call it 
a day.
  
  This definitely needs some cleanup in the documentation, for sure.
  
  In terms of the icons themselves, they look good! I have a visual change 
request though: could you put the page curl on the top rather than on the 
bottom. That's the general style that most Breeze document icons use, and it 
would be good to use that. Basically just vertically flipping the icons should 
be sufficient.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D22617

To: davidhurka, #vdg, ndavis
Cc: #okular, kde-frameworks-devel, ngraham, LeGast00n, sbergeron, michaelh, 
bruns

D22609: Add spacers as a customization option for toolbars

[Nathaniel Graham]

ngraham added a comment.


  +1 for adding both a fixed-width spacer as well as an expanding spacer.

REPOSITORY
  R263 KXmlGui

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D22609

To: felixernst, dfaure
Cc: ngraham, #vdg, dfaure, kde-frameworks-devel, LeGast00n, sbergeron, 
michaelh, bruns

D20078: RFC fix race on kcrash auto-restarts

[David Edmundson]

davidedmundson added a comment.


  ++
  
  Needs some cleanup, but the logic is all sound.

REPOSITORY
  R271 KDBusAddons

REVISION DETAIL
  https://phabricator.kde.org/D20078

To: sitter
Cc: davidedmundson, broulik, kde-frameworks-devel, LeGast00n, sbergeron, 
michaelh, ngraham, bruns

D14631: Adds a new RenameDialog to KIO with more options for batch renaming

[David Faure]

dfaure added a comment.


  In D14631#499600 , @emateli wrote:
  
  > More or less but they don't have to be in the same directory. Think of it 
as a sequence of `KIO::moveAs` operations. Any N files can be moved anywhere.
  
  
  Right.
  
  >> I could imagine a KIO::moveAs that takes two QList and then this 
information is fetched from there rather than using m_dest.
  >>  In fact, if the existing moveAs() method is ported to call the two-QLists 
one, that will mean less special casing in the code (which wouldn't use m_dest 
anymore in slotResultStating, when m_asMethod).
  > 
  > The two list version could work, but I was thinking of one 
`QList` that contains src and dest names. Looks less error prone 
IMO.
  
  Yes, or that. Might be more tedious to fill in, I don't know. It's ok with me 
in any case.
  
  > I was thinking of implementing this as a new subclass of Job where it will 
create the new Job and add a subjob for each of the files to be moved.
  
  Like all composite jobs, yes.
  
  This is less efficient, though, in the case where the dest dir is the same 
for 500 files because EACH moveAs will :
  
  - stat() the dest dir
  - check for enough free space at destination
  
  whereas this could be done only if the dest dir is different from the 
previous one.
  
  Also, user interaction like "skip all" or "overwrite all" won't be possible, 
because that's within a single CopyJob. If you start 500 copyjobs, this 
information won't be shared.
  
  > overloading will not break binary compatibility
  
  That's correct, it doesn't.
  It just has to be non-ambiguous for existing code, but that's fine for the 
current proposals.
  
  > then this can be an overloaded `KIO::moveAs(QList)`
  
  If that doesn't return a CopyJob like the other moveAs method, it'll be a bit 
confusing in itself IMHO.
  
  > It also has to remain as a single job so that it can be undone in one go 
instead of undoing for each item that was renamed.
  
  Yes, that part is clear and agreed upon.
  
  >   auto items = {
  >   KioRenameItem{QUrl("~/a.doc"), QUrl("~/Documents/a.doc")},
  >   KioRenameItem{QUrl("~/dir/file"), QUrl("~/Documents/file-2019")},
  >   };
  
  QUrl doesn't support ~ and needs fromLocalFile() when built from local paths, 
but I get the idea :-)
  
  Maybe the struct could be named KIO::MoveItem ?
  Generally we call it renaming when it's in the same directory and moving for 
the general case (same or different directory).
  
  > The option of adapting move to accept a list of dest also involves 
modifying CopyJobPrivate's dest which will lead to a larger refactoring needed 
than the proposal below, right?
  
  CopyJobPrivate's m_dest already changes over time (when copying dirs it has 
to recurse into subdirs at dest). Only m_globalDest is currently fixed, and 
would have to change over time now.
  And when it changes, we need to go back to state DEST_NOT_STATED and the 
"Stat the dest" code, to stat the new dest (to check that it exists and is a 
dir, check for free space).
  
  IMHO it's not a question of which is the bigger amount of work, but which one 
will work better. Support for "Overwrite all" requires that this is done within 
CopyJob.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D14631

To: emateli, #frameworks, dfaure, mlaurent
Cc: anthonyfieroni, chinmoyr, mlaurent, asensi, rkflx, dfaure, aacid, ngraham, 
kde-frameworks-devel, LeGast00n, sbergeron, michaelh, bruns

D22105: WIP : Fix SFTP Plugin of KIO for Windows

[Piyush Aggarwal]

brute4s99 edited the summary of this revision.

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D22105

To: brute4s99, albertvaka, vonreth, sredman, sitter, dfaure
Cc: pino, andriusr, kde-frameworks-devel, kfm-devel, aprcela, fprice, 
LeGast00n, sbergeron, fbampaloukas, alexde, feverfew, meven, michaelh, spoorun, 
navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp, mikesomov

D22105: WIP : Fix SFTP Plugin of KIO for Windows

[Piyush Aggarwal]

brute4s99 updated this revision to Diff 62237.
brute4s99 marked 3 inline comments as done.
brute4s99 added a comment.


  updated

REPOSITORY
  R320 KIO Extras

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22105?vs=62187=62237

BRANCH
  arcpatch-D22105

REVISION DETAIL
  https://phabricator.kde.org/D22105

AFFECTED FILES
  CMakeLists.txt
  sftp/CMakeLists.txt
  sftp/kio_sftp.cpp

To: brute4s99, albertvaka, vonreth, sredman, sitter, dfaure
Cc: pino, andriusr, kde-frameworks-devel, kfm-devel, aprcela, fprice, 
LeGast00n, sbergeron, fbampaloukas, alexde, feverfew, meven, michaelh, spoorun, 
navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp, mikesomov

D14631: Adds a new RenameDialog to KIO with more options for batch renaming

[Emirald Mateli]

emateli added a comment.


  In D14631#499038 , @dfaure wrote:
  
  > KIO::move (implemented by CopyJob) can move N files to a single destination 
directory, but they get the same name at that dest.
  >  KIO::moveAs (implemented by CopyJob too) can move/rename a single file to 
a specific filename at destination.
  >
  > What you're suggesting is a new job that can move N files to a destination 
directory (to make this generic it doesn't have to be in-place renames, 
right?), but you're providing the filename at destination for each file, right?
  
  
  More or less but they don't have to be in the same directory. Think of it as 
a sequence of `KIO::moveAs` operations. Any N files can be moved anywhere.
  
  > I could imagine a KIO::moveAs that takes two QList and then this 
information is fetched from there rather than using m_dest.
  >  In fact, if the existing moveAs() method is ported to call the two-QLists 
one, that will mean less special casing in the code (which wouldn't use m_dest 
anymore in slotResultStating, when m_asMethod).
  
  The two list version could work, but I was thinking of one 
`QList` that contains src and dest names. Looks less error prone 
IMO. Also yes, moveAs can be implemented as a special case of this with just 
one item to move. The option of adapting move to accept a list of dest also 
involves modifying CopyJobPrivate's dest which will lead to a larger 
refactoring needed than the proposal below, right?
  
  ---
  
  I was thinking of implementing this as a new subclass of Job where it will 
create the new Job and add a subjob for each of the files to be moved. In the 
same fashion that the current `BatchRenameJob` works. Otherwise if overloading 
will not break binary compatibility then this can be an overloaded 
`KIO::moveAs(QList)` which again does the same thing, a series of 
the current `moveAs`. It also has to remain as a single job so that it can be 
undone in one go instead of undoing for each item that was renamed.
  
  e.g:
  
auto items = {
KioRenameItem{QUrl("~/a.doc"), QUrl("~/Documents/a.doc")},
KioRenameItem{QUrl("~/dir/file"), QUrl("~/Documents/file-2019")},
};
  
  If this looks OK then I'll just get started with this and continue this part 
of the work in another patch.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D14631

To: emateli, #frameworks, dfaure, mlaurent
Cc: anthonyfieroni, chinmoyr, mlaurent, asensi, rkflx, dfaure, aacid, ngraham, 
kde-frameworks-devel, LeGast00n, sbergeron, michaelh, bruns

KDE CI: Frameworks » kcoreaddons » kf5-qt5 SUSEQt5.13 - Build # 6 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20SUSEQt5.13/6/
 Project:
kf5-qt5 SUSEQt5.13
 Date of build:
Sun, 21 Jul 2019 18:52:26 +
 Build duration:
4 min 14 sec and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5CoreAddons-5.61.0.xmlcompat_reports/KF5CoreAddons_compat_report.htmllogs/KF5CoreAddons/5.61.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 0 test(s), Passed: 26 test(s), Skipped: 0 test(s), Total: 26 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report91%
(10/11)85%
(76/89)85%
(76/89)76%
(6763/8946)43%
(10661/24586)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests94%
(29/31)94%
(29/31)97%
(2817/2907)48%
(6084/12551)src.desktoptojson100%
(2/2)100%
(2/2)77%
(86/111)38%
(122/325)src.lib67%
(2/3)67%
(2/3)62%
(382/621)26%
(243/926)src.lib.caching100%
(2/2)100%
(2/2)45%
(354/784)18%
(187/1054)src.lib.io75%
(9/12)75%
(9/12)67%
(868/1293)36%
(995/2771)src.lib.jobs71%
(5/7)71%
(5/7)57%
(160/281)40%
(53/134)src.lib.plugin100%
(7/7)100%
(7/7)85%
(672/788)42%
(944/2249)src.lib.randomness100%
(2/2)100%
(2/2)70%
(67/96)58%
(45/78)src.lib.text63%
(5/8)63%
(5/8)51%
(426/835)47%
(1014/2165)src.lib.util100%
(13/13)100%
(13/13)81%
(931/1145)50%
(974/1943)tests0%
(0/2)0%
(0/2)0%
(0/85)0%
(0/390)

KDE CI: Frameworks » kcoreaddons » kf5-qt5 FreeBSDQt5.13 - Build # 5 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20FreeBSDQt5.13/5/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Sun, 21 Jul 2019 18:52:26 +
 Build duration:
1 min 51 sec and counting
   JUnit Tests
  Name: projectroot Failed: 3 test(s), Passed: 23 test(s), Skipped: 0 test(s), Total: 26 test(s)Failed: projectroot.autotests.kdirwatch_inotify_unittestFailed: projectroot.autotests.kformattestFailed: projectroot.autotests.kprocesslisttest

D22105: WIP : Fix SFTP Plugin of KIO for Windows

[Piyush Aggarwal]

brute4s99 added inline comments.

INLINE COMMENTS

> dfaure wrote in kio_sftp.cpp:2257
> This is marked as Done, but it's not Done. In fact it matches my own 
> suggestion above, so I agree with Albert ;-)

so sorry, it seems I updated a previous version of the diff.

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D22105

To: brute4s99, albertvaka, vonreth, sredman, sitter, dfaure
Cc: pino, andriusr, kde-frameworks-devel, kfm-devel, aprcela, fprice, 
LeGast00n, sbergeron, fbampaloukas, alexde, feverfew, meven, michaelh, spoorun, 
navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp, mikesomov

D22620: Add function to suggest a unique filename

[Nicolas Fella]

This revision was automatically updated to reflect the committed changes.
Closed by commit R244:03b9bdee4f52: Add function to suggest a unique filename 
(authored by nicolasfella).

REPOSITORY
  R244 KCoreAddons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22620?vs=6=62223

REVISION DETAIL
  https://phabricator.kde.org/D22620

AFFECTED FILES
  autotests/CMakeLists.txt
  autotests/kfileutilstest.cpp
  autotests/kfileutilstest.h
  src/lib/CMakeLists.txt
  src/lib/io/kfileutils.cpp
  src/lib/io/kfileutils.h

To: nicolasfella, dfaure
Cc: kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns

D22620: Add function to suggest a unique filename

[David Faure]

dfaure accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R244 KCoreAddons

BRANCH
  suggestname

REVISION DETAIL
  https://phabricator.kde.org/D22620

To: nicolasfella, dfaure
Cc: kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns

D22620: Add function to suggest a unique filename

[Nicolas Fella]

nicolasfella updated this revision to Diff 6.
nicolasfella added a comment.


  - Don't steal David's copyright
  - Remove TODO

REPOSITORY
  R244 KCoreAddons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22620?vs=62218=6

BRANCH
  suggestname

REVISION DETAIL
  https://phabricator.kde.org/D22620

AFFECTED FILES
  autotests/CMakeLists.txt
  autotests/kfileutilstest.cpp
  autotests/kfileutilstest.h
  src/lib/CMakeLists.txt
  src/lib/io/kfileutils.cpp
  src/lib/io/kfileutils.h

To: nicolasfella, dfaure
Cc: kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns

D22620: Add function to suggest a unique filename

[David Faure]

dfaure requested changes to this revision.
dfaure added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> kfileutilstest.cpp:2
> +/* This file is part of the KDE libraries
> +Copyright (c) 2019 Nicolas Fella 
> +

Liar :-)

I wrote the first version of this test method.

> kfileutils.cpp:2
> +/* This file is part of the KDE libraries
> +   Copyright (C) 2019 Nicolas Fella 
> +

ditto

> kfileutils.cpp:64
> +
> +// TODO: network transparency. However, using NetAccess from a modal 
> dialog
> +// could be a problem, no? (given that it uses a modal widget itself)

You can remove this TODO. By moving this code to KCoreAddons we are finally 
closing the lid on this TODO.
It just won't be done, it wouldn't be a good idea anyway (too slow, and would 
require an async API, and a KIO dependency). So if it's ever done, it'll be 
with a different implementation in KIO, while this one will remain the "simple 
and synchronous" way, sufficient for many apps.

REPOSITORY
  R244 KCoreAddons

REVISION DETAIL
  https://phabricator.kde.org/D22620

To: nicolasfella, dfaure
Cc: kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns

D22105: WIP : Fix SFTP Plugin of KIO for Windows

[David Faure]

dfaure requested changes to this revision.
dfaure added a comment.
This revision now requires changes to proceed.


  Almost there :-)

INLINE COMMENTS

> kio_sftp.cpp:406
> +#ifdef Q_OS_WIN
> +// TODO Check if this works for other OSes too.
> +fileType = QT_STAT_LNK;

Yes, QT_STAT_LNK works on Unix too, we use it in many places in KIO
(and it has the value S_IFLNK)

So I'm pretty sure you can remove this ifdef.

You could also replace S_IFREG with QT_STAT_REG and S_IFDIR with QT_STAT_DIR, 
for consistency.

> kio_sftp.cpp:2032
>  }
> -else if (QT_STAT( QFile::encodeName(sPart),  ) == 0) { // 
> should a very small ".part" be deleted?
> +else if (partFile.exists()) { // should a very small ".part" be 
> deleted?
>  const int size = config()->readEntry("MinimumKeepSize", 
> DEFAULT_MINIMUM_KEEP_SIZE);

At this point we were doing another stat() in order to see how big the part 
file is *after* sftpGet.
You're reusing the old QFileInfo so that won't contain updated data.

You need to call QFileInfo::refresh() first.

> kio_sftp.cpp:2050
> +else {
> +
> receivedFile.setFileTime(partFile.fileTime(QFileDevice::FileAccessTime),
> +QFileDevice::FileAccessTime);

Sorry I gave wrong advice.
The old code was preserving the atime just because the utime() API forces us to 
specify an atime.
But what we want to do here is set the modification time, nothing else.
We don't care about the access time at all.
Please just remove this line.

> albertvaka wrote in kio_sftp.cpp:2257
> You can keep QT_STAT_LNK on every platform and remove the ifdef. That's the 
> point of the abstraction Qt provides.
> 
> For consistency, I would also change the other (S_IFDIR, etc.) to their Qt 
> counterparts.

This is marked as Done, but it's not Done. In fact it matches my own suggestion 
above, so I agree with Albert ;-)

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D22105

To: brute4s99, albertvaka, vonreth, sredman, sitter, dfaure
Cc: pino, andriusr, kde-frameworks-devel, kfm-devel, aprcela, fprice, 
LeGast00n, sbergeron, fbampaloukas, alexde, feverfew, meven, michaelh, spoorun, 
navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp, mikesomov

D22620: Add function to suggest a unique filename

[Nicolas Fella]

nicolasfella updated this revision to Diff 62218.
nicolasfella added a comment.


  - Add test

REPOSITORY
  R244 KCoreAddons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22620?vs=62215=62218

BRANCH
  suggestname

REVISION DETAIL
  https://phabricator.kde.org/D22620

AFFECTED FILES
  autotests/CMakeLists.txt
  autotests/kfileutilstest.cpp
  autotests/kfileutilstest.h
  src/lib/CMakeLists.txt
  src/lib/io/kfileutils.cpp
  src/lib/io/kfileutils.h

To: nicolasfella, dfaure
Cc: kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns

D22620: Add function to suggest a unique filename

[Nicolas Fella]

nicolasfella edited the summary of this revision.

REPOSITORY
  R244 KCoreAddons

REVISION DETAIL
  https://phabricator.kde.org/D22620

To: nicolasfella, dfaure
Cc: kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns

D22620: Add function to suggest a unique filename

[David Faure]

dfaure requested changes to this revision.
dfaure added a comment.
This revision now requires changes to proceed.


  Please "move" (copy) the autotest as well, see kio/autotests/globaltest.cpp
  
  Typo in the commit log: s/it's/its/

REPOSITORY
  R244 KCoreAddons

REVISION DETAIL
  https://phabricator.kde.org/D22620

To: nicolasfella, dfaure
Cc: kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns

D22609: Add spacers as a customization option for toolbars

[David Faure]

dfaure added a comment.


  Ah yeah, about the name, I expected a fixed-width spacer until I saw the 
video. And maybe someone wants to provide that as well... so "Expanding spacer" 
would actually make sense for this feature.
  Or maybe you even want to provide both right away, while at it...

REPOSITORY
  R263 KXmlGui

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D22609

To: felixernst, dfaure
Cc: ngraham, #vdg, dfaure, kde-frameworks-devel, LeGast00n, sbergeron, 
michaelh, bruns

D22609: Add spacers as a customization option for toolbars

[David Faure]

dfaure accepted this revision.
dfaure added a comment.
This revision is now accepted and ready to land.


  A video showing the feature, in the merge request! I'm blown away!
  
  Code looks fine.

INLINE COMMENTS

> kxmlguibuilder.cpp:349
> +} else if (tagName == d->tagSpacer) {
> +if (KToolBar *bar = qobject_cast(parent)) {
> +// Create the simple spacer widget

(pre-existing, in the separator code above) QToolBar would be sufficient, 
technically, in this code.

REPOSITORY
  R263 KXmlGui

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D22609

To: felixernst, dfaure
Cc: ngraham, #vdg, dfaure, kde-frameworks-devel, LeGast00n, sbergeron, 
michaelh, bruns

D10742: get rid of the raw KFileItem pointers in KCoreDirListerCache

[Jaime Torres Amate]

jtamate closed this revision.
jtamate added a comment.


  In D10742#499346 , @aacid wrote:
  
  > @jtamate Does that "let's continue in that other review" mean we should 
cancel this one? Still shows on the list of reviews to consider
  
  
  Yes, it should be closed. It was already commited, unfortunately with a bug 
associated to it, fixed in the other review.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D10742

To: jtamate, #frameworks, dfaure
Cc: aacid, elvisangelaccio, bruns, kde-frameworks-devel, mwolff, markg, 
LeGast00n, sbergeron, michaelh, ngraham

D22620: Add function to suggest a unique filename

[Nicolas Fella]

nicolasfella created this revision.
nicolasfella added a reviewer: dfaure.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
nicolasfella requested review of this revision.

REVISION SUMMARY
  This is a copy of KIO::suggestName. It doesn't use anything from KIO in it's 
implementation and this patch enables to use it without pulling in all the 
baggage that comes with KIO

TEST PLAN
  Port the one use in KDE Connect to it

REPOSITORY
  R244 KCoreAddons

BRANCH
  suggestname

REVISION DETAIL
  https://phabricator.kde.org/D22620

AFFECTED FILES
  src/lib/CMakeLists.txt
  src/lib/io/kfileutils.cpp
  src/lib/io/kfileutils.h

To: nicolasfella, dfaure
Cc: kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns

D22618: remove dangling remote widgets code

[Harald Sitter]

sitter created this revision.
sitter added a reviewer: Plasma.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
sitter requested review of this revision.

REVISION SUMMARY
  can't be enabled anywhere + not actually doing anything as there is no
  backing for it in the cpp + qca isn't even looked for by cmake

TEST PLAN
  none

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D22618

AFFECTED FILES
  src/plasma/private/authorizationmanager_p.h

To: sitter, #plasma
Cc: kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns

D22617: Add icons for pagelayout options, as needed in Okular

[David Hurka]

davidhurka edited the test plan for this revision.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D22617

To: davidhurka, #vdg
Cc: #okular, kde-frameworks-devel, ngraham, LeGast00n, sbergeron, michaelh, 
bruns

D22617: Add icons for pagelayout options, as needed in Okular

[David Hurka]

davidhurka added a subscriber: Okular.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D22617

To: davidhurka, #vdg
Cc: #okular, kde-frameworks-devel, ngraham, LeGast00n, sbergeron, michaelh, 
bruns

D19005: android: don't default to gcc anymore

[Albert Astals Cid]

aacid closed this revision.
aacid added a comment.


  Talked with Aleix, we're deciding to drop this for the moment

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D19005

To: apol, #frameworks, vkrause
Cc: aacid, kde-frameworks-devel, kde-buildsystem, LeGast00n, sbergeron, 
bencreasy, michaelh, ngraham, bruns

D22617: Add icons for pagelayout options, as needed in Okular

[David Hurka]

davidhurka added a comment.


  I’m not sure whether I did everything correctly. If I did, this is too 
complicated.
  
  The guidelines in the community wiki 
 and the 
HIG  are missing:
  
  - What are the borders good for?
  - What icon sizes are needed? (I choosed 16, 22, 24, because theese have the 
most icons.)
  - What is 24px good for? Isn’t it just 22px with 1px additional border?
  
  And there are just workflow tips, is the actual workflow for adding icons 
described somewhere?
  
  One more problem: scour breaks up the colors of the path elements, if they 
are more than 2. It moves the fill attribute in a group, but then the color 
attributes seem to override it, so the stylesheet is ignored.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D22617

To: davidhurka, #vdg
Cc: kde-frameworks-devel, ngraham, LeGast00n, sbergeron, michaelh, bruns

D22617: Add icons for pagelayout options, as needed in Okular

[David Hurka]

davidhurka created this revision.
davidhurka added a reviewer: VDG.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
davidhurka requested review of this revision.

REVISION SUMMARY
  This is my try to add the icons I requested in D21196#484674 
.
  
  The icons are: pagelayout-[single|facing|facing-first-centered|overview], as 
they are needed for the View Layout menu; and pagelayout-continuous, as it is 
needed for the Continuous view option (which might be moved into the View 
Layout menu).
  
  BUG: 409082

REPOSITORY
  R266 Breeze Icons

BRANCH
  add-icons-for-pagelayouts

REVISION DETAIL
  https://phabricator.kde.org/D22617

AFFECTED FILES
  icons-dark/actions/16/pagelayout-continuous.svg
  icons-dark/actions/16/pagelayout-facing-first-centered.svg
  icons-dark/actions/16/pagelayout-facing.svg
  icons-dark/actions/16/pagelayout-overview.svg
  icons-dark/actions/16/pagelayout-single.svg
  icons-dark/actions/22/pagelayout-continuous.svg
  icons-dark/actions/22/pagelayout-facing-first-centered.svg
  icons-dark/actions/22/pagelayout-facing.svg
  icons-dark/actions/22/pagelayout-overview.svg
  icons-dark/actions/22/pagelayout-single.svg
  icons-dark/actions/24/pagelayout-continuous.svg
  icons-dark/actions/24/pagelayout-facing-first-centered.svg
  icons-dark/actions/24/pagelayout-facing.svg
  icons-dark/actions/24/pagelayout-overview.svg
  icons-dark/actions/24/pagelayout-single.svg
  icons/actions/16/pagelayout-continuous.svg
  icons/actions/16/pagelayout-facing-first-centered.svg
  icons/actions/16/pagelayout-facing.svg
  icons/actions/16/pagelayout-overview.svg
  icons/actions/16/pagelayout-single.svg
  icons/actions/22/pagelayout-continuous.svg
  icons/actions/22/pagelayout-facing-first-centered.svg
  icons/actions/22/pagelayout-facing.svg
  icons/actions/22/pagelayout-overview.svg
  icons/actions/22/pagelayout-single.svg
  icons/actions/24/pagelayout-continuous.svg
  icons/actions/24/pagelayout-facing-first-centered.svg
  icons/actions/24/pagelayout-facing.svg
  icons/actions/24/pagelayout-overview.svg
  icons/actions/24/pagelayout-single.svg

To: davidhurka, #vdg
Cc: kde-frameworks-devel, ngraham, LeGast00n, sbergeron, michaelh, bruns

D10742: get rid of the raw KFileItem pointers in KCoreDirListerCache

[Albert Astals Cid]

aacid added a comment.


  @jtamate Does that "let's continue in that other review" mean we should 
cancel this one? Still shows on the list of reviews to consider

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D10742

To: jtamate, #frameworks, dfaure
Cc: aacid, elvisangelaccio, bruns, kde-frameworks-devel, mwolff, markg, 
LeGast00n, sbergeron, michaelh, ngraham

D22609: Add spacers as a customization option for toolbars

[Nathaniel Graham]

ngraham added a comment.


  Also, I would recommend doing most of the comment changes in a separate 
patch. They are good and useful, but not related to adding this awesome new 
spacer item.

REPOSITORY
  R263 KXmlGui

REVISION DETAIL
  https://phabricator.kde.org/D22609

To: felixernst
Cc: ngraham, #vdg, dfaure, kde-frameworks-devel, LeGast00n, sbergeron, 
michaelh, bruns

D22609: Add spacers as a customization option for toolbars

[Nathaniel Graham]

ngraham added a comment.


  +100!
  
  How about naming it "Flexible space" or "Expanding spacer" to make it a bit 
clearer?

REPOSITORY
  R263 KXmlGui

REVISION DETAIL
  https://phabricator.kde.org/D22609

To: felixernst
Cc: ngraham, #vdg, dfaure, kde-frameworks-devel, LeGast00n, sbergeron, 
michaelh, bruns

D22609: Add spacers as a customization option for toolbars

[Nathaniel Graham]

ngraham added subscribers: Frameworks, dfaure, VDG.
Herald removed a subscriber: Frameworks.

REPOSITORY
  R263 KXmlGui

REVISION DETAIL
  https://phabricator.kde.org/D22609

To: felixernst
Cc: #vdg, dfaure, kde-frameworks-devel, LeGast00n, sbergeron, michaelh, 
ngraham, bruns

Re: kbuildsycoca global in a modern world

[David Faure]

On mardi 16 juillet 2019 13:08:02 CEST Harald Sitter wrote:
> I was wondering if kbuildsycoca's global code still has a reason to exist.

I wondered the same when I redesigned most of ksycoca some time ago,
and I chose to keep the feature.
The thinking is the following: imagine a kiosk-mode device where every login 
is a first time login for that user (because the user gets deleted every time, 
to start ). 
The startup will be slow every time because the ksycoca file has to be created 
by parsing all desktop files.
A sysadmin can run kbuildsycoca5 --global once and users will end up using 
that.
 
> The way I read the code a local kbuildsycoca would only reuse the
> global sycoca iff languages, prefixes and signatures are a match.

Same logic as for a local sycoca, yes.

> But prefixes are not ever the same in any "default" or even reasonable
> scenario. Specifically, prefixes are essentially
> QStandardPaths::GenericDataLocation paths and those include at least
> one user-specific directory on every single platform documented for
> QSP. 

Oops. That's a porting bug, I would say. The home dir shouldn't be taken into 
account for the global database.
I checked the kde4 code and it used to do
   if (bGlobalDatabase)
   {
 setenv("KDEHOME", "-", 1);
 setenv("KDEROOTHOME", "-", 1);
   }
exactly for this purpose.

WARNING WARNING the current code seems to not do that, and still it cleans up 
the local applications directory afterwards, so if you run 
kbuildsycoca5 --global in your user account, it will delete 
~/.local/share/applications, as far as I can see in the code!

I just removed that very dangerous cleanup code, don't try --global before
having that fix...
https://commits.kde.org/kservice/5cf75cedc26447bce4c1cf0b4c0fa71018f506f5

> On linuxy systems this is even a very important path as (e.g.)
> application desktop files edited by kmenuedit are stored in
> XDG_DATA_HOME, so not including that would break overrides or custom
> software installs. Additionally bundle software such as flatpak can do
> user-specific software installation which means it also injects paths
> into XDG_DATA_DIRS.

Right. As soon as you have things in XDG_DATA_HOME, you need a local ksycoca, 
that's for sure.
 
> Do we still need the global cache feature at all?

I wish Waldo Bastian was around to answer the following question: how does 
this feature differ from an autostart script copying a global ksycoca to the 
user's directory, in such a kiosk setup?

I can't see a good reason to keep the feature, actually :-)

-- 
David Faure, fa...@kde.org, http://www.davidfaure.fr
Working on KDE Frameworks 5

KDE CI: Frameworks » kservice » kf5-qt5 FreeBSDQt5.13 - Build # 6 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kservice/job/kf5-qt5%20FreeBSDQt5.13/6/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Sun, 21 Jul 2019 15:01:05 +
 Build duration:
1 min 50 sec and counting
   JUnit Tests
  Name: projectroot Failed: 2 test(s), Passed: 7 test(s), Skipped: 0 test(s), Total: 9 test(s)Failed: projectroot.autotests.kmimeassociationstestFailed: projectroot.autotests.ksycoca_xdgdirstestName: projectroot.tests Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.13 - Build # 16 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.13/16/
 Project:
kf5-qt5 SUSEQt5.13
 Date of build:
Sun, 21 Jul 2019 14:12:05 +
 Build duration:
20 min and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5Plasma-5.61.0.xmlacc/KF5PlasmaQuick-5.61.0.xmlcompat_reports/KF5Plasma_compat_report.htmllogs/KF5Plasma/5.61.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 3 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 11 test(s)Failed: projectroot.autotests.dialognativetestFailed: projectroot.autotests.plasma_configmodeltestFailed: projectroot.autotests.plasma_iconitemtest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report33%
(6/18)28%
(35/123)28%
(35/123)25%
(3334/13138)18%
(1737/9632)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests82%
(9/11)82%
(9/11)55%
(490/890)33%
(276/824)src.declarativeimports.calendar0%
(0/6)0%
(0/6)0%
(0/471)0%
(0/243)src.declarativeimports.core31%
(5/16)31%
(5/16)14%
(314/2281)6%
(92/1479)src.declarativeimports.plasmacomponents0%
(0/6)0%
(0/6)0%
(0/518)0%
(0/207)src.declarativeimports.plasmaextracomponents0%
(0/3)0%
(0/3)0%
(0/42)0%
(0/22)src.declarativeimports.platformcomponents0%
(0/3)0%
(0/3)0%
(0/58)0%
(0/14)src.declarativeimports.platformcomponents.utils0%
(0/2)0%
(0/2)0%
(0/14)0%
(0/2)src.plasma45%
(10/22)45%
(10/22)37%
(1269/3473)26%
(748/2841)src.plasma.packagestructure0%
(0/7)0%
(0/7)0%
(0/134)0%
(0/12)src.plasma.private33%
(6/18)33%
(6/18)42%
(656/1573)29%
(300/1048)src.plasma.scripting0%
(0/3)0%
(0/3)0%
(0/171)0%
(0/113)src.plasmapkg0%
(0/1)0%
(0/1)0%
(0/45)0%
(0/40)src.plasmaquick33%
(4/12)33%
(4/12)28%
(574/2024)18%
(316/1729)src.plasmaquick.private50%
(1/2)50%
(1/2)29%
(31/106)36%
(5/14)src.scriptengines.qml.plasmoid0%
(0/6)0%
(0/6)0%
(0/1183)0%
(0/1020)tests.dpi0%
(0/2)0%
(0/2)0%
   

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.12 - Build # 139 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.12/139/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Sun, 21 Jul 2019 14:12:05 +
 Build duration:
19 min and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5Plasma-5.61.0.xmlacc/KF5PlasmaQuick-5.61.0.xmlcompat_reports/KF5Plasma_compat_report.htmllogs/KF5Plasma/5.61.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 3 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 11 test(s)Failed: projectroot.autotests.dialognativetestFailed: projectroot.autotests.plasma_configmodeltestFailed: projectroot.autotests.plasma_iconitemtest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report33%
(6/18)28%
(35/123)28%
(35/123)25%
(3338/13139)18%
(1738/9632)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests82%
(9/11)82%
(9/11)55%
(490/890)33%
(276/824)src.declarativeimports.calendar0%
(0/6)0%
(0/6)0%
(0/471)0%
(0/243)src.declarativeimports.core31%
(5/16)31%
(5/16)14%
(314/2281)6%
(92/1479)src.declarativeimports.plasmacomponents0%
(0/6)0%
(0/6)0%
(0/518)0%
(0/207)src.declarativeimports.plasmaextracomponents0%
(0/3)0%
(0/3)0%
(0/42)0%
(0/22)src.declarativeimports.platformcomponents0%
(0/3)0%
(0/3)0%
(0/58)0%
(0/14)src.declarativeimports.platformcomponents.utils0%
(0/2)0%
(0/2)0%
(0/14)0%
(0/2)src.plasma45%
(10/22)45%
(10/22)37%
(1269/3473)26%
(748/2841)src.plasma.packagestructure0%
(0/7)0%
(0/7)0%
(0/134)0%
(0/12)src.plasma.private33%
(6/18)33%
(6/18)42%
(656/1573)29%
(300/1048)src.plasma.scripting0%
(0/3)0%
(0/3)0%
(0/171)0%
(0/113)src.plasmapkg0%
(0/1)0%
(0/1)0%
(0/45)0%
(0/40)src.plasmaquick33%
(4/12)33%
(4/12)29%
(578/2025)18%
(317/1729)src.plasmaquick.private50%
(1/2)50%
(1/2)29%
(31/106)36%
(5/14)src.scriptengines.qml.plasmoid0%
(0/6)0%
(0/6)0%
(0/1183)0%
(0/1020)tests.dpi0%
(0/2)0%
(0/2)0%
  

KDE CI: Frameworks » bluez-qt » kf5-qt5 SUSEQt5.12 - Build # 31 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/bluez-qt/job/kf5-qt5%20SUSEQt5.12/31/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Sun, 21 Jul 2019 14:10:00 +
 Build duration:
18 min and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5BluezQt-5.61.0.xmlcompat_reports/KF5BluezQt_compat_report.htmllogs/KF5BluezQt/5.61.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 0 test(s), Passed: 13 test(s), Skipped: 0 test(s), Total: 13 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report50%
(3/6)57%
(68/120)57%
(68/120)54%
(3547/6581)32%
(1510/4751)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(14/14)100%
(14/14)96%
(1651/1717)37%
(1007/2736)autotests.fakebluez0%
(0/20)0%
(0/20)0%
(0/831)0%
(0/264)src79%
(48/61)79%
(48/61)55%
(1557/2845)38%
(484/1266)src.imports86%
(6/7)86%
(6/7)81%
(339/421)48%
(19/40)tests0%
(0/5)0%
(0/5)0%
(0/245)0%
(0/64)tools.bluezapi2qt0%
(0/13)0%
(0/13)0%
(0/522)0%
(0/381)

KDE CI: Frameworks » bluez-qt » kf5-qt5 SUSEQt5.13 - Build # 5 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/bluez-qt/job/kf5-qt5%20SUSEQt5.13/5/
 Project:
kf5-qt5 SUSEQt5.13
 Date of build:
Sun, 21 Jul 2019 14:10:00 +
 Build duration:
7 min 43 sec and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5BluezQt-5.61.0.xmlcompat_reports/KF5BluezQt_compat_report.htmllogs/KF5BluezQt/5.61.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 0 test(s), Passed: 13 test(s), Skipped: 0 test(s), Total: 13 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report50%
(3/6)57%
(68/120)57%
(68/120)54%
(3547/6581)32%
(1537/4751)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(14/14)100%
(14/14)96%
(1651/1717)38%
(1033/2736)autotests.fakebluez0%
(0/20)0%
(0/20)0%
(0/831)0%
(0/264)src79%
(48/61)79%
(48/61)55%
(1557/2845)38%
(485/1266)src.imports86%
(6/7)86%
(6/7)81%
(339/421)48%
(19/40)tests0%
(0/5)0%
(0/5)0%
(0/245)0%
(0/64)tools.bluezapi2qt0%
(0/13)0%
(0/13)0%
(0/522)0%
(0/381)

KDE CI: Frameworks » plasma-framework » kf5-qt5 FreeBSDQt5.13 - Build # 12 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20FreeBSDQt5.13/12/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Sun, 21 Jul 2019 14:12:05 +
 Build duration:
4 min 49 sec and counting
   JUnit Tests
  Name: projectroot Failed: 3 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 11 test(s)Failed: projectroot.autotests.dialognativetestFailed: projectroot.autotests.plasma_configmodeltestFailed: projectroot.autotests.plasma_iconitemtest

KDE CI: Frameworks » bluez-qt » kf5-qt5 FreeBSDQt5.13 - Build # 4 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/bluez-qt/job/kf5-qt5%20FreeBSDQt5.13/4/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Sun, 21 Jul 2019 14:10:00 +
 Build duration:
2 min 37 sec and counting
   JUnit Tests
  Name: projectroot Failed: 0 test(s), Passed: 13 test(s), Skipped: 0 test(s), Total: 13 test(s)

D22611: Remove deprecated tests

[David Edmundson]

This revision was automatically updated to reflect the committed changes.
Closed by commit R242:0e14ab6eca26: Remove deprecated tests (authored by 
davidedmundson).

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22611?vs=62191=62192

REVISION DETAIL
  https://phabricator.kde.org/D22611

AFFECTED FILES
  autotests/CMakeLists.txt
  autotests/fallbackpackagetest.cpp
  autotests/fallbackpackagetest.h
  autotests/packagemetadatatest.desktop
  autotests/packagestructuretest.cpp
  autotests/packagestructuretest.h
  autotests/storagetest.cpp
  autotests/storagetest.h

To: davidedmundson, #plasma, broulik
Cc: kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns

D22611: Remove deprecated tests

[Kai Uwe Broulik]

broulik accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D22611

To: davidedmundson, #plasma, broulik
Cc: kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns

D22611: Remove deprecated tests

[David Edmundson]

davidedmundson created this revision.
davidedmundson added a reviewer: Plasma.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
davidedmundson requested review of this revision.

REVISION SUMMARY
  Plasma::KPackage is deprecated in favour of KPackage.
  There are much better tests there.
  
  Storage is completely unused, no point testing it.

TEST PLAN
  Compiles

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D22611

AFFECTED FILES
  autotests/CMakeLists.txt
  autotests/fallbackpackagetest.cpp
  autotests/fallbackpackagetest.h
  autotests/packagemetadatatest.desktop
  autotests/packagestructuretest.cpp
  autotests/packagestructuretest.h
  autotests/storagetest.cpp
  autotests/storagetest.h

To: davidedmundson, #plasma
Cc: kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns

D22609: Add spacers as a customization option for toolbars

[Felix Ernst]

felixernst edited the summary of this revision.

REPOSITORY
  R263 KXmlGui

REVISION DETAIL
  https://phabricator.kde.org/D22609

To: felixernst
Cc: kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns

D22609: Add spacers as a customization option for toolbars

[Felix Ernst]

felixernst updated this revision to Diff 62188.
felixernst added a comment.


  Use insertWidget(before, spacer) instead of addWidget(spacer)

REPOSITORY
  R263 KXmlGui

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22609?vs=62185=62188

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D22609

AFFECTED FILES
  src/kedittoolbar.cpp
  src/kedittoolbar.h
  src/kxmlgui.xsd
  src/kxmlguibuilder.cpp

To: felixernst
Cc: kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns

D22105: WIP : Fix SFTP Plugin of KIO for Windows

[Piyush Aggarwal]

brute4s99 updated this revision to Diff 62187.
brute4s99 added a comment.


  updated

REPOSITORY
  R320 KIO Extras

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22105?vs=62159=62187

BRANCH
  arcpatch-D22105

REVISION DETAIL
  https://phabricator.kde.org/D22105

AFFECTED FILES
  CMakeLists.txt
  sftp/CMakeLists.txt
  sftp/kio_sftp.cpp

To: brute4s99, albertvaka, vonreth, sredman, sitter, dfaure
Cc: pino, andriusr, kde-frameworks-devel, kfm-devel, aprcela, fprice, 
LeGast00n, sbergeron, fbampaloukas, alexde, feverfew, meven, michaelh, spoorun, 
navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp, mikesomov

D22105: WIP : Fix SFTP Plugin of KIO for Windows

[Piyush Aggarwal]

brute4s99 marked 6 inline comments as done.

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D22105

To: brute4s99, albertvaka, vonreth, sredman, sitter, dfaure
Cc: pino, andriusr, kde-frameworks-devel, kfm-devel, aprcela, fprice, 
LeGast00n, sbergeron, fbampaloukas, alexde, feverfew, meven, michaelh, spoorun, 
navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp, mikesomov

D22609: Add spacers as a customization option for toolbars

[Felix Ernst]

felixernst planned changes to this revision.
felixernst added a comment.


  Need to fix wrong return type in KXMLGUIBuilder::createCustomElement

REPOSITORY
  R263 KXmlGui

REVISION DETAIL
  https://phabricator.kde.org/D22609

To: felixernst
Cc: kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns

D22599: Make first and last name available separately

[Aleix Pol Gonzalez]

apol added a comment.


  In D22599#499008 , @pino wrote:
  
  > How would first + last name work, when
  >  a) you have multiple first names
  >  b) you have multiple last names
  >  c) you have only one "name" -- http://wookware.org/name.html
  
  
  As I see it, this is in case the user/front-end needs to treat them 
separately. Applications shouldn't put them together, that's why there's a 
separate NameProperty already.

REPOSITORY
  R307 KPeople

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D22599

To: jbbgameich, #plasma:_mobile, apol
Cc: pino, kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns

D22609: Add spacers as a customization option for toolbars

[Felix Ernst]

felixernst edited the test plan for this revision.

REPOSITORY
  R263 KXmlGui

REVISION DETAIL
  https://phabricator.kde.org/D22609

To: felixernst
Cc: kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns

D22609: Add spacers as a customization option for toolbars

[Felix Ernst]

felixernst edited the summary of this revision.

REPOSITORY
  R263 KXmlGui

REVISION DETAIL
  https://phabricator.kde.org/D22609

To: felixernst
Cc: kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns

D22609: Add spacers as a customization option for toolbars

[Felix Ernst]

felixernst edited the test plan for this revision.

REPOSITORY
  R263 KXmlGui

REVISION DETAIL
  https://phabricator.kde.org/D22609

To: felixernst
Cc: kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns

D22609: Add spacers as a customization option for toolbars

[Felix Ernst]

felixernst created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
felixernst requested review of this revision.

REVISION SUMMARY
  This commit adds spacers to the kxmlgui framework so all applications
  using it will be able to use any amount of spacers in their toolbar(s).
  
  KEditToolbar gets the --- spacer --- entry by default. This entry is
  modified to allow any amount of spacers to be put into the toolbars
  (just like separators).
  The xml scheme is changed to allow "" nodes
  (just like separators).
  KXmlGuiBuilder then builds the simple spacer by itself.

REPOSITORY
  R263 KXmlGui

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D22609

AFFECTED FILES
  src/kedittoolbar.cpp
  src/kedittoolbar.h
  src/kxmlgui.xsd
  src/kxmlguibuilder.cpp

To: felixernst
Cc: kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns

Qt dependency policy

[David Faure]

Taking into account the feedback from the SUSE packagers
(about how dropping support for Qt 5.9 LTS the very month Qt 5.12 LTS comes 
out is a problem since not everyone can upgrade to Qt 5.12 LTS right away)
I have modified the policy to temporarily support 4 versions when the oldest 
(and newest) are LTS.

https://community.kde.org/Frameworks/Policies#Frameworks_Qt_requirements

-- 
David Faure, fa...@kde.org, http://www.davidfaure.fr
Working on KDE Frameworks 5

D22599: Make first and last name available separately

[Jonah Brüchert]

jbbgameich added a comment.


  In case a, all first names would probably be in a string separated by spaces, 
same for multiple last names.
  In case c, I guess only the last name would be set maybe.
  
  I have been only working with the KContacts based vcard backend, where 
givenName and FamilyName could be mapped directly. I'm not quite sure what 
KContacts does in this cases though.

REPOSITORY
  R307 KPeople

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D22599

To: jbbgameich, #plasma:_mobile, apol
Cc: pino, kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns

D22105: WIP : Fix SFTP Plugin of KIO for Windows

[David Faure]

dfaure requested changes to this revision.
dfaure added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> kio_sftp.cpp:266
>  
> -qCDebug(KIO_SFTP_LOG) << "name=" << name << " instruction=" << 
> instruction << " prompts=" << n;
> +qDebug() << "name=" << name << " instruction=" << instruction << " 
> prompts=" << n;
>  

Use `kdebugsettings` to enable sftp debug output instead of qCDebug->qDebug 
(which adds a lot of noise to the review)

> brute4s99 wrote in kio_sftp.cpp:2050-2051
> it uses buff.st_atime . Since I'm removing use of buff, I'm not sure how to 
> handle this. For now I've commented out setting the file access time 
> instruction for now.

Just use partFile.fileTime(QFileInfoFileAccessTime)

> kio_sftp.cpp:2052
> +// 
> QFileDevice::FileTime(QFileDevice::FileAccessTime));
> +receivedFile.setFileTime(dt, 
> QFileDevice::FileTime(QFileDevice::FileModificationTime));
> +}

You can remove the FileTime() type conversion, just do setFileTime(dt, 
QFileDevice::FileModificationTime)

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D22105

To: brute4s99, albertvaka, vonreth, sredman, sitter, dfaure
Cc: pino, andriusr, kde-frameworks-devel, kfm-devel, aprcela, fprice, 
LeGast00n, sbergeron, fbampaloukas, alexde, feverfew, meven, michaelh, spoorun, 
navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp, mikesomov

D21795: [KAuth] Add support for action details in Polkit1 backend.

[Harald Sitter]

sitter requested changes to this revision.
sitter added a comment.
This revision now requires changes to proceed.


  The way details are enumerated needs changing IMO. And this effectively bumps 
the required polkitqt version through exactly one call, so maybe an #if 
conditional to not have the forced bump might be good

INLINE COMMENTS

> AuthBackend.h:61
>  virtual bool isCallerAuthorized(const QString , QByteArray 
> callerID) = 0;
> +virtual bool isCallerAuthorized(const QString , const DetailsMap 
> , QByteArray callerID) = 0; // KF6 TODO Merge
>  virtual bool actionExists(const QString );

I didn't check super carefully but at a glance the backend api is not public 
API so we could probably refactor this right now already.

Also, shouldn't the callerID be a const ref?

> DBusHelperProxy.cpp:109
>  
> +qDebug() << details;
>  QList args;

left over debugging? either remove or categorize

> Polkit1Backend.cpp:187
> +QMap polkit1Details;
> +for (auto it = details.begin(); it != details.end(); ++it) {
> +polkit1Details.insert(it.key(), it.value().toString());

you want constBegin/End here

> Polkit1Backend.cpp:193
>  , SLOT(requestQuit(PolkitQt1::Authority::Result)));
> -authority->checkAuthorization(action, subject, 
> PolkitQt1::Authority::AllowUserInteraction);
> +authority->checkAuthorizationWithDetails(action, subject, 
> PolkitQt1::Authority::AllowUserInteraction, polkit1Details);
>  e.exec();

looks to me this was only added 4 months ago. so this would probably require a 
version bump. seeing as we are fairly conservative with frameworks' 
requirements it may be better to `if version>=whatevs` the call.

> kauthaction.cpp:77
>  Action::Action(const QString , const QString )
>  : d(new ActionData())
>  {

you could just delegate to the new constructor here instead of having two code 
duplicated ctors.

> kauthaction.h:236
> + */
> +void setDetails(const DetailsMap );
> +

this seems like super leaky abstraction. you are allowing the caller to set 
backend specific stuff here. I think it'd be much better to make an enum for 
detail types, and have this be a QMap of enum,QVariant.

if the caller sets polkit.message then that won't apply to the mac backend even 
if someone were to implement the relevant functionality there. if it is a 
general purpose enum key each backend can easily implement or ignore as 
necessary

> kauthaction.h:246
> + */
> +QString details() const; // KF6 TODO: Remove
>  

Should the old functions maybe be marked deprecated?

REPOSITORY
  R283 KAuth

REVISION DETAIL
  https://phabricator.kde.org/D21795

To: chinmoyr, apol, bruns, davidedmundson, #frameworks, dfaure, cfeck, sitter
Cc: sitter, mreeves, kde-frameworks-devel, LeGast00n, sbergeron, michaelh, 
ngraham, bruns

D22105: WIP : Fix SFTP Plugin of KIO for Windows

[Piyush Aggarwal]

brute4s99 added inline comments.

INLINE COMMENTS

> pino wrote in kio_sftp.cpp:2050-2051
> what is this commented code for?

it uses buff.st_atime . Since I'm removing use of buff, I'm not sure how to 
handle this. For now I've commented out setting the file access time 
instruction for now.

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D22105

To: brute4s99, albertvaka, vonreth, sredman, sitter, dfaure
Cc: pino, andriusr, kde-frameworks-devel, kfm-devel, aprcela, fprice, 
LeGast00n, sbergeron, fbampaloukas, alexde, feverfew, meven, michaelh, spoorun, 
navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp, mikesomov

D22606: add missing semicolon

[Pino Toscano]

pino added a comment.


  Patch landed, and build successfully everywhere.
  Congratulations for your first patch :)

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D22606

To: antonioh, pino
Cc: pino, kde-frameworks-devel, #baloo, LeGast00n, sbergeron, fbampaloukas, 
domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams

D22606: add missing semicolon

[Pino Toscano]

pino closed this revision.

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D22606

To: antonioh, pino
Cc: pino, kde-frameworks-devel, #baloo, LeGast00n, sbergeron, fbampaloukas, 
domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams

D22606: add missing semicolon

[Antonio Huete Jimenez]

antonioh added a comment.


  No, I don't have permissions to push that I know of, here are my details:  
Antonio Huete Jimenez 

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D22606

To: antonioh, pino
Cc: pino, kde-frameworks-devel, #baloo, LeGast00n, sbergeron, fbampaloukas, 
domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams

D14631: Adds a new RenameDialog to KIO with more options for batch renaming

[David Faure]

dfaure added a comment.


  KIO::move (implemented by CopyJob) can move N files to a single destination 
directory, but they get the same name at that dest.
  KIO::moveAs (implemented by CopyJob too) can move/rename a single file to a 
specific filename at destination.
  
  What you're suggesting is a new job that can move N files to a destination 
directory (to make this generic it doesn't have to be in-place renames, 
right?), but you're providing the filename at destination for each file, right?
  This sounds good to me. I could imagine this being handled by CopyJob too.
  The struct CopyInfo already stores source and destination URLs for every 
file, it's just that the destination URL is filled in 
CopyJobPrivate::slotResultStating by appending the filename to the dest dir, 
except in moveAs (m_asMethod==true) where the destination URL *is* the final 
filename.
  I could imagine a KIO::moveAs that takes two QList and then this 
information is fetched from there rather than using m_dest.
  In fact, if the existing moveAs() method is ported to call the two-QLists 
one, that will mean less special casing in the code (which wouldn't use m_dest 
anymore in slotResultStating, when m_asMethod).

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D14631

To: emateli, #frameworks, dfaure, mlaurent
Cc: anthonyfieroni, chinmoyr, mlaurent, asensi, rkflx, dfaure, aacid, ngraham, 
kde-frameworks-devel, LeGast00n, sbergeron, michaelh, bruns

D22606: add missing semicolon

[Pino Toscano]

pino accepted this revision.
pino added a comment.
This revision is now accepted and ready to land.


  Do you have permissions to push patches on your own? If not, please specify 
your email so I can properly attribute this patch to you.

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D22606

To: antonioh, pino
Cc: pino, kde-frameworks-devel, #baloo, LeGast00n, sbergeron, fbampaloukas, 
domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams

D22606: add missing semicolon

[Antonio Huete Jimenez]

antonioh created this revision.
Herald added projects: Frameworks, Baloo.
Herald added subscribers: Baloo, kde-frameworks-devel.
antonioh requested review of this revision.

REVISION SUMMARY
  There was a missing semicolon in the non xattr case

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D22606

AFFECTED FILES
  src/xattr_p.h

To: antonioh
Cc: kde-frameworks-devel, #baloo, LeGast00n, sbergeron, fbampaloukas, domson, 
ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams

D22580: Notify users when not using KDE_INSTALL_USE_QT_SYS_PATHS about prefix.sh

[Christophe Giboudeaux]

cgiboudeaux added a comment.


  Thinking again: KDE_INSTALL_USE_QT_SYS_PATHS has no effect on XDG_CONFIG_DIRS 
and XDG_DATA_DIRS. Running prefix.sh is useful even if 
KDE_INSTALL_USE_QT_SYS_PATHS is true.

REPOSITORY
  R240 Extra CMake Modules

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D22580

To: apol, #frameworks, albertvaka, cgiboudeaux
Cc: cgiboudeaux, albertvaka, kde-frameworks-devel, kde-buildsystem, LeGast00n, 
sbergeron, bencreasy, michaelh, ngraham, bruns

D22599: Make first and last name available separately

[Pino Toscano]

pino added a comment.


  How would first + last name work, when
  a) you have multiple first names
  b) you have multiple last names
  c) you have only one "name" -- http://wookware.org/name.html

REPOSITORY
  R307 KPeople

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D22599

To: jbbgameich, #plasma:_mobile, apol
Cc: pino, kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns

D14631: Adds a new RenameDialog to KIO with more options for batch renaming

[Emirald Mateli]

emateli added a comment.


  Before continuing work I'd like to hear some opinions on this.
  
  1. From @dfaure or other people at frameworks: How do we handle batch rejame 
jobs. Should I create a new patch to submit a basic batch move job that simply 
moves files around without any additional processing, that way it can also 
serve as a generic batch move job(I have written in previous comments more on 
this how I think it should look like). As I don't think going back to doing 
many single move jobs is the best of ideas. Also this patch is getting way too 
big and difficult to review.
  2. From everyone else (also pinging @ngraham) since we're doing this and the 
code sans the KIO batch stuff is almost done, are there any additional features 
we might want to take into consideration? E.g: File metadata?

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D14631

To: emateli, #frameworks, dfaure, mlaurent
Cc: anthonyfieroni, chinmoyr, mlaurent, asensi, rkflx, dfaure, aacid, ngraham, 
kde-frameworks-devel, LeGast00n, sbergeron, michaelh, bruns

D22580: Notify users when not using KDE_INSTALL_USE_QT_SYS_PATHS about prefix.sh

[Christophe Giboudeaux]

cgiboudeaux accepted this revision.

REPOSITORY
  R240 Extra CMake Modules

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D22580

To: apol, #frameworks, albertvaka, cgiboudeaux
Cc: cgiboudeaux, albertvaka, kde-frameworks-devel, kde-buildsystem, LeGast00n, 
sbergeron, bencreasy, michaelh, ngraham, bruns

D22599: Make first and last name available separately

[Aleix Pol Gonzalez]

apol accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R307 KPeople

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D22599

To: jbbgameich, #plasma:_mobile, apol
Cc: kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.13 - Build # 7 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.13/7/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Sun, 21 Jul 2019 08:36:37 +
 Build duration:
29 min and counting
   JUnit Tests
  Name: projectroot Failed: 5 test(s), Passed: 47 test(s), Skipped: 0 test(s), Total: 52 test(s)Failed: projectroot.autotests.kiocore_jobtestFailed: projectroot.autotests.kiocore_kmountpointtestFailed: projectroot.autotests.kiocore_ktcpsockettestFailed: projectroot.autotests.kiowidgets_kdirlistertestFailed: projectroot.autotests.kiowidgets_kdirmodeltestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)

D22586: KRun QML proxy: fix path/URL confusion

[Aleix Pol Gonzalez]

apol added a comment.


  In D22586#498715 , @dfaure wrote:
  
  > You'd think I would remember my own APIs :-)
  
  
  ;-)

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D22586

To: dfaure, davidedmundson
Cc: apol, kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns

D22580: Notify users when not using KDE_INSTALL_USE_QT_SYS_PATHS about prefix.sh

[Aleix Pol Gonzalez]

apol marked an inline comment as done.

REPOSITORY
  R240 Extra CMake Modules

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D22580

To: apol, #frameworks, albertvaka
Cc: cgiboudeaux, albertvaka, kde-frameworks-devel, kde-buildsystem, LeGast00n, 
sbergeron, bencreasy, michaelh, ngraham, bruns

D22580: Notify users when not using KDE_INSTALL_USE_QT_SYS_PATHS about prefix.sh

[Aleix Pol Gonzalez]

apol updated this revision to Diff 62169.
apol added a comment.


  Support older cmakes

REPOSITORY
  R240 Extra CMake Modules

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22580?vs=62110=62169

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D22580

AFFECTED FILES
  kde-modules/KDEInstallDirs.cmake

To: apol, #frameworks, albertvaka
Cc: cgiboudeaux, albertvaka, kde-frameworks-devel, kde-buildsystem, LeGast00n, 
sbergeron, bencreasy, michaelh, ngraham, bruns

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.12 - Build # 145 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.12/145/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Sun, 21 Jul 2019 08:36:38 +
 Build duration:
20 min and counting
   BUILD ARTIFACTS
  acc/KF5KIO-5.61.0.xmllogs/KF5KIO/5.61.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 0 test(s), Passed: 52 test(s), Skipped: 0 test(s), Total: 52 test(s)Name: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report64%
(23/36)66%
(264/402)66%
(264/402)55%
(33525/61108)39%
(17062/43977)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(57/57)100%
(57/57)95%
(9370/9820)48%
(4287/9013)autotests.http100%
(5/5)100%
(5/5)99%
(581/582)68%
(108/160)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(179/197)72%
(49/68)src100%
(1/1)100%
(1/1)86%
(6/7)67%
(4/6)src.core86%
(100/116)86%
(100/116)59%
(8561/14465)51%
(4704/9219)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets68%
(26/38)68%
(26/38)56%
(4597/8216)42%
(2000/4771)src.gui100%
(2/2)100%
(2/2)94%
(102/108)74%
(49/66)src.ioslaves.file100%
(7/7)100%
(7/7)54%
(653/1204)39%
(372/954)src.ioslaves.file.kauth0%
(0/2)0%
(0/2)0%
(0/168)0%
(0/89)src.ioslaves.ftp0%
(0/1)0%
(0/1)0%
(0/1343)0%
(0/1416)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/248)0%
(0/148)src.ioslaves.http88%
(7/8)88%
(7/8)42%
(1793/4290)36%
(1314/3670)src.ioslaves.http.kcookiejar33%
(2/6)33%
(2/6)47%
(630/1330)56%
(601/1081)src.ioslaves.remote100%
(2/2)100%
(2/2)27%
(73/267)8%
(14/184)src.ioslaves.remote.kdedmodule0%
(0/2)0%
(0/2)0%
   

D19903: Fix build with msvc

[Albert Astals Cid]

aacid requested changes to this revision.
aacid added a comment.
This revision now requires changes to proceed.


  yep, having it build with gcc is important :)

REPOSITORY
  R159 KActivities Statistics

REVISION DETAIL
  https://phabricator.kde.org/D19903

To: vonreth, mlaurent, davidedmundson, aacid
Cc: kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.13 - Build # 13 - Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.13/13/
 Project:
kf5-qt5 SUSEQt5.13
 Date of build:
Sun, 21 Jul 2019 08:36:38 +
 Build duration:
15 min and counting
   BUILD ARTIFACTS
  acc/KF5KIO-5.61.0.xmllogs/KF5KIO/5.61.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 51 test(s), Skipped: 0 test(s), Total: 52 test(s)Failed: projectroot.autotests.kiofilewidgets_kfilewidgettestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report64%
(23/36)66%
(264/402)66%
(264/402)55%
(33512/61108)39%
(17063/43977)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(57/57)100%
(57/57)95%
(9370/9820)48%
(4291/9013)autotests.http100%
(5/5)100%
(5/5)99%
(581/582)68%
(108/160)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(179/197)72%
(49/68)src100%
(1/1)100%
(1/1)86%
(6/7)67%
(4/6)src.core86%
(100/116)86%
(100/116)59%
(8557/14465)51%
(4704/9219)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets68%
(26/38)68%
(26/38)56%
(4594/8216)42%
(1999/4771)src.gui100%
(2/2)100%
(2/2)94%
(102/108)74%
(49/66)src.ioslaves.file100%
(7/7)100%
(7/7)54%
(653/1204)39%
(372/954)src.ioslaves.file.kauth0%
(0/2)0%
(0/2)0%
(0/168)0%
(0/89)src.ioslaves.ftp0%
(0/1)0%
(0/1)0%
(0/1343)0%
(0/1416)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/248)0%
(0/148)src.ioslaves.http88%
(7/8)88%
(7/8)42%
(1793/4290)36%
(1314/3670)src.ioslaves.http.kcookiejar33%
(2/6)33%
(2/6)47%
(630/1330)56%
(601/1081)src.ioslaves.remote100%
(2/2)100%
(2/2)27%
(73/267)8%
(14/184)src.ioslaves.remote.kdedmodule0%
(0/2)0%
   

KDE CI: Frameworks » plasma-framework » kf5-qt5 FreeBSDQt5.13 - Build # 11 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20FreeBSDQt5.13/11/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Sun, 21 Jul 2019 08:10:07 +
 Build duration:
38 min and counting
   JUnit Tests
  Name: projectroot Failed: 6 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 14 test(s)Failed: projectroot.autotests.dialognativetestFailed: projectroot.autotests.plasma_configmodeltestFailed: projectroot.autotests.plasma_fallbackpackagetestFailed: projectroot.autotests.plasma_iconitemtestFailed: projectroot.autotests.plasma_packagestructuretestFailed: projectroot.autotests.plasma_storagetest

D22105: WIP : Fix SFTP Plugin of KIO for Windows

[Pino Toscano]

pino added inline comments.

INLINE COMMENTS

> kio_sftp.cpp:2047
> +QString error_msg = receivedFile.errorString();
> +qDebug() << QStringLiteral("Couldn't update modified 
> time : ") << error_msg;
> +}

no need for QStringLiteral here, sending a `const char *` to debug is perfectly 
fine; also, the qDebug must be categorized, just like all the other debug 
outputs

> kio_sftp.cpp:2050-2051
> +else {
> +// 
> receivedFile.setFileTime(QDateTime::fromTime_t(buff.st_atime),
> +// 
> QFileDevice::FileTime(QFileDevice::FileAccessTime));
> +receivedFile.setFileTime(dt, 
> QFileDevice::FileTime(QFileDevice::FileModificationTime));

what is this commented code for?

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D22105

To: brute4s99, albertvaka, vonreth, sredman, sitter, dfaure
Cc: pino, andriusr, kde-frameworks-devel, kfm-devel, aprcela, fprice, 
LeGast00n, sbergeron, fbampaloukas, alexde, feverfew, meven, michaelh, spoorun, 
navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp, mikesomov

D22419: Fix can't enter directory error on some FTP servers with Turkish locale

[Albert Astals Cid]

aacid closed this revision.

REVISION DETAIL
  https://phabricator.kde.org/D22419

To: nxiss7, #frameworks, dfaure
Cc: dfaure, aacid, svuorela, kde-frameworks-devel, LeGast00n, sbergeron, 
michaelh, ngraham, bruns

D22105: WIP : Fix SFTP Plugin of KIO for Windows

[Hannah von Reth]

vonreth added a comment.


  Please revert the changes to qCDebug

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D22105

To: brute4s99, albertvaka, vonreth, sredman, sitter, dfaure
Cc: andriusr, kde-frameworks-devel, kfm-devel, aprcela, fprice, LeGast00n, 
sbergeron, fbampaloukas, alexde, feverfew, meven, michaelh, spoorun, 
navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp, mikesomov

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.13 - Build # 15 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.13/15/
 Project:
kf5-qt5 SUSEQt5.13
 Date of build:
Sun, 21 Jul 2019 08:10:08 +
 Build duration:
5 min 52 sec and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5Plasma-5.61.0.xmlacc/KF5PlasmaQuick-5.61.0.xmlcompat_reports/KF5Plasma_compat_report.htmllogs/KF5Plasma/5.61.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 6 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 14 test(s)Failed: projectroot.autotests.dialognativetestFailed: projectroot.autotests.plasma_configmodeltestFailed: projectroot.autotests.plasma_fallbackpackagetestFailed: projectroot.autotests.plasma_iconitemtestFailed: projectroot.autotests.plasma_packagestructuretestFailed: projectroot.autotests.plasma_storagetest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report33%
(6/18)36%
(45/126)36%
(45/126)27%
(3629/13391)18%
(1823/9898)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests86%
(12/14)86%
(12/14)55%
(612/1119)29%
(315/1090)src.declarativeimports.calendar0%
(0/6)0%
(0/6)0%
(0/471)0%
(0/243)src.declarativeimports.core31%
(5/16)31%
(5/16)14%
(314/2281)6%
(92/1479)src.declarativeimports.plasmacomponents0%
(0/6)0%
(0/6)0%
(0/518)0%
(0/207)src.declarativeimports.plasmaextracomponents0%
(0/3)0%
(0/3)0%
(0/42)0%
(0/22)src.declarativeimports.platformcomponents0%
(0/3)0%
(0/3)0%
(0/58)0%
(0/14)src.declarativeimports.platformcomponents.utils0%
(0/2)0%
(0/2)0%
(0/14)0%
(0/2)src.plasma64%
(14/22)64%
(14/22)41%
(1419/3490)28%
(794/2841)src.plasma.packagestructure0%
(0/7)0%
(0/7)0%
(0/134)0%
(0/12)src.plasma.private50%
(9/18)50%
(9/18)43%
(679/1580)29%
(301/1048)src.plasma.scripting0%
(0/3)0%
(0/3)0%
(0/171)0%
(0/113)src.plasmapkg0%
(0/1)0%
(0/1)0%
(0/45)0%
(0/40)src.plasmaquick33%
(4/12)33%
(4/12)28%
(574/2024)18%
(316/1729)src.plasmaquick.private50%
(1/2)50%
(1/2)29%
(31/106)36%
(5/14)src.scriptengines.qml.plasmoid0%
(0/6)0%
(0/6)0%
(0/1183)0%

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.12 - Build # 138 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.12/138/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Sun, 21 Jul 2019 08:10:07 +
 Build duration:
5 min 49 sec and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5Plasma-5.61.0.xmlacc/KF5PlasmaQuick-5.61.0.xmlcompat_reports/KF5Plasma_compat_report.htmllogs/KF5Plasma/5.61.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 6 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 14 test(s)Failed: projectroot.autotests.dialognativetestFailed: projectroot.autotests.plasma_configmodeltestFailed: projectroot.autotests.plasma_fallbackpackagetestFailed: projectroot.autotests.plasma_iconitemtestFailed: projectroot.autotests.plasma_packagestructuretestFailed: projectroot.autotests.plasma_storagetest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report33%
(6/18)36%
(45/126)36%
(45/126)27%
(3633/13392)18%
(1824/9898)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests86%
(12/14)86%
(12/14)55%
(612/1119)29%
(315/1090)src.declarativeimports.calendar0%
(0/6)0%
(0/6)0%
(0/471)0%
(0/243)src.declarativeimports.core31%
(5/16)31%
(5/16)14%
(314/2281)6%
(92/1479)src.declarativeimports.plasmacomponents0%
(0/6)0%
(0/6)0%
(0/518)0%
(0/207)src.declarativeimports.plasmaextracomponents0%
(0/3)0%
(0/3)0%
(0/42)0%
(0/22)src.declarativeimports.platformcomponents0%
(0/3)0%
(0/3)0%
(0/58)0%
(0/14)src.declarativeimports.platformcomponents.utils0%
(0/2)0%
(0/2)0%
(0/14)0%
(0/2)src.plasma64%
(14/22)64%
(14/22)41%
(1419/3490)28%
(794/2841)src.plasma.packagestructure0%
(0/7)0%
(0/7)0%
(0/134)0%
(0/12)src.plasma.private50%
(9/18)50%
(9/18)43%
(679/1580)29%
(301/1048)src.plasma.scripting0%
(0/3)0%
(0/3)0%
(0/171)0%
(0/113)src.plasmapkg0%
(0/1)0%
(0/1)0%
(0/45)0%
(0/40)src.plasmaquick33%
(4/12)33%
(4/12)29%
(578/2025)18%
(317/1729)src.plasmaquick.private50%
(1/2)50%
(1/2)29%
(31/106)36%
(5/14)src.scriptengines.qml.plasmoid0%
(0/6)0%
(0/6)0%
(0/1183)0%
   

D18114: FakeInput: add support for pointer move with absolute coordinates

[Jan Grulich]

jgrulich added a comment.


  In D18114#498642 , @romangg wrote:
  
  > @jgrulich With D22571  looking 
promising do you want to put the keyboard parts of this diff into a separate 
one? There is still the question about keysyms and key events but we should 
discuss this in the new diff. Maybe we can have both: Keysyms for special keys 
/ combinations like Alt+Tab and text input via text-input protocol?
  
  
  I currently don't have that much time to look into this, but I'm glad we can 
move with this further. Maybe Akademy is a good opportunity to work on this, 
there are also some things which would be nice to improve in screen sharing 
support.

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D18114

To: jgrulich, davidedmundson, graesslin, zzag
Cc: romangg, graesslin, zzag, kde-frameworks-devel, LeGast00n, sbergeron, 
michaelh, ngraham, bruns