D27444: Added plasmoid heading svg

[Noah Davis]

ndavis added a comment.


  Why do the outside edges have different opacity from the center part?
  
  BTW, this patch is saying it depends on a commit that doesn't exist in git 
master.

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  top_area (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27444

To: niccolove, #vdg, ngraham, ndavis
Cc: mart, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, 
bruns

D28033: Create ExpandableListItem

[David Edmundson]

davidedmundson added inline comments.

INLINE COMMENTS

> ExpandableListItem.qml:2
> +/*
> + *   Copyright 2020 Nate Graham 
> + *

It shouldn't be in PC3. It's new API from qqc2.A

> ExpandableListItem.qml:23
> +import org.kde.plasma.core 2.0 as PlasmaCore
> +import org.kde.plasma.plasmoid 2.0
> +import org.kde.plasma.components 2.0 as PlasmaComponents

Unused?

> ExpandableListItem.qml:153
> +PlasmaComponents.Label {
> +id: listItemSubtitle
> +

Why pc2?

> ExpandableListItem.qml:179
> +
> +onClicked: collapse()
> +}

Shouldn't it run the default action?

> ExpandableListItem.qml:190
> +// TODO: or should it just be right-aligned?
> +implicitWidth: defaultActionButton.width
> +implicitHeight: defaultActionButton.height

Neve rdefine an implicit size from an actual size.

> ExpandableListItem.qml:230
> +NumberAnimation {
> +duration: units.longDuration * 3
> +easing.type: Easing.InOutCubic

Seems random

> ExpandableListItem.qml:235
> +
> +// Custom view; when defined, the actions list doesn't appear
> +Loader {

Sounds like you want 2 classes. One a subclass with the list as the custom view.

Then you don't need the container, or this switching.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D28033

To: ngraham, #vdg, #plasma
Cc: davidedmundson, bruns, niccolove, cblack, davidre, kde-frameworks-devel, 
LeGast00n, GB_2, michaelh, ngraham

D28033: Create ExpandableListItem

[Nathaniel Graham]

ngraham updated this revision to Diff 77603.
ngraham added a comment.


  - Add an opacity animation when expanded view is shown
  - Add a button on the right to expand and collapse the expanded view
  - Clean and simplify expand()/collapse() code a bit

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28033?vs=77582=77603

BRANCH
  ExpandableListItem (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28033

AFFECTED FILES
  src/declarativeimports/plasmacomponents3/ExpandableListItem.qml
  src/declarativeimports/plasmacomponents3/qmldir

To: ngraham, #vdg, #plasma
Cc: bruns, niccolove, cblack, davidre, kde-frameworks-devel, LeGast00n, GB_2, 
michaelh, ngraham

D27951: Allow users to change dropAction to MoveAction through kdeglobals

[Tranter Madi]

trmdi added a comment.


  In D27951#627283 , @ngraham wrote:
  
  > My interpretation of the use case is that a user who chooses dndToMove 
prefers Move over Copy and Link, but not necessarily Extract or Set as 
Wallpaper, since those are context-specific options that exist because they are 
potentially more useful than move, copy, or link.
  >
  > > If he wants to see the menu, he could hold the Shift modifier key.
  >
  > If he doesn't know that there are other options, then he has no way of 
knowing that he should hold down the shift key to see them.
  
  
  What if he is familiar with Windows behavior, or he likes the move action 
most? In that case the menu still is an annoyance to them.
  When he chose that, it's likely he likes that the most, and he dislikes/ 
doesn't care about others.
  I think the current implementation is balanced.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D27951

To: trmdi, ngraham, dfaure, meven, #vdg, davidedmundson
Cc: davidedmundson, meven, kde-frameworks-devel, LeGast00n, cblack, GB_2, 
michaelh, ngraham, bruns

D24390: Add more file and directories to exclude filters

[Stefan Brüns]

bruns abandoned this revision.
bruns added a comment.


  open questions unanswered, does not look right/useful

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D24390

To: bruns, #baloo, ngraham, ognarb
Cc: bruns, ngraham, kde-frameworks-devel, #baloo, hurikhan77, lots0logs, 
LeGast00n, cblack, fbampaloukas, GB_2, domson, ashaposhnikov, michaelh, 
astippich, spoorun, abrahams

D24390: Add more file and directories to exclude filters

[Stefan Brüns]

bruns commandeered this revision.
bruns added a reviewer: ognarb.
bruns added a comment.


  open questions unanswered ...

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D24390

To: bruns, #baloo, ngraham, ognarb
Cc: bruns, ngraham, kde-frameworks-devel, #baloo, hurikhan77, lots0logs, 
LeGast00n, cblack, fbampaloukas, GB_2, domson, ashaposhnikov, michaelh, 
astippich, spoorun, abrahams

D25743: Expose IndexerState enum to QML

[Stefan Brüns]

bruns added a comment.


  In D25743#619435 , @davidedmundson 
wrote:
  
  > > Ping.
  >
  > Will do on Sunday (after tagging)
  
  
  Which Sunday? ;-)

REPOSITORY
  R293 Baloo

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D25743

To: davidedmundson, #baloo, ngraham
Cc: bruns, broulik, kde-frameworks-devel, ngraham, #baloo, hurikhan77, 
lots0logs, LeGast00n, cblack, fbampaloukas, GB_2, domson, ashaposhnikov, 
michaelh, astippich, spoorun, abrahams

D28033: Create ExpandableListItem

[Nathaniel Graham]

ngraham added a comment.


  If it were a flat button, I'd want to make the default action button flat 
too, or else they wouldn't match. Here's how that would look: F8174983: 
Toolbuttons.png 
  
  And here's how it would look with both of them as non-flat PushButtons: 
F8174985: Screenshot_20200313_163524.png 
  
  For some strange reason, the ToolButton version seems to suffer from 
keming... :(

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D28033

To: ngraham, #vdg, #plasma
Cc: bruns, niccolove, cblack, davidre, kde-frameworks-devel, LeGast00n, GB_2, 
michaelh, ngraham

D28039: optimize dynamic regex matching

[Dominik Haumann]

dhaumann accepted this revision.
dhaumann added a comment.
This revision is now accepted and ready to land.


  I guess this is OK, but the concept of a "skip offset" is a bit fuzzy to me.

INLINE COMMENTS

> rule_p.h:126
> +
> +protected:
> +bool m_dynamic = false;

I dislike this protected hack :-)

REPOSITORY
  R216 Syntax Highlighting

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D28039

To: cullmann, dhaumann, vkrause, nibags
Cc: kwrite-devel, kde-frameworks-devel, rrosch, LeGast00n, cblack, GB_2, 
domson, michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann

D27695: WIP: Create a new TopArea element using widgets/toparea svg

[Nathaniel Graham]

ngraham added a task: T10470: Improve the visuals of tray popups.

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D27695

To: niccolove, mart, ngraham
Cc: ngraham, davidedmundson, ahiemstra, kde-frameworks-devel, LeGast00n, 
cblack, GB_2, michaelh, bruns

D27444: Added plasmoid heading svg

[Nathaniel Graham]

ngraham added a task: T10470: Improve the visuals of tray popups.

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  top_area (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27444

To: niccolove, #vdg, ngraham, ndavis
Cc: mart, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, 
bruns

D27695: WIP: Create a new TopArea element using widgets/toparea svg

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  Excellent work.

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D27695

To: niccolove, mart, ngraham
Cc: ngraham, davidedmundson, ahiemstra, kde-frameworks-devel, LeGast00n, 
cblack, GB_2, michaelh, bruns

D27444: Added plasmoid heading svg

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  @ndavis does the SVG look good to you?

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  top_area (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27444

To: niccolove, #vdg, ngraham, ndavis
Cc: mart, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, 
bruns

D27951: Allow users to change dropAction to MoveAction through kdeglobals

[Nathaniel Graham]

ngraham added a comment.


  In D27951#627078 , @trmdi wrote:
  
  > I think the user has to choose. When he chose dndToMove, that means he 
prefers the move action to others (copy, link, extract, set as wallpaper...)
  
  
  My interpretation of the use case is that a user who chooses dndToMove 
prefers Move over Copy and Link, but not necessarily Extract or Set as 
Wallpaper, since those are context-specific options that exist because they are 
potentially more useful than move, copy, or link.
  
  > If he wants to see the menu, he could hold the Shift modifier key.
  
  If he doesn't know that there are other options, then he has no way of 
knowing that he should hold down the shift key to see them.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D27951

To: trmdi, ngraham, dfaure, meven, #vdg, davidedmundson
Cc: davidedmundson, meven, kde-frameworks-devel, LeGast00n, cblack, GB_2, 
michaelh, ngraham, bruns

Re: KIO: try to assign an icon to action submenus

[Chloe Kudryavtsev]

On 3/13/20 2:18 PM, David Faure wrote:
> On mardi 3 mars 2020 18:29:47 CET Chloe Kudryavtsev wrote:
>> Currently, action submenus (X-KDE-Submenu) have no icons.
>> This patch makes it inherit the icon of the first action.
> 
> I wonder if this is always wanted? The icon for the first action might not be 
> representative of what the other actions do.
> 
> Wouldn't it be better to be able to explicitly specify the icon for the 
> submenu?
> 

That would be better, but that can't easily be done without reorganizing
how the whole thing works.
insertServicesSubmenus() currently receives a QMap, the target QMenu and a boolean.
Meanwhile, the icon for the desktop file as a whole would be available
in the KConfigGroup (from desktopFile).

Basically, making the "global" (i.e [Desktop Entry]) Icon setting be
what is used would require breaking API (changing the signature of
insertServicesSubmenus).
In the meanwhile, in practice, ServiceMenus do have (at the very least)
similar icons, because TryExec is effectively global (there is no
support for disabling individual actions, it's done purely on a
per-desktop-file basis).
Ideally, of course, everything would be explicit, but the amount of
changes quickly grows if one wants to do this right.

I would participate in an effort to extend KConfig, KIO and co. to
improve the overall handling of .desktop files, but the process in
general is kind of a bother, and I don't really like touching C++
nowadays either, so it's a hard sell to put that as a high priority for me.
-


0xEB24BAD412DE2823.asc
Description: application/pgp-keys


signature.asc
Description: OpenPGP digital signature

D27544: Fix update scenarios with no explicit downloadlink selected

[Nathaniel Graham]

ngraham accepted this revision as: ngraham.
ngraham added a comment.
This revision is now accepted and ready to land.


  Probably wait for at least one more review from someone smarter and more 
familiar with this code than I am. :)

REPOSITORY
  R304 KNewStuff

BRANCH
  fix-update (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27544

To: leinir, #knewstuff, #frameworks, #plasma, ngraham, apol, 
#discover_software_store
Cc: alexde, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, 
bruns

T11950: Reduce the pain of working on monochrome Breeze icons

[David Hurka]

davidhurka added a comment.


  This is how my source file for find-location (D27983 
) looks in inkscape.
  
  F8174793: Screenshot_20200313_201936.png 

  
  Would it be nice to post such screenshots in Revisions, instead of 
montage-breeze-dark images? Theese are a bit redundant with automated tools. 
The screenshot would make it easy to spot pixel-misalignments.
  
  The montage-breeze output should stay, to see how the icon looks at original 
size. Or is another inkscape screenshot at original size (Key 1) sufficient?
  
  F8174818: Screenshot_20200313_203610.png 


TASK DETAIL
  https://phabricator.kde.org/T11950

To: ngraham, davidhurka
Cc: davidhurka, mglb, #frameworks, mart, trickyricky26, ndavis, #vdg, ngraham, 
manueljlin, Orage, LeGast00n, cblack, konkinartem, ian, jguidon, Ghost6, 
jraleigh, MrPepe, fbampaloukas, squeakypancakes, alexde, IohannesPetros, GB_2, 
michaelh, crozbo, firef, bruns, skadinna, aaronhoneycutt, mbohlender

D28039: optimize dynamic regex matching

[Christoph Cullmann]

cullmann added a comment.


  For the example from the bug this makes the difference between ~30 seconds on 
a 4 Ghz machine to << 1 second ;=)

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D28039

To: cullmann, dhaumann, vkrause, nibags
Cc: kwrite-devel, kde-frameworks-devel, rrosch, LeGast00n, cblack, GB_2, 
domson, michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann

D28039: optimize dynamic regex matching

[Christoph Cullmann]

cullmann created this revision.
cullmann added reviewers: dhaumann, vkrause, nibags.
Herald added projects: Kate, Frameworks.
Herald added subscribers: kde-frameworks-devel, kwrite-devel.
cullmann requested review of this revision.

REVISION SUMMARY
  allow such matches to be cached, too, by guarding the cache
  with the last used captures
  
  makes VHDL highlighting instantanious for bug 418778
  
  BUG: 418778

TEST PLAN
  make && make test
  
  example from bug 418778 is fast!

REPOSITORY
  R216 Syntax Highlighting

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D28039

AFFECTED FILES
  src/lib/abstracthighlighter.cpp
  src/lib/rule.cpp
  src/lib/rule_p.h

To: cullmann, dhaumann, vkrause, nibags
Cc: kwrite-devel, kde-frameworks-devel, rrosch, LeGast00n, cblack, GB_2, 
domson, michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann

D28014: smb: do not double finish

[Nathaniel Graham]

ngraham accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R320 KIO Extras

BRANCH
  smb-mount-doublefinish

REVISION DETAIL
  https://phabricator.kde.org/D28014

To: sitter, ngraham
Cc: kde-frameworks-devel, kfm-devel, pberestov, iasensio, fprice, LeGast00n, 
cblack, MrPepe, fbampaloukas, alexde, GB_2, Codezela, feverfew, meven, 
michaelh, spoorun, navarromorales, firef, ngraham, andrebarros, bruns, 
emmanuelp, mikesomov

D28015: extend indexer to detect dynamic=true regexes that have no place holders to adapt

[Christoph Cullmann]

cullmann added a comment.


  Better, but VHDL hl is still very slow, need to take a deeper look into it :/

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D28015

To: cullmann, nibags, dhaumann, vkrause
Cc: kwrite-devel, kde-frameworks-devel, rrosch, LeGast00n, cblack, GB_2, 
domson, michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann

D28015: extend indexer to detect dynamic=true regexes that have no place holders to adapt

[Christoph Cullmann]

This revision was automatically updated to reflect the committed changes.
Closed by commit R216:e6090be50f0d: extend indexer to detect dynamic=true 
regexes that have no place holders to… (authored by cullmann).

REPOSITORY
  R216 Syntax Highlighting

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28015?vs=77526=77590

REVISION DETAIL
  https://phabricator.kde.org/D28015

AFFECTED FILES
  src/indexer/katehighlightingindexer.cpp

To: cullmann, nibags, dhaumann, vkrause
Cc: kwrite-devel, kde-frameworks-devel, rrosch, LeGast00n, cblack, GB_2, 
domson, michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann

Re: KIO: try to assign an icon to action submenus

[David Faure]

On mardi 3 mars 2020 18:29:47 CET Chloe Kudryavtsev wrote:
> Currently, action submenus (X-KDE-Submenu) have no icons.
> This patch makes it inherit the icon of the first action.

I wonder if this is always wanted? The icon for the first action might not be 
representative of what the other actions do.

Wouldn't it be better to be able to explicitly specify the icon for the 
submenu?

-- 
David Faure, fa...@kde.org, http://www.davidfaure.fr
Working on KDE Frameworks 5

D27695: WIP: Create a new TopArea element using widgets/toparea svg

[Niccolò Venerandi]

niccolove added a comment.


  Works for me!

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D27695

To: niccolove, mart, ngraham
Cc: ngraham, davidedmundson, ahiemstra, kde-frameworks-devel, LeGast00n, 
cblack, GB_2, michaelh, bruns

D28033: Create ExpandableListItem

[Nathaniel Graham]

ngraham edited the test plan for this revision.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D28033

To: ngraham, #vdg, #plasma
Cc: bruns, niccolove, cblack, davidre, kde-frameworks-devel, LeGast00n, GB_2, 
michaelh, ngraham

D28033: Create ExpandableListItem

[David Redondo]

davidre added a comment.


  In D28033#627192 , @ngraham wrote:
  
  > In D28033#627184 , @cblack wrote:
  >
  > > In D28033#627180 , @davidre 
wrote:
  > >
  > > > I would love if we could find a way to show that the item is expandable
  > >
  > >
  > > I would probably use a pointing down arrow without a stem when collapsed, 
and pointing up when open.
  >
  >
  > Makes sense to me. Where would the arrow go though?
  >
  > In D28033#627186 , @niccolove 
wrote:
  >
  > > Strongly agree on having a single component. By the way, all these lists 
have the issue that the button only appearing on hover is very 
touch-unfriendly. This does not have to be addressed in this patch, but it 
having it implemented in only one place makes it much easier to fix.
  >
  >
  > Yeah, I could have the highlight remain in place if Qt detects that the 
click was actually a touch, and then the button would appear when the list item 
it touched.
  >
  > However the expanded view itself is not very touch-friendly since the 
individual list items are really too short to be easily touchable.
  
  
  I would put it in a flat button on the right

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D28033

To: ngraham, #vdg, #plasma
Cc: bruns, niccolove, cblack, davidre, kde-frameworks-devel, LeGast00n, GB_2, 
michaelh, ngraham

D28033: Create ExpandableListItem

[Nathaniel Graham]

ngraham added a comment.


  In D28033#627184 , @cblack wrote:
  
  > In D28033#627180 , @davidre 
wrote:
  >
  > > I would love if we could find a way to show that the item is expandable
  >
  >
  > I would probably use a pointing down arrow without a stem when collapsed, 
and pointing up when open.
  
  
  Makes sense to me. Where would the arrow go though?
  
  In D28033#627186 , @niccolove 
wrote:
  
  > Strongly agree on having a single component. By the way, all these lists 
have the issue that the button only appearing on hover is very 
touch-unfriendly. This does not have to be addressed in this patch, but it 
having it implemented in only one place makes it much easier to fix.
  
  
  Yeah, I could have the highlight remain in place if Qt detects that the click 
was actually a touch, and then the button would appear when the list item it 
touched.
  
  However the expanded view itself is not very touch-friendly since the 
individual list items are really too short to be easily touchable.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D28033

To: ngraham, #vdg, #plasma
Cc: bruns, niccolove, cblack, davidre, kde-frameworks-devel, LeGast00n, GB_2, 
michaelh, ngraham

D27695: WIP: Create a new TopArea element using widgets/toparea svg

[Niccolò Venerandi]

niccolove updated this revision to Diff 77588.
niccolove added a comment.


  Fixed inset

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27695?vs=77482=77588

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D27695

AFFECTED FILES
  src/declarativeimports/plasmaextracomponents/qml/PlasmoidHeading.qml
  src/declarativeimports/plasmaextracomponents/qml/qmldir

To: niccolove, mart, ngraham
Cc: ngraham, davidedmundson, ahiemstra, kde-frameworks-devel, LeGast00n, 
cblack, GB_2, michaelh, bruns

D28033: Create ExpandableListItem

[Nathaniel Graham]

ngraham added a subscriber: bruns.
ngraham added a comment.


  Discussion points:
  
  - Is this even the right paradigm to use for extra actions? Or should we 
instead use a SwipeListItem and put the extra actions in an overflow menu, and 
use the expanded view only for custom content?
  - Should this be in Kirigami instead? Discover also uses this paradigm, and I 
see that @bruns has just adopted it in D28025 
 too. Currently it is in PlasmaComponents 
because it needs to be able to switch to Plasma SVGs when the applet needs it 
(e.g. for Networks).
  - I need help porting Device Notifier to use this. I started and got a bit 
overwhelmed as it is quite a bit more complicated than any of the other applets.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D28033

To: ngraham, #vdg, #plasma
Cc: bruns, niccolove, cblack, davidre, kde-frameworks-devel, LeGast00n, GB_2, 
michaelh, ngraham

D28033: Create ExpandableListItem

[Niccolò Venerandi]

niccolove added a comment.


  Strongly agree on having a single component. By the way, all these lists have 
the issue that the button only appearing on hover is very touch-unfriendly. 
This does not have to be addressed in this patch, but it having it implemented 
in only one place makes it much easier to fix.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D28033

To: ngraham, #vdg, #plasma
Cc: niccolove, cblack, davidre, kde-frameworks-devel, LeGast00n, GB_2, 
michaelh, ngraham, bruns

D28033: Create ExpandableListItem

[Carson Black]

cblack added a comment.


  In D28033#627180 , @davidre wrote:
  
  > I would love if we could find a way to show that the item is expandable
  
  
  I would probably use a pointing down arrow without a stem when collapsed, and 
pointing up when open.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D28033

To: ngraham, #vdg, #plasma
Cc: cblack, davidre, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, 
bruns

D28032: [StorageDevices] Fix order of notification connect and initialization

[Stefan Brüns]

This revision was automatically updated to reflect the committed changes.
Closed by commit R293:d771f908cb44: [StorageDevices] Fix order of notification 
connect and initialization (authored by bruns).

REPOSITORY
  R293 Baloo

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28032?vs=77581=77587

REVISION DETAIL
  https://phabricator.kde.org/D28032

AFFECTED FILES
  src/file/storagedevices.cpp

To: bruns, #baloo, ngraham, davidedmundson
Cc: kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, cblack, 
fbampaloukas, GB_2, domson, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

D28033: Create ExpandableListItem

[David Redondo]

davidre added a comment.


  I would love if we could find a way to show that the item is expandable

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D28033

To: ngraham, #vdg, #plasma
Cc: davidre, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, 
bruns

D28033: Create ExpandableListItem

[Nathaniel Graham]

ngraham added a dependent revision: D28037: [Applet] Port to ExpandableListItem.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D28033

To: ngraham, #vdg, #plasma
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28032: [StorageDevices] Fix order of notification connect and initialization

[David Edmundson]

davidedmundson accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R293 Baloo

BRANCH
  submit

REVISION DETAIL
  https://phabricator.kde.org/D28032

To: bruns, #baloo, ngraham, davidedmundson
Cc: kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, cblack, 
fbampaloukas, GB_2, domson, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

D28033: Create ExpandableListItem

[Nathaniel Graham]

ngraham added a dependent revision: D28035: [Applet] Port to ExpandableListItem.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D28033

To: ngraham, #vdg, #plasma
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28033: Create ExpandableListItem

[Nathaniel Graham]

ngraham added a dependent revision: D28034: [WIP] [Applet] Port to 
ExpandableListItem.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D28033

To: ngraham, #vdg, #plasma
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28033: Create ExpandableListItem

[Nathaniel Graham]

ngraham added a dependent revision: D28036: [Applet] Port to ExpandableListItem.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D28033

To: ngraham, #vdg, #plasma
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28033: Create ExpandableListItem

[Nathaniel Graham]

ngraham created this revision.
ngraham added reviewers: VDG, Plasma.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
ngraham requested review of this revision.

REVISION SUMMARY
  This patch creates the `ExpandableListItem`, a re-usable PlasmaComponents3 
item that can
  be used for the views in various Plasma applet pop-ups, such as Vaults, 
Printers,
  Bluetooth, Networks, and Device Notifier. This way those applets can share 
more code and
  not have to implement this paradigm themselves in five different ways, as 
they currently
  do.
  
  All of these applets currently use slightly different visual styles. For 
example the
  network applet uses a pushbutton with no icon as its "default action" button, 
while
  other applets use icons-only toolbuttons. I tried my best to create a 
component that's
  flexible but also consistent, so various applets that adopt it will see minor 
visual
  changes as a result. Hopefully this is acceptable.
  
  Closes T12812 

TEST PLAN
  F8174587: vokoscreenNG-2020-03-13_10-44-43.webm 


REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  ExpandableListItem (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28033

AFFECTED FILES
  src/declarativeimports/plasmacomponents3/ExpandableListItem.qml
  src/declarativeimports/plasmacomponents3/qmldir

To: ngraham, #vdg, #plasma
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28032: [StorageDevices] Fix order of notification connect and initialization

[Stefan Brüns]

bruns created this revision.
bruns added reviewers: Baloo, ngraham.
Herald added projects: Frameworks, Baloo.
Herald added a subscriber: kde-frameworks-devel.
bruns requested review of this revision.

REVISION SUMMARY
  There is a small timeframe between cache initialization and connection
  of device notifiers where events can go amiss. Swapping the order fixes
  the problem.

REPOSITORY
  R293 Baloo

BRANCH
  submit

REVISION DETAIL
  https://phabricator.kde.org/D28032

AFFECTED FILES
  src/file/storagedevices.cpp

To: bruns, #baloo, ngraham
Cc: kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, cblack, 
fbampaloukas, GB_2, domson, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

D27923: [FileIndexScheduler] Cleanup firstRun handling

[Stefan Brüns]

bruns updated this revision to Diff 77580.
bruns added a comment.


  fix deprecation

REPOSITORY
  R293 Baloo

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27923?vs=77309=77580

BRANCH
  submit

REVISION DETAIL
  https://phabricator.kde.org/D27923

AFFECTED FILES
  autotests/unit/file/filewatchtest.cpp
  src/file/fileindexerconfig.cpp
  src/file/fileindexerconfig.h
  src/file/fileindexscheduler.cpp
  src/file/fileindexscheduler.h
  src/file/firstrunindexer.cpp
  src/file/indexerstate.h
  src/file/main.cpp
  src/file/mainhub.cpp
  src/file/mainhub.h
  src/file/migrator.cpp
  src/lib/CMakeLists.txt
  src/lib/indexerconfig.cpp
  src/lib/indexerconfig.h

To: bruns, #baloo, ngraham
Cc: broulik, kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, cblack, 
fbampaloukas, GB_2, domson, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

D28015: extend indexer to detect dynamic=true regexes that have no place holders to adapt

[Christoph Cullmann]

cullmann added a comment.


  Yes, I will fix the issues and then commit this as one thingy.
  Thanks for taking a look :=)
  My colleague was very unhappy with the VHDL performance :P
  The highlighting shouldn't take as long as a hardware simulator.

REPOSITORY
  R216 Syntax Highlighting

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D28015

To: cullmann, nibags, dhaumann, vkrause
Cc: kwrite-devel, kde-frameworks-devel, rrosch, LeGast00n, cblack, GB_2, 
domson, michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann

D28015: extend indexer to detect dynamic=true regexes that have no place holders to adapt

[Dominik Haumann]

dhaumann accepted this revision.
dhaumann added a comment.
This revision is now accepted and ready to land.


  I guess in a followup commit the reported issues will be fixed? :-)

REPOSITORY
  R216 Syntax Highlighting

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D28015

To: cullmann, nibags, dhaumann, vkrause
Cc: kwrite-devel, kde-frameworks-devel, rrosch, LeGast00n, cblack, GB_2, 
domson, michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann

D28020: New class ProcessLauncherJob in KIOGui

[David Edmundson]

davidedmundson added a comment.


  From the POV of the task at hand, it's great.
  
  If we are making new public API I have some minor requests for things we want 
in future.

INLINE COMMENTS

> kprocessrunner.cpp:39
> +
> +KProcessRunner::KProcessRunner(const KService::Ptr , const 
> QList , WId windowId,
> +   KIO::ProcessLauncherJob::RunFlags flags, 
> const QString , const QByteArray )

WId as an int is problematic for wayland.

Can we do QWindow*? it'll allow adding support in future.

For the compatibility path we can loop through QApp->windows to find the object 
from windowId

> processlauncherjob.h:111
> + */
> +qint64 pid() const;
> +

I don't like that this has to be available immediately after start()

it means we can't make all the blocking calls for kiofuse/discrete 
gpus/whatever async.

which would be really nice for the future.

can we have a signal 
started();

and it's valid after that?

or...alternatively have ProcessLaunchJob::finished() come after processStarted, 
instead of when the process ends?  and this is valid when the job completes? 
From a plasma POV I just want to know if kate started ok, but I don't care if 
it crashes later.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D28020

To: dfaure, apol, davidedmundson, nicolasfella, vkrause, broulik
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28030: Also expose the true minimum size to QML

[Volker Krause]

vkrause created this revision.
vkrause added a reviewer: svuorela.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
vkrause requested review of this revision.

REVISION SUMMARY
  Useful in case you want to implement manual scaling there, for example.

REPOSITORY
  R280 Prison

BRANCH
  pending

REVISION DETAIL
  https://phabricator.kde.org/D28030

AFFECTED FILES
  src/quick/barcodequickitem.cpp
  src/quick/barcodequickitem.h
  tests/barcode.qml

To: vkrause, svuorela
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27951: Allow users to change dropAction to MoveAction through kdeglobals

[Tranter Madi]

trmdi added a comment.


  In D27951#627041 , @ngraham wrote:
  
  > In D27951#626346 , @trmdi wrote:
  >
  > > When drop an image to the desktop in the FolderView layout, there would 
be no menu, so users can not change the wallpaper by drag in this case. 
How do you think about this?
  >
  >
  > In fact there are other options that I didn't think about. For example when 
dragging-and-dropping an archive, there's an "extract here" item that would be 
hidden with this patch.
  >
  > Could we maybe generalize the logic so that it always shows the full drop 
menu if there are any custom items in it like "Expand here" or "Set as 
Wallpaper"? That way it will only move if you have the setting turned on and 
there really are no other ambiguous options.
  
  
  I think the user has to choose. When he chose dndToMove, that means he 
prefers this behavior over others.
  If he wants to see the menu, he could hold the Shift modifier key.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D27951

To: trmdi, ngraham, dfaure, meven, #vdg, davidedmundson
Cc: davidedmundson, meven, kde-frameworks-devel, LeGast00n, cblack, GB_2, 
michaelh, ngraham, bruns

D27882: Move KProcessRunner into it's own file

[David Edmundson]

davidedmundson abandoned this revision.
davidedmundson added a comment.


  Outdated by David F's patch

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D27882

To: davidedmundson, apol
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27951: Allow users to change dropAction to MoveAction through kdeglobals

[Nathaniel Graham]

ngraham added a comment.


  In D27951#626346 , @trmdi wrote:
  
  > When drop an image to the desktop in the FolderView layout, there would be 
no menu, so users can not change the wallpaper by drag in this case. How 
do you think about this?
  
  
  In fact there are other options that I didn't think about. For example when 
dragging-and-dropping an archive, there's an "extract here" item that would be 
hidden with this patch.
  
  Could we maybe generalize the logic so that it always shows the full drop 
menu if there are any custom items in it like "Expand here" or "Set as 
Wallpaper"? That way it will only move if you have the setting turned on and 
there really are no other ambiguous options.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D27951

To: trmdi, ngraham, dfaure, meven, #vdg, davidedmundson
Cc: davidedmundson, meven, kde-frameworks-devel, LeGast00n, cblack, GB_2, 
michaelh, ngraham, bruns

KDE CI: Frameworks » kdeclarative » kf5-qt5 FreeBSDQt5.13 - Build # 87 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kdeclarative/job/kf5-qt5%20FreeBSDQt5.13/87/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Fri, 13 Mar 2020 15:32:35 +
 Build duration:
1 min 5 sec and counting
   JUnit Tests
  Name: projectroot Failed: 1 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 2 test(s)Failed: projectroot.autotests.quickviewsharedengine

D28028: [KCM Controls GridDelegate] Use `ShadowedRectangle`

[Kai Uwe Broulik]

This revision was automatically updated to reflect the committed changes.
Closed by commit R296:517bcca389d9: [KCM Controls GridDelegate] Use 
`ShadowedRectangle` (authored by broulik).

REPOSITORY
  R296 KDeclarative

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28028?vs=77567=77571

REVISION DETAIL
  https://phabricator.kde.org/D28028

AFFECTED FILES
  src/qmlcontrols/kcmcontrols/qml/GridDelegate.qml

To: broulik, #plasma, mart
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D21604: Fix building with Qt 5.13

[Allan Sandfeld Jensen]

carewolf abandoned this revision.
carewolf added a comment.


  Done independently

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D21604

To: carewolf, bruns, ngraham
Cc: alexeymin, kde-frameworks-devel, #baloo, hurikhan77, lots0logs, LeGast00n, 
cblack, fbampaloukas, GB_2, domson, ashaposhnikov, michaelh, astippich, 
spoorun, ngraham, bruns, abrahams

D28028: [KCM Controls GridDelegate] Use `ShadowedRectangle`

[Kai Uwe Broulik]

broulik edited the test plan for this revision.

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D28028

To: broulik, #plasma
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28028: [KCM Controls GridDelegate] Use `ShadowedRectangle`

[Marco Martin]

mart accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D28028

To: broulik, #plasma, mart
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28028: [KCM Controls GridDelegate] Use `ShadowedRectangle`

[Kai Uwe Broulik]

broulik created this revision.
broulik added a reviewer: Plasma.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
broulik requested review of this revision.

REVISION SUMMARY
  Instead of expensive `DropShadow` layer.

TEST PLAN
  Left is before, right is after
  F8174448: Screenshot_20200313_104013.PNG 

  There's a slight difference in falloff but colors and size are spot on

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D28028

AFFECTED FILES
  src/qmlcontrols/kcmcontrols/qml/GridDelegate.qml

To: broulik, #plasma
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27999: [DesktopExecParser] Open {ssh, telnet, rlogin}:// urls with ktelnetservice

[Alexander Saoutkin]

feverfew added a comment.


  don't merge yet, looking at the code I sense something might break here but I 
need some time to do my own testing first.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D27999

To: ahmadsamir, #frameworks, dfaure, sitter, meven, feverfew
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D17816: Support for xattrs on kio copy/move

[Cochise César]

cochise updated this revision to Diff 77559.
cochise added a comment.


  As @dfaure sugested, moved the attribute copy logic to a function on 
file_unix.cpp.
  
  As a side effect we lost hability to copy extened attributes of directories, 
(they are not copied, but created in CopyJob but now all tests pass.
  
  Minor changes:
  
  - Added tests for links, as the code works with them
  
  - Removed tests for copy/move to another partition, as this shpould fail. The 
destination don't support xattrs.

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17816?vs=72144=77559

BRANCH
  arcpatch-D17816

REVISION DETAIL
  https://phabricator.kde.org/D17816

AFFECTED FILES
  autotests/jobtest.cpp
  autotests/jobtest.h
  src/ioslaves/file/ConfigureChecks.cmake
  src/ioslaves/file/file.h
  src/ioslaves/file/file_unix.cpp

To: cochise, dfaure, chinmoyr, bruns, #frameworks, tmarshall
Cc: scheirle, anthonyfieroni, tmarshall, arrowd, cfeck, bruns, phidrho, 
dhaumann, funkybomber, abika, pino, davidedmundson, ngraham, atha.kane, 
spoorun, nicolasfella, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh

D17816: Support for xattrs on kio copy/move

[Cochise César]

cochise commandeered this revision.
cochise edited reviewers, added: tmarshall; removed: cochise.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D17816

To: cochise, dfaure, chinmoyr, bruns, #frameworks, tmarshall
Cc: scheirle, anthonyfieroni, tmarshall, arrowd, cfeck, bruns, phidrho, 
dhaumann, funkybomber, abika, pino, davidedmundson, ngraham, atha.kane, 
spoorun, nicolasfella, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh

D27947: Port away from deprecated QList::toSet()

[Ahmad Samir]

ahmadsamir added inline comments.

INLINE COMMENTS

> apol wrote in kcoredirlister.cpp:1045
> Is this to force dir at the end?

You mean at the front? I am not sure, but I matched the behaviour of the 
original code, it first appended "dir" then the QUrl list from canonicalUrls. 
It sort of makes sense, since we want to update the listing (kcoredirlister) of 
"dir" then the symlinks to it. From the comment right before canonicalUrls 
declaration[1], see https://bugs.kde.org/show_bug.cgi?id=213799

[1] https://cgit.kde.org/kio.git/tree/src/core/kcoredirlister_p.h#n474

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D27947

To: ahmadsamir, #frameworks, dfaure, meven
Cc: apol, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, 
bruns

D21466: Recommend rebooting after installing Samba

[Harald Sitter]

sitter edited the summary of this revision.

REPOSITORY
  R432 File Sharing (Samba) integration

BRANCH
  recommend-rebooting (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D21466

To: ngraham, #vdg, #frameworks, #dolphin, apol, sitter
Cc: anthonyfieroni, sitter, bruns

D27965: [KPasswdServer] replace foreach with range/index-based for

[Ahmad Samir]

ahmadsamir updated this revision to Diff 77554.
ahmadsamir added a comment.


  QList::erase() invalidates the iterators

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27965?vs=77477=77554

BRANCH
  l-kpasswdserver (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27965

AFFECTED FILES
  src/kpasswdserver/autotests/kpasswdservertest.cpp
  src/kpasswdserver/kpasswdserver.cpp

To: ahmadsamir, #frameworks, dfaure, meven
Cc: apol, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, 
bruns

D27986: Allow providing an error message from the application

[Harald Sitter]

sitter added a comment.


  Looks alright to me now. 

REPOSITORY
  R285 KCrash

REVISION DETAIL
  https://phabricator.kde.org/D27986

To: apol, #frameworks, sitter, dfaure
Cc: dfaure, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, 
bruns

D27947: Port away from deprecated QList::toSet()

[Aleix Pol Gonzalez]

apol added inline comments.

INLINE COMMENTS

> kcoredirlister.cpp:1045
> +
> +QList dirs({dir});
> +dirs.append(urlList);

Is this to force dir at the end?

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D27947

To: ahmadsamir, #frameworks, dfaure, meven
Cc: apol, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, 
bruns

D27986: Allow providing an error message from the application

[Aleix Pol Gonzalez]

apol updated this revision to Diff 77552.
apol added a comment.


  nullptr

REPOSITORY
  R285 KCrash

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27986?vs=77551=77552

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D27986

AFFECTED FILES
  src/kcrash.cpp
  src/kcrash.h

To: apol, #frameworks, sitter, dfaure
Cc: dfaure, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, 
bruns

D27947: Port away from deprecated QList::toSet()

[Ahmad Samir]

ahmadsamir added a comment.


  Ping.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D27947

To: ahmadsamir, #frameworks, dfaure, meven
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27986: Allow providing an error message from the application

[Harald Sitter]

sitter added inline comments.

INLINE COMMENTS

> kcrash.cpp:107
> +
> +static char *s_kcrashErrorMessage;
>  Q_GLOBAL_STATIC(KCrash::CoreConfig, s_coreConfig)

Still needs to be set to nullptr.

REPOSITORY
  R285 KCrash

REVISION DETAIL
  https://phabricator.kde.org/D27986

To: apol, #frameworks, sitter, dfaure
Cc: dfaure, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, 
bruns

D27986: Allow providing an error message from the application

[Aleix Pol Gonzalez]

apol updated this revision to Diff 77551.
apol added a comment.


  cleanup

REPOSITORY
  R285 KCrash

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27986?vs=77522=77551

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D27986

AFFECTED FILES
  src/kcrash.cpp
  src/kcrash.h

To: apol, #frameworks, sitter, dfaure
Cc: dfaure, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, 
bruns

D28002: [WIP]Allow disabling of data collection

[George Vogiatzis]

gvgeo added a comment.


  
  
  >> Currently data is collected by default, with no way of disabling it.
  > 
  > That's far from true. Things are off by default. Most providers are not run 
at all.
  > The commit message is either confused or misleading.
  
  I made an assumption, based on the data collected for gammaray. But on second 
check, it seems that it uses it's own implementation of kuserfeedback.
  Changed the description. Confused or not, if it is wrong, it is misleading.
  
  > I don't see why load needs to return early with a bool, it's overly 
complicating things.
  
  Agree. (My problem was accessing private from public.)
  
  > Some usage stuff is retained regardless, but as you note it is because it 
is used for the notification reminder.
  > I also don't see it as fixing anything real. It's local data (that 
kactivitymanagerd is keeping anyway...) and no different to an app storing a 
window size or whatever.
  
  Local data that are used for the functionality of the program, should not 
used as telemetry data. Tracking for telemetry should start when the user 
choose.
  
  An option "Don't remind me again" should exist. And it would be inappropriate 
to keep tracking if enabled, as they would serve no purpose.
  
  Keep in mind that this patch has many faults, and only uploaded as a 
discussion point.
  Including all other, would also like to see a separate switch for surveys, 
for example.

REPOSITORY
  R849 User Feedback Collection Framework

REVISION DETAIL
  https://phabricator.kde.org/D28002

To: gvgeo, #frameworks, apol, vkrause
Cc: davidedmundson, #frameworks

D28002: [WIP]Allow disabling of data collection

[George Vogiatzis]

gvgeo edited the summary of this revision.

REPOSITORY
  R849 User Feedback Collection Framework

REVISION DETAIL
  https://phabricator.kde.org/D28002

To: gvgeo, #frameworks, apol, vkrause
Cc: davidedmundson, #frameworks

D28020: New class ProcessLauncherJob in KIOGui

[David Faure]

dfaure created this revision.
dfaure added reviewers: apol, davidedmundson, nicolasfella, vkrause, broulik.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
dfaure requested review of this revision.

REVISION SUMMARY
  This is meant to replace KRun::runApplication/runService,
  without the QWidget dependency, for most use cases. One exception:
  applications who want to allow the user to make desktop files executable
  (this requires messageboxes, and therefore is still in KRun).
  
  The code is mostly based on KRun's internal KProcessRunner class,
  now moved to KIOGui, but still private.
  
  Next step: also routing KRun::runCommand via ProcessLauncherJob,
  and then writing OpenUrlJob on top of ProcessLauncherJob (but
  runUrl calling KOpenWithDialog is a problem in KIOGui...).

TEST PLAN
  see new unittest (which is based on krununittest)

REPOSITORY
  R241 KIO

BRANCH
  2020_ProcessLauncherJob

REVISION DETAIL
  https://phabricator.kde.org/D28020

AFFECTED FILES
  autotests/CMakeLists.txt
  autotests/kiotesthelper.h
  autotests/processlauncherjobtest.cpp
  autotests/processlauncherjobtest.h
  src/gui/CMakeLists.txt
  src/gui/config-kiogui.h.cmake
  src/gui/kprocessrunner.cpp
  src/gui/kprocessrunner_p.h
  src/gui/processlauncherjob.cpp
  src/gui/processlauncherjob.h
  src/widgets/CMakeLists.txt
  src/widgets/krun.cpp
  src/widgets/krun.h
  src/widgets/krun_p.h

To: dfaure, apol, davidedmundson, nicolasfella, vkrause, broulik
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27986: Allow providing an error message from the application

[Harald Sitter]

sitter added inline comments.

INLINE COMMENTS

> kcrash.cpp:107
> +
> +static char* s_kcrashErrorMessage;
>  Q_GLOBAL_STATIC(KCrash::CoreConfig, s_coreConfig)

- on wrong side of space

needs defining to nullptr

> kcrash.cpp:994
> +{
> +s_kcrashErrorMessage = qstrdup(message.toUtf8().constData());
> +}

I fear that is now leaking when the function is called more than once

  if (s_kcrashErrorMessage) {
  free(s_kcrashErrorMessage);
  }

REPOSITORY
  R285 KCrash

REVISION DETAIL
  https://phabricator.kde.org/D27986

To: apol, #frameworks, sitter, dfaure
Cc: dfaure, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, 
bruns

KDE CI: Frameworks » kirigami » kf5-qt5 SUSEQt5.13 - Build # 231 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/kirigami/job/kf5-qt5%20SUSEQt5.13/231/
 Project:
kf5-qt5 SUSEQt5.13
 Date of build:
Fri, 13 Mar 2020 09:33:48 +
 Build duration:
2 min 19 sec and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5Kirigami2-5.69.0.xmlcompat_reports/KF5Kirigami2_compat_report.htmllogs/KF5Kirigami2/5.69.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.home.jenkins.workspace.Frameworks.kirigami.kf5-qt5_SUSEQt513 Failed: 0 test(s), Passed: 5 test(s), Skipped: 0 test(s), Total: 5 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report60%
(3/5)52%
(13/25)52%
(13/25)46%
(1393/3034)29%
(609/2095)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(1/1)100%
(1/1)100%
(1/1)100%
(0/0)examples.applicationitemapp0%
(0/1)0%
(0/1)0%
(0/8)100%
(0/0)src64%
(9/14)64%
(9/14)42%
(921/2198)27%
(390/1440)src.libkirigami50%
(3/6)50%
(3/6)73%
(471/647)39%
(219/567)src.scenegraph0%
(0/3)0%
(0/3)0%
(0/180)0%
(0/88)

KDE CI: Frameworks » kirigami » kf5-qt5 SUSEQt5.12 - Build # 378 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/kirigami/job/kf5-qt5%20SUSEQt5.12/378/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Fri, 13 Mar 2020 09:33:48 +
 Build duration:
1 min 40 sec and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5Kirigami2-5.69.0.xmlcompat_reports/KF5Kirigami2_compat_report.htmllogs/KF5Kirigami2/5.69.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.home.jenkins.workspace.Frameworks.kirigami.kf5-qt5_SUSEQt512 Failed: 0 test(s), Passed: 5 test(s), Skipped: 0 test(s), Total: 5 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report60%
(3/5)52%
(13/25)52%
(13/25)46%
(1393/3034)29%
(609/2095)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(1/1)100%
(1/1)100%
(1/1)100%
(0/0)examples.applicationitemapp0%
(0/1)0%
(0/1)0%
(0/8)100%
(0/0)src64%
(9/14)64%
(9/14)42%
(921/2198)27%
(390/1440)src.libkirigami50%
(3/6)50%
(3/6)73%
(471/647)39%
(219/567)src.scenegraph0%
(0/3)0%
(0/3)0%
(0/180)0%
(0/88)

KDE CI: Frameworks » kirigami » kf5-qt5 FreeBSDQt5.13 - Build # 220 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/kirigami/job/kf5-qt5%20FreeBSDQt5.13/220/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Fri, 13 Mar 2020 09:33:48 +
 Build duration:
47 sec and counting
   JUnit Tests
  Name: projectroot.usr.home.jenkins.workspace.Frameworks.kirigami.kf5-qt5_FreeBSDQt513 Failed: 0 test(s), Passed: 5 test(s), Skipped: 0 test(s), Total: 5 test(s)

KDE CI: Frameworks » kirigami » kf5-qt5 SUSEQt5.13 - Build # 230 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks/job/kirigami/job/kf5-qt5%20SUSEQt5.13/230/
 Project:
kf5-qt5 SUSEQt5.13
 Date of build:
Fri, 13 Mar 2020 09:17:00 +
 Build duration:
42 sec and counting
   CONSOLE OUTPUT
  [...truncated 349 lines...][2020-03-13T09:17:39.004Z] [ 72%] Building CXX object src/CMakeFiles/kirigamiplugin.dir/settings.cpp.o[2020-03-13T09:17:39.004Z] [ 75%] Building CXX object src/CMakeFiles/kirigamiplugin.dir/delegaterecycler.cpp.o[2020-03-13T09:17:39.005Z] [ 77%] Building CXX object src/CMakeFiles/kirigamiplugin.dir/pagepool.cpp.o[2020-03-13T09:17:39.005Z] [ 79%] Building CXX object src/CMakeFiles/kirigamiplugin.dir/mnemonicattached.cpp.o[2020-03-13T09:17:39.005Z] [ 81%] Building CXX object src/CMakeFiles/kirigamiplugin.dir/scenepositionattached.cpp.o[2020-03-13T09:17:39.261Z] [ 81%] Built target qmltest[2020-03-13T09:17:39.261Z] [ 84%] Building CXX object src/CMakeFiles/kirigamiplugin.dir/wheelhandler.cpp.o[2020-03-13T09:17:39.827Z] [ 86%] Building CXX object src/CMakeFiles/kirigamiplugin.dir/shadowedrectangle.cpp.o[2020-03-13T09:17:39.827Z] /home/jenkins/workspace/Frameworks/kirigami/kf5-qt5 SUSEQt5.13/src/settings.cpp: In member function ���virtual bool Settings::eventFilter(QObject*, QEvent*)���:[2020-03-13T09:17:39.827Z] /home/jenkins/workspace/Frameworks/kirigami/kf5-qt5 SUSEQt5.13/src/settings.cpp:98:37: warning: unused parameter ���watched��� [-Wunused-parameter][2020-03-13T09:17:39.827Z]98 | bool Settings::eventFilter(QObject *watched, QEvent *event)[2020-03-13T09:17:39.827Z]   |~^~~[2020-03-13T09:17:40.392Z] [ 88%] Building CXX object src/CMakeFiles/kirigamiplugin.dir/scenegraph/shadowedrectanglenode.cpp.o[2020-03-13T09:17:40.392Z] [ 90%] Building CXX object src/CMakeFiles/kirigamiplugin.dir/scenegraph/shadowedrectanglematerial.cpp.o[2020-03-13T09:17:40.392Z] [ 93%] Building CXX object src/CMakeFiles/kirigamiplugin.dir/scenegraph/shadowedborderrectanglematerial.cpp.o[2020-03-13T09:17:40.659Z] [ 95%] Building CXX object src/CMakeFiles/kirigamiplugin.dir/ECMQmLoader-libkirigami2plugin_qt.cpp.o[2020-03-13T09:17:40.917Z] [ 97%] Building CXX object src/CMakeFiles/kirigamiplugin.dir/qrc_shaders.cpp.o[2020-03-13T09:17:41.177Z] In file included from /home/jenkins/workspace/Frameworks/kirigami/kf5-qt5 SUSEQt5.13/src/scenegraph/shadowedrectanglematerial.cpp:7:[2020-03-13T09:17:41.177Z] /home/jenkins/workspace/Frameworks/kirigami/kf5-qt5 SUSEQt5.13/src/scenegraph/shadowedrectanglematerial.h:30:12: error: field ���color��� has incomplete type ���QColor���[2020-03-13T09:17:41.177Z]30 | QColor color = Qt::white;[2020-03-13T09:17:41.177Z]   |^[2020-03-13T09:17:41.177Z] In file included from /usr/include/qt5/QtGui/qvector2d.h:45,[2020-03-13T09:17:41.177Z]  from /usr/include/qt5/QtGui/qopenglshaderprogram.h:48,[2020-03-13T09:17:41.177Z]  from /usr/include/qt5/QtQuick/qsgmaterial.h:45,[2020-03-13T09:17:41.177Z]  from /usr/include/qt5/QtQuick/QSGMaterial:1,[2020-03-13T09:17:41.177Z]  from /home/jenkins/workspace/Frameworks/kirigami/kf5-qt5 SUSEQt5.13/src/scenegraph/shadowedrectanglematerial.h:9,[2020-03-13T09:17:41.177Z]  from /home/jenkins/workspace/Frameworks/kirigami/kf5-qt5 SUSEQt5.13/src/scenegraph/shadowedrectanglematerial.cpp:7:[2020-03-13T09:17:41.177Z] /usr/include/qt5/QtCore/qmetatype.h:1972:1: note: forward declaration of ���class QColor���[2020-03-13T09:17:41.177Z]  1972 | QT_FOR_EACH_STATIC_GUI_CLASS(QT_FORWARD_DECLARE_STATIC_TYPES_ITER)[2020-03-13T09:17:41.177Z]   | ^~~~[2020-03-13T09:17:41.177Z] In file included from /home/jenkins/workspace/Frameworks/kirigami/kf5-qt5 SUSEQt5.13/src/scenegraph/shadowedrectanglematerial.cpp:7:[2020-03-13T09:17:41.177Z] /home/jenkins/workspace/Frameworks/kirigami/kf5-qt5 SUSEQt5.13/src/scenegraph/shadowedrectanglematerial.h:31:12: error: field ���shadowColor��� has incomplete type ���QColor���[2020-03-13T09:17:41.177Z]31 | QColor shadowColor = Qt::black;[2020-03-13T09:17:41.177Z]   |^~~[2020-03-13T09:17:41.177Z] In file included from /usr/include/qt5/QtGui/qvector2d.h:45,[2020-03-13T09:17:41.177Z]  from /usr/include/qt5/QtGui/qopenglshaderprogram.h:48,[2020-03-13T09:17:41.177Z]  from /usr/include/qt5/QtQuick/qsgmaterial.h:45,[2020-03-13T09:17:41.177Z]  from /usr/include/qt5/QtQuick/QSGMaterial:1,[2020-03-13T09:17:41.177Z]  from /home/jenkins/workspace/Frameworks/kirigami/kf5-qt5 SUSEQt5.13/src/scenegraph/shadowedrectanglematerial.h:9,[2020-03-13T09:17:41.177Z]  from /home/jenkins/workspace/Frameworks/kirigami/kf5-qt5 SUSEQt5.13/src/scenegraph/shadowedrectanglematerial.cpp:7:[2020-03-13T09:17:41.177Z] /usr/include/qt5/QtCore/qmetatype.h:1972:1: note: forward declaration of ���class 

KDE CI: Frameworks » kirigami » kf5-qt5 SUSEQt5.12 - Build # 377 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks/job/kirigami/job/kf5-qt5%20SUSEQt5.12/377/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Fri, 13 Mar 2020 09:17:00 +
 Build duration:
1 min 7 sec and counting
   CONSOLE OUTPUT
  [...truncated 349 lines...][2020-03-13T09:17:59.465Z] [ 65%] Building CXX object src/CMakeFiles/kirigamiplugin.dir/enums.cpp.o[2020-03-13T09:17:59.465Z] [ 68%] Building CXX object src/CMakeFiles/kirigamiplugin.dir/delegaterecycler.cpp.o[2020-03-13T09:17:59.465Z] [ 70%] Building CXX object src/CMakeFiles/kirigamiplugin.dir/icon.cpp.o[2020-03-13T09:18:00.853Z] [ 72%] Building CXX object src/CMakeFiles/kirigamiplugin.dir/settings.cpp.o[2020-03-13T09:18:01.790Z] [ 75%] Building CXX object src/CMakeFiles/kirigamiplugin.dir/formlayoutattached.cpp.o[2020-03-13T09:18:01.790Z] /home/jenkins/workspace/Frameworks/kirigami/kf5-qt5 SUSEQt5.12/src/settings.cpp: In member function ���virtual bool Settings::eventFilter(QObject*, QEvent*)���:[2020-03-13T09:18:01.790Z] /home/jenkins/workspace/Frameworks/kirigami/kf5-qt5 SUSEQt5.12/src/settings.cpp:98:37: warning: unused parameter ���watched��� [-Wunused-parameter][2020-03-13T09:18:01.790Z]98 | bool Settings::eventFilter(QObject *watched, QEvent *event)[2020-03-13T09:18:01.790Z]   |~^~~[2020-03-13T09:18:02.050Z] [ 77%] Building CXX object src/CMakeFiles/kirigamiplugin.dir/pagepool.cpp.o[2020-03-13T09:18:02.622Z] [ 79%] Building CXX object src/CMakeFiles/kirigamiplugin.dir/scenepositionattached.cpp.o[2020-03-13T09:18:03.216Z] [ 81%] Building CXX object src/CMakeFiles/kirigamiplugin.dir/mnemonicattached.cpp.o[2020-03-13T09:18:04.164Z] [ 84%] Building CXX object src/CMakeFiles/kirigamiplugin.dir/wheelhandler.cpp.o[2020-03-13T09:18:04.424Z] [ 86%] Building CXX object src/CMakeFiles/kirigamiplugin.dir/shadowedrectangle.cpp.o[2020-03-13T09:18:04.684Z] [ 88%] Building CXX object src/CMakeFiles/kirigamiplugin.dir/scenegraph/shadowedrectanglenode.cpp.o[2020-03-13T09:18:04.684Z] [ 90%] Building CXX object src/CMakeFiles/kirigamiplugin.dir/scenegraph/shadowedrectanglematerial.cpp.o[2020-03-13T09:18:05.628Z] [ 93%] Building CXX object src/CMakeFiles/kirigamiplugin.dir/scenegraph/shadowedborderrectanglematerial.cpp.o[2020-03-13T09:18:05.888Z] In file included from /home/jenkins/workspace/Frameworks/kirigami/kf5-qt5 SUSEQt5.12/src/scenegraph/shadowedrectanglematerial.cpp:7:[2020-03-13T09:18:05.888Z] /home/jenkins/workspace/Frameworks/kirigami/kf5-qt5 SUSEQt5.12/src/scenegraph/shadowedrectanglematerial.h:30:12: error: field ���color��� has incomplete type ���QColor���[2020-03-13T09:18:05.888Z]30 | QColor color = Qt::white;[2020-03-13T09:18:05.888Z]   |^[2020-03-13T09:18:05.888Z] In file included from /usr/include/qt5/QtGui/qvector2d.h:45,[2020-03-13T09:18:05.888Z]  from /usr/include/qt5/QtGui/qopenglshaderprogram.h:48,[2020-03-13T09:18:05.888Z]  from /usr/include/qt5/QtQuick/qsgmaterial.h:45,[2020-03-13T09:18:05.888Z]  from /usr/include/qt5/QtQuick/QSGMaterial:1,[2020-03-13T09:18:05.888Z]  from /home/jenkins/workspace/Frameworks/kirigami/kf5-qt5 SUSEQt5.12/src/scenegraph/shadowedrectanglematerial.h:9,[2020-03-13T09:18:05.888Z]  from /home/jenkins/workspace/Frameworks/kirigami/kf5-qt5 SUSEQt5.12/src/scenegraph/shadowedrectanglematerial.cpp:7:[2020-03-13T09:18:05.888Z] /usr/include/qt5/QtCore/qmetatype.h:1971:1: note: forward declaration of ���class QColor���[2020-03-13T09:18:05.888Z]  1971 | QT_FOR_EACH_STATIC_GUI_CLASS(QT_FORWARD_DECLARE_STATIC_TYPES_ITER)[2020-03-13T09:18:05.888Z]   | ^~~~[2020-03-13T09:18:05.888Z] In file included from /home/jenkins/workspace/Frameworks/kirigami/kf5-qt5 SUSEQt5.12/src/scenegraph/shadowedrectanglematerial.cpp:7:[2020-03-13T09:18:05.888Z] /home/jenkins/workspace/Frameworks/kirigami/kf5-qt5 SUSEQt5.12/src/scenegraph/shadowedrectanglematerial.h:31:12: error: field ���shadowColor��� has incomplete type ���QColor���[2020-03-13T09:18:05.888Z]31 | QColor shadowColor = Qt::black;[2020-03-13T09:18:05.888Z]   |^~~[2020-03-13T09:18:05.888Z] In file included from /usr/include/qt5/QtGui/qvector2d.h:45,[2020-03-13T09:18:05.888Z]  from /usr/include/qt5/QtGui/qopenglshaderprogram.h:48,[2020-03-13T09:18:05.888Z]  from /usr/include/qt5/QtQuick/qsgmaterial.h:45,[2020-03-13T09:18:05.888Z]  from /usr/include/qt5/QtQuick/QSGMaterial:1,[2020-03-13T09:18:05.888Z]  from /home/jenkins/workspace/Frameworks/kirigami/kf5-qt5 SUSEQt5.12/src/scenegraph/shadowedrectanglematerial.h:9,[2020-03-13T09:18:05.888Z]  from /home/jenkins/workspace/Frameworks/kirigami/kf5-qt5 SUSEQt5.12/src/scenegraph/shadowedrectanglematerial.cpp:7:[2020-03-13T09:18:05.888Z] /usr/include/qt5/QtCore/qmetatype.h:1971:1: note: forward 

KDE CI: Frameworks » kirigami » kf5-qt5 FreeBSDQt5.13 - Build # 219 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks/job/kirigami/job/kf5-qt5%20FreeBSDQt5.13/219/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Fri, 13 Mar 2020 09:17:00 +
 Build duration:
27 sec and counting
   CONSOLE OUTPUT
  [...truncated 293 lines...][2020-03-13T09:17:23.574Z] [ 72%] Building CXX object src/CMakeFiles/kirigamiplugin.dir/enums.cpp.o[2020-03-13T09:17:23.574Z] [ 77%] Building CXX object src/CMakeFiles/kirigamiplugin.dir/formlayoutattached.cpp.o[2020-03-13T09:17:23.574Z] [ 77%] Building CXX object src/CMakeFiles/kirigamiplugin.dir/pagepool.cpp.o[2020-03-13T09:17:23.574Z] [ 77%] Building CXX object src/CMakeFiles/kirigamiplugin.dir/icon.cpp.o[2020-03-13T09:17:23.574Z] [ 79%] Building CXX object src/CMakeFiles/kirigamiplugin.dir/scenepositionattached.cpp.o[2020-03-13T09:17:23.574Z] [ 81%] Building CXX object src/CMakeFiles/kirigamiplugin.dir/mnemonicattached.cpp.o[2020-03-13T09:17:23.574Z] [ 84%] Building CXX object src/CMakeFiles/kirigamiplugin.dir/wheelhandler.cpp.o[2020-03-13T09:17:24.521Z] [ 86%] Building CXX object src/CMakeFiles/kirigamiplugin.dir/shadowedrectangle.cpp.o[2020-03-13T09:17:24.521Z] /usr/home/jenkins/workspace/Frameworks/kirigami/kf5-qt5 FreeBSDQt5.13/src/settings.cpp:98:37: warning: unused parameter 'watched' [-Wunused-parameter][2020-03-13T09:17:24.521Z] bool Settings::eventFilter(QObject *watched, QEvent *event)[2020-03-13T09:17:24.521Z] ^[2020-03-13T09:17:24.795Z] /usr/home/jenkins/workspace/Frameworks/kirigami/kf5-qt5 FreeBSDQt5.13/src/columnview.cpp:616:80: warning: lambda capture 'attached' is not used [-Wunused-lambda-capture][2020-03-13T09:17:24.795Z]  connect(attached, ::fillWidthChanged, this, [this, attached](){[2020-03-13T09:17:24.795Z]  ~~^~~~[2020-03-13T09:17:24.795Z] 1 warning generated.[2020-03-13T09:17:24.795Z] [ 88%] Building CXX object src/CMakeFiles/kirigamiplugin.dir/scenegraph/shadowedrectanglenode.cpp.o[2020-03-13T09:17:24.795Z] [ 90%] Building CXX object src/CMakeFiles/kirigamiplugin.dir/scenegraph/shadowedrectanglematerial.cpp.o[2020-03-13T09:17:25.064Z] [ 93%] Building CXX object src/CMakeFiles/kirigamiplugin.dir/scenegraph/shadowedborderrectanglematerial.cpp.o[2020-03-13T09:17:25.064Z] [ 95%] Building CXX object src/CMakeFiles/kirigamiplugin.dir/ECMQmLoader-libkirigami2plugin_qt.cpp.o[2020-03-13T09:17:25.325Z] 1 warning generated.[2020-03-13T09:17:25.325Z] [ 97%] Building CXX object src/CMakeFiles/kirigamiplugin.dir/qrc_shaders.cpp.o[2020-03-13T09:17:25.898Z] In file included from /usr/home/jenkins/workspace/Frameworks/kirigami/kf5-qt5 FreeBSDQt5.13/src/scenegraph/shadowedrectanglematerial.cpp:7:[2020-03-13T09:17:25.898Z] /usr/home/jenkins/workspace/Frameworks/kirigami/kf5-qt5 FreeBSDQt5.13/src/scenegraph/shadowedrectanglematerial.h:30:12: error: field has incomplete type 'QColor'[2020-03-13T09:17:25.898Z] QColor color = Qt::white;[2020-03-13T09:17:25.898Z]^[2020-03-13T09:17:25.898Z] /usr/local/include/qt5/QtCore/qmetatype.h:1972:1: note: forward declaration of 'QColor'[2020-03-13T09:17:25.898Z] QT_FOR_EACH_STATIC_GUI_CLASS(QT_FORWARD_DECLARE_STATIC_TYPES_ITER)[2020-03-13T09:17:25.898Z] ^[2020-03-13T09:17:25.898Z] /usr/local/include/qt5/QtCore/qmetatype.h:151:19: note: expanded from macro 'QT_FOR_EACH_STATIC_GUI_CLASS'[2020-03-13T09:17:25.898Z] F(QColor, 67, QColor) \[2020-03-13T09:17:25.898Z]   ^[2020-03-13T09:17:25.898Z] In file included from /usr/home/jenkins/workspace/Frameworks/kirigami/kf5-qt5 FreeBSDQt5.13/src/scenegraph/shadowedrectanglematerial.cpp:7:[2020-03-13T09:17:25.898Z] /usr/home/jenkins/workspace/Frameworks/kirigami/kf5-qt5 FreeBSDQt5.13/src/scenegraph/shadowedrectanglematerial.h:31:12: error: field has incomplete type 'QColor'[2020-03-13T09:17:25.898Z] QColor shadowColor = Qt::black;[2020-03-13T09:17:25.898Z]^[2020-03-13T09:17:25.898Z] /usr/local/include/qt5/QtCore/qmetatype.h:1972:1: note: forward declaration of 'QColor'[2020-03-13T09:17:25.898Z] QT_FOR_EACH_STATIC_GUI_CLASS(QT_FORWARD_DECLARE_STATIC_TYPES_ITER)[2020-03-13T09:17:25.898Z] ^[2020-03-13T09:17:25.898Z] /usr/local/include/qt5/QtCore/qmetatype.h:151:19: note: expanded from macro 'QT_FOR_EACH_STATIC_GUI_CLASS'[2020-03-13T09:17:25.898Z] F(QColor, 67, QColor) \[2020-03-13T09:17:25.898Z]   ^[2020-03-13T09:17:25.898Z] /usr/home/jenkins/workspace/Frameworks/kirigami/kf5-qt5 FreeBSDQt5.13/src/scenegraph/shadowedrectanglematerial.cpp:15:5: error: cannot initialize object parameter of type 'QSGMaterial' with an _expression_ of type 'ShadowedRectangleMaterial'[2020-03-13T09:17:25.898Z] setFlag(QSGMaterial::Blending, true);[2020-03-13T09:17:25.898Z] ^~~[2020-03-13T09:17:25.898Z] /usr/home/jenkins/workspace/Frameworks/kirigami/kf5-qt5 FreeBSDQt5.13/src/scenegraph/shadowedrectanglematerial.cpp:41:25: error: cannot 

D27999: [DesktopExecParser] Open {ssh, telnet, rlogin}:// urls with ktelnetservice

[Ahmad Samir]

ahmadsamir updated this revision to Diff 77538.
ahmadsamir added a comment.


  As pointed out by dfaure, we have to make sure the unit test passes even if 
KIO isn't installed (which might be the case on the KDE CI system). Since we 
aren't actually executing the ktelnetservice5 binary and only checking what 
DesktopExecParser will try to use, this should work.

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27999?vs=77533=77538

BRANCH
  l-krun-ssh (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27999

AFFECTED FILES
  autotests/krununittest.cpp
  autotests/krununittest.h
  src/core/desktopexecparser.cpp

To: ahmadsamir, #frameworks, dfaure, sitter, meven, feverfew
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27540: KCModule: Indicate when a setting has been changed from the default or previous value

[Kevin Ottens]

ervin added a comment.


  In D27540#617485 , @ervin wrote:
  
  > And now you got a screenshot as well. Waiting for further feedback now.
  
  
  Ping? This patch was first created three weeks ago now.
  
  Note that look in D27840  and D27841 
 is pretty much the same than in here for 
which I provided screenshot

REPOSITORY
  R265 KConfigWidgets

REVISION DETAIL
  https://phabricator.kde.org/D27540

To: ervin, ngraham, davidedmundson, meven, crossi, bport, #vdg
Cc: alexde, ndavis, iasensio, davidre, kde-frameworks-devel, LeGast00n, cblack, 
GB_2, michaelh, ngraham, bruns

D27724: Syncronise setNeedsSave between KCModule and ConfigModule in both directions

[Méven Car]

meven added inline comments.

INLINE COMMENTS

> kcmoduleqml.cpp:87
> +
> +// changed is also manipulated extermally by KCModule, we need to keep 
> the Quick implementation in sync
> +// TODO KF6 remove the differed "emit changed" in KConfigModule and then 
> we can remove this here

s/extermally/externally

REPOSITORY
  R295 KCMUtils

REVISION DETAIL
  https://phabricator.kde.org/D27724

To: davidedmundson
Cc: meven, iasensio, crossi, kde-frameworks-devel, LeGast00n, cblack, GB_2, 
michaelh, ngraham, bruns

D28016: KWindowSystem: deprecate KStartupInfoData::launchedBy, unused

[Vlad Zahorodnii]

zzag added a comment.


  Do you know why LAUNCHED_BY was added? The spec [1] has no a single word 
about its potential use cases.
  
  [1] 
https://specifications.freedesktop.org/startup-notification-spec/startup-notification-latest.txt

REPOSITORY
  R278 KWindowSystem

REVISION DETAIL
  https://phabricator.kde.org/D28016

To: dfaure, zzag, broulik, davidedmundson
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28016: KWindowSystem: deprecate KStartupInfoData::launchedBy, unused

[Kai Uwe Broulik]

broulik added a comment.


  Anything WId also probably won't work on Wayland, so +1

REPOSITORY
  R278 KWindowSystem

REVISION DETAIL
  https://phabricator.kde.org/D28016

To: dfaure, zzag, broulik, davidedmundson
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27999: [DesktopExecParser] Open {ssh, telnet, rlogin}:// urls with ktelnetservice

[Méven Car]

meven added a comment.


  Good to me

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D27999

To: ahmadsamir, #frameworks, dfaure, sitter, meven, feverfew
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D25010: [StatJob] Use A QFlag to specify the details returned by StatJob

[Méven Car]

meven marked 2 inline comments as done.
meven added inline comments.

INLINE COMMENTS

> kossebau wrote in statjob.h:203
> Ah, was already fixed.

5434ffd0c655b0996e881fec605dc988a672d85c 


REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D25010

To: meven, #frameworks, dfaure, kossebau
Cc: mlaurent, dalbers, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, 
ngraham, bruns

D27966: KParts: add PartLoader as replacement to KMimeTypeTrader for parts

[David Faure]

dfaure added a comment.


  Yeah I guess "looks reasonable" is the most I can expect :-)
  
  Any chance you could take a look at https://phabricator.kde.org/D27967 which 
is needed for this to land? Thanks.

REPOSITORY
  R306 KParts

REVISION DETAIL
  https://phabricator.kde.org/D27966

To: dfaure, aacid, nicolasfella, kossebau
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27999: [DesktopExecParser] Open {ssh, telnet, rlogin}:// urls with ktelnetservice

[David Faure]

dfaure added a comment.


  Thanks, looks better. One possible problem left: if KIO has never been 
installed, I guess 
QStandardPaths::findExecutable(QStringLiteral("ktelnetservice5")) won't find it 
in builddir/bin.
  
  You could push and see what CI says, or you could test locally what happens 
when running this test method with PATH=/does/not/exist.
  It seems to me that desktopexecparser.cpp won't find it then, which should 
probably be fixed with a fallback to "if it exists in 
QCoreApplication::applicationDirPath(), use that" -- and then the unittest can 
do the same.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D27999

To: ahmadsamir, #frameworks, dfaure, sitter, meven, feverfew
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28016: KWindowSystem: deprecate KStartupInfoData::launchedBy, unused

[David Faure]

dfaure created this revision.
dfaure added reviewers: zzag, broulik, davidedmundson.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
dfaure requested review of this revision.

REVISION SUMMARY
  KRun bothers with a WId in many places just to end up calling
  KStartupInfoData::setLaunchedBy... and nobody uses that value anywhere.
  Time to deprecate this and simplify KRun (which I'm rewriting).

TEST PLAN
  Builds. Warns when used in KIO.

REPOSITORY
  R278 KWindowSystem

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D28016

AFFECTED FILES
  src/CMakeLists.txt
  src/kstartupinfo.cpp
  src/kstartupinfo.h

To: dfaure, zzag, broulik, davidedmundson
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.13 - Build # 331 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.13/331/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Fri, 13 Mar 2020 06:46:01 +
 Build duration:
6 min 11 sec and counting
   JUnit Tests
  Name: projectroot Failed: 4 test(s), Passed: 48 test(s), Skipped: 0 test(s), Total: 52 test(s)Failed: projectroot.autotests.kiocore_jobtestFailed: projectroot.autotests.kiocore_kmountpointtestFailed: projectroot.autotests.kiowidgets_kdirlistertestFailed: projectroot.autotests.kiowidgets_kdirmodeltestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.13 - Build # 330 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.13/330/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Fri, 13 Mar 2020 06:38:23 +
 Build duration:
7 min 35 sec and counting
   JUnit Tests
  Name: projectroot Failed: 4 test(s), Passed: 48 test(s), Skipped: 0 test(s), Total: 52 test(s)Failed: projectroot.autotests.kiocore_jobtestFailed: projectroot.autotests.kiocore_kmountpointtestFailed: projectroot.autotests.kiowidgets_kdirlistertestFailed: projectroot.autotests.kiowidgets_kdirmodeltestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)

KDE CI: Frameworks » kservice » kf5-qt5 SUSEQt5.12 - Build # 126 - Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kservice/job/kf5-qt5%20SUSEQt5.12/126/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Fri, 13 Mar 2020 06:36:48 +
 Build duration:
2 min 10 sec and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5Service-5.69.0.xmlcompat_reports/KF5Service_compat_report.htmllogs/KF5Service/5.69.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 9 test(s), Skipped: 0 test(s), Total: 10 test(s)Failed: projectroot.autotests.kmimeassociationstestName: projectroot.tests Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report75%
(6/8)85%
(75/88)85%
(75/88)71%
(5909/8307)48%
(2544/5280)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(14/14)100%
(14/14)96%
(1658/1728)50%
(701/1397)src.kbuildsycoca100%
(1/1)100%
(1/1)90%
(45/50)38%
(3/8)src.kdeinit0%
(0/2)0%
(0/2)0%
(0/329)0%
(0/225)src.plugin67%
(2/3)67%
(2/3)48%
(46/95)41%
(33/81)src.services100%
(31/31)100%
(31/31)63%
(1971/3122)42%
(771/1830)src.sycoca83%
(24/29)83%
(24/29)76%
(2084/2749)61%
(1020/1681)tests0%
(0/5)0%
(0/5)0%
(0/117)0%
(0/34)tests.pluginlocator100%
(3/3)100%
(3/3)90%
(105/117)67%
(16/24)

KDE CI: Frameworks » kservice » kf5-qt5 SUSEQt5.13 - Build # 100 - Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kservice/job/kf5-qt5%20SUSEQt5.13/100/
 Project:
kf5-qt5 SUSEQt5.13
 Date of build:
Fri, 13 Mar 2020 06:36:48 +
 Build duration:
2 min 10 sec and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5Service-5.69.0.xmlcompat_reports/KF5Service_compat_report.htmllogs/KF5Service/5.69.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 9 test(s), Skipped: 0 test(s), Total: 10 test(s)Failed: projectroot.autotests.kmimeassociationstestName: projectroot.tests Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report75%
(6/8)85%
(75/88)85%
(75/88)71%
(5909/8307)48%
(2544/5280)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(14/14)100%
(14/14)96%
(1658/1728)50%
(701/1397)src.kbuildsycoca100%
(1/1)100%
(1/1)90%
(45/50)38%
(3/8)src.kdeinit0%
(0/2)0%
(0/2)0%
(0/329)0%
(0/225)src.plugin67%
(2/3)67%
(2/3)48%
(46/95)41%
(33/81)src.services100%
(31/31)100%
(31/31)63%
(1971/3122)42%
(771/1830)src.sycoca83%
(24/29)83%
(24/29)76%
(2084/2749)61%
(1020/1681)tests0%
(0/5)0%
(0/5)0%
(0/117)0%
(0/34)tests.pluginlocator100%
(3/3)100%
(3/3)90%
(105/117)67%
(16/24)

KDE CI: Frameworks » kservice » kf5-qt5 FreeBSDQt5.13 - Build # 96 - Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kservice/job/kf5-qt5%20FreeBSDQt5.13/96/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Fri, 13 Mar 2020 06:36:48 +
 Build duration:
2 min 12 sec and counting
   JUnit Tests
  Name: projectroot Failed: 1 test(s), Passed: 9 test(s), Skipped: 0 test(s), Total: 10 test(s)Failed: projectroot.autotests.kmimeassociationstestName: projectroot.tests Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)

KDE CI: Frameworks » kcoreaddons » kf5-qt5 FreeBSDQt5.13 - Build # 117 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20FreeBSDQt5.13/117/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Fri, 13 Mar 2020 06:35:43 +
 Build duration:
1 min 49 sec and counting
   JUnit Tests
  Name: projectroot Failed: 2 test(s), Passed: 25 test(s), Skipped: 0 test(s), Total: 27 test(s)Failed: projectroot.autotests.kdirwatch_inotify_unittestFailed: projectroot.autotests.klistopenfilesjobtest_unix

D27999: [DesktopExecParser] Open {ssh, telnet, rlogin}:// urls with ktelnetservice

[Ahmad Samir]

ahmadsamir marked 3 inline comments as done.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D27999

To: ahmadsamir, #frameworks, dfaure, sitter, meven, feverfew
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27999: [DesktopExecParser] Open {ssh, telnet, rlogin}:// urls with ktelnetservice

[Ahmad Samir]

ahmadsamir updated this revision to Diff 77533.
ahmadsamir added a comment.


  - Use QStandardPaths::findExecutable(), as the path isn't hardcoded to 
/usr/bin/ on all systems
  - More QVERIFY()

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27999?vs=77521=77533

BRANCH
  l-krun-ssh (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27999

AFFECTED FILES
  autotests/krununittest.cpp
  autotests/krununittest.h
  src/core/desktopexecparser.cpp

To: ahmadsamir, #frameworks, dfaure, sitter, meven, feverfew
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns