D26968: Removed hardcoded values

[Noah Davis]

ndavis added a comment.


  Anyway, it works as it is, so don't worry about it.

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  fix_panel_color

REVISION DETAIL
  https://phabricator.kde.org/D26968

To: niccolove, #vdg, #plasma, ndavis
Cc: ndavis, ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D26968: Removed hardcoded values

[Noah Davis]

ndavis added a comment.


  In D26968#602031 , @niccolove 
wrote:
  
  > In D26968#601998 , @ndavis wrote:
  >
  > > You should remove the color field instead of using `color:currentColor` 
and `fill:currentColor`
  >
  >
  > I tried to do that, but for some reason the "color:#effeff" automatically 
appears again (in inkscape) :-/
  
  
  Yeah, you have to remove it with `sed` or a text editor every time unless you 
use Inkscape 1.0

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  fix_panel_color

REVISION DETAIL
  https://phabricator.kde.org/D26968

To: niccolove, #vdg, #plasma, ndavis
Cc: ndavis, ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D26968: Removed hardcoded values

[Noah Davis]

ndavis added reviewers: VDG, Plasma.
ndavis added a comment.


  This does have rounded corners and the background is fixed.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D26968

To: niccolove, #vdg, #plasma
Cc: ndavis, ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D26968: Removed hardcoded values

[Noah Davis]

ndavis accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  fix_panel_color

REVISION DETAIL
  https://phabricator.kde.org/D26968

To: niccolove, #vdg, #plasma, ndavis
Cc: ndavis, ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D26968: Removed hardcoded values

[Noah Davis]

ndavis added a comment.


  You should remove the color field instead of using `color:currentColor` and 
`fill:currentColor`

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D26968

To: niccolove
Cc: ndavis, ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D26955: Fix background SVG colors and adjust background SVG corners

[Noah Davis]

ndavis added a comment.


  In D26955#601984 , @niccolove 
wrote:
  
  > Might the problems of not-rounded corners here be caused from the "adjust 
background SVG corners" part by any chance?
  
  
  I tried using the same corners as the shadow patch, but it didn't change 
anything.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D26955

To: ndavis, #vdg, #plasma
Cc: niccolove, ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D26758: Fix the size and pixel alignment of checkboxes and radiobuttons

[Noah Davis]

This revision was automatically updated to reflect the committed changes.
Closed by commit R242:ad625f68f345: Fix the size and pixel alignment of 
checkboxes and radiobuttons (authored by ndavis).

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26758?vs=73852=74476

REVISION DETAIL
  https://phabricator.kde.org/D26758

AFFECTED FILES
  src/declarativeimports/plasmacomponents3/CheckIndicator.qml
  src/declarativeimports/plasmacomponents3/RadioButton.qml
  src/declarativeimports/plasmacomponents3/RadioIndicator.qml
  src/declarativeimports/plasmastyle/CheckBoxStyle.qml
  src/declarativeimports/plasmastyle/RadioButtonStyle.qml
  src/desktoptheme/breeze/widgets/actionbutton.svg
  src/desktoptheme/breeze/widgets/checkmarks.svg

To: ndavis, #plasma, #vdg, ngraham
Cc: ngraham, davidedmundson, kde-frameworks-devel, LeGast00n, GB_2, michaelh, 
bruns

D26955: Fix background SVG colors and adjust background SVG corners

[Noah Davis]

ndavis added a subscriber: niccolove.
ndavis added a comment.


  In D26955#601684 , @ngraham wrote:
  
  > This fixes the color bug, so that's good. :)
  >
  > However with Breeze Dark, now I see pointy corners and very weak shadows: 
F7982216: Screenshot_20200127_221203.png 
  >
  > ...Whereas with the Breeze and Breeze Light plasma style, I see nice 
shadows and rounded corners : F7982219: Screenshot_20200127_221718.png 

  >
  > (and yes I cleared the plasma SVG cache)
  
  
  Did you test the original shadows patch with breeze dark? These shadows are 
identical. I even zoomed into screenshots 1600% and used a color picker on 
different pixels in the shadow. If you don't like these shadows then we should 
just revert the shadows patch instead of fixing them with this patch.
  
  I don't know what to do about the corners. There's no reason why they should 
have sharp corners. Even if I replicate the previous corners, the issue is 
still there. I'm suspecting a bug in the code. @niccolove also had a lot of 
trouble with the mask. He said it doesn't seem to even work and deleting the 
mask from the SVG has no visible effect. I'm not even sure if the mask is the 
cause of the corners. Even the shadows patch still has some visual artifacts in 
the corners: F7982336: Screenshot_20200128_004638.PNG 


REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D26955

To: ndavis, #vdg, #plasma
Cc: niccolove, ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D26955: Fix background SVG colors and adjust background SVG corners

[Noah Davis]

ndavis retitled this revision from "Fix background colors and adjust background 
corners" to "Fix background SVG colors and adjust background SVG corners".

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D26955

To: ndavis, #vdg, #plasma
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26758: Fix the size and pixel alignment of checkboxes and radiobuttons

[Noah Davis]

ndavis added a comment.


  In D26758#601675 , @ngraham wrote:
  
  > I'd like to be able to verify that by looking at a radio button in the 
Plasma style but I can't actually find any. Do you know of any place where 
they're used?
  
  
  plasmathemeexplorer, also D26271 

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D26758

To: ndavis, #plasma, #vdg
Cc: ngraham, davidedmundson, kde-frameworks-devel, LeGast00n, GB_2, michaelh, 
bruns

D26758: Fix the size and pixel alignment of checkboxes and radiobuttons

[Noah Davis]

ndavis added a comment.


  In case it's not clear or for anyone skimming the conversation, I think the 
tests themselves are broken and can't be relied upon because they break things 
that normally work OK or at least better than they do in the tests. I don't 
know QML that well, but I don't see any obvious problems in the code of the 
tests.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D26758

To: ndavis, #plasma, #vdg
Cc: ngraham, davidedmundson, kde-frameworks-devel, LeGast00n, GB_2, michaelh, 
bruns

D26758: Fix the size and pixel alignment of checkboxes and radiobuttons

[Noah Davis]

ndavis added a comment.


  In D26758#601535 , @ngraham wrote:
  
  > Found one small regression in the test suite. The new correct radio button 
sizing results in vertical misalignment (for both PC2 and PC3):
  >
  > Status quo: F7978647: Screenshot_20200127_112436.PNG 

  >
  > With patch: F7978654: Screenshot_20200127_112559.PNG 

  >
  > Everything else looked good to me. Fix that, then let's ship it.
  
  
  I'm pretty sure that test is broken too.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D26758

To: ndavis, #plasma, #vdg
Cc: ngraham, davidedmundson, kde-frameworks-devel, LeGast00n, GB_2, michaelh, 
bruns

D26955: Fix background colors and adjust background corners

[Noah Davis]

ndavis created this revision.
ndavis added reviewers: VDG, Plasma.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
ndavis requested review of this revision.

REVISION SUMMARY
  The shadows patch before this patch had some problems with the SVGs that 
caused dark themes to be light. This fixes that and also makes the corner 
radius exactly the same as in the Breeze widget style.

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  fix-backgrounds (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D26955

AFFECTED FILES
  src/desktoptheme/breeze/dialogs/background.svg
  src/desktoptheme/breeze/translucent/dialogs/background.svg
  src/desktoptheme/breeze/translucent/widgets/panel-background.svg
  src/desktoptheme/breeze/translucent/widgets/tooltip.svg
  src/desktoptheme/breeze/widgets/panel-background.svg
  src/desktoptheme/breeze/widgets/tooltip.svg

To: ndavis, #vdg, #plasma
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26758: Fix the size and pixel alignment of checkboxes and radiobuttons

[Noah Davis]

ndavis added a comment.


  Ping. This patch doesn't fix everything, but it's still an improvement over 
the current state.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D26758

To: ndavis, #plasma, #vdg
Cc: davidedmundson, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, 
bruns

D26920: Change VLC icon to be more like official VLC icons

[Noah Davis]

This revision was not accepted when it landed; it landed in state "Needs 
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit R266:e215cca8900f: Change VLC icon to be more like official 
VLC icons (authored by ndavis).

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26920?vs=74366=74377

REVISION DETAIL
  https://phabricator.kde.org/D26920

AFFECTED FILES
  icons-dark/apps/22/vlc.svg
  icons-dark/apps/32/vlc.svg
  icons-dark/apps/48/vlc.svg
  icons/apps/22/vlc.svg
  icons/apps/32/vlc.svg
  icons/apps/48/vlc.svg

To: ndavis, #vdg
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26920: Change VLC icon to be more like official VLC icons

[Noah Davis]

ndavis edited the summary of this revision.
ndavis edited the test plan for this revision.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D26920

To: ndavis, #vdg
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26920: Change VLC icon to be more like official VLC icons

[Noah Davis]

ndavis created this revision.
ndavis added a reviewer: VDG.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
ndavis requested review of this revision.

REVISION SUMMARY
  This new icon is more in line with our policy on preserving the branding of 
apps.

REPOSITORY
  R266 Breeze Icons

BRANCH
  new-vlc (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D26920

AFFECTED FILES
  icons-dark/apps/22/vlc.svg
  icons-dark/apps/32/vlc.svg
  icons-dark/apps/48/vlc.svg
  icons/apps/22/vlc.svg
  icons/apps/32/vlc.svg
  icons/apps/48/vlc.svg

To: ndavis, #vdg
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26441: New icon for KTimeTracker

[Noah Davis]

ndavis requested changes to this revision.
ndavis added a subscriber: hellcp.
ndavis added a comment.
This revision now requires changes to proceed.


  I have to agree with what @hellcp said in the VDG chat earlier, the mahogany 
really does not fit. It draws attention to the wrong places and is confusing.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D26441

To: cblack, #vdg, ndavis
Cc: hellcp, ndavis, kde-frameworks-devel, aspotashev, LeGast00n, GB_2, 
michaelh, ngraham, bruns

D26758: Fix the size and pixel alignment of checkboxes and radiobuttons

[Noah Davis]

ndavis added a comment.


  In D26758#599231 , @davidedmundson 
wrote:
  
  > Please be sure to run the relevant tests in
  >
  > tests/components/
  >
  > with qmlscene
  >
  > It'll find more than running random applets
  
  
  Unfortunately, those have visual glitches, even for widgets that are normally 
perfectly fine.
  `qmlscene button.qml` (untouched by this patch): The position of the left 
side is off by half a pixel.
  F7918757: Screenshot_20200123_002724.PNG 

  `qmlscene checkbox.qml` (patch vs git master): these unchecked checkboxes are 
normally perfectly fine, but are somehow very wrong. I'm not sure what's going 
there.
  F7918911: Screenshot_20200123_003405.PNG 

  
  I can't figure out what might be wrong with the tests just by looking at the 
source code of the QML files.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D26758

To: ndavis, #plasma, #vdg
Cc: davidedmundson, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, 
bruns

D25015: Update breeze theme shadows

[Noah Davis]

ndavis accepted this revision.

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  bettershadows (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25015

To: niccolove, #vdg, ngraham, The-Feren-OS-Dev, ndavis
Cc: The-Feren-OS-Dev, mart, broulik, cblack, ndavis, manueljlin, ngraham, 
filipf, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D26758: Fix the size and pixel alignment of checkboxes and radiobuttons

[Noah Davis]

ndavis retitled this revision from "[WIP] Fix the size and pixel alignment of 
checkboxes and radiobuttons" to "Fix the size and pixel alignment of checkboxes 
and radiobuttons".

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D26758

To: ndavis, #plasma, #vdg
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

T12567: Reduce code/effort duplication around color scheme support

[Noah Davis]

ndavis added a comment.


  In T12567#218405 , @davidedmundson 
wrote:
  
  > The former won't know when to update, the latter can.
  
  
  So we'll need to make property bindings anyway? Or maybe we can use arrays 
instead of writing 108 individual variables?
  
  > As for the duplication a lot is simply down to layering and dependency 
issues of the time. If we can move this, then we're sorted.
  >  Extending QPalette would be the ideal solution to that.
  
  I'm a little confused. Are you saying we should contribute new ColorRoles to 
QPalette and deprecate KColorScheme?

TASK DETAIL
  https://phabricator.kde.org/T12567

To: ndavis
Cc: davidedmundson, ognarb, plasma-devel, kde-frameworks-devel, ndavis, Orage, 
LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, davidre, fbampaloukas, GB_2, 
ekasprzak, ragreen, domson, michaelh, ahmadsamir, dkardarakos, ZrenBot, 
ngraham, bruns, alexeymin, kpiwowarski, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, asturmlechner, jucato, cfeck, abetts, cgiboudeaux, cullmann, 
vkrause, sebas, cordlandwehr, apol, ahiemstra, mart, hein, knauss, dfaure

T12567: Reduce code/effort duplication around color scheme support

[Noah Davis]

ndavis added a comment.


  QML can use C++ functions right? Would we still need to make property 
bindings for all the colors if we had color() functions?

TASK DETAIL
  https://phabricator.kde.org/T12567

To: ndavis
Cc: ognarb, plasma-devel, kde-frameworks-devel, ndavis, Orage, LeGast00n, 
The-Feren-OS-Dev, jraleigh, zachus, davidre, fbampaloukas, GB_2, ekasprzak, 
ragreen, domson, michaelh, ahmadsamir, dkardarakos, ZrenBot, ngraham, bruns, 
alexeymin, kpiwowarski, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
asturmlechner, jucato, cfeck, abetts, cgiboudeaux, cullmann, vkrause, sebas, 
cordlandwehr, apol, ahiemstra, davidedmundson, mart, hein, knauss, dfaure

D25814: [KColorScheme] Add SeparatorColor

[Noah Davis]

ndavis added a comment.


  I think this is still ultimately the right thing to do. Making the 
frame/separator color a mix of 2 other colors makes it harder to get just the 
right color for both the light and dark variations of a theme unless you design 
the color palettes to solve problems in the QStyle. That makes it more 
difficult for users/3rd parties to design color schemes unless you're very 
familiar with the way the QStyle works.
  
  I missed this from before:
  
  In D25814#574152 , @cfeck wrote:
  
  > I also agree with the concerns rised by Hugo. An application will use 
various frame primitives, and the style decides how to draw them. It doesn't 
belong in the API, though (but neither do Focus and Hover colors).
  
  
  Why don't focus and hover colors belong?

REPOSITORY
  R265 KConfigWidgets

REVISION DETAIL
  https://phabricator.kde.org/D25814

To: ndavis, #frameworks, #vdg
Cc: broulik, manueljlin, alexde, ngraham, davidedmundson, filipf, cfeck, 
hpereiradacosta, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

T12567: Reduce code/effort duplication around color scheme support

[Noah Davis]

ndavis updated the task description.

TASK DETAIL
  https://phabricator.kde.org/T12567

To: ndavis
Cc: plasma-devel, kde-frameworks-devel, ndavis, Orage, LeGast00n, 
The-Feren-OS-Dev, jraleigh, zachus, davidre, fbampaloukas, GB_2, ekasprzak, 
ragreen, domson, michaelh, ahmadsamir, dkardarakos, ZrenBot, ngraham, bruns, 
alexeymin, kpiwowarski, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
asturmlechner, jucato, cfeck, abetts, cgiboudeaux, cullmann, vkrause, sebas, 
cordlandwehr, apol, ahiemstra, davidedmundson, mart, hein, knauss, dfaure

D25015: Update breeze theme shadows

[Noah Davis]

ndavis added a comment.


  Just in case you misunderstood me, when I said create the corners from 
rounded rectangles, I meant create the rounded rectangle and cut off the parts 
you don't need so that you're left with corners that you can place however you 
need. If you're not aware of it, check out Inkscape's Path menu. It has a ton 
of useful stuff for sculpting shapes.

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  bettershadows (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25015

To: niccolove, #vdg, ngraham
Cc: mart, broulik, cblack, ndavis, manueljlin, ngraham, filipf, 
kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D25015: Update breeze theme shadows

[Noah Davis]

ndavis added a comment.


  I'll trust your judgement on the masks and corners. If there's a problem, it 
can be patched. I know this stuff can be super janky at times.

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  bettershadows (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25015

To: niccolove, #vdg, ngraham
Cc: mart, broulik, cblack, ndavis, manueljlin, ngraham, filipf, 
kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D25015: Update breeze theme shadows

[Noah Davis]

ndavis added a comment.


  I noticed a few things.
  
  ---
  
  The masks have a rather odd shape and it's not pixel aligned, which might 
mean something is wrong: 
  F7891523: Screenshot_20200118_225818.PNG 

  It's different from master, which looks pretty normal: 
  F7891527: Screenshot_20200118_230209.PNG 

  
  ---
  
  In the `panel-background` a `tooltip` SVGs the shadow was changed, but the 
tooltip was not. Keep in mind that 
  F7891542: Screenshot_20200118_231610.PNG 

  
  ---
  
  I get the impression that these were changed with the node tool rather than 
creating the corners from rounded rectangles. I guess that works as long as all 
the svg corners are consistent with each other, but it's inconsistent with the 
QStyle and could still lead to visible pixel misalignment when the UI is scaled 
up.
  F7891536: Screenshot_20200118_230921.PNG 

  
  ---
  
  Why is `widgets/background.svg` different from the other ones? Maybe there's 
a good reason, since it's also different in the master branch, but its very odd.
  F7891628: Screenshot_20200118_232026.PNG 


REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  bettershadows (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25015

To: niccolove, #vdg, ngraham
Cc: mart, broulik, cblack, ndavis, manueljlin, ngraham, filipf, 
kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D26758: [WIP] Fix the size and pixel alignment of checkboxes and radiobuttons

[Noah Davis]

ndavis added a comment.


  For some reason, the corners of the checkbox indicator don't overlap 
perfectly with the corners of the base checkbox, even though the corners are 
exactly the same in the SVGs.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D26758

To: ndavis, #plasma, #vdg
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26758: [WIP] Fix the size and pixel alignment of checkboxes and radiobuttons

[Noah Davis]

ndavis edited the test plan for this revision.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D26758

To: ndavis, #plasma, #vdg
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26758: [WIP] Fix the size and pixel alignment of checkboxes and radiobuttons

[Noah Davis]

ndavis edited the summary of this revision.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D26758

To: ndavis, #plasma, #vdg
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26758: [WIP] Fix the size and pixel alignment of checkboxes and radiobuttons

[Noah Davis]

ndavis added a comment.


  This patch has a few problems and some things to consider.
  
  - Changing the size to `units.iconSizes.small` doesn't seem to break any 
layouts we have, but I have not done extensive testing with 3rd party widgets.
  - Is the size too small for touch input? If yes, that would mean the QStyle 
needs to be changed too.
  - For whatever reason, the checkboxes and radio buttons seem to grow in 
height and width by maybe 1px when hovered or checked. I can't figure out why 
and it still causes some pixel alignment issues, particularly with radio 
buttons.
  - Is it desirable to have multiple sizes for checkboxes and radio buttons? If 
not, then I suppose I should remove every size other than the one we choose 
from the svgs. Currently, I have 16, 22, 24 and 32px versions in both svgs.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D26758

To: ndavis, #plasma, #vdg
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26758: [WIP] Fix the size and pixel alignment of checkboxes and radiobuttons

[Noah Davis]

ndavis created this revision.
ndavis added reviewers: Plasma, VDG.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
ndavis requested review of this revision.

REVISION SUMMARY
  The checkboxes and radio buttons in plasmashell were signficantly different 
from checkboxes and radio buttons in the Breeze QStyle.
  
  - Plasmashell checkboxes and radio buttons were much larger.
- 24x24 for checkboxes and 29x29 for radio buttons (Plasmashell) vs 16x16 
(QStyle).
  - Pixel alignment was very poor.
- Checkbox indicator was 14x14, stretched to 24x24.
- Radio button background was 22x22 or 32x32, adjusted to 29x29.
- Radio button indicator was 16x16, stretched to 29x29.
  - Style was different.
- Checkbox indicators had sharper corners and less margin around the inner 
rectangle.
- Radio buttons had a hardcoded dark gray circular frame and a shadow on 
the bottom of the inside of the frame.
- Radio button indicators had less margin around the inner circle.

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  checkbox-radiobutton (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D26758

AFFECTED FILES
  src/declarativeimports/plasmacomponents3/CheckIndicator.qml
  src/declarativeimports/plasmacomponents3/RadioButton.qml
  src/declarativeimports/plasmacomponents3/RadioIndicator.qml
  src/declarativeimports/plasmastyle/CheckBoxStyle.qml
  src/declarativeimports/plasmastyle/RadioButtonStyle.qml
  src/desktoptheme/breeze/widgets/actionbutton.svg
  src/desktoptheme/breeze/widgets/checkmarks.svg

To: ndavis, #plasma, #vdg
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26703: Add icon for text/vnd.kde.kcrash-report

[Noah Davis]

ndavis accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D26703

To: broulik, #vdg, ndavis
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26671: Cleanup and add 22px media repeat icons

[Noah Davis]

ndavis accepted this revision.

REPOSITORY
  R266 Breeze Icons

BRANCH
  repeatIcons

REVISION DETAIL
  https://phabricator.kde.org/D26671

To: astippich, #vdg, ngraham, ndavis
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26649: [KMessageBox] Only allow selecting text in the dialog box using the mouse

[Noah Davis]

ndavis added a comment.


  In D26649#593825 , @broulik wrote:
  
  > So you can't tab around to end up focusing the text field?
  
  
  You currently aren't able to, but after you click with the mouse on the text, 
you can use the arrow keys to move an I beam around in the text.

REPOSITORY
  R236 KWidgetsAddons

BRANCH
  no-more-keyboard-selectability (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D26649

To: ngraham, dfaure, #frameworks, #vdg, ndavis
Cc: broulik, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26649: [KMessageBox] Only allow selecting text in the dialog box using the mouse

[Noah Davis]

ndavis accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R236 KWidgetsAddons

BRANCH
  no-more-keyboard-selectability (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D26649

To: ngraham, dfaure, #frameworks, #vdg, ndavis
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26595: Add network-wireless-hotspot icon

[Noah Davis]

ndavis added a comment.


  In D26595#592368 , @ngraham wrote:
  
  > Hmm, at normal size, the 8, 16, and 22px versions look too busy to me.:
  
  
  I kind of agree.
  
  > For the 16 and 22px versions, maybe reduce the number of waves and increase 
the spacing between them. And do we even need an 8px version?
  
  We don't need an 8px version.
  
  @cblack, if we did need an 8px version, you'd have to edit `index.theme` and 
define the 8px device icons folder.
  
  -
  
  One trick I learned from looking at the wifi icon is that you don't have to 
perfectly center the lines and the cut. If you offset them in a consistent way, 
you can get the spacing you want and the lines will still look fine.
  
  Here are edited versions of the 16 and 22px icons with a couple variations 
each: F7878874: network-wireless-hotspot.svg 
 F7878875: network-wireless-hotspot.svg 

  
  In the 16px version, I used a 14px outer circle, lowered it by 1px and cut it 
with a right triangle.
  
  F7878890: Screenshot_20200112_053351.PNG 

  
  In the 22px version, I cut it the same way, but only to give the triangle 
bottom variant a bit more space. It's not needed if you use the antenna variant.
  F7878893: Screenshot_20200112_053723.PNG 

  
  --
  
  I think the radio waves around the 32px version should be 1px thick.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D26595

To: cblack, #vdg
Cc: ndavis, ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D26555: Rename 'nepomuk' Plasma Theme icons to 'search'

[Noah Davis]

ndavis accepted this revision.
ndavis added a comment.
This revision is now accepted and ready to land.


  Icons in the desktop theme that are made to replace icons in the icon theme 
need to be kept up to date with the icon theme. I'm accepting this as it is, 
but if @davidre thinks we should continue to support the use of the `nepomuk` 
icon name, then include both in the desktop theme. If this seems inelegant, 
that's because comprehensive icon support is not very pretty, technically. 
breeze-icons is filled with tons of symlinks for compatibility and there's 
really nothing we can do about it.

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D26555

To: The-Feren-OS-Dev, #plasma, #vdg, ndavis
Cc: ndavis, davidre, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, 
bruns

D25814: [KColorScheme] Add SeparatorColor

[Noah Davis]

ndavis added a subscriber: broulik.
ndavis added a comment.


  In D25814#591053 , @ngraham wrote:
  
  > I wonder if a path forward is to move this option into Breeze itself and 
keep it out of the color scheme. We would add an option for "dark separators 
when using a dark color scheme" in the super hidden Breeze settings window.
  
  
  Hugo did suggest that. Although @broulik was just mentioning in the VDG chat 
that QML can't reuse the color because it's defined in Breeze and not part of 
the colorscheme.

REPOSITORY
  R265 KConfigWidgets

REVISION DETAIL
  https://phabricator.kde.org/D25814

To: ndavis, #frameworks, #vdg
Cc: broulik, manueljlin, alexde, ngraham, davidedmundson, filipf, cfeck, 
hpereiradacosta, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D26441: New icon for KTimeTracker

[Noah Davis]

ndavis added a comment.


  The top part looks a bit too flat and wide. There's also nothing attaching it 
to the body, so it looks like it's floating.
  
  I don't think Plasma Blue work well as a body color with no outline. This 
happens when I select the file in dolphin because it blends in with the 
highlight: F7862751: Screenshot_20200105_155033.PNG 


REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D26441

To: cblack, #vdg
Cc: ndavis, kde-frameworks-devel, aspotashev, LeGast00n, GB_2, michaelh, 
ngraham, bruns

D26404: Turn application/x-ms-shortcut into an actual shortcut icon

[Noah Davis]

ndavis accepted this revision.
ndavis added a comment.
This revision is now accepted and ready to land.


  Make sure you copy to breeze dark as well

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D26404

To: broulik, #vdg, ndavis
Cc: ndavis, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26404: Turn application/x-ms-shortcut into an actual shortcut icon

[Noah Davis]

ndavis requested changes to this revision.
ndavis added a comment.
This revision now requires changes to proceed.


  For 16/22px, symlinking to existing monochrome link icons is acceptable.
  
  This patch does not apply cleanly. The base commit isn't available.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D26404

To: broulik, #vdg, ndavis
Cc: ndavis, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26326: Add application/x-audacity-project icon

[Noah Davis]

ndavis accepted this revision.

REPOSITORY
  R266 Breeze Icons

BRANCH
  arcpatch-D26326

REVISION DETAIL
  https://phabricator.kde.org/D26326

To: cblack, #vdg, ndavis, ngraham, broulik
Cc: cblack, ndavis, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, 
bruns

D26326: Add application/x-audacity-project icon

[Noah Davis]

ndavis accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D26326

To: broulik, #vdg, ndavis, ngraham
Cc: ndavis, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

T11950: Reduce the pain of working on monochrome Breeze icons

[Noah Davis]

ndavis added a comment.


  For the Inkscape optimized svg gradient problem: 
https://gitlab.com/inkscape/inbox/issues/1121

TASK DETAIL
  https://phabricator.kde.org/T11950

To: ngraham, ndavis
Cc: mglb, #frameworks, mart, trickyricky26, ndavis, #vdg, ngraham, manueljlin, 
LeGast00n, cblack, konkinartem, ian, jguidon, hannahk, Ghost6, jraleigh, 
MrPepe, fbampaloukas, squeakypancakes, alexde, IohannesPetros, GB_2, michaelh, 
crozbo, firef, bruns, skadinna, aaronhoneycutt, mbohlender

D26326: Add application/x-audacity-project icon

[Noah Davis]

ndavis requested changes to this revision.
ndavis added a comment.
This revision now requires changes to proceed.


  Just needs some optimization and it'll be good to go

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D26326

To: broulik, #vdg, ndavis
Cc: ndavis, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26313: Add application/vnd.apple.pkpass icon

[Noah Davis]

ndavis accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D26313

To: broulik, #vdg, vkrause, ndavis
Cc: ndavis, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26313: Add application/vnd.apple.pkpass icon

[Noah Davis]

ndavis requested changes to this revision.
ndavis added a comment.
This revision now requires changes to proceed.


  Nice work!
  
  Looks like the 64px version got a part of it knocked out of position:
  F7851485: Screenshot_20191230_204235.PNG 

  
  Once that's fixed, run it through an optimizer and copy these to the 
icons-dark folder.
  
  
https://community.kde.org/Guidelines_and_HOWTOs/Icon_Workflow_Tips#SVG_optimization

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D26313

To: broulik, #vdg, vkrause, ndavis
Cc: ndavis, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26146: Delete icon

[Noah Davis]

ndavis accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R293 Baloo

BRANCH
  delete-icon (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D26146

To: ngraham, #baloo, #vdg, IlyaBizyaev, ndavis
Cc: kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, fbampaloukas, GB_2, 
domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams

D25878: Use clearer relative dates

[Noah Davis]

ndavis accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R244 KCoreAddons

BRANCH
  better-relative-dates (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25878

To: ngraham, davidedmundson, #vdg, #frameworks, ndavis
Cc: broulik, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25334: Added transparent blue background to tabbars

[Noah Davis]

ndavis added a comment.


  In D25334#578285 , @niccolove 
wrote:
  
  > Breeze dark highlight is currently #3daee9 in the Breeze Dark colorscheme. 
If that's too light, we could darken it there, right?
  >  Currently it's: F7819764: Screenshot_20191215_163924.png 

  >  Darker could be (example value):
  >  F7819766: Screenshot_20191215_164056.png 

  >  Otherwise, the highlight effect could be made more transparent so that 
it's darker, but that would be a problem for consistency, as the same highlight 
color is also used throughout the desktop theme.
  
  
  The base highlight color is not the problem, it's the background area based 
on the highlight color.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D25334

To: niccolove, #vdg, ngraham, ndavis
Cc: ngraham, ndavis, KonqiDragon, #vdg, kde-frameworks-devel, LeGast00n, GB_2, 
michaelh, bruns

D25999: Add optional subtitle to grid delegate

[Noah Davis]

ndavis resigned from this revision.
ndavis added a comment.
This revision now requires review to proceed.


  Whoops, didn't mean to give my official approval

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D25999

To: ngraham, #vdg, #plasma, davidedmundson
Cc: ndavis, filipf, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, 
bruns

D25999: Add optional subtitle to grid delegate

[Noah Davis]

ndavis accepted this revision.
ndavis added a comment.
This revision is now accepted and ready to land.


  +1 visually

REPOSITORY
  R296 KDeclarative

BRANCH
  optional-subtitle (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25999

To: ngraham, #vdg, #plasma, davidedmundson, ndavis
Cc: ndavis, filipf, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, 
bruns

D25897: Add 32, 48 and 64 px user-desktop icons

[Noah Davis]

This revision was automatically updated to reflect the committed changes.
Closed by commit R242:bcc1ba205d60: Add 32, 48 and 64 px user-desktop icons 
(authored by ndavis).

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25897?vs=71467=71469

REVISION DETAIL
  https://phabricator.kde.org/D25897

AFFECTED FILES
  src/desktoptheme/breeze/icons/user.svg

To: ndavis, #plasma, #vdg, ngraham
Cc: ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D25897: Add 32, 48 and 64 px user-desktop icons

[Noah Davis]

ndavis edited the test plan for this revision.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D25897

To: ndavis, #plasma, #vdg
Cc: ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D25897: Add 32, 48 and 64 px user-desktop icons

[Noah Davis]

ndavis updated this revision to Diff 71467.
ndavis added a comment.


  - increase line thickness for 48 and 64 px

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25897?vs=71303=71467

BRANCH
  show-desktop-icon (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25897

AFFECTED FILES
  src/desktoptheme/breeze/icons/user.svg

To: ndavis, #plasma, #vdg
Cc: ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D25897: Add 32, 48 and 64 px user-desktop icons

[Noah Davis]

ndavis added a comment.


  In D25897#576015 , @ngraham wrote:
  
  > The straight lines in the system tray items from my screenshot are 
definitely 1px strokes. But all the curved lines look thicker by virtue of not 
being able to align to the pixel grid. And most monochrome widgets have thicker 
lines when added to a tall panel:
  >
  > F7813795: Screenshot_20191212_101746.png 

  >
  > This may be a side effect of scaling up smaller icons, but I think the 
thicker strokes work well for a large panel.
  
  
  ew, blurry icons :(
  
  In D25897#576015 , @ngraham wrote:
  
  > The straight lines in the system tray items from my screenshot are 
definitely 1px strokes. But all the curved lines look thicker by virtue of not 
being able to align to the pixel grid. And most monochrome widgets have thicker 
lines when added to a tall panel:
  >
  > F7813795: Screenshot_20191212_101746.png 

  >
  > This may be a side effect of scaling up smaller icons, but I think the 
thicker strokes work well for a large panel.
  
  
  I think the icons in that screenshot are 32px scaled to 48px.
  
  Perhaps line thickness could be increased for the 48 and 64px versions, but I 
do not think it should be increased for 32px. That would require us to make 
32px icons less detailed than 22px icons because the effective space would be 
brought down to the level of 16px icons. Monochrome icons should not be highly 
detailed though, so the extra space is completely wasted on the 48 and 64 px 
versions.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D25897

To: ndavis, #plasma, #vdg
Cc: ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D25296: [RFC] Fix Display Configuration icon margins

[Noah Davis]

ndavis accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  fix-xrandr-icon (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25296

To: ngraham, #vdg, ndavis
Cc: trickyricky26, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, 
bruns

D25897: Add 32, 48 and 64 px user-desktop icons

[Noah Davis]

ndavis added a comment.


  In D25897#575934 , @ngraham wrote:
  
  > Thanks. However I wonder if the stroke width ought to increase for the 
larger sizes? Having such skinny lines looks a tad odd to me IMO:
  >
  > F7813271: Screenshot_20191211_235533.png 

  
  
  If you look to the left, the other 32px icons also use lines that are that 
thin. The difference is that the desktop icon is so empty compared to the other 
icons. I don't know what to do about this TBH.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D25897

To: ndavis, #plasma, #vdg
Cc: ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D25897: Add 32, 48 and 64 px user-desktop icons

[Noah Davis]

ndavis edited the test plan for this revision.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D25897

To: ndavis, #plasma, #vdg
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25897: Add 32, 48 and 64 px user-desktop icons

[Noah Davis]

ndavis created this revision.
ndavis added reviewers: Plasma, VDG.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
ndavis requested review of this revision.

REVISION SUMMARY
  This prevents the icon from becoming blurry at fairly normal panel widths.

TEST PLAN
  - make/ninja install
  - rm -r ~/.cache/plasma*
  - plasmashell --replace &

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  show-desktop-icon (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25897

AFFECTED FILES
  src/desktoptheme/breeze/icons/user.svg

To: ndavis, #plasma, #vdg
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25855: Don't show the info icon on the big preview delegate

[Noah Davis]

ndavis accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R304 KNewStuff

BRANCH
  dont-show-that-info-icon (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25855

To: leinir, #frameworks, #knewstuff, ngraham, abetts, #vdg, ndavis
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25820: SimpleScreenRecorder icon added

[Noah Davis]

ndavis added a comment.


  In D25820#574397 , @vinzenzv wrote:
  
  > In D25820#574119 , @ndavis wrote:
  >
  > > Good start! The lens flare looks upside down
  >
  >
  > That was intentionally to make it distinguishable from digiKam.
  
  
  I don't think it works because the light source in Breeze comes from the top 
left.
  
  >> and the icon needs more pixel alignment.
  > 
  > I didn't move anything around besides the lense flares. So consequentially 
the digiKam would need that as well. I'm not sure if that's intended?
  
  It's the lens flare and center part that aren't pixel aligned. Except for the 
smaller dot in the lens flare, they were aligned in the original version. 
F7807704: Screenshot_20191210_075015.png 
  What you could do instead of a lens flare is implement the rings of light 
that the official icon uses: 
https://github.com/MaartenBaert/ssr/blob/master/data/icons/48/simplescreenrecorder.png
  It doesn't have to be exactly the same as the original's rings, but it should 
remind you of them and look fairly natural.
  
  >> I feel like the red/green/blue colors of the center area are a bit too 
dark as well.
  > 
  > Yes, I'd thinks so too - but I took the original icon's colors. So we'd 
better not change that or the icon would move to far from the original?
  
  It's OK to deviate a bit from the original as long as you preserve the spirit 
of the original.
  
  In case you haven't seen the HIG, here is a list of some official colors you 
can use: https://hig.kde.org/style/color/default.html
  You can deviate from that list, but be mindful of the hues and saturation 
levels so that your choice of color isn't too far from what Breeze normally 
looks like. Also, avoid using any of the "Primary" colors (excluding Icon Gray, 
which we don't actually use for icons much) for backgrounds unless you have an 
outline in a different color. You don't want your icon to blend into the 
background of the UI.
  
  ---
  
  An extra tip: Zoom out to 100% with the grid, guides and page outline turned 
off so you can see what your icon would normally look like. It's important to 
make sure it looks good at higher zoom levels too since SVGs are scalable, but 
you should be most concerned with how it looks at 100% size.
  
  As you can see, even though there is an inner ring and a smaller circle, it 
looks like one dark green circle because they aren't pixel aligned. The smaller 
circle in the lens flare looks a bit shorter than it actually is for the same 
reason.
  F7808128: Screenshot_20191210_114611.png 


REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D25820

To: vinzenzv, #vdg, ndavis
Cc: filipf, ndavis, kde-frameworks-devel, LeGast00n, fbampaloukas, GB_2, 
trickyricky26, michaelh, ngraham, bruns

D25814: [KColorScheme] Add SeparatorColor

[Noah Davis]

ndavis added a comment.


  In D25814#574395 , @filipf wrote:
  
  > Already asked in VDG, but repeating here: how would we handle dark 
separators on really dark color schemes?
  >
  > This is the most downloaded color scheme and it won't work well with dark 
separators: https://store.kde.org/p/1294011/
  
  
  Are you asking in the case that we don't have a colorscheme color for 
separators or in the case that we do?
  Without: Either use special logic to use light separators when the background 
gets too dark or just allow the separators to be nearly invisible
  With: The colorscheme specifies an appropriate separator color or use Window 
Background 75%, Window Text 25% as the fallback color.

REPOSITORY
  R265 KConfigWidgets

REVISION DETAIL
  https://phabricator.kde.org/D25814

To: ndavis, #frameworks, #vdg
Cc: alexde, ngraham, davidedmundson, filipf, cfeck, hpereiradacosta, 
kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D25815: Transmission-Qt tray icon added

[Noah Davis]

ndavis added a comment.


  wait scratch that, it does work. I had to remove the `22-22-` prefix, which 
is what you need to do when you have multiple icon sizes.

REVISION DETAIL
  https://phabricator.kde.org/D25815

To: vinzenzv, #vdg, ndavis, ngraham
Cc: broulik, ndavis, ngraham, iasensio, kde-frameworks-devel, LeGast00n, 
fbampaloukas, GB_2, trickyricky26, michaelh, bruns

D25815: Transmission-Qt tray icon added

[Noah Davis]

ndavis added a comment.


  In D25815#574394 , @vinzenzv wrote:
  
  > In D25815#574216 , @ndavis wrote:
  >
  > > Here's one way to make a nice looking trapezoid in the Breeze style. I 
started by making a stroke with end points in the middle of pixels and the 
other settings I mentioned in my first comment. Then I converted it to a path 
and I added a 2px high rectangle to increase the thickness of the bottom part.
  >
  >
  > So as you already built it the icon is finished, right?
  
  
  Yes. We should probably add a 32px version too though. Panel tooltips use 
32px icons and I know @ngraham likes to set his systray icons to 32px. 22px 
icons scaled to 32px usually look blurry.
  
  I ran into another roadblock though. I tried to set the group id to 
`transmission-tray-icon` as @broulik said and it still wouldn't work. I wonder 
if the icon is hardcoded.

REVISION DETAIL
  https://phabricator.kde.org/D25815

To: vinzenzv, #vdg, ndavis, ngraham
Cc: broulik, ndavis, ngraham, iasensio, kde-frameworks-devel, LeGast00n, 
fbampaloukas, GB_2, trickyricky26, michaelh, bruns

D25814: [KColorScheme] Add SeparatorColor

[Noah Davis]

ndavis added a comment.


  In D25814#574356 , 
@hpereiradacosta wrote:
  
  > I meant: do the "light" (with window text color) toolbar icons play well 
with dark toolbar separators as opposed to current semi-light toolbar separators
  
  
  I assume you mean visually play well. It could, but it depends on other 
factors like consistency with the rest of the theme and other types of styling. 
Fusion uses dark toolbar separators (although they are lighter on the right 
side) and it doesn't stand out as ugly, but they're not quite my taste and a 
bit hard to see. F7806755: Screenshot_20191209_155237.png 

  
  FWIW, Adwaita Dark uses dark separators, but GNOME doesn't use nearly as many 
icons as we do. F7806761: Screenshot_20191209_155912.png 
 F7806768: Screenshot_20191209_160349.png 

  
  I see icons as similar to text in how other UI elements should be designed 
around them.

REPOSITORY
  R265 KConfigWidgets

REVISION DETAIL
  https://phabricator.kde.org/D25814

To: ndavis, #frameworks, #vdg
Cc: ngraham, davidedmundson, filipf, cfeck, hpereiradacosta, 
kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D25814: [KColorScheme] Add SeparatorColor

[Noah Davis]

ndavis added a comment.


  In D25814#574250 , 
@hpereiradacosta wrote:
  
  > - You should add toolbar separators, tabboxes and group boxes to that. For 
toolbar separators, I wonder how this would play with monochrome (color-themed) 
icons.
  
  
  I'm not sure what you mean when you wonder how it would play with monochrome 
icons. It should have nothing to do with them unless you embed stylesheets in 
the SVGs to use the separator color in breeze icons.
  
  > - Note that for frames, they come in three flavor (raised, sunken or flat) 
and not all widget themes ignore this additional setting the way breeze does 
(design decision). Oxygen does not.
  
  That's a good point and I hadn't considered it. I suppose whether or not 
SeparatorColor is used for frames would be left up to the theme, but that does 
hurt where this color can be applied.
  
  > - in breeze and in almost all widget themes, button frames are not the same 
color are ordinary frames. The former uses ButtonText and ButtonBackground, the 
later uses WindowText and WindowBackground. By replacing this by one single 
color, one would effectively break all the color schemes that use different 
colors for these two sets.
  
  Decoration colors can be customized individually for each color set, so 
button frames can use Button SeparatorColor.
  
  Some other thoughts:
  
  - Complementary SeparatorColor could be used for dark separators when a theme 
uses both light and dark separators or frames.
  - I suppose I could use AlternateBackground or InactiveText instead of 
SeparatorColor, but that seems semantically incorrect.

REPOSITORY
  R265 KConfigWidgets

REVISION DETAIL
  https://phabricator.kde.org/D25814

To: ndavis, #frameworks, #vdg
Cc: ngraham, davidedmundson, filipf, cfeck, hpereiradacosta, 
kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D25340: Added background colors to active and inactive icon view

[Noah Davis]

This revision was automatically updated to reflect the committed changes.
Closed by commit R242:7e52c869de2d: Added background colors to active and 
inactive icon view (authored by ndavis).

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25340?vs=71092=71136

REVISION DETAIL
  https://phabricator.kde.org/D25340

AFFECTED FILES
  src/desktoptheme/breeze/widgets/tasks.svg

To: ndavis, #vdg, ngraham, niccolove
Cc: filipf, manueljlin, ngraham, ndavis, kde-frameworks-devel, LeGast00n, GB_2, 
michaelh, bruns

D25815: Transmission-Qt tray icon added

[Noah Davis]

ndavis added a comment.


  Here's one way to make a nice looking trapezoid in the Breeze style. I 
started by making a stroke with end points in the middle of pixels and the 
other settings I mentioned in my first comment. Then I converted it to a path 
and I added a 2px high rectangle to increase the thickness of the bottom part.
  F7806306: Screenshot_20191209_085144.png 


REVISION DETAIL
  https://phabricator.kde.org/D25815

To: vinzenzv, #vdg, ndavis, ngraham
Cc: broulik, ndavis, ngraham, iasensio, kde-frameworks-devel, LeGast00n, 
fbampaloukas, GB_2, trickyricky26, michaelh, bruns

D25815: Transmission-Qt tray icon added

[Noah Davis]

ndavis added a comment.


  In D25815#574150 , @broulik wrote:
  
  > I chceked transmission git code and the icon name it uses is actually 
`transmission-tray-icon`, so you want to have a `transmission.svg` file and the 
"id" to be `transmission-tray-icon`, then it should work: 
https://github.com/transmission/transmission/blob/master/qt/MainWindow.cc#L302
  
  
  Thanks!

REVISION DETAIL
  https://phabricator.kde.org/D25815

To: vinzenzv, #vdg, ndavis, ngraham
Cc: broulik, ndavis, ngraham, iasensio, kde-frameworks-devel, LeGast00n, 
fbampaloukas, GB_2, trickyricky26, michaelh, bruns

D25814: [KColorScheme] Add SeparatorColor

[Noah Davis]

ndavis added a comment.


  In D25814#574129 , 
@hpereiradacosta wrote:
  
  > Few more comments on this:
  >
  > - general: you will never be able to make all the opiniated people happy, 
and you have to draw a line (otherwise your code will become bloated, buggy, 
and unmaintainable)
  > - regarding this specific case: many widget style will not implement this 
new color. For those this will just generate bugs reports: why is my color 
scheme not respectd ?
  > - some widget styles (oxygen at least, but I'm sure there are others) use 
two colors for frames and separators, to mimic shadows or relief effects. 
Adding one single color for this will not fit such schemes.
  > - in the end if you need an extra color for a given theme (be it 
future-breeze or whatever), there is also the possibility to add it as a extra 
option for this specific theme, rather than forcing it to kcolorscheme and 
imposing it to all styles (or making kcolorscheme broken for all the styles 
that wont use it). This is how window decoration shadows and glow were handled 
to oxygen. I think this change will break more things than it will fix, 
especially if the fix is to make some opinionated people happy.
  
  
  
  
  - I know it's not a great reason, but I want the setting too. I'm not only 
making it for others.
  - The most popular 3rd party themes (Kvantum themes) don't even support 
colorschemes. For Kvantum users, colorschemes are only useful for setting the 
colors on QML apps, which Kvantum doesn't properly set the colors for. AFAIK, 
the only other commonly used QStyles are Breeze, Oxygen and QStyles provided by 
Qt. Qt's QStyles only uses colors that map to QPalette colors. The only 
customizable colors which don't map to QPalette that Oxygen and Breeze use are 
View FocusColor, View HoverColor and View NegativeText. Oxygen also uses 
KColorScheme's shade colors. If KColorScheme is only used by us, what is is the 
point of having KColorScheme if we barely use it and we cannot extend it for 
use with our own software?
  - I don't intend to change Oxygen.
  - The VDG has been trying to make it easier to navigate through SySe, so I 
want to avoid putting more settings in poorly visible locations. I also want 
access to this color outside of the Breeze widget style so that it can be used 
in Plasmashell and QML apps. I suppose I wouldn't have to make this 
customizable for users to do the last part.
  - I'm not sure what you mean by "break". Do you mean themes that previously 
worked will stop working?

REPOSITORY
  R265 KConfigWidgets

REVISION DETAIL
  https://phabricator.kde.org/D25814

To: ndavis, #frameworks, #vdg
Cc: davidedmundson, filipf, cfeck, hpereiradacosta, kde-frameworks-devel, 
LeGast00n, GB_2, michaelh, ngraham, bruns

D25814: [KColorScheme] Add SeparatorColor

[Noah Davis]

ndavis added a comment.


  In D25814#574160 , @davidedmundson 
wrote:
  
  > Can we clarify what separators we're referring to.
  
  
  Frames around UI elements and horizontal/vertical lines that separate UI 
elements.
  These are the most common examples, but probably not absolutely everything: 
F7806225: Screenshot_20191209_070836-1.png 


REPOSITORY
  R265 KConfigWidgets

REVISION DETAIL
  https://phabricator.kde.org/D25814

To: ndavis, #frameworks, #vdg
Cc: davidedmundson, filipf, cfeck, hpereiradacosta, kde-frameworks-devel, 
LeGast00n, GB_2, michaelh, ngraham, bruns

D25820: SimpleScreenRecorder icon added

[Noah Davis]

ndavis requested changes to this revision.
ndavis added a comment.
This revision now requires changes to proceed.


  Good start! The lens flare looks upside down and the icon needs more pixel 
alignment. I feel like the red/green/blue colors of the center area are a bit 
too dark as well.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D25820

To: vinzenzv, #vdg, ndavis
Cc: ndavis, kde-frameworks-devel, LeGast00n, fbampaloukas, GB_2, trickyricky26, 
michaelh, ngraham, bruns

D25814: [KColorScheme] Add SeparatorColor

[Noah Davis]

ndavis added a comment.


  @hpereiradacosta, Fair points and I'm glad you spoke up. JFYI, I'm in no rush 
to land this and I will consider reserving this change for KF6 if experienced 
KDE devs think that is best.
  
  In D25814#574105 , 
@hpereiradacosta wrote:
  
  > Adding new entries to the kcolorscheme should be done with a lot of care, 
because it could be seen as some sort of API break for existing colorscheme, as 
soon as you start using this color in the widget style: you would need a 
fallback implementation, for all the colorscheme in the open which do not 
implement this particular color. These kind of additions happened a lot whith 
gtk3 css style and resulting of overall unhappiness and distrust from 
theme/color scheme developpers. This also increases the complexity of the code 
and difficulty to maintain.
  
  
  In terms of breakage, I think it would be fine if I made the color fallback 
(as you said) to what the breeze widget style currently does. 3rd party widget 
styles wouldn't use this color without modification, so it shouldn't hurt them. 
KColorScheme already has default colors, but they're defined before 
KColorScheme tries to read colors from the colorscheme file instead of when a 
color is not found. That hurts the flexibility of these defaults and seems 
backwards to me, but there may be a reason for it that I don't know of.
  
  > Also I am not convinced about the usefullness of this option either, 
especially considering that tweaking the colorscheme in the systemsettings is 
already quite advanced configuration (I would bet that most users stop at 
switching between pre-made color schemes, rather than tweaking a particular 
one. This will get even less the case if you start implementing more corner 
case colors.
  
  Yes, it is yet another option in a sea of options, many of which are 
completely useless when a user ventures outside of the Common Colors section. 
You're probably correct that most users don't even bother with manually 
adjusting colors since choosing good colors can be tricky. I don't think that 
makes this option useless though, except for the fact that it's repeated for 
each color set and only a few versions of it will get any amount of use. I hope 
to simplify the colorscheme editor in the future so that only options that do 
something are exposed.
  
  > Or do you plan to ship a "breeze dark with dark separators" +and+ a "breeze 
dark with light separators" ?
  
  I do not.
  
  > All in all i would say that people (that is: active developpers and the 
very few that manifest themselves on developper/vdg channels) having different 
opinion is not a strong enough argument to expose such a low level tweaking to 
all. Or is there an actual poll that shows (on a larger data sample) that one 
really cannot decide between the two options ?
  
  There is no such poll.

REPOSITORY
  R265 KConfigWidgets

BRANCH
  separator-color (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25814

To: ndavis, #frameworks, #vdg, dfaure
Cc: cfeck, hpereiradacosta, kde-frameworks-devel, LeGast00n, GB_2, michaelh, 
ngraham, bruns

D25815: Transmission-Qt tray icon added

[Noah Davis]

ndavis added a comment.


  In D25815#574111 , @vinzenzv wrote:
  
  > In D25815#574103 , @ndavis wrote:
  >
  > > The actual name of the icon is `transmission`, so you would have to 
rename the file to that and add `id="transmission"` to the group. Since this is 
a desktop theme icon, you would also have to add an invisible 22x22 rectangle 
to the group.
  > >
  > > However, even after doing all that myself, I can't get this icon to work. 
I'm not sure why. It doesn't work with `transmission-qt` either.
  >
  >
  > I rebuilt the whole icon taking the SVG of Konversation. Maybe I messed up 
something with the initial one.
  >
  > F7805591: Screenshot_20191209_015303.png 

  
  
  Nope, I even completely redid it any it wouldn't work with `transmission` or 
`transmission-qt`

REVISION DETAIL
  https://phabricator.kde.org/D25815

To: vinzenzv, #vdg, ndavis
Cc: ndavis, ngraham, iasensio, kde-frameworks-devel, LeGast00n, fbampaloukas, 
GB_2, trickyricky26, michaelh, bruns

D25815: Transmission-Qt tray icon added

[Noah Davis]

ndavis added a comment.


  The actual name of the icon is `transmission`, so you would have to rename 
the file to that and add `id="transmission"` to the group. Since this is a 
desktop theme icon, you would also have to add an invisible 22x22 rectangle to 
the group.
  
  However, even after doing all that myself, I can't get this icon to work. I'm 
not sure why.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D25815

To: vinzenzv, #vdg, ndavis
Cc: ndavis, ngraham, iasensio, kde-frameworks-devel, LeGast00n, fbampaloukas, 
GB_2, trickyricky26, michaelh, bruns

D25815: Transmission-Qt tray icon added

[Noah Davis]

ndavis requested changes to this revision.
ndavis added a comment.
This revision now requires changes to proceed.


  Hey, thanks for the patch!
  
  - Breeze usually uses 1px lines, but does use 2px in some instances (mainly 
centered lines). You can use a 2px thickness at the bottom in this case to 
match the look of the original logo.
  - The shapes need to be aligned to 1px grid spaces. If using strokes, use 
miter joins (value: 4), square caps, align to the centers of pixels and then 
convert to paths. I won't be too picky about diagonal lines except for 45 
degree angles: 
https://community.kde.org/Guidelines_and_HOWTOs/Icon_Workflow_Tips#Diagonal_lines
  - The margins must to be 3px on the top and bottom, but you can fudge the 
horizontal margins as needed

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D25815

To: vinzenzv, #vdg, ndavis
Cc: ndavis, ngraham, iasensio, kde-frameworks-devel, LeGast00n, fbampaloukas, 
GB_2, trickyricky26, michaelh, bruns

D25814: [KColorScheme] Add SeparatorColor

[Noah Davis]

ndavis updated this revision to Diff 71096.
ndavis added a comment.


  - update @since version

REPOSITORY
  R265 KConfigWidgets

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25814?vs=71095=71096

BRANCH
  separator-color (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25814

AFFECTED FILES
  src/kcolorscheme.cpp
  src/kcolorscheme.h

To: ndavis, #frameworks, #vdg, dfaure
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25814: [KColorScheme] Add SeparatorColor

[Noah Davis]

ndavis edited the summary of this revision.

REPOSITORY
  R265 KConfigWidgets

REVISION DETAIL
  https://phabricator.kde.org/D25814

To: ndavis, #frameworks, #vdg, dfaure
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25814: [KColorScheme] Add SeparatorColor

[Noah Davis]

ndavis edited the summary of this revision.

REPOSITORY
  R265 KConfigWidgets

REVISION DETAIL
  https://phabricator.kde.org/D25814

To: ndavis, #frameworks, #vdg, dfaure
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25814: [KColorScheme] Add SeparatorColor

[Noah Davis]

ndavis edited the summary of this revision.

REPOSITORY
  R265 KConfigWidgets

REVISION DETAIL
  https://phabricator.kde.org/D25814

To: ndavis, #frameworks, #vdg, dfaure
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25814: [KColorScheme] Add SeparatorColor

[Noah Davis]

ndavis edited the summary of this revision.
ndavis added reviewers: Frameworks, VDG, dfaure.

REPOSITORY
  R265 KConfigWidgets

REVISION DETAIL
  https://phabricator.kde.org/D25814

To: ndavis, #frameworks, #vdg, dfaure
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25814: [KColorScheme] Add SeparatorColor

[Noah Davis]

ndavis created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
ndavis requested review of this revision.

REVISION SUMMARY
  Users sometimes ask for the ability to customize the color of separators.
  When talking about how the next version of Breeze Dark should look, some 
developers

REPOSITORY
  R265 KConfigWidgets

BRANCH
  separator-color (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25814

AFFECTED FILES
  src/kcolorscheme.cpp
  src/kcolorscheme.h

To: ndavis
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25340: Added background colors to active and inactive icon view

[Noah Davis]

ndavis edited the summary of this revision.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D25340

To: ndavis, #vdg, ngraham, niccolove
Cc: filipf, manueljlin, ngraham, ndavis, kde-frameworks-devel, LeGast00n, GB_2, 
michaelh, bruns

D25340: Added background colors to active and inactive icon view

[Noah Davis]

ndavis edited the test plan for this revision.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D25340

To: ndavis, #vdg, ngraham, niccolove
Cc: filipf, manueljlin, ngraham, ndavis, kde-frameworks-devel, LeGast00n, GB_2, 
michaelh, bruns

D25340: Added background colors to active and inactive icon view

[Noah Davis]

ndavis updated this revision to Diff 71092.
ndavis added a comment.


  - change minimized bg opacity to 8%

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25340?vs=71084=71092

BRANCH
  arcpatch-D25340 (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25340

AFFECTED FILES
  src/desktoptheme/breeze/widgets/tasks.svg

To: ndavis, #vdg, ngraham, niccolove
Cc: filipf, manueljlin, ngraham, ndavis, kde-frameworks-devel, LeGast00n, GB_2, 
michaelh, bruns

D25340: Added background colors to active and inactive icon view

[Noah Davis]

ndavis updated this revision to Diff 71084.
ndavis added a comment.


  - Change normal bg to 15% opacity
  - Change minimized bg to 5% opacity

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25340?vs=71050=71084

BRANCH
  arcpatch-D25340 (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25340

AFFECTED FILES
  src/desktoptheme/breeze/widgets/tasks.svg

To: ndavis, #vdg, ngraham, niccolove
Cc: filipf, manueljlin, ngraham, ndavis, kde-frameworks-devel, LeGast00n, GB_2, 
michaelh, bruns

D25340: Added background colors to active and inactive icon view

[Noah Davis]

ndavis edited the summary of this revision.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D25340

To: ndavis, #vdg, ngraham, niccolove
Cc: filipf, manueljlin, ngraham, ndavis, kde-frameworks-devel, LeGast00n, GB_2, 
michaelh, bruns

D25340: Added background colors to active and inactive icon view

[Noah Davis]

ndavis edited the test plan for this revision.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D25340

To: ndavis, #vdg, ngraham, niccolove
Cc: filipf, manueljlin, ngraham, ndavis, kde-frameworks-devel, LeGast00n, GB_2, 
michaelh, bruns

D25340: Added background colors to active and inactive icon view

[Noah Davis]

ndavis commandeered this revision.
ndavis edited reviewers, added: niccolove; removed: ndavis.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D25340

To: ndavis, #vdg, ngraham, niccolove
Cc: filipf, manueljlin, ngraham, ndavis, kde-frameworks-devel, LeGast00n, GB_2, 
michaelh, bruns

D25340: Added background colors to active and inactive icon view

[Noah Davis]

ndavis added a comment.


  @niccolove Do you mind if I commandeer this? I know dealing with these kinds 
of issues can be super annoying and I'm already used to it.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D25340

To: niccolove, #vdg, ngraham, ndavis
Cc: filipf, manueljlin, ngraham, ndavis, kde-frameworks-devel, LeGast00n, GB_2, 
michaelh, bruns

D25340: Added background colors to active and inactive icon view

[Noah Davis]

ndavis added a comment.


  It's still going to be a PITA with manual editing. Maybe there's a way to 
automate it with `awk`, but I don't know that tool well enough. This should at 
least make the deleting part easier: `sed --follow-symlinks -i 
's/style="opacity:0.05"//' tasks.svg`
  
  Do this too while you're at it since I noticed some useless style lines: `sed 
--follow-symlinks -i 's/style=""//' tasks.svg`

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D25340

To: niccolove, #vdg, ngraham, ndavis
Cc: filipf, manueljlin, ngraham, ndavis, kde-frameworks-devel, LeGast00n, GB_2, 
michaelh, bruns

D25340: Added background colors to active and inactive icon view

[Noah Davis]

ndavis requested changes to this revision.
This revision now requires changes to proceed.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D25340

To: niccolove, #vdg, ngraham, ndavis
Cc: filipf, manueljlin, ngraham, ndavis, kde-frameworks-devel, LeGast00n, GB_2, 
michaelh, bruns

D25340: Added background colors to active and inactive icon view

[Noah Davis]

ndavis added a comment.


  Oh wait, here's the problem

INLINE COMMENTS

> tasks.svg:3206
> + transform="matrix(-1 0 0 -1 36 134)"
> + opacity=".16"
> + style="opacity:0.05">

Starts here
Conflicting opacity values. Set `opacity="0.05"` and delete the conflicting 
`style="opacity:0.05"` part.

> tasks.svg:3904
> + transform="matrix(0 1 1 0 122 89.97)"
> + opacity=".16"
> + style="opacity:0.05">

Ends here

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  backrgound-color-iconviewer (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25340

To: niccolove, #vdg, ngraham, ndavis
Cc: filipf, manueljlin, ngraham, ndavis, kde-frameworks-devel, LeGast00n, GB_2, 
michaelh, bruns

D25340: Added background colors to active and inactive icon view

[Noah Davis]

ndavis added a comment.


  In D25340#573654 , @ngraham wrote:
  
  > Hmm, I'm not seeing any change, and the difference between open and 
maximized items is still too subtle IMO: F7804140: 
Screenshot_20191207_093912.PNG 
  >
  > If the background is a different color/opacity, I can't tell.
  
  
  When changing the SVGs for plasmashell widgets, you have to delete cache. `rm 
-r ~/.cache/plasma*`

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  backrgound-color-iconviewer (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25340

To: niccolove, #vdg, ngraham, ndavis
Cc: filipf, manueljlin, ngraham, ndavis, kde-frameworks-devel, LeGast00n, GB_2, 
michaelh, bruns

D25340: Added background colors to active and inactive icon view

[Noah Davis]

ndavis accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  backrgound-color-iconviewer (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25340

To: niccolove, #vdg, ngraham, ndavis
Cc: filipf, manueljlin, ngraham, ndavis, kde-frameworks-devel, LeGast00n, GB_2, 
michaelh, bruns

D25340: Added background colors to active and inactive icon view

[Noah Davis]

ndavis requested changes to this revision.
ndavis added a comment.
This revision now requires changes to proceed.


  Wait, is a change to tabbar.svg supposed to be in this diff?

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D25340

To: niccolove, #vdg, ngraham, ndavis
Cc: filipf, manueljlin, ngraham, ndavis, kde-frameworks-devel, LeGast00n, GB_2, 
michaelh, bruns

D25340: Added background colors to active and inactive icon view

[Noah Davis]

ndavis accepted this revision.

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  backrgound-color-iconviewer (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25340

To: niccolove, #vdg, ngraham, ndavis
Cc: filipf, manueljlin, ngraham, ndavis, kde-frameworks-devel, LeGast00n, GB_2, 
michaelh, bruns