Re: [Kicad-developers] [PATCH] Board statistics dialog

[Alexander Shuklin]

Hi Dino,

Thanks for direction. I'm not sure, that counting pixels is good way, but for 
sure I will look how Plot function is implemented.

>Среда, 31 июля 2019, 15:08 +03:00 от Dino Ghilardi :
>
>Hi Alexander,
>
> >
> > Maybe that's not too bad, as far as I remember, copper layers are
> > polygons with get area method already implemented. But for sure that
> > will take hours for debug.
> >
>
>
>A little bit of "brainstorming":
>copper layer weight:
>For the covered area extimation one possible way could be generating a 
>black-and-white bitmap of the layer (may be using cairo), and count 
>black and white pixels, then calculate a "layer cover" percentage to be 
>multipliedy by the area and the weight-per-surface-area to get the 
>copper weight of that layer
>
>To generate that bitmap the same routines that now are used to plot or 
>print or to display on screen could be used.
>P.S.: This is just an idea to investigate, i did not look into deep in 
>the code to see if it is simpler than using the other methods.
>
>If area calculation is made starting from the copper area definitions 
>and track segments may be there are some critical points to be checked 
>twice: if you have two segments of a track, that are connected in one 
>point, around that point the two segments partially overlap, so the area 
>is not the sum of the two areas. (As I said above I did not dig into 
>this part of the code, so may be the problem has been considered yet).
>
>About the "bitmap" method:
>Pros: it will work even if some elements overlap (partially or fully).
>Cons: Its precision will depend on the resolution used to create the 
>bitmap since every "half-covered" pixel will introduce an approximation 
>error.
>
>
>About the hours to debug yes, it will need some time (but to check 
>it I'll use the plot functions in kicad, open the image in gimp, create 
>a bitmap and count black and white pixels...) That would be easier if in 
>the text report we will have not only the end result (the weight of the 
>board), but also the single parts (the weight of the layer or its copper 
>coverage percent), so it can be checked layer-by-layer on a multilayer 
>board.
>
>
>
> > If we will understand what should be in eeschema statistics dialog, I
> > can do that as well. Maybe they can even use one parent class...
> > It's probably can show pads number as well... But what else?
> >
> >
>
>Eeschema Statistics:
>About the eeschema Stats items I can think about:
>-Number of nets (probably the most important since it is used for a 
>rough extimation of the routing cost)
>-number of components (as above, but less important. P.S.: power 
>symbols, and power flags will not be components, so they should be 
>excluded from this count)
>
>Other generic stats that can be of some use:
>-number of symbol pins
>-number of component pins
>-number of connection segments?
>
>And of course may be more that at the moment I'm not able to think about
>
>The number of symbols and symbol pins could be used to evaluate the 
>complexity and the cost of the schematic entry (since at the moment we 
>do not have a timer that measures the time spent working on a project 
>moving the mouse and pressing keys  -may be another future extension, 
>but will require a change in file format to save that data, so it will 
>not be in the 5.1 series if it is not yet coded into the file format-)
>
>Cheers,
>Dino.


-- 
Alexander Shuklin
___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] [PATCH] Board statistics dialog

[Alexander Shuklin]

Thanks,
I was looking in my forked repo, so I've got lost)))


>Среда, 31 июля 2019, 16:13 +03:00 от Wayne Stambaugh :
>
>Hi Alexander,
>
>The 6.0.0-rc1 milestone[1] tag is the HEAD of master or at least what
>the next release version that master will become once it's ready to release.
>
>Cheers,
>
>Wayne
>
>[1]:  https://launchpad.net/kicad/+milestone/6.0.0-rc1
>
>On 7/31/19 6:31 AM, Alexander Shuklin wrote:
>> 
>> Hi! Thanks for that.
>> Currently I cannot reproduce the bug.
>> I think it can be connected to KiCad 6.0.0-rc1 tag. I will compile and look.
>> Can somebody please explain me about 6.0 version tag? I mean, should I
>> look for bugs in that tag or just follow master?
>> Sorry if that's stupid question. I really don't understand that )))
>> 
>> Понедельник, 29 июля 2019, 21:20 +03:00 от Diego Herranz
>> < diegoherr...@diegoherranz.com >:
>> 
>> Done: https://bugs.launchpad.net/kicad/+bug/1838325
>> 
>> Thanks!
>> 
>> On Sun, 28 Jul 2019 at 15:04, Wayne Stambaugh < stambau...@gmail.com
>> > wrote:
>> 
>> Diego,
>> 
>> Please file a bug report for this and include the board file
>> that causes
>> this so it's easier for us to figure out what is going on.
>> 
>> Thanks,
>> 
>> Wayne
>> 
>> On 7/27/19 5:06 AM, Diego Herranz wrote:
>> > I've been testing this dialog and I think it is a nice
>> addition. Thanks!
>> >
>> > There seems to be something wrong with the area calculation,
>> though. See
>> > image below:
>> > area.png
>> >
>> > Thanks,
>> > Diego
>> >
>> > On Tue, 23 Jul 2019 at 11:18, Ian McInerney
>> < ian.s.mciner...@ieee.org
>> 
>> > > >> 
>> wrote:
>> >
>> >     Alexander,
>> >
>> >     Instead of declaring the 2 static variables separately, I
>> would
>> >     suggest creating a struct for the settings then store that
>> as the
>> >     static variable. For an example of this see the
>> >     dialog_create_array.cpp file. This way if any new options
>> must be
>> >     added in the future, they can just be added to the struct
>> very easily.
>> >
>> >     -Ian
>> >
>> >     On Mon, Jul 22, 2019 at 9:39 PM Alexander Shuklin
>> < jasura...@mail.ru
>> 
>> >     > >> wrote:
>> >
>> >         Damn ><,
>> >         don't use last patch, please.
>> >         It doesn't count total vias amount. Use this one.
>> >
>> >
>> >             Понедельник, 22 июля 2019, 22:14 +03:00 от
>> Alexander Shuklin
>> >             > 
>> > >>:
>> >
>> >             Hi,
>> >             thanks for sharing experience, as I never used that
>> >             translations or wxWidgets before. And I have no
>> idea where
>> >             else could I get that information. ))
>> >             So, there's the patch with vias information and
>> some tiny
>> >             improvements.
>> >
>> >
>> >                 Понедельник, 22 июля 2019, 13:34 +03:00 от Ian
>> McInerney
>> >                 > 
>> >                 > >>:
>> >
>> >
>> >
>> >                 On Mon, Jul 22, 2019 at 11:03 AM Dino Ghilardi
>> >                 > 
>> >               
>>  < http://e.mail.ru/compose/?mailto=mailto%3adino.ghila...@ieee.org 
>> >>
>> >                 wrote:
>> >
>> >                     Hi Alexander,
>> >
>> >                     One possible solution for the translation
>> could be
>> >                     put the ":" in a
>> >                     different column of the table and
>> right-align the
>> >                     field description text
>> >                     (so all the colons will be aligned). A
>> rapid google
>> >                     search shown that in
>> >                     French and Vietnamese there should be a
>> space before
>> >                     the colon, while in
>> >                     the rest of the world there is not, so
>> having the
>> >                     translation for the
>> >                     ":" word seems to make sense. Also another
>> question
>> >                     arises: Is there
>> >                     some language in which the colon should be
>> another
>> >                     character before the

Re: [Kicad-developers] [PATCH] Board statistics dialog

[Wayne Stambaugh]

Hi Alexander,

The 6.0.0-rc1 milestone[1] tag is the HEAD of master or at least what
the next release version that master will become once it's ready to release.

Cheers,

Wayne

[1]: https://launchpad.net/kicad/+milestone/6.0.0-rc1

On 7/31/19 6:31 AM, Alexander Shuklin wrote:
> 
> Hi! Thanks for that.
> Currently I cannot reproduce the bug.
> I think it can be connected to KiCad 6.0.0-rc1 tag. I will compile and look.
> Can somebody please explain me about 6.0 version tag? I mean, should I
> look for bugs in that tag or just follow master?
> Sorry if that's stupid question. I really don't understand that )))
> 
> Понедельник, 29 июля 2019, 21:20 +03:00 от Diego Herranz
> :
> 
> Done: https://bugs.launchpad.net/kicad/+bug/1838325
> 
> Thanks!
> 
> On Sun, 28 Jul 2019 at 15:04, Wayne Stambaugh  > wrote:
> 
> Diego,
> 
> Please file a bug report for this and include the board file
> that causes
> this so it's easier for us to figure out what is going on.
> 
> Thanks,
> 
> Wayne
> 
> On 7/27/19 5:06 AM, Diego Herranz wrote:
> > I've been testing this dialog and I think it is a nice
> addition. Thanks!
> >
> > There seems to be something wrong with the area calculation,
> though. See
> > image below:
> > area.png
> >
> > Thanks,
> > Diego
> >
> > On Tue, 23 Jul 2019 at 11:18, Ian McInerney
>  
> >  >> 
> wrote:
> >
> >     Alexander,
> >
> >     Instead of declaring the 2 static variables separately, I
> would
> >     suggest creating a struct for the settings then store that
> as the
> >     static variable. For an example of this see the
> >     dialog_create_array.cpp file. This way if any new options
> must be
> >     added in the future, they can just be added to the struct
> very easily.
> >
> >     -Ian
> >
> >     On Mon, Jul 22, 2019 at 9:39 PM Alexander Shuklin
>  
> >      >> wrote:
> >
> >         Damn ><,
> >         don't use last patch, please.
> >         It doesn't count total vias amount. Use this one.
> >
> >
> >             Понедельник, 22 июля 2019, 22:14 +03:00 от
> Alexander Shuklin
> >              
>  >>:
> >
> >             Hi,
> >             thanks for sharing experience, as I never used that
> >             translations or wxWidgets before. And I have no
> idea where
> >             else could I get that information. ))
> >             So, there's the patch with vias information and
> some tiny
> >             improvements.
> >
> >
> >                 Понедельник, 22 июля 2019, 13:34 +03:00 от Ian
> McInerney
> >                  
> >                  >>:
> >
> >
> >
> >                 On Mon, Jul 22, 2019 at 11:03 AM Dino Ghilardi
> >                  
> >               
>  >
> >                 wrote:
> >
> >                     Hi Alexander,
> >
> >                     One possible solution for the translation
> could be
> >                     put the ":" in a
> >                     different column of the table and
> right-align the
> >                     field description text
> >                     (so all the colons will be aligned). A
> rapid google
> >                     search shown that in
> >                     French and Vietnamese there should be a
> space before
> >                     the colon, while in
> >                     the rest of the world there is not, so
> having the
> >                     translation for the
> >                     ":" word seems to make sense. Also another
> question
> >                     arises: Is there
> >                     some language in which the colon should be
> another
> >                     character before the
> >                     word? (I'm thinking about spanish where
> the question
> >                     mark upside-down
> >                     appears before a question...)? ...conclusion:
> >                     keeping "Height:" and
> >                     "Height" as two different words seem to be the
> >         

Re: [Kicad-developers] [PATCH] Board statistics dialog

[Dino Ghilardi]

Hi Alexander,

>
> Maybe that's not too bad, as far as I remember, copper layers are
> polygons with get area method already implemented. But for sure that
> will take hours for debug.
>


A little bit of "brainstorming":
copper layer weight:
	For the covered area extimation one possible way could be generating a 
black-and-white bitmap of the layer (may be using cairo), and count 
black and white pixels, then calculate a "layer cover" percentage to be 
multipliedy by the area and the weight-per-surface-area to get the 
copper weight of that layer


To generate that bitmap the same routines that now are used to plot or 
print or to display on screen could be used.
P.S.: This is just an idea to investigate, i did not look into deep in 
the code to see if it is simpler than using the other methods.


If area calculation is made starting from the copper area definitions 
and track segments may be there are some critical points to be checked 
twice: if you have two segments of a track, that are connected in one 
point, around that point the two segments partially overlap, so the area 
is not the sum of the two areas. (As I said above I did not dig into 
this part of the code, so may be the problem has been considered yet).


About the "bitmap" method:
Pros: it will work even if some elements overlap (partially or fully).
Cons: Its precision will depend on the resolution used to create the 
bitmap since every "half-covered" pixel will introduce an approximation 
error.



About the hours to debug yes, it will need some time (but to check 
it I'll use the plot functions in kicad, open the image in gimp, create 
a bitmap and count black and white pixels...) That would be easier if in 
the text report we will have not only the end result (the weight of the 
board), but also the single parts (the weight of the layer or its copper 
coverage percent), so it can be checked layer-by-layer on a multilayer 
board.




> If we will understand what should be in eeschema statistics dialog, I
> can do that as well. Maybe they can even use one parent class...
> It's probably can show pads number as well... But what else?
>
>

Eeschema Statistics:
About the eeschema Stats items I can think about:
-Number of nets (probably the most important since it is used for a 
rough extimation of the routing cost)
-number of components (as above, but less important. P.S.: power 
symbols, and power flags will not be components, so they should be 
excluded from this count)


Other generic stats that can be of some use:
-number of symbol pins
-number of component pins
-number of connection segments?

And of course may be more that at the moment I'm not able to think about

The number of symbols and symbol pins could be used to evaluate the 
complexity and the cost of the schematic entry (since at the moment we 
do not have a timer that measures the time spent working on a project 
moving the mouse and pressing keys  -may be another future extension, 
but will require a change in file format to save that data, so it will 
not be in the 5.1 series if it is not yet coded into the file format-)


Cheers,
Dino.

___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] [PATCH] Board statistics dialog

[Ian McInerney]

To work with the current 6.0 development code, just use the master branch
at its HEAD.

-Ian

On Wed, Jul 31, 2019 at 12:32 PM Alexander Shuklin 
wrote:

>
> Hi! Thanks for that.
> Currently I cannot reproduce the bug.
> I think it can be connected to KiCad 6.0.0-rc1 tag. I will compile and
> look.
> Can somebody please explain me about 6.0 version tag? I mean, should I
> look for bugs in that tag or just follow master?
> Sorry if that's stupid question. I really don't understand that )))
>
> Понедельник, 29 июля 2019, 21:20 +03:00 от Diego Herranz <
> diegoherr...@diegoherranz.com>:
>
> Done: https://bugs.launchpad.net/kicad/+bug/1838325
>
> Thanks!
>
> On Sun, 28 Jul 2019 at 15:04, Wayne Stambaugh  > wrote:
>
> Diego,
>
> Please file a bug report for this and include the board file that causes
> this so it's easier for us to figure out what is going on.
>
> Thanks,
>
> Wayne
>
> On 7/27/19 5:06 AM, Diego Herranz wrote:
> > I've been testing this dialog and I think it is a nice addition. Thanks!
> >
> > There seems to be something wrong with the area calculation, though. See
> > image below:
> > area.png
> >
> > Thanks,
> > Diego
> >
> > On Tue, 23 Jul 2019 at 11:18, Ian McInerney  
> >  >> wrote:
> >
> > Alexander,
> >
> > Instead of declaring the 2 static variables separately, I would
> > suggest creating a struct for the settings then store that as the
> > static variable. For an example of this see the
> > dialog_create_array.cpp file. This way if any new options must be
> > added in the future, they can just be added to the struct very
> easily.
> >
> > -Ian
> >
> > On Mon, Jul 22, 2019 at 9:39 PM Alexander Shuklin  
> >  >> wrote:
> >
> > Damn ><,
> > don't use last patch, please.
> > It doesn't count total vias amount. Use this one.
> >
> >
> > Понедельник, 22 июля 2019, 22:14 +03:00 от Alexander Shuklin
> >jasura...@mail.ru 
> >>:
> >
> > Hi,
> > thanks for sharing experience, as I never used that
> > translations or wxWidgets before. And I have no idea where
> > else could I get that information. ))
> > So, there's the patch with vias information and some tiny
> > improvements.
> >
> >
> > Понедельник, 22 июля 2019, 13:34 +03:00 от Ian McInerney
> >  
> >  >>:
> >
> >
> >
> > On Mon, Jul 22, 2019 at 11:03 AM Dino Ghilardi
> >  
> > <
> http://e.mail.ru/compose/?mailto=mailto%3adino.ghila...@ieee.org>>
> > wrote:
> >
> > Hi Alexander,
> >
> > One possible solution for the translation could be
> > put the ":" in a
> > different column of the table and right-align the
> > field description text
> > (so all the colons will be aligned). A rapid google
> > search shown that in
> > French and Vietnamese there should be a space before
> > the colon, while in
> > the rest of the world there is not, so having the
> > translation for the
> > ":" word seems to make sense. Also another question
> > arises: Is there
> > some language in which the colon should be another
> > character before the
> > word? (I'm thinking about spanish where the question
> > mark upside-down
> > appears before a question...)? ...conclusion:
> > keeping "Height:" and
> > "Height" as two different words seem to be the
> > solution that gives
> > maximum flexibility to translators.
> >
> >
> > This actually doesn't give them as much flexibility.
> > When translations are done, they need to examine the
> > entire string that needs translating, so the ":"
> > character should be included in the string. Separating
> > out the two portions is the equivalent of saying that
> > every lanugage will follow the same compositional rules.
> >
> >
> > Another possible solution (probably better then the
> > one above since it
> > just removes the problem) is to remove the ":" and
> > have the cell borders
> > in a different color, just like the tables in the
> > "board setup" dialog
> > (so that you can also take a look at that code to
> > solve also the color
> > problem seeing how 

Re: [Kicad-developers] [PATCH] Board statistics dialog

[Alexander Shuklin]

 About the weight estimation of the pcb, considering that in the (probably 
 near) future a board stackup definition with copper thickness and 
 dielectric properties will be a part of pcbnew, the weight calculation as 
 another data of the statistics window will become possible, once the 
 density of the materials is one of the columns that define the stackup.
 
>>Sounds nice. Not sure whether it may be too complex, though.

Maybe that's not too bad, as far as I remember, copper layers are polygons with 
get area method already implemented. But for sure that will take hours for 
debug.

>> By the way, a statistics report like the one of pcbnew,  with number of nets 
>> and number of components would be useful also in eeschema. Its typical usage 
>> would be to estimate he complexity (and cost) of pcb routing. I'm asking 
>> myself if Alexander's code can be extended to be used also in eeschema, so 
>> that we can have an almost identical "statistics" window there with minimal 
>> effort and consistent interface.

If we will understand what should be in eeschema statistics dialog, I can do 
that as well. Maybe they can even use one parent class...
It's probably can show pads number as well... But what else? 

>
>On Mon, 29 Jul 2019, 21:19 Dino Ghilardi, < dino.ghila...@ieee.org > wrote:
>>Hi,
>>
>>About the weight estimation of the pcb, considering that in the (probably 
>>near) future a board stackup definition with copper thickness and dielectric 
>>properties will be a part of pcbnew, the weight calculation as another data 
>>of the statistics window will become possible, once the density of the 
>>materials is one of the columns that define the stackup.
>>
>>By the way, a statistics report like the one of pcbnew,  with number of nets 
>>and number of components would be useful also in eeschema. Its typical usage 
>>would be to estimate he complexity (and cost) of pcb routing. I'm asking 
>>myself if Alexander's code can be extended to be used also in eeschema, so 
>>that we can have an almost identical "statistics" window there with minimal 
>>effort and consistent interface.
>>
>>Cheers,
>>Dino.
>>
>>Il Lun 29 Lug 2019 20:24 Diego Herranz < diegoherr...@diegoherranz.com > ha 
>>scritto:
>>>I agree both are useful.
>>>(Max width x Max height) area is useful as a worst case scenario for 
>>>manufacturing: it may end up being better depending on the shape of the 
>>>board and panel design.
>>>Regarding actual area, I'm working on a project right now where I need to 
>>>provide an estimation of the weight of the board. Knowing the actual area of 
>>>FR4 is useful.
>>>
>>>Thanks!
>>>
>>>
>>>
>>>On Mon, 29 Jul 2019 at 14:33, Wayne Stambaugh < stambau...@gmail.com > wrote:
I agree.  There is utility in both the actual area of a board and the
manufacturing area.  The latter should be fairly trivial to implement.

Cheers,

Wayne

On 7/29/19 9:30 AM, Clemens Koller wrote:
> Hi!
> I think it could be good to see both:
> - The actual PCB area of the outline (well, without drills).
> - The max-width * max-height which is usually what you have to pay for 
> when you get it manufactured.
> The second one could be also an interesting task to calculate if you have 
> an odd shaped polygonal outline.
> 
> Regards,
> Clemens
> 
> 
> On 29/07/2019 14.43, Alexander Shuklin wrote:
>>   Hi! I've been asked to do actually PCB area calculation. Since English 
>> is not my first language, maybe I just miss-understood. Do you mean, 
>> that area has to be just max width * max height? I never seen that, but 
>> there's a message in thread about sometimes you need proper area.
>> I utilized kicad outline functions for that.
>>
>>
>>     Понедельник, 29 июля 2019, 15:35 +03:00 от Mark Roszko < 
>>mark.ros...@gmail.com >:
>>
>>     Huh, looking at the statistics code, it actually tries and find the 
>>more "detailed area" of a board based on any polygonal outline.
>>     Is there any value in it this way? PCB manufacturing charges are 
>>generally per-square area  because ultimately the price is on panel space 
>>you are using. 
>>
>>     On Sat, Jul 27, 2019 at 5:07 AM Diego Herranz < 
>>diegoherr...@diegoherranz.com >e.mail.ru/compose/?mailto=mailto%3adiegoherr...@diegoherranz.com >> wrote:
>>
>>         I've been testing this dialog and I think it is a nice addition. 
>>Thanks!
>>
>>         There seems to be something wrong with the area calculation, 
>>though. See image below:
>>         area.png
>>
>>         Thanks,
>>         Diego
>>
>>         On Tue, 23 Jul 2019 at 11:18, Ian McInerney < 
>>ian.s.mciner...@ieee.org >e.mail.ru/compose/?mailto=mailto%3aian.s.mciner...@ieee.org >> wrote:
>>
>>             Alexander,
>>
>>             Instead of declaring the 2 static 

Re: [Kicad-developers] [PATCH] Board statistics dialog

[Alexander Shuklin]

Hi! Thanks for that.
Currently I cannot reproduce the bug.
I think it can be connected to KiCad 6.0.0-rc1 tag. I will compile and look.
Can somebody please explain me about 6.0 version tag? I mean, should I look for 
bugs in that tag or just follow master?
Sorry if that's stupid question. I really don't understand that )))

>Понедельник, 29 июля 2019, 21:20 +03:00 от Diego Herranz 
>:
>
>Done:  https://bugs.launchpad.net/kicad/+bug/1838325
>
>Thanks!
>On Sun, 28 Jul 2019 at 15:04, Wayne Stambaugh < stambau...@gmail.com > wrote:
>>Diego,
>>
>>Please file a bug report for this and include the board file that causes
>>this so it's easier for us to figure out what is going on.
>>
>>Thanks,
>>
>>Wayne
>>
>>On 7/27/19 5:06 AM, Diego Herranz wrote:
>>> I've been testing this dialog and I think it is a nice addition. Thanks!
>>> 
>>> There seems to be something wrong with the area calculation, though. See
>>> image below:
>>> area.png
>>> 
>>> Thanks,
>>> Diego
>>> 
>>> On Tue, 23 Jul 2019 at 11:18, Ian McInerney < ian.s.mciner...@ieee.org
>>> > wrote:
>>> 
>>>     Alexander,
>>> 
>>>     Instead of declaring the 2 static variables separately, I would
>>>     suggest creating a struct for the settings then store that as the
>>>     static variable. For an example of this see the
>>>     dialog_create_array.cpp file. This way if any new options must be
>>>     added in the future, they can just be added to the struct very easily.
>>> 
>>>     -Ian
>>> 
>>>     On Mon, Jul 22, 2019 at 9:39 PM Alexander Shuklin < jasura...@mail.ru
>>>     > wrote:
>>> 
>>>         Damn ><,
>>>         don't use last patch, please.
>>>         It doesn't count total vias amount. Use this one.
>>> 
>>> 
>>>             Понедельник, 22 июля 2019, 22:14 +03:00 от Alexander Shuklin
>>>             < jasura...@mail.ru >:
>>> 
>>>             Hi,
>>>             thanks for sharing experience, as I never used that
>>>             translations or wxWidgets before. And I have no idea where
>>>             else could I get that information. ))
>>>             So, there's the patch with vias information and some tiny
>>>             improvements.
>>> 
>>> 
>>>                 Понедельник, 22 июля 2019, 13:34 +03:00 от Ian McInerney
>>>                 < ian.s.mciner...@ieee.org
>>>                 >:
>>> 
>>> 
>>> 
>>>                 On Mon, Jul 22, 2019 at 11:03 AM Dino Ghilardi
>>>                 < dino.ghila...@ieee.org
>>>                 < 
>>>http://e.mail.ru/compose/?mailto=mailto%3adino.ghila...@ieee.org >>
>>>                 wrote:
>>> 
>>>                     Hi Alexander,
>>> 
>>>                     One possible solution for the translation could be
>>>                     put the ":" in a
>>>                     different column of the table and right-align the
>>>                     field description text
>>>                     (so all the colons will be aligned). A rapid google
>>>                     search shown that in
>>>                     French and Vietnamese there should be a space before
>>>                     the colon, while in
>>>                     the rest of the world there is not, so having the
>>>                     translation for the
>>>                     ":" word seems to make sense. Also another question
>>>                     arises: Is there
>>>                     some language in which the colon should be another
>>>                     character before the
>>>                     word? (I'm thinking about spanish where the question
>>>                     mark upside-down
>>>                     appears before a question...)? ...conclusion:
>>>                     keeping "Height:" and
>>>                     "Height" as two different words seem to be the
>>>                     solution that gives
>>>                     maximum flexibility to translators.
>>> 
>>> 
>>>                 This actually doesn't give them as much flexibility.
>>>                 When translations are done, they need to examine the
>>>                 entire string that needs translating, so the ":"
>>>                 character should be included in the string. Separating
>>>                 out the two portions is the equivalent of saying that
>>>                 every lanugage will follow the same compositional rules.
>>>                  
>>> 
>>>                     Another possible solution (probably better then the
>>>                     one above since it
>>>                     just removes the problem) is to remove the ":" and
>>>                     have the cell borders
>>>                     in a different color, just like the tables in the
>>>                     "board setup" dialog
>>>                     (so that you can also take a look at that code to
>>>                     solve also the color
>>>                     problem seeing how it was solved there). The
>>>                     advantage of this approach
>>>                     is also having a more consistent "look" through all
>>>  

Re: [Kicad-developers] [PATCH] Board statistics dialog

[Diego Herranz]

>> About the weight estimation of the pcb, considering that in the
(probably near) future a board stackup definition with copper thickness and
dielectric properties will be a part of pcbnew, the weight calculation as
another data of the statistics window will become possible, once the
density of the materials is one of the columns that define the stackup.

Sounds nice. Not sure whether it may be too complex, though.

>> By the way, a statistics report like the one of pcbnew,  with number of
nets and number of components would be useful also in eeschema. Its typical
usage would be to estimate he complexity (and cost) of pcb routing. I'm
asking myself if Alexander's code can be extended to be used also in
eeschema, so that we can have an almost identical "statistics" window there
with minimal effort and consistent interface.

+1

Thanks,
Diego



On Mon, 29 Jul 2019, 21:19 Dino Ghilardi,  wrote:

> Hi,
>
> About the weight estimation of the pcb, considering that in the (probably
> near) future a board stackup definition with copper thickness and
> dielectric properties will be a part of pcbnew, the weight calculation as
> another data of the statistics window will become possible, once the
> density of the materials is one of the columns that define the stackup.
>
> By the way, a statistics report like the one of pcbnew,  with number of
> nets and number of components would be useful also in eeschema. Its typical
> usage would be to estimate he complexity (and cost) of pcb routing. I'm
> asking myself if Alexander's code can be extended to be used also in
> eeschema, so that we can have an almost identical "statistics" window there
> with minimal effort and consistent interface.
>
> Cheers,
> Dino.
>
> Il Lun 29 Lug 2019 20:24 Diego Herranz  ha
> scritto:
>
>> I agree both are useful.
>> (Max width x Max height) area is useful as a worst case scenario for
>> manufacturing: it may end up being better depending on the shape of the
>> board and panel design.
>> Regarding actual area, I'm working on a project right now where I need to
>> provide an estimation of the weight of the board. Knowing the actual area
>> of FR4 is useful.
>>
>> Thanks!
>>
>>
>>
>>
>> On Mon, 29 Jul 2019 at 14:33, Wayne Stambaugh 
>> wrote:
>>
>>> I agree.  There is utility in both the actual area of a board and the
>>> manufacturing area.  The latter should be fairly trivial to implement.
>>>
>>> Cheers,
>>>
>>> Wayne
>>>
>>> On 7/29/19 9:30 AM, Clemens Koller wrote:
>>> > Hi!
>>> > I think it could be good to see both:
>>> > - The actual PCB area of the outline (well, without drills).
>>> > - The max-width * max-height which is usually what you have to pay for
>>> when you get it manufactured.
>>> > The second one could be also an interesting task to calculate if you
>>> have an odd shaped polygonal outline.
>>> >
>>> > Regards,
>>> > Clemens
>>> >
>>> >
>>> > On 29/07/2019 14.43, Alexander Shuklin wrote:
>>> >>   Hi! I've been asked to do actually PCB area calculation. Since
>>> English is not my first language, maybe I just miss-understood. Do you
>>> mean, that area has to be just max width * max height? I never seen that,
>>> but there's a message in thread about sometimes you need proper area.
>>> >> I utilized kicad outline functions for that.
>>> >>
>>> >>
>>> >> Понедельник, 29 июля 2019, 15:35 +03:00 от Mark Roszko <
>>> mark.ros...@gmail.com>:
>>> >>
>>> >> Huh, looking at the statistics code, it actually tries and find
>>> the more "detailed area" of a board based on any polygonal outline.
>>> >> Is there any value in it this way? PCB manufacturing charges are
>>> generally per-square area  because ultimately the price is on panel space
>>> you are using.
>>> >>
>>> >> On Sat, Jul 27, 2019 at 5:07 AM Diego Herranz <
>>> diegoherr...@diegoherranz.com >> e.mail.ru/compose/?mailto=mailto%3adiegoherr...@diegoherranz.com>>
>>> wrote:
>>> >>
>>> >> I've been testing this dialog and I think it is a nice
>>> addition. Thanks!
>>> >>
>>> >> There seems to be something wrong with the area calculation,
>>> though. See image below:
>>> >> area.png
>>> >>
>>> >> Thanks,
>>> >> Diego
>>> >>
>>> >> On Tue, 23 Jul 2019 at 11:18, Ian McInerney <
>>> ian.s.mciner...@ieee.org >> e.mail.ru/compose/?mailto=mailto%3aian.s.mciner...@ieee.org>> wrote:
>>> >>
>>> >> Alexander,
>>> >>
>>> >> Instead of declaring the 2 static variables separately, I
>>> would suggest creating a struct for the settings then store that as the
>>> static variable. For an example of this see the dialog_create_array.cpp
>>> file. This way if any new options must be added in the future, they can
>>> just be added to the struct very easily.
>>> >>
>>> >> -Ian
>>> >>
>>> >> On Mon, Jul 22, 2019 at 9:39 PM Alexander Shuklin <
>>> jasura...@mail.ru >> e.mail.ru/compose/?mailto=mailto%3ajasura...@mail.ru>> wrote:
>>> >>
>>> >> Damn ><,
>>> >>   

Re: [Kicad-developers] [PATCH] Board statistics dialog

[Dino Ghilardi]

Hi,

About the weight estimation of the pcb, considering that in the (probably
near) future a board stackup definition with copper thickness and
dielectric properties will be a part of pcbnew, the weight calculation as
another data of the statistics window will become possible, once the
density of the materials is one of the columns that define the stackup.

By the way, a statistics report like the one of pcbnew,  with number of
nets and number of components would be useful also in eeschema. Its typical
usage would be to estimate he complexity (and cost) of pcb routing. I'm
asking myself if Alexander's code can be extended to be used also in
eeschema, so that we can have an almost identical "statistics" window there
with minimal effort and consistent interface.

Cheers,
Dino.

Il Lun 29 Lug 2019 20:24 Diego Herranz  ha
scritto:

> I agree both are useful.
> (Max width x Max height) area is useful as a worst case scenario for
> manufacturing: it may end up being better depending on the shape of the
> board and panel design.
> Regarding actual area, I'm working on a project right now where I need to
> provide an estimation of the weight of the board. Knowing the actual area
> of FR4 is useful.
>
> Thanks!
>
>
>
>
> On Mon, 29 Jul 2019 at 14:33, Wayne Stambaugh 
> wrote:
>
>> I agree.  There is utility in both the actual area of a board and the
>> manufacturing area.  The latter should be fairly trivial to implement.
>>
>> Cheers,
>>
>> Wayne
>>
>> On 7/29/19 9:30 AM, Clemens Koller wrote:
>> > Hi!
>> > I think it could be good to see both:
>> > - The actual PCB area of the outline (well, without drills).
>> > - The max-width * max-height which is usually what you have to pay for
>> when you get it manufactured.
>> > The second one could be also an interesting task to calculate if you
>> have an odd shaped polygonal outline.
>> >
>> > Regards,
>> > Clemens
>> >
>> >
>> > On 29/07/2019 14.43, Alexander Shuklin wrote:
>> >>   Hi! I've been asked to do actually PCB area calculation. Since
>> English is not my first language, maybe I just miss-understood. Do you
>> mean, that area has to be just max width * max height? I never seen that,
>> but there's a message in thread about sometimes you need proper area.
>> >> I utilized kicad outline functions for that.
>> >>
>> >>
>> >> Понедельник, 29 июля 2019, 15:35 +03:00 от Mark Roszko <
>> mark.ros...@gmail.com>:
>> >>
>> >> Huh, looking at the statistics code, it actually tries and find
>> the more "detailed area" of a board based on any polygonal outline.
>> >> Is there any value in it this way? PCB manufacturing charges are
>> generally per-square area  because ultimately the price is on panel space
>> you are using.
>> >>
>> >> On Sat, Jul 27, 2019 at 5:07 AM Diego Herranz <
>> diegoherr...@diegoherranz.com > e.mail.ru/compose/?mailto=mailto%3adiegoherr...@diegoherranz.com>> wrote:
>> >>
>> >> I've been testing this dialog and I think it is a nice
>> addition. Thanks!
>> >>
>> >> There seems to be something wrong with the area calculation,
>> though. See image below:
>> >> area.png
>> >>
>> >> Thanks,
>> >> Diego
>> >>
>> >> On Tue, 23 Jul 2019 at 11:18, Ian McInerney <
>> ian.s.mciner...@ieee.org > e.mail.ru/compose/?mailto=mailto%3aian.s.mciner...@ieee.org>> wrote:
>> >>
>> >> Alexander,
>> >>
>> >> Instead of declaring the 2 static variables separately, I
>> would suggest creating a struct for the settings then store that as the
>> static variable. For an example of this see the dialog_create_array.cpp
>> file. This way if any new options must be added in the future, they can
>> just be added to the struct very easily.
>> >>
>> >> -Ian
>> >>
>> >> On Mon, Jul 22, 2019 at 9:39 PM Alexander Shuklin <
>> jasura...@mail.ru >
>> wrote:
>> >>
>> >> Damn ><,
>> >> don't use last patch, please.
>> >> It doesn't count total vias amount. Use this one.
>> >>
>> >>
>> >> Понедельник, 22 июля 2019, 22:14 +03:00 от
>> Alexander Shuklin > e.mail.ru/compose/?mailto=mailto%3ajasura...@mail.ru>>:
>> >>
>> >> Hi,
>> >> thanks for sharing experience, as I never used
>> that translations or wxWidgets before. And I have no idea where else could
>> I get that information. ))
>> >> So, there's the patch with vias information and
>> some tiny improvements.
>> >>
>> >>
>> >> Понедельник, 22 июля 2019, 13:34 +03:00 от Ian
>> McInerney > e.mail.ru/compose/?mailto=mailto%3aian.s.mciner...@ieee.org>>:
>> >>
>> >>
>> >>
>> >> On Mon, Jul 22, 2019 at 11:03 AM Dino Ghilardi
>> > http://e.mail.ru/compose/?mailto=mailto%3adino.ghila...@ieee.org>> wrote:
>> >>
>> >> Hi Alexander,
>> >>
>> >> One possible solution for the translation
>> could be put the ":" 

Re: [Kicad-developers] [PATCH] Board statistics dialog

[Diego Herranz]

I agree both are useful.
(Max width x Max height) area is useful as a worst case scenario for
manufacturing: it may end up being better depending on the shape of the
board and panel design.
Regarding actual area, I'm working on a project right now where I need to
provide an estimation of the weight of the board. Knowing the actual area
of FR4 is useful.

Thanks!




On Mon, 29 Jul 2019 at 14:33, Wayne Stambaugh  wrote:

> I agree.  There is utility in both the actual area of a board and the
> manufacturing area.  The latter should be fairly trivial to implement.
>
> Cheers,
>
> Wayne
>
> On 7/29/19 9:30 AM, Clemens Koller wrote:
> > Hi!
> > I think it could be good to see both:
> > - The actual PCB area of the outline (well, without drills).
> > - The max-width * max-height which is usually what you have to pay for
> when you get it manufactured.
> > The second one could be also an interesting task to calculate if you
> have an odd shaped polygonal outline.
> >
> > Regards,
> > Clemens
> >
> >
> > On 29/07/2019 14.43, Alexander Shuklin wrote:
> >>   Hi! I've been asked to do actually PCB area calculation. Since
> English is not my first language, maybe I just miss-understood. Do you
> mean, that area has to be just max width * max height? I never seen that,
> but there's a message in thread about sometimes you need proper area.
> >> I utilized kicad outline functions for that.
> >>
> >>
> >> Понедельник, 29 июля 2019, 15:35 +03:00 от Mark Roszko <
> mark.ros...@gmail.com>:
> >>
> >> Huh, looking at the statistics code, it actually tries and find the
> more "detailed area" of a board based on any polygonal outline.
> >> Is there any value in it this way? PCB manufacturing charges are
> generally per-square area  because ultimately the price is on panel space
> you are using.
> >>
> >> On Sat, Jul 27, 2019 at 5:07 AM Diego Herranz <
> diegoherr...@diegoherranz.com  e.mail.ru/compose/?mailto=mailto%3adiegoherr...@diegoherranz.com>> wrote:
> >>
> >> I've been testing this dialog and I think it is a nice
> addition. Thanks!
> >>
> >> There seems to be something wrong with the area calculation,
> though. See image below:
> >> area.png
> >>
> >> Thanks,
> >> Diego
> >>
> >> On Tue, 23 Jul 2019 at 11:18, Ian McInerney <
> ian.s.mciner...@ieee.org  e.mail.ru/compose/?mailto=mailto%3aian.s.mciner...@ieee.org>> wrote:
> >>
> >> Alexander,
> >>
> >> Instead of declaring the 2 static variables separately, I
> would suggest creating a struct for the settings then store that as the
> static variable. For an example of this see the dialog_create_array.cpp
> file. This way if any new options must be added in the future, they can
> just be added to the struct very easily.
> >>
> >> -Ian
> >>
> >> On Mon, Jul 22, 2019 at 9:39 PM Alexander Shuklin <
> jasura...@mail.ru >
> wrote:
> >>
> >> Damn ><,
> >> don't use last patch, please.
> >> It doesn't count total vias amount. Use this one.
> >>
> >>
> >> Понедельник, 22 июля 2019, 22:14 +03:00 от
> Alexander Shuklin  e.mail.ru/compose/?mailto=mailto%3ajasura...@mail.ru>>:
> >>
> >> Hi,
> >> thanks for sharing experience, as I never used that
> translations or wxWidgets before. And I have no idea where else could I get
> that information. ))
> >> So, there's the patch with vias information and
> some tiny improvements.
> >>
> >>
> >> Понедельник, 22 июля 2019, 13:34 +03:00 от Ian
> McInerney  e.mail.ru/compose/?mailto=mailto%3aian.s.mciner...@ieee.org>>:
> >>
> >>
> >>
> >> On Mon, Jul 22, 2019 at 11:03 AM Dino Ghilardi <
> dino.ghila...@ieee.org <
> http://e.mail.ru/compose/?mailto=mailto%3adino.ghila...@ieee.org>> wrote:
> >>
> >> Hi Alexander,
> >>
> >> One possible solution for the translation
> could be put the ":" in a
> >> different column of the table and
> right-align the field description text
> >> (so all the colons will be aligned). A
> rapid google search shown that in
> >> French and Vietnamese there should be a
> space before the colon, while in
> >> the rest of the world there is not, so
> having the translation for the
> >> ":" word seems to make sense. Also another
> question arises: Is there
> >> some language in which the colon should be
> another character before the
> >> word? (I'm thinking about spanish where the
> question mark upside-down
> >> appears before a question...)?
> ...conclusion: keeping "Height:" and
> >> "Height" as two different words seem to be
> the 

Re: [Kicad-developers] [PATCH] Board statistics dialog

[Diego Herranz]

Done: https://bugs.launchpad.net/kicad/+bug/1838325

Thanks!

On Sun, 28 Jul 2019 at 15:04, Wayne Stambaugh  wrote:

> Diego,
>
> Please file a bug report for this and include the board file that causes
> this so it's easier for us to figure out what is going on.
>
> Thanks,
>
> Wayne
>
> On 7/27/19 5:06 AM, Diego Herranz wrote:
> > I've been testing this dialog and I think it is a nice addition. Thanks!
> >
> > There seems to be something wrong with the area calculation, though. See
> > image below:
> > area.png
> >
> > Thanks,
> > Diego
> >
> > On Tue, 23 Jul 2019 at 11:18, Ian McInerney  > > wrote:
> >
> > Alexander,
> >
> > Instead of declaring the 2 static variables separately, I would
> > suggest creating a struct for the settings then store that as the
> > static variable. For an example of this see the
> > dialog_create_array.cpp file. This way if any new options must be
> > added in the future, they can just be added to the struct very
> easily.
> >
> > -Ian
> >
> > On Mon, Jul 22, 2019 at 9:39 PM Alexander Shuklin  > > wrote:
> >
> > Damn ><,
> > don't use last patch, please.
> > It doesn't count total vias amount. Use this one.
> >
> >
> > Понедельник, 22 июля 2019, 22:14 +03:00 от Alexander Shuklin
> > mailto:jasura...@mail.ru>>:
> >
> > Hi,
> > thanks for sharing experience, as I never used that
> > translations or wxWidgets before. And I have no idea where
> > else could I get that information. ))
> > So, there's the patch with vias information and some tiny
> > improvements.
> >
> >
> > Понедельник, 22 июля 2019, 13:34 +03:00 от Ian McInerney
> >  > >:
> >
> >
> >
> > On Mon, Jul 22, 2019 at 11:03 AM Dino Ghilardi
> >  > <
> http://e.mail.ru/compose/?mailto=mailto%3adino.ghila...@ieee.org>>
> > wrote:
> >
> > Hi Alexander,
> >
> > One possible solution for the translation could be
> > put the ":" in a
> > different column of the table and right-align the
> > field description text
> > (so all the colons will be aligned). A rapid google
> > search shown that in
> > French and Vietnamese there should be a space before
> > the colon, while in
> > the rest of the world there is not, so having the
> > translation for the
> > ":" word seems to make sense. Also another question
> > arises: Is there
> > some language in which the colon should be another
> > character before the
> > word? (I'm thinking about spanish where the question
> > mark upside-down
> > appears before a question...)? ...conclusion:
> > keeping "Height:" and
> > "Height" as two different words seem to be the
> > solution that gives
> > maximum flexibility to translators.
> >
> >
> > This actually doesn't give them as much flexibility.
> > When translations are done, they need to examine the
> > entire string that needs translating, so the ":"
> > character should be included in the string. Separating
> > out the two portions is the equivalent of saying that
> > every lanugage will follow the same compositional rules.
> >
> >
> > Another possible solution (probably better then the
> > one above since it
> > just removes the problem) is to remove the ":" and
> > have the cell borders
> > in a different color, just like the tables in the
> > "board setup" dialog
> > (so that you can also take a look at that code to
> > solve also the color
> > problem seeing how it was solved there). The
> > advantage of this approach
> > is also having a more consistent "look" through all
> > the dialogs.
> >
> >
> >
> > P.S. (a little bit off-topic):
> > If you move the statistic window and check/uncheck
> > one of the checkboxes
> > ("subctract holes" or "Exclude components...")
> > the window "jumps" to
> > the center of the screen (its default position on
> > open): do you have
> >   

Re: [Kicad-developers] [PATCH] Board statistics dialog

[Wayne Stambaugh]

I agree.  There is utility in both the actual area of a board and the
manufacturing area.  The latter should be fairly trivial to implement.

Cheers,

Wayne

On 7/29/19 9:30 AM, Clemens Koller wrote:
> Hi!
> I think it could be good to see both:
> - The actual PCB area of the outline (well, without drills).
> - The max-width * max-height which is usually what you have to pay for when 
> you get it manufactured.
> The second one could be also an interesting task to calculate if you have an 
> odd shaped polygonal outline.
> 
> Regards,
> Clemens
> 
> 
> On 29/07/2019 14.43, Alexander Shuklin wrote:
>>   Hi! I've been asked to do actually PCB area calculation. Since English is 
>> not my first language, maybe I just miss-understood. Do you mean, that area 
>> has to be just max width * max height? I never seen that, but there's a 
>> message in thread about sometimes you need proper area.
>> I utilized kicad outline functions for that.
>>
>>
>> Понедельник, 29 июля 2019, 15:35 +03:00 от Mark Roszko 
>> :
>>
>> Huh, looking at the statistics code, it actually tries and find the more 
>> "detailed area" of a board based on any polygonal outline.
>> Is there any value in it this way? PCB manufacturing charges are 
>> generally per-square area  because ultimately the price is on panel space 
>> you are using. 
>>
>> On Sat, Jul 27, 2019 at 5:07 AM Diego Herranz 
>> > > wrote:
>>
>> I've been testing this dialog and I think it is a nice addition. 
>> Thanks!
>>
>> There seems to be something wrong with the area calculation, though. 
>> See image below:
>> area.png
>>
>> Thanks,
>> Diego
>>
>> On Tue, 23 Jul 2019 at 11:18, Ian McInerney 
>> > > wrote:
>>
>> Alexander,
>>
>> Instead of declaring the 2 static variables separately, I would 
>> suggest creating a struct for the settings then store that as the static 
>> variable. For an example of this see the dialog_create_array.cpp file. This 
>> way if any new options must be added in the future, they can just be added 
>> to the struct very easily.
>>
>> -Ian
>>
>> On Mon, Jul 22, 2019 at 9:39 PM Alexander Shuklin 
>> > 
>> wrote:
>>
>> Damn ><,
>> don't use last patch, please.
>> It doesn't count total vias amount. Use this one.
>>
>>
>> Понедельник, 22 июля 2019, 22:14 +03:00 от Alexander 
>> Shuklin > >:
>>
>> Hi,
>> thanks for sharing experience, as I never used that 
>> translations or wxWidgets before. And I have no idea where else could I get 
>> that information. ))
>> So, there's the patch with vias information and some 
>> tiny improvements.
>>
>>
>> Понедельник, 22 июля 2019, 13:34 +03:00 от Ian 
>> McInerney > >:
>>
>>
>>
>> On Mon, Jul 22, 2019 at 11:03 AM Dino Ghilardi 
>> > > wrote:
>>
>> Hi Alexander,
>>
>> One possible solution for the translation could 
>> be put the ":" in a
>> different column of the table and right-align 
>> the field description text
>> (so all the colons will be aligned). A rapid 
>> google search shown that in
>> French and Vietnamese there should be a space 
>> before the colon, while in
>> the rest of the world there is not, so having 
>> the translation for the
>> ":" word seems to make sense. Also another 
>> question arises: Is there
>> some language in which the colon should be 
>> another character before the
>> word? (I'm thinking about spanish where the 
>> question mark upside-down
>> appears before a question...)? ...conclusion: 
>> keeping "Height:" and
>> "Height" as two different words seem to be the 
>> solution that gives
>> maximum flexibility to translators.
>>
>>
>> This actually doesn't give them as much flexibility. 
>> When translations are done, they need to examine the entire string that 
>> needs translating, so the ":" character should be included in the string. 
>> Separating out the two portions is the equivalent of saying that every 
>> lanugage will follow the same compositional rules.
>>  
>>
>> Another possible solution (probably better then 
>> the one above since it
>> just removes the problem) is to remove the ":" 
>> and have the cell borders
>> in a different color, just like the tables in 
>> the "board setup" dialog
>> (so that you can also take a 

Re: [Kicad-developers] [PATCH] Board statistics dialog

[Clemens Koller]

Hi!
I think it could be good to see both:
- The actual PCB area of the outline (well, without drills).
- The max-width * max-height which is usually what you have to pay for when you 
get it manufactured.
The second one could be also an interesting task to calculate if you have an 
odd shaped polygonal outline.

Regards,
Clemens


On 29/07/2019 14.43, Alexander Shuklin wrote:
>   Hi! I've been asked to do actually PCB area calculation. Since English is 
> not my first language, maybe I just miss-understood. Do you mean, that area 
> has to be just max width * max height? I never seen that, but there's a 
> message in thread about sometimes you need proper area.
> I utilized kicad outline functions for that.
> 
> 
> Понедельник, 29 июля 2019, 15:35 +03:00 от Mark Roszko 
> :
> 
> Huh, looking at the statistics code, it actually tries and find the more 
> "detailed area" of a board based on any polygonal outline.
> Is there any value in it this way? PCB manufacturing charges are 
> generally per-square area  because ultimately the price is on panel space you 
> are using. 
> 
> On Sat, Jul 27, 2019 at 5:07 AM Diego Herranz 
>  > wrote:
> 
> I've been testing this dialog and I think it is a nice addition. 
> Thanks!
> 
> There seems to be something wrong with the area calculation, though. 
> See image below:
> area.png
> 
> Thanks,
> Diego
> 
> On Tue, 23 Jul 2019 at 11:18, Ian McInerney  > wrote:
> 
> Alexander,
> 
> Instead of declaring the 2 static variables separately, I would 
> suggest creating a struct for the settings then store that as the static 
> variable. For an example of this see the dialog_create_array.cpp file. This 
> way if any new options must be added in the future, they can just be added to 
> the struct very easily.
> 
> -Ian
> 
> On Mon, Jul 22, 2019 at 9:39 PM Alexander Shuklin 
> > 
> wrote:
> 
> Damn ><,
> don't use last patch, please.
> It doesn't count total vias amount. Use this one.
> 
> 
> Понедельник, 22 июля 2019, 22:14 +03:00 от Alexander 
> Shuklin  >:
> 
> Hi,
> thanks for sharing experience, as I never used that 
> translations or wxWidgets before. And I have no idea where else could I get 
> that information. ))
> So, there's the patch with vias information and some tiny 
> improvements.
> 
> 
> Понедельник, 22 июля 2019, 13:34 +03:00 от Ian 
> McInerney  >:
> 
> 
> 
> On Mon, Jul 22, 2019 at 11:03 AM Dino Ghilardi 
>  > wrote:
> 
> Hi Alexander,
> 
> One possible solution for the translation could 
> be put the ":" in a
> different column of the table and right-align the 
> field description text
> (so all the colons will be aligned). A rapid 
> google search shown that in
> French and Vietnamese there should be a space 
> before the colon, while in
> the rest of the world there is not, so having the 
> translation for the
> ":" word seems to make sense. Also another 
> question arises: Is there
> some language in which the colon should be 
> another character before the
> word? (I'm thinking about spanish where the 
> question mark upside-down
> appears before a question...)? ...conclusion: 
> keeping "Height:" and
> "Height" as two different words seem to be the 
> solution that gives
> maximum flexibility to translators.
> 
> 
> This actually doesn't give them as much flexibility. 
> When translations are done, they need to examine the entire string that needs 
> translating, so the ":" character should be included in the string. 
> Separating out the two portions is the equivalent of saying that every 
> lanugage will follow the same compositional rules.
>  
> 
> Another possible solution (probably better then 
> the one above since it
> just removes the problem) is to remove the ":" 
> and have the cell borders
> in a different color, just like the tables in the 
> "board setup" dialog
> (so that you can also take a look at that code to 
> solve also the color
> problem seeing how it was solved there). The 
> advantage of this approach
> is also having a more consistent "look" through 
> all the dialogs.
> 
> 
> 
> P.S. (a little bit off-topic):
>  

Re: [Kicad-developers] [PATCH] Board statistics dialog

[Alexander Shuklin]

  Hi! I've been asked to do actually PCB area calculation. Since English is not 
my first language, maybe I just miss-understood. Do you mean, that area has to 
be just max width * max height? I never seen that, but there's a message in 
thread about sometimes you need proper area. 
I utilized kicad outline functions for that.


>Понедельник, 29 июля 2019, 15:35 +03:00 от Mark Roszko :
>
>Huh, looking at the statistics code, it actually tries and find the more 
>"detailed area" of a board based on any polygonal outline.
>Is there any value in it this way? PCB manufacturing charges are generally 
>per-square area  because ultimately the price is on panel space you are using. 
>On Sat, Jul 27, 2019 at 5:07 AM Diego Herranz < diegoherr...@diegoherranz.com 
>> wrote:
>>I've been testing this dialog and I think it is a nice addition. Thanks!
>>
>>There seems to be something wrong with the area calculation, though. See 
>>image below:
>>
>>
>>Thanks,
>>Diego
>>On Tue, 23 Jul 2019 at 11:18, Ian McInerney < ian.s.mciner...@ieee.org > 
>>wrote:
>>>Alexander,
>>>
>>>Instead of declaring the 2 static variables separately, I would suggest 
>>>creating a struct for the settings then store that as the static variable. 
>>>For an example of this see the dialog_create_array.cpp file. This way if any 
>>>new options must be added in the future, they can just be added to the 
>>>struct very easily.
>>>
>>>-Ian
>>>On Mon, Jul 22, 2019 at 9:39 PM Alexander Shuklin < jasura...@mail.ru > 
>>>wrote:
Damn ><,
don't use last patch, please.
It doesn't count total vias amount. Use this one.


>Понедельник, 22 июля 2019, 22:14 +03:00 от Alexander Shuklin < 
>jasura...@mail.ru >:
>
>Hi,
>thanks for sharing experience, as I never used that translations or 
>wxWidgets before. And I have no idea where else could I get that 
>information. ))
>So, there's the patch with vias information and some tiny improvements. 
>
>
>>Понедельник, 22 июля 2019, 13:34 +03:00 от Ian McInerney < 
>>ian.s.mciner...@ieee.org >:
>>
>>
>>
>>On Mon, Jul 22, 2019 at 11:03 AM Dino Ghilardi < dino.ghila...@ieee.org > 
>>wrote:
>>>Hi Alexander,
>>>
>>>One possible solution for the translation could be put the ":" in a 
>>>different column of the table and right-align the field description text 
>>>(so all the colons will be aligned). A rapid google search shown that in 
>>>French and Vietnamese there should be a space before the colon, while in 
>>>the rest of the world there is not, so having the translation for the 
>>>":" word seems to make sense. Also another question arises: Is there 
>>>some language in which the colon should be another character before the 
>>>word? (I'm thinking about spanish where the question mark upside-down 
>>>appears before a question...)? ...conclusion: keeping "Height:" and 
>>>"Height" as two different words seem to be the solution that gives 
>>>maximum flexibility to translators.
>>>
>>
>>This actually doesn't give them as much flexibility. When translations 
>>are done, they need to examine the entire string that needs translating, 
>>so the ":" character should be included in the string. Separating out the 
>>two portions is the equivalent of saying that every lanugage will follow 
>>the same compositional rules.
>>  
>>>Another possible solution (probably better then the one above since it 
>>>just removes the problem) is to remove the ":" and have the cell borders 
>>>in a different color, just like the tables in the "board setup" dialog 
>>>(so that you can also take a look at that code to solve also the color 
>>>problem seeing how it was solved there). The advantage of this approach 
>>>is also having a more consistent "look" through all the dialogs.
>>>
>>>
>>>
>>>P.S. (a little bit off-topic):
>>>If you move the statistic window and check/uncheck one of the checkboxes 
>>>("subctract holes" or "Exclude components...") the window "jumps" to 
>>>the center of the screen (its default position on open): do you have 
>>>also this behaviour or it is just on my debian-linux with gtk3?
>>>
>>>
>>>Cheers,
>>>Dino.
>>>
>>>On 22/07/19 10:13, Alexander Shuklin wrote:
 Hi!
 I'll have a look to add vias count to dialog.
 There's some questions:
 
 1)I don't have too much experience with wxdialogs. There was commit on 
 master, which says:
  >> remove settings for fg/bg color: the result is unpredictable: was 
 black texts on black background on my computer.
 And now I have all tables with data just in white boxes. Is it how it 
 meant to be, or just some misbehavior on different systems? I use 
 archlinux x64 OS.
 there's screenshot in attachment
 
 2) Can we use something 

Re: [Kicad-developers] [PATCH] Board statistics dialog

[Alexander Shuklin]

Hi,
I was without internet for few days, I will look for problem. Anyway, 
information about that bug will be very helpful.

>Воскресенье, 28 июля 2019, 17:04 +03:00 от Wayne Stambaugh 
>:
>
>Diego,
>
>Please file a bug report for this and include the board file that causes
>this so it's easier for us to figure out what is going on.
>
>Thanks,
>
>Wayne
>
>On 7/27/19 5:06 AM, Diego Herranz wrote:
>> I've been testing this dialog and I think it is a nice addition. Thanks!
>> 
>> There seems to be something wrong with the area calculation, though. See
>> image below:
>> area.png
>> 
>> Thanks,
>> Diego
>> 
>> On Tue, 23 Jul 2019 at 11:18, Ian McInerney < ian.s.mciner...@ieee.org
>> > wrote:
>> 
>> Alexander,
>> 
>> Instead of declaring the 2 static variables separately, I would
>> suggest creating a struct for the settings then store that as the
>> static variable. For an example of this see the
>> dialog_create_array.cpp file. This way if any new options must be
>> added in the future, they can just be added to the struct very easily.
>> 
>> -Ian
>> 
>> On Mon, Jul 22, 2019 at 9:39 PM Alexander Shuklin < jasura...@mail.ru
>> > wrote:
>> 
>> Damn ><,
>> don't use last patch, please.
>> It doesn't count total vias amount. Use this one.
>> 
>> 
>> Понедельник, 22 июля 2019, 22:14 +03:00 от Alexander Shuklin
>> < jasura...@mail.ru >:
>> 
>> Hi,
>> thanks for sharing experience, as I never used that
>> translations or wxWidgets before. And I have no idea where
>> else could I get that information. ))
>> So, there's the patch with vias information and some tiny
>> improvements.
>> 
>> 
>> Понедельник, 22 июля 2019, 13:34 +03:00 от Ian McInerney
>> < ian.s.mciner...@ieee.org
>> >:
>> 
>> 
>> 
>> On Mon, Jul 22, 2019 at 11:03 AM Dino Ghilardi
>> < dino.ghila...@ieee.org
>> < 
>> http://e.mail.ru/compose/?mailto=mailto%3adino.ghila...@ieee.org >>
>> wrote:
>> 
>> Hi Alexander,
>> 
>> One possible solution for the translation could be
>> put the ":" in a
>> different column of the table and right-align the
>> field description text
>> (so all the colons will be aligned). A rapid google
>> search shown that in
>> French and Vietnamese there should be a space before
>> the colon, while in
>> the rest of the world there is not, so having the
>> translation for the
>> ":" word seems to make sense. Also another question
>> arises: Is there
>> some language in which the colon should be another
>> character before the
>> word? (I'm thinking about spanish where the question
>> mark upside-down
>> appears before a question...)? ...conclusion:
>> keeping "Height:" and
>> "Height" as two different words seem to be the
>> solution that gives
>> maximum flexibility to translators.
>> 
>> 
>> This actually doesn't give them as much flexibility.
>> When translations are done, they need to examine the
>> entire string that needs translating, so the ":"
>> character should be included in the string. Separating
>> out the two portions is the equivalent of saying that
>> every lanugage will follow the same compositional rules.
>>  
>> 
>> Another possible solution (probably better then the
>> one above since it
>> just removes the problem) is to remove the ":" and
>> have the cell borders
>> in a different color, just like the tables in the
>> "board setup" dialog
>> (so that you can also take a look at that code to
>> solve also the color
>> problem seeing how it was solved there). The
>> advantage of this approach
>> is also having a more consistent "look" through all
>> the dialogs.
>> 
>> 
>> 
>> P.S. (a little bit off-topic):
>> If you move the statistic window and check/uncheck
>> one of the checkboxes
>> ("subctract holes" or "Exclude components...")
>> the window 

Re: [Kicad-developers] [PATCH] Board statistics dialog

[Mark Roszko]

Huh, looking at the statistics code, it actually tries and find the more
"detailed area" of a board based on any polygonal outline.
Is there any value in it this way? PCB manufacturing charges are generally
per-square area  because ultimately the price is on panel space you are
using.

On Sat, Jul 27, 2019 at 5:07 AM Diego Herranz 
wrote:

> I've been testing this dialog and I think it is a nice addition. Thanks!
>
> There seems to be something wrong with the area calculation, though. See
> image below:
> [image: area.png]
>
> Thanks,
> Diego
>
> On Tue, 23 Jul 2019 at 11:18, Ian McInerney 
> wrote:
>
>> Alexander,
>>
>> Instead of declaring the 2 static variables separately, I would suggest
>> creating a struct for the settings then store that as the static variable.
>> For an example of this see the dialog_create_array.cpp file. This way if
>> any new options must be added in the future, they can just be added to the
>> struct very easily.
>>
>> -Ian
>>
>> On Mon, Jul 22, 2019 at 9:39 PM Alexander Shuklin 
>> wrote:
>>
>>> Damn ><,
>>> don't use last patch, please.
>>> It doesn't count total vias amount. Use this one.
>>>
>>>
>>> Понедельник, 22 июля 2019, 22:14 +03:00 от Alexander Shuklin <
>>> jasura...@mail.ru>:
>>>
>>> Hi,
>>> thanks for sharing experience, as I never used that translations or
>>> wxWidgets before. And I have no idea where else could I get that
>>> information. ))
>>> So, there's the patch with vias information and some tiny improvements.
>>>
>>>
>>> Понедельник, 22 июля 2019, 13:34 +03:00 от Ian McInerney <
>>> ian.s.mciner...@ieee.org>:
>>>
>>>
>>>
>>> On Mon, Jul 22, 2019 at 11:03 AM Dino Ghilardi >> >
>>> wrote:
>>>
>>> Hi Alexander,
>>>
>>> One possible solution for the translation could be put the ":" in a
>>> different column of the table and right-align the field description text
>>> (so all the colons will be aligned). A rapid google search shown that in
>>> French and Vietnamese there should be a space before the colon, while in
>>> the rest of the world there is not, so having the translation for the
>>> ":" word seems to make sense. Also another question arises: Is there
>>> some language in which the colon should be another character before the
>>> word? (I'm thinking about spanish where the question mark upside-down
>>> appears before a question...)? ...conclusion: keeping "Height:" and
>>> "Height" as two different words seem to be the solution that gives
>>> maximum flexibility to translators.
>>>
>>>
>>> This actually doesn't give them as much flexibility. When translations
>>> are done, they need to examine the entire string that needs translating, so
>>> the ":" character should be included in the string. Separating out the two
>>> portions is the equivalent of saying that every lanugage will follow the
>>> same compositional rules.
>>>
>>>
>>> Another possible solution (probably better then the one above since it
>>> just removes the problem) is to remove the ":" and have the cell borders
>>> in a different color, just like the tables in the "board setup" dialog
>>> (so that you can also take a look at that code to solve also the color
>>> problem seeing how it was solved there). The advantage of this approach
>>> is also having a more consistent "look" through all the dialogs.
>>>
>>>
>>>
>>> P.S. (a little bit off-topic):
>>> If you move the statistic window and check/uncheck one of the checkboxes
>>> ("subctract holes" or "Exclude components...") the window "jumps" to
>>> the center of the screen (its default position on open): do you have
>>> also this behaviour or it is just on my debian-linux with gtk3?
>>>
>>>
>>> Cheers,
>>> Dino.
>>>
>>> On 22/07/19 10:13, Alexander Shuklin wrote:
>>> > Hi!
>>> > I'll have a look to add vias count to dialog.
>>> > There's some questions:
>>> >
>>> > 1)I don't have too much experience with wxdialogs. There was commit on
>>> > master, which says:
>>> >  >> remove settings for fg/bg color: the result is unpredictable: was
>>> > black texts on black background on my computer.
>>> > And now I have all tables with data just in white boxes. Is it how it
>>> > meant to be, or just some misbehavior on different systems? I use
>>> > archlinux x64 OS.
>>> > there's screenshot in attachment
>>> >
>>> > 2) Can we use something like _( "Height" ) + ":" for translation, not
>>> _(
>>> > "Height:" )? As far as I understand, now we will need to have 2
>>> > translations, first for "Height" and second for "Height:" but that's
>>> > basically same word.
>>> >
>>> > Воскресенье, 21 июля 2019, 23:42 +03:00 от Dino Ghilardi
>>> > >> >:
>>> >
>>> > Makes sense.
>>> > Instead of a generic "via count" a more complete table similar to
>>> the
>>> > one generated in the drill report file could be useful, but may be
>>> it
>>> > can became quite long if a lot of different drill sizes are 

Re: [Kicad-developers] [PATCH] Board statistics dialog

[Alexander Shuklin]

Here you are)

>Воскресенье, 28 июля 2019, 19:28 +03:00 от jp charras :
>
>Le 24/07/2019 à 14:52, Alexander Shuklin a écrit :
>> Hi Ian,
>> Sorry for delay, also I added feature to save statistics in txt file, as
>> Dino suggested.
>> 
>> -- 
>> Alexander Shuklin
>> 
>
>Hi Alexander,
>
>I just committed your patch.
>Thanks.
>
>
>-- 
>Jean-Pierre CHARRAS
>
>___
>Mailing list:  https://launchpad.net/~kicad-developers
>Post to :  kicad-developers@lists.launchpad.net
>Unsubscribe :  https://launchpad.net/~kicad-developers
>More help   :  https://help.launchpad.net/ListHelp


-- 
Alexander Shuklin
___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] [PATCH] Board statistics dialog

[Wayne Stambaugh]

Diego,

Please file a bug report for this and include the board file that causes
this so it's easier for us to figure out what is going on.

Thanks,

Wayne

On 7/27/19 5:06 AM, Diego Herranz wrote:
> I've been testing this dialog and I think it is a nice addition. Thanks!
> 
> There seems to be something wrong with the area calculation, though. See
> image below:
> area.png
> 
> Thanks,
> Diego
> 
> On Tue, 23 Jul 2019 at 11:18, Ian McInerney  > wrote:
> 
> Alexander,
> 
> Instead of declaring the 2 static variables separately, I would
> suggest creating a struct for the settings then store that as the
> static variable. For an example of this see the
> dialog_create_array.cpp file. This way if any new options must be
> added in the future, they can just be added to the struct very easily.
> 
> -Ian
> 
> On Mon, Jul 22, 2019 at 9:39 PM Alexander Shuklin  > wrote:
> 
> Damn ><,
> don't use last patch, please.
> It doesn't count total vias amount. Use this one.
> 
> 
> Понедельник, 22 июля 2019, 22:14 +03:00 от Alexander Shuklin
> mailto:jasura...@mail.ru>>:
> 
> Hi,
> thanks for sharing experience, as I never used that
> translations or wxWidgets before. And I have no idea where
> else could I get that information. ))
> So, there's the patch with vias information and some tiny
> improvements.
> 
> 
> Понедельник, 22 июля 2019, 13:34 +03:00 от Ian McInerney
>  >:
> 
> 
> 
> On Mon, Jul 22, 2019 at 11:03 AM Dino Ghilardi
>  
> >
> wrote:
> 
> Hi Alexander,
> 
> One possible solution for the translation could be
> put the ":" in a
> different column of the table and right-align the
> field description text
> (so all the colons will be aligned). A rapid google
> search shown that in
> French and Vietnamese there should be a space before
> the colon, while in
> the rest of the world there is not, so having the
> translation for the
> ":" word seems to make sense. Also another question
> arises: Is there
> some language in which the colon should be another
> character before the
> word? (I'm thinking about spanish where the question
> mark upside-down
> appears before a question...)? ...conclusion:
> keeping "Height:" and
> "Height" as two different words seem to be the
> solution that gives
> maximum flexibility to translators.
> 
> 
> This actually doesn't give them as much flexibility.
> When translations are done, they need to examine the
> entire string that needs translating, so the ":"
> character should be included in the string. Separating
> out the two portions is the equivalent of saying that
> every lanugage will follow the same compositional rules.
>  
> 
> Another possible solution (probably better then the
> one above since it
> just removes the problem) is to remove the ":" and
> have the cell borders
> in a different color, just like the tables in the
> "board setup" dialog
> (so that you can also take a look at that code to
> solve also the color
> problem seeing how it was solved there). The
> advantage of this approach
> is also having a more consistent "look" through all
> the dialogs.
> 
> 
> 
> P.S. (a little bit off-topic):
> If you move the statistic window and check/uncheck
> one of the checkboxes
> ("subctract holes" or "Exclude components...")
> the window "jumps" to
> the center of the screen (its default position on
> open): do you have
> also this behaviour or it is just on my debian-linux
> with gtk3?
> 
> 
> Cheers,
> Dino.
> 
> On 22/07/19 10:13, Alexander Shuklin wrote:
> > Hi!
> > I'll have a look to add 

Re: [Kicad-developers] [PATCH] Board statistics dialog

[Diego Herranz]

I've been testing this dialog and I think it is a nice addition. Thanks!

There seems to be something wrong with the area calculation, though. See
image below:
[image: area.png]

Thanks,
Diego

On Tue, 23 Jul 2019 at 11:18, Ian McInerney 
wrote:

> Alexander,
>
> Instead of declaring the 2 static variables separately, I would suggest
> creating a struct for the settings then store that as the static variable.
> For an example of this see the dialog_create_array.cpp file. This way if
> any new options must be added in the future, they can just be added to the
> struct very easily.
>
> -Ian
>
> On Mon, Jul 22, 2019 at 9:39 PM Alexander Shuklin 
> wrote:
>
>> Damn ><,
>> don't use last patch, please.
>> It doesn't count total vias amount. Use this one.
>>
>>
>> Понедельник, 22 июля 2019, 22:14 +03:00 от Alexander Shuklin <
>> jasura...@mail.ru>:
>>
>> Hi,
>> thanks for sharing experience, as I never used that translations or
>> wxWidgets before. And I have no idea where else could I get that
>> information. ))
>> So, there's the patch with vias information and some tiny improvements.
>>
>>
>> Понедельник, 22 июля 2019, 13:34 +03:00 от Ian McInerney <
>> ian.s.mciner...@ieee.org>:
>>
>>
>>
>> On Mon, Jul 22, 2019 at 11:03 AM Dino Ghilardi > >
>> wrote:
>>
>> Hi Alexander,
>>
>> One possible solution for the translation could be put the ":" in a
>> different column of the table and right-align the field description text
>> (so all the colons will be aligned). A rapid google search shown that in
>> French and Vietnamese there should be a space before the colon, while in
>> the rest of the world there is not, so having the translation for the
>> ":" word seems to make sense. Also another question arises: Is there
>> some language in which the colon should be another character before the
>> word? (I'm thinking about spanish where the question mark upside-down
>> appears before a question...)? ...conclusion: keeping "Height:" and
>> "Height" as two different words seem to be the solution that gives
>> maximum flexibility to translators.
>>
>>
>> This actually doesn't give them as much flexibility. When translations
>> are done, they need to examine the entire string that needs translating, so
>> the ":" character should be included in the string. Separating out the two
>> portions is the equivalent of saying that every lanugage will follow the
>> same compositional rules.
>>
>>
>> Another possible solution (probably better then the one above since it
>> just removes the problem) is to remove the ":" and have the cell borders
>> in a different color, just like the tables in the "board setup" dialog
>> (so that you can also take a look at that code to solve also the color
>> problem seeing how it was solved there). The advantage of this approach
>> is also having a more consistent "look" through all the dialogs.
>>
>>
>>
>> P.S. (a little bit off-topic):
>> If you move the statistic window and check/uncheck one of the checkboxes
>> ("subctract holes" or "Exclude components...") the window "jumps" to
>> the center of the screen (its default position on open): do you have
>> also this behaviour or it is just on my debian-linux with gtk3?
>>
>>
>> Cheers,
>> Dino.
>>
>> On 22/07/19 10:13, Alexander Shuklin wrote:
>> > Hi!
>> > I'll have a look to add vias count to dialog.
>> > There's some questions:
>> >
>> > 1)I don't have too much experience with wxdialogs. There was commit on
>> > master, which says:
>> >  >> remove settings for fg/bg color: the result is unpredictable: was
>> > black texts on black background on my computer.
>> > And now I have all tables with data just in white boxes. Is it how it
>> > meant to be, or just some misbehavior on different systems? I use
>> > archlinux x64 OS.
>> > there's screenshot in attachment
>> >
>> > 2) Can we use something like _( "Height" ) + ":" for translation, not
>> _(
>> > "Height:" )? As far as I understand, now we will need to have 2
>> > translations, first for "Height" and second for "Height:" but that's
>> > basically same word.
>> >
>> > Воскресенье, 21 июля 2019, 23:42 +03:00 от Dino Ghilardi
>> > > >:
>> >
>> > Makes sense.
>> > Instead of a generic "via count" a more complete table similar to
>> the
>> > one generated in the drill report file could be useful, but may be
>> it
>> > can became quite long if a lot of different drill sizes are used
>> (ok,
>> > scrollbars are made to handle that).
>> > Also having "vias", "blind vias" and "microvias" count man make
>> sense
>> > (or at least having something like "microvias used: yes/no"), just
>> to
>> > have in board statistics the information about the need of an
>> advanced
>> > pcb manufacturing process.
>> >
>> >
>> > Cheers,
>> > Dino.
>> >
>> >
>> > On 21/07/19 20:54, Mark Roszko wrote:
>> >  > > Since making every 

Re: [Kicad-developers] [PATCH] Board statistics dialog

[Alexander Shuklin]

Hi Ian,
Sorry for delay, also I added feature to save statistics in txt file, as Dino 
suggested.

>Понедельник, 22 июля 2019, 23:57 +03:00 от Ian McInerney 
>:
>
>Alexander,
>
>Instead of declaring the 2 static variables separately, I would suggest 
>creating a struct for the settings then store that as the static variable. For 
>an example of this see the dialog_create_array.cpp file. This way if any new 
>options must be added in the future, they can just be added to the struct very 
>easily.
>
>-Ian
>On Mon, Jul 22, 2019 at 9:39 PM Alexander Shuklin < jasura...@mail.ru > wrote:
>>Damn ><,
>>don't use last patch, please.
>>It doesn't count total vias amount. Use this one.
>>
>>
>>>Понедельник, 22 июля 2019, 22:14 +03:00 от Alexander Shuklin < 
>>>jasura...@mail.ru >:
>>>
>>>Hi,
>>>thanks for sharing experience, as I never used that translations or 
>>>wxWidgets before. And I have no idea where else could I get that 
>>>information. ))
>>>So, there's the patch with vias information and some tiny improvements. 
>>>
>>>
Понедельник, 22 июля 2019, 13:34 +03:00 от Ian McInerney < 
ian.s.mciner...@ieee.org >:



On Mon, Jul 22, 2019 at 11:03 AM Dino Ghilardi < dino.ghila...@ieee.org > 
wrote:
>Hi Alexander,
>
>One possible solution for the translation could be put the ":" in a 
>different column of the table and right-align the field description text 
>(so all the colons will be aligned). A rapid google search shown that in 
>French and Vietnamese there should be a space before the colon, while in 
>the rest of the world there is not, so having the translation for the 
>":" word seems to make sense. Also another question arises: Is there 
>some language in which the colon should be another character before the 
>word? (I'm thinking about spanish where the question mark upside-down 
>appears before a question...)? ...conclusion: keeping "Height:" and 
>"Height" as two different words seem to be the solution that gives 
>maximum flexibility to translators.
>

This actually doesn't give them as much flexibility. When translations are 
done, they need to examine the entire string that needs translating, so the 
":" character should be included in the string. Separating out the two 
portions is the equivalent of saying that every lanugage will follow the 
same compositional rules.
  
>Another possible solution (probably better then the one above since it 
>just removes the problem) is to remove the ":" and have the cell borders 
>in a different color, just like the tables in the "board setup" dialog 
>(so that you can also take a look at that code to solve also the color 
>problem seeing how it was solved there). The advantage of this approach 
>is also having a more consistent "look" through all the dialogs.
>
>
>
>P.S. (a little bit off-topic):
>If you move the statistic window and check/uncheck one of the checkboxes 
>("subctract holes" or "Exclude components...") the window "jumps" to 
>the center of the screen (its default position on open): do you have 
>also this behaviour or it is just on my debian-linux with gtk3?
>
>
>Cheers,
>Dino.
>
>On 22/07/19 10:13, Alexander Shuklin wrote:
>> Hi!
>> I'll have a look to add vias count to dialog.
>> There's some questions:
>> 
>> 1)I don't have too much experience with wxdialogs. There was commit on 
>> master, which says:
>>  >> remove settings for fg/bg color: the result is unpredictable: was 
>> black texts on black background on my computer.
>> And now I have all tables with data just in white boxes. Is it how it 
>> meant to be, or just some misbehavior on different systems? I use 
>> archlinux x64 OS.
>> there's screenshot in attachment
>> 
>> 2) Can we use something like _( "Height" ) + ":" for translation, not _( 
>> "Height:" )? As far as I understand, now we will need to have 2 
>> translations, first for "Height" and second for "Height:" but that's 
>> basically same word.
>> 
>>     Воскресенье, 21 июля 2019, 23:42 +03:00 от Dino Ghilardi
>>     < dino.ghila...@ieee.org >:
>> 
>>     Makes sense.
>>     Instead of a generic "via count" a more complete table similar to the
>>     one generated in the drill report file could be useful, but may be it
>>     can became quite long if a lot of different drill sizes are used (ok,
>>     scrollbars are made to handle that).
>>     Also having "vias", "blind vias" and "microvias" count man make sense
>>     (or at least having something like "microvias used: yes/no"), just to
>>     have in board statistics the information about the need of an 
>>advanced
>>     pcb manufacturing process.
>> 
>> 
>>     Cheers,
>>     Dino.
>> 
>> 
>>     On 21/07/19 20:54, Mark Roszko 

Re: [Kicad-developers] [PATCH] Board statistics dialog

[Alexander Shuklin]

Hi Ian,
That's good point. I'll change the patch tomorrow.  


>Понедельник, 22 июля 2019, 23:57 +03:00 от Ian McInerney 
>:
>
>Alexander,
>
>Instead of declaring the 2 static variables separately, I would suggest 
>creating a struct for the settings then store that as the static variable. For 
>an example of this see the dialog_create_array.cpp file. This way if any new 
>options must be added in the future, they can just be added to the struct very 
>easily.
>
>-Ian
>On Mon, Jul 22, 2019 at 9:39 PM Alexander Shuklin < jasura...@mail.ru > wrote:
>>Damn ><,
>>don't use last patch, please.
>>It doesn't count total vias amount. Use this one.
>>
>>
>>>Понедельник, 22 июля 2019, 22:14 +03:00 от Alexander Shuklin < 
>>>jasura...@mail.ru >:
>>>
>>>Hi,
>>>thanks for sharing experience, as I never used that translations or 
>>>wxWidgets before. And I have no idea where else could I get that 
>>>information. ))
>>>So, there's the patch with vias information and some tiny improvements. 
>>>
>>>
Понедельник, 22 июля 2019, 13:34 +03:00 от Ian McInerney < 
ian.s.mciner...@ieee.org >:



On Mon, Jul 22, 2019 at 11:03 AM Dino Ghilardi < dino.ghila...@ieee.org > 
wrote:
>Hi Alexander,
>
>One possible solution for the translation could be put the ":" in a 
>different column of the table and right-align the field description text 
>(so all the colons will be aligned). A rapid google search shown that in 
>French and Vietnamese there should be a space before the colon, while in 
>the rest of the world there is not, so having the translation for the 
>":" word seems to make sense. Also another question arises: Is there 
>some language in which the colon should be another character before the 
>word? (I'm thinking about spanish where the question mark upside-down 
>appears before a question...)? ...conclusion: keeping "Height:" and 
>"Height" as two different words seem to be the solution that gives 
>maximum flexibility to translators.
>

This actually doesn't give them as much flexibility. When translations are 
done, they need to examine the entire string that needs translating, so the 
":" character should be included in the string. Separating out the two 
portions is the equivalent of saying that every lanugage will follow the 
same compositional rules.
  
>Another possible solution (probably better then the one above since it 
>just removes the problem) is to remove the ":" and have the cell borders 
>in a different color, just like the tables in the "board setup" dialog 
>(so that you can also take a look at that code to solve also the color 
>problem seeing how it was solved there). The advantage of this approach 
>is also having a more consistent "look" through all the dialogs.
>
>
>
>P.S. (a little bit off-topic):
>If you move the statistic window and check/uncheck one of the checkboxes 
>("subctract holes" or "Exclude components...") the window "jumps" to 
>the center of the screen (its default position on open): do you have 
>also this behaviour or it is just on my debian-linux with gtk3?
>
>
>Cheers,
>Dino.
>
>On 22/07/19 10:13, Alexander Shuklin wrote:
>> Hi!
>> I'll have a look to add vias count to dialog.
>> There's some questions:
>> 
>> 1)I don't have too much experience with wxdialogs. There was commit on 
>> master, which says:
>>  >> remove settings for fg/bg color: the result is unpredictable: was 
>> black texts on black background on my computer.
>> And now I have all tables with data just in white boxes. Is it how it 
>> meant to be, or just some misbehavior on different systems? I use 
>> archlinux x64 OS.
>> there's screenshot in attachment
>> 
>> 2) Can we use something like _( "Height" ) + ":" for translation, not _( 
>> "Height:" )? As far as I understand, now we will need to have 2 
>> translations, first for "Height" and second for "Height:" but that's 
>> basically same word.
>> 
>>     Воскресенье, 21 июля 2019, 23:42 +03:00 от Dino Ghilardi
>>     < dino.ghila...@ieee.org >:
>> 
>>     Makes sense.
>>     Instead of a generic "via count" a more complete table similar to the
>>     one generated in the drill report file could be useful, but may be it
>>     can became quite long if a lot of different drill sizes are used (ok,
>>     scrollbars are made to handle that).
>>     Also having "vias", "blind vias" and "microvias" count man make sense
>>     (or at least having something like "microvias used: yes/no"), just to
>>     have in board statistics the information about the need of an 
>>advanced
>>     pcb manufacturing process.
>> 
>> 
>>     Cheers,
>>     Dino.
>> 
>> 
>>     On 21/07/19 20:54, Mark Roszko wrote:
>>      > > Since making 

Re: [Kicad-developers] [PATCH] Board statistics dialog

[Ian McInerney]

Alexander,

Instead of declaring the 2 static variables separately, I would suggest
creating a struct for the settings then store that as the static variable.
For an example of this see the dialog_create_array.cpp file. This way if
any new options must be added in the future, they can just be added to the
struct very easily.

-Ian

On Mon, Jul 22, 2019 at 9:39 PM Alexander Shuklin  wrote:

> Damn ><,
> don't use last patch, please.
> It doesn't count total vias amount. Use this one.
>
>
> Понедельник, 22 июля 2019, 22:14 +03:00 от Alexander Shuklin <
> jasura...@mail.ru>:
>
> Hi,
> thanks for sharing experience, as I never used that translations or
> wxWidgets before. And I have no idea where else could I get that
> information. ))
> So, there's the patch with vias information and some tiny improvements.
>
>
> Понедельник, 22 июля 2019, 13:34 +03:00 от Ian McInerney <
> ian.s.mciner...@ieee.org>:
>
>
>
> On Mon, Jul 22, 2019 at 11:03 AM Dino Ghilardi  > wrote:
>
> Hi Alexander,
>
> One possible solution for the translation could be put the ":" in a
> different column of the table and right-align the field description text
> (so all the colons will be aligned). A rapid google search shown that in
> French and Vietnamese there should be a space before the colon, while in
> the rest of the world there is not, so having the translation for the
> ":" word seems to make sense. Also another question arises: Is there
> some language in which the colon should be another character before the
> word? (I'm thinking about spanish where the question mark upside-down
> appears before a question...)? ...conclusion: keeping "Height:" and
> "Height" as two different words seem to be the solution that gives
> maximum flexibility to translators.
>
>
> This actually doesn't give them as much flexibility. When translations are
> done, they need to examine the entire string that needs translating, so the
> ":" character should be included in the string. Separating out the two
> portions is the equivalent of saying that every lanugage will follow the
> same compositional rules.
>
>
> Another possible solution (probably better then the one above since it
> just removes the problem) is to remove the ":" and have the cell borders
> in a different color, just like the tables in the "board setup" dialog
> (so that you can also take a look at that code to solve also the color
> problem seeing how it was solved there). The advantage of this approach
> is also having a more consistent "look" through all the dialogs.
>
>
>
> P.S. (a little bit off-topic):
> If you move the statistic window and check/uncheck one of the checkboxes
> ("subctract holes" or "Exclude components...") the window "jumps" to
> the center of the screen (its default position on open): do you have
> also this behaviour or it is just on my debian-linux with gtk3?
>
>
> Cheers,
> Dino.
>
> On 22/07/19 10:13, Alexander Shuklin wrote:
> > Hi!
> > I'll have a look to add vias count to dialog.
> > There's some questions:
> >
> > 1)I don't have too much experience with wxdialogs. There was commit on
> > master, which says:
> >  >> remove settings for fg/bg color: the result is unpredictable: was
> > black texts on black background on my computer.
> > And now I have all tables with data just in white boxes. Is it how it
> > meant to be, or just some misbehavior on different systems? I use
> > archlinux x64 OS.
> > there's screenshot in attachment
> >
> > 2) Can we use something like _( "Height" ) + ":" for translation, not _(
> > "Height:" )? As far as I understand, now we will need to have 2
> > translations, first for "Height" and second for "Height:" but that's
> > basically same word.
> >
> > Воскресенье, 21 июля 2019, 23:42 +03:00 от Dino Ghilardi
> >  >:
> >
> > Makes sense.
> > Instead of a generic "via count" a more complete table similar to the
> > one generated in the drill report file could be useful, but may be it
> > can became quite long if a lot of different drill sizes are used (ok,
> > scrollbars are made to handle that).
> > Also having "vias", "blind vias" and "microvias" count man make sense
> > (or at least having something like "microvias used: yes/no"), just to
> > have in board statistics the information about the need of an
> advanced
> > pcb manufacturing process.
> >
> >
> > Cheers,
> > Dino.
> >
> >
> > On 21/07/19 20:54, Mark Roszko wrote:
> >  > > Since making every hole in the pcb costs time,  manufacturers
> >  > calculate the price of the PCB using also that number.
> >  >
> >  > A long time ago, holes cost alot. These days if your manufacturer
> is
> >  > charging alot per hole, you should run far away. Usually
> > manufactuers
> >  > include 20k-40k holes in the base price per panel before they
> start
> >  > charging 

Re: [Kicad-developers] [PATCH] Board statistics dialog

[Alexander Shuklin]

Damn ><,
don't use last patch, please.
It doesn't count total vias amount. Use this one.


>Понедельник, 22 июля 2019, 22:14 +03:00 от Alexander Shuklin 
>:
>
>Hi,
>thanks for sharing experience, as I never used that translations or wxWidgets 
>before. And I have no idea where else could I get that information. ))
>So, there's the patch with vias information and some tiny improvements. 
>
>
>>Понедельник, 22 июля 2019, 13:34 +03:00 от Ian McInerney < 
>>ian.s.mciner...@ieee.org >:
>>
>>
>>
>>On Mon, Jul 22, 2019 at 11:03 AM Dino Ghilardi < dino.ghila...@ieee.org > 
>>wrote:
>>>Hi Alexander,
>>>
>>>One possible solution for the translation could be put the ":" in a 
>>>different column of the table and right-align the field description text 
>>>(so all the colons will be aligned). A rapid google search shown that in 
>>>French and Vietnamese there should be a space before the colon, while in 
>>>the rest of the world there is not, so having the translation for the 
>>>":" word seems to make sense. Also another question arises: Is there 
>>>some language in which the colon should be another character before the 
>>>word? (I'm thinking about spanish where the question mark upside-down 
>>>appears before a question...)? ...conclusion: keeping "Height:" and 
>>>"Height" as two different words seem to be the solution that gives 
>>>maximum flexibility to translators.
>>>
>>
>>This actually doesn't give them as much flexibility. When translations are 
>>done, they need to examine the entire string that needs translating, so the 
>>":" character should be included in the string. Separating out the two 
>>portions is the equivalent of saying that every lanugage will follow the same 
>>compositional rules.
>>  
>>>Another possible solution (probably better then the one above since it 
>>>just removes the problem) is to remove the ":" and have the cell borders 
>>>in a different color, just like the tables in the "board setup" dialog 
>>>(so that you can also take a look at that code to solve also the color 
>>>problem seeing how it was solved there). The advantage of this approach 
>>>is also having a more consistent "look" through all the dialogs.
>>>
>>>
>>>
>>>P.S. (a little bit off-topic):
>>>If you move the statistic window and check/uncheck one of the checkboxes 
>>>("subctract holes" or "Exclude components...") the window "jumps" to 
>>>the center of the screen (its default position on open): do you have 
>>>also this behaviour or it is just on my debian-linux with gtk3?
>>>
>>>
>>>Cheers,
>>>Dino.
>>>
>>>On 22/07/19 10:13, Alexander Shuklin wrote:
 Hi!
 I'll have a look to add vias count to dialog.
 There's some questions:
 
 1)I don't have too much experience with wxdialogs. There was commit on 
 master, which says:
  >> remove settings for fg/bg color: the result is unpredictable: was 
 black texts on black background on my computer.
 And now I have all tables with data just in white boxes. Is it how it 
 meant to be, or just some misbehavior on different systems? I use 
 archlinux x64 OS.
 there's screenshot in attachment
 
 2) Can we use something like _( "Height" ) + ":" for translation, not _( 
 "Height:" )? As far as I understand, now we will need to have 2 
 translations, first for "Height" and second for "Height:" but that's 
 basically same word.
 
     Воскресенье, 21 июля 2019, 23:42 +03:00 от Dino Ghilardi
     < dino.ghila...@ieee.org >:
 
     Makes sense.
     Instead of a generic "via count" a more complete table similar to the
     one generated in the drill report file could be useful, but may be it
     can became quite long if a lot of different drill sizes are used (ok,
     scrollbars are made to handle that).
     Also having "vias", "blind vias" and "microvias" count man make sense
     (or at least having something like "microvias used: yes/no"), just to
     have in board statistics the information about the need of an advanced
     pcb manufacturing process.
 
 
     Cheers,
     Dino.
 
 
     On 21/07/19 20:54, Mark Roszko wrote:
      > > Since making every hole in the pcb costs time,  manufacturers
      > calculate the price of the PCB using also that number.
      >
      > A long time ago, holes cost alot. These days if your manufacturer is
      > charging alot per hole, you should run far away. Usually
     manufactuers
      > include 20k-40k holes in the base price per panel before they start
      > charging you tiny penny amounts for more in some increments of
      > thousands. The CNC machines these days as blazing fast at making the
      > holes required and they charge more for the drill bit being worn
     down
      > than the time.
      >
      > What does actually cost money is via type and size. Blind vias make
      > layer stackups a pain in the 

Re: [Kicad-developers] [PATCH] Board statistics dialog

[Alexander Shuklin]

Hi Dino,
Thanks for that, I just haven't seen that stuff:

>>If you move the statistic window and check/uncheck one of the checkboxes 
>>("subctract holes" or "Exclude components...") the window "jumps" to 
>>the center of the screen (its default position on open): do you have 
>>also this behaviour or it is just on my debian-linux with gtk3?

That's bug. I fixed that with last patch I've sent. It should disappear once it 
will be accepted. 
>Понедельник, 22 июля 2019, 12:02 +03:00 от Dino Ghilardi 
>:
>
>Hi Alexander,
>
>One possible solution for the translation could be put the ":" in a 
>different column of the table and right-align the field description text 
>(so all the colons will be aligned). A rapid google search shown that in 
>French and Vietnamese there should be a space before the colon, while in 
>the rest of the world there is not, so having the translation for the 
>":" word seems to make sense. Also another question arises: Is there 
>some language in which the colon should be another character before the 
>word? (I'm thinking about spanish where the question mark upside-down 
>appears before a question...)? ...conclusion: keeping "Height:" and 
>"Height" as two different words seem to be the solution that gives 
>maximum flexibility to translators.
>
>Another possible solution (probably better then the one above since it 
>just removes the problem) is to remove the ":" and have the cell borders 
>in a different color, just like the tables in the "board setup" dialog 
>(so that you can also take a look at that code to solve also the color 
>problem seeing how it was solved there). The advantage of this approach 
>is also having a more consistent "look" through all the dialogs.
>
>
>
>P.S. (a little bit off-topic):
>If you move the statistic window and check/uncheck one of the checkboxes 
>("subctract holes" or "Exclude components...") the window "jumps" to 
>the center of the screen (its default position on open): do you have 
>also this behaviour or it is just on my debian-linux with gtk3?
>
>
>Cheers,
>Dino.
>
>On 22/07/19 10:13, Alexander Shuklin wrote:
>> Hi!
>> I'll have a look to add vias count to dialog.
>> There's some questions:
>> 
>> 1)I don't have too much experience with wxdialogs. There was commit on 
>> master, which says:
>>  >> remove settings for fg/bg color: the result is unpredictable: was 
>> black texts on black background on my computer.
>> And now I have all tables with data just in white boxes. Is it how it 
>> meant to be, or just some misbehavior on different systems? I use 
>> archlinux x64 OS.
>> there's screenshot in attachment
>> 
>> 2) Can we use something like _( "Height" ) + ":" for translation, not _( 
>> "Height:" )? As far as I understand, now we will need to have 2 
>> translations, first for "Height" and second for "Height:" but that's 
>> basically same word.
>> 
>> Воскресенье, 21 июля 2019, 23:42 +03:00 от Dino Ghilardi
>> < dino.ghila...@ieee.org >:
>> 
>> Makes sense.
>> Instead of a generic "via count" a more complete table similar to the
>> one generated in the drill report file could be useful, but may be it
>> can became quite long if a lot of different drill sizes are used (ok,
>> scrollbars are made to handle that).
>> Also having "vias", "blind vias" and "microvias" count man make sense
>> (or at least having something like "microvias used: yes/no"), just to
>> have in board statistics the information about the need of an advanced
>> pcb manufacturing process.
>> 
>> 
>> Cheers,
>> Dino.
>> 
>> 
>> On 21/07/19 20:54, Mark Roszko wrote:
>>  > > Since making every hole in the pcb costs time,  manufacturers
>>  > calculate the price of the PCB using also that number.
>>  >
>>  > A long time ago, holes cost alot. These days if your manufacturer is
>>  > charging alot per hole, you should run far away. Usually
>> manufactuers
>>  > include 20k-40k holes in the base price per panel before they start
>>  > charging you tiny penny amounts for more in some increments of
>>  > thousands. The CNC machines these days as blazing fast at making the
>>  > holes required and they charge more for the drill bit being worn
>> down
>>  > than the time.
>>  >
>>  > What does actually cost money is via type and size. Blind vias make
>>  > layer stackups a pain in the butt and micro vias needing lasers.
>>  > And also going below some via size can significantly add cost
>> even if
>>  > not at microvia size because it requires different machines with
>> more
>>  > precision and smaller drill bits.
>>  >
>>  >
>>  > If anything I would say to break down the statistics based on via
>> type.
>>  >
>>  > On Sun, Jul 21, 2019 at 1:55 PM Dino Ghilardi
>> < dino.ghila...@ieee.org 
>>  > > wrote:
>>  >
>>  > I just tried the 

Re: [Kicad-developers] [PATCH] Board statistics dialog

[Alexander Shuklin]

Hi,
thanks for sharing experience, as I never used that translations or wxWidgets 
before. And I have no idea where else could I get that information. ))
So, there's the patch with vias information and some tiny improvements. 


>Понедельник, 22 июля 2019, 13:34 +03:00 от Ian McInerney 
>:
>
>
>
>On Mon, Jul 22, 2019 at 11:03 AM Dino Ghilardi < dino.ghila...@ieee.org > 
>wrote:
>>Hi Alexander,
>>
>>One possible solution for the translation could be put the ":" in a 
>>different column of the table and right-align the field description text 
>>(so all the colons will be aligned). A rapid google search shown that in 
>>French and Vietnamese there should be a space before the colon, while in 
>>the rest of the world there is not, so having the translation for the 
>>":" word seems to make sense. Also another question arises: Is there 
>>some language in which the colon should be another character before the 
>>word? (I'm thinking about spanish where the question mark upside-down 
>>appears before a question...)? ...conclusion: keeping "Height:" and 
>>"Height" as two different words seem to be the solution that gives 
>>maximum flexibility to translators.
>>
>
>This actually doesn't give them as much flexibility. When translations are 
>done, they need to examine the entire string that needs translating, so the 
>":" character should be included in the string. Separating out the two 
>portions is the equivalent of saying that every lanugage will follow the same 
>compositional rules.
>  
>>Another possible solution (probably better then the one above since it 
>>just removes the problem) is to remove the ":" and have the cell borders 
>>in a different color, just like the tables in the "board setup" dialog 
>>(so that you can also take a look at that code to solve also the color 
>>problem seeing how it was solved there). The advantage of this approach 
>>is also having a more consistent "look" through all the dialogs.
>>
>>
>>
>>P.S. (a little bit off-topic):
>>If you move the statistic window and check/uncheck one of the checkboxes 
>>("subctract holes" or "Exclude components...") the window "jumps" to 
>>the center of the screen (its default position on open): do you have 
>>also this behaviour or it is just on my debian-linux with gtk3?
>>
>>
>>Cheers,
>>Dino.
>>
>>On 22/07/19 10:13, Alexander Shuklin wrote:
>>> Hi!
>>> I'll have a look to add vias count to dialog.
>>> There's some questions:
>>> 
>>> 1)I don't have too much experience with wxdialogs. There was commit on 
>>> master, which says:
>>>  >> remove settings for fg/bg color: the result is unpredictable: was 
>>> black texts on black background on my computer.
>>> And now I have all tables with data just in white boxes. Is it how it 
>>> meant to be, or just some misbehavior on different systems? I use 
>>> archlinux x64 OS.
>>> there's screenshot in attachment
>>> 
>>> 2) Can we use something like _( "Height" ) + ":" for translation, not _( 
>>> "Height:" )? As far as I understand, now we will need to have 2 
>>> translations, first for "Height" and second for "Height:" but that's 
>>> basically same word.
>>> 
>>>     Воскресенье, 21 июля 2019, 23:42 +03:00 от Dino Ghilardi
>>>     < dino.ghila...@ieee.org >:
>>> 
>>>     Makes sense.
>>>     Instead of a generic "via count" a more complete table similar to the
>>>     one generated in the drill report file could be useful, but may be it
>>>     can became quite long if a lot of different drill sizes are used (ok,
>>>     scrollbars are made to handle that).
>>>     Also having "vias", "blind vias" and "microvias" count man make sense
>>>     (or at least having something like "microvias used: yes/no"), just to
>>>     have in board statistics the information about the need of an advanced
>>>     pcb manufacturing process.
>>> 
>>> 
>>>     Cheers,
>>>     Dino.
>>> 
>>> 
>>>     On 21/07/19 20:54, Mark Roszko wrote:
>>>      > > Since making every hole in the pcb costs time,  manufacturers
>>>      > calculate the price of the PCB using also that number.
>>>      >
>>>      > A long time ago, holes cost alot. These days if your manufacturer is
>>>      > charging alot per hole, you should run far away. Usually
>>>     manufactuers
>>>      > include 20k-40k holes in the base price per panel before they start
>>>      > charging you tiny penny amounts for more in some increments of
>>>      > thousands. The CNC machines these days as blazing fast at making the
>>>      > holes required and they charge more for the drill bit being worn
>>>     down
>>>      > than the time.
>>>      >
>>>      > What does actually cost money is via type and size. Blind vias make
>>>      > layer stackups a pain in the butt and micro vias needing lasers.
>>>      > And also going below some via size can significantly add cost
>>>     even if
>>>      > not at microvia size because it requires different machines with
>>>     more
>>>      > precision and smaller drill bits.
>>>      >
>>>      >
>>>      > 

Re: [Kicad-developers] [PATCH] Board statistics dialog

[Ian McInerney]

On Mon, Jul 22, 2019 at 11:03 AM Dino Ghilardi 
wrote:

> Hi Alexander,
>
> One possible solution for the translation could be put the ":" in a
> different column of the table and right-align the field description text
> (so all the colons will be aligned). A rapid google search shown that in
> French and Vietnamese there should be a space before the colon, while in
> the rest of the world there is not, so having the translation for the
> ":" word seems to make sense. Also another question arises: Is there
> some language in which the colon should be another character before the
> word? (I'm thinking about spanish where the question mark upside-down
> appears before a question...)? ...conclusion: keeping "Height:" and
> "Height" as two different words seem to be the solution that gives
> maximum flexibility to translators.
>
>
This actually doesn't give them as much flexibility. When translations are
done, they need to examine the entire string that needs translating, so the
":" character should be included in the string. Separating out the two
portions is the equivalent of saying that every lanugage will follow the
same compositional rules.


> Another possible solution (probably better then the one above since it
> just removes the problem) is to remove the ":" and have the cell borders
> in a different color, just like the tables in the "board setup" dialog
> (so that you can also take a look at that code to solve also the color
> problem seeing how it was solved there). The advantage of this approach
> is also having a more consistent "look" through all the dialogs.
>
>
>
> P.S. (a little bit off-topic):
> If you move the statistic window and check/uncheck one of the checkboxes
> ("subctract holes" or "Exclude components...") the window "jumps" to
> the center of the screen (its default position on open): do you have
> also this behaviour or it is just on my debian-linux with gtk3?
>
>
> Cheers,
> Dino.
>
> On 22/07/19 10:13, Alexander Shuklin wrote:
> > Hi!
> > I'll have a look to add vias count to dialog.
> > There's some questions:
> >
> > 1)I don't have too much experience with wxdialogs. There was commit on
> > master, which says:
> >  >> remove settings for fg/bg color: the result is unpredictable: was
> > black texts on black background on my computer.
> > And now I have all tables with data just in white boxes. Is it how it
> > meant to be, or just some misbehavior on different systems? I use
> > archlinux x64 OS.
> > there's screenshot in attachment
> >
> > 2) Can we use something like _( "Height" ) + ":" for translation, not _(
> > "Height:" )? As far as I understand, now we will need to have 2
> > translations, first for "Height" and second for "Height:" but that's
> > basically same word.
> >
> > Воскресенье, 21 июля 2019, 23:42 +03:00 от Dino Ghilardi
> > :
> >
> > Makes sense.
> > Instead of a generic "via count" a more complete table similar to the
> > one generated in the drill report file could be useful, but may be it
> > can became quite long if a lot of different drill sizes are used (ok,
> > scrollbars are made to handle that).
> > Also having "vias", "blind vias" and "microvias" count man make sense
> > (or at least having something like "microvias used: yes/no"), just to
> > have in board statistics the information about the need of an
> advanced
> > pcb manufacturing process.
> >
> >
> > Cheers,
> > Dino.
> >
> >
> > On 21/07/19 20:54, Mark Roszko wrote:
> >  > > Since making every hole in the pcb costs time,  manufacturers
> >  > calculate the price of the PCB using also that number.
> >  >
> >  > A long time ago, holes cost alot. These days if your manufacturer
> is
> >  > charging alot per hole, you should run far away. Usually
> > manufactuers
> >  > include 20k-40k holes in the base price per panel before they
> start
> >  > charging you tiny penny amounts for more in some increments of
> >  > thousands. The CNC machines these days as blazing fast at making
> the
> >  > holes required and they charge more for the drill bit being worn
> > down
> >  > than the time.
> >  >
> >  > What does actually cost money is via type and size. Blind vias
> make
> >  > layer stackups a pain in the butt and micro vias needing lasers.
> >  > And also going below some via size can significantly add cost
> > even if
> >  > not at microvia size because it requires different machines with
> > more
> >  > precision and smaller drill bits.
> >  >
> >  >
> >  > If anything I would say to break down the statistics based on via
> > type.
> >  >
> >  > On Sun, Jul 21, 2019 at 1:55 PM Dino Ghilardi
> > mailto:dino.ghila...@ieee.org>
> >  > > wrote:
> >  >
> >  > I just tried the board statistics dialog and looks good, I like
> it.
> >  >
> >  > A thing I'd like to have to make it better 

Re: [Kicad-developers] [PATCH] Board statistics dialog

[Dino Ghilardi]

Hi Alexander,

One possible solution for the translation could be put the ":" in a 
different column of the table and right-align the field description text 
(so all the colons will be aligned). A rapid google search shown that in 
French and Vietnamese there should be a space before the colon, while in 
the rest of the world there is not, so having the translation for the 
":" word seems to make sense. Also another question arises: Is there 
some language in which the colon should be another character before the 
word? (I'm thinking about spanish where the question mark upside-down 
appears before a question...)? ...conclusion: keeping "Height:" and 
"Height" as two different words seem to be the solution that gives 
maximum flexibility to translators.


Another possible solution (probably better then the one above since it 
just removes the problem) is to remove the ":" and have the cell borders 
in a different color, just like the tables in the "board setup" dialog 
(so that you can also take a look at that code to solve also the color 
problem seeing how it was solved there). The advantage of this approach 
is also having a more consistent "look" through all the dialogs.




P.S. (a little bit off-topic):
If you move the statistic window and check/uncheck one of the checkboxes 
("subctract holes" or "Exclude components...") the window "jumps" to 
the center of the screen (its default position on open): do you have 
also this behaviour or it is just on my debian-linux with gtk3?



Cheers,
Dino.

On 22/07/19 10:13, Alexander Shuklin wrote:

Hi!
I'll have a look to add vias count to dialog.
There's some questions:

1)I don't have too much experience with wxdialogs. There was commit on 
master, which says:
 >> remove settings for fg/bg color: the result is unpredictable: was 
black texts on black background on my computer.
And now I have all tables with data just in white boxes. Is it how it 
meant to be, or just some misbehavior on different systems? I use 
archlinux x64 OS.

there's screenshot in attachment

2) Can we use something like _( "Height" ) + ":" for translation, not _( 
"Height:" )? As far as I understand, now we will need to have 2 
translations, first for "Height" and second for "Height:" but that's 
basically same word.


Воскресенье, 21 июля 2019, 23:42 +03:00 от Dino Ghilardi
:

Makes sense.
Instead of a generic "via count" a more complete table similar to the
one generated in the drill report file could be useful, but may be it
can became quite long if a lot of different drill sizes are used (ok,
scrollbars are made to handle that).
Also having "vias", "blind vias" and "microvias" count man make sense
(or at least having something like "microvias used: yes/no"), just to
have in board statistics the information about the need of an advanced
pcb manufacturing process.


Cheers,
Dino.


On 21/07/19 20:54, Mark Roszko wrote:
 > > Since making every hole in the pcb costs time,  manufacturers
 > calculate the price of the PCB using also that number.
 >
 > A long time ago, holes cost alot. These days if your manufacturer is
 > charging alot per hole, you should run far away. Usually
manufactuers
 > include 20k-40k holes in the base price per panel before they start
 > charging you tiny penny amounts for more in some increments of
 > thousands. The CNC machines these days as blazing fast at making the
 > holes required and they charge more for the drill bit being worn
down
 > than the time.
 >
 > What does actually cost money is via type and size. Blind vias make
 > layer stackups a pain in the butt and micro vias needing lasers.
 > And also going below some via size can significantly add cost
even if
 > not at microvia size because it requires different machines with
more
 > precision and smaller drill bits.
 >
 >
 > If anything I would say to break down the statistics based on via
type.
 >
 > On Sun, Jul 21, 2019 at 1:55 PM Dino Ghilardi
mailto:dino.ghila...@ieee.org>
 > > wrote:
 >
 > I just tried the board statistics dialog and looks good, I like it.
 >
 > A thing I'd like to have to make it better is adding the number
of vias
 > to the statistics: Since making every hole in the pcb costs time,
 > manufacturers calculate the price of the PCB using also that number.
 >
 > Also the option to save or print a text with the statistics report
 > would
 > be nice.
 >
 >
 > Cheers,
 > Dino.
 >

___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net

Unsubscribe : https://launchpad.net/~kicad-developers
More help : https://help.launchpad.net/ListHelp



--
Alexander Shuklin

Re: [Kicad-developers] [PATCH] Board statistics dialog

[jp charras]

Le 22/07/2019 à 10:13, Alexander Shuklin a écrit :
> Hi!
> I'll have a look to add vias count to dialog.
> There's some questions:
> 
> 1)I don't have too much experience with wxdialogs. There was commit on
> master, which says:
>>> remove settings for fg/bg color: the result is unpredictable: was
> black texts on black background on my computer.
> And now I have all tables with data just in white boxes. Is it how it
> meant to be, or just some misbehavior on different systems? I use
> archlinux x64 OS.
> there's screenshot in attachment

Colors and fonts in dialogs depend on Window Managers, selected themes,
selected fonts ... on the user computer.

We already have issues in dialogs when forcing colors and/or fonts.
So a golden rule is to avoid forcing fonts and colors when not mandatory.

On my computer, the initial colors selection give me just a black box
for the full dialog.

> 
> 2) Can we use something like _( "Height" ) + ":" for translation, not _(
> "Height:" )? As far as I understand, now we will need to have 2
> translations, first for "Height" and second for "Height:" but that's
> basically same word.
> 

An other golden rule is *never* create a string by concatenation of words:
- One can translate a full sentence, but usually not a list of
concatenated words: the translation is never a word to word change.
- Are you sure "Height" and "Height:" are basically the same word
("Height" + ":") in any language in any context?

-- 
Jean-Pierre CHARRAS

___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] [PATCH] Board statistics dialog

[Alexander Shuklin]

Hi!
I'll have a look to add vias count to dialog.
There's some questions:

1)I don't have too much experience with wxdialogs. There was commit on master, 
which says: 
>> remove settings for fg/bg color: the result is unpredictable: was black 
>> texts on black background on my computer. 
And now I have all tables with data just in white boxes. Is it how it meant to 
be, or just some misbehavior on different systems? I use archlinux x64 OS.
there's screenshot in attachment

2) Can we use something like  _ (  " Height " ) + ":" for translation, not  _ ( 
 " Height: " )? As far as I understand, now we will need to have 2 
translations, first for "Height" and second for "Height:" but that's basically 
same word.

>Воскресенье, 21 июля 2019, 23:42 +03:00 от Dino Ghilardi 
>:
>
>Makes sense.
>Instead of a generic "via count" a more complete table similar to the 
>one generated in the drill report file could be useful, but may be it 
>can became quite long if a lot of different drill sizes are used (ok, 
>scrollbars are made to handle that).
>Also having "vias", "blind vias" and "microvias" count man make sense 
>(or at least having something like "microvias used: yes/no"), just to 
>have in board statistics the information about the need of an advanced 
>pcb manufacturing process.
>
>
>Cheers,
>Dino.
>
>
>On 21/07/19 20:54, Mark Roszko wrote:
>>  > Since making every hole in the pcb costs time,  manufacturers 
>> calculate the price of the PCB using also that number.
>> 
>> A long time ago, holes cost alot. These days if your manufacturer is 
>> charging alot per hole, you should run far away. Usually manufactuers 
>> include 20k-40k holes in the base price per panel before they start 
>> charging you tiny penny amounts for more in some increments of 
>> thousands. The CNC machines these days as blazing fast at making the 
>> holes required and they charge more for the drill bit being worn down 
>> than the time.
>> 
>> What does actually cost money is via type and size. Blind vias make 
>> layer stackups a pain in the butt and micro vias needing lasers.
>> And also going below some via size can significantly add cost even if 
>> not at microvia size because it requires different machines with more 
>> precision and smaller drill bits.
>> 
>> 
>> If anything I would say to break down the statistics based on via type.
>> 
>> On Sun, Jul 21, 2019 at 1:55 PM Dino Ghilardi < dino.ghila...@ieee.org
>> > wrote:
>> 
>> I just tried the board statistics dialog and looks good, I like it.
>> 
>> A thing I'd like to have to make it better is adding the number of vias
>> to the statistics: Since making every hole in the pcb costs time,
>> manufacturers calculate the price of the PCB using also that number.
>> 
>> Also the option to save or print a text with the statistics report
>> would
>> be nice.
>> 
>> 
>> Cheers,
>> Dino.
>> 
>
>___
>Mailing list:  https://launchpad.net/~kicad-developers
>Post to :  kicad-developers@lists.launchpad.net
>Unsubscribe :  https://launchpad.net/~kicad-developers
>More help   :  https://help.launchpad.net/ListHelp


-- 
Alexander Shuklin
___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] [PATCH] Board statistics dialog

[Dino Ghilardi]

Makes sense.
Instead of a generic "via count" a more complete table similar to the 
one generated in the drill report file could be useful, but may be it 
can became quite long if a lot of different drill sizes are used (ok, 
scrollbars are made to handle that).
Also having "vias", "blind vias" and "microvias" count man make sense 
(or at least having something like "microvias used: yes/no"), just to 
have in board statistics the information about the need of an advanced 
pcb manufacturing process.



Cheers,
Dino.


On 21/07/19 20:54, Mark Roszko wrote:
 > Since making every hole in the pcb costs time,  manufacturers 
calculate the price of the PCB using also that number.


A long time ago, holes cost alot. These days if your manufacturer is 
charging alot per hole, you should run far away. Usually manufactuers 
include 20k-40k holes in the base price per panel before they start 
charging you tiny penny amounts for more in some increments of 
thousands. The CNC machines these days as blazing fast at making the 
holes required and they charge more for the drill bit being worn down 
than the time.


What does actually cost money is via type and size. Blind vias make 
layer stackups a pain in the butt and micro vias needing lasers.
And also going below some via size can significantly add cost even if 
not at microvia size because it requires different machines with more 
precision and smaller drill bits.



If anything I would say to break down the statistics based on via type.

On Sun, Jul 21, 2019 at 1:55 PM Dino Ghilardi > wrote:


I just tried the board statistics dialog and looks good, I like it.

A thing I'd like to have to make it better is adding the number of vias
to the statistics: Since making every hole in the pcb costs time,
manufacturers calculate the price of the PCB using also that number.

Also the option to save or print a text with the statistics report
would
be nice.


Cheers,
Dino.



___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] [PATCH] Board statistics dialog

[Mark Roszko]

> Since making every hole in the pcb costs time,  manufacturers calculate
the price of the PCB using also that number.

A long time ago, holes cost alot. These days if your manufacturer is
charging alot per hole, you should run far away. Usually manufactuers
include 20k-40k holes in the base price per panel before they start
charging you tiny penny amounts for more in some increments of thousands.
The CNC machines these days as blazing fast at making the holes required
and they charge more for the drill bit being worn down than the time.

What does actually cost money is via type and size. Blind vias make layer
stackups a pain in the butt and micro vias needing lasers.
And also going below some via size can significantly add cost even if not
at microvia size because it requires different machines with more precision
and smaller drill bits.


If anything I would say to break down the statistics based on via type.

On Sun, Jul 21, 2019 at 1:55 PM Dino Ghilardi 
wrote:

> I just tried the board statistics dialog and looks good, I like it.
>
> A thing I'd like to have to make it better is adding the number of vias
> to the statistics: Since making every hole in the pcb costs time,
> manufacturers calculate the price of the PCB using also that number.
>
> Also the option to save or print a text with the statistics report would
> be nice.
>
>
> Cheers,
> Dino.
>
> On 20/07/19 20:48, Jeff Young wrote:
> > Hi Alex,
> >
> > Looks good.  I’m going to go ahead and merge it and follow it up with a
> > commit to make the GUI look a little better on MacOS.  I’ll send another
> > reply when they’re pushed to master.
> >
> > Cheers,
> > Jeff.
> >
> >
> >> On 17 Jul 2019, at 23:45, Alexander Shuklin  >> > wrote:
> >>
> >>
> >> Hi Jeff,
> >> Have a nice flight. I found one more:
> >> there's issue with menu item capitalization as well, so that will be
> >> in the pcb_actions.cpp
> >>
> >> +//Show board statistics tool
> >> +TOOL_ACTION PCB_ACTIONS::boardStatistics(
> >> "pcbnew.InspectionTool.ShowStatisticsDialog", AS_GLOBAL,
> >> +0, LEGACY_HK_NAME( "Show Board Statistics" ), _( "Show Board
> >> Statistics" ),
> >> +_( "Shows board statistics" ), pcbnew_xpm );
> >> +
> >>
> >>
> https://github.com/jasuramme/kicad-source-mirror/commit/9d6061d5df63ee59f0c285cbe990cb7464e6f1da
> >>
> >> Среда, 17 июля 2019, 23:56 +03:00 от Jeff Young  >> >:
> >>
> >> Hi Alex,
> >>
> >> I’m about to go on vacation myself so I’ll be on a plane all day
> >> tomorrow, but I’ll look at this when I get there.
> >>
> >> Cheers,
> >> Jeff.
> >>
> >>
> >>> On 17 Jul 2019, at 19:06, Alexander Shuklin  >>> >
> >>> wrote:
> >>>
> >>> Hi Jeff,
> >>>
> >>> That's not a problem. Now I'm on 2 weeks vacation ))
> >>> We don't use header capitalization in russian language, so it's
> >>> sometimes confuses me.
> >>> All done. You can find changed commit on github if you want.
> >>>
> >>>
> https://github.com/jasuramme/kicad-source-mirror/commit/6ce77c20ff479f2fa4f1af9ba4e8d7f93d2ee1e5
> >>>
> >>> And patch in the attachment below.
> >>>
> >>> Best regards,
> >>> Alex
> >>>
> >>> Среда, 17 июля 2019, 15:18 +03:00 от Jeff Young
> >>>  >>> >:
> >>>
> >>> Hi Alex,
> >>>
> >>> No need for apologies.  It’s a steep learning curve.
> >>>
> >>> Some more comments:
> >>>
> >>> 1) Dialog items use sentence-capitalization and colons;
> >>> dialog headers use title-capitalization and no colons.  So
> >>> “Components:” should be “Components”, “Front side:” should be
> >>> “Front Side”, etc.
> >>>
> >>> 2) Right-align the StdButtonSizer (and give it right and left
> >>> margins).
> >>>
> >>> 3) I don’t think this ever made it into the coding
> >>> guidelines, but we prefer ctor initializers each on their own
> >>> line (with the colon on the line above):
> >>>
> >>> padsType_t( PAD_ATTR_T aAttribute, wxString aTitle ) :
> >>> attribute( aAttribute ),
> >>> title( aTitle ),
> >>> qty( 0 )
> >>>
> >>> 4) And yes, I would space-align the inspectMenu->AddItem
> >>> calls that the Git checker messed up.
> >>>
> >>> If you don’t have time to make these fixes just holler and I
> >>> can do it.
> >>>
> >>> Cheers,
> >>> Jeff.
> >>>
> >>>
>  On 17 Jul 2019, at 12:47, Alexander Shuklin
>   wrote:
> 
>  Hi,
>  I'm very sorry. I know, that's stupid, but it takes so much
>  time to get myself familiar with kicad code
>  If it's not too late, can you look for newer patch, not one
>  I sent this morning? Of course, I can make commit on top of
>  it, but I think it doesn't make sense
>  There only few changes, such as
>    

Re: [Kicad-developers] [PATCH] Board statistics dialog

[Dino Ghilardi]

I just tried the board statistics dialog and looks good, I like it.

A thing I'd like to have to make it better is adding the number of vias 
to the statistics: Since making every hole in the pcb costs time, 
manufacturers calculate the price of the PCB using also that number.


Also the option to save or print a text with the statistics report would 
be nice.



Cheers,
Dino.

On 20/07/19 20:48, Jeff Young wrote:

Hi Alex,

Looks good.  I’m going to go ahead and merge it and follow it up with a 
commit to make the GUI look a little better on MacOS.  I’ll send another 
reply when they’re pushed to master.


Cheers,
Jeff.


On 17 Jul 2019, at 23:45, Alexander Shuklin > wrote:



Hi Jeff,
Have a nice flight. I found one more:
there's issue with menu item capitalization as well, so that will be 
in the pcb_actions.cpp


+//Show board statistics tool
+TOOL_ACTION PCB_ACTIONS::boardStatistics( 
"pcbnew.InspectionTool.ShowStatisticsDialog", AS_GLOBAL,
+    0, LEGACY_HK_NAME( "Show Board Statistics" ), _( "Show Board 
Statistics" ),

+    _( "Shows board statistics" ), pcbnew_xpm );
+

https://github.com/jasuramme/kicad-source-mirror/commit/9d6061d5df63ee59f0c285cbe990cb7464e6f1da

Среда, 17 июля 2019, 23:56 +03:00 от Jeff Young mailto:j...@rokeby.ie>>:

Hi Alex,

I’m about to go on vacation myself so I’ll be on a plane all day
tomorrow, but I’ll look at this when I get there.

Cheers,
Jeff.



On 17 Jul 2019, at 19:06, Alexander Shuklin >
wrote:

Hi Jeff,

That's not a problem. Now I'm on 2 weeks vacation ))
We don't use header capitalization in russian language, so it's
sometimes confuses me.
All done. You can find changed commit on github if you want.


https://github.com/jasuramme/kicad-source-mirror/commit/6ce77c20ff479f2fa4f1af9ba4e8d7f93d2ee1e5

And patch in the attachment below.

Best regards,
Alex

Среда, 17 июля 2019, 15:18 +03:00 от Jeff Young
>:

Hi Alex,

No need for apologies.  It’s a steep learning curve.

Some more comments:

1) Dialog items use sentence-capitalization and colons;
dialog headers use title-capitalization and no colons.  So
“Components:” should be “Components”, “Front side:” should be
“Front Side”, etc.

2) Right-align the StdButtonSizer (and give it right and left
margins).

3) I don’t think this ever made it into the coding
guidelines, but we prefer ctor initializers each on their own
line (with the colon on the line above):

        padsType_t( PAD_ATTR_T aAttribute, wxString aTitle ) :
                attribute( aAttribute ),
title( aTitle ),
qty( 0 )

4) And yes, I would space-align the inspectMenu->AddItem
calls that the Git checker messed up.

If you don’t have time to make these fixes just holler and I
can do it.

Cheers,
Jeff.



On 17 Jul 2019, at 12:47, Alexander Shuklin
 wrote:

Hi,
I'm very sorry. I know, that's stupid, but it takes so much
time to get myself familiar with kicad code
If it's not too late, can you look for newer patch, not one
I sent this morning? Of course, I can make commit on top of
it, but I think it doesn't make sense
There only few changes, such as
- code formatting
- I usedFinishDialogSettings() instead of just Fit() as
written in KiCad documentation
- I changed tool name for
"pcbnew.InspectionTool.ShowStatisticsDialog" so it would
correspond to PCB_INSPECTION_TOOL::ShowStatisticsDialog method
- And I changed wxString ( _( "some string " ) ) to just _(
"some string" )
That's link to github:

https://github.com/jasuramme/kicad-source-mirror/commit/7846cc554fa13c27159d6b1ba4693ac96707c559
and patch uploaded to this mail
Sorry for that, but I've just understood that, during
further doxygen documentation reading

Среда, 17 июля 2019, 9:01 +03:00 от Alexander Shuklin
:

Hi!
Sorry for delay, there to much to do for my primary job.
I hope that code will be alright.
That's commit on the github:

https://github.com/jasuramme/kicad-source-mirror/commit/9f9ff463ac679dd79a85a88c9b4156dcec05b337

There's one thing. Git coding standards checkers writes
following

+++ b/pcbnew/menubar_pcb_editor.cpp
@@ -436,7 +436,7 @@ void PCB_EDIT_FRAME::ReCreateMenuBar()

 inspectMenu->AddItem(
PCB_ACTIONS::listNets,
SELECTION_CONDITIONS::ShowAlways );

 inspectMenu->AddItem(
ACTIONS::measureTool, 
SELECTION_CONDITIONS::ShowAlways );

-    inspectMenu->AddItem(
 

Re: [Kicad-developers] [PATCH] Board statistics dialog

[Jeff Young]

Hi Alex,

Looks good.  I’m going to go ahead and merge it and follow it up with a commit 
to make the GUI look a little better on MacOS.  I’ll send another reply when 
they’re pushed to master.

Cheers,
Jeff.


> On 17 Jul 2019, at 23:45, Alexander Shuklin  wrote:
> 
> 
> Hi Jeff,
> Have a nice flight. I found one more:
> there's issue with menu item capitalization as well, so that will be in the 
> pcb_actions.cpp
> 
> +//Show board statistics tool
> +TOOL_ACTION PCB_ACTIONS::boardStatistics( 
> "pcbnew.InspectionTool.ShowStatisticsDialog", AS_GLOBAL,
> +0, LEGACY_HK_NAME( "Show Board Statistics" ), _( "Show Board 
> Statistics" ),
> +_( "Shows board statistics" ), pcbnew_xpm );
> +
> 
> https://github.com/jasuramme/kicad-source-mirror/commit/9d6061d5df63ee59f0c285cbe990cb7464e6f1da
>  
> 
> 
> Среда, 17 июля 2019, 23:56 +03:00 от Jeff Young :
> 
> Hi Alex,
> 
> I’m about to go on vacation myself so I’ll be on a plane all day tomorrow, 
> but I’ll look at this when I get there.
> 
> Cheers,
> Jeff.
> 
> 
>> On 17 Jul 2019, at 19:06, Alexander Shuklin > > wrote:
>> 
>> Hi Jeff,
>> 
>> That's not a problem. Now I'm on 2 weeks vacation ))
>> We don't use header capitalization in russian language, so it's sometimes 
>> confuses me.
>> All done. You can find changed commit on github if you want. 
>> 
>> https://github.com/jasuramme/kicad-source-mirror/commit/6ce77c20ff479f2fa4f1af9ba4e8d7f93d2ee1e5
>>  
>> 
>>  
>> 
>> And patch in the attachment below.
>> 
>> Best regards,
>> Alex
>> 
>> Среда, 17 июля 2019, 15:18 +03:00 от Jeff Young > >:
>> 
>> Hi Alex,
>> 
>> No need for apologies.  It’s a steep learning curve.
>> 
>> Some more comments:
>> 
>> 1) Dialog items use sentence-capitalization and colons; dialog headers use 
>> title-capitalization and no colons.  So “Components:” should be 
>> “Components”, “Front side:” should be “Front Side”, etc.
>> 
>> 2) Right-align the StdButtonSizer (and give it right and left margins).
>> 
>> 3) I don’t think this ever made it into the coding guidelines, but we prefer 
>> ctor initializers each on their own line (with the colon on the line above):
>> 
>> padsType_t( PAD_ATTR_T aAttribute, wxString aTitle ) :
>> attribute( aAttribute ), 
>>  title( aTitle ), 
>>  qty( 0 )
>> 
>> 4) And yes, I would space-align the inspectMenu->AddItem calls that the Git 
>> checker messed up.
>> 
>> If you don’t have time to make these fixes just holler and I can do it.
>> 
>> Cheers,
>> Jeff.
>> 
>> 
>>> On 17 Jul 2019, at 12:47, Alexander Shuklin > wrote:
>>> 
>>> Hi,
>>> I'm very sorry. I know, that's stupid, but it takes so much time to get 
>>> myself familiar with kicad code
>>> If it's not too late, can you look for newer patch, not one I sent this 
>>> morning? Of course, I can make commit on top of it, but I think it doesn't 
>>> make sense
>>> There only few changes, such as
>>> - code formatting
>>> - I used   <>FinishDialogSettings() instead of just Fit() as written in 
>>> KiCad documentation
>>> - I changed tool name for "pcbnew.InspectionTool.ShowStatisticsDialog" so 
>>> it would correspond to PCB_INSPECTION_TOOL::ShowStatisticsDialog method
>>> - And I changed wxString ( _( "some string " ) ) to just _( "some string" )
>>> That's link to github:
>>> https://github.com/jasuramme/kicad-source-mirror/commit/7846cc554fa13c27159d6b1ba4693ac96707c559
>>>  
>>> 
>>>  
>>> and patch uploaded to this mail
>>> Sorry for that, but I've just understood that, during further doxygen 
>>> documentation reading
>>> Среда, 17 июля 2019, 9:01 +03:00 от Alexander Shuklin >> <>>:
>>> 
>>> Hi!
>>> Sorry for delay, there to much to do for my primary job.
>>> I hope that code will be alright.
>>> That's commit on the github:
>>> https://github.com/jasuramme/kicad-source-mirror/commit/9f9ff463ac679dd79a85a88c9b4156dcec05b337
>>>  
>>> 
>>>  
>>> There's one thing. Git coding standards checkers writes following
>>> 
>>> +++ b/pcbnew/menubar_pcb_editor.cpp
>>> @@ -436,7 +436,7 @@ void PCB_EDIT_FRAME::ReCreateMenuBar()
>>>  
>>>  inspectMenu->AddItem( PCB_ACTIONS::listNets, 
>>> SELECTION_CONDITIONS::ShowAlways );
>>>  inspectMenu->AddItem( ACTIONS::measureTool,  
>>> SELECTION_CONDITIONS::ShowAlways );
>>> -inspectMenu->AddItem( PCB_ACTIONS::boardStatistics,  
>>> SELECTION_CONDITIONS::ShowAlways );
>>> +inspectMenu->AddItem( PCB_ACTIONS::boardStatistics, 
>>> SELECTION_CONDITIONS::ShowAlways );
>>> 
>>> 
>>> 
>>> But I would leave whitespaces, for better code looking as all functions 
>>> around use it

Re: [Kicad-developers] [PATCH] Board statistics dialog

[Jeff Young]

Hi Alex,

I’m about to go on vacation myself so I’ll be on a plane all day tomorrow, but 
I’ll look at this when I get there.

Cheers,
Jeff.


> On 17 Jul 2019, at 19:06, Alexander Shuklin  wrote:
> 
> Hi Jeff,
> 
> That's not a problem. Now I'm on 2 weeks vacation ))
> We don't use header capitalization in russian language, so it's sometimes 
> confuses me.
> All done. You can find changed commit on github if you want. 
> 
> https://github.com/jasuramme/kicad-source-mirror/commit/6ce77c20ff479f2fa4f1af9ba4e8d7f93d2ee1e5
>  
> 
>  
> 
> And patch in the attachment below.
> 
> Best regards,
> Alex
> 
> Среда, 17 июля 2019, 15:18 +03:00 от Jeff Young :
> 
> Hi Alex,
> 
> No need for apologies.  It’s a steep learning curve.
> 
> Some more comments:
> 
> 1) Dialog items use sentence-capitalization and colons; dialog headers use 
> title-capitalization and no colons.  So “Components:” should be “Components”, 
> “Front side:” should be “Front Side”, etc.
> 
> 2) Right-align the StdButtonSizer (and give it right and left margins).
> 
> 3) I don’t think this ever made it into the coding guidelines, but we prefer 
> ctor initializers each on their own line (with the colon on the line above):
> 
> padsType_t( PAD_ATTR_T aAttribute, wxString aTitle ) :
> attribute( aAttribute ), 
>   title( aTitle ), 
>   qty( 0 )
> 
> 4) And yes, I would space-align the inspectMenu->AddItem calls that the Git 
> checker messed up.
> 
> If you don’t have time to make these fixes just holler and I can do it.
> 
> Cheers,
> Jeff.
> 
> 
>> On 17 Jul 2019, at 12:47, Alexander Shuklin > > wrote:
>> 
>> Hi,
>> I'm very sorry. I know, that's stupid, but it takes so much time to get 
>> myself familiar with kicad code
>> If it's not too late, can you look for newer patch, not one I sent this 
>> morning? Of course, I can make commit on top of it, but I think it doesn't 
>> make sense
>> There only few changes, such as
>> - code formatting
>> - I used   <>FinishDialogSettings() instead of just Fit() as written in 
>> KiCad documentation
>> - I changed tool name for "pcbnew.InspectionTool.ShowStatisticsDialog" so it 
>> would correspond to PCB_INSPECTION_TOOL::ShowStatisticsDialog method
>> - And I changed wxString ( _( "some string " ) ) to just _( "some string" )
>> That's link to github:
>> https://github.com/jasuramme/kicad-source-mirror/commit/7846cc554fa13c27159d6b1ba4693ac96707c559
>>  
>> 
>>  
>> and patch uploaded to this mail
>> Sorry for that, but I've just understood that, during further doxygen 
>> documentation reading
>> Среда, 17 июля 2019, 9:01 +03:00 от Alexander Shuklin > >:
>> 
>> Hi!
>> Sorry for delay, there to much to do for my primary job.
>> I hope that code will be alright.
>> That's commit on the github:
>> https://github.com/jasuramme/kicad-source-mirror/commit/9f9ff463ac679dd79a85a88c9b4156dcec05b337
>>  
>> 
>>  
>> There's one thing. Git coding standards checkers writes following
>> 
>> +++ b/pcbnew/menubar_pcb_editor.cpp
>> @@ -436,7 +436,7 @@ void PCB_EDIT_FRAME::ReCreateMenuBar()
>>  
>>  inspectMenu->AddItem( PCB_ACTIONS::listNets, 
>> SELECTION_CONDITIONS::ShowAlways );
>>  inspectMenu->AddItem( ACTIONS::measureTool,  
>> SELECTION_CONDITIONS::ShowAlways );
>> -inspectMenu->AddItem( PCB_ACTIONS::boardStatistics,  
>> SELECTION_CONDITIONS::ShowAlways );
>> +inspectMenu->AddItem( PCB_ACTIONS::boardStatistics, 
>> SELECTION_CONDITIONS::ShowAlways );
>> 
>> 
>> 
>> But I would leave whitespaces, for better code looking as all functions 
>> around use it
>> 
>> 
>> 
>> Понедельник, 8 июля 2019, 17:03 +03:00 от Jeff Young > >:
>> 
>> Hi Alex,
>> 
>> Have a look at the second half of 
>> DIALOG_GLOBAL_EDIT_TEXT_AND_GRAPHICS::TransferDataToWindow().  That code 
>> builds a read-only grid.  You could  then have columns for Top, Bottom, and 
>> Total.
>> 
>> (BTW, I think we use Front/Back nomenclature rather than Top/Bottom.)
>> 
>> Cheers,
>> Jeff.
>> 
>> 
>>> On 8 Jul 2019, at 13:48, Alexander Shuklin >> > wrote:
>>> 
>>> Hi Jeff,
>>> that bug reports are some job to do)
>>> 
>>> Well, reason why I went up with that top-side/bottom-side checkboxes is if 
>>> you will want to count let's say SMD components on the bottom side, you can 
>>> manage it with setting top one off. I'm not sure, how important it is. On 
>>> the another hand, we could write down something like: 
>>> THT components: top: 15, bottom: 32, total: 47
>>> SMD components: top: 14, bottom: 31, total: 45
>>> But that would be ugly as well.
>>> 
>>> If there would be more options and more components properties, 

Re: [Kicad-developers] [PATCH] Board statistics dialog

[Jeff Young]

Hi Alex,

No need for apologies.  It’s a steep learning curve.

Some more comments:

1) Dialog items use sentence-capitalization and colons; dialog headers use 
title-capitalization and no colons.  So “Components:” should be “Components”, 
“Front side:” should be “Front Side”, etc.

2) Right-align the StdButtonSizer (and give it right and left margins).

3) I don’t think this ever made it into the coding guidelines, but we prefer 
ctor initializers each on their own line (with the colon on the line above):

padsType_t( PAD_ATTR_T aAttribute, wxString aTitle ) :
attribute( aAttribute ), 
title( aTitle ), 
qty( 0 )

4) And yes, I would space-align the inspectMenu->AddItem calls that the Git 
checker messed up.

If you don’t have time to make these fixes just holler and I can do it.

Cheers,
Jeff.


> On 17 Jul 2019, at 12:47, Alexander Shuklin  wrote:
> 
> Hi,
> I'm very sorry. I know, that's stupid, but it takes so much time to get 
> myself familiar with kicad code
> If it's not too late, can you look for newer patch, not one I sent this 
> morning? Of course, I can make commit on top of it, but I think it doesn't 
> make sense
> There only few changes, such as
> - code formatting
> - I used   <>FinishDialogSettings() instead of just Fit() as written in KiCad 
> documentation
> - I changed tool name for "pcbnew.InspectionTool.ShowStatisticsDialog" so it 
> would correspond to PCB_INSPECTION_TOOL::ShowStatisticsDialog method
> - And I changed wxString ( _( "some string " ) ) to just _( "some string" )
> That's link to github:
> https://github.com/jasuramme/kicad-source-mirror/commit/7846cc554fa13c27159d6b1ba4693ac96707c559
>  
> 
>  
> and patch uploaded to this mail
> Sorry for that, but I've just understood that, during further doxygen 
> documentation reading
> Среда, 17 июля 2019, 9:01 +03:00 от Alexander Shuklin :
> 
> Hi!
> Sorry for delay, there to much to do for my primary job.
> I hope that code will be alright.
> That's commit on the github:
> https://github.com/jasuramme/kicad-source-mirror/commit/9f9ff463ac679dd79a85a88c9b4156dcec05b337
>  
> 
>  
> There's one thing. Git coding standards checkers writes following
> 
> +++ b/pcbnew/menubar_pcb_editor.cpp
> @@ -436,7 +436,7 @@ void PCB_EDIT_FRAME::ReCreateMenuBar()
>  
>  inspectMenu->AddItem( PCB_ACTIONS::listNets, 
> SELECTION_CONDITIONS::ShowAlways );
>  inspectMenu->AddItem( ACTIONS::measureTool,  
> SELECTION_CONDITIONS::ShowAlways );
> -inspectMenu->AddItem( PCB_ACTIONS::boardStatistics,  
> SELECTION_CONDITIONS::ShowAlways );
> +inspectMenu->AddItem( PCB_ACTIONS::boardStatistics, 
> SELECTION_CONDITIONS::ShowAlways );
> 
> 
> 
> But I would leave whitespaces, for better code looking as all functions 
> around use it
> 
> 
> 
> Понедельник, 8 июля 2019, 17:03 +03:00 от Jeff Young  >:
> 
> Hi Alex,
> 
> Have a look at the second half of 
> DIALOG_GLOBAL_EDIT_TEXT_AND_GRAPHICS::TransferDataToWindow().  That code 
> builds a read-only grid.  You could  then have columns for Top, Bottom, and 
> Total.
> 
> (BTW, I think we use Front/Back nomenclature rather than Top/Bottom.)
> 
> Cheers,
> Jeff.
> 
> 
>> On 8 Jul 2019, at 13:48, Alexander Shuklin > > wrote:
>> 
>> Hi Jeff,
>> that bug reports are some job to do)
>> 
>> Well, reason why I went up with that top-side/bottom-side checkboxes is if 
>> you will want to count let's say SMD components on the bottom side, you can 
>> manage it with setting top one off. I'm not sure, how important it is. On 
>> the another hand, we could write down something like: 
>> THT components: top: 15, bottom: 32, total: 47
>> SMD components: top: 14, bottom: 31, total: 45
>> But that would be ugly as well.
>> 
>> If there would be more options and more components properties, maybe better 
>> to write all data to wxTextCtrl then? Just in big text field, which you 
>> could copy. And that will be easy to change and expand.
>> 
>> Понедельник, 8 июля 2019, 14:24 +03:00 от Jeff Young > >:
>> 
>> Hi Alex,
>> 
>> I don’t like the top-side/bottom-side checkboxes (because I want to see both 
>> numbers at once), but I do like the other three.
>> 
>> I think we need to move to a list or grid presentation, though.  One of the 
>> other features we’ve talked about is user-defined attributes, so there might 
>> be more things than just THT, SMD and Virtual.
>> 
>> Cheers,
>> Jeff.
>> 
>> [1] https://bugs.launchpad.net/kicad/+bug/1789363 
>> 
>> [2] https://bugs.launchpad.net/kicad/+bug/980919 
>>  
>> 

Re: [Kicad-developers] [PATCH] Board statistics dialog

[Jeff Young]

Hi Alex,

I don’t like the top-side/bottom-side checkboxes (because I want to see both 
numbers at once), but I do like the other three.

I think we need to move to a list or grid presentation, though.  One of the 
other features we’ve talked about is user-defined attributes, so there might be 
more things than just THT, SMD and Virtual.

Cheers,
Jeff.

[1] https://bugs.launchpad.net/kicad/+bug/1789363 

[2] https://bugs.launchpad.net/kicad/+bug/980919 
 



> On 8 Jul 2019, at 11:20, Alexander Shuklin  wrote:
> 
> Hi!, I added stuff for footprints THT,SMD,virtual properties and now it's 
> calculate area.
> But for me dialog is not very straight forward now. Can you please advice, 
> what better to do?
> I attached 2 pics. I think, maybe right way is to add few checkboxes which 
> will change dialog data as soon as you pressed them?
> Just look at pics and say what would be better, as I'm in doubt.
> Second one is in WxFormBuilder so it looks a bit different.
> 
> 
> Пятница, 5 июля 2019, 0:05 +03:00 от Jeff Young :
> 
> I agree that it shouldn’t be its own tool, but PCB_EDITOR_CONTROL is getting 
> too big.
> 
> Let’s just name this tool the PCB_INSPECTION_TOOL, and then I’ll move the 
> highlight and list nets stuff, and the DRC dialog to it later.  That’ll 
> nicely parallel the EE_INSPECTION_TOOL.
> 
> Cheers,
> Jeff.
> 
>> On 4 Jul 2019, at 21:56, Ian McInerney > > wrote:
>> 
>> This looks nice, but a few comments from my initial usage of it:
>> 
>> Usability:
>> 1) When I use english units, your statistics dialog gives the dimensions in 
>> mils. It should probably give those in inches instead, since that is what 
>> the grid panel at the bottom gives.
>> 2) Including the board area would also be useful, definitely the area of the 
>> bounding box, and possibly the area of the actual PCB (but that is more 
>> complicated). I know of several board houses that charge based on area, so 
>> this could provide a quick way to estimate price for the user.
>> 3) I am not sure I am a fan of the icon used for the menu item, since this 
>> dialog focuses on board statistics rather than footprint statistics and that 
>> icon is used mainly for footprint actions. Could a variant of the pcbnew 
>> icon be used?
>> 
>> 
>> While the code as you gave works, I think the following changes could be 
>> beneficial:
>> 1) It seems that this action could just be added to PCB_EDITOR_CONTROL as 
>> the action "pcbnew.Control.BoardStatistics" rather than creating a new tool 
>> just for this.
>> 2) I think the launching of the window could be simplified if you used a 
>> modal window instead (see https://docs.wxwidgets.org/3.0/classwx_dialog.html 
>> , the Modal and Modeless 
>> section). Then you don't have to keep track of the window pointer, and could 
>> actually just make launching this a single function instead of an entire 
>> class (this would go nicely with point #1).
>> 3) The function to start the window should be TransferDataToWindow, not 
>> TransferDataFromWindow. FromWindow is called when the window is destroyed 
>> and ToWindow is called when it is created. Also, it is called automatically 
>> when the window is started, so there is no need to manually call it.
>> 
>> 
>> Other code parts:
>> 1) There are some lines that are too long in dialog_board_statistics.cpp 
>> (max 100 characters per line)
>> 2) There are a few whitespace errors when applying it:
>> Applying: added board statistics dialog, which shows info for production and 
>> assembly
>> /home/imcinerney/Downloads/0001-added-board-statistics-dialog-which-shows-info-for-p.patch:158:
>>  trailing whitespace.
>> /* if pin has drill with width==0 and height==0, we 
>> /home/imcinerney/Downloads/0001-added-board-statistics-dialog-which-shows-info-for-p.patch:1612:
>>  new blank line at EOF.
>> +
>> warning: 2 lines add whitespace errors.
>> 
>> Overall though it looks pretty nice.
>> 
>> -Ian
>> 
>> On Thu, Jul 4, 2019 at 3:07 PM Шуклин Александр > > wrote:
>> Hi, that's first time I try to contribute to KiCad and write to Launchpad 
>> mailing lists, so please, don't beat me to hard )))
>> I really miss some board statistic dialog, where you can see quantity of SMD 
>> pads, THT pads, board dimensions, all the stuff, you need for PCB production 
>> and assembly. There was also issue in the bug tracker 
>> https://bugs.launchpad.net/kicad/+bug/1817232 
>> 
>> And like guy from bug issue, I moved from Altium Designer and miss that 
>> dialog as well. 
>> Can you please look at that and commit if you think it's useful or tell me 
>> what to change.
>> That's my commit in the github:
>> https://github.com/jasuramme/kicad-source-mirror/commit/6290375c1d41ddb89d4b08067593f170c7d344c5
>>  
>> 

Re: [Kicad-developers] [PATCH] Board statistics dialog

[Alexander Shuklin]

Hi!, I added stuff for footprints THT,SMD,virtual properties and now it's 
calculate area.
But for me dialog is not very straight forward now. Can you please advice, what 
better to do?
I attached 2 pics. I think, maybe right way is to add few checkboxes which will 
change dialog data as soon as you pressed them?
Just look at pics and say what would be better, as I'm in doubt.
Second one is in WxFormBuilder so it looks a bit different.


>Пятница,  5 июля 2019, 0:05 +03:00 от Jeff Young :
>
>I agree that it shouldn’t be its own tool, but PCB_EDITOR_CONTROL is getting 
>too big.
>
>Let’s just name this tool the PCB_INSPECTION_TOOL, and then I’ll move the 
>highlight and list nets stuff, and the DRC dialog to it later.  That’ll nicely 
>parallel the EE_INSPECTION_TOOL.
>
>Cheers,
>Jeff.
>
>>On 4 Jul 2019, at 21:56, Ian McInerney < ian.s.mciner...@ieee.org > wrote:
>>This looks nice, but a few comments from my initial usage of it:
>>
>>Usability:
>>1) When I use english units, your statistics dialog gives the dimensions in 
>>mils. It should probably give those in inches instead, since that is what the 
>>grid panel at the bottom gives.
>>2) Including the board area would also be useful, definitely the area of the 
>>bounding box, and possibly the area of the actual PCB (but that is more 
>>complicated). I know of several board houses that charge based on area, so 
>>this could provide a quick way to estimate price for the user.
>>3) I am not sure I am a fan of the icon used for the menu item, since this 
>>dialog focuses on board statistics rather than footprint statistics and that 
>>icon is used mainly for footprint actions. Could a variant of the pcbnew icon 
>>be used?
>>
>>
>>While the code as you gave works, I think the following changes could be 
>>beneficial:
>>1) It seems that this action could just be added to PCB_EDITOR_CONTROL as the 
>>action "pcbnew.Control.BoardStatistics" rather than creating a new tool just 
>>for this.
>>2) I think the launching of the window could be simplified if you used a 
>>modal window instead (see  https://docs.wxwidgets.org/3.0/classwx_dialog.html 
>>, the Modal and Modeless section). Then you don't have to keep track of the 
>>window pointer, and could actually just make launching this a single function 
>>instead of an entire class (this would go nicely with point #1).
>>3) The function to start the window should be TransferDataToWindow, not 
>>TransferDataFromWindow. FromWindow is called when the window is destroyed and 
>>ToWindow is called when it is created. Also, it is called automatically when 
>>the window is started, so there is no need to manually call it.
>>
>>
>>Other code parts:
>>1) There are some lines that are too long in dialog_board_statistics.cpp (max 
>>100 characters per line)
>>2) There are a few whitespace errors when applying it:
>>Applying: added board statistics dialog, which shows info for production and 
>>assembly
>>/home/imcinerney/Downloads/0001-added-board-statistics-dialog-which-shows-info-for-p.patch:158:
>> trailing whitespace.
>>                /* if pin has drill with width==0 and height==0, we 
>>/home/imcinerney/Downloads/0001-added-board-statistics-dialog-which-shows-info-for-p.patch:1612:
>> new blank line at EOF.
>>+
>>warning: 2 lines add whitespace errors.
>>
>>Overall though it looks pretty nice.
>>
>>-Ian
>>On Thu, Jul 4, 2019 at 3:07 PM Шуклин Александр < jasura...@mail.ru > wrote:
>>>Hi, that's first time I try to contribute to KiCad and write to Launchpad 
>>>mailing lists, so please, don't beat me to hard )))
>>>I really miss some board statistic dialog, where you can see quantity of SMD 
>>>pads, THT pads, board dimensions, all the stuff, you need for PCB production 
>>>and assembly. There was also issue in the bug tracker 
>>>https://bugs.launchpad.net/kicad/+bug/1817232
>>>And like guy from bug issue, I moved from Altium Designer and miss that 
>>>dialog as well. 
>>>Can you please look at that and commit if you think it's useful or tell me 
>>>what to change.
>>>That's my commit in the github:
>>>https://github.com/jasuramme/kicad-source-mirror/commit/6290375c1d41ddb89d4b08067593f170c7d344c5
>>>and branch:
>>>https://github.com/jasuramme/kicad-source-mirror/tree/statistic_dialog
>>>and there's also patch and dialogs pics in the attachment.
>>>
>>>___
>>>Mailing list:  https://launchpad.net/~kicad-developers
>>>Post to     :  kicad-developers@lists.launchpad.net
>>>Unsubscribe :  https://launchpad.net/~kicad-developers
>>>More help   :  https://help.launchpad.net/ListHelp
>>___
>>Mailing list:  https://launchpad.net/~kicad-developers
>>Post to :  kicad-developers@lists.launchpad.net
>>Unsubscribe :  https://launchpad.net/~kicad-developers
>>More help   :  https://help.launchpad.net/ListHelp
>


-- 
Alexander Shuklin
___
Mailing list: https://launchpad.net/~kicad-developers
Post 

Re: [Kicad-developers] [PATCH] Board statistics dialog

[Jeff Young]

Hi Alex,

Yes, MessageTextFromValue() is what you want.  (There’s also StringFromValue(), 
but that produces very exact numbers to prevent round-off errors so they’re 
much less human-readable.)

Use ShowModal(), not ShowQuasiModal().  ShowQuasiModal() is a bit of a hack for 
modal dialogs which can spawn non-modal frames.

Cheers,
Jeff.


> On 5 Jul 2019, at 08:52, Alexander Shuklin  wrote:
> 
> Hi All!
> Jeff,
> I don't think, it should have it's own tool either ))) But I couldn't realize 
> by myself, where to put it. No problems, I will rename to PCB_INSPECTION_TOOL.
> 
> Ian,
> 1) I will look at that. To be honest, I don't know much about imperial units 
> ) But I think that's some parameter in MessageTextFromValue, which will do 
> the trick. I will check that.
> 2) hm... I will think what we can do.
> 3) I cannot switch on Icons in any menus just now O_o. Anyway, I will change 
> icon
> 
> About modal dialog. isn't better to use DIALOG_SHIM::ShowQuasiModal()?
> 
> I'll take some time to change that stuff )))
> 
> 
> 
> Пятница, 5 июля 2019, 0:05 +03:00 от Jeff Young :
> 
> I agree that it shouldn’t be its own tool, but PCB_EDITOR_CONTROL is getting 
> too big.
> 
> Let’s just name this tool the PCB_INSPECTION_TOOL, and then I’ll move the 
> highlight and list nets stuff, and the DRC dialog to it later.  That’ll 
> nicely parallel the EE_INSPECTION_TOOL.
> 
> Cheers,
> Jeff.
> 
>> On 4 Jul 2019, at 21:56, Ian McInerney > > wrote:
>> 
>> This looks nice, but a few comments from my initial usage of it:
>> 
>> Usability:
>> 1) When I use english units, your statistics dialog gives the dimensions in 
>> mils. It should probably give those in inches instead, since that is what 
>> the grid panel at the bottom gives.
>> 2) Including the board area would also be useful, definitely the area of the 
>> bounding box, and possibly the area of the actual PCB (but that is more 
>> complicated). I know of several board houses that charge based on area, so 
>> this could provide a quick way to estimate price for the user.
>> 3) I am not sure I am a fan of the icon used for the menu item, since this 
>> dialog focuses on board statistics rather than footprint statistics and that 
>> icon is used mainly for footprint actions. Could a variant of the pcbnew 
>> icon be used?
>> 
>> 
>> While the code as you gave works, I think the following changes could be 
>> beneficial:
>> 1) It seems that this action could just be added to PCB_EDITOR_CONTROL as 
>> the action "pcbnew.Control.BoardStatistics" rather than creating a new tool 
>> just for this.
>> 2) I think the launching of the window could be simplified if you used a 
>> modal window instead (see https://docs.wxwidgets.org/3.0/classwx_dialog.html 
>> , the Modal and Modeless 
>> section). Then you don't have to keep track of the window pointer, and could 
>> actually just make launching this a single function instead of an entire 
>> class (this would go nicely with point #1).
>> 3) The function to start the window should be TransferDataToWindow, not 
>> TransferDataFromWindow. FromWindow is called when the window is destroyed 
>> and ToWindow is called when it is created. Also, it is called automatically 
>> when the window is started, so there is no need to manually call it.
>> 
>> 
>> Other code parts:
>> 1) There are some lines that are too long in dialog_board_statistics.cpp 
>> (max 100 characters per line)
>> 2) There are a few whitespace errors when applying it:
>> Applying: added board statistics dialog, which shows info for production and 
>> assembly
>> /home/imcinerney/Downloads/0001-added-board-statistics-dialog-which-shows-info-for-p.patch:158:
>>  trailing whitespace.
>> /* if pin has drill with width==0 and height==0, we 
>> /home/imcinerney/Downloads/0001-added-board-statistics-dialog-which-shows-info-for-p.patch:1612:
>>  new blank line at EOF.
>> +
>> warning: 2 lines add whitespace errors.
>> 
>> Overall though it looks pretty nice.
>> 
>> -Ian
>> 
>> On Thu, Jul 4, 2019 at 3:07 PM Шуклин Александр > > wrote:
>> Hi, that's first time I try to contribute to KiCad and write to Launchpad 
>> mailing lists, so please, don't beat me to hard )))
>> I really miss some board statistic dialog, where you can see quantity of SMD 
>> pads, THT pads, board dimensions, all the stuff, you need for PCB production 
>> and assembly. There was also issue in the bug tracker 
>> https://bugs.launchpad.net/kicad/+bug/1817232 
>> 
>> And like guy from bug issue, I moved from Altium Designer and miss that 
>> dialog as well. 
>> Can you please look at that and commit if you think it's useful or tell me 
>> what to change.
>> That's my commit in the github:
>> https://github.com/jasuramme/kicad-source-mirror/commit/6290375c1d41ddb89d4b08067593f170c7d344c5
>>  
>> 

Re: [Kicad-developers] [PATCH] Board statistics dialog

[Alexander Shuklin]

Hi All!
Jeff,
I don't think, it should have it's own tool either ))) But I couldn't realize 
by myself, where to put it. No problems, I will rename to PCB_INSPECTION_TOOL.

Ian,
1) I will look at that. To be honest, I don't know much about imperial units ) 
But I think that's some parameter in MessageTextFromValue, which will do the 
trick. I will check that.
2) hm... I will think what we can do.
3) I cannot switch on Icons in any menus just now O_o. Anyway, I will change 
icon

About modal dialog. isn't better to use DIALOG_SHIM::ShowQuasiModal()?

I'll take some time to change that stuff )))



>Пятница,  5 июля 2019, 0:05 +03:00 от Jeff Young :
>
>I agree that it shouldn’t be its own tool, but PCB_EDITOR_CONTROL is getting 
>too big.
>
>Let’s just name this tool the PCB_INSPECTION_TOOL, and then I’ll move the 
>highlight and list nets stuff, and the DRC dialog to it later.  That’ll nicely 
>parallel the EE_INSPECTION_TOOL.
>
>Cheers,
>Jeff.
>
>>On 4 Jul 2019, at 21:56, Ian McInerney < ian.s.mciner...@ieee.org > wrote:
>>This looks nice, but a few comments from my initial usage of it:
>>
>>Usability:
>>1) When I use english units, your statistics dialog gives the dimensions in 
>>mils. It should probably give those in inches instead, since that is what the 
>>grid panel at the bottom gives.
>>2) Including the board area would also be useful, definitely the area of the 
>>bounding box, and possibly the area of the actual PCB (but that is more 
>>complicated). I know of several board houses that charge based on area, so 
>>this could provide a quick way to estimate price for the user.
>>3) I am not sure I am a fan of the icon used for the menu item, since this 
>>dialog focuses on board statistics rather than footprint statistics and that 
>>icon is used mainly for footprint actions. Could a variant of the pcbnew icon 
>>be used?
>>
>>
>>While the code as you gave works, I think the following changes could be 
>>beneficial:
>>1) It seems that this action could just be added to PCB_EDITOR_CONTROL as the 
>>action "pcbnew.Control.BoardStatistics" rather than creating a new tool just 
>>for this.
>>2) I think the launching of the window could be simplified if you used a 
>>modal window instead (see  https://docs.wxwidgets.org/3.0/classwx_dialog.html 
>>, the Modal and Modeless section). Then you don't have to keep track of the 
>>window pointer, and could actually just make launching this a single function 
>>instead of an entire class (this would go nicely with point #1).
>>3) The function to start the window should be TransferDataToWindow, not 
>>TransferDataFromWindow. FromWindow is called when the window is destroyed and 
>>ToWindow is called when it is created. Also, it is called automatically when 
>>the window is started, so there is no need to manually call it.
>>
>>
>>Other code parts:
>>1) There are some lines that are too long in dialog_board_statistics.cpp (max 
>>100 characters per line)
>>2) There are a few whitespace errors when applying it:
>>Applying: added board statistics dialog, which shows info for production and 
>>assembly
>>/home/imcinerney/Downloads/0001-added-board-statistics-dialog-which-shows-info-for-p.patch:158:
>> trailing whitespace.
>>                /* if pin has drill with width==0 and height==0, we 
>>/home/imcinerney/Downloads/0001-added-board-statistics-dialog-which-shows-info-for-p.patch:1612:
>> new blank line at EOF.
>>+
>>warning: 2 lines add whitespace errors.
>>
>>Overall though it looks pretty nice.
>>
>>-Ian
>>On Thu, Jul 4, 2019 at 3:07 PM Шуклин Александр < jasura...@mail.ru > wrote:
>>>Hi, that's first time I try to contribute to KiCad and write to Launchpad 
>>>mailing lists, so please, don't beat me to hard )))
>>>I really miss some board statistic dialog, where you can see quantity of SMD 
>>>pads, THT pads, board dimensions, all the stuff, you need for PCB production 
>>>and assembly. There was also issue in the bug tracker 
>>>https://bugs.launchpad.net/kicad/+bug/1817232
>>>And like guy from bug issue, I moved from Altium Designer and miss that 
>>>dialog as well. 
>>>Can you please look at that and commit if you think it's useful or tell me 
>>>what to change.
>>>That's my commit in the github:
>>>https://github.com/jasuramme/kicad-source-mirror/commit/6290375c1d41ddb89d4b08067593f170c7d344c5
>>>and branch:
>>>https://github.com/jasuramme/kicad-source-mirror/tree/statistic_dialog
>>>and there's also patch and dialogs pics in the attachment.
>>>
>>>___
>>>Mailing list:  https://launchpad.net/~kicad-developers
>>>Post to     :  kicad-developers@lists.launchpad.net
>>>Unsubscribe :  https://launchpad.net/~kicad-developers
>>>More help   :  https://help.launchpad.net/ListHelp
>>___
>>Mailing list:  https://launchpad.net/~kicad-developers
>>Post to :  kicad-developers@lists.launchpad.net
>>Unsubscribe :  https://launchpad.net/~kicad-developers
>>More help   :  

Re: [Kicad-developers] [PATCH] Board statistics dialog

[Шуклин Александр]

Hi! 
Sorry for delay in my answer, I have 2 small kids and sometimes there's no time 
for everything.
Do I answer just to  kicad-developers@lists.launchpad.net , right?
Mario, Shuklin is my surname. Name is Alex)))
I will try to do what you are asking for. Do you mean "count" components, not 
list them? I mean, do you want to get count of surface mount, through hole and 
virtual footprints? That's shouldn't be a problem.
As far as I understand, modules in pcbnew file doesn't hold data about 
components. For example, I don't think I can count unique components (only 
unique footprints) without pulling data from schematic file.
Maurice, that was my message on forum) But indeed I've seen some similar 
questions.
I will keep you informed, when I add that to the patch.

>Четверг,  4 июля 2019, 22:33 +03:00 от ea...@katamail.com:
>
>Hi,
>nice addition indeed...
>You may find someone with the same needs at the forum
>https://forum.kicad.info/t/how-to-get-pin-count-and-board-size-for-assembly/17792
>There is a small plugin offering this option ATM, 
>listing what Mario is asking for...
>It would be nice to have it in the main branch.
>Maurice
>Il 04.07.2019 16:28 Mário Luzeiro ha scritto:
>>Hi SHuklin! ( is this the romanization of your name? :) )
>>
>>This is just my user feedback:
>>That is a cool addition, another feature suggestions would be to list the 
>>components by "Fabrication attributes" "Through hole"/"Surface 
>>mount"/"Virtual" Each footprint has this attribute so I guess you can easily 
>>count it.
>>They are important values for calculation costs of the assembly.
>>
>>Mario Luzeiro
>>
>>________
>>From: Kicad-developers 
>> on behalf of 
>>Шуклин Александр 
>>Sent: 04 July 2019 15:06
>>To: kicad-developers@lists.launchpad.net
>>Subject: [Kicad-developers] [PATCH] Board statistics dialog
>>
>>Hi, that's first time I try to contribute to KiCad and write to Launchpad 
>>mailing lists, so please, don't beat me to hard )))
>>I really miss some board statistic dialog, where you can see quantity of SMD 
>>pads, THT pads, board dimensions, all the stuff, you need for PCB production 
>>and assembly. There was also issue in the bug tracker
>>https://bugs.launchpad.net/kicad/+bug/1817232
>>And like guy from bug issue, I moved from Altium Designer and miss that 
>>dialog as well.
>>Can you please look at that and commit if you think it's useful or tell me 
>>what to change.
>>That's my commit in the github:
>>https://github.com/jasuramme/kicad-source-mirror/commit/6290375c1d41ddb89d4b08067593f170c7d344c5
>>and branch:
>>https://github.com/jasuramme/kicad-source-mirror/tree/statistic_dialog
>>and there's also patch and dialogs pics in the attachment.
>>
>>___
>>Mailing list: https://launchpad.net/~kicad-developers
>>Post to : kicad-developers@lists.launchpad.net
>>Unsubscribe : https://launchpad.net/~kicad-developers
>>More help   : https://help.launchpad.net/ListHelp
>>
>
>
>Con Mobile Open 7 GB a 9 euro/4 sett navighi veloce con 7 GB di Internet e hai 
>200 minuti ed SMS a 15 cent. Passa a Tiscali Mobile!  
>http://tisca.li/Open7GB0617
>
>___
>Mailing list:  https://launchpad.net/~kicad-developers
>Post to :  kicad-developers@lists.launchpad.net
>Unsubscribe :  https://launchpad.net/~kicad-developers
>More help   :  https://help.launchpad.net/ListHelp


-- 
Шуклин Александр
___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] [PATCH] Board statistics dialog

[Jeff Young]

I agree that it shouldn’t be its own tool, but PCB_EDITOR_CONTROL is getting 
too big.

Let’s just name this tool the PCB_INSPECTION_TOOL, and then I’ll move the 
highlight and list nets stuff, and the DRC dialog to it later.  That’ll nicely 
parallel the EE_INSPECTION_TOOL.

Cheers,
Jeff.

> On 4 Jul 2019, at 21:56, Ian McInerney  wrote:
> 
> This looks nice, but a few comments from my initial usage of it:
> 
> Usability:
> 1) When I use english units, your statistics dialog gives the dimensions in 
> mils. It should probably give those in inches instead, since that is what the 
> grid panel at the bottom gives.
> 2) Including the board area would also be useful, definitely the area of the 
> bounding box, and possibly the area of the actual PCB (but that is more 
> complicated). I know of several board houses that charge based on area, so 
> this could provide a quick way to estimate price for the user.
> 3) I am not sure I am a fan of the icon used for the menu item, since this 
> dialog focuses on board statistics rather than footprint statistics and that 
> icon is used mainly for footprint actions. Could a variant of the pcbnew icon 
> be used?
> 
> 
> While the code as you gave works, I think the following changes could be 
> beneficial:
> 1) It seems that this action could just be added to PCB_EDITOR_CONTROL as the 
> action "pcbnew.Control.BoardStatistics" rather than creating a new tool just 
> for this.
> 2) I think the launching of the window could be simplified if you used a 
> modal window instead (see https://docs.wxwidgets.org/3.0/classwx_dialog.html 
> , the Modal and Modeless 
> section). Then you don't have to keep track of the window pointer, and could 
> actually just make launching this a single function instead of an entire 
> class (this would go nicely with point #1).
> 3) The function to start the window should be TransferDataToWindow, not 
> TransferDataFromWindow. FromWindow is called when the window is destroyed and 
> ToWindow is called when it is created. Also, it is called automatically when 
> the window is started, so there is no need to manually call it.
> 
> 
> Other code parts:
> 1) There are some lines that are too long in dialog_board_statistics.cpp (max 
> 100 characters per line)
> 2) There are a few whitespace errors when applying it:
> Applying: added board statistics dialog, which shows info for production and 
> assembly
> /home/imcinerney/Downloads/0001-added-board-statistics-dialog-which-shows-info-for-p.patch:158:
>  trailing whitespace.
> /* if pin has drill with width==0 and height==0, we 
> /home/imcinerney/Downloads/0001-added-board-statistics-dialog-which-shows-info-for-p.patch:1612:
>  new blank line at EOF.
> +
> warning: 2 lines add whitespace errors.
> 
> Overall though it looks pretty nice.
> 
> -Ian
> 
> On Thu, Jul 4, 2019 at 3:07 PM Шуклин Александр  > wrote:
> Hi, that's first time I try to contribute to KiCad and write to Launchpad 
> mailing lists, so please, don't beat me to hard )))
> I really miss some board statistic dialog, where you can see quantity of SMD 
> pads, THT pads, board dimensions, all the stuff, you need for PCB production 
> and assembly. There was also issue in the bug tracker 
> https://bugs.launchpad.net/kicad/+bug/1817232 
> 
> And like guy from bug issue, I moved from Altium Designer and miss that 
> dialog as well. 
> Can you please look at that and commit if you think it's useful or tell me 
> what to change.
> That's my commit in the github:
> https://github.com/jasuramme/kicad-source-mirror/commit/6290375c1d41ddb89d4b08067593f170c7d344c5
>  
> 
> and branch:
> https://github.com/jasuramme/kicad-source-mirror/tree/statistic_dialog 
> 
> and there's also patch and dialogs pics in the attachment.
> 
> ___
> Mailing list: https://launchpad.net/~kicad-developers 
> 
> Post to : kicad-developers@lists.launchpad.net 
> 
> Unsubscribe : https://launchpad.net/~kicad-developers 
> 
> More help   : https://help.launchpad.net/ListHelp 
> 
> ___
> Mailing list: https://launchpad.net/~kicad-developers
> Post to : kicad-developers@lists.launchpad.net
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp

___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help 

Re: [Kicad-developers] [PATCH] Board statistics dialog

[Ian McInerney]

This looks nice, but a few comments from my initial usage of it:

Usability:
1) When I use english units, your statistics dialog gives the dimensions in
mils. It should probably give those in inches instead, since that is what
the grid panel at the bottom gives.
2) Including the board area would also be useful, definitely the area of
the bounding box, and possibly the area of the actual PCB (but that is more
complicated). I know of several board houses that charge based on area, so
this could provide a quick way to estimate price for the user.
3) I am not sure I am a fan of the icon used for the menu item, since this
dialog focuses on board statistics rather than footprint statistics and
that icon is used mainly for footprint actions. Could a variant of the
pcbnew icon be used?


While the code as you gave works, I think the following changes could be
beneficial:
1) It seems that this action could just be added to PCB_EDITOR_CONTROL as
the action "pcbnew.Control.BoardStatistics" rather than creating a new tool
just for this.
2) I think the launching of the window could be simplified if you used a
modal window instead (see https://docs.wxwidgets.org/3.0/classwx_dialog.html,
the Modal and Modeless section). Then you don't have to keep track of the
window pointer, and could actually just make launching this a single
function instead of an entire class (this would go nicely with point #1).
3) The function to start the window should be TransferDataToWindow, not
TransferDataFromWindow. FromWindow is called when the window is destroyed
and ToWindow is called when it is created. Also, it is called automatically
when the window is started, so there is no need to manually call it.


Other code parts:
1) There are some lines that are too long in dialog_board_statistics.cpp
(max 100 characters per line)
2) There are a few whitespace errors when applying it:
Applying: added board statistics dialog, which shows info for production
and assembly
/home/imcinerney/Downloads/0001-added-board-statistics-dialog-which-shows-info-for-p.patch:158:
trailing whitespace.
/* if pin has drill with width==0 and height==0, we
/home/imcinerney/Downloads/0001-added-board-statistics-dialog-which-shows-info-for-p.patch:1612:
new blank line at EOF.
+
warning: 2 lines add whitespace errors.

Overall though it looks pretty nice.

-Ian

On Thu, Jul 4, 2019 at 3:07 PM Шуклин Александр  wrote:

> Hi, that's first time I try to contribute to KiCad and write to Launchpad
> mailing lists, so please, don't beat me to hard )))
> I really miss some board statistic dialog, where you can see quantity of
> SMD pads, THT pads, board dimensions, all the stuff, you need for PCB
> production and assembly. There was also issue in the bug tracker
> https://bugs.launchpad.net/kicad/+bug/1817232
> And like guy from bug issue, I moved from Altium Designer and miss that
> dialog as well.
> Can you please look at that and commit if you think it's useful or tell me
> what to change.
> That's my commit in the github:
>
> https://github.com/jasuramme/kicad-source-mirror/commit/6290375c1d41ddb89d4b08067593f170c7d344c5
> and branch:
> https://github.com/jasuramme/kicad-source-mirror/tree/statistic_dialog
> and there's also patch and dialogs pics in the attachment.
>
> ___
> Mailing list: https://launchpad.net/~kicad-developers
> Post to : kicad-developers@lists.launchpad.net
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp
>
___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] [PATCH] Board statistics dialog

[easyw]

  
Hi, 
nice addition indeed... 
You may find someone with the same
needs at the forum

https://forum.kicad.info/t/how-to-get-pin-count-and-board-size-for-assembly/17792

There is a small plugin offering this option ATM,  
listing what Mario
is asking for... 
It would be nice to have it in the main branch.

Maurice 

Il 04.07.2019 16:28 Mário Luzeiro ha scritto: 

> Hi SHuklin!
( is this the romanization of your name? :) )
> 
> This is just my user
feedback:
> That is a cool addition, another feature suggestions would
be to list the components by "Fabrication attributes" "Through
hole"/"Surface mount"/"Virtual" Each footprint has this attribute so I
guess you can easily count it.
> They are important values for
calculation costs of the assembly.
> 
> Mario Luzeiro
> 
>

> From: Kicad-developers on
behalf of Шуклин Александр 
> Sent: 04 July 2019 15:06
> To:
kicad-developers@lists.launchpad.net [3]
> Subject: [Kicad-developers]
[PATCH] Board statistics dialog
> 
> Hi, that's first time I try to
contribute to KiCad and write to Launchpad mailing lists, so please,
don't beat me to hard )))
> I really miss some board statistic dialog,
where you can see quantity of SMD pads, THT pads, board dimensions, all
the stuff, you need for PCB production and assembly. There was also
issue in the bug tracker
> https://bugs.launchpad.net/kicad/+bug/1817232
[4]
> And like guy from bug issue, I moved from Altium Designer and miss
that dialog as well.
> Can you please look at that and commit if you
think it's useful or tell me what to change.
> That's my commit in the
github:
>
https://github.com/jasuramme/kicad-source-mirror/commit/6290375c1d41ddb89d4b08067593f170c7d344c5
[5]
> and branch:
>
https://github.com/jasuramme/kicad-source-mirror/tree/statistic_dialog
[6]
> and there's also patch and dialogs pics in the attachment.
> 
>
___
> Mailing list:
https://launchpad.net/~kicad-developers [7]
> Post to :
kicad-developers@lists.launchpad.net [8]
> Unsubscribe :
https://launchpad.net/~kicad-developers [9]
> More help :
https://help.launchpad.net/ListHelp [10]
  


Con Mobile Open 7 GB a 9 euro/4 sett navighi veloce con 7 GB di Internet e hai 
200 minuti ed SMS a 15 cent. Passa a Tiscali Mobile! http://tisca.li/Open7GB0617

___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] [PATCH] Board statistics dialog

[Mário Luzeiro]

Hi SHuklin! ( is this the romanization of your name? :) )

This is just my user feedback:
That is a cool addition, another feature suggestions would be to list the 
components by "Fabrication attributes" "Through hole"/"Surface mount"/"Virtual" 
Each footprint has this attribute so I guess you can easily count it.
They are important values for calculation costs of the assembly.

Mario Luzeiro


From: Kicad-developers 
 on behalf of 
Шуклин Александр 
Sent: 04 July 2019 15:06
To: kicad-developers@lists.launchpad.net
Subject: [Kicad-developers] [PATCH] Board statistics dialog

Hi, that's first time I try to contribute to KiCad and write to Launchpad 
mailing lists, so please, don't beat me to hard )))
I really miss some board statistic dialog, where you can see quantity of SMD 
pads, THT pads, board dimensions, all the stuff, you need for PCB production 
and assembly. There was also issue in the bug tracker
https://bugs.launchpad.net/kicad/+bug/1817232
And like guy from bug issue, I moved from Altium Designer and miss that dialog 
as well.
Can you please look at that and commit if you think it's useful or tell me what 
to change.
That's my commit in the github:
https://github.com/jasuramme/kicad-source-mirror/commit/6290375c1d41ddb89d4b08067593f170c7d344c5
and branch:
https://github.com/jasuramme/kicad-source-mirror/tree/statistic_dialog
and there's also patch and dialogs pics in the attachment.

___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp