[Koha-bugs] [Bug 9783] can hit submit twice when adding patrons
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9783 David Cook dc...@prosentient.com.au changed: What|Removed |Added Status|NEW |Needs Signoff Assignee|koha-b...@lists.koha-commun |dc...@prosentient.com.au |ity.org | --- Comment #1 from David Cook dc...@prosentient.com.au --- Created attachment 16010 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=16010action=edit Bug 9783 - can hit submit twice when adding patrons Currently, clicking twice or more on the Save button will generate duplicate patrons when adding patrons in the Patron module. Of course, there is handling that detects this, so you can choose to either edit the original record (i.e. throw away the duplicate) or create a duplicate record. However, it shouldn't get to that point by clicking on the Save button. That handling seems to be there to handle cases where you go through the whole process of trying to add a new patron only to find out that they already exist in the system (or at least their username/password do). -- This patch uses the preventDoubleFormSubmit function (which is also used in holds and fines to prevent double form submits). It was also necessary to edit members.js, since check_form_borrowers was forcing form submits despite the preventDoubleFormSubmit function. I've changed it from forcing a document.form.submit to return true, which the browser will still submit the form if it's a unique borrower, but the preventDoubleFormSubmit function will still prevent multiple submits. I've also added a waiting class to staff-global.js which changes the cursor to wait (i.e. loading circle graphic). I've included an AddClass call in preventDoubleFormSubmit, so that the cursor graphic will change to show users that the page is loading so that they don't click Save again. Of course, even if they do click save again, there will only be one submit. However, this way - as Chris Cormack mentioned - the user knows that something is happening and that the form isn't broken. --- Test Plan Before applying patch... 1) Fill out the form for a new patron in the Patron module 2) Click Save several times 3) Once the page loads, you'll be shown a prompt that says that this borrower already exists. You will have the option to view the original record, edit the original record, or create a new patron anyway 4) Click on edit the existing record, and delete the patron Apply the patch 5) Repeat steps 1 and 2 6) Notice that your cursor has changed into a little loading circle graphic when you hover over the body of the page, as well as any links or any inputs/buttons of the type submit within that form 7) Notice that no matter how many times you press the button, the form is not re-submitted. Eventually you will be taken to the new patron's record (no mention of duplication will occur) Ta da! Multiple form submits are prevented and the loading graphic signals to users that the form was submitted and that Koha is processing their data -- I understand that some people might want to change which elements are given the waiting class. I'm happy to renegotiate this as necessary. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9784] New: koha-shell missing from koha-common man page
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9784 Bug ID: 9784 Summary: koha-shell missing from koha-common man page Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Packaging Assignee: koha-bugs@lists.koha-community.org Reporter: mag...@enger.priv.no CC: ro...@catalyst.net.nz Depends on: 8878 The koha-shell command introduced by Bug 8878 should be added to the table of contents koha-common man page. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8878] koha-shell: a command to make using koha commands easier
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8878 Magnus Enger mag...@enger.priv.no changed: What|Removed |Added Blocks||9784 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7308] new column in admin/aqbudgets
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7308 Julian Maurice julian.maur...@biblibre.com changed: What|Removed |Added Attachment #9167|0 |1 is obsolete|| --- Comment #10 from Julian Maurice julian.maur...@biblibre.com --- Created attachment 16011 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=16011action=edit Bug 7308: Show ordered amount in aqbudgets.pl -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7308] new column in admin/aqbudgets
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7308 Julian Maurice julian.maur...@biblibre.com changed: What|Removed |Added Attachment #12769|0 |1 is obsolete|| --- Comment #11 from Julian Maurice julian.maur...@biblibre.com --- Created attachment 16012 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=16012action=edit Bug 7308: rework aqbudgets.pl table admin/aqbudgets.pl should have the following columns: Base-level allocated (or just Allocated) Base-level ordered Total sub-levels ordered Base-level spent Total sub-levels spent Base-level available Total sub-levels available Base-level is always calculated for one level, without children. Total sub-levels should include child funds. Available is calculated as allocated - (ordered + spent). -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7308] new column in admin/aqbudgets
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7308 Julian Maurice julian.maur...@biblibre.com changed: What|Removed |Added Status|Patch doesn't apply |Needs Signoff --- Comment #12 from Julian Maurice julian.maur...@biblibre.com --- Patches rebased on master. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8993] LDAP authentication improvements: multiple branch and transformation modules
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8993 --- Comment #17 from Julian Maurice julian.maur...@biblibre.com --- Hi Elliott, this patch is not customer-specific and is intended to be integrated into master. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5336] Acq history search
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5336 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Attachment #14213|0 |1 is obsolete|| --- Comment #24 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 16013 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=16013action=edit Bug 5336:Order search (search and UI enhancements) You can now search orders by - order status - branchcode - budget New field aqorders.orderstatus, it can contains following values: 0 = New 1 = Ordered 2 = Partial 3 = Complete 4 = Deleted New field aqorders.parent_ordernumber is added (which is mainly used by others enhancement). It allows to know the main(=parent) order for an order (if an order is partially received, Koha creates another order. But it is the same order. We want to know this information). To test: Search and check if results are consistent in histsearch.pl -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7180] Order from staged file improvements
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7180 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Attachment #15617|0 |1 is obsolete|| Attachment #15677|0 |1 is obsolete|| Attachment #15934|0 |1 is obsolete|| Attachment #15935|0 |1 is obsolete|| --- Comment #18 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 16014 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=16014action=edit Bug 7180: Order from staged file improvements Rebased and squashed patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7180] Order from staged file improvements
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7180 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8682] quick slip: renewals do not appear on quick slips
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8682 Chris Cormack ch...@bigballofwax.co.nz changed: What|Removed |Added Status|Pushed to Master|Pushed to Stable CC||ch...@bigballofwax.co.nz --- Comment #6 from Chris Cormack ch...@bigballofwax.co.nz --- Pushed to 3.10.x and 3.8.x will be 3.10.4 and 3.8.11 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8942] Translation process breaks javascript in calendar.inc
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8942 --- Comment #47 from Chris Cormack ch...@bigballofwax.co.nz --- The patches don't apply to 3.10.x or 3.8.x please rebase and submit if you wish them to be in those branches -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9663] Individual bibliographic record Save option requires export permission
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9663 Chris Cormack ch...@bigballofwax.co.nz changed: What|Removed |Added Status|Pushed to Master|Pushed to Stable CC||ch...@bigballofwax.co.nz --- Comment #7 from Chris Cormack ch...@bigballofwax.co.nz --- Pushed to 3.10.x and 3.8.x will be in 3.10.4 and 3.8.11 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5333] Undefined value stops import from z39.50
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5333 Chris Cormack ch...@bigballofwax.co.nz changed: What|Removed |Added Status|Pushed to Master|Pushed to Stable --- Comment #11 from Chris Cormack ch...@bigballofwax.co.nz --- Pushed to 3.10.x and 3.8.x will be in 3.10.4 and 3.8.11 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9520] Update default LOC Z39.50 target
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9520 Chris Cormack ch...@bigballofwax.co.nz changed: What|Removed |Added Status|Pushed to Master|Pushed to Stable CC||ch...@bigballofwax.co.nz --- Comment #12 from Chris Cormack ch...@bigballofwax.co.nz --- Pushed to 3.8.x and 3.10.x will be in 3.8.11 and 3.10.4 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9574] serials/subscription-add.pl does not work right under Plack
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9574 Chris Cormack ch...@bigballofwax.co.nz changed: What|Removed |Added Status|Pushed to Master|Pushed to Stable CC||ch...@bigballofwax.co.nz --- Comment #7 from Chris Cormack ch...@bigballofwax.co.nz --- Pushed to 3.10.x will be in 3.10.4 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8620] Barcode searching not working correctly
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8620 Chris Cormack ch...@bigballofwax.co.nz changed: What|Removed |Added Status|Pushed to Master|Pushed to Stable CC||ch...@bigballofwax.co.nz --- Comment #19 from Chris Cormack ch...@bigballofwax.co.nz --- Pushed to 3.10.x and 3.8.x will be in 3.10.4 and 3.8.11 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9656] fines.pl creating a log file should be optional
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9656 Chris Cormack ch...@bigballofwax.co.nz changed: What|Removed |Added Status|Pushed to Master|Pushed to Stable --- Comment #16 from Chris Cormack ch...@bigballofwax.co.nz --- Pushed to 3.10.x will be in 3.10.4 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9555] Template files contain single quote strings
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9555
Jonathan Druart jonathan.dru...@biblibre.com changed:
What|Removed |Added
Status|Signed Off |Passed QA
--- Comment #11 from Jonathan Druart jonathan.dru...@biblibre.com ---
QA comment:
The xt/single_quotes.t test failed before this patch
# Failed test 'Files do not contain single quotes _(' '
# at xt/single_quotes.t line 39.
# Files list:
# manage.tt: return GB_showCenter(_('Export patron cards'),
/cgi-bin/koha/patroncards/print.pl? + getstr, 700, 800);
# Looks like you failed 1 test of 1.
xt/single_quotes.t .. Dubious, test returned 1 (wstat 256, 0x100)
Failed 1/1 subtests
Now all tests pass.
Marked as Passed QA.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9555] Template files contain single quote strings
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9555 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Attachment #15988|0 |1 is obsolete|| --- Comment #12 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 16015 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=16015action=edit Bug 9555: Another template contains single quotes in a js string Signed-off-by: Kyle M Hall k...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9367] Code optimization: CheckReserves is too often called
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9367 M. de Rooy m.de.r...@rijksmuseum.nl changed: What|Removed |Added CC||m.de.r...@rijksmuseum.nl QA Contact||m.de.r...@rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9620] IncludeSeeFromInSearches ON and data in $9 subfields can break indexing
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9620 Chris Cormack ch...@bigballofwax.co.nz changed: What|Removed |Added Status|Pushed to Master|Pushed to Stable CC||ch...@bigballofwax.co.nz --- Comment #7 from Chris Cormack ch...@bigballofwax.co.nz --- Pushed to 3.10.x will be in 3.10.4 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9570] view plain not working in ccsr
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9570 Chris Cormack ch...@bigballofwax.co.nz changed: What|Removed |Added Status|Pushed to Master|Pushed to Stable CC||ch...@bigballofwax.co.nz --- Comment #6 from Chris Cormack ch...@bigballofwax.co.nz --- Pushed to 3.10.x will be in 3.10.4 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9267] Ubuntu 12.04 install docs broken
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9267 Chris Cormack ch...@bigballofwax.co.nz changed: What|Removed |Added Status|Pushed to Master|Pushed to Stable CC||ch...@bigballofwax.co.nz --- Comment #7 from Chris Cormack ch...@bigballofwax.co.nz --- Pushed to 3.10.x and 3.8.x will be in 3.10.4 and 3.8.11 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9586] Remove $ENV{DEBUG} info from Member Template
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9586 Chris Cormack ch...@bigballofwax.co.nz changed: What|Removed |Added Status|Pushed to Master|Pushed to Stable CC||ch...@bigballofwax.co.nz --- Comment #5 from Chris Cormack ch...@bigballofwax.co.nz --- Pushed to 3.8.x and 3.10.x will be in 3.8.11 and 3.10.4 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9367] Code optimization: CheckReserves is too often called
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9367
M. de Rooy m.de.r...@rijksmuseum.nl changed:
What|Removed |Added
Status|Signed Off |Failed QA
--- Comment #3 from M. de Rooy m.de.r...@rijksmuseum.nl ---
QA Comment:
This looks quite good. Code improvement! koha-qa is happy too :)
A few minor details needing some attention:
1) Circ $error-{message} = on_reserve; Should be just $error= on_reserve
2) GetReserveStatus needs some error checking to prevent warnings on
$found/$priority at the end (if there is no reserve)
3) IsAvailableForItemLevelRequest: the check GetReserveStatus($itemnumber) eq
W is replaced by $status eq Waiting or $status = Reserved
Please clarify. As I understand, AllowOnShelfHolds is OFF here. So the second
part of the check should be: AND Is it on loan or waiting (current behavior)?
You could even argue that you should test only for on loan..
Why do you add Reserved?
Please send a followup. I will gladly sign off on that..
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5336] Acq history search
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5336 --- Comment #25 from mathieu saby mathieu.s...@univ-rennes2.fr --- By the way, applying 7294 does not update the database. Pbm in updatedatabase.pl (3.09.XXX should be 3.11.XXX) M. Saby -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9367] Code optimization: CheckReserves is too often called
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9367
Jonathan Druart jonathan.dru...@biblibre.com changed:
What|Removed |Added
Status|Failed QA |Needs Signoff
--- Comment #4 from Jonathan Druart jonathan.dru...@biblibre.com ---
(In reply to comment #3)
QA Comment:
Hello Marcel,
This looks quite good. Code improvement! koha-qa is happy too :)
A few minor details needing some attention:
1) Circ $error-{message} = on_reserve; Should be just $error=
on_reserve
Yep, good catch! Will be fixed.
2) GetReserveStatus needs some error checking to prevent warnings on
$found/$priority at the end (if there is no reserve)
Will be fixed too.
3) IsAvailableForItemLevelRequest: the check GetReserveStatus($itemnumber)
eq W is replaced by $status eq Waiting or $status = Reserved
Please clarify. As I understand, AllowOnShelfHolds is OFF here. So the
second part of the check should be: AND Is it on loan or waiting (current
behavior)?
You could even argue that you should test only for on loan..
Why do you add Reserved?
You are right too, I don't find any reason. The test should only be on
Waiting.
Please send a followup. I will gladly sign off on that..
It's coming...
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9367] Code optimization: CheckReserves is too often called
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9367 --- Comment #5 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 16016 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=16016action=edit Bug 9367: Followup: Code optimization: CheckReserves is too often called -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9367] Code optimization: CheckReserves is too often called
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9367 M. de Rooy m.de.r...@rijksmuseum.nl changed: What|Removed |Added Status|Needs Signoff |Failed QA --- Comment #6 from M. de Rooy m.de.r...@rijksmuseum.nl --- There is another error too in GetReserveStatus. If you pass an itemnumber and no biblionumber, you always return undef. You should put the biblionumber stuff in the else part of the itemnumber test.. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9367] Code optimization: CheckReserves is too often called
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9367 --- Comment #7 from M. de Rooy m.de.r...@rijksmuseum.nl --- (In reply to comment #6) There is another error too in GetReserveStatus. If you pass an itemnumber and no biblionumber, you always return undef. You should put the biblionumber stuff in the else part of the itemnumber test.. Do this not too literally :) You will understand hopefully. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9785] New: Add new facet
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9785 Bug ID: 9785 Summary: Add new facet Classification: Unclassified Change sponsored?: --- Product: Koha Version: 3.6 Hardware: All OS: Linux Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleon...@myacpl.org Reporter: hend.eler...@bibalex.org I can't add new facet to the facets lists. Is there a capability to set facets configuration ?? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9367] Code optimization: CheckReserves is too often called
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9367
--- Comment #8 from M. de Rooy m.de.r...@rijksmuseum.nl ---
This should work including testing uninitialized:
if ( $itemnumber ) {
$sth = $dbh-prepare(SELECT found, priority FROM reserves WHERE
itemnumber = ? order by priority LIMIT 1);
$sth-execute($itemnumber);
($found, $priority) = $sth-fetchrow_array;
}
if ( $biblionumber and not defined $found and not defined $priority ) {
$sth = $dbh-prepare(SELECT found, priority FROM reserves WHERE
biblionumber = ? order by priority LIMIT 1);
$sth-execute($biblionumber);
($found, $priority) = $sth-fetchrow_array;
}
return if not defined $found;
etc.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7294] status in order
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7294 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Attachment #14918|0 |1 is obsolete|| --- Comment #51 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 16017 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=16017action=edit Bug 7294: Adds acquisition informations in marc record View status 'in order' to the OPAC and staff interface. Specific fields from aqorders can be mapped to marc fields (using ACQ bibliographic framework): aqorders.branchcode aqorders.quantity aqorders.listprice aqorders.uncertainprice aqorders.rrp aqorders.ecost aqorders.notes aqorders.supplierreference aqorders.ordernumber This way, you can keep track on what is currently on order at biblio level until you receive everything. Once all items have been received, the marc field is deleted. Please note that mapping the ordernumber is mandatory for this feature to work Signed-off-by: Kyle M Hall k...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9367] Code optimization: CheckReserves is too often called
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9367 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Attachment #16016|0 |1 is obsolete|| --- Comment #9 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 16018 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=16018action=edit Bug 9367: Followup: Code optimization: CheckReserves is too often called -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9367] Code optimization: CheckReserves is too often called
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9367 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Status|Failed QA |Needs Signoff --- Comment #10 from Jonathan Druart jonathan.dru...@biblibre.com --- The last patch fixes all your comments. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8952] Add http:// to url in social media links on opac-detail
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8952 M. de Rooy m.de.r...@rijksmuseum.nl changed: What|Removed |Added QA Contact||m.de.r...@rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8952] Add http:// to url in social media links on opac-detail
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8952 M. de Rooy m.de.r...@rijksmuseum.nl changed: What|Removed |Added Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8952] Add http:// to url in social media links on opac-detail
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8952 M. de Rooy m.de.r...@rijksmuseum.nl changed: What|Removed |Added Attachment #14291|0 |1 is obsolete|| Attachment #14614|0 |1 is obsolete|| --- Comment #11 from M. de Rooy m.de.r...@rijksmuseum.nl --- Created attachment 16019 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=16019action=edit Bug 8952 - Add http:// to url in social media links on opac-detail This patch adds a variable to the template, protocol based on whether using_https is set. The appropriate protocol is inserted before social media links. To test, confirm that OPACBaseURL is set and lacks http(s):// Social media links should include correct URLs. A follow-up patch could copy use of this [% protocol %] variable in other parts of this template which duplicate large chunks of HTML based on [% using_https %]. Signed-off-by: Marcel de Rooy m.de.r...@rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8952] Add http:// to url in social media links on opac-detail
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8952 --- Comment #12 from M. de Rooy m.de.r...@rijksmuseum.nl --- Created attachment 16020 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=16020action=edit Bug 8952: Followup: Change all occurrences of using_https Signed-off-by: Corey Fuimaono agent@gmail.com Verified. Signed-off-by: Marcel de Rooy m.de.r...@rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8952] Add http:// to url in social media links on opac-detail
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8952 M. de Rooy m.de.r...@rijksmuseum.nl changed: What|Removed |Added Status|Needs Signoff |Signed Off --- Comment #13 from M. de Rooy m.de.r...@rijksmuseum.nl --- QA Comment: Simplifies template. Looks good to me. Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8952] Add http:// to url in social media links on opac-detail
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8952 M. de Rooy m.de.r...@rijksmuseum.nl changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9673] Track when items are marked as lost or withdrawn
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9673 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Status|Signed Off |Failed QA CC||jonathan.dru...@biblibre.co ||m --- Comment #9 from Jonathan Druart jonathan.dru...@biblibre.com --- (In reply to comment #2) Hi Kyle, please add the new fields also to the deleteditems table, else deleting items won't work correctly. I was also wondering if it might be useful to add this information to action_log or statistics table? In kohastructure too :) Marked as Failed QA. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9734] String::Random is marked as optional, but C4::Members requires it
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9734 Jared Camins-Esakov jcam...@cpbibliography.com changed: What|Removed |Added Status|Passed QA |Pushed to Master --- Comment #6 from Jared Camins-Esakov jcam...@cpbibliography.com --- This patch has been pushed to master. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9555] Template files contain single quote strings
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9555 Jared Camins-Esakov jcam...@cpbibliography.com changed: What|Removed |Added Status|Passed QA |Pushed to Master --- Comment #13 from Jared Camins-Esakov jcam...@cpbibliography.com --- This patch has been pushed to master. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9377] itemtype in duplicate biblio search
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9377 Jared Camins-Esakov jcam...@cpbibliography.com changed: What|Removed |Added Status|Passed QA |Pushed to Master --- Comment #14 from Jared Camins-Esakov jcam...@cpbibliography.com --- This patch has been pushed to master. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9367] Code optimization: CheckReserves is too often called
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9367 M. de Rooy m.de.r...@rijksmuseum.nl changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9367] Code optimization: CheckReserves is too often called
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9367 M. de Rooy m.de.r...@rijksmuseum.nl changed: What|Removed |Added Attachment #14544|0 |1 is obsolete|| Attachment #16018|0 |1 is obsolete|| --- Comment #11 from M. de Rooy m.de.r...@rijksmuseum.nl --- Created attachment 16021 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=16021action=edit Bug 9367: Code optimization: CheckReserves is too often called This patch rewrites the GetReserveStatus routine in order to take in parameter the itemnumber and/or the biblionumber. In some places, the C4::Reserves::CheckReserves routine is called when we just want to get the status of the reserve. In these cases, the C4::Reserves::GetReserveStatus is now called. This routine executes 1 sql query (or 2 max). Test plan: Check that there is no regression on the different pages where reserves are used. The different status will be the same than before applying this patch. Signed-off-by: Kyle M Hall k...@bywatersolutions.com Signed-off-by: Marcel de Rooy m.de.r...@rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9367] Code optimization: CheckReserves is too often called
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9367 --- Comment #12 from M. de Rooy m.de.r...@rijksmuseum.nl --- Created attachment 16022 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=16022action=edit Bug 9367: Followup: Code optimization: CheckReserves is too often called Signed-off-by: Marcel de Rooy m.de.r...@rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9367] Code optimization: CheckReserves is too often called
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9367 --- Comment #13 from M. de Rooy m.de.r...@rijksmuseum.nl --- Created attachment 16023 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=16023action=edit Bug 9367: Followup finalizing QA Signed-off-by: Marcel de Rooy m.de.r...@rijksmuseum.nl Keeping fetchrow close to its execute worked even better in GetReserveStatus. Instead of returning undef, I return empty string. I checked all calls; this value is mostly not checked for undef. So we eliminate a lot of warnings in log. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9367] Code optimization: CheckReserves is too often called
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9367 M. de Rooy m.de.r...@rijksmuseum.nl changed: What|Removed |Added Status|Signed Off |Passed QA --- Comment #14 from M. de Rooy m.de.r...@rijksmuseum.nl --- Final QA Comments: Keeping fetchrow close to its execute worked even better in GetReserveStatus. Instead of returning undef, I return empty string. I checked all calls; this value is mostly not checked for undef. So we eliminate a lot of warnings in log. Instead of harassing Jonathan again, I added a followup myself. From opac include item-status.inc: [% ELSIF ( item.waiting ) %] On hold Funny thing: If you set waiting=1, the message is On hold. If you set onhold=1 (for a pending reserve), the variable is not used. Conclusion is probably that the line in opac-detail setting var onhold, is not needed.. Can be handled later or somewhere else.. Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8054] can hit submit twice when paying fines
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8054 Jared Camins-Esakov jcam...@cpbibliography.com changed: What|Removed |Added Status|Passed QA |Pushed to Master --- Comment #15 from Jared Camins-Esakov jcam...@cpbibliography.com --- This patch has been pushed to master. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9781] Fix bug in 3.8.x (dynarch) calendar positioning in IE
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9781 Owen Leonard oleon...@myacpl.org changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9781] Fix bug in 3.8.x (dynarch) calendar positioning in IE
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9781 Owen Leonard oleon...@myacpl.org changed: What|Removed |Added Attachment #16007|0 |1 is obsolete|| --- Comment #2 from Owen Leonard oleon...@myacpl.org --- Created attachment 16024 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=16024action=edit [SIGNED-OFF] Bug 9781 - Fix bug in 3.8.x (dynarch) calendar positioning in IE Currently, if you click on the calendar icon on a long patron entry/edit page, the calendar pop-up appears off-screen near the top of the page rather than under the appropriate input box next to the actual icon. For most people, they don't think the calendar pop-up is actually created. For others, it's quite annoying to scroll up to the top of the page to pick a date for a date field lower on the page. -- I've adapted a patch I found at the following URL: http://blog.anorakgirl.co.uk/2009/04/dynarch-dhtml-calendar-ie7-positioning-problem/ This takes care of the problem. -- Test Plan: Before applying patch... 1) In any version of IE, create or edit a Patron entry 2) If you have a Date of birth field at the top, click the calendar icon next to it. 3) Note that the calendar pop-up appears fine. 4) Scroll down to the bottom of the page and click on the calendar icon next to Registration date or Expiry date. 5) Note that no calendar pop-up appears on the screen. Scroll up the page and you should see it up near the top of the page. Apply patch 6) Refresh the page (you might need to clear your cache as well) and try clicking the calendar icon next to Registration date or Expiry date 7) Note that the calendar pop-up appears correctly underneath the input box for which you want to pick a date Signed-off-by: Owen Leonard oleon...@myacpl.org Tested successfully using IE9 on Windows 7. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9781] Fix bug in 3.8.x (dynarch) calendar positioning in IE
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9781 --- Comment #3 from Owen Leonard oleon...@myacpl.org --- This bug affects 3.6.x too, and the patch applies there as well. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9458] Add sorting to lists
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9458 Jared Camins-Esakov jcam...@cpbibliography.com changed: What|Removed |Added Status|Passed QA |Failed QA --- Comment #30 from Jared Camins-Esakov jcam...@cpbibliography.com --- (In reply to comment #29) Good catch! This latest followup fixes that. I've also simplified some of the presentation logic. There's a problem with your latest follow-up: it inserts unsanitized user input into the page. I checked and it seems that most browsers catch the XSS if you try to insert Javascript, but I'd rather not depend on that if we don't have to. To see what I mean, try a link like: /cgi-bin/koha/virtualshelves/shelves.pl?viewshelf=55sort=titledirection=%22%3Ehere's%20some%20text%3Cspan%20style=%22 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9431] Use DataTables on Patron Category Administration page
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9431 Jared Camins-Esakov jcam...@cpbibliography.com changed: What|Removed |Added Status|Passed QA |Pushed to Master --- Comment #15 from Jared Camins-Esakov jcam...@cpbibliography.com --- This patch has been pushed to master. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9786] New: Holds to pull showing items not available
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9786 Bug ID: 9786 Summary: Holds to pull showing items not available Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Hold requests Assignee: koha-bugs@lists.koha-community.org Reporter: k...@bywatersolutions.com CC: gmcha...@gmail.com If an item is on hold and waiting for pickup, and another hold is placed on the record, a hold to pull will show in the Holds to pull report, even though there are no items that can fill that hold request! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9554] single quote in didyoumean
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9554 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added CC||jonathan.dru...@biblibre.co ||m --- Comment #4 from Jonathan Druart jonathan.dru...@biblibre.com --- I'm not able to reproduce the issue. The results appear without any js errors. Could you confirm that the issue still exists? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6886] Single branch mode should disable showing the branch name in front of all callnumbers
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6886 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Status|Signed Off |Patch doesn't apply CC||jonathan.dru...@biblibre.co ||m --- Comment #18 from Jonathan Druart jonathan.dru...@biblibre.com --- Patch does not apply. Caused by bug 5079 which removes the Copies available for reference block. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9787] New: Receive order : Add / Clear links (translation and style)
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9787 Bug ID: 9787 Summary: Receive order : Add / Clear links (translation and style) Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: trivial Priority: P5 - low Component: Acquisitions Assignee: adrien.sau...@biblibre.com Reporter: adrien.sau...@biblibre.com Created attachment 16025 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=16025action=edit screenshot When receiving an ordered item: at the bottom of the Item box, we can see two links, Add and Clear. (see screenshot, in French) Issues: 1) The Add link is not translated (they are JS generated). 2) As suggested by a library, both links are tiny and should be more visible. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9532] reserve rules with itemtype on biblio
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9532 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added CC||jonathan.dru...@biblibre.co ||m --- Comment #3 from Jonathan Druart jonathan.dru...@biblibre.com --- Hum... I don't see what this patch does :-/ There are 2 variables rename (itype with itemtypefield and itemtype with eruleitemtype) and what else? What I miss? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9788] New: Improvements when calling GetReservesFromItemnumber
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9788 Bug ID: 9788 Summary: Improvements when calling GetReservesFromItemnumber Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Hold requests Assignee: m.de.r...@rijksmuseum.nl Reporter: m.de.r...@rijksmuseum.nl CC: gmcha...@gmail.com If we give GetReservesFromItemnumber an additional return value (waitingdate), we can remove some code from several scripts. If we pass the alldates parameter in these cases, Koha takes into account future hold requests and provides more correct information in some cases. This report builds further on changes for bug 9761 and bug 9367. All calls to this function have been checked. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9788] Improvements when calling GetReservesFromItemnumber
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9788 --- Comment #1 from M. de Rooy m.de.r...@rijksmuseum.nl --- Will still add some additional information for testing. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9788] Improvements when calling GetReservesFromItemnumber
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9788 M. de Rooy m.de.r...@rijksmuseum.nl changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9788] Improvements when calling GetReservesFromItemnumber
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9788 --- Comment #2 from M. de Rooy m.de.r...@rijksmuseum.nl --- Created attachment 16026 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=16026action=edit Bug 9788: Improvements when calling GetReservesFromItemnumber -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9035] remove deprecated 'bulkauthimport.pl' file
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9035 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Status|Signed Off |Passed QA CC||jonathan.dru...@biblibre.co ||m QA Contact||jonathan.dru...@biblibre.co ||m --- Comment #4 from Jonathan Druart jonathan.dru...@biblibre.com --- QA comment: Looks unused to me too. All functionality seems available in bulkmarcimport.pl Marked as Passed QA. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9035] remove deprecated 'bulkauthimport.pl' file
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9035 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Attachment #15962|0 |1 is obsolete|| --- Comment #5 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 16027 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=16027action=edit Bug 9035 - delete bulkauthimport.pl dcook Then bulkauthimport.pl? jcamins bulkauthimport should not be used ever. eythian it probably should be deleted jcamins It should be. Signed-off-by: David Cook dc...@prosentient.com.au I've poked around in bulkmarcimport.pl and it certainly seems to have the functionality that Mason (and Jared and Robin) mention. Signed-off-by: Jonathan Druart jonathan.dru...@biblibre.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9789] New: goodreads and librarything in social share
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9789 Bug ID: 9789 Summary: goodreads and librarything in social share Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleon...@myacpl.org Reporter: neng...@gmail.com It would be nice if the socialnetworks shown on the OPAC included GoodReads and Librarything. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9789] goodreads and librarything in social share
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9789 --- Comment #1 from Owen Leonard oleon...@myacpl.org --- I think it's time to build a system where the administrator can choose what to show in the OPAC from a list of available sharing services. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9790] New: move item specific holds to circ matrix
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9790 Bug ID: 9790 Summary: move item specific holds to circ matrix Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Hold requests Assignee: koha-bugs@lists.koha-community.org Reporter: neng...@gmail.com CC: gmcha...@gmail.com It would be nice if you could allow item specific holds based on item type instead of all or nothing. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9789] goodreads and librarything in social share
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9789 --- Comment #2 from Nicole C. Engard neng...@gmail.com --- I think I might have a bug for that too :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9791] New: Some tables are displayed with a pixel before and after
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9791 Bug ID: 9791 Summary: Some tables are displayed with a pixel before and after Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: koha-bugs@lists.koha-community.org Reporter: jonathan.dru...@biblibre.com 5 tables (with datatables) are displayed with a pixel before and after. List is: - acqui/acqui-home.tt - acqui/booksellers.tt - acqui/neworderbiblio.tt - acqui/supplier.tt - members/statistics.tt -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6886] Single branch mode should disable showing the branch name in front of all callnumbers
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6886 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Attachment #15065|0 |1 is obsolete|| --- Comment #19 from Kyle M Hall k...@bywatersolutions.com --- Created attachment 16028 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=16028action=edit Bug 6886 - Single branch mode should disable showing the branch name in front of all callnumbers Followup - Copies available for reference Test plan: Enable singleBranchMode and OPACXSLTResultsDisplay. Perform a search in the OPAC which returns results containing not-for-loan items. Before the patch these items will show their library in search results loan items. After the patch there will be not be a library listed, matching other items in results. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6886] Single branch mode should disable showing the branch name in front of all callnumbers
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6886 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9685] Allow sort baskets by number
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9685 --- Comment #12 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 16029 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=16029action=edit But 9791: Remove single pixel on datatable tables Test plan: Check on the 5 pages that pixels are disappears after applying this patch. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9685] Allow sort baskets by number
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9685 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Attachment #16029|0 |1 is obsolete|| --- Comment #13 from Jonathan Druart jonathan.dru...@biblibre.com --- Comment on attachment 16029 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=16029 But 9791: Remove single pixel on datatable tables Not the good report either... -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9791] Some tables are displayed with a pixel before and after
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9791 --- Comment #1 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 16030 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=16030action=edit But 9791: Remove single pixel on datatable tables Test plan: Check on the 5 pages that pixels are disappears after applying this patch. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9791] Some tables are displayed with a pixel before and after
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9791 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch Assignee|koha-b...@lists.koha-commun |jonathan.dru...@biblibre.co |ity.org |m -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9458] Add sorting to lists
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9458 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Attachment #15952|0 |1 is obsolete|| --- Comment #31 from Kyle M Hall k...@bywatersolutions.com --- Created attachment 16031 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=16031action=edit Bug 9458 - Add sorting to lists - QA Followup 4 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9458] Add sorting to lists
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9458 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Status|Failed QA |Passed QA --- Comment #32 from Kyle M Hall k...@bywatersolutions.com --- There's a problem with your latest follow-up: it inserts unsanitized user input into the page. I checked and it seems that most browsers catch the XSS if you try to insert Javascript, but I'd rather not depend on that if we don't have to. To see what I mean, try a link like: /cgi-bin/koha/virtualshelves/shelves. pl?viewshelf=55sort=titledirection=%22%3Ehere's%20some%20text%3Cspan%20styl e=%22 Fixed! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9673] Track when items are marked as lost or withdrawn
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9673 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Attachment #16003|0 |1 is obsolete|| --- Comment #10 from Kyle M Hall k...@bywatersolutions.com --- Created attachment 16032 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=16032action=edit Bug 9673 - Track when items are marked as lost or withdrawn Add date fields to track when an item was marked as lost or withdrawn. Display those fields on catalogue/moredetail.pl Test Plan: 1) Apply patch 2) Run updatedatabase.pl 3) Pick a record with items, browse to the 'items' tab ( moredetail.pl ) 4) Mark an item as lost, verify the field Lost on: displays below the Lost status field with todays date. 5) Mark the item as not lost, verify the field no longer displays 6) Repeat steps 4 and 5 with the Withdrawn field. Signed-off-by: Mathieu Saby mathieu.s...@univ-rennes2.fr Signed-off-by: Kyle M Hall k...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9673] Track when items are marked as lost or withdrawn
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9673 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9673] Track when items are marked as lost or withdrawn
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9673 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Attachment #16032|0 |1 is obsolete|| --- Comment #11 from Kyle M Hall k...@bywatersolutions.com --- Created attachment 16033 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=16033action=edit Bug 9673 - Track when items are marked as lost or withdrawn Add date fields to track when an item was marked as lost or withdrawn. Display those fields on catalogue/moredetail.pl Test Plan: 1) Apply patch 2) Run updatedatabase.pl 3) Pick a record with items, browse to the 'items' tab ( moredetail.pl ) 4) Mark an item as lost, verify the field Lost on: displays below the Lost status field with todays date. 5) Mark the item as not lost, verify the field no longer displays 6) Repeat steps 4 and 5 with the Withdrawn field. Signed-off-by: Mathieu Saby mathieu.s...@univ-rennes2.fr Signed-off-by: Kyle M Hall k...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6898] circulation librarians can't run overdues without reports permissions
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6898 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Status|Signed Off |Passed QA QA Contact|koha-b...@lists.koha-commun |jonathan.dru...@biblibre.co |ity.org |m --- Comment #31 from Jonathan Druart jonathan.dru...@biblibre.com --- QA comment: This patch adds a new permission (overdues_report) for the circulation module. This permission allows a librarian to access to the overdues page. The updatedb script updates user permissions for users having permissions for the report module + circulate_remaining_permissions (same behavior as before). There is no link to this page (so nothing to hide). Marked as Passed QA. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6898] circulation librarians can't run overdues without reports permissions
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6898 --- Comment #32 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 16034 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=16034action=edit Bug 6898 - circulation librarians can't run overdues without reports permissions This patch adds a new user permission overdues_report for the circulation module, and requires this permission to run the overdue items report, rather than requiring full reports permissions. Test plan : With a user with permissions circulate_remaining_permissions : - Add overdues_report permission to user - Go to circulation home = you see Overdues link - Clik on it = you are allowed to access and use this page - Remove overdues_report permission to user - Go to circulation home = you do not see Overdues link - Edit URL : server/cgi-bin/koha/circ/overdue.pl = you are not allowed to access this page - Go to main page = you don't have access to reports module Signed-off-by: Kyle M Hall k...@bywatersolutions.com Signed-off-by: Fridolyn SOMERS fridolyn.som...@biblibre.com Signed-off-by: Jonathan Druart jonathan.dru...@biblibre.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6898] circulation librarians can't run overdues without reports permissions
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6898 --- Comment #33 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 16035 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=16035action=edit Bug 6898 - circulation librarians can't run overdues without reports permissions followup Better update database. Signed-off-by: Kyle M Hall k...@bywatersolutions.com Signed-off-by: Jonathan Druart jonathan.dru...@biblibre.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6898] circulation librarians can't run overdues without reports permissions
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6898 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Attachment #15974|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6898] circulation librarians can't run overdues without reports permissions
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6898 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Attachment #15975|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7740] Highlight items in own library in search results/detail page in OPAC
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7740 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Attachment #15118|0 |1 is obsolete|| --- Comment #11 from Kyle M Hall k...@bywatersolutions.com --- Created attachment 16036 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=16036action=edit Bug 7740 - Highlight items in own library in search results/detail page in OPAC This feature enables a particular library's items to be emphasized and moved to the first position on the search results and details pages of the OPAC. It is enabled by the sytem preference HighlightOwnItemsOnOPAC. To choose which branches items are emphasized, use the system preference HighlightOwnItemsOnOPACWhich. It has two modes. If set to PatronBranch, the items emphasized will be those of the same library as the patron's library. If no one is logged into the opac, no items will be highlighted. If set to OpacURLBranch, the library is chosen based on the Apache environment variable BRANCHCODE. For example, this could be added to the OPAC section of koha-httpd.conf: SetEnv BRANCHCODE CPL The point of this feature is to allow each library on a given Koha server to have a specific subdomain for the opac where that library's items are empasized. That was http://branch1.opac.mylibrary.org will emphasize the items of branch1, while http://branch2.opac.mylibrary.org will emphasize the items of branch2. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9785] Add new facet
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9785 Owen Leonard oleon...@myacpl.org changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |INVALID --- Comment #1 from Owen Leonard oleon...@myacpl.org --- I'm marking this invalid because it's not a bug report but a support request. This kind of question is best asked on the Koha mailing list: http://koha-community.org/support/koha-mailing-lists/ However, as far as I know Koha facets are not user-configurable. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9760] Simplify local use preferences
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9760 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Status|Signed Off |Passed QA CC||jonathan.dru...@biblibre.co ||m Patch complexity|--- |Medium patch QA Contact||jonathan.dru...@biblibre.co ||m --- Comment #3 from Jonathan Druart jonathan.dru...@biblibre.com --- QA comment: This patch removes a lot of useless code in the systempreferences.pl script. I didn't find anything to delete in the template file. All works great, no regression found. I will just remove the $sth-finish statements in my sign-off patch. Marked as Passed QA. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9760] Simplify local use preferences
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9760 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Attachment #15983|0 |1 is obsolete|| --- Comment #4 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 16037 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=16037action=edit Bug 9760: Simplify local use preferences Removes a lot of code that was needed to handle prefs the old way. Test plan: Goto Local use preferences. Do you see some local preferences? Add a new pref, edit and delete it. Modify the url to systempreferences.pl?tab=OPAC or tab=log. You should only see a short message. Signed-off-by: Kyle M Hall k...@bywatersolutions.com Signed-off-by: Jonathan Druart jonathan.dru...@biblibre.com Amended patch: Remove the $sth-finish statements -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8853] clicking basketgroup name in closed basketgroups reopens it
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8853 Owen Leonard oleon...@myacpl.org changed: What|Removed |Added Attachment #15998|0 |1 is obsolete|| --- Comment #7 from Owen Leonard oleon...@myacpl.org --- Created attachment 16038 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=16038action=edit [SIGNED-OFF] Bug 8853: Suppress links in basketgroups list In the table listing all closed basketgroups, clicking the name of a basketgroup reopen it. To edit an open basketgroup or reopen a closed basketgroup, there are specific buttons in Action column. So the link around basketgroup name is an UX problem. This patch suppress the link around basketgroup name, in both closed and open tab. To test : 1. create some closed and open basketgroups 2. check links are not showing anymore Signed-off-by: Owen Leonard oleon...@myacpl.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8853] clicking basketgroup name in closed basketgroups reopens it
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8853 Owen Leonard oleon...@myacpl.org changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8853] clicking basketgroup name in closed basketgroups reopens it
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8853 Owen Leonard oleon...@myacpl.org changed: What|Removed |Added Version|3.10|master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9673] Track when items are marked as lost or withdrawn
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9673 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Status|Signed Off |Failed QA --- Comment #12 from Jonathan Druart jonathan.dru...@biblibre.com --- QA comment: 1/ DateTime::Format::MySQL is not load in C4::Items 2/ If someone edits the item even thought it is already marked as lost, the lost on date becomes the current date. Is it really what we want? Marked as Failed QA for 1 and certainly for 2 too (except if it is wanted). -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9792] New: Layout problem with patron entry form when using Internet Explorer 9
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9792 Bug ID: 9792 Summary: Layout problem with patron entry form when using Internet Explorer 9 Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All URL: /cgi-bin/koha/members/memberentry.pl?op=add OS: All Status: NEW Severity: normal Priority: P5 - low Component: Browser compatibility Assignee: oleon...@myacpl.org Reporter: oleon...@myacpl.org Created attachment 16039 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=16039action=edit Patron entry form in Internet Explorer 9 The Additional attributes and identifiers section of the patron entry form has a broken layout in IE9. See attached screenshot. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8853] clicking basketgroup name in closed basketgroups reopens it
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8853 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Status|Signed Off |Passed QA CC||jonathan.dru...@biblibre.co ||m --- Comment #8 from Jonathan Druart jonathan.dru...@biblibre.com --- QA comment: This patch fixes an ergonomic issue (action edit or reopen on clicking a basketgroup name link). qa tools complains on tabulation characters but the file contains too much tab. Marked as Passed QA. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9673] Track when items are marked as lost or withdrawn
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9673 --- Comment #13 from mathieu saby mathieu.s...@univ-rennes2.fr --- For 2) : I did not see that, but clearly, no, I don't want such a behavior... M. Saby -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
