[Koha-bugs] [Bug 18636] Can not save new patron on fresh install ( Conflict between autoMemberNum and BorrowerMandatoryField)

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18636

--- Comment #1 from Krishna K  ---
Hi,

We are using Koha 17.05.01 with MySQL. When we try to add a patron, the card
number field is not getting autogenerated and save is failing.

Automembernum is enabled and BorrowerMandatoryField contains cardnumber. I see
no contradiction in these parameters.

This was working perfectly fine in 16.05. What could be going wrong ?

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19019] Patron clubs feature needs documentation

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19019

Krishna K  changed:

   What|Removed |Added

 CC||krishna.moorth...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18915] Creating a checkout note (patron note) sends an incomplete email message

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18915

Amit Gupta  changed:

   What|Removed |Added

 CC||amitddng...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18798] Use Koha.Preference in OPAC Reading Record

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18798

Amit Gupta  changed:

   What|Removed |Added

 CC||amitddng...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14803] Rental and fine fees are not updating on circulation screen

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14803

Srdjan Jankovic  changed:

   What|Removed |Added

  Attachment #63230|0   |1
is obsolete||

--- Comment #36 from Srdjan Jankovic  ---
Created attachment 65698
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65698=edit
bug 14803: KOHA.Checkouts js object

* Use javascript to:
- update fines/checkouts info
- show/hide checkouts form and messages
* Created svc/patron/fines

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14803] Rental and fine fees are not updating on circulation screen

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14803

Srdjan Jankovic  changed:

   What|Removed |Added

 Status|Patch doesn't apply |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14803] Rental and fine fees are not updating on circulation screen

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14803

Srdjan Jankovic  changed:

   What|Removed |Added

  Attachment #60630|0   |1
is obsolete||

--- Comment #35 from Srdjan Jankovic  ---
Created attachment 65697
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65697=edit
Bugfix: added missing use Koha::Account

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14803] Rental and fine fees are not updating on circulation screen

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14803

Srdjan Jankovic  changed:

   What|Removed |Added

  Attachment #60629|0   |1
is obsolete||

--- Comment #34 from Srdjan Jankovic  ---
Created attachment 65696
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65696=edit
Bug 14803: Reload checkouts table on renewal

svc/checkouts: get real rental charges for patron, rather than itemtype
indication

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19040] Refactor C4::Biblio::GetMarcBiblio

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19040

--- Comment #2 from M. Tompsett  ---
Created attachment 65695
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65695=edit
Bug 19040: print STDERRs to develop test plan

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12566] Duplicate checks for Self Registered borrowers

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12566

--- Comment #4 from Liz Rea  ---
I agree with Emma, this needs to be at least as robust as the staff client
duplicate borrower checking.

I envision some scenarios as follows:

Let's just say we have a user who has registered a year or two ago, and can't
remember they did. This person registered in the library, using a paper form,
and their data was input into the system by a librarian based on the fields
required in the staff interface.

I'm going to assume for the sake of the exercise, that the library allows users
to reset their own password by email.

This person now comes to the library website, and has forgotten their
username/password. They don't remember that they have even used the library
website before (maybe they haven't).

This user cannot accomplish what they want to without an account, so they
decide to register. Sensible. 

User registers online, using the form specified by the library. Koha will then
check those required fields and look for a user in the existing database that
matches to some great extent, i.e. if we ask for 10 items of information, let's
say if 6 match and one is an email address in any of the address fields, we
have a suspected duplicate user.

At this point, we can do one of several things:

1. suggest to the user that maybe they've already registered, please go to the
library (which one?) because sorry we can't resolve this online. This is ok,
but pretty bad service for a modern web app.

2. If we have a matching email address in any of the email fields
(configurable?), and a strongly suspected duplicate, send an email with
password recovery instructions to the matching email account. The user may not
have access to this account - but that isn't our problem. It is much better
than sending them away! Something like "We noticed you were trying to register,
but we think you might already be registered with the library. Would you like
us to email you information on how to recover your account?" If accepted, the
email would help them reset their password and take them through the "forgotten
password" workflow. If the user declines, send them to the library for
in-person help. Alternately, we could 

If we have a strongly suspected duplicate, but no email address in any
collected email field, we would not offer to send anything - "We can't register
you online, sorry." 

3. add the user but flag it with MANY FLAGS AND BLINK TAGS as PROBABLY
DUPLICATE and note which borrower, and put it in the patron modification queue
for a librarian to merge with the existing user. We will want to prefer the
username and password that the user has just created with the new registration
so they can still log in.

There are other scenarios but I don't really have clearance to think about them
right now. I do welcome discussion.

Cheers,
Liz

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18245] debian/templates/koha-conf-site.xml.in missing tls

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18245

M. Tompsett  changed:

   What|Removed |Added

   Severity|enhancement |minor

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12935] Allow different from_address in the message_queue

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12935

M. Tompsett  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |WORKSFORME

--- Comment #1 from M. Tompsett  ---
In recent configurations of setting up Email, I discovered it was working
correctly, but GMail was re-writing the header, because I had not authenticated
the other email addresses.

Log in at gmail, and then go to the following in the address bar:
https://mail.google.com/mail/u/0/#settings/accounts
(cog -> settings -> accounts if you wish to click the long way)

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19065] Transaction library filter on Cash register report doesn' t work

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19065

Katrin Fischer  changed:

   What|Removed |Added

Summary|Transaction library resets  |Transaction library filter
   |itself on Cash register |on Cash register report
   |report  |doesn't work

--- Comment #2 from Katrin Fischer  ---
... it's a little late. 

After testing some more, this filter doesn't appear to work. It keeps showing
me entries from Centerville, no mater what I select and submit on the
Transaction branch filter.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19065] Transaction library resets itself on Cash register report

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19065

--- Comment #1 from Katrin Fischer  ---
... And transaction branch should actually be named transaction library to fit
with our terminology!

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19065] New: Transaction library resets itself on Cash register report

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19065

Bug ID: 19065
   Summary: Transaction library resets itself on Cash register
report
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: normal
  Priority: P5 - low
 Component: Reports
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: katrin.fisc...@bsz-bw.de
QA Contact: testo...@bugs.koha-community.org

When working with the cash register report the input for 'transaction library'
resets itself with every submit of the form. It should show the value that was
selected.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17717] process_message_queue.pl: Can't locate Authen/CAS/Client/ Response/Failure.pm

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17717

Marco Moreno  changed:

   What|Removed |Added

 CC||mmor...@pobox.com
 Status|RESOLVED|REOPENED
 Resolution|WORKSFORME  |---

--- Comment #40 from Marco Moreno  ---
This issue is NOT fixed in 17.05.  I'm seeing this now after having upgraded
from 16.11.  However, I've discovered some things that might be helpful.

As Chris mentioned, this appears to be a bug with base.pm (IMO).  Perhaps it's
behavior has changed due to this security resolution that forces Perl to die if
a required module is cannot be read when traversing @INC:
https://rt.perl.org/Public/Bug/Display.html?id=113422

According to this post, base.pm may attempt to require a module that does not
exist and traverse the entire @INC array:
https://rt.cpan.org/Public/Bug/Display.html?id=106552#txn-1589169
Evidently, it dies as soon as it encounters a directory it cannot read.

Avoiding '.' in PERL5LIB doesn't really help since Perl already includes '.' in
@INC (also a security concern???).  Working around this means either ensuring
that '.' points to a directory that can be read (e.g. "cd /tmp") or modifying
the @INC array to remove '.' from it.

The latter seems better so I modified the BEGIN block in
/usr/share/koha/bin/kohalib.pl like this:

-
use strict;
#use warnings; FIXME - Bug 2505

my $module_dir;
BEGIN {
$module_dir = '/usr/share/koha/lib';
die if $module_dir =~ /^[_]{2}PERL_MODULE_DIR[_]{2}$/;
@INC = grep {$_ ne '.'} @INC;
}

use lib $module_dir;

1;
-

This also allows the change to be in one place and avoid having to insert a 'cd
/tmp' for each cron job.

I'm running Perl 5.22 - I wonder if it's fixed in 5.24.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19012] Note additional columns that are required during patron import

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19012

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #65363|0   |1
is obsolete||

--- Comment #2 from Katrin Fischer  ---
Created attachment 65693
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65693=edit
[SIGNED OFF] Bug 19012 - Note additional columns that are required during
patron import

This adds surname and cardnumber to the list of required columns on the
import tool screen and help page

To test:
Read the updated notes, verify it is true and understandable

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19012] Note additional columns that are required during patron import

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19012

Katrin Fischer  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18857] Have "actions" at both ends of the circulation rules table

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18857

--- Comment #7 from Liz Rea  ---
I disagree with Nick's change, it isn't how the column is labelled currently
and I don't see the point to having it in the table footer. Consistency is
usually good, there doesn't seem to be much point to it in this case.

Cheers,
Liz

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19043] Z39.50 target clio-db.cc.columbia.edu: 7090 is no longer publicly available.

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19043

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #65641|0   |1
is obsolete||

--- Comment #2 from Katrin Fischer  ---
Created attachment 65692
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65692=edit
[SIGNED OFF] Bug 19043: Z39.50 target clio-db.cc.columbia.edu:7090 is no longer
publicly available

Test plan:
0) Apply the patch
1) Install all affected languages: de-DE, es-ES, fr-CA and pl-PL
2) Remove and recreate Koha database
3) Go through web installer in English and don't forgot to load sample Z39.50
servers
4) Go to Administration -> Z39.50/SRU Servers and confirm the sample
servers are here, but columbia.edu is not here
5) Repeat 2-4 for other languages: de-DE, es-ES, fr-CA and pl-PL

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19043] Z39.50 target clio-db.cc.columbia.edu: 7090 is no longer publicly available.

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19043

Katrin Fischer  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off
   Patch complexity|--- |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8643] Add important constraint to marc subfields

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8643

Katrin Fischer  changed:

   What|Removed |Added

 Status|Needs Signoff   |Failed QA

--- Comment #38 from Katrin Fischer  ---
There are some things odd about this patch set:

1) In the database update the new columns are added in different spots:

+ALTER TABLE marc_subfield_structure ADD COLUMN important TINYINT(4) NOT NULL
DEFAULT 0  AFTER mandatory;
+ALTER TABLE marc_tag_structure ADD COLUMN important TINYINT(4) NOT NULL
DEFAULT 0  AFTER frameworkcode;

Why not have marc_tag_structure.important after mandatory too? This is mostly
cosmetic, but I was wondering about the inconsistency.

2) There is a change on the serialitems table in kohastructure.sql, that needs
to be removed from this patch set:

@@ -2456,7 +2458,7 @@ DROP TABLE IF EXISTS `serialitems`;
 CREATE TABLE `serialitems` (
 `itemnumber` int(11) NOT NULL,
 `serialid` int(11) NOT NULL,
-PRIMARY KEY (`itemnumber`),
+UNIQUE KEY `serialitemsidx` (`itemnumber`),

3) In marctagstructure.tt the following line is added, I think also
accidentally?

+Authorized value: [%
authorised_value %] (if you select a value here, the indicators will be limited
to the authorized value list)

Also, when testing I noticed that the important field shows up below the
authorised value. I think it should be right below mandatory here too, to be
consistent with the subfield configuration.

4) The number of the tab is missing from the alert:

A few important fields are not filled:

* tag 245 subfield b Zusatz zum Titel in tab 

Are you sure you want to save?

5) The hightlighting seems to only work for subfields, not for fields, is that
correct?

I think it would be nice if the important fields highlighted in a different
color to the mandatory ones (totally not blocker).

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18137] REST API: Migrate from Mojolicious::Plugin:: Swagger2 to Mojolicious::Plugin::OpenAPI

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18137

Jonathan Druart  changed:

   What|Removed |Added

 Status|Passed QA   |Failed QA

--- Comment #94 from Jonathan Druart  
---
I get a warning and a failure from tests:

t/db_dependent/api/v1/auth.t . Use of uninitialized value
$lasttime in numeric lt (<) at /home/vagrant/kohaclone/C4/Auth.pm line 1679.

t/db_dependent/api/v1/swagger/definitions.t .. Can't locate object method
"cache_dir" via package "Swagger2::SchemaValidator" at
/usr/share/perl5/Swagger2.pm line 41.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11317] Add a way to access files from the intranet

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11317

--- Comment #81 from Katrin Fischer  ---
Created attachment 65691
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65691=edit
Bug 11317 - Follow-up - Fixing merge error and cosmetic changes

- Fixed conflicts on reports-home.tt from adding/removing
  the link before moving it to tools
- Slightly reworded second line on the tools page to be
  a bit more verbose.
- Added entry to the tools-menu.inc.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11317] Add a way to access files from the intranet

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11317

Katrin Fischer  changed:

   What|Removed |Added

 Status|Needs Signoff   |Failed QA

--- Comment #80 from Katrin Fischer  ---
I am testing with a kohadevbox, but have problems to access the file, even
though it is listed on the page. This is what I did:

- Added the entry to koha-conf.xml, copied from the plugins/uploads default
  /var/lib/koha/kohadev/files
- Created a file with runreport.pl and moved it to the files directory
- The file is listed on the tool page
- When I try to access the file, I get "internal server error"
- The Plack error log shows:
  /home/vagrant/kohaclone/tools/access_files.pl line 119.
  I thought it might be permission related, but even with 
  777 the problem remains:
  -rwxrwxrwx 1 kohadev-koha kohadev-koha 592 Aug  8  2017 report1.csv

While testing I've made a few little changes:
- Fixed conflicts on reports-home.tt from adding/removing the link before
moving it to tools
- Slightly reworded second line on the tools page to be a bit more verbose.
- Added entry to the tools-menu.inc.

Attaching this as a follow-up for sign-off if you agree.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17277] Current Location column in Holdings table showing empty under OPAC

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17277

Jonathan Druart  changed:

   What|Removed |Added

   Assignee|oleon...@myacpl.org |jonathan.dru...@bugs.koha-c
   ||ommunity.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19014] Patrons should not get a on_reserve notification if the checkout is due in the future

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19014

Jonathan Druart  changed:

   What|Removed |Added

 Depends on||15705


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15705
[Bug 15705] Notify the user on auto renewing
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15705] Notify the user on auto renewing

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15705

Jonathan Druart  changed:

   What|Removed |Added

 Blocks||19014


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19014
[Bug 19014] Patrons should not get a on_reserve notification if the checkout is
due in the future
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18999] Acq: Shipping cost not included in total spent on acq home and funds page

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18999

Marjorie Barry-Vila  changed:

   What|Removed |Added

 CC||marjorie.barry-v...@ccsr.qc
   ||.ca

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13374] AllowHoldsOnPatronsPossessions not working

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13374

Jonathan Druart  changed:

   What|Removed |Added

 Status|Passed QA   |In Discussion

--- Comment #8 from Jonathan Druart  
---
Kyle, I think a new bug report must be opened, the original issue seems fixed.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11299] Add a button to automatically link authority records in cataloguing (AJAX )

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11299

Katrin Fischer  changed:

   What|Removed |Added

 Status|Needs Signoff   |Failed QA

--- Comment #41 from Katrin Fischer  ---
Argh, sorry, I think I forgot to switch the status last time I worked on this.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18007] Interface updates to notices and notice previews

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18007

Jonathan Druart  changed:

   What|Removed |Added

 Status|Needs Signoff   |Patch doesn't apply

--- Comment #3 from Jonathan Druart  
---
Owen, could you rebase it please?

CONFLICT (content): Merge conflict in
koha-tmpl/intranet-tmpl/prog/en/modules/tools/letter.tt

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17981] Add the ability to preview generated notice templates

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17981

Jonathan Druart  changed:

   What|Removed |Added

 Status|Patch doesn't apply |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17981] Add the ability to preview generated notice templates

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17981

--- Comment #20 from Jonathan Druart  
---
Created attachment 65689
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65689=edit
Bug 17981: Better error handling

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17981] Add the ability to preview generated notice templates

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17981

--- Comment #21 from Jonathan Druart  
---
Created attachment 65690
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65690=edit
Bug 17981: Move the divs to the top of the modal

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17981] Add the ability to preview generated notice templates

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17981

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #63980|0   |1
is obsolete||
  Attachment #63981|0   |1
is obsolete||
  Attachment #63982|0   |1
is obsolete||

--- Comment #19 from Jonathan Druart  
---
Created attachment 65688
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65688=edit
Bug 17981: Add a preview mode for notice templates

This patch is a first step to provide a preview mode for notice
templates.

CHECKIN, CHECKOUT and HOLD_SLIP are supported so far.
Maybe more, but I have not tested yet and the interface will not allow
you to generate the preview.

The idea is to provide an idea of how will render the messages generated
from a notice template.

A new "Preview" button is added close to each textarea on the editing
notice templates view.
For each notice template code (letter_code), we will need some input
data to produce the preview.

For instance, for CHECKIN we need an barcode. From the barcode we
can guess all the other data.
For CHECKOUT we will need the borrowernumber and the barcode.
Note that the way to enter the data for the preview is not really
user-friendly, for CHECKOUT you will have to fill
'borrowernumber|barcode', but the placeholder will help you to know how
and what to fill.
In the modal window, you will see 4 blocks:
1/ the content of the letter (with the placeholds << >>)
2/ the generated message (with the data filled)
3/ if the letter contained historical syntax markers, the screen will
try to generate a notice template using the TT syntax
4/ the generated message from this TT syntax
=> You will be able to compare the 2 generated messages.

What is the goal of this first patchset:
- Show this first POC and get feedback from other developpers
- Add a way to easily visualise the differences between the 2 syntaxes
- Confort users with the TT syntax and the migration step from the
historical syntax.

I'd like to get opinions before going further.

The possibilities:
- Mock data to get fully working generated messages for any notice
templates. For instance, for CHECKIN and CHECKOUT, the item is not
checked in/out yet. So we cannot access the issue's information.
(I have no idea how to do that)
- Browse the data to get the ones we want to use for the preview (big).

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19049] Recover the Arbitrary file type on stage-marc-import with plugin to_marc

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19049

Tomás Cohen Arazi  changed:

   What|Removed |Added

 CC||tomasco...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18821] TrackLastPatronActivity is a performance killer

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18821

Kyle M Hall  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18821] TrackLastPatronActivity is a performance killer

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18821

Kyle M Hall  changed:

   What|Removed |Added

  Attachment #64426|0   |1
is obsolete||

--- Comment #4 from Kyle M Hall  ---
Created attachment 65687
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65687=edit
Bug 18821 - TrackLastPatronActivity is a performance killer

Enabling TrackLastPatronActivity can cause an extreme performance hit,
especially on the staff side during checkin and checkout. It makes more sense
to only update the last activity timestamp on the first access of a given
session. This will greatly improve performance while retaining the same basic
information.

Test Plan:
1) Apply this patch
2) Start a new session ( a private browser window works well )
3) Note the lastseen column in the borrowers table is updated
4) Browse a few pages, not the lastseen column is not updated again
5) Close the browser window and repeat steps 2-4
6) prove t/db_dependent/Members.t

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18821] TrackLastPatronActivity is a performance killer

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18821

Kyle M Hall  changed:

   What|Removed |Added

Summary|GetPatronLastActivity is a  |TrackLastPatronActivity is
   |performance killer  |a performance killer

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12095] Hold queue should take closed dates into account

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12095

jdem...@roseville.ca.us  changed:

   What|Removed |Added

 CC||jdem...@roseville.ca.us

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17981] Add the ability to preview generated notice templates

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17981

Kyle M Hall  changed:

   What|Removed |Added

 Status|Needs Signoff   |Patch doesn't apply

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17967] TT syntax for notices - Prove that ODUE is compatible

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17967

Kyle M Hall  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17967] TT syntax for notices - Prove that ODUE is compatible

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17967

Kyle M Hall  changed:

   What|Removed |Added

  Attachment #63977|0   |1
is obsolete||

--- Comment #4 from Kyle M Hall  ---
Created attachment 65686
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65686=edit
Bug 17967: TT syntax for notices - Prove that ODUE is compatible

Nothing new here, unless we are introducing a regression.
The items.fine is a trick of our historical syntax.
We need to provide a way to access this value from the a notice template
using the TT syntax.
A bug 17976 has been opened for discussion.

Test plan:
Define ODUE and OVERDUES_SLIP notice templates and use it to generate
overdue notices from the cronjob script (misc/cronjobs/overdue_notices.pl)
or the interface (members/print_overdues.pl).

You should be able to generate the same notices with and without using
the TT syntax

Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17969] Refactor the way <> is generated

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17969

--- Comment #9 from Kyle M Hall  ---
Created attachment 65685
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65685=edit
Bug 17969: (QA followup) Add POD

Signed-off-by: Tomas Cohen Arazi 

Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17969] Refactor the way <> is generated

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17969

Kyle M Hall  changed:

   What|Removed |Added

  Attachment #65567|0   |1
is obsolete||
  Attachment #65568|0   |1
is obsolete||

--- Comment #8 from Kyle M Hall  ---
Created attachment 65684
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65684=edit
Bug 17969: Refactor the way <> is generated

<> is generated 4x in advance_notices.pl and once in
overdue_notices.pl
It would be better to have it in C4::Letters.
It will enforce the fact that it already has the same behavior, make it
testable and reusable.

Test plan:
Use the <> tag for advance and overdue notices.
The generated notices must be the same as before this patch.

Followed test plan, works as expected.
Signed-off-by: Marc Véron 
Signed-off-by: Tomas Cohen Arazi 

Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17966] TT syntax for notices - Prove that ISSUESLIP is compatible

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17966

Kyle M Hall  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17966] TT syntax for notices - Prove that ISSUESLIP is compatible

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17966

Kyle M Hall  changed:

   What|Removed |Added

  Attachment #63975|0   |1
is obsolete||
 CC||k...@bywatersolutions.com

--- Comment #5 from Kyle M Hall  ---
Created attachment 65683
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65683=edit
Bug 17966: TT syntax for notices - Prove that ISSUESLIP is compatible

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8643] Add important constraint to marc subfields

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8643

Philippe Audet-Fortin  changed:

   What|Removed |Added

 Status|Patch doesn't apply |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8643] Add important constraint to marc subfields

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8643

Philippe Audet-Fortin  changed:

   What|Removed |Added

  Attachment #60554|0   |1
is obsolete||

--- Comment #37 from Philippe Audet-Fortin  
---
Created attachment 65682
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65682=edit
Bug 8643 - Add important constraint to marc subfields

This fix permits to add an "Important" option to the marc structure pages.

Testing:

I Apply the patch
II Run updatedatabase.pl

0) Define 100 as an "important" field ( Administration » MARC bibliographic
framework » MARC structure ( Default Frameword) » Edit )
1) Define 100$a as an "important" subfield (Administration » MARC bibliographic
framework » MARC structure (Default Frameword) » Subfield » Onglet a)
2) Edit a record to clear the field 100
3) Save the record.
4) Validate the following message:

A few important fields are not filled:

* tag 100 subfield a Nom de personne in tab
* Field 100 is important, at least one of its subfields should be filled.

Are you sure you want to save?

sponsored by the CCSR ( http://www.ccsr.qc.ca )

Signed-off-by: Bernardo Gonzalez Kriegel 
Work as described. Fixed small conflict

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15707] Add ability to define hierarchical groups of libraries

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15707

Kyle M Hall  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15707] Add ability to define hierarchical groups of libraries

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15707

Kyle M Hall  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15707] Add ability to define hierarchical groups of libraries

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15707

--- Comment #188 from Kyle M Hall  ---
Created attachment 65681
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65681=edit
Bug 15707 - Display error if group title is already used

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15707] Add ability to define hierarchical groups of libraries

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15707

--- Comment #187 from Kyle M Hall  ---
Created attachment 65680
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65680=edit
Bug 15707 - Updates for Bootstrap 3

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15707] Add ability to define hierarchical groups of libraries

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15707

--- Comment #186 from Kyle M Hall  ---
Created attachment 65679
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65679=edit
Bug 15707 - Add UNIQUE constraint to library groups table

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15707] Add ability to define hierarchical groups of libraries

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15707

--- Comment #185 from Kyle M Hall  ---
Created attachment 65678
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65678=edit
Bug 15707 - Switch datetimes to timestamps

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15707] Add ability to define hierarchical groups of libraries

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15707

--- Comment #184 from Kyle M Hall  ---
Created attachment 65677
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65677=edit
Bug 15707: Followup - use cat-search instead of cities-search in header

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15707] Add ability to define hierarchical groups of libraries

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15707

--- Comment #183 from Kyle M Hall  ---
Created attachment 65676
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65676=edit
Bug 15707 - Update Schema Files

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15707] Add ability to define hierarchical groups of libraries

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15707

--- Comment #182 from Kyle M Hall  ---
Created attachment 65675
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65675=edit
Bug 15707 [QA Followup] - Allow object names to be styled without impeding
translation

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15707] Add ability to define hierarchical groups of libraries

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15707

--- Comment #181 from Kyle M Hall  ---
Created attachment 65674
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65674=edit
Bug 15707 [QA Followup] - Remove class for treegrid

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15707] Add ability to define hierarchical groups of libraries

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15707

--- Comment #180 from Kyle M Hall  ---
Created attachment 65673
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65673=edit
Bug 15707 [QA Followup] - Fix UI issues

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15707] Add ability to define hierarchical groups of libraries

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15707

--- Comment #179 from Kyle M Hall  ---
Created attachment 65672
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65672=edit
Bug 15707: QA follow-up - Drop table if exists

1/ DROP table if exists
2/ FAIL   spelling
decendents  ==> descendants

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15707] Add ability to define hierarchical groups of libraries

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15707

--- Comment #178 from Kyle M Hall  ---
Created attachment 65671
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65671=edit
Bug 15707 [QA Followup] - Switch to treetable which Koha already uses

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15707] Add ability to define hierarchical groups of libraries

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15707

--- Comment #177 from Kyle M Hall  ---
Created attachment 65670
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65670=edit
Bug 15707: Fix conflict with bug 15446 (type vs _type)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15707] Add ability to define hierarchical groups of libraries

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15707

--- Comment #174 from Kyle M Hall  ---
Created attachment 65667
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65667=edit
Bug 15707 - Add new modules

Signed-off-by: Mark Tompsett 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15707] Add ability to define hierarchical groups of libraries

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15707

Kyle M Hall  changed:

   What|Removed |Added

  Attachment #60756|0   |1
is obsolete||
  Attachment #60757|0   |1
is obsolete||
  Attachment #60758|0   |1
is obsolete||
  Attachment #60759|0   |1
is obsolete||
  Attachment #60760|0   |1
is obsolete||
  Attachment #60761|0   |1
is obsolete||
  Attachment #60762|0   |1
is obsolete||
  Attachment #60763|0   |1
is obsolete||
  Attachment #60764|0   |1
is obsolete||
  Attachment #60765|0   |1
is obsolete||
  Attachment #60766|0   |1
is obsolete||
  Attachment #60767|0   |1
is obsolete||
  Attachment #60768|0   |1
is obsolete||
  Attachment #60769|0   |1
is obsolete||
  Attachment #60770|0   |1
is obsolete||
  Attachment #60771|0   |1
is obsolete||

--- Comment #173 from Kyle M Hall  ---
Created attachment 65666
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65666=edit
Bug 15707 - Update DB

Signed-off-by: Mark Tompsett 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15707] Add ability to define hierarchical groups of libraries

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15707

--- Comment #176 from Kyle M Hall  ---
Created attachment 65669
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65669=edit
Bug 15707 - Unit Tests

Signed-off-by: Mark Tompsett 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15707] Add ability to define hierarchical groups of libraries

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15707

--- Comment #175 from Kyle M Hall  ---
Created attachment 65668
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65668=edit
Bug 15707 - Add editor

Signed-off-by: Mark Tompsett 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16735] Replace existing library search groups functionality with the new hierarchical groups system

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16735

--- Comment #55 from Kyle M Hall  ---
Created attachment 65664
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65664=edit
Bug 16735 - Filter groups without immediate child libraries from group pulldown

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16735] Replace existing library search groups functionality with the new hierarchical groups system

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16735

--- Comment #56 from Kyle M Hall  ---
Created attachment 65665
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65665=edit
Bug 16735 - Use libraries in all subgroups, not just immediate children

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16735] Replace existing library search groups functionality with the new hierarchical groups system

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16735

--- Comment #52 from Kyle M Hall  ---
Created attachment 65661
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65661=edit
Bug 16735 - Don't use objects for database update

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16735] Replace existing library search groups functionality with the new hierarchical groups system

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16735

--- Comment #54 from Kyle M Hall  ---
Created attachment 65663
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65663=edit
Bug 16735 - Filter individual libraries from search group pulldown

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16735] Replace existing library search groups functionality with the new hierarchical groups system

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16735

--- Comment #51 from Kyle M Hall  ---
Created attachment 65660
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65660=edit
Bug 16735 - Replace existing library search groups functionality with the new
hierarchical groups system

Test Plan:
1) Apply this patch set
2) Note your existing search groups have been ported over to the new
   __SEARCH_GROUPS__ group if you had any
3) Create the group __SEARCH_GROUPS__ if one does not already exist
4) Add some first level subgroups to this group, add libraries to those groups
5) Search the library group searching in the intranet and opac
6) Note you get the same results as pre-patch

Signed-off-by: Josef Moravec 

Conflicts:
catalogue/search.pl
installer/data/mysql/updatedatabase.pl
opac/opac-search.pl

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16735] Replace existing library search groups functionality with the new hierarchical groups system

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16735

--- Comment #53 from Kyle M Hall  ---
Created attachment 65662
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65662=edit
Bug 16735 - Remove use of get_categories

Feature using it is completely undocumented as far as my research has
shown.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16735] Replace existing library search groups functionality with the new hierarchical groups system

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16735

Kyle M Hall  changed:

   What|Removed |Added

  Attachment #60772|0   |1
is obsolete||
  Attachment #60773|0   |1
is obsolete||
  Attachment #60774|0   |1
is obsolete||
  Attachment #60775|0   |1
is obsolete||
  Attachment #60776|0   |1
is obsolete||
  Attachment #60777|0   |1
is obsolete||
  Attachment #60778|0   |1
is obsolete||
  Attachment #60779|0   |1
is obsolete||

--- Comment #49 from Kyle M Hall  ---
Created attachment 65658
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65658=edit
Bug 16735 - Remove modules no longer needed

Signed-off-by: Josef Moravec 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16735] Replace existing library search groups functionality with the new hierarchical groups system

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16735

--- Comment #50 from Kyle M Hall  ---
Created attachment 65659
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65659=edit
Bug 16735 - Clean up sample data

Signed-off-by: Josef Moravec 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16735] Replace existing library search groups functionality with the new hierarchical groups system

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16735

Kyle M Hall  changed:

   What|Removed |Added

 Status|BLOCKED |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18584] Our legacy code contains trailing-spaces

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18584

Jonathan Druart  changed:

   What|Removed |Added

URL||https://github.com/joubu/ko
   ||ha-howto

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18877] Outdated explanation of use when two patches applied

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18877

Jonathan Druart  changed:

   What|Removed |Added

 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org

--- Comment #4 from Jonathan Druart  
---
(In reply to Lee Jamison from comment #2)
> testing 2 commit(s) (applied to 3d24c19 'Bug 14533: remove CREATE USER when
> ko')
> 
> Processing files before patches
> 
> Processing files after patches
> 
> 
> kohadev-koha@kohadevbox:/home/vagrant/kohaclone$
> 
> 
> It appears that applying this patch breaks QA Tools for some reason.
> 
> Failing QA

This is not relevant, nothing is displayed because no file are processed.
You can consider that as a bug in the QA script.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10267] No error message when entering an invalid cardnumber

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10267

Katrin Fischer  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10267] No error message when entering an invalid cardnumber

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10267

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #62934|0   |1
is obsolete||

--- Comment #20 from Katrin Fischer  ---
Created attachment 65657
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65657=edit
[SIGNED OFF] Bug 10267: Show error message if user tries to enter too many
characters for cardnumber

This patch displays a message if the user tries to enter more than the
max number of characters for a cardnumber.

To test:
1) Apply patch and go to Patrons -> New patron
2) Scroll down to Card number
3) Put in any characters. Notice that when you have entered the max
number of characters, you are unable to type any more.
4) Click out of the text field (so it loses focus), the error message will show
up.
5) if you backspace some characters and click out of the text field
again, the message should disappear

Sponsored-by: Catalyst IT

Followed test plan, works as expected
Signed-off-by: Marc Véron 

Signed-off-by: Katrin Fischer 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10267] No error message when entering an invalid cardnumber

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10267

--- Comment #19 from Katrin Fischer  ---
It's impossible to enter them, but scanning from an ID or c from another
system you might not know that it has been automatically cut off. This was just
thought to provide some help for this case. 

I am signing off.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19049] Recover the Arbitrary file type on stage-marc-import with plugin to_marc

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19049

Marcel de Rooy  changed:

   What|Removed |Added

  Attachment #65595|0   |1
is obsolete||

--- Comment #3 from Marcel de Rooy  ---
Created attachment 65655
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65655=edit
Bug 19049: Restore import with to_marc plugin

Still needs some polishing and testing.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19049] Recover the Arbitrary file type on stage-marc-import with plugin to_marc

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19049

--- Comment #4 from Marcel de Rooy  ---
Created attachment 65656
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65656=edit
Bug 19049: Tests

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10407] Allow MARCXML records to be imported with Tools/ Stage MARC records for import

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10407

--- Comment #61 from Marcel de Rooy  ---
(In reply to Tomás Cohen Arazi from comment #59)
> I think bug 12412 should've added new options to the 'format' dropdown so we
> don't rely on it magically falling back to some plugin  processing the file,
> and explicitly choosing it instead.

(In reply to Katrin Fischer from comment #60)
> It's probably true, but was missed at the time. Reenabling the feature, it
> could be done.

Will submit on bug 19049. Putting the plugins into the format combo.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10112] add test for ./debian/control file

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10112

--- Comment #9 from Katrin Fischer  ---
The patch proposes a new dependency libparse-debcontrol-perl and there has been
some discussion about it.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10112] add test for ./debian/control file

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10112

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #64313|0   |1
is obsolete||

--- Comment #8 from Katrin Fischer  ---
Created attachment 65654
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65654=edit
[SIGNED OFF] Bug 10112 - add test for ./debian/control* files

to test, apply patch...

1/ install libparse-debcontrol-perl package
apt-get install libparse-debcontrol-perl

2/ run successful tests
$ perl ./t/00-valid-debian-control-file.t  
1..2
ok 1 - parsed ./debian/control file cleanly
ok 2 - parsed ./debian/control.in file cleanly

3/ add some bad syntax to a file
$ sed -i -e '20i ---\' ./debian/control.in

4/ run failed tests
$ perl ./t/00-valid-debian-control-file.t
1..2
ok 1 - parsed ./debian/control file cleanly
not ok 2 - parsed ./debian/control.in file cleanly

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10112] add test for ./debian/control file

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10112

Katrin Fischer  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off
   Patch complexity|--- |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10112] add test for ./debian/control file

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10112

Katrin Fischer  changed:

   What|Removed |Added

   Keywords||dependency

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10112] add test for ./debian/control file

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10112

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #64313|1   |0
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8643] Add important constraint to marc subfields

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8643

Katrin Fischer  changed:

   What|Removed |Added

 Status|Needs Signoff   |Patch doesn't apply

--- Comment #36 from Katrin Fischer  ---
Hm, there are changes in kohastructure.sql to the table serialitems causing a
conflict when applying the patch:

Bug 8643 - Add important constraint to marc subfields

60554 - Bug 8643 - Add important constraint to marc subfields
60555 - Bug 8643: (follow-up) atomic update
65149 - Bug 8643 - Added hint for important fields and implemented it for item
fields

Apply? [(y)es, (n)o, (i)nteractive] y
Applying: Bug 8643 - Add important constraint to marc subfields
.git/rebase-apply/patch:22: trailing whitespace.
FROM marc_tag_structure 
.git/rebase-apply/patch:23: trailing whitespace.
WHERE frameworkcode=? 
.git/rebase-apply/patch:42: trailing whitespace.
 FROM   marc_subfield_structure 
.git/rebase-apply/patch:43: trailing whitespace.
 WHERE  frameworkcode=? 
.git/rebase-apply/patch:194: trailing whitespace.
FROM marc_tag_structure 
warning: squelched 10 whitespace errors
warning: 15 lines add whitespace errors.
Using index info to reconstruct a base tree...
M   C4/Biblio.pm
M   admin/marc_subfields_structure.pl
M   cataloguing/addbiblio.pl
M   installer/data/mysql/kohastructure.sql
.git/rebase-apply/patch:22: trailing whitespace.
FROM marc_tag_structure 
.git/rebase-apply/patch:23: trailing whitespace.
WHERE frameworkcode=? 
.git/rebase-apply/patch:42: trailing whitespace.
 FROM   marc_subfield_structure 
.git/rebase-apply/patch:43: trailing whitespace.
 WHERE  frameworkcode=? 
.git/rebase-apply/patch:194: trailing whitespace.
FROM marc_tag_structure 
warning: squelched 10 whitespace errors
warning: 15 lines add whitespace errors.
Falling back to patching base and 3-way merge...
Auto-merging installer/data/mysql/kohastructure.sql
CONFLICT (content): Merge conflict in installer/data/mysql/kohastructure.sql
Auto-merging cataloguing/addbiblio.pl
Auto-merging admin/marc_subfields_structure.pl
Auto-merging C4/Biblio.pm
error: Failed to merge in the changes.
Patch failed at 0001 Bug 8643 - Add important constraint to marc subfields
The copy of the patch that failed is found in: .git/rebase-apply/patch
When you have resolved this problem run "git bz apply --continue".
If you would prefer to skip this patch, instead run "git bz apply --skip".
To restore the original branch and stop patching run "git bz apply --abort".
Patch left in
/tmp/Bug-8643---Add-important-constraint-to-marc-subfie-FP83NQ.patch

Are those changes related to the patch?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8630] Add covers from AdLibris to the OPAC and Intranet

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8630

Katrin Fischer  changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de

--- Comment #27 from Katrin Fischer  ---
There is a conflict in the OPAC minified CSS:

Apply? [(y)es, (n)o, (i)nteractive] y
Applying: Bug 8630 - Adlibris covers (OPAC minified CSS)
Using index info to reconstruct a base tree...
M   koha-tmpl/opac-tmpl/bootstrap/css/opac.css
Falling back to patching base and 3-way merge...
Auto-merging koha-tmpl/opac-tmpl/bootstrap/css/opac.css
CONFLICT (content): Merge conflict in
koha-tmpl/opac-tmpl/bootstrap/css/opac.css
error: Failed to merge in the changes.
Patch failed at 0001 Bug 8630 - Adlibris covers (OPAC minified CSS)

Leaving this Needs Signoff, someone familiar with the process could recompile
before testing.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18149] Move CountUsage calls to Koha namespace

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18149

Josef Moravec  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18149] Move CountUsage calls to Koha namespace

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18149

Josef Moravec  changed:

   What|Removed |Added

  Attachment #64720|0   |1
is obsolete||

--- Comment #2 from Josef Moravec  ---
Created attachment 65653
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65653=edit
[SIGNED-OFF] Bug 18149: Move CountUsage calls to Koha namespace

After the introduction of Koha::Authorities->get_usage_count with bug
9988, we can now replace the remaining occurrences of CountUsage.

At the same time we remove CountUsageChildren. This was an empty sub.
The typo get_count_usage in a subtest title is adjusted.

Test plan:
[1] Run t/db_dependent/Koha/Authorities.t
[2] Perform a search on authorities-home.pl and verify that you see
plausible numbers for 'used in xx records'.
[3] Click on Details for one authority. See the same number?
[4] Do the same as in 2/3 for Authority search on OPAC.
[5] Remember the authid and enter this in the record numbers box on
tools/batch_delete_records.pl. Select Authorities and click
Continue. The next form shows a column "Used in". Do you see
the same count again?
[6] Git grep CountUsage.
You should see just one hit in a comment that can be kept in
Koha/Authorities.pm.

Signed-off-by: Marcel de Rooy 

Signed-off-by: Josef Moravec 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14826] Resurrect account offsets table

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14826

--- Comment #78 from Kyle M Hall  ---
Created attachment 65651
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65651=edit
Bug 14826 [QA Followup] - Fix minor issues with unit tests

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14826] Resurrect account offsets table

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14826

--- Comment #79 from Kyle M Hall  ---
Created attachment 65652
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65652=edit
Bug 14826 [QA Followup] - Only use plural modules in other modules

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14826] Resurrect account offsets table

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14826

--- Comment #76 from Kyle M Hall  ---
Created attachment 65649
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65649=edit
Bug 14826 - Add unit tests for _FixAccountForLostAndReturned and
_FixOverduesOnReturn

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14826] Resurrect account offsets table

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14826

--- Comment #77 from Kyle M Hall  ---
Created attachment 65650
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65650=edit
Bug 14826 - Update existing schema files

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14826] Resurrect account offsets table

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14826

--- Comment #75 from Kyle M Hall  ---
Created attachment 65648
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65648=edit
Bug 14826 - Add offset for rental fees

Signed-off-by: Josef Moravec 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14826] Resurrect account offsets table

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14826

--- Comment #74 from Kyle M Hall  ---
Created attachment 65647
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65647=edit
Bug 14826 - Add new offset table schema file

Signed-off-by: Josef Moravec 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/