[Koha-bugs] [Bug 27992] When recording local use with statistical patron items are not checked in
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27992 Lucas Gass changed: What|Removed |Added Attachment #146041|0 |1 is obsolete|| --- Comment #22 from Lucas Gass --- Created attachment 158011 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158011=edit Bug 27992: Call AddReturn on stats patron -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35157] The searchfieldstype select element produces invalid HTML
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35157 David Nind changed: What|Removed |Added CC||da...@davidnind.com --- Comment #4 from David Nind --- Testing notes (using KTD): 1. I used the HTML Validator extension (https://www.gueury.com/mozilla/) with the Chromium browser, which shows under Developer Tools. (It is available on Firefox as well, but for some reason Firefox seemed to strip the tags from the option element.) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35157] The searchfieldstype select element produces invalid HTML
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35157 David Nind changed: What|Removed |Added Attachment #157876|0 |1 is obsolete|| --- Comment #3 from David Nind --- Created attachment 158010 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158010=edit Bug 35157: Remove spans from patronfields.inc To test: 1. Run any page that contains the "Search patrons" search bar through an HTML validator and you will see a lot of: Stray start tag span. Stray end tag span. 2. Apply patch 3. Try step 1 again, no more errors from the HTML validator. 4. Make sure the patron searches still work when limiting by 'Search field'. Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35157] The searchfieldstype select element produces invalid HTML
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35157 David Nind changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32707] ElasticSearch should not auto truncate (even if QueryAutoTruncate = 1) for identifiers (and some other fields)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32707 --- Comment #11 from Janusz Kaczmarek --- Koha with Zebra prevented auto truncation in some circumstances -- see the first return for ccl inside C4::Search:: buildQuery, before applying auto truncation, and setting $auto_truncation = 0 for some search fields. Koha with ElasticSearch applies auto truncation for all search fields, not paying attention to these special cases when it should not be done. This leads to various problems as described in bug 26508, 26608, etc. The solution would be to prevent auto truncation for certain search fields, above all – the identifiers. In addition, under no circumstances should a search field other than of text type be truncated (an attempt to truncate would generate an exception from ElasticSearch, e.g. number_format_exception for integer). Test plan = Scenario A (authority) -- 1. Enable Elasticsearch engine. 2. Have like 100+ bibliographic records and properly linked authority records. 3. Reindex ElasticSearch if needed. 4. Enable QueryAutoTruncate systempreference. 5. Find the authority record #1 and note the number of linked biblio records. 6. Show the detail of authority #1 and compare the number of linked biblio records. 7. If in the database there are authority records with ids =~ /^1/ (i.e. 10, 11, 12, ..., 100, 101, ...) linked to the biblio records you get two different numbers of linked records. 8. Also, as lists of linked biblio records (via link: Used in N record(s) from results view and detail view) you will get two different sets of biblio records. In particular, on the list generated from detail view (authorities/detail.pl?authid=1) you will get biblio records that are in fact not linked to the auth #1 (the list is generated with =an:1). 9. Apply this patch. 10. Counts and list of linked biblios should be ok. Scenario B (analytics) -- 1. Enable Elasticsearch engine. 2. Have three monographic bibliographic records with 001 = 1, 10, 100 (i.e. =~ /^1/). 3. Have an analytical record with 773 $w = 1. 4. Reindex ElasticSearch if needed. 5. Enable QueryAutoTruncate and UseControlNumber systempreference. 6. Find the analytical record and click on the link generated from 773, i.e. (In: ... --> catalogue/search.pl?q=Control-number:1). 7. You should see a list of three records (001 = 1, 10, 100) instead of one (001 = 1). 8. Apply this patch. Make sure that record-control-number is included in ESPreventAutoTruncate syspref. 9. Repeat step 6. You should arrive at the right host record. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32707] ElasticSearch should not auto truncate (even if QueryAutoTruncate = 1) for identifiers (and some other fields)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32707 --- Comment #10 from Janusz Kaczmarek --- Created attachment 158009 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158009=edit Bug 32707: Unit tests NB in t/db_dependent/Koha/SearchEngine/Elasticsearch/QueryBuilder.t, I had to modify four existing test by changing Local-number:123456 to Personal-name:donald -- since Local-number should never be auto truncated according to the submitted patch. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32707] ElasticSearch should not auto truncate (even if QueryAutoTruncate = 1) for identifiers (and some other fields)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32707 --- Comment #9 from Janusz Kaczmarek --- Created attachment 158008 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158008=edit Bug 32707: ElasticSearch should not auto truncate (even if QueryAutoTruncate = 1) for identifiers (and some other fields) Koha with Zebra prevented auto truncation in some circumstances -- see the first return for ccl inside C4::Search:: buildQuery, before applying auto truncation, and setting $auto_truncation = 0 for some search fields. Koha with ElasticSearch applies auto truncation for all search fields, not paying attention to these special cases when it should not be done. This leads to various problems as described in bug 26508, 26608, etc. The solution would be to prevent auto truncation for certain search fields, above all – the identifiers. In addition, under no circumstances should a search field other than of text type be truncated (an attempt to truncate would generate an exception from ElasticSearch, e.g. number_format_exception for integer). Test plan = Scenario A (authority) -- 1. Enable Elasticsearch engine. 2. Have like 100+ bibliographic records and properly linked authority records. 3. Reindex ElasticSearch if needed. 4. Enable QueryAutoTruncate systempreference. 5. Find the authority record #1 and note the number of linked biblio records. 6. Show the detail of authority #1 and compare the number of linked biblio records. 7. If in the database there are authority records with ids =~ /^1/ (i.e. 10, 11, 12, ..., 100, 101, ...) linked to the biblio records you get two different numbers of linked records. 8. Also, as lists of linked biblio records (via link: Used in N record(s) from results view and detail view) you will get two different sets of biblio records. In particular, on the list generated from detail view (authorities/detail.pl?authid=1) you will get biblio records that are in fact not linked to the auth #1 (the list is generated with =an:1). 9. Apply this patch. 10. Counts and list of linked biblios should be ok. Scenario B (analytics) -- 1. Enable Elasticsearch engine. 2. Have three monographic bibliographic records with 001 = 1, 10, 100 (i.e. =~ /^1/). 3. Have an analytical record with 773 $w = 1. 4. Reindex ElasticSearch if needed. 5. Enable QueryAutoTruncate and UseControlNumber systempreference. 6. Find the analytical record and click on the link generated from 773, i.e. (In: ... --> catalogue/search.pl?q=Control-number:1). 7. You should see a list of three records (001 = 1, 10, 100) instead of one (001 = 1). 8. Apply this patch. Make sure that record-control-number is included in ESPreventAutoTruncate syspref. 9. Repeat step 6. You should arrive at the right host record. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32707] ElasticSearch should not auto truncate (even if QueryAutoTruncate = 1) for identifiers (and some other fields)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32707 Janusz Kaczmarek changed: What|Removed |Added Attachment #145606|0 |1 is obsolete|| --- Comment #8 from Janusz Kaczmarek --- Created attachment 158007 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158007=edit Bug 32707: Add 'ESPreventAutoTruncate' preference This patch adds a new 'ESPreventAutoTruncate' preference allowing to define Elasticsearch search fields that should not be autotruncated when 'QueryAutoTruncate' is active (e.g. barcode). -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32707] ElasticSearch should not auto truncate (even if QueryAutoTruncate = 1) for identifiers (and some other fields)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32707 Janusz Kaczmarek changed: What|Removed |Added Status|In Discussion |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29390] Authorised values: Add a few missing foreign keys
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29390 Emily Lamancusa changed: What|Removed |Added Status|Signed Off |Failed QA --- Comment #23 from Emily Lamancusa --- Generally the code looks good, and the dbrev is idempotent. One big concern, though - should all of the foreign keys be ON DELETE CASCADE? With the exception of additional_fields, the field is nullable, and when removing conflicts before applying the foreign key, the dbrev sets them to null. Shouldn't the foreign key constraint do the same if the authorized value is deleted? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28411] Investigate memory footprint of the different dependencies
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28411 --- Comment #9 from Blou --- Created attachment 158006 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158006=edit Bug 28411: modify t/db_dependent tests to use Koha::Config::SysPrefs' set_preference insteand of C4::Context Some work left to be done, including missing use at top of files -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28411] Investigate memory footprint of the different dependencies
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28411 --- Comment #8 from Blou --- Created attachment 158005 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158005=edit Bug 28411: modify scripts' call to set_preference now in Koha::Config::SysPrefs All the scripts using the call C4::Context->set_preference are edited to now use Koha::Config::SysPrefs->set_preference instead of C4::Context->set_preference() One call to delete_preference moved as well -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28411] Investigate memory footprint of the different dependencies
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28411 Blou changed: What|Removed |Added Attachment #157957|0 |1 is obsolete|| --- Comment #7 from Blou --- Created attachment 158004 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158004=edit Bug 28411: remove Koha::Config::Syspref(s) from C4::Context Use straigth SQL queries to access systempreferences instead of relying on the ORM, thus removing all direct and indirect dependencies to Koha::Object To remove all dependencies between C4::Context and the db object model, we move the calls to set_preference and delete_prefence directly to the class object Koha::Config::SysPrefs C4::Context::preference remains but uses straight SQL C4::Context::set_preference moves to Koha::Config::SysPrefs::set_preference C4::Context::delete_preference moves to Koha::Config::SysPrefs::delete_preference -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28411] Investigate memory footprint of the different dependencies
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28411
Blou changed:
What|Removed |Added
Attachment #157956|0 |1
is obsolete||
--- Comment #6 from Blou ---
Created attachment 158003
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158003=edit
Bug 28411: Use lazy loading to reduce memory footprint of C4/Context.pm
This simply removes some 'use' declarations at the top of the file to
instead use 'require' later on.
The effect can be validated with a simple one-liner (provided KOHA_CONF
and PERL5LIB being set)
perl -e "use C4::Context; while(1){sleep(1);}"
And monitoring the memoring usage in tools like 'top'
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35139] Filter holds to pull on current library and add 'View all libraries' link
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35139 --- Comment #5 from Fridolin Somers --- Created attachment 158002 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158002=edit Bug 35139: [ALTERNATE] Filter holds to pull on holding library and add 'View all libraries' link Like previous patch but with impact on items.holdingbranch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35139] Filter holds to pull on current library and add 'View all libraries' link
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35139 Fridolin Somers changed: What|Removed |Added Status|Signed Off |In Discussion --- Comment #4 from Fridolin Somers --- Ah our client ended with another version. Filter must be on item holding library. Exactly like the current filter at the bottom of table. Here is the alternate patch. I set to "in discussion" for feed backs. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29002] Add ability to book items ahead of time
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29002 Kyle M Hall changed: What|Removed |Added Status|Signed Off |Passed QA --- Comment #45 from Kyle M Hall --- Passing QA! I'll leave it to Martin and Tomas to deal with added sign-offs to the commits since they are on a gitlab branch ;) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19501] New list category to restrict specific lists to staff & hide from OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19501 Dani Elder changed: What|Removed |Added CC||danielle.elder@law.utexas.e ||du --- Comment #14 from Dani Elder --- I like the public (visible in catalog), private(only me), staff (only staff) lists options Donna mentioned. It would be nice if I could create a list for a project and share it to another staff person to do the work and add/delete/edit form the list as they complete the work without having to run a report(potentially resource intensive) each time. Ideally I would like to limit it to certain staff, but I would accept the option of all staff or none in lieu of no staff-side only list. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35063] Convert SelfCheckInMainUserBlock system preference to HTML customization
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35063 David Nind changed: What|Removed |Added Attachment #157921|0 |1 is obsolete|| --- Comment #8 from David Nind --- Created attachment 158001 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158001=edit Bug 35063: (follow-up) Add entry to HTML customization help include Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35063] Convert SelfCheckInMainUserBlock system preference to HTML customization
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35063 David Nind changed: What|Removed |Added Attachment #157920|0 |1 is obsolete|| --- Comment #7 from David Nind --- Created attachment 158000 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158000=edit Bug 35063: Convert SelfCheckInMainUserBlock system preference to HTML customization This patch moves the SelfCheckInMainUserBlock system preference into HTML customizations, making it possible to have language- and library-specific content. To test you should have some content in the SelfCheckInMainUserBlock system preference before applying the patch. Apply the patch, run the database update process, and rebuild the OPAC CSS. - In the staff client, go to Tools -> HTML customizations and verify that the content from SelfCheckInMainUserBlock is now stored there. - The HTML customization entry form should offer SelfCheckInMainUserBlock as a choice under "Display location." - Update and reinstall active translations (for instance fr-FR): - perl misc/translator/translate update fr-FR - perl misc/translator/translate install fr-FR - Enable the translation if necessary under Administration -> System preferences -> language. - Enable the "opaclanguagesdisplay" preference if necessary. - Edit the SelfCheckInMainUserBlock HTML customization and add unique content to the "fr-FR" tab. - Log into the self check-in system and confirm that the SelfCheckInMainUserBlock content is shown there. - Switch to your updated translation and confirm that the content you added for your translation shows up correctly. - Go to Administration -> System preferences and search for "SelfCheckInMainUserBlock." It should return no results. Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35063] Convert SelfCheckInMainUserBlock system preference to HTML customization
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35063 David Nind changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34232] Item groups dropdown on add item form does not respect display order
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34232 --- Comment #13 from Miranda Nero --- Oh gotcha, thanks. I was looking at the drop down menu from that other bug. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10762] Make it possible to adjust the barcode height and width on labels
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10762 --- Comment #43 from Tomás Cohen Arazi --- I fixed the first trivial case. One failing test remains. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10762] Make it possible to adjust the barcode height and width on labels
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10762 --- Comment #42 from Tomás Cohen Arazi --- Created attachment 157999 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157999=edit Bug 10762: Fix default values test This patch adds the new default values to the data structure the result is compared with. It also fixes the tests count (probably an untested rebase issue) Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10762] Make it possible to adjust the barcode height and width on labels
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10762 Tomás Cohen Arazi changed: What|Removed |Added Keywords||additional_work_needed --- Comment #41 from Tomás Cohen Arazi --- Please fix the tests or I will need to revert this from master. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31391] Staff-side recalls
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31391 David Nind changed: What|Removed |Added Status|Needs Signoff |Failed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35173] Call concat correctly for EDI SFTP Transport errors
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35173 --- Comment #3 from Tomás Cohen Arazi --- Pushed to master for 23.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35173] Call concat correctly for EDI SFTP Transport errors
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35173 Tomás Cohen Arazi changed: What|Removed |Added Version(s)||23.11.00 released in|| Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35003] Holds with cancellation requests table on waitingreserves.tt does not filter by branch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35003 --- Comment #4 from Tomás Cohen Arazi --- Pushed to master for 23.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35003] Holds with cancellation requests table on waitingreserves.tt does not filter by branch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35003 Tomás Cohen Arazi changed: What|Removed |Added Version(s)||23.11.00 released in|| Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35167] GET /items* broken if notforloan == 0 and itemtype.notforloan == NULL
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35167 --- Comment #10 from Tomás Cohen Arazi --- Pushed to master for 23.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35167] GET /items* broken if notforloan == 0 and itemtype.notforloan == NULL
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35167 Tomás Cohen Arazi changed: What|Removed |Added Status|Passed QA |Pushed to master Version(s)||23.11.00 released in|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35141] Prevent link_bibs_to_authorities from dying on search error
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35141 --- Comment #10 from Tomás Cohen Arazi --- Pushed to master for 23.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35141] Prevent link_bibs_to_authorities from dying on search error
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35141 Tomás Cohen Arazi changed: What|Removed |Added Version(s)||23.11.00 released in|| Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35043] Handling of \t in PO files is confusing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35043 --- Comment #9 from Tomás Cohen Arazi --- Pushed to master for 23.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35043] Handling of \t in PO files is confusing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35043 Tomás Cohen Arazi changed: What|Removed |Added Status|Passed QA |Pushed to master Version(s)||23.11.00 released in|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34678] Concurrent changes to the holds can fail due to primary key constraints
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34678 --- Comment #19 from Tomás Cohen Arazi --- Pushed to master for 23.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34678] Concurrent changes to the holds can fail due to primary key constraints
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34678 Tomás Cohen Arazi changed: What|Removed |Added Status|Passed QA |Pushed to master Version(s)||23.11.00 released in|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34136] Add ability to render a report using a notice template
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34136 --- Comment #12 from Tomás Cohen Arazi --- Pushed to master for 23.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34136] Add ability to render a report using a notice template
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34136 Tomás Cohen Arazi changed: What|Removed |Added Status|Passed QA |Pushed to master Version(s)||23.11.00 released in|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29523] Add a way to prevent embedding objects that should not be allowed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29523 --- Comment #192 from Tomás Cohen Arazi --- Pushed to master for 23.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29523] Add a way to prevent embedding objects that should not be allowed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29523 Tomás Cohen Arazi changed: What|Removed |Added Status|Passed QA |Pushed to master Version(s)||23.11.00 released in|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35119] Make bibliographic errors more prominent and match current styling
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35119 Tomás Cohen Arazi changed: What|Removed |Added Keywords|additional_work_needed | --- Comment #19 from Tomás Cohen Arazi --- Follow-up pushed to master. Thanks! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34232] Item groups dropdown on add item form does not respect display order
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34232 --- Comment #12 from Emily Lamancusa --- (In reply to Miranda Nero from comment #11) > If we are already on 22.11, are we supposed to be seeing this work > correctly? It's not for us. If you're on 22.11.08 or higher, then it should be working, but if you're on 22.11.07 or earlier, then it wouldn't be. Note that this fixes only the form for creating a new item - there's also bug 34234 (which hasn't been fixed yet) for the dialog box you get when adding an existing item to an item group. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34234] Item groups dropdown in detail.tt modal does not respect display order
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34234 Emily Lamancusa changed: What|Removed |Added Resolution|DUPLICATE |--- Status|RESOLVED|REOPENED --- Comment #2 from Emily Lamancusa --- This is not exactly a duplicate of 34232 - it's the same problem, but in a different place. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34232] Item groups dropdown on add item form does not respect display order
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34232 Miranda Nero changed: What|Removed |Added CC||mn...@oslri.net --- Comment #11 from Miranda Nero --- If we are already on 22.11, are we supposed to be seeing this work correctly? It's not for us. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35179] New: Limit MARC Modification Templates by User
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35179 Bug ID: 35179 Summary: Limit MARC Modification Templates by User Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Cataloging Assignee: koha-bugs@lists.koha-community.org Reporter: mn...@oslri.net QA Contact: testo...@bugs.koha-community.org CC: m.de.r...@rijksmuseum.nl We have multiple people using MARC Modification Templates for different workflows, so the list of templates is very long and requires a lot of scrolling if your template is at the bottom. It would be useful to have local or user specific templates, so we can create some that are not needed by others without making the list longer. Adding a column showing who created each template that we could limit by would not be perfect but would limit the amount of clicking and/or scrolling. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29390] Authorised values: Add a few missing foreign keys
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29390 Emily Lamancusa changed: What|Removed |Added CC||emily.lamancusa@montgomeryc ||ountymd.gov QA Contact|testo...@bugs.koha-communit |emily.lamancusa@montgomeryc |y.org |ountymd.gov -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28402] Add ability to view/edit MARC Modification Templates from the Batch Record Modification screen
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28402 --- Comment #1 from Miranda Nero --- I would find this useful and even more so it would be useful to be able to create a MARC modification template in the Batch Record Modification screen. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28402] Add ability to view/edit MARC Modification Templates from the Batch Record Modification screen
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28402 Miranda Nero changed: What|Removed |Added CC||mn...@oslri.net -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22712] Funds from inactive budgets appear on Item details if using MarcItemFieldstoOrder
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22712 Tomás Cohen Arazi changed: What|Removed |Added CC||tomasco...@gmail.com Keywords||rel_23_11_candidate -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34587] Add a Usage Statistics module to ERM
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34587 Tomás Cohen Arazi changed: What|Removed |Added Keywords||rel_23_11_candidate -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33960] Add ability to retrieve deleted biblios
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33960 Tomás Cohen Arazi changed: What|Removed |Added Keywords||rel_23_11_candidate -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33036] REST API: Merge biblio records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33036 --- Comment #27 from Katrin Fischer --- See here too: https://wiki.koha-community.org/wiki/Perltidy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34896] Separate Z39.50 permission from edit_catalogue
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34896 Angela Berrett changed: What|Removed |Added CC||angela.berrett@familysearch ||.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31074] Cached plugin code is used in Koha even after changes to plugin (install/upgrade/uninstall)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31074 --- Comment #25 from Victor Grousset/tuxayo --- (In reply to Martin Renvoize from comment #23) > I had a look to see if there was any obvious way to get the instance name or > track up to find the parent PID so we could call the HUP call mentioned > above.. but I failed so far. Is a SIGHUP on all starmans running on a large shared hosting server a paralyzing load? On the occasional plugin install/upgrade/uninstall. Or should it be okay and worth it for correctness sake until something else is found? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17617] Confirmation e-mail to patron when hold is placed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17617 Kelly McElligott changed: What|Removed |Added Status|Needs Signoff |Signed Off CC||ke...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17617] Confirmation e-mail to patron when hold is placed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17617 ByWater Sandboxes changed: What|Removed |Added Attachment #157964|0 |1 is obsolete|| --- Comment #9 from ByWater Sandboxes --- Created attachment 157998 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157998=edit Bug 17617: Confirmation email to patron when hold is placed This enhancement adds a new notice HOLDPLACED_PATRON that will be sent to a patron when a hold is placed for them. It depends on the new system preference EmailPatronWhenHoldIsPlaced to be enabled. To test: 1) Update database and restart services 2) Go to Koha Administration -> System preferences and search for the new EmailPatronWhenHoldIsPlaced syspref. It should be disabled by default - leave it disabled for now. 3) Search for a record and go to the Holds tab. Place a hold for your patron. 4) Go to your patron's account and go to the Notices tab. Confirm the HOLDPLACED_PATRON notice was NOT queued. 5) Enable the EmailPatronWhenHoldIsPlaced syspref. 6) Repeat steps 3 and 4. Confirm the HOLDPLACED_PATRON notice WAS generated and queued. 7) Confirm tests pass t/db_dependent/Holds.t Sponsored-by: Fire and Emergency New Zealand Signed-off-by: Kelly -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17617] Confirmation e-mail to patron when hold is placed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17617 ByWater Sandboxes changed: What|Removed |Added Attachment #157963|0 |1 is obsolete|| --- Comment #8 from ByWater Sandboxes --- Created attachment 157997 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157997=edit Bug 17617: Unit tests Signed-off-by: Kelly -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17617] Confirmation e-mail to patron when hold is placed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17617 ByWater Sandboxes changed: What|Removed |Added Attachment #157962|0 |1 is obsolete|| --- Comment #7 from ByWater Sandboxes --- Created attachment 157996 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157996=edit Bug 17617: Add HOLDPLACED_PATRON notice A HOLDPLACED notice exists and is used by the emailLibrarianWhenHoldIsPlaced function, but libraries may want to use different wording when emailing patrons. Signed-off-by: Kelly -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17617] Confirmation e-mail to patron when hold is placed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17617 ByWater Sandboxes changed: What|Removed |Added Attachment #157961|0 |1 is obsolete|| --- Comment #6 from ByWater Sandboxes --- Created attachment 157995 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157995=edit Bug 17617: EmailPatronWhenHoldIsPlaced system preference Signed-off-by: Kelly -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27119] Allow batch actions from item search results
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27119 Lisette Scheer changed: What|Removed |Added CC||lisette.scheer@bywatersolut ||ions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35178] Add option to save item search as an SQL report
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35178 --- Comment #1 from Lisette Scheer --- We would probably want this to be a permission and possible also a preference. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14322] Can't link to an item search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14322 Lisette Scheer changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=35178 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35178] Add option to save item search as an SQL report
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35178 Lisette Scheer changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=14322 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35178] Add option to save item search as an SQL report
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35178 Laura O'Neil changed: What|Removed |Added CC||la...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35178] New: Add option to save item search as an SQL report
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35178 Bug ID: 35178 Summary: Add option to save item search as an SQL report Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Searching Assignee: koha-bugs@lists.koha-community.org Reporter: lisette.sch...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org Add an option to save an item search as an SQL search. This would allow sharing/rerunning of item searches while lowering the threshold for reporting. Lisette -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33164] Return claim message shows intermittently when BlockReturnOfLostItems enabled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33164 Phil Ringnalda changed: What|Removed |Added Attachment #157710|0 |1 is obsolete|| --- Comment #6 from Phil Ringnalda --- Created attachment 157994 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157994=edit Bug 33164: Do not prevent processing of all error messages This follow-up patch removes the use of $exit_required_p completely. The sysprefs BlockReturnOfLostItems and BlockReturnOfWithdrawnItems are handled in other scripts, and should not prevent the processing of all returns error messages when enabled. Signed-off-by: Phil Ringnalda -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33164] Return claim message shows intermittently when BlockReturnOfLostItems enabled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33164 Phil Ringnalda changed: What|Removed |Added Attachment #147890|0 |1 is obsolete|| --- Comment #5 from Phil Ringnalda --- Created attachment 157993 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157993=edit Bug 33164: Ensure return claim message shows if lost item return blocked This fix ensures that a return claim confirmation always shows, even if the return of lost items has been blocked by BlockReturnOfLostItems being enabled. To test: 1. Set BlockReturnOfLostItems system preference to Block 2. Check out an item to a patron 3. Go to the patrons page and claim a return on the item 4. Check in the item and keep checking in the item. Notice the message "Item is lost, cannot be checked in." shows every time, but the return claim message only shows sometimes. 5. Apply the patch and restart services 6. Check in the item and keep checking in the item. Confirm both the lost message shows and the return claim message shows every time. 7. Confirm the return of the item is still blocked. Sponsored-by: Pymble Ladies' College Signed-off-by: Phil Ringnalda -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33164] Return claim message shows intermittently when BlockReturnOfLostItems enabled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33164 Phil Ringnalda changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32730] Add patron lists tab to patron details and circulation pages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32730
Kyle M Hall changed:
What|Removed |Added
Attachment #155575|0 |1
is obsolete||
Attachment #155589|0 |1
is obsolete||
--- Comment #29 from Kyle M Hall ---
Created attachment 157992
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157992=edit
Bug 32730: Add Patron Lists tab to patron details and circulation pages
Test Plan:
1. Apply patch
2. create a patron list if there aren't any
3. search for a patron
4. observe the "Patron lists" tab showing the list that the patron is not in
5. try adding the patron to the list and removing them from the list to
be sure the feature has full operation
6. click "Check Out" on the side bar menu to navigate to the circulation
page for this patron
7. observe the "Patron lists" tab, and verify it operates as it did on the
patron details page
Bug 32730: (follow-up) Minor corrections
by Owen Leonard
This patch corrects an instance of an incorrect capital letter
("Patron Lists" -> "Patron lists") and makes minor tweaks to
indentation.
Signed-off-by: Stina Hallin
Signed-off-by: Kyle M Hall
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32730] Add patron lists tab to patron details and circulation pages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32730 Kyle M Hall changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34587] Add a Usage Statistics module to ERM
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34587 Nick Clemens changed: What|Removed |Added Status|Signed Off |Passed QA --- Comment #28 from Nick Clemens --- Did a run through the code, a little clean up for QA tools - talked with the PFTS team and RM and our testers, all seems to be working well. Standalone module so no worries about the late push. Passing QA! Excellent work all! My SO lines are added on the remote branch. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34704] Print templates are formatted incorrectly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34704 --- Comment #26 from Martin Renvoize --- In my perfect world you'd have WYSIWYG and Codemirror options. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34704] Print templates are formatted incorrectly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34704 --- Comment #25 from Martin Renvoize --- I think if we're going whole hog here, we likely would want to switch the editor to allow the WYSIWYG option for html input to keep the simplicity option at user disposal. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34704] Print templates are formatted incorrectly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34704 --- Comment #24 from Martin Renvoize --- OK, I see you're points now. This was meant to be "least invasive", but I do agree it would be nice to drop it entirely and require proper HTML throughout for these notices. The challenge will be to write a DB update that looks at all the existing notices and fixes them for all current html notices to include the breaks. Also, we'd need to update all the existing default notices for install. This is all a much larger job that we were expecting to undertake here.. worthwhile I suppose, but I'm not sure where I'm going to find funding for that extra time. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35177] New: StripWhitespaceChars can break/depends on how data is copied
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35177 Bug ID: 35177 Summary: StripWhitespaceChars can break/depends on how data is copied Change sponsored?: --- Product: Koha Version: 23.05 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Cataloging Assignee: koha-bugs@lists.koha-community.org Reporter: esther.melan...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org CC: m.de.r...@rijksmuseum.nl Created attachment 157991 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157991=edit Highlighted text This refers to bug 30358 The enhancement generally works system wide but it depends on how data is copied to the clipboard. To confirm it works: 1. Enable the system preference to strip white spaces. 2. Find a biblio with an item that has a barcode. 3. Highlight the barcode starting from the end of the barcode to the first character and release the mouse button. 4. Copy the highlighted barcode to the clipboard and paste somewhere in Koha. See there are no white spaces in front of the barcode. To see it break: 1. Repeat the steps but highlight the barcode from the end of the barcode but allow the cursor to travel beyond the first digit of the barcode before releasing the mouse button. The screen will show the highlight only includes the barcode, but in reality additional white spaces are included. 2.Copy this "highlight" and paste it somewhere in Koha. 3. See that white spaces are included despite the system preference being enabled. Very often when highlighting data to copy to the clipboard, the "highlight" or mouse movement incorporates more than the visible data in an attempt to make sure everything is highlighted. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35111] Background jobs worker crashes on SIGPIPE when database connection lost in Ubuntu 22.04
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35111 Victor Grousset/tuxayo changed: What|Removed |Added CC||vic...@tuxayo.net --- Comment #19 from Victor Grousset/tuxayo --- Weird, I can't reproduce the issue (comment 3) with koha master, KTD image master-jammy, mariadb 10.6 Maybe there is another condition to get this. Regardless, as far a doing a simple signoff I can since the test plan is just about no-regression checking. So here it is so it's possible to swap roles with Marcel if they feel confident enough to pass QA. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35111] Background jobs worker crashes on SIGPIPE when database connection lost in Ubuntu 22.04
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35111 Victor Grousset/tuxayo changed: What|Removed |Added Attachment #157786|0 |1 is obsolete|| --- Comment #18 from Victor Grousset/tuxayo --- Created attachment 157990 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157990=edit Bug 35111: Ignore SIGPIPE in background jobs worker This change explicitly ignores SIGPIPE signals in the background jobs worker. Daemons like Starman ignore SIGPIPE so it makes sense to explicitly set this. Differences in the inner workings of MySQL vs MariaDB client libraries have yielded different behaviours in automatic reconnections and potentially SIGPIPE handling, so this helps to make the overall behaviour more consistent. Test plan: 0. Apply patch and run "restart_all" 1. Go to http://localhost:8081/cgi-bin/koha/catalogue/detail.pl?biblionumber=29 2. Click "Save" > "MARCXML" 3. Go to http://localhost:8081/cgi-bin/koha/tools/stage-marc-import.pl 4. Click "Choose file", choose the MARCXML file, click "Upload file" 5. Click "Stage for import" 6. Note the job is marked as "100% Finished" 7. In a separate window run "docker restart koha-db-1" 8. Repeat steps 3-5 for uploading file and running stage for import 9. Note that the job is marked as "100% Finished" as you'd expect Signed-off-by: Marcel de Rooy [EDIT] Added comment on the SIG PIPE line. Signed-off-by: Victor Grousset/tuxayo -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33809] Accessibility: OPAC results page needs more descriptive links
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33809 --- Comment #15 from Kyle M Hall --- Created attachment 157989 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157989=edit Bug 33809: Centralize duplicated code Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33809] Accessibility: OPAC results page needs more descriptive links
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33809
--- Comment #14 from Kyle M Hall ---
Created attachment 157988
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157988=edit
Bug 33809: (follow-up) Grammar correction
This is somewhat nitpicky but I think "Show fewer..." is more correct
than "Show less..." for strings like "Show fewer authors."
'Generally, fewer is used when the number of things is counted ("fewer
problems") whereas less is used when the number is measured ("less
trouble" or "less time").'
-- https://www.merriam-webster.com/words-at-play/fewer-vs-less
It's not a strict rule but to my ear it sounds more correct. The brief
"Show less" displayed on screen seems fine because the object feels
indeterminate: "Show less information."
Signed-off-by: Lucas Gass
Signed-off-by: Kyle M Hall
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33809] Accessibility: OPAC results page needs more descriptive links
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33809 --- Comment #13 from Kyle M Hall --- Created attachment 157987 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157987=edit Bug 33809: Place hold and Add to cart links need better descriptions The place hold and add to cart buttons should identify to screen readers which title the button is linked to. This patch adds aria-labels that include the item title to make this more clear Signed-off-by: Lucas Gass Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33809] Accessibility: OPAC results page needs more descriptive links
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33809 Kyle M Hall changed: What|Removed |Added Attachment #151606|0 |1 is obsolete|| Attachment #151607|0 |1 is obsolete|| Attachment #152050|0 |1 is obsolete|| Attachment #153121|0 |1 is obsolete|| --- Comment #12 from Kyle M Hall --- Created attachment 157986 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157986=edit Bug 33809: Facet "Show more/less" links don't identify what they are showing This patch addresses the Show more/less links in the side menu in opac-facets.inc. The links don't identify which facet they are linked to and this is confusing for screen readers. Signed-off-by: Lucas Gass Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33809] Accessibility: OPAC results page needs more descriptive links
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33809 Kyle M Hall changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35112] Return claims table showing on all patron tabs and not behaving as normal
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35112 Kris changed: What|Removed |Added CC||kbec...@jcls.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28410] [Omnibus] Reduce memory footprint
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28410 --- Comment #23 from Blou --- We were talking about moving all calls to preference(). updatedatabase.pl has had problems in the past when the code calls DB objects of the new version that do not correspond to the database that is currently being upgraded. So if systempreference gets modified, along with Koha::Config::Syspref (?) in 26.05, calling C4::Context->(set_)preference during the ugprade process on a database that is at 21.05 at that point... will crash, when using the underlying object. No? Maybe systempreference doesn't work like that, or maybe you have a new way of doing thing. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28410] [Omnibus] Reduce memory footprint
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28410 --- Comment #22 from Jonathan Druart --- (In reply to Blou from comment #21) > Did a quick check. There are a lot of them. > > One question: installer/data/mysql/updatedatabase.pl calls > C4::Context->preference, which is now an object call behind the scene. I > know updatedatabase is not the do-it-all anymore, but to ensure it still > works for years to come shouldn't we replace those calls by a local, > straight SQL call ? > > A few hundred calls to preference, and one to set_preference. > > > THAT SAID, pragmatism tells me to look for another way: Modify preference() > to use straight DB, and move all the calls to set_preference() and > delete_preference() to Koha::Config::Sysprefs. > > I'll test that in Bug 28411. Won't prevent major overhaul later, but seems > like a safe approach. Why do you want to remove C4::Context from updatedatabase? What would be the gain? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34940] Highlight logged-in library in facets
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34940 Martin Renvoize changed: What|Removed |Added Keywords|additional_work_needed | --- Comment #11 from Martin Renvoize --- Ignore that.. it's not this one. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34940] Highlight logged-in library in facets
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34940 Martin Renvoize changed: What|Removed |Added Keywords||additional_work_needed --- Comment #10 from Martin Renvoize --- I reckon this one could be the cause of one of our selenium failures.. investigating now. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35119] Make bibliographic errors more prominent and match current styling
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35119 Martin Renvoize changed: What|Removed |Added Attachment #157984|0 |1 is obsolete|| --- Comment #18 from Martin Renvoize --- Created attachment 157985 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157985=edit Bug 35119: Add back classes used for selenium tests This patch re-instates the classes used for the selenium tests.. I checked we weren't using them for javascript or css, but didn't think about tests before. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35119] Make bibliographic errors more prominent and match current styling
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35119 --- Comment #17 from Martin Renvoize --- Created attachment 157984 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157984=edit Bug 35119: Add back classes used for selenium tests This patch re-instates the classes used for the selenium tests.. I checked we weren't using them for javascript or css, but didn't think about tests before. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35176] New: Unable to delete itemnotes_nonpublic
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35176 Bug ID: 35176 Summary: Unable to delete itemnotes_nonpublic Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Staff interface Assignee: koha-bugs@lists.koha-community.org Reporter: david.robe...@ptfs-europe.com QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com Once an item record has been given a non-public note, it cannot be deleted other than directly in the database. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35175] New: MARC21: Display 700/710 $g - Miscellaneous information in detail and results pages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35175 Bug ID: 35175 Summary: MARC21: Display 700/710 $g - Miscellaneous information in detail and results pages Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: MARC Bibliographic data support Assignee: koha-bugs@lists.koha-community.org Reporter: katrin.fisc...@bsz-bw.de QA Contact: testo...@bugs.koha-community.org It would be nice if Koha allowed to display 700 and 710 $g in the detail pages and result lists as it already does for 711. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32195] Changing a patron category to disallow guarantors should remove existing guarantors
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32195 Liz Rea changed: What|Removed |Added CC||wizzy...@gmail.com --- Comment #1 from Liz Rea --- I think we just need to always show the "remove" link no matter what the category says - if there is a guarantor we at least need to be able to remove it. The main problem here being that we are editing the category underneath an existing patron and the settings aren't retroactive to patrons who now don't fit the defined category. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29002] Add ability to book items ahead of time
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29002 --- Comment #44 from Martin Renvoize --- Follow-up added to branch to deal with that case.. weirdly the recommended way to clear a select2 set doesn't actually clean up after itself fully so we need an additional call to .empty() to drop all the option tags it may have added in it's "first life". -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28410] [Omnibus] Reduce memory footprint
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28410 --- Comment #21 from Blou --- Did a quick check. There are a lot of them. One question: installer/data/mysql/updatedatabase.pl calls C4::Context->preference, which is now an object call behind the scene. I know updatedatabase is not the do-it-all anymore, but to ensure it still works for years to come shouldn't we replace those calls by a local, straight SQL call ? A few hundred calls to preference, and one to set_preference. THAT SAID, pragmatism tells me to look for another way: Modify preference() to use straight DB, and move all the calls to set_preference() and delete_preference() to Koha::Config::Sysprefs. I'll test that in Bug 28411. Won't prevent major overhaul later, but seems like a safe approach. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31184] Add default permissions by patron category
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31184 Sally changed: What|Removed |Added CC||sally.healey@cheshireshared ||services.gov.uk -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30579] When placing item level hold, some options that are not used are not disabled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30579 --- Comment #62 from Nick Clemens --- (In reply to Emily Lamancusa from comment #61) > Awesome, just tested the fixes and they all seem to be working! > Adding a tiny follow-up patch to fix what I assume is a copy/paste error, > though. > > In the "Use same conditions..." follow-up, shouldn't the button id still be > "hold_grp_btn" though? (the patch changed it to "hold_any_btn") Yes, lazy copy/pasta error, thank you for follow-up :-) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35074] Add --patron_category to writeoff_debts.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35074 --- Comment #9 from Martin Renvoize --- Patch split and SO cloned across.. All patches re-tidied and QA script no longer complaining. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35074] Add --patron_category to writeoff_debts.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35074 Martin Renvoize changed: What|Removed |Added Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
