[Koha-bugs] [Bug 20936] Holds history for patrons in OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20936 Tomás Cohen Arazi changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=35353 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20936] Holds history for patrons in OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20936 Tomás Cohen Arazi changed: What|Removed |Added Blocks|29526 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29526 [Bug 29526] Add 'Immediately delete holds history' button to patron privacy tab in opac -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20936] Holds history for patrons in OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20936 Nick Clemens changed: What|Removed |Added Blocks||29526 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29526 [Bug 29526] Add 'Immediately delete holds history' button to patron privacy tab in opac -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20936] Holds history for patrons in OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20936 Nick Clemens changed: What|Removed |Added Blocks||29525 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29525 [Bug 29525] Privacy settings for patrons should also affect holds history -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20936] Holds history for patrons in OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20936 Tomás Cohen Arazi changed: What|Removed |Added Blocks||28861 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28861 [Bug 28861] Item type column always hidden in holds history -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20936] Holds history for patrons in OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20936 Jonathan Druart changed: What|Removed |Added Blocks||28631 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28631 [Bug 28631] Holds History title link returns "not found" error -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20936] Holds history for patrons in OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20936 Andrew Fuerste-Henry changed: What|Removed |Added Blocks||27264 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27264 [Bug 27264] Reword sentence of OPACHoldsHistory -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20936] Holds history for patrons in OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20936
--- Comment #99 from Jonathan Druart
---
+var table = $("table_holdshistory").dataTable($.extend(true, {},
dataTablesDefaults, {
The selector is wrong, must be $("#table_holdshistory")
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20936] Holds history for patrons in OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20936 --- Comment #98 from Katrin Fischer --- "your holds history" tab label doesn't appear on translate yet? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20936] Holds history for patrons in OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20936 Lucas Gass changed: What|Removed |Added CC||lu...@bywatersolutions.com --- Comment #97 from Lucas Gass --- enhancement will not be backported t0 20.05.x -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20936] Holds history for patrons in OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20936 Martin Renvoize changed: What|Removed |Added Keywords|release-notes-needed| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20936] Holds history for patrons in OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20936 Jonathan Druart changed: What|Removed |Added Version(s)||20.11.00 released in|| Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20936] Holds history for patrons in OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20936 --- Comment #96 from Jonathan Druart --- Pushed to master for 20.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20936] Holds history for patrons in OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20936 Jonathan Druart changed: What|Removed |Added Keywords||release-notes-needed -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20936] Holds history for patrons in OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20936 --- Comment #93 from Agustín Moyano --- Created attachment 113447 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113447=edit Bug 20936: Add patron's hold history menu in OPAC This patch adds patron's hold history in OPAC. To test: 1. apply this patch 2. Find a patron, place several holds and cancel or fulfill them 3. Go to patron's opac CHECK => There is no 'your holds history' option in menu 4. In admin preferences enable OPACHoldsHistory 5. Go back to patron's opac SUCCESS => There is a 'your holds history' menu option => Holds history displays all holds 6. Change order, and list limit SUCCESS => All controls work as expected 7. Sign off. Signed-off-by: Todd Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20936] Holds history for patrons in OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20936 Agustín Moyano changed: What|Removed |Added Attachment #112730|0 |1 is obsolete|| Attachment #112731|0 |1 is obsolete|| Attachment #112732|0 |1 is obsolete|| Attachment #112733|0 |1 is obsolete|| --- Comment #92 from Agustín Moyano --- Created attachment 113446 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113446=edit Bug 20936: Add OPACHoldsHistory syspref Signed-off-by: Kyle M Hall Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20936] Holds history for patrons in OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20936 --- Comment #95 from Agustín Moyano --- Created attachment 113449 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113449=edit Bug 20936: (follow-up) add biblio and item relation to old holds and set a limit on search holds -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20936] Holds history for patrons in OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20936 --- Comment #94 from Agustín Moyano --- Created attachment 113448 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113448=edit Bug 20936: (QA follow-up) Use Branches template plugin Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20936] Holds history for patrons in OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20936 Agustín Moyano changed: What|Removed |Added Status|In Discussion |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20936] Holds history for patrons in OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20936 --- Comment #91 from Agustín Moyano --- (In reply to Jonathan Druart from comment #86) > (In reply to Jonathan Druart from comment #85) > > What happened between May (comment 74) and now? Did we fix all the things we > > needed? > > Ok, got it, we are not using the REST API. > > The controller script is weird. We are retrieving all the holds and then > limit the size of the array. We will face performance issues without the > benefit (having the info on the UI). We are retrieving all holds from a single patron. The controller looks weird because it grabs current holds and old holds, join and sort them and then limit the result.. When I coded this I could not use client side pagination, because unlike staff interface, there are no css classes prepared for datatables controles and it looked pretty ugly. I do not believe we'll face performance issues.. even if a patron placed 500 holds, penalties would be marginal. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20936] Holds history for patrons in OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20936 Jonathan Druart changed: What|Removed |Added Status|Passed QA |In Discussion -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20936] Holds history for patrons in OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20936 --- Comment #90 from Jonathan Druart --- Can I get an answer on my last 2 comments please? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20936] Holds history for patrons in OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20936 --- Comment #89 from Tomás Cohen Arazi --- (In reply to Jonathan Druart from comment #85) > What happened between May (comment 74) and now? Did we fix all the things we > needed? We dropped the development using the API, and moved back to doing the old .pl way. And there were no remaining issues, besides the failure with the QA scripts Katrin reported. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20936] Holds history for patrons in OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20936 --- Comment #88 from Jonathan Druart --- What about: 1. display all if <= X (50, 100?) 2. If >X then we only display current holds with an option (checkbox) to display old ones as well? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20936] Holds history for patrons in OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20936 --- Comment #87 from Jonathan Druart --- Erk, and you have to, because of the sort option. What about: 1. display all if <= X (50, 100?) 2. If >X then we remove the sort? That's ugly but.. I am lacking imagination right now. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20936] Holds history for patrons in OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20936 --- Comment #86 from Jonathan Druart --- (In reply to Jonathan Druart from comment #85) > What happened between May (comment 74) and now? Did we fix all the things we > needed? Ok, got it, we are not using the REST API. The controller script is weird. We are retrieving all the holds and then limit the size of the array. We will face performance issues without the benefit (having the info on the UI). -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20936] Holds history for patrons in OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20936 --- Comment #85 from Jonathan Druart --- What happened between May (comment 74) and now? Did we fix all the things we needed? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20936] Holds history for patrons in OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20936 Nick Clemens changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20936] Holds history for patrons in OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20936 --- Comment #84 from Nick Clemens --- Created attachment 112733 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112733=edit Bug 20936: (QA follow-up) Use Branches template plugin Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20936] Holds history for patrons in OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20936 Nick Clemens changed: What|Removed |Added Attachment #112667|0 |1 is obsolete|| Attachment #112668|0 |1 is obsolete|| --- Comment #81 from Nick Clemens --- Created attachment 112730 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112730=edit Bug 20936: Add OPACHoldsHistory syspref Signed-off-by: Kyle M Hall Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20936] Holds history for patrons in OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20936 --- Comment #82 from Nick Clemens --- Created attachment 112731 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112731=edit Bug 20936: Add patron's hold history menu in OPAC This patch adds patron's hold history in OPAC. To test: 1. apply this patch 2. Find a patron, place several holds and cancel or fulfill them 3. Go to patron's opac CHECK => There is no 'your holds history' option in menu 4. In admin preferences enable OPACHoldsHistory 5. Go back to patron's opac SUCCESS => There is a 'your holds history' menu option => Holds history displays all holds 6. Change order, and list limit SUCCESS => All controls work as expected 7. Sign off. Signed-off-by: Todd Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20936] Holds history for patrons in OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20936 --- Comment #83 from Nick Clemens --- Created attachment 112732 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112732=edit Bug 20936: (QA follow-up) Remove OPACHoldsPrivacy reference Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20936] Holds history for patrons in OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20936 Agustín Moyano changed: What|Removed |Added Attachment #104466|0 |1 is obsolete|| Attachment #105131|0 |1 is obsolete|| --- Comment #79 from Agustín Moyano --- Created attachment 112667 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112667=edit Bug 20936: Add OPACHoldsHistory syspref Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20936] Holds history for patrons in OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20936 --- Comment #80 from Agustín Moyano --- Created attachment 112668 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112668=edit Bug 20936: Add patron's hold history menu in OPAC This patch adds patron's hold history in OPAC. To test: 1. apply this patch 2. Find a patron, place several holds and cancel or fulfill them 3. Go to patron's opac CHECK => There is no 'your holds history' option in menu 4. In admin preferences enable OPACHoldsHistory 5. Go back to patron's opac SUCCESS => There is a 'your holds history' menu option => Holds history displays all holds 6. Change order, and list limit SUCCESS => All controls work as expected 7. Sign off. Signed-off-by: Todd -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20936] Holds history for patrons in OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20936 Agustín Moyano changed: What|Removed |Added Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20936] Holds history for patrons in OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20936 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Failed QA Summary|Holds History for patrons |Holds history for patrons |in OPAC |in OPAC --- Comment #78 from Katrin Fischer --- Can you please check the QA tools failure? FAIL koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-holdshistory.tt FAIL valid_template ColumnsSettings: plugin not found -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20936] Holds History for patrons in OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20936 Tomás Cohen Arazi changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20936] Holds History for patrons in OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20936 ByWater Sandboxes changed: What|Removed |Added Attachment #104467|0 |1 is obsolete|| --- Comment #77 from ByWater Sandboxes --- Created attachment 105131 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105131=edit Bug 20936: Add patron's hold history menu in OPAC This patch adds patron's hold history in OPAC. To test: 1. apply this patch 2. Find a patron, place several holds and cancel or fulfill them 3. Go to patron's opac CHECK => There is no 'your holds history' option in menu 4. In admin preferences enable OPACHoldsHistory 5. Go back to patron's opac SUCCESS => There is a 'your holds history' menu option => Holds history displays all holds 6. Change order, and list limit SUCCESS => All controls work as expected 7. Sign off. Signed-off-by: Todd -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20936] Holds History for patrons in OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20936 Martin Renvoize changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=25260 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20936] Holds History for patrons in OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20936 Agustín Moyano changed: What|Removed |Added Depends on|24455, 24561, 24980, 25032, | |25044, 24302, 24432 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24302 [Bug 24302] Add a way to specify nested objects to embed in OpenAPI https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24432 [Bug 24432] order_by broken for date columns https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24455 [Bug 24455] Date formatting from JS https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24561 [Bug 24561] Add a datatables API wrapper https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24980 [Bug 24980] Date formatting from JS - use timezone only with dates with offset https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25032 [Bug 25032] Generic unhandled exception handling https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25044 [Bug 25044] No need to define koha_object[s]_class for standard object class names -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20936] Holds History for patrons in OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20936 --- Comment #76 from Agustín Moyano --- Created attachment 104467 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104467=edit Bug 20936: Add patron's hold history menu in OPAC This patch adds patron's hold history in OPAC. To test: 1. apply this patch 2. Find a patron, place several holds and cancel or fulfill them 3. Go to patron's opac CHECK => There is no 'your holds history' option in menu 4. In admin preferences enable OPACHoldsHistory 5. Go back to patron's opac SUCCESS => There is a 'your holds history' menu option => Holds history displays all holds 6. Change order, and list limit SUCCESS => All controls work as expected 7. Sign off. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20936] Holds History for patrons in OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20936 Agustín Moyano changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20936] Holds History for patrons in OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20936 Agustín Moyano changed: What|Removed |Added Attachment #103948|0 |1 is obsolete|| Attachment #103949|0 |1 is obsolete|| Attachment #104040|0 |1 is obsolete|| Attachment #104041|0 |1 is obsolete|| --- Comment #75 from Agustín Moyano --- Created attachment 104466 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104466=edit Bug 20936: Add OPACHoldsHistory syspref Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20936] Holds History for patrons in OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20936 --- Comment #74 from Tomás Cohen Arazi --- (In reply to Agustín Moyano from comment #73) > (In reply to Jonathan Druart from comment #60) > > Use of union could be a solution, but I don't think it could be implemented > > easily, see bug 25043 for an example using DBIx::Class::ResultSet > > > > https://metacpan.org/pod/DBIx::Class::Helper::ResultSet::SetOperations > > Throwing the towel here, at least untill bug 25260 gets pushed.. > > union cannot be used here, because it doesn't accept prefetch of tables, and > we need to filter and order by prefetched tables, and making a view with the > union of both tables won't work either, because it hasn't got relationships > with other tables. > > I'll have to put the logic in the pl file and wait till > reserves/old_reserves get merged properly. You did a great job anyways, Agustín. Don't let this put you down! We'll finish this and more with the API really soon! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20936] Holds History for patrons in OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20936 --- Comment #73 from Agustín Moyano --- (In reply to Jonathan Druart from comment #60) > Use of union could be a solution, but I don't think it could be implemented > easily, see bug 25043 for an example using DBIx::Class::ResultSet > > https://metacpan.org/pod/DBIx::Class::Helper::ResultSet::SetOperations Throwing the towel here, at least untill bug 25260 gets pushed.. union cannot be used here, because it doesn't accept prefetch of tables, and we need to filter and order by prefetched tables, and making a view with the union of both tables won't work either, because it hasn't got relationships with other tables. I'll have to put the logic in the pl file and wait till reserves/old_reserves get merged properly. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20936] Holds History for patrons in OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20936
--- Comment #72 from Agustín Moyano ---
(In reply to Tomás Cohen Arazi from comment #71)
> (In reply to Josef Moravec from comment #68)
> > Comment on attachment 103950 [details] [review] [review]
> > Bug 20936: Add patron's hold history menu in OPAC
> >
> > Review of attachment 103950 [details] [review] [review]:
> > -
> >
> > ::: Koha/REST/V1/Patrons/Holds.pm
> > @@ +61,5 @@
> > > +my $holds = $c->objects->search( $holds_set );
> > > +return $c->render( status => 200, openapi => $holds );
> > > +}
> > > +catch {
> > > +$c->unhandlede_exception($_);
> >
> > typo, should be unhandled_excecption
>
> Done!
>
> > @@ +118,5 @@
> > > +[% INCLUDE 'datatables.inc' %]
> > > +[% INCLUDE 'js-date-format.inc' %]
> > >
[Koha-bugs] [Bug 20936] Holds History for patrons in OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20936
--- Comment #71 from Tomás Cohen Arazi ---
(In reply to Josef Moravec from comment #68)
> Comment on attachment 103950 [details] [review]
> Bug 20936: Add patron's hold history menu in OPAC
>
> Review of attachment 103950 [details] [review]:
> -
>
> ::: Koha/REST/V1/Patrons/Holds.pm
> @@ +61,5 @@
> > +my $holds = $c->objects->search( $holds_set );
> > +return $c->render( status => 200, openapi => $holds );
> > +}
> > +catch {
> > +$c->unhandlede_exception($_);
>
> typo, should be unhandled_excecption
Done!
> @@ +118,5 @@
> > +[% INCLUDE 'datatables.inc' %]
> > +[% INCLUDE 'js-date-format.inc' %]
> >
[Koha-bugs] [Bug 20936] Holds History for patrons in OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20936 --- Comment #70 from Tomás Cohen Arazi --- Created attachment 104041 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104041=edit Bug 20936: Add API tests Add test to /api/v1/public/patrons/:patron_id/holds endpoint To test: 1. prove t/db_dependent/api/v1/patrons_holds.t -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20936] Holds History for patrons in OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20936 Tomás Cohen Arazi changed: What|Removed |Added Attachment #103951|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20936] Holds History for patrons in OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20936
--- Comment #69 from Tomás Cohen Arazi ---
Created attachment 104040
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104040=edit
Bug 20936: Add patron's hold history menu in OPAC
This patch adds patron's hold history in OPAC. Right now, it only shows records
from old_reserves table, but I'll wait till bug 20271 is pushed to show full
history (old and new holds)
To test:
1. apply this patch
2. Find a patron, place several holds and cancel or fulfill them
3. Go to patron's opac
CHECK => There is no 'your holds history' option in menu
4. In admin preferences enable OPACHoldsHistory
5. Go back to patron's opac
SUCCESS => There is a 'your holds history' menu option
=> Holds history displays all holds canceled or fulfilled
6. Filter, order and change page
SUCCESS => All controls work as expected
7. Sign off.
Table content is fetched from the api. If you see data, and you can order and
filter then please sign off bug 24561.
Date columns use $date function to transform dates strings from api (for
example '2020-02-20') to 'dateformat' prefernce format ('02/20/20202'). If you
change dateformat prefernce and see the changes reflected in date columns,
please sign off bug 24455.
Signed-off-by: Kyle M Hall
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20936] Holds History for patrons in OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20936 Tomás Cohen Arazi changed: What|Removed |Added Attachment #103950|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20936] Holds History for patrons in OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20936 Josef Moravec changed: What|Removed |Added Status|Signed Off |Failed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20936] Holds History for patrons in OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20936
--- Comment #68 from Josef Moravec ---
Comment on attachment 103950
--> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103950
Bug 20936: Add patron's hold history menu in OPAC
Review of attachment 103950:
-->
(https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html=20936=103950)
-
::: Koha/REST/V1/Patrons/Holds.pm
@@ +61,5 @@
> +my $holds = $c->objects->search( $holds_set );
> +return $c->render( status => 200, openapi => $holds );
> +}
> +catch {
> +$c->unhandlede_exception($_);
typo, should be unhandled_excecption
::: koha-tmpl/opac-tmpl/bootstrap/en/includes/usermenu.inc
@@ +58,4 @@
> your search
> history
> [% END %]
>
> +[% IF opacreadinghistory || Koha.Preference('OPACHoldsHistory')
> == 1 %]
You don't need this combined condition
@@ +77,2 @@
> [% END %]
> +[% IF ( OPACPrivacy || Koha.Preference('OPACHoldsPrivacy')
> == 1 ) %]
the OPACHoldsPrivacy does not exist, this change should be reverted
::: koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-holdshistory.tt
@@ +3,5 @@
> +[% USE KohaDates %]
> +[% INCLUDE 'doc-head-open.inc' %]
> +[% IF ( LibraryNameTitle ) %][% LibraryNameTitle | html %][% ELSE
> %]Koha online[% END %] catalog Your holds history
> +[% INCLUDE 'doc-head-close.inc' %]
> +[% BLOCK cssinclude %]
CSS should be in own file and added by Asset plugin
@@ +118,5 @@
> +[% INCLUDE 'datatables.inc' %]
> +[% INCLUDE 'js-date-format.inc' %]
>
[Koha-bugs] [Bug 20936] Holds History for patrons in OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20936 Tomás Cohen Arazi changed: What|Removed |Added Status|Failed QA |Signed Off --- Comment #67 from Tomás Cohen Arazi --- (In reply to Jonathan Druart from comment #57) > Some more QA comments: > > 1. Enabled by default? > At least it should not in the upgrade. Solved. > 2. Users can still access their holds history using the REST API even if the > pref is off, is that expected? I think it is, the syspref is about visibility. > 5. return (data&&$date(data))||''; > Should be removed (see one of the follow-ups on bug 24980). What is the status of that bug and why is it still In discussion? > 7. why do you need koha_objects_class for items and biblios in the schema? > You should not. This is fixed. > 8. DBIC schema adds FK on old_reserves, that's wrong. It adds relationships. There's nothing wrong about it, They are used in Koha::Objects->to_api to embed related objects. > 9. Even if Signed off already, please squash some patches when needed > (rename of the script for instance). Done -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20936] Holds History for patrons in OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20936 Tomás Cohen Arazi changed: What|Removed |Added Depends on||25032 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25032 [Bug 25032] Generic unhandled exception handling -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20936] Holds History for patrons in OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20936
--- Comment #65 from Tomás Cohen Arazi ---
Created attachment 103950
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103950=edit
Bug 20936: Add patron's hold history menu in OPAC
This patch adds patron's hold history in OPAC. Right now, it only shows records
from old_reserves table, but I'll wait till bug 20271 is pushed to show full
history (old and new holds)
To test:
1. apply this patch
2. Find a patron, place several holds and cancel or fulfill them
3. Go to patron's opac
CHECK => There is no 'your holds history' option in menu
4. In admin preferences enable OPACHoldsHistory
5. Go back to patron's opac
SUCCESS => There is a 'your holds history' menu option
=> Holds history displays all holds canceled or fulfilled
6. Filter, order and change page
SUCCESS => All controls work as expected
7. Sign off.
Table content is fetched from the api. If you see data, and you can order and
filter then please sign off bug 24561.
Date columns use $date function to transform dates strings from api (for
example '2020-02-20') to 'dateformat' prefernce format ('02/20/20202'). If you
change dateformat prefernce and see the changes reflected in date columns,
please sign off bug 24455.
Signed-off-by: Kyle M Hall
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20936] Holds History for patrons in OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20936 --- Comment #66 from Tomás Cohen Arazi --- Created attachment 103951 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103951=edit Bug 20936: Add API tests Add test to /api/v1/public/patrons/:patron_id/holds endpoint To test: 1. prove t/db_dependent/api/v1/patrons_holds.t -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20936] Holds History for patrons in OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20936 --- Comment #64 from Tomás Cohen Arazi --- Created attachment 103949 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103949=edit Bug 20936: Add required relations for the OldReserve schema In order to make it work as the Reserve schema, we need those relations defined so we can fetch related object (e.g items). -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20936] Holds History for patrons in OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20936 --- Comment #63 from Tomás Cohen Arazi --- Created attachment 103948 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103948=edit Bug 20936: Add OPACHoldsHistory syspref Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20936] Holds History for patrons in OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20936 Tomás Cohen Arazi changed: What|Removed |Added Attachment #101727|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20936] Holds History for patrons in OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20936 Tomás Cohen Arazi changed: What|Removed |Added Attachment #101725|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20936] Holds History for patrons in OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20936 Tomás Cohen Arazi changed: What|Removed |Added Attachment #101726|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20936] Holds History for patrons in OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20936 Tomás Cohen Arazi changed: What|Removed |Added Attachment #101915|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20936] Holds History for patrons in OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20936 Tomás Cohen Arazi changed: What|Removed |Added Attachment #101724|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20936] Holds History for patrons in OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20936 Tomás Cohen Arazi changed: What|Removed |Added Attachment #102166|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20936] Holds History for patrons in OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20936 --- Comment #62 from Jonathan Druart --- (In reply to Jonathan Druart from comment #60) > Use of union could be a solution, but I don't think it could be implemented > easily, see bug 25043 for an example using DBIx::Class::ResultSet > > https://metacpan.org/pod/DBIx::Class::Helper::ResultSet::SetOperations If that does not work (or hard to implement), did you try to create a view? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20936] Holds History for patrons in OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20936 Jonathan Druart changed: What|Removed |Added Depends on||25044 --- Comment #61 from Jonathan Druart --- (In reply to Jonathan Druart from comment #57) > 7. why do you need koha_objects_class for items and biblios in the schema? > You should not. See bug 25044. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25044 [Bug 25044] No need to define koha_object[s]_class for standard object class names -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20936] Holds History for patrons in OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20936 Jonathan Druart changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=25043 --- Comment #60 from Jonathan Druart --- Use of union could be a solution, but I don't think it could be implemented easily, see bug 25043 for an example using DBIx::Class::ResultSet https://metacpan.org/pod/DBIx::Class::Helper::ResultSet::SetOperations -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20936] Holds History for patrons in OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20936 --- Comment #59 from Jonathan Druart --- (In reply to Tomás Cohen Arazi from comment #58) > (In reply to Jonathan Druart from comment #57) > > > > 7. why do you need koha_objects_class for items and biblios in the schema? > > You should not. > > Take a look at Koha::Object->prefetch_whitelist, it is used to recursively > embed objects. Koha::Object->_get_object_class should be called instead. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20936] Holds History for patrons in OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20936 --- Comment #58 from Tomás Cohen Arazi --- (In reply to Jonathan Druart from comment #57) > > 7. why do you need koha_objects_class for items and biblios in the schema? > You should not. Take a look at Koha::Object->prefetch_whitelist, it is used to recursively embed objects. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20936] Holds History for patrons in OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20936
Jonathan Druart changed:
What|Removed |Added
Status|Signed Off |Failed QA
--- Comment #57 from Jonathan Druart
---
Some more QA comments:
1. Enabled by default?
At least it should not in the upgrade.
2. Users can still access their holds history using the REST API even if the
pref is off, is that expected?
3. in controller script:
55 my $borr = Koha::Patrons->find( $borrowernumber )->unblessed;
56
57 $template->param(%{$borr});
Sure we need that?
4. Too many use statements in controller script
5. return (data&&$date(data))||'';
Should be removed (see one of the follow-ups on bug 24980).
6.
koha-tmpl/opac-tmpl/bootstrap/en/includes/usermenu.inc:[% IF (
OPACPrivacy || Koha.Preference('OPACHoldsPrivacy') == 1 ) %]
OPACHoldsPrivacy is coming from nowhere?
7. why do you need koha_objects_class for items and biblios in the schema? You
should not.
8. DBIC schema adds FK on old_reserves, that's wrong.
9. Even if Signed off already, please squash some patches when needed (rename
of the script for instance).
(In reply to Agustín Moyano from comment #56)
> Basically yes.. seeing that bug 20271 was moving, I suspected that it was
> going to happen in a reasonable time.
>
> Is it far from happening?, what would you suggest?
Bug 20271 is far from happening, cannot imagine reserves/old_reserves...
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20936] Holds History for patrons in OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20936 --- Comment #56 from Agustín Moyano --- (In reply to Jonathan Druart from comment #54) > > (In reply to Jonathan Druart from comment #11) > > > 0. Dates look great now! :) > > > > > > 1. Why not having current holds in the table (behavior intranet-side, > > > members/holdshistory.pl) > > > > Controller uses object.search, and places order by in dbic.. to replicate > > current behaviour in intranet I should one object.search for both current > > and old holds, merge and sort both arrays depending on search column... I > > decided to wait till requests and old_requests tables were merged to have > > current intranet behaviour > > This is not going to happen any time soon. > > > > 2. Is there a plan to make existing intranet-side view using the REST API? > > > ie. only 1 code to maintain. > > > > > > > Once we can replicate current intranet behaviour, we can think on changing > > intranet-side > > So waiting for tables to be merged? Basically yes.. seeing that bug 20271 was moving, I suspected that it was going to happen in a reasonable time. Is it far from happening?, what would you suggest? Thanks -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20936] Holds History for patrons in OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20936 --- Comment #55 from Tomás Cohen Arazi --- (In reply to Jonathan Druart from comment #54) > > (In reply to Jonathan Druart from comment #11) > > > 0. Dates look great now! :) > > > > > > 1. Why not having current holds in the table (behavior intranet-side, > > > members/holdshistory.pl) > > > > Controller uses object.search, and places order by in dbic.. to replicate > > current behaviour in intranet I should one object.search for both current > > and old holds, merge and sort both arrays depending on search column... I > > decided to wait till requests and old_requests tables were merged to have > > current intranet behaviour > > This is not going to happen any time soon. > > > > 2. Is there a plan to make existing intranet-side view using the REST API? > > > ie. only 1 code to maintain. > > > > > > > Once we can replicate current intranet behaviour, we can think on changing > > intranet-side > > So waiting for tables to be merged? We don't need to solve intranet-side on this bug :-D -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20936] Holds History for patrons in OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20936 --- Comment #54 from Jonathan Druart --- > (In reply to Jonathan Druart from comment #11) > > 0. Dates look great now! :) > > > > 1. Why not having current holds in the table (behavior intranet-side, > > members/holdshistory.pl) > > Controller uses object.search, and places order by in dbic.. to replicate > current behaviour in intranet I should one object.search for both current > and old holds, merge and sort both arrays depending on search column... I > decided to wait till requests and old_requests tables were merged to have > current intranet behaviour This is not going to happen any time soon. > > 2. Is there a plan to make existing intranet-side view using the REST API? > > ie. only 1 code to maintain. > > > > Once we can replicate current intranet behaviour, we can think on changing > intranet-side So waiting for tables to be merged? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20936] Holds History for patrons in OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20936 --- Comment #53 from Jonathan Druart --- Copy/pasting a comment from bug 24980 (I sent it to the wrong bug number): """ Hi Jonathan, (In reply to Jonathan Druart from comment #11) > 0. Dates look great now! :) > > 1. Why not having current holds in the table (behavior intranet-side, > members/holdshistory.pl) Controller uses object.search, and places order by in dbic.. to replicate current behaviour in intranet I should one object.search for both current and old holds, merge and sort both arrays depending on search column... I decided to wait till requests and old_requests tables were merged to have current intranet behaviour > > 2. Is there a plan to make existing intranet-side view using the REST API? > ie. only 1 code to maintain. > Once we can replicate current intranet behaviour, we can think on changing intranet-side > 3. Why only 10 results displayed by default? Usually 20 > ok, will change that > 4. Why no way to modify the number of results displayed? Basically, why > DataTable does not display as other table? (like no page number, search box, > etc.) > Is that the OPAC style? > OPAC has no style for DataTables.. only intranet has. What you see in other tables in OPAC was coded outside DataTables. I thought it best to have a search box and page number, but I'm open to suggestions. > 5. Not translatable strings: > 187 if(row.cancelation_date) return 'Canceled'; > 188 if (data == 'F') return 'Fulfilled'; > 189 if (data == 'W') return 'Waiting'; > 190 if (data == 'T') return 'In Transit'; > 191 return 'Pending'; > Good catch.. will fix that > 6. opac-holdsrecord.pl vs members/holdshistory.pl > Should not we use the same script names? copied the name from opac-readingrecord, but it can be changed Comment 14 Agustín Moyano(reporter)(assignee) 2020-03-30 17:53:20 CEST (In reply to Jonathan Druart from comment #12) > 7. Should not deal with that in js-date-format.inc? > (data&&$date(data))||''; ok, it can be done """ -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20936] Holds History for patrons in OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20936 Agustín Moyano changed: What|Removed |Added Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20936] Holds History for patrons in OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20936 --- Comment #52 from Agustín Moyano --- Created attachment 102166 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102166=edit Bug 20936: (follow-up) change opac-holdsrecord to opac-holdshistory, set translatable strings and set rows per page to 20 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20936] Holds History for patrons in OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20936 Agustín Moyano changed: What|Removed |Added Status|Signed Off |Failed QA --- Comment #51 from Agustín Moyano --- Failed QA because of comment 11 of bug 24980, that are really for this bug https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24980#c11 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20936] Holds History for patrons in OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20936 --- Comment #50 from Agustín Moyano --- Created attachment 101915 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101915=edit Bug 20936: (follow-up) use modified by bug 24980, fix display of page info and fix search without enter -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20936] Holds History for patrons in OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20936 Martin Renvoize changed: What|Removed |Added CC||n...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20936] Holds History for patrons in OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20936 --- Comment #49 from Martin Renvoize --- Just spotted.. we need to add the `Sponsored-by: ` Line into at least one of the patches for the release notes ;) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20936] Holds History for patrons in OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20936 --- Comment #48 from Martin Renvoize --- With the new dependency added I believe we are unblocked again here.. resetting to signed off. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20936] Holds History for patrons in OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20936 Martin Renvoize changed: What|Removed |Added Status|BLOCKED |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20936] Holds History for patrons in OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20936 Martin Renvoize changed: What|Removed |Added Status|Failed QA |BLOCKED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20936] Holds History for patrons in OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20936 --- Comment #47 from Martin Renvoize --- Moved followup to bug 24980 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20936] Holds History for patrons in OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20936 Martin Renvoize changed: What|Removed |Added Attachment #101772|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20936] Holds History for patrons in OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20936 --- Comment #46 from Martin Renvoize --- Agustin, could you take a look at my followup and confirm that it makes sense? I think I should probably push it as an RM follow-up to bug 24455 rather than here.. but would like a sanity check from you first. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20936] Holds History for patrons in OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20936 --- Comment #45 from Martin Renvoize --- Created attachment 101772 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101772=edit Bug 20936: (QA follow-up) Only add timezone if date-time This patch prevents a timezone from being assigned to the js moment if the input string is only at the full-date and not date-time resolution -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20936] Holds History for patrons in OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20936 --- Comment #44 from Martin Renvoize --- Totally makes sense.. your right. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20936] Holds History for patrons in OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20936 Agustín Moyano changed: What|Removed |Added Depends on||24980 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24980 [Bug 24980] Date formatting from JS - use timezone only with dates with offset -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20936] Holds History for patrons in OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20936
--- Comment #43 from Agustín Moyano ---
(In reply to Martin Renvoize from comment #40)
> Comment on attachment 101726 [details] [review]
> Bug 20936: Add patron's hold history menu in OPAC
>
> Review of attachment 101726 [details] [review]:
> -
>
> ::: api/v1/swagger/paths/public_patrons.json
> @@ +301,5 @@
> > + {
> > +"name": "timestamp",
> > +"in": "query",
> > +"description": "Time of latest update",
> > +"type": "string"
>
> This feels wrong.. surely this needs a `format: date-time` entry
>
> @@ +313,5 @@
> > + {
> > +"name": "waiting_date",
> > +"in": "query",
> > +"description": "Date the item was marked as waiting
> > for the patron",
> > +"type": "string"
>
> This feels wrong.. surely this needs a `format: date-time` entry
>
> @@ +319,5 @@
> > + {
> > +"name": "expiration_date",
> > +"in": "query",
> > +"description": "Date the hold expires",
> > +"type": "string"
>
> This feels wrong.. surely this needs a `format: date-time` entry
>
> @@ +337,5 @@
> > + {
> > +"name": "suspended_until",
> > +"in": "query",
> > +"description": "Suspended until",
> > +"type": "string"
>
> This feels wrong.. surely this needs a `format: date-time` entry
These are input parameters.. these are for search, including partial search..
so you cannot put 'format: date-time' if you plan to search by all dates from
year 2020, for example.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20936] Holds History for patrons in OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20936 --- Comment #42 from Martin Renvoize --- OK.. this issue here is that the js code in bug 24455 does not distinguish between the perfectly valid 'full-date' and 'date-time' resolutions of RFC3339. Both are valid formats, but one includes a time offset whilst the other does not. The 'full-date' option does not include time resolution and as such also does not include an offset. When moment parses this, it 'upgrades' the internal representation from full-date (2020-03-25) to date-time (2020-03-25T00:00:00+00:00) internally.. When you then apply a timezone to that (say +0300 for Argentina I believe), we end up with an internal date of 2020-03-24T21:00:00-03:00.. spot the day change.. formating this back down to just 'date' will loose the day. Hope that makes sense.. so.. what we need to do is detect if we're parsing a date-time vs a full-date and only apply timezone maths to the former -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20936] Holds History for patrons in OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20936 Martin Renvoize changed: What|Removed |Added Status|Signed Off |Failed QA --- Comment #41 from Martin Renvoize --- Indeed, dropping the use of the call to `date` for formatting breaks it entirely.. i.e we don't format using the sysprefs at all. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20936] Holds History for patrons in OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20936
--- Comment #40 from Martin Renvoize ---
Comment on attachment 101726
--> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101726
Bug 20936: Add patron's hold history menu in OPAC
Review of attachment 101726:
-->
(https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html=20936=101726)
-
::: api/v1/swagger/paths/public_patrons.json
@@ +301,5 @@
> + {
> +"name": "timestamp",
> +"in": "query",
> +"description": "Time of latest update",
> +"type": "string"
This feels wrong.. surely this needs a `format: date-time` entry
@@ +313,5 @@
> + {
> +"name": "waiting_date",
> +"in": "query",
> +"description": "Date the item was marked as waiting for
> the patron",
> +"type": "string"
This feels wrong.. surely this needs a `format: date-time` entry
@@ +319,5 @@
> + {
> +"name": "expiration_date",
> +"in": "query",
> +"description": "Date the hold expires",
> +"type": "string"
This feels wrong.. surely this needs a `format: date-time` entry
@@ +337,5 @@
> + {
> +"name": "suspended_until",
> +"in": "query",
> +"description": "Suspended until",
> +"type": "string"
This feels wrong.. surely this needs a `format: date-time` entry
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20936] Holds History for patrons in OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20936 --- Comment #39 from Agustín Moyano --- (In reply to Jonathan Druart from comment #37) > Agustin, please do not amend patches that have been signed off yet, submit > follow-ups instead. They can be squashed later if needed. Ok, will rememeber that -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20936] Holds History for patrons in OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20936 --- Comment #38 from Jonathan Druart --- Also found: Search "foo", nothing is displayed, info is "showing page 1 of 0" https://snipboard.io/stcEuY.jpg Then remove "foo", you need to hit enter to see the unfiltered result, not sure it's the expected behavior as filtering works without hitting enter. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20936] Holds History for patrons in OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20936 --- Comment #37 from Jonathan Druart --- Agustin, please do not amend patches that have been signed off yet, submit follow-ups instead. They can be squashed later if needed. Still not correct: https://snipboard.io/0QNHgX.jpg There is one non formatted string, I guess that is what you modified. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20936] Holds History for patrons in OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20936 Agustín Moyano changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20936] Holds History for patrons in OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20936 --- Comment #36 from Agustín Moyano --- Created attachment 101727 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101727=edit Bug 20936: Add test Add test to /api/v1/public/patrons/:patron_id/holds endpoint To test: 1. prove t/db_dependent/api/v1/patrons_holds.t -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20936] Holds History for patrons in OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20936
--- Comment #35 from Agustín Moyano ---
Created attachment 101726
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101726=edit
Bug 20936: Add patron's hold history menu in OPAC
This patch adds patron's hold history in OPAC. Right now, it only shows records
from old_reserves table, but I'll wait till bug 20271 is pushed to show full
history (old and new holds)
To test:
1. apply this patch
2. Find a patron, place several holds and cancel or fulfill them
3. Go to patron's opac
CHECK => There is no 'your holds history' option in menu
4. In admin preferences enable OPACHoldsHistory
5. Go back to patron's opac
SUCCESS => There is a 'your holds history' menu option
=> Holds history displays all holds canceled or fulfilled
6. Filter, order and change page
SUCCESS => All controls work as expected
7. Sign off.
Table content is fetched from the api. If you see data, and you can order and
filter then please sign off bug 24561.
Date columns use $date function to transform dates strings from api (for
example '2020-02-20') to 'dateformat' prefernce format ('02/20/20202'). If you
change dateformat prefernce and see the changes reflected in date columns,
please sign off bug 24455.
Signed-off-by: Kyle M Hall
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
