Re: loplugin:useuniqueptr and a crash

2017-02-01 Thread Noel Grandin



On 2017/02/01 10:35 PM, Zolnai Tamás wrote:

2017-02-01 18:56 GMT+00:00 Zolnai Tamás :

Hi guys,

I tried to revert one loplugin:useuniqueptr related change because it
makes Impress to crash:
https://bugs.documentfoundation.org/show_bug.cgi?id=105677

But as I pushed a patch to gerrit I see that it makes build failing:
https://gerrit.libreoffice.org/#/c/33805/
http://ci.libreoffice.org/job/lo_gerrit/6397/Config=linux_clang_dbgutil_64/console

So what can I do here?


Was a useless question actually.. Noel, I cc-d you to the related bug.




Ah, thanks, I see that mst has pushed a fix for that.

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice


[Libreoffice-bugs] [Bug 105672] UI: On calc, Toolbar Layout - Notebookbar - Contextual groups. Column dropdown doesn' t work.

2017-02-01 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=105672

--- Comment #9 from Julien Nabet  ---
Who's responsible for this new layout? We should put him/her in cc and increase
importance.
Indeed there are quite a bunch of things in LO which have been started and
never finished (eg: macro recording). It doesn't give a good impression.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-commits] core.git: comphelper/qa comphelper/source connectivity/source desktop/source extensions/source framework/source io/source scripting/source svtools/source toolkit/source

2017-02-01 Thread Noel Grandin
 comphelper/qa/unit/variadictemplates.cxx|   11 
-
 comphelper/source/container/enumerablemap.cxx   |   12 
--
 comphelper/source/misc/configurationhelper.cxx  |   21 
---
 comphelper/source/misc/namedvaluecollection.cxx |   13 
--
 comphelper/source/property/propertycontainerhelper.cxx  |   17 
+-
 connectivity/source/drivers/postgresql/pq_array.cxx |   15 
+-
 connectivity/source/drivers/postgresql/pq_baseresultset.cxx |   32 
++---
 connectivity/source/drivers/postgresql/pq_connection.cxx|   35 
++---
 connectivity/source/drivers/postgresql/pq_preparedstatement.cxx |   41 
+++---
 connectivity/source/drivers/postgresql/pq_resultsetmetadata.cxx |   10 
-
 connectivity/source/drivers/postgresql/pq_sequenceresultsetmetadata.cxx |   11 
-
 connectivity/source/drivers/postgresql/pq_statement.cxx |9 
-
 connectivity/source/drivers/postgresql/pq_tools.cxx |   10 
-
 connectivity/source/drivers/postgresql/pq_updateableresultset.cxx   |9 
-
 connectivity/source/drivers/postgresql/pq_xbase.cxx |9 
-
 connectivity/source/drivers/postgresql/pq_xcolumns.cxx  |   11 
-
 connectivity/source/drivers/postgresql/pq_xcontainer.cxx|   59 
+++---
 connectivity/source/drivers/postgresql/pq_xindexes.cxx  |   12 
--
 connectivity/source/drivers/postgresql/pq_xkeys.cxx |7 
-
 connectivity/source/drivers/postgresql/pq_xtables.cxx   |8 
-
 connectivity/source/drivers/postgresql/pq_xusers.cxx|   19 
+--
 connectivity/source/drivers/postgresql/pq_xviews.cxx|   11 
-
 desktop/source/pkgchk/unopkg/unopkg_misc.cxx|   10 
-
 extensions/source/config/ldap/ldapaccess.cxx|   15 
--
 framework/source/services/autorecovery.cxx  |7 
-
 framework/source/services/pathsettings.cxx  |   20 
+--
 framework/source/xml/acceleratorconfigurationreader.cxx |6 
-
 io/source/acceptor/acc_socket.cxx   |   27 
+---
 io/source/stm/omark.cxx |   48 
+++-
 scripting/source/basprov/basprov.cxx|   12 
--
 scripting/source/provider/ActiveMSPList.cxx |   26 
++--
 scripting/source/provider/MasterScriptProvider.cxx  |5 
 svtools/source/uno/wizard/unowizard.cxx |7 
-
 toolkit/source/controls/unocontrolmodel.cxx |   14 
--
 34 files changed, 212 insertions(+), 367 deletions(-)

New commits:
commit c0f9bdd3e644e3ebf690aff9eb1aeec4f16dbf27
Author: Noel Grandin 
Date:   Wed Feb 1 12:24:07 2017 +0200

unnecessary use of OUStringBuffer in throwing exceptions

Change-Id: Iec1473264426f19c31e72260dfce9494389e474f
Reviewed-on: https://gerrit.libreoffice.org/33788
Tested-by: Jenkins 
Reviewed-by: Noel Grandin 

diff --git a/comphelper/qa/unit/variadictemplates.cxx 
b/comphelper/qa/unit/variadictemplates.cxx
index 77114df..2a3d0fe 100644
--- a/comphelper/qa/unit/variadictemplates.cxx
+++ b/comphelper/qa/unit/variadictemplates.cxx
@@ -44,14 +44,11 @@ inline void extract(
 xErrorContext, static_cast(nArg) );
 }
 if (! fromAny(seq[nArg], )) {
-OUStringBuffer buf;
-buf.append( "Cannot extract ANY { " );
-buf.append( seq[nArg].getValueType().getTypeName() );
-buf.append( " } to " );
-buf.append( ::cppu::UnoType::get().getTypeName() );
-buf.append( static_cast('!') );
 throw ::com::sun::star::lang::IllegalArgumentException(
-buf.makeStringAndClear(), xErrorContext,
+"Cannot extract ANY { "
++ seq[nArg].getValueType().getTypeName()
++ " } to " + ::cppu::UnoType::get().getTypeName(),
+xErrorContext,
 static_cast(nArg) );
 }
 }
diff --git a/comphelper/source/container/enumerablemap.cxx 
b/comphelper/source/container/enumerablemap.cxx
index 69e8976..b87f2c1 100644
--- a/comphelper/source/container/enumerablemap.cxx
+++ b/comphelper/source/container/enumerablemap.cxx
@@ -445,13 +445,11 @@ namespace comphelper
 
 if ( !bValid )
 {
-OUStringBuffer aMessage;
-aMessage.append( "Incompatible value type. Found '" );
-aMessage.append( _value.getValueTypeName() );
-aMessage.append( "', where '" );
-aMessage.append( m_aData.m_aValueType.getTypeName() );
-aMessage.append( "' (or compatible type) is 

[Libreoffice-commits] core.git: filter/source include/vcl svtools/source svx/source vcl/source

2017-02-01 Thread Noel Grandin
 filter/source/msfilter/msdffimp.cxx|2 
 include/vcl/bitmap.hxx |   11 
 svtools/source/graphic/transformer.cxx |2 
 svx/source/dialog/_bmpmask.cxx |2 
 svx/source/dialog/_contdlg.cxx |2 
 vcl/source/filter/wmf/winmtf.cxx   |4 -
 vcl/source/gdi/bitmap.cxx  |   87 -
 7 files changed, 10 insertions(+), 100 deletions(-)

New commits:
commit 52360bf8dd567598593cb212ac85f0c919315618
Author: Noel Grandin 
Date:   Wed Feb 1 15:04:45 2017 +0200

convert BmpCombine to scoped enum and drop unused

Change-Id: Ic67474683a25a25e5753777f4bbbeded6ceba414
Reviewed-on: https://gerrit.libreoffice.org/33793
Tested-by: Jenkins 
Reviewed-by: Noel Grandin 

diff --git a/filter/source/msfilter/msdffimp.cxx 
b/filter/source/msfilter/msdffimp.cxx
index d2aeeeb..5e45f5b 100644
--- a/filter/source/msfilter/msdffimp.cxx
+++ b/filter/source/msfilter/msdffimp.cxx
@@ -3826,7 +3826,7 @@ SdrObject* SvxMSDffManager::ImportGraphic( SvStream& rSt, 
SfxItemSet& rSet, cons
 Bitmap  aBitmap( aBitmapEx.GetBitmap() );
 Bitmap  aMask( aBitmap.CreateMask( MSO_CLR_ToColor( 
nTransColor, DFF_Prop_pictureTransparent ), 9 ) );
 if ( aBitmapEx.IsTransparent() )
-aMask.CombineSimple( aBitmapEx.GetMask(), 
BMP_COMBINE_OR );
+aMask.CombineSimple( aBitmapEx.GetMask(), 
BmpCombine::Or );
 aGraf = BitmapEx( aBitmap, aMask );
 }
 }
diff --git a/include/vcl/bitmap.hxx b/include/vcl/bitmap.hxx
index 9ff3984..9f99467 100644
--- a/include/vcl/bitmap.hxx
+++ b/include/vcl/bitmap.hxx
@@ -88,16 +88,9 @@ enum BmpConversion
 BMP_CONVERSION_GHOSTED = 10
 };
 
-enum BmpCombine
+enum class BmpCombine
 {
-BMP_COMBINE_COPY = 0,
-BMP_COMBINE_INVERT = 1,
-BMP_COMBINE_AND = 2,
-BMP_COMBINE_NAND = 3,
-BMP_COMBINE_OR = 4,
-BMP_COMBINE_NOR = 5,
-BMP_COMBINE_XOR = 6,
-BMP_COMBINE_NXOR = 7
+Or, And
 };
 
 enum BmpReduce
diff --git a/svtools/source/graphic/transformer.cxx 
b/svtools/source/graphic/transformer.cxx
index 4caf469..8b934da 100644
--- a/svtools/source/graphic/transformer.cxx
+++ b/svtools/source/graphic/transformer.cxx
@@ -98,7 +98,7 @@ uno::Reference< graphic::XGraphic > SAL_CALL 
GraphicTransformer::colorChange(
 {
 Bitmap aMask( aBitmapEx.GetMask() );
 Bitmap aMask2( aBitmap.CreateMask( aColorFrom, nTolerance ) );
-aMask.CombineSimple( aMask2, BMP_COMBINE_OR );
+aMask.CombineSimple( aMask2, BmpCombine::Or );
 aBitmap.Replace( aColorFrom, aColorTo, nTolerance );
 aGraphic = ::Graphic( BitmapEx( aBitmap, aMask ) );
 }
diff --git a/svx/source/dialog/_bmpmask.cxx b/svx/source/dialog/_bmpmask.cxx
index b7e1948..eebc880 100644
--- a/svx/source/dialog/_bmpmask.cxx
+++ b/svx/source/dialog/_bmpmask.cxx
@@ -631,7 +631,7 @@ BitmapEx SvxBmpMask::ImpMaskTransparent( const BitmapEx& 
rBitmapEx, const Color&
 Bitmap  aMask( rBitmapEx.GetBitmap().CreateMask( rColor, nTol ) );
 
 if( rBitmapEx.IsTransparent() )
-aMask.CombineSimple( rBitmapEx.GetMask(), BMP_COMBINE_OR );
+aMask.CombineSimple( rBitmapEx.GetMask(), BmpCombine::Or );
 
 aBmpEx = BitmapEx( rBitmapEx.GetBitmap(), aMask );
 LeaveWait();
diff --git a/svx/source/dialog/_contdlg.cxx b/svx/source/dialog/_contdlg.cxx
index 11d559f..c8c20df 100644
--- a/svx/source/dialog/_contdlg.cxx
+++ b/svx/source/dialog/_contdlg.cxx
@@ -691,7 +691,7 @@ IMPL_LINK( SvxSuperContourDlg, PipetteClickHdl, 
ContourWindow&, rWnd, void )
 aMask = aBmp.CreateMask( rColor, nTol );
 
 if( aGraphic.IsTransparent() )
-aMask.CombineSimple( aGraphic.GetBitmapEx().GetMask(), 
BMP_COMBINE_OR );
+aMask.CombineSimple( aGraphic.GetBitmapEx().GetMask(), 
BmpCombine::Or );
 
 if( !!aMask )
 {
diff --git a/vcl/source/filter/wmf/winmtf.cxx b/vcl/source/filter/wmf/winmtf.cxx
index b383439..b824a1a 100644
--- a/vcl/source/filter/wmf/winmtf.cxx
+++ b/vcl/source/filter/wmf/winmtf.cxx
@@ -1637,11 +1637,11 @@ void WinMtfOutput::ImplDrawBitmap( const Point& rPos, 
const Size& rSize, const B
 
 if ( rBitmap.GetTransparentColor() == Color( COL_WHITE ) )
 {
-aMask.CombineSimple( rBitmap.GetMask(), BMP_COMBINE_OR );
+aMask.CombineSimple( rBitmap.GetMask(), BmpCombine::Or );
 }
 else
 {
-aMask.CombineSimple( rBitmap.GetMask(), BMP_COMBINE_AND );
+aMask.CombineSimple( rBitmap.GetMask(), BmpCombine::And );
 }
 
 aBmpEx = BitmapEx( 

[Libreoffice-commits] core.git: download.lst external/fontconfig

2017-02-01 Thread David Tardon
 download.lst  |3 
 external/fontconfig/0001-Fix-a-memory-leak-in-FcDirScanConfig.patch.1 |   26 -
 external/fontconfig/UnpackedTarball_fontconfig.mk |5 
 external/fontconfig/fontconfig-2.12.1.patch.1 |  135 
++
 external/fontconfig/fontconfig-2.8.0.patch|   64 

 5 files changed, 138 insertions(+), 95 deletions(-)

New commits:
commit ba9b66eecf9ced0d890ff9d6b7a6efda35825382
Author: David Tardon 
Date:   Wed Feb 1 10:43:57 2017 +0100

upload fontconfig 2.12.1

Change-Id: I6f035afbf4a904bed5074d79f467ba43f7d8ed32
Reviewed-on: https://gerrit.libreoffice.org/33813
Tested-by: Jenkins 
Reviewed-by: David Tardon 

diff --git a/download.lst b/download.lst
index 2a67327..d5ecfcb 100644
--- a/download.lst
+++ b/download.lst
@@ -39,7 +39,8 @@ export EXPAT_MD5SUM := 2f47841c829facb346eb6e3fab5212e2
 export EXPAT_TARBALL := expat-2.2.0.tar.bz2
 export FIREBIRD_MD5SUM := 821260b61dafc22899d1464d4e91ee6a
 export FIREBIRD_TARBALL := Firebird-3.0.0.32483-0.tar.bz2
-export FONTCONFIG_TARBALL := 
77e15a92006ddc2adbb06f840d591c0e-fontconfig-2.8.0.tar.gz
+export FONTCONFIG_MD5SUM := b5af5a423ee3b5cfc34846838963c058
+export FONTCONFIG_TARBALL := fontconfig-2.12.1.tar.bz2
 export FONT_CALADEA_TARBALL := 
368f114c078f94214a308a74c7e991bc-crosextrafonts-20130214.tar.gz
 export FONT_CARLITO_TARBALL := 
c74b7223abe75949b4af367942d96c7a-crosextrafonts-carlito-20130920.tar.gz
 export FONT_DEJAVU_TARBALL := 
33e1e61fab06a547851ed308b4ffef42-dejavu-fonts-ttf-2.37.zip
diff --git 
a/external/fontconfig/0001-Fix-a-memory-leak-in-FcDirScanConfig.patch.1 
b/external/fontconfig/0001-Fix-a-memory-leak-in-FcDirScanConfig.patch.1
deleted file mode 100644
index 8fd4dcf..000
--- a/external/fontconfig/0001-Fix-a-memory-leak-in-FcDirScanConfig.patch.1
+++ /dev/null
@@ -1,26 +0,0 @@
-From ea1c6ea337b8cf6b86169b565787d0d31a0fc330 Mon Sep 17 00:00:00 2001
-From: Akira TAGOH 
-Date: Tue, 27 Mar 2012 21:06:36 +0900
-Subject: [PATCH] Fix a memory leak in FcDirScanConfig()
-

- src/fcdir.c | 3 +++
- 1 file changed, 3 insertions(+)
-
-diff --git a/src/fcdir.c b/src/fcdir.c
-index d8b094f..4399afc 100644
 a/src/fcdir.c
-+++ b/src/fcdir.c
-@@ -211,6 +211,9 @@ bail2:
- bail1:
- closedir (d);
- bail:
-+if (file)
-+  free (file);
-+
- return ret;
- }
- 
--- 
-2.9.3
-
diff --git a/external/fontconfig/UnpackedTarball_fontconfig.mk 
b/external/fontconfig/UnpackedTarball_fontconfig.mk
index be44033..6026a81 100644
--- a/external/fontconfig/UnpackedTarball_fontconfig.mk
+++ b/external/fontconfig/UnpackedTarball_fontconfig.mk
@@ -11,11 +11,8 @@ $(eval $(call gb_UnpackedTarball_UnpackedTarball,fontconfig))
 
 $(eval $(call 
gb_UnpackedTarball_set_tarball,fontconfig,$(FONTCONFIG_TARBALL),,fontconfig))
 
-$(eval $(call gb_UnpackedTarball_set_patchlevel,fontconfig,3))
-
 $(eval $(call gb_UnpackedTarball_add_patches,fontconfig,\
-   external/fontconfig/fontconfig-2.8.0.patch \
-   external/fontconfig/0001-Fix-a-memory-leak-in-FcDirScanConfig.patch.1 \
+   external/fontconfig/fontconfig-2.12.1.patch.1 \
 ))
 
 # vim: set noet sw=4 ts=4:
diff --git a/external/fontconfig/fontconfig-2.12.1.patch.1 
b/external/fontconfig/fontconfig-2.12.1.patch.1
new file mode 100644
index 000..f348d2a
--- /dev/null
+++ b/external/fontconfig/fontconfig-2.12.1.patch.1
@@ -0,0 +1,135 @@
+diff -up fontconfig/configure.dt fontconfig/configure
+--- fontconfig/configure.dt2017-02-01 22:07:29.671668568 +0100
 fontconfig/configure   2017-02-01 22:09:53.335215490 +0100
+@@ -10469,7 +10469,7 @@ _LT_EOF
+   case $host_cpu in
+   powerpc)
+ # see comment about AmigaOS4 .so support
+-archive_cmds='$CC -shared $libobjs $deplibs $compiler_flags 
$wl-soname $wl$soname -o $lib'
++archive_cmds='$CC -shared $libobjs $deplibs $compiler_flags -o 
$lib'
+ archive_expsym_cmds=''
+ ;;
+   m68k)
+@@ -10485,7 +10485,7 @@ _LT_EOF
+   allow_undefined_flag=unsupported
+   # Joseph Beckenbach  says some releases of gcc
+   # support --undefined.  This deserves some investigation.  FIXME
+-  archive_cmds='$CC -nostart $libobjs $deplibs $compiler_flags $wl-soname 
$wl$soname -o $lib'
++  archive_cmds='$CC -nostart $libobjs $deplibs $compiler_flags -o $lib'
+   else
+   ld_shlibs=no
+   fi
+@@ -10519,7 +10519,7 @@ _LT_EOF
+   ;;
+ 
+ haiku*)
+-  archive_cmds='$CC -shared $libobjs $deplibs $compiler_flags $wl-soname 
$wl$soname -o $lib'
++  archive_cmds='$CC -shared $libobjs $deplibs $compiler_flags -o $lib'
+   link_all_deplibs=yes
+   ;;
+ 
+@@ -10614,13 +10614,13 @@ _LT_EOF
+   *Sun\ F*)   # Sun Fortran 8.3
+ tmp_sharedflag='-G' ;;
+   esac
+-  

[Libreoffice-commits] core.git: download.lst external/freetype RepositoryExternal.mk

2017-02-01 Thread David Tardon
 RepositoryExternal.mk|7 
 download.lst |3 
 external/freetype/ExternalProject_freetype.mk|5 
 external/freetype/UnpackedTarball_freetype.mk|4 
 external/freetype/freetype-2.4.8.patch   |   20 --
 external/freetype/freetype-2.6.5.patch.1 |  158 +++
 external/freetype/freetype-msvc-disable-sse2.patch.1 |   57 --
 7 files changed, 206 insertions(+), 48 deletions(-)

New commits:
commit cc96f0c841961961f9274c4717419da8d5d27533
Author: David Tardon 
Date:   Wed Feb 1 12:32:35 2017 +0100

upload freetype 2.7.1

Change-Id: I8da4395cefe6bb542ab7cac2a849ec587a63f37c
Reviewed-on: https://gerrit.libreoffice.org/33814
Tested-by: Jenkins 
Reviewed-by: David Tardon 

diff --git a/RepositoryExternal.mk b/RepositoryExternal.mk
index 13c9ddf..b00776c 100644
--- a/RepositoryExternal.mk
+++ b/RepositoryExternal.mk
@@ -1474,6 +1474,8 @@ $(call gb_LinkTarget_add_libs,$(1),$(HARFBUZZ_LIBS))
 
 endef
 
+gb_ExternalProject__use_harfbuzz :=
+
 else # SYSTEM_HARFBUZZ != TRUE
 
 define gb_LinkTarget__use_harfbuzz
@@ -1486,6 +1488,11 @@ $(call gb_LinkTarget_use_external_project,$(1),harfbuzz)
 
 endef
 
+define gb_ExternalProject__use_harfbuzz
+$(call gb_ExternalProject_use_external_project,$(1),harfbuzz)
+
+endef
+
 endif # SYSTEM_HARFBUZZ
 
 ifeq ($(DISABLE_OPENSSL),TRUE)
diff --git a/download.lst b/download.lst
index bf2ac36..2a67327 100644
--- a/download.lst
+++ b/download.lst
@@ -55,7 +55,8 @@ export FONT_EMOJIONE_COLOR_MD5SUM := 
919389b307ee8696288ea3b8210ab974
 export FONT_EMOJIONE_COLOR_TARBALL := EmojiOneColor-SVGinOT-1.3.tar.gz
 export FREEHAND_MD5SUM := 8cf70c5dc4d24d2dc4a107f509d2d6d7
 export FREEHAND_TARBALL := libfreehand-0.1.1.tar.bz2
-export FREETYPE_TARBALL := 
dbf2caca1d3afd410a29217a9809d397-freetype-2.4.8.tar.bz2
+export FREETYPE_MD5SUM := b3230110e0cab777e0df7631837ac36e
+export FREETYPE_TARBALL := freetype-2.7.1.tar.bz2
 export GLM_TARBALL := 
bae83fa5dc7f081768daace6e199adc3-glm-0.9.4.6-libreoffice.zip
 export GRAPHITE_TARBALL := 
3069842a88b8f40c6b83ad2850cda293-graphite2-minimal-1.3.9.tgz
 export HARFBUZZ_MD5SUM := 5986e1bfcd983d1f6caa53ef64c4abc5
diff --git a/external/freetype/ExternalProject_freetype.mk 
b/external/freetype/ExternalProject_freetype.mk
index 2353030..b12303c6 100644
--- a/external/freetype/ExternalProject_freetype.mk
+++ b/external/freetype/ExternalProject_freetype.mk
@@ -9,6 +9,10 @@
 
 $(eval $(call gb_ExternalProject_ExternalProject,freetype))
 
+$(eval $(call gb_ExternalProject_use_externals,freetype,\
+   harfbuzz \
+))
+
 $(eval $(call gb_ExternalProject_register_targets,freetype,\
build \
 ))
@@ -29,7 +33,6 @@ $(call gb_ExternalProject_get_state_target,freetype,build) :
--prefix=$(call 
gb_UnpackedTarball_get_dir,freetype/instdir) \
--build=$(BUILD_PLATFORM) --host=$(HOST_PLATFORM) \
CFLAGS="$(if $(debug),-g) $(gb_VISIBILITY_FLAGS)" \
-   && chmod +x builds/unix/freetype-config \
&& $(MAKE) install \
&& touch $@ )
 endif
diff --git a/external/freetype/UnpackedTarball_freetype.mk 
b/external/freetype/UnpackedTarball_freetype.mk
index 769d39a..847ae6f 100644
--- a/external/freetype/UnpackedTarball_freetype.mk
+++ b/external/freetype/UnpackedTarball_freetype.mk
@@ -11,10 +11,8 @@ $(eval $(call gb_UnpackedTarball_UnpackedTarball,freetype))
 
 $(eval $(call 
gb_UnpackedTarball_set_tarball,freetype,$(FREETYPE_TARBALL),,freetype))
 
-$(eval $(call gb_UnpackedTarball_set_patchlevel,freetype,3))
-
 $(eval $(call gb_UnpackedTarball_add_patches,freetype,\
-   external/freetype/freetype-2.4.8.patch \
+   external/freetype/freetype-2.6.5.patch.1 \
external/freetype/freetype-msvc-disable-sse2.patch.1 \
 ))
 
diff --git a/external/freetype/freetype-2.4.8.patch 
b/external/freetype/freetype-2.4.8.patch
deleted file mode 100644
index 9ae69a3..000
--- a/external/freetype/freetype-2.4.8.patch
+++ /dev/null
@@ -1,20 +0,0 @@
 misc/build/freetype-2.4.8/builds/unix/configure
-+++ misc/build/freetype-2.4.8/builds/unix/configure
-@@ -3619,7 +3619,7 @@
- 
- if test "x$GCC" = xyes; then
-   XX_CFLAGS="-Wall"
--  XX_ANSIFLAGS="-pedantic -ansi"
-+  XX_ANSIFLAGS=
- else
-   case "$host" in
-   *-dec-osf*)
-@@ -10039,7 +10039,7 @@
-   *Sun\ F*)   # Sun Fortran 8.3
- tmp_sharedflag='-G' ;;
-   esac
--  archive_cmds='$CC '"$tmp_sharedflag""$tmp_addflag"' $libobjs $deplibs 
$compiler_flags ${wl}-soname $wl$soname -o $lib'
-+  archive_cmds='$CC '"$tmp_sharedflag""$tmp_addflag"' $libobjs $deplibs 
$compiler_flags -o $lib'
- 
- if test "x$supports_anon_versioning" = xyes; then
-   archive_expsym_cmds='echo "{ global:" > $output_objdir/$libname.ver~
diff --git 

Re: Improve Comments in Writer Documents: Proper Printing of Comments[Gsoc 2017]

2017-02-01 Thread Jan Iversen
Welcome.

Remark in order to be considered for GSoC at LibreOffice, you need to build 
LibreOffice, and solve at least one non-trivial easyhack. Once GSoC starts 
mentors will be announced.

We have made a step-by-step guide, to help new people:
https://wiki.documentfoundation.org/Development/GetInvolved 


have fun
jan I.

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice


[Libreoffice-commits] core.git: bin/gbuild-to-ide

2017-02-01 Thread Federico Bassini
 bin/gbuild-to-ide |   26 +-
 1 file changed, 13 insertions(+), 13 deletions(-)

New commits:
commit 25a502050f4a898e4ce147afa71f135c771c50a3
Author: Federico Bassini 
Date:   Thu Feb 2 00:11:03 2017 +0100

gbuild-to-ide: second patch for vs2013 and testIde

the path in gbuildparse changed, so this patch re-adapt this
2 IDE integration

Change-Id: I5f7a679b8b12eac6f44030a33713ff19327b9d1a
Reviewed-on: https://gerrit.libreoffice.org/33815
Tested-by: Jenkins 
Reviewed-by: jan iversen 

diff --git a/bin/gbuild-to-ide b/bin/gbuild-to-ide
index 258a971..0ab45d1 100755
--- a/bin/gbuild-to-ide
+++ b/bin/gbuild-to-ide
@@ -94,7 +94,7 @@ class GbuildParser:
 # Relation between json object and file extension
 jsonSrc = {
 'CXXOBJECTS': '.cxx', 'OBJCOBJECTS': '.m', 
'OBJCXXOBJECTS': '.mm', 'COBJECTS': '.c',
-'LEXOBJECTS': '.l',   'YACCOBJECTS': '.y',
+'FLEXOBJECTS': '.l',   'YACCOBJECTS': '.y',
 
 'GENCXXOBJECTS': '.cxx', # remark is in 
workdir/GenCxxObject
 'ASMOBJECTS': '.s',  #not in json, due to Blacklist ?
@@ -368,9 +368,9 @@ class testVS2013Ide(IdeIntegrationGenerator):
 for cxxobject in target['CXXOBJECTS']:
 cxxrelpath= 
os.path.join('../..',target['location'].split('/')[-1], cxxobject)
 cxxabspath = 
os.path.join(self.gbuildparser.srcdir,target['location'].split('/')[-1], 
cxxobject)
-cxxfile = cxxabspath + '.cxx'
+cxxfile = cxxabspath
 if os.path.isfile(cxxfile):
-ET.SubElement(cxxobjects_node, '{%s}ClCompile' % ns, 
Include=cxxrelpath + '.cxx')
+ET.SubElement(cxxobjects_node, '{%s}ClCompile' % ns, 
Include=cxxrelpath)
 else:
 print('Source %s in project %s does not exist' % (cxxfile, 
target['target_name']))
 
@@ -378,13 +378,13 @@ class testVS2013Ide(IdeIntegrationGenerator):
 for cxxobject in target['CXXOBJECTS']:
 include_rel_path = 
os.path.join('../..',target['location'].split('/')[-1], cxxobject)
 include_abs_path = 
os.path.join(self.gbuildparser.srcdir,target['location'].split('/')[-1], 
cxxobject)
-hxxfile = include_abs_path + '.hxx'
+hxxfile = include_abs_path
 if os.path.isfile(hxxfile):
-ET.SubElement(includes_node, '{%s}ClInclude' % ns, 
Include=include_rel_path + '.hxx')
+ET.SubElement(includes_node, '{%s}ClInclude' % ns, 
Include=include_rel_path)
 # Few files have corresponding .h files
-hfile = include_abs_path + '.h'
+hfile = include_abs_path
 if os.path.isfile(hfile):
-ET.SubElement(includes_node, '{%s}ClInclude' % ns, 
Include=include_rel_path + '.h')
+ET.SubElement(includes_node, '{%s}ClInclude' % ns, 
Include=include_rel_path)
 ET.SubElement(proj_node, '{%s}Import' % ns, 
Project='$(VCTargetsPath)\Microsoft.Cpp.targets')
 ET.SubElement(proj_node, '{%s}ImportGroup' % ns, 
Label='ExtensionTargets')
 self.write_pretty_xml(proj_node, project_path)
@@ -844,9 +844,9 @@ class 
VisualStudioIntegrationGenerator(IdeIntegrationGenerator):
 for cxxobject in target['CXXOBJECTS']:
 cxxrelpath = os.path.join('../..', 
target['location'].split('/')[-1], cxxobject)
 cxxabspath = os.path.join(self.gbuildparser.srcdir, 
target['location'].split('/')[-1], cxxobject)
-cxxfile = cxxabspath + '.cxx'
+cxxfile = cxxabspath
 if os.path.isfile(cxxfile):
-ET.SubElement(cxxobjects_node, '{%s}ClCompile' % ns, 
Include=cxxrelpath + '.cxx')
+ET.SubElement(cxxobjects_node, '{%s}ClCompile' % ns, 
Include=cxxrelpath)
 else:
 print('Source %s in project %s does not exist' % (cxxfile, 
target['target_name']))
 
@@ -854,13 +854,13 @@ class 
VisualStudioIntegrationGenerator(IdeIntegrationGenerator):
 for cxxobject in target['CXXOBJECTS']:
 include_rel_path = 
os.path.join('../..',target['location'].split('/')[-1], cxxobject)
 include_abs_path = 
os.path.join(self.gbuildparser.srcdir,target['location'].split('/')[-1], 
cxxobject)
-hxxfile = include_abs_path + '.hxx'
+hxxfile = include_abs_path
 if os.path.isfile(hxxfile):
-ET.SubElement(includes_node, '{%s}ClInclude' % ns, 
Include=include_rel_path + '.hxx')
+ET.SubElement(includes_node, '{%s}ClInclude' % ns, 
Include=include_rel_path)
 # Few files have corresponding .h files
-hfile = include_abs_path + '.h'
+hfile = include_abs_path
 if os.path.isfile(hfile):
-ET.SubElement(includes_node, '{%s}ClInclude' % ns, 

Improve Comments in Writer Documents: Proper Printing of Comments[Gsoc 2017]

2017-02-01 Thread krishna keshav
Hello,
I am interested in Improve Comments in Writer Documents: Proper Printing of
Comments

as GSOC 2017 project. I am currently going through the code pointers
provided and as stated, I would be happy to know the the mentors for the
project.

Thanks,
Krishna Keshav
IRC nick - peace_
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice


[Libreoffice-commits] core.git: sc/qa

2017-02-01 Thread Zdeněk Crhonek
 sc/qa/unit/data/functions/financial/fods/mduration.fods | 1733 
 1 file changed, 1733 insertions(+)

New commits:
commit 5badb5b1f3ac9406a0b733579aa1f0438fd299e0
Author: Zdeněk Crhonek 
Date:   Thu Feb 2 07:16:09 2017 +0100

add MDURATION test case

Change-Id: I9eb700a0977d13dbca41962eeb74b33f80ee7ef1
Reviewed-on: https://gerrit.libreoffice.org/33820
Tested-by: Jenkins 
Reviewed-by: Zdenek Crhonek 

diff --git a/sc/qa/unit/data/functions/financial/fods/mduration.fods 
b/sc/qa/unit/data/functions/financial/fods/mduration.fods
new file mode 100644
index 000..89fb3cb
--- /dev/null
+++ b/sc/qa/unit/data/functions/financial/fods/mduration.fods
@@ -0,0 +1,1733 @@
+
+
+http://www.w3.org/1999/xlink; 
xmlns:dc="http://purl.org/dc/elements/1.1/; 
xmlns:meta="urn:oasis:names:tc:opendocument:xmlns:meta:1.0" 
xmlns:number="urn:oasis:names:tc:opendocument:xmlns:datastyle:1.0" 
xmlns:presentation="urn:oasis:names:tc:opendocument:xmlns:presentation:1.0" 
xmlns:svg="urn:oasis:names:tc:opendocument:xmlns:svg-compatible:1.0" 
xmlns:chart="urn:oasis:names:tc:opendocument:xmlns:chart:1.0" 
xmlns:dr3d="urn:oasis:names:tc:opendocument:xmlns:dr3d:1.0" 
xmlns:math="http://www.w3.org/1998/Math/MathML; 
xmlns:form="urn:oasis:names:tc:opendocument:xmlns:form:1.0" xmlns:scr
 ipt="urn:oasis:names:tc:opendocument:xmlns:script:1.0" 
xmlns:config="urn:oasis:names:tc:opendocument:xmlns:config:1.0" 
xmlns:ooo="http://openoffice.org/2004/office; 
xmlns:ooow="http://openoffice.org/2004/writer; 
xmlns:oooc="http://openoffice.org/2004/calc; 
xmlns:dom="http://www.w3.org/2001/xml-events; 
xmlns:xforms="http://www.w3.org/2002/xforms; 
xmlns:xsd="http://www.w3.org/2001/XMLSchema; 
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance; 
xmlns:rpt="http://openoffice.org/2005/report; 
xmlns:of="urn:oasis:names:tc:opendocument:xmlns:of:1.2" 
xmlns:xhtml="http://www.w3.org/1999/xhtml; 
xmlns:grddl="http://www.w3.org/2003/g/data-view#; 
xmlns:tableooo="http://openoffice.org/2009/table; 
xmlns:drawooo="http://openoffice.org/2010/draw; 
xmlns:calcext="urn:org:documentfoundation:names:experimental:calc:xmlns:calcext:1.0"
 
xmlns:loext="urn:org:documentfoundation:names:experimental:office:xmlns:loext:1.0"
 xmlns:field="urn:openoffice:names:experimental:ooo-ms-interop:xmlns:field:1.0" 
xmlns:form
 x="urn:openoffice:names:experimental:ooxml-odf-interop:xmlns:form:1.0" 
xmlns:css3t="http://www.w3.org/TR/css3-text/; office:version="1.2" 
office:mimetype="application/vnd.oasis.opendocument.spreadsheet">
+ 
2016-06-28T13:38:57.45300P0D1LibreOfficeDev/5.3.0.0.alpha1$Linux_X86_64
 
LibreOffice_project/883024d657fb45c7da459017d2f936aac5644bfb
+ 
+  
+   0
+   0
+   34080
+   12047
+   
+
+ view1
+ 
+  
+   2
+   8
+   0
+   0
+   0
+   0
+   2
+   0
+   0
+   0
+   0
+   0
+   90
+   60
+   true
+   false
+  
+  
+   4
+   14
+   0
+   0
+   0
+   0
+   2
+   0
+   0
+   0
+   0
+   0
+   90
+   60
+   true
+   false
+  
+ 
+ Sheet2
+ 1241
+ 0
+ 90
+ 60
+ false
+ true
+ true
+ true
+ 12632256
+ true
+ true
+ true
+ true
+ false
+ false
+ false
+ 1270
+ 1270
+ 1
+ 1
+ true
+ false
+
+   
+  
+  
+   7
+   false
+   false
+   true
+   true
+   false
+   false
+   false
+   1270
+   1270
+   true
+   true
+   true
+   true
+   true
+   false
+   12632256
+   false
+   Lexmark-E352dn
+   
+
+ cs
+ CZ
+ 
+ 
+ 
+
+
+ en
+ US
+ 
+ 
+ 
+
+
+ nl
+ NL
+ 
+ 
+ 
+
+   
+   true
+   true
+   3
+   1
+   true
+   1
+   true
+   lgH+/0xleG1hcmstRTM1MmRuQ1VQUzpMZXhtYXJrLUUzNTJkbgAWAAMAtwAIAFZUAAAkbQAASm9iRGF0YSAxCnByaW50ZXI9TGV4bWFyay1FMzUyZG4Kb3JpZW50YXRpb249UG9ydHJhaXQKY29waWVzPTEKY29sbGF0ZT1mYWxzZQptYXJnaW5kYWp1c3RtZW50PTAsMCwwLDAKY29sb3JkZXB0aD0yNApwc2xldmVsPTAKcGRmZGV2aWNlPTEKY29sb3JkZXZpY2U9MApQUERDb250ZXhEYXRhClBhZ2VTaXplOkxldHRlcgAAEgBDT01QQVRfRFVQTEVYX01PREUPAER1cGxleE1vZGU6Ok9mZg==
+   false
+   0
+  
+ 
+ 
+  
+   http://openoffice.org/2004/office; 
xmlns:xlink="http://www.w3.org/1999/xlink;>
+
+   
+  
+ 
+ 
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+ 
+ 
+  
+   
+   
+  
+  
+   
+  
+  
+   
+
+   Kč
+  
+  
+   
+   -
+   
+
+   Kč
+   
+  
+  
+
+
+   
+
+  
+  
+
+
+   (
+   
+   )
+  
+  
+
+
+   -
+   
+
+  
+  
+   
+
+   
+   
+   
+  
+  
+   £
+   
+  
+  
+   -
+   £
+   
+   
+  
+  
+   £
+   
+  
+  
+   -
+   £
+   
+   
+  
+  
+   £
+   
+  
+  
+   
+   -
+   £
+   

[Libreoffice-bugs] [Bug 105673] Dutch translation anchor image, frame to character/ as character switched

2017-02-01 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=105673

Adolfo Jayme  changed:

   What|Removed |Added

  Component|LibreOffice |Localization
 Whiteboard||target:5.4.0 target:5.3.1
   ||target:5.2.6

--- Comment #3 from Adolfo Jayme  ---
Tentatively adding targets to whiteboard; if incorrect, please adjust ;-)

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-commits] core.git: sc/qa

2017-02-01 Thread Zdeněk Crhonek
 sc/qa/unit/data/functions/addin/fods/imcos.fods | 5911 
 1 file changed, 5911 insertions(+)

New commits:
commit 4311cdfe77aa525fd485b1043f17e0b1bf8af7bc
Author: Zdeněk Crhonek 
Date:   Fri Jan 27 22:30:49 2017 +0100

add IMCOS test case

Change-Id: I41a5636aa6b87ae26a615c0e267dae64e12a6c6b
Reviewed-on: https://gerrit.libreoffice.org/33639
Tested-by: Jenkins 
Reviewed-by: Zdenek Crhonek 

diff --git a/sc/qa/unit/data/functions/addin/fods/imcos.fods 
b/sc/qa/unit/data/functions/addin/fods/imcos.fods
new file mode 100644
index 000..cf6cc2b
--- /dev/null
+++ b/sc/qa/unit/data/functions/addin/fods/imcos.fods
@@ -0,0 +1,5911 @@
+
+
+http://www.w3.org/1999/xlink; 
xmlns:dc="http://purl.org/dc/elements/1.1/; 
xmlns:meta="urn:oasis:names:tc:opendocument:xmlns:meta:1.0" 
xmlns:number="urn:oasis:names:tc:opendocument:xmlns:datastyle:1.0" 
xmlns:presentation="urn:oasis:names:tc:opendocument:xmlns:presentation:1.0" 
xmlns:svg="urn:oasis:names:tc:opendocument:xmlns:svg-compatible:1.0" 
xmlns:chart="urn:oasis:names:tc:opendocument:xmlns:chart:1.0" 
xmlns:dr3d="urn:oasis:names:tc:opendocument:xmlns:dr3d:1.0" 
xmlns:math="http://www.w3.org/1998/Math/MathML; 
xmlns:form="urn:oasis:names:tc:opendocument:xmlns:form:1.0" xmlns:scr
 ipt="urn:oasis:names:tc:opendocument:xmlns:script:1.0" 
xmlns:config="urn:oasis:names:tc:opendocument:xmlns:config:1.0" 
xmlns:ooo="http://openoffice.org/2004/office; 
xmlns:ooow="http://openoffice.org/2004/writer; 
xmlns:oooc="http://openoffice.org/2004/calc; 
xmlns:dom="http://www.w3.org/2001/xml-events; 
xmlns:xforms="http://www.w3.org/2002/xforms; 
xmlns:xsd="http://www.w3.org/2001/XMLSchema; 
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance; 
xmlns:rpt="http://openoffice.org/2005/report; 
xmlns:of="urn:oasis:names:tc:opendocument:xmlns:of:1.2" 
xmlns:xhtml="http://www.w3.org/1999/xhtml; 
xmlns:grddl="http://www.w3.org/2003/g/data-view#; 
xmlns:tableooo="http://openoffice.org/2009/table; 
xmlns:drawooo="http://openoffice.org/2010/draw; 
xmlns:calcext="urn:org:documentfoundation:names:experimental:calc:xmlns:calcext:1.0"
 
xmlns:loext="urn:org:documentfoundation:names:experimental:office:xmlns:loext:1.0"
 xmlns:field="urn:openoffice:names:experimental:ooo-ms-interop:xmlns:field:1.0" 
xmlns:form
 x="urn:openoffice:names:experimental:ooxml-odf-interop:xmlns:form:1.0" 
xmlns:css3t="http://www.w3.org/TR/css3-text/; office:version="1.2" 
office:mimetype="application/vnd.oasis.opendocument.spreadsheet">
+ 
2016-12-29T18:23:56.52200P0D1LibreOfficeDev/5.3.0.0.alpha1$Linux_X86_64
 
LibreOffice_project/883024d657fb45c7da459017d2f936aac5644bfb
+ 
+  
+   0
+   0
+   75258
+   360087
+   
+
+ view1
+ 
+  
+   2
+   5
+   0
+   0
+   0
+   0
+   2
+   0
+   0
+   0
+   0
+   0
+   85
+   60
+   true
+   false
+  
+  
+   5
+   8
+   0
+   0
+   0
+   0
+   2
+   0
+   0
+   0
+   0
+   0
+   85
+   60
+   true
+   false
+  
+ 
+ Sheet2
+ 1241
+ 0
+ 85
+ 60
+ false
+ true
+ true
+ true
+ 12632256
+ true
+ true
+ true
+ true
+ true
+ false
+ false
+ 1270
+ 1270
+ 1
+ 1
+ true
+ false
+
+   
+  
+  
+   7
+   false
+   false
+   true
+   true
+   false
+   false
+   false
+   1270
+   1270
+   true
+   true
+   true
+   true
+   true
+   false
+   12632256
+   false
+   Lexmark-E352dn
+   
+
+ cs
+ CZ
+ 
+ 
+ 
+
+
+ de
+ DE
+ 
+ 
+ 
+
+
+ en
+ US
+ 
+ 
+ 
+
+
+ nl
+ NL
+ 
+ 
+ 
+
+   
+   true
+   true
+   3
+   1
+   true
+   1
+   true
+   sgH+/0xleG1hcmstRTM1MmRuQ1VQUzpMZXhtYXJrLUUzNTJkbgAWAAMA0wAIAFZUAAAkbQAASm9iRGF0YSAxCnByaW50ZXI9TGV4bWFyay1FMzUyZG4Kb3JpZW50YXRpb249UG9ydHJhaXQKY29waWVzPTEKY29sbGF0ZT1mYWxzZQptYXJnaW5kYWp1c3RtZW50PTAsMCwwLDAKY29sb3JkZXB0aD0yNApwc2xldmVsPTAKcGRmZGV2aWNlPTEKY29sb3JkZXZpY2U9MApQUERDb250ZXhEYXRhCkR1cGxleDpOb25lAElucHV0U2xvdDpUcmF5MQBQYWdlU2l6ZTpMZXR0ZXIAABIAQ09NUEFUX0RVUExFWF9NT0RFDwBEdXBsZXhNb2RlOjpPZmY=
+   false
+   0
+  
+ 
+ 
+  
+   http://openoffice.org/2004/office; 
xmlns:xlink="http://www.w3.org/1999/xlink;>
+
+   
+  
+ 
+ 
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+ 
+ 
+  
+   
+   
+  
+  
+   
+  
+  
+   
+  
+  
+   
+
+   Kč
+  
+  
+   
+   -
+   
+
+   Kč
+   
+  
+  
+
+   
+
+  
+  
+
+   (
+   
+   )
+  
+  
+
+   -
+   
+
+  
+  
+   
+
+   
+   
+   
+  
+  
+   
+  
+  
+   
+  
+  
+   
+
+   Kč
+  
+  
+   -
+   
+
+   Kč
+   

[Libreoffice-commits] core.git: sc/qa

2017-02-01 Thread Zdeněk Crhonek
 sc/qa/unit/data/functions/addin/fods/imcosh.fods | 5913 ++
 sc/qa/unit/data/functions/addin/fods/imcot.fods  | 5983 +++
 2 files changed, 11896 insertions(+)

New commits:
commit cfc8714763bb7d3d002b73d7743150d588ccea75
Author: Zdeněk Crhonek 
Date:   Sat Jan 28 10:56:39 2017 +0100

add IMCOSH, IMCOT test case

Change-Id: Id81bcf7d9c93080116333be48e666e0cf10c6508
Reviewed-on: https://gerrit.libreoffice.org/33643
Tested-by: Jenkins 
Reviewed-by: Zdenek Crhonek 

diff --git a/sc/qa/unit/data/functions/addin/fods/imcosh.fods 
b/sc/qa/unit/data/functions/addin/fods/imcosh.fods
new file mode 100644
index 000..13e90b2
--- /dev/null
+++ b/sc/qa/unit/data/functions/addin/fods/imcosh.fods
@@ -0,0 +1,5913 @@
+
+
+http://www.w3.org/1999/xlink; 
xmlns:dc="http://purl.org/dc/elements/1.1/; 
xmlns:meta="urn:oasis:names:tc:opendocument:xmlns:meta:1.0" 
xmlns:number="urn:oasis:names:tc:opendocument:xmlns:datastyle:1.0" 
xmlns:presentation="urn:oasis:names:tc:opendocument:xmlns:presentation:1.0" 
xmlns:svg="urn:oasis:names:tc:opendocument:xmlns:svg-compatible:1.0" 
xmlns:chart="urn:oasis:names:tc:opendocument:xmlns:chart:1.0" 
xmlns:dr3d="urn:oasis:names:tc:opendocument:xmlns:dr3d:1.0" 
xmlns:math="http://www.w3.org/1998/Math/MathML; 
xmlns:form="urn:oasis:names:tc:opendocument:xmlns:form:1.0" xmlns:scr
 ipt="urn:oasis:names:tc:opendocument:xmlns:script:1.0" 
xmlns:config="urn:oasis:names:tc:opendocument:xmlns:config:1.0" 
xmlns:ooo="http://openoffice.org/2004/office; 
xmlns:ooow="http://openoffice.org/2004/writer; 
xmlns:oooc="http://openoffice.org/2004/calc; 
xmlns:dom="http://www.w3.org/2001/xml-events; 
xmlns:xforms="http://www.w3.org/2002/xforms; 
xmlns:xsd="http://www.w3.org/2001/XMLSchema; 
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance; 
xmlns:rpt="http://openoffice.org/2005/report; 
xmlns:of="urn:oasis:names:tc:opendocument:xmlns:of:1.2" 
xmlns:xhtml="http://www.w3.org/1999/xhtml; 
xmlns:grddl="http://www.w3.org/2003/g/data-view#; 
xmlns:tableooo="http://openoffice.org/2009/table; 
xmlns:drawooo="http://openoffice.org/2010/draw; 
xmlns:calcext="urn:org:documentfoundation:names:experimental:calc:xmlns:calcext:1.0"
 
xmlns:loext="urn:org:documentfoundation:names:experimental:office:xmlns:loext:1.0"
 xmlns:field="urn:openoffice:names:experimental:ooo-ms-interop:xmlns:field:1.0" 
xmlns:form
 x="urn:openoffice:names:experimental:ooxml-odf-interop:xmlns:form:1.0" 
xmlns:css3t="http://www.w3.org/TR/css3-text/; office:version="1.2" 
office:mimetype="application/vnd.oasis.opendocument.spreadsheet">
+ 
2016-12-29T18:23:56.52200P0D1LibreOfficeDev/5.3.0.0.alpha1$Linux_X86_64
 
LibreOffice_project/883024d657fb45c7da459017d2f936aac5644bfb
+ 
+  
+   0
+   0
+   77413
+   360254
+   
+
+ view1
+ 
+  
+   2
+   8
+   0
+   0
+   0
+   0
+   2
+   0
+   0
+   0
+   0
+   0
+   75
+   60
+   true
+   false
+  
+  
+   1
+   7
+   0
+   0
+   0
+   0
+   2
+   0
+   0
+   0
+   0
+   0
+   75
+   60
+   true
+   false
+  
+ 
+ Sheet2
+ 1241
+ 0
+ 75
+ 60
+ false
+ true
+ true
+ true
+ 12632256
+ true
+ true
+ true
+ true
+ true
+ false
+ false
+ 1270
+ 1270
+ 1
+ 1
+ true
+ false
+
+   
+  
+  
+   7
+   false
+   false
+   true
+   true
+   false
+   false
+   false
+   1270
+   1270
+   true
+   true
+   true
+   true
+   true
+   false
+   12632256
+   false
+   Lexmark-E352dn
+   
+
+ cs
+ CZ
+ 
+ 
+ 
+
+
+ de
+ DE
+ 
+ 
+ 
+
+
+ en
+ US
+ 
+ 
+ 
+
+
+ nl
+ NL
+ 
+ 
+ 
+
+   
+   true
+   true
+   3
+   1
+   true
+   1
+   true
+   sgH+/0xleG1hcmstRTM1MmRuQ1VQUzpMZXhtYXJrLUUzNTJkbgAWAAMA0wAIAFZUAAAkbQAASm9iRGF0YSAxCnByaW50ZXI9TGV4bWFyay1FMzUyZG4Kb3JpZW50YXRpb249UG9ydHJhaXQKY29waWVzPTEKY29sbGF0ZT1mYWxzZQptYXJnaW5kYWp1c3RtZW50PTAsMCwwLDAKY29sb3JkZXB0aD0yNApwc2xldmVsPTAKcGRmZGV2aWNlPTEKY29sb3JkZXZpY2U9MApQUERDb250ZXhEYXRhCkR1cGxleDpOb25lAElucHV0U2xvdDpUcmF5MQBQYWdlU2l6ZTpMZXR0ZXIAABIAQ09NUEFUX0RVUExFWF9NT0RFDwBEdXBsZXhNb2RlOjpPZmY=
+   false
+   0
+  
+ 
+ 
+  
+   http://openoffice.org/2004/office; 
xmlns:xlink="http://www.w3.org/1999/xlink;>
+
+   
+  
+ 
+ 
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+ 
+ 
+  
+   
+   
+  
+  
+   
+  
+  
+   
+  
+  
+   
+
+   Kč
+  
+  
+   
+   -
+   
+
+   Kč
+   
+  
+  
+
+   
+
+  
+  
+
+   (
+   
+   )
+  
+  
+
+   -
+   
+
+  
+  
+   
+
+   
+   
+  

[Libreoffice-bugs] [Bug 105688] New: SAXParseException error on particular document

2017-02-01 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=105688

Bug ID: 105688
   Summary: SAXParseException error on particular document
   Product: LibreOffice
   Version: 5.2.5.1 release
  Hardware: x86-64 (AMD64)
OS: Linux (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Writer
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: russianneuroman...@ya.ru

Description:
Document that available in Download section on this page
https://customers.microsoft.com/en-us/story/turkish-bank-upgrades-communications-to-respond-faster
can not be opened in LibreOffice and Collabora Online.



Steps to Reproduce:
1. Open page
https://customers.microsoft.com/en-us/story/turkish-bank-upgrades-communications-to-respond-faster
 
2. Click on download link in Download section of this page.
3. Try to open downloaded document in LibreOffice or Collabora Online.

Actual Results:  
Error messages:

LibreOffice Writer:
File format error found at 
SAXParseException: '[word/document.xml line 2]: unknown error', Stream
'word/document.xml', Line 2, Column 108499(row,col).
After click on OK LibreOffice Writer exit.

Collabora Online:
Failed to load the document. Please ensure the file type is supported and not
corrupted, and try again.
Then instead of returning to documents list Collabora Online stay open with
"Connecting..." progress indicator which is probably shouldn't happen in case
of such error.

Expected Results:
LibreOffice Writer: open document.
Collabora Online: open document or at least exit gracefully after displaying
error message.


Reproducible: Always

User Profile Reset: No

Additional Info:


User-Agent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like
Gecko) Chrome/55.0.2883.87 Safari/537.36 OPR/42.0.2393.517

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-commits] core.git: sc/qa

2017-02-01 Thread Kohei Yoshida
 sc/qa/unit/ucalc.cxx |   54 ++-
 sc/qa/unit/ucalc.hxx |2 +
 2 files changed, 55 insertions(+), 1 deletion(-)

New commits:
commit 9966697b89a68e05f2182dfef984d7b6e8e9ef94
Author: Kohei Yoshida 
Date:   Wed Feb 1 22:48:55 2017 -0500

tdf#105629: add test case for the auto filter usage with time values.

Change-Id: Ic459eefde02037c0aa615044003abaf03e48f9e3
Reviewed-on: https://gerrit.libreoffice.org/33819
Tested-by: Jenkins 
Reviewed-by: Kohei Yoshida 

diff --git a/sc/qa/unit/ucalc.cxx b/sc/qa/unit/ucalc.cxx
index 969c1a2..a23bda1 100644
--- a/sc/qa/unit/ucalc.cxx
+++ b/sc/qa/unit/ucalc.cxx
@@ -54,6 +54,7 @@
 #include "queryparam.hxx"
 #include "edittextiterator.hxx"
 #include "editutil.hxx"
+#include "cellform.hxx"
 #include 
 #include 
 #include 
@@ -3026,6 +3027,55 @@ void Test::testAutofilter()
 m_pDoc->DeleteTab(0);
 }
 
+void Test::testAutoFilterTimeValue()
+{
+m_pDoc->InsertTab(0, "Test");
+
+m_pDoc->SetString(ScAddress(0,0,0), "Hours");
+m_pDoc->SetValue(ScAddress(0,1,0), 72.360416671);
+m_pDoc->SetValue(ScAddress(0,2,0), 265);
+
+ScDBData* pDBData = new ScDBData(STR_DB_GLOBAL_NONAME, 0, 0, 0, 0, 2);
+m_pDoc->SetAnonymousDBData(0, pDBData);
+
+// Apply the "hour:minute:second" format to A2:A3.
+SvNumberFormatter* pFormatter = m_pDoc->GetFormatTable();
+sal_uInt32 nFormat = pFormatter->GetFormatIndex(NF_TIME_HH_MMSS, 
LANGUAGE_ENGLISH_US);
+ScPatternAttr aNewAttrs(m_pDoc->GetPool());
+SfxItemSet& rSet = aNewAttrs.GetItemSet();
+rSet.Put(SfxUInt32Item(ATTR_VALUE_FORMAT, nFormat));
+
+m_pDoc->ApplyPatternAreaTab(0, 1, 0, 2, 0, aNewAttrs); // apply it to 
A2:A3.
+
+printRange(m_pDoc, ScRange(0,0,0,0,2,0), "Data"); // A1:A3
+
+// Make sure the hour:minute:second format is really applied.
+CPPUNIT_ASSERT_EQUAL(OUString("1736:39:00"), 
m_pDoc->GetString(ScAddress(0,1,0))); // A2
+CPPUNIT_ASSERT_EQUAL(OUString("6360:00:00"), 
m_pDoc->GetString(ScAddress(0,2,0))); // A3
+
+// Filter by the A2 value.  Only A1 and A2 should be visible.
+ScQueryParam aParam;
+pDBData->GetQueryParam(aParam);
+ScQueryEntry& rEntry = aParam.GetEntry(0);
+rEntry.bDoQuery = true;
+rEntry.nField = 0;
+rEntry.eOp = SC_EQUAL;
+rEntry.GetQueryItem().maString = 
m_pDoc->GetSharedStringPool().intern("1736:39:00");
+rEntry.GetQueryItem().meType = ScQueryEntry::ByString;
+
+pDBData->SetQueryParam(aParam);
+
+// perform the query.
+m_pDoc->Query(0, aParam, true);
+
+// A1:A2 should be visible while A3 should be filtered out.
+CPPUNIT_ASSERT_MESSAGE("A1 should be visible.", !m_pDoc->RowFiltered(0,0));
+CPPUNIT_ASSERT_MESSAGE("A2 should be visible.", !m_pDoc->RowFiltered(1,0));
+CPPUNIT_ASSERT_MESSAGE("A3 should be filtered out.", 
m_pDoc->RowFiltered(2,0));
+
+m_pDoc->DeleteTab(0);
+}
+
 void Test::testAdvancedFilter()
 {
 m_pDoc->InsertTab(0, "Test");
@@ -6377,7 +6427,9 @@ void Test::printRange(ScDocument* pDoc, const ScRange& 
rRange, const char* pCapt
 {
 for (SCCOL nCol = nCol1; nCol <= nCol2; ++nCol)
 {
-OUString aVal = pDoc->GetString(nCol, nRow, rRange.aStart.Tab());
+ScAddress aPos(nCol, nRow, rRange.aStart.Tab());
+ScRefCellValue aCell(*pDoc, aPos);
+OUString aVal = ScCellFormat::GetOutputString(*pDoc, aPos, aCell);
 printer.set(nRow-nRow1, nCol-nCol1, aVal);
 }
 }
diff --git a/sc/qa/unit/ucalc.hxx b/sc/qa/unit/ucalc.hxx
index 0ae9fcd..9852426 100644
--- a/sc/qa/unit/ucalc.hxx
+++ b/sc/qa/unit/ucalc.hxx
@@ -322,6 +322,7 @@ public:
 void testSheetMove();
 void testDataArea();
 void testAutofilter();
+void testAutoFilterTimeValue();
 void testAdvancedFilter();
 void testCopyPaste();
 void testCopyPasteAsLink();
@@ -625,6 +626,7 @@ public:
 CPPUNIT_TEST(testFunctionLists);
 CPPUNIT_TEST(testToggleRefFlag);
 CPPUNIT_TEST(testAutofilter);
+CPPUNIT_TEST(testAutoFilterTimeValue);
 CPPUNIT_TEST(testAdvancedFilter);
 CPPUNIT_TEST(testCopyPaste);
 CPPUNIT_TEST(testCopyPasteAsLink);
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-commits] core.git: sc/qa

2017-02-01 Thread Kohei Yoshida
 sc/qa/unit/ucalc.cxx |   93 +++
 sc/qa/unit/ucalc.hxx |2 +
 2 files changed, 95 insertions(+)

New commits:
commit 73ac88748ff7077e8189603935bd48242cfe9776
Author: Kohei Yoshida 
Date:   Tue Jan 31 22:21:35 2017 -0500

tdf#105629: add test for the advanced filter usage.

The test case itself is derived from tdf#43831.

Change-Id: Ifd847e84b84b02c1eb74572303af729c30c4f380
Reviewed-on: https://gerrit.libreoffice.org/33818
Reviewed-by: Kohei Yoshida 
Tested-by: Kohei Yoshida 

diff --git a/sc/qa/unit/ucalc.cxx b/sc/qa/unit/ucalc.cxx
index b7417ba..969c1a2 100644
--- a/sc/qa/unit/ucalc.cxx
+++ b/sc/qa/unit/ucalc.cxx
@@ -3026,6 +3026,99 @@ void Test::testAutofilter()
 m_pDoc->DeleteTab(0);
 }
 
+void Test::testAdvancedFilter()
+{
+m_pDoc->InsertTab(0, "Test");
+
+// cell contents (nullptr = empty cell)
+std::vector aData = {
+{ "Value", "Tag" }, // A1:B11
+{  "1", "R" },
+{  "2", "R" },
+{  "3", "R" },
+{  "4", "C" },
+{  "5", "C" },
+{  "6", "C" },
+{  "7", "R" },
+{  "8", "R" },
+{  "9", "R" },
+{ "10", "C" },
+{ nullptr },
+{ "Value", "Tag" }, // A13:B14
+{ "> 5", "R" },
+};
+
+// Populate cells.
+for (size_t nRow = 0; nRow < aData.size(); ++nRow)
+{
+const std::vector& rRowData = aData[nRow];
+for (size_t nCol = 0; nCol < rRowData.size(); ++nCol)
+{
+const char* pCell = rRowData[nCol];
+if (pCell)
+m_pDoc->SetString(nCol, nRow, 0, 
OUString::createFromAscii(pCell));
+}
+}
+
+ScDBData* pDBData = new ScDBData(STR_DB_GLOBAL_NONAME, 0, 0, 0, 1, 10);
+m_pDoc->SetAnonymousDBData(0, pDBData);
+
+ScRange aDataRange(0,0,0,1,10,0);
+ScRange aFilterRuleRange(0,12,0,1,13,0);
+
+printRange(m_pDoc, aDataRange, "Data");
+printRange(m_pDoc, aFilterRuleRange, "Filter Rule");
+
+ScQueryParam aQueryParam;
+aQueryParam.bHasHeader = true;
+aQueryParam.nCol1 = aDataRange.aStart.Col();
+aQueryParam.nRow1 = aDataRange.aStart.Row();
+aQueryParam.nCol2 = aDataRange.aEnd.Col();
+aQueryParam.nRow2 = aDataRange.aEnd.Row();
+aQueryParam.nTab = aDataRange.aStart.Tab();
+
+bool bGood = m_pDoc->CreateQueryParam(aFilterRuleRange, aQueryParam);
+CPPUNIT_ASSERT_MESSAGE("failed to create query param.", bGood);
+
+// First entry is for the 'Value' field, and is greater than 5.
+ScQueryEntry aEntry = aQueryParam.GetEntry(0);
+CPPUNIT_ASSERT(aEntry.bDoQuery);
+CPPUNIT_ASSERT_EQUAL(SCCOLROW(0), aEntry.nField);
+CPPUNIT_ASSERT_EQUAL(SC_GREATER, aEntry.eOp);
+
+ScQueryEntry::QueryItemsType aItems = aEntry.GetQueryItems();
+CPPUNIT_ASSERT_EQUAL(size_t(1), aItems.size());
+CPPUNIT_ASSERT_EQUAL(ScQueryEntry::ByValue, aItems[0].meType);
+CPPUNIT_ASSERT_EQUAL(5.0, aItems[0].mfVal);
+
+// Second entry is for the 'Tag' field, and is == 'R'.
+aEntry = aQueryParam.GetEntry(1);
+CPPUNIT_ASSERT(aEntry.bDoQuery);
+CPPUNIT_ASSERT_EQUAL(SCCOLROW(1), aEntry.nField);
+CPPUNIT_ASSERT_EQUAL(SC_EQUAL, aEntry.eOp);
+
+aItems = aEntry.GetQueryItems();
+CPPUNIT_ASSERT_EQUAL(size_t(1), aItems.size());
+CPPUNIT_ASSERT_EQUAL(ScQueryEntry::ByString, aItems[0].meType);
+CPPUNIT_ASSERT_EQUAL(OUString("R"), aItems[0].maString.getString());
+
+// perform the query.
+m_pDoc->Query(0, aQueryParam, true);
+
+// Only rows 1,8-10 should be visible.
+bool bFiltered = m_pDoc->RowFiltered(0, 0);
+CPPUNIT_ASSERT_MESSAGE("row 1 (header row) should be visible", !bFiltered);
+
+SCROW nRow1 = -1, nRow2 = -1;
+bFiltered = m_pDoc->RowFiltered(1, 0, , );
+CPPUNIT_ASSERT_MESSAGE("rows 2-7 should be filtered out.", bFiltered && 
nRow1 == 1 && nRow2 == 6);
+
+bFiltered = m_pDoc->RowFiltered(7, 0, , );
+CPPUNIT_ASSERT_MESSAGE("rows 8-10 should be visible.", !bFiltered && nRow1 
== 7 && nRow2 == 9);
+
+m_pDoc->DeleteTab(0);
+}
+
 void Test::testCopyPaste()
 {
 m_pDoc->InsertTab(0, "Sheet1");
diff --git a/sc/qa/unit/ucalc.hxx b/sc/qa/unit/ucalc.hxx
index 041a827..0ae9fcd 100644
--- a/sc/qa/unit/ucalc.hxx
+++ b/sc/qa/unit/ucalc.hxx
@@ -322,6 +322,7 @@ public:
 void testSheetMove();
 void testDataArea();
 void testAutofilter();
+void testAdvancedFilter();
 void testCopyPaste();
 void testCopyPasteAsLink();
 void testCopyPasteTranspose();
@@ -624,6 +625,7 @@ public:
 CPPUNIT_TEST(testFunctionLists);
 CPPUNIT_TEST(testToggleRefFlag);
 CPPUNIT_TEST(testAutofilter);
+CPPUNIT_TEST(testAdvancedFilter);
 CPPUNIT_TEST(testCopyPaste);
 CPPUNIT_TEST(testCopyPasteAsLink);
 CPPUNIT_TEST(testCopyPasteTranspose);
___
Libreoffice-commits mailing list

[Libreoffice-commits] core.git: sc/inc sc/source

2017-02-01 Thread Kohei Yoshida
 sc/inc/document.hxx|3 +--
 sc/source/core/data/documen3.cxx   |   14 +-
 sc/source/filter/excel/excimp8.cxx |4 +---
 sc/source/ui/dbgui/sfiltdlg.cxx|8 +---
 sc/source/ui/unoobj/cellsuno.cxx   |6 +-
 sc/source/ui/view/dbfunc3.cxx  |5 +
 6 files changed, 14 insertions(+), 26 deletions(-)

New commits:
commit 871614789ca7af6ebe51a3e7615551176642891a
Author: Kohei Yoshida 
Date:   Tue Jan 31 22:19:43 2017 -0500

CreateQueryParam to take a ScRange parameter.

This simplifies its usage a bit.

Change-Id: Idd5b24897f65c7cf8b7ff88806dd058c35c95ffe
Reviewed-on: https://gerrit.libreoffice.org/33817
Tested-by: Jenkins 
Reviewed-by: Kohei Yoshida 

diff --git a/sc/inc/document.hxx b/sc/inc/document.hxx
index 3f494b7..ee50a0a 100644
--- a/sc/inc/document.hxx
+++ b/sc/inc/document.hxx
@@ -1872,8 +1872,7 @@ public:
 void Reorder( const sc::ReorderParam& rParam );
 
 SCSIZE  Query( SCTAB nTab, const ScQueryParam& rQueryParam, bool 
bKeepSub );
-SC_DLLPUBLIC bool   CreateQueryParam( SCCOL nCol1, SCROW nRow1, 
SCCOL nCol2, SCROW nRow2,
-SCTAB nTab, ScQueryParam& rQueryParam 
);
+SC_DLLPUBLIC bool CreateQueryParam( const ScRange& rRange, ScQueryParam& 
rQueryParam );
 voidGetUpperCellString(SCCOL nCol, SCROW nRow, SCTAB nTab, 
OUString& rStr);
 
 /**
diff --git a/sc/source/core/data/documen3.cxx b/sc/source/core/data/documen3.cxx
index 3e2d1ac..bbece70 100644
--- a/sc/source/core/data/documen3.cxx
+++ b/sc/source/core/data/documen3.cxx
@@ -1424,13 +1424,17 @@ void ScDocument::GetUpperCellString(SCCOL nCol, SCROW 
nRow, SCTAB nTab, OUString
 rStr.clear();
 }
 
-bool ScDocument::CreateQueryParam(SCCOL nCol1, SCROW nRow1, SCCOL nCol2, SCROW 
nRow2, SCTAB nTab, ScQueryParam& rQueryParam)
+bool ScDocument::CreateQueryParam( const ScRange& rRange, ScQueryParam& 
rQueryParam )
 {
-if ( ValidTab(nTab) && nTab < static_cast(maTabs.size()) && 
maTabs[nTab] )
-return maTabs[nTab]->CreateQueryParam(nCol1, nRow1, nCol2, nRow2, 
rQueryParam);
+ScTable* pTab = FetchTable(rRange.aStart.Tab());
+if (!pTab)
+{
+OSL_FAIL("missing tab");
+return false;
+}
 
-OSL_FAIL("missing tab");
-return false;
+return pTab->CreateQueryParam(
+rRange.aStart.Col(), rRange.aStart.Row(), rRange.aEnd.Col(), 
rRange.aEnd.Row(), rQueryParam);
 }
 
 bool ScDocument::HasAutoFilter( SCCOL nCurCol, SCROW nCurRow, SCTAB nCurTab )
diff --git a/sc/source/filter/excel/excimp8.cxx 
b/sc/source/filter/excel/excimp8.cxx
index 020962d..d7f1ab7 100644
--- a/sc/source/filter/excel/excimp8.cxx
+++ b/sc/source/filter/excel/excimp8.cxx
@@ -546,9 +546,7 @@ void XclImpAutoFilterData::InsertQueryParam()
 ScRange aAdvRange;
 boolbHasAdv = pCurrDBData->GetAdvancedQuerySource( aAdvRange );
 if( bHasAdv )
-pExcRoot->pIR->GetDoc().CreateQueryParam( aAdvRange.aStart.Col(),
-aAdvRange.aStart.Row(), aAdvRange.aEnd.Col(), 
aAdvRange.aEnd.Row(),
-aAdvRange.aStart.Tab(), aParam );
+pExcRoot->pIR->GetDoc().CreateQueryParam(aAdvRange, aParam);
 
 pCurrDBData->SetQueryParam( aParam );
 if( bHasAdv )
diff --git a/sc/source/ui/dbgui/sfiltdlg.cxx b/sc/source/ui/dbgui/sfiltdlg.cxx
index 4f5eca4..d3622bc 100644
--- a/sc/source/ui/dbgui/sfiltdlg.cxx
+++ b/sc/source/ui/dbgui/sfiltdlg.cxx
@@ -365,13 +365,7 @@ IMPL_LINK( ScSpecialFilterDlg, EndDlgHdl, Button*, pBtn, 
void )
 theOutParam.bDuplicate = !pBtnUnique->IsChecked();
 theOutParam.bDestPers  = pBtnDestPers->IsChecked();
 
-bQueryOk =
-pDoc->CreateQueryParam( rStart.Col(),
-rStart.Row(),
-rEnd.Col(),
-rEnd.Row(),
-rStart.Tab(),
-theOutParam );
+bQueryOk = pDoc->CreateQueryParam(ScRange(rStart,rEnd), 
theOutParam);
 }
 }
 
diff --git a/sc/source/ui/unoobj/cellsuno.cxx b/sc/source/ui/unoobj/cellsuno.cxx
index 6e325a5..ae624ce 100644
--- a/sc/source/ui/unoobj/cellsuno.cxx
+++ b/sc/source/ui/unoobj/cellsuno.cxx
@@ -5660,11 +5660,7 @@ uno::Reference SAL_CALL 
ScCellRangeObj::createFil
 aParam.nTab  = aDataAddress.Sheet;
 
 ScDocument& rDoc = pDocSh->GetDocument();
-bool bOk = rDoc.CreateQueryParam(
-aRange.aStart.Col(), aRange.aStart.Row(),
-aRange.aEnd.Col(), aRange.aEnd.Row(),
-aRange.aStart.Tab(), aParam );
-if ( bOk )
+if (rDoc.CreateQueryParam(aRange, aParam))
 {
  

[Libreoffice-commits] core.git: sc/source

2017-02-01 Thread Kohei Yoshida
 sc/source/core/data/table3.cxx |   29 ++---
 1 file changed, 14 insertions(+), 15 deletions(-)

New commits:
commit 42e472b5870278058537d43d03d457dc80b16166
Author: Kohei Yoshida 
Date:   Mon Jan 30 22:01:45 2017 -0500

tdf#105629: Let's move the advanced-filter specific stuff ...

to the place where we actually parse the filtering rules for advanced
filter queries.

Change-Id: I87650227e15fa54303efd720530d31ecf9827226
Reviewed-on: https://gerrit.libreoffice.org/33816
Tested-by: Jenkins 
Reviewed-by: Kohei Yoshida 

diff --git a/sc/source/core/data/table3.cxx b/sc/source/core/data/table3.cxx
index 64c082b..17cc5b3 100644
--- a/sc/source/core/data/table3.cxx
+++ b/sc/source/core/data/table3.cxx
@@ -2888,26 +2888,15 @@ public:
 
 void operator() (ScQueryEntry::Item& rItem)
 {
-if (rItem.meType != ScQueryEntry::ByString && rItem.meType != 
ScQueryEntry::ByDate)
+// Double-check if the query by date is really appropriate.
+
+if (rItem.meType != ScQueryEntry::ByDate)
 return;
 
 sal_uInt32 nIndex = 0;
 bool bNumber = mrDoc.GetFormatTable()->
 IsNumberFormat(rItem.maString.getString(), nIndex, rItem.mfVal);
 
-// Advanced Filter creates only ByString queries that need to be
-// converted to ByValue if appropriate. rItem.mfVal now holds the value
-// if bNumber==true.
-
-if (rItem.meType == ScQueryEntry::ByString)
-{
-if (bNumber)
-rItem.meType = ScQueryEntry::ByValue;
-return;
-}
-
-// Double-check if the query by date is really appropriate.
-
 if (bNumber && ((nIndex % SV_COUNTRY_LANGUAGE_OFFSET) != 0))
 {
 const SvNumberformat* pEntry = 
mrDoc.GetFormatTable()->GetEntry(nIndex);
@@ -3272,12 +3261,22 @@ bool ScTable::CreateQueryParam(SCCOL nCol1, SCROW 
nRow1, SCCOL nCol2, SCROW nRow
 if (!bValid)
 bValid = CreateExcelQuery(nCol1, nRow1, nCol2, nRow2, rQueryParam);
 
+SvNumberFormatter* pFormatter = pDocument->GetFormatTable();
 nCount = rQueryParam.GetEntryCount();
+
 if (bValid)
 {
 //  bQueryByString must be set
 for (i=0; i < nCount; i++)
-rQueryParam.GetEntry(i).GetQueryItem().meType = 
ScQueryEntry::ByString;
+{
+ScQueryEntry::Item& rItem = rQueryParam.GetEntry(i).GetQueryItem();
+
+sal_uInt32 nIndex = 0;
+bool bNumber = pFormatter->IsNumberFormat(
+rItem.maString.getString(), nIndex, rItem.mfVal);
+
+rItem.meType = bNumber ? ScQueryEntry::ByValue : 
ScQueryEntry::ByString;
+}
 }
 else
 {
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-bugs] [Bug 105628] TOC cannot be made to show chapter number on doc with page numbers by chapter

2017-02-01 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=105628

--- Comment #4 from Lee <92ma...@gmail.com> ---
There is a way to generate a Table of Contents (TOC) with page numbering by
chapter. It was difficult to find the sequence that produces the desired
result. It is as follows:

Insert a Table of Contents. Then edit that TOC.  For each of the levels, make
the following changes just before the page number field (in the blank area)
1. Add the chapter number field
2. In the blank area between the E# and #, place a hyphen
3. (this is the part that is not well documented.) Select the E# field just
entered.  Change the field "Evaluate up to level:" make the value a 1.

Since there is a way to create a TOC with page numbers by chapter, it remains
for someone with an understanding of the architecture to determine if this is
the intended solution.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 105496] Standard Filter dialog box too big multi-display setup, unable to resize Standard Filter Dialog

2017-02-01 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=105496

--- Comment #4 from dbely...@gmail.com ---
Great!
Ok downloaded ver.:  5.4.0.0.alpha0+
from:
http://dev-builds.libreoffice.org/daily/master/Win-x86@62-merge-TDF/2017-02-02_00.34.40/

can confirm that the Standard filter dialog appears on the correct monitor is
is of reasonable size (still not re-sizable, but I think that's by design)

bonus: tried the same version in MacOS, I think I found a different bug, will
submit separately

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-ux-advise] [Bug 105496] Standard Filter dialog box too big multi-display setup, unable to resize Standard Filter Dialog

2017-02-01 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=105496

--- Comment #4 from dbely...@gmail.com ---
Great!
Ok downloaded ver.:  5.4.0.0.alpha0+
from:
http://dev-builds.libreoffice.org/daily/master/Win-x86@62-merge-TDF/2017-02-02_00.34.40/

can confirm that the Standard filter dialog appears on the correct monitor is
is of reasonable size (still not re-sizable, but I think that's by design)

bonus: tried the same version in MacOS, I think I found a different bug, will
submit separately

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Libreoffice-ux-advise mailing list
Libreoffice-ux-advise@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise


[Libreoffice-commits] core.git: Branch 'libreoffice-5-3' - xmlsecurity/uiconfig

2017-02-01 Thread Samuel Mehrbrodt
 xmlsecurity/uiconfig/ui/digitalsignaturesdialog.ui |4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

New commits:
commit 75c305ad1cff7f4a4cae97e02297e7f1fbddab44
Author: Samuel Mehrbrodt 
Date:   Tue Jan 31 13:50:20 2017 +0100

tdf#105637 Digital signatures dialog has unnessary labels

Change-Id: I474968d566a31fba29bcdc1f74749de8e86fedce
Reviewed-on: https://gerrit.libreoffice.org/33754
Reviewed-by: Samuel Mehrbrodt 
Tested-by: Samuel Mehrbrodt 
(cherry picked from commit 1478f81f236b88377293432a642def218e228145)
Reviewed-on: https://gerrit.libreoffice.org/33780
Tested-by: Jenkins 
Reviewed-by: Adolfo Jayme Barrientos 
Tested-by: Adolfo Jayme Barrientos 

diff --git a/xmlsecurity/uiconfig/ui/digitalsignaturesdialog.ui 
b/xmlsecurity/uiconfig/ui/digitalsignaturesdialog.ui
index d79d7e9..31bec83 100644
--- a/xmlsecurity/uiconfig/ui/digitalsignaturesdialog.ui
+++ b/xmlsecurity/uiconfig/ui/digitalsignaturesdialog.ui
@@ -194,7 +194,7 @@
 
 
   
-True
+True
 False
 Description
   
@@ -205,7 +205,7 @@
 
 
   
-True
+True
 False
 Signature 
type
   
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-bugs] [Bug 105687] New: FILEOPEN, Crash in: sdr::table::TableRow::dispose()

2017-02-01 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=105687

Bug ID: 105687
   Summary: FILEOPEN, Crash in: sdr::table::TableRow::dispose()
   Product: LibreOffice
   Version: unspecified
  Hardware: x86-64 (AMD64)
OS: Windows (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Impress
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: l1068...@mvrht.com

This bug was filed from the crash reporting server and is
br-bdf3c8a8-a76e-4935-ae55-54c7d6a69103.
=
Opening big file (sample too big to be included here) upsets Impress. In
PowerPoint it works fine. You can download sample file from here
https://ufile.io/1086c1

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 82707] STATUSBAR: Unify click behaviour

2017-02-01 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=82707

--- Comment #19 from Commit Notification 
 ---
Adolfo Jayme Barrientos committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=5f33745c1d6750126e53a02b2a95355a3e5b16a0

tdf#105669 tdf#82707 A single click in the status bar is now enough

It will be available in 5.4.0.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 82707] STATUSBAR: Unify click behaviour

2017-02-01 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=82707

Commit Notification  changed:

   What|Removed |Added

 Whiteboard| target:4.4.0   | target:4.4.0 target:5.4.0

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-ux-advise] [Bug 82707] STATUSBAR: Unify click behaviour

2017-02-01 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=82707

--- Comment #19 from Commit Notification 
 ---
Adolfo Jayme Barrientos committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=5f33745c1d6750126e53a02b2a95355a3e5b16a0

tdf#105669 tdf#82707 A single click in the status bar is now enough

It will be available in 5.4.0.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Libreoffice-ux-advise mailing list
Libreoffice-ux-advise@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise


[Libreoffice-ux-advise] [Bug 82707] STATUSBAR: Unify click behaviour

2017-02-01 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=82707

Commit Notification  changed:

   What|Removed |Added

 Whiteboard| target:4.4.0   | target:4.4.0 target:5.4.0

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Libreoffice-ux-advise mailing list
Libreoffice-ux-advise@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise


[Libreoffice-bugs] [Bug 86066] [META] Improvements to the statusbar

2017-02-01 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=86066
Bug 86066 depends on bug 105669, which changed state.

Bug 105669 Summary: Double-clic instead of single-clic
https://bugs.documentfoundation.org/show_bug.cgi?id=105669

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 105669] Double-clic instead of single-clic

2017-02-01 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=105669

Adolfo Jayme  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |FIXED
   Assignee|libreoffice-b...@lists.free |f...@libreoffice.org
   |desktop.org |

--- Comment #3 from Adolfo Jayme  ---
Thanks for the finding! Fixed.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-ux-advise] [Bug 82707] STATUSBAR: Unify click behaviour

2017-02-01 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=82707
Bug 82707 depends on bug 105669, which changed state.

Bug 105669 Summary: Double-clic instead of single-clic
https://bugs.documentfoundation.org/show_bug.cgi?id=105669

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Libreoffice-ux-advise mailing list
Libreoffice-ux-advise@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise


[Libreoffice-bugs] [Bug 82707] STATUSBAR: Unify click behaviour

2017-02-01 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=82707
Bug 82707 depends on bug 105669, which changed state.

Bug 105669 Summary: Double-clic instead of single-clic
https://bugs.documentfoundation.org/show_bug.cgi?id=105669

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-commits] core.git: svx/source

2017-02-01 Thread Adolfo Jayme Barrientos
 svx/source/stbctrls/stbctrls.src |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 5f33745c1d6750126e53a02b2a95355a3e5b16a0
Author: Adolfo Jayme Barrientos 
Date:   Wed Feb 1 20:11:13 2017 -0600

tdf#105669 tdf#82707 A single click in the status bar is now enough

Change-Id: I5acc6ce95a3dc7fe6e23088ef2ec9c6a93d32670

diff --git a/svx/source/stbctrls/stbctrls.src b/svx/source/stbctrls/stbctrls.src
index 83618a4..36eb871 100644
--- a/svx/source/stbctrls/stbctrls.src
+++ b/svx/source/stbctrls/stbctrls.src
@@ -100,7 +100,7 @@ String RID_SVXSTR_XMLSEC_SIG_CERT_OK_PARTIAL_SIG
 
 String RID_SVXSTR_DOC_MODIFIED_YES
 {
-Text [ en-US ] = "The document has been modified. Double-click to save the 
document.";
+Text [ en-US ] = "The document has been modified. Click to save the 
document.";
 };
 
 String RID_SVXSTR_DOC_MODIFIED_NO
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-commits] core.git: Branch 'aoo/trunk' - LICENSE NOTICE README

2017-02-01 Thread Pedro Giffuni
 LICENSE |3 ++-
 NOTICE  |2 +-
 README  |3 ++-
 3 files changed, 5 insertions(+), 3 deletions(-)

New commits:
commit 1f450b40ebf1e1f6b336ce362277026a0408db5a
Author: Pedro Giffuni 
Date:   Thu Feb 2 00:13:07 2017 +

Let's leave the $HeadURL$ in the end.

Looks better and serves the same purpose.

diff --git a/LICENSE b/LICENSE
index 3becfa3..9e1e938 100644
--- a/LICENSE
+++ b/LICENSE
@@ -1,4 +1,3 @@
-$HeadURL$
 
  Apache License
Version 2.0, January 2004
@@ -1962,3 +1961,5 @@ If you redistribute modified sources, we would appreciate 
that you include in
 the file ChangeLog history information documenting your changes.  Please read
 the FAQ for more information on the distribution of modified source versions.
 
+
+$HeadURL$
diff --git a/NOTICE b/NOTICE
index f9f89c7..6f128dc 100644
--- a/NOTICE
+++ b/NOTICE
@@ -1,4 +1,3 @@
-$HeadURL$
 
 Apache OpenOffice (http://www.openoffice.org)
 Copyright 2011, 2017 The Apache Software Foundation
@@ -159,3 +158,4 @@ 
 This product includes software developed by the OpenSSL Project
 for use in the OpenSSL Toolkit. (http://www.openssl.org/)
 
+$HeadURL$
diff --git a/README b/README
index d1620cf..5ebf898 100644
--- a/README
+++ b/README
@@ -1,4 +1,3 @@
-$HeadURL$
 
 Apache OpenOffice (AOO)
 ===
@@ -58,3 +57,5 @@ Building Apache OpenOffice
 The default build will produce a setup version (e.g. setup program on 
windows, dmg on Mac OS, 
 rpm and deb packages on Linux, pkg packages on Solaris) and an archived 
version. The output
 can be found in the  directory in 
instsetoo_native//Apache_OpenOffice/...
+
+$HeadURL$
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-bugs] [Bug 105686] FILTER: STYLE function is imported wrongly when is part of named formula (ods)

2017-02-01 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=105686

--- Comment #1 from m.a.riosv  ---
Created attachment 130822
  --> https://bugs.documentfoundation.org/attachment.cgi?id=130822=edit
File with the Style function as part of named formula.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 105686] New: FILTER: STYLE function is imported wrongly when is part of named formula (ods)

2017-02-01 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=105686

Bug ID: 105686
   Summary: FILTER: STYLE function is imported wrongly when is
part of named formula (ods)
   Product: LibreOffice
   Version: 5.4.0.0.alpha0+ Master
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: major
  Priority: medium
 Component: Calc
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: miguelange...@libreoffice.org

Description:
STYLE function is imported wrongly when is part of named formula (ods)

Steps to Reproduce:
1.Open attached file
2.Named formula is broken, style function not properly imported.
3.

Actual Results:  
.

Expected Results:
.


Reproducible: Always

User Profile Reset: No

Additional Info:


User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:51.0) Gecko/20100101
Firefox/51.0

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 105685] [UI] String badly translated: Notebookbar → Ribb =?UTF-8?Q?on=20?=( Cinta in Spanish)

2017-02-01 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=105685

Adolfo Jayme  changed:

   What|Removed |Added

   Keywords|needsUXEval |
 Status|UNCONFIRMED |NEEDINFO
 CC||f...@libreoffice.org
 Ever confirmed|0   |1

--- Comment #1 from Adolfo Jayme  ---
I thing you’re mixing up some things:

MUFFIN is out new UI concept which entails several configurable UI
arrangements, comprising the single toolbar modes, the Notebookbar, the Sidebar
and the traditional toolbars; that term is not translated.

“Notebookbar”, in English, is used to refer specifically to our ribbon-like
arrangement, which is implemented with the GtkNotebook widget of the Gtk+
toolkit, hence the name.

It is translated as “cinta” in Spanish because that is what it is in essence,
even though our implementation differs from others in several fundamental ways.
The word was chosen because it is the most representative one for users that
migrate from Microsoft Office or other office suites that use it. The “ribbon”
is, of course, not a UI paradigm invented by Microsoft, but they popularized it
as one part of their UI redesign of Office 2007 and named it so.

If you can give me a replacement that is:

- Short
- Understandable
- Representative of the thing it refers to

… I’ll change it.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 105672] UI: On calc, Toolbar Layout - Notebookbar - Contextual groups. Column dropdown doesn' t work.

2017-02-01 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=105672

--- Comment #8 from m.a.riosv  ---
Also with calc, fails:
- format as currency
- conditional format

On write, on a basic test, doesn't work:
- Style (like with calc)
- ~References dropdown.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 105633] Increased CPU usage while hoovering over a drop-down menu with OpenGL enabled

2017-02-01 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=105633

Aron Budea  changed:

   What|Removed |Added

 CC||markus.mohrhard@googlemail.
   ||com
  Component|LibreOffice |graphics stack
 Blocks||93529
   Severity|minor   |normal

--- Comment #4 from Aron Budea  ---
The increase of CPU usage started with the commit referenced below. Since this
commit the usage goes up to ~20% for me (4-core AMD CPU, so about 80% of a
core), while in the previous one it's only ~5-10%. I also get the impression
this commit is connected to the current behavior that first a grey rectangle is
shown in place of the menu, and the content is painted after a short, but
noticeable delay.

The interseting thing is that this is a cleanup commit, and it never seems to
have been backported into 5.0. Quite peculiar, I'd say.
Adding Cc: to Markus Mohrhard, please take a look.

https://cgit.freedesktop.org/libreoffice/core/commit/?id=7eb4c6921850a5a377f6aa42ce4af85b145da01c
author  Markus Mohrhard    
2015-06-04 15:39:48 (GMT)
committer   Markus Mohrhard    
2015-06-17 12:46:26 (GMT)
commit  7eb4c6921850a5a377f6aa42ce4af85b145da01c (patch)

"remove all traces of old device code"


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=93529
[Bug 93529] [META] VCL/OpenGL tracker bug for 5.0+
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 93529] [META] VCL/OpenGL tracker bug for 5.0+

2017-02-01 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=93529

Aron Budea  changed:

   What|Removed |Added

 Depends on||105633


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=105633
[Bug 105633] Increased CPU usage while hoovering over a drop-down menu with
OpenGL enabled
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 105633] Increased CPU usage while hoovering over a drop-down menu with OpenGL enabled

2017-02-01 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=105633

Aron Budea  changed:

   What|Removed |Added

   Keywords|bibisectRequest |bibisected, bisected

--- Comment #3 from Aron Budea  ---
Bibisected with repo bibisect-win32-5.1.

dfe5bc24f6cc175d0021854f2a8042578f291265 is the first bad commit
commit dfe5bc24f6cc175d0021854f2a8042578f291265
Author: Norbert Thiebaud 
Date:   Sat Jul 18 16:35:48 2015 -0700

source sha:7eb4c6921850a5a377f6aa42ce4af85b145da01c

# bad: [05d11632892a322664fb52bac90b2598b7fb7544] source
sha:5616d22b57a9a5e57d545e912e029162a230829b
# good: [c1efd324c6ad448ac9edb030dc9738b9e6899e4d] source
sha:ab465b90f6c6da5595393a0ba73f33a1e71a2b65
git bisect start '05d11632892a322664fb52bac90b2598b7fb7544' 'oldest'
# bad: [97526ab777da7e58ce283c05498262ecdd4d6f7f] source
sha:4ea70f87f7a2b61eda6e5ab1f48debf6fcfadc1f
git bisect bad 97526ab777da7e58ce283c05498262ecdd4d6f7f
# bad: [2202cdaa0eae3f646f1285a0ea45934edeb26e8a] source
sha:a88bf8fd10c42a15e5d6e66da656889c82b4933a
git bisect bad 2202cdaa0eae3f646f1285a0ea45934edeb26e8a
# good: [1d0a95445c203c11beb1aa5eae844cf178ea0984] source
sha:8f324aebfb94c4b2023894121b954ad4f35eb395
git bisect good 1d0a95445c203c11beb1aa5eae844cf178ea0984
# bad: [2ab10dd694f52d975b104db63c74d74affc857cf] source
sha:c92853c93e537b75444ea2852777d73390de1b1a
git bisect bad 2ab10dd694f52d975b104db63c74d74affc857cf
# bad: [131890245b4ecbfbc397a21035817baf2bbe1f6b] source
sha:cd3881d7171b828872db2ed0b3d49b580c3b17d1
git bisect bad 131890245b4ecbfbc397a21035817baf2bbe1f6b
# bad: [59400bc212cf2ceca6dd2fc6280f232888af1612] source
sha:56b1a63e670ed7e8c5cda4c86a23c347ce32a224
git bisect bad 59400bc212cf2ceca6dd2fc6280f232888af1612
# good: [c511e2274cf41d88a087cb2f14cb640d9003265c] source
sha:86bbb304db54befcd3b5b64b112b2a849f9273ae
git bisect good c511e2274cf41d88a087cb2f14cb640d9003265c
# good: [e7f43dae6e35fee73a48d6d66b0420ee22056f36] source
sha:888098ef0d26b80d36e464c14b2f6bb440d30f4e
git bisect good e7f43dae6e35fee73a48d6d66b0420ee22056f36
# good: [9122e1995771bee211cdbfc537c0af44ab78276e] source
sha:55e7aa6022a7d05f79bd9fe6df8a865e3901aecf
git bisect good 9122e1995771bee211cdbfc537c0af44ab78276e
# good: [6078fc2882f050eb85d8f369020553e02c9db6d0] source
sha:5652313e8a1aee00fd973cdcdd0d04071a8abd31
git bisect good 6078fc2882f050eb85d8f369020553e02c9db6d0
# good: [4aff389391796eb918598422708c01f30eb2cc58] source
sha:37ee25a7f4745fe347084a06f889d8c6ef206a41
git bisect good 4aff389391796eb918598422708c01f30eb2cc58
# good: [c457da64a51517aa871887d96c0488db3462eca7] source
sha:72dca3022d3a82b59cf41b410c82fecf63c3c156
git bisect good c457da64a51517aa871887d96c0488db3462eca7
# bad: [dfe5bc24f6cc175d0021854f2a8042578f291265] source
sha:7eb4c6921850a5a377f6aa42ce4af85b145da01c
git bisect bad dfe5bc24f6cc175d0021854f2a8042578f291265
# good: [624bb0f532192c44e632cd8bde80a506e1a121f1] source
sha:f067d7010322505013693a18b68fac6d6a53e61f
git bisect good 624bb0f532192c44e632cd8bde80a506e1a121f1
# first bad commit: [dfe5bc24f6cc175d0021854f2a8042578f291265] source
sha:7eb4c6921850a5a377f6aa42ce4af85b145da01c

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 105683] DSUM function SearchCriteria parameter should allow references to cells

2017-02-01 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=105683

m.a.riosv  changed:

   What|Removed |Added

 CC||miguelangelrv@libreoffice.o
   ||rg

--- Comment #1 from m.a.riosv  ---
It happens with all inner arrays, not only with DSUM.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 105672] UI: On calc, Toolbar Layout - Notebookbar - Contextual groups. Column dropdown doesn' t work.

2017-02-01 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=105672

--- Comment #7 from m.a.riosv  ---
Looks that also the Style button does nothing after selection. While others
like color selection for backgroun or letter color, and border works properly.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-commits] core.git: starmath/inc starmath/source

2017-02-01 Thread Takeshi Abe
 starmath/inc/rect.hxx|6 -
 starmath/source/rect.cxx |  161 +++
 2 files changed, 80 insertions(+), 87 deletions(-)

New commits:
commit d7736283aae4a79aa497bd2196a076ff402e671f
Author: Takeshi Abe 
Date:   Wed Feb 1 22:48:04 2017 +0900

starmath: these functions are local

Change-Id: I7b1c9722e300585603ce54610d7ef20425a4e634
Reviewed-on: https://gerrit.libreoffice.org/33797
Tested-by: Jenkins 
Reviewed-by: Takeshi Abe 

diff --git a/starmath/inc/rect.hxx b/starmath/inc/rect.hxx
index 4270465..2a33bb5 100644
--- a/starmath/inc/rect.hxx
+++ b/starmath/inc/rect.hxx
@@ -29,12 +29,6 @@
 #include "format.hxx"
 
 
-bool SmGetGlyphBoundRect(const OutputDevice ,
- const OUString , Rectangle );
-
-bool SmIsMathAlpha(const OUString );
-
-
 inline long SmFromTo(long nFrom, long nTo, double fRelDist)
 {
 return nFrom + static_cast(fRelDist * (nTo - nFrom));
diff --git a/starmath/source/rect.cxx b/starmath/source/rect.cxx
index aa64894..54ceb6e 100644
--- a/starmath/source/rect.cxx
+++ b/starmath/source/rect.cxx
@@ -31,6 +31,85 @@
 #include 
 #include 
 
+namespace {
+
+bool SmGetGlyphBoundRect(const vcl::RenderContext ,
+ const OUString , Rectangle )
+// basically the same as 'GetTextBoundRect' (in class 'OutputDevice')
+// but with a string as argument.
+{
+// handle special case first
+if (rText.isEmpty())
+{
+rRect.SetEmpty();
+return true;
+}
+
+// get a device where 'OutputDevice::GetTextBoundRect' will be successful
+OutputDevice *pGlyphDev;
+if (rDev.GetOutDevType() != OUTDEV_PRINTER)
+pGlyphDev = const_cast();
+else
+{
+// since we format for the printer (where GetTextBoundRect will fail)
+// we need a virtual device here.
+pGlyphDev = _MOD()->GetDefaultVirtualDev();
+}
+
+const FontMetric  aDevFM (rDev.GetFontMetric());
+
+pGlyphDev->Push(PushFlags::FONT | PushFlags::MAPMODE);
+vcl::Font aFnt(rDev.GetFont());
+aFnt.SetAlignment(ALIGN_TOP);
+
+// use scale factor when calling GetTextBoundRect to counter
+// negative effects from antialiasing which may otherwise result
+// in significant incorrect bounding rectangles for some characters.
+Size aFntSize = aFnt.GetFontSize();
+
+// Workaround to avoid HUGE font sizes and resulting problems
+long nScaleFactor = 1;
+while( aFntSize.Height() > 2000 * nScaleFactor )
+nScaleFactor *= 2;
+
+aFnt.SetFontSize( Size( aFntSize.Width() / nScaleFactor, aFntSize.Height() 
/ nScaleFactor ) );
+pGlyphDev->SetFont(aFnt);
+
+long nTextWidth = rDev.GetTextWidth(rText);
+Point aPoint;
+Rectangle   aResult (aPoint, Size(nTextWidth, rDev.GetTextHeight())),
+aTmp;
+
+bool bSuccess = pGlyphDev->GetTextBoundRect(aTmp, rText);
+OSL_ENSURE( bSuccess, "GetTextBoundRect failed" );
+
+
+if (!aTmp.IsEmpty())
+{
+aResult = Rectangle(aTmp.Left() * nScaleFactor, aTmp.Top() * 
nScaleFactor,
+aTmp.Right() * nScaleFactor, aTmp.Bottom() * 
nScaleFactor);
+if ( != pGlyphDev) /* only when rDev is a printer... */
+{
+long nGDTextWidth  = pGlyphDev->GetTextWidth(rText);
+if (nGDTextWidth != 0  &&
+nTextWidth != nGDTextWidth)
+{
+aResult.Right() *= nTextWidth;
+aResult.Right() /= nGDTextWidth * nScaleFactor;
+}
+}
+}
+
+// move rectangle to match possibly different baselines
+// (because of different devices)
+long nDelta = aDevFM.GetAscent() - pGlyphDev->GetFontMetric().GetAscent() 
* nScaleFactor;
+aResult.Move(0, nDelta);
+
+pGlyphDev->Pop();
+
+rRect = aResult;
+return bSuccess;
+}
 
 bool SmIsMathAlpha(const OUString )
 // true iff symbol (from StarMath Font) should be treated as letter
@@ -62,8 +141,7 @@ bool SmIsMathAlpha(const OUString )
 return aMathAlpha.find(cChar) != aMathAlpha.end();
 }
 
-
-// SmRect members
+}
 
 
 SmRect::SmRect()
@@ -542,83 +620,4 @@ SmRect SmRect::AsGlyphRect() const
 return aRect;
 }
 
-bool SmGetGlyphBoundRect(const vcl::RenderContext ,
- const OUString , Rectangle )
-// basically the same as 'GetTextBoundRect' (in class 'OutputDevice')
-// but with a string as argument.
-{
-// handle special case first
-if (rText.isEmpty())
-{
-rRect.SetEmpty();
-return true;
-}
-
-// get a device where 'OutputDevice::GetTextBoundRect' will be successful
-OutputDevice *pGlyphDev;
-if (rDev.GetOutDevType() != OUTDEV_PRINTER)
-pGlyphDev = const_cast();
-else
-{
-// since we format for the printer (where GetTextBoundRect will fail)
-// we need a virtual device here.
-pGlyphDev = 

[Libreoffice-bugs] [Bug 105678] FILEOPEN PDF Text in imported PDF is misplaced

2017-02-01 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=105678

Xisco Faulí  changed:

   What|Removed |Added

   Keywords||filter:pdf
 Status|UNCONFIRMED |NEW
 CC||xiscofa...@libreoffice.org
Version|5.3.0.2 rc  |Inherited From OOo
 Ever confirmed|0   |1

--- Comment #3 from Xisco Faulí  ---
Reproduced in

Version: 5.0.0.0.alpha1+
Build ID: 0db96caf0fcce09b87621c11b584a6d81cc7df86
Locale: ca-ES (ca_ES.UTF-8)

and

LibreOffice 3.3.0 
OOO330m19 (Build:6)
tag libreoffice-3.3.0.4

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 105667] Crash in: `anonymous namespace'::ScCaptionCreator:: UpdateCaptionPos()

2017-02-01 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=105667

Aron Budea  changed:

   What|Removed |Added

 CC||dennisfrancis...@gmail.com,
   ||er...@redhat.com
   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=94
   ||561

--- Comment #4 from Aron Budea  ---
The first time the crash happens on undo started with the commit referenced
below. Adding Cc: to Dennis Francis (author), also adding Cc: to Eike Rathke
(committer). Please take a look.

https://cgit.freedesktop.org/libreoffice/core/commit/?id=7c0f6b9d0fb8d7d9e54865ccf1047bb8f8148101
author  Dennis Francis  2016-02-12
20:59:12 (GMT)
committer   Eike Rathke   2016-03-08 18:06:09 (GMT)

"tdf#94561 : Create notes drawing objects only once on sheet copy"

Note that before that commit there's already a crash on exit. If it is still
there after this is fixed, that bug has to be bibisected separately.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 105667] Crash in: `anonymous namespace'::ScCaptionCreator:: UpdateCaptionPos()

2017-02-01 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=105667

Aron Budea  changed:

   What|Removed |Added

   Keywords||bisected

--- Comment #3 from Aron Budea  ---
Bibisected with repo bibisect-win32-5.2.

18e8fa47941375b9fcb3b5c41ee4945880cb is the first bad commit
commit 18e8fa47941375b9fcb3b5c41ee4945880cb
Author: Norbert Thiebaud 
Date:   Wed Mar 9 16:33:39 2016 -0800

source sha:7c0f6b9d0fb8d7d9e54865ccf1047bb8f8148101

# bad: [ce3bdd3a861e140979c75eeb56e5e2c7d0dd00cd] source
sha:45701913f642b17aabd67b52de9002cc79cf07ae
# good: [dfc2a983418964c4608f8f7b23d9947cdea7a1d6] source
sha:a420a4346ec21ea561f1321767d6a5eed98df02b
git bisect start 'ce3bdd3a861e140979c75eeb56e5e2c7d0dd00cd'
'dfc2a983418964c4608f8f7b23d9947cdea7a1d6'
# good: [f1fed57552870f0cbe204edd91ecac6bbc163522] source
sha:07d4c443e21cd22545d4516515c50b1c8dd39a9b
git bisect good f1fed57552870f0cbe204edd91ecac6bbc163522
# good: [3ef7113c324c5814e0e89ed63cdf9febdb4f033a] source
sha:b38f58a3f959b5e36813f8c2d88bdb2baf03a1b9
git bisect good 3ef7113c324c5814e0e89ed63cdf9febdb4f033a
# good: [641eb3eed84cbab5636f2aa07e556ce178d03c3f] source
sha:10f048bafa52bc443249bf7abe23ad5c96f98f80
git bisect good 641eb3eed84cbab5636f2aa07e556ce178d03c3f
# bad: [82c187880a973bcdc43b42d5d6f9e2f852fe6f1f] source
sha:6651aca57bae1bef3343f26d1a0fd59d3802c1cd
git bisect bad 82c187880a973bcdc43b42d5d6f9e2f852fe6f1f
# bad: [b9838bb99a273341f38ced4b4c5e3f423ea86324] source
sha:6f6c21ad91d10f160ab904985cfcaefd98102636
git bisect bad b9838bb99a273341f38ced4b4c5e3f423ea86324
# bad: [18e8fa47941375b9fcb3b5c41ee4945880cb] source
sha:7c0f6b9d0fb8d7d9e54865ccf1047bb8f8148101
git bisect bad 18e8fa47941375b9fcb3b5c41ee4945880cb
# first bad commit: [18e8fa47941375b9fcb3b5c41ee4945880cb] source
sha:7c0f6b9d0fb8d7d9e54865ccf1047bb8f8148101

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 105684] LibO 5.3.0.3 Writer crashes using mailing assistant when opening template (5.2.5.1 is ok)

2017-02-01 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=105684

Xisco Faulí  changed:

   What|Removed |Added

   Keywords|bibisectRequest |bibisected, bisected
 CC||noelgran...@gmail.com
Version|5.2.0.0.alpha1  |5.3.0.0.alpha0+

--- Comment #2 from Xisco Faulí  ---
Regression introduced by:

author  Noel Grandin  2016-09-21 12:48:15 (GMT)
committer   Noel Grandin  2016-10-27
06:08:30 (GMT)
commit  eca5ea9f79181d45cd7fbabe2313617d3025818a (patch)
tree10b5837fe04212349825742b38f5a37be9ce7009
parent  bbd44f8f89839b5abb4ec6c7ea195431de5b2f48 (diff)
make the AbstractDialog stuff extend from VclReferenceBase
Because some stuff wants to multiple-inherit from VclAbstractDialog and
OutputDevice-subclasses, and we'd prefer to keep all the lifetime
management through a single smart pointer class (VclPtr)

The change in msgbox.cxx and window.cxx is to workaround a bug in
VS2013 to do with virtual inheritance and delegating constructors.

Adding Cc: to Noel Grandin

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 105672] UI: On calc, Toolbar Layout - Notebookbar - Contextual groups. Column dropdown doesn' t work.

2017-02-01 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=105672

--- Comment #6 from m.a.riosv  ---
You are right, for row shows the selection but does nothing. May mistake by no
test.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 105684] LibO 5.3.0.3 Writer crashes using mailing assistant when opening template (5.2.5.1 is ok)

2017-02-01 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=105684

Xisco Faulí  changed:

   What|Removed |Added

   Priority|medium  |highest
 Status|UNCONFIRMED |NEW
Version|unspecified |5.2.0.0.alpha1
   Keywords||bibisectRequest, regression
   Hardware|x86-64 (AMD64)  |All
 CC||xiscofa...@libreoffice.org
 Ever confirmed|0   |1
   Severity|normal  |critical
 OS|Windows (All)   |All

--- Comment #1 from Xisco Faulí  ---
Confirmed 

Confirmed in

Version: 5.4.0.0.alpha0+
Build ID: fc53cce64400430cdc21f79c959d75fb9a26d13d
CPU Threads: 4; OS Version: Linux 4.8; UI Render: default; VCL: gtk2; 
Locale: ca-ES (ca_ES.UTF-8); Calc: group

and

Version: 5.2.0.0.alpha1+
Build ID: 5b168b3fa568e48e795234dc5fa454bf24c9805e
CPU Threads: 4; OS Version: Linux 4.8; UI Render: default; 
Locale: ca-ES (ca_ES.UTF-8)

but not in

Version: 5.0.0.0.alpha1+
Build ID: 0db96caf0fcce09b87621c11b584a6d81cc7df86
Locale: ca-ES (ca_ES.UTF-8)

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-commits] core.git: Branch 'distro/collabora/cp-5.1' - bin/pack-debug

2017-02-01 Thread Andras Timar
 bin/pack-debug |1 +
 1 file changed, 1 insertion(+)

New commits:
commit 695ea08058f022b7fecb1ac6ddbca13dba16f94d
Author: Andras Timar 
Date:   Thu Feb 2 00:03:05 2017 +0100

fix debug package of KDE integration

Change-Id: I5ce9711a910163b9ae3cd9c15d857f90d0f23ad3

diff --git a/bin/pack-debug b/bin/pack-debug
index 60df442..a1f4124 100755
--- a/bin/pack-debug
+++ b/bin/pack-debug
@@ -247,6 +247,7 @@ do
TARGET_NAME=$INSTALLDIRNAME"$(echo $(basename $i) | awk '
/epm_gid_Module_Optional_Gnome.lst/{print"basis5.1-gnome-integration"}
/epm_gid_Module_Optional_Grfflt.lst/{print"basis5.1-graphicfilter"}
+   /epm_gid_Module_Optional_Kde.lst/{print"basis5.1-kde-integration"}
/epm_gid_Module_Optional_OGLTrans.lst/{print"basis5.1-ogltrans"}

/epm_gid_Module_Optional_PostgresqlSdbc.lst/{print"basis5.1-postgresql-sdbc"}
/epm_gid_Module_Pdfimport.lst/{print"basis5.1-extension-pdf-import"}
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-bugs] [Bug 105663] implement a Sidebar content panel to review a list of grammar and spelling mistakes

2017-02-01 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=105663

--- Comment #5 from Olivier R.  ---
(In reply to Heiko Tietze from comment #4)
> I would look for document related places at the Navigator. That includes
> comments, bookmarks, changes etc., in general everything that is related to
> a certain page. If we put the various functions in extra decks it will
> quickly clutter the sidebar tabs.

Grammar/spelling/typographic errors are like changes, they also need a specific
tab for specific interactions. They can be hundreds mistakes, or even
thousands, like changes.

The Navigator is better fit to list objects that are part of a document.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-ux-advise] [Bug 105663] implement a Sidebar content panel to review a list of grammar and spelling mistakes

2017-02-01 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=105663

--- Comment #5 from Olivier R.  ---
(In reply to Heiko Tietze from comment #4)
> I would look for document related places at the Navigator. That includes
> comments, bookmarks, changes etc., in general everything that is related to
> a certain page. If we put the various functions in extra decks it will
> quickly clutter the sidebar tabs.

Grammar/spelling/typographic errors are like changes, they also need a specific
tab for specific interactions. They can be hundreds mistakes, or even
thousands, like changes.

The Navigator is better fit to list objects that are part of a document.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Libreoffice-ux-advise mailing list
Libreoffice-ux-advise@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise


[Libreoffice-commits] core.git: sw/qa sw/source

2017-02-01 Thread Mike Kaganski
 sw/qa/extras/uiwriter/uiwriter.cxx |   12 +++-
 sw/source/uibase/wrtsh/delete.cxx  |   24 ++--
 2 files changed, 33 insertions(+), 3 deletions(-)

New commits:
commit af42aab836626fdf7b29921dff5d344a8b0e47c6
Author: Mike Kaganski 
Date:   Wed Feb 1 19:40:43 2017 +0300

tdf#105625: Allow Delete/Backspace to delete whole fieldmark

Previously, the fieldmarks couldn't be removed with backspace or
deletee when cursor was right/left to them.

After commits f72b866c9cf4f07fce6744fbf482c4c6488106e2 and
c34fc4520dfee4ca068f249ee0756dacaa7a60cf, deletion worked wrong
(it didn't delete the mark from mark manager; in case of text
field, it removed one field's boundary).

Now single backspace/delete properly removes the whole fieldmark,
replacing it with its contents if applicable.

Change-Id: Id26e6e4e40e274d9fd6f0224f3e2b4fe33c369b7
Reviewed-on: https://gerrit.libreoffice.org/33812
Tested-by: Jenkins 
Reviewed-by: Mike Kaganski 

diff --git a/sw/qa/extras/uiwriter/uiwriter.cxx 
b/sw/qa/extras/uiwriter/uiwriter.cxx
index 309791e..39d678d 100644
--- a/sw/qa/extras/uiwriter/uiwriter.cxx
+++ b/sw/qa/extras/uiwriter/uiwriter.cxx
@@ -4277,7 +4277,9 @@ void SwUiWriterTest::testTdf105625()
 SwWrtShell* pWrtShell = pDoc->GetDocShell()->GetWrtShell();
 uno::Reference 
xComponentContext(comphelper::getProcessComponentContext());
 // Ensure correct initial setting
-comphelper::ConfigurationHelper::writeDirectKey(xComponentContext, 
"org.openoffice.Office.Writer/", "Cursor/Option", "IgnoreProtectedArea", 
css::uno::Any(false), comphelper::EConfigurationModes::Standard);
+comphelper::ConfigurationHelper::writeDirectKey(xComponentContext,
+"org.openoffice.Office.Writer/", "Cursor/Option", 
"IgnoreProtectedArea",
+css::uno::Any(false), comphelper::EConfigurationModes::Standard);
 // We should be able to edit at positions adjacent to fields.
 // Check if the start and the end of the 1st paragraph are not protected
 // (they are adjacent to FORMCHECKBOX)
@@ -4291,6 +4293,14 @@ void SwUiWriterTest::testTdf105625()
 pWrtShell->SttPara();
 pWrtShell->Right(CRSR_SKIP_CHARS, /*bSelect=*/true, 1, 
/*bBasicCall=*/false);
 CPPUNIT_ASSERT_EQUAL(true, pWrtShell->HasReadonlySel());
+// Test deletion of whole field with single backspace
+// Previously it only removed right boundary of FORMTEXT, or failed 
removal at all
+const IDocumentMarkAccess* pMarksAccess = pDoc->getIDocumentMarkAccess();
+sal_Int32 nMarksBefore = pMarksAccess->getAllMarksCount();
+pWrtShell->EndPara();
+pWrtShell->DelLeft();
+sal_Int32 nMarksAfter = pMarksAccess->getAllMarksCount();
+CPPUNIT_ASSERT_EQUAL(nMarksBefore, nMarksAfter + 1);
 }
 
 CPPUNIT_TEST_SUITE_REGISTRATION(SwUiWriterTest);
diff --git a/sw/source/uibase/wrtsh/delete.cxx 
b/sw/source/uibase/wrtsh/delete.cxx
index 1736273..27edcce 100644
--- a/sw/source/uibase/wrtsh/delete.cxx
+++ b/sw/source/uibase/wrtsh/delete.cxx
@@ -209,8 +209,19 @@ long SwWrtShell::DelLeft()
 }
 else
 {
+// If we are just to the right to a fieldmark, then remove it 
completely
+const SwPosition* aCurPos = GetCursor()->GetPoint();
+SwPosition aPrevChar(*aCurPos);
+--aPrevChar.nContent;
+sw::mark::IFieldmark* pFm = 
getIDocumentMarkAccess()->getFieldmarkFor(aPrevChar);
+if (pFm && pFm->GetMarkEnd() == *aCurPos)
+{
+getIDocumentMarkAccess()->deleteMark(pFm);
+return 1;
+}
+
 OpenMark();
-SwCursorShell::Left(1,CRSR_SKIP_CHARS);
+SwCursorShell::Left(1, CRSR_SKIP_CHARS);
 }
 long nRet = Delete();
 if( !nRet && bSwap )
@@ -329,10 +340,19 @@ long SwWrtShell::DelRight()
 // restore cursor
 SwCursorShell::Pop( false );
 }
+
+// If we are just ahead of a fieldmark, then remove it completely
+sw::mark::IFieldmark* pFm = GetCurrentFieldmark();
+if (pFm && pFm->GetMarkStart() == *GetCursor()->GetPoint())
+{
+getIDocumentMarkAccess()->deleteMark(pFm);
+nRet = 1;
+break;
+}
 }
 
 OpenMark();
-SwCursorShell::Right(1,CRSR_SKIP_CELLS);
+SwCursorShell::Right(1, CRSR_SKIP_CELLS);
 nRet = Delete();
 CloseMark( 0 != nRet );
 break;
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-bugs] [Bug 105685] [UI] String badly translated: Notebookbar → Ribb =?UTF-8?Q?on=20?=( Cinta in Spanish)

2017-02-01 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=105685

haevalen...@gmail.com changed:

   What|Removed |Added

   Keywords||needsUXEval

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 105685] New: [UI] String badly translated: Notebookbar → Ribb =?UTF-8?Q?on=20?=( Cinta in Spanish)

2017-02-01 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=105685

Bug ID: 105685
   Summary: [UI] String badly translated: Notebookbar → Ribbon
(Cinta in Spanish)
   Product: LibreOffice
   Version: 5.3.0.2 rc
  Hardware: All
OS: Linux (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Linguistic
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: haevalen...@gmail.com

Description:
In the translation into Spanish (and other languages) the concept "Notebookbar"
is not maintained and replaced by Ribbon.

I have read a lot that Notebookbar is not Ribbon and this confuses a lot to
users like saying that MUFFIN is Ribbon or that Notebookbar is the Ribbon
component of LO, etc.

Actual Results:  
Bad translation

Expected Results:
Good translation


Reproducible: Always

User Profile Reset: No

Additional Info:


User-Agent: Mozilla/5.0 (X11; Fedora; Linux x86_64; rv:51.0) Gecko/20100101
Firefox/51.0

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 105684] New: LibO 5.3.0.3 Writer crashes using mailing assistant when opening template (5.2.5.1 is ok)

2017-02-01 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=105684

Bug ID: 105684
   Summary: LibO 5.3.0.3 Writer crashes using mailing assistant
when opening template (5.2.5.1 is ok)
   Product: LibreOffice
   Version: unspecified
  Hardware: x86-64 (AMD64)
OS: Windows (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Writer
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: r.legal...@ville-auray.fr

Hello,

LibO 5.3.0.3 64-bit (FR) is installed on Win7 64-bit

Start Writer, go to Tools\Mailing Assistant.
Select start from template, browse, select template (modern business letter) =>
crash

Browsing with explorer to directory: C:\Program Files\LibreOffice
5\share\template\common\wizard\letter and double-click on off-modern_l.ott
opens the template without crash.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


Re: What is the best way to pass a flag from a unit test?

2017-02-01 Thread Khaled Hosny
On Wed, Feb 01, 2017 at 10:41:33AM +0100, Miklos Vajna wrote:
> Hi Khaled,
> 
> On Wed, Feb 01, 2017 at 09:38:02AM +0200, Khaled Hosny 
>  wrote:
> > What the best way to detect, inside VCL, that a given CppunitTest is
> > being run and do something conditionally? I basically want to detect if
> > a given class of unit tests is run and disable all font searching and
> > fallback and just use a hard-coded font name so that the tests are not
> > affected by what fonts are available or not on the system (or that the
> > theory).
> 
> At one place vcl code already checks for LO_TESTNAME.
>
> (That may be a better option compared to the one in the comment of
> .)

It seems that LO_TESTNAME name is currently not set on Windows (or that
is my reading of sal/cppunittester/cppunittester.cxx).

I’m rather not sure if we want to do this unconditionally for all tests
or not, but if that is the consensus, I think we can make sure
LO_TESTNAME is set also on Windows (assuming there is no reason not to
do so) and use it.

Regards,
Khaled


signature.asc
Description: PGP signature
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice


[Libreoffice-bugs] [Bug 105683] New: DSUM function SearchCriteria parameter should allow references to cells

2017-02-01 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=105683

Bug ID: 105683
   Summary: DSUM function SearchCriteria parameter should allow
references to cells
   Product: LibreOffice
   Version: 5.3.0.2 rc
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: enhancement
  Priority: medium
 Component: Calc
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: parke.ne...@gmail.com

Description:
Consider the following spreadsheet with 2 columns and 6 rows:

symbol  price
a   10
b   20
a   30
=DSUM ( A1:B4, "price", {"symbol";"a"} )
=DSUM ( A1:B4, "price", {"symbol";A2} )

The SearchCriteria of the first DSUM is hard coded to the value "a", and the
expression evaluates correctly to 40.

The SearchCriteria of the second DSUM refers to the cell A2.  The value of A2
is "a".  However, this expression causes an error: "Err:512".

It would be nice if Calc could correctly evaluate the second DSUM expression.

Aside:  The second DSUM expression does evaluate correctly inside a GoogleDocs
Spreadsheet.

Steps to Reproduce:
Recreate the example spreadsheet in the description.

Actual Results:  
Err:512

Expected Results:
40


Reproducible: Always

User Profile Reset: No

Additional Info:


User-Agent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like
Gecko) Ubuntu Chromium/53.0.2785.143 Chrome/53.0.2785.143 Safari/537.36

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 105663] implement a Sidebar content panel to review a list of grammar and spelling mistakes

2017-02-01 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=105663

--- Comment #4 from Heiko Tietze  ---
(In reply to V Stuart Foote from comment #2)
> Why would Spelling and Grammar modules be interfaced to Navigator deck?

I would look for document related places at the Navigator. That includes
comments, bookmarks, changes etc., in general everything that is related to a
certain page. If we put the various functions in extra decks it will quickly
clutter the sidebar tabs.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-ux-advise] [Bug 105663] implement a Sidebar content panel to review a list of grammar and spelling mistakes

2017-02-01 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=105663

--- Comment #4 from Heiko Tietze  ---
(In reply to V Stuart Foote from comment #2)
> Why would Spelling and Grammar modules be interfaced to Navigator deck?

I would look for document related places at the Navigator. That includes
comments, bookmarks, changes etc., in general everything that is related to a
certain page. If we put the various functions in extra decks it will quickly
clutter the sidebar tabs.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Libreoffice-ux-advise mailing list
Libreoffice-ux-advise@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise


[Libreoffice-bugs] [Bug 105486] horizontal conditional formatting in xlsb file not visible

2017-02-01 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=105486

--- Comment #3 from Stefan Grotz  ---
What does this mean?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-commits] online.git: Changes to 'refs/tags/2.0.3'

2017-02-01 Thread Andras Timar
Tag '2.0.3' created by Andras Timar  at 2017-02-01 
21:33 +

2.0.3

Changes since 2.0.2-3-7:
---
 0 files changed
---
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-commits] online.git: Branch 'distro/collabora/collabora-online-2-0' - loleaflet/po

2017-02-01 Thread Andras Timar
 loleaflet/po/help-ab.po|2 
 loleaflet/po/help-af.po|2 
 loleaflet/po/help-am.po|2 
 loleaflet/po/help-an.po|2 
 loleaflet/po/help-ar.po|2 
 loleaflet/po/help-as.po|2 
 loleaflet/po/help-ast.po   |2 
 loleaflet/po/help-az.po|2 
 loleaflet/po/help-be.po|2 
 loleaflet/po/help-bg.po|2 
 loleaflet/po/help-bn.po|2 
 loleaflet/po/help-bn_IN.po |2 
 loleaflet/po/help-bo.po|2 
 loleaflet/po/help-br.po|2 
 loleaflet/po/help-brx.po   |2 
 loleaflet/po/help-bs.po|2 
 loleaflet/po/help-ca.po|2 
 loleaflet/po/help-cs.po|   94 -
 loleaflet/po/help-cy.po|   54 ---
 loleaflet/po/help-da.po|2 
 loleaflet/po/help-de.po|2 
 loleaflet/po/help-dgo.po   |2 
 loleaflet/po/help-dz.po|2 
 loleaflet/po/help-el.po|2 
 loleaflet/po/help-en_GB.po |2 
 loleaflet/po/help-en_ZA.po |2 
 loleaflet/po/help-eo.po|2 
 loleaflet/po/help-es.po|2 
 loleaflet/po/help-et.po|2 
 loleaflet/po/help-eu.po|2 
 loleaflet/po/help-fa.po|2 
 loleaflet/po/help-fi.po|2 
 loleaflet/po/help-fr.po|2 
 loleaflet/po/help-ga.po|2 
 loleaflet/po/help-gd.po|2 
 loleaflet/po/help-gl.po|2 
 loleaflet/po/help-gu.po|2 
 loleaflet/po/help-gug.po   |2 
 loleaflet/po/help-he.po|2 
 loleaflet/po/help-hi.po|2 
 loleaflet/po/help-hr.po|2 
 loleaflet/po/help-hu.po|2 
 loleaflet/po/help-id.po|2 
 loleaflet/po/help-is.po|2 
 loleaflet/po/help-it.po|2 
 loleaflet/po/help-ja.po|2 
 loleaflet/po/help-jv.po|2 
 loleaflet/po/help-ka.po|2 
 loleaflet/po/help-kk.po|2 
 loleaflet/po/help-kl.po|2 
 loleaflet/po/help-km.po|2 
 loleaflet/po/help-kn.po|2 
 loleaflet/po/help-ko.po|2 
 loleaflet/po/help-kok.po   |2 
 loleaflet/po/help-ks.po|2 
 loleaflet/po/help-ky.po|2 
 loleaflet/po/help-lb.po|2 
 loleaflet/po/help-lo.po|2 
 loleaflet/po/help-lt.po|2 
 loleaflet/po/help-lv.po|   32 --
 loleaflet/po/help-mai.po   |2 
 loleaflet/po/help-mk.po|2 
 loleaflet/po/help-ml.po|2 
 loleaflet/po/help-mn.po|2 
 loleaflet/po/help-mni.po   |2 
 loleaflet/po/help-mr.po|2 
 loleaflet/po/help-my.po|2 
 loleaflet/po/help-nb.po|2 
 loleaflet/po/help-ne.po|2 
 loleaflet/po/help-nl.po|2 
 loleaflet/po/help-nn.po|2 
 loleaflet/po/help-nr.po|2 
 loleaflet/po/help-nso.po   |2 
 loleaflet/po/help-oc.po|2 
 loleaflet/po/help-om.po|2 
 loleaflet/po/help-or.po|2 
 loleaflet/po/help-pa_IN.po |2 
 loleaflet/po/help-pl.po|2 
 loleaflet/po/help-pt.po|   92 -
 loleaflet/po/help-pt_BR.po |2 
 loleaflet/po/help-ro.po|   92 -
 loleaflet/po/help-ru.po|2 
 loleaflet/po/help-rw.po|2 
 loleaflet/po/help-sa_IN.po |2 
 loleaflet/po/help-sah.po   |2 
 loleaflet/po/help-sat.po   |2 
 loleaflet/po/help-sd.po|2 
 loleaflet/po/help-si.po|2 
 loleaflet/po/help-sid.po   |2 
 loleaflet/po/help-sk.po|2 
 loleaflet/po/help-sq.po|2 
 loleaflet/po/help-ss.po|2 
 loleaflet/po/help-st.po|2 
 loleaflet/po/help-sv.po|2 
 loleaflet/po/help-sw_TZ.po |2 
 loleaflet/po/help-ta.po|2 
 loleaflet/po/help-te.po|2 
 loleaflet/po/help-tg.po|2 
 loleaflet/po/help-th.po|2 
 loleaflet/po/help-ti.po|2 
 loleaflet/po/help-tn.po|2 
 loleaflet/po/help-tr.po|2 
 loleaflet/po/help-ts.po|2 
 loleaflet/po/help-tt.po|2 
 loleaflet/po/help-ug.po|2 
 loleaflet/po/help-uk.po|2 
 loleaflet/po/help-ur.po|2 
 loleaflet/po/help-uz.po|2 
 loleaflet/po/help-ve.po|2 
 loleaflet/po/help-vi.po|2 
 loleaflet/po/help-xh.po|2 
 loleaflet/po/help-zh_CN.po |   26 -
 loleaflet/po/help-zh_TW.po |  102 --
 loleaflet/po/help-zu.po|2 
 loleaflet/po/ui-ab.po  |2 
 loleaflet/po/ui-af.po  |2 
 loleaflet/po/ui-am.po  |2 
 loleaflet/po/ui-an.po  |2 
 loleaflet/po/ui-ar.po  |  132 
 loleaflet/po/ui-as.po  |2 
 loleaflet/po/ui-ast.po |2 
 loleaflet/po/ui-az.po  |2 
 loleaflet/po/ui-be.po  |2 
 loleaflet/po/ui-bg.po  |2 
 loleaflet/po/ui-bn.po  |2 
 loleaflet/po/ui-bn_IN.po   |2 
 loleaflet/po/ui-bo.po  |2 
 loleaflet/po/ui-br.po  |2 
 loleaflet/po/ui-brx.po |2 
 loleaflet/po/ui-bs.po  |2 
 loleaflet/po/ui-ca.po  |2 
 loleaflet/po/ui-cs.po  |  715 ++---
 loleaflet/po/ui-cy.po  |2 
 loleaflet/po/ui-da.po  |2 
 loleaflet/po/ui-de.po  |2 
 loleaflet/po/ui-dgo.po |2 
 loleaflet/po/ui-dz.po 

[Libreoffice-bugs] [Bug 103442] Can't build android viewer with recent NDK

2017-02-01 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=103442

--- Comment #5 from mtes...@outlook.com ---
About the recent 5.3 release. I've tried to package 5.3.0.3 for F-Droid, and
got a build error which looks like another bug, without any idea how to work
around it. Can I file an issue for it? Do you think I should avoid packaging
it?

Also, could you make it more transparent which git commits you use for Android
builds? Like giving them special git tags for example, or maintaining a public
document with git commits.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 104927] Text Import - fixed width mode not adjusting csvtablebox for multi-byte fonts

2017-02-01 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=104927

--- Comment #7 from Caolán McNamara  ---
I don't think its anything to do with double byte fonts or encodings, just that
we're assuming that the cjk font width is the same as the western font width

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 86899] [META] Requests for the addition of UNO commands

2017-02-01 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=86899
Bug 86899 depends on bug 102132, which changed state.

Bug 102132 Summary: Contextual UNO command for editing a section
https://bugs.documentfoundation.org/show_bug.cgi?id=102132

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 84837] Make show/hide comments UNO command work in Calc

2017-02-01 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=84837

Gülşah Köse  changed:

   What|Removed |Added

   Assignee|libreoffice-b...@lists.free |gulsah.1...@gmail.com
   |desktop.org |

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 105677] Crash when applying background to a slide.

2017-02-01 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=105677

Michael Stahl  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 CC||mst...@redhat.com
 Resolution|--- |FIXED
   Assignee|libreoffice-b...@lists.free |mst...@redhat.com
   |desktop.org |

--- Comment #5 from Michael Stahl  ---
fixed on master

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 105677] Crash when applying background to a slide.

2017-02-01 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=105677

Commit Notification  changed:

   What|Removed |Added

 Whiteboard||target:5.4.0

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 105677] Crash when applying background to a slide.

2017-02-01 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=105677

--- Comment #4 from Commit Notification 
 ---
Michael Stahl committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=4ec3d8cedebb83700e3254486d6d3a502584c9b1

tdf#105677: sd: fix crash in FuPage::ApplyItemSet

It will be available in 5.4.0.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-commits] core.git: sd/source

2017-02-01 Thread Michael Stahl
 sd/source/ui/func/fupage.cxx |3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

New commits:
commit 4ec3d8cedebb83700e3254486d6d3a502584c9b1
Author: Michael Stahl 
Date:   Wed Feb 1 21:51:09 2017 +0100

tdf#105677: sd: fix crash in FuPage::ApplyItemSet

(regression from f3a90d13056ca23708cc4fd9562c99d0b41a4b6f)

Change-Id: I54e3f06a74b2ac715061b5da54ac4db2b0a1010a

diff --git a/sd/source/ui/func/fupage.cxx b/sd/source/ui/func/fupage.cxx
index 59c7cf2..15682c4 100644
--- a/sd/source/ui/func/fupage.cxx
+++ b/sd/source/ui/func/fupage.cxx
@@ -621,8 +621,7 @@ void FuPage::ApplyItemSet( const SfxItemSet* pArgs )
 if( mpBackgroundObjUndoAction )
 {
 // set merge flag, because a SdUndoGroupAction could have been 
inserted before
-mpDocSh->GetUndoManager()->AddUndoAction( 
mpBackgroundObjUndoAction.get(), true );
-mpBackgroundObjUndoAction = nullptr;
+mpDocSh->GetUndoManager()->AddUndoAction( 
mpBackgroundObjUndoAction.release(), true );
 }
 
 // Objects can not be bigger than ViewSize
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-commits] core.git: download.lst external/jpeg-turbo

2017-02-01 Thread David Tardon
 download.lst |4 ++--
 external/jpeg-turbo/jpeg-turbo.build.patch.1 |8 
 external/jpeg-turbo/jpeg-turbo.win_build.patch.1 |4 ++--
 3 files changed, 8 insertions(+), 8 deletions(-)

New commits:
commit 750ca7dec9491e924905b402a662aab6ecc00387
Author: David Tardon 
Date:   Wed Feb 1 10:22:11 2017 +0100

upload libjpeg-turbo 1.5.1

Change-Id: Ie34f030abad75317b8bd813386e6bbf9439a3d1c
Reviewed-on: https://gerrit.libreoffice.org/33810
Tested-by: Jenkins 
Reviewed-by: David Tardon 

diff --git a/download.lst b/download.lst
index e04462d..bf2ac36 100644
--- a/download.lst
+++ b/download.lst
@@ -77,8 +77,8 @@ export JFREEREPORT_LIBXML_TARBALL := 
ace6ab49184e329db254e454a010f56d-libxml-1.1
 export JFREEREPORT_SAC_TARBALL := 
39bb3fcea1514f1369fcfc87542390fd-sacjava-1.3.zip
 export JPEG_MD5SUM := 3353992aecaee1805ef4109aadd433e7
 export JPEG_TARBALL := jpegsrc.v9a.tar.gz
-export JPEG_TURBO_MD5SUM := 86b0d5f7507c2e6c21c00219162c3c44
-export JPEG_TURBO_TARBALL := libjpeg-turbo-1.4.2.tar.gz
+export JPEG_TURBO_MD5SUM := 55deb139b0cac3c8200b75d485fc13f3
+export JPEG_TURBO_TARBALL := libjpeg-turbo-1.5.1.tar.gz
 export LANGTAGREG_MD5SUM := 8a037dc60b16bf8c5fe871b33390a4a2
 export LANGTAGREG_TARBALL := language-subtag-registry-2016-07-19.tar.bz2
 export LANGUAGETOOL_TARBALL := 
b63e6340a02ff1cacfeadb2c42286161-JLanguageTool-1.7.0.tar.bz2
diff --git a/external/jpeg-turbo/jpeg-turbo.build.patch.1 
b/external/jpeg-turbo/jpeg-turbo.build.patch.1
index 85cd7f6..4d01ad4 100644
--- a/external/jpeg-turbo/jpeg-turbo.build.patch.1
+++ b/external/jpeg-turbo/jpeg-turbo.build.patch.1
@@ -24,10 +24,10 @@ diff -ru jpeg-turbo.orig/Makefile.in jpeg-turbo/Makefile.in
$(srcdir)/jconfigint.h.in $(srcdir)/libjpeg.map.in \
 @@ -622,7 +622,7 @@
jidctflt.c jidctfst.c jidctint.c jidctred.c jquant1.c \
-   jquant2.c jutils.c jmemmgr.c jmemnobs.c $(am__append_3) \
-   $(am__append_4) $(am__append_5) $(am__append_10)
--SUBDIRS = java $(am__append_9) md5
-+SUBDIRS = java $(am__append_9)
+   jquant2.c jutils.c jmemmgr.c jmemnobs.c $(am__append_4) \
+   $(am__append_5) $(am__append_6) $(am__append_11)
+-SUBDIRS = java $(am__append_10) md5
++SUBDIRS = java $(am__append_10)
  @WITH_TURBOJPEG_TRUE@libturbojpeg_la_SOURCES = $(libjpeg_la_SOURCES) \
  @WITH_TURBOJPEG_TRUE@ turbojpeg.c turbojpeg.h transupp.c \
  @WITH_TURBOJPEG_TRUE@ transupp.h jdatadst-tj.c jdatasrc-tj.c \
diff --git a/external/jpeg-turbo/jpeg-turbo.win_build.patch.1 
b/external/jpeg-turbo/jpeg-turbo.win_build.patch.1
index b5dabaa..00b6427 100644
--- a/external/jpeg-turbo/jpeg-turbo.win_build.patch.1
+++ b/external/jpeg-turbo/jpeg-turbo.win_build.patch.1
@@ -32,8 +32,8 @@ diff -ru jpeg-turbo.orig/configure jpeg-turbo/configure
 +++ jpeg-turbo/jconfig.h.in2016-11-02 22:45:01.90540 +0100
 @@ -71,3 +71,21 @@
  
- /* The size of `size_t', as computed by sizeof. */
- #undef SIZEOF_SIZE_T
+ /* Define to `unsigned int' if  does not define. */
+ #undef size_t
 +
 +#ifdef _MSC_VER
 +
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-commits] core.git: download.lst external/cairo

2017-02-01 Thread David Tardon
 download.lst|3 ++-
 external/cairo/ExternalPackage_cairo.mk |2 +-
 2 files changed, 3 insertions(+), 2 deletions(-)

New commits:
commit 0e36d7ec6020c380c00955b2c13f279690184685
Author: David Tardon 
Date:   Wed Feb 1 12:35:39 2017 +0100

upload cairo 1.14.8

Change-Id: I3f602b881477653f51025fce72d22a0499e7f077
Reviewed-on: https://gerrit.libreoffice.org/33806
Tested-by: Jenkins 
Reviewed-by: David Tardon 

diff --git a/download.lst b/download.lst
index ac429f6..e04462d 100644
--- a/download.lst
+++ b/download.lst
@@ -12,7 +12,8 @@ export BREAKPAD_TARBALL := breakpad.zip
 export BREAKPAD_MD5SUM := 415ce291aa6f2ee1d5db7b62bf62ade8
 export BSH_TARBALL := beeca87be45ec87d241ddd0e1bad80c1-bsh-2.0b6-src.zip
 export BZIP2_TARBALL := 00b516f4704d4a7cb50a1d97e6e8e15b-bzip2-1.0.6.tar.gz
-export CAIRO_TARBALL := 23a0b2f0235431d35238df1d3a517fdb-cairo-1.14.6.tar.xz
+export CAIRO_MD5SUM := 4ef0db2eacb271c74f8a3fd87822aa98
+export CAIRO_TARBALL := cairo-1.14.8.tar.xz
 export CDR_MD5SUM := e369f30b5b861ee0fc4f9e6cbad701fe
 export CDR_TARBALL := libcdr-0.1.3.tar.bz2
 export CLUCENE_TARBALL := 
48d647fbd8ef8889e5a7f422c1bfda94-clucene-core-2.3.3.4.tar.gz
diff --git a/external/cairo/ExternalPackage_cairo.mk 
b/external/cairo/ExternalPackage_cairo.mk
index e9cd1e8..dc76224 100644
--- a/external/cairo/ExternalPackage_cairo.mk
+++ b/external/cairo/ExternalPackage_cairo.mk
@@ -14,7 +14,7 @@ $(eval $(call 
gb_ExternalPackage_use_external_project,cairo,cairo))
 ifneq ($(DISABLE_DYNLOADING),TRUE)
 ifneq ($(OS),ANDROID)
 
-$(eval $(call 
gb_ExternalPackage_add_file,cairo,$(LIBO_LIB_FOLDER)/libcairo.so.2,src/.libs/libcairo.so.2.11400.6))
+$(eval $(call 
gb_ExternalPackage_add_file,cairo,$(LIBO_LIB_FOLDER)/libcairo.so.2,src/.libs/libcairo.so.2.11400.8))
 
 endif
 endif
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-commits] core.git: download.lst external/openssl

2017-02-01 Thread David Tardon
 download.lst  |4 ++--
 external/openssl/openssllnx.patch |2 +-
 2 files changed, 3 insertions(+), 3 deletions(-)

New commits:
commit a97371bf4d123ece75f3f9aeef8f3d4abfc6ad9c
Author: David Tardon 
Date:   Wed Feb 1 12:47:04 2017 +0100

upload openssl 1.0.2k

Change-Id: I26d49db0207b3f4f64aa9698da4cf3567d195834
Reviewed-on: https://gerrit.libreoffice.org/33800
Tested-by: Jenkins 
Reviewed-by: David Tardon 

diff --git a/download.lst b/download.lst
index e46dfcd..ac429f6 100644
--- a/download.lst
+++ b/download.lst
@@ -121,8 +121,8 @@ export OPENCOLLADA_MD5SUM := 
4ca8a6ef0afeefc864e9ef21b9f14bd6
 export OPENCOLLADA_TARBALL := OpenCOLLADA-master-6509aa13af.tar.bz2
 export OPENLDAP_MD5SUM := 693ac26de86231f8dcae2b4e9d768e51
 export OPENLDAP_TARBALL := openldap-2.4.44.tgz
-export OPENSSL_MD5SUM := 9392e65072ce4b614c1392eefc1f23d0
-export OPENSSL_TARBALL := openssl-1.0.2h.tar.gz
+export OPENSSL_MD5SUM := f965fc0bf01bf882b31314b61391ae65
+export OPENSSL_TARBALL := openssl-1.0.2k.tar.gz
 export ORCUS_MD5SUM := d0ad3a2fcf7008e5b33604bab33df3ad
 export ORCUS_TARBALL := liborcus-0.12.1.tar.gz
 export OWNCLOUD_ANDROID_LIB_MD5SUM := 593f0aa47bf2efc0efda2d28fae063b2
diff --git a/external/openssl/openssllnx.patch 
b/external/openssl/openssllnx.patch
index de19807..224df8f 100644
--- a/external/openssl/openssllnx.patch
+++ b/external/openssl/openssllnx.patch
@@ -19,5 +19,5 @@
 -  AS='$(CC)' ASFLAG='$(CFLAG) -c' \
 +  AS='$(CC)' ASFLAG='$(CFLAG) -c -Wa,--noexecstack'   \
AR='$(AR)' NM='$(NM)' RANLIB='$(RANLIB)'\
+   RC='$(RC)'  \
CROSS_COMPILE='$(CROSS_COMPILE)'\
-   PERL='$(PERL)' ENGDIRS='$(ENGDIRS)' \
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-commits] core.git: download.lst external/lcms2

2017-02-01 Thread David Tardon
 download.lst  |4 
 external/lcms2/ExternalPackage_lcms2.mk   |2 
 external/lcms2/UnpackedTarball_lcms2.mk   |4 
 external/lcms2/lcms2-2.4-windows.patch|   32 
 external/lcms2/lcms2-config-guess.patch.0 | 1566 --
 external/lcms2/lcms2-vc2013-project.patch |  490 -
 external/lcms2/lcms2.patch|   20 
 external/lcms2/ubsan.patch.0  |   22 
 8 files changed, 7 insertions(+), 2133 deletions(-)

New commits:
commit 0ada594b5c4cd8490efac86029674187356c56c8
Author: David Tardon 
Date:   Wed Feb 1 10:20:43 2017 +0100

upload lcms2 2.8

Change-Id: I8a3b138c051d3cddf25855a635262311669bdddc
Reviewed-on: https://gerrit.libreoffice.org/33798
Tested-by: Jenkins 
Reviewed-by: David Tardon 

diff --git a/download.lst b/download.lst
index c313a52..e46dfcd 100644
--- a/download.lst
+++ b/download.lst
@@ -81,8 +81,8 @@ export JPEG_TURBO_TARBALL := libjpeg-turbo-1.4.2.tar.gz
 export LANGTAGREG_MD5SUM := 8a037dc60b16bf8c5fe871b33390a4a2
 export LANGTAGREG_TARBALL := language-subtag-registry-2016-07-19.tar.bz2
 export LANGUAGETOOL_TARBALL := 
b63e6340a02ff1cacfeadb2c42286161-JLanguageTool-1.7.0.tar.bz2
-export LCMS2_MD5SUM := f4c08d38ceade4a664ebff7228910a33
-export LCMS2_TARBALL := lcms2-2.6.tar.gz
+export LCMS2_MD5SUM := 87a5913f1a52464190bb655ad230539c
+export LCMS2_TARBALL := lcms2-2.8.tar.gz
 export LIBATOMIC_OPS_MD5SUM := c0b86562d5aa40761a87134f83e6adcf
 export LIBATOMIC_OPS_TARBALL := libatomic_ops-7_2d.zip
 export LIBEOT_MD5SUM := aa24f5dd2a2992f4a116aa72af817548
diff --git a/external/lcms2/ExternalPackage_lcms2.mk 
b/external/lcms2/ExternalPackage_lcms2.mk
index 07f6ddb..4efd696 100644
--- a/external/lcms2/ExternalPackage_lcms2.mk
+++ b/external/lcms2/ExternalPackage_lcms2.mk
@@ -21,7 +21,7 @@ else ifeq ($(COM),MSC)
 $(eval $(call 
gb_ExternalPackage_add_file,lcms2,$(LIBO_LIB_FOLDER)/lcms2.dll,bin/lcms2.dll))
 endif # $(COM)
 else  # $(OS) != WNT/MACOSX
-$(eval $(call 
gb_ExternalPackage_add_file,lcms2,$(LIBO_LIB_FOLDER)/liblcms2.so.2,src/.libs/liblcms2.so.2.0.6))
+$(eval $(call 
gb_ExternalPackage_add_file,lcms2,$(LIBO_LIB_FOLDER)/liblcms2.so.2,src/.libs/liblcms2.so.2.0.8))
 endif # $(OS)
 endif # $(DISABLE_DYNLOADING)
 
diff --git a/external/lcms2/UnpackedTarball_lcms2.mk 
b/external/lcms2/UnpackedTarball_lcms2.mk
index db22934..c72797e 100644
--- a/external/lcms2/UnpackedTarball_lcms2.mk
+++ b/external/lcms2/UnpackedTarball_lcms2.mk
@@ -13,12 +13,8 @@ $(eval $(call 
gb_UnpackedTarball_set_tarball,lcms2,$(LCMS2_TARBALL)))
 $(eval $(call gb_UnpackedTarball_set_patchlevel,lcms2,3))
 
 $(eval $(call gb_UnpackedTarball_add_patches,lcms2,\
-   external/lcms2/lcms2.patch \
external/lcms2/lcms2-2.4-windows.patch \
external/lcms2/lcms2-msvc-disable-sse2.patch.1 \
-   external/lcms2/lcms2-vc2013-project.patch \
-   external/lcms2/lcms2-config-guess.patch.0 \
-   external/lcms2/ubsan.patch.0 \
external/lcms2/0001-Added-an-extra-check-to-MLU-bounds.patch.1 \
 ))
 
diff --git a/external/lcms2/lcms2-2.4-windows.patch 
b/external/lcms2/lcms2-2.4-windows.patch
index f1c681a..749a812 100644
--- a/external/lcms2/lcms2-2.4-windows.patch
+++ b/external/lcms2/lcms2-2.4-windows.patch
@@ -1,34 +1,10 @@
 misc/lcms2-2.4/Projects/VC2010/lcms2_DLL/lcms2_DLL.vcproj  2012-09-10 
18:01:51.0 +0200
-+++ misc/build/lcms2-2.4/Projects/VC2010/lcms2_DLL/lcms2_DLL.vcproj
2012-10-05 22:35:01.607191700 +0200
-@@ -205,6 +205,10 @@
-   >
-   
-   
-+  
-+  
-   
 misc/lcms2-2.4/Projects/VC2010/lcms2_static/lcms2_static.vcproj
2012-09-10 18:01:51.0 +0200
-+++ misc/build/lcms2-2.4/Projects/VC2010/lcms2_static/lcms2_static.vcproj  
2012-10-05 22:35:28.168963200 +0200
-@@ -175,6 +175,10 @@
-   >
-   
-   
-+  
-+  
-   
+TODO: Is this still needed?
+
 --- misc/lcms2-2.4/include/lcms2.h 2011-12-15 16:45:47.0 +0100
 +++ misc/build/lcms2-2.4/include/lcms2.h   2012-03-17 22:53:28.731585981 
+0100
 @@ -192,6 +192,15 @@ typedef int  cmsBool;
- # endif
- #endif
+ #endif  // CMS_USE_BIG_ENDIAN
+ 
  
 +// LibreOffice always builds this as DLL and with the stdcall calling
 +// convention, so make this usable from outside without having to
diff --git a/external/lcms2/lcms2-config-guess.patch.0 
b/external/lcms2/lcms2-config-guess.patch.0
deleted file mode 100644
index 546fc48..000
--- a/external/lcms2/lcms2-config-guess.patch.0
+++ /dev/null
@@ -1,1566 +0,0 @@
 config.guess
-+++ config.guess
-@@ -1,14 +1,12 @@
- #! /bin/sh
- # Attempt to guess a canonical system name.
--#   Copyright (C) 1992, 1993, 1994, 1995, 

Re: loplugin:useuniqueptr and a crash

2017-02-01 Thread Zolnai Tamás
2017-02-01 18:56 GMT+00:00 Zolnai Tamás :
> Hi guys,
>
> I tried to revert one loplugin:useuniqueptr related change because it
> makes Impress to crash:
> https://bugs.documentfoundation.org/show_bug.cgi?id=105677
>
> But as I pushed a patch to gerrit I see that it makes build failing:
> https://gerrit.libreoffice.org/#/c/33805/
> http://ci.libreoffice.org/job/lo_gerrit/6397/Config=linux_clang_dbgutil_64/console
>
> So what can I do here?

Was a useless question actually.. Noel, I cc-d you to the related bug.

Best Regards,
Tamás
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice


[Libreoffice-commits] core.git: 2 commits - odk/CustomTarget_build-examples.mk

2017-02-01 Thread Michael Stahl
 odk/CustomTarget_build-examples.mk |4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

New commits:
commit e95765027e183728cf830ee0c120df29ce04c0d3
Author: Michael Stahl 
Date:   Wed Feb 1 21:20:57 2017 +0100

odk: don't run make with LD_LIBRARY_PATH set

In a build with -fsanitize=address, this fails with:

Change-Id: If8581363a395af78bbbe00dd656290aea53af330
make: symbol lookup error: instdir/program/libfreebl3.so: undefined symbol: 
__asan_option_detect_stack_use_after_return

diff --git a/odk/CustomTarget_build-examples.mk 
b/odk/CustomTarget_build-examples.mk
index b9c5c53..ea4eb3b 100644
--- a/odk/CustomTarget_build-examples.mk
+++ b/odk/CustomTarget_build-examples.mk
@@ -91,6 +91,7 @@ $(call gb_CustomTarget_get_target,odk/build-examples): \
 $(call gb_CustomTarget_get_workdir,odk/build-examples)/setsdkenv
$(call gb_Output_announce,$(subst $(WORKDIR)/,,$@),$(true),CHK,1)
(. $< \
+   && unset LD_LIBRARY_PATH \
 && export \
 UserInstallation=$(call gb_Helper_make_url,$(call 
gb_CustomTarget_get_workdir,odk/build-examples)/user) \
 $(foreach my_dir,$(my_example_dirs), \
commit 616e19fc25848e5b35d9a252cd20b7c16262824d
Author: Michael Stahl 
Date:   Wed Feb 1 21:14:02 2017 +0100

odk: recreate setsdkenv if config changes

Change-Id: I4a34f03fdab4626bdbf9b254986b0953ecfdffa7

diff --git a/odk/CustomTarget_build-examples.mk 
b/odk/CustomTarget_build-examples.mk
index 27f0158..b9c5c53 100644
--- a/odk/CustomTarget_build-examples.mk
+++ b/odk/CustomTarget_build-examples.mk
@@ -102,7 +102,8 @@ $(call gb_CustomTarget_get_target,odk/build-examples): \
 && exit $$RET)
 
 $(call gb_CustomTarget_get_workdir,odk/build-examples)/setsdkenv: \
-$(SRCDIR)/odk/config/setsdkenv_unix.sh.in | \
+$(SRCDIR)/odk/config/setsdkenv_unix.sh.in \
+   $(BUILDDIR)/config_$(gb_Side).mk | \
 $(call gb_CustomTarget_get_workdir,odk/build-examples)/.dir
$(call gb_Output_announce,$(subst $(WORKDIR)/,,$@),$(true),SED,1)
sed -e 's!@OO_SDK_NAME@!sdk!' \
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-bugs] [Bug 103355] Notebookbar doesnt disappear during slide show / presentation mode

2017-02-01 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=103355

--- Comment #4 from Ljiljan  ---
Can confirm this bug on Ubuntu 16.04 with LibreOffice 5.3.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 105682] Insert -> New slide not working in Notebookbar

2017-02-01 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=105682

Buovjaga  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEW
 Ever confirmed|0   |1

--- Comment #1 from Buovjaga  ---
Repro.

Arch Linux 64-bit, KDE Plasma 5
Version: 5.4.0.0.alpha0+
Build ID: b12823aa81003e80372bd89db79bd6ba8e032a95
CPU Threads: 8; OS Version: Linux 4.9; UI Render: default; VCL: kde4; 
Locale: fi-FI (fi_FI.UTF-8); Calc: group
Built on February 1st 2016

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 102062] [META] Notebookbar: bugs and enhancements

2017-02-01 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=102062

Ljiljan  changed:

   What|Removed |Added

 Depends on||105682


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=105682
[Bug 105682] Insert -> New slide not working in Notebookbar
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 105682] Insert -> New slide not working in Notebookbar

2017-02-01 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=105682

Ljiljan  changed:

   What|Removed |Added

 Blocks||102062


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=102062
[Bug 102062] [META] Notebookbar: bugs and enhancements
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 105682] New: Insert -> New slide not working in Notebookbar

2017-02-01 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=105682

Bug ID: 105682
   Summary: Insert -> New slide not working in Notebookbar
   Product: LibreOffice
   Version: 5.3.0.2 rc
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Impress
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: lili...@gmail.com

Insert -> New Slide in Notebookbar is not producing any action (not creating
new slides) both on Insert -> Slide as well as on Home -> New slide.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 105677] Crash when applying background to a slide.

2017-02-01 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=105677

Julien Nabet  changed:

   What|Removed |Added

 CC||serval2...@yahoo.fr

--- Comment #3 from Julien Nabet  ---
Tamás/Noel: are we're forced to get back to simple pointer in this case? If
yes, how to detect similar cases where we should get back to simple pointer
without waiting for new bugtrackers?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 68459] EDITING: frames are jumping and impossible to position correctly with arrow keys

2017-02-01 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=68459

--- Comment #16 from mango wodzak  ---
I'm very sad to see that this bug is still not fixed in version 5.3… Surely it
is more important to fix bugs in a program before adding new features? This
issue has been around since the dawn of libreoffice/openoffice and is still
present, and still very annoying. It has been well over three years since I
first reported it too.. It would be much appreciated if some kind soul could at
least acknowledge that this bug is being worked on, or low prioritized on a
long list of bugs that need fixing?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 96532] Export of page with transparent PNG inserts gray line on transparency border

2017-02-01 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=96532

Andreas B.  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEW
 Ever confirmed|0   |1

--- Comment #8 from Andreas B.  ---
I can confirm it, but I'm not sure if it's a LibreOffice Bug.

If you open the generated PDF with the Firefox Integrated PDF Viewer, it
displays the gray Border.
With Evince the Gray border is also visible.
With chrome also.

Because of this: The bug is confirmed.

BUT:
If I save the image from PDF to a .png file from Evince (which displays the
border) the image doesn't contain the border.

If I open the PDF with GIMP, there is no Gray Border.


I changed the status to NEW, as it's confirmed.

It may would be helpful also to attach a good example, e.g. from PDFCreator.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 96532] Export of page with transparent PNG inserts gray line on transparency border

2017-02-01 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=96532

Andreas B.  changed:

   What|Removed |Added

 OS|Windows (All)   |All

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 105531] Color scale conditional formatting doesn' t copy as expected

2017-02-01 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=105531

Buovjaga  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEW
 CC||todven...@suomi24.fi
Version|5.3.0.1 rc  |3.6.7.2 release
 Blocks||87351
 Ever confirmed|0   |1
 OS|Windows (All)   |All
   Severity|normal  |minor

--- Comment #3 from Buovjaga  ---
Reproduced with the file. Removed all the pasted formats in Manage and pasted
again.

It's pasted a bit differently in 3.6: D7 is referring to C4..

Arch Linux 64-bit, KDE Plasma 5
Version: 5.4.0.0.alpha0+
Build ID: b12823aa81003e80372bd89db79bd6ba8e032a95
CPU Threads: 8; OS Version: Linux 4.9; UI Render: default; VCL: kde4; 
Locale: fi-FI (fi_FI.UTF-8); Calc: group
Built on February 1st 2016

Arch Linux 64-bit
Version 3.6.7.2 (Build ID: e183d5b)


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=87351
[Bug 87351] [META] Conditional formatting bugs and enhancements
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 87351] [META] Conditional formatting bugs and enhancements

2017-02-01 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=87351

Buovjaga  changed:

   What|Removed |Added

 Depends on||105531


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=105531
[Bug 105531] Color scale conditional formatting doesn't copy as expected
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 105681] New: 5.3.0.3 installer hangs when custom option to install to d: drive selected

2017-02-01 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=105681

Bug ID: 105681
   Summary: 5.3.0.3 installer hangs when custom option to install
to d: drive selected
   Product: LibreOffice
   Version: 5.3.0.2 rc
  Hardware: x86-64 (AMD64)
OS: Windows (All)
Status: UNCONFIRMED
  Severity: minor
  Priority: medium
 Component: Installation
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: john.kiss...@gmail.com

Description:
Installer kept hanging if a custom install to go to the d: drive is selected.
After a few attempts & a reboot, I gave up and let it install to the primary
(c:) drive which went as normal. It did remove most of the files from the
previous installation to the d: drive as part of this.

Steps to Reproduce:
1. Run the installer
2. Select custom install
3. Change the installation folder to the d: drive

Actual Results:  
Hang!

Expected Results:
Should install to selected drive like previous version.


Reproducible: Always

User Profile Reset: No

Additional Info:


User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36
(KHTML, like Gecko) Chrome/56.0.2924.76 Safari/537.36

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 105680] Strange caret behavior

2017-02-01 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=105680

--- Comment #1 from eric.cout...@gmail.com ---
Created attachment 130821
  --> https://bugs.documentfoundation.org/attachment.cgi?id=130821=edit
Specific file (xlsx) to reproduce the bug

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 105680] New: Strange caret behavior

2017-02-01 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=105680

Bug ID: 105680
   Summary: Strange caret behavior
   Product: LibreOffice
   Version: 5.2.5.1 release
  Hardware: x86-64 (AMD64)
OS: Linux (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Calc
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: eric.cout...@gmail.com

Description:
While direct typing text in specific cells, caret is shown at the top of the
sheet and not in the current cell.
For example, in the enclosed file, type text in O14 cell.

Steps to Reproduce:
1.Download the file
2.Type text in O14, O27, O41, O54
3.Caret is shown at the top of the sheet while direct typing text

Actual Results:  
1.Download the file
2.Type text in O14, O27, O41, O54
3.Caret is shown at the top of the sheet while direct typing text

Expected Results:
1.Download the file
2.Type text in O14, O27, O41, O54
3.Caret is shown at the top of the sheet while direct typing text


Reproducible: Sometimes

User Profile Reset: No

Additional Info:


User-Agent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like
Gecko) Chrome/56.0.2924.76 Safari/537.36

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-commits] core.git: Branch 'libreoffice-5-2' - filter/source

2017-02-01 Thread Caolán McNamara
 filter/source/graphicfilter/ieps/ieps.cxx |   82 +++---
 1 file changed, 54 insertions(+), 28 deletions(-)

New commits:
commit 9176d089b6a65649f136e20ec260311535d26948
Author: Caolán McNamara 
Date:   Sun Jan 29 20:54:56 2017 +

Resolves: ofz#488 check remaining size while parsing

Change-Id: Ibb2b6c59a159f9fafa6a065be438b59a6d2d3f21
Reviewed-on: https://gerrit.libreoffice.org/33666
Reviewed-by: Michael Stahl 
Tested-by: Michael Stahl 

diff --git a/filter/source/graphicfilter/ieps/ieps.cxx 
b/filter/source/graphicfilter/ieps/ieps.cxx
index a62c15a..0de5327 100644
--- a/filter/source/graphicfilter/ieps/ieps.cxx
+++ b/filter/source/graphicfilter/ieps/ieps.cxx
@@ -36,6 +36,7 @@
 #include 
 #include 
 #include 
+#include 
 
 class FilterConfigItem;
 
@@ -459,7 +460,6 @@ void MakePreview(sal_uInt8* pBuf, sal_uInt32 nBytesRead,
 pVDev->SetFillColor();
 
 aFont.SetColor( COL_LIGHTRED );
-//  aFont.SetSize( Size( 0, 32 ) );
 
 pVDev->Push( PushFlags::FONT );
 pVDev->SetFont( aFont );
@@ -470,51 +470,77 @@ void MakePreview(sal_uInt8* pBuf, sal_uInt32 nBytesRead,
 OUString aString;
 int nLen;
 sal_uInt8* pDest = ImplSearchEntry( pBuf, reinterpret_cast("%%Title:"), nBytesRead - 32, 8 );
-if ( pDest )
+sal_uInt32 nRemainingBytes = pDest ? (nBytesRead - (pDest - pBuf)) : 0;
+if (nRemainingBytes >= 8)
 {
 pDest += 8;
-if ( *pDest == ' ' )
-pDest++;
-nLen = ImplGetLen( pDest, 32 );
-sal_uInt8 aOldValue(pDest[ nLen ]); pDest[ nLen ] = 0;
-if ( strcmp( reinterpret_cast(pDest), "none" ) != 0 )
+nRemainingBytes -= 8;
+if (nRemainingBytes && *pDest == ' ')
 {
-aString += " Title:" + OUString::createFromAscii( 
reinterpret_cast(pDest) ) + "\n";
+++pDest;
+--nRemainingBytes;
+}
+nLen = ImplGetLen(pDest, std::min(nRemainingBytes, 32));
+if (static_cast(nLen) < nRemainingBytes)
+{
+sal_uInt8 aOldValue(pDest[ nLen ]); pDest[ nLen ] = 0;
+if ( strcmp( reinterpret_cast(pDest), "none" ) != 0 )
+{
+aString += " Title:" + OUString::createFromAscii( 
reinterpret_cast(pDest) ) + "\n";
+}
+pDest[ nLen ] = aOldValue;
 }
-pDest[ nLen ] = aOldValue;
 }
 pDest = ImplSearchEntry( pBuf, reinterpret_cast("%%Creator:"), nBytesRead - 32, 10 );
-if ( pDest )
+nRemainingBytes = pDest ? (nBytesRead - (pDest - pBuf)) : 0;
+if (nRemainingBytes >= 10)
 {
 pDest += 10;
-if ( *pDest == ' ' )
-pDest++;
-nLen = ImplGetLen( pDest, 32 );
-sal_uInt8 aOldValue(pDest[ nLen ]); pDest[ nLen ] = 0;
-aString += " Creator:" + OUString::createFromAscii( 
reinterpret_cast(pDest) ) + "\n";
-pDest[ nLen ] = aOldValue;
+nRemainingBytes -= 10;
+if (nRemainingBytes && *pDest == ' ')
+{
+++pDest;
+--nRemainingBytes;
+}
+nLen = ImplGetLen(pDest, std::min(nRemainingBytes, 32));
+if (static_cast(nLen) < nRemainingBytes)
+{
+sal_uInt8 aOldValue(pDest[nLen]); pDest[nLen] = 0;
+aString += " Creator:" + OUString::createFromAscii( 
reinterpret_cast(pDest) ) + "\n";
+pDest[nLen] = aOldValue;
+}
 }
 pDest = ImplSearchEntry( pBuf, reinterpret_cast("%%CreationDate:"), nBytesRead - 32, 15 );
-if ( pDest )
+nRemainingBytes = pDest ? (nBytesRead - (pDest - pBuf)) : 0;
+if (nRemainingBytes >= 15)
 {
 pDest += 15;
-if ( *pDest == ' ' )
-pDest++;
-nLen = ImplGetLen( pDest, 32 );
-sal_uInt8 aOldValue(pDest[ nLen ]); pDest[ nLen ] = 0;
-if ( strcmp( reinterpret_cast(pDest), "none" ) != 0 )
+nRemainingBytes -= 15;
+if (nRemainingBytes && *pDest == ' ')
+{
+++pDest;
+--nRemainingBytes;
+}
+nLen = ImplGetLen(pDest, std::min(nRemainingBytes, 32));
+if (static_cast(nLen) < nRemainingBytes)
 {
-aString += " CreationDate:" + OUString::createFromAscii( 
reinterpret_cast(pDest) ) + "\n";
+sal_uInt8 aOldValue(pDest[ nLen ]); pDest[ nLen ] = 0;
+if ( strcmp( reinterpret_cast(pDest), "none" ) != 0 )
+{
+aString += " CreationDate:" + OUString::createFromAscii( 
reinterpret_cast(pDest) ) + "\n";
+}
+pDest[ nLen ] = aOldValue;
 }
-pDest[ nLen ] = aOldValue;
 }
 pDest = ImplSearchEntry( pBuf, reinterpret_cast("%%LanguageLevel:"), nBytesRead - 4, 16 );
-if ( pDest )
+nRemainingBytes = pDest ? (nBytesRead - (pDest - pBuf)) : 0;
+if (nRemainingBytes >= 16)
 {
 pDest 

[Libreoffice-commits] core.git: Branch 'libreoffice-5-3' - include/sfx2 sfx2/source

2017-02-01 Thread Caolán McNamara
 include/sfx2/sidebar/SidebarController.hxx |7 ++-
 sfx2/source/sidebar/SidebarController.cxx  |   14 ++
 2 files changed, 20 insertions(+), 1 deletion(-)

New commits:
commit 9f031721d7b281ef11c93da78d68f7899816094c
Author: Caolán McNamara 
Date:   Tue Jan 31 14:29:18 2017 +

Resolves: tdf#104884 print preview replaces the frame controller

so the sidebar is listening to the old controller which has been 
disposed[1] so
when print preview exits and yet another controller replaces the print 
preview
one then the sidebar still doesn't listen to the current one.

framework broadcasts COMPONENT_DETACHING/COMPONENT_REATTACHED around these
changes, so if we listen to them we can keep attached to whatever is the
current component

[1] note that ContextChangeEventMultipler doesn't inform clients that the
controller has been disposed, this remains unchanged here

Reviewed-on: https://gerrit.libreoffice.org/33758
Reviewed-by: Caolán McNamara 
Tested-by: Caolán McNamara 
(cherry picked from commit 3e27ba70ce212642026874ba73021930a06cdbbd)

Change-Id: I141509d4a262307afd7dcfc3d77de6cdd6dbfa5f
Reviewed-on: https://gerrit.libreoffice.org/33760
Reviewed-by: Michael Stahl 
Tested-by: Michael Stahl 

diff --git a/include/sfx2/sidebar/SidebarController.hxx 
b/include/sfx2/sidebar/SidebarController.hxx
index d4cdd57..ca71500 100644
--- a/include/sfx2/sidebar/SidebarController.hxx
+++ b/include/sfx2/sidebar/SidebarController.hxx
@@ -48,7 +48,8 @@ namespace
 css::ui::XContextChangeEventListener,
 css::beans::XPropertyChangeListener,
 css::ui::XSidebar,
-css::frame::XStatusListener
+css::frame::XStatusListener,
+css::frame::XFrameActionListener
 > SidebarControllerInterfaceBase;
 }
 
@@ -105,6 +106,10 @@ public:
 virtual void SAL_CALL statusChanged (const css::frame::FeatureStateEvent& 
rEvent)
 throw(css::uno::RuntimeException, std::exception) override;
 
+// frame::XFrameActionListener
+virtual void SAL_CALL frameAction (const css::frame::FrameActionEvent& 
rEvent)
+throw (com::sun::star::uno::RuntimeException, std::exception) override;
+
 // ui::XSidebar
 virtual void SAL_CALL requestLayout()
 throw(css::uno::RuntimeException, std::exception) override;
diff --git a/sfx2/source/sidebar/SidebarController.cxx 
b/sfx2/source/sidebar/SidebarController.cxx
index 98112eb..58117bd 100644
--- a/sfx2/source/sidebar/SidebarController.cxx
+++ b/sfx2/source/sidebar/SidebarController.cxx
@@ -118,6 +118,7 @@ SidebarController::SidebarController (
 mpResourceManager = o3tl::make_unique();
 
 registerSidebarForFrame(this, mxFrame->getController());
+rxFrame->addFrameActionListener(this);
 // Listen for window events.
 mpParentWindow->AddEventListener(LINK(this, SidebarController, 
WindowEventHandler));
 
@@ -184,6 +185,7 @@ void 
SidebarController::unregisterSidebarForFrame(SidebarController* pController
 
 void SidebarController::disposeDecks()
 {
+SolarMutexGuard aSolarMutexGuard;
 mpCurrentDeck.clear();
 maFocusManager.Clear();
 mpResourceManager->disposeDecks();
@@ -228,6 +230,7 @@ void SAL_CALL SidebarController::disposing()
 if (!xController.is())
 xController = mxCurrentController;
 
+mxFrame->removeFrameActionListener(this);
 unregisterSidebarForFrame(this, xController);
 
 if (mxReadOnlyModeDispatch.is())
@@ -1311,6 +1314,17 @@ void SidebarController::FadeIn()
 mpSplitWindow->FadeIn();
 }
 
+void SidebarController::frameAction(const css::frame::FrameActionEvent& rEvent)
+throw (com::sun::star::uno::RuntimeException, std::exception)
+{
+if (rEvent.Frame == mxFrame)
+{
+if (rEvent.Action == css::frame::FrameAction_COMPONENT_DETACHING)
+unregisterSidebarForFrame(this, mxFrame->getController());
+else if (rEvent.Action == css::frame::FrameAction_COMPONENT_REATTACHED)
+registerSidebarForFrame(this, mxFrame->getController());
+}
+}
 
 } } // end of namespace sfx2::sidebar
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-bugs] [Bug 105679] New: PDF Filter: does not respect last value of ExportOnlyNotesPages setting

2017-02-01 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=105679

Bug ID: 105679
   Summary: PDF Filter: does not respect last value of
ExportOnlyNotesPages setting
   Product: LibreOffice
   Version: 5.2.0.0.alpha1
  Hardware: x86-64 (AMD64)
OS: Linux (All)
Status: UNCONFIRMED
  Severity: minor
  Priority: medium
 Component: filters and storage
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: ztra...@everlaw.com

Description:
When exporting with the pdf filter, the most recent settings should be honored
(e.g. when exporting on the command line).  However, the "ExportOnlyNotesPage"
setting is not.

Steps to Reproduce:
1. Export a presentation to PDF using the GUI, selecting "Export Notes Pages"
and "Export Only Notes Pages". Your export should have only notes pages.
2. Run a command-line export of that same spreadsheet to pdf (`soffice
--convert-to pdf in.pptx --outdir /tmp`).

Actual Results:  
The command-line exported pdf will have slide pages and note pages (as if
ExportOnlyNotesPages is false).

Expected Results:
The command-line exported pdf should have only notes pages (matching the most
recent GUI output).


Reproducible: Always

User Profile Reset: No

Additional Info:
I think this is due to a simple omission at
LibreOffice/core/filter/source/pdf/pdffilter.cxx:74:

"""
/* we don't get FilterData if we are exporting directly
   to pdf, but we have to use the last user settings (especially for the
CompressMode) */
if ( !aFilterData.getLength() )
{
FilterConfigItem aCfgItem( "Office.Common/Filter/PDF/Export/" );
...
aCfgItem.ReadBool(  "ExportNotesPages", false );
aCfgItem.ReadBool(  "UseTransitionEffects", true );
...
}
"""

A simple fix is to add `aCfgItem.ReadBool(  "ExportOnlyNotesPages", false );`. 
More comprehensive/better
would be to re-write the configuration code so that the expected settings (and
their types and default values)
are defined in a single place in such a way as to make
creating/updating/merging a "configuration" possible without
enumerating all the necessary fields.


User-Agent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like
Gecko) Chrome/55.0.2883.87 Safari/537.36

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 105672] UI: On calc, Toolbar Layout - Notebookbar - Contextual groups. Column dropdown doesn' t work.

2017-02-01 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=105672

--- Comment #5 from Julien Nabet  ---
(In reply to m.a.riosv from comment #4)
> Created attachment 130820 [details]
> Screnshoot row button
> 
> I'm not sure if I understand what you write about Row. But row button works
> for me.

Yes, items of row menu appear but they don't work for me.
I mean "insert rows", doesn't insert row here.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 105672] UI: On calc, Toolbar Layout - Notebookbar - Contextual groups. Column dropdown doesn' t work.

2017-02-01 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=105672

--- Comment #4 from m.a.riosv  ---
Created attachment 130820
  --> https://bugs.documentfoundation.org/attachment.cgi?id=130820=edit
Screnshoot row button

I'm not sure if I understand what you write about Row. But row button works for
me.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 61242] Customise comments background color in Writer

2017-02-01 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=61242

--- Comment #9 from Stan Armstrong  ---
Please add me to the list of those who will be notified when the enhancement is
added. It is distressing in a Linux program not to be able to change the
colours associated with a given author.

Perhaps if I keep adding different author names, I will find colours I can live
with.

Meanwhile, could someone tell us what the algorithm is that LibreOffice uses to
"automatically" assign colours.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 101638] [FILEOPEN, DOC] Bullets in a graph are too large

2017-02-01 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=101638

--- Comment #9 from Johnny_M  ---
Thanks for the fix!

Could someone please cherry-pick this for LO 5.3 and 5.2 in Gerrit? It errors
out with "wrong author" in if I try.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 101626] Hyphen missing in pdf export

2017-02-01 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=101626

Johnny_M  changed:

   What|Removed |Added

 CC||kla...@partyheld.de
 Whiteboard||target:5.4.0

--- Comment #6 from Johnny_M  ---
Fixed for LO 5.4 (current master) in https://gerrit.libreoffice.org/33707 which
isn't shown here for some reason. Thanks!

Could someone please cherry-pick this for LO 5.3 and 5.2 in Gerrit? It errors
out with "wrong author" in if I try.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 105142] FIREBIRD 3 - create default collation or character set on database creation

2017-02-01 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=105142

--- Comment #4 from Julien Nabet  ---
For 5.3 backport, I cherry-picked the Tamas' commit, waiting for review here:
https://gerrit.libreoffice.org/#/c/33809/1

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


  1   2   3   4   >