[Libreoffice-bugs] [Bug 109158] slower loading of a huge AutoCorrect replacement table

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=109158

Xisco Faulí  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=15
   ||4063

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 109158] slower loading of a huge AutoCorrect replacement table

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=109158

tommy27  changed:

   What|Removed |Added

 Status|VERIFIED|CLOSED

--- Comment #70 from tommy27  ---
issue finally gone in 7.1.x branch
see bug 128078

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 109158] slower loading of a huge AutoCorrect replacement table

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=109158

Shantanu  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=13
   ||3874
 CC||shantanu@gmail.com

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 109158] slower loading of a huge AutoCorrect replacement table

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=109158

V Stuart Foote  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=13
   ||3700

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 109158] slower loading of a huge AutoCorrect replacement table

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=109158

--- Comment #69 from Xisco Faulí  ---
*** Bug 133700 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 109158] slower loading of a huge AutoCorrect replacement table

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=109158

Buovjaga  changed:

   What|Removed |Added

 Resolution|MOVED   |FIXED
 Status|RESOLVED|VERIFIED

--- Comment #68 from Buovjaga  ---
(In reply to tommy27 from comment #67)
> thanks Stuart for creating the new ticket.
> 
> however I would not label the current as FIXED since the slowness is still
> there... latest commits just reverted a worsening of the original bug.
> 
> let's label this as MOVED and continue discussion in the new report

tommy27: I know this is your pet bug, but let's be realistic and keep the
status as fixed. I hope you can finally acknowledge that this is not a case of
worsening. The good "performance" of old came with corrupted actual results.

I think I will change the new report to reflect this characteristic.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 109158] slower loading of a huge AutoCorrect replacement table

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=109158

tommy27  changed:

   What|Removed |Added

 Resolution|FIXED   |MOVED

--- Comment #67 from tommy27  ---
thanks Stuart for creating the new ticket.

however I would not label the current as FIXED since the slowness is still
there... latest commits just reverted a worsening of the original bug.

let's label this as MOVED and continue discussion in the new report

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 109158] slower loading of a huge AutoCorrect replacement table

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=109158

--- Comment #66 from V Stuart Foote  ---
(In reply to Buovjaga from comment #65)
> (In reply to V Stuart Foote from comment #63)
> > Reopening... but might be better to move to a new issue?
> 
> New issue is better, if anyone cares to report. As specific as possible.

Done -> bug 128078

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 109158] slower loading of a huge AutoCorrect replacement table

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=109158

V Stuart Foote  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=12
   ||8078

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 109158] slower loading of a huge AutoCorrect replacement table

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=109158

Buovjaga  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 Status|REOPENED|RESOLVED

--- Comment #65 from Buovjaga  ---
(In reply to V Stuart Foote from comment #63)
> Reopening... but might be better to move to a new issue?

New issue is better, if anyone cares to report. As specific as possible.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 109158] slower loading of a huge AutoCorrect replacement table

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=109158

--- Comment #64 from Julien Nabet  ---
Created attachment 154391
  --> https://bugs.documentfoundation.org/attachment.cgi?id=154391=edit
perf flamegraph

Here's an update with master sources updated today
(203865e128ddea66041bb1597333dfb04ec81186)

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 109158] slower loading of a huge AutoCorrect replacement table

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=109158

Julien Nabet  changed:

   What|Removed |Added

 Attachment #154269|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 109158] slower loading of a huge AutoCorrect replacement table

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=109158

V Stuart Foote  changed:

   What|Removed |Added

 Status|RESOLVED|REOPENED
 Resolution|FIXED   |---

--- Comment #63 from V Stuart Foote  ---
(In reply to Xisco Faulí from comment #53)
> (In reply to Xisco Faulí from comment #52)
> > @tommy27, @V Stuart Foote, Could you please check again this issue with a
> > master build containing noel's commits ?
> 
> Any update?
> Meanwhile, I'm going to backport both commits to libreoffice-6-3, you know,
> deliver early and often...

Hmm, compared loading (so no language change) of attachment 134684 (which I
renamed for my en-US locale).

Comparing master from 2019-09-14 to latest 2019-09-23 with all Noel's patches.

empty cache user/autocorr
Open Writer
Tools -> AutoCorrect -> AutoCorrect Options...

2019-09-14 :: 20s openings (10 repetitions)
0d0e8533afe565564835e6d51500e64066fd565b

2019-09-23 :: 21s openings (10 repetitions)
e1b51d4588b4b39592bb94dd5bb90de5e04d061e

So we are actually slower for this obscenely large autocorrect table... but
probably more correct ;-)

And with an installed 6.3.1.2 release build :: 16s openings (10 repetitions)
b79626edf0065ac373bd1df5c28bd630b4424273

So backport of Noel's optimizations is maybe not a good idea, yet?

And for comparison 5.3.7.2 release build :: 5s openings (10 repetitions)
6b8ed514a9f8b44d37a1b96673cbbdd077e24059

All testing on same Windows 10 Home 64-bit en-US (1903) laptop system with
Samsung SSD.

Reopening... but might be better to move to a new issue?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 109158] slower loading of a huge AutoCorrect replacement table

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=109158

--- Comment #62 from Julien Nabet  ---

(In reply to Buovjaga from comment #61)
> ...
> 
> I will try another approach:
> 
> a) do things incorrectly, making problems appear everywhere, but having the
> performance be fantastic
> b) do things correctly, which has a performance penalty that shows with huge
> amounts of data
> 
> Implementing b) is not causing a regression, because a) was "just an
> illusion" to begin with. To get to nice performance, a fascinating new
> adventure is needed. It has to be seen as an enhancement request that
> requires completely new strategies of attack.

Completely agree, there was some UI problems, the revert has been made about it
knowing that in the specific "expert config dialog" (the UI part which was
originally fixed), there would be no more perf pb since the loading has been
modified. That's what means:
"The expert dialog got fixed by not populating it with all options on load..."

Now we got indeed perf problem but on a different part of UI.

Perhaps these 2 ways may be investigated:
1) Optimize GetTextWidth
2) load differently autocorrect dialog (perhaps by taking example to expert
config)

(I'm not enough expert to work on this)

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 109158] slower loading of a huge AutoCorrect replacement table

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=109158

--- Comment #61 from Buovjaga  ---
(In reply to tommy27 from comment #60)
> sorry but I've never fully understood what Caolan meant (that's because I
> have no proper code knowledge).
> 
> even if that was not a "traditional regression" it seems if was that committ
> that caused the performance drop from 5.3.x to 6.0.x 
> 
> I hope another commit will restore the nice performance of 5.3.x as well.

I will try another approach:

a) do things incorrectly, making problems appear everywhere, but having the
performance be fantastic
b) do things correctly, which has a performance penalty that shows with huge
amounts of data

Implementing b) is not causing a regression, because a) was "just an illusion"
to begin with. To get to nice performance, a fascinating new adventure is
needed. It has to be seen as an enhancement request that requires completely
new strategies of attack.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 109158] slower loading of a huge AutoCorrect replacement table

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=109158

--- Comment #60 from tommy27  ---
(In reply to Buovjaga from comment #58)
> (In reply to tommy27 from comment #55)
> > however the performance is still worse than 5.3.7 where it was quite fast.
> > 
> > as mentioned several time, the regression happened in 6.0.x development
> > (comment 11) and a bibisect regarding the offending committ is available in
> > comment 13 but it seems it has never been addressed.
> 
> It is a question of being exact with text widths. Using approximate width
> caused problems. So like Caolán said in comment 12, it cannot be called a
> regression in the traditional sense.


sorry but I've never fully understood what Caolan meant (that's because I have
no proper code knowledge).

even if that was not a "traditional regression" it seems if was that committ
that caused the performance drop from 5.3.x to 6.0.x 

then another, even worse, performance regression happened between 6.1.x and
6.2.x but Noel just fixed it.

I hope another commit will restore the nice performance of 5.3.x as well.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 109158] slower loading of a huge AutoCorrect replacement table

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=109158

--- Comment #59 from Commit Notification 
 ---
Noel Grandin committed a patch related to this issue.
It has been pushed to "libreoffice-6-3":

https://git.libreoffice.org/core/commit/4ea561aa56208c63938fbc4dbf1e1e509de456ec

tdf#109158 improve load time of autocorrect XML file

It will be available in 6.3.3.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 109158] slower loading of a huge AutoCorrect replacement table

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=109158

--- Comment #58 from Buovjaga  ---
(In reply to tommy27 from comment #55)
> however the performance is still worse than 5.3.7 where it was quite fast.
> 
> as mentioned several time, the regression happened in 6.0.x development
> (comment 11) and a bibisect regarding the offending committ is available in
> comment 13 but it seems it has never been addressed.

It is a question of being exact with text widths. Using approximate width
caused problems. So like Caolán said in comment 12, it cannot be called a
regression in the traditional sense.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 109158] slower loading of a huge AutoCorrect replacement table

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=109158

--- Comment #57 from Xisco Faulí  ---
(In reply to tommy27 from comment #55)

> do you think a new clean report should be opened or should we continue over
> this one.

+1 from me. this one already has more than 50 comments...

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 109158] slower loading of a huge AutoCorrect replacement table

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=109158

--- Comment #56 from Julien Nabet  ---
I'll retrieve another Flamegraph with master sources updated today so I got all
the Noel's patches.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 109158] slower loading of a huge AutoCorrect replacement table

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=109158

--- Comment #55 from tommy27  ---
(In reply to tommy27 from comment #45)
> performance declined from 6.1.x to 6.2.x
> 
> a huge autocorrect table that loads in 14 seconds under LibO 6.1.3
> now takes 32 seconds to load in LibO 6.2.7
> 
> awful performance drop...
> 
> I'm stuck with 6.1.x because of this issue


retested under 6.4.0.0.alpha0+ (x64)
Build ID: 30c5aead03b10b4dc0497c1d799dbfb903ee140b
CPU threads: 8; OS: Windows 6.1; UI render: GL; VCL: win; 
TinderBox: Win-x86_64@42, Branch:master, Time: 2019-09-23_00:31:42
Locale: it-IT (it_IT); UI-Language: en-US
Calc: threaded

now the 6.4.x performance is the same as in 6.1.3...
both take 14 seconds to load which is much better than the awful 32 seconds of
6.2.7

however the performance is still worse than 5.3.7 where it was quite fast.

as mentioned several time, the regression happened in 6.0.x development
(comment 11) and a bibisect regarding the offending committ is available in
comment 13 but it seems it has never been addressed.

to Noel's last commits (thank you very much) fixed the awful 6.2.x regression
but we are still dealing with an inferior performance when compared to the old
5.3.x branch

do you think a new clean report should be opened or should we continue over
this one.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 109158] slower loading of a huge AutoCorrect replacement table

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=109158

Commit Notification  changed:

   What|Removed |Added

 Whiteboard|target:6.3.0 target:6.4.0   |target:6.3.0 target:6.4.0
   |target:6.3.0.1  |target:6.3.0.1 target:6.3.3

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 109158] slower loading of a huge AutoCorrect replacement table

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=109158

--- Comment #54 from Commit Notification 
 ---
Noel Grandin committed a patch related to this issue.
It has been pushed to "libreoffice-6-3":

https://git.libreoffice.org/core/commit/36ea8194ae86a9072b2d8a1154ac5e8c83764fce

tdf#109158 improve sorting when loading large autocorrect file

It will be available in 6.3.3.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 109158] slower loading of a huge AutoCorrect replacement table

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=109158

--- Comment #53 from Xisco Faulí  ---
(In reply to Xisco Faulí from comment #52)
> @tommy27, @V Stuart Foote, Could you please check again this issue with a
> master build containing noel's commits ?

Any update?
Meanwhile, I'm going to backport both commits to libreoffice-6-3, you know,
deliver early and often...

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 109158] slower loading of a huge AutoCorrect replacement table

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=109158

--- Comment #52 from Xisco Faulí  ---
@tommy27, @V Stuart Foote, Could you please check again this issue with a
master build containing noel's commits ?

in

Version: 6.4.0.0.alpha0+
Build ID: ea4f3099d6e0cf30d80caa8b2121c7a358f80fdd
CPU threads: 4; OS: Linux 4.15; UI render: default; VCL: gtk3; 
Locale: ca-ES (ca_ES.UTF-8); UI-Language: en-US
Calc: threaded

it takes ~4 seconds for me.
I would like to backport the commits to 6.3 if you confirm the improvements on
your side.
Thanks in advance

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 109158] slower loading of a huge AutoCorrect replacement table

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=109158

Noel Grandin  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 CC|noelgran...@gmail.com   |
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 109158] slower loading of a huge AutoCorrect replacement table

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=109158

--- Comment #51 from Commit Notification 
 ---
Noel Grandin committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/ea4f3099d6e0cf30d80caa8b2121c7a358f80fdd

tdf#109158 improve load time of autocorrect XML file

It will be available in 6.4.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 109158] slower loading of a huge AutoCorrect replacement table

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=109158

--- Comment #50 from Commit Notification 
 ---
Noel Grandin committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/77dec7588c9141b03f8ec0139eb96c298b26f261

tdf#109158 improve sorting when loading large autocorrect file

It will be available in 6.4.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 109158] slower loading of a huge AutoCorrect replacement table

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=109158

Xisco Faulí  changed:

   What|Removed |Added

 CC||noelgran...@gmail.com

--- Comment #49 from Xisco Faulí  ---
(In reply to Julien Nabet from comment #48)
> Created attachment 154269 [details]
> perf flamegraph
> 
> Here's a Flamegraph retrieved on pc Debian x86-64 with master sources
> updated today + enable-symbols.

Thanks a lot!

@Noel, I thought you might be interested in this issue...

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 109158] slower loading of a huge AutoCorrect replacement table

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=109158

--- Comment #48 from Julien Nabet  ---
Created attachment 154269
  --> https://bugs.documentfoundation.org/attachment.cgi?id=154269=edit
perf flamegraph

Here's a Flamegraph retrieved on pc Debian x86-64 with master sources updated
today + enable-symbols.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 109158] slower loading of a huge AutoCorrect replacement table

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=109158

--- Comment #47 from Julien Nabet  ---
(In reply to Xisco Faulí from comment #46)
> @Julien Nabet, any chance you could get a perf chart here ?

No pb, I'll do this after my day time job.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 109158] slower loading of a huge AutoCorrect replacement table

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=109158

Xisco Faulí  changed:

   What|Removed |Added

 CC||serval2...@yahoo.fr

--- Comment #46 from Xisco Faulí  ---
@Julien Nabet, any chance you could get a perf chart here ?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 109158] slower loading of a huge AutoCorrect replacement table

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=109158

--- Comment #45 from tommy27  ---
performance declined from 6.1.x to 6.2.x

a huge autocorrect table that loads in 14 seconds under LibO 6.1.3
now takes 32 seconds to load in LibO 6.2.7

awful performance drop...

I'm stuck with 6.1.x because of this issue

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 109158] slower loading of a huge AutoCorrect replacement table

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=109158

tommy27  changed:

   What|Removed |Added

 Status|REOPENED|NEW

--- Comment #44 from tommy27  ---
tested with  6.4.0.0.alpha0+ (x64)
Build ID: 9a2fbfa3cc1da8bd9388d5b4c780e86f0dccc791
CPU threads: 8; OS: Windows 6.1; UI render: GL; VCL: win; 
TinderBox: Win-x86_64@42, Branch:master, Time: 2019-06-25_23:12:21
Locale: it-IT (it_IT); UI-Language: en-US
Calc: threaded

same findings as reported by Stuart.
no change in overall speed loading that huge replacement table.

looking at the committ by Noel it seems his fix only addressed slowness while
switching to another language in an already opened replacement table, this is
good of course but this was not the issue that I originally reported.

the current bug report is about slower loading of huge replacament table
compared to 5.3.7 where it was quite fast.

as mentioned several time, the regression happened in 6.0.x development
(comment 11) and a bibisect regarding the offending committ is available in
comment 13.

so I set back status to NEW since there are 2 independent confirmations about
persistence of original issue

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 109158] slower loading of a huge AutoCorrect replacement table

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=109158

V Stuart Foote  changed:

   What|Removed |Added

 Status|RESOLVED|REOPENED
 Resolution|FIXED   |---

--- Comment #43 from V Stuart Foote  ---
Hate to pester, but with today's master with Noel's latest--still have
painfully slow load of attachment 134684 (I just rename it to acor_en-US.dat to
load in master).

No change from prior build with same delay to load--about 16 sec from opening
the Tools -> AutoCorrect -> AutoCorrect Options dialog.

Same system with 5.3.7 dialog takes just 5 sec to load ready for use.

-ref-=
https://cgit.freedesktop.org/libreoffice/core/log/?qt=range=cf5a3cb687a502e7f71cefb5f7001a73925bee56..4808ae1c73597726c89936f5b9cb3f11c9a4a7bf

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 109158] slower loading of a huge AutoCorrect replacement table

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=109158

--- Comment #42 from Commit Notification 
 ---
Noel Grandin committed a patch related to this issue.
It has been pushed to "libreoffice-6-3":

https://git.libreoffice.org/core/+/3a2d31cdd684b42b0921917dc7a8c27d6f6bb25a%5E%21

tdf#109158 slow AutoCorrect table, speedup switching away from language

It will be available in 6.3.0.1.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 109158] slower loading of a huge AutoCorrect replacement table

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=109158

Commit Notification  changed:

   What|Removed |Added

 Whiteboard|target:6.3.0 target:6.4.0   |target:6.3.0 target:6.4.0
   ||target:6.3.0.1

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 109158] slower loading of a huge AutoCorrect replacement table

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=109158

Noel Grandin  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 Status|NEW |RESOLVED

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 109158] slower loading of a huge AutoCorrect replacement table

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=109158

--- Comment #41 from Commit Notification 
 ---
Noel Grandin committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/+/ab7652aabf9c1c91980d47c9d1be30b24313f142%5E%21

tdf#109158 slow AutoCorrect table, speedup switching away from language

It will be available in 6.4.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 109158] slower loading of a huge AutoCorrect replacement table

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=109158

Commit Notification  changed:

   What|Removed |Added

 Whiteboard|target:6.3.0|target:6.3.0 target:6.4.0

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 109158] slower loading of a huge AutoCorrect replacement table

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=109158

--- Comment #40 from tommy27  ---
the issue doesn't affect the 5.4.x branch and appeared during the developement
of the 6.0.x branch (see comment 11).

a bibisect was performed long time ago (see comment 13) but it seems that
information was not used to fix the problem that still affects current 6.3.x
master where the loading speed of the replacement table is still too much slow
compared to 5.4.x

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 109158] slower loading of a huge AutoCorrect replacement table

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=109158

V Stuart Foote  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=12
   ||5490

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 109158] slower loading of a huge AutoCorrect replacement table

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=109158

V Stuart Foote  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=12
   ||5348

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 109158] slower loading of a huge AutoCorrect replacement table

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=109158

--- Comment #39 from V Stuart Foote  ---
Hmm, issue remains (compare a 5.3.7/5.4.0 load of attachment 134684 to current
master) a large (in both count & width) correction table that was quickly
loaded at one point is has become painfully slow to load for
review/modification.


=--ref-=
Testing Windows 10 Home 64-bit en-US (1809) with current master
Version: 6.3.0.0.alpha1+
Build ID: 959e8ae7ea33ce94dd80ee8ea172b6db64593873
CPU threads: 4; OS: Windows 10.0; UI render: GL; VCL: win; 
Locale: en-US (en_US); UI-Language: en-US
Calc: threaded

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 109158] slower loading of a huge AutoCorrect replacement table

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=109158

--- Comment #38 from Commit Notification 
 ---
Caolán McNamara committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/+/86618248683fa4048192d15356c7e6b430e8dbb9%5E%21

tdf#109158 short-circuit text width measuring with fixed width columns

It will be available in 6.3.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 109158] slower loading of a huge AutoCorrect replacement table

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=109158

Commit Notification  changed:

   What|Removed |Added

 Whiteboard||target:6.3.0

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 109158] slower loading of a huge AutoCorrect replacement table

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=109158

--- Comment #37 from Commit Notification 
 ---
Caolán McNamara committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/+/50588a1583e3cc5dc647a35889e50478c7bfd033%5E%21

Related: tdf#109158 GtkTreeStore append performance is poor

It will be available in 6.3.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 109158] slower loading of a huge AutoCorrect replacement table

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=109158

tommy27  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=12
   ||5241

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 109158] slower loading of a huge AutoCorrect replacement table

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=109158

Telesto  changed:

   What|Removed |Added

   Priority|highest |medium

--- Comment #36 from Telesto  ---
(In reply to tommy27 from comment #35)
> there's an important performance regression since the 6.2.x branch.
> 
> trying to load large autocorrect replacement tables  such as the one in
> attachment 134684 [details] causes freezing in LibO 6.2.0 and 6.2.3 final
> releases
> 
> that list can be loaded with no problems in latest 6.1.5 release.
> 
> this means that the autocorrect replacement table load option is completely
> broken in 6.2.x so I have to raise the importance of this bug report.
> 
> this bug block upgrading from 6.1.x to 6.2.x to all users with large
> autocorrect lists.

Created a separate report (bug 125241). It's a different bug IMHO; appears to
be related to this, but newer. Moving status back to medium.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 109158] slower loading of a huge AutoCorrect replacement table

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=109158

tommy27  changed:

   What|Removed |Added

   Priority|medium  |highest

--- Comment #35 from tommy27  ---
there's an important performance regression since the 6.2.x branch.

trying to load large autocorrect replacement tables  such as the one in
attachment 134684 causes freezing in LibO 6.2.0 and 6.2.3 final releases

that list can be loaded with no problems in latest 6.1.5 release.

this means that the autocorrect replacement table load option is completely
broken in 6.2.x so I have to raise the importance of this bug report.

this bug block upgrading from 6.1.x to 6.2.x to all users with large
autocorrect lists.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 109158] slower loading of a huge AutoCorrect replacement table

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=109158

--- Comment #34 from V Stuart Foote  ---
(In reply to V Stuart Foote from comment #33)
> testing size of the list, assigning a fixed width when list is > some number

And of course not a fixed width (which would be ugly). But rather than doing a
precise calculation, would calculate width with an "approximate character
width" of the font against the "string length" of each list entry. Just for
lists above the threshold.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 109158] slower loading of a huge AutoCorrect replacement table

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=109158

V Stuart Foote  changed:

   What|Removed |Added

 CC||michael.me...@collabora.com

--- Comment #33 from V Stuart Foote  ---
(In reply to Xisco Faulí from comment #31)
> Created attachment 143558 [details]
> Callgrind trace from bug 118761. Thanks to Buovjaga

In this callgrind -- see line# 47060

Each of the 2642 items  loaded in the Autocorrect listbox's GUI with
SvLBoxString::InitViewData() cost both a GetTextHeight() and more expensive
GetTextWidth() call.

As suggested comment 23 the GetTextWidth() could again be controlled by testing
size of the list, assigning a fixed width when list is > some number maybe
~300.

Also, since this controls all GUI listboxes, we can't just make the text height
fixed, but guess we could include within the same list size testing and save
that cost as well?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 109158] slower loading of a huge AutoCorrect replacement table

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=109158

--- Comment #32 from tommy27  ---
retested  under Win8.1 x64
there's a worsening of the bug...

6.0.5.2 still takes 23 seconds to load
6.1.0.3 takes 27 seconds to load.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 109158] slower loading of a huge AutoCorrect replacement table

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=109158

--- Comment #31 from Xisco Faulí  ---
Created attachment 143558
  --> https://bugs.documentfoundation.org/attachment.cgi?id=143558=edit
Callgrind trace from bug 118761. Thanks to Buovjaga

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 109158] slower loading of a huge AutoCorrect replacement table

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=109158

Xisco Faulí  changed:

   What|Removed |Added

 CC||todven...@suomi24.fi

--- Comment #30 from Xisco Faulí  ---
*** Bug 118761 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 109158] slower loading of a huge AutoCorrect replacement table

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=109158

--- Comment #29 from tommy27  ---
interestingly LibO 6.0.4 x64 takes the same amount of time to load that list of
the corresponding x32 version.

I hoped that x64 could be faster but I wasn't right

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 109158] slower loading of a huge AutoCorrect replacement table

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=109158

--- Comment #28 from V Stuart Foote  ---
Of course it remains slow--populating an autocorrect listbox of 200K
entries--each pair of strings has their size precisely calculated with
GetTextWidth() and GetTextHeight() calls [1], looks very expensive.

Kendy's original approach for bug 72125 of using an "approximate character
width" against the "string length" for lists over > 100 entries avoided that
overhead with the Expert Configuration dialog.

Though reverted, seems restoring similar logic (bumping the limit to 500 or
1000 list items) would still be helpful for folks using really large
autocorrection replacement tables. 

It might cause some layout problems (truncation like bug 99071) with a pair of
long strings, but should be rare with a higher threshold.

=-ref-=
https://opengrok.libreoffice.org/xref/core/svtools/source/contnr/svlbitm.cxx#209

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 109158] slower loading of a huge AutoCorrect replacement table

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=109158

--- Comment #27 from tommy27  ---
issue confirmed even on a Windows 10 Pro for Workstations 64-bit

CPU Intel Xeon @ 3.60GHz
RAM 16GB 
Motherboard HP 81C5 (CPU0)

autocorrect table loads in 3 seconds using 5.3.7 and in 9 seconds using 6.0.4

basically there's a 3x performance drop in all Windows O/S with overall speed
being worst under Win 8.1 compared to Win7 and Win10

a bibisect is available from long time
I hope someone could fix this annoying regression

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 109158] slower loading of a huge AutoCorrect replacement table

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=109158

--- Comment #26 from tommy27  ---
bad performance affects LibO 6.2.x master too.
it still takes 23 seconds to load the list under Win8 x64 on a SSD disk.

the same list is loaded in 8 seconds with LibO 5.3.7

this performance drop affects all the 5.4.x, 6.0.x and 6.1.x branches as well

interestingly on older Win7 x64 O/S the time to load those list is lower (4
seconds with 5.3.x and 11 seconds with 5.4.x and later releases) but there's
still almost a 3x difference.

I'll try soon on a Win x10 machine and report the results.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 109158] slower loading of a huge AutoCorrect replacement table

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=109158

--- Comment #25 from tommy27  ---
I hope this issue could be addressed by some developer.

the bibisect data is already available (see comment 13) and there are also some
hints about a possible solution (see comment 23)

because of this issue I'm stuck with LibO 5.3.7

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 109158] slower loading of a huge AutoCorrect replacement table

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=109158

--- Comment #24 from tommy27  ---
thanks Stuart for confirming the regression and giving some insight about the
bug roots

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 109158] slower loading of a huge AutoCorrect replacement table

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=109158

V Stuart Foote  changed:

   What|Removed |Added

 CC||ke...@collabora.com
Version|5.4.1.2 release |5.4.1.1 rc

--- Comment #23 from V Stuart Foote  ---
OK sure, there is a regression 5.4.0.3 -> 5.4.1.1, and in 6.0 and master.

4s -- Version: 5.4.0.3 (x64)
Build ID: 7556cbc6811c9d992f4064ab9287069087d7f62c
CPU threads: 4; OS: Windows 6.19; UI render: GL; 
Locale: en-US (en_US); Calc: group

8s -- Version: 5.4.1.1 (x64)
Build ID: a5be49f0c45fe24a575c7f41559aa8fc79a781a2
CPU threads: 4; OS: Windows 6.19; UI render: GL; 
Locale: en-US (en_US); Calc: group

With earlier benchmarks improved as for bug 79761
18s -- Version: 4.1.6.2
Build ID: 40ff705089295be5be0aae9b15123f687c05b0a

14s -- Version: 4.2.0.1
Build ID: 7bf567613a536ded11709b952950c9e8f7181a4a

4s -- Version: 5.2.7.2 --> on ward.
Build ID: 2b7f1e640c46ceb28adf43ee075a6e8b8439ed10
CPU Threads: 4; OS Version: Windows 6.2; UI Render: GL; 
Locale: en-US (en_US); Calc: group

So fixing bug 99071, reverted Kendy's hack for populating list box views with
more than 100 items, and means all entries in a list box again must lookup the
font and calculate font text width and height. For a user's autocorrect list
box of 200K entries--this is expensive.

Maybe the better way to have fixed it might have been to bump up the number of
GetEntryCount items in a list box before shifting to an approximate_char_width.
With a complex document, would 1000 or 2000 entries in a list box be enough for
well formed list box in Navigator?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 109158] slower loading of a huge AutoCorrect replacement table

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=109158

--- Comment #22 from tommy27  ---
a portable 5.3.7 release is available here:
https://sourceforge.net/projects/winpenpack/files/X-LibreOffice/releases/

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 109158] slower loading of a huge AutoCorrect replacement table

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=109158

--- Comment #21 from tommy27  ---
@Stuart

yes, parsing 200K entries must cause some load, but why LibO 6.x and 5.4.x load
the same autocorrect replacament table 3 times slower than 5.3.x ?

the point of my report is that there has been a performance regression between
those releases.

another thing I've noticed is that Win8.1 x64 is musch slower than Win7 x64

in my initial description which was performed on a Win7 machine the loading
time was 4 seconds in 5.3.x and 10 seconds in other branches 

when moving on another computer with Win8.1 x64 the time climbed to 8 and 21
seconds respectively.

in order to fully reproduce the bug you should test that autocorrect table in
5.3.7 and measure the time needed to load the list.

you tested only 6.1.x and you took 10 seconds to load the list... try 5.3.x and
you see that is faster

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 109158] slower loading of a huge AutoCorrect replacement table

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=109158

V Stuart Foote  changed:

   What|Removed |Added

 CC||vstuart.fo...@utsa.edu

--- Comment #20 from V Stuart Foote  ---
Testing with the acor-it-IT.dat file of attachment 134684 downloaded and
renamed acor-en-US.dat and pasted into $ORIGIN/../Data/settings/user/autocorr

With LO Writer opened, the Tools -> AutoCorrect -> AutoCorrect Options dialog
opens the 206,956 entry list in ~8 seconds. With just the default 2,399 entry
list (i.e. built-ins and Emojis) the dialog opens in ~4 seconds.

And with NVDA 2017.3 screen reader assistive technology (IAccessible2 based)
enabled--the time delay is perhaps 1 sec longer.  So issue of bug 72125, bug
70465 are not in play. Expert Config dialog was converted to tree view [1]
which eliminated need to use a fixed width when traversing long tables [2] and
is the commit Caolán had reverted with [3]

Guess one question might be what structure is used when opening the autocorrect
table data? Looks like a table like Expert Config used to be, and is it
populated with a GetTextWidth() call? I don't see it spike like it was doing
with Expert Configuration but parsing 200K entries must cause some load.

Using OpenGL or default rendering does not seem to affect the loading speed on
Windows 10. Once visible the table scrolls cleanly--but is there otherwise a
font rendering issue when building it?

=-Testing-=

Version: 6.1.0.0.alpha0+ (x64)
Build ID: 609888f3c8d6c0fe72c41ac26de431a12ad3fdd0
CPU threads: 4; OS: Windows 10.0; UI render: GL; 
TinderBox: Win-x86_64@42, Branch:master, Time: 2018-02-08_02:03:29
Locale: en-US (en_US); Calc: CL

[1]
https://cgit.freedesktop.org/libreoffice/core/commit/?id=db35b73037483cd22cd7d4ac93fe40f23fbe3967

[2]
http://cgit.freedesktop.org/libreoffice/core/commit/?id=62ea355b2679073b8ee326df5793231996136da9

[3]
https://cgit.freedesktop.org/libreoffice/core/commit/?id=94c7a401583200cf5982594b1b043ad1a5e3cd38

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 109158] slower loading of a huge AutoCorrect replacement table

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=109158

--- Comment #19 from tommy27  ---
bug still present in 6.1.0.0.alpha0+
Build ID: e0a94ded5d1635fa2a2d9e222bfcfa0a2289a01f
CPU threads: 4; OS: Windows 6.3; UI render: default; 
TinderBox: Win-x86@42, Branch:master, Time: 2018-02-08_23:36:06
Locale: it-IT (it_IT); Calc: group

as said before there's a huge performance drop between LibO 5.3.x and 5.4.x and
6.x branches  (8 seconds vs. 23 seconds)

a bibisect has been performed and apperently identified the committ which
introduced the regression.

I really hope so developer can take a look into it..
this bug has become a showstopper for me and I'm stuck with 5.3.7

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 109158] slower loading of a huge AutoCorrect replacement table

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=109158

tommy27  changed:

   What|Removed |Added

Version|5.4.0.3 release |5.4.1.2 release

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 109158] slower loading of a huge AutoCorrect replacement table

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=109158

tommy27  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=72
   ||125

--- Comment #18 from tommy27  ---
that bibisect log points toward a fix for Bug 72125 - Expert config dialog
takes too much time to come up

could that fix be the culprit of the current autocorrect table performance
regression?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 109158] slower loading of a huge AutoCorrect replacement table

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=109158

tommy27  changed:

   What|Removed |Added

 CC||nthieb...@gmail.com

--- Comment #17 from tommy27  ---
bad performance affects LibO 6.1.x master too.
it still takes 23 seconds to load the list

the same list is loaded in 8 seconds with LibO 5.3.6.1

unfortunately the issue is present in the 5.4.x branch as well with 23 seconds
to load the list using LibO 5.4.3.2

this means that something caused a 3x slower performance in the 5.4.x and
master branches in respect to the 5.3.x branch.

a bibisect has been performed by telesto (see comment 13) so I gently ask to
the developers to give a look at it

@Norbert Thiebaud
would you please take a look at the bibisect log?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 109158] slower loading of a huge AutoCorrect replacement table

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=109158

--- Comment #16 from tommy27  ---
retested on latest daily build (*) but this time the performance is worsened a
lot...

it takes 23 seconds instead of 12 of october 31st build.

(*) 6.0.0.0.alpha1+
Build ID: 2865210607364feaff2c0275b7cd6c5439f5f070
CPU threads: 4; OS: Windows 6.3; UI render: default; 
TinderBox: Win-x86@42, Branch:master, Time: 2017-11-18_23:53:39
Locale: it-IT (it_IT); Calc: group

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 109158] slower loading of a huge AutoCorrect replacement table

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=109158

--- Comment #15 from tommy27  ---

retested on the same Win8.1 x64 machine as in comment 4

> LibO 6.0.0.0.alpha0+ (the day before bug 99071 fix)
> TinderBox: Win-x86@42, Branch:master, Time: 2017-07-13_23:50:53
> takes 8 seconds to load which is the same time needed by 5.4.3.2 on the same
> PC.

> LibO 6.0.0.0.alpha0+ (on builds featuring that committ)
> TinderBox: Win-x86@42, Branch:master, Time: 2017-07-17_23:50:28
> takes 21 seconds to load instead of 8 of the previous 6.0.x builds

LibO 6.0.0.0.alpha1+ (*)
takes 12 seconds to load, which is still slower than 5.3.6.1 (still 8 seconds)
but much better that 6.0.x alpha0+


(*) Build ID: 8ea346b87c8f62d93bec283515abae8db36a08ed
CPU threads: 4; OS: Windows 6.3; UI render: default; 
TinderBox: Win-x86@42, Branch:master, Time: 2017-10-31_23:37:25
Locale: it-IT (it_IT); Calc: group

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 109158] slower loading of a huge AutoCorrect replacement table

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=109158

--- Comment #14 from tommy27  ---
(In reply to Caolán McNamara from comment #12)
> which is, quite frankly, useless information in the sense that if one picks
> a fairly random fixed value as the size of text instead of measuring it then
> its faster to use that number and have wrong text size then measure the text
> and have correct text size. Throwing "regression" around doesn't change that.

well, being just an user my suspect was just caused by the fact that before
that bug 99071 got fixed performance was good and after the fix was poor. 

I have no technical knowledge to inspect the code and tell if my suspect was
correct or not.

but what do you think about Telestos's bibisect? 
it seems to confirm that a precise committ caused the performance drop.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 109158] slower loading of a huge AutoCorrect replacement table

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=109158

Telesto  changed:

   What|Removed |Added

   Keywords|bibisectRequest |bibisected, bisected

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 109158] slower loading of a huge AutoCorrect replacement table

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=109158

--- Comment #13 from Telesto  ---
Created attachment 136759
  --> https://bugs.documentfoundation.org/attachment.cgi?id=136759=edit
Bibisect log

~/bibisect-win32-6.0
$ git bisect good
53cd0ea77358e5ea6f8933846afdfa4192290b10 is the first bad commit
commit 53cd0ea77358e5ea6f8933846afdfa4192290b10
Author: Norbert Thiebaud 
Date:   Sat Jul 29 16:11:21 2017 -0700

source sha:94c7a401583200cf5982594b1b043ad1a5e3cd38

source sha:94c7a401583200cf5982594b1b043ad1a5e3cd38

:04 04 aeb8bb5ed3559a4d854e68b2667c85b3e1e7c64f
b8f5129dbc48f015bbd7e7f90ff1bd83dd364e62 M  instdir



author  Caolán McNamara 2017-07-14 13:22:06 (GMT)
committer   Caolán McNamara 2017-07-14 16:11:03
(GMT)
commit  94c7a401583200cf5982594b1b043ad1a5e3cd38 (patch)
tree993b6717312394349d547e271b8e2e8811194b12
parent  6b6b81cae861a1e6463360d1b320c0d3e24de111 (diff)
Resolves: tdf#99071 tree view shows odd text widths when > 100 lines
reverts

commit 62ea355b2679073b8ee326df5793231996136da9
Date:   Thu Dec 12 09:55:35 2013 +0100

fdo#72125: GetTextWidth() can get very expensive.

Let's just count an approximate width using a cached value when we have too
many entries.

The expert dialog got fixed by not populating it with all options on load
and instead by incremental disclosure as the users searches/expands it so
this optimization effort isn't needed

in the meantime there was another problem the above papered over with

commit b4bbb5e5d7b31caad2fbcc00382ad27df3c81001
Date:   Sun May 17 22:56:46 2015 +0900

refactor how font, fg. and bg. are applied in widgets/controls

which was fixed (hopefully) in the previous commit

Change-Id: I8383d9cd7a9983a85c7f3acec0281d984c44f9e7
Reviewed-on: https://gerrit.libreoffice.org/39951
Tested-by: Jenkins 
Reviewed-by: Caolán McNamara 
Tested-by: Caolán McNamara 

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 109158] slower loading of a huge AutoCorrect replacement table

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=109158

--- Comment #12 from Caolán McNamara  ---
which is, quite frankly, useless information in the sense that if one picks a
fairly random fixed value as the size of text instead of measuring it then its
faster to use that number and have wrong text size then measure the text and
have correct text size. Throwing "regression" around doesn't change that.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 109158] slower loading of a huge AutoCorrect replacement table

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=109158

--- Comment #11 from tommy27  ---
performance drop unchanged with latest LibO 6.0.0.0.alpha0+ daily build
downloaded tonight.

I confirm the perfomance regression (test done on a Win8.1 x64 machine, but
affects Win7 x74 as well)

> 
> LibO 4.4.0 --> 42 seconds
> 
> LibO 5.1.2 --> 10 seconds to load
> 
> LibO 5.3.4 --> 8 seconds to load 
> 
> LibO 6.0.0 --> 8 seconds to load (the day before bug 99071 fix)
> 
> LibO 6.0.0 --> 21 seconds to load (the day after bug 99071 fix)
> 

as said before I have strong suspects that the regression was caused by bug
99071 fix.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 109158] slower loading of a huge AutoCorrect replacement table

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=109158

tommy27  changed:

   What|Removed |Added

 Blocks||103341


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=103341
[Bug 103341] [META] Auto Correct and Completion bugs and enhancements
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 109158] slower loading of a huge AutoCorrect replacement table

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=109158

tommy27  changed:

   What|Removed |Added

   Keywords||bibisectRequest

--- Comment #10 from tommy27  ---
I confirm there's no slowdown in 5.4.0.3
the loading time is the same as in 5.3.4.2

this means that the guilty committ comes from the 6.0.x branch and has been
backported to 5.4.1 but not in 5.4.0

as said before in comment 2 I suspect that bug 99071 fix started the regression
which appeared between 13th and 17th of July.

a bibisect is needed to confirm.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 109158] slower loading of a huge AutoCorrect replacement table

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=109158

--- Comment #9 from tommy27  ---
(In reply to Telesto from comment #8)
> I can confirm a slow down:
> Version: 5.4.0.3 -> 4 seconds 
> Version 6.0.0.0 → 10 seconds

interesting...
I see the slowdown in 5.4.1.x but you don't see it in 5.4.0.3.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 109158] slower loading of a huge AutoCorrect replacement table

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=109158

Xisco Faulí  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEW
 Ever confirmed|0   |1

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 109158] slower loading of a huge AutoCorrect replacement table

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=109158

--- Comment #8 from Telesto  ---
I can confirm a slow down:
Version: 5.4.0.3 -> 4 seconds 
Version 6.0.0.0 → 10 seconds

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 109158] slower loading of a huge AutoCorrect replacement table

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=109158

tommy27  changed:

   What|Removed |Added

   Keywords||perf

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 109158] slower loading of a huge AutoCorrect replacement table

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=109158

tommy27  changed:

   What|Removed |Added

Version|6.0.0.0.alpha0+ Master  |5.4.0.3 rc

--- Comment #7 from tommy27  ---
Maybe the total lenght is O/S related...

I retested on a Win7 x64 machine and result is:

5.3.4.2 -> 4 seconds 

6.0.0.0 → 10 seconds


Win8.1 x64 machine is:

Intel Core i7 959 @ 3.07Ghz
12 GB RAM
SSD disk

Win7 x64 machine in:

AMD A8-6410
8 GB RAM
SSD disk


so the same file and the same version of LibO are slower under Win8.1
anyway the performance drop between 5.3.x an 5.4.x is clear in either O/S

@Aron
can you confirm it's slower in 5.4.x and 6.0.x compared to 5.3.x ?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 109158] slower loading of a huge AutoCorrect replacement table

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=109158

Aron Budea  changed:

   What|Removed |Added

 CC||ba...@caesar.elte.hu

--- Comment #6 from Aron Budea  ---
My 32-bit Windows build of 46bfe17e2bceced4ceffe82ba98d8687b31d9ce8 isn't that
slow, it takes ~10s to open the dialog with the sample from the description.

However looking at profiling results I do see that performance could be
improved: when looping through entries and inserting each in
OfaAutocorrReplacePage::RefillReplaceBox(...), a couple of levels deeper in
SvTreeList::Insert(...) the SvListAction::INSERTED event is broadcasted, then
further deeper handled, which updates the view data.
Doing that per each entry seems wasteful.

Loading the XML could be faster as well.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 109158] slower loading of a huge AutoCorrect replacement table

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=109158

--- Comment #5 from tommy27  ---
(In reply to tommy27 from comment #4)
> 
> retested on the same Win8.1 x64 machine as in comment 2.
> 
> 
> 
> LibO 5.3.4 --> 8 seconds to load 
> 
> LibO 6.0.0 * --> 8 seconds to load (the day before bug 99071 fix)
> 
> LibO 6.0.0 * --> 21 seconds to load (the day after bug 99071 fix)
> 
> 
> 
> I cannot test 5.4.x daily builds since the Windows tinderbox are not working.


issue affect the 5.4.x branch as well

5.4.1.0.0+ (x64)* --> 21 seconds to load

* Build ID: b78c398817940bbbe0b9ebe848a923cef1856758
CPU threads: 4; OS: Windows 6.29; UI render: default; 
TinderBox: Win-x86_64@62-TDF, Branch:libreoffice-5-4, Time: 2017-07-28_09:02:44
Locale: it-IT (it_IT); Calc: group


this is gonna be an upgrade stopper for me, since I often open the autocorrect
replacement table at work.

I can cope with an 8 seconds wait as in 5.3.x but I cannot stand a 21 seconds
wait such a performance drop is not compatible with my workflow... I'll
stick to 5.3.x in the meantime, hoping the issue will be resolved in next 5.4.x
releases.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 109158] slower loading of a huge AutoCorrect replacement table

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=109158

tommy27  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=79
   ||761

--- Comment #4 from tommy27  ---
@Xisco

retested on the same Win8.1 x64 machine as in comment 2.

LibO 4.4.0 --> 42 seconds

LibO 5.1.2 --> 10 seconds to load

LibO 5.3.4 --> 8 seconds to load 

LibO 6.0.0 * --> 8 seconds to load (the day before bug 99071 fix)

LibO 6.0.0 * --> 21 seconds to load (the day after bug 99071 fix)


so the situation was even worse in 4.1.x but a considerable performance
improvement was achieved in the 5.x branch. see also history in Bug 79761

the performance was the same as 5.3.x in recent 6.0.x daily builds but just
after the bug 99071 got fixed , thing become worse again.

according to my tests the regression happened during recent 6.x development.
I don't know if the regression was effectively caused by that committ or is
just a coincidence... anyway something has happened.

I cannot test 5.4.x daily builds since the Windows tinderbox are not working.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 109158] slower loading of a huge AutoCorrect replacement table

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=109158

Xisco Faulí  changed:

   What|Removed |Added

 CC||xiscofa...@libreoffice.org

--- Comment #3 from Xisco Faulí  ---
the fix for Bug 99071 just reverts 62ea355b2679073b8ee326df5793231996136da9, so
I guess it was slower in 4.1 or previous. Could you please test how long it
takes with an old version?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 109158] slower loading of a huge AutoCorrect replacement table

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=109158

tommy27  changed:

   What|Removed |Added

 CC||ba...@quipo.it
   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=10
   ||9156

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs