Re: [PATCH 2/2] enabled vdda_dac regulator support tvout on rx51

2010-12-22 Thread Srikar 
Updated version of patch of this is available at

https://patchwork.kernel.org/patch/424731/



On 11/30/2010 07:39 PM, ext Tony Lindgren wrote:
 * Mark Brown broo...@opensource.wolfsonmicro.com [101129 10:27]:
 On Mon, Nov 29, 2010 at 10:18:31AM -0800, Tony Lindgren wrote:
 * Mark Brown broo...@opensource.wolfsonmicro.com [101127 02:10]:
 Yeah.  Some of it will need to be __devinitdata for hotpluggable things
 but most of it should be __initdata.  I'll update the regulator API to
 copy the constraints before the next merge window.
 OK sounds good to me.
 FWIW the patch is regulator: Copy constraints from regulators when
 initialising them, posted for review today.
 Great, once that merges we'll start checking what can be __init or
 __init_or_module for the omap board-*.c files.

 Tony

--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 2/2] enabled vdda_dac regulator support tvout on rx51

2010-11-30 Thread Tony Lindgren 
* Mark Brown broo...@opensource.wolfsonmicro.com [101129 10:27]:
 On Mon, Nov 29, 2010 at 10:18:31AM -0800, Tony Lindgren wrote:
  * Mark Brown broo...@opensource.wolfsonmicro.com [101127 02:10]:
 
   Yeah.  Some of it will need to be __devinitdata for hotpluggable things
   but most of it should be __initdata.  I'll update the regulator API to
   copy the constraints before the next merge window.
 
  OK sounds good to me.
 
 FWIW the patch is regulator: Copy constraints from regulators when
 initialising them, posted for review today.

Great, once that merges we'll start checking what can be __init or
__init_or_module for the omap board-*.c files.

Tony
--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 2/2] enabled vdda_dac regulator support tvout on rx51

2010-11-29 Thread Tony Lindgren 
* Mark Brown broo...@opensource.wolfsonmicro.com [101127 02:10]:
 On Fri, Nov 26, 2010 at 09:45:17AM -0800, Tony Lindgren wrote:
 
  By the way, all the board specific data should be __initdata eventually.
  Now we're hogging memory for the regulators for all the boards compiled in..
 
 Yeah.  Some of it will need to be __devinitdata for hotpluggable things
 but most of it should be __initdata.  I'll update the regulator API to
 copy the constraints before the next merge window.

OK sounds good to me.

Tony
--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 2/2] enabled vdda_dac regulator support tvout on rx51

2010-11-29 Thread Mark Brown 
On Mon, Nov 29, 2010 at 10:18:31AM -0800, Tony Lindgren wrote:
 * Mark Brown broo...@opensource.wolfsonmicro.com [101127 02:10]:

  Yeah.  Some of it will need to be __devinitdata for hotpluggable things
  but most of it should be __initdata.  I'll update the regulator API to
  copy the constraints before the next merge window.

 OK sounds good to me.

FWIW the patch is regulator: Copy constraints from regulators when
initialising them, posted for review today.
--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 2/2] enabled vdda_dac regulator support tvout on rx51

2010-11-27 Thread Mark Brown 
On Fri, Nov 26, 2010 at 09:45:17AM -0800, Tony Lindgren wrote:

 By the way, all the board specific data should be __initdata eventually.
 Now we're hogging memory for the regulators for all the boards compiled in..

Yeah.  Some of it will need to be __devinitdata for hotpluggable things
but most of it should be __initdata.  I'll update the regulator API to
copy the constraints before the next merge window.
--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

RE: [PATCH 2/2] enabled vdda_dac regulator support tvout on rx51

2010-11-26 Thread ext-srikar.1.bhavanarayana 
 +#if defined(CONFIG_FB_OMAP2) || defined(CONFIG_FB_OMAP2_MODULE)

The ifdefs here aren't really saving much...
 In the same file board-rx51-peripheral.c,Under these  rx51_display_device is
defined  as extern  and also in board-rx51-video.c the under same #defines 
Complete display functionality is implemented
currently so used  not to break compilation when #defines are not enabled .

.dev_name is preferred, though I'm not sure if we'll ever get round to
phasing out plain dev.
It is difficult to modify currently.


From: ext Mark Brown [broo...@opensource.wolfsonmicro.com]
Sent: Thursday, November 25, 2010 6:11 PM
To: Bhavanarayana Srikar.1 (EXT-Elektrobit/Helsinki)
Cc: t...@atomide.com; li...@arm.linux.org.uk; linux-omap@vger.kernel.org
Subject: Re: [PATCH 2/2] enabled vdda_dac regulator support tvout on rx51

On Thu, Nov 25, 2010 at 05:52:23PM +0200, Srikar wrote:

 +static struct regulator_consumer_supply rx51_vdac_supply[] = {
 + {
 +#if defined(CONFIG_FB_OMAP2) || defined(CONFIG_FB_OMAP2_MODULE)

The ifdefs here aren't really saving much...

 + .supply = vdda_dac,
 + .dev= rx51_display_device.dev,

dev_name is preferred, though I'm not sure if we'll ever get round to
phasing out plain dev.
--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 2/2] enabled vdda_dac regulator support tvout on rx51

2010-11-26 Thread Srikar 
On 11/25/2010 06:11 PM, ext Mark Brown wrote:
 On Thu, Nov 25, 2010 at 05:52:23PM +0200, Srikar wrote:

 +static struct regulator_consumer_supply rx51_vdac_supply[] = {
 +{
 +#if defined(CONFIG_FB_OMAP2) || defined(CONFIG_FB_OMAP2_MODULE)
 The ifdefs here aren't really saving much...
Currently rx51_display_device is defined under same
ifdefs(CONFIG_FB_OMAP2,CONFIG_FB_OMAP2_MODULE)
 as extern and also in board-rx51-video.c display devices are under same
ifdefs,So used to  not
break compilation when CONFIG_FB_OMAP2,CONFIG_FB_OMAP2_MODULE not defined.
 +.supply = vdda_dac,
 +.dev= rx51_display_device.dev,
 dev_name is preferred, though I'm not sure if we'll ever get round to
 phasing out plain dev.
Currently difficult to use .dev_name .
--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 2/2] enabled vdda_dac regulator support tvout on rx51

2010-11-26 Thread Mark Brown 
On Fri, Nov 26, 2010 at 11:56:35AM +0200, Srikar wrote:
 On 11/25/2010 06:11 PM, ext Mark Brown wrote:
  On Thu, Nov 25, 2010 at 05:52:23PM +0200, Srikar wrote:
 
  +static struct regulator_consumer_supply rx51_vdac_supply[] = {
  +  {
  +#if defined(CONFIG_FB_OMAP2) || defined(CONFIG_FB_OMAP2_MODULE)
  The ifdefs here aren't really saving much...

 Currently rx51_display_device is defined under same
 ifdefs(CONFIG_FB_OMAP2,CONFIG_FB_OMAP2_MODULE)
  as extern and also in board-rx51-video.c display devices are under same
 ifdefs,So used to  not
 break compilation when CONFIG_FB_OMAP2,CONFIG_FB_OMAP2_MODULE not defined.

If you convert to usign dev_name as is better practice anyway this
won't be an issue.

  +  .supply = vdda_dac,
  +  .dev= rx51_display_device.dev,
  dev_name is preferred, though I'm not sure if we'll ever get round to
  phasing out plain dev.

 Currently difficult to use .dev_name .

because...
--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 2/2] enabled vdda_dac regulator support tvout on rx51

2010-11-26 Thread Tony Lindgren 
* Mark Brown broo...@opensource.wolfsonmicro.com [101126 04:50]:
 On Fri, Nov 26, 2010 at 11:56:35AM +0200, Srikar wrote:
  On 11/25/2010 06:11 PM, ext Mark Brown wrote:
   On Thu, Nov 25, 2010 at 05:52:23PM +0200, Srikar wrote:
  
   +static struct regulator_consumer_supply rx51_vdac_supply[] = {
   +{
   +#if defined(CONFIG_FB_OMAP2) || defined(CONFIG_FB_OMAP2_MODULE)
   The ifdefs here aren't really saving much...

By the way, all the board specific data should be __initdata eventually.
Now we're hogging memory for the regulators for all the boards compiled in..

Regards,

Tony

--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH 2/2] enabled vdda_dac regulator support tvout on rx51

2010-11-25 Thread Srikar 
To support tvout on rx51,added the venc vdac regulator
consumer supply data  and also intialised the vdac regulator
with vdac regulator consumer supply data which enables the
power supply to venc through twl4030 on rx51

Signed-off-by: Srikar ext-srikar.1.bhavanaray...@nokia.com
---
 arch/arm/mach-omap2/board-rx51-peripherals.c |   17 +++--
 1 files changed, 15 insertions(+), 2 deletions(-)

diff --git a/arch/arm/mach-omap2/board-rx51-peripherals.c 
b/arch/arm/mach-omap2/board-rx51-peripherals.c
index e56d6d7..ec47402 100644
--- a/arch/arm/mach-omap2/board-rx51-peripherals.c
+++ b/arch/arm/mach-omap2/board-rx51-peripherals.c
@@ -372,6 +372,16 @@ static struct regulator_consumer_supply 
rx51_vaux1_consumers[] = {
 #endif
 };
 
+static struct regulator_consumer_supply rx51_vdac_supply[] = {
+   {
+#if defined(CONFIG_FB_OMAP2) || defined(CONFIG_FB_OMAP2_MODULE)
+   .supply = vdda_dac,
+   .dev= rx51_display_device.dev,
+   },
+#endif
+};
+
+
 static struct regulator_init_data rx51_vaux1 = {
.constraints = {
.name   = V28,
@@ -489,14 +499,17 @@ static struct regulator_init_data rx51_vsim = {
 
 static struct regulator_init_data rx51_vdac = {
.constraints = {
+   .name   = VDAC,
.min_uV = 180,
.max_uV = 180,
+   .apply_uV   = true,
.valid_modes_mask   = REGULATOR_MODE_NORMAL
| REGULATOR_MODE_STANDBY,
-   .valid_ops_mask = REGULATOR_CHANGE_VOLTAGE
-   | REGULATOR_CHANGE_MODE
+   .valid_ops_mask = REGULATOR_CHANGE_MODE
| REGULATOR_CHANGE_STATUS,
},
+   .num_consumer_supplies  = 1,
+   .consumer_supplies  = rx51_vdac_supply,
 };
 
 static struct regulator_init_data rx51_vio = {
-- 
1.7.1

--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 2/2] enabled vdda_dac regulator support tvout on rx51

2010-11-25 Thread Mark Brown 
On Thu, Nov 25, 2010 at 05:52:23PM +0200, Srikar wrote:

 +static struct regulator_consumer_supply rx51_vdac_supply[] = {
 + {
 +#if defined(CONFIG_FB_OMAP2) || defined(CONFIG_FB_OMAP2_MODULE)

The ifdefs here aren't really saving much...

 + .supply = vdda_dac,
 + .dev= rx51_display_device.dev,

dev_name is preferred, though I'm not sure if we'll ever get round to
phasing out plain dev.
--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html