Re: [RFC][PATCH] native file dialogs

[Jürgen Spitzmüller]

Am Dienstag, den 30.01.2018, 23:24 +0100 schrieb Jean-Marc Lasgouttes:
> Nice, so to speak. To be frank, I have no interest in reworking 20+ 
> dialogs to give them nice buttons. But this is of course desirable
> in 
> the long term.

I agree.

> > > 1/ apply this patch, maybe with a default of "false" and value
> > > "true"
> > > set in mac and windows lyxrc.dist files. This would give us the
> > > same
> > > behavior as before, but configurable
> > 
> > Would be good as a start.
> 
> Or set the default to use native everywhere and let experimented
> people 
> override that.

Yes. But then, I think, you can also drop it altogether.

> > > 3/ remove support for our custom file dialog and always use the
> > > native
> > > one (this would lose the Document/Example buttons)
> > 
> > Which would be a pity.
> 
> Why? Because of the buttons? José proposed to add an entry "Open 
> example..." in Help menu (could be in File menu too). Would that be
> enough ?

The nice thing about the buttons is that they only occur when it makes
sense. And remember we do not only have "Examples". We also show
"Templates" (my favorite), "Documents", "Cliparts" (and maybe others).
And if done correctly, it could be extended to other places depending
on the context (e.g., "BibTeX databases" ($TEXMF/bib) in the BibTeX
dialog).

> 
> Note that each OS offers a way to add your own favorite places in a
> kind 
> of sidebar.

I know, but these are static (at least on an app-level).

> > > 4/  remove support for our custom file dialog and always use the
> > > Qt
> > > custom file dialog, and try to make setSidebarUrl work, so that
> > > we
> > > have
> > > our Documents/Examples links in the side bar; this cannot work
> > > with
> > > a
> > > native file dialog.
> > 
> > This would be the best solution IMHO. But do you know how to make
> > setSidebarUrl work with proper entries? (I don't).
> 
> Well, first, remember that it means no native dialog.

Why? Doesn't the method work with native dialogs?

> Then the way to do it could be to create links to the proper
> directories 
> which have the proper names. But this is bound to fail in one way or 
> another. It is a pity that QUrl does not allow to add a text part.

Indeed.

Jürgen


signature.asc
Description: This is a digitally signed message part

LyX version 2.3.0rc2 available

[Scott Kostyshak]

Public release of LyX version 2.3.0rc2


We are proud to announce the second public release candidate of the new LyX 2.3
series. This pre-release is meant for testing and should not be used for
serious work. For curious users who would like to test in order to help catch
bugs before the 2.3.0 release, please back up all of your documents and be
prepared for the worst to happen. Most users (who desire a stable LyX version)
should not use this pre-release.

The 2.3 series has a rich set of new features compared to the current stable
series. An overview of the new features can be found here:

  https://wiki.lyx.org/LyX/NewInLyX23

You can download LyX 2.3.0rc2 from ftp://ftp.lyx.org/pub/lyx/devel/.

We appreciate your help in testing this pre-release!

If a file from an earlier version of LyX is opened *and saved* with
any version of 2.3.x, then the original file will automatically be
backed up. The backup file will be found in the backup directory, if one
is set under Tools> Preferences> Paths, or else in the same folder as
the original file, if no backup directory is set. The filename of the
backup file will be:
ORIGNAME-lyxformat-NUM.lyx~
where NUM is the LyX format number of the original file. In the case of
2.2.x file, this will be 508, but in the case of older files it will be
different.

The file lib/RELEASE-NOTES lists some known issues and problems compared
to the current stable releases (LyX 2.2.x). We strongly recommend that
packagers of LyX on various platforms and distributions read this file.

As with any major release, this one comes with a lot of new features but
also some bugs. If you think you have found a bug in LyX 2.3.0rc2, either
email the LyX developers' mailing list (lyx-devel at lists.lyx.org),
or open a bug report at https://www.lyx.org/trac/wiki/BugTrackerHome.
Please specify if the behavior you are reporting is different from behavior
in a previous LyX version.

If you have trouble using LyX or have a question, consult the
documentation that comes with LyX (under Help) and the LyX wiki, which you
will find at https://wiki.lyx.org/. You can also send email to the LyX users'
list (lyx-users at lists.lyx.org).

The LyX team.
https://www.lyx.org



signature.asc
Description: PGP signature

Re: lyx.org down?

[Joel Kulesza]

Just came up for me.

On Tue, Jan 30, 2018 at 10:23 PM, Scott Kostyshak  wrote:

> lyx.org is not responding to me.
>
> Scott
>

lyx.org down?

[Scott Kostyshak]

lyx.org is not responding to me.

Scott


signature.asc
Description: PGP signature

Re: [RFC][PATCH] native file dialogs

[Andrew Parsloe]

On 31/01/2018 4:41 a.m., Jean-Marc Lasgouttes wrote:

Le 30/01/2018 à 16:33, José Abílio Matos a écrit :
One option that I thought about it sometimes is the removal of the 
native file dialogs and the placement in the Help menu of an entry 
that would allow to open the file picker for Examples. Because, at 
least to me, Examples conceptually belong to Help and not to File.


You mean _custom_ file dialogs, right?

JMarc
As a windows user, I like this idea. At present the examples are well 
hidden. To get to them needs a lot of clicking so that over a decade of 
LyX use I've hardly looked at them.


Andrew

---
This email has been checked for viruses by Avast antivirus software.
https://www.avast.com/antivirus

Re: [RFC][PATCH] native file dialogs

[Jean-Marc Lasgouttes]

Le 30/01/2018 à 19:32, Jürgen Spitzmüller a écrit :

The following patch allows to select the type of file dialog at
runtime
(see ticket http://www.lyx.org/trac/ticket/11003 for why I am doing
that).


Nice.


Nice, so to speak. To be frank, I have no interest in reworking 20+ 
dialogs to give them nice buttons. But this is of course desirable in 
the long term.



1/ apply this patch, maybe with a default of "false" and value
"true"
set in mac and windows lyxrc.dist files. This would give us the same
behavior as before, but configurable


Would be good as a start.


Or set the default to use native everywhere and let experimented people 
override that.



3/ remove support for our custom file dialog and always use the
native
one (this would lose the Document/Example buttons)


Which would be a pity.


Why? Because of the buttons? José proposed to add an entry "Open 
example..." in Help menu (could be in File menu too). Would that be enough ?


Note that each OS offers a way to add your own favorite places in a kind 
of sidebar.



4/  remove support for our custom file dialog and always use the Qt
custom file dialog, and try to make setSidebarUrl work, so that we
have
our Documents/Examples links in the side bar; this cannot work with
a
native file dialog.


This would be the best solution IMHO. But do you know how to make
setSidebarUrl work with proper entries? (I don't).


Well, first, remember that it means no native dialog.

Then the way to do it could be to create links to the proper directories 
which have the proper names. But this is bound to fail in one way or 
another. It is a pity that QUrl does not allow to add a text part.




Does somebody use the custom Documents/Examples buttons? Are they
really
needed?


I don't use them anymore personally (I use the native dialog), but I
think they are quite useful. But of course they should work on all
platforms.


Indeed.

JMarc

Re: [LyX/master] Once more, the libertine font package has been renamed.

[Scott Kostyshak]

On Tue, Jan 30, 2018 at 06:28:09PM +, Jürgen Spitzmüller wrote:
> Am Dienstag, den 30.01.2018, 13:09 -0500 schrieb Scott Kostyshak:
> > Thanks, please go ahead.
> > 
> > Just to make sure I understand: if the user has only the older
> > version
> > installed, there is no expected change in (LyX) behavior. It is just
> > in
> > case the user has the newer version installed, LyX now uses that. Did
> > I
> > get that right?
> 
> Yes, correct.

Thanks,

Scott


signature.asc
Description: PGP signature

Re: [RFC][PATCH] native file dialogs

[Jürgen Spitzmüller]

Am Dienstag, den 30.01.2018, 15:01 +0100 schrieb Jean-Marc Lasgouttes:
> Currently native file dialogs are used on windows and Mac. It is 
> possible to select them on unix with cmake, but not autoconf.
> 
> The following patch allows to select the type of file dialog at
> runtime 
> (see ticket http://www.lyx.org/trac/ticket/11003 for why I am doing
> that).

Nice.

> Currently all platforms default to true (native). Where can we go
> from 
> there? Ideas:
> 
> 1/ apply this patch, maybe with a default of "false" and value
> "true" 
> set in mac and windows lyxrc.dist files. This would give us the same 
> behavior as before, but configurable

Would be good as a start.

> 
> 2/ the same, but also add a 100th checkbox to our crowded preference 
> dialog so that people can toggle it at ease

Nah.

> 3/ remove support for our custom file dialog and always use the
> native 
> one (this would lose the Document/Example buttons)

Which would be a pity.

> 4/  remove support for our custom file dialog and always use the Qt 
> custom file dialog, and try to make setSidebarUrl work, so that we
> have 
> our Documents/Examples links in the side bar; this cannot work with
> a 
> native file dialog.

This would be the best solution IMHO. But do you know how to make
setSidebarUrl work with proper entries? (I don't).

> Does somebody use the custom Documents/Examples buttons? Are they
> really 
> needed?

I don't use them anymore personally (I use the native dialog), but I
think they are quite useful. But of course they should work on all
platforms.

Jürgen

> 
> JMarc
> 
> 

signature.asc
Description: This is a digitally signed message part

Re: [LyX/master] Once more, the libertine font package has been renamed.

[Jürgen Spitzmüller]

Am Dienstag, den 30.01.2018, 13:09 -0500 schrieb Scott Kostyshak:
> Thanks, please go ahead.
> 
> Just to make sure I understand: if the user has only the older
> version
> installed, there is no expected change in (LyX) behavior. It is just
> in
> case the user has the newer version installed, LyX now uses that. Did
> I
> get that right?

Yes, correct.

Jürgen

> 
> Scott

signature.asc
Description: This is a digitally signed message part

Re: [RFC][PATCH] native file dialogs

[Scott Kostyshak]

On Tue, Jan 30, 2018 at 02:01:54PM +, Jean-Marc Lasgouttes wrote:

> Does somebody use the custom Documents/Examples buttons? Are they really
> needed?

I use them, but the cost of forgetting that they are not available on
all platforms always comes back to bite me when I give a presentation on
LyX.

Scott

Re: [LyX/master] Once more, the libertine font package has been renamed.

[Scott Kostyshak]

On Tue, Jan 30, 2018 at 07:16:57AM +, Juergen Spitzmueller wrote:
> commit 7e071f14b9394d1e8e974ba5d19c61921c203f5b
> Author: Juergen Spitzmueller 
> Date:   Tue Jan 30 08:16:06 2018 +0100
> 
> Once more, the libertine font package has been renamed.
> 
> Take the newest one, if present.
> 
> Candidate for 2.3.x.

Thanks, please go ahead.

Just to make sure I understand: if the user has only the older version
installed, there is no expected change in (LyX) behavior. It is just in
case the user has the newer version installed, LyX now uses that. Did I
get that right?

Scott

Re: Crash when working with tables (master)

[Pavel Sanda]

Pavel Sanda wrote:
> Ok try step 2 to be:

I meant step 1... P

Re: Crash when working with tables (master)

[Pavel Sanda]

Jean-Marc Lasgouttes wrote:
> Le 30/01/2018 ? 16:43, Pavel Sanda a écrit :
>> Hi,
>> I have difficult time to produce reliable recipy, but I get consistent 
>> crashes when
>> using undo in tables. Hopefully I narrow it down sooner or later, but the
>> scenario is along the following lines:
>> 0. Load the attached file.
>> 1. "Some" random editing (also involing undo),
>> this step is the "dificult" part of reproducibility,
>> but I was capable to couple crashes within few minutes...
>> 2. Go to the most right-top cell and choose via context
>> menu and choose Column/Rows->Append row
>> 3. Undo
>> 4. Kaboom
>
> It might be my patch that moves plenty of Cursor methods to CursorData, or 
> just code that is not safe. The interesting line is 
> :CursorData::checkNewWordPosition (this=0x56e791f8) at Cursor.cpp:469.
>
> A recipe would be useful indeed.

Ok try step 2 to be:

"[x,y]" = cell: x-th right from left, y-th down from top

1. [3,2] set via context menu "append row"
2. [4,2] write "asdasdasd"
3. [4,1] set "append row"
4. undo many times to get to initial state
5. repeat 1,2,3,4. Kaboom at 4.

Can you reproduce? P

Re: Crash when working with tables (master)

[Jean-Marc Lasgouttes]

Le 30/01/2018 à 16:43, Pavel Sanda a écrit :

Hi,

I have difficult time to produce reliable recipy, but I get consistent crashes 
when
using undo in tables. Hopefully I narrow it down sooner or later, but the
scenario is along the following lines:

0. Load the attached file.
1. "Some" random editing (also involing undo),
this step is the "dificult" part of reproducibility,
but I was capable to couple crashes within few minutes...
2. Go to the most right-top cell and choose via context
menu and choose Column/Rows->Append row
3. Undo
4. Kaboom


It might be my patch that moves plenty of Cursor methods to CursorData, 
or just code that is not safe. The interesting line is 
:CursorData::checkNewWordPosition (this=0x56e791f8) at Cursor.cpp:469.


A recipe would be useful indeed.

JMarc

Re: [RFC][PATCH] native file dialogs

[José Abílio Matos]

On Tuesday, 30 January 2018 15.41.28 WET Jean-Marc 
Lasgouttes wrote:
> You mean _custom_ file dialogs, right?
> 
> JMarc

Sure. My mistake. :-)
-- 
José Abílio

Crash when working with tables (master)

[Pavel Sanda]

Hi,

I have difficult time to produce reliable recipy, but I get consistent crashes 
when
using undo in tables. Hopefully I narrow it down sooner or later, but the
scenario is along the following lines:

0. Load the attached file.
1. "Some" random editing (also involing undo),
   this step is the "dificult" part of reproducibility,
   but I was capable to couple crashes within few minutes...
2. Go to the most right-top cell and choose via context
   menu and choose Column/Rows->Append row
3. Undo
4. Kaboom

Backtrace:
Thread 1 "lyx" received signal SIGSEGV, Segmentation fault.
lyx::CursorSlice::paragraph (this=) at CursorSlice.cpp:59
59  return text()->getPar(pit_);
(gdb) bt
#0  lyx::CursorSlice::paragraph (this=) at CursorSlice.cpp:59
#1  0x55775214 in lyx::DocIterator::paragraph 
(this=this@entry=0x56e79310) at DocIterator.cpp:204
#2  0x557752e0 in lyx::DocIterator::lastpos 
(this=this@entry=0x56e79310) at DocIterator.cpp:270
#3  0x5575c23e in lyx::CursorData::checkNewWordPosition 
(this=0x56e791f8) at Cursor.cpp:469
#4  0x5575c47c in lyx::CursorData::textUndo 
(this=this@entry=0x56e791f8) at Cursor.cpp:549
#5  0x558f705b in lyx::BufferView::dispatch 
(this=this@entry=0x56e78cd0, cmd=..., dr=...) at BufferView.cpp:1390
#6  0x55b5e9f2 in lyx::frontend::GuiView::dispatchToBufferView 
(this=0x56a07500, cmd=..., dr=...) at GuiView.cpp:3592
#7  0x55b72966 in lyx::frontend::GuiView::dispatch 
(this=0x56a07500, cmd=..., dr=...) at GuiView.cpp:4255
#8  0x55b3b804 in lyx::frontend::GuiApplication::dispatch 
(this=0x566af5f0, cmd=..., dr=...) at GuiApplication.cpp:2061
#9  0x55b34b54 in lyx::frontend::GuiApplication::dispatch 
(this=0x566af5f0, cmd=...) at GuiApplication.cpp:1402
#10 0x55b350b3 in lyx::frontend::GuiApplication::processKeySym 
(this=0x566af5f0, keysym=..., state=) at 
GuiApplication.cpp:2254
#11 0x55b8547f in lyx::frontend::GuiWorkArea::processKeySym 
(this=, key=..., mod=) at GuiWorkArea.cpp:516
#12 0x55b8866f in lyx::frontend::GuiWorkArea::qt_static_metacall 
(_o=0x56b03850, _c=, _id=, _a=) at moc_GuiWorkArea.cpp:124
#13 0x767cc5e9 in QMetaObject::activate(QObject*, int, int, void**) () 
from /usr/lib/x86_64-linux-gnu/libQt5Core.so.5
#14 0x55b84663 in lyx::frontend::CompressorProxy::signal 
(this=this@entry=0x56e78740, _t1=..., _t2=, 
_t2@entry=lyx::ControlModifier) at moc_GuiWorkArea.cpp:362
#15 0x55b87f71 in lyx::frontend::CompressorProxy::slot 
(this=0x56e78740, sym=..., mod=lyx::ControlModifier, 
isAutoRepeat=) at GuiWorkArea.cpp:1064
#16 0x55b887d6 in lyx::frontend::CompressorProxy::qt_static_metacall 
(_o=0x56e78740, _c=, _id=, _a=) at moc_GuiWorkArea.cpp:306

Pavel
#LyX 2.4 created this file. For more info see https://www.lyx.org/
\lyxformat 544
\begin_document
\begin_header
\save_transient_properties true
\origin unavailable
\textclass article
\use_default_options false
\maintain_unincluded_children false
\language english
\language_package default
\inputencoding auto
\fontencoding global
\font_roman "lmodern" "default"
\font_sans "lmss" "default"
\font_typewriter "lmtt" "default"
\font_math "auto" "auto"
\font_default_family default
\use_non_tex_fonts false
\font_sc false
\font_osf false
\font_sf_scale 100 100
\font_tt_scale 100 100
\use_microtype false
\use_dash_ligatures true
\graphics default
\default_output_format default
\output_sync 0
\bibtex_command default
\index_command default
\paperfontsize default
\spacing single
\use_hyperref false
\papersize default
\use_geometry false
\use_package amsmath 1
\use_package amssymb 1
\use_package cancel 1
\use_package esint 1
\use_package mathdots 0
\use_package mathtools 1
\use_package mhchem 1
\use_package stackrel 1
\use_package stmaryrd 1
\use_package undertilde 1
\cite_engine basic
\cite_engine_type default
\biblio_style plain
\use_bibtopic false
\use_indices false
\paperorientation portrait
\suppress_date false
\justification true
\use_refstyle 0
\use_minted 0
\index Index
\shortcut idx
\color #008000
\end_index
\secnumdepth 3
\tocdepth 3
\paragraph_separation indent
\paragraph_indentation default
\is_math_indent 0
\math_numbering_side default
\quotes_style english
\dynamic_quotes 0
\papercolumns 1
\papersides 1
\paperpagestyle default
\tracking_changes false
\output_changes false
\html_math_output 0
\html_css_as_file 0
\html_be_strict false
\end_header

\begin_body

\begin_layout Standard
\begin_inset Tabular








\begin_inset Text

\begin_layout Plain Layout
d
\end_layout

\end_inset


\begin_inset Text

\begin_layout Plain Layout
asdasd
\end_layout

\end_inset


\begin_inset Text

\begin_layout Plain Layout
asdasd
\end_layout

\end_inset


\begin_inset Text

\begin_layout Plain Layout
ASAS
\end_layout

\end_inset




\begin_inset Text

\begin_layout Plain Layout
a
\end_layout

\end_inset


\begin_inset Text

\begin_layout Plain Layout

Re: [RFC][PATCH] native file dialogs

[Jean-Marc Lasgouttes]

Le 30/01/2018 à 16:33, José Abílio Matos a écrit :
One option that I thought about it sometimes is the removal of the 
native file dialogs and the placement in the Help menu of an entry that 
would allow to open the file picker for Examples. Because, at least to 
me, Examples conceptually belong to Help and not to File.


You mean _custom_ file dialogs, right?

JMarc

Re: [RFC][PATCH] native file dialogs

[José Abílio Matos]

On Tuesday, 30 January 2018 14.53.45 WET Pavel Sanda wrote:
> I use them sometimes, but can't say whether it's because of real usage or
> devel activities... P

Me too. :-)

I think that the question regarding the usefulness of the those dialogs could 
get a 
better feedback on the users list. If not for other reason for the fact that 
most of us on 
this list are tainted.

One option that I thought about it sometimes is the removal of the native file 
dialogs 
and the placement in the Help menu of an entry that would allow to open the 
file 
picker for Examples. Because, at least to me, Examples conceptually belong to 
Help 
and not to File.

Regards,
-- 
José Abílio

Re: [RFC][PATCH] native file dialogs

[Pavel Sanda]

Jean-Marc Lasgouttes wrote:
> Does somebody use the custom Documents/Examples buttons? Are they really 
> needed?

I use them sometimes, but can't say whether it's because of real usage or
devel activities... P

Re: [RFC][PATCH] native file dialogs

[Jean-Pierre Chrétien]

Le 30/01/2018 à 15:01, Jean-Marc Lasgouttes a écrit :


Does somebody use the custom Documents/Examples buttons? Are they really needed?


I use these two quite often (more frequently examples), but my use of LyX is 
mostly for translations.


--
Jean-Pierre

[RFC][PATCH] native file dialogs

[Jean-Marc Lasgouttes]

Currently native file dialogs are used on windows and Mac. It is 
possible to select them on unix with cmake, but not autoconf.


The following patch allows to select the type of file dialog at runtime 
(see ticket http://www.lyx.org/trac/ticket/11003 for why I am doing that).


Currently all platforms default to true (native). Where can we go from 
there? Ideas:


1/ apply this patch, maybe with a default of "false" and value "true" 
set in mac and windows lyxrc.dist files. This would give us the same 
behavior as before, but configurable


2/ the same, but also add a 100th checkbox to our crowded preference 
dialog so that people can toggle it at ease


3/ remove support for our custom file dialog and always use the native 
one (this would lose the Document/Example buttons)


4/  remove support for our custom file dialog and always use the Qt 
custom file dialog, and try to make setSidebarUrl work, so that we have 
our Documents/Examples links in the side bar; this cannot work with a 
native file dialog.


Does somebody use the custom Documents/Examples buttons? Are they really 
needed?


JMarc


From 2bf8eecb41c8af81a5988ba032f567936ad99662 Mon Sep 17 00:00:00 2001
From: Jean-Marc Lasgouttes 
Date: Tue, 30 Jan 2018 14:32:53 +0100
Subject: [PATCH] Make it possible to select (not)native file dialogs at run
 time

Add a new LyXRC variable use_native_filedialog (true by default) that
allows to select the kind of FileDialog we want at runtime.
---
 src/LyXRC.cpp|  16 
 src/LyXRC.h  |   3 +
 src/frontends/qt4/FileDialog.cpp | 177 +++
 3 files changed, 106 insertions(+), 90 deletions(-)

diff --git a/src/LyXRC.cpp b/src/LyXRC.cpp
index 9e42857..6a58f34 100644
--- a/src/LyXRC.cpp
+++ b/src/LyXRC.cpp
@@ -195,6 +195,7 @@ LexerKeyword lyxrcTags[] = {
 	{ "\\use_converter_needauth", LyXRC::RC_USE_CONVERTER_NEEDAUTH },
 	{ "\\use_converter_needauth_forbidden", LyXRC::RC_USE_CONVERTER_NEEDAUTH_FORBIDDEN },
 	{ "\\use_lastfilepos", LyXRC::RC_USELASTFILEPOS },
+	{ "\\use_native_filedialog", LyXRC::RC_USE_NATIVE_FILEDIALOG },
 	{ "\\use_pixmap_cache", LyXRC::RC_USE_PIXMAP_CACHE },
 	// compatibility with versions older than 1.4.0 only
 	{ "\\use_system_colors", LyXRC::RC_USE_SYSTEM_COLORS },
@@ -272,6 +273,7 @@ void LyXRC::setDefaults()
 	num_lastfiles = 20;
 	check_lastfiles = true;
 	use_lastfilepos = true;
+	use_native_filedialog = true;
 	load_session = false;
 	make_backup = true;
 	save_compressed = false;
@@ -871,6 +873,9 @@ LyXRC::ReturnValues LyXRC::read(Lexer & lexrc, bool check_format)
 		case RC_ACCEPT_COMPOUND:
 			lexrc >> spellchecker_accept_compound;
 			break;
+		case RC_USE_NATIVE_FILEDIALOG:
+			lexrc >> use_native_filedialog;
+			break;
 		case RC_USE_SYSTEM_COLORS:
 			lexrc >> use_system_colors;
 			break;
@@ -2405,6 +2410,16 @@ void LyXRC::write(ostream & os, bool ignore_system_lyxrc, string const & name) c
 		if (tag != RC_LAST)
 			break;
 		// fall through
+	case RC_USE_NATIVE_FILEDIALOG:
+		if (ignore_system_lyxrc ||
+		use_native_filedialog != system_lyxrc.use_native_filedialog) {
+			os << "\\use_native_filedialog "
+			   << convert(use_native_filedialog)
+			   << '\n';
+		}
+		if (tag != RC_LAST)
+			break;
+		// fall through
 	case RC_USE_SYSTEM_COLORS:
 		if (ignore_system_lyxrc ||
 		use_system_colors != system_lyxrc.use_system_colors) {
@@ -3015,6 +3030,7 @@ void actOnUpdatedPrefs(LyXRC const & lyxrc_orig, LyXRC const & lyxrc_new)
 	case LyXRC::RC_USE_CONVERTER_CACHE:
 	case LyXRC::RC_USE_CONVERTER_NEEDAUTH_FORBIDDEN:
 	case LyXRC::RC_USE_CONVERTER_NEEDAUTH:
+	case LyXRC::RC_USE_NATIVE_FILEDIALOG:
 	case LyXRC::RC_USE_SYSTEM_COLORS:
 	case LyXRC::RC_USE_TOOLTIP:
 	case LyXRC::RC_USE_PIXMAP_CACHE:
diff --git a/src/LyXRC.h b/src/LyXRC.h
index 3da93ac..5376673 100644
--- a/src/LyXRC.h
+++ b/src/LyXRC.h
@@ -172,6 +172,7 @@ public:
 		RC_USE_CONVERTER_CACHE,
 		RC_USE_CONVERTER_NEEDAUTH_FORBIDDEN,
 		RC_USE_CONVERTER_NEEDAUTH,
+		RC_USE_NATIVE_FILEDIALOG,
 		RC_USE_SYSTEM_COLORS,
 		RC_USE_TOOLTIP,
 		RC_USE_PIXMAP_CACHE,
@@ -332,6 +333,8 @@ public:
 	bool use_tooltip;
 	/// Use the colors from current system theme?
 	bool use_system_colors;
+	/// use native file dialog or our own ?
+	bool use_native_filedialog;
 	/// Use pixmap cache?
 	bool use_pixmap_cache;
 	/// Spellchecker engine: aspell, hunspell, etc
diff --git a/src/frontends/qt4/FileDialog.cpp b/src/frontends/qt4/FileDialog.cpp
index f115634..ee5f350 100644
--- a/src/frontends/qt4/FileDialog.cpp
+++ b/src/frontends/qt4/FileDialog.cpp
@@ -16,6 +16,8 @@
 #include "LyXFileDialog.h"
 #include "qt_helpers.h"
 
+#include "LyXRC.h"
+
 #include "support/debug.h"
 #include "support/FileName.h"
 #include "support/filetools.h"
@@ -24,7 +26,9 @@
 
 #include 
 
-/** when this is defined, the code will use
+#include 
+
+/** when LyXRC::use_native_filedialog is true, we use
  * QFileDialog::getOpenFileName and friends to create