[MediaWiki-commits] [Gerrit] mediawiki...Translate[master]: Reorder Translate filters

[jenkins-bot (Code Review)]

jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/393671 )

Change subject: Reorder Translate filters
..


Reorder Translate filters

Reorder the filters as follows:
- Translations
- Site messages
- Not translations

Bug: T159795
Change-Id: I9cea48df95a042926d74baea3fed436a02bbe878
---
M utils/RcFilter.php
1 file changed, 11 insertions(+), 11 deletions(-)

Approvals:
  jenkins-bot: Verified
  Nikerabbit: Looks good to me, approved



diff --git a/utils/RcFilter.php b/utils/RcFilter.php
index de9197b..54e533f 100644
--- a/utils/RcFilter.php
+++ b/utils/RcFilter.php
@@ -144,17 +144,6 @@
'isFullCoverage' => true,
'filters' => [
[
-   'name' => 'filter',
-   'label' => 
'translate-rcfilters-translations-filter-label',
-   'description' => 
'translate-rcfilters-translations-filter-desc',
-   'cssClassSuffix' => 'filter',
-   'isRowApplicableCallable' => 
function ( $ctx, $rc ) {
-   $namespaces = 
self::getTranslateNamespaces();
-
-   return !in_array( 
$rc->getAttribute( 'rc_namespace' ), $namespaces );
-   }
-   ],
-   [
'name' => 'only',
'label' => 
'translate-rcfilters-translations-only-label',
'description' => 
'translate-rcfilters-translations-only-desc',
@@ -178,6 +167,17 @@
strpos( 
$rc->getAttribute( 'rc_title' ), '/' ) === false;
}
],
+   [
+   'name' => 'filter',
+   'label' => 
'translate-rcfilters-translations-filter-label',
+   'description' => 
'translate-rcfilters-translations-filter-desc',
+   'cssClassSuffix' => 'filter',
+   'isRowApplicableCallable' => 
function ( $ctx, $rc ) {
+   $namespaces = 
self::getTranslateNamespaces();
+
+   return !in_array( 
$rc->getAttribute( 'rc_namespace' ), $namespaces );
+   }
+   ],
],
'queryCallable' => function ( 
$specialClassName, $ctx, $dbr, &$tables,
&$fields, &$conds, &$query_options, 
&$join_conds, $selectedValues

-- 
To view, visit https://gerrit.wikimedia.org/r/393671
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I9cea48df95a042926d74baea3fed436a02bbe878
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Translate
Gerrit-Branch: master
Gerrit-Owner: Petar.petkovic 
Gerrit-Reviewer: Nikerabbit 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...ContentTranslation[master]: Prevent empty chart flashing on CX dashboard

[jenkins-bot (Code Review)]

jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/393578 )

Change subject: Prevent empty chart flashing on CX dashboard
..


Prevent empty chart flashing on CX dashboard

- Change appearance behavior of CX stats card:
* Old behavior displays empty stats card in CX dashboard,
which is populated or removed after user statistics are loaded.
* New behavior does not display stats card initially. Stats card is
only displayed if there is data to show.

Bug: T179747
Change-Id: I9080464ce1a5e1ec2e411014f71add1ccf2036ba
---
M modules/dashboard/styles/ext.cx.dashboard.less
M modules/widgets/translator/ext.cx.translator.js
M modules/widgets/translator/ext.cx.translator.less
3 files changed, 10 insertions(+), 1 deletion(-)

Approvals:
  jenkins-bot: Verified
  Nikerabbit: Checked; Looks good to me, approved



diff --git a/modules/dashboard/styles/ext.cx.dashboard.less 
b/modules/dashboard/styles/ext.cx.dashboard.less
index 6affd4e..18bf0eb 100644
--- a/modules/dashboard/styles/ext.cx.dashboard.less
+++ b/modules/dashboard/styles/ext.cx.dashboard.less
@@ -102,7 +102,7 @@
.box-shadow-card;
font-size: 16px;
 
-   .cx-translator ~ & {
+   .cx-translator--visible ~ & {
@media only screen and ( min-width: @narrow ) and ( 
max-width: ( @wide - 1px ) ) {
width: 47.5%;
margin-left: 5%;
diff --git a/modules/widgets/translator/ext.cx.translator.js 
b/modules/widgets/translator/ext.cx.translator.js
index 74ee041..1652cf3 100644
--- a/modules/widgets/translator/ext.cx.translator.js
+++ b/modules/widgets/translator/ext.cx.translator.js
@@ -93,6 +93,10 @@
 
self.$canvas.prop( 'width', self.$widget.width() );
self.draw();
+
+   // Make statistics visible in dashboard sidebar,
+   // after all data is fetched and drawn on canvas
+   self.$widget.addClass( 'cx-translator--visible' );
} ).fail( function () {
self.$widget.remove();
} );
diff --git a/modules/widgets/translator/ext.cx.translator.less 
b/modules/widgets/translator/ext.cx.translator.less
index 3baad07..e5a7c20 100644
--- a/modules/widgets/translator/ext.cx.translator.less
+++ b/modules/widgets/translator/ext.cx.translator.less
@@ -5,6 +5,7 @@
.mw-ui-one-whole;
 
background-color: #fff;
+   display: none;
margin-bottom: 1em;
border-radius: @borderRadius;
padding: 1em;
@@ -14,6 +15,10 @@
width: 47.5%;
margin-bottom: 0;
}
+
+   &--visible {
+   display: block;
+   }
 }
 
 .cx-translator__header {

-- 
To view, visit https://gerrit.wikimedia.org/r/393578
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I9080464ce1a5e1ec2e411014f71add1ccf2036ba
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/ContentTranslation
Gerrit-Branch: master
Gerrit-Owner: Petar.petkovic 
Gerrit-Reviewer: Nikerabbit 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...ContentTranslation[master]: Prevent body color changes

[jenkins-bot (Code Review)]

jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/393666 )

Change subject: Prevent body color changes
..


Prevent body color changes

While CX page is loading, background color is changing from #f6f6f6
to #eaecf0. Prevent color changes by overriding skin default background.

Change-Id: I1beae91d9d41b76f36bea371edd8cdc46780a067
---
M modules/dashboard/styles/ext.cx.dashboard.less
M modules/ui/styles/mw.cx.ui.Header.skin.less
2 files changed, 8 insertions(+), 4 deletions(-)

Approvals:
  jenkins-bot: Verified
  Nikerabbit: Checked; Looks good to me, approved



diff --git a/modules/dashboard/styles/ext.cx.dashboard.less 
b/modules/dashboard/styles/ext.cx.dashboard.less
index 6affd4e..1f24610 100644
--- a/modules/dashboard/styles/ext.cx.dashboard.less
+++ b/modules/dashboard/styles/ext.cx.dashboard.less
@@ -1,10 +1,6 @@
 @import '../../widgets/common/ext.cx.common.less';
 @import 'mediawiki.mixins';
 
-body {
-   background: @colorGray14;
-}
-
 .cx-dashboard {
color: @gray-darker;
max-width: @max-dashboard-width;
diff --git a/modules/ui/styles/mw.cx.ui.Header.skin.less 
b/modules/ui/styles/mw.cx.ui.Header.skin.less
index 7e293ee..d51388e 100644
--- a/modules/ui/styles/mw.cx.ui.Header.skin.less
+++ b/modules/ui/styles/mw.cx.ui.Header.skin.less
@@ -1,3 +1,11 @@
+@import '../../widgets/common/ext.cx.common.less';
+
+body.mw-special-ContentTranslation {
+   // Not using background-color, because we want to override skin 
specific backgrounds,
+   // like on monobook
+   background: @colorGray14;
+}
+
 .client-js .cx-nojs {
display: none;
 }

-- 
To view, visit https://gerrit.wikimedia.org/r/393666
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I1beae91d9d41b76f36bea371edd8cdc46780a067
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/ContentTranslation
Gerrit-Branch: master
Gerrit-Owner: Petar.petkovic 
Gerrit-Reviewer: Nikerabbit 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] translatewiki[master]: [BlueSpice] Remove already deleted subrepo

[Raimond Spekking (Code Review)]

Raimond Spekking has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/393719 )

Change subject: [BlueSpice] Remove already deleted subrepo
..

[BlueSpice] Remove already deleted subrepo

Change-Id: I3c1c1d2a261b59a481b2f929755ac48bc2eeca2c
---
M groups/MediaWiki/mediawiki-extensions.txt
1 file changed, 0 insertions(+), 5 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/translatewiki 
refs/changes/19/393719/1

diff --git a/groups/MediaWiki/mediawiki-extensions.txt 
b/groups/MediaWiki/mediawiki-extensions.txt
index 26645ed..1343bdb 100644
--- a/groups/MediaWiki/mediawiki-extensions.txt
+++ b/groups/MediaWiki/mediawiki-extensions.txt
@@ -182,11 +182,6 @@
 aliasfile = BlueSpiceFoundation/languages/BlueSpice.Credits.alias.php
 id = ext-bs-credits
 
-Blue Spice - Dashboards
-id = ext-bs-dashboards
-descmsg = bs-dashboards-desc
-file = BlueSpiceExtensions/Dashboards/i18n/%CODE%.json
-
 Blue Spice - Deferred
 id = ext-bs-deferred
 file = BlueSpiceFoundation/i18n/deferred/%CODE%.json

-- 
To view, visit https://gerrit.wikimedia.org/r/393719
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I3c1c1d2a261b59a481b2f929755ac48bc2eeca2c
Gerrit-PatchSet: 1
Gerrit-Project: translatewiki
Gerrit-Branch: master
Gerrit-Owner: Raimond Spekking 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] translatewiki[master]: [BlueSpice] Remove already deleted subrepo

[Raimond Spekking (Code Review)]

Raimond Spekking has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/393719 )

Change subject: [BlueSpice] Remove already deleted subrepo
..


[BlueSpice] Remove already deleted subrepo

Change-Id: I3c1c1d2a261b59a481b2f929755ac48bc2eeca2c
---
M groups/MediaWiki/mediawiki-extensions.txt
1 file changed, 0 insertions(+), 5 deletions(-)

Approvals:
  Raimond Spekking: Verified; Looks good to me, approved



diff --git a/groups/MediaWiki/mediawiki-extensions.txt 
b/groups/MediaWiki/mediawiki-extensions.txt
index 26645ed..1343bdb 100644
--- a/groups/MediaWiki/mediawiki-extensions.txt
+++ b/groups/MediaWiki/mediawiki-extensions.txt
@@ -182,11 +182,6 @@
 aliasfile = BlueSpiceFoundation/languages/BlueSpice.Credits.alias.php
 id = ext-bs-credits
 
-Blue Spice - Dashboards
-id = ext-bs-dashboards
-descmsg = bs-dashboards-desc
-file = BlueSpiceExtensions/Dashboards/i18n/%CODE%.json
-
 Blue Spice - Deferred
 id = ext-bs-deferred
 file = BlueSpiceFoundation/i18n/deferred/%CODE%.json

-- 
To view, visit https://gerrit.wikimedia.org/r/393719
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I3c1c1d2a261b59a481b2f929755ac48bc2eeca2c
Gerrit-PatchSet: 1
Gerrit-Project: translatewiki
Gerrit-Branch: master
Gerrit-Owner: Raimond Spekking 
Gerrit-Reviewer: Raimond Spekking 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] translatewiki[master]: [FileExporter, FileImporter] Deployed on Beta

[Raimond Spekking (Code Review)]

Raimond Spekking has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/393718 )

Change subject: [FileExporter, FileImporter] Deployed on Beta
..


[FileExporter, FileImporter] Deployed on Beta

https://phabricator.wikimedia.org/rOMWCed0953cf03e16621029ba7b21b716d448e387de0

Change-Id: Iee947d772c33b7806ab0b8c2dd8d6653ef10af70
---
M groups/MediaWiki/WikimediaAgg.yaml
1 file changed, 2 insertions(+), 0 deletions(-)

Approvals:
  Raimond Spekking: Verified; Looks good to me, approved



diff --git a/groups/MediaWiki/WikimediaAgg.yaml 
b/groups/MediaWiki/WikimediaAgg.yaml
index 3e75203..baf7030 100644
--- a/groups/MediaWiki/WikimediaAgg.yaml
+++ b/groups/MediaWiki/WikimediaAgg.yaml
@@ -46,6 +46,8 @@
   - ext-eventbus # 2016-01-21 for MediaWiki.org, change id: 
603461016bd9a4cc862f4713fd57358b0cd38f2d
   - ext-eventlogging # Change-Id: 1fc99b92c1692515295e8c7bb7c757112531c330
   - ext-extensiondistributor # MediaWiki.org
+  - ext-fileexporter # 
https://phabricator.wikimedia.org/rOMWCed0953cf03e16621029ba7b21b716d448e387de0
+  - ext-fileimporter # 
https://phabricator.wikimedia.org/rOMWCed0953cf03e16621029ba7b21b716d448e387de0
   - ext-flaggedrevs-0-all
   - ext-flow-api
   - ext-fundraiserlandingpage # r101409 for donatewiki

-- 
To view, visit https://gerrit.wikimedia.org/r/393718
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Iee947d772c33b7806ab0b8c2dd8d6653ef10af70
Gerrit-PatchSet: 1
Gerrit-Project: translatewiki
Gerrit-Branch: master
Gerrit-Owner: Raimond Spekking 
Gerrit-Reviewer: Raimond Spekking 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] translatewiki[master]: [FileExporter, FileImporter] Deployed on Beta

[Raimond Spekking (Code Review)]

Raimond Spekking has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/393718 )

Change subject: [FileExporter, FileImporter] Deployed on Beta
..

[FileExporter, FileImporter] Deployed on Beta

https://phabricator.wikimedia.org/rOMWCed0953cf03e16621029ba7b21b716d448e387de0

Change-Id: Iee947d772c33b7806ab0b8c2dd8d6653ef10af70
---
M groups/MediaWiki/WikimediaAgg.yaml
1 file changed, 2 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/translatewiki 
refs/changes/18/393718/1

diff --git a/groups/MediaWiki/WikimediaAgg.yaml 
b/groups/MediaWiki/WikimediaAgg.yaml
index 3e75203..baf7030 100644
--- a/groups/MediaWiki/WikimediaAgg.yaml
+++ b/groups/MediaWiki/WikimediaAgg.yaml
@@ -46,6 +46,8 @@
   - ext-eventbus # 2016-01-21 for MediaWiki.org, change id: 
603461016bd9a4cc862f4713fd57358b0cd38f2d
   - ext-eventlogging # Change-Id: 1fc99b92c1692515295e8c7bb7c757112531c330
   - ext-extensiondistributor # MediaWiki.org
+  - ext-fileexporter # 
https://phabricator.wikimedia.org/rOMWCed0953cf03e16621029ba7b21b716d448e387de0
+  - ext-fileimporter # 
https://phabricator.wikimedia.org/rOMWCed0953cf03e16621029ba7b21b716d448e387de0
   - ext-flaggedrevs-0-all
   - ext-flow-api
   - ext-fundraiserlandingpage # r101409 for donatewiki

-- 
To view, visit https://gerrit.wikimedia.org/r/393718
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Iee947d772c33b7806ab0b8c2dd8d6653ef10af70
Gerrit-PatchSet: 1
Gerrit-Project: translatewiki
Gerrit-Branch: master
Gerrit-Owner: Raimond Spekking 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...MultiLanguageManager[master]: Added more information into the composer.json

[jenkins-bot (Code Review)]

jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/393030 )

Change subject: Added more information into the composer.json
..


Added more information into the composer.json

Change-Id: If5e8e21644fff75b585ff7f832f62e84b3adc23a
---
M composer.json
1 file changed, 6 insertions(+), 0 deletions(-)

Approvals:
  Robert Vogel: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/composer.json b/composer.json
index b9b4f42..c61212a 100644
--- a/composer.json
+++ b/composer.json
@@ -1,4 +1,10 @@
 {
+   "name": "mediawiki/multi-language-manager",
+   "type": "mediawiki-extension",
+   "description": "Provides linking articles as translations",
+   "require": {
+   "composer/installers": "~1.0"
+   },
"autoload": {
"psr-4": {
"MultiLanguageManager\\Tests\\": "tests/phpunit",

-- 
To view, visit https://gerrit.wikimedia.org/r/393030
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: If5e8e21644fff75b585ff7f832f62e84b3adc23a
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/MultiLanguageManager
Gerrit-Branch: master
Gerrit-Owner: Pwirth 
Gerrit-Reviewer: Robert Vogel 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] operations/puppet[production]: mariadb: Reimage db1099

[Marostegui (Code Review)]

Marostegui has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/393717 )

Change subject: mariadb: Reimage db1099
..


mariadb: Reimage db1099

Given that we are not going to do the failover soon, let's take the
opportunity to keep building the proper rc multi-instance slaves for s5
and s8 which we were not planning on doing as we didn't have time before
the failover.

Bug: T178359
Change-Id: I7425c3e4d0732c5a3d702bd1699e51e7d69ece26
---
M hieradata/hosts/db1099.yaml
M modules/install_server/files/autoinstall/netboot.cfg
M modules/install_server/files/dhcpd/linux-host-entries.ttyS1-115200
3 files changed, 4 insertions(+), 1 deletion(-)

Approvals:
  Marostegui: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/hieradata/hosts/db1099.yaml b/hieradata/hosts/db1099.yaml
index 3ecb13a..8b1f532 100644
--- a/hieradata/hosts/db1099.yaml
+++ b/hieradata/hosts/db1099.yaml
@@ -1 +1,2 @@
 mariadb::shard: 's8'
+profile::base::notifications_enabled: '0'
diff --git a/modules/install_server/files/autoinstall/netboot.cfg 
b/modules/install_server/files/autoinstall/netboot.cfg
index fa06ae1..bdd60b5 100755
--- a/modules/install_server/files/autoinstall/netboot.cfg
+++ b/modules/install_server/files/autoinstall/netboot.cfg
@@ -64,7 +64,7 @@
 conf200[123]) echo partman/raid1-lvm-ext4-srv.cfg ;; \
 cp1008|cp300[3-9]|cp3010) echo partman/varnish-oldssd.cfg ;; \
 cp[12345][0-9][0-9][0-9]) echo partman/varnish.cfg ;; \
-db1109|db111[0-9]) echo partman/db.cfg ;; \
+db1099|db1109|db111[0-9]) echo partman/db.cfg ;; \
 db207[1-9]|db208[0-9]|db209[0-2]) echo partman/db.cfg ;; \
 db[12][01][0-9][0-9]|dbstore[12]00[1-9]|es[12]01[1-9]) echo 
partman/db-no-srv-format.cfg ;; \
 deploy[12]001|flerovium|furud) echo 
partman/raid1-lvm-ext4-srv-noswap.cfg;; \
diff --git a/modules/install_server/files/dhcpd/linux-host-entries.ttyS1-115200 
b/modules/install_server/files/dhcpd/linux-host-entries.ttyS1-115200
index bbdf0e6..e1ac3bb 100644
--- a/modules/install_server/files/dhcpd/linux-host-entries.ttyS1-115200
+++ b/modules/install_server/files/dhcpd/linux-host-entries.ttyS1-115200
@@ -1231,6 +1231,8 @@
 host db1099 {
 hardware ethernet 18:66:DA:F8:D4:F4;
 fixed-address db1099.eqiad.wmnet;
+option pxelinux.pathprefix "stretch-installer/";
+filename "stretch-installer/debian-installer/amd64/pxelinux.0";
 }
 
 host db1100 {

-- 
To view, visit https://gerrit.wikimedia.org/r/393717
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I7425c3e4d0732c5a3d702bd1699e51e7d69ece26
Gerrit-PatchSet: 2
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Marostegui 
Gerrit-Reviewer: Jcrespo 
Gerrit-Reviewer: Marostegui 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] operations/puppet[production]: mariadb: Reimage db1099

[Marostegui (Code Review)]

Marostegui has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/393717 )

Change subject: mariadb: Reimage db1099
..

mariadb: Reimage db1099

Given that we are not going to do the failover soon, let's take the
opportunity to keep building the proper rc multi-instance slaves for s5
and s8 which we were not planning on doing as we didn't have time before
the failover.

Bug: T178359
Change-Id: I7425c3e4d0732c5a3d702bd1699e51e7d69ece26
---
M hieradata/hosts/db1099.yaml
M modules/install_server/files/dhcpd/linux-host-entries.ttyS1-115200
2 files changed, 3 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/operations/puppet 
refs/changes/17/393717/1

diff --git a/hieradata/hosts/db1099.yaml b/hieradata/hosts/db1099.yaml
index 3ecb13a..8b1f532 100644
--- a/hieradata/hosts/db1099.yaml
+++ b/hieradata/hosts/db1099.yaml
@@ -1 +1,2 @@
 mariadb::shard: 's8'
+profile::base::notifications_enabled: '0'
diff --git a/modules/install_server/files/dhcpd/linux-host-entries.ttyS1-115200 
b/modules/install_server/files/dhcpd/linux-host-entries.ttyS1-115200
index bbdf0e6..e1ac3bb 100644
--- a/modules/install_server/files/dhcpd/linux-host-entries.ttyS1-115200
+++ b/modules/install_server/files/dhcpd/linux-host-entries.ttyS1-115200
@@ -1231,6 +1231,8 @@
 host db1099 {
 hardware ethernet 18:66:DA:F8:D4:F4;
 fixed-address db1099.eqiad.wmnet;
+option pxelinux.pathprefix "stretch-installer/";
+filename "stretch-installer/debian-installer/amd64/pxelinux.0";
 }
 
 host db1100 {

-- 
To view, visit https://gerrit.wikimedia.org/r/393717
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I7425c3e4d0732c5a3d702bd1699e51e7d69ece26
Gerrit-PatchSet: 1
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Marostegui 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...Flow[master]: Unify BetaFeatures SVG screenshot markup

[VolkerE (Code Review)]

VolkerE has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/393716 )

Change subject: Unify BetaFeatures SVG screenshot markup
..

Unify BetaFeatures SVG screenshot markup

Unifying BetaFeatures SVG screenshot markup by:
- adding/changing `id`s for better readability,
- sorting attributes,
- using full pixel values where applicable and
- generalizing attributes on `g` where applicable.

Follows up I1dc546a0df52ce9b0885d92b29a7c638ef618025.

Bug: T180427
Change-Id: I318494488c8caad842a2d0dd93e7353f8d05b08e
---
M images/betafeature-flow-ltr.svg
M images/betafeature-flow-rtl.svg
2 files changed, 29 insertions(+), 27 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Flow 
refs/changes/16/393716/1

diff --git a/images/betafeature-flow-ltr.svg b/images/betafeature-flow-ltr.svg
index da2d3d6..df0bc21 100644
--- a/images/betafeature-flow-ltr.svg
+++ b/images/betafeature-flow-ltr.svg
@@ -1,19 +1,21 @@
 
 http://www.w3.org/2000/svg; width="264" height="162" viewBox="0 0 
264 162">
-  
-
-  
-
-  
-  
-
-
-
-  
-  
-
-
-
-
-  
+   
+   
+   
+   
+   
+   
+   
+   
+   
+   
+   
+   
+   
+   
+   
+   
+   
+   
 
diff --git a/images/betafeature-flow-rtl.svg b/images/betafeature-flow-rtl.svg
index d4d6e3a..3848e51 100644
--- a/images/betafeature-flow-rtl.svg
+++ b/images/betafeature-flow-rtl.svg
@@ -1,20 +1,20 @@
 
 http://www.w3.org/2000/svg; width="264" height="162" viewBox="0 0 
264 162">

-   
+   



-   
-   
-   
-   
-   
-   
-   
+   
+   
+   
+   
+   
+   
+   

-   
-   
-   
+   
+   
+   

 

-- 
To view, visit https://gerrit.wikimedia.org/r/393716
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I318494488c8caad842a2d0dd93e7353f8d05b08e
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Flow
Gerrit-Branch: master
Gerrit-Owner: VolkerE 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...ContentTranslation[master]: Make dump-corpora.php streaming to reduce memory usage

[jenkins-bot (Code Review)]

jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/393212 )

Change subject: Make dump-corpora.php streaming to reduce memory usage
..


Make dump-corpora.php streaming to reduce memory usage

== Test script ==
mkdir -p test/{a,b,c,d,e,f,g,h}
php dump-corpora.php  --plaintext --format=json --outputdir=test/a
php dump-corpora.php  --plaintext --format=tmx  --outputdir=test/b
php dump-corpora.php  --format=json --outputdir=test/c

php dump-corpora.php --source-language=fi --outputdir=test/d
php dump-corpora.php --target-language=fi --outputdir=test/e

php dump-corpora.php --split-at=10 --outputdir=test/f
php dump-corpora.php --split-at=1  --outputdir=test/g
php dump-corpora.php --split-at=1 --target-language=fi --outputdir=test/h

== Differences ==
a,c-e are identical

=== b ===
TMX output differs slightly because " are turned into entities now in TMX format

=== f ===
The files are little bit different now:
new/f:
cx-corpora._2fi.html.json  cx-corpora._2_.html.json  cx-corpora.fi2en.html.json

old/f:
cx-corpora._2_.html.json  cx-corpora.fi2en.html.json

But the contents are the same (few bytes difference comes from the json 
begin/end)
du -cs {old,new}/f
10112   old/f
10116   new/f

=== g ===
g is simlar to f:

new/g:
cx-corpora.de2eo.html.json  cx-corpora.en2la.html.json  
cx-corpora.et2fi.html.json
cx-corpora.de2fi.html.json  cx-corpora.en2nb.html.json  
cx-corpora.fi2en.html.json
cx-corpora.en2cy.html.json  cx-corpora.en2pt.html.json  
cx-corpora.fi2se.html.json
cx-corpora.en2de.html.json  cx-corpora.en2ru.html.json  
cx-corpora.he2ca.html.json
cx-corpora.en2es.html.json  cx-corpora.en2yi.html.json  
cx-corpora.no2nn.html.json
cx-corpora.en2fi.html.json  cx-corpora.es2ca.html.json  
cx-corpora.pt2en.html.json

old/g:
cx-corpora.de2fi.html.json  cx-corpora.en2nb.html.json  
cx-corpora.fi2en.html.json
cx-corpora.en2cy.html.json  cx-corpora.en2pt.html.json  
cx-corpora.fi2se.html.json
cx-corpora.en2de.html.json  cx-corpora.en2ru.html.json  
cx-corpora.he2ca.html.json
cx-corpora.en2es.html.json  cx-corpora.en2yi.html.json  
cx-corpora.no2nn.html.json
cx-corpora.en2fi.html.json  cx-corpora.es2ca.html.json  
cx-corpora.pt2en.html.json
cx-corpora.en2la.html.json  cx-corpora.et2fi.html.json

But again the contents are the same: du -cs {old,new}/g
10144   old/g
10148   new/g

In addition this command shows that every unique ID exists twice, which means 
that
assuming there are no bugs that cause duplicate IDs in the output, both old and
new export exactly the same set of units:
cat -u {old,new}/g/* | grep '"id"' | sort | uniq -c | sort -r

== Benchmarks ==
For JSON format:
for i in {0..10}; do \time -v php dump-corpora.php 2>> timings-json; done;

For TMX format:
for i in {0..10}; do \time -v php dump-corpora.php --format=tmx --plaintext 2>> 
timings-tmx; done;

Main findings:
For JSON format the runtime was about equivalent (too small dataset, too much 
variance).
For JSON format the Maximum resident size went down from ~160M to ~134M.
For TMX format the runtime was about equivalent (too small dataset, too much 
variance).
For TMX format the Maximum resident size was unchanged at ~121M.

Bug: T180264
Change-Id: Ia2c26c82b70197672fde497875b7458865631bfc
---
M extension.json
A includes/JsonDumpFormatter.php
A includes/TmxDumpFormatter.php
M includes/Translation.php
M includes/Translator.php
M scripts/dump-corpora.php
6 files changed, 393 insertions(+), 288 deletions(-)

Approvals:
  jenkins-bot: Verified
  Santhosh: Looks good to me, approved



diff --git a/extension.json b/extension.json
index 78c283f..c33c1a8 100644
--- a/extension.json
+++ b/extension.json
@@ -88,6 +88,7 @@
"ContentTranslation\\Database": "includes/Database.php",
"ContentTranslation\\DateManipulator": 
"includes/DateManipulator.php",
"ContentTranslation\\EchoNotificationPresentationModel": 
"includes/EchoNotificationPresentationModel.php",
+   "ContentTranslation\\JsonDumpFormatter": 
"includes/JsonDumpFormatter.php",
"ContentTranslation\\Notification": "includes/Notification.php",
"ContentTranslation\\RestbaseClient": 
"includes/RestbaseClient.php",
"ContentTranslation\\SiteMapper": "includes/SiteMapper.php",
@@ -95,6 +96,7 @@
"ContentTranslation\\Suggestion": "includes/Suggestion.php",
"ContentTranslation\\SuggestionList": 
"includes/SuggestionList.php",
"ContentTranslation\\SuggestionListManager": 
"includes/SuggestionListManager.php",
+   "ContentTranslation\\TmxDumpFormatter": 
"includes/TmxDumpFormatter.php",
"ContentTranslation\\Translation": "includes/Translation.php",
"ContentTranslation\\TranslationStorageManager": 
"includes/TranslationStorageManager.php",
"ContentTranslation\\TranslationUnit": 

[MediaWiki-commits] [Gerrit] wikimedia-ui-base[master]: Replace repetitive comment about breakpoint values with sing...

[jenkins-bot (Code Review)]

jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/390363 )

Change subject: Replace repetitive comment about breakpoint values with single 
one
..


Replace repetitive comment about breakpoint values with single one

Change-Id: Id92c426ebd3bb0f4c1a81c7f4be87a51e2ccffee
---
M wikimedia-ui-base.css
M wikimedia-ui-base.less
2 files changed, 9 insertions(+), 28 deletions(-)

Approvals:
  jenkins-bot: Verified
  VolkerE: Looks good to me, approved



diff --git a/wikimedia-ui-base.css b/wikimedia-ui-base.css
index 10ca2ce..3209a8b 100644
--- a/wikimedia-ui-base.css
+++ b/wikimedia-ui-base.css
@@ -5,36 +5,28 @@
 
 :root {
/* == Breakpoints == */
+   /* The following numbers are prone to change with new information. */
+
/**
 * Minimum available screen width at which a device can be considered a 
mobile device
 * Many older feature phones have screens smaller than this value.
-* Number is prone to change with new information.
 */
--width-breakpoint-mobile: 320px;
 
/**
 * Minimum available screen width at which a device can be considered a 
tablet
 * The number is currently based on the device width of a Samsung 
Galaxy S5 mini and is low
-* enough to cover iPad (768px). Number is prone to change with new 
information.
+* enough to cover iPad (768px).
 */
--width-breakpoint-tablet: 720px;
 
-   /**
-* Minimum available screen width at which a device can be considered a 
desktop
-* Number is prone to change with new information.
-*/
+   /* Minimum available screen width at which a device can be considered a 
desktop */
--width-breakpoint-desktop: 1000px;
 
-   /**
-* Wider desktop breakpoint, currently used in Flow.
-* Number is prone to change with new information.
-*/
+   /* Wider desktop breakpoint, currently used in Flow. */
--width-breakpoint-desktop-wide: 1200px;
 
-   /**
-* Extra wide desktop breakpoint
-* Number is prone to change with new information.
-*/
+   /* Extra wide desktop breakpoint */
--width-breapoint-desktop-extrawide: 2000px;
 
 
diff --git a/wikimedia-ui-base.less b/wikimedia-ui-base.less
index 7976e62..572013b 100644
--- a/wikimedia-ui-base.less
+++ b/wikimedia-ui-base.less
@@ -4,35 +4,24 @@
  */
 
 // == Breakpoints ==
+// The following numbers are prone to change with new information.
+
 // Minimum available screen width at which a device can be considered a mobile 
device
 // Many older feature phones have screens smaller than this value.
-// Number is prone to change with new information.
-
 @width-breakpoint-mobile: 320px;
-
 
 // Minimum available screen width at which a device can be considered a tablet
 // The number is currently based on the device width of a Samsung Galaxy S5 
mini and is low
-// enough to cover iPad (768px). Number is prone to change with new 
information.
-
+// enough to cover iPad (768px).
 @width-breakpoint-tablet: 720px;
 
-
 // Minimum available screen width at which a device can be considered a desktop
-// Number is prone to change with new information.
-
 @width-breakpoint-desktop: 1000px;
 
-
 // Wider desktop breakpoint, currently used in Flow.
-// Number is prone to change with new information.
-
 @width-breakpoint-desktop-wide: 1200px;
 
-
 // Extra wide desktop breakpoint
-// Number is prone to change with new information.
-
 @width-breapoint-desktop-extrawide: 2000px;
 
 

-- 
To view, visit https://gerrit.wikimedia.org/r/390363
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Id92c426ebd3bb0f4c1a81c7f4be87a51e2ccffee
Gerrit-PatchSet: 3
Gerrit-Project: wikimedia-ui-base
Gerrit-Branch: master
Gerrit-Owner: Prtksxna 
Gerrit-Reviewer: Jforrester 
Gerrit-Reviewer: VolkerE 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...Popups[master]: Unify BetaFeatures SVG screenshot markup

[VolkerE (Code Review)]

VolkerE has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/393715 )

Change subject: Unify BetaFeatures SVG screenshot markup
..

Unify BetaFeatures SVG screenshot markup

Unifying BetaFeatures SVG screenshot markup by:
- adding/changing `id`s for better readability,
- sorting attributes,
- using full pixel values where applicable and
- generalizing attributes on `g` where applicable.

Follows up I91e0495e922a1fcf094af14e424a410fad313ba0.

Bug: T180427
Change-Id: Id5acd5e918dfa895210a622612f4a1cda5bef985
---
M images/popups-ltr.svg
M images/popups-rtl.svg
2 files changed, 56 insertions(+), 50 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Popups 
refs/changes/15/393715/1

diff --git a/images/popups-ltr.svg b/images/popups-ltr.svg
index 35ab989..9ddb50f 100644
--- a/images/popups-ltr.svg
+++ b/images/popups-ltr.svg
@@ -1,34 +1,37 @@
 
 http://www.w3.org/2000/svg; width="264" height="162" viewBox="0 0 
264 162">

-   
+   



-   
-   
-   
-   
-   
-   
-   
-   
-   
-   
-   
-   
-   
-   
-   
-   
-   
-   
-   
-   
-   
-   
-   
-   
+   
+
+
+
+
+
+
+
+
+
+
+
+   
+   
+   
+   
+   
+   
+   
+   
+   
+   
+   
+   
+   
+   
+   


 
diff --git a/images/popups-rtl.svg b/images/popups-rtl.svg
index 5f21e0a..905347a 100644
--- a/images/popups-rtl.svg
+++ b/images/popups-rtl.svg
@@ -1,34 +1,37 @@
 
 http://www.w3.org/2000/svg; width="264" height="162" viewBox="0 0 
264 162">

-   
+   



-   
-   
-   
-   
-   
-   
-   
-   
-   
-   
-   
-   
-   
-   
-   
-   
-   
-   
-   
-   
-   
-   
-   
-   
+   
+
+
+
+
+
+
+
+
+
+
+
+   
+   
+   
+   
+   
+   
+   
+   
+   
+   
+   
+   
+   
+   
+   


 

-- 
To view, visit https://gerrit.wikimedia.org/r/393715
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Id5acd5e918dfa895210a622612f4a1cda5bef985
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Popups
Gerrit-Branch: master
Gerrit-Owner: VolkerE 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] operations/puppet[production]: silver (wikitech): remove ganglia

[Dzahn (Code Review)]

Dzahn has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/393714 )

Change subject: silver (wikitech): remove ganglia
..


silver (wikitech): remove ganglia

This needs an extra setting since it's not using any
of the mw appserver roles anymore. (or it would have been
covered when ganglia was removed from appservers)

Change-Id: I0a94c4074e0c43f93cf1d379bf6c2622f00ee027
---
M hieradata/role/eqiad/wmcs/openstack/main/wikitech.yaml
1 file changed, 1 insertion(+), 0 deletions(-)

Approvals:
  jenkins-bot: Verified
  Dzahn: Looks good to me, approved



diff --git a/hieradata/role/eqiad/wmcs/openstack/main/wikitech.yaml 
b/hieradata/role/eqiad/wmcs/openstack/main/wikitech.yaml
index bb340dd..7aec360 100644
--- a/hieradata/role/eqiad/wmcs/openstack/main/wikitech.yaml
+++ b/hieradata/role/eqiad/wmcs/openstack/main/wikitech.yaml
@@ -1,3 +1,4 @@
 ---
 admin::groups:
   - wmcs-roots
+standard::has_ganglia: false

-- 
To view, visit https://gerrit.wikimedia.org/r/393714
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I0a94c4074e0c43f93cf1d379bf6c2622f00ee027
Gerrit-PatchSet: 1
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Dzahn 
Gerrit-Reviewer: Dzahn 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] operations/puppet[production]: silver (wikitech): remove ganglia

[Dzahn (Code Review)]

Dzahn has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/393714 )

Change subject: silver (wikitech): remove ganglia
..

silver (wikitech): remove ganglia

This needs an extra setting since it's not using any
of the mw appserver roles anymore. (or it would have been
covered when ganglia was removed from appservers)

Change-Id: I0a94c4074e0c43f93cf1d379bf6c2622f00ee027
---
M hieradata/role/eqiad/wmcs/openstack/main/wikitech.yaml
1 file changed, 1 insertion(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/operations/puppet 
refs/changes/14/393714/1

diff --git a/hieradata/role/eqiad/wmcs/openstack/main/wikitech.yaml 
b/hieradata/role/eqiad/wmcs/openstack/main/wikitech.yaml
index bb340dd..7aec360 100644
--- a/hieradata/role/eqiad/wmcs/openstack/main/wikitech.yaml
+++ b/hieradata/role/eqiad/wmcs/openstack/main/wikitech.yaml
@@ -1,3 +1,4 @@
 ---
 admin::groups:
   - wmcs-roots
+standard::has_ganglia: false

-- 
To view, visit https://gerrit.wikimedia.org/r/393714
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I0a94c4074e0c43f93cf1d379bf6c2622f00ee027
Gerrit-PatchSet: 1
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Dzahn 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...UniversalLanguageSelector[master]: Unify BetaFeatures SVG screenshot markup

[jenkins-bot (Code Review)]

jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/393706 )

Change subject: Unify BetaFeatures SVG screenshot markup
..


Unify BetaFeatures SVG screenshot markup

Unifying BetaFeatures SVG screenshot markup by:
- changing `id`s for better readability,
- sorting attributes,
- using full pixel values where applicable and
- generalizing attributes on `g` where applicable

Also fixing a visual glitch in the RTL version.
Follows up Idace90e945a2bd5efa869ee717224274fd94e91a.

Bug: T180427
Change-Id: I57f2f4890e980992db2c25506bbdc330530d67b1
---
M resources/images/compact-links-ltr.svg
M resources/images/compact-links-rtl.svg
2 files changed, 37 insertions(+), 41 deletions(-)

Approvals:
  Prtksxna: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/resources/images/compact-links-ltr.svg 
b/resources/images/compact-links-ltr.svg
index d887637..2aee3aa 100644
--- a/resources/images/compact-links-ltr.svg
+++ b/resources/images/compact-links-ltr.svg
@@ -5,30 +5,28 @@



-   
-   
-   
-   
-   
-   
-   
-   
-   
-   
+   
+   
+
+   
+   
+   
+   
+   


-   
-   
+
+   

-   
-   
-   
+   
+   
+   

-   
-   
-   
+   
+   
+   

-   
-   
+   
+   

 
diff --git a/resources/images/compact-links-rtl.svg 
b/resources/images/compact-links-rtl.svg
index 9d96352..b189bf4 100644
--- a/resources/images/compact-links-rtl.svg
+++ b/resources/images/compact-links-rtl.svg
@@ -5,30 +5,28 @@



-   
-   
-   
-   
-   
-   
-   
-   
-   
-   
+   
+   
+   
+   
+   
+   
+   
+   


-   
-   
+
+   

-   
-   
-   
-   
-   
-   
-   
+   
+   
+   
+   
+   
+   
+   

-   
-   
+   
+   

 

-- 
To view, visit https://gerrit.wikimedia.org/r/393706
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I57f2f4890e980992db2c25506bbdc330530d67b1
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/UniversalLanguageSelector
Gerrit-Branch: master
Gerrit-Owner: VolkerE 
Gerrit-Reviewer: Esanders 
Gerrit-Reviewer: Jforrester 
Gerrit-Reviewer: Prtksxna 
Gerrit-Reviewer: Santhosh 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: [WIP] WebStart: Remove use of realpath() for $IP

[Krinkle (Code Review)]

Krinkle has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/393713 )

Change subject: [WIP] WebStart: Remove use of realpath() for $IP
..

[WIP] WebStart: Remove use of realpath() for $IP

When installing MediaWiki in a sub directory of document root,
and including it from an /index.php file in the document root,
MediaWiki succesfully includes WebStart from index.php, but
WebStart.php fails to include Setup.php.

Example:
* /var/www/mediawiki - MediaWiki installation
* /var/www/index.php - Containing:

```
 Fatal error:  require_once(): Failed opening required 
> '/var/www/includes/Setup.php' (include_path='.:/usr/local/lib/php') in 
> /var/www/mediawiki/includes/WebStart.php on line 97
> Stack trace:
>   1. {main}() /var/www/index.php:0
>   2. require() /var/www/index.php:3
>   3. require() /var/www/mediawiki/index.php:40

Change-Id: Icd8cfa580ce1c22bc3bf177570a9f4a940d2427c
---
M includes/WebStart.php
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core 
refs/changes/13/393713/1

diff --git a/includes/WebStart.php b/includes/WebStart.php
index e4d93f9..ab499af 100644
--- a/includes/WebStart.php
+++ b/includes/WebStart.php
@@ -56,7 +56,7 @@
 # if we don't have permissions on parent directories.
 $IP = getenv( 'MW_INSTALL_PATH' );
 if ( $IP === false ) {
-   $IP = realpath( '.' ) ?: dirname( __DIR__ );
+   $IP = dirname( __DIR__ );
 }
 
 // If no LocalSettings file exists, try to display an error page

-- 
To view, visit https://gerrit.wikimedia.org/r/393713
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Icd8cfa580ce1c22bc3bf177570a9f4a940d2427c
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Krinkle 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] operations/puppet[production]: rename requesttracker_server to just requesttracker

[Dzahn (Code Review)]

Dzahn has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/393712 )

Change subject: rename requesttracker_server to just requesttracker
..

rename requesttracker_server to just requesttracker

Change-Id: Ic4b24585374bd2a63285a357cd9f44edd7f6e835
---
R hieradata/role/common/requesttracker.yaml
M manifests/site.pp
R modules/profile/manifests/requesttracker.pp
M modules/profile/templates/cumin/aliases.yaml.erb
A modules/role/manifests/requesttracker.pp
D modules/role/manifests/requesttracker_server.pp
6 files changed, 14 insertions(+), 14 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/operations/puppet 
refs/changes/12/393712/1

diff --git a/hieradata/role/common/requesttracker_server.yaml 
b/hieradata/role/common/requesttracker.yaml
similarity index 100%
rename from hieradata/role/common/requesttracker_server.yaml
rename to hieradata/role/common/requesttracker.yaml
diff --git a/manifests/site.pp b/manifests/site.pp
index 2b374d0..44dd690 100644
--- a/manifests/site.pp
+++ b/manifests/site.pp
@@ -2296,7 +2296,7 @@
 
 # replaced magnesium (RT) (T119112 T123713)
 node 'ununpentium.wikimedia.org' {
-role(requesttracker_server)
+role(requesttracker)
 interface::add_ip6_mapped { 'main': }
 }
 
diff --git a/modules/profile/manifests/requesttracker/server.pp 
b/modules/profile/manifests/requesttracker.pp
similarity index 94%
rename from modules/profile/manifests/requesttracker/server.pp
rename to modules/profile/manifests/requesttracker.pp
index e38fae6..edcc0e2 100644
--- a/modules/profile/manifests/requesttracker/server.pp
+++ b/modules/profile/manifests/requesttracker.pp
@@ -1,6 +1,6 @@
 # server running "Request Tracker"
 # https://bestpractical.com/request-tracker
-class profile::requesttracker::server {
+class profile::requesttracker {
 
 include ::passwords::misc::rt
 
diff --git a/modules/profile/templates/cumin/aliases.yaml.erb 
b/modules/profile/templates/cumin/aliases.yaml.erb
index edcef5a..f836dc7 100644
--- a/modules/profile/templates/cumin/aliases.yaml.erb
+++ b/modules/profile/templates/cumin/aliases.yaml.erb
@@ -191,7 +191,7 @@
 
 # Miscellaneous groups
 misc-analytics: P{O:statistics::web or O:piwik::server or 
O:analytics_cluster::coordinator} or A:eventlogging
-misc-apache: P{O:microsites::peopleweb or C:grafana::production or 
O:requesttracker_server or O:releases or O:otrs} or A:planet
+misc-apache: P{O:microsites::peopleweb or C:grafana::production or 
O:requesttracker or O:releases or O:otrs} or A:planet
 misc-devel: P{O:webperf or O:ve or O:archiva} or A:debugproxy or A:mwlog
 misc-nonprod: P{O:spare::system or O:test or O:pybaltest or 
O:restbase::test_cluster or O:authdns::testns or O:cache::canary}
 misc-ops: A:installserver or A:cumin or A:url-downloader or A:icinga or 
P{O:logging::kafkatee::webrequest::ops or O:builder or O:syslog::centralserver 
or O:pmacct or O:backup::offsite or O:backup} or A:netmon
diff --git a/modules/role/manifests/requesttracker.pp 
b/modules/role/manifests/requesttracker.pp
new file mode 100644
index 000..13db0de
--- /dev/null
+++ b/modules/role/manifests/requesttracker.pp
@@ -0,0 +1,11 @@
+# https://wikitech.wikimedia.org/wiki/RT
+class role::requesttracker {
+
+include ::standard
+include ::profile::base::firewall
+include ::profile::requesttracker
+
+system::role { 'requesttracker':
+description => 'RT server'
+}
+}
diff --git a/modules/role/manifests/requesttracker_server.pp 
b/modules/role/manifests/requesttracker_server.pp
deleted file mode 100644
index 1fe36bc..000
--- a/modules/role/manifests/requesttracker_server.pp
+++ /dev/null
@@ -1,11 +0,0 @@
-# https://wikitech.wikimedia.org/wiki/RT
-class role::requesttracker_server {
-
-include ::standard
-include ::profile::base::firewall
-include ::profile::requesttracker::server
-
-system::role { 'requesttracker::server':
-description => 'RT server'
-}
-}

-- 
To view, visit https://gerrit.wikimedia.org/r/393712
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic4b24585374bd2a63285a357cd9f44edd7f6e835
Gerrit-PatchSet: 1
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Dzahn 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] operations...apertium-crh[master]: apertium-crh: New upstream release

[KartikMistry (Code Review)]

KartikMistry has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/393711 )

Change subject: apertium-crh: New upstream release
..

apertium-crh: New upstream release

Bug: T181465
Change-Id: I96f1585a04ba3043add6b81c17e4117ee01f57d9
---
M debian/changelog
1 file changed, 6 insertions(+), 0 deletions(-)


  git pull 
ssh://gerrit.wikimedia.org:29418/operations/debs/contenttranslation/apertium-crh
 refs/changes/11/393711/1

diff --git a/debian/changelog b/debian/changelog
index c46509b..c1ae9ba 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -1,3 +1,9 @@
+apertium-crh (0.2.0~r83161-1+wmf1) jessie-wikimedia; urgency=low
+
+  * New upstream release.
+
+ -- Kartik Mistry   Tue, 28 Nov 2017 10:03:04 +0530
+
 apertium-crh (0.1.0~r81872-1+wmf1) jessie-wikimedia; urgency=low
 
   * Rebuild for Jessie.

-- 
To view, visit https://gerrit.wikimedia.org/r/393711
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I96f1585a04ba3043add6b81c17e4117ee01f57d9
Gerrit-PatchSet: 1
Gerrit-Project: operations/debs/contenttranslation/apertium-crh
Gerrit-Branch: master
Gerrit-Owner: KartikMistry 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] operations/puppet[production]: rename planet_server to just planet

[Dzahn (Code Review)]

Dzahn has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/393710 )

Change subject: rename planet_server to just planet
..

rename planet_server to just planet

Change-Id: I88e3fcb0205e1f1d99afae86627cc81e7a2e2a5a
---
R hieradata/role/common/planet.yaml
M manifests/site.pp
M modules/profile/templates/cumin/aliases.yaml.erb
M modules/role/manifests/planet_server.pp
4 files changed, 4 insertions(+), 4 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/operations/puppet 
refs/changes/10/393710/1

diff --git a/hieradata/role/common/planet_server.yaml 
b/hieradata/role/common/planet.yaml
similarity index 100%
rename from hieradata/role/common/planet_server.yaml
rename to hieradata/role/common/planet.yaml
diff --git a/manifests/site.pp b/manifests/site.pp
index 2b374d0..6c45300 100644
--- a/manifests/site.pp
+++ b/manifests/site.pp
@@ -1968,7 +1968,7 @@
 
 # virtual machines hosting 
https://wikitech.wikimedia.org/wiki/Planet.wikimedia.org
 node /^planet[12]001\.(eqiad|codfw)\.wmnet$/ {
-role(planet_server)
+role(planet)
 interface::add_ip6_mapped { 'main': }
 }
 
diff --git a/modules/profile/templates/cumin/aliases.yaml.erb 
b/modules/profile/templates/cumin/aliases.yaml.erb
index edcef5a..a4f889e 100644
--- a/modules/profile/templates/cumin/aliases.yaml.erb
+++ b/modules/profile/templates/cumin/aliases.yaml.erb
@@ -147,7 +147,7 @@
 parsoid-canary: P{wtp1025.eqiad.wmnet}
 parsoid-codfw: A:parsoid and A:codfw
 parsoid-eqiad: A:parsoid and A:eqiad
-planet: P{O:planet_server}
+planet: P{O:planet}
 poolcounter: P{O:poolcounter::server}
 poolcounter-codfw: A:poolcounter and A:codfw
 poolcounter-eqiad: A:poolcounter and A:eqiad
diff --git a/modules/role/manifests/planet_server.pp 
b/modules/role/manifests/planet_server.pp
index ecee04b..f524f28 100644
--- a/modules/role/manifests/planet_server.pp
+++ b/modules/role/manifests/planet_server.pp
@@ -1,5 +1,5 @@
 # server running a planet RSS feed aggregator
-class role::planet_server {
+class role::planet {
 
 include ::standard
 include ::profile::base::firewall
@@ -11,7 +11,7 @@
 
 include ::profile::planet::venus
 
-system::role { 'planet_server':
+system::role { 'planet':
 description => 'Planet-venus or rawdog RSS feed aggregator'
 }
 }

-- 
To view, visit https://gerrit.wikimedia.org/r/393710
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I88e3fcb0205e1f1d99afae86627cc81e7a2e2a5a
Gerrit-PatchSet: 1
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Dzahn 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] operations/puppet[production]: rename phabricator_server to just phabricator

[Dzahn (Code Review)]

Dzahn has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/393709 )

Change subject: rename phabricator_server to just phabricator
..

rename phabricator_server to just phabricator

Similar to gerrit we can also rename "phabricator_server" to just
"phabricator". There were just historic reasons for that.

Change-Id: I1293ef9eb9a779d80fbfb43df127677112d89d06
---
R hieradata/role/common/phabricator.yaml
M manifests/site.pp
M modules/profile/templates/cumin/aliases.yaml.erb
R modules/role/manifests/phabricator.pp
4 files changed, 4 insertions(+), 4 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/operations/puppet 
refs/changes/09/393709/1

diff --git a/hieradata/role/common/phabricator_server.yaml 
b/hieradata/role/common/phabricator.yaml
similarity index 100%
rename from hieradata/role/common/phabricator_server.yaml
rename to hieradata/role/common/phabricator.yaml
diff --git a/manifests/site.pp b/manifests/site.pp
index 2b374d0..8d180a9 100644
--- a/manifests/site.pp
+++ b/manifests/site.pp
@@ -1142,7 +1142,7 @@
 
 # Phabricator
 node /^(phab1001\.eqiad|phab2001\.codfw)\.wmnet$/ {
-role(phabricator_server)
+role(phabricator)
 include ::ganglia
 interface::add_ip6_mapped { 'main': }
 }
diff --git a/modules/profile/templates/cumin/aliases.yaml.erb 
b/modules/profile/templates/cumin/aliases.yaml.erb
index edcef5a..664d3f0 100644
--- a/modules/profile/templates/cumin/aliases.yaml.erb
+++ b/modules/profile/templates/cumin/aliases.yaml.erb
@@ -196,5 +196,5 @@
 misc-nonprod: P{O:spare::system or O:test or O:pybaltest or 
O:restbase::test_cluster or O:authdns::testns or O:cache::canary}
 misc-ops: A:installserver or A:cumin or A:url-downloader or A:icinga or 
P{O:logging::kafkatee::webrequest::ops or O:builder or O:syslog::centralserver 
or O:pmacct or O:backup::offsite or O:backup} or A:netmon
 misc-others: P{O:mw_rc_irc or O:etherpad or O:tor_relay or O:lists}
-misc-releng: P{O:labs::openstack::nodepool or O:phabricator_server} or 
A:contint or A:gerrit
+misc-releng: P{O:labs::openstack::nodepool or O:phabricator} or A:contint or 
A:gerrit
 misc-wmcs: A:labnet or A:labcontrol or A:labservices or A:labweb
diff --git a/modules/role/manifests/phabricator_server.pp 
b/modules/role/manifests/phabricator.pp
similarity index 85%
rename from modules/role/manifests/phabricator_server.pp
rename to modules/role/manifests/phabricator.pp
index cbb85df..2db93a0 100644
--- a/modules/role/manifests/phabricator_server.pp
+++ b/modules/role/manifests/phabricator.pp
@@ -1,9 +1,9 @@
 # phabricator instance
 #
 # filtertags: labs-project-deployment-prep labs-project-phabricator
-class role::phabricator_server {
+class role::phabricator {
 
-system::role { 'phabricator_server':
+system::role { 'phabricator':
 description => 'Phabricator (Main) Server'
 }
 

-- 
To view, visit https://gerrit.wikimedia.org/r/393709
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I1293ef9eb9a779d80fbfb43df127677112d89d06
Gerrit-PatchSet: 1
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Dzahn 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] operations/puppet[production]: various misc roles: remove ganglia

[Dzahn (Code Review)]

Dzahn has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/393708 )

Change subject: various misc roles: remove ganglia
..

various misc roles: remove ganglia

Bug: T177225
Change-Id: I875e4dea1a2233049b37d9539a6ffeedce2ed0b0
---
M hieradata/role/common/builder.yaml
M hieradata/role/common/phabricator_server.yaml
M hieradata/role/common/planet_server.yaml
M hieradata/role/common/releases.yaml
M hieradata/role/common/requesttracker_server.yaml
M hieradata/role/common/webperf.yaml
M hieradata/role/common/webserver_misc_apps.yaml
M hieradata/role/common/webserver_misc_static.yaml
8 files changed, 8 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/operations/puppet 
refs/changes/08/393708/1

diff --git a/hieradata/role/common/builder.yaml 
b/hieradata/role/common/builder.yaml
index 82fc96d..62d6a04 100644
--- a/hieradata/role/common/builder.yaml
+++ b/hieradata/role/common/builder.yaml
@@ -7,5 +7,6 @@
 profile::docker::builder::proxy_address: "webproxy.%{::site}.wmnet"
 profile::docker::builder::proxy_port: "8080"
 monitor_screens: false
+standard::has_ganglia: false
 # The default setup has no lvm, so no source
 #profile::docker::storage::loopback::dm_source: null
diff --git a/hieradata/role/common/phabricator_server.yaml 
b/hieradata/role/common/phabricator_server.yaml
index 8b8d5cc..eadbfa5 100644
--- a/hieradata/role/common/phabricator_server.yaml
+++ b/hieradata/role/common/phabricator_server.yaml
@@ -2,6 +2,7 @@
 admin::groups:
   - phabricator-admin
   - phabricator-roots
+standard::has_ganglia: false
 apache::logrotate::period: "daily"
 apache::logrotate::rotate: 3
 
diff --git a/hieradata/role/common/planet_server.yaml 
b/hieradata/role/common/planet_server.yaml
index a3b25fa..a5e57bb 100644
--- a/hieradata/role/common/planet_server.yaml
+++ b/hieradata/role/common/planet_server.yaml
@@ -1,3 +1,3 @@
 cluster: misc
-
 planet_domain_name: 'wikimedia.org'
+standard::has_ganglia: false
diff --git a/hieradata/role/common/releases.yaml 
b/hieradata/role/common/releases.yaml
index 92ac574..0b07b0a 100644
--- a/hieradata/role/common/releases.yaml
+++ b/hieradata/role/common/releases.yaml
@@ -1,7 +1,7 @@
 admin::groups:
   - releasers-mediawiki
   - releasers-mobile
-
+standard::has_ganglia: false
 profile::releases::mediawiki::sitename: 'releases.wikimedia.org'
 profile::releases::mediawiki::sitename_jenkins: 
'releases-jenkins.wikimedia.org'
 profile::releases::mediawiki::server_admin: 'n...@wikimedia.org'
diff --git a/hieradata/role/common/requesttracker_server.yaml 
b/hieradata/role/common/requesttracker_server.yaml
index 7ad0377..8758e27 100644
--- a/hieradata/role/common/requesttracker_server.yaml
+++ b/hieradata/role/common/requesttracker_server.yaml
@@ -1 +1,2 @@
 standard::has_default_mail_relay: false
+standard::has_ganglia: false
diff --git a/hieradata/role/common/webperf.yaml 
b/hieradata/role/common/webperf.yaml
index c637fcb..8c1c633 100644
--- a/hieradata/role/common/webperf.yaml
+++ b/hieradata/role/common/webperf.yaml
@@ -1,3 +1,4 @@
 admin::groups:
   - perf-team
   - eventlogging-admins
+standard::has_ganglia: false
diff --git a/hieradata/role/common/webserver_misc_apps.yaml 
b/hieradata/role/common/webserver_misc_apps.yaml
index 7ad0377..8758e27 100644
--- a/hieradata/role/common/webserver_misc_apps.yaml
+++ b/hieradata/role/common/webserver_misc_apps.yaml
@@ -1 +1,2 @@
 standard::has_default_mail_relay: false
+standard::has_ganglia: false
diff --git a/hieradata/role/common/webserver_misc_static.yaml 
b/hieradata/role/common/webserver_misc_static.yaml
index ff1f796..1e33d9a4 100644
--- a/hieradata/role/common/webserver_misc_static.yaml
+++ b/hieradata/role/common/webserver_misc_static.yaml
@@ -1,3 +1,4 @@
 admin::groups:
   - releasers-mediawiki
   - releasers-mobile
+standard::has_ganglia: false

-- 
To view, visit https://gerrit.wikimedia.org/r/393708
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I875e4dea1a2233049b37d9539a6ffeedce2ed0b0
Gerrit-PatchSet: 1
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Dzahn 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] oojs/ui[master]: README: Re-arrange intro section

[jenkins-bot (Code Review)]

jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/390361 )

Change subject: README: Re-arrange intro section
..


README: Re-arrange intro section

Bug: T179111
Change-Id: I7faae1ca31a5670d2a4582798455cf33a8d65769
---
M README.md
1 file changed, 10 insertions(+), 1 deletion(-)

Approvals:
  jenkins-bot: Verified
  VolkerE: Looks good to me, approved



diff --git a/README.md b/README.md
index 8248e63..f10330f 100644
--- a/README.md
+++ b/README.md
@@ -3,7 +3,16 @@
 OOjs UI
 =
 
-OOjs UI is a modern JavaScript UI library. It provides common widgets, 
layouts, dialogs and icons that are ready to use, as well as many useful and 
convenient classes for constructing custom user interfaces. It is the standard 
user-interface library in Wikimedia Foundation Web products, having been 
originally created for use by 
[VisualEditor](https://www.mediawiki.org/wiki/VisualEditor), which uses it for 
its entire user interface.
+OOjs UI is a component-based JavaScript UI library. Key features:
+
+* Common widgets, layouts, and dialogs
+* Classes, elements, and mixins to create custom interfaces
+* Internationalization and localization, like right-to-left (RTL) languages 
support
+* Theme-ability
+* Built-in icons
+* Accessibility features
+
+It is the standard library for Web products at the Wikimedia Foundation, 
having been originally created for use by 
[VisualEditor](https://www.mediawiki.org/wiki/VisualEditor).
 
 
 Quick start

-- 
To view, visit https://gerrit.wikimedia.org/r/390361
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I7faae1ca31a5670d2a4582798455cf33a8d65769
Gerrit-PatchSet: 5
Gerrit-Project: oojs/ui
Gerrit-Branch: master
Gerrit-Owner: Prtksxna 
Gerrit-Reviewer: Jforrester 
Gerrit-Reviewer: Prtksxna 
Gerrit-Reviewer: VolkerE 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] operations/puppet[production]: phabricator: Fix elasticsearch version field

[Dzahn (Code Review)]

Dzahn has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/393655 )

Change subject: phabricator: Fix elasticsearch version field
..


phabricator: Fix elasticsearch version field

It has to be set outside hosts for it to take effect.

Bug: T181437
Change-Id: I2fa29e198569e96624b26c81ffda15ca4f92211b
---
M hieradata/role/codfw/phabricator_server.yaml
M hieradata/role/common/phabricator_server.yaml
M hieradata/role/eqiad/phabricator_server.yaml
3 files changed, 7 insertions(+), 7 deletions(-)

Approvals:
  20after4: Looks good to me, but someone else must approve
  jenkins-bot: Verified
  Dzahn: Looks good to me, approved



diff --git a/hieradata/role/codfw/phabricator_server.yaml 
b/hieradata/role/codfw/phabricator_server.yaml
index 654c0ca..f1dd9b4 100644
--- a/hieradata/role/codfw/phabricator_server.yaml
+++ b/hieradata/role/codfw/phabricator_server.yaml
@@ -22,20 +22,20 @@
   - type: 'elasticsearch'
 path: '/phabricator'
 port: 9243
+version: 5
 hosts:
   - protocol: 'https'
 host: 'search.svc.codfw.wmnet'
-version: 5
 roles:
   read: true
   write: true
   - type: 'elasticsearch'
 path: '/phabricator'
 port: 9243
+version: 5
 hosts:
   - protocol: 'https'
 host: 'search.svc.eqiad.wmnet'
-version: 5
 roles:
   read: true
   write: true
diff --git a/hieradata/role/common/phabricator_server.yaml 
b/hieradata/role/common/phabricator_server.yaml
index cdda0b4..8b8d5cc 100644
--- a/hieradata/role/common/phabricator_server.yaml
+++ b/hieradata/role/common/phabricator_server.yaml
@@ -20,20 +20,20 @@
   - type: 'elasticsearch'
 path: '/phabricator'
 port: 9243
+version: 5
 hosts:
   - protocol: 'https'
 host: 'search.svc.eqiad.wmnet'
-version: 5
 roles:
   read: true
   write: true
   - type: 'elasticsearch'
 path: '/phabricator'
 port: 9243
+version: 5
 hosts:
   - protocol: 'https'
 host: 'search.svc.codfw.wmnet'
-version: 5
 roles:
   read: true
   write: true
diff --git a/hieradata/role/eqiad/phabricator_server.yaml 
b/hieradata/role/eqiad/phabricator_server.yaml
index 02d6fda..fa5c6a5 100644
--- a/hieradata/role/eqiad/phabricator_server.yaml
+++ b/hieradata/role/eqiad/phabricator_server.yaml
@@ -13,20 +13,20 @@
   - type: 'elasticsearch'
 path: '/phabricator'
 port: 9243
+version: 5
 hosts:
   - protocol: 'https'
 host: 'search.svc.eqiad.wmnet'
-version: 5
 roles:
   read: true
   write: true
   - type: 'elasticsearch'
 path: '/phabricator'
 port: 9243
+version: 5
 hosts:
   - protocol: 'https'
 host: 'search.svc.codfw.wmnet'
-version: 5
 roles:
   read: true
-  write: true
\ No newline at end of file
+  write: true

-- 
To view, visit https://gerrit.wikimedia.org/r/393655
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I2fa29e198569e96624b26c81ffda15ca4f92211b
Gerrit-PatchSet: 3
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Paladox 
Gerrit-Reviewer: 20after4 
Gerrit-Reviewer: Dzahn 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] operations/puppet[production]: Gerrit: Fix negative cut-off logo on page load

[Dzahn (Code Review)]

Dzahn has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/393691 )

Change subject: Gerrit: Fix negative cut-off logo on page load
..


Gerrit: Fix negative cut-off logo on page load

Follows-up db9ea750ef. Simplify the CSS a bit and make the logo
absolute positioned.

It was practically already absolutely positioned given all the
arbitrary and negative relative offsets that are highly dependent
on the rest of the interface (which are variable).

Previously the logo was positioned relative to the bottom of the
menu, into the left margin that the menu reserved. It positioned
itself upward by 56px which is 48px (height of menu), plus 4px (
padding-top of menu), plus 4px (padding-bottom of menu).

However, this didn't always work as expected:

* The menu's height isn't actually defined as 48px, which
  is only the default render height given a particular font size
  and number of rows. This can change. Gerrit's interface supports
  such change, but our hack did not.

* The menu's padding isn't actually defined as 4px. Rather 4px
  is the result of various internal table borders of 1px or 2px
  stacking up to produce 4px efffective padding.
  In addition, those borders are not defined in Gerrit and actually
  varies by browser (user agent default styles). Causing the logo
  to render in slightly different positions.

* When a Gerrit page first loads, the gerrit_topmenu element
  is empty and has no height. Its contents are populated later.
  As a result, the first render of a Gerrit page is empty with
  some "Page is loading..." text and a partially cut-off Gerrit
  logo that was 56px off the page toward the top.

These are all fixed, by changing the position of the logo to
be computed from the top-left edge of the page, instead of
relative to the bottom bottom corner of the menu.

The relative position code for that ensures the heigiht being
reserved is replaced with a min-height declaration on topmenu.

Change-Id: I3ca795bb3a3f7c5088fac00bb1b81fdd3139098c
---
M modules/gerrit/files/etc/GerritSite.css
1 file changed, 21 insertions(+), 13 deletions(-)

Approvals:
  Thcipriani: Looks good to me, but someone else must approve
  Chad: Looks good to me, but someone else must approve
  jenkins-bot: Verified
  Dzahn: Looks good to me, approved



diff --git a/modules/gerrit/files/etc/GerritSite.css 
b/modules/gerrit/files/etc/GerritSite.css
index 906fe64..a80386d 100644
--- a/modules/gerrit/files/etc/GerritSite.css
+++ b/modules/gerrit/files/etc/GerritSite.css
@@ -52,30 +52,35 @@
 }
 
 /**
- * Header
+ * The logo uses position absolute because the HTML generated by Gerrit
+ * creates the header as a sibling *after* the menu instead of before it.
+ * As such, the only reliable way to render to the left of it, is either
+ * with fragile negative offsets, or by using absolute position.
+ *
+ * The logo is taller than gerrit_topmenu. As such, a later CSS rule
+ * ensures gerrit_topmenu has a minimum height that accomodates the
+ * logo as well, to avoid page content from overlapping the logo.
  */
 #gerrit_header {
display: block !important;
-   width: 85px;
-   position: relative;
-   /* 54px puts it exactly against the top of the page */
-   top: -54px;
-   margin-bottom: -54px;
-   height: 68px;
 }
-
 .wm-gerrit-heading {
-   margin: 0.5em 0 0 0.5em;
+   position: absolute;
+   top: 0;
+   left: 0;
+
+   margin: 7px 13px;
padding: 0;
-   font-family: 'PT Sans', sans-serif;
+
+   /* This font and color aren't used since there is an image there,
+* but is kept for consistency when used for display of alt-text
+*/
font-weight: normal;
letter-spacing: -1px;
-   /* This color isn't used since there is an image there,
-* but it kept for consistency when used for display of alt-text
-*/
color: #99;
 
min-height: 60px;
+   min-width: 60px;
background: transparent no-repeat 0 0;
background-image: url(/r/static/wikimedia-codereview-logo.cache.png);
background-image: linear-gradient(transparent,transparent), 
url(/r/static/wikimedia-codereview-logo.cache.svg);
@@ -94,6 +99,9 @@
background: none;
/* Make sure it is above the logo or we can not clck the sub menu items 
*/
z-index: 1;
+   /* Ensure logo is not cut off by page content */
+   /* 74px = 60px height + (2 x 7px) margin */
+   min-height: 74px;
 }
 
 #gerrit_topmenu tbody tr td table {

-- 
To view, visit https://gerrit.wikimedia.org/r/393691
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I3ca795bb3a3f7c5088fac00bb1b81fdd3139098c
Gerrit-PatchSet: 4
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Krinkle 
Gerrit-Reviewer: Chad 
Gerrit-Reviewer: 

[MediaWiki-commits] [Gerrit] operations/puppet[production]: ganglia: ensure more things are gone in decom class

[Dzahn (Code Review)]

Dzahn has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/393707 )

Change subject: ganglia: ensure more things are gone in decom class
..

ganglia: ensure more things are gone in decom class

Bug: T177225
Change-Id: I2a0fdff42330f920838ee25132734d19a63860c4
---
M modules/ganglia/manifests/monitor/decommission.pp
1 file changed, 16 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/operations/puppet 
refs/changes/07/393707/1

diff --git a/modules/ganglia/manifests/monitor/decommission.pp 
b/modules/ganglia/manifests/monitor/decommission.pp
index 088bed9..ca122a6 100644
--- a/modules/ganglia/manifests/monitor/decommission.pp
+++ b/modules/ganglia/manifests/monitor/decommission.pp
@@ -23,7 +23,22 @@
 force   => true,
 require => Package['ganglia-monitor'],
 }
-
+# in some cases /var/lib/ganglia becomes a remnant
+# with files like pdns_gmetric.state in it
+file { '/var/lib/ganglia/':
+ensure  => absent,
+recurse => true,
+force   => true,
+require => Package['ganglia-monitor'],
+}
+# just to make sure
+service { 'ganglia-monitor':
+ensure => 'stopped',
+}
+# in some cases the pid file was left even when service was stopped
+file { '/run/ganglia-monitor.pid':
+ensure => absent,
+}
 file { '/etc/systemd/system/ganglia-monitor.service':
 ensure => absent,
 }

-- 
To view, visit https://gerrit.wikimedia.org/r/393707
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I2a0fdff42330f920838ee25132734d19a63860c4
Gerrit-PatchSet: 1
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Dzahn 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...UniversalLanguageSelector[master]: Unify BetaFeatures SVG screenshot markup

[VolkerE (Code Review)]

VolkerE has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/393706 )

Change subject: Unify BetaFeatures SVG screenshot markup
..

Unify BetaFeatures SVG screenshot markup

Unifying BetaFeatures SVG screenshot markup by:
- changing `id`s for better readability,
- sorting attributes,
- using full pixel values where applicable and
- generalizing attributes on `g` where applicable

Also fixing a visual glitch in the RTL version.
Follows up Idace90e945a2bd5efa869ee717224274fd94e91a.

Bug: T180427
Change-Id: I57f2f4890e980992db2c25506bbdc330530d67b1
---
M resources/images/compact-links-ltr.svg
M resources/images/compact-links-rtl.svg
2 files changed, 37 insertions(+), 41 deletions(-)


  git pull 
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/UniversalLanguageSelector 
refs/changes/06/393706/1

diff --git a/resources/images/compact-links-ltr.svg 
b/resources/images/compact-links-ltr.svg
index d887637..2aee3aa 100644
--- a/resources/images/compact-links-ltr.svg
+++ b/resources/images/compact-links-ltr.svg
@@ -5,30 +5,28 @@



-   
-   
-   
-   
-   
-   
-   
-   
-   
-   
+   
+   
+
+   
+   
+   
+   
+   


-   
-   
+
+   

-   
-   
-   
+   
+   
+   

-   
-   
-   
+   
+   
+   

-   
-   
+   
+   

 
diff --git a/resources/images/compact-links-rtl.svg 
b/resources/images/compact-links-rtl.svg
index 9d96352..b189bf4 100644
--- a/resources/images/compact-links-rtl.svg
+++ b/resources/images/compact-links-rtl.svg
@@ -5,30 +5,28 @@



-   
-   
-   
-   
-   
-   
-   
-   
-   
-   
+   
+   
+   
+   
+   
+   
+   
+   


-   
-   
+
+   

-   
-   
-   
-   
-   
-   
-   
+   
+   
+   
+   
+   
+   
+   

-   
-   
+   
+   

 

-- 
To view, visit https://gerrit.wikimedia.org/r/393706
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I57f2f4890e980992db2c25506bbdc330530d67b1
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/UniversalLanguageSelector
Gerrit-Branch: master
Gerrit-Owner: VolkerE 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] VisualEditor/VisualEditor[master]: ce.ContentBranchNode: Move setNotUnicorning into detach

[jenkins-bot (Code Review)]

jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/386419 )

Change subject: ce.ContentBranchNode: Move setNotUnicorning into detach
..


ce.ContentBranchNode: Move setNotUnicorning into detach

We can be more confident that the root will exist during detach, and it's also
reasonable to de-unicorn any node which is detached even if it's not
immediately destroyed.

Change-Id: I6ab27fe19fceddb7284e22b6f763cb272fdb8946
---
M src/ce/ve.ce.ContentBranchNode.js
1 file changed, 9 insertions(+), 8 deletions(-)

Approvals:
  Divec: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/src/ce/ve.ce.ContentBranchNode.js 
b/src/ce/ve.ce.ContentBranchNode.js
index cd3a292..821c4dd 100644
--- a/src/ce/ve.ce.ContentBranchNode.js
+++ b/src/ce/ve.ce.ContentBranchNode.js
@@ -475,17 +475,18 @@
 };
 
 /**
- * Handle teardown event.
- *
- * @method
+ * @inheritdoc
  */
-ve.ce.ContentBranchNode.prototype.onTeardown = function () {
-   var ceSurface = this.getRoot().getSurface();
+ve.ce.ContentBranchNode.prototype.detach = function () {
+   if ( this.getRoot() ) {
+   // This should be true, as the root is removed in the parent 
detach
+   // method which hasn't run yet. However, just in case a node 
gets
+   // double-detached...
+   this.getRoot().getSurface().setNotUnicorning( this );
+   }
 
// Parent method
-   ve.ce.ContentBranchNode.super.prototype.onTeardown.call( this );
-
-   ceSurface.setNotUnicorning( this );
+   ve.ce.ContentBranchNode.super.prototype.detach.call( this );
 };
 
 /**

-- 
To view, visit https://gerrit.wikimedia.org/r/386419
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I6ab27fe19fceddb7284e22b6f763cb272fdb8946
Gerrit-PatchSet: 5
Gerrit-Project: VisualEditor/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: DLynch 
Gerrit-Reviewer: DLynch 
Gerrit-Reviewer: Divec 
Gerrit-Reviewer: Esanders 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: logging: Abstract LogPager enforcing of action and performer...

[jenkins-bot (Code Review)]

jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/266397 )

Change subject: logging: Abstract LogPager enforcing of action and performer 
restrictions
..


logging: Abstract LogPager enforcing of action and performer restrictions

This avoids duplicating the code in the future, such as proposed for
I3ea2c050b6dd6c (T16711).

Change-Id: Ic53b074f542014f156b006864d91a138ba5fb22b
---
M includes/logging/LogPager.php
1 file changed, 43 insertions(+), 16 deletions(-)

Approvals:
  Krinkle: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/includes/logging/LogPager.php b/includes/logging/LogPager.php
index df432e1..05e55de 100644
--- a/includes/logging/LogPager.php
+++ b/includes/logging/LogPager.php
@@ -45,6 +45,12 @@
/** @var string */
private $action = '';
 
+   /** @var bool */
+   private $performerRestrictionsEnforced = false;
+
+   /** @var bool */
+   private $actionRestrictionsEnforced = false;
+
/** @var LogEventsList */
public $mLogEventsList;
 
@@ -177,14 +183,7 @@
} else {
$this->mConds['log_user'] = $userid;
}
-   // Paranoia: avoid brute force searches (T19342)
-   $user = $this->getUser();
-   if ( !$user->isAllowed( 'deletedhistory' ) ) {
-   $this->mConds[] = $this->mDb->bitAnd( 'log_deleted', 
LogPage::DELETED_USER ) . ' = 0';
-   } elseif ( !$user->isAllowedAny( 'suppressrevision', 
'viewsuppressed' ) ) {
-   $this->mConds[] = $this->mDb->bitAnd( 'log_deleted', 
LogPage::SUPPRESSED_USER ) .
-   ' != ' . LogPage::SUPPRESSED_USER;
-   }
+   $this->enforcePerformerRestrictions();
 
$this->performer = $name;
}
@@ -252,14 +251,7 @@
} else {
$this->mConds['log_title'] = $title->getDBkey();
}
-   // Paranoia: avoid brute force searches (T19342)
-   $user = $this->getUser();
-   if ( !$user->isAllowed( 'deletedhistory' ) ) {
-   $this->mConds[] = $db->bitAnd( 'log_deleted', 
LogPage::DELETED_ACTION ) . ' = 0';
-   } elseif ( !$user->isAllowedAny( 'suppressrevision', 
'viewsuppressed' ) ) {
-   $this->mConds[] = $db->bitAnd( 'log_deleted', 
LogPage::SUPPRESSED_ACTION ) .
-   ' != ' . LogPage::SUPPRESSED_ACTION;
-   }
+   $this->enforceActionRestrictions();
}
 
/**
@@ -420,4 +412,39 @@
parent::doQuery();
$this->mDb->setBigSelects( 'default' );
}
+
+   /**
+* Paranoia: avoid brute force searches (T19342)
+*/
+   private function enforceActionRestrictions() {
+   if ( $this->actionRestrictionsEnforced ) {
+   return;
+   }
+   $this->actionRestrictionsEnforced = true;
+   $user = $this->getUser();
+   if ( !$user->isAllowed( 'deletedhistory' ) ) {
+   $this->mConds[] = $this->mDb->bitAnd( 'log_deleted', 
LogPage::DELETED_USER ) . ' = 0';
+   } elseif ( !$user->isAllowedAny( 'suppressrevision', 
'viewsuppressed' ) ) {
+   $this->mConds[] = $this->mDb->bitAnd( 'log_deleted', 
LogPage::SUPPRESSED_USER ) .
+   ' != ' . LogPage::SUPPRESSED_USER;
+   }
+   }
+
+   /**
+* Paranoia: avoid brute force searches (T19342)
+*/
+   private function enforcePerformerRestrictions() {
+   // Same as enforceActionRestrictions(), except for _USER 
instead of _ACTION bits.
+   if ( $this->performerRestrictionsEnforced ) {
+   return;
+   }
+   $this->performerRestrictionsEnforced = true;
+   $user = $this->getUser();
+   if ( !$user->isAllowed( 'deletedhistory' ) ) {
+   $this->mConds[] = $db->bitAnd( 'log_deleted', 
LogPage::DELETED_ACTION ) . ' = 0';
+   } elseif ( !$user->isAllowedAny( 'suppressrevision', 
'viewsuppressed' ) ) {
+   $this->mConds[] = $db->bitAnd( 'log_deleted', 
LogPage::SUPPRESSED_ACTION ) .
+   ' != ' . LogPage::SUPPRESSED_ACTION;
+   }
+   }
 }

-- 
To view, visit https://gerrit.wikimedia.org/r/266397
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ic53b074f542014f156b006864d91a138ba5fb22b
Gerrit-PatchSet: 4
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Cenarium 
Gerrit-Reviewer: Aaron Schulz 
Gerrit-Reviewer: Cenarium 

[MediaWiki-commits] [Gerrit] wikimedia...civicrm[master]: CRM-21489 resurrect deadlock re-tries

[Eileen (Code Review)]

Eileen has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/393705 )

Change subject: CRM-21489 resurrect deadlock re-tries
..

CRM-21489 resurrect deadlock re-tries

It turns out the code to retry 3 times in event of a deadlock is broken.

More detail on the JIRA ticket

Change-Id: Ic83168ff45a89092e7fcf688c6feb7d09deee608
---
M packages/DB/DataObject.php
1 file changed, 13 insertions(+), 6 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/wikimedia/fundraising/crm/civicrm 
refs/changes/05/393705/1

diff --git a/packages/DB/DataObject.php b/packages/DB/DataObject.php
index 0d74ece..37a1961 100644
--- a/packages/DB/DataObject.php
+++ b/packages/DB/DataObject.php
@@ -2436,14 +2436,21 @@
 $t= explode(' ',microtime());
 $_DB_DATAOBJECT['QUERYENDTIME'] = $time = $t[0]+$t[1];
 
-
+$maxTries = is_defined('CIVICRM_DEADLOCK_RETRIES') ? 
CIVICRM_DEADLOCK_RETRIES : 3;
 for ($tries = 0;$tries < 3;$tries++) {
-
 if ($_DB_driver == 'DB') {
-if ($tries) {
-  CRM_Core_Error::debug_log_message('Attempt: ' . $tries + 1 . 
' at query : ' . $string);
+try {
+  $result = $DB->query($string);
 }
-$result = $DB->query($string);
+catch (PEAR_Exception $e) {
+  // If we have caught a deadlock - let it go around the loop 
until our tries limit is hit.
+  // else rethrow the exception.
+  if (!stristr($e->getCause()->getUserInfo(), 
'nativecode=1205') || ($tries + 1) === $maxTries) {
+throw $e;
+  }
+  CRM_Core_Error::debug_log_message('Retrying after deadlock 
hit on attempt ' . $tries + 1 . ' at query : ' . $string);
+  continue;
+}
 
 } else {
 switch (strtolower(substr(trim($string),0,6))) {
@@ -2460,7 +2467,7 @@
 }
 }
 
-// see if we got a failure.. - try again a few times..
+// See CRM-21489 for why I believe this is never hit.
 if (!is_a($result,'PEAR_Error')) {
 break;
 }

-- 
To view, visit https://gerrit.wikimedia.org/r/393705
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic83168ff45a89092e7fcf688c6feb7d09deee608
Gerrit-PatchSet: 1
Gerrit-Project: wikimedia/fundraising/crm/civicrm
Gerrit-Branch: master
Gerrit-Owner: Eileen 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...BetaFeatures[master]: Unify BetaFeatures SVG screenshot markup

[jenkins-bot (Code Review)]

jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/393703 )

Change subject: Unify BetaFeatures SVG screenshot markup
..


Unify BetaFeatures SVG screenshot markup

Unifying BetaFeatures SVG screenshot markup by:
- removing unnecessary `standalone=no` attribute,
- changing `id`s for better readability,
- sorting attributes,
- using full pixel values where applicable and
- generalizing attributes on `g` where applicable
Results in 22 & 17% file size reduction before gzipping.
Follows up I60ad8fc3a475219f5b018d876e78f861396505bc.

Bug: T180427
Change-Id: I80ec68492cfd1d5142294686f641610a9b1c4f49
---
M resources/images/screenshot-template-ltr.svg
M resources/images/screenshot-template-rtl.svg
2 files changed, 27 insertions(+), 31 deletions(-)

Approvals:
  Prtksxna: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/resources/images/screenshot-template-ltr.svg 
b/resources/images/screenshot-template-ltr.svg
index deed7ec..9af0d2d 100644
--- a/resources/images/screenshot-template-ltr.svg
+++ b/resources/images/screenshot-template-ltr.svg
@@ -1,23 +1,21 @@
-
-http://www.w3.org/2000/svg; id="svg2" viewBox="0 0 264 162" 
height="162" width="264">
-
+
+http://www.w3.org/2000/svg; width="264" height="162" viewBox="0 0 
264 162">
+
 
 
 
 
-
-
-
-
-
-
-
-
-
-
+
+
+
+
+
+
+
+
 
 
-
-
+
+
 
 
diff --git a/resources/images/screenshot-template-rtl.svg 
b/resources/images/screenshot-template-rtl.svg
index f795af8..36b9b11 100644
--- a/resources/images/screenshot-template-rtl.svg
+++ b/resources/images/screenshot-template-rtl.svg
@@ -1,23 +1,21 @@
-
-http://www.w3.org/2000/svg; id="svg2" viewBox="0 0 264 162" 
height="162" width="264">
-
+
+http://www.w3.org/2000/svg; width="264" height="162" viewBox="0 0 
264 162">
+
 
 
 
 
-
-
-
-
-
-
-
+
+
+
+
+
+
+
+
+
 
-
-
-
-
-
-
+
+
 
 

-- 
To view, visit https://gerrit.wikimedia.org/r/393703
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I80ec68492cfd1d5142294686f641610a9b1c4f49
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/BetaFeatures
Gerrit-Branch: master
Gerrit-Owner: VolkerE 
Gerrit-Reviewer: Esanders 
Gerrit-Reviewer: Jforrester 
Gerrit-Reviewer: Legoktm 
Gerrit-Reviewer: Prtksxna 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki/core[REL1_27]: Autodiscover extension unittests

[Reedy (Code Review)]

Reedy has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/393704 )

Change subject: Autodiscover extension unittests
..

Autodiscover extension unittests

Instead of requiring every extension that wants to add unit tests to
copy the exact same boilerplate over and over, let's just automatically
discover them. We now have an extension registry, so we know exactly
which extensions are loaded (this won't work for extensions not being
loaded through extension.json).

For each extension, we check to see if the directory "tests/phpunit/"
exists, and if it does, add those unit tests. If there is a
`UnitTestsList` subscriber already set, PHPUnit will automatically
de-duplicate test cases so we won't be running anything twice.

Change-Id: I6ec654ef2d8ee3630b121b1277b4ee21ba0b6cd4
(cherry picked from commit 1d7221d066c01c3fa6fb3e539cebd9fe7a91550f)
---
M tests/phpunit/suites/ExtensionsTestSuite.php
1 file changed, 8 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core 
refs/changes/04/393704/1

diff --git a/tests/phpunit/suites/ExtensionsTestSuite.php 
b/tests/phpunit/suites/ExtensionsTestSuite.php
index 0e23fdd..02934fa 100644
--- a/tests/phpunit/suites/ExtensionsTestSuite.php
+++ b/tests/phpunit/suites/ExtensionsTestSuite.php
@@ -8,10 +8,16 @@
 class ExtensionsTestSuite extends PHPUnit_Framework_TestSuite {
public function __construct() {
parent::__construct();
+
$paths = [];
+   // Autodiscover extension unit tests
+   $registry = ExtensionRegistry::getInstance();
+   foreach ( $registry->getAllThings() as $info ) {
+   $paths[] = dirname( $info['path'] ) . '/tests/phpunit';
+   }
// Extensions can return a list of files or directories
Hooks::run( 'UnitTestsList', [ &$paths ] );
-   foreach ( $paths as $path ) {
+   foreach ( array_unique( $paths ) as $path ) {
if ( is_dir( $path ) ) {
// If the path is a directory, search for test 
cases.
// @since 1.24
@@ -19,7 +25,7 @@
$fileIterator = new File_Iterator_Facade();
$matchingFiles = 
$fileIterator->getFilesAsArray( $path, $suffixes );
$this->addTestFiles( $matchingFiles );
-   } else {
+   } elseif ( file_exists( $path ) ) {
// Add a single test case or suite class
$this->addTestFile( $path );
}

-- 
To view, visit https://gerrit.wikimedia.org/r/393704
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I6ec654ef2d8ee3630b121b1277b4ee21ba0b6cd4
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: REL1_27
Gerrit-Owner: Reedy 
Gerrit-Reviewer: Legoktm 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: objectcache: add "graceTTL" option to WANObjectCache::getWit...

[jenkins-bot (Code Review)]

jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/393571 )

Change subject: objectcache: add "graceTTL" option to 
WANObjectCache::getWithSetCallback()
..


objectcache: add "graceTTL" option to WANObjectCache::getWithSetCallback()

Also made worthRefreshExpiring() fully match the method documentation.

Change-Id: I48a4b1b9d006de100389b47c03c1185a9316abfc
---
M includes/libs/objectcache/WANObjectCache.php
M tests/phpunit/includes/libs/objectcache/WANObjectCacheTest.php
2 files changed, 100 insertions(+), 19 deletions(-)

Approvals:
  Krinkle: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/includes/libs/objectcache/WANObjectCache.php 
b/includes/libs/objectcache/WANObjectCache.php
index f5c561f..a55d21c 100644
--- a/includes/libs/objectcache/WANObjectCache.php
+++ b/includes/libs/objectcache/WANObjectCache.php
@@ -137,6 +137,8 @@
const HOLDOFF_NONE = 0;
/** Idiom for set()/getWithSetCallback() for "do not augment the 
storage medium TTL" */
const STALE_TTL_NONE = 0;
+   /** Idiom for set()/getWithSetCallback() for "no post-expired grace 
period" */
+   const GRACE_TTL_NONE = 0;
 
/** Idiom for getWithSetCallback() for "no minimum required as-of 
timestamp" */
const MIN_TIMESTAMP_NONE = 0.0;
@@ -820,6 +822,12 @@
 *   - checkKeys: List of "check" keys. The key at $key will be seen as 
invalid when either
 *  touchCheckKey() or resetCheckKey() is called on any of these 
keys.
 *  Default: [].
+*   - graceTTL: Consider reusing expired values instead of refreshing 
them if they expired
+*  less than this many seconds ago. The odds of a refresh becomes 
more likely over time,
+*  becoming certain once the grace period is reached. This can 
reduce traffic spikes
+*  when millions of keys are compared to the same "check" key and 
touchCheckKey()
+*  or resetCheckKey() is called on that "check" key.
+*  Default: WANObjectCache::GRACE_TTL_NONE.
 *   - lockTSE: If the key is tombstoned or expired (by checkKeys) less 
than this many seconds
 *  ago, then try to have a single thread handle cache regeneration 
at any given time.
 *  Other threads will try to use stale values if possible. If, on 
miss, the time since
@@ -854,13 +862,13 @@
 *  This is useful if the source of a key is suspected of having 
possibly changed
 *  recently, and the caller wants any such changes to be reflected.
 *  Default: WANObjectCache::MIN_TIMESTAMP_NONE.
-*   - hotTTR: Expected time-till-refresh (TTR) for keys that average 
~1 hit/second (1 Hz).
-*  Keys with a hit rate higher than 1Hz will refresh sooner than 
this TTR and vise versa.
-*  Such refreshes won't happen until keys are "ageNew" seconds 
old. The TTR is useful at
-*  reducing the impact of missed cache purges, since the effect of 
a heavily referenced
-*  key being stale is worse than that of a rarely referenced key. 
Unlike simply lowering
-*  $ttl, seldomly used keys are largely unaffected by this option, 
which makes it possible
-*  to have a high hit rate for the "long-tail" of less-used keys.
+*   - hotTTR: Expected time-till-refresh (TTR) in seconds for keys 
that average ~1 hit per
+*  second (e.g. 1Hz). Keys with a hit rate higher than 1Hz will 
refresh sooner than this
+*  TTR and vise versa. Such refreshes won't happen until keys are 
"ageNew" seconds old.
+*  The TTR is useful at reducing the impact of missed cache 
purges, since the effect of
+*  a heavily referenced key being stale is worse than that of a 
rarely referenced key.
+*  Unlike simply lowering $ttl, seldomly used keys are largely 
unaffected by this option,
+*  which makes it possible to have a high hit rate for the 
"long-tail" of less-used keys.
 *  Default: WANObjectCache::HOT_TTR.
 *   - lowTTL: Consider pre-emptive updates when the current TTL 
(seconds) of the key is less
 *  than this. It becomes more likely over time, becoming certain 
once the key is expired.
@@ -962,6 +970,7 @@
$lowTTL = isset( $opts['lowTTL'] ) ? $opts['lowTTL'] : min( 
self::LOW_TTL, $ttl );
$lockTSE = isset( $opts['lockTSE'] ) ? $opts['lockTSE'] : 
self::TSE_NONE;
$staleTTL = isset( $opts['staleTTL'] ) ? $opts['staleTTL'] : 
self::STALE_TTL_NONE;
+   $graceTTL = isset( $opts['graceTTL'] ) ? $opts['graceTTL'] : 
self::GRACE_TTL_NONE;
$checkKeys = isset( $opts['checkKeys'] ) ? $opts['checkKeys'] : 
[];
$busyValue = isset( $opts['busyValue'] ) ? $opts['busyValue'] : 
null;
$popWindow = isset( 

[MediaWiki-commits] [Gerrit] mediawiki...BetaFeatures[master]: Unify BetaFeatures SVG screenshot markup

[VolkerE (Code Review)]

VolkerE has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/393703 )

Change subject: Unify BetaFeatures SVG screenshot markup
..

Unify BetaFeatures SVG screenshot markup

Unifying BetaFeatures SVG screenshot markup by:
- removing unnecessary `standalone=no` attribute,
- changing `id`s for better readability,
- sorting attributes,
- using full pixel values where applicable and
- generalizing attributes on `g` where applicable
Results in 22 & 17% file size reduction before gzipping.
Follows up I60ad8fc3a475219f5b018d876e78f861396505bc.

Bug: T180427
Change-Id: I80ec68492cfd1d5142294686f641610a9b1c4f49
---
M resources/images/screenshot-template-ltr.svg
M resources/images/screenshot-template-rtl.svg
2 files changed, 27 insertions(+), 31 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/BetaFeatures 
refs/changes/03/393703/1

diff --git a/resources/images/screenshot-template-ltr.svg 
b/resources/images/screenshot-template-ltr.svg
index deed7ec..9af0d2d 100644
--- a/resources/images/screenshot-template-ltr.svg
+++ b/resources/images/screenshot-template-ltr.svg
@@ -1,23 +1,21 @@
-
-http://www.w3.org/2000/svg; id="svg2" viewBox="0 0 264 162" 
height="162" width="264">
-
+
+http://www.w3.org/2000/svg; width="264" height="162" viewBox="0 0 
264 162">
+
 
 
 
 
-
-
-
-
-
-
-
-
-
-
+
+
+
+
+
+
+
+
 
 
-
-
+
+
 
 
diff --git a/resources/images/screenshot-template-rtl.svg 
b/resources/images/screenshot-template-rtl.svg
index f795af8..36b9b11 100644
--- a/resources/images/screenshot-template-rtl.svg
+++ b/resources/images/screenshot-template-rtl.svg
@@ -1,23 +1,21 @@
-
-http://www.w3.org/2000/svg; id="svg2" viewBox="0 0 264 162" 
height="162" width="264">
-
+
+http://www.w3.org/2000/svg; width="264" height="162" viewBox="0 0 
264 162">
+
 
 
 
 
-
-
-
-
-
-
-
+
+
+
+
+
+
+
+
+
 
-
-
-
-
-
-
+
+
 
 

-- 
To view, visit https://gerrit.wikimedia.org/r/393703
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I80ec68492cfd1d5142294686f641610a9b1c4f49
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/BetaFeatures
Gerrit-Branch: master
Gerrit-Owner: VolkerE 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] performance[refs/meta/dashboards/custom]: Exclude CR<0 if from performance group

[Krinkle (Code Review)]

Krinkle has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/393702 )

Change subject: Exclude CR<0 if from performance group
..

Exclude CR<0 if from performance group

We already exclude CR -2 which is limited to repo maintainers.
For other cases we exclude all CR<0 because they are from ourselves.
Apply the same to this section by using the group= syntax of 'label:'.

This way, patches we -1 are hidden from "Todo review", but patches
-1'ed by other users don't result in such hiding.

Change-Id: I9546a0b8e8f534c86d553d2c5e7fe72552e8f455
---
M custom
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/performance refs/changes/02/393702/1

diff --git a/custom b/custom
index 600144b..1e167f6 100644
--- a/custom
+++ b/custom
@@ -4,7 +4,7 @@
 [section "Our patches awaiting review"]
   query = is:open ownerin:performance -owner:self -message:WIP -message:DNM 
-label:Verified<0 -label:Code-Review<0 limit:40
 [section "Other patches in subscribed areas"]
-  query = is:open -ownerin:performance -message:WIP -message:DNM 
-label:Verified<0 -label:Code-Review=-2 
(project:mediawiki/extensions/NavigationTiming OR 
project:mediawiki/extensions/PerformanceInspector OR project:performance OR 
project:performance/docroot OR project:performance/WebPageTest OR 
(project:mediawiki/core reviewerin:performance)) limit:20
+  query = is:open -ownerin:performance -message:WIP -message:DNM 
-label:Verified<0 -label:Code-Review=-2 -label:Code-Review<0,group=performance 
(project:mediawiki/extensions/NavigationTiming OR 
project:mediawiki/extensions/PerformanceInspector OR project:performance OR 
project:performance/docroot OR project:performance/WebPageTest OR 
(project:mediawiki/core reviewerin:performance)) limit:20
 [section "My patches awaiting review"]
   query = is:open ownerin:performance owner:self -message:WIP -message:DNM 
-label:Verified<0 -label:Code-Review<0 limit:40
 [section "My other patches"]

-- 
To view, visit https://gerrit.wikimedia.org/r/393702
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I9546a0b8e8f534c86d553d2c5e7fe72552e8f455
Gerrit-PatchSet: 1
Gerrit-Project: performance
Gerrit-Branch: refs/meta/dashboards/custom
Gerrit-Owner: Krinkle 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] performance[refs/meta/dashboards/custom]: Exclude CR<0 if from performance group

[Krinkle (Code Review)]

Krinkle has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/393702 )

Change subject: Exclude CR<0 if from performance group
..


Exclude CR<0 if from performance group

We already exclude CR -2 which is limited to repo maintainers.
For other cases we exclude all CR<0 because they are from ourselves.
Apply the same to this section by using the group= syntax of 'label:'.

This way, patches we -1 are hidden from "Todo review", but patches
-1'ed by other users don't result in such hiding.

Change-Id: I9546a0b8e8f534c86d553d2c5e7fe72552e8f455
---
M custom
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Krinkle: Verified; Looks good to me, approved



diff --git a/custom b/custom
index 600144b..1e167f6 100644
--- a/custom
+++ b/custom
@@ -4,7 +4,7 @@
 [section "Our patches awaiting review"]
   query = is:open ownerin:performance -owner:self -message:WIP -message:DNM 
-label:Verified<0 -label:Code-Review<0 limit:40
 [section "Other patches in subscribed areas"]
-  query = is:open -ownerin:performance -message:WIP -message:DNM 
-label:Verified<0 -label:Code-Review=-2 
(project:mediawiki/extensions/NavigationTiming OR 
project:mediawiki/extensions/PerformanceInspector OR project:performance OR 
project:performance/docroot OR project:performance/WebPageTest OR 
(project:mediawiki/core reviewerin:performance)) limit:20
+  query = is:open -ownerin:performance -message:WIP -message:DNM 
-label:Verified<0 -label:Code-Review=-2 -label:Code-Review<0,group=performance 
(project:mediawiki/extensions/NavigationTiming OR 
project:mediawiki/extensions/PerformanceInspector OR project:performance OR 
project:performance/docroot OR project:performance/WebPageTest OR 
(project:mediawiki/core reviewerin:performance)) limit:20
 [section "My patches awaiting review"]
   query = is:open ownerin:performance owner:self -message:WIP -message:DNM 
-label:Verified<0 -label:Code-Review<0 limit:40
 [section "My other patches"]

-- 
To view, visit https://gerrit.wikimedia.org/r/393702
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I9546a0b8e8f534c86d553d2c5e7fe72552e8f455
Gerrit-PatchSet: 1
Gerrit-Project: performance
Gerrit-Branch: refs/meta/dashboards/custom
Gerrit-Owner: Krinkle 
Gerrit-Reviewer: Krinkle 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] performance[refs/meta/dashboards/custom]: Also exclude WIP/DNM from "Other" section

[Krinkle (Code Review)]

Krinkle has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/393701 )

Change subject: Also exclude WIP/DNM from "Other" section
..


Also exclude WIP/DNM from "Other" section

Matches the logic of the other sections.

DNM = Do Not Merge.

Change-Id: I795a533233439a66831859fbc6af9ff484e8d1cb
---
M custom
1 file changed, 4 insertions(+), 4 deletions(-)

Approvals:
  Krinkle: Verified; Looks good to me, approved



diff --git a/custom b/custom
index 4c16292..600144b 100644
--- a/custom
+++ b/custom
@@ -2,12 +2,12 @@
   title = Performance Team
   description = Custom dashboard for the Performance Team
 [section "Our patches awaiting review"]
-  query = is:open ownerin:performance -owner:self -message:WIP -message:DNM 
-label:Verified<=-1 -label:Code-Review<=-1 limit:40
+  query = is:open ownerin:performance -owner:self -message:WIP -message:DNM 
-label:Verified<0 -label:Code-Review<0 limit:40
 [section "Other patches in subscribed areas"]
-  query = is:open -ownerin:performance -label:Verified<0 -label:Code-Review=-2 
(project:mediawiki/extensions/NavigationTiming OR 
project:mediawiki/extensions/PerformanceInspector OR project:performance OR 
project:performance/docroot OR project:performance/WebPageTest OR 
(project:mediawiki/core reviewerin:performance)) limit:20
+  query = is:open -ownerin:performance -message:WIP -message:DNM 
-label:Verified<0 -label:Code-Review=-2 
(project:mediawiki/extensions/NavigationTiming OR 
project:mediawiki/extensions/PerformanceInspector OR project:performance OR 
project:performance/docroot OR project:performance/WebPageTest OR 
(project:mediawiki/core reviewerin:performance)) limit:20
 [section "My patches awaiting review"]
-  query = is:open ownerin:performance owner:self -message:WIP -message:DNM 
-label:Verified<=-1 -label:Code-Review<=-1 limit:40
+  query = is:open ownerin:performance owner:self -message:WIP -message:DNM 
-label:Verified<0 -label:Code-Review<0 limit:40
 [section "My other patches"]
-  query = is:open ownerin:performance owner:self (message:WIP OR message:DNM 
OR label:Verified<=-1 OR label:Code-Review<=-1) limit:40
+  query = is:open ownerin:performance owner:self (message:WIP OR message:DNM 
OR label:Verified<0 OR label:Code-Review<0) limit:40
 [section "Recently merged"]
   query = is:merged ownerin:performance limit:30

-- 
To view, visit https://gerrit.wikimedia.org/r/393701
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I795a533233439a66831859fbc6af9ff484e8d1cb
Gerrit-PatchSet: 1
Gerrit-Project: performance
Gerrit-Branch: refs/meta/dashboards/custom
Gerrit-Owner: Krinkle 
Gerrit-Reviewer: Krinkle 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] performance[refs/meta/dashboards/custom]: Also exclude WIP/DNM from "Other" section

[Krinkle (Code Review)]

Krinkle has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/393701 )

Change subject: Also exclude WIP/DNM from "Other" section
..

Also exclude WIP/DNM from "Other" section

Matches the logic of the other sections.

DNM = Do Not Merge.

Change-Id: I795a533233439a66831859fbc6af9ff484e8d1cb
---
M custom
1 file changed, 4 insertions(+), 4 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/performance refs/changes/01/393701/1

diff --git a/custom b/custom
index 4c16292..600144b 100644
--- a/custom
+++ b/custom
@@ -2,12 +2,12 @@
   title = Performance Team
   description = Custom dashboard for the Performance Team
 [section "Our patches awaiting review"]
-  query = is:open ownerin:performance -owner:self -message:WIP -message:DNM 
-label:Verified<=-1 -label:Code-Review<=-1 limit:40
+  query = is:open ownerin:performance -owner:self -message:WIP -message:DNM 
-label:Verified<0 -label:Code-Review<0 limit:40
 [section "Other patches in subscribed areas"]
-  query = is:open -ownerin:performance -label:Verified<0 -label:Code-Review=-2 
(project:mediawiki/extensions/NavigationTiming OR 
project:mediawiki/extensions/PerformanceInspector OR project:performance OR 
project:performance/docroot OR project:performance/WebPageTest OR 
(project:mediawiki/core reviewerin:performance)) limit:20
+  query = is:open -ownerin:performance -message:WIP -message:DNM 
-label:Verified<0 -label:Code-Review=-2 
(project:mediawiki/extensions/NavigationTiming OR 
project:mediawiki/extensions/PerformanceInspector OR project:performance OR 
project:performance/docroot OR project:performance/WebPageTest OR 
(project:mediawiki/core reviewerin:performance)) limit:20
 [section "My patches awaiting review"]
-  query = is:open ownerin:performance owner:self -message:WIP -message:DNM 
-label:Verified<=-1 -label:Code-Review<=-1 limit:40
+  query = is:open ownerin:performance owner:self -message:WIP -message:DNM 
-label:Verified<0 -label:Code-Review<0 limit:40
 [section "My other patches"]
-  query = is:open ownerin:performance owner:self (message:WIP OR message:DNM 
OR label:Verified<=-1 OR label:Code-Review<=-1) limit:40
+  query = is:open ownerin:performance owner:self (message:WIP OR message:DNM 
OR label:Verified<0 OR label:Code-Review<0) limit:40
 [section "Recently merged"]
   query = is:merged ownerin:performance limit:30

-- 
To view, visit https://gerrit.wikimedia.org/r/393701
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I795a533233439a66831859fbc6af9ff484e8d1cb
Gerrit-PatchSet: 1
Gerrit-Project: performance
Gerrit-Branch: refs/meta/dashboards/custom
Gerrit-Owner: Krinkle 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] apps...wikipedia[master]: Create app-wide onboarding screens introducing new users to ...

[Cooltey (Code Review)]

Cooltey has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/393700 )

Change subject: Create app-wide onboarding screens introducing new users to the 
app and its features  - Update images and texts
..

Create app-wide onboarding screens introducing new users to the app and its 
features
 - Update images and texts

Bug: T181149
Change-Id: Iea91e977ddefb020e6d1dc679e54f1e6c5dad7de
---
M app/src/main/java/org/wikipedia/onboarding/InitialOnboardingFragment.java
M app/src/main/java/org/wikipedia/onboarding/OnboardingPageView.java
M app/src/main/java/org/wikipedia/util/FeedbackUtil.java
A app/src/main/res/drawable/ic_illustration_app_onboarding_0.xml
A app/src/main/res/drawable/ic_illustration_app_onboarding_1_alt.xml
A app/src/main/res/drawable/ic_illustration_reading_list_offline.xml
M app/src/main/res/layout/inflate_initial_onboarding_page_one.xml
M app/src/main/res/layout/inflate_initial_onboarding_page_two.xml
A app/src/main/res/layout/inflate_initial_onboarding_page_zero.xml
M app/src/main/res/values-qq/strings.xml
M app/src/main/res/values/strings.xml
11 files changed, 363 insertions(+), 11 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/apps/android/wikipedia 
refs/changes/00/393700/1

diff --git 
a/app/src/main/java/org/wikipedia/onboarding/InitialOnboardingFragment.java 
b/app/src/main/java/org/wikipedia/onboarding/InitialOnboardingFragment.java
index 9f78cbc..7fc85a8 100644
--- a/app/src/main/java/org/wikipedia/onboarding/InitialOnboardingFragment.java
+++ b/app/src/main/java/org/wikipedia/onboarding/InitialOnboardingFragment.java
@@ -63,6 +63,8 @@
 Constants.ACTIVITY_REQUEST_LOGIN);
 } else if (url.equals("#privacy")) {
 FeedbackUtil.showPrivacyPolicy(getContext());
+} else if (url.equals("#about")) {
+FeedbackUtil.showAboutWikipedia(getContext());
 } else  {
 handleExternalLink(getActivity(), Uri.parse(url));
 }
@@ -106,6 +108,7 @@
 }
 
 private enum OnboardingPage implements EnumCode {
+PAGE_WELCOME(R.layout.inflate_initial_onboarding_page_zero),
 PAGE_EXPLORE(R.layout.inflate_initial_onboarding_page_one),
 PAGE_READING_LISTS(R.layout.inflate_initial_onboarding_page_two),
 PAGE_USAGE_DATA(R.layout.inflate_initial_onboarding_page_three);
diff --git a/app/src/main/java/org/wikipedia/onboarding/OnboardingPageView.java 
b/app/src/main/java/org/wikipedia/onboarding/OnboardingPageView.java
index 803b8f2..857261d 100644
--- a/app/src/main/java/org/wikipedia/onboarding/OnboardingPageView.java
+++ b/app/src/main/java/org/wikipedia/onboarding/OnboardingPageView.java
@@ -119,13 +119,10 @@
 switchView.setText(switchText);
 
 secondaryTextView.setMovementMethod(new LinkMovementMethodExt(
-new LinkMovementMethodExt.UrlHandler() {
-@Override
-public void onUrlClick(@NonNull String url, @Nullable 
String notUsed) {
+(@NonNull String url, @Nullable String notUsed) -> {
 if (callback != null) {
 callback.onLinkClick(OnboardingPageView.this, 
url);
 }
-}
 }));
 
 array.recycle();
diff --git a/app/src/main/java/org/wikipedia/util/FeedbackUtil.java 
b/app/src/main/java/org/wikipedia/util/FeedbackUtil.java
index c2bdc38..3c46544 100644
--- a/app/src/main/java/org/wikipedia/util/FeedbackUtil.java
+++ b/app/src/main/java/org/wikipedia/util/FeedbackUtil.java
@@ -87,6 +87,10 @@
 visitInExternalBrowser(context, 
Uri.parse(context.getString(R.string.privacy_policy_url)));
 }
 
+public static void showAboutWikipedia(Context context) {
+visitInExternalBrowser(context, 
Uri.parse(context.getString(R.string.about_wikipedia_url)));
+}
+
 public static void setToolbarButtonLongPressToast(View... views) {
 for (View v : views) {
 v.setOnLongClickListener(TOOLBAR_LONG_CLICK_LISTENER);
diff --git a/app/src/main/res/drawable/ic_illustration_app_onboarding_0.xml 
b/app/src/main/res/drawable/ic_illustration_app_onboarding_0.xml
new file mode 100644
index 000..6fce1b5
--- /dev/null
+++ b/app/src/main/res/drawable/ic_illustration_app_onboarding_0.xml
@@ -0,0 +1,104 @@
+http://schemas.android.com/apk/res/android;
+android:width="160dp"
+android:height="160dp"
+android:viewportWidth="160.0"
+android:viewportHeight="160.0">
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
diff --git a/app/src/main/res/drawable/ic_illustration_app_onboarding_1_alt.xml 

[MediaWiki-commits] [Gerrit] mediawiki...DonationInterface[master]: TEST

[Reedy (Code Review)]

Reedy has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/393699 )

Change subject: TEST
..

TEST

Change-Id: I295653202fe122d4b419eb43a1c4fd7a81919b86
---
M README.txt
1 file changed, 2 insertions(+), 0 deletions(-)


  git pull 
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/DonationInterface 
refs/changes/99/393699/1

diff --git a/README.txt b/README.txt
index 1781e10..a2ceb4a 100644
--- a/README.txt
+++ b/README.txt
@@ -1,3 +1,5 @@
+VANDALISM ZOMG
+
 Donation Interface
 
 To install the DontaionInterface extension, put the following line in 
LocalSettings.php:

-- 
To view, visit https://gerrit.wikimedia.org/r/393699
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I295653202fe122d4b419eb43a1c4fd7a81919b86
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/DonationInterface
Gerrit-Branch: master
Gerrit-Owner: Reedy 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...MinervaNeue[master]: Hygiene: Refactor Minerva history link generation

[jenkins-bot (Code Review)]

jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/392890 )

Change subject: Hygiene: Refactor Minerva history link generation
..


Hygiene: Refactor Minerva history link generation

* Create several sub functions to manage complexity of the history link
* Clean up MinervaTemplate to use data directly and remove isMainPage
template variable which is no longer being used.

Change-Id: I124aec9637f3635a335c58e559e578b2a56eb4c5
---
M includes/skins/MinervaTemplate.php
M includes/skins/SkinMinerva.php
M includes/skins/history.mustache
M includes/skins/minerva.mustache
4 files changed, 78 insertions(+), 70 deletions(-)

Approvals:
  Bmansurov: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/includes/skins/MinervaTemplate.php 
b/includes/skins/MinervaTemplate.php
index d747916..7726d05 100644
--- a/includes/skins/MinervaTemplate.php
+++ b/includes/skins/MinervaTemplate.php
@@ -107,18 +107,11 @@
protected function getHistoryLinkHtml( $data ) {
$action = Action::getActionName( RequestContext::getMain() );
if ( isset( $data['historyLink'] ) && $action === 'view' ) {
-   $historyLink = $data['historyLink'];
$args = [
'clockIconClass' => MinervaUI::iconClass( 
'clock-gray', 'before' ),
'arrowIconClass' => MinervaUI::iconClass(
'arrow-gray', 'element', 
'mw-ui-icon-small mf-mw-ui-icon-rotate-anti-clockwise indicator' ),
-   'isMainPage' => 
$this->getSkin()->getTitle()->isMainPage(),
-   'link' => $historyLink['href'],
-   'text' => $historyLink['text'],
-   'username' => $historyLink['data-user-name'],
-   'userGender' => 
$historyLink['data-user-gender'],
-   'timestamp' => $historyLink['data-timestamp']
-   ];
+   ] + $data['historyLink'];
$templateParser = new TemplateParser( __DIR__ );
return $templateParser->processTemplate( 'history', 
$args );
} else {
diff --git a/includes/skins/SkinMinerva.php b/includes/skins/SkinMinerva.php
index 4b7ccaa..d5e3d2e 100644
--- a/includes/skins/SkinMinerva.php
+++ b/includes/skins/SkinMinerva.php
@@ -718,16 +718,60 @@
}
 
/**
+* Get a history link which describes author and relative time of last 
edit
+* @param Title $title The Title object of the page being viewed
+* @param int $timestamp
+* @return array
+*/
+   protected function getRelativeHistoryLink( Title $title, $timestamp ) {
+   $user = $this->getUser();
+   $text = $this->msg(
+   'minerva-last-modified-date',
+   $this->getLanguage()->userDate( $timestamp, $user ),
+   $this->getLanguage()->userTime( $timestamp, $user )
+   )->parse();
+   return [
+   // Use $edit['timestamp'] (Unix format) instead of 
$timestamp (MW format)
+   'data-timestamp' => wfTimestamp( TS_UNIX, $timestamp ),
+   'href' => $this->getHistoryUrl( $title ),
+   'text' => $text,
+   ] + $this->getRevisionEditorData( $title );
+   }
+
+   /**
+* Get a history link which makes no reference to user or last edited 
time
+* @param Title $title The Title object of the page being viewed
+* @return array
+*/
+   protected function getGenericHistoryLink( Title $title ) {
+   $text = $this->msg( 'mobile-frontend-history' )->plain();
+   return [
+   'href' => $this->getHistoryUrl( $title ),
+   'text' => $text,
+   ];
+   }
+
+   /**
+* Get the URL for the history page for the given title using 
Special:History
+* when available.
+* @param Title $title The Title object of the page being viewed
+* @return string
+*/
+   protected function getHistoryUrl( Title $title ) {
+   return SpecialPageFactory::exists( 'History' ) ?
+   SpecialPage::getTitleFor( 'History', $title 
)->getLocalURL() :
+   $title->getLocalURL( [ 'action' => 'history' ] );
+   }
+
+   /**
 * Prepare the content for the 'last edited' message, e.g. 'Last edited 
on 30 August
 * 2013, at 23:31'. This message is different for the main page since 
main page
 * content is typically transcuded rather than edited directly.
 * @param Title $title The Title object of the page being viewed
-* @param 

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Add WebAssembly application/wasm MIME type

[jenkins-bot (Code Review)]

jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/392567 )

Change subject: Add WebAssembly application/wasm MIME type
..


Add WebAssembly application/wasm MIME type

Needed to get TimedMediaHandler's .wasm binaries for latest version
of ogv.js working via the static.php intermediary, which uses
StreamFile::contentTypeFromPath() to check MIME types and refuses
to serve out the file if it's unknown.

Bug: T179108
Bug: T181022
Change-Id: Ic15c4d985a9cac9e685b12876804504e6eb46171
---
M includes/libs/mime/mime.info
M includes/libs/mime/mime.types
2 files changed, 2 insertions(+), 0 deletions(-)

Approvals:
  jenkins-bot: Verified
  Jforrester: Looks good to me, approved



diff --git a/includes/libs/mime/mime.info b/includes/libs/mime/mime.info
index d8b8be7..3670243 100644
--- a/includes/libs/mime/mime.info
+++ b/includes/libs/mime/mime.info
@@ -87,6 +87,7 @@
 application/x-tcl  [EXECUTABLE]
 application/x-perl [EXECUTABLE]
 application/x-python   [EXECUTABLE]
+application/wasm   [EXECUTABLE]
 
 application/pdf application/acrobat[OFFICE]
 application/msword [OFFICE]
diff --git a/includes/libs/mime/mime.types b/includes/libs/mime/mime.types
index f1cd59d..ef6854c 100644
--- a/includes/libs/mime/mime.types
+++ b/includes/libs/mime/mime.types
@@ -187,3 +187,4 @@
 chemical/x-mdl-rgfile rg
 application/x-amf amf
 application/sla stl
+application/wasm wasm

-- 
To view, visit https://gerrit.wikimedia.org/r/392567
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ic15c4d985a9cac9e685b12876804504e6eb46171
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Brion VIBBER 
Gerrit-Reviewer: Jforrester 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] operations/puppet[production]: grafana: add dashboard for cloud

[Dzahn (Code Review)]

Dzahn has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/393698 )

Change subject: grafana: add dashboard for cloud
..

grafana: add dashboard for cloud

Change-Id: I524da22a4726f37a58846bad40ef6853ae01a5d7
---
A modules/grafana/files/dashboards/cloud-codfw
1 file changed, 28,145 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/operations/puppet 
refs/changes/98/393698/1


-- 
To view, visit https://gerrit.wikimedia.org/r/393698
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I524da22a4726f37a58846bad40ef6853ae01a5d7
Gerrit-PatchSet: 1
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Dzahn 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...TimedMediaHandler[master]: Enable MP3 audio transcodes by default

[jenkins-bot (Code Review)]

jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/380791 )

Change subject: Enable MP3 audio transcodes by default
..


Enable MP3 audio transcodes by default

Currently TimedMediaHandler's frontend code doesn't work on the mobile
view, which means we don't load the ogv.js shim for Mobile Safari.
Creating MP3 transcodes for audio means they can get used directly
in the mobile view, fixing audio playback for iPhone/iPad and
probably Windows Mobile and other "misc" OSs.

Note that on desktop Safari/IE/Edge, ogv.js is still used because Ogg
has a higher priority than MP3. This may be changed later.

Relevant MP3 patents are believed to now be expired.

Bug: T165717
Change-Id: Ia06e3a3fe18628b378f786197da430515d9d92d3
---
M TimedMediaHandler.php
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  jenkins-bot: Verified
  Jforrester: Looks good to me, approved



diff --git a/TimedMediaHandler.php b/TimedMediaHandler.php
index 0cade78..80b410d 100644
--- a/TimedMediaHandler.php
+++ b/TimedMediaHandler.php
@@ -225,7 +225,7 @@
// WebVideoTranscode::ENC_OGG_OPUS,
 
// avconv needs libmp3lame support
-   // WebVideoTranscode::ENC_MP3,
+   WebVideoTranscode::ENC_MP3,
 
// avconv needs libvo_aacenc support
// WebVideoTranscode::ENC_AAC,

-- 
To view, visit https://gerrit.wikimedia.org/r/380791
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ia06e3a3fe18628b378f786197da430515d9d92d3
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/TimedMediaHandler
Gerrit-Branch: master
Gerrit-Owner: Brion VIBBER 
Gerrit-Reviewer: Jforrester 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] RelPath[master]: Move global functions into Wikimedia\RelPath class

[jenkins-bot (Code Review)]

jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/375931 )

Change subject: Move global functions into Wikimedia\RelPath class
..


Move global functions into Wikimedia\RelPath class

Change-Id: I65a8d36a5e74b9614c1109c19b66f99c66c8809c
---
M README.md
M composer.json
D src/RelPath.php
A src/RelPath/RelPath.php
A src/Wikimedia/RelPath.php
M tests/RelPathTest.php
6 files changed, 224 insertions(+), 157 deletions(-)

Approvals:
  Krinkle: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/README.md b/README.md
index 421be52..0595c9c 100644
--- a/README.md
+++ b/README.md
@@ -7,10 +7,10 @@
 Here is how you use it:
 
 
-$relPath = RelPath\getRelativePath( '/srv/mediawiki/resources/src/startup.js', 
'/srv/mediawiki' );
+$relPath = \Wikimedia\RelPath::getRelativePath( 
'/srv/mediawiki/resources/src/startup.js', '/srv/mediawiki' );
 // Result: string(24) "resources/src/startup.js"
 
-$fullPath = RelPath\joinPath( '/srv/mediawiki', 'resources/src/startup.js' );
+$fullPath = \Wikimedia\RelPath::joinPath( '/srv/mediawiki', 
'resources/src/startup.js' );
 // Result: string(39) "/srv/mediawiki/resources/src/startup.js"
 
 
diff --git a/composer.json b/composer.json
index bbe8ff5..402ade4 100644
--- a/composer.json
+++ b/composer.json
@@ -11,7 +11,8 @@
],
"autoload": {
"files": [
-   "src/RelPath.php"
+   "src/RelPath/RelPath.php",
+   "src/Wikimedia/RelPath.php"
]
},
"require": {
diff --git a/src/RelPath.php b/src/RelPath.php
deleted file mode 100644
index 86103c0..000
--- a/src/RelPath.php
+++ /dev/null
@@ -1,152 +0,0 @@
-
- *
- * Permission is hereby granted, free of charge, to any person obtaining
- * a copy of this software and associated documentation files (the
- * "Software"), to deal in the Software without restriction, including
- * without limitation the rights to use, copy, modify, merge, publish,
- * distribute, sublicense, and/or sell copies of the Software, and to
- * permit persons to whom the Software is furnished to do so, subject to
- * the following conditions:
- *
- * The above copyright notice and this permission notice shall be
- * included in all copies or substantial portions of the Software.
- *
- * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND,
- * EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF
- * MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT.
- * IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY
- * CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT,
- * TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE
- * SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.
- *
- * @file
- * @author Ori Livneh 
- */
-
-namespace RelPath;
-
-/**
- * Split a path into path components.
- *
- * @param string $path File path.
- * @return array Array of path components.
- */
-function splitPath( $path ) {
-   $fragments = [];
-
-   while ( true ) {
-   $cur = dirname( $path );
-   if ( $cur[0] === DIRECTORY_SEPARATOR ) {
-   // dirname() on Windows sometimes returns a leading 
backslash, but other
-   // times retains the leading forward slash. Slashes 
other than the leading one
-   // are returned as-is, and therefore do not need to be 
touched.
-   // Furthermore, don't break on *nix where \ is allowed 
in file/directory names.
-   $cur[0] = '/';
-   }
-
-   if ( $cur === $path || ( $cur === '.' && basename( $path ) === 
$path ) ) {
-   break;
-   }
-
-   $fragment = trim( substr( $path, strlen( $cur ) ), '/' );
-
-   if ( !$fragments ) {
-   $fragments[] = $fragment;
-   } elseif ( $fragment === '..' && basename( $cur ) !== '..' ) {
-   $cur = dirname( $cur );
-   } elseif ( $fragment !== '.' ) {
-   $fragments[] = $fragment;
-   }
-
-   $path = $cur;
-   }
-
-   if ( $path !== '' ) {
-   $fragments[] = trim( $path, '/' );
-   }
-
-   return array_reverse( $fragments );
-}
-
-/**
- * Return a relative filepath to path either from the current directory or from
- * an optional start directory. Both paths must be absolute.
- *
- * @param string $path File path.
- * @param string $start Start directory. Optional; if not specified, the 
current
- *  working directory will be used.
- * @return string|bool Relative path, or false if input was invalid.
- */
-function getRelativePath( $path, $start = null ) {
-   if ( $start === null ) {
-   // @codeCoverageIgnoreStart
-

[MediaWiki-commits] [Gerrit] mediawiki...CirrusSearch[master]: Fix create_new_page.feature with ruby

[jenkins-bot (Code Review)]

jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/393125 )

Change subject: Fix create_new_page.feature with ruby
..


Fix create_new_page.feature with ruby

I think this test was broken, the step it refers to does not exist and
some of the queries used could no match to Catapult.
It seems to ignore missing steps.
Flipped amazing-catapult to catapult-amazing because being on a random
we hit the go feature to Amazing Catapult bypassing the srp.

Change-Id: Ibacb14218608e05b9c806171d536581dc89c2a6c
---
M tests/browser/features/create_new_page.feature
1 file changed, 43 insertions(+), 43 deletions(-)

Approvals:
  Cindy-the-browser-test-bot: Looks good to me, but someone else must approve
  EBernhardson: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/tests/browser/features/create_new_page.feature 
b/tests/browser/features/create_new_page.feature
index e92a9e5..fd4d01e 100644
--- a/tests/browser/features/create_new_page.feature
+++ b/tests/browser/features/create_new_page.feature
@@ -23,65 +23,65 @@
   Scenario Outline: boolean operators in bad positions in the query are 
ignored so you get the option to create a new page
 When I search for 
 Then there is no warning
-  And Catapult is in the first search result
+  And  is the first search result
   And there is a link to create a new page from the search result
   Examples:
-  | query  |
-  | catapult + |
-  | catapult - |
-  | catapult ! |
+  | query  | page |
+  | catapult + | Catapult |
+  | catapult - | Catapult |
+  | catapult ! | Catapult |
   # Bug 60362
-  #| catapult AND   |
-  #| catapult OR|
-  #| catapult NOT   |
-  | + catapult |
-  | - catapult |
-  | ! catapult |
+  #| catapult AND   | Catapult |
+  #| catapult OR| Catapult |
+  #| catapult NOT   | Catapult |
+  | + catapult | Catapult |
+  | - catapult | Catapult |
+  | ! catapult | Catapult |
   # Bug 60362
-  #| AND catapult   |
-  #| OR catapult|
-  | catapult + amazing |
-  | catapult - amazing |
-  | catapult ! amazing |
-  | amazing+catapult   |
-  | amazing-catapult   |
-  | amazing!catapult   |
-  | catapult!!!|
-  | catapult   |
-  |  catapult  |
-  | --- catapult   |
-  |  catapult  |
-  | ++amazingcatapult  |
-  | catapult ~/|
-  | catapult ~/|
-  | amazing~◆~catapult |
-  | *** catapult   |
+  #| AND catapult   | Catapult |
+  #| OR catapult| Catapult |
+  | catapult + amazing | Amazing Catapult |
+  | catapult - amazing | Amazing Catapult |
+  | catapult ! amazing | Amazing Catapult |
+  | amazing+catapult   | Amazing Catapult |
+  | catapult-amazing   | Amazing Catapult |
+  | amazing!catapult   | Amazing Catapult |
+  | catapult!!!| Catapult |
+  | catapult   | Catapult |
+  |  catapult  | Catapult |
+  | --- catapult   | Catapult |
+  |  catapult  | Catapult |
+  | ++amazingcatapult  | Amazing Catapult |
+  | catapult ~/| Catapult |
+  | catapult ~/| Catapult |
+  | amazing~◆~catapult | Amazing Catapult |
+  | *** catapult   | Catapult |
 
   @boolean_operators
   Scenario Outline: boolean operators in bad positions in the query are 
ignored but if there are other valid operators then you don't get the option to 
create a new page
 When I search for 
 Then there is no warning
-  And Catapult is in the first search result
+  And  is the first search result
   And there is no link to create a new page from the search result
   Examples:
-  | query  |
-  | catapult AND + amazing |
-  | catapult AND - amazing |
-  | catapult AND ! amazing |
-  | catapult \|\|---   |
-  | catapult[[\|\|.\|\|\|\|\|\|+\|+\|==\\*.$.$.$. |
-  | T:8~=~¥9:77:7:57;7;76;6346- OR catapult |
-  | catapult OR T:8~=~¥9:77:7:57;7;76;6346- |
-  | --- AND catapult   |
-  | *catapult* |
-  | ***catapult*   |
-  | ** catapult*   |
+  | query  | page |
+  | catapult AND + amazing | Amazing Catapult |
+  | catapult AND - amazing | Amazing Catapult |
+  | catapult AND ! amazing | Amazing Catapult |
+  | catapult \|\|---   | Catapult |
+  | catapult[[\|\|.\|\|\|\|\|\|+\|+\|==\\*.$.$.$. | Catapult |
+  | T:8~=~¥9:77:7:57;7;76;6346- OR catapult | Catapult |
+  | catapult OR 

[MediaWiki-commits] [Gerrit] mediawiki...DonationInterface[master]: Remove UnitTestsList hook subscriber

[Reedy (Code Review)]

Reedy has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/393697 )

Change subject: Remove UnitTestsList hook subscriber
..

Remove UnitTestsList hook subscriber

Bug: T142121
Change-Id: I69db60beef1de49c13ff6dc567c1a38b4e891abf
---
M DonationInterface.class.php
M extension.json
2 files changed, 0 insertions(+), 38 deletions(-)


  git pull 
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/DonationInterface 
refs/changes/97/393697/1

diff --git a/DonationInterface.class.php b/DonationInterface.class.php
index 44821e1..59a0b3f 100644
--- a/DonationInterface.class.php
+++ b/DonationInterface.class.php
@@ -53,39 +53,6 @@
}
}
 
-   public static function onDonationInterfaceUnitTests( &$files ) {
-   global $wgAutoloadClasses;
-
-   $testDir = __DIR__ . '/tests/phpunit/';
-
-   // Set up globaltown
-   if ( file_exists( $testDir . 'TestConfiguration.php' ) ) {
-   require_once $testDir . 'TestConfiguration.php';
-   } else {
-   return true;
-   }
-
-   $files[] = $testDir . 'AllTests.php';
-
-   $wgAutoloadClasses['DonationInterfaceTestCase'] = $testDir . 
'DonationInterfaceTestCase.php';
-   $wgAutoloadClasses['DonationInterfaceApiTestCase'] = $testDir . 
'DonationInterfaceApiTestCase.php';
-   $wgAutoloadClasses['BaseIngenicoTestCase'] = $testDir . 
'BaseIngenicoTestCase.php';
-   $wgAutoloadClasses['TestingAdyenAdapter'] = $testDir . 
'includes/test_gateway/TestingAdyenAdapter.php';
-   $wgAutoloadClasses['TestingAstroPayAdapter'] = $testDir . 
'includes/test_gateway/TestingAstroPayAdapter.php';
-   $wgAutoloadClasses['TestingDonationLogger'] = $testDir . 
'includes/TestingDonationLogger.php';
-   $wgAutoloadClasses['TestingGatewayPage'] = $testDir . 
'includes/TestingGatewayPage.php';
-   $wgAutoloadClasses['TestingGenericAdapter'] = $testDir . 
'includes/test_gateway/TestingGenericAdapter.php';
-   $wgAutoloadClasses['TestingGlobalCollectAdapter'] = $testDir . 
'includes/test_gateway/TestingGlobalCollectAdapter.php';
-   $wgAutoloadClasses['TestingGlobalCollectOrphanAdapter'] = 
$testDir . 'includes/test_gateway/TestingGlobalCollectOrphanAdapter.php';
-   $wgAutoloadClasses['TestingPaypalExpressAdapter'] = $testDir . 
'includes/test_gateway/TestingPaypalExpressAdapter.php';
-   $wgAutoloadClasses['TestingPaypalLegacyAdapter'] = $testDir . 
'includes/test_gateway/TestingPaypalLegacyAdapter.php';
-
-   $wgAutoloadClasses['TestingRequest'] = $testDir . 
'includes/test_request/test.request.php';
-   $wgAutoloadClasses['TTestingAdapter'] = $testDir . 
'includes/test_gateway/test.adapter.php';
-
-   return true;
-   }
-
public static function getAdapterClassForGateway( $gateway ) {
global $wgDonationInterfaceGatewayAdapters;
if ( !key_exists( $gateway, $wgDonationInterfaceGatewayAdapters 
) ) {
diff --git a/extension.json b/extension.json
index d841370..ba44890 100644
--- a/extension.json
+++ b/extension.json
@@ -296,11 +296,6 @@
"localBasePath": "",
"remoteExtPath": "DonationInterface"
},
-   "Hooks": {
-   "UnitTestsList": [
-   "DonationInterface::onDonationInterfaceUnitTests"
-   ]
-   },
"config": {
"DonationInterfaceTest": false,
"DonationInterfaceAppealWikiTemplate": 
"LanguageSwitch|2011FR/$appeal/text|$language",

-- 
To view, visit https://gerrit.wikimedia.org/r/393697
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I69db60beef1de49c13ff6dc567c1a38b4e891abf
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/DonationInterface
Gerrit-Branch: master
Gerrit-Owner: Reedy 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...CirrusSearch[master]: Port go_browser.feature to nodejs

[jenkins-bot (Code Review)]

jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/393076 )

Change subject: Port go_browser.feature to nodejs
..


Port go_browser.feature to nodejs

- introduced TitlePage and moved the title param to it.
  I found it misleading to have a title param for pages like /w/index.php
- added wiki support on World.visit
- added search_steps to reflect what we had with ruby but "browser_steps"
  would probably be more approriate

Change-Id: I6bba0baac4a8f565508eb2b153c0c27a2af8f23c
---
M tests/integration/config/wdio.conf.js
A tests/integration/features/go_browser.feature
M tests/integration/features/step_definitions/page_steps.js
A tests/integration/features/step_definitions/search_steps.js
M tests/integration/features/support/pages/article_page.js
M tests/integration/features/support/pages/page.js
A tests/integration/features/support/pages/search_results_page.js
M tests/integration/features/support/pages/special_version.js
A tests/integration/features/support/pages/title_page.js
M tests/integration/features/support/world.js
10 files changed, 119 insertions(+), 40 deletions(-)

Approvals:
  Cindy-the-browser-test-bot: Looks good to me, but someone else must approve
  EBernhardson: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/tests/integration/config/wdio.conf.js 
b/tests/integration/config/wdio.conf.js
index c30dcb2..1af44b6 100644
--- a/tests/integration/config/wdio.conf.js
+++ b/tests/integration/config/wdio.conf.js
@@ -39,17 +39,20 @@
cirrustest: {
username: 'Admin',
password: 'vagrant',
-   apiUrl: 
'http://cirrustest.wiki.local.wmftest.net:8080/w/api.php'
+   apiUrl: 
'http://cirrustest.wiki.local.wmftest.net:8080/w/api.php',
+   baseUrl: 'http://cirrustest.wiki.local.wmftest.net:8080'
},
commons: {
username: 'Admin',
password: 'vagrant',
-   apiUrl: 
'http://commons.wiki.local.wmftest.net:8080/w/api.php'
+   apiUrl: 
'http://commons.wiki.local.wmftest.net:8080/w/api.php',
+   baseUrl: 'http://cirrustest.wiki.local.wmftest.net:8080'
},
ru: {
username: 'Admin',
password: 'vagrant',
-   apiUrl: 
'http://ru.wiki.local.wmftest.net:8080/w/api.php'
+   apiUrl: 
'http://ru.wiki.local.wmftest.net:8080/w/api.php',
+   baseUrl: 'http://ru.wiki.local.wmftest.net:8080'
},
beta: {},
test2: {},
@@ -84,7 +87,8 @@
relPath('./integration/features/support/world.js'),
relPath('./integration/features/support/hooks.js'),

relPath('./integration/features/step_definitions/page_step_helpers.js'),
-   
relPath('./integration/features/step_definitions/page_steps.js')
+   
relPath('./integration/features/step_definitions/page_steps.js'),
+   
relPath('./integration/features/step_definitions/search_steps.js')
]
},
// Patterns to exclude.
@@ -145,18 +149,6 @@
//
// Saves a screenshot to a given path if a command fails.
screenshotPath: './log/',
-   //
-   // Set a base URL in order to shorten url command calls. If your url 
parameter starts
-   // with "/", then the base url gets prepended.
-   baseUrl: (
-   process.env.MW_SERVER === undefined ?
-   'http://dev.wiki.local.wmftest.net:8080' :
-   process.env.MW_SERVER
-   ) + (
-   process.env.MW_SCRIPT_PATH === undefined ?
-   '/w' :
-   process.env.MW_SCRIPT_PATH
-   ),
//
// Default timeout for all waitFor* commands.
waitforTimeout: 2,
diff --git a/tests/integration/features/go_browser.feature 
b/tests/integration/features/go_browser.feature
new file mode 100644
index 000..b92d70f
--- /dev/null
+++ b/tests/integration/features/go_browser.feature
@@ -0,0 +1,20 @@
+@clean @go @phantomjs
+Feature: Go Search
+  @from_core
+  Scenario: I can "go" to a user's page whether it is there or not
+When I go search for User:DoesntExist
+Then I am on a page titled User:DoesntExist
+
+  @options
+  Scenario Outline: When I near match more than one page but one is exact 
(case, modulo case, or converted to title case) I go to that page
+When I go search for  Nearmatchflattentest
+Then I am on a page titled  Nearmatchflattentest
+  Examples:
+|  term  |  title  |
+| bach   | Johann Sebastian Bach |
+| Søn Redirectnoncompete | Blah 

[MediaWiki-commits] [Gerrit] mediawiki...CirrusSearch[master]: Port commons.feature to nodejs

[jenkins-bot (Code Review)]

jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/392987 )

Change subject: Port commons.feature to nodejs
..


Port commons.feature to nodejs

Change-Id: I43075458594338eab49375da1697ed5114583bea
---
A tests/integration/features/commons.feature
M tests/integration/features/step_definitions/page_step_helpers.js
M tests/integration/features/step_definitions/page_steps.js
3 files changed, 65 insertions(+), 10 deletions(-)

Approvals:
  Cindy-the-browser-test-bot: Looks good to me, but someone else must approve
  EBernhardson: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/tests/integration/features/commons.feature 
b/tests/integration/features/commons.feature
new file mode 100644
index 000..b36867b
--- /dev/null
+++ b/tests/integration/features/commons.feature
@@ -0,0 +1,12 @@
+@clean @api @commons
+Feature: Searching for files on local wiki stored on commons
+  Scenario: A file that exists only on commons can be found on the local wiki
+When I api search in namespace 6 for oncommons
+Then File:OnCommons.svg is the first api search result
+
+  Scenario: A file that exists on commons and the local wiki returns the local 
result
+When within 20 seconds File:DuplicatedLocally.svg has cirrustestwiki as 
local_sites_with_dupe
+Then I api search in namespace 6 for duplicated
+Then File:DuplicatedLocally.svg is the first api search result
+And Locally stored file *duplicated* on commons is the highlighted snippet 
of the first api search result
+And there are 1 api search results
diff --git a/tests/integration/features/step_definitions/page_step_helpers.js 
b/tests/integration/features/step_definitions/page_step_helpers.js
index 730e3b3..0b37135 100644
--- a/tests/integration/features/step_definitions/page_step_helpers.js
+++ b/tests/integration/features/step_definitions/page_step_helpers.js
@@ -163,7 +163,17 @@
} ).call( this );
}
 
-   checkExists( title ) {
+   /**
+* Call query api with cirrusdoc prop to return the docs identified
+* by title that are indexed in elasticsearch.
+*
+* NOTE: Multiple docs can be returned if the doc identified by title 
is indexed
+* over multiple indices (content/general).
+*
+* @param {string} title page title
+* @returns {Promise.<[]>} resolves to an array of indexed docs or null 
if title not indexed
+*/
+   getCirrusIndexedContent( title ) {
return Promise.coroutine( function* () {
let client = yield this.apiPromise;
let response = yield client.request( {
@@ -183,11 +193,23 @@
}
for ( let page of response.query.pages ) {
if ( page.title === title ) {
-   // without boolean cast we could return 
undefined
-   return Boolean( page.cirrusdoc && 
page.cirrusdoc.length > 0 );
+   return page.cirrusdoc;
}
}
-   return false;
+   return null;
+   } ).call( this );
+   }
+
+   /**
+* Check if title is indexed
+* @param {string} title
+* @returns {Promise.} resolves to a boolean
+*/
+   checkExists( title ) {
+   return Promise.coroutine( function* () {
+   let content = yield this.getCirrusIndexedContent( title 
);
+   // without boolean cast we could return undefined
+   return Boolean(content && content.length > 0);
} ).call( this );
}
 
diff --git a/tests/integration/features/step_definitions/page_steps.js 
b/tests/integration/features/step_definitions/page_steps.js
index c6ee18e..7ee0774 100644
--- a/tests/integration/features/step_definitions/page_steps.js
+++ b/tests/integration/features/step_definitions/page_steps.js
@@ -152,9 +152,9 @@
// Chai doesnt (yet) have a native assertion 
for this:
// https://github.com/chaijs/chai/issues/858
let ok = found.reduce( ( a, b ) => a || 
b.indexOf( title ) > -1, false );
-   expect( ok, `expected ${JSON.stringify(found)} 
to include "${title}"` ).to.be.true; // jshint ignore:line
+   return expect( ok, `expected 
${JSON.stringify(found)} to include "${title}"` ).to.be.true;
} else {
-   expect( found ).to.include(title);
+   return expect( found ).to.include(title);
}
}
}
@@ -173,9 +173,9 @@
   

[MediaWiki-commits] [Gerrit] operations/puppet[production]: ganeti: remove Ganglia

[Dzahn (Code Review)]

Dzahn has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/393683 )

Change subject: ganeti: remove Ganglia
..


ganeti: remove Ganglia

Bug: T177225
Change-Id: I01711b01485452ce871d9820fe67b3bae56dca26
---
M hieradata/role/common/ganeti.yaml
1 file changed, 1 insertion(+), 0 deletions(-)

Approvals:
  jenkins-bot: Verified
  Dzahn: Looks good to me, approved



diff --git a/hieradata/role/common/ganeti.yaml 
b/hieradata/role/common/ganeti.yaml
index b98d368..955dcc1 100644
--- a/hieradata/role/common/ganeti.yaml
+++ b/hieradata/role/common/ganeti.yaml
@@ -1,5 +1,6 @@
 profile::base::ssh_server_settings:
   authorized_keys_file: /etc/ssh/userkeys/%u /etc/ssh/userkeys/%u.d/cumin 
/etc/ssh/userkeys/%u.d/ganeti
+standard::has_ganglia: false
 ganeti::ganeti01.svc.codfw.wmnet::nodes:
   - ganeti2001.codfw.wmnet
   - ganeti2002.codfw.wmnet

-- 
To view, visit https://gerrit.wikimedia.org/r/393683
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I01711b01485452ce871d9820fe67b3bae56dca26
Gerrit-PatchSet: 3
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Dzahn 
Gerrit-Reviewer: Alexandros Kosiaris 
Gerrit-Reviewer: Dzahn 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] operations/puppet[production]: grafana: add dashboards for ganeti

[Dzahn (Code Review)]

Dzahn has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/393696 )

Change subject: grafana: add dashboards for ganeti
..

grafana: add dashboards for ganeti

Change-Id: Ib1d18474ec4700281e124149cd8e727dd4040da8
---
A modules/grafana/files/dashboards/ganeti-codfw
A modules/grafana/files/dashboards/ganeti-eqiad
2 files changed, 35,953 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/operations/puppet 
refs/changes/96/393696/1


-- 
To view, visit https://gerrit.wikimedia.org/r/393696
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib1d18474ec4700281e124149cd8e727dd4040da8
Gerrit-PatchSet: 1
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Dzahn 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] operations/puppet[production]: public_dumps: Add puppet class to set up NFS for dumps servers

[Madhuvishy (Code Review)]

Madhuvishy has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/393695 )

Change subject: public_dumps: Add puppet class to set up NFS for dumps servers
..


public_dumps: Add puppet class to set up NFS for dumps servers

Bug: T181431
Change-Id: I068f639e3b5a544af288408d90558a85c8287f72
---
M modules/profile/manifests/dumps/public_server.pp
A modules/public_dumps/files/nfs-common
A modules/public_dumps/files/nfs-kernel-server
A modules/public_dumps/manifests/nfs.pp
4 files changed, 78 insertions(+), 1 deletion(-)

Approvals:
  Madhuvishy: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/modules/profile/manifests/dumps/public_server.pp 
b/modules/profile/manifests/dumps/public_server.pp
index f841c39..f0e95d9 100644
--- a/modules/profile/manifests/dumps/public_server.pp
+++ b/modules/profile/manifests/dumps/public_server.pp
@@ -5,5 +5,5 @@
 class profile::dumps::public_server {
 
 class {'::public_dumps::server':}
-class {'::labstore':}
+class {'::public_dumps::nfs':}
 }
diff --git a/modules/public_dumps/files/nfs-common 
b/modules/public_dumps/files/nfs-common
new file mode 100644
index 000..cd91678
--- /dev/null
+++ b/modules/public_dumps/files/nfs-common
@@ -0,0 +1,17 @@
+# If you do not set values for the NEED_ options, they will be attempted
+# autodetected; this should be sufficient for most people. Valid alternatives
+# for the NEED_ options are "yes" and "no".
+
+# Do you want to start the statd daemon? It is not needed for NFSv4.
+NEED_STATD=yes
+
+# Options for rpc.statd.
+#   Should rpc.statd listen on a specific port? This is especially useful
+#   when you have a port-based firewall. To use a fixed port, set this
+#   this variable to a statd argument like: "--port 4000 --outgoing-port 4001".
+#   For more information, see rpc.statd(8) or 
http://wiki.debian.org/SecuringNFS
+STATDOPTS='--port 55659 --outgoing-port 44153'
+
+# Do you want to start the gssd daemon? It is required for Kerberos mounts.
+NEED_GSSD=
+NEED_LOCKD=no
diff --git a/modules/public_dumps/files/nfs-kernel-server 
b/modules/public_dumps/files/nfs-kernel-server
new file mode 100644
index 000..bfb4950
--- /dev/null
+++ b/modules/public_dumps/files/nfs-kernel-server
@@ -0,0 +1,23 @@
+# Number of servers to start up
+# To disable nfsv4 on the server, specify '--no-nfs-version 4' here
+
+# Best as max concurrently connected clients.  We currently hover around
+# 250-280 connected clients as of 1/25/2016
+RPCNFSDCOUNT=192
+
+# Runtime priority of server (see nice(1))
+RPCNFSDPRIORITY=0
+
+# Options for rpc.mountd.
+# If you have a port-based firewall, you might want to set up
+# a fixed port here using the --port option. For more information,
+# see rpc.mountd(8) or http://wiki.debian.org/SecuringNFS
+# To disable NFSv4 on the server, specify '--no-nfs-version 4' here
+RPCMOUNTDOPTS='--manage-gids --port 38466 --no-nfs-version 2,3'
+
+# Do you want to start the svcgssd daemon? It is only required for Kerberos
+# exports. Valid alternatives are "yes" and "no"; the default is "no".
+NEED_SVCGSSD=
+
+# Options for rpc.svcgssd.
+RPCSVCGSSDOPTS=
diff --git a/modules/public_dumps/manifests/nfs.pp 
b/modules/public_dumps/manifests/nfs.pp
new file mode 100644
index 000..3586906
--- /dev/null
+++ b/modules/public_dumps/manifests/nfs.pp
@@ -0,0 +1,37 @@
+# Set up NFS Server for the public dumps servers
+# Firewall rules are managed separately through profile::wmcs::nfs::ferm
+
+class public_dumps::nfs {
+
+require_package('nfs-kernel-server', 'nfs-common', 'rpcbind')
+
+file { '/etc/default/nfs-common':
+ensure => present,
+owner  => 'root',
+group  => 'root',
+mode   => '0555',
+source => 'puppet:///modules/public_dumps/nfs-common',
+}
+
+file { '/etc/default/nfs-kernel-server':
+ensure => present,
+owner  => 'root',
+group  => 'root',
+mode   => '0555',
+source => 'puppet:///modules/public_dumps/nfs-kernel-server',
+}
+
+file { '/etc/modprobe.d/nfs-lockd.conf':
+ensure  => present,
+owner   => 'root',
+group   => 'root',
+mode=> '0644',
+content => 'options lockd nlm_udpport=32768 nlm_tcpport=32769',
+}
+
+# Manage state manually
+service { 'nfs-kernel-server':
+enable => false,
+}
+
+}

-- 
To view, visit https://gerrit.wikimedia.org/r/393695
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I068f639e3b5a544af288408d90558a85c8287f72
Gerrit-PatchSet: 2
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Madhuvishy 
Gerrit-Reviewer: Madhuvishy 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org

[MediaWiki-commits] [Gerrit] operations/puppet[production]: public_dumps: Add puppet class to set up NFS for dumps servers

[Madhuvishy (Code Review)]

Madhuvishy has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/393695 )

Change subject: public_dumps: Add puppet class to set up NFS for dumps servers
..

public_dumps: Add puppet class to set up NFS for dumps servers

Bug: T181431
Change-Id: I068f639e3b5a544af288408d90558a85c8287f72
---
M modules/profile/manifests/dumps/public_server.pp
A modules/public_dumps/files/nfs-common
A modules/public_dumps/files/nfs-kernel-server
A modules/public_dumps/manifests/nfs.pp
4 files changed, 78 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/operations/puppet 
refs/changes/95/393695/1

diff --git a/modules/profile/manifests/dumps/public_server.pp 
b/modules/profile/manifests/dumps/public_server.pp
index f841c39..f0e95d9 100644
--- a/modules/profile/manifests/dumps/public_server.pp
+++ b/modules/profile/manifests/dumps/public_server.pp
@@ -5,5 +5,5 @@
 class profile::dumps::public_server {
 
 class {'::public_dumps::server':}
-class {'::labstore':}
+class {'::public_dumps::nfs':}
 }
diff --git a/modules/public_dumps/files/nfs-common 
b/modules/public_dumps/files/nfs-common
new file mode 100644
index 000..cd91678
--- /dev/null
+++ b/modules/public_dumps/files/nfs-common
@@ -0,0 +1,17 @@
+# If you do not set values for the NEED_ options, they will be attempted
+# autodetected; this should be sufficient for most people. Valid alternatives
+# for the NEED_ options are "yes" and "no".
+
+# Do you want to start the statd daemon? It is not needed for NFSv4.
+NEED_STATD=yes
+
+# Options for rpc.statd.
+#   Should rpc.statd listen on a specific port? This is especially useful
+#   when you have a port-based firewall. To use a fixed port, set this
+#   this variable to a statd argument like: "--port 4000 --outgoing-port 4001".
+#   For more information, see rpc.statd(8) or 
http://wiki.debian.org/SecuringNFS
+STATDOPTS='--port 55659 --outgoing-port 44153'
+
+# Do you want to start the gssd daemon? It is required for Kerberos mounts.
+NEED_GSSD=
+NEED_LOCKD=no
diff --git a/modules/public_dumps/files/nfs-kernel-server 
b/modules/public_dumps/files/nfs-kernel-server
new file mode 100644
index 000..bfb4950
--- /dev/null
+++ b/modules/public_dumps/files/nfs-kernel-server
@@ -0,0 +1,23 @@
+# Number of servers to start up
+# To disable nfsv4 on the server, specify '--no-nfs-version 4' here
+
+# Best as max concurrently connected clients.  We currently hover around
+# 250-280 connected clients as of 1/25/2016
+RPCNFSDCOUNT=192
+
+# Runtime priority of server (see nice(1))
+RPCNFSDPRIORITY=0
+
+# Options for rpc.mountd.
+# If you have a port-based firewall, you might want to set up
+# a fixed port here using the --port option. For more information,
+# see rpc.mountd(8) or http://wiki.debian.org/SecuringNFS
+# To disable NFSv4 on the server, specify '--no-nfs-version 4' here
+RPCMOUNTDOPTS='--manage-gids --port 38466 --no-nfs-version 2,3'
+
+# Do you want to start the svcgssd daemon? It is only required for Kerberos
+# exports. Valid alternatives are "yes" and "no"; the default is "no".
+NEED_SVCGSSD=
+
+# Options for rpc.svcgssd.
+RPCSVCGSSDOPTS=
diff --git a/modules/public_dumps/manifests/nfs.pp 
b/modules/public_dumps/manifests/nfs.pp
new file mode 100644
index 000..3586906
--- /dev/null
+++ b/modules/public_dumps/manifests/nfs.pp
@@ -0,0 +1,37 @@
+# Set up NFS Server for the public dumps servers
+# Firewall rules are managed separately through profile::wmcs::nfs::ferm
+
+class public_dumps::nfs {
+
+require_package('nfs-kernel-server', 'nfs-common', 'rpcbind')
+
+file { '/etc/default/nfs-common':
+ensure => present,
+owner  => 'root',
+group  => 'root',
+mode   => '0555',
+source => 'puppet:///modules/public_dumps/nfs-common',
+}
+
+file { '/etc/default/nfs-kernel-server':
+ensure => present,
+owner  => 'root',
+group  => 'root',
+mode   => '0555',
+source => 'puppet:///modules/public_dumps/nfs-kernel-server',
+}
+
+file { '/etc/modprobe.d/nfs-lockd.conf':
+ensure  => present,
+owner   => 'root',
+group   => 'root',
+mode=> '0644',
+content => 'options lockd nlm_udpport=32768 nlm_tcpport=32769',
+}
+
+# Manage state manually
+service { 'nfs-kernel-server':
+enable => false,
+}
+
+}

-- 
To view, visit https://gerrit.wikimedia.org/r/393695
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I068f639e3b5a544af288408d90558a85c8287f72
Gerrit-PatchSet: 1
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Madhuvishy 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...CirrusSearch[master]: Port prefer_recent_api.feature to nodejs

[EBernhardson (Code Review)]

EBernhardson has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/393693 )

Change subject: Port prefer_recent_api.feature to nodejs
..

Port prefer_recent_api.feature to nodejs

* Remove @expect_failure tag from scenario outlines
* Drop test in final scenario with settings `.4,.0001`. It
  doesn't pass, and not really sure why or what it's supposed
  to do.
* Tune down pause between first and second stage of the hook
  from 20s to 5s. At least locally this seems to still work.
* Drop final pause in hook and replace with deletes at top
  of the hook. Best i can tell the pause was to ensure the
  final edit made it into elasticsearch. We can check the edit,
  but since we dont check revision ids we need to pre-delete
  so the check actually waits.

Change-Id: I7fbf7b9945f71b0e46a769ec5b2ebec6f338af14
---
A tests/integration/features/prefer_recent_api.feature
M tests/integration/features/support/hooks.js
2 files changed, 38 insertions(+), 5 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/CirrusSearch 
refs/changes/93/393693/1

diff --git a/tests/integration/features/prefer_recent_api.feature 
b/tests/integration/features/prefer_recent_api.feature
new file mode 100644
index 000..553b026
--- /dev/null
+++ b/tests/integration/features/prefer_recent_api.feature
@@ -0,0 +1,24 @@
+@clean @api @prefer_recent
+Feature: Searches with prefer-recent
+  Scenario Outline: Recently updated articles are prefered if prefer-recent: 
is specified
+When I api search for PreferRecent First OR Second OR Third
+Then PreferRecent Second Second is the first api search result
+When I api search for prefer-recent: PreferRecent First OR Second 
OR Third
+Then PreferRecent Third is the first api search result
+  Examples:
+|   options   |
+| 1,.001  |
+| 1,0.001 |
+| 1,.0001 |
+| .99,.0001   |
+| .99,.001|
+
+  Scenario Outline: You can specify prefer-recent: in such a way that being 
super recent isn't enough
+When I api search for prefer-recent: PreferRecent First OR Second 
OR Third
+Then PreferRecent Second Second is the first api search result
+  Examples:
+|  options  |
+|   |
+| 1 |
+| 1,1   |
+| 1,.1  |
diff --git a/tests/integration/features/support/hooks.js 
b/tests/integration/features/support/hooks.js
index 2c78666..ea9ad93 100644
--- a/tests/integration/features/support/hooks.js
+++ b/tests/integration/features/support/hooks.js
@@ -399,6 +399,17 @@
} ) );
 
BeforeOnce( { tags: "@prefer_recent", timeout: 6 }, 
Promise.coroutine( function* () {
+   // Deleting the pages first ensures we actually wait around for 
the edits to
+   // make it into the DB. Better might be if runBatch() could 
wait for revision id's,
+   // but it doesn't (yet).
+   yield runBatch( this, false, {
+   delete: [
+   'PreferRecent First',
+   'PreferRecent Second Second',
+   'PreferRecent Third',
+   ]
+   } );
+
yield runBatch( this, false, {
edit: {
// Using epochs as content ensures the page is 
edited.
@@ -407,17 +418,15 @@
}
} );
 
-   // We need to wait around to ensure the next page has enough 
time difference
-   // for prefer-recent to reorder things
-   yield this.stepHelpers.waitForMs( 2 );
+   // We need to wait around to ensure the next page has enough 
time
+   // difference for prefer-recent to reorder things.
+   yield this.stepHelpers.waitForMs( 5000 );
 
yield runBatch( this, false, {
edit: {
'PreferRecent Third': "" + ( new Date() / 1 )
}
} );
-   // TODO: Why are we waiting here?
-   yield this.stepHelpers.waitForMs( 1 );
} ) );
 
BeforeOnce( { tags: "@hastemplate" }, runBatchFn( {

-- 
To view, visit https://gerrit.wikimedia.org/r/393693
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I7fbf7b9945f71b0e46a769ec5b2ebec6f338af14
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/CirrusSearch
Gerrit-Branch: master
Gerrit-Owner: EBernhardson 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...CirrusSearch[master]: Port update_general_api.feature to nodejs

[EBernhardson (Code Review)]

EBernhardson has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/393694 )

Change subject: Port update_general_api.feature to nodejs
..

Port update_general_api.feature to nodejs

* Rework cirrusdoc api query to source page ids from archive and
 page table, whichever is more recent. This allows figuring out when
 deletes have made it into elasticsearch.
* Rewrite all the 'within ...' clauses to direct query/check after
 waiting for the previous operation to go through
* The only operation we can't directly wait for is the template
 update, which for unrelated reasons is broken on my MWV so commented
 out
* The archive search is only exposed via browser, so its test
 uses the browser. As Special:Undelete requires special rights this
 meant rigging up a login method for the browser.
* Changed baseurl from dev.wiki -> cirrustest.wiki. This probably
 needs to be handled more generically though to support browser with
 multiple wikis.
* Adjust waitForOperation to take a revision id, and make step
 helpers editPage method pass the new revision id into waitForOperation.
 Without this an edit to page that already exists is not waited for and
 fails.
* Implement step helpers movePage(). Waiting for the move to make it
 into cirrus required adding an additional check to the cirrusdoc query
 that the requested page matches the elastic page. This probably still
 has issues if a redirect points to the moved page, but we don't test
 that.
* Support %{epoch} transformation in steps. This required normalizing
 all parameters that should support this to (.+), removing uses of (.*)
 as cucumber-js doesn't have a generic transformation step, only one on
 individual capture patterns.

Change-Id: I99c0ef1e3453fedea5f3afbe29e5e8f9dd73d7e4
---
M includes/Api/QueryCirrusDoc.php
M tests/integration/config/wdio.conf.js
M tests/integration/features/step_definitions/page_step_helpers.js
M tests/integration/features/step_definitions/page_steps.js
M tests/integration/features/support/hooks.js
M tests/integration/features/support/pages/page.js
A tests/integration/features/support/pages/special_undelete.js
M tests/integration/features/support/world.js
A tests/integration/features/update_general_api.feature
9 files changed, 373 insertions(+), 66 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/CirrusSearch 
refs/changes/94/393694/1

diff --git a/includes/Api/QueryCirrusDoc.php b/includes/Api/QueryCirrusDoc.php
index 27e2216..e03ee1c 100644
--- a/includes/Api/QueryCirrusDoc.php
+++ b/includes/Api/QueryCirrusDoc.php
@@ -3,7 +3,7 @@
 namespace CirrusSearch\Api;
 
 use CirrusSearch\Searcher;
-use CirrusSearch\Updater;
+use PageArchive;
 use Title;
 
 /**
@@ -31,51 +31,139 @@
 class QueryCirrusDoc extends \ApiQueryBase {
use ApiTrait;
 
+   private $config;
+   private $searcher;
+
public function __construct( \ApiQuery $query, $moduleName ) {
parent::__construct( $query, $moduleName, 'cd' );
}
 
public function execute() {
$conn = $this->getCirrusConnection();
-   $config = $this->getSearchConfig();
-   $updater = new Updater( $conn, $config );
-   $searcher = new Searcher( $conn, 0, 0, $config, [], 
$this->getUser() );
-   $result = [];
+   $this->config = $this->getSearchConfig();
+   $this->searcher = new Searcher( $conn, 0, 0, $this->config, [], 
$this->getUser() );
foreach ( $this->getPageSet()->getGoodTitles() as $origPageId 
=> $title ) {
-   list( $page, $redirects ) = $updater->traceRedirects( 
$title );
-
-   $result = [];
-   if ( $page ) {
-   $docId = $config->makeId( $page->getId() );
-   // could be optimized by implementing multi-get 
but not
-   // expecting much usage except debugging/tests.
-   $esSources = $searcher->get( [ $docId ], true );
-   if ( $esSources->isOK() ) {
-   foreach ( $esSources->getValue() as $i 
=> $esSource ) {
-   // If we have followed 
redirects only report the
-   // article dump if the redirect 
has been indexed. If it
-   // hasn't been indexed this 
document does not represent
-   // the original title.
-   if ( count( $redirects ) &&
-   !$this->hasRedirect( 
$esSource->getData(), $title )
-   ) {
-   continue;
-   

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Use WANObjectCache::makeKey() in ChangesFeed

[jenkins-bot (Code Review)]

jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/393646 )

Change subject: Use WANObjectCache::makeKey() in ChangesFeed
..


Use WANObjectCache::makeKey() in ChangesFeed

Change-Id: Ia029873e5d0883d177007555ad494cae9e00c407
---
M includes/changes/ChangesFeed.php
1 file changed, 3 insertions(+), 2 deletions(-)

Approvals:
  Krinkle: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/includes/changes/ChangesFeed.php b/includes/changes/ChangesFeed.php
index df964e0..7ac8cd0 100644
--- a/includes/changes/ChangesFeed.php
+++ b/includes/changes/ChangesFeed.php
@@ -82,10 +82,11 @@
return null;
}
 
+   $cache = ObjectCache::getMainWANInstance();
$optionsHash = md5( serialize( $opts->getAllValues() ) ) . 
$wgRenderHashAppend;
-   $timekey = wfMemcKey(
+   $timekey = $cache->makeKey(
$this->type, $this->format, $wgLang->getCode(), 
$optionsHash, 'timestamp' );
-   $key = wfMemcKey( $this->type, $this->format, 
$wgLang->getCode(), $optionsHash );
+   $key = $cache->makeKey( $this->type, $this->format, 
$wgLang->getCode(), $optionsHash );
 
FeedUtils::checkPurge( $timekey, $key );
 

-- 
To view, visit https://gerrit.wikimedia.org/r/393646
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ia029873e5d0883d177007555ad494cae9e00c407
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Aaron Schulz 
Gerrit-Reviewer: Krinkle 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Graduate live update out of beta

[jenkins-bot (Code Review)]

jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/393692 )

Change subject: Graduate live update out of beta
..


Graduate live update out of beta

Bug: T173614
Change-Id: I680b518fa3b8a0bb5ac3a6ec8347e57e70c26d20
---
M resources/src/mediawiki.rcfilters/mw.rcfilters.js
1 file changed, 1 insertion(+), 2 deletions(-)

Approvals:
  jenkins-bot: Verified
  Mooeypoo: Looks good to me, approved



diff --git a/resources/src/mediawiki.rcfilters/mw.rcfilters.js 
b/resources/src/mediawiki.rcfilters/mw.rcfilters.js
index e28f34a..466b7c0 100644
--- a/resources/src/mediawiki.rcfilters/mw.rcfilters.js
+++ b/resources/src/mediawiki.rcfilters/mw.rcfilters.js
@@ -46,8 +46,7 @@
}
},
featureFlags: {
-   liveUpdate: mw.config.get( 
'StructuredChangeFiltersLiveUpdatePollingRate' ) &&
-   ( mw.user.options.get( 'rcenhancedfilters' ) || 
new mw.Uri().query.liveupdate )
+   liveUpdate: mw.config.get( 
'StructuredChangeFiltersLiveUpdatePollingRate' )
}
};
 }( mediaWiki ) );

-- 
To view, visit https://gerrit.wikimedia.org/r/393692
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I680b518fa3b8a0bb5ac3a6ec8347e57e70c26d20
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Catrope 
Gerrit-Reviewer: Mooeypoo 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...BounceHandler[master]: Remove UnitTestsList hook subscriber

[jenkins-bot (Code Review)]

jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/313654 )

Change subject: Remove UnitTestsList hook subscriber
..


Remove UnitTestsList hook subscriber

Bug: T142121
Change-Id: Iac91c86fc66ef99bbc838b7458e8efcdcd2bcfb8
---
M BounceHandlerHooks.php
M extension.json
R tests/phpunit/ApiBounceHandlerTest.php
R tests/phpunit/ProcessBounceWithRegexTest.php
R tests/phpunit/PruneOldBounceRecordsTest.php
R tests/phpunit/UnSubscribeUserTest.php
R tests/phpunit/VERPEncodeDecodeTest.php
R tests/phpunit/bounce_emails/email1
R tests/phpunit/bounce_emails/email2
R tests/phpunit/bounce_emails/emailStatus1
R tests/phpunit/bounce_emails/emailStatus2
R tests/phpunit/bounce_emails/emailStatus3
R tests/phpunit/bounce_emails/oracle7
13 files changed, 0 insertions(+), 31 deletions(-)

Approvals:
  jenkins-bot: Verified
  Jforrester: Looks good to me, approved



diff --git a/BounceHandlerHooks.php b/BounceHandlerHooks.php
index 225f373..2b80d6b 100644
--- a/BounceHandlerHooks.php
+++ b/BounceHandlerHooks.php
@@ -63,34 +63,6 @@
}
 
/**
-* Hook to add PHPUnit test cases.
-* @see https://www.mediawiki.org/wiki/Manual:Hooks/UnitTestsList
-*
-* @param array &$files
-*
-* @return bool
-*/
-   public static function registerUnitTests( array &$files ) {
-   // @codeCoverageIgnoreStart
-   $directoryIterator = new RecursiveDirectoryIterator( __DIR__ . 
'/tests/' );
-
-   /**
-* @var SplFileInfo $fileInfo
-*/
-   $ourFiles = [];
-   foreach ( new RecursiveIteratorIterator( $directoryIterator ) 
as $fileInfo ) {
-   if ( substr( $fileInfo->getFilename(), -8 ) === 
'Test.php' ) {
-   $ourFiles[] = $fileInfo->getPathname();
-   }
-   }
-
-   $files = array_merge( $files, $ourFiles );
-
-   return true;
-   // @codeCoverageIgnoreEnd
-   }
-
-   /**
 * Add tables to Database
 *
 * @param DatabaseUpdater $updater
diff --git a/extension.json b/extension.json
index 728ad9b..80cef27 100644
--- a/extension.json
+++ b/extension.json
@@ -54,9 +54,6 @@
"UserMailerChangeReturnPath": [
"BounceHandlerHooks::onVERPAddressGenerate"
],
-   "UnitTestsList": [
-   "BounceHandlerHooks::registerUnitTests"
-   ],
"LoadExtensionSchemaUpdates": [
"BounceHandlerHooks::loadExtensionSchemaUpdates"
],
diff --git a/tests/ApiBounceHandlerTest.php 
b/tests/phpunit/ApiBounceHandlerTest.php
similarity index 100%
rename from tests/ApiBounceHandlerTest.php
rename to tests/phpunit/ApiBounceHandlerTest.php
diff --git a/tests/ProcessBounceWithRegexTest.php 
b/tests/phpunit/ProcessBounceWithRegexTest.php
similarity index 100%
rename from tests/ProcessBounceWithRegexTest.php
rename to tests/phpunit/ProcessBounceWithRegexTest.php
diff --git a/tests/PruneOldBounceRecordsTest.php 
b/tests/phpunit/PruneOldBounceRecordsTest.php
similarity index 100%
rename from tests/PruneOldBounceRecordsTest.php
rename to tests/phpunit/PruneOldBounceRecordsTest.php
diff --git a/tests/UnSubscribeUserTest.php 
b/tests/phpunit/UnSubscribeUserTest.php
similarity index 100%
rename from tests/UnSubscribeUserTest.php
rename to tests/phpunit/UnSubscribeUserTest.php
diff --git a/tests/VERPEncodeDecodeTest.php 
b/tests/phpunit/VERPEncodeDecodeTest.php
similarity index 100%
rename from tests/VERPEncodeDecodeTest.php
rename to tests/phpunit/VERPEncodeDecodeTest.php
diff --git a/tests/bounce_emails/email1 b/tests/phpunit/bounce_emails/email1
similarity index 100%
rename from tests/bounce_emails/email1
rename to tests/phpunit/bounce_emails/email1
diff --git a/tests/bounce_emails/email2 b/tests/phpunit/bounce_emails/email2
similarity index 100%
rename from tests/bounce_emails/email2
rename to tests/phpunit/bounce_emails/email2
diff --git a/tests/bounce_emails/emailStatus1 
b/tests/phpunit/bounce_emails/emailStatus1
similarity index 100%
rename from tests/bounce_emails/emailStatus1
rename to tests/phpunit/bounce_emails/emailStatus1
diff --git a/tests/bounce_emails/emailStatus2 
b/tests/phpunit/bounce_emails/emailStatus2
similarity index 100%
rename from tests/bounce_emails/emailStatus2
rename to tests/phpunit/bounce_emails/emailStatus2
diff --git a/tests/bounce_emails/emailStatus3 
b/tests/phpunit/bounce_emails/emailStatus3
similarity index 100%
rename from tests/bounce_emails/emailStatus3
rename to tests/phpunit/bounce_emails/emailStatus3
diff --git a/tests/bounce_emails/oracle7 b/tests/phpunit/bounce_emails/oracle7
similarity index 100%
rename from tests/bounce_emails/oracle7
rename to tests/phpunit/bounce_emails/oracle7

-- 
To view, visit 

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Move seperators from digits transforms to seperator transforms

[jenkins-bot (Code Review)]

jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/393250 )

Change subject: Move seperators from digits transforms to seperator transforms
..


Move seperators from digits transforms to seperator transforms

Change-Id: Iecc30b4eae9a5fe0f87d162c8118722ba5aab90c
---
M languages/messages/MessagesAr.php
M languages/messages/MessagesArz.php
M languages/messages/MessagesCkb.php
M languages/messages/MessagesFa.php
M languages/messages/MessagesKu_arab.php
M languages/messages/MessagesLzh.php
6 files changed, 22 insertions(+), 4 deletions(-)

Approvals:
  jenkins-bot: Verified
  Jforrester: Looks good to me, approved



diff --git a/languages/messages/MessagesAr.php 
b/languages/messages/MessagesAr.php
index e2845a5..3bc2245 100644
--- a/languages/messages/MessagesAr.php
+++ b/languages/messages/MessagesAr.php
@@ -96,7 +96,10 @@
'7' => '٧', # 
'8' => '٨', # 
'9' => '٩', # 
-   '.' => '٫', #  wrong table ?
+];
+
+$separatorTransformTable = [
+   '.' => '٫', # 
',' => '٬', # 
 ];
 
diff --git a/languages/messages/MessagesArz.php 
b/languages/messages/MessagesArz.php
index bb99553..a2f9f65 100644
--- a/languages/messages/MessagesArz.php
+++ b/languages/messages/MessagesArz.php
@@ -341,6 +341,9 @@
'7' => '7',
'8' => '8',
'9' => '9',
+];
+
+$separatorTransformTable = [
'.' => '.',
',' => ',',
 ];
diff --git a/languages/messages/MessagesCkb.php 
b/languages/messages/MessagesCkb.php
index ad45b66..e615462 100644
--- a/languages/messages/MessagesCkb.php
+++ b/languages/messages/MessagesCkb.php
@@ -130,7 +130,10 @@
'7' => '٧', # 
'8' => '٨', # 
'9' => '٩', # 
-   '.' => '٫', #  wrong table ?
+];
+
+$separatorTransformTable = [
+   '.' => '٫', # 
',' => '٬', # 
 ];
 
diff --git a/languages/messages/MessagesFa.php 
b/languages/messages/MessagesFa.php
index 84dfabf..4e10908 100644
--- a/languages/messages/MessagesFa.php
+++ b/languages/messages/MessagesFa.php
@@ -329,7 +329,10 @@
'8' => '۸', # 
'9' => '۹', # 
'%' => '٪', # 
-   '.' => '٫', #  wrong table?
+];
+
+$separatorTransformTable = [
+   '.' => '٫', # 
',' => '٬', # 
 ];
 
diff --git a/languages/messages/MessagesKu_arab.php 
b/languages/messages/MessagesKu_arab.php
index 7551ccf..0a80a62 100644
--- a/languages/messages/MessagesKu_arab.php
+++ b/languages/messages/MessagesKu_arab.php
@@ -29,6 +29,9 @@
'7' => '٧', # 
'8' => '٨', # 
'9' => '٩', # 
-   '.' => '٫', #  wrong table ?
+];
+
+$separatorTransformTable = [
+   '.' => '٫', # 
',' => '٬', # 
 ];
diff --git a/languages/messages/MessagesLzh.php 
b/languages/messages/MessagesLzh.php
index 5214c46..1850d67 100644
--- a/languages/messages/MessagesLzh.php
+++ b/languages/messages/MessagesLzh.php
@@ -148,6 +148,9 @@
'7' => '七',
'8' => '八',
'9' => '九',
+];
+
+$separatorTransformTable = [
'.' => '點',
',' => '',
 ];

-- 
To view, visit https://gerrit.wikimedia.org/r/393250
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Iecc30b4eae9a5fe0f87d162c8118722ba5aab90c
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Reedy 
Gerrit-Reviewer: Jforrester 
Gerrit-Reviewer: Nikerabbit 
Gerrit-Reviewer: Siebrand 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: shell: Optionally restrict commands' access with firejail

[jenkins-bot (Code Review)]

jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/384930 )

Change subject: shell: Optionally restrict commands' access with firejail
..


shell: Optionally restrict commands' access with firejail

Introduces a FirejailCommand class, which can be used to add additional
restrictions to a command, for increased security. For now, firejail
containment needs to be enabled on a per-command basis.

The following restrictions are implemented:
* NO_ROOT - disallows any root access, including via setuid binaries
* SECCOMP - block dangerous syscalls with seccomp
* PRIVATE_DEV - create a private /dev
* NO_NETWORK - deny all network access
* NO_EXECVE - block the execve syscall

A convenient Shell::RESTRICT_DEFAULT is equivalent to NO_ROOT | SECCOMP
| PRIVATE_DEV, with the expectation that more restrictions may be added
to it in the future.

In addition, specific paths can be whitelisted with
Command::whitelistPaths(). Any file/directory that isn't whitelisted in
that top level directory (e.g. /srv) won't exist inside the firejail.

$wgShellRestrictionMethod can be set to false for no restriction system,
'firejail' to explicitly use it, or 'autodetect' to autodetect whatever
system is available. In the future the default should be changed to
autodetection once firejail is tested more.

Bug: T173370
Change-Id: Id74df0dbba40e1e7c07c4368aacffb6eb06a17c5
---
M autoload.php
M includes/DefaultSettings.php
M includes/GitInfo.php
M includes/ServiceWiring.php
M includes/shell/Command.php
M includes/shell/CommandFactory.php
A includes/shell/FirejailCommand.php
M includes/shell/Shell.php
A includes/shell/firejail.profile
M tests/phpunit/includes/shell/CommandFactoryTest.php
A tests/phpunit/includes/shell/FirejailCommandTest.php
11 files changed, 402 insertions(+), 4 deletions(-)

Approvals:
  Tim Starling: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/autoload.php b/autoload.php
index 5a2156a..2231a3f 100644
--- a/autoload.php
+++ b/autoload.php
@@ -939,6 +939,7 @@
'MediaWiki\\ShellDisabledError' => __DIR__ . 
'/includes/exception/ShellDisabledError.php',
'MediaWiki\\Shell\\Command' => __DIR__ . '/includes/shell/Command.php',
'MediaWiki\\Shell\\CommandFactory' => __DIR__ . 
'/includes/shell/CommandFactory.php',
+   'MediaWiki\\Shell\\FirejailCommand' => __DIR__ . 
'/includes/shell/FirejailCommand.php',
'MediaWiki\\Shell\\Result' => __DIR__ . '/includes/shell/Result.php',
'MediaWiki\\Shell\\Shell' => __DIR__ . '/includes/shell/Shell.php',
'MediaWiki\\Site\\MediaWikiPageNameNormalizer' => __DIR__ . 
'/includes/site/MediaWikiPageNameNormalizer.php',
diff --git a/includes/DefaultSettings.php b/includes/DefaultSettings.php
index 2d344fd..25be60c 100644
--- a/includes/DefaultSettings.php
+++ b/includes/DefaultSettings.php
@@ -8271,6 +8271,22 @@
  */
 $wgShellLocale = 'C.UTF-8';
 
+/**
+ * Method to use to restrict shell commands
+ *
+ * Supported options:
+ * - 'autodetect': Autodetect if any restriction methods are available
+ * - 'firejail': Use firejail 
+ * - false: Don't use any restrictions
+ *
+ * @note If using firejail with MediaWiki running in a home directory different
+ *  from the webserver user, firejail 0.9.44+ is required.
+ *
+ * @since 1.31
+ * @var string|bool
+ */
+$wgShellRestrictionMethod = false;
+
 /** @} */ # End shell }
 
 ///**
diff --git a/includes/GitInfo.php b/includes/GitInfo.php
index 8095fd7..f170a02 100644
--- a/includes/GitInfo.php
+++ b/includes/GitInfo.php
@@ -232,6 +232,8 @@
];
$result = Shell::command( $cmd )
->environment( [ 'GIT_DIR' => 
$this->basedir ] )
+   ->restrict( Shell::RESTRICT_DEFAULT | 
Shell::NO_NETWORK )
+   ->whitelistPaths( [ $this->basedir ] )
->execute();
 
if ( $result->getExitCode() === 0 ) {
diff --git a/includes/ServiceWiring.php b/includes/ServiceWiring.php
index ae88d37..dad0630 100644
--- a/includes/ServiceWiring.php
+++ b/includes/ServiceWiring.php
@@ -439,8 +439,9 @@
'filesize' => $config->get( 'MaxShellFileSize' ),
];
$cgroup = $config->get( 'ShellCgroup' );
+   $restrictionMethod = $config->get( 'ShellRestrictionMethod' );
 
-   $factory = new CommandFactory( $limits, $cgroup );
+   $factory = new CommandFactory( $limits, $cgroup, 
$restrictionMethod );
$factory->setLogger( LoggerFactory::getInstance( 'exec' ) );
$factory->logStderr();
 
diff --git a/includes/shell/Command.php b/includes/shell/Command.php
index 

[MediaWiki-commits] [Gerrit] mediawiki...OAuth[master]: Remove UnitTestsList hook subscriber

[jenkins-bot (Code Review)]

jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/313653 )

Change subject: Remove UnitTestsList hook subscriber
..


Remove UnitTestsList hook subscriber

Bug: T142121
Change-Id: I304fb53f3d10db40797322a3565395d4f8447454
---
M .phpcs.xml
M backend/MWOAuth.hooks.php
M extension.json
R tests/phpunit/backend/MWOAuthServerTest.php
R tests/phpunit/lib/Mock_OAuthBaseStringRequest.php
R tests/phpunit/lib/Mock_OAuthDataStore.php
R tests/phpunit/lib/Mock_OAuthSignatureMethod_RSA_SHA1.php
R tests/phpunit/lib/OAuthConsumerTest.php
R tests/phpunit/lib/OAuthRequestTest.php
R tests/phpunit/lib/OAuthServerTest.php
R tests/phpunit/lib/OAuthSignatureMethodHmacSha1Test.php
R tests/phpunit/lib/OAuthSignatureMethodRsaSha1Test.php
R tests/phpunit/lib/OAuthTokenTest.php
R tests/phpunit/lib/OAuthUtilTest.php
R tests/phpunit/lib/common.php
15 files changed, 1 insertion(+), 12 deletions(-)

Approvals:
  jenkins-bot: Verified
  Jforrester: Looks good to me, approved



diff --git a/.phpcs.xml b/.phpcs.xml
index ba83817..38d4195 100644
--- a/.phpcs.xml
+++ b/.phpcs.xml
@@ -17,5 +17,5 @@


^lib/
-   ^tests/lib/
+   ^tests/phpunit/lib/
 
diff --git a/backend/MWOAuth.hooks.php b/backend/MWOAuth.hooks.php
index b561a8e..1480ade 100644
--- a/backend/MWOAuth.hooks.php
+++ b/backend/MWOAuth.hooks.php
@@ -155,16 +155,6 @@
}
}
 
-   public static function onUnitTestsList( array &$files ) {
-   $directoryIterator = new \RecursiveDirectoryIterator( __DIR__ . 
'/../tests/' );
-   foreach ( new \RecursiveIteratorIterator( $directoryIterator ) 
as $fileInfo ) {
-   if ( substr( $fileInfo->getFilename(), -8 ) === 
'Test.php' ) {
-   $files[] = $fileInfo->getPathname();
-   }
-   }
-   return true;
-   }
-
public static function onApiRsdServiceApis( array &$apis ) {
$apis['MediaWiki']['settings']['OAuth'] = true;
}
diff --git a/extension.json b/extension.json
index fcde189..0a8fd8b 100644
--- a/extension.json
+++ b/extension.json
@@ -125,7 +125,6 @@
"MergeAccountFromTo": 
"MediaWiki\\Extensions\\OAuth\\MWOAuthHooks::onMergeAccountFromTo",
"CentralAuthGlobalUserMerged": 
"MediaWiki\\Extensions\\OAuth\\MWOAuthHooks::onCentralAuthGlobalUserMerged",
"LoadExtensionSchemaUpdates": 
"MediaWiki\\Extensions\\OAuth\\MWOAuthUpdaterHooks::addSchemaUpdates",
-   "UnitTestsList": 
"MediaWiki\\Extensions\\OAuth\\MWOAuthHooks::onUnitTestsList",
"GetPreferences": 
"MediaWiki\\Extensions\\OAuth\\MWOAuthUIHooks::onGetPreferences",
"MessagesPreLoad": 
"MediaWiki\\Extensions\\OAuth\\MWOAuthUIHooks::onMessagesPreLoad",
"SpecialPageAfterExecute": 
"MediaWiki\\Extensions\\OAuth\\MWOAuthUIHooks::onSpecialPageAfterExecute",
diff --git a/tests/backend/MWOAuthServerTest.php 
b/tests/phpunit/backend/MWOAuthServerTest.php
similarity index 100%
rename from tests/backend/MWOAuthServerTest.php
rename to tests/phpunit/backend/MWOAuthServerTest.php
diff --git a/tests/lib/Mock_OAuthBaseStringRequest.php 
b/tests/phpunit/lib/Mock_OAuthBaseStringRequest.php
similarity index 100%
rename from tests/lib/Mock_OAuthBaseStringRequest.php
rename to tests/phpunit/lib/Mock_OAuthBaseStringRequest.php
diff --git a/tests/lib/Mock_OAuthDataStore.php 
b/tests/phpunit/lib/Mock_OAuthDataStore.php
similarity index 100%
rename from tests/lib/Mock_OAuthDataStore.php
rename to tests/phpunit/lib/Mock_OAuthDataStore.php
diff --git a/tests/lib/Mock_OAuthSignatureMethod_RSA_SHA1.php 
b/tests/phpunit/lib/Mock_OAuthSignatureMethod_RSA_SHA1.php
similarity index 100%
rename from tests/lib/Mock_OAuthSignatureMethod_RSA_SHA1.php
rename to tests/phpunit/lib/Mock_OAuthSignatureMethod_RSA_SHA1.php
diff --git a/tests/lib/OAuthConsumerTest.php 
b/tests/phpunit/lib/OAuthConsumerTest.php
similarity index 100%
rename from tests/lib/OAuthConsumerTest.php
rename to tests/phpunit/lib/OAuthConsumerTest.php
diff --git a/tests/lib/OAuthRequestTest.php 
b/tests/phpunit/lib/OAuthRequestTest.php
similarity index 100%
rename from tests/lib/OAuthRequestTest.php
rename to tests/phpunit/lib/OAuthRequestTest.php
diff --git a/tests/lib/OAuthServerTest.php 
b/tests/phpunit/lib/OAuthServerTest.php
similarity index 100%
rename from tests/lib/OAuthServerTest.php
rename to tests/phpunit/lib/OAuthServerTest.php
diff --git a/tests/lib/OAuthSignatureMethodHmacSha1Test.php 
b/tests/phpunit/lib/OAuthSignatureMethodHmacSha1Test.php
similarity index 100%
rename from tests/lib/OAuthSignatureMethodHmacSha1Test.php
rename to tests/phpunit/lib/OAuthSignatureMethodHmacSha1Test.php
diff --git a/tests/lib/OAuthSignatureMethodRsaSha1Test.php 
b/tests/phpunit/lib/OAuthSignatureMethodRsaSha1Test.php
similarity index 100%
rename from 

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Graduate live update out of beta

[Catrope (Code Review)]

Catrope has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/393692 )

Change subject: Graduate live update out of beta
..

Graduate live update out of beta

Bug: T173614
Change-Id: I680b518fa3b8a0bb5ac3a6ec8347e57e70c26d20
---
M resources/src/mediawiki.rcfilters/mw.rcfilters.js
1 file changed, 1 insertion(+), 2 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core 
refs/changes/92/393692/1

diff --git a/resources/src/mediawiki.rcfilters/mw.rcfilters.js 
b/resources/src/mediawiki.rcfilters/mw.rcfilters.js
index e28f34a..466b7c0 100644
--- a/resources/src/mediawiki.rcfilters/mw.rcfilters.js
+++ b/resources/src/mediawiki.rcfilters/mw.rcfilters.js
@@ -46,8 +46,7 @@
}
},
featureFlags: {
-   liveUpdate: mw.config.get( 
'StructuredChangeFiltersLiveUpdatePollingRate' ) &&
-   ( mw.user.options.get( 'rcenhancedfilters' ) || 
new mw.Uri().query.liveupdate )
+   liveUpdate: mw.config.get( 
'StructuredChangeFiltersLiveUpdatePollingRate' )
}
};
 }( mediaWiki ) );

-- 
To view, visit https://gerrit.wikimedia.org/r/393692
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I680b518fa3b8a0bb5ac3a6ec8347e57e70c26d20
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Catrope 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...ApiExplorer[master]: Remove $wgStyleVersion

[jenkins-bot (Code Review)]

jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/393665 )

Change subject: Remove $wgStyleVersion
..


Remove $wgStyleVersion

Remove some unused variables

Bug: T181318
Change-Id: I8ba1eebc9f6a57d2f0e572ebbc4c8789e92159fd
---
M SpecialApiExplorer.php
1 file changed, 6 insertions(+), 11 deletions(-)

Approvals:
  jenkins-bot: Verified
  Jforrester: Looks good to me, approved



diff --git a/SpecialApiExplorer.php b/SpecialApiExplorer.php
index 1e82641..ce71f8a 100644
--- a/SpecialApiExplorer.php
+++ b/SpecialApiExplorer.php
@@ -45,20 +45,15 @@
 * @param $par - parameters for SpecialPage. Ignored.
 */
public function execute( $par = null ) {
-   global $wgOut, $wgExtensionsPath, $wgCityId, $wgStyleVersion;
+   global $wgOut, $wgExtensionsPath;
wfProfileIn( __METHOD__ );
 
-   // TODO: Make this work for ResourceLoader (Wikia isn't using 
RL yet at the time of this writing).
-   // Wikia has the cachebuster in the wgExtensionPath (we rewrite 
that in varnish because many proxies won't cache things that have "?" in the 
URL), but other MediaWikis need the style-version in the querystring.
-   $cbSuffix = ( isset( $wgCityId ) ? "?{$wgStyleVersion}" : "" );
-   $wgOut->addScript( ""
 );
-   $wgOut->addScript( "" );
-   $wgOut->addScript( "" );
+   $wgOut->addScript( "" );
+   $wgOut->addScript( "" );
+   $wgOut->addScript( "" );
 
ob_start();
$buttonHeight = 15;
-   $collapseSrc = 
"$wgExtensionsPath/ApiExplorer/collapse.png$cbSuffix";
-   $expandSrc = 
"$wgExtensionsPath/ApiExplorer/collapse.png$cbSuffix";
?>
.collapsible h2 span, .collapsible h3 span{
width:px;
@@ -68,10 +63,10 @@
 
background-repeat:no-repeat;
background-position:right center;
-   background-image: url();
+   background-image: url();
}
.collapsed h2 span, .collapsed h3 span{
-   background-image: url();
+   background-image: url();
}



-- 
To view, visit https://gerrit.wikimedia.org/r/393665
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I8ba1eebc9f6a57d2f0e572ebbc4c8789e92159fd
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/ApiExplorer
Gerrit-Branch: master
Gerrit-Owner: Reedy 
Gerrit-Reviewer: Jforrester 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...SemanticPageMaker[master]: Remove $wgStyleVersion

[jenkins-bot (Code Review)]

jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/393663 )

Change subject: Remove $wgStyleVersion
..


Remove $wgStyleVersion

Bug: T181318
Change-Id: I296dcdbb197412a96ad3b04a8d5a8e3efbabf112
---
M specials/WidgetAssembler/SPM_UploadWindow.php
1 file changed, 2 insertions(+), 2 deletions(-)

Approvals:
  jenkins-bot: Verified
  Jforrester: Looks good to me, approved



diff --git a/specials/WidgetAssembler/SPM_UploadWindow.php 
b/specials/WidgetAssembler/SPM_UploadWindow.php
index 2e31958..ccbe7c6 100644
--- a/specials/WidgetAssembler/SPM_UploadWindow.php
+++ b/specials/WidgetAssembler/SPM_UploadWindow.php
@@ -850,7 +850,7 @@
global $wgOut, $wgUser, $wgContLang;
global $wgUseCopyrightUpload, $wgUseAjax, 
$wgAjaxUploadDestCheck, $wgAjaxLicensePreview;
global $wgAllowCopyUploads;
-   global $wgStylePath, $wgStyleVersion;
+   global $wgStylePath;
 
$useAjaxDestCheck = $wgUseAjax && $wgAjaxUploadDestCheck;
$useAjaxLicensePreview = $wgUseAjax && $wgAjaxLicensePreview;
@@ -862,7 +862,7 @@
 wgAjaxUploadDestCheck = {$adc};
 wgAjaxLicensePreview = {$alp};
 
-
+
" );
 
if ( !wfRunHooks( 'UploadForm:initial', array( &$this ) ) )

-- 
To view, visit https://gerrit.wikimedia.org/r/393663
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I296dcdbb197412a96ad3b04a8d5a8e3efbabf112
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/SemanticPageMaker
Gerrit-Branch: master
Gerrit-Owner: Reedy 
Gerrit-Reviewer: Jforrester 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Change "Live update" button animation

[jenkins-bot (Code Review)]

jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/393643 )

Change subject: Change "Live update" button animation
..


Change "Live update" button animation

- Extend the total length of the animation to 2.3 seconds.
- Redefine the transitions in the animation to be completed
already at the 80% point (instead of the current 100%),
in order to create a period of no change between repetitions.

Bug: T176474
Change-Id: Ibea7c74a90be0394223d8fa85324bbf4cee16c4d
---
M 
resources/src/mediawiki.rcfilters/styles/mw.rcfilters.ui.LiveUpdateButtonWidget.less
1 file changed, 2 insertions(+), 1 deletion(-)

Approvals:
  Catrope: Looks good to me, approved
  jenkins-bot: Verified



diff --git 
a/resources/src/mediawiki.rcfilters/styles/mw.rcfilters.ui.LiveUpdateButtonWidget.less
 
b/resources/src/mediawiki.rcfilters/styles/mw.rcfilters.ui.LiveUpdateButtonWidget.less
index 67664b5..3c8664c 100644
--- 
a/resources/src/mediawiki.rcfilters/styles/mw.rcfilters.ui.LiveUpdateButtonWidget.less
+++ 
b/resources/src/mediawiki.rcfilters/styles/mw.rcfilters.ui.LiveUpdateButtonWidget.less
@@ -19,7 +19,7 @@
border-radius: 100%;
transform-origin: 50% 50%;
opacity: 0;
-   animation: ripple 1.2s ease-out infinite;
+   animation: ripple 2.3s ease-out infinite;
animation-delay: 1s;
}
}
@@ -35,6 +35,7 @@
.transform( scale( 1.5 ) );
opacity: 0.8;
}
+   80%,
100% {
opacity: 0;
.transform( scale( 4 ) );

-- 
To view, visit https://gerrit.wikimedia.org/r/393643
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ibea7c74a90be0394223d8fa85324bbf4cee16c4d
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Petar.petkovic 
Gerrit-Reviewer: Catrope 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] operations/puppet[production]: Gerrit: Fix negative cut-off logo on page load

[Krinkle (Code Review)]

Krinkle has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/393691 )

Change subject: Gerrit: Fix negative cut-off logo on page load
..

Gerrit: Fix negative cut-off logo on page load

Follows-up db9ea750ef. Simplify the CSS a bit and make the logo
absolute positioned.

It was practically already absolutely positioned given all the
arbitrary and negative relative offsets that are highly dependent
on the rest of the interface (which are variable).

Previously the logo was positioned relative to the bottom of the
menu, into the left margin that the menu reserved. It positioned
itself upward by 56px which is 48px (height of menu), plus 4px (
padding-top of menu), plus 4px (padding-bottom of menu).

However, this didn't always work as expected:

* The menu's height isn't actually defined as 48px, which
  is only the default render height given a particular font size
  and number of rows. This can change. Gerrit's interface supports
  such change, but our hack did not.

* The menu's padding isn't actually defined as 4px. Rather 4px
  is the result of various internal table borders of 1px or 2px
  stacking up to produce 4px efffective padding.
  In addition, those borders are not defined in Gerrit and actually
  varies by browser (user agent default styles). Causing the logo
  to render in slightly different positions.

* When a Gerrit page first loads, the gerrit_topmenu element
  is empty and has no height. Its contents are populated later.
  As a result, the first render of a Gerrit page is empty with
  some "Page is loading..." text and a partially cut-off Gerrit
  logo that was 56px off the page toward the top.

These are all fixed, by changing the position of the logo to
be computed from the top-left edge of the page, instead of
relative to the bottom bottom corner of the menu.

The relative position code for that ensures the heigiht being
reserved is replaced with a min-height declaration on topmenu.

Change-Id: I3ca795bb3a3f7c5088fac00bb1b81fdd3139098c
---
M modules/gerrit/files/etc/GerritSite.css
1 file changed, 19 insertions(+), 13 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/operations/puppet 
refs/changes/91/393691/1

diff --git a/modules/gerrit/files/etc/GerritSite.css 
b/modules/gerrit/files/etc/GerritSite.css
index 906fe64..eeda090 100644
--- a/modules/gerrit/files/etc/GerritSite.css
+++ b/modules/gerrit/files/etc/GerritSite.css
@@ -52,27 +52,30 @@
 }
 
 /**
- * Header
+ * The logo uses position absolute because the HTML generated by Gerrit
+ * creates the header as a sibling *after* the menu instead of before it.
+ * As such, the only reliable way to render to the left of it, is either
+ * with fragile negative offsets, or by using absolute position.
+ *
+ * The logo is taller than gerrit_topmenu. As such, a later CSS rule
+ * ensures gerrit_topmenu has a minimum height that accomodates the
+ * logo as well, to avoid page content from overlapping the logo.
  */
 #gerrit_header {
display: block !important;
-   width: 85px;
-   position: relative;
-   /* 54px puts it exactly against the top of the page */
-   top: -54px;
-   margin-bottom: -54px;
-   height: 68px;
 }
-
 .wm-gerrit-heading {
-   margin: 0.5em 0 0 0.5em;
+   position: absolute;
+   top: 0; left: 0;
+
+   margin: 7px 13px;
padding: 0;
-   font-family: 'PT Sans', sans-serif;
+
+   /* This font and color aren't used since there is an image there,
+* but is kept for consistency when used for display of alt-text
+*/
font-weight: normal;
letter-spacing: -1px;
-   /* This color isn't used since there is an image there,
-* but it kept for consistency when used for display of alt-text
-*/
color: #99;
 
min-height: 60px;
@@ -94,6 +97,9 @@
background: none;
/* Make sure it is above the logo or we can not clck the sub menu items 
*/
z-index: 1;
+   /* Ensure logo is not cut off by page content */
+   /* 74px = 60px height + (2 x 7px) margin */
+   min-height: 74px;
 }
 
 #gerrit_topmenu tbody tr td table {

-- 
To view, visit https://gerrit.wikimedia.org/r/393691
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I3ca795bb3a3f7c5088fac00bb1b81fdd3139098c
Gerrit-PatchSet: 1
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Krinkle 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] apps...wikipedia[master]: Design updates for Randomizer.

[jenkins-bot (Code Review)]

jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/393632 )

Change subject: Design updates for Randomizer.
..


Design updates for Randomizer.

- The bookmark icon is now correctly filled-in when the page is added to a
  list, and allows the user to remove and/or add to another list.
- Fixed background color.
- Card height is now fixed.

Bug: T158788
Change-Id: I7015f580713346b227b7a3a8d755e11d21bc6621
---
M app/src/main/java/org/wikipedia/random/RandomFragment.java
M app/src/main/java/org/wikipedia/random/RandomItemFragment.java
M app/src/main/res/layout-land/fragment_random.xml
M app/src/main/res/layout/fragment_random.xml
M app/src/main/res/layout/fragment_random_item.xml
5 files changed, 36 insertions(+), 14 deletions(-)

Approvals:
  jenkins-bot: Verified
  Cooltey: Looks good to me, approved



diff --git a/app/src/main/java/org/wikipedia/random/RandomFragment.java 
b/app/src/main/java/org/wikipedia/random/RandomFragment.java
index d822a1f..cca8bc6 100644
--- a/app/src/main/java/org/wikipedia/random/RandomFragment.java
+++ b/app/src/main/java/org/wikipedia/random/RandomFragment.java
@@ -22,11 +22,11 @@
 import org.wikipedia.page.PageTitle;
 import org.wikipedia.readinglist.AddToReadingListDialog;
 import org.wikipedia.readinglist.ReadingList;
+import org.wikipedia.readinglist.ReadingListBookmarkMenu;
 import org.wikipedia.readinglist.page.ReadingListPage;
 import org.wikipedia.readinglist.page.database.ReadingListDaoProxy;
 import org.wikipedia.util.DimenUtil;
 import org.wikipedia.util.FeedbackUtil;
-import org.wikipedia.util.ShareUtil;
 
 import butterknife.BindView;
 import butterknife.ButterKnife;
@@ -36,11 +36,11 @@
 public class RandomFragment extends Fragment {
 @BindView(R.id.random_item_pager) ViewPager randomPager;
 @BindView(R.id.random_next_button) View nextButton;
-@BindView(R.id.random_save_button) ImageView saveShareButton;
+@BindView(R.id.random_save_button) ImageView saveButton;
 @BindView(R.id.random_back_button) View backButton;
 private Unbinder unbinder;
 private ExclusiveBottomSheetPresenter bottomSheetPresenter = new 
ExclusiveBottomSheetPresenter();
-private boolean saveShareButtonState;
+private boolean saveButtonState;
 private ViewPagerListener viewPagerListener = new ViewPagerListener();
 
 @NonNull
@@ -54,7 +54,7 @@
 super.onCreateView(inflater, container, savedInstanceState);
 View view = inflater.inflate(R.layout.fragment_random, container, 
false);
 unbinder = ButterKnife.bind(this, view);
-FeedbackUtil.setToolbarButtonLongPressToast(nextButton, 
saveShareButton);
+FeedbackUtil.setToolbarButtonLongPressToast(nextButton, saveButton);
 
 randomPager.setOffscreenPageLimit(2);
 randomPager.setAdapter(new RandomItemAdapter((AppCompatActivity) 
getActivity()));
@@ -88,8 +88,20 @@
 if (title == null) {
 return;
 }
-if (saveShareButtonState) {
-ShareUtil.shareText(getActivity(), title);
+if (saveButtonState) {
+new ReadingListBookmarkMenu(saveButton, new 
ReadingListBookmarkMenu.Callback() {
+@Override
+public void onAddRequest(@Nullable ReadingListPage page) {
+onAddPageToList(title);
+}
+
+@Override
+public void onDeleted(@Nullable ReadingListPage page) {
+FeedbackUtil.showMessage(getActivity(),
+getString(R.string.reading_list_item_deleted, 
title.getDisplayText()));
+updateSaveShareButton(title);
+}
+}).show(title);
 } else {
 onAddPageToList(title);
 }
@@ -117,9 +129,9 @@
 
ReadingList.DAO.anyListContainsTitleAsync(ReadingListDaoProxy.key(title),
 new CallbackTask.DefaultCallback() {
 @Override public void success(@Nullable ReadingListPage 
page) {
-saveShareButtonState = page != null;
-saveShareButton.setImageResource(saveShareButtonState
-? R.drawable.ic_share_white_24dp : 
R.drawable.ic_bookmark_border_white_24dp);
+saveButtonState = page != null;
+saveButton.setImageResource(saveButtonState
+? R.drawable.ic_bookmark_white_24dp : 
R.drawable.ic_bookmark_border_white_24dp);
 }
 });
 }
diff --git a/app/src/main/java/org/wikipedia/random/RandomItemFragment.java 
b/app/src/main/java/org/wikipedia/random/RandomItemFragment.java
index ed69650..2a6aec5 100644
--- a/app/src/main/java/org/wikipedia/random/RandomItemFragment.java
+++ b/app/src/main/java/org/wikipedia/random/RandomItemFragment.java
@@ -9,6 +9,7 @@
 import 

[MediaWiki-commits] [Gerrit] mediawiki...Wikibase[master]: [WIP] Move most of the config building to CirrusSearch

[Smalyshev (Code Review)]

Smalyshev has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/393690 )

Change subject: [WIP] Move most of the config building to CirrusSearch
..

[WIP] Move most of the config building to CirrusSearch

Depends-On: I6abaf6b75aac86b39d416372c612e4099bfddfaa
Bug: T176903
Change-Id: Ie1936878fe7a820cef5ccf78ae4ea548243c0f2e
---
M repo/includes/Search/Elastic/ConfigBuilder.php
1 file changed, 8 insertions(+), 140 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Wikibase 
refs/changes/90/393690/1

diff --git a/repo/includes/Search/Elastic/ConfigBuilder.php 
b/repo/includes/Search/Elastic/ConfigBuilder.php
index 3fbb733..d0df529 100644
--- a/repo/includes/Search/Elastic/ConfigBuilder.php
+++ b/repo/includes/Search/Elastic/ConfigBuilder.php
@@ -34,152 +34,20 @@
}
 
/**
-* Replace certain filter name in all configs with different name.
-* @param array[] $config Configuration being processed
-* @param string $oldName
-* @param string $newName
-*/
-   private function replaceFilter( array &$config, $oldName, $newName ) {
-   foreach ( $config['analyzer'] as &$analyzer ) {
-   if ( !isset( $analyzer['filter'] ) ) {
-   continue;
-   }
-   $analyzer['filter'] = array_map( function ( $filter ) 
use ( $oldName, $newName ) {
-   if ( $filter === $oldName ) {
-   return $newName;
-   }
-   return $filter;
-   }, $analyzer['filter'] );
-   }
-   }
-
-   /**
-* Check every filter in the config - if it's the same as in old config,
-* ignore it. If it has the same name, but different content - create 
new filter
-* with different name by prefixing it with language name.
-*
-* @param array[] $config Configuration being processed
-* @param array[] $standardFilters Existing filters list
-* @param array[] $defaultFilters List of default filters already 
mentioned in the config
-* @param string $prefix Prefix for disambiguation
-* @return array[] The list of filters not in the old config.
-*/
-   private function resolveFilters( array &$config, array 
$standardFilters, array $defaultFilters, $prefix ) {
-   $resultFilters = [];
-   foreach ( $config['filter'] as $name => $filter ) {
-   $existingFilter = null;
-   if ( isset( $standardFilters[$name] ) ) {
-   $existingFilter = $standardFilters[$name];
-   } elseif ( isset( $defaultFilters[$name] ) ) {
-   $existingFilter = $defaultFilters[$name];
-   }
-
-   if ( $existingFilter ) { // Filter with this name 
already exists
-   if ( $existingFilter != $filter ) {
-   // filter with the same name but 
different config - need to
-   // rename by adding prefix
-   $newName = $prefix . '_' . $name;
-   $this->replaceFilter( $config, $name, 
$newName );
-   $resultFilters[$newName] = $filter;
-   }
-   } else {
-   $resultFilters[$name] = $filter;
-   }
-   }
-   return $resultFilters;
-   }
-
-   /**
-* Merge per-language config into the main config.
-* It will copy specific analyzer and all dependant filters and 
char_filters.
-* @param array $config Main config
-* @param array $langConfig Per-language config
-* @param string $name Name for analyzer whose config we're merging
-* @param string $prefix Prefix for this configuration
-*/
-   private function mergeConfig( array &$config, array $langConfig, $name, 
$prefix ) {
-   $analyzer = $langConfig['analyzer'][$name];
-   $config['analyzer'][$prefix . '_' . $name] = $analyzer;
-   if ( !empty( $analyzer['filter'] ) ) {
-   // Add private filters for this analyzer
-   foreach ( $analyzer['filter'] as $filter ) {
-   // Copy filters that are in language config but 
not in the main config.
-   // We would not copy the same filter into the 
main config since due to
-   // the resolution step we know they are the 
same (otherwise we would have
-   // renamed it).
- 

[MediaWiki-commits] [Gerrit] mediawiki...CirrusSearch[master]: [WIP] Port per-language indexing code from Wikibase to Cirru...

[Smalyshev (Code Review)]

Smalyshev has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/393689 )

Change subject: [WIP] Port per-language indexing code from Wikibase to 
CirrusSearch
..

[WIP] Port per-language indexing code from Wikibase to CirrusSearch

Bug: T176903
Change-Id: I6abaf6b75aac86b39d416372c612e4099bfddfaa
---
M includes/Maintenance/AnalysisConfigBuilder.php
1 file changed, 144 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/CirrusSearch 
refs/changes/89/393689/1

diff --git a/includes/Maintenance/AnalysisConfigBuilder.php 
b/includes/Maintenance/AnalysisConfigBuilder.php
index 0ee472b..9615687 100644
--- a/includes/Maintenance/AnalysisConfigBuilder.php
+++ b/includes/Maintenance/AnalysisConfigBuilder.php
@@ -987,6 +987,150 @@
}
 
/**
+* Get list of filters that are mentioned in analyzers but not defined
+* explicitly.
+* @param array[] $config Full configuration array
+* @param string[] $analyzers List of analyzers to consider.
+* @return array List of default filters, each containing only filter 
type
+*/
+   private function getDefaultFilters( array &$config,  array $analyzers ) 
{
+   $defaultFilters = [];
+   foreach ( $analyzers as $analyzer ) {
+   if ( empty( $config['analyzer'][$analyzer]['filter'] ) 
) {
+   continue;
+   }
+   foreach ( $config['analyzer'][$analyzer]['filter'] as 
$filterName ) {
+   if ( !isset( $config['filter'][$filterName] ) ) 
{
+   // This is default definition for the 
built-in filter
+   $defaultFilters[$filterName] = [ 'type' 
=> $filterName ];
+   }
+   }
+   }
+   return $defaultFilters;
+   }
+
+   /**
+* Check every filter in the config - if it's the same as in old config,
+* ignore it. If it has the same name, but different content - create 
new filter
+* with different name by prefixing it with language name.
+*
+* @param array[] $config Configuration being processed
+* @param array[] $standardFilters Existing filters list
+* @param array[] $defaultFilters List of default filters already 
mentioned in the config
+* @param string $prefix Prefix for disambiguation
+* @return array[] The list of filters not in the old config.
+*/
+   private function resolveFilters( array &$config, array 
$standardFilters, array $defaultFilters, $prefix ) {
+   $resultFilters = [];
+   foreach ( $config['filter'] as $name => $filter ) {
+   $existingFilter = null;
+   if ( isset( $standardFilters[$name] ) ) {
+   $existingFilter = $standardFilters[$name];
+   } elseif ( isset( $defaultFilters[$name] ) ) {
+   $existingFilter = $defaultFilters[$name];
+   }
+
+   if ( $existingFilter ) { // Filter with this name 
already exists
+   if ( $existingFilter != $filter ) {
+   // filter with the same name but 
different config - need to
+   // rename by adding prefix
+   $newName = $prefix . '_' . $name;
+   $this->replaceFilter( $config, $name, 
$newName );
+   $resultFilters[$newName] = $filter;
+   }
+   } else {
+   $resultFilters[$name] = $filter;
+   }
+   }
+   return $resultFilters;
+   }
+
+   /**
+* Replace certain filter name in all configs with different name.
+* @param array[] $config Configuration being processed
+* @param string $oldName
+* @param string $newName
+*/
+   private function replaceFilter( array &$config, $oldName, $newName ) {
+   foreach ( $config['analyzer'] as &$analyzer ) {
+   if ( !isset( $analyzer['filter'] ) ) {
+   continue;
+   }
+   $analyzer['filter'] = array_map( function ( $filter ) 
use ( $oldName, $newName ) {
+   if ( $filter === $oldName ) {
+   return $newName;
+   }
+   return $filter;
+   }, $analyzer['filter'] );
+   }
+   }
+
+   /**
+* Merge per-language config into 

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: resources: Upgrade jquery.chosen from 0.9.14 to 1.8.2

[Jforrester (Code Review)]

Jforrester has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/393687 )

Change subject: resources: Upgrade jquery.chosen from 0.9.14 to 1.8.2
..

resources: Upgrade jquery.chosen from 0.9.14 to 1.8.2

Change-Id: If9c720ebca8ca663869d0f73b0cd3ea415262cff
---
M RELEASE-NOTES-1.31
M resources/lib/jquery.chosen/LICENSE
A resources/lib/jquery.chosen/README.md
M resources/lib/jquery.chosen/chosen-sprite.png
M resources/lib/jquery.chosen/chosen-spr...@2x.png
M resources/lib/jquery.chosen/chosen.css
M resources/lib/jquery.chosen/chosen.jquery.js
7 files changed, 1,201 insertions(+), 857 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core 
refs/changes/87/393687/1

diff --git a/RELEASE-NOTES-1.31 b/RELEASE-NOTES-1.31
index 3de0e17..4b7795a 100644
--- a/RELEASE-NOTES-1.31
+++ b/RELEASE-NOTES-1.31
@@ -26,6 +26,7 @@
 === External library changes in 1.31 ===
 
  Upgraded external libraries 
+* Updated jquery.chosen from v0.9.14 to v1.8.2.
 * …
 
  New external libraries 
diff --git a/resources/lib/jquery.chosen/LICENSE 
b/resources/lib/jquery.chosen/LICENSE
index 0675dc5..5e1332c 100644
--- a/resources/lib/jquery.chosen/LICENSE
+++ b/resources/lib/jquery.chosen/LICENSE
@@ -1,9 +1,8 @@
-# Chosen, a Select Box Enhancer for jQuery and Protoype
-## by Patrick Filler for [Harvest](http://getharvest.com)
+ Chosen
+- by Patrick Filler for [Harvest](http://getharvest.com)
+- Copyright (c) 2011-2016 by Harvest
 
 Available for use under the [MIT 
License](http://en.wikipedia.org/wiki/MIT_License)
-
-Copyright (c) 2011-2013 by Harvest
 
 Permission is hereby granted, free of charge, to any person obtaining a copy
 of this software and associated documentation files (the "Software"), to deal
diff --git a/resources/lib/jquery.chosen/README.md 
b/resources/lib/jquery.chosen/README.md
new file mode 100644
index 000..5b21256
--- /dev/null
+++ b/resources/lib/jquery.chosen/README.md
@@ -0,0 +1,48 @@
+# Chosen
+
+Chosen is a library for making long, unwieldy select boxes more user friendly.
+
+- jQuery support: 1.7+
+- Prototype support: 1.7+
+
+For **documentation**, usage, and examples, see:
+http://harvesthq.github.io/chosen/
+
+For **downloads**, see:
+https://github.com/harvesthq/chosen/releases/
+
+### Package managers
+
+Chosen is available through [Bower](https://bower.io/) and 
[npm](https://www.npmjs.com),
+_however, the package names are not the same_.
+
+To install with Bower:
+
+```
+bower install chosen
+```
+
+To install with npm:
+
+```
+npm install chosen-js
+```
+
+The compiled files for these packages are automatically generated and stored 
in a [2nd Chosen repository](https://github.com/harvesthq/chosen-package). No 
pull requests will be accepted to that repository.
+
+### Contributing to this project
+
+We welcome all to participate in making Chosen the best software it can be. 
The repository is maintained by only a few people, but has accepted 
contributions from over 50 authors after reviewing hundreds of pull requests 
related to thousands of issues. You can help reduce the maintainers' workload 
(and increase your chance of having an accepted contribution to Chosen) by 
following the
+[guidelines for contributing](contributing.md).
+
+* [Bug reports](contributing.md#bugs)
+* [Feature requests](contributing.md#features)
+* [Pull requests](contributing.md#pull-requests)
+
+### Chosen Credits
+
+- Concept and development by [Patrick Filler](http://patrickfiller.com) for 
[Harvest](http://getharvest.com/).
+- Design and CSS by [Matthew Lettini](http://matthewlettini.com/)
+- Repository maintained by [@pfiller](http://github.com/pfiller), 
[@kenearley](http://github.com/kenearley), [@stof](http://github.com/stof), 
[@koenpunt](http://github.com/koenpunt), and 
[@tjschuck](http://github.com/tjschuck).
+- Chosen includes [contributions by many fine 
folks](https://github.com/harvesthq/chosen/contributors).
+
diff --git a/resources/lib/jquery.chosen/chosen-sprite.png 
b/resources/lib/jquery.chosen/chosen-sprite.png
index 3611ae4..c57da70 100644
--- a/resources/lib/jquery.chosen/chosen-sprite.png
+++ b/resources/lib/jquery.chosen/chosen-sprite.png
Binary files differ
diff --git a/resources/lib/jquery.chosen/chosen-spr...@2x.png 
b/resources/lib/jquery.chosen/chosen-spr...@2x.png
index bd61d96..6b50545 100644
--- a/resources/lib/jquery.chosen/chosen-spr...@2x.png
+++ b/resources/lib/jquery.chosen/chosen-spr...@2x.png
Binary files differ
diff --git a/resources/lib/jquery.chosen/chosen.css 
b/resources/lib/jquery.chosen/chosen.css
index 17793ed..d4219b4 100644
--- a/resources/lib/jquery.chosen/chosen.css
+++ b/resources/lib/jquery.chosen/chosen.css
@@ -1,440 +1,490 @@
+/*!
+Chosen, a Select Box Enhancer for jQuery and Prototype
+by Patrick Filler for Harvest, http://getharvest.com
+
+Version 1.8.2
+Full source at https://github.com/harvesthq/chosen
+Copyright (c) 2011-2017 Harvest 

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: [WIP] HTMLForm: Drop this never-used backwards-compatibility

[Jforrester (Code Review)]

Jforrester has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/393688 )

Change subject: [WIP] HTMLForm: Drop this never-used backwards-compatibility
..

[WIP] HTMLForm: Drop this never-used backwards-compatibility

Change-Id: I6864d3a1207de44d465491baad87cb9c00714255
---
M RELEASE-NOTES-1.31
M includes/htmlform/fields/HTMLMultiSelectField.php
2 files changed, 5 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core 
refs/changes/88/393688/1

diff --git a/RELEASE-NOTES-1.31 b/RELEASE-NOTES-1.31
index 4b7795a..f1cb261 100644
--- a/RELEASE-NOTES-1.31
+++ b/RELEASE-NOTES-1.31
@@ -106,6 +106,10 @@
 * Use of Maintenance::error( $err, $die ) to exit script was deprecated. Use
   Maintenance::fatalError() instead.
 * Passing a ParserOptions object to OutputPage::parserOptions() is deprecated.
+* The backwards-compatibility code in HTMLForm to add a drop-down control to an
+  option that is not set to be a drop-down if the "mw-chosen" class is present,
+  is now removed.
+* …
 
 == Compatibility ==
 MediaWiki 1.31 requires PHP 5.5.9 or later. There is experimental support for
diff --git a/includes/htmlform/fields/HTMLMultiSelectField.php 
b/includes/htmlform/fields/HTMLMultiSelectField.php
index 238b2b4..21c034b 100644
--- a/includes/htmlform/fields/HTMLMultiSelectField.php
+++ b/includes/htmlform/fields/HTMLMultiSelectField.php
@@ -22,8 +22,7 @@
$this->mParams['disabled-options'] = [];
}
 
-   // For backwards compatibility, also handle the old way with 
'cssclass' => 'mw-chosen'
-   if ( isset( $params['dropdown'] ) || strpos( $this->mClass, 
'mw-chosen' ) !== false ) {
+   if ( isset( $params['dropdown'] ) ) {
$this->mClass .= ' mw-htmlform-dropdown';
}
 

-- 
To view, visit https://gerrit.wikimedia.org/r/393688
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I6864d3a1207de44d465491baad87cb9c00714255
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Jforrester 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] wikimedia...dash[deployment]: Merge branch 'master' into deployment

[jenkins-bot (Code Review)]

jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/393686 )

Change subject: Merge branch 'master' into deployment
..


Merge branch 'master' into deployment

4d49a59 git.wikimedia.org -> phab
8e62035 Label dates better in Big English chart
4cb44dc Change individual amount cutoff to $5000
130ec05 Configurable target per campaign

Change-Id: I7417e323146e160b5d48df8121789e284de1a636
---
0 files changed, 0 insertions(+), 0 deletions(-)

Approvals:
  jenkins-bot: Verified
  Ejegg: Looks good to me, approved




-- 
To view, visit https://gerrit.wikimedia.org/r/393686
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I7417e323146e160b5d48df8121789e284de1a636
Gerrit-PatchSet: 1
Gerrit-Project: wikimedia/fundraising/dash
Gerrit-Branch: deployment
Gerrit-Owner: Ejegg 
Gerrit-Reviewer: Ejegg 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] wikimedia...dash[deployment]: Merge branch 'master' into deployment

[Ejegg (Code Review)]

Ejegg has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/393686 )

Change subject: Merge branch 'master' into deployment
..

Merge branch 'master' into deployment

4d49a59 git.wikimedia.org -> phab
8e62035 Label dates better in Big English chart
4cb44dc Change individual amount cutoff to $5000
130ec05 Configurable target per campaign

Change-Id: I7417e323146e160b5d48df8121789e284de1a636
---
0 files changed, 0 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/wikimedia/fundraising/dash 
refs/changes/86/393686/1


-- 
To view, visit https://gerrit.wikimedia.org/r/393686
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I7417e323146e160b5d48df8121789e284de1a636
Gerrit-PatchSet: 1
Gerrit-Project: wikimedia/fundraising/dash
Gerrit-Branch: deployment
Gerrit-Owner: Ejegg 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] wikimedia...dash[deployment]: Update bower_modules

[jenkins-bot (Code Review)]

jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/393685 )

Change subject: Update bower_modules
..


Update bower_modules

Change-Id: I8ae3c12dcccb60fb93864d94e5812d761ec7689b
---
M src/bower_modules
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  jenkins-bot: Verified
  Ejegg: Looks good to me, approved



diff --git a/src/bower_modules b/src/bower_modules
index 1db0504..f170ad9 16
--- a/src/bower_modules
+++ b/src/bower_modules
@@ -1 +1 @@
-Subproject commit 1db0504302c21003f6f5ad9a05d668ba929283d8
+Subproject commit f170ad9020b3b8a733fe8a6064fa119f34470244

-- 
To view, visit https://gerrit.wikimedia.org/r/393685
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I8ae3c12dcccb60fb93864d94e5812d761ec7689b
Gerrit-PatchSet: 1
Gerrit-Project: wikimedia/fundraising/dash
Gerrit-Branch: deployment
Gerrit-Owner: Ejegg 
Gerrit-Reviewer: Ejegg 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] wikimedia...dash[deployment]: Update bower_modules

[Ejegg (Code Review)]

Ejegg has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/393685 )

Change subject: Update bower_modules
..

Update bower_modules

Change-Id: I8ae3c12dcccb60fb93864d94e5812d761ec7689b
---
M src/bower_modules
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/wikimedia/fundraising/dash 
refs/changes/85/393685/1

diff --git a/src/bower_modules b/src/bower_modules
index 1db0504..f170ad9 16
--- a/src/bower_modules
+++ b/src/bower_modules
@@ -1 +1 @@
-Subproject commit 1db0504302c21003f6f5ad9a05d668ba929283d8
+Subproject commit f170ad9020b3b8a733fe8a6064fa119f34470244

-- 
To view, visit https://gerrit.wikimedia.org/r/393685
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I8ae3c12dcccb60fb93864d94e5812d761ec7689b
Gerrit-PatchSet: 1
Gerrit-Project: wikimedia/fundraising/dash
Gerrit-Branch: deployment
Gerrit-Owner: Ejegg 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] wikimedia...bower_modules[master]: Update momentjs

[Ejegg (Code Review)]

Ejegg has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/393684 )

Change subject: Update momentjs
..


Update momentjs

Change-Id: I8723b37f5f3667ab21ff72322bae1e53d5f277e2
---
M d3/.bower.json
M moment/.bower.json
A moment/CHANGELOG.md
M moment/LICENSE
A moment/README.md
M moment/bower.json
D moment/lang/ar-ma.js
D moment/lang/ar-sa.js
D moment/lang/ar.js
D moment/lang/az.js
D moment/lang/bg.js
D moment/lang/bn.js
D moment/lang/br.js
D moment/lang/bs.js
D moment/lang/ca.js
D moment/lang/cs.js
D moment/lang/cv.js
D moment/lang/cy.js
D moment/lang/da.js
D moment/lang/de-at.js
D moment/lang/de.js
D moment/lang/el.js
D moment/lang/en-au.js
D moment/lang/en-ca.js
D moment/lang/en-gb.js
D moment/lang/eo.js
D moment/lang/es.js
D moment/lang/et.js
D moment/lang/eu.js
D moment/lang/fa.js
D moment/lang/fi.js
D moment/lang/fo.js
D moment/lang/fr-ca.js
D moment/lang/fr.js
D moment/lang/gl.js
D moment/lang/he.js
D moment/lang/hi.js
D moment/lang/hr.js
D moment/lang/hu.js
D moment/lang/hy-am.js
D moment/lang/id.js
D moment/lang/is.js
D moment/lang/it.js
D moment/lang/ja.js
D moment/lang/ka.js
D moment/lang/km.js
D moment/lang/ko.js
D moment/lang/lb.js
D moment/lang/lt.js
D moment/lang/lv.js
D moment/lang/mk.js
D moment/lang/ml.js
D moment/lang/mr.js
D moment/lang/ms-my.js
D moment/lang/nb.js
D moment/lang/ne.js
D moment/lang/nl.js
D moment/lang/nn.js
D moment/lang/pl.js
D moment/lang/pt-br.js
D moment/lang/pt.js
D moment/lang/ro.js
D moment/lang/ru.js
D moment/lang/sk.js
D moment/lang/sl.js
D moment/lang/sq.js
D moment/lang/sr-cyrl.js
D moment/lang/sr.js
D moment/lang/sv.js
D moment/lang/ta.js
D moment/lang/th.js
D moment/lang/tl-ph.js
D moment/lang/tr.js
D moment/lang/tzm-latn.js
D moment/lang/tzm.js
D moment/lang/uk.js
D moment/lang/uz.js
D moment/lang/vi.js
D moment/lang/zh-cn.js
D moment/lang/zh-tw.js
A moment/locale/af.js
A moment/locale/ar-dz.js
A moment/locale/ar-kw.js
A moment/locale/ar-ly.js
A moment/locale/ar-ma.js
A moment/locale/ar-sa.js
A moment/locale/ar-tn.js
A moment/locale/ar.js
A moment/locale/az.js
A moment/locale/be.js
A moment/locale/bg.js
A moment/locale/bm.js
A moment/locale/bn.js
A moment/locale/bo.js
A moment/locale/br.js
A moment/locale/bs.js
A moment/locale/ca.js
A moment/locale/cs.js
A moment/locale/cv.js
A moment/locale/cy.js
A moment/locale/da.js
A moment/locale/de-at.js
A moment/locale/de-ch.js
A moment/locale/de.js
A moment/locale/dv.js
A moment/locale/el.js
A moment/locale/en-au.js
A moment/locale/en-ca.js
A moment/locale/en-gb.js
A moment/locale/en-ie.js
A moment/locale/en-nz.js
A moment/locale/eo.js
A moment/locale/es-do.js
A moment/locale/es-us.js
A moment/locale/es.js
A moment/locale/et.js
A moment/locale/eu.js
A moment/locale/fa.js
A moment/locale/fi.js
A moment/locale/fo.js
A moment/locale/fr-ca.js
A moment/locale/fr-ch.js
A moment/locale/fr.js
A moment/locale/fy.js
A moment/locale/gd.js
A moment/locale/gl.js
A moment/locale/gom-latn.js
A moment/locale/gu.js
A moment/locale/he.js
A moment/locale/hi.js
A moment/locale/hr.js
A moment/locale/hu.js
A moment/locale/hy-am.js
A moment/locale/id.js
A moment/locale/is.js
A moment/locale/it.js
A moment/locale/ja.js
A moment/locale/jv.js
A moment/locale/ka.js
A moment/locale/kk.js
A moment/locale/km.js
A moment/locale/kn.js
A moment/locale/ko.js
A moment/locale/ky.js
A moment/locale/lb.js
A moment/locale/lo.js
A moment/locale/lt.js
A moment/locale/lv.js
A moment/locale/me.js
A moment/locale/mi.js
A moment/locale/mk.js
A moment/locale/ml.js
A moment/locale/mr.js
A moment/locale/ms-my.js
A moment/locale/ms.js
A moment/locale/my.js
A moment/locale/nb.js
A moment/locale/ne.js
A moment/locale/nl-be.js
A moment/locale/nl.js
A moment/locale/nn.js
A moment/locale/pa-in.js
A moment/locale/pl.js
A moment/locale/pt-br.js
A moment/locale/pt.js
A moment/locale/ro.js
A moment/locale/ru.js
A moment/locale/sd.js
A moment/locale/se.js
A moment/locale/si.js
A moment/locale/sk.js
A moment/locale/sl.js
A moment/locale/sq.js
A moment/locale/sr-cyrl.js
A moment/locale/sr.js
A moment/locale/ss.js
A moment/locale/sv.js
A moment/locale/sw.js
A moment/locale/ta.js
A moment/locale/te.js
A moment/locale/tet.js
A moment/locale/th.js
A moment/locale/tl-ph.js
A moment/locale/tlh.js
A moment/locale/tr.js
A moment/locale/tzl.js
A moment/locale/tzm-latn.js
A moment/locale/tzm.js
A moment/locale/uk.js
A moment/locale/ur.js
A moment/locale/uz-latn.js
A moment/locale/uz.js
A moment/locale/vi.js
A moment/locale/x-pseudo.js
A moment/locale/yo.js
A moment/locale/zh-cn.js
A moment/locale/zh-hk.js
A moment/locale/zh-tw.js
D moment/min/langs.js
D moment/min/langs.min.js
A moment/min/locales.js
A moment/min/locales.min.js
D moment/min/moment-with-langs.js
D moment/min/moment-with-langs.min.js
A moment/min/moment-with-locales.js
A moment/min/moment-with-locales.min.js
M moment/min/moment.min.js
A moment/moment.d.ts
M moment/moment.js
D moment/readme.md
A 

[MediaWiki-commits] [Gerrit] wikimedia...bower_modules[master]: Update momentjs

[Ejegg (Code Review)]

Ejegg has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/393684 )

Change subject: Update momentjs
..

Update momentjs

Change-Id: I8723b37f5f3667ab21ff72322bae1e53d5f277e2
---
M d3/.bower.json
M moment/.bower.json
A moment/CHANGELOG.md
M moment/LICENSE
A moment/README.md
M moment/bower.json
D moment/lang/ar-ma.js
D moment/lang/ar-sa.js
D moment/lang/ar.js
D moment/lang/az.js
D moment/lang/bg.js
D moment/lang/bn.js
D moment/lang/br.js
D moment/lang/bs.js
D moment/lang/ca.js
D moment/lang/cs.js
D moment/lang/cv.js
D moment/lang/cy.js
D moment/lang/da.js
D moment/lang/de-at.js
D moment/lang/de.js
D moment/lang/el.js
D moment/lang/en-au.js
D moment/lang/en-ca.js
D moment/lang/en-gb.js
D moment/lang/eo.js
D moment/lang/es.js
D moment/lang/et.js
D moment/lang/eu.js
D moment/lang/fa.js
D moment/lang/fi.js
D moment/lang/fo.js
D moment/lang/fr-ca.js
D moment/lang/fr.js
D moment/lang/gl.js
D moment/lang/he.js
D moment/lang/hi.js
D moment/lang/hr.js
D moment/lang/hu.js
D moment/lang/hy-am.js
D moment/lang/id.js
D moment/lang/is.js
D moment/lang/it.js
D moment/lang/ja.js
D moment/lang/ka.js
D moment/lang/km.js
D moment/lang/ko.js
D moment/lang/lb.js
D moment/lang/lt.js
D moment/lang/lv.js
D moment/lang/mk.js
D moment/lang/ml.js
D moment/lang/mr.js
D moment/lang/ms-my.js
D moment/lang/nb.js
D moment/lang/ne.js
D moment/lang/nl.js
D moment/lang/nn.js
D moment/lang/pl.js
D moment/lang/pt-br.js
D moment/lang/pt.js
D moment/lang/ro.js
D moment/lang/ru.js
D moment/lang/sk.js
D moment/lang/sl.js
D moment/lang/sq.js
D moment/lang/sr-cyrl.js
D moment/lang/sr.js
D moment/lang/sv.js
D moment/lang/ta.js
D moment/lang/th.js
D moment/lang/tl-ph.js
D moment/lang/tr.js
D moment/lang/tzm-latn.js
D moment/lang/tzm.js
D moment/lang/uk.js
D moment/lang/uz.js
D moment/lang/vi.js
D moment/lang/zh-cn.js
D moment/lang/zh-tw.js
A moment/locale/af.js
A moment/locale/ar-dz.js
A moment/locale/ar-kw.js
A moment/locale/ar-ly.js
A moment/locale/ar-ma.js
A moment/locale/ar-sa.js
A moment/locale/ar-tn.js
A moment/locale/ar.js
A moment/locale/az.js
A moment/locale/be.js
A moment/locale/bg.js
A moment/locale/bm.js
A moment/locale/bn.js
A moment/locale/bo.js
A moment/locale/br.js
A moment/locale/bs.js
A moment/locale/ca.js
A moment/locale/cs.js
A moment/locale/cv.js
A moment/locale/cy.js
A moment/locale/da.js
A moment/locale/de-at.js
A moment/locale/de-ch.js
A moment/locale/de.js
A moment/locale/dv.js
A moment/locale/el.js
A moment/locale/en-au.js
A moment/locale/en-ca.js
A moment/locale/en-gb.js
A moment/locale/en-ie.js
A moment/locale/en-nz.js
A moment/locale/eo.js
A moment/locale/es-do.js
A moment/locale/es-us.js
A moment/locale/es.js
A moment/locale/et.js
A moment/locale/eu.js
A moment/locale/fa.js
A moment/locale/fi.js
A moment/locale/fo.js
A moment/locale/fr-ca.js
A moment/locale/fr-ch.js
A moment/locale/fr.js
A moment/locale/fy.js
A moment/locale/gd.js
A moment/locale/gl.js
A moment/locale/gom-latn.js
A moment/locale/gu.js
A moment/locale/he.js
A moment/locale/hi.js
A moment/locale/hr.js
A moment/locale/hu.js
A moment/locale/hy-am.js
A moment/locale/id.js
A moment/locale/is.js
A moment/locale/it.js
A moment/locale/ja.js
A moment/locale/jv.js
A moment/locale/ka.js
A moment/locale/kk.js
A moment/locale/km.js
A moment/locale/kn.js
A moment/locale/ko.js
A moment/locale/ky.js
A moment/locale/lb.js
A moment/locale/lo.js
A moment/locale/lt.js
A moment/locale/lv.js
A moment/locale/me.js
A moment/locale/mi.js
A moment/locale/mk.js
A moment/locale/ml.js
A moment/locale/mr.js
A moment/locale/ms-my.js
A moment/locale/ms.js
A moment/locale/my.js
A moment/locale/nb.js
A moment/locale/ne.js
A moment/locale/nl-be.js
A moment/locale/nl.js
A moment/locale/nn.js
A moment/locale/pa-in.js
A moment/locale/pl.js
A moment/locale/pt-br.js
A moment/locale/pt.js
A moment/locale/ro.js
A moment/locale/ru.js
A moment/locale/sd.js
A moment/locale/se.js
A moment/locale/si.js
A moment/locale/sk.js
A moment/locale/sl.js
A moment/locale/sq.js
A moment/locale/sr-cyrl.js
A moment/locale/sr.js
A moment/locale/ss.js
A moment/locale/sv.js
A moment/locale/sw.js
A moment/locale/ta.js
A moment/locale/te.js
A moment/locale/tet.js
A moment/locale/th.js
A moment/locale/tl-ph.js
A moment/locale/tlh.js
A moment/locale/tr.js
A moment/locale/tzl.js
A moment/locale/tzm-latn.js
A moment/locale/tzm.js
A moment/locale/uk.js
A moment/locale/ur.js
A moment/locale/uz-latn.js
A moment/locale/uz.js
A moment/locale/vi.js
A moment/locale/x-pseudo.js
A moment/locale/yo.js
A moment/locale/zh-cn.js
A moment/locale/zh-hk.js
A moment/locale/zh-tw.js
D moment/min/langs.js
D moment/min/langs.min.js
A moment/min/locales.js
A moment/min/locales.min.js
D moment/min/moment-with-langs.js
D moment/min/moment-with-langs.min.js
A moment/min/moment-with-locales.js
A moment/min/moment-with-locales.min.js
M moment/min/moment.min.js
A moment/moment.d.ts
M moment/moment.js
D moment/readme.md
A moment/src/lib/create/check-overflow.js
A 

[MediaWiki-commits] [Gerrit] operations/puppet[production]: ganeti: remove Ganglia

[Dzahn (Code Review)]

Dzahn has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/393683 )

Change subject: ganeti: remove Ganglia
..

ganeti: remove Ganglia

Bug: T177225
Change-Id: I01711b01485452ce871d9820fe67b3bae56dca26
---
M hieradata/role/common/ganeti.yaml
1 file changed, 1 insertion(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/operations/puppet 
refs/changes/83/393683/1

diff --git a/hieradata/role/common/ganeti.yaml 
b/hieradata/role/common/ganeti.yaml
index b98d368..955dcc1 100644
--- a/hieradata/role/common/ganeti.yaml
+++ b/hieradata/role/common/ganeti.yaml
@@ -1,5 +1,6 @@
 profile::base::ssh_server_settings:
   authorized_keys_file: /etc/ssh/userkeys/%u /etc/ssh/userkeys/%u.d/cumin 
/etc/ssh/userkeys/%u.d/ganeti
+standard::has_ganglia: false
 ganeti::ganeti01.svc.codfw.wmnet::nodes:
   - ganeti2001.codfw.wmnet
   - ganeti2002.codfw.wmnet

-- 
To view, visit https://gerrit.wikimedia.org/r/393683
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I01711b01485452ce871d9820fe67b3bae56dca26
Gerrit-PatchSet: 1
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Dzahn 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] wikimedia...dash[master]: Configurable target per campaign

[jenkins-bot (Code Review)]

jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/393681 )

Change subject: Configurable target per campaign
..


Configurable target per campaign

Change-Id: I88f005eec9aa0a324270149130c73459f7a9d24c
---
M src/app/campaign.js
M src/components/widgets/totals-earned-chart/totals-earned-chart.js
2 files changed, 5 insertions(+), 2 deletions(-)

Approvals:
  XenoRyet: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/src/app/campaign.js b/src/app/campaign.js
index cd350cd..5f3f68e 100644
--- a/src/app/campaign.js
+++ b/src/app/campaign.js
@@ -12,6 +12,7 @@
this.endDate = new Date( params.endDate ||
Date.UTC( currentYear + 1, 0, 1 ) );
this.name = params.name || currentYear.toString();
+   this.target = params.target || 2500;
}
 
Campaign.prototype.getDayOfYearOffset = function () {
diff --git a/src/components/widgets/totals-earned-chart/totals-earned-chart.js 
b/src/components/widgets/totals-earned-chart/totals-earned-chart.js
index c2c2277..8a12dbf 100644
--- a/src/components/widgets/totals-earned-chart/totals-earned-chart.js
+++ b/src/components/widgets/totals-earned-chart/totals-earned-chart.js
@@ -35,14 +35,14 @@
self.hourlyChart = ko.observable( false );
self.dailyChart = ko.observable( false );
 
-   self.goal = params.sharedContext.goal = ko.observable( 
self.config.goal || 2500 );
self.majorDonationCutoff = ko.observable( 
self.config.majorDonationCutoff || 1000 ).extend( { throttle: 500 } );
 
self.campaigns = [
new Campaign( {
name: '2017',
startDate: Date.UTC( 2017, 9, 2 ),
-   endDate: Date.UTC( 2018, 0, 1 )
+   endDate: Date.UTC( 2018, 0, 1 ),
+   target: 5500
} ),
new Campaign( {
name: '2016',
@@ -76,6 +76,7 @@
} )
];
self.campaign = ko.observable( self.campaigns[ 0 ] );
+   self.goal = params.sharedContext.goal = ko.observable( 
self.config.goal || self.campaign().target );
 
self.isCurrentYear = ko.computed( function () {
return self.campaign() === self.campaigns[ 0 ];
@@ -94,6 +95,7 @@
} ) );
 
self.disposables.push( self.campaign.subscribe( function () {
+   self.goal( self.campaign().target );
self.logStateChange();
self.reloadData();
} ) );

-- 
To view, visit https://gerrit.wikimedia.org/r/393681
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I88f005eec9aa0a324270149130c73459f7a9d24c
Gerrit-PatchSet: 2
Gerrit-Project: wikimedia/fundraising/dash
Gerrit-Branch: master
Gerrit-Owner: Ejegg 
Gerrit-Reviewer: XenoRyet 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] operations/puppet[production]: labtest/labvirt/labs*: remove Ganglia

[Dzahn (Code Review)]

Dzahn has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/393682 )

Change subject: labtest/labvirt/labs*: remove Ganglia
..


labtest/labvirt/labs*: remove Ganglia

Bug: T177225
Change-Id: I9955d7fa1afdcd948333bfd42440df361147b30e
---
M hieradata/regex.yaml
1 file changed, 3 insertions(+), 0 deletions(-)

Approvals:
  jenkins-bot: Verified
  Dzahn: Looks good to me, approved



diff --git a/hieradata/regex.yaml b/hieradata/regex.yaml
index 0b355c6..d108150 100644
--- a/hieradata/regex.yaml
+++ b/hieradata/regex.yaml
@@ -107,14 +107,17 @@
 labvirt:
   __regex: !ruby/regexp /^labvirt10[0-9][0-9]\.eqiad\.wmnet$/
   cluster: labvirt
+  standard::has_ganglia: false
 
 labstore:
   __regex: !ruby/regexp /^labstore.*\.wmnet$/
   cluster: labsnfs
+  standard::has_ganglia: false
 
 labs:
   __regex: !ruby/regexp 
/^lab((net|nodepool|mon)100[1-9]\.eqiad\.wmnet|(services|control)100[1-9]\.wikimedia\.org)$/
   cluster: labs
+  standard::has_ganglia: false
 
 swift_be_codfw_dell:
   __regex: !ruby/regexp /^ms-be201[3-5]\.codfw\.wmnet$/

-- 
To view, visit https://gerrit.wikimedia.org/r/393682
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I9955d7fa1afdcd948333bfd42440df361147b30e
Gerrit-PatchSet: 2
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Dzahn 
Gerrit-Reviewer: Dzahn 
Gerrit-Reviewer: Giuseppe Lavagetto 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] wikimedia...dash[master]: Change individual amount cutoff to $5000

[jenkins-bot (Code Review)]

jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/391884 )

Change subject: Change individual amount cutoff to $5000
..


Change individual amount cutoff to $5000

Change-Id: Id305d616aff081a73864a4bd876f092cb28d548d
---
M widgets/big-english.js
M widgets/top10.js
2 files changed, 3 insertions(+), 3 deletions(-)

Approvals:
  XenoRyet: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/widgets/big-english.js b/widgets/big-english.js
index 97d5119..32eaa22 100644
--- a/widgets/big-english.js
+++ b/widgets/big-english.js
@@ -12,7 +12,7 @@
left: {
type: 'eq',
left: { type: 'property', name: 'Year' },
-   right: { type: 'literal', value: '2015' }
+   right: { type: 'literal', value: '2017' }
},
right: {
type: 'and',
@@ -24,7 +24,7 @@
right: {
type: 'lt',
left: { type: 'property', name: 'Amount' },
-   right: { type: 'literal', value: '1000' }
+   right: { type: 'literal', value: '5000' }
}
}
}
diff --git a/widgets/top10.js b/widgets/top10.js
index ae8efb5..4bef824 100644
--- a/widgets/top10.js
+++ b/widgets/top10.js
@@ -25,6 +25,6 @@
defaultFilter: {
type: 'lt',
left: { type: 'property', name: 'Amount' },
-   right: { type: 'literal', value: '1000' }
+   right: { type: 'literal', value: '5000' }
}
 };

-- 
To view, visit https://gerrit.wikimedia.org/r/391884
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Id305d616aff081a73864a4bd876f092cb28d548d
Gerrit-PatchSet: 2
Gerrit-Project: wikimedia/fundraising/dash
Gerrit-Branch: master
Gerrit-Owner: Ejegg 
Gerrit-Reviewer: XenoRyet 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] wikimedia...dash[master]: Label dates better in Big English chart

[jenkins-bot (Code Review)]

jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/383708 )

Change subject: Label dates better in Big English chart
..


Label dates better in Big English chart

Now that it's not just one month

Change-Id: I4973b0a259e0cc0311ba41647f946b9b3162e7f2
---
M bower.json
M src/app/campaign.js
M src/components/widgets/totals-earned-chart/totals-earned-chart.js
3 files changed, 22 insertions(+), 5 deletions(-)

Approvals:
  Mepps: Looks good to me, but someone else must approve
  XenoRyet: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/bower.json b/bower.json
index 45e3044..5f4874b 100644
--- a/bower.json
+++ b/bower.json
@@ -33,7 +33,7 @@
"hasher": "1.2.0",
"knockout-projections": "1.1.0-pre",
"knockout": "3.2.0",
-   "moment": "2.7.0",
+   "moment": "2.19.1",
"raphael": "2.1.2",
"requirejs": "2.1.15",
"lato": "0.2.1",
diff --git a/src/app/campaign.js b/src/app/campaign.js
index 8ebe71e..cd350cd 100644
--- a/src/app/campaign.js
+++ b/src/app/campaign.js
@@ -46,5 +46,13 @@
return msToDays( diff );
};
 
+   Campaign.prototype.getStartDate = function () {
+   return this.startDate;
+   };
+
+   Campaign.prototype.getEndDate = function () {
+   return this.endDate;
+   };
+
return Campaign;
 } );
diff --git a/src/components/widgets/totals-earned-chart/totals-earned-chart.js 
b/src/components/widgets/totals-earned-chart/totals-earned-chart.js
index d9fc523..c2c2277 100644
--- a/src/components/widgets/totals-earned-chart/totals-earned-chart.js
+++ b/src/components/widgets/totals-earned-chart/totals-earned-chart.js
@@ -21,7 +21,9 @@
function TotalsEarnedChartViewModel( params ) {
 
var self = this,
-   timeFormat = ',  Do , h:mm:ss a';
+   timeFormat = ',  Do , h:mm:ss a',
+   getDay,
+   localUtcOffset = moment().utcOffset();
 
WidgetBase.call( this, params );
 
@@ -234,6 +236,13 @@
self.showChart( 'daily' );
};
 
+   getDay = function ( dayNum ) {
+   var result = moment( self.campaign().getStartDate() );
+   result.subtract( localUtcOffset, 'm' );
+   result.add( dayNum, 'd' );
+   return result.format( 'MMM D' );
+   };
+
self.makeHourlyChart = function ( d, i ) {
var hourlyData = params.sharedContext.dayObj[ d.x + 1 ],
hourlyCountArray = [ 'Hourly Count' ],
@@ -274,7 +283,7 @@
axis: {
x: {
label: {
-   text: 'Day ' + ( d.x + 
1 ),
+   text: getDay( d.x ),
position: 'outer-left'
},
tick: {
@@ -347,7 +356,7 @@
axis: {
x: {
tick: {
-   format: function ( x ) 
{ return 'Day ' + ( x + 1 ); }
+   format: function ( x ) 
{ return getDay( x ); }
}
},
y: {
@@ -364,7 +373,7 @@
},
tooltip: {
format: {
-   title: function ( d ) { return 
'Day ' + ( d + 1 ); },
+   title: function ( d ) { return 
getDay( d ); },
value: function ( value, ratio, 
id ) {
var display;
if ( id === 'Daily 
Total' ) {

-- 
To view, visit https://gerrit.wikimedia.org/r/383708
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I4973b0a259e0cc0311ba41647f946b9b3162e7f2
Gerrit-PatchSet: 4
Gerrit-Project: wikimedia/fundraising/dash
Gerrit-Branch: master
Gerrit-Owner: Ejegg 
Gerrit-Reviewer: AndyRussG 
Gerrit-Reviewer: Cdentinger 
Gerrit-Reviewer: Eileen 
Gerrit-Reviewer: Katie 

[MediaWiki-commits] [Gerrit] operations/puppet[production]: labtest/labvirt/labs*: remove Ganglia

[Dzahn (Code Review)]

Dzahn has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/393682 )

Change subject: labtest/labvirt/labs*: remove Ganglia
..

labtest/labvirt/labs*: remove Ganglia

Bug: T177225
Change-Id: I9955d7fa1afdcd948333bfd42440df361147b30e
---
M hieradata/regex.yaml
1 file changed, 3 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/operations/puppet 
refs/changes/82/393682/1

diff --git a/hieradata/regex.yaml b/hieradata/regex.yaml
index 0b355c6..d108150 100644
--- a/hieradata/regex.yaml
+++ b/hieradata/regex.yaml
@@ -107,14 +107,17 @@
 labvirt:
   __regex: !ruby/regexp /^labvirt10[0-9][0-9]\.eqiad\.wmnet$/
   cluster: labvirt
+  standard::has_ganglia: false
 
 labstore:
   __regex: !ruby/regexp /^labstore.*\.wmnet$/
   cluster: labsnfs
+  standard::has_ganglia: false
 
 labs:
   __regex: !ruby/regexp 
/^lab((net|nodepool|mon)100[1-9]\.eqiad\.wmnet|(services|control)100[1-9]\.wikimedia\.org)$/
   cluster: labs
+  standard::has_ganglia: false
 
 swift_be_codfw_dell:
   __regex: !ruby/regexp /^ms-be201[3-5]\.codfw\.wmnet$/

-- 
To view, visit https://gerrit.wikimedia.org/r/393682
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I9955d7fa1afdcd948333bfd42440df361147b30e
Gerrit-PatchSet: 1
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Dzahn 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] apps...wikipedia[master]: New: onboarding card for customizing the Feed.

[jenkins-bot (Code Review)]

jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/393609 )

Change subject: New: onboarding card for customizing the Feed.
..


New: onboarding card for customizing the Feed.

Bug: T181147
Change-Id: I2a72ae93c618452317250c91927313d7b8cf9a9b
---
M app/src/main/java/org/wikipedia/feed/FeedFragment.java
M app/src/main/java/org/wikipedia/feed/announcement/Announcement.java
M app/src/main/java/org/wikipedia/feed/announcement/AnnouncementCard.java
M app/src/main/java/org/wikipedia/feed/announcement/AnnouncementCardView.java
M app/src/main/java/org/wikipedia/feed/model/CardType.java
A app/src/main/java/org/wikipedia/feed/onboarding/CustomizeOnboardingCard.java
M app/src/main/java/org/wikipedia/feed/onboarding/OnboardingClient.java
M app/src/main/java/org/wikipedia/settings/Prefs.java
M app/src/main/java/org/wikipedia/util/UriUtil.java
M app/src/main/res/values-qq/strings.xml
M app/src/main/res/values/preference_keys.xml
M app/src/main/res/values/strings.xml
12 files changed, 81 insertions(+), 5 deletions(-)

Approvals:
  jenkins-bot: Verified
  Cooltey: Looks good to me, approved



diff --git a/app/src/main/java/org/wikipedia/feed/FeedFragment.java 
b/app/src/main/java/org/wikipedia/feed/FeedFragment.java
index bcd8ea4..f1c939b 100644
--- a/app/src/main/java/org/wikipedia/feed/FeedFragment.java
+++ b/app/src/main/java/org/wikipedia/feed/FeedFragment.java
@@ -443,6 +443,8 @@
 } else if (uri.toString().equals(UriUtil.LOCAL_URL_SETTINGS)) {
 
startActivityForResult(SettingsActivity.newIntent(getContext()),
 SettingsActivity.ACTIVITY_REQUEST_SHOW_SETTINGS);
+} else if 
(uri.toString().equals(UriUtil.LOCAL_URL_CUSTOMIZE_FEED)) {
+showConfigureActivity();
 } else {
 UriUtil.handleExternalLink(getContext(), uri);
 }
@@ -526,6 +528,11 @@
 snackbar.show();
 }
 
+private void showConfigureActivity() {
+startActivityForResult(ConfigureActivity.newIntent(getActivity()),
+Constants.ACTIVITY_REQUEST_FEED_CONFIGURE);
+}
+
 private void showOverflowMenu(@NonNull View anchor) {
 ExploreOverflowView overflowView = new 
ExploreOverflowView(getContext());
 overflowView.show(anchor, overflowCallback);
@@ -555,8 +562,7 @@
 
 @Override
 public void configureCardsClick() {
-startActivityForResult(ConfigureActivity.newIntent(getActivity()),
-Constants.ACTIVITY_REQUEST_FEED_CONFIGURE);
+showConfigureActivity();
 }
 
 @Override
diff --git 
a/app/src/main/java/org/wikipedia/feed/announcement/Announcement.java 
b/app/src/main/java/org/wikipedia/feed/announcement/Announcement.java
index 0f132de..5bd15fc 100644
--- a/app/src/main/java/org/wikipedia/feed/announcement/Announcement.java
+++ b/app/src/main/java/org/wikipedia/feed/announcement/Announcement.java
@@ -32,14 +32,17 @@
 
 @SuppressWarnings("unused,NullableProblems") @Required @NonNull private 
String text;
 @SuppressWarnings("unused") @Nullable private Action action;
+@SuppressWarnings("unused") @Nullable private String negativeText;
 
 public Announcement() { }
 
-public Announcement(@NonNull String id, @NonNull String text, @NonNull 
String imageUrl, @NonNull Action action) {
+public Announcement(@NonNull String id, @NonNull String text, @NonNull 
String imageUrl,
+@NonNull Action action, @NonNull String negativeText) {
 this.id = id;
 this.text = text;
 this.imageUrl = imageUrl;
 this.action = action;
+this.negativeText = negativeText;
 }
 
 @NonNull String id() {
@@ -106,6 +109,10 @@
 return defaultString(imageUrl);
 }
 
+@Nullable String negativeText() {
+return negativeText;
+}
+
 public static class Action {
 @SuppressWarnings("unused,NullableProblems") @Required @NonNull 
private String title;
 @SuppressWarnings("unused,NullableProblems") @Required @NonNull 
private String url;
diff --git 
a/app/src/main/java/org/wikipedia/feed/announcement/AnnouncementCard.java 
b/app/src/main/java/org/wikipedia/feed/announcement/AnnouncementCard.java
index 4c22a43..2b7d2d3 100644
--- a/app/src/main/java/org/wikipedia/feed/announcement/AnnouncementCard.java
+++ b/app/src/main/java/org/wikipedia/feed/announcement/AnnouncementCard.java
@@ -34,6 +34,10 @@
 return Uri.parse(announcement.actionUrl());
 }
 
+@Nullable public String negativeText() {
+return announcement.negativeText();
+}
+
 public boolean hasFooterCaption() {
 return announcement.hasFooterCaption();
 }
diff --git 
a/app/src/main/java/org/wikipedia/feed/announcement/AnnouncementCardView.java 
b/app/src/main/java/org/wikipedia/feed/announcement/AnnouncementCardView.java
index 

[MediaWiki-commits] [Gerrit] apps...wikipedia[master]: Update design of feed content customization.

[jenkins-bot (Code Review)]

jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/393601 )

Change subject: Update design of feed content customization.
..


Update design of feed content customization.

Bug: T141397
Change-Id: I11b1646ec78750dd9757a9983a16f4ba287c1e27
---
M app/src/main/java/org/wikipedia/feed/FeedContentType.java
M app/src/main/java/org/wikipedia/feed/configure/ConfigureFragment.java
M app/src/main/java/org/wikipedia/feed/configure/ConfigureItemView.java
R app/src/main/res/drawable/ic_reorder_black_24dp.xml
M app/src/main/res/layout/fragment_feed_configure.xml
M app/src/main/res/layout/item_feed_content_type.xml
M app/src/main/res/layout/view_explore_overflow.xml
M app/src/main/res/menu/menu_feed_configure.xml
M app/src/main/res/values-qq/strings.xml
M app/src/main/res/values/strings.xml
10 files changed, 124 insertions(+), 57 deletions(-)

Approvals:
  jenkins-bot: Verified
  Cooltey: Looks good to me, approved



diff --git a/app/src/main/java/org/wikipedia/feed/FeedContentType.java 
b/app/src/main/java/org/wikipedia/feed/FeedContentType.java
index 0731980..afc94cf 100644
--- a/app/src/main/java/org/wikipedia/feed/FeedContentType.java
+++ b/app/src/main/java/org/wikipedia/feed/FeedContentType.java
@@ -22,63 +22,63 @@
 import static org.wikipedia.util.ReleaseUtil.isPreBetaRelease;
 
 public enum FeedContentType implements EnumCode {
-NEWS(0, R.string.view_card_news_title) {
+NEWS(0, R.string.view_card_news_title, R.string.feed_item_type_news) {
 @Nullable
 @Override
 public FeedClient newClient(AggregatedFeedContentClient 
aggregatedClient, int age, boolean isOnline) {
 return isEnabled() && age == 0 && isOnline ? new 
AggregatedFeedContentClient.InTheNews(aggregatedClient) : null;
 }
 },
-FEATURED_ARTICLE(1, R.string.view_featured_article_card_title) {
+FEATURED_ARTICLE(1, R.string.view_featured_article_card_title, 
R.string.feed_item_type_featured_article) {
 @Nullable
 @Override
 public FeedClient newClient(AggregatedFeedContentClient 
aggregatedClient, int age, boolean isOnline) {
 return isEnabled() && isOnline ? new 
AggregatedFeedContentClient.FeaturedArticle(aggregatedClient) : null;
 }
 },
-TRENDING_ARTICLES(2, R.string.most_read_list_card_title) {
+TRENDING_ARTICLES(2, R.string.most_read_list_card_title, 
R.string.feed_item_type_trending) {
 @Nullable
 @Override
 public FeedClient newClient(AggregatedFeedContentClient 
aggregatedClient, int age, boolean isOnline) {
 return isEnabled() && isOnline ? new 
AggregatedFeedContentClient.TrendingArticles(aggregatedClient) : null;
 }
 },
-FEATURED_IMAGE(3, R.string.view_featured_image_card_title) {
+FEATURED_IMAGE(3, R.string.view_featured_image_card_title, 
R.string.feed_item_type_featured_image) {
 @Nullable
 @Override
 public FeedClient newClient(AggregatedFeedContentClient 
aggregatedClient, int age, boolean isOnline) {
 return isEnabled() && isOnline ? new 
AggregatedFeedContentClient.FeaturedImage(aggregatedClient) : null;
 }
 },
-ON_THIS_DAY(4, R.string.on_this_day_card_title) {
+ON_THIS_DAY(4, R.string.on_this_day_card_title, 
R.string.feed_item_type_on_this_day) {
 @Nullable
 @Override
 public FeedClient newClient(AggregatedFeedContentClient 
aggregatedClient, int age, boolean isOnline) {
 return isEnabled() && isOnline && isPreBetaRelease() ? new 
OnThisDayClient() : null;
 }
 },
-CONTINUE_READING(5, R.string.view_continue_reading_card_title) {
+CONTINUE_READING(5, R.string.view_continue_reading_card_title, 
R.string.feed_item_type_continue_reading) {
 @Nullable
 @Override
 public FeedClient newClient(AggregatedFeedContentClient 
aggregatedClient, int age, boolean isOnline) {
 return isEnabled() ? new ContinueReadingClient() : null;
 }
 },
-BECAUSE_YOU_READ(6, R.string.view_because_you_read_card_title) {
+BECAUSE_YOU_READ(6, R.string.view_because_you_read_card_title, 
R.string.feed_item_type_because_you_read) {
 @Nullable
 @Override
 public FeedClient newClient(AggregatedFeedContentClient 
aggregatedClient, int age, boolean isOnline) {
 return isEnabled() && isOnline ? new BecauseYouReadClient() : null;
 }
 },
-MAIN_PAGE(7, R.string.view_main_page_card_title) {
+MAIN_PAGE(7, R.string.view_main_page_card_title, 
R.string.feed_item_type_main_page) {
 @Nullable
 @Override
 public FeedClient newClient(AggregatedFeedContentClient 
aggregatedClient, int age, boolean isOnline) {
 return isEnabled() && age == 0 ? new MainPageClient() : null;
 }
 },
-RANDOM(8, R.string.view_random_card_title) {
+RANDOM(8, 

[MediaWiki-commits] [Gerrit] wikimedia...dash[master]: Configurable target per campaign

[Ejegg (Code Review)]

Ejegg has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/393681 )

Change subject: Configurable target per campaign
..

Configurable target per campaign

Change-Id: I88f005eec9aa0a324270149130c73459f7a9d24c
---
M src/app/campaign.js
M src/components/widgets/totals-earned-chart/totals-earned-chart.js
2 files changed, 5 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/wikimedia/fundraising/dash 
refs/changes/81/393681/1

diff --git a/src/app/campaign.js b/src/app/campaign.js
index cd350cd..5f3f68e 100644
--- a/src/app/campaign.js
+++ b/src/app/campaign.js
@@ -12,6 +12,7 @@
this.endDate = new Date( params.endDate ||
Date.UTC( currentYear + 1, 0, 1 ) );
this.name = params.name || currentYear.toString();
+   this.target = params.target || 2500;
}
 
Campaign.prototype.getDayOfYearOffset = function () {
diff --git a/src/components/widgets/totals-earned-chart/totals-earned-chart.js 
b/src/components/widgets/totals-earned-chart/totals-earned-chart.js
index c2c2277..8a12dbf 100644
--- a/src/components/widgets/totals-earned-chart/totals-earned-chart.js
+++ b/src/components/widgets/totals-earned-chart/totals-earned-chart.js
@@ -35,14 +35,14 @@
self.hourlyChart = ko.observable( false );
self.dailyChart = ko.observable( false );
 
-   self.goal = params.sharedContext.goal = ko.observable( 
self.config.goal || 2500 );
self.majorDonationCutoff = ko.observable( 
self.config.majorDonationCutoff || 1000 ).extend( { throttle: 500 } );
 
self.campaigns = [
new Campaign( {
name: '2017',
startDate: Date.UTC( 2017, 9, 2 ),
-   endDate: Date.UTC( 2018, 0, 1 )
+   endDate: Date.UTC( 2018, 0, 1 ),
+   target: 5500
} ),
new Campaign( {
name: '2016',
@@ -76,6 +76,7 @@
} )
];
self.campaign = ko.observable( self.campaigns[ 0 ] );
+   self.goal = params.sharedContext.goal = ko.observable( 
self.config.goal || self.campaign().target );
 
self.isCurrentYear = ko.computed( function () {
return self.campaign() === self.campaigns[ 0 ];
@@ -94,6 +95,7 @@
} ) );
 
self.disposables.push( self.campaign.subscribe( function () {
+   self.goal( self.campaign().target );
self.logStateChange();
self.reloadData();
} ) );

-- 
To view, visit https://gerrit.wikimedia.org/r/393681
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I88f005eec9aa0a324270149130c73459f7a9d24c
Gerrit-PatchSet: 1
Gerrit-Project: wikimedia/fundraising/dash
Gerrit-Branch: master
Gerrit-Owner: Ejegg 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] operations/puppet[production]: public_dumps: Set up NFS on the dumps servers

[Madhuvishy (Code Review)]

Madhuvishy has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/393680 )

Change subject: public_dumps: Set up NFS on the dumps servers
..


public_dumps: Set up NFS on the dumps servers

Bug: T181431
Change-Id: I4cb40fd76c83582c0d2e946707891278d3e1c65e
---
M modules/profile/manifests/dumps/public_server.pp
M modules/role/manifests/dumps/public/server.pp
2 files changed, 2 insertions(+), 1 deletion(-)

Approvals:
  Madhuvishy: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/modules/profile/manifests/dumps/public_server.pp 
b/modules/profile/manifests/dumps/public_server.pp
index 25defd1..f841c39 100644
--- a/modules/profile/manifests/dumps/public_server.pp
+++ b/modules/profile/manifests/dumps/public_server.pp
@@ -5,5 +5,5 @@
 class profile::dumps::public_server {
 
 class {'::public_dumps::server':}
-
+class {'::labstore':}
 }
diff --git a/modules/role/manifests/dumps/public/server.pp 
b/modules/role/manifests/dumps/public/server.pp
index 4396293..d1a46b9 100644
--- a/modules/role/manifests/dumps/public/server.pp
+++ b/modules/role/manifests/dumps/public/server.pp
@@ -3,6 +3,7 @@
 
 include ::standard
 include ::profile::base::firewall
+include ::profile::wmcs::nfs::ferm
 include ::profile::dumps::public_server
 include ::profile::dumps::web::rsync_server
 include ::profile::dumps::rsyncer

-- 
To view, visit https://gerrit.wikimedia.org/r/393680
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I4cb40fd76c83582c0d2e946707891278d3e1c65e
Gerrit-PatchSet: 1
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Madhuvishy 
Gerrit-Reviewer: Madhuvishy 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] operations/puppet[production]: public_dumps: Set up NFS on the dumps servers

[Madhuvishy (Code Review)]

Madhuvishy has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/393680 )

Change subject: public_dumps: Set up NFS on the dumps servers
..

public_dumps: Set up NFS on the dumps servers

Bug: T181431
Change-Id: I4cb40fd76c83582c0d2e946707891278d3e1c65e
---
M modules/profile/manifests/dumps/public_server.pp
M modules/role/manifests/dumps/public/server.pp
2 files changed, 2 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/operations/puppet 
refs/changes/80/393680/1

diff --git a/modules/profile/manifests/dumps/public_server.pp 
b/modules/profile/manifests/dumps/public_server.pp
index 25defd1..f841c39 100644
--- a/modules/profile/manifests/dumps/public_server.pp
+++ b/modules/profile/manifests/dumps/public_server.pp
@@ -5,5 +5,5 @@
 class profile::dumps::public_server {
 
 class {'::public_dumps::server':}
-
+class {'::labstore':}
 }
diff --git a/modules/role/manifests/dumps/public/server.pp 
b/modules/role/manifests/dumps/public/server.pp
index 4396293..d1a46b9 100644
--- a/modules/role/manifests/dumps/public/server.pp
+++ b/modules/role/manifests/dumps/public/server.pp
@@ -3,6 +3,7 @@
 
 include ::standard
 include ::profile::base::firewall
+include ::profile::wmcs::nfs::ferm
 include ::profile::dumps::public_server
 include ::profile::dumps::web::rsync_server
 include ::profile::dumps::rsyncer

-- 
To view, visit https://gerrit.wikimedia.org/r/393680
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I4cb40fd76c83582c0d2e946707891278d3e1c65e
Gerrit-PatchSet: 1
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Madhuvishy 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] operations/mediawiki-config[master]: Revert "Comply wikidata with new ores thresholds"

[Ladsgroup (Code Review)]

Hello Urbanecm, jenkins-bot, Zoranzoki21,

I'd like you to do a code review.  Please visit

https://gerrit.wikimedia.org/r/393679

to review the following change.


Change subject: Revert "Comply wikidata with new ores thresholds"
..

Revert "Comply wikidata with new ores thresholds"

This reverts commit 6258ca2a16138655ddcf00dc6b46242849463a5a.
Bug: T180450

Change-Id: I50896030c91b6bb464db0298ba52b2492711f202
---
M wmf-config/InitialiseSettings.php
1 file changed, 2 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/operations/mediawiki-config 
refs/changes/79/393679/1

diff --git a/wmf-config/InitialiseSettings.php 
b/wmf-config/InitialiseSettings.php
index b74abbc..eab50bf 100644
--- a/wmf-config/InitialiseSettings.php
+++ b/wmf-config/InitialiseSettings.php
@@ -19050,8 +19050,8 @@
'damaging' => [
// likelygood uses default
'maybebad' => false,
-   'likelybad' => [ 'min' => 
'recall_at_precision(min_precision=0.08)', 'max' => 1 ],
-   'verylikelybad' => [ 'min' => 0, 'max' => 
'recall_at_precision(min_precision=0.12)' ],
+   'likelybad' => [ 'min' => 
'recall_at_precision(min_precision=0.75)', 'max' => 1 ],
+   // verylikelybad uses defaults
],
'goodfaith' => [
// likelygood uses default

-- 
To view, visit https://gerrit.wikimedia.org/r/393679
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I50896030c91b6bb464db0298ba52b2492711f202
Gerrit-PatchSet: 1
Gerrit-Project: operations/mediawiki-config
Gerrit-Branch: master
Gerrit-Owner: Ladsgroup 
Gerrit-Reviewer: Urbanecm 
Gerrit-Reviewer: Zoranzoki21 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] operations/puppet[production]: profile::puppetmaster::common: Always enable environments

[Andrew Bogott (Code Review)]

Andrew Bogott has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/393677 )

Change subject: profile::puppetmaster::common: Always enable environments
..

profile::puppetmaster::common: Always enable environments

This was switchable via hiera but is switched on in all production
cases.  It was switched off on labpuppetmaster* which as far
as I can tell was a mistake.

Since having this be configurable just makes it easy to overlook,
let's just turn it on.

Change-Id: Ic96b4f33265fa3653aca4c3c0ee7faa381ab513e
---
M hieradata/role/common/puppetmaster/backend.yaml
M hieradata/role/common/puppetmaster/frontend.yaml
M modules/profile/manifests/puppetmaster/common.pp
3 files changed, 3 insertions(+), 12 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/operations/puppet 
refs/changes/77/393677/1

diff --git a/hieradata/role/common/puppetmaster/backend.yaml 
b/hieradata/role/common/puppetmaster/backend.yaml
index eee065a..eb833db 100644
--- a/hieradata/role/common/puppetmaster/backend.yaml
+++ b/hieradata/role/common/puppetmaster/backend.yaml
@@ -7,5 +7,4 @@
   - esams.wmnet
   - ulsfo.wmnet
 cluster: puppet
-profile::puppetmaster::common::directory_environments: true
 profile::puppetmaster::common::storeconfigs: puppetdb
diff --git a/hieradata/role/common/puppetmaster/frontend.yaml 
b/hieradata/role/common/puppetmaster/frontend.yaml
index a65135f..8438f89 100644
--- a/hieradata/role/common/puppetmaster/frontend.yaml
+++ b/hieradata/role/common/puppetmaster/frontend.yaml
@@ -15,5 +15,4 @@
 profile::conftool::master::sync_dir: "/etc/conftool/data"
 profile::discovery::path: "/srv/config-master/discovery"
 profile::discovery::watch_interval: 60
-profile::puppetmaster::common::directory_environments: true
 profile::puppetmaster::common::storeconfigs: puppetdb
diff --git a/modules/profile/manifests/puppetmaster/common.pp 
b/modules/profile/manifests/puppetmaster/common.pp
index d18ffe6..53ad831 100644
--- a/modules/profile/manifests/puppetmaster/common.pp
+++ b/modules/profile/manifests/puppetmaster/common.pp
@@ -3,24 +3,17 @@
 # $config:  Dict merged with front- or back- specifics and then passed
 #   to ::puppetmaster as $config
 #
-# $directory_environments: boolean, when True adds boilerplate environment 
config
-#
 # $storeconfigs: Accepts values of 'puppetdb', 'activerecord', and 'none'
 
 class profile::puppetmaster::common (
 $base_config,
-$directory_environments = 
hiera('profile::puppetmaster::common::directory_environments', false),
 $storeconfigs = hiera('profile::puppetmaster::common::storeconfigs', 
'activerecord'),
 ) {
 include passwords::puppet::database
 
-if $directory_environments {
-$env_config = {
-'environmentpath' => '$confdir/environments',
-'default_manifest' => '$confdir/manifests/site.pp'
-}
-} else {
-$env_config = {}
+$env_config = {
+'environmentpath' => '$confdir/environments',
+'default_manifest' => '$confdir/manifests/site.pp'
 }
 
 $activerecord_config =   {

-- 
To view, visit https://gerrit.wikimedia.org/r/393677
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic96b4f33265fa3653aca4c3c0ee7faa381ab513e
Gerrit-PatchSet: 1
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Andrew Bogott 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] operations/puppet[production]: puppetmaster::standalone: include environment env

[Andrew Bogott (Code Review)]

Andrew Bogott has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/393678 )

Change subject: puppetmaster::standalone: include environment env
..

puppetmaster::standalone: include environment env

We need this in order for the transition to puppet v4 to work
properly.

Change-Id: Iefcd2c3e7977400f08fb8caca49c788ab9ff397e
---
M modules/role/manifests/puppetmaster/standalone.pp
1 file changed, 2 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/operations/puppet 
refs/changes/78/393678/1

diff --git a/modules/role/manifests/puppetmaster/standalone.pp 
b/modules/role/manifests/puppetmaster/standalone.pp
index 2b89432..e113a47 100644
--- a/modules/role/manifests/puppetmaster/standalone.pp
+++ b/modules/role/manifests/puppetmaster/standalone.pp
@@ -61,6 +61,8 @@
 'external_nodes'=> '/usr/local/bin/puppet-enc',
 'thin_storeconfigs' => false,
 'autosign'  => $autosign,
+'environmentpath'   => '$confdir/environments',
+'default_manifest'  => '$confdir/manifests/site.pp'
 }
 
 class { '::puppetmaster':

-- 
To view, visit https://gerrit.wikimedia.org/r/393678
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Iefcd2c3e7977400f08fb8caca49c788ab9ff397e
Gerrit-PatchSet: 1
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Andrew Bogott 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] apps...wikipedia[master]: Fix navigation to certain links from Reference popups.

[jenkins-bot (Code Review)]

jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/393618 )

Change subject: Fix navigation to certain links from Reference popups.
..


Fix navigation to certain links from Reference popups.

Bug: T180823
Change-Id: I2e05da1099e4495ff4966bd8f4dd6c791f44aec3
---
M app/src/main/java/org/wikipedia/page/LinkHandler.java
1 file changed, 3 insertions(+), 2 deletions(-)

Approvals:
  jenkins-bot: Verified
  Cooltey: Looks good to me, approved



diff --git a/app/src/main/java/org/wikipedia/page/LinkHandler.java 
b/app/src/main/java/org/wikipedia/page/LinkHandler.java
index 68b5943..344edd3 100644
--- a/app/src/main/java/org/wikipedia/page/LinkHandler.java
+++ b/app/src/main/java/org/wikipedia/page/LinkHandler.java
@@ -87,13 +87,14 @@
 }
 PageTitle title = TextUtils.isEmpty(titleString)
 ? site.titleForInternalLink(uri.getPath())
-: new PageTitle(titleString, site);
+: PageTitle.withSeparateFragment(titleString, 
uri.getFragment(), site);
 onInternalLinkClicked(title);
 } else if (!TextUtils.isEmpty(titleString) && 
UriUtil.isValidOfflinePageLink(uri)) {
 WikiSite site = new WikiSite(uri);
 PageTitle title = PageTitle.withSeparateFragment(titleString, 
uri.getFragment(), site);
 onInternalLinkClicked(title);
-} else if (!TextUtils.isEmpty(uri.getFragment())) {
+} else if (!TextUtils.isEmpty(uri.getAuthority()) && 
WikiSite.supportedAuthority(uri.getAuthority())
+&& !TextUtils.isEmpty(uri.getFragment())) {
 onPageLinkClicked(uri.getFragment());
 } else {
 onExternalLinkClicked(uri);

-- 
To view, visit https://gerrit.wikimedia.org/r/393618
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I2e05da1099e4495ff4966bd8f4dd6c791f44aec3
Gerrit-PatchSet: 1
Gerrit-Project: apps/android/wikipedia
Gerrit-Branch: master
Gerrit-Owner: Dbrant 
Gerrit-Reviewer: Brion VIBBER 
Gerrit-Reviewer: Cooltey 
Gerrit-Reviewer: Sharvaniharan 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] operations/puppet[production]: remove Ganglia from cache::misc

[Dzahn (Code Review)]

Dzahn has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/393675 )

Change subject: remove Ganglia from cache::misc
..

remove Ganglia from cache::misc

Bug: T177225
Change-Id: I98ae2b0a66f82809f43ee5b500521e2b7df58f1a
---
M hieradata/role/common/cache/misc.yaml
1 file changed, 1 insertion(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/operations/puppet 
refs/changes/75/393675/1

diff --git a/hieradata/role/common/cache/misc.yaml 
b/hieradata/role/common/cache/misc.yaml
index 18d846b..6d4bbd0 100644
--- a/hieradata/role/common/cache/misc.yaml
+++ b/hieradata/role/common/cache/misc.yaml
@@ -2,6 +2,7 @@
 cache::cluster: misc
 cache::lua_support: true
 apt::use_experimental: true
+standard::has_ganglia: false
 profile::cache::base::varnish_version: 5
 prometheus::node_exporter::collectors_extra:
   - qdisc

-- 
To view, visit https://gerrit.wikimedia.org/r/393675
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I98ae2b0a66f82809f43ee5b500521e2b7df58f1a
Gerrit-PatchSet: 1
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Dzahn 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] operations/puppet[production]: remove ganglia from cache::text, cache::upload

[Dzahn (Code Review)]

Dzahn has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/393676 )

Change subject: remove ganglia from cache::text,cache::upload
..

remove ganglia from cache::text,cache::upload

Bug: T177225
Change-Id: I349c34cb52c12d13966fd3935174b9211c1d4860
---
M hieradata/role/common/cache/text.yaml
M hieradata/role/common/cache/upload.yaml
2 files changed, 2 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/operations/puppet 
refs/changes/76/393676/1

diff --git a/hieradata/role/common/cache/text.yaml 
b/hieradata/role/common/cache/text.yaml
index 3f1330f..6c0b1d4 100644
--- a/hieradata/role/common/cache/text.yaml
+++ b/hieradata/role/common/cache/text.yaml
@@ -6,6 +6,7 @@
 prometheus::node_exporter::collectors_extra:
   - qdisc
   - meminfo_numa
+standard::has_ganglia: false
 # The contents of this hash control our DC->DC routing for varnish backend
 # daemons.  There should be a key for every cache datacenter.  The values must
 # be a core datacenter (eqiad or codfw), or at least must lead indirectly to
diff --git a/hieradata/role/common/cache/upload.yaml 
b/hieradata/role/common/cache/upload.yaml
index 322b5c1..39e7844 100644
--- a/hieradata/role/common/cache/upload.yaml
+++ b/hieradata/role/common/cache/upload.yaml
@@ -6,6 +6,7 @@
 prometheus::node_exporter::collectors_extra:
   - qdisc
   - meminfo_numa
+standard::has_ganglia: false
 cache::tune_for_media: true
 # The contents of this hash control our DC->DC routing for varnish backend
 # daemons.  There should be a key for every cache datacenter.  The values must

-- 
To view, visit https://gerrit.wikimedia.org/r/393676
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I349c34cb52c12d13966fd3935174b9211c1d4860
Gerrit-PatchSet: 1
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Dzahn 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] operations/puppet[production]: remove Ganglia from cache::canary (cp1008)

[Dzahn (Code Review)]

Dzahn has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/393674 )

Change subject: remove Ganglia from cache::canary (cp1008)
..

remove Ganglia from cache::canary (cp1008)

caching servers are still providing Ganglia
data and showing up in Dashboards.

As part of general decom of Ganglia
remove Ganglia package and config with the decom class.

Starting with cache::canary role (cp1008) which is its
own cluster in Ganglia dashboards.

Bug: T177225

Change-Id: Ie7c90aa57bf8580d186b417b2e2b1f52647b2c95
---
M hieradata/role/common/cache/canary.yaml
1 file changed, 1 insertion(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/operations/puppet 
refs/changes/74/393674/1

diff --git a/hieradata/role/common/cache/canary.yaml 
b/hieradata/role/common/cache/canary.yaml
index ca89252..8caf6a8 100644
--- a/hieradata/role/common/cache/canary.yaml
+++ b/hieradata/role/common/cache/canary.yaml
@@ -4,6 +4,7 @@
 cache::lua_support: true
 cluster: cache_canary
 cache::cluster: canary
+standard::has_ganglia: false
 admin::groups:
   - perf-roots
 prometheus::node_exporter::collectors_extra:

-- 
To view, visit https://gerrit.wikimedia.org/r/393674
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie7c90aa57bf8580d186b417b2e2b1f52647b2c95
Gerrit-PatchSet: 1
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Dzahn 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...CentralAuth[master]: Various fixes to WikiSet caching logic

[Aaron Schulz (Code Review)]

Aaron Schulz has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/393673 )

Change subject: Various fixes to WikiSet caching logic
..

Various fixes to WikiSet caching logic

* Make the by-name caching actually work.
* Use the proper getGlobalKey() method. This makes the by-id lookup keys have a 
namespace.
* Avoid duplicating the name/id key generation logic.
* Use getWithSetCallback() instead of get()/set().
* Remove unused $useCache parameter.

Change-Id: Iaaed90d36bc992af43e3739d33e86b723bdcefee
---
M includes/WikiSet.php
1 file changed, 104 insertions(+), 68 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/CentralAuth 
refs/changes/73/393673/1

diff --git a/includes/WikiSet.php b/includes/WikiSet.php
index ad2fccd..48ec121 100644
--- a/includes/WikiSet.php
+++ b/includes/WikiSet.php
@@ -1,5 +1,8 @@
 mName = $name;
$this->mType = $type;
$this->mWikis = $wikis;
-   }
-
-   /**
-* @param string $k
-* @return string
-*/
-   protected static function memcKey( $k ) {
-   return "wikiset:{$k}";
}
 
/**
@@ -93,7 +84,6 @@
 
/**
 * @param string $t
-* @return bool
 */
public function setType( $t ) {
if ( !in_array( $t, [ self::OPTIN, self::OPTOUT ] ) ) {
@@ -130,64 +120,103 @@
 
/**
 * @param string $name
-* @param bool $useCache
 * @return null|WikiSet
 */
-   public static function newFromName( $name, $useCache = true ) {
-   if ( $useCache ) {
-   $cache = ObjectCache::getMainWANInstance();
-   $data = $cache->get( self::memcKey( "name:" . md5( 
$name ) ) );
-   if ( $data ) {
-   if ( $data['mVersion'] == self::VERSION ) {
-   $ws = new WikiSet( null, null );
-   foreach ( $data as $key => $val ) {
-   $ws->$key = $val;
-   }
-   return $ws;
+   public static function newFromName( $name ) {
+   $cache = 
MediaWikiServices::getInstance()->getMainWANObjectCache();
+
+   $data = $cache->getWithSetCallback(
+   self::getKeyByNameCacheKey( $cache, $name ),
+   $cache::TTL_INDEFINITE,
+   function ( $oldValue, &$ttl, &$setOpts ) use ( $name ) {
+   $dbr = CentralAuthUtils::getCentralSlaveDB();
+   $setOpts += Database::getCacheSetOptions( $dbr 
);
+
+   $row = $dbr->selectRow( 'wikiset', '*', [ 
'ws_name' => $name ], __METHOD__ );
+
+   $wikiSet = self::newFromRow( $row );
+   if ( $wikiSet ) {
+   $value = $wikiSet->getDataForCache();
+   } else {
+   $ttl = WANObjectCache::TTL_MINUTE; // 
cache negatives
+   $value = null;
}
-   }
-   }
-   $dbr = CentralAuthUtils::getCentralSlaveDB();
-   $row = $dbr->selectRow(
-   'wikiset', '*', [ 'ws_name' => $name ], __METHOD__
+
+   return $value;
+   },
+   [ 'version' => self::VERSION ]
);
-   if ( !$row ) {
-   return null;
+
+   if ( $data ) {
+   $wikiSet = new WikiSet( null, null );
+   $wikiSet->loadFromCachedData( $data );
+
+   return $wikiSet;
}
-   $ws = self::newFromRow( $row );
-   $ws->saveToCache();
-   return $ws;
+
+   return null;
}
 
/**
 * @param string|int $id
-* @param bool $useCache
 * @return null|WikiSet
 */
-   public static function newFromID( $id, $useCache = true ) {
-   if ( $useCache ) {
-   $cache = ObjectCache::getMainWANInstance();
-   $data = $cache->get( self::memcKey( $id ) );
-   if ( $data ) {
-   if ( $data['mVersion'] == self::VERSION ) {
-   $ws = new WikiSet( null, null );
-   foreach ( $data as $name => $val ) {
-   $ws->$name = $val;
-   }
-   return $ws;
+   public static function 

[MediaWiki-commits] [Gerrit] eventlogging[master]: Don't use gen.Task when parsing POST body into event(s)

[Ottomata (Code Review)]

Ottomata has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/393672 )

Change subject: Don't use gen.Task when parsing POST body into event(s)
..

Don't use gen.Task when parsing POST body into event(s)

This doesn't do anything useful here, since Event.factory does not
take a callback.

Change-Id: I25d23343d261d85ec12b3d7fbf5b799ea22e1773
---
M eventlogging/service.py
1 file changed, 16 insertions(+), 21 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/eventlogging 
refs/changes/72/393672/1

diff --git a/eventlogging/service.py b/eventlogging/service.py
index f7d30ef..b0ba2a4 100644
--- a/eventlogging/service.py
+++ b/eventlogging/service.py
@@ -28,7 +28,7 @@
 from . import ValidationError, SchemaError  # these are int __init__.py
 from .compat import json
 from .event import create_event_error, Event
-from .factory import apply_safe, get_writer
+from .factory import get_writer
 from .schema import (
 cache_schema, init_schema_cache, is_schema_cached, validate,
 scid_from_uri, get_schema, get_cached_schema_uris,
@@ -156,13 +156,10 @@
 
 def send(self, event):
 """
-Send the event to configured eventlogging writers. If a writer
-returns a future like object, this method will convert it into
-a tornado future.  A list of these futures will be returned.
-
-The non tornado futures returned by the eventlogging writer handlers
-MUST each have a convert_yielded future function
-registered with @tornado.gen.convert_yielded.register.
+Send the event to configured eventlogging writers.  If the configured
+writers yield anything back, it is expected that they yield either
+a Tornado future, or a Future like object that has a convert_yielded
+future function registered with @tornado.gen.convert_yielded.register.
 """
 futures = []
 for uri in self.writers.keys():
@@ -186,7 +183,7 @@
 if future:
 futures.append(future)
 
-# Return the list of tornado futures.
+# Return the list of futures.
 return futures
 
 @tornado.gen.coroutine
@@ -236,8 +233,8 @@
 validate(event, encapsulate=event.should_encapsulate())
 
 # Send this processed event to all configured writers.  This will
-# return a list a futures, the result of which will be yielded to the
-# caller.
+# get a list of tornado futures, the result of which will be yielded
+# to the caller.
 yield self.send(event)
 
 @tornado.gen.coroutine
@@ -259,6 +256,7 @@
 error_message = None
 
 try:
+# process event
 yield self.process_event(event)
 
 except TopicNotConfigured as e:
@@ -313,8 +311,8 @@
 if self.error_writer:
 self.error_writer.send(event_error)
 
-# raise Return will cause the gen.coroutine
-# to return a future filled with event_errors
+# raise tornado.gen.Return will cause the gen.coroutine
+# to return a tornado future filled with event_errors
 raise tornado.gen.Return(event_errors)
 
 def start(self):
@@ -334,9 +332,10 @@
 """
 events_string json string is read in from POST body.
 It can be a single event object or a list of event objects.
-They will be asynchronously parsed and validated, and then
-written to configured EventLogging writers.  'topic'
-must be set in each event's meta data.
+They will be parsed and validated, and then
+(asynchronously, if supported) written to configured
+EventLogging writers.
+'topic' must be set in each event's meta data.
 
 Reponses:
 - 201 if all events are accepted.
@@ -347,8 +346,6 @@
 body as a JSON list of the form:
 [{'event': {...}, 'error': 'String Error Message'}, ... ]
 
-# TODO: Use EventError and configure an error writer like
-  eventlogging-processor?
 """
 response_body = None
 if self.request.headers['Content-Type'] == 'application/json':
@@ -356,9 +353,7 @@
 if self.request.body:
 
 # Load the json body into Event objects.
-events = yield tornado.gen.Task(
-apply_safe, Event.factory, {'data': self.request.body}
-)
+events = Event.factory(self.request.body)
 
 # If we were only given a single event in the json,
 # convert it to a list so the rest of the code just works.

-- 
To view, visit https://gerrit.wikimedia.org/r/393672
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I25d23343d261d85ec12b3d7fbf5b799ea22e1773
Gerrit-PatchSet: 1

[MediaWiki-commits] [Gerrit] mediawiki...Translate[master]: Reorder Translate filters

[Petar.petkovic (Code Review)]

Petar.petkovic has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/393671 )

Change subject: Reorder Translate filters
..

Reorder Translate filters

Reorder the filters as follows:
- Translations
- Site messages
- Not translations

Bug: T159795
Change-Id: I9cea48df95a042926d74baea3fed436a02bbe878
---
M utils/RcFilter.php
1 file changed, 11 insertions(+), 11 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Translate 
refs/changes/71/393671/1

diff --git a/utils/RcFilter.php b/utils/RcFilter.php
index de9197b..54e533f 100644
--- a/utils/RcFilter.php
+++ b/utils/RcFilter.php
@@ -144,17 +144,6 @@
'isFullCoverage' => true,
'filters' => [
[
-   'name' => 'filter',
-   'label' => 
'translate-rcfilters-translations-filter-label',
-   'description' => 
'translate-rcfilters-translations-filter-desc',
-   'cssClassSuffix' => 'filter',
-   'isRowApplicableCallable' => 
function ( $ctx, $rc ) {
-   $namespaces = 
self::getTranslateNamespaces();
-
-   return !in_array( 
$rc->getAttribute( 'rc_namespace' ), $namespaces );
-   }
-   ],
-   [
'name' => 'only',
'label' => 
'translate-rcfilters-translations-only-label',
'description' => 
'translate-rcfilters-translations-only-desc',
@@ -178,6 +167,17 @@
strpos( 
$rc->getAttribute( 'rc_title' ), '/' ) === false;
}
],
+   [
+   'name' => 'filter',
+   'label' => 
'translate-rcfilters-translations-filter-label',
+   'description' => 
'translate-rcfilters-translations-filter-desc',
+   'cssClassSuffix' => 'filter',
+   'isRowApplicableCallable' => 
function ( $ctx, $rc ) {
+   $namespaces = 
self::getTranslateNamespaces();
+
+   return !in_array( 
$rc->getAttribute( 'rc_namespace' ), $namespaces );
+   }
+   ],
],
'queryCallable' => function ( 
$specialClassName, $ctx, $dbr, &$tables,
&$fields, &$conds, &$query_options, 
&$join_conds, $selectedValues

-- 
To view, visit https://gerrit.wikimedia.org/r/393671
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I9cea48df95a042926d74baea3fed436a02bbe878
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Translate
Gerrit-Branch: master
Gerrit-Owner: Petar.petkovic 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] operations/puppet[production]: remove Ganglia from labtest* hosts

[Dzahn (Code Review)]

Dzahn has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/393669 )

Change subject: remove Ganglia from labtest* hosts
..


remove Ganglia from labtest* hosts

Bug: T177225
Change-Id: I36e2c064e8b79393a4eac481ff2ea490f46273d3
---
M hieradata/regex.yaml
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  jenkins-bot: Verified
  Dzahn: Looks good to me, approved



diff --git a/hieradata/regex.yaml b/hieradata/regex.yaml
index 3b829bb..0b355c6 100644
--- a/hieradata/regex.yaml
+++ b/hieradata/regex.yaml
@@ -194,7 +194,7 @@
   openstack::nova::conductor::monitor::critical: false
   openstack::nova::network::monitor::critical: false
   icinga::monitor::toollabs::critical: false
-
+  standard::has_ganglia: false
 
 # require WriteBack policy to all hosts (independent of the role) that look
 # like databases. Currently this only works for megacli systems, but it will

-- 
To view, visit https://gerrit.wikimedia.org/r/393669
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I36e2c064e8b79393a4eac481ff2ea490f46273d3
Gerrit-PatchSet: 2
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Dzahn 
Gerrit-Reviewer: Dzahn 
Gerrit-Reviewer: Giuseppe Lavagetto 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits