[MediaWiki-commits] [Gerrit] mediawiki...ObjectFactory[master]: Add .gitreview

[Jforrester (Code Review)]

Jforrester has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/406047 )

Change subject: Add .gitreview
..


Add .gitreview

Change-Id: I779382c6bc00c49989f572b2091015c7e9fc12ca
---
A .gitreview
1 file changed, 5 insertions(+), 0 deletions(-)

Approvals:
  Jforrester: Verified; Looks good to me, approved



diff --git a/.gitreview b/.gitreview
new file mode 100644
index 000..2c3d116
--- /dev/null
+++ b/.gitreview
@@ -0,0 +1,5 @@
+[gerrit]
+host=gerrit.wikimedia.org
+port=29418
+project=mediawiki/libs/ObjectFactory.git
+track=1

-- 
To view, visit https://gerrit.wikimedia.org/r/406047
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I779382c6bc00c49989f572b2091015c7e9fc12ca
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/libs/ObjectFactory
Gerrit-Branch: master
Gerrit-Owner: Jforrester 
Gerrit-Reviewer: Jforrester 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...ObjectFactory[master]: Add .gitreview

[Jforrester (Code Review)]

Jforrester has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/406047 )

Change subject: Add .gitreview
..

Add .gitreview

Change-Id: I779382c6bc00c49989f572b2091015c7e9fc12ca
---
A .gitreview
1 file changed, 5 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/libs/ObjectFactory 
refs/changes/47/406047/1

diff --git a/.gitreview b/.gitreview
new file mode 100644
index 000..2c3d116
--- /dev/null
+++ b/.gitreview
@@ -0,0 +1,5 @@
+[gerrit]
+host=gerrit.wikimedia.org
+port=29418
+project=mediawiki/libs/ObjectFactory.git
+track=1

-- 
To view, visit https://gerrit.wikimedia.org/r/406047
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I779382c6bc00c49989f572b2091015c7e9fc12ca
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/libs/ObjectFactory
Gerrit-Branch: master
Gerrit-Owner: Jforrester 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...VisualEditor[wmf/1.31.0-wmf.17]: NWE: Don't attempt to set selection on unattached textarea

[Jforrester (Code Review)]

Jforrester has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/405933 )

Change subject: NWE: Don't attempt to set selection on unattached textarea
..

NWE: Don't attempt to set selection on unattached textarea

Prevents an exception being thrown in Firefox <= 52.

Bug: T185304
Change-Id: Ic9a43e3cf12d4cc566cebb328f8e807e464af634
(cherry picked from commit f2568c8d7db19b8ad594bbcff11194ed6e062677)
---
M modules/ve-mw/init/targets/ve.init.mw.DesktopArticleTarget.init.js
M modules/ve-mw/init/ve.init.mw.TempWikitextEditorWidget.js
2 files changed, 11 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/VisualEditor 
refs/changes/33/405933/1

diff --git a/modules/ve-mw/init/targets/ve.init.mw.DesktopArticleTarget.init.js 
b/modules/ve-mw/init/targets/ve.init.mw.DesktopArticleTarget.init.js
index a737d41..832dadc 100644
--- a/modules/ve-mw/init/targets/ve.init.mw.DesktopArticleTarget.init.js
+++ b/modules/ve-mw/init/targets/ve.init.mw.DesktopArticleTarget.init.js
@@ -139,7 +139,8 @@
 
// Resize the textarea to fit content. We could do this more 
often (e.g. on change)
// but hopefully this temporary textarea won't be visible for 
too long.
-   tempWikitextEditor.adjustSize().focus();
+   // Support: Firefox =< 52
+   tempWikitextEditor.adjustSize().moveCursorToStart();
ve.track( 'mwedit.ready', { mode: 'source' } );
}
 
diff --git a/modules/ve-mw/init/ve.init.mw.TempWikitextEditorWidget.js 
b/modules/ve-mw/init/ve.init.mw.TempWikitextEditorWidget.js
index 829ef78..5bc228c 100644
--- a/modules/ve-mw/init/ve.init.mw.TempWikitextEditorWidget.js
+++ b/modules/ve-mw/init/ve.init.mw.TempWikitextEditorWidget.js
@@ -34,9 +34,18 @@
} )
.val( config.value )
.on( 'input', config.onChange );
+};
 
+/**
+ * Focus the input and move the cursor to the start.
+ *
+ * @chainable
+ */
+mw.libs.ve.MWTempWikitextEditorWidget.prototype.moveCursorToStart = function 
() {
// Move cursor to start
this.$element[ 0 ].setSelectionRange( 0, 0 );
+   this.focus();
+   return this;
 };
 
 /**

-- 
To view, visit https://gerrit.wikimedia.org/r/405933
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic9a43e3cf12d4cc566cebb328f8e807e464af634
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/VisualEditor
Gerrit-Branch: wmf/1.31.0-wmf.17
Gerrit-Owner: Jforrester 
Gerrit-Reviewer: Esanders 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...VisualEditor[master]: Update VE core submodule to master (67548dc57)

[Jforrester (Code Review)]

Jforrester has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/405751 )

Change subject: Update VE core submodule to master (67548dc57)
..

Update VE core submodule to master (67548dc57)

New changes:
21a5d55b8 [BREAKING CHANGE] Store metadata as block nodes in the main data list
2f9868aae Localisation updates from https://translatewiki.net.

Bug: T56299
Change-Id: I45251811e3fbb3323a25ca5cf364e4cb94aa1d01
---
M .jsduck/categories.json
M .jsduck/eg-iframe.html
M extension.json
M lib/ve
4 files changed, 4 insertions(+), 6 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/VisualEditor 
refs/changes/51/405751/1

diff --git a/.jsduck/categories.json b/.jsduck/categories.json
index 81ebb36..f48e4bb 100644
--- a/.jsduck/categories.json
+++ b/.jsduck/categories.json
@@ -103,7 +103,6 @@
"ve.dm.ModelRegistry",
"ve.dm.ModelFactory",
"ve.dm.AnnotationFactory",
-   "ve.dm.MetaItemFactory",
"ve.dm.NodeFactory",
"ve.dm.Converter",
"ve.dm.DataString",
@@ -153,6 +152,7 @@
"ve.ce.TextState",
"ve.ce.TextStateChunk",
"ve.ce.*Annotation",
+   "ve.ce.MetaItem",
"ve.ce.*Factory",
"ve.ce.*KeyDownHandler",
"ve.ce.Document",
diff --git a/.jsduck/eg-iframe.html b/.jsduck/eg-iframe.html
index 51aa527..63426fe 100644
--- a/.jsduck/eg-iframe.html
+++ b/.jsduck/eg-iframe.html
@@ -180,7 +180,6 @@



-   



@@ -220,7 +219,6 @@



-   



@@ -291,6 +289,7 @@



+   



diff --git a/extension.json b/extension.json
index 82aefe2..a0353cb 100644
--- a/extension.json
+++ b/extension.json
@@ -600,7 +600,6 @@
"lib/ve/src/dm/ve.dm.NodeFactory.js",
"lib/ve/src/dm/ve.dm.AnnotationFactory.js",
"lib/ve/src/dm/ve.dm.AnnotationSet.js",
-   "lib/ve/src/dm/ve.dm.MetaItemFactory.js",
"lib/ve/src/dm/ve.dm.Node.js",
"lib/ve/src/dm/ve.dm.ClassAttributeNode.js",
"lib/ve/src/dm/ve.dm.AlignableNode.js",
@@ -640,7 +639,6 @@

"lib/ve/src/dm/selections/ve.dm.TableSelection.js",

"lib/ve/src/dm/lineardata/ve.dm.FlatLinearData.js",

"lib/ve/src/dm/lineardata/ve.dm.ElementLinearData.js",
-   
"lib/ve/src/dm/lineardata/ve.dm.MetaLinearData.js",

"lib/ve/src/dm/nodes/ve.dm.GeneratedContentNode.js",
"lib/ve/src/dm/nodes/ve.dm.AlienNode.js",
"lib/ve/src/dm/nodes/ve.dm.ArticleNode.js",
@@ -710,6 +708,7 @@
"lib/ve/src/ce/ve.ce.BranchNode.js",
"lib/ve/src/ce/ve.ce.ContentBranchNode.js",
"lib/ve/src/ce/ve.ce.LeafNode.js",
+   "lib/ve/src/ce/ve.ce.MetaItem.js",
"lib/ve/src/ce/ve.ce.ClassAttributeNode.js",
"lib/ve/src/ce/ve.ce.AlignableNode.js",
"lib/ve/src/ce/ve.ce.FocusableNode.js",
diff --git a/lib/ve b/lib/ve
index 88ba1eb..67548dc 16
--- a/lib/ve
+++ b/lib/ve
@@ -1 +1 @@
-Subproject commit 88ba1eb9a87b648a945fd3b655a9db852aa81a56
+Subproject commit 67548dc5741ab9baed44f7d8abe60d6ea3fa5a32

-- 
To view, visit https://gerrit.wikimedia.org/r/405751
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I45251811e3fbb3323a25ca5cf364e4cb94aa1d01
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Jforrester 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...ExtJSBase[master]: Use SPDX 3.0 license identifier

[Jforrester (Code Review)]

Jforrester has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/402019 )

Change subject: Use SPDX 3.0 license identifier
..


Use SPDX 3.0 license identifier

SPDX released version 3 of their license list (),
which changed the FSF licenses to explicitly end in -only or -or-later
instead of relying on an easy to miss + symbol.

Bug: T183858
Change-Id: I40d8e5c33dce29bb68bd56e77123d4be6389e5b5
---
M extension.json
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Thiemo Kreuz (WMDE): Looks good to me, approved
  Jforrester: Verified; Looks good to me, approved



diff --git a/extension.json b/extension.json
index 1c31c90..410b15c 100644
--- a/extension.json
+++ b/extension.json
@@ -6,7 +6,7 @@
],
"url": "https://www.mediawiki.org/wiki/Extension:ExtJSBase;,
"descriptionmsg": "extjsbase-desc",
-   "license-name": "GPL-3.0",
+   "license-name": "GPL-3.0-only",
"type": "other",
"MessagesDirs": {
"ExtJSBase": [

-- 
To view, visit https://gerrit.wikimedia.org/r/402019
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I40d8e5c33dce29bb68bd56e77123d4be6389e5b5
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/ExtJSBase
Gerrit-Branch: master
Gerrit-Owner: Legoktm 
Gerrit-Reviewer: Jforrester 
Gerrit-Reviewer: Thiemo Kreuz (WMDE) 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Follow-up 95e7c545: Fix .gitattributes file line truncation

[Jforrester (Code Review)]

Jforrester has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/405556 )

Change subject: Follow-up 95e7c545: Fix .gitattributes file line truncation
..

Follow-up 95e7c545: Fix .gitattributes file line truncation

Change-Id: I82bf4beeed41cde89da3f1f8bc517420bdfd03ad
---
M .gitattributes
1 file changed, 2 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core 
refs/changes/56/405556/1

diff --git a/.gitattributes b/.gitattributes
index b306f36..786c09f 100644
--- a/.gitattributes
+++ b/.gitattributes
@@ -5,8 +5,8 @@
 *~ export-ignore
 #*# export-ignore
 .* export-ignore
-package.jso export-ignore
-README.mediawik export-ignore
+package.json export-ignore
+README.mediawiki export-ignore
 Gemfile* export-ignore
 vendor/pear/net_smtp/README.rst export-ignore
 

-- 
To view, visit https://gerrit.wikimedia.org/r/405556
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I82bf4beeed41cde89da3f1f8bc517420bdfd03ad
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Jforrester 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] oojs/ui[master]: [WIP] doc: Convert from jsduck to JSDoc3

[Jforrester (Code Review)]

Jforrester has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/405543 )

Change subject: [WIP] doc: Convert from jsduck to JSDoc3
..

[WIP] doc: Convert from jsduck to JSDoc3

Bug: T185396
Change-Id: I65a7bbd8d0311c4537e06f89922f39b4d67f805e
---
M src/ActionSet.js
M src/Dialog.js
M src/Element.js
M src/Error.js
M src/Layout.js
M src/Tool.js
M src/ToolGroup.js
M src/Toolbar.js
M src/Widget.js
M src/Window.js
M src/WindowManager.js
M src/layouts/BookletLayout.js
M src/layouts/FieldLayout.js
M src/layouts/FieldsetLayout.js
M src/layouts/FormLayout.js
M src/layouts/HorizontalLayout.js
M src/layouts/IndexLayout.js
M src/layouts/MenuLayout.js
M src/layouts/PanelLayout.js
M src/layouts/StackLayout.js
M src/layouts/TabPanelLayout.js
M src/mixins/AccessKeyedElement.js
M src/mixins/ButtonElement.js
M src/mixins/ClippableElement.js
M src/mixins/DraggableElement.js
M src/mixins/DraggableGroupElement.js
M src/mixins/FlaggedElement.js
M src/mixins/FloatableElement.js
M src/mixins/GroupElement.js
M src/mixins/GroupWidget.js
M src/mixins/IconElement.js
M src/mixins/IndicatorElement.js
M src/mixins/ItemWidget.js
M src/mixins/LabelElement.js
M src/mixins/LookupElement.js
M src/mixins/PendingElement.js
M src/mixins/PopupElement.js
M src/mixins/RequestManager.js
M src/mixins/TabIndexedElement.js
M src/mixins/TitledElement.js
M src/toolgroups/ListToolGroup.js
M src/toolgroups/PopupToolGroup.js
M src/tools/PopupTool.js
M src/widgets/ActionWidget.js
M src/widgets/ButtonGroupWidget.js
M src/widgets/ButtonInputWidget.js
M src/widgets/ButtonOptionWidget.js
M src/widgets/ButtonSelectWidget.js
M src/widgets/ButtonWidget.js
M src/widgets/CapsuleItemWidget.js
M src/widgets/CapsuleMultiselectWidget.js
M src/widgets/CheckboxInputWidget.js
M src/widgets/CheckboxMultiselectInputWidget.js
M src/widgets/ComboBoxInputWidget.js
M src/widgets/DecoratedOptionWidget.js
M src/widgets/DropdownInputWidget.js
M src/widgets/DropdownWidget.js
M src/widgets/HiddenInputWidget.js
M src/widgets/IconWidget.js
M src/widgets/IndicatorWidget.js
M src/widgets/InputWidget.js
M src/widgets/LabelWidget.js
M src/widgets/MenuSelectWidget.js
M src/widgets/MenuTagMultiselectWidget.js
M src/widgets/MultilineTextInputWidget.js
M src/widgets/MultioptionWidget.js
M src/widgets/MultiselectWidget.js
M src/widgets/NumberInputWidget.js
M src/widgets/OptionWidget.js
M src/widgets/OutlineControlsWidget.js
M src/widgets/OutlineOptionWidget.js
M src/widgets/OutlineSelectWidget.js
M src/widgets/PopupButtonWidget.js
M src/widgets/PopupTagMultiselectWidget.js
M src/widgets/PopupWidget.js
M src/widgets/ProgressBarWidget.js
M src/widgets/RadioInputWidget.js
M src/widgets/RadioSelectInputWidget.js
M src/widgets/RadioSelectWidget.js
M src/widgets/SearchWidget.js
M src/widgets/SelectFileWidget.js
M src/widgets/SelectWidget.js
M src/widgets/TabSelectWidget.js
M src/widgets/TagItemWidget.js
M src/widgets/TagMultiselectWidget.js
M src/widgets/TextInputWidget.js
M src/widgets/ToggleButtonWidget.js
M src/widgets/ToggleSwitchWidget.js
M src/widgets/ToggleWidget.js
89 files changed, 368 insertions(+), 415 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/oojs/ui refs/changes/43/405543/1

diff --git a/src/ActionSet.js b/src/ActionSet.js
index bb7ea5a..ab58489 100644
--- a/src/ActionSet.js
+++ b/src/ActionSet.js
@@ -74,7 +74,7 @@
  *
  * @abstract
  * @class
- * @mixins OO.EventEmitter
+ * @mixes OO.EventEmitter
  *
  * @constructor
  * @param {Object} [config] Configuration options
@@ -125,36 +125,33 @@
 /* Events */
 
 /**
- * @event click
- *
  * A 'click' event is emitted when an action is clicked.
  *
+ * @event click
  * @param {OO.ui.ActionWidget} action Action that was clicked
  */
 
 /**
- * @event add
- *
  * An 'add' event is emitted when actions are {@link #method-add added} to the 
action set.
  *
+ * @event add
  * @param {OO.ui.ActionWidget[]} added Actions added
  */
 
 /**
- * @event remove
- *
  * A 'remove' event is emitted when actions are {@link #method-remove removed}
  *  or {@link #clear cleared}.
  *
+ * @event remove
  * @param {OO.ui.ActionWidget[]} added Actions removed
  */
 
 /**
- * @event change
  *
  * A 'change' event is emitted when actions are {@link #method-add added}, 
{@link #clear cleared},
  * or {@link #method-remove removed} from the action set or when the {@link 
#setMode mode} is changed.
  *
+ * @event change
  */
 
 /* Methods */
diff --git a/src/Dialog.js b/src/Dialog.js
index 7ef81f8..71049b5 100644
--- a/src/Dialog.js
+++ b/src/Dialog.js
@@ -36,7 +36,7 @@
  * @abstract
  * @class
  * @extends OO.ui.Window
- * @mixins OO.ui.mixin.PendingElement
+ * @mixes OO.ui.mixin.PendingElement
  *
  * @constructor
  * @param {Object} [config] Configuration options
diff --git a/src/Element.js b/src/Element.js
index abb91dc..fce5a18 100644
--- a/src/Element.js
+++ b/src/Element.js
@@ -8,18 +8,18 @@
  *
  * @constructor
  * @param {Object} [config] Configuration 

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: PHPVersionCheck: PHP 5.5.0 is no longer supported by upstrea...

[Jforrester (Code Review)]

Jforrester has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/405219 )

Change subject: PHPVersionCheck: PHP 5.5.0 is no longer supported by upstream, 
but 5.6.0 is
..

PHPVersionCheck: PHP 5.5.0 is no longer supported by upstream, but 5.6.0 is

Change-Id: I7031f0e909db8d63012f4057939292cb3b472cde
---
M includes/PHPVersionCheck.php
1 file changed, 3 insertions(+), 3 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core 
refs/changes/19/405219/1

diff --git a/includes/PHPVersionCheck.php b/includes/PHPVersionCheck.php
index da428dd..a48d460 100644
--- a/includes/PHPVersionCheck.php
+++ b/includes/PHPVersionCheck.php
@@ -94,7 +94,7 @@
'implementation' => 'PHP',
'version' => PHP_VERSION,
'vendor' => 'the PHP Group',
-   'upstreamSupported' => '5.5.0',
+   'upstreamSupported' => '5.6.0',
'minSupported' => '5.5.9',
'upgradeURL' => 'https://secure.php.net/downloads.php',
);
@@ -128,13 +128,13 @@
$longHtml = <download an 
+   you will need to https://www.mediawiki.org/wiki/Download;>download an
older version of MediaWiki from our website.
See ourhttps://www.mediawiki.org/wiki/Compatibility#PHP;>compatibility page
for details of which versions are compatible with prior 
versions of {$phpInfo['implementation']}.

-- 
To view, visit https://gerrit.wikimedia.org/r/405219
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I7031f0e909db8d63012f4057939292cb3b472cde
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Jforrester 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: [DNM] Bump PHP version requirement to 7.0.0+

[Jforrester (Code Review)]

Jforrester has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/405216 )

Change subject: [DNM] Bump PHP version requirement to 7.0.0+
..

[DNM] Bump PHP version requirement to 7.0.0+

Intended to be merged into master before the branch of REL1_31, pending the
upgrade and clean-up of Wikimedia production to make this possible.

Bug: T172165
Change-Id: I740f32ac859d9bb3787fdf8414f82ae6f410492f
---
M INSTALL
M RELEASE-NOTES-1.31
M composer.json
M includes/GlobalFunctions.php
M includes/PHPVersionCheck.php
M includes/libs/CSSMin.php
6 files changed, 6 insertions(+), 74 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core 
refs/changes/16/405216/1

diff --git a/INSTALL b/INSTALL
index 1a59f0b..5c6669e 100644
--- a/INSTALL
+++ b/INSTALL
@@ -6,7 +6,7 @@
 "in-place", as long as you have the necessary prerequisites available.
 
 Required software:
-* Web server with PHP 5.5.9 or higher.
+* Web server with PHP 7.0.0 or HHVM 3.18.5 or higher.
 * A SQL server, the following types are supported
 ** MySQL 5.5.8 or higher
 ** PostgreSQL 8.3 or higher
diff --git a/RELEASE-NOTES-1.31 b/RELEASE-NOTES-1.31
index a50159c..422f7e9 100644
--- a/RELEASE-NOTES-1.31
+++ b/RELEASE-NOTES-1.31
@@ -179,8 +179,8 @@
   default driver for MySQL has been 'mysqli' since MediaWiki 1.22.
 
 == Compatibility ==
-MediaWiki 1.31 requires PHP 5.5.9 or later. Although HHVM 3.18.5 or later is 
supported,
-it is generally advised to use PHP 5.5.9 or later for long term support.
+MediaWiki 1.31 requires PHP 7.0.0 or later. Although HHVM 3.18.5 or later is 
supported,
+it is generally advised to use PHP 7.0.0 or later for long term support.
 
 MySQL/MariaDB is the recommended DBMS. PostgreSQL or SQLite can also be used,
 but support for them is somewhat less mature. There is experimental support for
diff --git a/composer.json b/composer.json
index 4ae1f00..4d8982e 100644
--- a/composer.json
+++ b/composer.json
@@ -27,7 +27,7 @@
"mediawiki/at-ease": "1.1.0",
"oojs/oojs-ui": "0.25.1",
"oyejorge/less.php": "1.7.0.14",
-   "php": ">=5.5.9",
+   "php": ">=7.0.0",
"psr/log": "1.0.2",
"wikimedia/assert": "0.2.2",
"wikimedia/base-convert": "1.0.1",
diff --git a/includes/GlobalFunctions.php b/includes/GlobalFunctions.php
index b181628..a365e6c 100644
--- a/includes/GlobalFunctions.php
+++ b/includes/GlobalFunctions.php
@@ -32,75 +32,6 @@
 use Wikimedia\ScopedCallback;
 use Wikimedia\Rdbms\DBReplicationWaitError;
 
-// Hide compatibility functions from Doxygen
-/// @cond
-/**
- * Compatibility functions
- *
- * We support PHP 5.5.9 and up.
- * Re-implementations of newer functions or functions in non-standard
- * PHP extensions may be included here.
- */
-
-// hash_equals function only exists in PHP >= 5.6.0
-// https://secure.php.net/hash_equals
-if ( !function_exists( 'hash_equals' ) ) {
-   /**
-* Check whether a user-provided string is equal to a fixed-length 
secret string
-* without revealing bytes of the secret string through timing 
differences.
-*
-* The usual way to compare strings (PHP's === operator or the 
underlying memcmp()
-* function in C) is to compare corresponding bytes and stop at the 
first difference,
-* which would take longer for a partial match than for a complete 
mismatch. This
-* is not secure when one of the strings (e.g. an HMAC or token) must 
remain secret
-* and the other may come from an attacker. Statistical analysis of 
timing measurements
-* over many requests may allow the attacker to guess the string's 
bytes one at a time
-* (and check his guesses) even if the timing differences are extremely 
small.
-*
-* When making such a security-sensitive comparison, it is essential 
that the sequence
-* in which instructions are executed and memory locations are accessed 
not depend on
-* the secret string's value. HOWEVER, for simplicity, we do not 
attempt to minimize
-* the inevitable leakage of the string's length. That is generally 
known anyway as
-* a chararacteristic of the hash function used to compute the secret 
value.
-*
-* Longer explanation: http://www.emerose.com/timing-attacks-explained
-*
-* @codeCoverageIgnore
-* @param string $known_string Fixed-length secret string to compare 
against
-* @param string $user_string User-provided string
-* @return bool True if the strings are the same, false otherwise
-*/
-   function hash_equals( $known_string, $user_string ) {
-   // Strict type checking as in PHP's native implementation
-   if ( !is_string( $known_string ) ) {
-   trigger_error( 'hash_equals(): Expected known_string to 
be a string, ' .
-

[MediaWiki-commits] [Gerrit] oojs/ui[master]: [BREAKING CHANGE] indicators: Remove 'alert', deprecated in ...

[Jforrester (Code Review)]

Jforrester has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/405045 )

Change subject: [BREAKING CHANGE] indicators: Remove 'alert', deprecated in 
v0.25.2
..

[BREAKING CHANGE] indicators: Remove 'alert', deprecated in v0.25.2

Bug: T185158
Change-Id: I50d99597332a127a8f4c074fd26fd811acb5b5c5
---
D src/themes/apex/images/indicators/alert.svg
M src/themes/apex/indicators.json
D src/themes/wikimediaui/images/indicators/alert.svg
M src/themes/wikimediaui/indicators.json
4 files changed, 0 insertions(+), 16 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/oojs/ui refs/changes/45/405045/1

diff --git a/src/themes/apex/images/indicators/alert.svg 
b/src/themes/apex/images/indicators/alert.svg
deleted file mode 100644
index 2a4e23d..000
--- a/src/themes/apex/images/indicators/alert.svg
+++ /dev/null
@@ -1,4 +0,0 @@
-
-http://www.w3.org/2000/svg; width="12" height="12" viewBox="0 0 12 
12">
-   
-
diff --git a/src/themes/apex/indicators.json b/src/themes/apex/indicators.json
index 2c6fd51..afa262c 100644
--- a/src/themes/apex/indicators.json
+++ b/src/themes/apex/indicators.json
@@ -2,10 +2,6 @@
"prefix": "oo-ui-indicator",
"intro": "@import '../../../../src/styles/common';",
"images": {
-   "alert": {
-   "file": "images/indicators/alert.svg",
-   "deprecated": "This will be removed in v0.27.0."
-   },
"clear": { "file": "images/indicators/clear.svg" },
"up": { "file": "images/indicators/arrow-up.svg" },
"down": { "file": "images/indicators/arrow-down.svg" },
diff --git a/src/themes/wikimediaui/images/indicators/alert.svg 
b/src/themes/wikimediaui/images/indicators/alert.svg
deleted file mode 100644
index 2a4e23d..000
--- a/src/themes/wikimediaui/images/indicators/alert.svg
+++ /dev/null
@@ -1,4 +0,0 @@
-
-http://www.w3.org/2000/svg; width="12" height="12" viewBox="0 0 12 
12">
-   
-
diff --git a/src/themes/wikimediaui/indicators.json 
b/src/themes/wikimediaui/indicators.json
index f554a5c..2d71fdb 100644
--- a/src/themes/wikimediaui/indicators.json
+++ b/src/themes/wikimediaui/indicators.json
@@ -9,10 +9,6 @@
}
},
"images": {
-   "alert": {
-   "file": "images/indicators/alert.svg",
-   "deprecated": "This will be removed in v0.27.0."
-   },
"clear": { "file": "images/indicators/clear.svg" },
"up": { "file": "images/indicators/arrow-up.svg" },
"down": { "file": "images/indicators/arrow-down.svg" },

-- 
To view, visit https://gerrit.wikimedia.org/r/405045
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I50d99597332a127a8f4c074fd26fd811acb5b5c5
Gerrit-PatchSet: 1
Gerrit-Project: oojs/ui
Gerrit-Branch: master
Gerrit-Owner: Jforrester 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] oojs/ui[master]: [BREAKING CHANGE] indicators: Remove 'next' and 'previous', ...

[Jforrester (Code Review)]

Jforrester has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/405044 )

Change subject: [BREAKING CHANGE] indicators: Remove 'next' and 'previous', 
deprecated in v0.25.0
..

[BREAKING CHANGE] indicators: Remove 'next' and 'previous', deprecated in 
v0.25.0

Bug: T184329
Change-Id: I20e98ac6740887c2965e1b4dd62f8009081d9dc3
---
D src/themes/apex/images/indicators/arrow-ltr.svg
D src/themes/apex/images/indicators/arrow-rtl.svg
M src/themes/apex/indicators.json
D src/themes/wikimediaui/images/indicators/arrow-ltr.svg
D src/themes/wikimediaui/images/indicators/arrow-rtl.svg
M src/themes/wikimediaui/indicators.json
6 files changed, 0 insertions(+), 40 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/oojs/ui refs/changes/44/405044/1

diff --git a/src/themes/apex/images/indicators/arrow-ltr.svg 
b/src/themes/apex/images/indicators/arrow-ltr.svg
deleted file mode 100644
index 31bcbaa..000
--- a/src/themes/apex/images/indicators/arrow-ltr.svg
+++ /dev/null
@@ -1,4 +0,0 @@
-
-http://www.w3.org/2000/svg; width="12" height="12" viewBox="0 0 12 
12">
-   
-
diff --git a/src/themes/apex/images/indicators/arrow-rtl.svg 
b/src/themes/apex/images/indicators/arrow-rtl.svg
deleted file mode 100644
index 30a08ee..000
--- a/src/themes/apex/images/indicators/arrow-rtl.svg
+++ /dev/null
@@ -1,4 +0,0 @@
-
-http://www.w3.org/2000/svg; width="12" height="12" viewBox="0 0 12 
12">
-   
-
diff --git a/src/themes/apex/indicators.json b/src/themes/apex/indicators.json
index 2c32e58..2c6fd51 100644
--- a/src/themes/apex/indicators.json
+++ b/src/themes/apex/indicators.json
@@ -9,18 +9,6 @@
"clear": { "file": "images/indicators/clear.svg" },
"up": { "file": "images/indicators/arrow-up.svg" },
"down": { "file": "images/indicators/arrow-down.svg" },
-   "next": { "file": {
-   "ltr": "images/indicators/arrow-ltr.svg",
-   "rtl": "images/indicators/arrow-rtl.svg"
-   },
-   "deprecated": "This will be removed in v0.26.0."
-   },
-   "previous": { "file": {
-   "ltr": "images/indicators/arrow-rtl.svg",
-   "rtl": "images/indicators/arrow-ltr.svg"
-   },
-   "deprecated": "This will be removed in v0.26.0."
-   },
"required": { "file": "images/indicators/required.svg" },
"search": { "file": {
"ltr": "images/indicators/search-ltr.svg",
diff --git a/src/themes/wikimediaui/images/indicators/arrow-ltr.svg 
b/src/themes/wikimediaui/images/indicators/arrow-ltr.svg
deleted file mode 100644
index e4a280d..000
--- a/src/themes/wikimediaui/images/indicators/arrow-ltr.svg
+++ /dev/null
@@ -1,4 +0,0 @@
-
-http://www.w3.org/2000/svg; width="12" height="12" viewBox="0 0 12 
12">
-   
-
diff --git a/src/themes/wikimediaui/images/indicators/arrow-rtl.svg 
b/src/themes/wikimediaui/images/indicators/arrow-rtl.svg
deleted file mode 100644
index 419dbb2..000
--- a/src/themes/wikimediaui/images/indicators/arrow-rtl.svg
+++ /dev/null
@@ -1,4 +0,0 @@
-
-http://www.w3.org/2000/svg; width="12" height="12" viewBox="0 0 12 
12">
-   
-
diff --git a/src/themes/wikimediaui/indicators.json 
b/src/themes/wikimediaui/indicators.json
index eb3a2a6..f554a5c 100644
--- a/src/themes/wikimediaui/indicators.json
+++ b/src/themes/wikimediaui/indicators.json
@@ -16,18 +16,6 @@
"clear": { "file": "images/indicators/clear.svg" },
"up": { "file": "images/indicators/arrow-up.svg" },
"down": { "file": "images/indicators/arrow-down.svg" },
-   "next": { "file": {
-   "ltr": "images/indicators/arrow-ltr.svg",
-   "rtl": "images/indicators/arrow-rtl.svg"
-   },
-   "deprecated": "This will be removed in v0.26.0."
-   },
-   "previous": { "file": {
-   "ltr": "images/indicators/arrow-rtl.svg",
-   "rtl": "images/indicators/arrow-ltr.svg"
-   },
-   "deprecated": "This will be removed in v0.26.0."
-   },
"required": { "file": "images/indicators/required.svg" },
"search": { "file": {
"ltr": "images/indicators/search-ltr.svg",

-- 
To view, visit https://gerrit.wikimedia.org/r/405044
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I20e98ac6740887c2965e1b4dd62f8009081d9dc3
Gerrit-PatchSet: 1
Gerrit-Project: oojs/ui
Gerrit-Branch: master
Gerrit-Owner: Jforrester 

___
MediaWiki-commits mailing list

[MediaWiki-commits] [Gerrit] mediawiki...WikiEditor[master]: Remove dummy isSupported function, deprecated in REL1_31

[Jforrester (Code Review)]

Hello Esanders, Legoktm, jenkins-bot, TheDJ,

I'd like you to do a code review.  Please visit

https://gerrit.wikimedia.org/r/405031

to review the following change.


Change subject: Remove dummy isSupported function, deprecated in REL1_31
..

Remove dummy isSupported function, deprecated in REL1_31

This reverts commit a92c99cd45f3ffa1e606662d3e5a3fff170105dd.

Change-Id: I2567fbf5a41efb1242b690dd23e4b59b166c0251
---
M modules/jquery.wikiEditor.js
1 file changed, 0 insertions(+), 14 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/WikiEditor 
refs/changes/31/405031/1

diff --git a/modules/jquery.wikiEditor.js b/modules/jquery.wikiEditor.js
index 691bcb3..5b098d8 100644
--- a/modules/jquery.wikiEditor.js
+++ b/modules/jquery.wikiEditor.js
@@ -61,20 +61,6 @@
imgPath: mw.config.get( 'wgExtensionAssetsPath' ) + 
'/WikiEditor/modules/images/',
 
/**
-* Checks if the client supports WikiEditor.
-*
-* Since 1.31 this check is deprecated and can be skipped as 
all browsers
-* which are served JS by MediaWiki support WikiEditor.
-*
-* @deprecated since 1.31
-* @return {boolean}
-*/
-   isSupported: function () {
-   mw.log.warn( '$.wikiEditor.isSupported is deprecated.' 
);
-   return true;
-   },
-
-   /**
 * Checks if a module has a specific requirement
 *
 * @param {Object} module Module object

-- 
To view, visit https://gerrit.wikimedia.org/r/405031
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I2567fbf5a41efb1242b690dd23e4b59b166c0251
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/WikiEditor
Gerrit-Branch: master
Gerrit-Owner: Jforrester 
Gerrit-Reviewer: Esanders 
Gerrit-Reviewer: Legoktm 
Gerrit-Reviewer: TheDJ 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...Score[wmf/1.31.0-wmf.17]: Always pass FileBackend instance to `new FileRepo()`

[Jforrester (Code Review)]

Jforrester has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/405029 )

Change subject: Always pass FileBackend instance to `new FileRepo()`
..

Always pass FileBackend instance to `new FileRepo()`

Score::$backend is only initialized if Score::getBackend() has been called,
but there are code paths in which getLength() will be called before that
function is ever called. Instead just use Score::getBackend(), which will
lazy-load the backend object, ensuring that we always pass one to FileRepo.

Bug: T185204
Change-Id: Id75c270e1ee49bd94db06c11353b7be9ecb773de
(cherry picked from commit 58e19ece76fa98dad17f63c02dd9d4743f1f9dc2)
---
M includes/Score.php
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Score 
refs/changes/29/405029/1

diff --git a/includes/Score.php b/includes/Score.php
index ca32ab4..492b14c 100644
--- a/includes/Score.php
+++ b/includes/Score.php
@@ -1034,7 +1034,7 @@
$isFileMp3 = pathinfo( $path, PATHINFO_EXTENSION ) === 'mp3';
$repo = new FileRepo( [
'name' => 'foo',
-   'backend' => self::$backend
+   'backend' => self::getBackend()
] );
 
$f = new UnregisteredLocalFile( false, $repo, $path, $isFileMp3

-- 
To view, visit https://gerrit.wikimedia.org/r/405029
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Id75c270e1ee49bd94db06c11353b7be9ecb773de
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Score
Gerrit-Branch: wmf/1.31.0-wmf.17
Gerrit-Owner: Jforrester 
Gerrit-Reviewer: Legoktm 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...VisualEditor[master]: Remove use of global for wgEditSubmitButtonLabelPublish

[Jforrester (Code Review)]

Jforrester has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/404764 )

Change subject: Remove use of global for wgEditSubmitButtonLabelPublish
..

Remove use of global for wgEditSubmitButtonLabelPublish

Change-Id: I0d02dffd92e74d001ea1a8873aaa9faf1cf08da2
---
M VisualEditorDataModule.php
1 file changed, 2 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/VisualEditor 
refs/changes/64/404764/1

diff --git a/VisualEditorDataModule.php b/VisualEditorDataModule.php
index c550f03..e7eef89 100644
--- a/VisualEditorDataModule.php
+++ b/VisualEditorDataModule.php
@@ -44,8 +44,8 @@
}
 
protected function getMessageInfo( ResourceLoaderContext $context ) {
-   global $wgEditSubmitButtonLabelPublish;
-   $saveButtonLabelKey = $wgEditSubmitButtonLabelPublish ? 
'publishpage' : 'savearticle';
+   $editSubmitButtonLabelPublish = $context->getConfig()->get( 
'EditSubmitButtonLabelPublish' );
+   $saveButtonLabelKey = $editSubmitButtonLabelPublish ? 
'publishpage' : 'savearticle';
$saveButtonLabel = $context->msg( $saveButtonLabelKey )->text();
 
// Messages to be exported as parsed html

-- 
To view, visit https://gerrit.wikimedia.org/r/404764
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I0d02dffd92e74d001ea1a8873aaa9faf1cf08da2
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Jforrester 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...VisualEditor[master]: Update VE core submodule to master (76c4c0b65)

[Jforrester (Code Review)]

Jforrester has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/404763 )

Change subject: Update VE core submodule to master (76c4c0b65)
..

Update VE core submodule to master (76c4c0b65)

New changes:
ba7adf119 OOUI: Manually pull in fix from I99caad7b ahead of the release cycle
3cdb40b27 Update OOUI to v0.25.1
a1ec03ade getSelectedItem() -> findSelectedItem()

Change-Id: I58562868ff9c76e5abcca3297d8c7cc1bc60bf12
---
M lib/ve
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/VisualEditor 
refs/changes/63/404763/1

diff --git a/lib/ve b/lib/ve
index d5428e9..76c4c0b 16
--- a/lib/ve
+++ b/lib/ve
@@ -1 +1 @@
-Subproject commit d5428e9b346bb3b9bf5e043efae6078d8a55c683
+Subproject commit 76c4c0b65190cf7531aec3a93be6a1ae35dacd8b

-- 
To view, visit https://gerrit.wikimedia.org/r/404763
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I58562868ff9c76e5abcca3297d8c7cc1bc60bf12
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Jforrester 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...VisualEditor[master]: Use wgEditSubmitButtonLabelPublish from upstream

[Jforrester (Code Review)]

Jforrester has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/404760 )

Change subject: Use wgEditSubmitButtonLabelPublish from upstream
..

Use wgEditSubmitButtonLabelPublish from upstream

Change-Id: I772a21025771f82cdb7260e53996c2c6fd6fa718
Depends-On: I065f733bd8b27bda68023cd1b718e257fd135aa2
---
M VisualEditor.hooks.php
1 file changed, 0 insertions(+), 4 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/VisualEditor 
refs/changes/60/404760/1

diff --git a/VisualEditor.hooks.php b/VisualEditor.hooks.php
index ebd7463..efb3660 100644
--- a/VisualEditor.hooks.php
+++ b/VisualEditor.hooks.php
@@ -68,10 +68,6 @@
$output->addJsConfigVars( 'wgVisualEditorToolbarScrollOffset', 
$toolbarScrollOffset );
$output->addJsConfigVars( 
'wgVisualEditorUnsupportedEditParams', self::$unsupportedEditParams );
 
-   $output->addJsConfigVars(
-   'wgEditSubmitButtonLabelPublish',
-   $veConfig->get( 'EditSubmitButtonLabelPublish' )
-   );
return true;
}
 

-- 
To view, visit https://gerrit.wikimedia.org/r/404760
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I772a21025771f82cdb7260e53996c2c6fd6fa718
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Jforrester 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...SpellingDictionary[master]: Replace use of OOUI deprecated constructive flag

[Jforrester (Code Review)]

Jforrester has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/404725 )

Change subject: Replace use of OOUI deprecated constructive flag
..


Replace use of OOUI deprecated constructive flag

Change-Id: I44dcd6c574e2e557cd106f5af32ca8446c024d89
---
M modules/ext.SpellingDictionary.submitWord.js
M modules/ext.SpellingDictionary.viewByLanguage.js
2 files changed, 2 insertions(+), 2 deletions(-)

Approvals:
  Jforrester: Verified; Looks good to me, approved



diff --git a/modules/ext.SpellingDictionary.submitWord.js 
b/modules/ext.SpellingDictionary.submitWord.js
index 3ab977a..8adf083 100644
--- a/modules/ext.SpellingDictionary.submitWord.js
+++ b/modules/ext.SpellingDictionary.submitWord.js
@@ -16,7 +16,7 @@
} );
var submitButton = new OO.ui.ButtonInputWidget( {
label: mw.message( 'add-word-form-submit' ).text(),
-   flags: [ 'constructive', 'primary'],
+   flags: [ 'progressive', 'primary'],
indicator: 'next',
type: 'submit'
} );
diff --git a/modules/ext.SpellingDictionary.viewByLanguage.js 
b/modules/ext.SpellingDictionary.viewByLanguage.js
index 60629da..2982461 100644
--- a/modules/ext.SpellingDictionary.viewByLanguage.js
+++ b/modules/ext.SpellingDictionary.viewByLanguage.js
@@ -14,7 +14,7 @@
} );
var submitButton = new OO.ui.ButtonInputWidget( {
label: mw.message( 'sd-admin-view-selected-language' ).text(),
-   flags: [ 'constructive', 'primary' ],
+   flags: [ 'progressive', 'primary' ],
indicator: 'next',
type: 'submit'
} );

-- 
To view, visit https://gerrit.wikimedia.org/r/404725
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I44dcd6c574e2e557cd106f5af32ca8446c024d89
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/SpellingDictionary
Gerrit-Branch: master
Gerrit-Owner: Jforrester 
Gerrit-Reviewer: Jforrester 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...BetaFeatures[master]: tests: Quick fix for unit tests asserting the shape of OOUI ids

[Jforrester (Code Review)]

Jforrester has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/404735 )

Change subject: tests: Quick fix for unit tests asserting the shape of OOUI ids
..

tests: Quick fix for unit tests asserting the shape of OOUI ids

Longer term, these tests probably shouldn't rely on this detail, but this
unbreaks the tests for now.

Change-Id: Id1a794249d9b5ee3ca6200cb661e37b319155696
---
M tests/phpunit/HTMLFeatureFieldTest.php
M tests/phpunit/NewHTMLCheckFieldTest.php
2 files changed, 4 insertions(+), 4 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/BetaFeatures 
refs/changes/35/404735/1

diff --git a/tests/phpunit/HTMLFeatureFieldTest.php 
b/tests/phpunit/HTMLFeatureFieldTest.php
index bbbf8c8..3266e7f 100644
--- a/tests/phpunit/HTMLFeatureFieldTest.php
+++ b/tests/phpunit/HTMLFeatureFieldTest.php
@@ -49,11 +49,11 @@
],
[
'pattern' => "##",
+   "name='wpblahblahblah' value='1' 
id='ooui-php-\d+' class='oo-ui-inputWidget-input' />#",
'message' => 'Styled checkbox input not found.',
],
[
-   'pattern' => "#" .
+   'pattern' => "#" .
"blah blah blah#",
'message' => 'Checkbox label not found.',
],
diff --git a/tests/phpunit/NewHTMLCheckFieldTest.php 
b/tests/phpunit/NewHTMLCheckFieldTest.php
index f0671de..0f07b15 100644
--- a/tests/phpunit/NewHTMLCheckFieldTest.php
+++ b/tests/phpunit/NewHTMLCheckFieldTest.php
@@ -47,12 +47,12 @@
);
$this->assertRegExp(
"##",
+   "value='1' checked='checked' id='ooui-php-\d+' 
class='oo-ui-inputWidget-input' />#",
$html,
'Styled input not found.'
);
$this->assertRegExp(
-   "#blah blah blah#",
+   "#blah blah blah#",
$html,
'Checkbox label not found.'
);

-- 
To view, visit https://gerrit.wikimedia.org/r/404735
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Id1a794249d9b5ee3ca6200cb661e37b319155696
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/BetaFeatures
Gerrit-Branch: master
Gerrit-Owner: Jforrester 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki/core[wmf/1.31.0-wmf.17]: EditPage: Update Save/Publish button flag from 'constructive...

[Jforrester (Code Review)]

Jforrester has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/404733 )

Change subject: EditPage: Update Save/Publish button flag from 'constructive' 
to 'progressive'
..

EditPage: Update Save/Publish button flag from 'constructive' to 'progressive'

OOUI 'constructive' flag was removed in OOUI v0.25.0.

Change-Id: I751d45cca3919dcf67b79bc1de6a085ea018bf58
(cherry picked from commit 656a2efcc2f4495b09a5d34b8980398690767db4)
---
M includes/EditPage.php
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core 
refs/changes/33/404733/1

diff --git a/includes/EditPage.php b/includes/EditPage.php
index a41e6d9..62307b6 100644
--- a/includes/EditPage.php
+++ b/includes/EditPage.php
@@ -4405,7 +4405,7 @@
'inputId' => 'wpSave',
// Support: IE 6 – Use , otherwise it can't 
distinguish which button was clicked
'useInputTag' => true,
-   'flags' => [ 'constructive', 'primary' ],
+   'flags' => [ 'progressive', 'primary' ],
'label' => $buttonLabel,
'infusable' => true,
'type' => 'submit',

-- 
To view, visit https://gerrit.wikimedia.org/r/404733
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I751d45cca3919dcf67b79bc1de6a085ea018bf58
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: wmf/1.31.0-wmf.17
Gerrit-Owner: Jforrester 
Gerrit-Reviewer: Bartosz Dziewoński 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...Translate[master]: Replace use of OOUI deprecated constructive flag

[Jforrester (Code Review)]

Jforrester has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/404732 )

Change subject: Replace use of OOUI deprecated constructive flag
..

Replace use of OOUI deprecated constructive flag

Change-Id: I665e50fe0e1fcbed6a98f3b6a7b756d394e5210b
---
M TranslateEditAddons.php
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Translate 
refs/changes/32/404732/1

diff --git a/TranslateEditAddons.php b/TranslateEditAddons.php
index b5269c8..0da518e 100644
--- a/TranslateEditAddons.php
+++ b/TranslateEditAddons.php
@@ -132,7 +132,7 @@
$buttons['save'] = new OOUI\ButtonInputWidget( [
// Support: IE 6 – Use , 
otherwise it can't distinguish which button was clicked
'useInputTag' => true,
-   'flags' => [ 'constructive', 'primary' 
],
+   'flags' => [ 'progressive', 'primary' ],
'label' => $context->msg( 
'translate-save', $name )->text(),
'type' => 'submit',
] + $saveConfig );

-- 
To view, visit https://gerrit.wikimedia.org/r/404732
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I665e50fe0e1fcbed6a98f3b6a7b756d394e5210b
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Translate
Gerrit-Branch: master
Gerrit-Owner: Jforrester 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...SemanticLinks[master]: Replace use of OOUI deprecated constructive flag

[Jforrester (Code Review)]

Jforrester has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/404731 )

Change subject: Replace use of OOUI deprecated constructive flag
..

Replace use of OOUI deprecated constructive flag

Change-Id: Ib2a215854b808b8c2ce80601e9aed1661830b96b
---
M modules/VELinkTyping.js
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/SemanticLinks 
refs/changes/31/404731/1

diff --git a/modules/VELinkTyping.js b/modules/VELinkTyping.js
index dc2972a..a4f5bc9 100644
--- a/modules/VELinkTyping.js
+++ b/modules/VELinkTyping.js
@@ -314,7 +314,7 @@
 {
 'action': 'insert',
 'label': mw.msg( 've-SMWAnnotationDialog-insert' ),
-'flags': [ 'constructive' ],
+'flags': [ 'progressive' ],
 'modes': 'insert'
 },
 {

-- 
To view, visit https://gerrit.wikimedia.org/r/404731
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib2a215854b808b8c2ce80601e9aed1661830b96b
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/SemanticLinks
Gerrit-Branch: master
Gerrit-Owner: Jforrester 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...QuizGame[master]: Replace use of OOUI deprecated constructive flag

[Jforrester (Code Review)]

Jforrester has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/404730 )

Change subject: Replace use of OOUI deprecated constructive flag
..

Replace use of OOUI deprecated constructive flag

Change-Id: Iaddcc38617ed0489e3067db268afb2ef5383691d
---
M resources/js/QuizGame.js
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/QuizGame 
refs/changes/30/404730/1

diff --git a/resources/js/QuizGame.js b/resources/js/QuizGame.js
index f2440e1..9a7270e 100644
--- a/resources/js/QuizGame.js
+++ b/resources/js/QuizGame.js
@@ -83,7 +83,7 @@
var options = {
actions: [
{ label: mw.msg( 'cancel' ) },
-   { label: mw.msg( 'quizgame-unflag' ), action: 
'accept', flags: ['constructive', 'primary'] }
+   { label: mw.msg( 'quizgame-unflag' ), action: 
'accept', flags: ['progressive', 'primary'] }
]
};
OO.ui.confirm( mw.msg( 'quizgame-unflag-confirm' ), options 
).done( function ( confirmed ) {

-- 
To view, visit https://gerrit.wikimedia.org/r/404730
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Iaddcc38617ed0489e3067db268afb2ef5383691d
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/QuizGame
Gerrit-Branch: master
Gerrit-Owner: Jforrester 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...QuickSurveys[master]: Replace use of OOUI deprecated constructive flag

[Jforrester (Code Review)]

Jforrester has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/404729 )

Change subject: Replace use of OOUI deprecated constructive flag
..

Replace use of OOUI deprecated constructive flag

Change-Id: Id443d2ecffa53c401d7601bb948b641690a2cac3
---
M resources/ext.quicksurveys.views/ExternalSurvey.js
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/QuickSurveys 
refs/changes/29/404729/1

diff --git a/resources/ext.quicksurveys.views/ExternalSurvey.js 
b/resources/ext.quicksurveys.views/ExternalSurvey.js
index c4fbf88..01ebe1a 100644
--- a/resources/ext.quicksurveys.views/ExternalSurvey.js
+++ b/resources/ext.quicksurveys.views/ExternalSurvey.js
@@ -33,7 +33,7 @@
href: btnHref.toString(),
target: '_blank',
label: mw.msg( 
'ext-quicksurveys-external-survey-yes-button' ),
-   flags: 'constructive',
+   flags: 'progressive',
data: {
answer: 
'ext-quicksurveys-external-survey-yes-button'
}

-- 
To view, visit https://gerrit.wikimedia.org/r/404729
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Id443d2ecffa53c401d7601bb948b641690a2cac3
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/QuickSurveys
Gerrit-Branch: master
Gerrit-Owner: Jforrester 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...MultiLanguageManager[master]: Replace use of OOUI deprecated constructive flag

[Jforrester (Code Review)]

Jforrester has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/404728 )

Change subject: Replace use of OOUI deprecated constructive flag
..

Replace use of OOUI deprecated constructive flag

Change-Id: I5acdeb4f743818b92155a0b20661cd3861d3
---
M resources/ext.mlm.js
1 file changed, 2 insertions(+), 2 deletions(-)


  git pull 
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/MultiLanguageManager 
refs/changes/28/404728/1

diff --git a/resources/ext.mlm.js b/resources/ext.mlm.js
index ef59c91..d6e456e 100644
--- a/resources/ext.mlm.js
+++ b/resources/ext.mlm.js
@@ -53,7 +53,7 @@
mw.mlm.dialog.static.actions = [{
action: 'save',
label: mw.message( 'mlm-input-label-save' ).plain(),
-   flags: [ 'primary', 'constructive' ]
+   flags: [ 'primary', 'progressive' ]
}, {
action: 'cancel',
label: mw.message( 'mlm-input-label-cancel' ).plain(),
@@ -136,7 +136,7 @@
});
this.translationAdd = new OO.ui.ButtonWidget( {
label: mw.message( 'mlm-input-label-add' 
).plain(),
-   flags: [ 'primary', 'constructive' ]
+   flags: [ 'primary', 'progressive' ]
});
 
var me = this;

-- 
To view, visit https://gerrit.wikimedia.org/r/404728
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I5acdeb4f743818b92155a0b20661cd3861d3
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/MultiLanguageManager
Gerrit-Branch: master
Gerrit-Owner: Jforrester 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...ForcePreview[master]: Replace use of OOUI deprecated constructive flag

[Jforrester (Code Review)]

Jforrester has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/404726 )

Change subject: Replace use of OOUI deprecated constructive flag
..

Replace use of OOUI deprecated constructive flag

Change-Id: I0d7688f4e73e5647caad3dc2075dd47e3dcc32bf
---
M modules/ext.ForcePreview.livePreview.js
1 file changed, 2 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/ForcePreview 
refs/changes/26/404726/1

diff --git a/modules/ext.ForcePreview.livePreview.js 
b/modules/ext.ForcePreview.livePreview.js
index f47596e..cbb235e 100644
--- a/modules/ext.ForcePreview.livePreview.js
+++ b/modules/ext.ForcePreview.livePreview.js
@@ -15,11 +15,11 @@
}
 
preview.on( "click", function enableSave() {
-   save.setFlags( { primary: true, constructive: true } )
+   save.setFlags( { primary: true, progressive: true } )
.setDisabled( false )
.setLabel( OO.ui.msg( message ) );
 
-   preview.setFlags( { primary: false, constructive: false } )
+   preview.setFlags( { primary: false, progressive: false } )
.off( "click", enableSave );
} );
 } );

-- 
To view, visit https://gerrit.wikimedia.org/r/404726
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I0d7688f4e73e5647caad3dc2075dd47e3dcc32bf
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/ForcePreview
Gerrit-Branch: master
Gerrit-Owner: Jforrester 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...SpellingDictionary[master]: Replace use of OOUI deprecated constructive flag

[Jforrester (Code Review)]

Jforrester has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/404725 )

Change subject: Replace use of OOUI deprecated constructive flag
..

Replace use of OOUI deprecated constructive flag

Change-Id: I44dcd6c574e2e557cd106f5af32ca8446c024d89
---
M modules/ext.SpellingDictionary.submitWord.js
M modules/ext.SpellingDictionary.viewByLanguage.js
2 files changed, 2 insertions(+), 2 deletions(-)


  git pull 
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/SpellingDictionary 
refs/changes/25/404725/1

diff --git a/modules/ext.SpellingDictionary.submitWord.js 
b/modules/ext.SpellingDictionary.submitWord.js
index 3ab977a..8adf083 100644
--- a/modules/ext.SpellingDictionary.submitWord.js
+++ b/modules/ext.SpellingDictionary.submitWord.js
@@ -16,7 +16,7 @@
} );
var submitButton = new OO.ui.ButtonInputWidget( {
label: mw.message( 'add-word-form-submit' ).text(),
-   flags: [ 'constructive', 'primary'],
+   flags: [ 'progressive', 'primary'],
indicator: 'next',
type: 'submit'
} );
diff --git a/modules/ext.SpellingDictionary.viewByLanguage.js 
b/modules/ext.SpellingDictionary.viewByLanguage.js
index 60629da..2982461 100644
--- a/modules/ext.SpellingDictionary.viewByLanguage.js
+++ b/modules/ext.SpellingDictionary.viewByLanguage.js
@@ -14,7 +14,7 @@
} );
var submitButton = new OO.ui.ButtonInputWidget( {
label: mw.message( 'sd-admin-view-selected-language' ).text(),
-   flags: [ 'constructive', 'primary' ],
+   flags: [ 'progressive', 'primary' ],
indicator: 'next',
type: 'submit'
} );

-- 
To view, visit https://gerrit.wikimedia.org/r/404725
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I44dcd6c574e2e557cd106f5af32ca8446c024d89
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/SpellingDictionary
Gerrit-Branch: master
Gerrit-Owner: Jforrester 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...CollaborationKit[master]: Replace use of OOUI deprecated constructive flag

[Jforrester (Code Review)]

Jforrester has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/404724 )

Change subject: Replace use of OOUI deprecated constructive flag
..

Replace use of OOUI deprecated constructive flag

Change-Id: I8a5424e54ff4b2363590cbfde8235b1daa0e644d
---
M modules/ext.CollaborationKit.list.members.js
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull 
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/CollaborationKit 
refs/changes/24/404724/1

diff --git a/modules/ext.CollaborationKit.list.members.js 
b/modules/ext.CollaborationKit.list.members.js
index 9dd1bf3..9b2cc6c 100644
--- a/modules/ext.CollaborationKit.list.members.js
+++ b/modules/ext.CollaborationKit.list.members.js
@@ -120,7 +120,7 @@
new OO.ui.ButtonWidget( {
label: mw.msg( 
'collaborationkit-list-add-self' ),
icon: 'add',
-   flags: [ 
'constructive', 'primary' ]
+   flags: [ 'progressive', 
'primary' ]
} ).on( 'click', addSelf )
.$element
)

-- 
To view, visit https://gerrit.wikimedia.org/r/404724
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I8a5424e54ff4b2363590cbfde8235b1daa0e644d
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/CollaborationKit
Gerrit-Branch: master
Gerrit-Owner: Jforrester 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...OOJsUIAjaxLogin[master]: Replace use of OOUI deprecated constructive flag

[Jforrester (Code Review)]

Jforrester has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/404723 )

Change subject: Replace use of OOUI deprecated constructive flag
..

Replace use of OOUI deprecated constructive flag

Change-Id: I9d2f54831dfa03b8e33a4ee0d11c4e90906601a8
---
M resources/ext.OOJsUIAjaxLogin.overlay/LoginOverlay.js
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull 
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/OOJsUIAjaxLogin 
refs/changes/23/404723/1

diff --git a/resources/ext.OOJsUIAjaxLogin.overlay/LoginOverlay.js 
b/resources/ext.OOJsUIAjaxLogin.overlay/LoginOverlay.js
index a8f9521..e1762f8 100644
--- a/resources/ext.OOJsUIAjaxLogin.overlay/LoginOverlay.js
+++ b/resources/ext.OOJsUIAjaxLogin.overlay/LoginOverlay.js
@@ -43,7 +43,7 @@
{
action: 'login',
label: mw.msg( 'pt-login-button' ),
-   flags: [ 'primary', 'constructive' ]
+   flags: [ 'primary', 'progressive' ]
},
{
action: 'register',

-- 
To view, visit https://gerrit.wikimedia.org/r/404723
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I9d2f54831dfa03b8e33a4ee0d11c4e90906601a8
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/OOJsUIAjaxLogin
Gerrit-Branch: master
Gerrit-Owner: Jforrester 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...MultimediaViewer[master]: doc: Update comment about OOUI constructive state, now gone

[Jforrester (Code Review)]

Jforrester has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/404722 )

Change subject: doc: Update comment about OOUI constructive state, now gone
..

doc: Update comment about OOUI constructive state, now gone

Change-Id: I634e8384b726450bafbb6a6ad32e4e002f644792
---
M resources/mmv/ui/mmv.ui.download.pane.js
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull 
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/MultimediaViewer 
refs/changes/22/404722/1

diff --git a/resources/mmv/ui/mmv.ui.download.pane.js 
b/resources/mmv/ui/mmv.ui.download.pane.js
index d7fd273..7c7ecb7 100644
--- a/resources/mmv/ui/mmv.ui.download.pane.js
+++ b/resources/mmv/ui/mmv.ui.download.pane.js
@@ -81,7 +81,7 @@
 * @param {jQuery} $container
 */
DP.createDownloadButton = function ( $container ) {
-   // TODO:  Use oojs-ui constructive button widget instead
+   // TODO: Use OOUI progressive button widget instead
this.$downloadButton = $( '' )
.attr( 'target', '_blank' )
.attr( 'download', '' )

-- 
To view, visit https://gerrit.wikimedia.org/r/404722
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I634e8384b726450bafbb6a6ad32e4e002f644792
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/MultimediaViewer
Gerrit-Branch: master
Gerrit-Owner: Jforrester 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] VisualEditor/VisualEditor[master]: OOUI: Manually pull in fix from I99caad7b ahead of the relea...

[Jforrester (Code Review)]

Jforrester has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/404597 )

Change subject: OOUI: Manually pull in fix from I99caad7b ahead of the release 
cycle
..

OOUI: Manually pull in fix from I99caad7b ahead of the release cycle

The .map file will be wrong, but those aren't used, so oh well.

Change-Id: Ic9a6a20541b2f5f1268dd1cf48f767877d2781d4
---
M lib/oojs-ui/oojs-ui-toolbars.js
1 file changed, 2 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/VisualEditor/VisualEditor 
refs/changes/97/404597/1

diff --git a/lib/oojs-ui/oojs-ui-toolbars.js b/lib/oojs-ui/oojs-ui-toolbars.js
index 59d6474..1b57f09 100644
--- a/lib/oojs-ui/oojs-ui-toolbars.js
+++ b/lib/oojs-ui/oojs-ui-toolbars.js
@@ -1978,7 +1978,7 @@
this.$element.addClass( 'oo-ui-popupToolGroup-active 
oo-ui-popupToolGroup-left' );
this.setFlags( { progressive: true } );
this.toggleClipping( true );
-   if ( this.isClippedHorizontally() || 
this.isFloatableOutOfView() ) {
+   if ( this.isClippedHorizontally() ) {
// Anchoring to the left caused the popup to 
clip, so anchor it to the right instead
this.toggleClipping( false );
this.$element
@@ -1986,7 +1986,7 @@
.addClass( 'oo-ui-popupToolGroup-right' 
);
this.toggleClipping( true );
}
-   if ( this.isClippedHorizontally() || 
this.isFloatableOutOfView() ) {
+   if ( this.isClippedHorizontally() ) {
// Anchoring to the right also caused the popup 
to clip, so just make it fill the container
containerWidth = 
this.$clippableScrollableContainer.width();
containerLeft = 
this.$clippableScrollableContainer[ 0 ] === document.documentElement ?

-- 
To view, visit https://gerrit.wikimedia.org/r/404597
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic9a6a20541b2f5f1268dd1cf48f767877d2781d4
Gerrit-PatchSet: 1
Gerrit-Project: VisualEditor/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Jforrester 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...VisualEditor[master]: Update VE core submodule to master (d5428e9b3)

[Jforrester (Code Review)]

Jforrester has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/404513 )

Change subject: Update VE core submodule to master (d5428e9b3)
..

Update VE core submodule to master (d5428e9b3)

New changes:
d837033c2 Use findItemFromData instead getItemFromData
c656fb267 Localisation updates from https://translatewiki.net.
5cbaf0674 Catch errors when accessing localStorage
d5428e9b3 Localisation updates from https://translatewiki.net.

Bug: T181822
Bug: T76630
Change-Id: I5b02898ed020cf2fc3bd93a650870bd3ab7b31b0
---
M lib/ve
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/VisualEditor 
refs/changes/13/404513/1

diff --git a/lib/ve b/lib/ve
index bfa92c6..d5428e9 16
--- a/lib/ve
+++ b/lib/ve
@@ -1 +1 @@
-Subproject commit bfa92c6e93ccc016747bede1c871cc9dc337a748
+Subproject commit d5428e9b346bb3b9bf5e043efae6078d8a55c683

-- 
To view, visit https://gerrit.wikimedia.org/r/404513
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I5b02898ed020cf2fc3bd93a650870bd3ab7b31b0
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Jforrester 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] VisualEditor/VisualEditor[master]: build: Bump stylelint and config, and make pass

[Jforrester (Code Review)]

Jforrester has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/403960 )

Change subject: build: Bump stylelint and config, and make pass
..

build: Bump stylelint and config, and make pass

stylelint   7.8.0  →  8.2.0
stylelint-config-wikimedia  0.4.1  →  0.4.2

Change-Id: I61a97c00ccf82eee1a6a8025a456252540a9da64
---
M package.json
M src/ui/styles/dialogs/ve.ui.CommandHelpDialog.css
M src/ui/styles/elements/ve.ui.DiffElement.css
3 files changed, 48 insertions(+), 48 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/VisualEditor/VisualEditor 
refs/changes/60/403960/1

diff --git a/package.json b/package.json
index 1870110..c4d15b4 100644
--- a/package.json
+++ b/package.json
@@ -42,7 +42,7 @@
 "karma-mocha-reporter": "2.2.5",
 "karma-qunit": "1.2.1",
 "qunitjs": "2.4.1",
-"stylelint": "7.8.0",
-"stylelint-config-wikimedia": "0.4.1"
+"stylelint": "8.2.0",
+"stylelint-config-wikimedia": "0.4.2"
   }
 }
diff --git a/src/ui/styles/dialogs/ve.ui.CommandHelpDialog.css 
b/src/ui/styles/dialogs/ve.ui.CommandHelpDialog.css
index 63b2d37..11a792a 100644
--- a/src/ui/styles/dialogs/ve.ui.CommandHelpDialog.css
+++ b/src/ui/styles/dialogs/ve.ui.CommandHelpDialog.css
@@ -83,7 +83,7 @@
text-align: center;
 }
 
-.ve-ui-commandHelpDialog-list dt kbd[data-label]:before {
+.ve-ui-commandHelpDialog-list dt kbd[ data-label ]:before {
content: attr( data-label );
font-weight: normal;
font-style: italic;
diff --git a/src/ui/styles/elements/ve.ui.DiffElement.css 
b/src/ui/styles/elements/ve.ui.DiffElement.css
index 8c59e33..129a3a9 100644
--- a/src/ui/styles/elements/ve.ui.DiffElement.css
+++ b/src/ui/styles/elements/ve.ui.DiffElement.css
@@ -63,85 +63,85 @@
overflow-wrap: break-word;
 }
 
-[data-diff-action='insert'],
-[data-diff-action='insert'] > ins,
-[data-diff-action='remove'],
-[data-diff-action='change-insert'],
-[data-diff-action='change-remove'] {
+[ data-diff-action='insert' ],
+[ data-diff-action='insert' ] > ins,
+[ data-diff-action='remove' ],
+[ data-diff-action='change-insert' ],
+[ data-diff-action='change-remove' ] {
text-decoration: inherit;
 }
 
-ins[data-diff-action='insert'],
-[data-diff-action='insert'] > ins,
-del[data-diff-action='remove'],
-[data-diff-action='remove'] > del {
+ins[ data-diff-action='insert' ],
+[ data-diff-action='insert' ] > ins,
+del[ data-diff-action='remove' ],
+[ data-diff-action='remove' ] > del {
white-space: pre-wrap;
 }
 
-[data-diff-action='insert'],
+[ data-diff-action='insert' ],
 /* elements using display:table-caption need separate backgrounds */
-table[data-diff-action='insert'] > caption,
-figure[data-diff-action='insert'] > figcaption {
+table[ data-diff-action='insert' ] > caption,
+figure[ data-diff-action='insert' ] > figcaption {
background-color: #7fd7c4 !important; /* stylelint-disable-line 
declaration-no-important */
box-shadow: 0 0 0 1px #7fd7c4;
 }
 
-[data-diff-action='remove'],
+[ data-diff-action='remove' ],
 /* elements using display:table-caption need separate backgrounds */
-table[data-diff-action='remove'] > caption,
-figure[data-diff-action='remove'] > figcaption {
+table[ data-diff-action='remove' ] > caption,
+figure[ data-diff-action='remove' ] > figcaption {
background-color: #e88e89 !important; /* stylelint-disable-line 
declaration-no-important */
box-shadow: 0 0 0 1px #e88e89;
 }
 
-[data-diff-action='change'],
-[data-diff-action='change-insert'] {
+[ data-diff-action='change' ],
+[ data-diff-action='change-insert' ] {
background-color: #b6d4fb !important; /* stylelint-disable-line 
declaration-no-important */
box-shadow: 0 0 0 1px #b6d4fb;
 }
 
-[data-diff-action='change-remove'] {
+[ data-diff-action='change-remove' ] {
display: none;
 }
 
-del[data-diff-action='remove'],
-[data-diff-action='remove'] > del {
+del[ data-diff-action='remove' ],
+[ data-diff-action='remove' ] > del {
text-decoration: line-through;
 }
 
-del[data-diff-action='remove']:hover,
-[data-diff-action='remove']:hover > del {
+del[ data-diff-action='remove' ]:hover,
+[ data-diff-action='remove' ]:hover > del {
text-decoration: none;
 }
 
-[data-diff-action='insert'] [rel='ve:Comment'],
-[data-diff-action='remove'] [rel='ve:Comment'],
-[data-diff-action='change-insert'] [rel='ve:Comment'],
-[data-diff-action='change-remove'] [rel='ve:Comment'] {
+[ data-diff-action='insert' ] [ rel='ve:Comment' ],
+[ data-diff-action='remove' ] [ rel='ve:Comment' ],
+[ data-diff-action='change-insert' ] [ rel='ve:Comment' ],
+[ data-diff-action='change-remove' ] [ rel='ve:Comment' ] {
display: inline-block;
width: 1em;
 }
 
 /* TODO: These sibling selectors still match when there is a text node 
in-between, should be fixed in JS */
-[data-diff-action='remove'] + [data-diff-action='insert'],

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: OOUI: Manually pull in fix from I99caad7b ahead of the relea...

[Jforrester (Code Review)]

Jforrester has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/403949 )

Change subject: OOUI: Manually pull in fix from I99caad7b ahead of the release 
cycle
..

OOUI: Manually pull in fix from I99caad7b ahead of the release cycle

The .map file will be wrong, but those aren't used outside of an
experimental branch yet, so it's not the end of the world.

Bug: T184665
Change-Id: I9ff1ed80496ec61b836de4221dd36cde6d4a71ac
---
M resources/lib/oojs-ui/oojs-ui-toolbars.js
1 file changed, 2 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core 
refs/changes/49/403949/1

diff --git a/resources/lib/oojs-ui/oojs-ui-toolbars.js 
b/resources/lib/oojs-ui/oojs-ui-toolbars.js
index 59d6474..1b57f09 100644
--- a/resources/lib/oojs-ui/oojs-ui-toolbars.js
+++ b/resources/lib/oojs-ui/oojs-ui-toolbars.js
@@ -1978,7 +1978,7 @@
this.$element.addClass( 'oo-ui-popupToolGroup-active 
oo-ui-popupToolGroup-left' );
this.setFlags( { progressive: true } );
this.toggleClipping( true );
-   if ( this.isClippedHorizontally() || 
this.isFloatableOutOfView() ) {
+   if ( this.isClippedHorizontally() ) {
// Anchoring to the left caused the popup to 
clip, so anchor it to the right instead
this.toggleClipping( false );
this.$element
@@ -1986,7 +1986,7 @@
.addClass( 'oo-ui-popupToolGroup-right' 
);
this.toggleClipping( true );
}
-   if ( this.isClippedHorizontally() || 
this.isFloatableOutOfView() ) {
+   if ( this.isClippedHorizontally() ) {
// Anchoring to the right also caused the popup 
to clip, so just make it fill the container
containerWidth = 
this.$clippableScrollableContainer.width();
containerLeft = 
this.$clippableScrollableContainer[ 0 ] === document.documentElement ?

-- 
To view, visit https://gerrit.wikimedia.org/r/403949
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I9ff1ed80496ec61b836de4221dd36cde6d4a71ac
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Jforrester 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...MinervaNeue[master]: Remove reference to mw-editButtons-pipe-separator, now remov...

[Jforrester (Code Review)]

Jforrester has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/403549 )

Change subject: Remove reference to mw-editButtons-pipe-separator, now removed 
from MW
..

Remove reference to mw-editButtons-pipe-separator, now removed from MW

Change-Id: I59d34dfdd13122db0229ce40909d66d88bdd8d65
---
M skinStyles/mediawiki.action.edit.styles/minerva.less
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/skins/MinervaNeue 
refs/changes/49/403549/1

diff --git a/skinStyles/mediawiki.action.edit.styles/minerva.less 
b/skinStyles/mediawiki.action.edit.styles/minerva.less
index d3fdb20..cfd634d 100644
--- a/skinStyles/mediawiki.action.edit.styles/minerva.less
+++ b/skinStyles/mediawiki.action.edit.styles/minerva.less
@@ -5,7 +5,7 @@
border: 1px solid @colorGray12;
 }
 
-.editHelp, .cancelLink, .mw-editButtons-pipe-separator {
+.editHelp, .cancelLink {
display: none;
 }
 

-- 
To view, visit https://gerrit.wikimedia.org/r/403549
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I59d34dfdd13122db0229ce40909d66d88bdd8d65
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/skins/MinervaNeue
Gerrit-Branch: master
Gerrit-Owner: Jforrester 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...CodeEditor[master]: Remove reference to mw-editButtons-pipe-separator, now remov...

[Jforrester (Code Review)]

Jforrester has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/403548 )

Change subject: Remove reference to mw-editButtons-pipe-separator, now removed 
from MW
..

Remove reference to mw-editButtons-pipe-separator, now removed from MW

Change-Id: Ia214c25b1ca65f6998da9de0949034829d9959d5
---
M modules/jquery.codeEditor.less
1 file changed, 1 insertion(+), 2 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/CodeEditor 
refs/changes/48/403548/1

diff --git a/modules/jquery.codeEditor.less b/modules/jquery.codeEditor.less
index 98aabb3..5112f5b 100644
--- a/modules/jquery.codeEditor.less
+++ b/modules/jquery.codeEditor.less
@@ -122,8 +122,7 @@
 /* Hide vanilla MediaWiki's "Editing help" link, as we provide it in the 
toolbar */
 /* Copied from the same code in WikiEditor */
 .client-js .editButtons {
-   .editHelp,
-   .mw-editButtons-pipe-separator {
+   .editHelp {
display: none;
}
 }

-- 
To view, visit https://gerrit.wikimedia.org/r/403548
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia214c25b1ca65f6998da9de0949034829d9959d5
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/CodeEditor
Gerrit-Branch: master
Gerrit-Owner: Jforrester 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...WikiEditor[master]: Remove reference to mw-editButtons-pipe-separator, now remov...

[Jforrester (Code Review)]

Jforrester has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/403547 )

Change subject: Remove reference to mw-editButtons-pipe-separator, now removed 
from MW
..

Remove reference to mw-editButtons-pipe-separator, now removed from MW

Change-Id: I50aeda4aee2dae8094ae19bdc6fb0c64425c3e14
---
M modules/ext.wikiEditor.toolbar.styles.less
1 file changed, 1 insertion(+), 2 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/WikiEditor 
refs/changes/47/403547/1

diff --git a/modules/ext.wikiEditor.toolbar.styles.less 
b/modules/ext.wikiEditor.toolbar.styles.less
index 016a56c..da93bfa 100644
--- a/modules/ext.wikiEditor.toolbar.styles.less
+++ b/modules/ext.wikiEditor.toolbar.styles.less
@@ -4,8 +4,7 @@
 
 /* Hide vanilla MediaWiki's "Editing help" link, as we provide it in the 
toolbar */
 .client-js .editButtons {
-   .editHelp,
-   .mw-editButtons-pipe-separator {
+   .editHelp {
display: none;
}
 }

-- 
To view, visit https://gerrit.wikimedia.org/r/403547
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I50aeda4aee2dae8094ae19bdc6fb0c64425c3e14
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/WikiEditor
Gerrit-Branch: master
Gerrit-Owner: Jforrester 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...VisualEditor[master]: Update VE core submodule to master (bfa92c6e9)

[Jforrester (Code Review)]

Jforrester has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/403429 )

Change subject: Update VE core submodule to master (bfa92c6e9)
..

Update VE core submodule to master (bfa92c6e9)

New changes:
f88d8d4a9 Localisation updates from https://translatewiki.net.
bfa92c6e9 Update OOUI to v0.25.0

Change-Id: I7e790290354a76e5bce0a7caf18dac56a5787922
---
M lib/ve
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/VisualEditor 
refs/changes/29/403429/1

diff --git a/lib/ve b/lib/ve
index b04645a..bfa92c6 16
--- a/lib/ve
+++ b/lib/ve
@@ -1 +1 @@
-Subproject commit b04645ac8c39f412f2b3300ef8629f1624c4837e
+Subproject commit bfa92c6e93ccc016747bede1c871cc9dc337a748

-- 
To view, visit https://gerrit.wikimedia.org/r/403429
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I7e790290354a76e5bce0a7caf18dac56a5787922
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Jforrester 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Follow-up 8a7fb8577: For deprecated RL modules, allow strings

[Jforrester (Code Review)]

Jforrester has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/403079 )

Change subject: Follow-up 8a7fb8577: For deprecated RL modules, allow strings
..

Follow-up 8a7fb8577: For deprecated RL modules, allow strings

So that more than just PHP code and MediaWiki core can use it, but
also JSON-based static extension registrations. :-)

Change-Id: If22fccbb43c5b05db2a666d61ae8864ee9815e7d
---
M docs/extension.schema.v1.json
M docs/extension.schema.v2.json
2 files changed, 4 insertions(+), 4 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core 
refs/changes/79/403079/1

diff --git a/docs/extension.schema.v1.json b/docs/extension.schema.v1.json
index ddf82e8..0763e7d 100644
--- a/docs/extension.schema.v1.json
+++ b/docs/extension.schema.v1.json
@@ -210,8 +210,8 @@

"description": "Group which this module should be loaded together with"
},
"deprecated": {
-   "type": 
["object", "boolean"],
-   
"description": "Whether the module is deprecated and usage is discouraged. 
Either a boolean or an object with key message can be used to customise 
deprecation message."
+   "type": 
["object", "string", "boolean"],
+   
"description": "Whether the module is deprecated and usage is discouraged. 
Either a boolean, or a string or an object with key message can be used to 
customise deprecation message."
},
"position": {
"type": 
"string",
diff --git a/docs/extension.schema.v2.json b/docs/extension.schema.v2.json
index 0bdf97d..51f9417 100644
--- a/docs/extension.schema.v2.json
+++ b/docs/extension.schema.v2.json
@@ -211,8 +211,8 @@

"description": "Group with which this module should be loaded"
},
"deprecated": {
-   "type": 
["object", "boolean"],
-   
"description": "Whether the module is deprecated and usage is discouraged. 
Either a boolean or an object with key message can be used to customise 
deprecation message."
+   "type": 
["object", "string", "boolean"],
+   
"description": "Whether the module is deprecated and usage is discouraged. 
Either a boolean, or a string or an object with key message can be used to 
customise deprecation message."
},
"position": {
"type": 
"string",

-- 
To view, visit https://gerrit.wikimedia.org/r/403079
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: If22fccbb43c5b05db2a666d61ae8864ee9815e7d
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Jforrester 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] operations/mediawiki-config[master]: Save -> Publish on remaining Wikinewses which haven't updated

[Jforrester (Code Review)]

Jforrester has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/403077 )

Change subject: Save -> Publish on remaining Wikinewses which haven't updated
..

Save -> Publish on remaining Wikinewses which haven't updated

Originally meant to have been done in August 2016 following 22ba4cced3;
if one of these Wikinewses wants to be like the English/Spanish/etc.
ones, we can switch them back later once they've updated their local
copyright warnings.

Change-Id: I8a022c264d1e8c8ed7de775510ee458b58f9877b
---
M wmf-config/InitialiseSettings.php
1 file changed, 4 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/operations/mediawiki-config 
refs/changes/77/403077/1

diff --git a/wmf-config/InitialiseSettings.php 
b/wmf-config/InitialiseSettings.php
index 3750523..e439573 100644
--- a/wmf-config/InitialiseSettings.php
+++ b/wmf-config/InitialiseSettings.php
@@ -15442,7 +15442,10 @@
 'wgEditSubmitButtonLabelPublish' => [
'default' => true,  // T131132 from 2017-03-15
'private' => false, // Private wikis are not public
-   'wikinews' => false,// Done via local {{int:Copyrightwarning}}s 
instead.
+   'enwikinews' => false,  // Done via local {{int:Copyrightwarning}}s 
instead.
+   'eswikinews' => false,  // Done via local {{int:Copyrightwarning}}s 
instead.
+   'frwikinews' => false,  // Done via local {{int:Copyrightwarning}}s 
instead.
+   'ptwikinews' => false,  // Done via local {{int:Copyrightwarning}}s 
instead.
 ],
 
 'wmgCheckUserForceSummary' => [

-- 
To view, visit https://gerrit.wikimedia.org/r/403077
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I8a022c264d1e8c8ed7de775510ee458b58f9877b
Gerrit-PatchSet: 1
Gerrit-Project: operations/mediawiki-config
Gerrit-Branch: master
Gerrit-Owner: Jforrester 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] oojs/ui[master]: Follow-up Ia2110f71: doc: Correct deprecation version, v0.25...

[Jforrester (Code Review)]

Jforrester has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/403074 )

Change subject: Follow-up Ia2110f71: doc: Correct deprecation version, v0.25.0 
is master
..

Follow-up Ia2110f71: doc: Correct deprecation version, v0.25.0 is master

Change-Id: I2dfa03802740886847a000931fccf11127bc37ad
---
M src/mixins/GroupElement.js
M src/widgets/MultiselectWidget.js
M src/widgets/SelectWidget.js
3 files changed, 5 insertions(+), 5 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/oojs/ui refs/changes/74/403074/1

diff --git a/src/mixins/GroupElement.js b/src/mixins/GroupElement.js
index a807c38..43ddf17 100644
--- a/src/mixins/GroupElement.js
+++ b/src/mixins/GroupElement.js
@@ -87,7 +87,7 @@
 /**
  * Get an item by its data.
  *
- * @deprecated 0.25.1 Use {@link #findItemFromData} instead.
+ * @deprecated Since v0.25.0; use {@link #findItemFromData} instead.
  * @param {Object} data Item data to search for
  * @return {OO.ui.Element|null} Item with equivalent data, `null` if none 
exists
  */
@@ -122,7 +122,7 @@
 /**
  * Find items by their data.
  *
- * @deprecated 0.25.1 Use {@link #findItemsFromData} instead.
+ * @deprecated Since v0.25.0; use {@link #findItemsFromData} instead.
  * @param {Object} data Item data to search for
  * @return {OO.ui.Element[]} Items with equivalent data
  */
diff --git a/src/widgets/MultiselectWidget.js b/src/widgets/MultiselectWidget.js
index 77cb532..f985b7a 100644
--- a/src/widgets/MultiselectWidget.js
+++ b/src/widgets/MultiselectWidget.js
@@ -74,7 +74,7 @@
 /**
  * Get options that are selected.
  *
- * @deprecated 0.25.1 Use {@link #findSelectedItems} instead.
+ * @deprecated Since v0.25.0; use {@link #findSelectedItems} instead.
  * @return {OO.ui.MultioptionWidget[]} Selected options
  */
 OO.ui.MultiselectWidget.prototype.getSelectedItems = function () {
@@ -96,7 +96,7 @@
 /**
  * Get the data of options that are selected.
  *
- * @deprecated 0.25.1 Use {@link #findSelectedItemsData} instead.
+ * @deprecated Since v0.25.0; use {@link #findSelectedItemsData} instead.
  * @return {Object[]|string[]} Values of selected options
  */
 OO.ui.MultiselectWidget.prototype.getSelectedItemsData = function () {
diff --git a/src/widgets/SelectWidget.js b/src/widgets/SelectWidget.js
index 3ce91d3..1f9621d 100644
--- a/src/widgets/SelectWidget.js
+++ b/src/widgets/SelectWidget.js
@@ -541,7 +541,7 @@
 /**
  * Get selected item.
  *
- * @deprecated 0.25.1 Use {@link #findSelectedItem} instead.
+ * @deprecated Since v0.25.0; use {@link #findSelectedItem} instead.
  * @return {OO.ui.OptionWidget|null} Selected item, `null` if no item is 
selected
  */
 OO.ui.SelectWidget.prototype.getSelectedItem = function () {

-- 
To view, visit https://gerrit.wikimedia.org/r/403074
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I2dfa03802740886847a000931fccf11127bc37ad
Gerrit-PatchSet: 1
Gerrit-Project: oojs/ui
Gerrit-Branch: master
Gerrit-Owner: Jforrester 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] oojs/ui[master]: [BREAKING CHANGE] icons: Remove 'arrowLast', deprecated sinc...

[Jforrester (Code Review)]

Jforrester has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/402394 )

Change subject: [BREAKING CHANGE] icons: Remove 'arrowLast', deprecated since 
v0.25.0
..

[BREAKING CHANGE] icons: Remove 'arrowLast', deprecated since v0.25.0

Bug: T183997
Change-Id: I2f3de0e0030dc4eca557666a72c77b5c9c918c4d
---
M src/themes/apex/icons-movement.json
M src/themes/wikimediaui/icons-movement.json
2 files changed, 0 insertions(+), 12 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/oojs/ui refs/changes/94/402394/1

diff --git a/src/themes/apex/icons-movement.json 
b/src/themes/apex/icons-movement.json
index 3e7d80d..a24e0a7 100644
--- a/src/themes/apex/icons-movement.json
+++ b/src/themes/apex/icons-movement.json
@@ -6,12 +6,6 @@
"ltr": "images/icons/arrow-ltr.svg",
"rtl": "images/icons/arrow-rtl.svg"
} },
-   "arrowLast": { "file": {
-   "ltr": "images/icons/arrow-rtl.svg",
-   "rtl": "images/icons/arrow-ltr.svg"
-   },
-   "deprecated": "Renamed since v0.25.0, use 
'arrowPrevious' instead."
-   },
"arrowPrevious": { "file": {
"ltr": "images/icons/arrow-rtl.svg",
"rtl": "images/icons/arrow-ltr.svg"
diff --git a/src/themes/wikimediaui/icons-movement.json 
b/src/themes/wikimediaui/icons-movement.json
index 77d73f9..e737d3b 100644
--- a/src/themes/wikimediaui/icons-movement.json
+++ b/src/themes/wikimediaui/icons-movement.json
@@ -23,12 +23,6 @@
"ltr": "images/icons/arrow-ltr.svg",
"rtl": "images/icons/arrow-rtl.svg"
} },
-   "arrowLast": { "file": {
-   "ltr": "images/icons/arrow-rtl.svg",
-   "rtl": "images/icons/arrow-ltr.svg"
-   },
-   "deprecated": "Renamed since v0.25.0, use 
'arrowPrevious' instead."
-   },
"arrowPrevious": { "file": {
"ltr": "images/icons/arrow-rtl.svg",
"rtl": "images/icons/arrow-ltr.svg"

-- 
To view, visit https://gerrit.wikimedia.org/r/402394
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I2f3de0e0030dc4eca557666a72c77b5c9c918c4d
Gerrit-PatchSet: 1
Gerrit-Project: oojs/ui
Gerrit-Branch: master
Gerrit-Owner: Jforrester 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] oojs/ui[master]: [DEPRECATING CHANGE] icons: Rename 'arrowLast' to 'arrowPrev...

[Jforrester (Code Review)]

Jforrester has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/402393 )

Change subject: [DEPRECATING CHANGE] icons: Rename 'arrowLast' to 
'arrowPrevious'
..

[DEPRECATING CHANGE] icons: Rename 'arrowLast' to 'arrowPrevious'

Bug: T183997
Change-Id: Ia9d4d1e7e63b9076734e4bba22a7a1000f734f8c
---
M demos/pages/icons.js
M src/themes/apex/icons-movement.json
M src/themes/wikimediaui/icons-movement.json
3 files changed, 13 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/oojs/ui refs/changes/93/402393/1

diff --git a/demos/pages/icons.js b/demos/pages/icons.js
index bbe18e6..4551f41 100644
--- a/demos/pages/icons.js
+++ b/demos/pages/icons.js
@@ -2,7 +2,7 @@
var i, len, iconSet, iconsFieldset, iconWidget, selector,
icons = {
movement: [
-   'arrowLast',
+   'arrowPrevious',
'arrowNext',
'downTriangle',
'upTriangle',
diff --git a/src/themes/apex/icons-movement.json 
b/src/themes/apex/icons-movement.json
index 5ecee27..3e7d80d 100644
--- a/src/themes/apex/icons-movement.json
+++ b/src/themes/apex/icons-movement.json
@@ -9,6 +9,12 @@
"arrowLast": { "file": {
"ltr": "images/icons/arrow-rtl.svg",
"rtl": "images/icons/arrow-ltr.svg"
+   },
+   "deprecated": "Renamed since v0.25.0, use 
'arrowPrevious' instead."
+   },
+   "arrowPrevious": { "file": {
+   "ltr": "images/icons/arrow-rtl.svg",
+   "rtl": "images/icons/arrow-ltr.svg"
} },
"collapse": { "file": "images/icons/collapse.svg" },
"downTriangle": { "file": "images/icons/downTriangle.svg" },
diff --git a/src/themes/wikimediaui/icons-movement.json 
b/src/themes/wikimediaui/icons-movement.json
index bea0823..77d73f9 100644
--- a/src/themes/wikimediaui/icons-movement.json
+++ b/src/themes/wikimediaui/icons-movement.json
@@ -26,6 +26,12 @@
"arrowLast": { "file": {
"ltr": "images/icons/arrow-rtl.svg",
"rtl": "images/icons/arrow-ltr.svg"
+   },
+   "deprecated": "Renamed since v0.25.0, use 
'arrowPrevious' instead."
+   },
+   "arrowPrevious": { "file": {
+   "ltr": "images/icons/arrow-rtl.svg",
+   "rtl": "images/icons/arrow-ltr.svg"
} },
"collapse": { "file": "images/icons/collapse.svg" },
"downTriangle": { "file": "images/icons/downTriangle.svg" },

-- 
To view, visit https://gerrit.wikimedia.org/r/402393
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia9d4d1e7e63b9076734e4bba22a7a1000f734f8c
Gerrit-PatchSet: 1
Gerrit-Project: oojs/ui
Gerrit-Branch: master
Gerrit-Owner: Jforrester 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...VisualEditor[master]: Update VE core submodule to master (b04645ac8)

[Jforrester (Code Review)]

Jforrester has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/402079 )

Change subject: Update VE core submodule to master (b04645ac8)
..

Update VE core submodule to master (b04645ac8)

New changes:
3738f1584 ve.ui.TargetWidget: Emit an event to allow last-minute setup
e70e717e0 Update AUTHORS.txt for the last couple of years' work
6393da80b Localisation updates from https://translatewiki.net.

Bug: T157084
Change-Id: Ie2da62d0c06209e5b21c186f1f50be42bbe014d8
---
M lib/ve
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/VisualEditor 
refs/changes/79/402079/1

diff --git a/lib/ve b/lib/ve
index 9d70354..b04645a 16
--- a/lib/ve
+++ b/lib/ve
@@ -1 +1 @@
-Subproject commit 9d7035436b51d4a78554967d8ec9c546de33bee5
+Subproject commit b04645ac8c39f412f2b3300ef8629f1624c4837e

-- 
To view, visit https://gerrit.wikimedia.org/r/402079
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie2da62d0c06209e5b21c186f1f50be42bbe014d8
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Jforrester 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] oojs/ui[master]: Follow-up 49cce4496: Bump package.json version as well for v...

[Jforrester (Code Review)]

Jforrester has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/401802 )

Change subject: Follow-up 49cce4496: Bump package.json version as well for 
v0.24.4
..

Follow-up 49cce4496: Bump package.json version as well for v0.24.4

This way the history release tool selects v0.24.4..v0.25.0 and not
v0.24.3..v0.25.0, which would be a pain.

Change-Id: I997cf78d4550ca4511dfdc6b8d40599f815263ba
---
M package.json
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/oojs/ui refs/changes/02/401802/1

diff --git a/package.json b/package.json
index 0e10483..7ab1775 100644
--- a/package.json
+++ b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "oojs-ui",
-  "version": "0.24.3",
+  "version": "0.24.4",
   "description": "User interface classes built on the OOjs framework.",
   "keywords": [
 "oojs-plugin",

-- 
To view, visit https://gerrit.wikimedia.org/r/401802
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I997cf78d4550ca4511dfdc6b8d40599f815263ba
Gerrit-PatchSet: 1
Gerrit-Project: oojs/ui
Gerrit-Branch: master
Gerrit-Owner: Jforrester 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...VisualEditor[master]: Update VE core submodule to master (9d7035436)

[Jforrester (Code Review)]

Jforrester has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/401787 )

Change subject: Update VE core submodule to master (9d7035436)
..

Update VE core submodule to master (9d7035436)

New changes:
5e96bf362 doc: Bump copyright year
172ac9f0b Convert single nbsp's to plain spaces on paste

Bug: T183647
Change-Id: I8359ccb27deb42f017b411b57658401bc5376f61
---
M lib/ve
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/VisualEditor 
refs/changes/87/401787/1

diff --git a/lib/ve b/lib/ve
index 8c5e78c..9d70354 16
--- a/lib/ve
+++ b/lib/ve
@@ -1 +1 @@
-Subproject commit 8c5e78c7f3d90bb79ef3b462f1629880db639c03
+Subproject commit 9d7035436b51d4a78554967d8ec9c546de33bee5

-- 
To view, visit https://gerrit.wikimedia.org/r/401787
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I8359ccb27deb42f017b411b57658401bc5376f61
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Jforrester 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...VisualEditor[master]: Update AUTHORS.txt for the last couple of years' work

[Jforrester (Code Review)]

Jforrester has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/401788 )

Change subject: Update AUTHORS.txt for the last couple of years' work
..

Update AUTHORS.txt for the last couple of years' work

Not updated since November 2015, whoops! Also added a few
normalisations to the .mailmap file.

Change-Id: I6de4b84bfb34ee1d2ea0b5df4e0f0eb358fd46b6
---
M .mailmap
M AUTHORS.txt
M extension.json
3 files changed, 34 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/VisualEditor 
refs/changes/88/401788/1

diff --git a/.mailmap b/.mailmap
index b924280..21e4d1d 100644
--- a/.mailmap
+++ b/.mailmap
@@ -2,6 +2,7 @@
 Aaron Schulz  
 Alex Monk 
 Alex Monk  
+Alex Monk  
 Alexander Emsenhuber 
 Alexander Emsenhuber  
 Amir E. Aharoni 
@@ -16,6 +17,7 @@
 Brion Vibber  
 C. Scott Ananian 
 C. Scott Ananian  
+Chad Horohoe 
 Chris McMahon 
 Christian Williams 
 Christian Williams  
@@ -42,6 +44,9 @@
 Jon Robson 
 Juliusz Gonera 
 Juliusz Gonera  
+Kunal Mehta 
+Kunal Mehta  
+Kunal Mehta  
 Marielle Volz 
 Mark A. Hershberger 
 Mark A. Hershberger  
diff --git a/AUTHORS.txt b/AUTHORS.txt
index c06a047..d0aca1b 100644
--- a/AUTHORS.txt
+++ b/AUTHORS.txt
@@ -3,6 +3,7 @@
 Alex Monk 
 Bartosz Dziewoński 
 Christian Williams 
+David Lynch 
 Ed Sanders 
 Inez Korczyński 
 James D. Forrester 
@@ -24,17 +25,23 @@
 Andrew Green 
 ankita-ks 
 Antoine Musso 
+Arlo Breault 
 Audrey Tang 
 Brad Jorsch 
 Brion Vibber 
 C. Scott Ananian 
 Carl Fürstenberg 
+cenarium 
+Chad Horohoe 
+Chris McMahon 
 Dan Duvall 
 David Chan 
-David Lynch 
 Derk-Jan Hartman 
+Deskana 
 Douglas Gardner 
+Ebrahim Byagowi 
 ecotg 
+Egbe Eugene 
 Elena Tonkovidova 
 eranroz 
 Erick Guan 
@@ -42,30 +49,43 @@
 Federico Leva 
 Florian 
 Frédéric Bolduc 
+Gabriel Wicke 
+Gergő Tisza 
 Gilles Dubuc 
 Glaisher 
 Helder 
+IvanFon 
 Jamison Lofthouse 
 Jeff Hall 
 Jiabao 
+jo12bar 
 John Du Hart 
 Jon Robson 
 Juliusz Gonera 
+Justin Du 
 Kaity Hammerstein 
 Kunal Mehta 
 Kyle Florence 
+Legoktm 
+Leszek Manicki 
 lokal-profil 
 Marc Ordinas i Llopis 
 Marielle Volz 
+Mark A. Hershberger 
 Mark Holmquist 
 Marko Obrovac 
 Matthew Flaschen 
 Matthias Mullie 
 maurelio 
+Max Semenik 
 mayankmadan 
+Mukunda Modell 
 Neil Kandalgaonkar 
+Nemo bis 
 Niklas Laxström 
+Obaid Raza 
 Ori Livneh 
+Paladox 
 palerdot 
 Pavel Selitskas 
 Peter Coti 
@@ -73,6 +93,7 @@
 Quim Gil 
 rachel99 

[MediaWiki-commits] [Gerrit] VisualEditor/VisualEditor[master]: Update AUTHORS.txt for the last couple of years' work

[Jforrester (Code Review)]

Jforrester has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/401785 )

Change subject: Update AUTHORS.txt for the last couple of years' work
..

Update AUTHORS.txt for the last couple of years' work

Not updated since November 2015, whoops! Also added a few
normalisations to the .mailmap file.

Change-Id: I5c8153e4c06f01550f670ab78967643a6143a13c
---
M .mailmap
M AUTHORS.txt
2 files changed, 19 insertions(+), 4 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/VisualEditor/VisualEditor 
refs/changes/85/401785/1

diff --git a/.mailmap b/.mailmap
index b924280..d72cfd9 100644
--- a/.mailmap
+++ b/.mailmap
@@ -16,6 +16,7 @@
 Brion Vibber  
 C. Scott Ananian 
 C. Scott Ananian  
+Chad Horohoe 
 Chris McMahon 
 Christian Williams 
 Christian Williams  
@@ -28,6 +29,7 @@
 Erik Moeller  
 Florian 
 Florian  

+Frédéric Bolduc 
 Gabriel Wicke 
 Gabriel Wicke  
 Gabriel Wicke  
@@ -42,12 +44,15 @@
 Jon Robson 
 Juliusz Gonera 
 Juliusz Gonera  
+Kunal Mehta 
+Kunal Mehta  
 Marielle Volz 
 Mark A. Hershberger 
 Mark A. Hershberger  
 Mark A. Hershberger  
 Moriel Schottlender 
 Moriel Schottlender  
+Paladox 
 Peter Coti 
 Raimond Spekking 
 Raimond Spekking  
diff --git a/AUTHORS.txt b/AUTHORS.txt
index 424e41b..00bc5a9 100644
--- a/AUTHORS.txt
+++ b/AUTHORS.txt
@@ -1,5 +1,6 @@
 Principal Authors (major contributors, alphabetically)
 
+Bartosz Dziewoński 
 Christian Williams 
 David Chan 
 Ed Sanders 
@@ -19,23 +20,27 @@
 Alexander Emsenhuber 
 Amir E. Aharoni 
 Antoine Musso 
+Arlo Breault 
 Audrey Tang 
-Bartosz Dziewoński 
+Brad Jorsch 
 Brion Vibber 
 C. Scott Ananian 
 Carl Fürstenberg 
+Chad Horohoe 
 Chris McMahon 
 David Lynch 
+Deskana 
 Erick Guan 
 Erik Bernhardson 
 Erik Moeller 
-Florianschmidtwelzow 
-Frédéric Bolduc 
+Florian 
+Frédéric Bolduc 
 Helder 
 Jeff Hall 
 Jiabao 
 John Du Hart 
 Juliusz Gonera 
+Kaartic Sivaraam 
 Kunal Mehta 
 Kyle Florence 
 Mark A. Hershberger 
@@ -43,12 +48,14 @@
 Matthew Flaschen 
 mayankmadan 
 Moriel Schottlender 
+Neil Kandalgaonkar 
 Niklas Laxström 
 Oliver Buchtala 
 Ori Livneh 
-paladox 
+Paladox 
 Pavel Selitskas 
 Peter Coti 
+Prateek Saxena 
 Quim Gil 
 rachel99 
 Raimond Spekking 
@@ -57,9 +64,12 @@
 shirayuki 
 Siebrand Mazeland 
 Steven Zhang 
+Subramanya Sastry 
 Sucheta Ghoshal 
 Thalia Chan 
 Tongbo Sui 
+Umherirrender 
+Volker E 
 Yuki Shira 
 Željko Filipin 
 

-- 
To view, visit https://gerrit.wikimedia.org/r/401785
To unsubscribe, visit 

[MediaWiki-commits] [Gerrit] VisualEditor/VisualEditor[master]: Revert "Comment out broken test after Chrome upgrade"

[Jforrester (Code Review)]

Hello Bartosz Dziewoński, Catrope, Divec, jenkins-bot,

I'd like you to do a code review.  Please visit

https://gerrit.wikimedia.org/r/401764

to review the following change.


Change subject: Revert "Comment out broken test after Chrome upgrade"
..

Revert "Comment out broken test after Chrome upgrade"

This reverts commit 8c5e78c7f3d90bb79ef3b462f1629880db639c03.

[Once RelEng fix CI.]

Change-Id: I1c34012e66a20754e298654a876a67d04dee18f9
---
M tests/ce/ve.ce.Surface.test.js
1 file changed, 2 insertions(+), 8 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/VisualEditor/VisualEditor 
refs/changes/64/401764/1

diff --git a/tests/ce/ve.ce.Surface.test.js b/tests/ce/ve.ce.Surface.test.js
index 31e5be7..419ecdd 100644
--- a/tests/ce/ve.ce.Surface.test.js
+++ b/tests/ce/ve.ce.Surface.test.js
@@ -1430,18 +1430,12 @@
'',
expectedText: 'Foo\n\n',
msg: 'RDFa attributes encoded into 
data-ve-attributes'
-   }
-   /*
-   // Our CI environment uses either Chrome 57 
(mediawiki/extensions/VisualEditor)
-   // or Chrome 63 (VisualEditor/VisualEditor), but they 
produce different results,
-   // so this test will always fail in at least one of 
them.
+   },
{
rangeOrSelection: new ve.Range( 0, 61 ),
-   expectedText: 
'abc\n\nd\n\ne\n\nf\n\ng\n\nhi\nj\n\nk\n\nl\n\nm\n\n', // Chrome 57
-   expectedText: 
'abc\nd\n\ne\n\nf\n\ng\n\nhi\nj\n\nk\n\nl\n\nm\n\n',   // Chrome 63
+   expectedText: 
'abc\nd\n\ne\n\nf\n\ng\n\nhi\nj\n\nk\n\nl\n\nm\n\n',
msg: 'Plain text of entire document'
}
-   */
];
 
function testRunner( doc, rangeOrSelection, expectedData, 
expectedOriginalRange, expectedBalancedRange, expectedHtml, expectedText, msg ) 
{

-- 
To view, visit https://gerrit.wikimedia.org/r/401764
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I1c34012e66a20754e298654a876a67d04dee18f9
Gerrit-PatchSet: 1
Gerrit-Project: VisualEditor/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Jforrester 
Gerrit-Reviewer: Bartosz Dziewoński 
Gerrit-Reviewer: Catrope 
Gerrit-Reviewer: Divec 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...Cite[master]: doc: Bump copyright year

[Jforrester (Code Review)]

Jforrester has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/401646 )

Change subject: doc: Bump copyright year
..

doc: Bump copyright year

Also make the overly-terse statement clearer.

Change-Id: I752bb82444bf7cb41480076bace42331dc35a598
---
M MIT-LICENSE.txt
M includes/CiteCSSFileModule.php
M includes/CiteDataModule.php
M includes/CiteHooks.php
M modules/ve-cite/tests/ve.dm.Converter.test.js
M modules/ve-cite/tests/ve.dm.InternalList.test.js
M modules/ve-cite/tests/ve.dm.Transaction.test.js
M modules/ve-cite/tests/ve.dm.citeExample.js
M modules/ve-cite/tests/ve.ui.MWWikitextStringTransferHandler.test.js
M modules/ve-cite/ve.ce.MWReferenceNode.css
M modules/ve-cite/ve.ce.MWReferenceNode.js
M modules/ve-cite/ve.ce.MWReferencesListNode.css
M modules/ve-cite/ve.ce.MWReferencesListNode.js
M modules/ve-cite/ve.dm.MWReferenceModel.js
M modules/ve-cite/ve.dm.MWReferenceNode.js
M modules/ve-cite/ve.dm.MWReferencesListNode.js
M modules/ve-cite/ve.ui.MWCitationAction.js
M modules/ve-cite/ve.ui.MWCitationContextItem.js
M modules/ve-cite/ve.ui.MWCitationDialog.js
M modules/ve-cite/ve.ui.MWCitationDialogTool.js
M modules/ve-cite/ve.ui.MWReference.init.js
M modules/ve-cite/ve.ui.MWReferenceContextItem.css
M modules/ve-cite/ve.ui.MWReferenceContextItem.js
M modules/ve-cite/ve.ui.MWReferenceDialog.js
M modules/ve-cite/ve.ui.MWReferenceDialogTool.js
M modules/ve-cite/ve.ui.MWReferenceGroupInputWidget.css
M modules/ve-cite/ve.ui.MWReferenceGroupInputWidget.js
M modules/ve-cite/ve.ui.MWReferenceIcons.css
M modules/ve-cite/ve.ui.MWReferenceResultWidget.css
M modules/ve-cite/ve.ui.MWReferenceResultWidget.js
M modules/ve-cite/ve.ui.MWReferenceSearchWidget.css
M modules/ve-cite/ve.ui.MWReferenceSearchWidget.js
M modules/ve-cite/ve.ui.MWReferencesListCommand.js
M modules/ve-cite/ve.ui.MWReferencesListContextItem.js
M modules/ve-cite/ve.ui.MWReferencesListDialog.js
M modules/ve-cite/ve.ui.MWUseExistingReferenceCommand.js
36 files changed, 37 insertions(+), 37 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Cite 
refs/changes/46/401646/1

diff --git a/MIT-LICENSE.txt b/MIT-LICENSE.txt
index a3be0d7..ece90dd 100644
--- a/MIT-LICENSE.txt
+++ b/MIT-LICENSE.txt
@@ -1,5 +1,5 @@
-Copyright (c) 2011-2017 Cite VisualEditor Team and others under the terms
-of The MIT License (MIT), as follows:
+Copyright (c) 2011-2018 VisualEditor Team's Cite sub-team and others
+under the terms of The MIT License (MIT), as follows:
 
 This software consists of voluntary contributions made by many
 individuals (AUTHORS.txt) For exact contribution history, see the
diff --git a/includes/CiteCSSFileModule.php b/includes/CiteCSSFileModule.php
index 245fcf9..68e6e34 100644
--- a/includes/CiteCSSFileModule.php
+++ b/includes/CiteCSSFileModule.php
@@ -3,7 +3,7 @@
 /**
  * ResourceLoaderFileModule for adding the content language Cite CSS
  *
- * @copyright 2011-2017 Cite VisualEditor Team and others; see AUTHORS.txt
+ * @copyright 2011-2018 VisualEditor Team's Cite sub-team and others; see 
AUTHORS.txt
  * @license The MIT License (MIT); see LICENSE.txt
  */
 class CiteCSSFileModule extends ResourceLoaderFileModule {
diff --git a/includes/CiteDataModule.php b/includes/CiteDataModule.php
index 1aa515d..c16bff7 100644
--- a/includes/CiteDataModule.php
+++ b/includes/CiteDataModule.php
@@ -5,7 +5,7 @@
  *
  * Temporary hack for T93800
  *
- * @copyright 2011-2017 Cite VisualEditor Team and others; see AUTHORS.txt
+ * @copyright 2011-2018 VisualEditor Team's Cite sub-team and others; see 
AUTHORS.txt
  * @license The MIT License (MIT); see MIT-LICENSE.txt
  */
 class CiteDataModule extends ResourceLoaderModule {
diff --git a/includes/CiteHooks.php b/includes/CiteHooks.php
index f23e2be..076266c 100644
--- a/includes/CiteHooks.php
+++ b/includes/CiteHooks.php
@@ -1,6 +1,6 @@
 https://gerrit.wikimedia.org/r/401646
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I752bb82444bf7cb41480076bace42331dc35a598
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Cite
Gerrit-Branch: master
Gerrit-Owner: Jforrester 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] unicodejs[master]: doc: Bump copyright year

[Jforrester (Code Review)]

Jforrester has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/401645 )

Change subject: doc: Bump copyright year
..

doc: Bump copyright year

Change-Id: Idd13eaf4b722606ec6282b3ec3acdb19ebe8e861
---
M src/unicodejs.characterclass.js
M src/unicodejs.graphemebreak.js
M src/unicodejs.js
M src/unicodejs.textstring.js
M src/unicodejs.wordbreak.js
M tests/unicodejs.graphemebreak.test.js
M tests/unicodejs.test.js
M tests/unicodejs.wordbreak.test.js
8 files changed, 8 insertions(+), 8 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/unicodejs refs/changes/45/401645/1

diff --git a/src/unicodejs.characterclass.js b/src/unicodejs.characterclass.js
index 3142ccc..9f18251 100644
--- a/src/unicodejs.characterclass.js
+++ b/src/unicodejs.characterclass.js
@@ -3,7 +3,7 @@
  *
  * Support for unicode equivalents of JS regex character classes
  *
- * @copyright 2013–2015 UnicodeJS team and others; see AUTHORS.txt
+ * @copyright 2013–2018 UnicodeJS team and others; see AUTHORS.txt
  * @license The MIT License (MIT); see LICENSE.txt
  */
 ( function () {
diff --git a/src/unicodejs.graphemebreak.js b/src/unicodejs.graphemebreak.js
index 46defeb..f904c15 100644
--- a/src/unicodejs.graphemebreak.js
+++ b/src/unicodejs.graphemebreak.js
@@ -4,7 +4,7 @@
  * Implementation of Unicode 8.0.0 Default Grapheme Cluster Boundary 
Specification
  * http://www.unicode.org/reports/tr29/#Default_Grapheme_Cluster_Table
  *
- * @copyright 2013–2015 UnicodeJS team and others; see AUTHORS.txt
+ * @copyright 2013–2018 UnicodeJS team and others; see AUTHORS.txt
  * @license The MIT License (MIT); see LICENSE.txt
  */
 ( function () {
diff --git a/src/unicodejs.js b/src/unicodejs.js
index cba801c..0593628 100644
--- a/src/unicodejs.js
+++ b/src/unicodejs.js
@@ -1,7 +1,7 @@
 /*!
  * UnicodeJS namespace
  *
- * @copyright 2013–2015 UnicodeJS team and others; see AUTHORS.txt
+ * @copyright 2013-2018 UnicodeJS team and others; see AUTHORS.txt
  * @license The MIT License (MIT); see LICENSE.txt
  */
 
diff --git a/src/unicodejs.textstring.js b/src/unicodejs.textstring.js
index 99246cb..3679942 100644
--- a/src/unicodejs.textstring.js
+++ b/src/unicodejs.textstring.js
@@ -1,7 +1,7 @@
 /*!
  * UnicodeJS TextString class.
  *
- * @copyright 2013–2015 UnicodeJS team and others; see AUTHORS.txt
+ * @copyright 2013-2018 UnicodeJS team and others; see AUTHORS.txt
  * @license The MIT License (MIT); see LICENSE.txt
  */
 
diff --git a/src/unicodejs.wordbreak.js b/src/unicodejs.wordbreak.js
index ea1e0e3..d096b4b 100644
--- a/src/unicodejs.wordbreak.js
+++ b/src/unicodejs.wordbreak.js
@@ -4,7 +4,7 @@
  * Implementation of Unicode 8.0.0 Default Word Boundary Specification
  * http://www.unicode.org/reports/tr29/#Default_Word_Boundaries
  *
- * @copyright 2013–2015 UnicodeJS team and others; see AUTHORS.txt
+ * @copyright 2013-2018 UnicodeJS team and others; see AUTHORS.txt
  * @license The MIT License (MIT); see LICENSE.txt
  */
 ( function () {
diff --git a/tests/unicodejs.graphemebreak.test.js 
b/tests/unicodejs.graphemebreak.test.js
index a51d3bb..ac05a46 100644
--- a/tests/unicodejs.graphemebreak.test.js
+++ b/tests/unicodejs.graphemebreak.test.js
@@ -1,7 +1,7 @@
 /*!
  * UnicodeJS Grapheme Break module tests
  *
- * @copyright 2013–2014 UnicodeJS team and others; see AUTHORS.txt
+ * @copyright 2013-2018 UnicodeJS team and others; see AUTHORS.txt
  * @license The MIT License (MIT); see LICENSE.txt
  */
 
diff --git a/tests/unicodejs.test.js b/tests/unicodejs.test.js
index 8cd53d1..2b0f5a4 100644
--- a/tests/unicodejs.test.js
+++ b/tests/unicodejs.test.js
@@ -1,7 +1,7 @@
 /*!
  * UnicodeJS Base module tests
  *
- * @copyright 2013–2014 UnicodeJS team and others; see AUTHORS.txt
+ * @copyright 2013-2018 UnicodeJS team and others; see AUTHORS.txt
  * @license The MIT License (MIT); see LICENSE.txt
  */
 
diff --git a/tests/unicodejs.wordbreak.test.js 
b/tests/unicodejs.wordbreak.test.js
index 209496d..9decc71 100644
--- a/tests/unicodejs.wordbreak.test.js
+++ b/tests/unicodejs.wordbreak.test.js
@@ -1,7 +1,7 @@
 /*!
  * UnicodeJS Word Break module tests
  *
- * @copyright 2013–2014 UnicodeJS team and others; see AUTHORS.txt
+ * @copyright 2013-2018 UnicodeJS team and others; see AUTHORS.txt
  * @license The MIT License (MIT); see LICENSE.txt
  */
 

-- 
To view, visit https://gerrit.wikimedia.org/r/401645
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Idd13eaf4b722606ec6282b3ec3acdb19ebe8e861
Gerrit-PatchSet: 1
Gerrit-Project: unicodejs
Gerrit-Branch: master
Gerrit-Owner: Jforrester 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] oojs/ui[master]: doc: Bump copyright year

[Jforrester (Code Review)]

Jforrester has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/401643 )

Change subject: doc: Bump copyright year
..

doc: Bump copyright year

Change-Id: Ief9d2159c137ee73c9a305977f720fae4bb787ae
---
M LICENSE-MIT
M tests/QUnit.assert.equalDomElement.js
M tests/TestTimer.js
3 files changed, 2 insertions(+), 5 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/oojs/ui refs/changes/43/401643/1

diff --git a/LICENSE-MIT b/LICENSE-MIT
index 25303af..7648d4c 100644
--- a/LICENSE-MIT
+++ b/LICENSE-MIT
@@ -1,4 +1,4 @@
-Copyright 2011-2017 OOjs UI Team and other contributors.
+Copyright 2011-2018 OOjs UI Team and other contributors.
 
 Permission is hereby granted, free of charge, to any person obtaining
 a copy of this software and associated documentation files (the
diff --git a/tests/QUnit.assert.equalDomElement.js 
b/tests/QUnit.assert.equalDomElement.js
index 4aff2c9..c34791f 100644
--- a/tests/QUnit.assert.equalDomElement.js
+++ b/tests/QUnit.assert.equalDomElement.js
@@ -5,8 +5,7 @@
  * attributes (for dynamically generated nodes) and order-insensitive 
comparison of classes on DOM
  * nodes.
  *
- * @copyright 2011-2017 VisualEditor Team and others; see 
http://ve.mit-license.org
- * @copyright 2011-2017 OOjs UI Team and other contributors
+ * @copyright 2011-2018 VisualEditor Team and others; see 
http://ve.mit-license.org
  */
 
 ( function ( QUnit ) {
diff --git a/tests/TestTimer.js b/tests/TestTimer.js
index aa8cd11..f4b202a 100644
--- a/tests/TestTimer.js
+++ b/tests/TestTimer.js
@@ -1,7 +1,5 @@
 /*!
  * OO UI TestTimer class.
- *
- * @copyright 2011-2017 OOjs UI Team and others; see http://ve.mit-license.org
  */
 
 /**

-- 
To view, visit https://gerrit.wikimedia.org/r/401643
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ief9d2159c137ee73c9a305977f720fae4bb787ae
Gerrit-PatchSet: 1
Gerrit-Project: oojs/ui
Gerrit-Branch: master
Gerrit-Owner: Jforrester 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...VisualEditor[master]: Update VE core submodule to master (90a2a3834)

[Jforrester (Code Review)]

Jforrester has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/401599 )

Change subject: Update VE core submodule to master (90a2a3834)
..

Update VE core submodule to master (90a2a3834)

New changes:
7b24c338b Fix stale comment
288e6cffd Unbreak tests after Chrome upgrade
61c2bb7c0 Follow-up c7ef30a30f6: append multi-element nodes in the right order
be89723c6 ve.ce.DocumentNode: Documentation fix
7a5288231 ve.ui.DesktopContext: Do not flip the popup
e2b755b9f Localisation updates from https://translatewiki.net.

Bug: T182907
Bug: T183590
Change-Id: Ie08c04c137e9927b78642d4b8b75f914f9758187
---
M lib/ve
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/VisualEditor 
refs/changes/99/401599/1

diff --git a/lib/ve b/lib/ve
index bafb26b..90a2a38 16
--- a/lib/ve
+++ b/lib/ve
@@ -1 +1 @@
-Subproject commit bafb26b25c42914452b46d787331f6f4edaa263c
+Subproject commit 90a2a383438f30232f3d6b04e807f2c937b56620

-- 
To view, visit https://gerrit.wikimedia.org/r/401599
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie08c04c137e9927b78642d4b8b75f914f9758187
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Jforrester 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...VisualEditor[wmf/1.31.0-wmf.12]: ArticleTargetEvents: Track editor mode on save events

[Jforrester (Code Review)]

Jforrester has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/398389 )

Change subject: ArticleTargetEvents: Track editor mode on save events
..

ArticleTargetEvents: Track editor mode on save events

Bug: T182610
Change-Id: I8b58bea8e478cde4c1340d13ddf97aab8f01
(cherry picked from commit 5bbda2b8c8f16cdebf08c53daa4148439dc7546f)
---
M lib/ve
M modules/ve-mw/init/ve.init.mw.ArticleTargetEvents.js
2 files changed, 30 insertions(+), 19 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/VisualEditor 
refs/changes/89/398389/1

diff --git a/lib/ve b/lib/ve
index cd6bce1..bafb26b 16
--- a/lib/ve
+++ b/lib/ve
@@ -1 +1 @@
-Subproject commit cd6bce192f313cc4670bee1b66197f4ff1b8b2ce
+Subproject commit bafb26b25c42914452b46d787331f6f4edaa263c
diff --git a/modules/ve-mw/init/ve.init.mw.ArticleTargetEvents.js 
b/modules/ve-mw/init/ve.init.mw.ArticleTargetEvents.js
index f3e9fd2..0f4584b 100644
--- a/modules/ve-mw/init/ve.init.mw.ArticleTargetEvents.js
+++ b/modules/ve-mw/init/ve.init.mw.ArticleTargetEvents.js
@@ -51,9 +51,20 @@
  * @param {Object} data Additional data describing the event, encoded as an 
object
  */
 ve.init.mw.ArticleTargetEvents.prototype.track = function ( topic, data ) {
+   ve.track( topic, $.extend( {
+   mode: this.target.surface ? this.target.surface.getMode() : 
this.target.getDefaultMode()
+   }, data ) );
+};
+
+/**
+ * Target specific ve.track wrapper, focused on mwtiming
+ *
+ * @param {string} topic Event name
+ * @param {Object} data Additional data describing the event, encoded as an 
object
+ */
+ve.init.mw.ArticleTargetEvents.prototype.trackTiming = function ( topic, data 
) {
data.targetName = this.target.constructor.static.trackingName;
-   data.mode = this.target.surface ? this.target.surface.getMode() : 
this.target.getDefaultMode();
-   ve.track( 'mwtiming.' + topic, data );
+   this.track( 'mwtiming.' + topic, data );
 
if ( topic.indexOf( 'performance.system.serializeforcache' ) === 0 ) {
// HACK: track serializeForCache duration here, because there's 
no event for that
@@ -66,17 +77,17 @@
  */
 ve.init.mw.ArticleTargetEvents.prototype.onSaveWorkflowBegin = function () {
this.timings.saveWorkflowBegin = ve.now();
-   this.track( 'behavior.lastTransactionTillSaveDialogOpen', {
+   this.trackTiming( 'behavior.lastTransactionTillSaveDialogOpen', {
duration: this.timings.saveWorkflowBegin - 
this.timings.lastTransaction
} );
-   ve.track( 'mwedit.saveIntent' );
+   this.track( 'mwedit.saveIntent' );
 };
 
 /**
  * Track when user ends the save workflow
  */
 ve.init.mw.ArticleTargetEvents.prototype.onSaveWorkflowEnd = function () {
-   this.track( 'behavior.saveDialogClose', { duration: ve.now() - 
this.timings.saveWorkflowBegin } );
+   this.trackTiming( 'behavior.saveDialogClose', { duration: ve.now() - 
this.timings.saveWorkflowBegin } );
this.timings.saveWorkflowBegin = null;
 };
 
@@ -86,10 +97,10 @@
 ve.init.mw.ArticleTargetEvents.prototype.onSaveInitiated = function () {
this.timings.saveInitiated = ve.now();
this.timings.saveRetries++;
-   this.track( 'behavior.saveDialogOpenTillSave', {
+   this.trackTiming( 'behavior.saveDialogOpenTillSave', {
duration: this.timings.saveInitiated - 
this.timings.saveWorkflowBegin
} );
-   ve.track( 'mwedit.saveAttempt' );
+   this.track( 'mwedit.saveAttempt' );
 };
 
 /**
@@ -100,9 +111,9 @@
  * @param {number} newRevId
  */
 ve.init.mw.ArticleTargetEvents.prototype.onSaveComplete = function ( content, 
categoriesHtml, newRevId ) {
-   this.track( 'performance.user.saveComplete', { duration: ve.now() - 
this.timings.saveInitiated } );
+   this.trackTiming( 'performance.user.saveComplete', { duration: ve.now() 
- this.timings.saveInitiated } );
this.timings.saveRetries = 0;
-   ve.track( 'mwedit.saveSuccess', {
+   this.track( 'mwedit.saveSuccess', {
timing: ve.now() - this.timings.saveInitiated + ( 
this.timings.serializeForCache || 0 ),
'page.revid': newRevId
} );
@@ -142,7 +153,7 @@
if ( specialTypes.indexOf( type ) !== -1 ) {
key += '.' + type;
}
-   this.track( key, {
+   this.trackTiming( key, {
duration: ve.now() - this.timings.saveInitiated,
retries: this.timings.saveRetries,
type: type
@@ -155,7 +166,7 @@
if ( type === 'unknown' && failureArguments[ 0 ] ) {
data.message = failureArguments[ 0 ];
}
-   ve.track( 'mwedit.saveFailure', data );
+   this.track( 'mwedit.saveFailure', data );
 };
 
 /**
@@ -171,7 +182,7 @@
  * Record activation being complete.
  */
 ve.init.mw.ArticleTargetEvents.prototype.trackActivationComplete = function () 

[MediaWiki-commits] [Gerrit] mediawiki...WikimediaEvents[wmf/1.31.0-wmf.12]: Bump Edit schema version

[Jforrester (Code Review)]

Jforrester has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/398114 )

Change subject: Bump Edit schema version
..

Bump Edit schema version

Change-Id: I5d44537d84c67c1612bcbfc3dcc7f4f6f4ca95fa
(cherry picked from commit 874f9bfb8dc4fe685d7f3b7b63683f49a537aa27)
---
M extension.json
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull 
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/WikimediaEvents 
refs/changes/14/398114/1

diff --git a/extension.json b/extension.json
index 746e5de..57cc937 100644
--- a/extension.json
+++ b/extension.json
@@ -85,7 +85,7 @@
"schema.Edit": {
"class": "ResourceLoaderSchemaModule",
"schema": "Edit",
-   "revision": 17520312
+   "revision": 17541122
},
"schema.CompletionSuggestions": {
"class": "ResourceLoaderSchemaModule",

-- 
To view, visit https://gerrit.wikimedia.org/r/398114
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I5d44537d84c67c1612bcbfc3dcc7f4f6f4ca95fa
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/WikimediaEvents
Gerrit-Branch: wmf/1.31.0-wmf.12
Gerrit-Owner: Jforrester 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...WikimediaEvents[master]: Bump Edit schema version

[Jforrester (Code Review)]

Jforrester has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/398111 )

Change subject: Bump Edit schema version
..

Bump Edit schema version

Change-Id: I5d44537d84c67c1612bcbfc3dcc7f4f6f4ca95fa
---
M extension.json
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull 
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/WikimediaEvents 
refs/changes/11/398111/1

diff --git a/extension.json b/extension.json
index 746e5de..57cc937 100644
--- a/extension.json
+++ b/extension.json
@@ -85,7 +85,7 @@
"schema.Edit": {
"class": "ResourceLoaderSchemaModule",
"schema": "Edit",
-   "revision": 17520312
+   "revision": 17541122
},
"schema.CompletionSuggestions": {
"class": "ResourceLoaderSchemaModule",

-- 
To view, visit https://gerrit.wikimedia.org/r/398111
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I5d44537d84c67c1612bcbfc3dcc7f4f6f4ca95fa
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/WikimediaEvents
Gerrit-Branch: master
Gerrit-Owner: Jforrester 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...VisualEditor[wmf/1.31.0-wmf.12]: trackSubscriber: Add timing data for 'loaded' state

[Jforrester (Code Review)]

Jforrester has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/398105 )

Change subject: trackSubscriber: Add timing data for 'loaded' state
..

trackSubscriber: Add timing data for 'loaded' state

Change-Id: I771764e5f40adcfc67d181cda68f60fc283a9cb2
---
M modules/ve-mw/init/ve.init.mw.trackSubscriber.js
1 file changed, 2 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/VisualEditor 
refs/changes/05/398105/1

diff --git a/modules/ve-mw/init/ve.init.mw.trackSubscriber.js 
b/modules/ve-mw/init/ve.init.mw.trackSubscriber.js
index 2caa31d..737a153 100644
--- a/modules/ve-mw/init/ve.init.mw.trackSubscriber.js
+++ b/modules/ve-mw/init/ve.init.mw.trackSubscriber.js
@@ -34,6 +34,8 @@
);
case 'ready':
return timeStamp - timing.init;
+   case 'loaded':
+   return timeStamp - timing.init;
case 'saveIntent':
return timeStamp - timing.ready;
case 'saveAttempt':

-- 
To view, visit https://gerrit.wikimedia.org/r/398105
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I771764e5f40adcfc67d181cda68f60fc283a9cb2
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/VisualEditor
Gerrit-Branch: wmf/1.31.0-wmf.12
Gerrit-Owner: Jforrester 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...VisualEditor[master]: trackSubscriber: Add timing data for 'loaded' state

[Jforrester (Code Review)]

Jforrester has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/398104 )

Change subject: trackSubscriber: Add timing data for 'loaded' state
..

trackSubscriber: Add timing data for 'loaded' state

Change-Id: I771764e5f40adcfc67d181cda68f60fc283a9cb2
---
M modules/ve-mw/init/ve.init.mw.trackSubscriber.js
1 file changed, 2 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/VisualEditor 
refs/changes/04/398104/1

diff --git a/modules/ve-mw/init/ve.init.mw.trackSubscriber.js 
b/modules/ve-mw/init/ve.init.mw.trackSubscriber.js
index 2caa31d..737a153 100644
--- a/modules/ve-mw/init/ve.init.mw.trackSubscriber.js
+++ b/modules/ve-mw/init/ve.init.mw.trackSubscriber.js
@@ -34,6 +34,8 @@
);
case 'ready':
return timeStamp - timing.init;
+   case 'loaded':
+   return timeStamp - timing.init;
case 'saveIntent':
return timeStamp - timing.ready;
case 'saveAttempt':

-- 
To view, visit https://gerrit.wikimedia.org/r/398104
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I771764e5f40adcfc67d181cda68f60fc283a9cb2
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Jforrester 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...VisualEditor[wmf/1.31.0-wmf.12]: trackSubscriber: data isn't required

[Jforrester (Code Review)]

Jforrester has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/398098 )

Change subject: trackSubscriber: data isn't required
..

trackSubscriber: data isn't required

Editor-fixing caused errors on some events which don't pass data in.

Introduced in 8f612fbe64.

Change-Id: I5c9471e6ffe4cdda0bf5455c80ef70251690e20f
(cherry picked from commit e66d58076fac8ac92e9a3bcaa59596c6829cce5f)
---
M modules/ve-mw/init/ve.init.mw.trackSubscriber.js
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/VisualEditor 
refs/changes/98/398098/1

diff --git a/modules/ve-mw/init/ve.init.mw.trackSubscriber.js 
b/modules/ve-mw/init/ve.init.mw.trackSubscriber.js
index 29b75cb..2caa31d 100644
--- a/modules/ve-mw/init/ve.init.mw.trackSubscriber.js
+++ b/modules/ve-mw/init/ve.init.mw.trackSubscriber.js
@@ -95,7 +95,7 @@
}
 
// Convert mode=source/visual to editor name
-   if ( data.mode ) {
+   if ( data && data.mode ) {
data.editor = data.mode === 'source' ? 'wikitext-2017' 
: 'visualeditor';
delete data.mode;
}

-- 
To view, visit https://gerrit.wikimedia.org/r/398098
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I5c9471e6ffe4cdda0bf5455c80ef70251690e20f
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/VisualEditor
Gerrit-Branch: wmf/1.31.0-wmf.12
Gerrit-Owner: Jforrester 
Gerrit-Reviewer: DLynch 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] analytics/limn-edit-data[master]: Drop support for the Edit_11448630 schema revision

[Jforrester (Code Review)]

Jforrester has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/397627 )

Change subject: Drop support for the Edit_11448630 schema revision
..

Drop support for the Edit_11448630 schema revision

Not been written to (except for very oddly-cached code) since
October 2015. No need to keep querying it.

Change-Id: Ibc248c45f0adb86d53df44299544639df8987eaa
---
M edit/failure_rates_by_type.sql
M edit/failure_types_by_user_type.sql
M edit/rates.sql
M edit/sessions.sql
M edit/success_by_user_type.sql
5 files changed, 0 insertions(+), 80 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/analytics/limn-edit-data 
refs/changes/27/397627/1

diff --git a/edit/failure_rates_by_type.sql b/edit/failure_rates_by_type.sql
index a540e82..75b75a9 100644
--- a/edit/failure_rates_by_type.sql
+++ b/edit/failure_rates_by_type.sql
@@ -38,23 +38,6 @@
 `event_action.saveFailure.type`,
 clientIp,
 event_editingSessionId
- from Edit_11448630
- where
-event_editor = '{editor}' and
-('{wiki}' = 'all' or wiki = '{wiki}') and
-timestamp >= '{from_timestamp}' and
-timestamp < '{to_timestamp}'
-
- # Add in events using the new schema. To be removed once everything
- # is switched over.
- union all
-
- select
-timestamp,
-event_action,
-`event_action.saveFailure.type`,
-clientIp,
-event_editingSessionId
  from Edit_13457736
  where
 event_editor = '{editor}' and
diff --git a/edit/failure_types_by_user_type.sql 
b/edit/failure_types_by_user_type.sql
index 22c294f..c0651ff 100644
--- a/edit/failure_types_by_user_type.sql
+++ b/edit/failure_types_by_user_type.sql
@@ -21,19 +21,6 @@
 from (
( select timestamp, `event_user.class`,
`event_user.editCount`, `event_action.saveFailure.type`
-   from Edit_11448630
-   where
-   event_editor = '{editor}' and
-   ('{wiki}' = 'all' or wiki = '{wiki}') and
-   timestamp >= '{from_timestamp}' and
-   timestamp < '{to_timestamp}' and
-   `event_action` = 'saveFailure' and
-   `event_action.saveFailure.type` is not null )
-
-   union all
-
-   ( select timestamp, `event_user.class`,
-   `event_user.editCount`, `event_action.saveFailure.type`
from Edit_13457736
where
event_editor = '{editor}' and
diff --git a/edit/rates.sql b/edit/rates.sql
index f41906a..f16e267 100644
--- a/edit/rates.sql
+++ b/edit/rates.sql
@@ -22,22 +22,6 @@
event_action,
clientIp,
event_editingSessionId
-from Edit_11448630
-where
-   event_editor = '{editor}' and
-   ('{wiki}' = 'all' or wiki = '{wiki}') and
-   timestamp >= '{from_timestamp}' and
-   timestamp < '{to_timestamp}'
-
-# Add in events using the new schema. To be removed once 
everything
-# is switched over.
-union all
-
-select
-   timestamp,
-   event_action,
-   clientIp,
-   event_editingSessionId
 from Edit_13457736
 where
event_editor = '{editor}' and
diff --git a/edit/sessions.sql b/edit/sessions.sql
index e84f56e..fab56c9 100644
--- a/edit/sessions.sql
+++ b/edit/sessions.sql
@@ -8,22 +8,6 @@
event_action,
clientIp,
event_editingSessionId
-from Edit_11448630
-where
-   event_editor = '{editor}' and
-   ('{wiki}' = 'all' or wiki = '{wiki}') and
-   timestamp >= '{from_timestamp}' and
-   timestamp < '{to_timestamp}'
-
-# Add in events using the new schema. To be removed once 
everything
-# is switched over.
-union all
-
-select
-   timestamp,
-   event_action,
-   clientIp,
-   event_editingSessionId
 from Edit_13457736
 where
event_editor = '{editor}' and
diff --git a/edit/success_by_user_type.sql b/edit/success_by_user_type.sql
index 6a09f0a..2f8ec97 100644
--- a/edit/success_by_user_type.sql
+++ b/edit/success_by_user_type.sql
@@ -34,24 +34,6 @@
event_editingSessionId,
`event_user.class`,
`event_user.editCount` as edit_count
-from Edit_11448630
-where
-   event_editor = '{editor}' and
-   ('{wiki}' = 'all' or wiki = '{wiki}') and
-   timestamp >= '{from_timestamp}' and
-   timestamp < 

[MediaWiki-commits] [Gerrit] analytics/limn-edit-data[master]: Revert "Adding renamed tables to sql union statements"

[Jforrester (Code Review)]

Jforrester has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/397625 )

Change subject: Revert "Adding renamed tables to sql union statements"
..

Revert "Adding renamed tables to sql union statements"

This reverts commit 582bcce26e2a16643e1b127834ed825585e33ede.

The temporary table Edit_13457736_15423246 no longer exists, so we can
remove this complexity.

Change-Id: I6327dcaba6ec672f0738d3314ead4ddc9f780a9f
---
M edit/failure_rates_by_type.sql
M edit/failure_types_by_user_type.sql
M edit/rates.sql
M edit/sessions.sql
M edit/success_by_user_type.sql
5 files changed, 4 insertions(+), 84 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/analytics/limn-edit-data 
refs/changes/25/397625/1

diff --git a/edit/failure_rates_by_type.sql b/edit/failure_rates_by_type.sql
index a4e04e7..05e2500 100644
--- a/edit/failure_rates_by_type.sql
+++ b/edit/failure_rates_by_type.sql
@@ -55,29 +55,13 @@
 `event_action.saveFailure.type`,
 clientIp,
 event_editingSessionId
- from Edit_13457736_15423246
- where
-event_editor = '{editor}' and
-('{wiki}' = 'all' or wiki = '{wiki}') and
-timestamp >= '{from_timestamp}' and
-timestamp < '{to_timestamp}'
-
-union all
-
- select
-timestamp,
-event_action,
-`event_action.saveFailure.type`,
-clientIp,
-event_editingSessionId
  from Edit_13457736
  where
 event_editor = '{editor}' and
 ('{wiki}' = 'all' or wiki = '{wiki}') and
 timestamp >= '{from_timestamp}' and
 timestamp < '{to_timestamp}'
-
-) raw_events
+ ) raw_events
 
  inner join
 (select 'init' as action, 0 as ord
diff --git a/edit/failure_types_by_user_type.sql 
b/edit/failure_types_by_user_type.sql
index edb86cd..6fbfcfc 100644
--- a/edit/failure_types_by_user_type.sql
+++ b/edit/failure_types_by_user_type.sql
@@ -34,19 +34,6 @@
 
( select timestamp, `event_user.class`,
`event_user.editCount`, `event_action.saveFailure.type`
-   from Edit_13457736_15423246
-   where
-   event_editor = '{editor}' and
-   ('{wiki}' = 'all' or wiki = '{wiki}') and
-   timestamp >= '{from_timestamp}' and
-   timestamp < '{to_timestamp}' and
-   `event_action` = 'saveFailure' and
-   `event_action.saveFailure.type` is not null )
-
-union all
-
-   ( select timestamp, `event_user.class`,
-   `event_user.editCount`, `event_action.saveFailure.type`
from Edit_13457736
where
event_editor = '{editor}' and
@@ -55,7 +42,6 @@
timestamp < '{to_timestamp}' and
`event_action` = 'saveFailure' and
`event_action.saveFailure.type` is not null )
-
 ) saveFailures
 
 group by 1, 2
diff --git a/edit/rates.sql b/edit/rates.sql
index d905cd5..eef80db 100644
--- a/edit/rates.sql
+++ b/edit/rates.sql
@@ -15,7 +15,6 @@
date(timestamp) as day,
group_concat(event_action order by timestamp, action_order.ord 
separator '-') as actions
  from (
-
 select
timestamp,
event_action,
@@ -37,28 +36,13 @@
event_action,
clientIp,
event_editingSessionId
-from Edit_13457736_15423246
-where
-   event_editor = '{editor}' and
-   ('{wiki}' = 'all' or wiki = '{wiki}') and
-   timestamp >= '{from_timestamp}' and
-   timestamp < '{to_timestamp}'
-
-   union all
-
-select
-   timestamp,
-   event_action,
-   clientIp,
-   event_editingSessionId
 from Edit_13457736
 where
event_editor = '{editor}' and
('{wiki}' = 'all' or wiki = '{wiki}') and
timestamp >= '{from_timestamp}' and
timestamp < '{to_timestamp}'
-
-) raw_events
+) raw_events
 
 inner join
(select 'init' as action, 0 as ord
diff --git a/edit/sessions.sql b/edit/sessions.sql
index 70c817a..130f090 100644
--- a/edit/sessions.sql
+++ b/edit/sessions.sql
@@ -2,24 +2,7 @@
 actions,
 count(*) as repeated
from (select group_concat(event_action order by timestamp, action_order.ord 
separator '-') as actions
-   from (
-select timestamp,
-event_action,
-clientIp,
-event_editingSessionId
-
-   from Edit_13457736_15423246
-# NOTE: used to union all with Edit_11448630
-# That schema is still used 

[MediaWiki-commits] [Gerrit] analytics/limn-edit-data[master]: Swap archaïc code to use current tables

[Jforrester (Code Review)]

Jforrester has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/397628 )

Change subject: Swap archaïc code to use current tables
..

Swap archaïc code to use current tables

Not sure these are run, but at least they'll now have data.

Change-Id: Ib925704b9df2fa8cb2fb8a302aa13ded5ea812c8
---
M edit/aborts.sql
M edit/aborts_rates.sql
M edit/action.sql
M edit/saves.sql
M edit/saves_rates.sql
M edit/saves_rates_comparative_attempts.sql
M edit/saves_rates_comparative_success_attempts.sql
M edit/saves_rates_comparative_successes.sql
8 files changed, 16 insertions(+), 16 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/analytics/limn-edit-data 
refs/changes/28/397628/1

diff --git a/edit/aborts.sql b/edit/aborts.sql
index 9375773..34f617f 100644
--- a/edit/aborts.sql
+++ b/edit/aborts.sql
@@ -18,7 +18,7 @@
 `event_action.abort.type`,
 timestamp
 
-FROM Edit_10604157
+FROM Edit_13457736
 
 WHERE event_action = 'abort' OR event_action = 'ready' OR 
event_action = 'init'
 
@@ -30,7 +30,7 @@
 `event_action.abort.type`,
 timestamp
 
-FROM Edit_10676603
+FROM Edit_17520312
 
 WHERE event_action = 'abort' OR event_action = 'ready' OR 
event_action = 'init'
 
diff --git a/edit/aborts_rates.sql b/edit/aborts_rates.sql
index 6453e2f..0839cb3 100644
--- a/edit/aborts_rates.sql
+++ b/edit/aborts_rates.sql
@@ -29,7 +29,7 @@
 `event_action.abort.type`,
 timestamp
 
-FROM Edit_10604157
+FROM Edit_13457736
 
 WHERE event_action = 'abort' OR event_action = 'ready' OR 
event_action = 'init'
 
@@ -41,7 +41,7 @@
 `event_action.abort.type`,
 timestamp
 
-FROM Edit_10676603
+FROM Edit_17520312
 
 WHERE event_action = 'abort' OR event_action = 'ready' OR 
event_action = 'init'
 
diff --git a/edit/action.sql b/edit/action.sql
index 6da5e4d..b6d3339 100644
--- a/edit/action.sql
+++ b/edit/action.sql
@@ -9,13 +9,13 @@
 
from (select event_action,
 timestamp
-   from Edit_10604157
+   from Edit_13457736
 
   union all
 
  select event_action,
 timestamp
-   from Edit_10676603
+   from Edit_17520312
 ) valid_edit_schema_revisions
 
   group by day
diff --git a/edit/saves.sql b/edit/saves.sql
index 4cf48fe..a86b70d 100644
--- a/edit/saves.sql
+++ b/edit/saves.sql
@@ -13,7 +13,7 @@
 event_action,
 timestamp
 
-FROM Edit_10604157
+FROM Edit_13457736
 
 UNION ALL
 
@@ -22,7 +22,7 @@
 event_action,
 timestamp
 
-FROM Edit_10676603
+FROM Edit_17520312
 
 ) AS valid_edit_schema_revisions
 
diff --git a/edit/saves_rates.sql b/edit/saves_rates.sql
index 6fe014e..ead2f0e 100644
--- a/edit/saves_rates.sql
+++ b/edit/saves_rates.sql
@@ -22,7 +22,7 @@
 event_action,
 timestamp
 
-FROM Edit_10604157
+FROM Edit_13457736
 
 UNION ALL
 
@@ -31,7 +31,7 @@
 event_action,
 timestamp
 
-FROM Edit_10676603
+FROM Edit_17520312
 
 ) AS valid_edit_schema_revisions
 
diff --git a/edit/saves_rates_comparative_attempts.sql 
b/edit/saves_rates_comparative_attempts.sql
index b514bf6..728f0e0 100644
--- a/edit/saves_rates_comparative_attempts.sql
+++ b/edit/saves_rates_comparative_attempts.sql
@@ -35,7 +35,7 @@
 wiki,
 timestamp
 
-FROM Edit_10604157
+FROM Edit_13457736
 
 UNION ALL
 
@@ -45,7 +45,7 @@
 wiki,
 timestamp
 
-FROM Edit_10676603
+FROM Edit_17520312
 
 ) AS valid_edit_schema_revisions
 
diff --git a/edit/saves_rates_comparative_success_attempts.sql 
b/edit/saves_rates_comparative_success_attempts.sql
index ba86e53..25aebee 100644
--- a/edit/saves_rates_comparative_success_attempts.sql
+++ b/edit/saves_rates_comparative_success_attempts.sql
@@ -35,7 +35,7 @@
 wiki,
 timestamp
 
-FROM Edit_10604157
+FROM Edit_13457736
 
 UNION ALL
 
@@ -45,7 +45,7 @@
 wiki,
 timestamp
 
-FROM Edit_10676603
+FROM Edit_17520312
 
 ) AS valid_edit_schema_revisions
 
diff --git a/edit/saves_rates_comparative_successes.sql 
b/edit/saves_rates_comparative_successes.sql
index 6728ad0..3cedf6c 100644
--- 

[MediaWiki-commits] [Gerrit] analytics/limn-edit-data[master]: Update for new Edit schema version 17520312

[Jforrester (Code Review)]

Jforrester has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/397626 )

Change subject: Update for new Edit schema version 17520312
..

Update for new Edit schema version 17520312

New action state (loaded, after ready and before saveIntent), which
means some changes to the queries, and editor type (wikitext), which
doesn't..

Change-Id: I9bf52dcbaa175ef52dcc9a4b615e14785be753ee
---
M edit/failure_rates_by_type.sql
M edit/failure_types_by_user_type.sql
M edit/rates.sql
M edit/sessions.sql
M edit/success_by_user_type.sql
5 files changed, 133 insertions(+), 32 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/analytics/limn-edit-data 
refs/changes/26/397626/1

diff --git a/edit/failure_rates_by_type.sql b/edit/failure_rates_by_type.sql
index 05e2500..a540e82 100644
--- a/edit/failure_rates_by_type.sql
+++ b/edit/failure_rates_by_type.sql
@@ -63,20 +63,38 @@
 timestamp < '{to_timestamp}'
  ) raw_events
 
+ union all
+
+ select
+timestamp,
+event_action,
+`event_action.saveFailure.type`,
+clientIp,
+event_editingSessionId
+ from Edit_17520312
+ where
+event_editor = '{editor}' and
+('{wiki}' = 'all' or wiki = '{wiki}') and
+timestamp >= '{from_timestamp}' and
+timestamp < '{to_timestamp}'
+ ) raw_events
+
  inner join
 (select 'init' as action, 0 as ord
 union all
  select 'ready' as action, 1 as ord
 union all
- select 'saveIntent' as action, 2 as ord
+ select 'loaded' as action, 2 as ord
 union all
- select 'saveAttempt' as action, 3 as ord
+ select 'saveIntent' as action, 3 as ord
 union all
- select 'saveFailure' as action, 4 as ord
+ select 'saveAttempt' as action, 4 as ord
 union all
- select 'saveSuccess' as action, 5 as ord
+ select 'saveFailure' as action, 5 as ord
 union all
- select 'abort' as action, 6 as ord
+ select 'saveSuccess' as action, 6 as ord
+union all
+ select 'abort' as action, 7 as ord
 ) action_order
  on action = event_action
 
diff --git a/edit/failure_types_by_user_type.sql 
b/edit/failure_types_by_user_type.sql
index 6fbfcfc..22c294f 100644
--- a/edit/failure_types_by_user_type.sql
+++ b/edit/failure_types_by_user_type.sql
@@ -42,6 +42,19 @@
timestamp < '{to_timestamp}' and
`event_action` = 'saveFailure' and
`event_action.saveFailure.type` is not null )
+
+   union all
+
+   ( select timestamp, `event_user.class`,
+   `event_user.editCount`, `event_action.saveFailure.type`
+   from Edit_17520312
+   where
+   event_editor = '{editor}' and
+   ('{wiki}' = 'all' or wiki = '{wiki}') and
+   timestamp >= '{from_timestamp}' and
+   timestamp < '{to_timestamp}' and
+   `event_action` = 'saveFailure' and
+   `event_action.saveFailure.type` is not null )
 ) saveFailures
 
 group by 1, 2
diff --git a/edit/rates.sql b/edit/rates.sql
index eef80db..f41906a 100644
--- a/edit/rates.sql
+++ b/edit/rates.sql
@@ -1,4 +1,5 @@
  select day,
+sum(ready and not loaded) / sum(ready) as `load-failure`,
 sum(ready and not saving) / sum(ready) as `bounce-rate`,
 sum(ready and not attempt) / sum(ready) as `not-attempted-rate`,
 sum(attempt and success) / sum(attempt) as `success-rate`,
@@ -6,6 +7,7 @@
 
from (select day,
 actions like '%ready%' as ready,
+actions like '%loaded%' as loaded,
 actions like '%save%' as saving,
 actions like '%Failure%' as failure,
 actions like '%Attempt%' as attempt,
@@ -44,20 +46,37 @@
timestamp < '{to_timestamp}'
 ) raw_events
 
+union all
+
+select
+   timestamp,
+   event_action,
+   clientIp,
+   event_editingSessionId
+from Edit_17520312
+where
+   event_editor = '{editor}' and
+   ('{wiki}' = 'all' or wiki = '{wiki}') and
+   timestamp >= '{from_timestamp}' and
+   timestamp < '{to_timestamp}'
+) raw_events
+
 inner join
(select 'init' as action, 0 as ord
union all
 select 'ready' as action, 1 as ord
union all
-select 'saveIntent' as action, 2 as ord
+select 'loaded' as action, 2 as ord
union all
-select 'saveAttempt' as action, 3 

[MediaWiki-commits] [Gerrit] mediawiki...VisualEditor[wmf/1.31.0-wmf.11]: Update VE core submodule to 1.31.0-wmf.11 HEAD (56fe63b62)

[Jforrester (Code Review)]

Jforrester has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/396050 )

Change subject: Update VE core submodule to 1.31.0-wmf.11 HEAD (56fe63b62)
..

Update VE core submodule to 1.31.0-wmf.11 HEAD (56fe63b62)

New changes:
56fe63b62 Don't execute commands twice

Bug: T182270
Change-Id: Ief48048796478cac0ee007b3581449c889fa67ce
---
M lib/ve
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/VisualEditor 
refs/changes/50/396050/1

diff --git a/lib/ve b/lib/ve
index 7894515..56fe63b 16
--- a/lib/ve
+++ b/lib/ve
@@ -1 +1 @@
-Subproject commit 78945151120ad2db06185faa6e444d4a6341f13d
+Subproject commit 56fe63b62e401c3a45ea557a1a7de71e0d615fab

-- 
To view, visit https://gerrit.wikimedia.org/r/396050
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ief48048796478cac0ee007b3581449c889fa67ce
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/VisualEditor
Gerrit-Branch: wmf/1.31.0-wmf.11
Gerrit-Owner: Jforrester 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...VisualEditor[master]: Update VE core submodule to 1.31.0-wmf.11 HEAD (56fe63b62)

[Jforrester (Code Review)]

Jforrester has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/396048 )

Change subject: Update VE core submodule to 1.31.0-wmf.11 HEAD (56fe63b62)
..

Update VE core submodule to 1.31.0-wmf.11 HEAD (56fe63b62)

New changes:
56fe63b62 Don't execute commands twice

Bug: T182270
Change-Id: Ief48048796478cac0ee007b3581449c889fa67cd
---
M lib/ve
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/VisualEditor 
refs/changes/48/396048/1

diff --git a/lib/ve b/lib/ve
index 7894515..56fe63b 16
--- a/lib/ve
+++ b/lib/ve
@@ -1 +1 @@
-Subproject commit 78945151120ad2db06185faa6e444d4a6341f13d
+Subproject commit 56fe63b62e401c3a45ea557a1a7de71e0d615fab

-- 
To view, visit https://gerrit.wikimedia.org/r/396048
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ief48048796478cac0ee007b3581449c889fa67cd
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Jforrester 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...VisualEditor[master]: Update VE core submodule to 1.31.0-wmf.11 HEAD (56fe63b62)

[Jforrester (Code Review)]

Jforrester has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/396046 )

Change subject: Update VE core submodule to 1.31.0-wmf.11 HEAD (56fe63b62)
..

Update VE core submodule to 1.31.0-wmf.11 HEAD (56fe63b62)

New changes:
56fe63b62 Don't execute commands twice

Bug: T182270
Change-Id: Ief48048796478cac0ee007b3581449c889fa67cc
---
M lib/ve
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/VisualEditor 
refs/changes/46/396046/1

diff --git a/lib/ve b/lib/ve
index 7894515..56fe63b 16
--- a/lib/ve
+++ b/lib/ve
@@ -1 +1 @@
-Subproject commit 78945151120ad2db06185faa6e444d4a6341f13d
+Subproject commit 56fe63b62e401c3a45ea557a1a7de71e0d615fab

-- 
To view, visit https://gerrit.wikimedia.org/r/396046
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ief48048796478cac0ee007b3581449c889fa67cc
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Jforrester 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] VisualEditor/VisualEditor[wmf/1.31.0-wmf.11]: Don't execute commands twice

[Jforrester (Code Review)]

Jforrester has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/396034 )

Change subject: Don't execute commands twice
..


Don't execute commands twice

Bug: T182270
Change-Id: Iecc15a744d9a4606f8e1c9a1d2641d0fe8191049
(cherry picked from commit 2a1316fccd9166131c659ce83fe37bb8d491b8c8)
---
M src/ui/ve.ui.Tool.js
1 file changed, 10 insertions(+), 7 deletions(-)

Approvals:
  jenkins-bot: Verified
  Jforrester: Looks good to me, approved



diff --git a/src/ui/ve.ui.Tool.js b/src/ui/ve.ui.Tool.js
index 0a63bd1..c07290c 100644
--- a/src/ui/ve.ui.Tool.js
+++ b/src/ui/ve.ui.Tool.js
@@ -114,7 +114,6 @@
contextClosePromise = 
surface.context.inspector.close().closed;
} else {
contextClosePromise = $.Deferred().resolve().promise();
-   command.execute( surface );
}
}
if ( this.constructor.static.deactivateOnSelect ) {
@@ -123,12 +122,16 @@
// if the promise is slow.
this.setActive( false );
}
-   contextClosePromise.done( function () {
-   if ( !command.execute( surface ) ) {
-   // If the command fails, ensure the tool is not active
-   tool.setActive( false );
-   }
-   } );
+   if ( contextClosePromise ) {
+   // N.B. If contextClosePromise is already resolved, then the 
handler is called
+   // before the call to .done returns
+   contextClosePromise.done( function () {
+   if ( !command.execute( surface ) ) {
+   // If the command fails, ensure the tool is not 
active
+   tool.setActive( false );
+   }
+   } );
+   }
 };
 
 /**

-- 
To view, visit https://gerrit.wikimedia.org/r/396034
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Iecc15a744d9a4606f8e1c9a1d2641d0fe8191049
Gerrit-PatchSet: 1
Gerrit-Project: VisualEditor/VisualEditor
Gerrit-Branch: wmf/1.31.0-wmf.11
Gerrit-Owner: Jforrester 
Gerrit-Reviewer: Divec 
Gerrit-Reviewer: Jforrester 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...VisualEditor[master]: Update VE core submodule to master (cd6bce192)

[Jforrester (Code Review)]

Jforrester has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/396039 )

Change subject: Update VE core submodule to master (cd6bce192)
..

Update VE core submodule to master (cd6bce192)

New changes:
8f9a3d713 Localisation updates from https://translatewiki.net.
2d9987ade Update RuboCop Ruby gem
3c7276672 Use rel="noopener" on links targeted at new windows
2a1316fcc Don't execute commands twice
3c547f413 Localisation updates from https://translatewiki.net.

Bug: T180878
Bug: T180932
Bug: T182270
Change-Id: Ifdbf40d4bc27f10c30e2e5d03fb569eef754defb
---
M lib/ve
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/VisualEditor 
refs/changes/39/396039/1

diff --git a/lib/ve b/lib/ve
index 7894515..cd6bce1 16
--- a/lib/ve
+++ b/lib/ve
@@ -1 +1 @@
-Subproject commit 78945151120ad2db06185faa6e444d4a6341f13d
+Subproject commit cd6bce192f313cc4670bee1b66197f4ff1b8b2ce

-- 
To view, visit https://gerrit.wikimedia.org/r/396039
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ifdbf40d4bc27f10c30e2e5d03fb569eef754defb
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Jforrester 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] VisualEditor/VisualEditor[wmf/1.31.0-wmf.11]: Don't execute commands twice

[Jforrester (Code Review)]

Jforrester has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/396034 )

Change subject: Don't execute commands twice
..

Don't execute commands twice

Bug: T182270
Change-Id: Iecc15a744d9a4606f8e1c9a1d2641d0fe8191049
(cherry picked from commit 2a1316fccd9166131c659ce83fe37bb8d491b8c8)
---
M src/ui/ve.ui.Tool.js
1 file changed, 10 insertions(+), 7 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/VisualEditor/VisualEditor 
refs/changes/34/396034/1

diff --git a/src/ui/ve.ui.Tool.js b/src/ui/ve.ui.Tool.js
index 0a63bd1..c07290c 100644
--- a/src/ui/ve.ui.Tool.js
+++ b/src/ui/ve.ui.Tool.js
@@ -114,7 +114,6 @@
contextClosePromise = 
surface.context.inspector.close().closed;
} else {
contextClosePromise = $.Deferred().resolve().promise();
-   command.execute( surface );
}
}
if ( this.constructor.static.deactivateOnSelect ) {
@@ -123,12 +122,16 @@
// if the promise is slow.
this.setActive( false );
}
-   contextClosePromise.done( function () {
-   if ( !command.execute( surface ) ) {
-   // If the command fails, ensure the tool is not active
-   tool.setActive( false );
-   }
-   } );
+   if ( contextClosePromise ) {
+   // N.B. If contextClosePromise is already resolved, then the 
handler is called
+   // before the call to .done returns
+   contextClosePromise.done( function () {
+   if ( !command.execute( surface ) ) {
+   // If the command fails, ensure the tool is not 
active
+   tool.setActive( false );
+   }
+   } );
+   }
 };
 
 /**

-- 
To view, visit https://gerrit.wikimedia.org/r/396034
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Iecc15a744d9a4606f8e1c9a1d2641d0fe8191049
Gerrit-PatchSet: 1
Gerrit-Project: VisualEditor/VisualEditor
Gerrit-Branch: wmf/1.31.0-wmf.11
Gerrit-Owner: Jforrester 
Gerrit-Reviewer: Divec 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...VisualEditor[master]: Update VE core submodule to master (789451511)

[Jforrester (Code Review)]

Jforrester has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/394726 )

Change subject: Update VE core submodule to master (789451511)
..

Update VE core submodule to master (789451511)

New changes:
f91a80008 build: Bump Ruby cruft to avoid security warnings for old rubocop
c89c238dc Fix insertion annotations in source mode

Bug: T181726
Change-Id: I92dd60ec3adbe261ce4c47942150bff162b8149a
---
M lib/ve
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/VisualEditor 
refs/changes/26/394726/1

diff --git a/lib/ve b/lib/ve
index 49b1821..7894515 16
--- a/lib/ve
+++ b/lib/ve
@@ -1 +1 @@
-Subproject commit 49b1821234cd99a463a46337cf0ae0e000daea91
+Subproject commit 78945151120ad2db06185faa6e444d4a6341f13d

-- 
To view, visit https://gerrit.wikimedia.org/r/394726
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I92dd60ec3adbe261ce4c47942150bff162b8149a
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Jforrester 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...Wikibase[master]: build: Bump CI development dependencies

[Jforrester (Code Review)]

Jforrester has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/394605 )

Change subject: build: Bump CI development dependencies
..

build: Bump CI development dependencies

 grunt-eslint20.0.0  →  20.1.0
 grunt-stylelint  0.8.0  →   0.9.0
 stylelint7.8.0  →   8.2.0
 stylelint-config-wikimedia   0.4.1  →   0.4.2

Also exempt the extensions directory from linting now it exists.

Change-Id: I78d2958cb3828f436eed7a0d9401b81201f4dc34
---
M .stylelintrc.json
M Gruntfile.js
M package.json
3 files changed, 9 insertions(+), 7 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Wikibase 
refs/changes/05/394605/1

diff --git a/.stylelintrc.json b/.stylelintrc.json
index 880ad7a..9bd3fc5 100644
--- a/.stylelintrc.json
+++ b/.stylelintrc.json
@@ -1,7 +1,7 @@
 {
"extends": "stylelint-config-wikimedia",
"rules": {
-   "selector-no-id": null,
+   "selector-max-id": null,
"no-duplicate-selectors": null,
"no-descending-specificity": null,
"declaration-no-important": null
diff --git a/Gruntfile.js b/Gruntfile.js
index 7897255..8cccae9 100644
--- a/Gruntfile.js
+++ b/Gruntfile.js
@@ -14,7 +14,8 @@
all: [
'**/*.json',
'!node_modules/**',
-   '!vendor/**'
+   '!vendor/**',
+   '!extensions/**'
]
},
stylelint: {
@@ -24,7 +25,8 @@
'!view/resources/jquery/ui/**',
'!view/lib/**',
'!node_modules/**',
-   '!vendor/**'
+   '!vendor/**',
+   '!extensions/**'
]
},
banana: {
diff --git a/package.json b/package.json
index ac9ee18..f31f2fa 100644
--- a/package.json
+++ b/package.json
@@ -14,10 +14,10 @@
 "eslint-config-wikimedia": "0.5.0",
 "grunt": "1.0.1",
 "grunt-banana-checker": "0.6.0",
-"grunt-eslint": "20.0.0",
+"grunt-eslint": "20.1.0",
 "grunt-jsonlint": "1.1.0",
-"grunt-stylelint": "0.8.0",
-"stylelint": "7.8.0",
-"stylelint-config-wikimedia": "0.4.1"
+"grunt-stylelint": "0.9.0",
+"stylelint": "8.2.0",
+"stylelint-config-wikimedia": "0.4.2"
   }
 }

-- 
To view, visit https://gerrit.wikimedia.org/r/394605
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I78d2958cb3828f436eed7a0d9401b81201f4dc34
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Jforrester 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki/core[wmf/1.31.0-wmf.10]: HTMLMultiSelectField: Allow formatting in section headings i...

[Jforrester (Code Review)]

Jforrester has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/394339 )

Change subject: HTMLMultiSelectField: Allow formatting in section headings in 
OOUI mode
..

HTMLMultiSelectField: Allow formatting in section headings in OOUI mode

Follow-up to 5a113417e5af9d0d0dbed63429649a9780784d45.
It is allowed in non-OOUI modes.

Bug: T181698
Change-Id: Ib2ebcd1a92f1b02a528787fe3fd1f5452b9808c4
(cherry picked from commit f75232305410689a54c86fe327a40586eb459239)
---
M includes/htmlform/fields/HTMLMultiSelectField.php
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core 
refs/changes/39/394339/1

diff --git a/includes/htmlform/fields/HTMLMultiSelectField.php 
b/includes/htmlform/fields/HTMLMultiSelectField.php
index 238b2b4..09bacad 100644
--- a/includes/htmlform/fields/HTMLMultiSelectField.php
+++ b/includes/htmlform/fields/HTMLMultiSelectField.php
@@ -192,7 +192,7 @@
if ( $sectionLabel ) {
$out[] = new OOUI\FieldsetLayout( [
'items' => [ $widget ],
-   'label' => $sectionLabel,
+   'label' => new OOUI\HtmlSnippet( 
$sectionLabel ),
] );
} else {
$out[] = $widget;

-- 
To view, visit https://gerrit.wikimedia.org/r/394339
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib2ebcd1a92f1b02a528787fe3fd1f5452b9808c4
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: wmf/1.31.0-wmf.10
Gerrit-Owner: Jforrester 
Gerrit-Reviewer: Bartosz Dziewoński 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] oojs/ui[master]: [BREAKING CHANGE] icons: Drop 'watchlist', deprecated in v0....

[Jforrester (Code Review)]

Jforrester has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/394225 )

Change subject: [BREAKING CHANGE] icons: Drop 'watchlist', deprecated in v0.23.1
..

[BREAKING CHANGE] icons: Drop 'watchlist', deprecated in v0.23.1

Change-Id: I9b62d4b744234c68fde719389abc2813fb5581a0
---
M src/themes/apex/icons-interactions.json
M src/themes/wikimediaui/icons-interactions.json
2 files changed, 2 insertions(+), 14 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/oojs/ui refs/changes/25/394225/1

diff --git a/src/themes/apex/icons-interactions.json 
b/src/themes/apex/icons-interactions.json
index 602081f..0a1628d 100644
--- a/src/themes/apex/icons-interactions.json
+++ b/src/themes/apex/icons-interactions.json
@@ -60,12 +60,6 @@
}
},
"settings": { "file": "images/icons/settings.svg" },
-   "subtract": { "file": "images/icons/subtract.svg" },
-   "watchlist": { "file": {
-   "ltr": "images/icons/watchlist-ltr.svg",
-   "rtl": "images/icons/watchlist-rtl.svg"
-   },
-   "deprecated": "This will be removed in v0.24.0."
-   }
+   "subtract": { "file": "images/icons/subtract.svg" }
}
 }
diff --git a/src/themes/wikimediaui/icons-interactions.json 
b/src/themes/wikimediaui/icons-interactions.json
index 243637e..7d9ca98 100644
--- a/src/themes/wikimediaui/icons-interactions.json
+++ b/src/themes/wikimediaui/icons-interactions.json
@@ -83,12 +83,6 @@
}
},
"settings": { "file": "images/icons/settings.svg" },
-   "subtract": { "file": "images/icons/subtract.svg" },
-   "watchlist": { "file": {
-   "ltr": "images/icons/watchlist-ltr.svg",
-   "rtl": "images/icons/watchlist-rtl.svg"
-   },
-   "deprecated": "This will be removed in v0.24.0."
-   }
+   "subtract": { "file": "images/icons/subtract.svg" }
}
 }

-- 
To view, visit https://gerrit.wikimedia.org/r/394225
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I9b62d4b744234c68fde719389abc2813fb5581a0
Gerrit-PatchSet: 1
Gerrit-Project: oojs/ui
Gerrit-Branch: master
Gerrit-Owner: Jforrester 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: resources: Bump moment.js from 2.15.0 to 2.19.3

[Jforrester (Code Review)]

Jforrester has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/394103 )

Change subject: resources: Bump moment.js from 2.15.0 to 2.19.3
..

resources: Bump moment.js from 2.15.0 to 2.19.3

Languages and locales now with support:
* bm
* de-ch
* gom-latn
* gu
* kn
* sd
* tet
* ur
* uz-latn
* yo

Skipped languages because we don't support them in MW:
* ar-dz
* ar-kw
* ar-ly
* en-ie
* en-nz
* es-do
* es-us
* fr-ch
* me
* nl-be
* tlh
* tzl

Bug: T181547
Change-Id: I7f89569c6ee6640d368af1378e84c5a9e725dad0
---
M resources/Resources.php
M resources/lib/moment/LICENSE
A resources/lib/moment/README.md
M resources/lib/moment/locale/af.js
M resources/lib/moment/locale/ar-ma.js
M resources/lib/moment/locale/ar-sa.js
M resources/lib/moment/locale/ar-tn.js
M resources/lib/moment/locale/ar.js
M resources/lib/moment/locale/az.js
M resources/lib/moment/locale/be.js
M resources/lib/moment/locale/bg.js
A resources/lib/moment/locale/bm.js
M resources/lib/moment/locale/bn.js
M resources/lib/moment/locale/bo.js
M resources/lib/moment/locale/br.js
M resources/lib/moment/locale/bs.js
M resources/lib/moment/locale/ca.js
M resources/lib/moment/locale/cs.js
M resources/lib/moment/locale/cv.js
M resources/lib/moment/locale/cy.js
M resources/lib/moment/locale/da.js
M resources/lib/moment/locale/de-at.js
A resources/lib/moment/locale/de-ch.js
M resources/lib/moment/locale/de.js
M resources/lib/moment/locale/dv.js
M resources/lib/moment/locale/el.js
M resources/lib/moment/locale/en-au.js
M resources/lib/moment/locale/en-ca.js
M resources/lib/moment/locale/en-gb.js
M resources/lib/moment/locale/eo.js
M resources/lib/moment/locale/es.js
M resources/lib/moment/locale/et.js
M resources/lib/moment/locale/eu.js
M resources/lib/moment/locale/fa.js
M resources/lib/moment/locale/fi.js
M resources/lib/moment/locale/fo.js
M resources/lib/moment/locale/fr-ca.js
M resources/lib/moment/locale/fr.js
M resources/lib/moment/locale/fy.js
M resources/lib/moment/locale/gd.js
M resources/lib/moment/locale/gl.js
A resources/lib/moment/locale/gom-latn.js
A resources/lib/moment/locale/gu.js
M resources/lib/moment/locale/he.js
M resources/lib/moment/locale/hi.js
M resources/lib/moment/locale/hr.js
M resources/lib/moment/locale/hu.js
M resources/lib/moment/locale/hy-am.js
M resources/lib/moment/locale/id.js
M resources/lib/moment/locale/is.js
M resources/lib/moment/locale/it.js
M resources/lib/moment/locale/ja.js
M resources/lib/moment/locale/jv.js
M resources/lib/moment/locale/ka.js
M resources/lib/moment/locale/kk.js
M resources/lib/moment/locale/km.js
A resources/lib/moment/locale/kn.js
M resources/lib/moment/locale/ko.js
M resources/lib/moment/locale/ky.js
M resources/lib/moment/locale/lb.js
M resources/lib/moment/locale/lo.js
M resources/lib/moment/locale/lt.js
M resources/lib/moment/locale/lv.js
M resources/lib/moment/locale/mi.js
M resources/lib/moment/locale/mk.js
M resources/lib/moment/locale/ml.js
M resources/lib/moment/locale/mr.js
M resources/lib/moment/locale/ms-my.js
M resources/lib/moment/locale/ms.js
M resources/lib/moment/locale/my.js
M resources/lib/moment/locale/nb.js
M resources/lib/moment/locale/ne.js
M resources/lib/moment/locale/nl.js
M resources/lib/moment/locale/nn.js
M resources/lib/moment/locale/pa-in.js
M resources/lib/moment/locale/pl.js
M resources/lib/moment/locale/pt-br.js
M resources/lib/moment/locale/pt.js
M resources/lib/moment/locale/ro.js
M resources/lib/moment/locale/ru.js
A resources/lib/moment/locale/sd.js
M resources/lib/moment/locale/se.js
M resources/lib/moment/locale/si.js
M resources/lib/moment/locale/sk.js
M resources/lib/moment/locale/sl.js
M resources/lib/moment/locale/sq.js
M resources/lib/moment/locale/sr-cyrl.js
M resources/lib/moment/locale/sr.js
M resources/lib/moment/locale/ss.js
M resources/lib/moment/locale/sv.js
M resources/lib/moment/locale/sw.js
M resources/lib/moment/locale/ta.js
M resources/lib/moment/locale/te.js
A resources/lib/moment/locale/tet.js
M resources/lib/moment/locale/th.js
M resources/lib/moment/locale/tl-ph.js
M resources/lib/moment/locale/tr.js
M resources/lib/moment/locale/tzm-latn.js
M resources/lib/moment/locale/tzm.js
M resources/lib/moment/locale/uk.js
A resources/lib/moment/locale/ur.js
A resources/lib/moment/locale/uz-latn.js
M resources/lib/moment/locale/uz.js
M resources/lib/moment/locale/vi.js
M resources/lib/moment/locale/x-pseudo.js
A resources/lib/moment/locale/yo.js
M resources/lib/moment/locale/zh-cn.js
M resources/lib/moment/locale/zh-hk.js
M resources/lib/moment/locale/zh-tw.js
M resources/lib/moment/moment.js
110 files changed, 12,500 insertions(+), 11,159 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core 
refs/changes/03/394103/1


-- 
To view, visit https://gerrit.wikimedia.org/r/394103
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I7f89569c6ee6640d368af1378e84c5a9e725dad0
Gerrit-PatchSet: 1

[MediaWiki-commits] [Gerrit] mediawiki...TimedMediaHandler[master]: Enable MP3 upload ingestion by default

[Jforrester (Code Review)]

Jforrester has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/393974 )

Change subject: Enable MP3 upload ingestion by default
..

Enable MP3 upload ingestion by default

This is set to false by default on Wikimedia wikis, so doesn't need
to also be set false here.

Change-Id: Id55b47d12f856842f45d602ccba490188846f9ea
---
M TimedMediaHandler.php
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull 
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/TimedMediaHandler 
refs/changes/74/393974/1

diff --git a/TimedMediaHandler.php b/TimedMediaHandler.php
index 80b410d..1f912cc 100644
--- a/TimedMediaHandler.php
+++ b/TimedMediaHandler.php
@@ -232,7 +232,7 @@
 ];
 
 // If mp3 source assets can be ingested:
-$wgTmhEnableMp3Uploads = false;
+$wgTmhEnableMp3Uploads = true;
 
 // If mp4 source assets can be ingested:
 $wgTmhEnableMp4Uploads = false;

-- 
To view, visit https://gerrit.wikimedia.org/r/393974
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Id55b47d12f856842f45d602ccba490188846f9ea
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/TimedMediaHandler
Gerrit-Branch: master
Gerrit-Owner: Jforrester 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...TimedMediaHandler[master]: Remove ability to disable MP3 ingestion

[Jforrester (Code Review)]

Jforrester has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/393975 )

Change subject: Remove ability to disable MP3 ingestion
..

Remove ability to disable MP3 ingestion

Change-Id: I3f1c9f93b2231d5c65c8b2821b6fd29f0e2c8623
---
M TimedMediaHandler.hooks.php
M TimedMediaHandler.php
2 files changed, 1 insertion(+), 12 deletions(-)


  git pull 
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/TimedMediaHandler 
refs/changes/75/393975/1

diff --git a/TimedMediaHandler.hooks.php b/TimedMediaHandler.hooks.php
index 175c5e1..94fec8a 100644
--- a/TimedMediaHandler.hooks.php
+++ b/TimedMediaHandler.hooks.php
@@ -206,7 +206,7 @@
public static function register() {
global $wgHooks, $wgJobClasses, 
$wgJobTypesExcludedFromDefaultQueue, $wgMediaHandlers,
$wgResourceModules, $wgExcludeFromThumbnailPurge,
-   $wgFileExtensions, $wgTmhEnableMp3Uploads, 
$wgTmhEnableMp4Uploads, $wgExtensionAssetsPath,
+   $wgFileExtensions, $wgTmhEnableMp4Uploads, 
$wgExtensionAssetsPath,
$wgMwEmbedModuleConfig, $wgEnableLocalTimedText, 
$wgTmhFileExtensions,
$wgTmhTheoraTwoPassEncoding, $wgWikimediaJenkinsCI;
 
@@ -215,14 +215,6 @@
global $wgEnableTranscode, $wgFFmpegLocation;
$wgEnableTranscode = false;
$wgFFmpegLocation = '/usr/bin/ffmpeg';
-   }
-
-   // Remove mp3 if not enabled:
-   if ( $wgTmhEnableMp3Uploads === false ) {
-   $index = array_search( 'mp3', $wgFileExtensions );
-   if ( $index !== false ) {
-   array_splice( $wgFileExtensions, $index, 1 );
-   }
}
 
// Remove mp4 if not enabled:
diff --git a/TimedMediaHandler.php b/TimedMediaHandler.php
index 1f912cc..76a9a88 100644
--- a/TimedMediaHandler.php
+++ b/TimedMediaHandler.php
@@ -231,9 +231,6 @@
// WebVideoTranscode::ENC_AAC,
 ];
 
-// If mp3 source assets can be ingested:
-$wgTmhEnableMp3Uploads = true;
-
 // If mp4 source assets can be ingested:
 $wgTmhEnableMp4Uploads = false;
 

-- 
To view, visit https://gerrit.wikimedia.org/r/393975
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I3f1c9f93b2231d5c65c8b2821b6fd29f0e2c8623
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/TimedMediaHandler
Gerrit-Branch: master
Gerrit-Owner: Jforrester 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...Translate[master]: Drop `-webkit-linear-gradient` image CSS fallback

[Jforrester (Code Review)]

Jforrester has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/393969 )

Change subject: Drop `-webkit-linear-gradient` image CSS fallback
..

Drop `-webkit-linear-gradient` image CSS fallback

This reduces the payload of CSS slightly (and in the few cases where these
were not just present but @embed'ed, significantly), at a cost of giving
those user agents which don't support the un-prefixed rule the icons as
PNGs rather than SVGs (i.e. Chrome < 25, Safari < 6.1, Android < 4.4).

We made this change for MediaWiki back in November 2015 in T118815. This
repo is not alone in not having noticed. :-) Ideally this repo would use
LESS and re-use the LESS macro in MediaWiki, but that's for the future.

Change-Id: I1469bce3dd6c6eed0d291a0cb8a19eceeaff4c10
---
M resources/css/ext.translate.editor.css
M resources/css/ext.translate.groupselector.css
M resources/css/ext.translate.loader.css
M resources/css/ext.translate.navitoggle.css
M resources/css/ext.translate.pagemode.css
M resources/css/ext.translate.proofread.css
M resources/css/ext.translate.special.aggregategroups.css
M resources/css/ext.translate.special.managetranslatorsandbox.css
M resources/css/ext.translate.special.pagemigration.css
M resources/css/ext.translate.special.translate.css
M resources/css/ext.translate.workflowselector.css
M resources/js/ext.translate.groupselector.js
12 files changed, 1 insertion(+), 38 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Translate 
refs/changes/69/393969/1

diff --git a/resources/css/ext.translate.editor.css 
b/resources/css/ext.translate.editor.css
index e2aeb0f..982499c 100644
--- a/resources/css/ext.translate.editor.css
+++ b/resources/css/ext.translate.editor.css
@@ -8,7 +8,6 @@
 
 .grid .tux-message-editor .close {
background: url( ../images/close.png ) no-repeat center center;
-   background-image: -webkit-linear-gradient( transparent, transparent ), 
url( ../images/close.svg );
/* @embed */
background-image: linear-gradient( transparent, transparent ), url( 
../images/close.svg );
padding: 16px;
@@ -25,14 +24,12 @@
 
 .tux-message-editor .editor-contract {
background: url( ../images/contract-ltr.png ) no-repeat center center;
-   background-image: -webkit-linear-gradient( transparent, transparent ), 
url( ../images/contract-ltr.svg );
/* @embed */
background-image: linear-gradient( transparent, transparent ), url( 
../images/contract-ltr.svg );
 }
 
 .tux-message-editor .editor-expand {
background: url( ../images/expand-ltr.png ) no-repeat center center;
-   background-image: -webkit-linear-gradient( transparent, transparent ), 
url( ../images/expand-ltr.svg );
/* @embed */
background-image: linear-gradient( transparent, transparent ), url( 
../images/expand-ltr.svg );
 }
@@ -230,7 +227,6 @@
 
 .message-desc-edit {
background: url( ../images/action-edit.png ) left center no-repeat;
-   background-image: -webkit-linear-gradient( transparent, transparent ), 
url( ../images/action-edit.svg );
/* @embed */
background-image: linear-gradient( transparent, transparent ), url( 
../images/action-edit.svg );
background-size: 18px 18px;
@@ -319,14 +315,12 @@
 
 .tux-warning-message.validation {
background-image: url( ../images/label-flag.png );
-   background-image: -webkit-linear-gradient( transparent, transparent ), 
url( ../images/label-flag.svg );
/* @embed */
background-image: linear-gradient( transparent, transparent ), url( 
../images/label-flag.svg );
 }
 
 .tux-warning-message.diff {
background-image: url( ../images/label-clock.png );
-   background-image: -webkit-linear-gradient( transparent, transparent ), 
url( ../images/label-clock.svg );
/* @embed */
background-image: linear-gradient( transparent, transparent ), url( 
../images/label-clock.svg );
 }
@@ -395,7 +389,6 @@
 
 .tux-editor-insert-buttons .tux-editor-paste-original-button {
background: #fbfbfb url( ../images/paste.png ) left center no-repeat;
-   background-image: -webkit-linear-gradient( transparent, transparent ), 
url( ../images/paste.svg );
/* @embed */
background-image: linear-gradient( transparent, transparent ), url( 
../images/paste.svg );
background-size: 16px 16px;
@@ -434,7 +427,6 @@
 
 .tux-message-tools-menu li.selected {
background: url( ../images/label-tick.png ) right no-repeat;
-   background-image: -webkit-linear-gradient( transparent, transparent ), 
url( ../images/label-tick.svg );
/* @embed */
background-image: linear-gradient( transparent, transparent ), url( 
../images/label-tick.svg );
color: #222;
diff --git a/resources/css/ext.translate.groupselector.css 
b/resources/css/ext.translate.groupselector.css
index 11d60d1..95b039e 100644
--- 

[MediaWiki-commits] [Gerrit] mediawiki...VisualEditor[master]: Update VE core submodule to master (49b182123)

[Jforrester (Code Review)]

Jforrester has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/393968 )

Change subject: Update VE core submodule to master (49b182123)
..

Update VE core submodule to master (49b182123)

New changes:
3fa757520 ce.Surface: support formatted google docs paste content again
52d849e6b ce.Surface: more tests for Google Docs pasting
49b182123 Update OOjs UI to v0.24.3

Bug: T145252
Change-Id: I5ceeeae946873cd1fdc692ce37c81b22e1973a89
---
M lib/ve
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/VisualEditor 
refs/changes/68/393968/1

diff --git a/lib/ve b/lib/ve
index 56cfb5d..49b1821 16
--- a/lib/ve
+++ b/lib/ve
@@ -1 +1 @@
-Subproject commit 56cfb5d6f290563069d257cbf72e1a534e0bbc13
+Subproject commit 49b1821234cd99a463a46337cf0ae0e000daea91

-- 
To view, visit https://gerrit.wikimedia.org/r/393968
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I5ceeeae946873cd1fdc692ce37c81b22e1973a89
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Jforrester 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki/vendor[master]: Update OOjs UI to v0.24.3

[Jforrester (Code Review)]

Jforrester has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/393957 )

Change subject: Update OOjs UI to v0.24.3
..

Update OOjs UI to v0.24.3

Release notes:
 
https://phabricator.wikimedia.org/diffusion/GOJU/browse/master/History.md;v0.24.3

Change-Id: Ifdd44ead7d782288aaef0979322f0943f7304853
---
M composer.json
M composer.lock
M composer/installed.json
M oojs/oojs-ui/History.md
M oojs/oojs-ui/README.md
M oojs/oojs-ui/bin/testsuitegenerator.rb
M oojs/oojs-ui/demos/demo.js
M oojs/oojs-ui/i18n/lv.json
M oojs/oojs-ui/i18n/sl.json
M oojs/oojs-ui/i18n/sr-ec.json
M oojs/oojs-ui/i18n/sr-el.json
M oojs/oojs-ui/i18n/ur.json
M oojs/oojs-ui/package.json
M oojs/oojs-ui/php/widgets/TextInputWidget.php
14 files changed, 173 insertions(+), 104 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/vendor 
refs/changes/57/393957/1

diff --git a/composer.json b/composer.json
index d90bc77..0a7f405 100644
--- a/composer.json
+++ b/composer.json
@@ -83,7 +83,7 @@
"mustangostang/spyc": "0.6.2",
"nikic/php-parser": "3.0.6",
"nmred/kafka-php": "0.1.5",
-   "oojs/oojs-ui": "0.24.2",
+   "oojs/oojs-ui": "0.24.3",
"oyejorge/less.php": "1.7.0.14",
"pear/console_getopt": "1.4.1",
"pear/mail": "1.4.1",
diff --git a/composer.lock b/composer.lock
index 7a7e842..ad4345b 100644
--- a/composer.lock
+++ b/composer.lock
@@ -4,7 +4,7 @@
 "Read more about it at 
https://getcomposer.org/doc/01-basic-usage.md#composer-lock-the-lock-file;,
 "This file is @generated automatically"
 ],
-"content-hash": "27b864cad3750d7557cd5dae84899c82",
+"content-hash": "e948033dcea38ac3c205abf7e2e274f7",
 "packages": [
 {
 "name": "composer/semver",
@@ -1245,16 +1245,16 @@
 },
 {
 "name": "oojs/oojs-ui",
-"version": "v0.24.2",
+"version": "v0.24.3",
 "source": {
 "type": "git",
 "url": "https://github.com/wikimedia/oojs-ui.git;,
-"reference": "b6d9d5e50940a7c56d329a605c64d51f147aab80"
+"reference": "a48d69b22bf89b87f2f931a4c23401e6214562d4"
 },
 "dist": {
 "type": "zip",
-"url": 
"https://api.github.com/repos/wikimedia/oojs-ui/zipball/b6d9d5e50940a7c56d329a605c64d51f147aab80;,
-"reference": "b6d9d5e50940a7c56d329a605c64d51f147aab80",
+"url": 
"https://api.github.com/repos/wikimedia/oojs-ui/zipball/a48d69b22bf89b87f2f931a4c23401e6214562d4;,
+"reference": "a48d69b22bf89b87f2f931a4c23401e6214562d4",
 "shasum": ""
 },
 "require": {
@@ -1320,7 +1320,7 @@
 ],
 "description": "Provides library of common widgets, layouts, and 
windows.",
 "homepage": "https://www.mediawiki.org/wiki/OOjs_UI;,
-"time": "2017-11-07T21:27:09+00:00"
+"time": "2017-11-28T23:14:25+00:00"
 },
 {
 "name": "oyejorge/less.php",
diff --git a/composer/installed.json b/composer/installed.json
index 10d56f4..c031f43 100644
--- a/composer/installed.json
+++ b/composer/installed.json
@@ -3205,87 +3205,6 @@
 ]
 },
 {
-"name": "oojs/oojs-ui",
-"version": "v0.24.2",
-"version_normalized": "0.24.2.0",
-"source": {
-"type": "git",
-"url": "https://github.com/wikimedia/oojs-ui.git;,
-"reference": "b6d9d5e50940a7c56d329a605c64d51f147aab80"
-},
-"dist": {
-"type": "zip",
-"url": 
"https://api.github.com/repos/wikimedia/oojs-ui/zipball/b6d9d5e50940a7c56d329a605c64d51f147aab80;,
-"reference": "b6d9d5e50940a7c56d329a605c64d51f147aab80",
-"shasum": ""
-},
-"require": {
-"mediawiki/at-ease": "1.1.0",
-"php": ">=5.5.9"
-},
-"require-dev": {
-"jakub-onderka/php-parallel-lint": "0.9.2",
-"mediawiki/mediawiki-codesniffer": "14.1.0",
-"phpunit/phpunit": "4.8.21"
-},
-"time": "2017-11-07T21:27:09+00:00",
-"type": "library",
-"installation-source": "dist",
-"autoload": {
-"classmap": [
-"php/"
-]
-},
-"notification-url": "https://packagist.org/downloads/;,
-"license": [
-"MIT"
-],
-"authors": [
-{
-"name": "Timo Tijhof",
-"email": "krinklem...@gmail.com"
-},
-{
-"name": "Bartosz Dziewoński",
-"email": "matma@gmail.com"
-},
-{
-"name": "Ed Sanders",
-"email": 

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Update OOjs UI to v0.24.3

[Jforrester (Code Review)]

Jforrester has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/393958 )

Change subject: Update OOjs UI to v0.24.3
..

Update OOjs UI to v0.24.3

Release notes:
 
https://phabricator.wikimedia.org/diffusion/GOJU/browse/master/History.md;v0.24.3

Depends-On: Ifdd44ead7d782288aaef0979322f0943f7304853
Change-Id: Ifdd44ead7d782288aaef0979322f0943f7304835
---
M composer.json
M resources/lib/oojs-ui/i18n/lv.json
M resources/lib/oojs-ui/i18n/sl.json
M resources/lib/oojs-ui/i18n/sr-ec.json
M resources/lib/oojs-ui/i18n/sr-el.json
M resources/lib/oojs-ui/i18n/ur.json
M resources/lib/oojs-ui/oojs-ui-apex.js
M resources/lib/oojs-ui/oojs-ui-core-apex.css
M resources/lib/oojs-ui/oojs-ui-core-wikimediaui.css
M resources/lib/oojs-ui/oojs-ui-core.js
M resources/lib/oojs-ui/oojs-ui-core.js.map
M resources/lib/oojs-ui/oojs-ui-toolbars-apex.css
M resources/lib/oojs-ui/oojs-ui-toolbars-wikimediaui.css
M resources/lib/oojs-ui/oojs-ui-toolbars.js
M resources/lib/oojs-ui/oojs-ui-toolbars.js.map
M resources/lib/oojs-ui/oojs-ui-widgets-apex.css
M resources/lib/oojs-ui/oojs-ui-widgets-wikimediaui.css
M resources/lib/oojs-ui/oojs-ui-widgets.js
M resources/lib/oojs-ui/oojs-ui-widgets.js.map
M resources/lib/oojs-ui/oojs-ui-wikimediaui.js
M resources/lib/oojs-ui/oojs-ui-windows-apex.css
M resources/lib/oojs-ui/oojs-ui-windows-wikimediaui.css
M resources/lib/oojs-ui/oojs-ui-windows.js
M resources/lib/oojs-ui/wikimedia-ui-base.less
24 files changed, 472 insertions(+), 167 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core 
refs/changes/58/393958/1


-- 
To view, visit https://gerrit.wikimedia.org/r/393958
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ifdd44ead7d782288aaef0979322f0943f7304835
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Jforrester 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] VisualEditor/VisualEditor[master]: Update OOjs UI to v0.24.3

[Jforrester (Code Review)]

Jforrester has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/393955 )

Change subject: Update OOjs UI to v0.24.3
..

Update OOjs UI to v0.24.3

Release notes:
 
https://phabricator.wikimedia.org/diffusion/GOJU/browse/master/History.md;v0.24.3

Change-Id: I866ad3f0b16086dce6f3e48d91fec7a3728bd0ff
---
M lib/oojs-ui/README.md
M lib/oojs-ui/i18n/lv.json
M lib/oojs-ui/i18n/sl.json
M lib/oojs-ui/i18n/sr-ec.json
M lib/oojs-ui/i18n/sr-el.json
M lib/oojs-ui/i18n/ur.json
M lib/oojs-ui/oojs-ui-apex-icons-accessibility.css
M lib/oojs-ui/oojs-ui-apex-icons-accessibility.rtl.css
M lib/oojs-ui/oojs-ui-apex-icons-alerts.css
M lib/oojs-ui/oojs-ui-apex-icons-alerts.rtl.css
M lib/oojs-ui/oojs-ui-apex-icons-content.css
M lib/oojs-ui/oojs-ui-apex-icons-content.rtl.css
M lib/oojs-ui/oojs-ui-apex-icons-editing-advanced.css
M lib/oojs-ui/oojs-ui-apex-icons-editing-advanced.rtl.css
M lib/oojs-ui/oojs-ui-apex-icons-editing-core.css
M lib/oojs-ui/oojs-ui-apex-icons-editing-core.rtl.css
M lib/oojs-ui/oojs-ui-apex-icons-editing-list.css
M lib/oojs-ui/oojs-ui-apex-icons-editing-list.rtl.css
M lib/oojs-ui/oojs-ui-apex-icons-editing-styling.css
M lib/oojs-ui/oojs-ui-apex-icons-editing-styling.rtl.css
M lib/oojs-ui/oojs-ui-apex-icons-interactions.css
M lib/oojs-ui/oojs-ui-apex-icons-interactions.rtl.css
M lib/oojs-ui/oojs-ui-apex-icons-layout.css
M lib/oojs-ui/oojs-ui-apex-icons-layout.rtl.css
M lib/oojs-ui/oojs-ui-apex-icons-media.css
M lib/oojs-ui/oojs-ui-apex-icons-media.rtl.css
M lib/oojs-ui/oojs-ui-apex-icons-moderation.css
M lib/oojs-ui/oojs-ui-apex-icons-moderation.rtl.css
M lib/oojs-ui/oojs-ui-apex-icons-movement.css
M lib/oojs-ui/oojs-ui-apex-icons-movement.rtl.css
M lib/oojs-ui/oojs-ui-apex-icons-user.css
M lib/oojs-ui/oojs-ui-apex-icons-user.rtl.css
M lib/oojs-ui/oojs-ui-apex.css
M lib/oojs-ui/oojs-ui-apex.js
M lib/oojs-ui/oojs-ui-apex.rtl.css
M lib/oojs-ui/oojs-ui-core-apex.css
M lib/oojs-ui/oojs-ui-core-apex.rtl.css
M lib/oojs-ui/oojs-ui-core-wikimediaui.css
M lib/oojs-ui/oojs-ui-core-wikimediaui.rtl.css
M lib/oojs-ui/oojs-ui-core.js
M lib/oojs-ui/oojs-ui-core.js.map
M lib/oojs-ui/oojs-ui-images-apex.css
M lib/oojs-ui/oojs-ui-images-apex.rtl.css
M lib/oojs-ui/oojs-ui-images-wikimediaui.css
M lib/oojs-ui/oojs-ui-images-wikimediaui.rtl.css
M lib/oojs-ui/oojs-ui-toolbars-apex.css
M lib/oojs-ui/oojs-ui-toolbars-apex.rtl.css
M lib/oojs-ui/oojs-ui-toolbars-wikimediaui.css
M lib/oojs-ui/oojs-ui-toolbars-wikimediaui.rtl.css
M lib/oojs-ui/oojs-ui-toolbars.js
M lib/oojs-ui/oojs-ui-toolbars.js.map
M lib/oojs-ui/oojs-ui-widgets-apex.css
M lib/oojs-ui/oojs-ui-widgets-apex.rtl.css
M lib/oojs-ui/oojs-ui-widgets-wikimediaui.css
M lib/oojs-ui/oojs-ui-widgets-wikimediaui.rtl.css
M lib/oojs-ui/oojs-ui-widgets.js
M lib/oojs-ui/oojs-ui-widgets.js.map
M lib/oojs-ui/oojs-ui-wikimediaui-icons-accessibility.css
M lib/oojs-ui/oojs-ui-wikimediaui-icons-accessibility.rtl.css
M lib/oojs-ui/oojs-ui-wikimediaui-icons-alerts.css
M lib/oojs-ui/oojs-ui-wikimediaui-icons-alerts.rtl.css
M lib/oojs-ui/oojs-ui-wikimediaui-icons-content.css
M lib/oojs-ui/oojs-ui-wikimediaui-icons-content.rtl.css
M lib/oojs-ui/oojs-ui-wikimediaui-icons-editing-advanced.css
M lib/oojs-ui/oojs-ui-wikimediaui-icons-editing-advanced.rtl.css
M lib/oojs-ui/oojs-ui-wikimediaui-icons-editing-core.css
M lib/oojs-ui/oojs-ui-wikimediaui-icons-editing-core.rtl.css
M lib/oojs-ui/oojs-ui-wikimediaui-icons-editing-list.css
M lib/oojs-ui/oojs-ui-wikimediaui-icons-editing-list.rtl.css
M lib/oojs-ui/oojs-ui-wikimediaui-icons-editing-styling.css
M lib/oojs-ui/oojs-ui-wikimediaui-icons-editing-styling.rtl.css
M lib/oojs-ui/oojs-ui-wikimediaui-icons-interactions.css
M lib/oojs-ui/oojs-ui-wikimediaui-icons-interactions.rtl.css
M lib/oojs-ui/oojs-ui-wikimediaui-icons-layout.css
M lib/oojs-ui/oojs-ui-wikimediaui-icons-layout.rtl.css
M lib/oojs-ui/oojs-ui-wikimediaui-icons-location.css
M lib/oojs-ui/oojs-ui-wikimediaui-icons-location.rtl.css
M lib/oojs-ui/oojs-ui-wikimediaui-icons-media.css
M lib/oojs-ui/oojs-ui-wikimediaui-icons-media.rtl.css
M lib/oojs-ui/oojs-ui-wikimediaui-icons-moderation.css
M lib/oojs-ui/oojs-ui-wikimediaui-icons-moderation.rtl.css
M lib/oojs-ui/oojs-ui-wikimediaui-icons-movement.css
M lib/oojs-ui/oojs-ui-wikimediaui-icons-movement.rtl.css
M lib/oojs-ui/oojs-ui-wikimediaui-icons-user.css
M lib/oojs-ui/oojs-ui-wikimediaui-icons-user.rtl.css
M lib/oojs-ui/oojs-ui-wikimediaui-icons-wikimedia.css
M lib/oojs-ui/oojs-ui-wikimediaui-icons-wikimedia.rtl.css
M lib/oojs-ui/oojs-ui-wikimediaui.css
M lib/oojs-ui/oojs-ui-wikimediaui.js
M lib/oojs-ui/oojs-ui-wikimediaui.rtl.css
M lib/oojs-ui/oojs-ui-windows-apex.css
M lib/oojs-ui/oojs-ui-windows-apex.rtl.css
M lib/oojs-ui/oojs-ui-windows-wikimediaui.css
M lib/oojs-ui/oojs-ui-windows-wikimediaui.rtl.css
M lib/oojs-ui/oojs-ui-windows.js
M lib/oojs-ui/wikimedia-ui-base.less
96 files changed, 807 insertions(+), 4,868 deletions(-)


  git pull 

[MediaWiki-commits] [Gerrit] oojs/ui[master]: Tag v0.24.3

[Jforrester (Code Review)]

Jforrester has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/393931 )

Change subject: Tag v0.24.3
..

Tag v0.24.3

Change-Id: Ifc9d08232bcee4c91e0b6f02ee28cd31e189cbd5
---
M History.md
M package.json
2 files changed, 27 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/oojs/ui refs/changes/31/393931/1

diff --git a/History.md b/History.md
index 1ee8904..31b64ef 100644
--- a/History.md
+++ b/History.md
@@ -1,4 +1,30 @@
 # OOjs UI Release History
+## v0.24.3 / 2017-11-28
+### Features
+* Allow adding virtual viewport spacing (Bartosz Dziewoński)
+* ClippableElement: Allow clipping with top or left edge (Bartosz Dziewoński)
+* DropdownInputWidget: Generate a hidden `` in JS (Bartosz Dziewoński)
+* FieldsetLayout: Hide header when there is no icon or label (Bartosz 
Dziewoński)
+* MenuSelectWidget, PopupWidget: Automatically change popup direction if there 
is no space (Bartosz Dziewoński)
+* PopupToolGroup: Set clipping edges to fix clipping edge (heh) cases (Bartosz 
Dziewoński)
+* TextInputWidget: support spellcheck attribute (David Lynch)
+
+### Styles
+* themes: Fix PHP ComboboxInputWidget indicator position (Volker E.)
+* WikimediaUI theme: Restore `:hover:focus` border color on TextInputWidgets 
(Volker E.)
+* oo-ui-background-image: Drop `-o-linear-gradient` fallback (James D. 
Forrester)
+* oo-ui-background-image: Drop `-webkit-linear-gradient` fallback (James D. 
Forrester)
+
+### Code
+* PHP DropdownInputWidget: Firefox 57 ignores hack with whitespace (Volker E.)
+* DraggableGroupElement: Don't try to access non-existent property (Bartosz 
Dziewoński)
+* DropdownInputWidget: Remove duplicate TitledElement mixin (Bartosz 
Dziewoński)
+* README: Add "Community" section (Prateek Saxena)
+* README: Re-arrange intro section (Prateek Saxena)
+* build: Bump wikimedia-ui-base (Volker E.)
+* git.wikimedia.org -> phab (Zach)
+
+
 ## v0.24.2 / 2017-11-07
 ### Deprecations
 * [DEPRECATING CHANGE] Use en-US spelling for icon names for consistency (Ed 
Sanders)
diff --git a/package.json b/package.json
index 12ddd21..0e10483 100644
--- a/package.json
+++ b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "oojs-ui",
-  "version": "0.24.2",
+  "version": "0.24.3",
   "description": "User interface classes built on the OOjs framework.",
   "keywords": [
 "oojs-plugin",

-- 
To view, visit https://gerrit.wikimedia.org/r/393931
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ifc9d08232bcee4c91e0b6f02ee28cd31e189cbd5
Gerrit-PatchSet: 1
Gerrit-Project: oojs/ui
Gerrit-Branch: master
Gerrit-Owner: Jforrester 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...Flow[master]: Delete Ruby Selenium tests

[Jforrester (Code Review)]

Jforrester has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/393917 )

Change subject: Delete Ruby Selenium tests
..

Delete Ruby Selenium tests

These aren't being run, the Ruby framework is deprecated, and the
entire front-end of Structured Discussions is being re-written, so
it's a lot simpler to remove them now and re-add them based on the
node selenium test system with the new UI.

Bug: T164479
Change-Id: I236fc83557290323c5168ec1292084624be64f56
---
M Gemfile
M Gemfile.lock
M Rakefile
D tests/browser/README.md
D tests/browser/ci.yml
D tests/browser/environments.yml
D tests/browser/features/action_menu_permalink.feature
D tests/browser/features/anon_interface.feature
D tests/browser/features/categories.feature
D tests/browser/features/description.feature
D tests/browser/features/edit_existing.feature
D tests/browser/features/flow_in_recent_changes.feature
D tests/browser/features/flow_logged_in.feature
D tests/browser/features/flow_no_javascript.feature
D tests/browser/features/moderation.feature
D tests/browser/features/new_topic.feature
D tests/browser/features/opt_in.feature
D tests/browser/features/post_links.feature
D tests/browser/features/preload.feature
D tests/browser/features/reopen_topic.feature
D tests/browser/features/reply.feature
D tests/browser/features/reply_moderation.feature
D tests/browser/features/resolve_topic.feature
D tests/browser/features/sorting_topics.feature
D tests/browser/features/special_enableflow.feature
D tests/browser/features/step_definitions/action_menu_permalink_steps.rb
D tests/browser/features/step_definitions/api_steps.rb
D tests/browser/features/step_definitions/categories_steps.rb
D tests/browser/features/step_definitions/description_steps.rb
D tests/browser/features/step_definitions/edit_existing_steps.rb
D tests/browser/features/step_definitions/flow_in_recent_changes_steps.rb
D tests/browser/features/step_definitions/flow_no_javascript_steps.rb
D tests/browser/features/step_definitions/flow_steps.rb
D tests/browser/features/step_definitions/moderation_steps.rb
D tests/browser/features/step_definitions/new_topic_steps.rb
D tests/browser/features/step_definitions/opt_in_steps.rb
D tests/browser/features/step_definitions/preload_steps.rb
D tests/browser/features/step_definitions/reply_moderation_steps.rb
D tests/browser/features/step_definitions/reply_steps.rb
D tests/browser/features/step_definitions/resolve_reopen_steps.rb
D tests/browser/features/step_definitions/sorting_topics_steps.rb
D tests/browser/features/step_definitions/special_enable_flow_steps.rb
D tests/browser/features/step_definitions/suppress_steps.rb
D tests/browser/features/step_definitions/thank_steps.rb
D tests/browser/features/step_definitions/undo_actions.rb
D tests/browser/features/step_definitions/watch_steps.rb
D tests/browser/features/summarize.feature
D tests/browser/features/support/components/board_description.rb
D tests/browser/features/support/components/flow_editor.rb
D tests/browser/features/support/data_manager.rb
D tests/browser/features/support/env.rb
D tests/browser/features/support/extensions.rb
D tests/browser/features/support/hooks.rb
D tests/browser/features/support/pages/abstract_flow_page.rb
D tests/browser/features/support/pages/board_history_page.rb
D tests/browser/features/support/pages/flow_component.rb
D tests/browser/features/support/pages/flow_diff_page.rb
D tests/browser/features/support/pages/flow_old_permalink_page.rb
D tests/browser/features/support/pages/flow_page.rb
D tests/browser/features/support/pages/new_flow_page.rb
D tests/browser/features/support/pages/preloaded_flow_page.rb
D tests/browser/features/support/pages/recent_changes_page.rb
D tests/browser/features/support/pages/special_enable_flow_archive_page.rb
D tests/browser/features/support/pages/special_enable_flow_confirmation_page.rb
D tests/browser/features/support/pages/special_enable_flow_page.rb
D tests/browser/features/support/pages/special_notifications_page.rb
D tests/browser/features/support/pages/special_preferences_page.rb
D tests/browser/features/support/pages/topic_history_page.rb
D tests/browser/features/support/pages/user_page.rb
D tests/browser/features/support/pages/user_talk_page.rb
D tests/browser/features/support/pages/wiki_page.rb
D tests/browser/features/suppress.feature
D tests/browser/features/thank.feature
D tests/browser/features/undo.feature
D tests/browser/features/watch.feature
75 files changed, 1 insertion(+), 2,547 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Flow 
refs/changes/17/393917/1

diff --git a/Gemfile b/Gemfile
index b5a3497..942680a 100644
--- a/Gemfile
+++ b/Gemfile
@@ -1,6 +1,5 @@
 source "https://rubygems.org;
 
 gem "csscss", "~> 1.3.3"
-gem 'mediawiki_selenium', '~> 1.8'
 gem 'rake', '~> 11.1', '>= 11.1.1'
 gem "rubocop", "~> 0.32.1", require: false
diff --git a/Gemfile.lock b/Gemfile.lock
index 5e814ab..81120cd 100644
--- 

[MediaWiki-commits] [Gerrit] mediawiki...Flow[master]: build: Bump Ruby cruft to avoid security warnings for old ru...

[Jforrester (Code Review)]

Jforrester has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/393918 )

Change subject: build: Bump Ruby cruft to avoid security warnings for old 
rubocop
..

build: Bump Ruby cruft to avoid security warnings for old rubocop

So. Much. Cruft.

Change-Id: I27299ac709aa6ba772b2fc5ee9dc976ad4bb07d3
---
M .rubocop.yml
M .rubocop_todo.yml
M Gemfile
M Gemfile.lock
4 files changed, 67 insertions(+), 84 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Flow 
refs/changes/18/393918/1

diff --git a/.rubocop.yml b/.rubocop.yml
index a549dfc..305b0a5 100644
--- a/.rubocop.yml
+++ b/.rubocop.yml
@@ -1,37 +1,18 @@
 inherit_from: .rubocop_todo.yml
 
-# See discussion of rules at
-# https://www.mediawiki.org/wiki/Manual:Coding_conventions/Ruby
-
-Metrics/AbcSize:
-  Enabled: false
-
-Metrics/ClassLength:
-  Enabled: false
-
-Metrics/CyclomaticComplexity:
-  Enabled: false
-
-Metrics/MethodLength:
-  Enabled: false
-
-Metrics/ParameterLists:
-  Enabled: false
-
-Metrics/PerceivedComplexity:
-  Enabled: false
-
-Style/Alias:
-  Enabled: false
-
-# rubocop fix lifted from CirrusSearch/.rubocop.yml
-Style/LeadingCommentSpace:
+AllCops:
+  Include:
+- 'Gemfile'
+- 'Rakefile'
+- '.jsduck/CustomTags.rb'
   Exclude:
-- Gemfile  # RVM doesn't recognise spaces after the #s
+  - 'node_modules/**/*'
+  - 'vendor/**/*'
+  - 'rebaser/**/*'
 
-Style/SignalException:
-  Enabled: false
+Metrics/LineLength:
+  Max: 100
 
-Style/SpaceInsideStringInterpolation:
+Layout/SpaceInsideStringInterpolation:
   Exclude:
-- jsduck_custom_tags.rb
\ No newline at end of file
+- jsduck_custom_tags.rb
diff --git a/.rubocop_todo.yml b/.rubocop_todo.yml
index 8e5ff3f..70cec29 100644
--- a/.rubocop_todo.yml
+++ b/.rubocop_todo.yml
@@ -1,42 +1,51 @@
-# This configuration was generated by `rubocop --auto-gen-config`
-# on 2014-11-07 11:17:24 -0700 using RuboCop version 0.27.0.
+# This configuration was generated by
+# `rubocop --auto-gen-config`
+# on 2017-11-28 13:54:19 -0800 using RuboCop version 0.51.0.
 # The point is for the user to remove these configuration records
 # one by one as the offenses are removed from the code base.
 # Note that changes in the inspected code, or installation of new
 # versions of RuboCop, may require this file to be generated again.
 
-# Offense count: 66
-# Configuration parameters: AllowURI, URISchemes.
-Metrics/LineLength:
-  Max: 224
-
-# Offense count: 1
-# Cop supports --auto-correct.
-# Configuration parameters: EnforcedStyle, SupportedStyles.
-Style/BracesAroundHashParameters:
-  Enabled: false
-
-# Offense count: 1
-# Configuration parameters: Keywords.
-Style/CommentAnnotation:
-  Enabled: false
+# Offense count: 4
+# Configuration parameters: Blacklist.
+# Blacklist: END, (?-mix:EO[A-Z]{1})
+Naming/HeredocDelimiterNaming:
+  Exclude:
+- 'jsduck_custom_tags.rb'
 
 # Offense count: 5
 Style/Documentation:
-  Enabled: false
+  Exclude:
+- 'spec/**/*'
+- 'test/**/*'
+- 'jsduck_custom_tags.rb'
 
 # Offense count: 1
-# Configuration parameters: AllowedVariables.
-Style/GlobalVars:
-  Enabled: false
+# Configuration parameters: MinBodyLength.
+Style/GuardClause:
+  Exclude:
+- 'jsduck_custom_tags.rb'
 
-# Offense count: 111
+# Offense count: 1
 # Cop supports --auto-correct.
-# Configuration parameters: EnforcedStyle, SupportedStyles.
+# Configuration parameters: EnforcedStyle, SupportedStyles, 
UseHashRocketsWithSymbolValues, PreferHashRocketsForNonAlnumEndingSymbols.
+# SupportedStyles: ruby19, hash_rockets, no_mixed_keys, ruby19_no_mixed_keys
+Style/HashSyntax:
+  Exclude:
+- 'Gemfile'
+
+# Offense count: 2
+# Cop supports --auto-correct.
+# Configuration parameters: AllowMultipleReturnValues.
+Style/RedundantReturn:
+  Exclude:
+- 'jsduck_custom_tags.rb'
+
+# Offense count: 6
+# Cop supports --auto-correct.
+# Configuration parameters: EnforcedStyle, SupportedStyles, 
ConsistentQuotesInMultiline.
+# SupportedStyles: single_quotes, double_quotes
 Style/StringLiterals:
-  Enabled: false
-
-# Offense count: 1
-# Cop supports --auto-correct.
-Style/WhileUntilDo:
-  Enabled: false
+  Exclude:
+- 'Gemfile'
+- 'jsduck_custom_tags.rb'
diff --git a/Gemfile b/Gemfile
index 942680a..2f7b6b0 100644
--- a/Gemfile
+++ b/Gemfile
@@ -1,5 +1,4 @@
 source "https://rubygems.org;
 
-gem "csscss", "~> 1.3.3"
 gem 'rake', '~> 11.1', '>= 11.1.1'
-gem "rubocop", "~> 0.32.1", require: false
+gem "rubocop", "~> 0.51", :require => false
diff --git a/Gemfile.lock b/Gemfile.lock
index 81120cd..fd633f8 100644
--- a/Gemfile.lock
+++ b/Gemfile.lock
@@ -1,36 +1,30 @@
 GEM
   remote: https://rubygems.org/
   specs:
-ast (2.1.0)
-astrolabe (1.3.1)
-  parser (~> 2.2)
-blankslate (3.1.3)
-colorize (0.7.7)
-csscss (1.3.3)
-  colorize
-  parslet (>= 1.6.1, < 2.0)
-parser (2.2.2.6)
-  ast (>= 1.1, < 3.0)
-parslet (1.7.1)
-

[MediaWiki-commits] [Gerrit] mediawiki...VisualEditor[master]: build: Bump Ruby cruft to avoid security warnings for old ru...

[Jforrester (Code Review)]

Jforrester has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/393837 )

Change subject: build: Bump Ruby cruft to avoid security warnings for old 
rubocop
..

build: Bump Ruby cruft to avoid security warnings for old rubocop

So. Much. Cruft.

Change-Id: I27299ac709aa6ba772b2fc5ee9dc976ad4bb07d3
---
M .rubocop.yml
M .rubocop_todo.yml
M Gemfile
M Gemfile.lock
M Rakefile
5 files changed, 103 insertions(+), 38 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/VisualEditor 
refs/changes/37/393837/1

diff --git a/.rubocop.yml b/.rubocop.yml
index c4d7615..a12c4e2 100644
--- a/.rubocop.yml
+++ b/.rubocop.yml
@@ -2,10 +2,17 @@
 
 AllCops:
   StyleGuideCopsOnly: true
+  Include:
+- 'Gemfile'
+- 'Rakefile'
+- '.jsduck/CustomTags.rb'
+  Exclude:
+  - 'node_modules/**/*'
+  - 'vendor/**/*'
+  - 'lib/ve/**/*'
 
-# uncomment when the offense is fixed
-# Metrics/LineLength:
-#   Max: 100
+Metrics/LineLength:
+  Max: 100
 
 Metrics/MethodLength:
   Enabled: false
diff --git a/.rubocop_todo.yml b/.rubocop_todo.yml
index 26e59ec..c5dd970 100644
--- a/.rubocop_todo.yml
+++ b/.rubocop_todo.yml
@@ -1,15 +1,70 @@
-# This configuration was generated by `rubocop --auto-gen-config`
-# on 2016-02-15 14:53:20 +0100 using RuboCop version 0.32.1.
+# This configuration was generated by
+# `rubocop --auto-gen-config`
+# on 2017-11-28 12:08:04 -0800 using RuboCop version 0.51.0.
 # The point is for the user to remove these configuration records
 # one by one as the offenses are removed from the code base.
 # Note that changes in the inspected code, or installation of new
 # versions of RuboCop, may require this file to be generated again.
 
-# Offense count: 1
-Lint/HandleExceptions:
-  Enabled: false
+# Offense count: 4
+# Cop supports --auto-correct.
+# Configuration parameters: AllowForAlignment.
+Layout/SpaceAroundOperators:
+  Exclude:
+- '.jsduck/CustomTags.rb'
 
-# Offense count: 56
-# Configuration parameters: AllowURI, URISchemes.
-Metrics/LineLength:
-  Max: 398
+# Offense count: 2
+# Cop supports --auto-correct.
+# Configuration parameters: EnforcedStyle, SupportedStyles.
+# SupportedStyles: space, no_space
+Layout/SpaceInsideStringInterpolation:
+  Exclude:
+- '.jsduck/CustomTags.rb'
+
+# Offense count: 2
+# Cop supports --auto-correct.
+# Configuration parameters: AllowUnusedKeywordArguments, IgnoreEmptyMethods.
+Lint/UnusedMethodArgument:
+  Exclude:
+- '.jsduck/CustomTags.rb'
+
+# Offense count: 3
+# Configuration parameters: Blacklist.
+# Blacklist: END, (?-mix:EO[A-Z]{1})
+Naming/HeredocDelimiterNaming:
+  Exclude:
+- '.jsduck/CustomTags.rb'
+
+# Offense count: 1
+# Configuration parameters: MinBodyLength.
+Style/GuardClause:
+  Exclude:
+- '.jsduck/CustomTags.rb'
+
+# Offense count: 4
+# Cop supports --auto-correct.
+# Configuration parameters: SupportedStyles, UseHashRocketsWithSymbolValues, 
PreferHashRocketsForNonAlnumEndingSymbols.
+# SupportedStyles: ruby19, hash_rockets, no_mixed_keys, ruby19_no_mixed_keys
+Style/HashSyntax:
+  EnforcedStyle: hash_rockets
+
+# Offense count: 4
+# Cop supports --auto-correct.
+Style/PerlBackrefs:
+  Exclude:
+- '.jsduck/CustomTags.rb'
+
+# Offense count: 6
+# Cop supports --auto-correct.
+# Configuration parameters: AllowMultipleReturnValues.
+Style/RedundantReturn:
+  Exclude:
+- '.jsduck/CustomTags.rb'
+
+# Offense count: 2
+# Cop supports --auto-correct.
+# Configuration parameters: EnforcedStyle, SupportedStyles, 
ConsistentQuotesInMultiline.
+# SupportedStyles: single_quotes, double_quotes
+Style/StringLiterals:
+  Exclude:
+- '.jsduck/CustomTags.rb'
diff --git a/Gemfile b/Gemfile
index 2c79842..59b4be4 100644
--- a/Gemfile
+++ b/Gemfile
@@ -2,4 +2,4 @@
 
 gem 'commons_upload', '~> 1.0', '>= 1.0.1'
 gem 'rake', '~> 10.4', '>= 10.4.2'
-gem 'rubocop', '~> 0.32.1', require: false
+gem 'rubocop', '~> 0.51', :require => false
diff --git a/Gemfile.lock b/Gemfile.lock
index 0fa0954..ced00bf 100644
--- a/Gemfile.lock
+++ b/Gemfile.lock
@@ -2,41 +2,43 @@
   remote: https://rubygems.org/
   specs:
 ast (2.3.0)
-astrolabe (1.3.1)
-  parser (~> 2.2)
 commons_upload (1.0.1)
   mediawiki_api (~> 0.7.0)
-domain_name (0.5.20160615)
+domain_name (0.5.20170404)
   unf (>= 0.0.5, < 1.0.0)
-faraday (0.9.2)
+faraday (0.13.1)
   multipart-post (>= 1.2, < 3)
 faraday-cookie_jar (0.0.6)
   faraday (>= 0.7.4)
   http-cookie (~> 1.0.0)
-faraday_middleware (0.10.0)
-  faraday (>= 0.7.4, < 0.10)
-http-cookie (1.0.2)
+faraday_middleware (0.12.2)
+  faraday (>= 0.7.4, < 1.0)
+http-cookie (1.0.3)
   domain_name (~> 0.5)
-mediawiki_api (0.7.0)
+mediawiki_api (0.7.1)
   faraday (~> 0.9, >= 0.9.0)
   faraday-cookie_jar (~> 0.0, >= 0.0.6)
   faraday_middleware (~> 0.10, >= 0.10.0)
 multipart-post (2.0.0)
-parser (2.3.1.2)
- 

[MediaWiki-commits] [Gerrit] VisualEditor/VisualEditor[master]: build: Bump Ruby cruft to avoid security warnings for old ru...

[Jforrester (Code Review)]

Jforrester has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/393836 )

Change subject: build: Bump Ruby cruft to avoid security warnings for old 
rubocop
..

build: Bump Ruby cruft to avoid security warnings for old rubocop

So. Much. Cruft.

Change-Id: I27299ac709aa6ba772b2fc5ee9dc976ad4bb07d3
---
M .rubocop.yml
M .rubocop_todo.yml
M Gemfile
M Gemfile.lock
M Rakefile
5 files changed, 80 insertions(+), 32 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/VisualEditor/VisualEditor 
refs/changes/36/393836/1

diff --git a/.rubocop.yml b/.rubocop.yml
index c5d903f..2735a4a 100644
--- a/.rubocop.yml
+++ b/.rubocop.yml
@@ -3,7 +3,12 @@
 AllCops:
   Include:
 - 'Gemfile'
-- '.jsduck/**/*.rb'
+- 'Rakefile'
+- '.jsduck/CustomTags.rb'
+  Exclude:
+  - 'node_modules/**/*'
+  - 'vendor/**/*'
+  - 'rebaser/**/*'
 
 Metrics/LineLength:
   Max: 100
diff --git a/.rubocop_todo.yml b/.rubocop_todo.yml
index 3102583..4e1ebb2 100644
--- a/.rubocop_todo.yml
+++ b/.rubocop_todo.yml
@@ -1,5 +1,6 @@
-# This configuration was generated by `rubocop --auto-gen-config`
-# on 2014-11-12 14:07:33 +0100 using RuboCop version 0.27.1.
+# This configuration was generated by
+# `rubocop --auto-gen-config`
+# on 2017-11-28 12:11:12 -0800 using RuboCop version 0.51.0.
 # The point is for the user to remove these configuration records
 # one by one as the offenses are removed from the code base.
 # Note that changes in the inspected code, or installation of new
@@ -7,20 +8,55 @@
 
 # Offense count: 2
 # Cop supports --auto-correct.
-Lint/UnusedMethodArgument:
-  Enabled: false
+# Configuration parameters: EnforcedStyle, SupportedStyles.
+# SupportedStyles: space, no_space
+Layout/SpaceInsideStringInterpolation:
+  Exclude:
+- '.jsduck/CustomTags.rb'
 
-# Offense count: 5
-Style/Documentation:
-  Enabled: false
-
-# Offense count: 5
+# Offense count: 2
 # Cop supports --auto-correct.
-# Configuration parameters: SupportedStyles.
+# Configuration parameters: AllowUnusedKeywordArguments, IgnoreEmptyMethods.
+Lint/UnusedMethodArgument:
+  Exclude:
+- '.jsduck/CustomTags.rb'
+
+# Offense count: 3
+# Configuration parameters: Blacklist.
+# Blacklist: END, (?-mix:EO[A-Z]{1})
+Naming/HeredocDelimiterNaming:
+  Exclude:
+- '.jsduck/CustomTags.rb'
+
+# Offense count: 4
+Style/Documentation:
+  Exclude:
+- 'spec/**/*'
+- 'test/**/*'
+- '.jsduck/CustomTags.rb'
+
+# Offense count: 1
+# Configuration parameters: MinBodyLength.
+Style/GuardClause:
+  Exclude:
+- '.jsduck/CustomTags.rb'
+
+# Offense count: 4
+# Cop supports --auto-correct.
+# Configuration parameters: SupportedStyles, UseHashRocketsWithSymbolValues, 
PreferHashRocketsForNonAlnumEndingSymbols.
+# SupportedStyles: ruby19, hash_rockets, no_mixed_keys, ruby19_no_mixed_keys
 Style/HashSyntax:
-  Enabled: false
+  EnforcedStyle: hash_rockets
 
 # Offense count: 4
 # Cop supports --auto-correct.
 Style/PerlBackrefs:
-  Enabled: false
+  Exclude:
+- '.jsduck/CustomTags.rb'
+
+# Offense count: 6
+# Cop supports --auto-correct.
+# Configuration parameters: AllowMultipleReturnValues.
+Style/RedundantReturn:
+  Exclude:
+- '.jsduck/CustomTags.rb'
diff --git a/Gemfile b/Gemfile
index eea2055..449daca 100644
--- a/Gemfile
+++ b/Gemfile
@@ -1,3 +1,3 @@
 source 'https://rubygems.org'
 
-gem 'rubocop', require: false
+gem 'rubocop', :require => false
diff --git a/Gemfile.lock b/Gemfile.lock
index 30d2965..3e7127c 100644
--- a/Gemfile.lock
+++ b/Gemfile.lock
@@ -1,23 +1,29 @@
 GEM
   remote: https://rubygems.org/
   specs:
-ast (2.0.0)
-astrolabe (1.3.0)
-  parser (>= 2.2.0.pre.3, < 3.0)
-parser (2.2.0.3)
-  ast (>= 1.1, < 3.0)
-powerpack (0.1.0)
-rainbow (2.0.0)
-rubocop (0.29.1)
-  astrolabe (~> 1.3)
-  parser (>= 2.2.0.1, < 3.0)
+ast (2.3.0)
+parallel (1.12.0)
+parser (2.4.0.2)
+  ast (~> 2.3)
+powerpack (0.1.1)
+rainbow (2.2.2)
+  rake
+rake (12.3.0)
+rubocop (0.51.0)
+  parallel (~> 1.10)
+  parser (>= 2.3.3.1, < 3.0)
   powerpack (~> 0.1)
-  rainbow (>= 1.99.1, < 3.0)
-  ruby-progressbar (~> 1.4)
-ruby-progressbar (1.7.1)
+  rainbow (>= 2.2.2, < 3.0)
+  ruby-progressbar (~> 1.7)
+  unicode-display_width (~> 1.0, >= 1.0.1)
+ruby-progressbar (1.9.0)
+unicode-display_width (1.3.0)
 
 PLATFORMS
   ruby
 
 DEPENDENCIES
   rubocop
+
+BUNDLED WITH
+   1.16.0
diff --git a/Rakefile b/Rakefile
index 6eef121..13fce2f 100644
--- a/Rakefile
+++ b/Rakefile
@@ -2,13 +2,14 @@
 
 require 'rubocop/rake_task'
 RuboCop::RakeTask.new(:rubocop) do |task|
-  # if you use mediawiki-vagrant, rubocop will by default use it's .rubocop.yml
-  # the next line makes it explicit that you want .rubocop.yml from the 
directory
-  # where `bundle exec rake` is executed
+  # If you use mediawiki-vagrant, rubocop will by default use its .rubocop.yml.
+
+  # 

[MediaWiki-commits] [Gerrit] mediawiki...VisualEditor[master]: Update VE core submodule to master (56cfb5d6f)

[Jforrester (Code Review)]

Jforrester has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/393812 )

Change subject: Update VE core submodule to master (56cfb5d6f)
..

Update VE core submodule to master (56cfb5d6f)

New changes:
00589df33 ce.ContentBranchNode: Move setNotUnicorning into detach
70a56d30a Destroy CE nodes on removal by onSplice

Bug: T179574
Change-Id: Ib0217c0f089dc9423776805f1bf31f1f16c68beb
---
M lib/ve
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/VisualEditor 
refs/changes/12/393812/1

diff --git a/lib/ve b/lib/ve
index 6c0b740..56cfb5d 16
--- a/lib/ve
+++ b/lib/ve
@@ -1 +1 @@
-Subproject commit 6c0b7407f890c68450205fb6923bc64c2e29016b
+Subproject commit 56cfb5d6f290563069d257cbf72e1a534e0bbc13

-- 
To view, visit https://gerrit.wikimedia.org/r/393812
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib0217c0f089dc9423776805f1bf31f1f16c68beb
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Jforrester 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] oojs/ui[master]: oo-ui-background-image: Drop `-o-linear-gradient` fallback

[Jforrester (Code Review)]

Jforrester has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/393797 )

Change subject: oo-ui-background-image: Drop `-o-linear-gradient` fallback
..

oo-ui-background-image: Drop `-o-linear-gradient` fallback

This support for pre-v.15 Opera uses increases the payload and
processing cost of every icon for all users to serve about 0.15%
of users.

Bug: T121517
Change-Id: Ib31ed695409fe14a7340a5412cd9885b06296ff3
---
M src/styles/common.less
1 file changed, 0 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/oojs/ui refs/changes/97/393797/1

diff --git a/src/styles/common.less b/src/styles/common.less
index 73d6071..c3b6d69 100644
--- a/src/styles/common.less
+++ b/src/styles/common.less
@@ -18,7 +18,6 @@
 .oo-ui-background-image-svg-internal( @svg, @fallback ) when ( 
@oo-ui-distribution = mixed ) {
background-image: url( @fallback );
background-image: linear-gradient( transparent, transparent ), e( '/* 
@embed */' ) url( @svg );
-   background-image: -o-linear-gradient( transparent, transparent ), url( 
@fallback );
 }
 .oo-ui-background-image-svg-internal( @svg, @fallback ) when ( 
@oo-ui-distribution = vector ) {
.oo-ui-background-image( @svg );

-- 
To view, visit https://gerrit.wikimedia.org/r/393797
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib31ed695409fe14a7340a5412cd9885b06296ff3
Gerrit-PatchSet: 1
Gerrit-Project: oojs/ui
Gerrit-Branch: master
Gerrit-Owner: Jforrester 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] oojs/ui[master]: oo-ui-background-image: Drop `-webkit-linear-gradient` fallback

[Jforrester (Code Review)]

Jforrester has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/393796 )

Change subject: oo-ui-background-image: Drop `-webkit-linear-gradient` fallback
..

oo-ui-background-image: Drop `-webkit-linear-gradient` fallback

This is only for unsupported browsers; we dropped this (to save on bloat)
in MediaWiki in November 2015 in T118815 (and then put back in Opera
support; see next commit).

Change-Id: I44114f4ab12075e115a389dcb7faebed1038b352
---
M src/styles/common.less
1 file changed, 0 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/oojs/ui refs/changes/96/393796/1

diff --git a/src/styles/common.less b/src/styles/common.less
index 6802aab..73d6071 100644
--- a/src/styles/common.less
+++ b/src/styles/common.less
@@ -17,7 +17,6 @@
 
 .oo-ui-background-image-svg-internal( @svg, @fallback ) when ( 
@oo-ui-distribution = mixed ) {
background-image: url( @fallback );
-   background-image: -webkit-linear-gradient( transparent, transparent ), 
e( '/* @embed */' ) url( @svg );
background-image: linear-gradient( transparent, transparent ), e( '/* 
@embed */' ) url( @svg );
background-image: -o-linear-gradient( transparent, transparent ), url( 
@fallback );
 }

-- 
To view, visit https://gerrit.wikimedia.org/r/393796
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I44114f4ab12075e115a389dcb7faebed1038b352
Gerrit-PatchSet: 1
Gerrit-Project: oojs/ui
Gerrit-Branch: master
Gerrit-Owner: Jforrester 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: resources: Upgrade jquery.chosen from 0.9.14 to 1.8.2

[Jforrester (Code Review)]

Jforrester has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/393687 )

Change subject: resources: Upgrade jquery.chosen from 0.9.14 to 1.8.2
..

resources: Upgrade jquery.chosen from 0.9.14 to 1.8.2

Change-Id: If9c720ebca8ca663869d0f73b0cd3ea415262cff
---
M RELEASE-NOTES-1.31
M resources/lib/jquery.chosen/LICENSE
A resources/lib/jquery.chosen/README.md
M resources/lib/jquery.chosen/chosen-sprite.png
M resources/lib/jquery.chosen/chosen-spr...@2x.png
M resources/lib/jquery.chosen/chosen.css
M resources/lib/jquery.chosen/chosen.jquery.js
7 files changed, 1,201 insertions(+), 857 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core 
refs/changes/87/393687/1

diff --git a/RELEASE-NOTES-1.31 b/RELEASE-NOTES-1.31
index 3de0e17..4b7795a 100644
--- a/RELEASE-NOTES-1.31
+++ b/RELEASE-NOTES-1.31
@@ -26,6 +26,7 @@
 === External library changes in 1.31 ===
 
  Upgraded external libraries 
+* Updated jquery.chosen from v0.9.14 to v1.8.2.
 * …
 
  New external libraries 
diff --git a/resources/lib/jquery.chosen/LICENSE 
b/resources/lib/jquery.chosen/LICENSE
index 0675dc5..5e1332c 100644
--- a/resources/lib/jquery.chosen/LICENSE
+++ b/resources/lib/jquery.chosen/LICENSE
@@ -1,9 +1,8 @@
-# Chosen, a Select Box Enhancer for jQuery and Protoype
-## by Patrick Filler for [Harvest](http://getharvest.com)
+ Chosen
+- by Patrick Filler for [Harvest](http://getharvest.com)
+- Copyright (c) 2011-2016 by Harvest
 
 Available for use under the [MIT 
License](http://en.wikipedia.org/wiki/MIT_License)
-
-Copyright (c) 2011-2013 by Harvest
 
 Permission is hereby granted, free of charge, to any person obtaining a copy
 of this software and associated documentation files (the "Software"), to deal
diff --git a/resources/lib/jquery.chosen/README.md 
b/resources/lib/jquery.chosen/README.md
new file mode 100644
index 000..5b21256
--- /dev/null
+++ b/resources/lib/jquery.chosen/README.md
@@ -0,0 +1,48 @@
+# Chosen
+
+Chosen is a library for making long, unwieldy select boxes more user friendly.
+
+- jQuery support: 1.7+
+- Prototype support: 1.7+
+
+For **documentation**, usage, and examples, see:
+http://harvesthq.github.io/chosen/
+
+For **downloads**, see:
+https://github.com/harvesthq/chosen/releases/
+
+### Package managers
+
+Chosen is available through [Bower](https://bower.io/) and 
[npm](https://www.npmjs.com),
+_however, the package names are not the same_.
+
+To install with Bower:
+
+```
+bower install chosen
+```
+
+To install with npm:
+
+```
+npm install chosen-js
+```
+
+The compiled files for these packages are automatically generated and stored 
in a [2nd Chosen repository](https://github.com/harvesthq/chosen-package). No 
pull requests will be accepted to that repository.
+
+### Contributing to this project
+
+We welcome all to participate in making Chosen the best software it can be. 
The repository is maintained by only a few people, but has accepted 
contributions from over 50 authors after reviewing hundreds of pull requests 
related to thousands of issues. You can help reduce the maintainers' workload 
(and increase your chance of having an accepted contribution to Chosen) by 
following the
+[guidelines for contributing](contributing.md).
+
+* [Bug reports](contributing.md#bugs)
+* [Feature requests](contributing.md#features)
+* [Pull requests](contributing.md#pull-requests)
+
+### Chosen Credits
+
+- Concept and development by [Patrick Filler](http://patrickfiller.com) for 
[Harvest](http://getharvest.com/).
+- Design and CSS by [Matthew Lettini](http://matthewlettini.com/)
+- Repository maintained by [@pfiller](http://github.com/pfiller), 
[@kenearley](http://github.com/kenearley), [@stof](http://github.com/stof), 
[@koenpunt](http://github.com/koenpunt), and 
[@tjschuck](http://github.com/tjschuck).
+- Chosen includes [contributions by many fine 
folks](https://github.com/harvesthq/chosen/contributors).
+
diff --git a/resources/lib/jquery.chosen/chosen-sprite.png 
b/resources/lib/jquery.chosen/chosen-sprite.png
index 3611ae4..c57da70 100644
--- a/resources/lib/jquery.chosen/chosen-sprite.png
+++ b/resources/lib/jquery.chosen/chosen-sprite.png
Binary files differ
diff --git a/resources/lib/jquery.chosen/chosen-spr...@2x.png 
b/resources/lib/jquery.chosen/chosen-spr...@2x.png
index bd61d96..6b50545 100644
--- a/resources/lib/jquery.chosen/chosen-spr...@2x.png
+++ b/resources/lib/jquery.chosen/chosen-spr...@2x.png
Binary files differ
diff --git a/resources/lib/jquery.chosen/chosen.css 
b/resources/lib/jquery.chosen/chosen.css
index 17793ed..d4219b4 100644
--- a/resources/lib/jquery.chosen/chosen.css
+++ b/resources/lib/jquery.chosen/chosen.css
@@ -1,440 +1,490 @@
+/*!
+Chosen, a Select Box Enhancer for jQuery and Prototype
+by Patrick Filler for Harvest, http://getharvest.com
+
+Version 1.8.2
+Full source at https://github.com/harvesthq/chosen
+Copyright (c) 2011-2017 Harvest 

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: [WIP] HTMLForm: Drop this never-used backwards-compatibility

[Jforrester (Code Review)]

Jforrester has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/393688 )

Change subject: [WIP] HTMLForm: Drop this never-used backwards-compatibility
..

[WIP] HTMLForm: Drop this never-used backwards-compatibility

Change-Id: I6864d3a1207de44d465491baad87cb9c00714255
---
M RELEASE-NOTES-1.31
M includes/htmlform/fields/HTMLMultiSelectField.php
2 files changed, 5 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core 
refs/changes/88/393688/1

diff --git a/RELEASE-NOTES-1.31 b/RELEASE-NOTES-1.31
index 4b7795a..f1cb261 100644
--- a/RELEASE-NOTES-1.31
+++ b/RELEASE-NOTES-1.31
@@ -106,6 +106,10 @@
 * Use of Maintenance::error( $err, $die ) to exit script was deprecated. Use
   Maintenance::fatalError() instead.
 * Passing a ParserOptions object to OutputPage::parserOptions() is deprecated.
+* The backwards-compatibility code in HTMLForm to add a drop-down control to an
+  option that is not set to be a drop-down if the "mw-chosen" class is present,
+  is now removed.
+* …
 
 == Compatibility ==
 MediaWiki 1.31 requires PHP 5.5.9 or later. There is experimental support for
diff --git a/includes/htmlform/fields/HTMLMultiSelectField.php 
b/includes/htmlform/fields/HTMLMultiSelectField.php
index 238b2b4..21c034b 100644
--- a/includes/htmlform/fields/HTMLMultiSelectField.php
+++ b/includes/htmlform/fields/HTMLMultiSelectField.php
@@ -22,8 +22,7 @@
$this->mParams['disabled-options'] = [];
}
 
-   // For backwards compatibility, also handle the old way with 
'cssclass' => 'mw-chosen'
-   if ( isset( $params['dropdown'] ) || strpos( $this->mClass, 
'mw-chosen' ) !== false ) {
+   if ( isset( $params['dropdown'] ) ) {
$this->mClass .= ' mw-htmlform-dropdown';
}
 

-- 
To view, visit https://gerrit.wikimedia.org/r/393688
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I6864d3a1207de44d465491baad87cb9c00714255
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Jforrester 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: [WIP] Drop Opera 12 from Grade A to Grade X

[Jforrester (Code Review)]

Jforrester has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/393652 )

Change subject: [WIP] Drop Opera 12 from Grade A to Grade X
..

[WIP] Drop Opera 12 from Grade A to Grade X

Bug: T121517
Change-Id: Ie4df9c751bd0250581cd2e25cf1b38e69e67e82f
---
M includes/resourceloader/ResourceLoaderImageModule.php
M resources/src/mediawiki.less/mediawiki.mixins.less
M tests/phpunit/includes/resourceloader/ResourceLoaderImageModuleTest.php
3 files changed, 0 insertions(+), 6 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core 
refs/changes/52/393652/1

diff --git a/includes/resourceloader/ResourceLoaderImageModule.php 
b/includes/resourceloader/ResourceLoaderImageModule.php
index 71a0fa2..5e329e8 100644
--- a/includes/resourceloader/ResourceLoaderImageModule.php
+++ b/includes/resourceloader/ResourceLoaderImageModule.php
@@ -386,8 +386,6 @@
return [
"background-image: $fallbackUrl;",
"background-image: linear-gradient(transparent, 
transparent), $primaryUrl;",
-   // Do not serve SVG to Opera 12, bad rendering with 
border-radius or background-size (T87504)
-   "background-image: -o-linear-gradient(transparent, 
transparent), $fallbackUrl;",
];
}
 
diff --git a/resources/src/mediawiki.less/mediawiki.mixins.less 
b/resources/src/mediawiki.less/mediawiki.mixins.less
index ea0b959..58f6dc2 100644
--- a/resources/src/mediawiki.less/mediawiki.mixins.less
+++ b/resources/src/mediawiki.less/mediawiki.mixins.less
@@ -38,8 +38,6 @@
 .background-image-svg( @svg, @fallback ) {
background-image: url( @fallback );
background-image: linear-gradient( transparent, transparent ), e( '/* 
@embed */' ) url( @svg );
-   // Do not serve SVG to Opera 12, bad rendering with border-radius or 
background-size (T87504)
-   background-image: -o-linear-gradient( transparent, transparent ), url( 
@fallback );
 }
 
 // Shorthand for background-image-svg. Use if your PNG and SVG have the same 
name
diff --git 
a/tests/phpunit/includes/resourceloader/ResourceLoaderImageModuleTest.php 
b/tests/phpunit/includes/resourceloader/ResourceLoaderImageModuleTest.php
index f53cd06..e5b338e 100644
--- a/tests/phpunit/includes/resourceloader/ResourceLoaderImageModuleTest.php
+++ b/tests/phpunit/includes/resourceloader/ResourceLoaderImageModuleTest.php
@@ -207,7 +207,6 @@
 <

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...VisualEditor[master]: Update VE core submodule to master (6c0b7407f)

[Jforrester (Code Review)]

Jforrester has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/393617 )

Change subject: Update VE core submodule to master (6c0b7407f)
..

Update VE core submodule to master (6c0b7407f)

New changes:
c56a4eef5 Localisation updates from https://translatewiki.net.
71da5d798 Localisation updates from https://translatewiki.net.
36811a12e TableAction: Add option for creating a table with a caption
7979ceb97 DebugBar: Debounce onHistory handler
505f06d2e Highlight table caption when table cells selected
3f1cc6cb0 Localisation updates from https://translatewiki.net.

Bug: T181173
Change-Id: Id8999ac2cb15484e9eed7a1db194152d56816420
---
M lib/ve
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/VisualEditor 
refs/changes/17/393617/1

diff --git a/lib/ve b/lib/ve
index cca896a..6c0b740 16
--- a/lib/ve
+++ b/lib/ve
@@ -1 +1 @@
-Subproject commit cca896ac37fe2b8c9c049542fb1ec9062d158062
+Subproject commit 6c0b7407f890c68450205fb6923bc64c2e29016b

-- 
To view, visit https://gerrit.wikimedia.org/r/393617
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Id8999ac2cb15484e9eed7a1db194152d56816420
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Jforrester 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...WikiEditor[master]: Merge all the non-styles-only ResourceLoader modules into one

[Jforrester (Code Review)]

Jforrester has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/392902 )

Change subject: Merge all the non-styles-only ResourceLoader modules into one
..

Merge all the non-styles-only ResourceLoader modules into one

These were always jointly loaded, so they just bloated the module table
to no benefit.

Bug: T165112
Change-Id: I51745e84d6b840a18d84385dfb5ea4f96ada311d
---
M extension.json
M modules/jquery.wikiEditor.dialogs.js
2 files changed, 51 insertions(+), 123 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/WikiEditor 
refs/changes/02/392902/1

diff --git a/extension.json b/extension.json
index e6b91e3..a1419c7 100644
--- a/extension.json
+++ b/extension.json
@@ -47,70 +47,23 @@
]
},
"ResourceModules": {
-   "jquery.wikiEditor": {
+   "ext.wikiEditor": {
"group": "ext.wikiEditor",
-   "dependencies": [
-   "jquery.wikiEditor.core",
-   "jquery.wikiEditor.toolbar",
-   "jquery.wikiEditor.dialogs"
-   ]
-   },
-   "jquery.wikiEditor.core": {
-   "group": "ext.wikiEditor",
-   "scripts": "jquery.wikiEditor.js",
-   "styles": "jquery.wikiEditor.less",
-   "dependencies": [
-   "jquery.client",
-   "jquery.textSelection",
-   "mediawiki.language"
+   "scripts": [
+   "ext.wikiEditor.js",
+   "jquery.wikiEditor.js",
+   "ext.wikiEditor.toolbar.js",
+   "jquery.wikiEditor.toolbar.js",
+   "jquery.wikiEditor.toolbar.config.js",
+   "ext.wikiEditor.dialogs.js",
+   "jquery.wikiEditor.dialogs.js",
+   "jquery.wikiEditor.dialogs.config.js"
],
-   "messages": [
-   "wikieditor-wikitext-tab",
-   "wikieditor-loading"
-   ]
-   },
-   "jquery.wikiEditor.dialogs": {
-   "group": "ext.wikiEditor",
-   "scripts": "jquery.wikiEditor.dialogs.js",
-   "styles": "jquery.wikiEditor.dialogs.less",
-   "dependencies": [
-   "jquery.wikiEditor.core",
-   "jquery.wikiEditor.toolbar",
-   "jquery.ui.dialog",
-   "jquery.ui.button",
-   "jquery.ui.draggable",
-   "jquery.ui.resizable",
-   "jquery.tabIndex"
-   ]
-   },
-   "jquery.wikiEditor.dialogs.config": {
-   "group": "ext.wikiEditor",
-   "scripts": "jquery.wikiEditor.dialogs.config.js",
-   "styles": "jquery.wikiEditor.dialogs.config.less",
-   "dependencies": [
-   "jquery.wikiEditor.core",
-   "jquery.wikiEditor.dialogs",
-   "jquery.wikiEditor.toolbar.i18n",
-   "jquery.suggestions",
-   "mediawiki.Upload.Dialog",
-   
"mediawiki.ForeignStructuredUpload.BookletLayout",
-   "mediawiki.api",
-   "mediawiki.RegExp",
-   "mediawiki.Title",
-   "mediawiki.jqueryMsg"
-   ],
-   "messages": [
-   "wikieditor-toolbar-tool-file-title",
-   "wikieditor-toolbar-file-target",
-   "wikieditor-toolbar-file-caption",
-   "wikieditor-toolbar-file-size",
-   "wikieditor-toolbar-file-float",
-   "wikieditor-toolbar-file-default",
-   "wikieditor-toolbar-file-format-none",
-   "wikieditor-toolbar-file-format",
-   "wikieditor-toolbar-tool-file-insert",
-   "wikieditor-toolbar-tool-file-cancel",
-   "wikieditor-toolbar-tool-file-upload"
+   "styles": [
+   "jquery.wikiEditor.less",
+   "jquery.wikiEditor.toolbar.less",
+ 

[MediaWiki-commits] [Gerrit] mediawiki...WikiEditor[master]: Radically simplify this extension now there's only one confi...

[Jforrester (Code Review)]

Jforrester has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/392901 )

Change subject: Radically simplify this extension now there's only one config 
option
..

Radically simplify this extension now there's only one config option

On or off. Pick your apples.

Change-Id: I7677f0b597c33f236192aea1aaa347a36216fbb7
---
M README
M WikiEditor.hooks.php
M extension.json
M i18n/en.json
M i18n/qqq.json
M modules/jquery.wikiEditor.js
6 files changed, 33 insertions(+), 123 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/WikiEditor 
refs/changes/01/392901/1

diff --git a/README b/README
index e50b695..9d4459f 100644
--- a/README
+++ b/README
@@ -1,20 +1,17 @@
-# WikiEditor provides enhancements to the MediaWiki edit page
+WikiEditor provides enhancements to the MediaWiki edit page
 
-# This extension requires MediaWiki 1.17+ because it makes use of 
ResourceLoader.
+This extension requires MediaWiki 1.25+, because it makes use of 
ResourceLoader, static extension
+loading, and other features.
 
-# Example LocalSettings.php additions
+For installation, once the code is copied into your extensions directory, you 
can load it for your
+wiki by adding to LocalSettings.php the line:
 
-require_once( "$IP/extensions/WikiEditor/WikiEditor.php" );
+   wfLoadExtensions( "WikiEditor" );
 
-# Before configuring this extension, see WikiEditor.php and become familiar 
with the initial state and structure of the
-# $wgWikiEditorFeatures configuration variable. Essentially it's an array of 
arrays, keyed by feature name, each
-# containing global and user keys with boolean values. "global" indicates that 
it should be turned on for everyone
-# always, while user indicates that users should be allowed to turn it on or 
off in their user preferences.
+By default, when installed this extension will be available to all users, and 
logged-in users can
+disable it from their preferences. If you wish all users to have it, and be 
unable to disable it,
+add it to $wgHiddenPrefs in your LocalSettings.php:
 
-# To enable a preference by default but still allow users to disable it in 
preferences, use something like...
+   $wgHiddenPrefs[] = 'usebetatoolbar';
 
-$wgDefaultUserOptions['usebetatoolbar'] = 1;
-
-# Release 1.21 removes the $wgWikiEditorToolbarClickTracking config variable
-# and with it support for tracking clicks on WikiEditor features via the
-# ClickTracking extension.
+More can be found on the extension's page: 
https://www.mediawiki.org/wiki/Extension:WikiEditor
diff --git a/WikiEditor.hooks.php b/WikiEditor.hooks.php
index 1cba9db..ae4ccd0 100644
--- a/WikiEditor.hooks.php
+++ b/WikiEditor.hooks.php
@@ -11,70 +11,7 @@
// EventLogging.
private static $statsId = false;
 
-   /* Protected Static Members */
-
-   protected static $features = [
-
-   /* Toolbar Features */
-
-   // 'toolbar' is the main wikieditor feature, including toolbars 
and dialogs.
-   // The legacy name preserves user preferences for disabling the 
feature.
-   'toolbar' => [
-   'preferences' => [
-   // Ideally this key would be 
'wikieditor-toolbar'
-   'usebetatoolbar' => [
-   'type' => 'toggle',
-   'label-message' => 
'wikieditor-toolbar-preference',
-   'section' => 'editing/editor',
-   ],
-   ],
-   'requirements' => [
-   'usebetatoolbar' => true,
-   ],
-   'modules' => [
-   'ext.wikiEditor',
-   ],
-   'stylemodules' => [
-   'ext.wikiEditor.styles',
-   ],
-   ],
-   ];
-
/* Static Methods */
-
-   /**
-* Checks if a certain option is enabled
-*
-* This method is public to allow other extensions that use WikiEditor 
to use the
-* same configuration as WikiEditor itself
-*
-* @param string $name Name of the feature, should be a key of $features
-* @return bool
-*/
-   public static function isEnabled( $name ) {
-   global $wgWikiEditorFeatures, $wgUser;
-
-   // Features with global set to true are always enabled
-   if ( !isset( $wgWikiEditorFeatures[$name] ) || 
$wgWikiEditorFeatures[$name]['global'] ) {
-   return true;
-   }
-   // Features with user preference control can have any number of 
preferences
-   // to be specific values to be enabled
-   if ( $wgWikiEditorFeatures[$name]['user'] ) {
-  

[MediaWiki-commits] [Gerrit] mediawiki...WikiEditor[master]: Drop the never-finished "Labs" publish and preview features

[Jforrester (Code Review)]

Jforrester has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/392899 )

Change subject: Drop the never-finished "Labs" publish and preview features
..

Drop the never-finished "Labs" publish and preview features

These features were ideas in the Usability Initiative but were never
finished to the level that they would be deployed on Wikimedia wikis
and have been marked as "going to be removed" for years. Now is time
to act on that promise.

Change-Id: Ia1eb91d2dfb1979518d97badc1477146b4606f7c
---
M WikiEditor.hooks.php
M extension.json
M i18n/en.json
M i18n/qqq.json
D modules/ext.wikiEditor.preview.js
D modules/ext.wikiEditor.publish.js
M modules/jquery.wikiEditor.dialogs.config.less
D modules/jquery.wikiEditor.preview.js
D modules/jquery.wikiEditor.preview.less
D modules/jquery.wikiEditor.publish.js
10 files changed, 0 insertions(+), 518 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/WikiEditor 
refs/changes/99/392899/1

diff --git a/WikiEditor.hooks.php b/WikiEditor.hooks.php
index 8bf742b..1cba9db 100644
--- a/WikiEditor.hooks.php
+++ b/WikiEditor.hooks.php
@@ -38,39 +38,6 @@
'ext.wikiEditor.styles',
],
],
-
-   /* Labs Features */
-
-   'preview' => [
-   'preferences' => [
-   'wikieditor-preview' => [
-   'type' => 'toggle',
-   'label-message' => 
'wikieditor-preview-preference',
-   'section' => 'editing/labs',
-   ],
-   ],
-   'requirements' => [
-   'wikieditor-preview' => true,
-   ],
-   'modules' => [
-   'ext.wikiEditor.preview',
-   ],
-   ],
-   'publish' => [
-   'preferences' => [
-   'wikieditor-publish' => [
-   'type' => 'toggle',
-   'label-message' => 
'wikieditor-publish-preference',
-   'section' => 'editing/labs',
-   ],
-   ],
-   'requirements' => [
-   'wikieditor-publish' => true,
-   ],
-   'modules' => [
-   'ext.wikiEditor.publish',
-   ],
-   ]
];
 
/* Static Methods */
diff --git a/extension.json b/extension.json
index d604f3c..0726873 100644
--- a/extension.json
+++ b/extension.json
@@ -120,23 +120,6 @@
"dialogReplace.html": 
"templates/dialogReplace.html"
}
},
-   "jquery.wikiEditor.preview": {
-   "group": "ext.wikiEditor",
-   "scripts": "jquery.wikiEditor.preview.js",
-   "styles": "jquery.wikiEditor.preview.less",
-   "dependencies": [
-   "jquery.wikiEditor.core",
-   "mediawiki.api"
-   ]
-   },
-   "jquery.wikiEditor.publish": {
-   "group": "ext.wikiEditor",
-   "scripts": "jquery.wikiEditor.publish.js",
-   "dependencies": [
-   "jquery.wikiEditor.core",
-   "jquery.wikiEditor.dialogs"
-   ]
-   },
"jquery.wikiEditor.toolbar": {
"group": "ext.wikiEditor",
"scripts": "jquery.wikiEditor.toolbar.js",
@@ -364,37 +347,6 @@
"jquery.wikiEditor.dialogs.config"
]
},
-   "ext.wikiEditor.preview": {
-   "group": "ext.wikiEditor",
-   "scripts": "ext.wikiEditor.preview.js",
-   "dependencies": [
-   "ext.wikiEditor.core",
-   "jquery.wikiEditor.preview"
-   ],
-   "messages": [
-   "wikieditor-preview-tab",
-   "wikieditor-preview-changes-tab",
-   "wikieditor-preview-loading"
-   ]
-   },
-   "ext.wikiEditor.publish": {
-   "group": "ext.wikiEditor",
-   "scripts": "ext.wikiEditor.publish.js",
-   "dependencies": [
-   

[MediaWiki-commits] [Gerrit] mediawiki...WikiEditor[master]: Follow-up 7815040: Remove the 'dialogs' config object, no lo...

[Jforrester (Code Review)]

Jforrester has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/392900 )

Change subject: Follow-up 7815040: Remove the 'dialogs' config object, no 
longer read
..

Follow-up 7815040: Remove the 'dialogs' config object, no longer read

Change-Id: Ife28707368d9c7e058df25f1673aeed75522757a
---
M extension.json
1 file changed, 0 insertions(+), 4 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/WikiEditor 
refs/changes/00/392900/1

diff --git a/extension.json b/extension.json
index 0726873..cdb768a 100644
--- a/extension.json
+++ b/extension.json
@@ -367,10 +367,6 @@
"global": false,
"user": true
},
-   "dialogs": {
-   "global": false,
-   "user": true
-   },
"_merge_strategy": "array_plus_2d"
}
},

-- 
To view, visit https://gerrit.wikimedia.org/r/392900
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ife28707368d9c7e058df25f1673aeed75522757a
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/WikiEditor
Gerrit-Branch: master
Gerrit-Owner: Jforrester 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] operations/mediawiki-config[master]: BetaFeatures whitelist: Update date comments

[Jforrester (Code Review)]

Jforrester has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/392885 )

Change subject: BetaFeatures whitelist: Update date comments
..

BetaFeatures whitelist: Update date comments

Change-Id: Ic23ac08a118b16fa5d2c32fdd653d253a3a8ce56
---
M wmf-config/InitialiseSettings.php
1 file changed, 9 insertions(+), 9 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/operations/mediawiki-config 
refs/changes/85/392885/1

diff --git a/wmf-config/InitialiseSettings.php 
b/wmf-config/InitialiseSettings.php
index d764602..4a78b0d 100644
--- a/wmf-config/InitialiseSettings.php
+++ b/wmf-config/InitialiseSettings.php
@@ -13694,15 +13694,15 @@
 // DO NOT add entries here without OK from Greg Grossmeier or James Forrester.
 'wgBetaFeaturesWhitelist' => [
'default' => [
-   'visualeditor-enable',   // [Editing] On-going 
(special permission) – VisualEditor
-   'beta-feature-flow-user-talk-page',  // [Editing] On-going 
(special permission) – Flow opt-in
-   'uls-compact-links', // [Editing] 2017-11-20 – 
Compact language links
-   'popups',// [Reading] 2017-11-05 – 
Page Previews
-   'cx',// [Editing] 2017-11-20 - 
ContentTranslation
-   'visualeditor-newwikitext',  // [Editing] 2017-11-02 – 
New wikitext editor
-   'twocolconflict',// [WMDE TW] 2017-11-12 – 
New edit conflict view
-   'rcenhancedfilters', // [Editing] 2017-11-18 - 
Enhanced recent changes filters
-   'codemirror-syntax-highlight',   // [Community Tech] 
2018-01-05 - Syntax highlighting
+   'visualeditor-enable',   // [Contrib] On-going 
(special permission) – VisualEditor
+   'beta-feature-flow-user-talk-page',  // [Contrib] On-going 
(special permission) – Flow opt-in
+   'uls-compact-links', // [Contrib] 2018-05-01 – 
Compact language links
+   'popups',// [Readers] 2018-04-01 – 
Page Previews
+   'cx',// [Contrib] 2018-05-05 - 
ContentTranslation
+   'visualeditor-newwikitext',  // [Contrib] 2018-05-02 – 
New wikitext editor
+   'twocolconflict',// [WMDE TW] 2018-04-30 – 
New edit conflict view
+   'rcenhancedfilters', // [Contrib] 2018-05-22 - 
Enhanced watchlist filters
+   'codemirror-syntax-highlight',   // [ComTech] 2018-05-06 - 
Syntax highlighting
'advancedsearch',// [WMDE TW] 2018-05-22 - 
Advanced Search
],
 ],

-- 
To view, visit https://gerrit.wikimedia.org/r/392885
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic23ac08a118b16fa5d2c32fdd653d253a3a8ce56
Gerrit-PatchSet: 1
Gerrit-Project: operations/mediawiki-config
Gerrit-Branch: master
Gerrit-Owner: Jforrester 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] operations/mediawiki-config[master]: Switch submit button from 'save' to 'publish' on enwiki

[Jforrester (Code Review)]

Jforrester has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/392886 )

Change subject: Switch submit button from 'save' to 'publish' on enwiki
..

Switch submit button from 'save' to 'publish' on enwiki

Change-Id: I13902cc35ab3ad452a1df3844479fd538504db8d
---
M wmf-config/InitialiseSettings.php
1 file changed, 2 insertions(+), 3 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/operations/mediawiki-config 
refs/changes/86/392886/1

diff --git a/wmf-config/InitialiseSettings.php 
b/wmf-config/InitialiseSettings.php
index 4a78b0d..38b1e7b 100644
--- a/wmf-config/InitialiseSettings.php
+++ b/wmf-config/InitialiseSettings.php
@@ -15340,12 +15340,11 @@
 
 // Whether to show "Publish" rather than "Save" on the edit page (and related 
circumstances)
 // This should be set to true for all public WMF wikis, and any changes should 
be discussed
-// with Editing before they are done due to the legal implications.
+// with Contributors and Legal before they are done, due to the legal 
implications.
 'wgEditSubmitButtonLabelPublish' => [
'default' => true,  // T131132 from 2017-03-15
'private' => false, // Private wikis are not public
-   'enwiki' => false,  // Temporarily not set
-   'wikinews' => false,// Done in local {{int:Copyrightwarning}}s 
instead.
+   'wikinews' => false,// Done via local {{int:Copyrightwarning}}s 
instead.
 ],
 
 'wmgCheckUserForceSummary' => [

-- 
To view, visit https://gerrit.wikimedia.org/r/392886
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I13902cc35ab3ad452a1df3844479fd538504db8d
Gerrit-PatchSet: 1
Gerrit-Project: operations/mediawiki-config
Gerrit-Branch: master
Gerrit-Owner: Jforrester 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki/core[wmf/1.31.0-wmf.8]: RCFilters: Respect subpage in RCLinked

[Jforrester (Code Review)]

Jforrester has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/392882 )

Change subject: RCFilters: Respect subpage in RCLinked
..

RCFilters: Respect subpage in RCLinked

Make sure that when we redirect a URL when there's a saved query,
we retain the information about a subpage.

Then, normalize the URL to always use =xxx so that the
system knows to correct the value if the user uses the form that
is, for the moment, outside the regular RCFilters interface.

Bug: T181100
Change-Id: I75cfb2b56a4da6357e6117b3f34f3178bfb2c90c
(cherry picked from commit 28132fb14afe23b27942150a2fb8b265ece40451)
---
M includes/specials/SpecialRecentchangeslinked.php
M resources/src/mediawiki.rcfilters/mw.rcfilters.UriProcessor.js
2 files changed, 27 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core 
refs/changes/82/392882/1

diff --git a/includes/specials/SpecialRecentchangeslinked.php 
b/includes/specials/SpecialRecentchangeslinked.php
index 358a309..e4cc3d1 100644
--- a/includes/specials/SpecialRecentchangeslinked.php
+++ b/includes/specials/SpecialRecentchangeslinked.php
@@ -30,6 +30,8 @@
/** @var bool|Title */
protected $rclTargetTitle;
 
+   protected $rclTarget;
+
function __construct() {
parent::__construct( 'Recentchangeslinked' );
}
@@ -44,6 +46,7 @@
 
public function parseParameters( $par, FormOptions $opts ) {
$opts['target'] = $par;
+   $this->rclTarget = $par;
}
 
/**
@@ -293,4 +296,15 @@
public function prefixSearchSubpages( $search, $limit, $offset ) {
return $this->prefixSearchString( $search, $limit, $offset );
}
+
+   /**
+* Get a self-referential title object
+* with consideration to the given subpage.
+*
+* @return Title
+* @since 1.23
+*/
+   public function getPageTitle() {
+   return parent::getPageTitle( $this->rclTarget );
+   }
 }
diff --git a/resources/src/mediawiki.rcfilters/mw.rcfilters.UriProcessor.js 
b/resources/src/mediawiki.rcfilters/mw.rcfilters.UriProcessor.js
index 621c200..fe806ed 100644
--- a/resources/src/mediawiki.rcfilters/mw.rcfilters.UriProcessor.js
+++ b/resources/src/mediawiki.rcfilters/mw.rcfilters.UriProcessor.js
@@ -63,13 +63,25 @@
 * @return {mw.Uri} Updated Uri
 */
mw.rcfilters.UriProcessor.prototype.getUpdatedUri = function ( uriQuery 
) {
-   var uri = new mw.Uri(),
+   var titlePieces,
+   uri = new mw.Uri(),
unrecognizedParams = this.getUnrecognizedParams( 
uriQuery || uri.query );
 
if ( uriQuery ) {
// This is mainly for tests, to be able to give the 
method
// an initial URI Query and test that it retains 
parameters
uri.query = uriQuery;
+   }
+
+   // Normalize subpage to use = so we are always
+   // consistent in Special:RecentChangesLinked between the
+   // ?title=Special:RecentChangesLinked/TargetPage and
+   // ?title=Special:RecentChangesLinked=TargetPage
+   if ( uri.query.title && uri.query.title.indexOf( '/' ) !== -1 ) 
{
+   titlePieces = uri.query.title.split( '/' );
+
+   unrecognizedParams.title = titlePieces.shift();
+   unrecognizedParams.target = titlePieces.join( '/' );
}
 
uri.query = this.filtersModel.getMinimizedParamRepresentation(
@@ -87,7 +99,6 @@
 
// Reapply unrecognized params and url version
uri.query = $.extend( true, {}, uri.query, unrecognizedParams, 
{ urlversion: '2' } );
-
return uri;
};
 

-- 
To view, visit https://gerrit.wikimedia.org/r/392882
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I75cfb2b56a4da6357e6117b3f34f3178bfb2c90c
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: wmf/1.31.0-wmf.8
Gerrit-Owner: Jforrester 
Gerrit-Reviewer: Mooeypoo 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: [DNM] Drop deprecated EnableAPI and EnableWriteAPI settings

[Jforrester (Code Review)]

Jforrester has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/392542 )

Change subject: [DNM] Drop deprecated EnableAPI and EnableWriteAPI settings
..

[DNM] Drop deprecated EnableAPI and EnableWriteAPI settings

Bug: T115414
Change-Id: I54ff9428b247ba203d67aba079149393f323d5a9
---
M api.php
M includes/DefaultSettings.php
M includes/OutputPage.php
M includes/Preferences.php
M includes/diff/DifferenceEngine.php
M includes/page/Article.php
M includes/resourceloader/ResourceLoaderStartUpModule.php
M includes/skins/Skin.php
M includes/specials/SpecialApiSandbox.php
M includes/specials/forms/UploadForm.php
M opensearch_desc.php
M tests/phpunit/includes/OutputPageTest.php
M tests/phpunit/includes/api/ApiTestCaseUpload.php
13 files changed, 48 insertions(+), 93 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core 
refs/changes/42/392542/1

diff --git a/api.php b/api.php
index d9a69db..9c5ac95 100644
--- a/api.php
+++ b/api.php
@@ -2,13 +2,10 @@
 /**
  * This file is the entry point for all API queries.
  *
- * It begins by checking whether the API is enabled on this wiki; if not,
- * it informs the user that s/he should set $wgEnableAPI to true and exits.
- * Otherwise, it constructs a new ApiMain using the parameter passed to it
- * as an argument in the URL ('?action=') and with write-enabled set to the
- * value of $wgEnableWriteAPI as specified in LocalSettings.php.
- * It then invokes "execute()" on the ApiMain object instance, which
- * produces output in the format specified in the URL.
+ * It begins by constructing a new ApiMain using the parameter passed to it
+ * as an argument in the URL ('?action='). It then invokes "execute()" on the
+ * ApiMain object instance, which produces output in the format specified in
+ * the URL.
  *
  * Copyright © 2006 Yuri Astrakhan @gmail.com
  *
@@ -55,14 +52,6 @@
die( 1 );
 }
 
-// Verify that the API has not been disabled
-if ( !$wgEnableAPI ) {
-   header( $_SERVER['SERVER_PROTOCOL'] . ' 500 MediaWiki configuration 
Error', true, 500 );
-   echo 'MediaWiki API is not enabled for this site. Add the following 
line to your LocalSettings.php'
-   . '$wgEnableAPI=true;';
-   die( 1 );
-}
-
 // Set a dummy $wgTitle, because $wgTitle == null breaks various things
 // In a perfect world this wouldn't be necessary
 $wgTitle = Title::makeTitle( NS_SPECIAL, 'Badtitle/dummy title for API calls 
set in api.php' );
@@ -76,7 +65,7 @@
 * is some form of an ApiMain, possibly even one that produces an error 
message,
 * but we don't care here, as that is handled by the constructor.
 */
-   $processor = new ApiMain( RequestContext::getMain(), $wgEnableWriteAPI 
);
+   $processor = new ApiMain( RequestContext::getMain(), true );
 
// Last chance hook before executing the API
Hooks::run( 'ApiBeforeMain', [ &$processor ] );
diff --git a/includes/DefaultSettings.php b/includes/DefaultSettings.php
index 3cd7ef1..5c3ad63 100644
--- a/includes/DefaultSettings.php
+++ b/includes/DefaultSettings.php
@@ -7964,25 +7964,6 @@
  */
 
 /**
- * Enable the MediaWiki API for convenient access to
- * machine-readable data via api.php
- *
- * See https://www.mediawiki.org/wiki/API
- *
- * @deprecated since 1.31
- */
-$wgEnableAPI = true;
-
-/**
- * Allow the API to be used to perform write operations
- * (page edits, rollback, etc.) when an authorised user
- * accesses it
- *
- * @deprecated since 1.31
- */
-$wgEnableWriteAPI = true;
-
-/**
  *
  * WARNING: SECURITY THREAT - debug use only
  *
@@ -8136,7 +8117,7 @@
 $wgAjaxUploadDestCheck = true;
 
 /**
- * Enable previewing licences via AJAX. Also requires $wgEnableAPI to be true.
+ * Enable previewing licences via AJAX.
  */
 $wgAjaxLicensePreview = true;
 
diff --git a/includes/OutputPage.php b/includes/OutputPage.php
index 4635f99..049335b 100644
--- a/includes/OutputPage.php
+++ b/includes/OutputPage.php
@@ -3406,24 +3406,22 @@
'title' => $this->msg( 'opensearch-desc' 
)->inContentLanguage()->text(),
] );
 
-   if ( $config->get( 'EnableAPI' ) ) {
-   # Real Simple Discovery link, provides auto-discovery 
information
-   # for the MediaWiki API (and potentially additional 
custom API
-   # support such as WordPress or Twitter-compatible APIs 
for a
-   # blogging extension, etc)
-   $tags['rsd'] = Html::element( 'link', [
-   'rel' => 'EditURI',
-   'type' => 'application/rsd+xml',
-   // Output a protocol-relative URL here if 
$wgServer is protocol-relative.
-   // Whether RSD accepts relative or 
protocol-relative URLs is completely
-   // undocumented, though.
-