[jira] [Commented] (OFBIZ-10145) Remove the Gradle wrapper from our release packages and add a step to our build notes
[ https://issues.apache.org/jira/browse/OFBIZ-10145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16919316#comment-16919316 ] Jacques Le Roux commented on OFBIZ-10145: - Great stuff, thanks Nicolas, Looking forward for https://cwiki.apache.org/confluence/display/OFBIZ/Load+new+gradle+wrapper+version+on+bintray ;) > Remove the Gradle wrapper from our release packages and add a step to our > build notes > - > > Key: OFBIZ-10145 > URL: https://issues.apache.org/jira/browse/OFBIZ-10145 > Project: OFBiz > Issue Type: Task > Components: Gradle >Affects Versions: 17.12.01, 16.11.06, 18.12.01 >Reporter: Jacques Le Roux >Assignee: Nicolas Malin >Priority: Blocker > Fix For: 17.12.01, 16.11.06, Upcoming Branch, 18.12.01 > > Attachments: OFBIZ-10145-gradlew.patch, > OFBIZ-10145_wrapper_properties_check.patch, gradlew.bat.patch, > gradlew.bat.patch, gradlew.bat.patch, gradlew.bat.patch, > init-gradle-wrapper-R16.sh, init-gradle-wrapper-trunk-and-18.sh, > init-gradle-wrapper-trunk-and-18.sh, init-gradle-wrapper-trunk-and-18.sh, > init-gradle-wrapper-trunk-and-18.sh, > init-gradle-wrapper-with-backup-and-checksum.sh, init-gradle-wrapper.bat, > init-gradle-wrapper.ps1, init-gradle-wrapper.ps1, init-gradle-wrapper.sh, > init-gradle-wrapper.sh, init-gradle-wrapper.sh, init-gradle-wrapper.sh, > init-gradle-wrapper.sh, init-gradle-wrapper.sh, init-gradle-wrapper.sh, > init-gradlew-readme-R16.patch, init-gradlew-readme-R17.1.patch, > init-gradlew-readme-R17.1.patch, init-gradlew-readme.patch, > init-gradlew-readme.patch, release-16.11-without-gradlew.patch, > release-16.11-without-gradlew.patch > > > Following the discussion at http://markmail.org/message/nd7grfiyobjkfwae, > considering LEGAL-288 and based on a lazy consensus on dev ML, we want to > remove the gradle-wrapper.jar file from the next packaged releases and use > [~jacopoc]'s related proposition to document how to have Gradle working in > the main README.md file. > # Extract the archive file to your local directory. > # Download gradle-wrapper.jar and place it in the > OFBiz-root-dir/gradle/wrapper folder. > I'm not sure if we should recommend a link to download the > gradle-wrapper.jar. This might change in the future (versions, etc.), so > indeed maybe simply asking to download is enough, cf > https://www.google.com/search?q=gradle-wrapper.jar+download=UTF-8 > Also we need to add a point about removing gradle-wrapper.jar in > https://cwiki.apache.org/confluence/display/OFBIZ/Release+Management+Guide+for+OFBiz -- This message was sent by Atlassian Jira (v8.3.2#803003)
[jira] [Commented] (OFBIZ-10145) Remove the Gradle wrapper from our release packages and add a step to our build notes
[ https://issues.apache.org/jira/browse/OFBIZ-10145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16919287#comment-16919287 ] Swapnil M Mane commented on OFBIZ-10145: Kudos, thanks so much everyone! :) > Remove the Gradle wrapper from our release packages and add a step to our > build notes > - > > Key: OFBIZ-10145 > URL: https://issues.apache.org/jira/browse/OFBIZ-10145 > Project: OFBiz > Issue Type: Task > Components: Gradle >Affects Versions: 17.12.01, 16.11.06, 18.12.01 >Reporter: Jacques Le Roux >Assignee: Nicolas Malin >Priority: Blocker > Fix For: 17.12.01, 16.11.06, Upcoming Branch, 18.12.01 > > Attachments: OFBIZ-10145-gradlew.patch, > OFBIZ-10145_wrapper_properties_check.patch, gradlew.bat.patch, > gradlew.bat.patch, gradlew.bat.patch, gradlew.bat.patch, > init-gradle-wrapper-R16.sh, init-gradle-wrapper-trunk-and-18.sh, > init-gradle-wrapper-trunk-and-18.sh, init-gradle-wrapper-trunk-and-18.sh, > init-gradle-wrapper-trunk-and-18.sh, > init-gradle-wrapper-with-backup-and-checksum.sh, init-gradle-wrapper.bat, > init-gradle-wrapper.ps1, init-gradle-wrapper.ps1, init-gradle-wrapper.sh, > init-gradle-wrapper.sh, init-gradle-wrapper.sh, init-gradle-wrapper.sh, > init-gradle-wrapper.sh, init-gradle-wrapper.sh, init-gradle-wrapper.sh, > init-gradlew-readme-R16.patch, init-gradlew-readme-R17.1.patch, > init-gradlew-readme-R17.1.patch, init-gradlew-readme.patch, > init-gradlew-readme.patch, release-16.11-without-gradlew.patch, > release-16.11-without-gradlew.patch > > > Following the discussion at http://markmail.org/message/nd7grfiyobjkfwae, > considering LEGAL-288 and based on a lazy consensus on dev ML, we want to > remove the gradle-wrapper.jar file from the next packaged releases and use > [~jacopoc]'s related proposition to document how to have Gradle working in > the main README.md file. > # Extract the archive file to your local directory. > # Download gradle-wrapper.jar and place it in the > OFBiz-root-dir/gradle/wrapper folder. > I'm not sure if we should recommend a link to download the > gradle-wrapper.jar. This might change in the future (versions, etc.), so > indeed maybe simply asking to download is enough, cf > https://www.google.com/search?q=gradle-wrapper.jar+download=UTF-8 > Also we need to add a point about removing gradle-wrapper.jar in > https://cwiki.apache.org/confluence/display/OFBIZ/Release+Management+Guide+for+OFBiz -- This message was sent by Atlassian Jira (v8.3.2#803003)
[jira] [Commented] (OFBIZ-10145) Remove the Gradle wrapper from our release packages and add a step to our build notes
[ https://issues.apache.org/jira/browse/OFBIZ-10145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16917821#comment-16917821 ] Jacques Le Roux commented on OFBIZ-10145: - Hi Nicolas, With the way used for 16.12.06 version, I believe this issue issue is essentially done, should we not close (w/o forgetting to document how to upload files to Bintray)? > Remove the Gradle wrapper from our release packages and add a step to our > build notes > - > > Key: OFBIZ-10145 > URL: https://issues.apache.org/jira/browse/OFBIZ-10145 > Project: OFBiz > Issue Type: Task > Components: Gradle >Affects Versions: 17.12.01, 16.11.06, 18.12.01 >Reporter: Jacques Le Roux >Assignee: Nicolas Malin >Priority: Blocker > Fix For: 17.12.01 > > Attachments: OFBIZ-10145-gradlew.patch, > OFBIZ-10145_wrapper_properties_check.patch, gradlew.bat.patch, > gradlew.bat.patch, gradlew.bat.patch, gradlew.bat.patch, > init-gradle-wrapper-R16.sh, init-gradle-wrapper-trunk-and-18.sh, > init-gradle-wrapper-trunk-and-18.sh, init-gradle-wrapper-trunk-and-18.sh, > init-gradle-wrapper-trunk-and-18.sh, > init-gradle-wrapper-with-backup-and-checksum.sh, init-gradle-wrapper.bat, > init-gradle-wrapper.ps1, init-gradle-wrapper.ps1, init-gradle-wrapper.sh, > init-gradle-wrapper.sh, init-gradle-wrapper.sh, init-gradle-wrapper.sh, > init-gradle-wrapper.sh, init-gradle-wrapper.sh, init-gradle-wrapper.sh, > init-gradlew-readme-R16.patch, init-gradlew-readme-R17.1.patch, > init-gradlew-readme-R17.1.patch, init-gradlew-readme.patch, > init-gradlew-readme.patch, release-16.11-without-gradlew.patch, > release-16.11-without-gradlew.patch > > > Following the discussion at http://markmail.org/message/nd7grfiyobjkfwae, > considering LEGAL-288 and based on a lazy consensus on dev ML, we want to > remove the gradle-wrapper.jar file from the next packaged releases and use > [~jacopoc]'s related proposition to document how to have Gradle working in > the main README.md file. > # Extract the archive file to your local directory. > # Download gradle-wrapper.jar and place it in the > OFBiz-root-dir/gradle/wrapper folder. > I'm not sure if we should recommend a link to download the > gradle-wrapper.jar. This might change in the future (versions, etc.), so > indeed maybe simply asking to download is enough, cf > https://www.google.com/search?q=gradle-wrapper.jar+download=UTF-8 > Also we need to add a point about removing gradle-wrapper.jar in > https://cwiki.apache.org/confluence/display/OFBIZ/Release+Management+Guide+for+OFBiz -- This message was sent by Atlassian Jira (v8.3.2#803003)
[jira] [Commented] (OFBIZ-10145) Remove the Gradle wrapper from our release packages and add a step to our build notes
[ https://issues.apache.org/jira/browse/OFBIZ-10145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16904645#comment-16904645 ] Jacques Le Roux commented on OFBIZ-10145: - BTW while working on it and downloading from http://dl.bintray.com I noticed that, in all branches, the gradle-wrapper.jar files are somehow different. When looking at the contents with 7-Zip, I can see different properties and number of them in the "root" of the archives. Also the 5.0.0 version on bintray claims it's FAT OS (I guess file system). Not sure from that this comes. I guess from the origin used to upload. Anyway I tested, at least with trunk, and it has no side effects. > Remove the Gradle wrapper from our release packages and add a step to our > build notes > - > > Key: OFBIZ-10145 > URL: https://issues.apache.org/jira/browse/OFBIZ-10145 > Project: OFBiz > Issue Type: Task > Components: Gradle >Affects Versions: 17.12.01, 16.11.06, 18.12.01 >Reporter: Jacques Le Roux >Assignee: Nicolas Malin >Priority: Blocker > Fix For: 17.12.01 > > Attachments: OFBIZ-10145-gradlew.patch, > OFBIZ-10145_wrapper_properties_check.patch, gradlew.bat.patch, > gradlew.bat.patch, gradlew.bat.patch, gradlew.bat.patch, > init-gradle-wrapper-R16.sh, init-gradle-wrapper-trunk-and-18.sh, > init-gradle-wrapper-trunk-and-18.sh, init-gradle-wrapper-trunk-and-18.sh, > init-gradle-wrapper-trunk-and-18.sh, > init-gradle-wrapper-with-backup-and-checksum.sh, init-gradle-wrapper.bat, > init-gradle-wrapper.ps1, init-gradle-wrapper.ps1, init-gradle-wrapper.sh, > init-gradle-wrapper.sh, init-gradle-wrapper.sh, init-gradle-wrapper.sh, > init-gradle-wrapper.sh, init-gradle-wrapper.sh, init-gradle-wrapper.sh, > init-gradlew-readme-R16.patch, init-gradlew-readme-R17.1.patch, > init-gradlew-readme-R17.1.patch, init-gradlew-readme.patch, > init-gradlew-readme.patch, release-16.11-without-gradlew.patch, > release-16.11-without-gradlew.patch > > > Following the discussion at http://markmail.org/message/nd7grfiyobjkfwae, > considering LEGAL-288 and based on a lazy consensus on dev ML, we want to > remove the gradle-wrapper.jar file from the next packaged releases and use > [~jacopoc]'s related proposition to document how to have Gradle working in > the main README.md file. > # Extract the archive file to your local directory. > # Download gradle-wrapper.jar and place it in the > OFBiz-root-dir/gradle/wrapper folder. > I'm not sure if we should recommend a link to download the > gradle-wrapper.jar. This might change in the future (versions, etc.), so > indeed maybe simply asking to download is enough, cf > https://www.google.com/search?q=gradle-wrapper.jar+download=UTF-8 > Also we need to add a point about removing gradle-wrapper.jar in > https://cwiki.apache.org/confluence/display/OFBIZ/Release+Management+Guide+for+OFBiz -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Commented] (OFBIZ-10145) Remove the Gradle wrapper from our release packages and add a step to our build notes
[ https://issues.apache.org/jira/browse/OFBIZ-10145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16904638#comment-16904638 ] Jacques Le Roux commented on OFBIZ-10145: - At r1864927 I have added the Windows init-gradle-wrapper scripts (both .bat et .ps1) in all concerned branch (trunk, R18, R17) These are very simple because I believe (almost?) nobody is using a Windows server to deploy OFBiz in production. So they will be only used in development environment. In case deployment in production is needed they supply a base to work on... The init-gradle-wrapper.ps1 scripts use only HTTP and not HTTPS because it's very difficult to handle all the issues related with different versions of Powershell and .net in different versions of Windows. Better to let that to deployment in case it's really needed... > Remove the Gradle wrapper from our release packages and add a step to our > build notes > - > > Key: OFBIZ-10145 > URL: https://issues.apache.org/jira/browse/OFBIZ-10145 > Project: OFBiz > Issue Type: Task > Components: Gradle >Affects Versions: 17.12.01, 16.11.06, 18.12.01 >Reporter: Jacques Le Roux >Assignee: Nicolas Malin >Priority: Blocker > Fix For: 17.12.01 > > Attachments: OFBIZ-10145-gradlew.patch, > OFBIZ-10145_wrapper_properties_check.patch, gradlew.bat.patch, > gradlew.bat.patch, gradlew.bat.patch, gradlew.bat.patch, > init-gradle-wrapper-R16.sh, init-gradle-wrapper-trunk-and-18.sh, > init-gradle-wrapper-trunk-and-18.sh, init-gradle-wrapper-trunk-and-18.sh, > init-gradle-wrapper-trunk-and-18.sh, > init-gradle-wrapper-with-backup-and-checksum.sh, init-gradle-wrapper.bat, > init-gradle-wrapper.ps1, init-gradle-wrapper.ps1, init-gradle-wrapper.sh, > init-gradle-wrapper.sh, init-gradle-wrapper.sh, init-gradle-wrapper.sh, > init-gradle-wrapper.sh, init-gradle-wrapper.sh, init-gradle-wrapper.sh, > init-gradlew-readme-R16.patch, init-gradlew-readme-R17.1.patch, > init-gradlew-readme-R17.1.patch, init-gradlew-readme.patch, > init-gradlew-readme.patch, release-16.11-without-gradlew.patch, > release-16.11-without-gradlew.patch > > > Following the discussion at http://markmail.org/message/nd7grfiyobjkfwae, > considering LEGAL-288 and based on a lazy consensus on dev ML, we want to > remove the gradle-wrapper.jar file from the next packaged releases and use > [~jacopoc]'s related proposition to document how to have Gradle working in > the main README.md file. > # Extract the archive file to your local directory. > # Download gradle-wrapper.jar and place it in the > OFBiz-root-dir/gradle/wrapper folder. > I'm not sure if we should recommend a link to download the > gradle-wrapper.jar. This might change in the future (versions, etc.), so > indeed maybe simply asking to download is enough, cf > https://www.google.com/search?q=gradle-wrapper.jar+download=UTF-8 > Also we need to add a point about removing gradle-wrapper.jar in > https://cwiki.apache.org/confluence/display/OFBIZ/Release+Management+Guide+for+OFBiz -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Commented] (OFBIZ-10145) Remove the Gradle wrapper from our release packages and add a step to our build notes
[ https://issues.apache.org/jira/browse/OFBIZ-10145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16903978#comment-16903978 ] Nicolas Malin commented on OFBIZ-10145: --- Hello, from my part : * The bintray account is open as opensource community [1] and pmc team have code to manage it * helper script as commited with correct version and check sum for : ** 17.12 : r1864812 ** 18.12 : r1864816 ** trunk : r1864815 [1] https://bintray.com/apacheofbiz/ > Remove the Gradle wrapper from our release packages and add a step to our > build notes > - > > Key: OFBIZ-10145 > URL: https://issues.apache.org/jira/browse/OFBIZ-10145 > Project: OFBiz > Issue Type: Task > Components: Gradle >Affects Versions: 17.12.01, 16.11.06, 18.12.01 >Reporter: Jacques Le Roux >Assignee: Nicolas Malin >Priority: Blocker > Fix For: 17.12.01 > > Attachments: OFBIZ-10145-gradlew.patch, > OFBIZ-10145_wrapper_properties_check.patch, gradlew.bat.patch, > gradlew.bat.patch, gradlew.bat.patch, gradlew.bat.patch, > init-gradle-wrapper-R16.sh, init-gradle-wrapper-trunk-and-18.sh, > init-gradle-wrapper-trunk-and-18.sh, init-gradle-wrapper-trunk-and-18.sh, > init-gradle-wrapper-trunk-and-18.sh, > init-gradle-wrapper-with-backup-and-checksum.sh, init-gradle-wrapper.bat, > init-gradle-wrapper.ps1, init-gradle-wrapper.ps1, init-gradle-wrapper.sh, > init-gradle-wrapper.sh, init-gradle-wrapper.sh, init-gradle-wrapper.sh, > init-gradle-wrapper.sh, init-gradle-wrapper.sh, init-gradle-wrapper.sh, > init-gradlew-readme-R16.patch, init-gradlew-readme-R17.1.patch, > init-gradlew-readme-R17.1.patch, init-gradlew-readme.patch, > init-gradlew-readme.patch, release-16.11-without-gradlew.patch, > release-16.11-without-gradlew.patch > > > Following the discussion at http://markmail.org/message/nd7grfiyobjkfwae, > considering LEGAL-288 and based on a lazy consensus on dev ML, we want to > remove the gradle-wrapper.jar file from the next packaged releases and use > [~jacopoc]'s related proposition to document how to have Gradle working in > the main README.md file. > # Extract the archive file to your local directory. > # Download gradle-wrapper.jar and place it in the > OFBiz-root-dir/gradle/wrapper folder. > I'm not sure if we should recommend a link to download the > gradle-wrapper.jar. This might change in the future (versions, etc.), so > indeed maybe simply asking to download is enough, cf > https://www.google.com/search?q=gradle-wrapper.jar+download=UTF-8 > Also we need to add a point about removing gradle-wrapper.jar in > https://cwiki.apache.org/confluence/display/OFBIZ/Release+Management+Guide+for+OFBiz -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Commented] (OFBIZ-10145) Remove the Gradle wrapper from our release packages and add a step to our build notes
[ https://issues.apache.org/jira/browse/OFBIZ-10145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16903867#comment-16903867 ] Jacopo Cappellato commented on OFBIZ-10145: --- Thank you [~swapnilmmane]! It is possible it is an issue specific to my environment, however it would be great if others could test it as well. In order to simplify testing and according to the feedback by Swapnil I have committed the patch in the 16.11 branch with revision 1864797. > Remove the Gradle wrapper from our release packages and add a step to our > build notes > - > > Key: OFBIZ-10145 > URL: https://issues.apache.org/jira/browse/OFBIZ-10145 > Project: OFBiz > Issue Type: Task > Components: Gradle >Affects Versions: 17.12.01, 16.11.06, 18.12.01 >Reporter: Jacques Le Roux >Assignee: Nicolas Malin >Priority: Blocker > Fix For: 17.12.01 > > Attachments: OFBIZ-10145-gradlew.patch, > OFBIZ-10145_wrapper_properties_check.patch, gradlew.bat.patch, > gradlew.bat.patch, gradlew.bat.patch, gradlew.bat.patch, > init-gradle-wrapper-R16.sh, init-gradle-wrapper-trunk-and-18.sh, > init-gradle-wrapper-trunk-and-18.sh, init-gradle-wrapper-trunk-and-18.sh, > init-gradle-wrapper-trunk-and-18.sh, > init-gradle-wrapper-with-backup-and-checksum.sh, init-gradle-wrapper.bat, > init-gradle-wrapper.ps1, init-gradle-wrapper.ps1, init-gradle-wrapper.sh, > init-gradle-wrapper.sh, init-gradle-wrapper.sh, init-gradle-wrapper.sh, > init-gradle-wrapper.sh, init-gradle-wrapper.sh, init-gradle-wrapper.sh, > init-gradlew-readme-R16.patch, init-gradlew-readme-R17.1.patch, > init-gradlew-readme-R17.1.patch, init-gradlew-readme.patch, > init-gradlew-readme.patch, release-16.11-without-gradlew.patch, > release-16.11-without-gradlew.patch > > > Following the discussion at http://markmail.org/message/nd7grfiyobjkfwae, > considering LEGAL-288 and based on a lazy consensus on dev ML, we want to > remove the gradle-wrapper.jar file from the next packaged releases and use > [~jacopoc]'s related proposition to document how to have Gradle working in > the main README.md file. > # Extract the archive file to your local directory. > # Download gradle-wrapper.jar and place it in the > OFBiz-root-dir/gradle/wrapper folder. > I'm not sure if we should recommend a link to download the > gradle-wrapper.jar. This might change in the future (versions, etc.), so > indeed maybe simply asking to download is enough, cf > https://www.google.com/search?q=gradle-wrapper.jar+download=UTF-8 > Also we need to add a point about removing gradle-wrapper.jar in > https://cwiki.apache.org/confluence/display/OFBIZ/Release+Management+Guide+for+OFBiz -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Commented] (OFBIZ-10145) Remove the Gradle wrapper from our release packages and add a step to our build notes
[ https://issues.apache.org/jira/browse/OFBIZ-10145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16903813#comment-16903813 ] Swapnil M Mane commented on OFBIZ-10145: Hi [~jacopoc], Thanks for the patch. I followed the steps mentioned above with patch applied, and everything works well (got no error) for me. Thanks! > Remove the Gradle wrapper from our release packages and add a step to our > build notes > - > > Key: OFBIZ-10145 > URL: https://issues.apache.org/jira/browse/OFBIZ-10145 > Project: OFBiz > Issue Type: Task > Components: Gradle >Affects Versions: 17.12.01, 16.11.06, 18.12.01 >Reporter: Jacques Le Roux >Assignee: Nicolas Malin >Priority: Blocker > Fix For: 17.12.01 > > Attachments: OFBIZ-10145-gradlew.patch, > OFBIZ-10145_wrapper_properties_check.patch, gradlew.bat.patch, > gradlew.bat.patch, gradlew.bat.patch, gradlew.bat.patch, > init-gradle-wrapper-R16.sh, init-gradle-wrapper-trunk-and-18.sh, > init-gradle-wrapper-trunk-and-18.sh, init-gradle-wrapper-trunk-and-18.sh, > init-gradle-wrapper-trunk-and-18.sh, > init-gradle-wrapper-with-backup-and-checksum.sh, init-gradle-wrapper.bat, > init-gradle-wrapper.ps1, init-gradle-wrapper.ps1, init-gradle-wrapper.sh, > init-gradle-wrapper.sh, init-gradle-wrapper.sh, init-gradle-wrapper.sh, > init-gradle-wrapper.sh, init-gradle-wrapper.sh, init-gradle-wrapper.sh, > init-gradlew-readme-R16.patch, init-gradlew-readme-R17.1.patch, > init-gradlew-readme-R17.1.patch, init-gradlew-readme.patch, > init-gradlew-readme.patch, release-16.11-without-gradlew.patch, > release-16.11-without-gradlew.patch > > > Following the discussion at http://markmail.org/message/nd7grfiyobjkfwae, > considering LEGAL-288 and based on a lazy consensus on dev ML, we want to > remove the gradle-wrapper.jar file from the next packaged releases and use > [~jacopoc]'s related proposition to document how to have Gradle working in > the main README.md file. > # Extract the archive file to your local directory. > # Download gradle-wrapper.jar and place it in the > OFBiz-root-dir/gradle/wrapper folder. > I'm not sure if we should recommend a link to download the > gradle-wrapper.jar. This might change in the future (versions, etc.), so > indeed maybe simply asking to download is enough, cf > https://www.google.com/search?q=gradle-wrapper.jar+download=UTF-8 > Also we need to add a point about removing gradle-wrapper.jar in > https://cwiki.apache.org/confluence/display/OFBIZ/Release+Management+Guide+for+OFBiz -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Commented] (OFBIZ-10145) Remove the Gradle wrapper from our release packages and add a step to our build notes
[
https://issues.apache.org/jira/browse/OFBIZ-10145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16903765#comment-16903765
]
Jacopo Cappellato commented on OFBIZ-10145:
---
Hi all,
I need some help testing my patch because when I generate the wrapper file
named 'gradlew' it contains the following setting:
{quote}DEFAULT_JVM_OPTS='"-Xmx64m" "-Xms64m"'
{quote}
instead of:
{quote}DEFAULT_JVM_OPTS=""
{quote}
With the former, I am getting an out-of-memory error when I try to build OFBiz.
I need your help to test it (both the gradlew.bat and the gradlew file) in your
environment.
Steps to replicate:
1) get a fresh checkout of 16.11
2) remove the files: gradlew and gradlew.bat
3) re-create them with the command:
{quote}gradle wrapper --gradle-version 2.13
{quote}
4) run the command:
./gradlew build
You should get an error java.lang.OutOfMemoryError
The error can be fixed by editing gradlew to change this:
{quote} DEFAULT_JVM_OPTS='"-Xmx64m" "-Xms64m"'
{quote}
into this
{quote}DEFAULT_JVM_OPTS=""
{quote}
Can you confirm this behavior?
I could fix it, without editing gradlew, by adding to the OFBiz home folder a
file named gradle.properties containing:
{quote}org.gradle.jvmargs="-Xmx512m"
{quote}
It would be great if you could also test this.
Thanks.
> Remove the Gradle wrapper from our release packages and add a step to our
> build notes
> -
>
> Key: OFBIZ-10145
> URL: https://issues.apache.org/jira/browse/OFBIZ-10145
> Project: OFBiz
> Issue Type: Task
> Components: Gradle
>Affects Versions: 17.12.01, 16.11.06, 18.12.01
>Reporter: Jacques Le Roux
>Assignee: Nicolas Malin
>Priority: Blocker
> Fix For: 17.12.01
>
> Attachments: OFBIZ-10145-gradlew.patch,
> OFBIZ-10145_wrapper_properties_check.patch, gradlew.bat.patch,
> gradlew.bat.patch, gradlew.bat.patch, gradlew.bat.patch,
> init-gradle-wrapper-R16.sh, init-gradle-wrapper-trunk-and-18.sh,
> init-gradle-wrapper-trunk-and-18.sh, init-gradle-wrapper-trunk-and-18.sh,
> init-gradle-wrapper-trunk-and-18.sh,
> init-gradle-wrapper-with-backup-and-checksum.sh, init-gradle-wrapper.bat,
> init-gradle-wrapper.ps1, init-gradle-wrapper.ps1, init-gradle-wrapper.sh,
> init-gradle-wrapper.sh, init-gradle-wrapper.sh, init-gradle-wrapper.sh,
> init-gradle-wrapper.sh, init-gradle-wrapper.sh, init-gradle-wrapper.sh,
> init-gradlew-readme-R16.patch, init-gradlew-readme-R17.1.patch,
> init-gradlew-readme-R17.1.patch, init-gradlew-readme.patch,
> init-gradlew-readme.patch, release-16.11-without-gradlew.patch,
> release-16.11-without-gradlew.patch
>
>
> Following the discussion at http://markmail.org/message/nd7grfiyobjkfwae,
> considering LEGAL-288 and based on a lazy consensus on dev ML, we want to
> remove the gradle-wrapper.jar file from the next packaged releases and use
> [~jacopoc]'s related proposition to document how to have Gradle working in
> the main README.md file.
> # Extract the archive file to your local directory.
> # Download gradle-wrapper.jar and place it in the
> OFBiz-root-dir/gradle/wrapper folder.
> I'm not sure if we should recommend a link to download the
> gradle-wrapper.jar. This might change in the future (versions, etc.), so
> indeed maybe simply asking to download is enough, cf
> https://www.google.com/search?q=gradle-wrapper.jar+download=UTF-8
> Also we need to add a point about removing gradle-wrapper.jar in
> https://cwiki.apache.org/confluence/display/OFBIZ/Release+Management+Guide+for+OFBiz
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
[jira] [Commented] (OFBIZ-10145) Remove the Gradle wrapper from our release packages and add a step to our build notes
[ https://issues.apache.org/jira/browse/OFBIZ-10145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16903168#comment-16903168 ] Jacques Le Roux commented on OFBIZ-10145: - I did not see that you need an account. I just noticed that there is not the 5.0 version there. I agree that an OFBiz account would work :) > Remove the Gradle wrapper from our release packages and add a step to our > build notes > - > > Key: OFBIZ-10145 > URL: https://issues.apache.org/jira/browse/OFBIZ-10145 > Project: OFBiz > Issue Type: Task > Components: Gradle >Affects Versions: 17.12.01, 16.11.06, 18.12.01 >Reporter: Jacques Le Roux >Assignee: Nicolas Malin >Priority: Blocker > Fix For: 17.12.01 > > Attachments: OFBIZ-10145-gradlew.patch, > OFBIZ-10145_wrapper_properties_check.patch, gradlew.bat.patch, > gradlew.bat.patch, gradlew.bat.patch, gradlew.bat.patch, > init-gradle-wrapper-R16.sh, init-gradle-wrapper-trunk-and-18.sh, > init-gradle-wrapper-trunk-and-18.sh, init-gradle-wrapper-trunk-and-18.sh, > init-gradle-wrapper-trunk-and-18.sh, > init-gradle-wrapper-with-backup-and-checksum.sh, init-gradle-wrapper.bat, > init-gradle-wrapper.ps1, init-gradle-wrapper.ps1, init-gradle-wrapper.sh, > init-gradle-wrapper.sh, init-gradle-wrapper.sh, init-gradle-wrapper.sh, > init-gradle-wrapper.sh, init-gradle-wrapper.sh, init-gradle-wrapper.sh, > init-gradlew-readme-R16.patch, init-gradlew-readme-R17.1.patch, > init-gradlew-readme-R17.1.patch, init-gradlew-readme.patch, > init-gradlew-readme.patch, release-16.11-without-gradlew.patch, > release-16.11-without-gradlew.patch > > > Following the discussion at http://markmail.org/message/nd7grfiyobjkfwae, > considering LEGAL-288 and based on a lazy consensus on dev ML, we want to > remove the gradle-wrapper.jar file from the next packaged releases and use > [~jacopoc]'s related proposition to document how to have Gradle working in > the main README.md file. > # Extract the archive file to your local directory. > # Download gradle-wrapper.jar and place it in the > OFBiz-root-dir/gradle/wrapper folder. > I'm not sure if we should recommend a link to download the > gradle-wrapper.jar. This might change in the future (versions, etc.), so > indeed maybe simply asking to download is enough, cf > https://www.google.com/search?q=gradle-wrapper.jar+download=UTF-8 > Also we need to add a point about removing gradle-wrapper.jar in > https://cwiki.apache.org/confluence/display/OFBIZ/Release+Management+Guide+for+OFBiz -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Commented] (OFBIZ-10145) Remove the Gradle wrapper from our release packages and add a step to our build notes
[ https://issues.apache.org/jira/browse/OFBIZ-10145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16903150#comment-16903150 ] Nicolas Malin commented on OFBIZ-10145: --- I tried to load new gradle wrapper version in current bintray repository without success [1] so I continued with open I new account and load needed version. This work fine [2] but is under my name (during my test :) ) Now if no opposition, I can open a real account for Apache OFBiz (managed by PMC) and terminate this task adter loading all wrapper used \o/ [1] https://bintray.com/bintray/jcenter/org.gradle:gradle-wrapper [2] https://bintray.com/nicolasmalin/GradleWrapper/org.gradle.gradle-wrapper > Remove the Gradle wrapper from our release packages and add a step to our > build notes > - > > Key: OFBIZ-10145 > URL: https://issues.apache.org/jira/browse/OFBIZ-10145 > Project: OFBiz > Issue Type: Task > Components: Gradle >Affects Versions: 17.12.01, 16.11.06, 18.12.01 >Reporter: Jacques Le Roux >Assignee: Nicolas Malin >Priority: Blocker > Fix For: 17.12.01 > > Attachments: OFBIZ-10145-gradlew.patch, > OFBIZ-10145_wrapper_properties_check.patch, gradlew.bat.patch, > gradlew.bat.patch, gradlew.bat.patch, gradlew.bat.patch, > init-gradle-wrapper-R16.sh, init-gradle-wrapper-trunk-and-18.sh, > init-gradle-wrapper-trunk-and-18.sh, init-gradle-wrapper-trunk-and-18.sh, > init-gradle-wrapper-trunk-and-18.sh, > init-gradle-wrapper-with-backup-and-checksum.sh, init-gradle-wrapper.bat, > init-gradle-wrapper.ps1, init-gradle-wrapper.ps1, init-gradle-wrapper.sh, > init-gradle-wrapper.sh, init-gradle-wrapper.sh, init-gradle-wrapper.sh, > init-gradle-wrapper.sh, init-gradle-wrapper.sh, init-gradle-wrapper.sh, > init-gradlew-readme-R16.patch, init-gradlew-readme-R17.1.patch, > init-gradlew-readme-R17.1.patch, init-gradlew-readme.patch, > init-gradlew-readme.patch, release-16.11-without-gradlew.patch, > release-16.11-without-gradlew.patch > > > Following the discussion at http://markmail.org/message/nd7grfiyobjkfwae, > considering LEGAL-288 and based on a lazy consensus on dev ML, we want to > remove the gradle-wrapper.jar file from the next packaged releases and use > [~jacopoc]'s related proposition to document how to have Gradle working in > the main README.md file. > # Extract the archive file to your local directory. > # Download gradle-wrapper.jar and place it in the > OFBiz-root-dir/gradle/wrapper folder. > I'm not sure if we should recommend a link to download the > gradle-wrapper.jar. This might change in the future (versions, etc.), so > indeed maybe simply asking to download is enough, cf > https://www.google.com/search?q=gradle-wrapper.jar+download=UTF-8 > Also we need to add a point about removing gradle-wrapper.jar in > https://cwiki.apache.org/confluence/display/OFBIZ/Release+Management+Guide+for+OFBiz -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Commented] (OFBIZ-10145) Remove the Gradle wrapper from our release packages and add a step to our build notes
[ https://issues.apache.org/jira/browse/OFBIZ-10145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16902140#comment-16902140 ] Jacques Le Roux commented on OFBIZ-10145: - Hi Jacopo, Thanks for tacking care of our Release Management Guide, I agree we can wait. I'm not against about the option 1) I even think that at this stage it's the best solution. > Remove the Gradle wrapper from our release packages and add a step to our > build notes > - > > Key: OFBIZ-10145 > URL: https://issues.apache.org/jira/browse/OFBIZ-10145 > Project: OFBiz > Issue Type: Task > Components: Gradle >Affects Versions: 17.12.01, 16.11.06, 18.12.01 >Reporter: Jacques Le Roux >Assignee: Nicolas Malin >Priority: Blocker > Fix For: 17.12.01 > > Attachments: OFBIZ-10145-gradlew.patch, > OFBIZ-10145_wrapper_properties_check.patch, gradlew.bat.patch, > gradlew.bat.patch, gradlew.bat.patch, gradlew.bat.patch, > init-gradle-wrapper-R16.sh, init-gradle-wrapper-trunk-and-18.sh, > init-gradle-wrapper-trunk-and-18.sh, init-gradle-wrapper-trunk-and-18.sh, > init-gradle-wrapper-trunk-and-18.sh, > init-gradle-wrapper-with-backup-and-checksum.sh, init-gradle-wrapper.bat, > init-gradle-wrapper.ps1, init-gradle-wrapper.ps1, init-gradle-wrapper.sh, > init-gradle-wrapper.sh, init-gradle-wrapper.sh, init-gradle-wrapper.sh, > init-gradle-wrapper.sh, init-gradle-wrapper.sh, init-gradle-wrapper.sh, > init-gradlew-readme-R16.patch, init-gradlew-readme-R17.1.patch, > init-gradlew-readme-R17.1.patch, init-gradlew-readme.patch, > init-gradlew-readme.patch, release-16.11-without-gradlew.patch, > release-16.11-without-gradlew.patch > > > Following the discussion at http://markmail.org/message/nd7grfiyobjkfwae, > considering LEGAL-288 and based on a lazy consensus on dev ML, we want to > remove the gradle-wrapper.jar file from the next packaged releases and use > [~jacopoc]'s related proposition to document how to have Gradle working in > the main README.md file. > # Extract the archive file to your local directory. > # Download gradle-wrapper.jar and place it in the > OFBiz-root-dir/gradle/wrapper folder. > I'm not sure if we should recommend a link to download the > gradle-wrapper.jar. This might change in the future (versions, etc.), so > indeed maybe simply asking to download is enough, cf > https://www.google.com/search?q=gradle-wrapper.jar+download=UTF-8 > Also we need to add a point about removing gradle-wrapper.jar in > https://cwiki.apache.org/confluence/display/OFBIZ/Release+Management+Guide+for+OFBiz -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Commented] (OFBIZ-10145) Remove the Gradle wrapper from our release packages and add a step to our build notes
[ https://issues.apache.org/jira/browse/OFBIZ-10145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16901784#comment-16901784 ] Nicolas Malin commented on OFBIZ-10145: --- [~jacopoc] to move forward I suggest to follow your first proposal. I oriented the works for 17.12.01 and now need to check for bintray :) > Remove the Gradle wrapper from our release packages and add a step to our > build notes > - > > Key: OFBIZ-10145 > URL: https://issues.apache.org/jira/browse/OFBIZ-10145 > Project: OFBiz > Issue Type: Task > Components: Gradle >Affects Versions: 17.12.01, 16.11.06, 18.12.01 >Reporter: Jacques Le Roux >Assignee: Nicolas Malin >Priority: Blocker > Fix For: 17.12.01 > > Attachments: OFBIZ-10145-gradlew.patch, > OFBIZ-10145_wrapper_properties_check.patch, gradlew.bat.patch, > gradlew.bat.patch, gradlew.bat.patch, gradlew.bat.patch, > init-gradle-wrapper-R16.sh, init-gradle-wrapper-trunk-and-18.sh, > init-gradle-wrapper-trunk-and-18.sh, init-gradle-wrapper-trunk-and-18.sh, > init-gradle-wrapper-trunk-and-18.sh, > init-gradle-wrapper-with-backup-and-checksum.sh, init-gradle-wrapper.bat, > init-gradle-wrapper.ps1, init-gradle-wrapper.ps1, init-gradle-wrapper.sh, > init-gradle-wrapper.sh, init-gradle-wrapper.sh, init-gradle-wrapper.sh, > init-gradle-wrapper.sh, init-gradle-wrapper.sh, init-gradle-wrapper.sh, > init-gradlew-readme-R16.patch, init-gradlew-readme-R17.1.patch, > init-gradlew-readme-R17.1.patch, init-gradlew-readme.patch, > init-gradlew-readme.patch, release-16.11-without-gradlew.patch, > release-16.11-without-gradlew.patch > > > Following the discussion at http://markmail.org/message/nd7grfiyobjkfwae, > considering LEGAL-288 and based on a lazy consensus on dev ML, we want to > remove the gradle-wrapper.jar file from the next packaged releases and use > [~jacopoc]'s related proposition to document how to have Gradle working in > the main README.md file. > # Extract the archive file to your local directory. > # Download gradle-wrapper.jar and place it in the > OFBiz-root-dir/gradle/wrapper folder. > I'm not sure if we should recommend a link to download the > gradle-wrapper.jar. This might change in the future (versions, etc.), so > indeed maybe simply asking to download is enough, cf > https://www.google.com/search?q=gradle-wrapper.jar+download=UTF-8 > Also we need to add a point about removing gradle-wrapper.jar in > https://cwiki.apache.org/confluence/display/OFBIZ/Release+Management+Guide+for+OFBiz -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Commented] (OFBIZ-10145) Remove the Gradle wrapper from our release packages and add a step to our build notes
[ https://issues.apache.org/jira/browse/OFBIZ-10145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16900829#comment-16900829 ] Jacopo Cappellato commented on OFBIZ-10145: --- [~jacques.le.roux]: I can take care of updating our Release Management Guide but maybe we can wait until we have finalized the long term release strategy that we like most. Before this happens, I would like to proceed for the 16.11.06 release and I am getting confused about what needs to happen there before we can release; my understanding is that we need to: 1) apply the patch that I have submitted some days ago: [^release-16.11-without-gradlew.patch] OR 2) alternatively we can apply your updated patch [^release-16.11-without-gradlew.patch] after that Nicola has completed his work on the init wrapper and we have finalized our discussion on Bintray etc... I still prefer option #1 because it will allow us to proceed now and will give us time to craft a good solution for future releases. Any other opinion? If we go with option #1, are there other tasks before the release that I am missing? > Remove the Gradle wrapper from our release packages and add a step to our > build notes > - > > Key: OFBIZ-10145 > URL: https://issues.apache.org/jira/browse/OFBIZ-10145 > Project: OFBiz > Issue Type: Task > Components: Gradle >Affects Versions: 17.12.01, 16.11.06, 18.12.01 >Reporter: Jacques Le Roux >Assignee: Nicolas Malin >Priority: Blocker > Fix For: 17.12.01 > > Attachments: OFBIZ-10145-gradlew.patch, > OFBIZ-10145_wrapper_properties_check.patch, gradlew.bat.patch, > gradlew.bat.patch, gradlew.bat.patch, gradlew.bat.patch, > init-gradle-wrapper-R16.sh, init-gradle-wrapper-trunk-and-18.sh, > init-gradle-wrapper-trunk-and-18.sh, init-gradle-wrapper-trunk-and-18.sh, > init-gradle-wrapper-trunk-and-18.sh, > init-gradle-wrapper-with-backup-and-checksum.sh, init-gradle-wrapper.bat, > init-gradle-wrapper.ps1, init-gradle-wrapper.ps1, init-gradle-wrapper.sh, > init-gradle-wrapper.sh, init-gradle-wrapper.sh, init-gradle-wrapper.sh, > init-gradle-wrapper.sh, init-gradle-wrapper.sh, init-gradle-wrapper.sh, > init-gradlew-readme-R16.patch, init-gradlew-readme-R17.1.patch, > init-gradlew-readme-R17.1.patch, init-gradlew-readme.patch, > init-gradlew-readme.patch, release-16.11-without-gradlew.patch, > release-16.11-without-gradlew.patch > > > Following the discussion at http://markmail.org/message/nd7grfiyobjkfwae, > considering LEGAL-288 and based on a lazy consensus on dev ML, we want to > remove the gradle-wrapper.jar file from the next packaged releases and use > [~jacopoc]'s related proposition to document how to have Gradle working in > the main README.md file. > # Extract the archive file to your local directory. > # Download gradle-wrapper.jar and place it in the > OFBiz-root-dir/gradle/wrapper folder. > I'm not sure if we should recommend a link to download the > gradle-wrapper.jar. This might change in the future (versions, etc.), so > indeed maybe simply asking to download is enough, cf > https://www.google.com/search?q=gradle-wrapper.jar+download=UTF-8 > Also we need to add a point about removing gradle-wrapper.jar in > https://cwiki.apache.org/confluence/display/OFBIZ/Release+Management+Guide+for+OFBiz -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Commented] (OFBIZ-10145) Remove the Gradle wrapper from our release packages and add a step to our build notes
[ https://issues.apache.org/jira/browse/OFBIZ-10145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16899847#comment-16899847 ] Nicolas Malin commented on OFBIZ-10145: --- Good catch Jacques :) > Remove the Gradle wrapper from our release packages and add a step to our > build notes > - > > Key: OFBIZ-10145 > URL: https://issues.apache.org/jira/browse/OFBIZ-10145 > Project: OFBiz > Issue Type: Task > Components: Gradle >Affects Versions: 17.12.01, 16.11.06, 18.12.01 >Reporter: Jacques Le Roux >Assignee: Nicolas Malin >Priority: Blocker > Fix For: 17.12.01 > > Attachments: OFBIZ-10145-gradlew.patch, > OFBIZ-10145_wrapper_properties_check.patch, gradlew.bat.patch, > gradlew.bat.patch, gradlew.bat.patch, gradlew.bat.patch, > init-gradle-wrapper-R16.sh, init-gradle-wrapper-trunk-and-18.sh, > init-gradle-wrapper-trunk-and-18.sh, init-gradle-wrapper-trunk-and-18.sh, > init-gradle-wrapper-trunk-and-18.sh, > init-gradle-wrapper-with-backup-and-checksum.sh, init-gradle-wrapper.bat, > init-gradle-wrapper.ps1, init-gradle-wrapper.ps1, init-gradle-wrapper.sh, > init-gradle-wrapper.sh, init-gradle-wrapper.sh, init-gradle-wrapper.sh, > init-gradle-wrapper.sh, init-gradle-wrapper.sh, init-gradle-wrapper.sh, > init-gradlew-readme-R16.patch, init-gradlew-readme-R17.1.patch, > init-gradlew-readme-R17.1.patch, init-gradlew-readme.patch, > init-gradlew-readme.patch, release-16.11-without-gradlew.patch, > release-16.11-without-gradlew.patch > > > Following the discussion at http://markmail.org/message/nd7grfiyobjkfwae, > considering LEGAL-288 and based on a lazy consensus on dev ML, we want to > remove the gradle-wrapper.jar file from the next packaged releases and use > [~jacopoc]'s related proposition to document how to have Gradle working in > the main README.md file. > # Extract the archive file to your local directory. > # Download gradle-wrapper.jar and place it in the > OFBiz-root-dir/gradle/wrapper folder. > I'm not sure if we should recommend a link to download the > gradle-wrapper.jar. This might change in the future (versions, etc.), so > indeed maybe simply asking to download is enough, cf > https://www.google.com/search?q=gradle-wrapper.jar+download=UTF-8 > Also we need to add a point about removing gradle-wrapper.jar in > https://cwiki.apache.org/confluence/display/OFBIZ/Release+Management+Guide+for+OFBiz -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Commented] (OFBIZ-10145) Remove the Gradle wrapper from our release packages and add a step to our build notes
[ https://issues.apache.org/jira/browse/OFBIZ-10145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16899454#comment-16899454 ] Jacques Le Roux commented on OFBIZ-10145: - Hi Jacopo, Will you handle the changes in https://cwiki.apache.org/confluence/display/OFBIZ/Release+Management+Guide+for+OFBiz or do you prefer that we do it later when releasing R17 and olders? The RM should be stable then. Note: I prefer to keep this bloker issue open as a reminder and close it later when the RM process will be stable. > Remove the Gradle wrapper from our release packages and add a step to our > build notes > - > > Key: OFBIZ-10145 > URL: https://issues.apache.org/jira/browse/OFBIZ-10145 > Project: OFBiz > Issue Type: Task > Components: Gradle >Affects Versions: 17.12.01, 16.11.06, 18.12.01 >Reporter: Jacques Le Roux >Assignee: Nicolas Malin >Priority: Blocker > Fix For: 17.12.01 > > Attachments: OFBIZ-10145-gradlew.patch, > OFBIZ-10145_wrapper_properties_check.patch, gradlew.bat.patch, > gradlew.bat.patch, gradlew.bat.patch, gradlew.bat.patch, > init-gradle-wrapper-R16.sh, init-gradle-wrapper-trunk-and-18.sh, > init-gradle-wrapper-trunk-and-18.sh, init-gradle-wrapper-trunk-and-18.sh, > init-gradle-wrapper-trunk-and-18.sh, > init-gradle-wrapper-with-backup-and-checksum.sh, init-gradle-wrapper.bat, > init-gradle-wrapper.ps1, init-gradle-wrapper.ps1, init-gradle-wrapper.sh, > init-gradle-wrapper.sh, init-gradle-wrapper.sh, init-gradle-wrapper.sh, > init-gradle-wrapper.sh, init-gradle-wrapper.sh, init-gradle-wrapper.sh, > init-gradlew-readme-R16.patch, init-gradlew-readme-R17.1.patch, > init-gradlew-readme-R17.1.patch, init-gradlew-readme.patch, > init-gradlew-readme.patch, release-16.11-without-gradlew.patch, > release-16.11-without-gradlew.patch > > > Following the discussion at http://markmail.org/message/nd7grfiyobjkfwae, > considering LEGAL-288 and based on a lazy consensus on dev ML, we want to > remove the gradle-wrapper.jar file from the next packaged releases and use > [~jacopoc]'s related proposition to document how to have Gradle working in > the main README.md file. > # Extract the archive file to your local directory. > # Download gradle-wrapper.jar and place it in the > OFBiz-root-dir/gradle/wrapper folder. > I'm not sure if we should recommend a link to download the > gradle-wrapper.jar. This might change in the future (versions, etc.), so > indeed maybe simply asking to download is enough, cf > https://www.google.com/search?q=gradle-wrapper.jar+download=UTF-8 > Also we need to add a point about removing gradle-wrapper.jar in > https://cwiki.apache.org/confluence/display/OFBIZ/Release+Management+Guide+for+OFBiz -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Commented] (OFBIZ-10145) Remove the Gradle wrapper from our release packages and add a step to our build notes
[
https://issues.apache.org/jira/browse/OFBIZ-10145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16899449#comment-16899449
]
Jacques Le Roux commented on OFBIZ-10145:
-
Hi Nicolas,
Globally your patch looks good to me, at least the intent :)
It's the same that I proposed at
[https://markmail.org/message/4cdbkfm47jmcsyim:]
{quote}as a priority we should download the wrapper from Gradle "repo", and if
it's not longer there, use OFBiz repo. The later would be very rare.
{quote}
It seems you did not notice that I have removed the wrappers from tools.
Because they are present in releases branches and will stay there, as we
agreed. They will be only removed during the RM phase. So instead of
{code:java}
RELEASE="5.0.0"
GRADLE_WRAPPER_URI="https://github.com/gradle/gradle/raw/v$RELEASE/gradle/wrapper/;
GRADLE_WRAPPER_URI_BACKUP="https://svn.apache.org/repos/asf/ofbiz/tools/gradle/wrapper/v$RELEASE;
{code}
you should use something like (here for R17)
{code:java}
GRADLE_RELEASE="3.2.1"
OFBIZ_RELEASE="17.12"
GRADLE_WRAPPER_URI="https://github.com/gradle/gradle/raw/v$GRADLE_RELEASE/gradle/wrapper/;
GRADLE_WRAPPER_URI_BACKUP=https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/branches/release$OFBIZ_RELEASE/gradle/wrapper;
{code}
Except if your idea is to copy and maintain the wrappers versions in tools,
which seems not needed and more work to me ;)
> Remove the Gradle wrapper from our release packages and add a step to our
> build notes
> -
>
> Key: OFBIZ-10145
> URL: https://issues.apache.org/jira/browse/OFBIZ-10145
> Project: OFBiz
> Issue Type: Task
> Components: Gradle
>Affects Versions: 17.12.01, 16.11.06, 18.12.01
>Reporter: Jacques Le Roux
>Assignee: Nicolas Malin
>Priority: Blocker
> Fix For: 17.12.01
>
> Attachments: OFBIZ-10145-gradlew.patch,
> OFBIZ-10145_wrapper_properties_check.patch, gradlew.bat.patch,
> gradlew.bat.patch, gradlew.bat.patch, gradlew.bat.patch,
> init-gradle-wrapper-R16.sh, init-gradle-wrapper-trunk-and-18.sh,
> init-gradle-wrapper-trunk-and-18.sh, init-gradle-wrapper-trunk-and-18.sh,
> init-gradle-wrapper-trunk-and-18.sh,
> init-gradle-wrapper-with-backup-and-checksum.sh, init-gradle-wrapper.bat,
> init-gradle-wrapper.ps1, init-gradle-wrapper.ps1, init-gradle-wrapper.sh,
> init-gradle-wrapper.sh, init-gradle-wrapper.sh, init-gradle-wrapper.sh,
> init-gradle-wrapper.sh, init-gradle-wrapper.sh, init-gradle-wrapper.sh,
> init-gradlew-readme-R16.patch, init-gradlew-readme-R17.1.patch,
> init-gradlew-readme-R17.1.patch, init-gradlew-readme.patch,
> init-gradlew-readme.patch, release-16.11-without-gradlew.patch,
> release-16.11-without-gradlew.patch
>
>
> Following the discussion at http://markmail.org/message/nd7grfiyobjkfwae,
> considering LEGAL-288 and based on a lazy consensus on dev ML, we want to
> remove the gradle-wrapper.jar file from the next packaged releases and use
> [~jacopoc]'s related proposition to document how to have Gradle working in
> the main README.md file.
> # Extract the archive file to your local directory.
> # Download gradle-wrapper.jar and place it in the
> OFBiz-root-dir/gradle/wrapper folder.
> I'm not sure if we should recommend a link to download the
> gradle-wrapper.jar. This might change in the future (versions, etc.), so
> indeed maybe simply asking to download is enough, cf
> https://www.google.com/search?q=gradle-wrapper.jar+download=UTF-8
> Also we need to add a point about removing gradle-wrapper.jar in
> https://cwiki.apache.org/confluence/display/OFBIZ/Release+Management+Guide+for+OFBiz
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
[jira] [Commented] (OFBIZ-10145) Remove the Gradle wrapper from our release packages and add a step to our build notes
[ https://issues.apache.org/jira/browse/OFBIZ-10145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16898905#comment-16898905 ] Jacopo Cappellato commented on OFBIZ-10145: --- Hi [~soledad] I have refactored the gradle script (replacing "<<" with "doLast") because "<<" doesn't work with the new versions of Gradle and if a user that downloads OFBiz and downloads Gradle (following the instructions in our README) will get an error message. > Remove the Gradle wrapper from our release packages and add a step to our > build notes > - > > Key: OFBIZ-10145 > URL: https://issues.apache.org/jira/browse/OFBIZ-10145 > Project: OFBiz > Issue Type: Task > Components: Gradle >Affects Versions: 17.12.01, 16.11.06, 18.12.01 >Reporter: Jacques Le Roux >Assignee: Nicolas Malin >Priority: Blocker > Fix For: 17.12.01 > > Attachments: OFBIZ-10145-gradlew.patch, > OFBIZ-10145_wrapper_properties_check.patch, gradlew.bat.patch, > gradlew.bat.patch, gradlew.bat.patch, gradlew.bat.patch, > init-gradle-wrapper-R16.sh, init-gradle-wrapper-trunk-and-18.sh, > init-gradle-wrapper-trunk-and-18.sh, init-gradle-wrapper-trunk-and-18.sh, > init-gradle-wrapper-trunk-and-18.sh, > init-gradle-wrapper-with-backup-and-checksum.sh, init-gradle-wrapper.bat, > init-gradle-wrapper.ps1, init-gradle-wrapper.ps1, init-gradle-wrapper.sh, > init-gradle-wrapper.sh, init-gradle-wrapper.sh, init-gradle-wrapper.sh, > init-gradle-wrapper.sh, init-gradle-wrapper.sh, init-gradle-wrapper.sh, > init-gradlew-readme-R16.patch, init-gradlew-readme-R17.1.patch, > init-gradlew-readme-R17.1.patch, init-gradlew-readme.patch, > init-gradlew-readme.patch, release-16.11-without-gradlew.patch, > release-16.11-without-gradlew.patch > > > Following the discussion at http://markmail.org/message/nd7grfiyobjkfwae, > considering LEGAL-288 and based on a lazy consensus on dev ML, we want to > remove the gradle-wrapper.jar file from the next packaged releases and use > [~jacopoc]'s related proposition to document how to have Gradle working in > the main README.md file. > # Extract the archive file to your local directory. > # Download gradle-wrapper.jar and place it in the > OFBiz-root-dir/gradle/wrapper folder. > I'm not sure if we should recommend a link to download the > gradle-wrapper.jar. This might change in the future (versions, etc.), so > indeed maybe simply asking to download is enough, cf > https://www.google.com/search?q=gradle-wrapper.jar+download=UTF-8 > Also we need to add a point about removing gradle-wrapper.jar in > https://cwiki.apache.org/confluence/display/OFBIZ/Release+Management+Guide+for+OFBiz -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Commented] (OFBIZ-10145) Remove the Gradle wrapper from our release packages and add a step to our build notes
[ https://issues.apache.org/jira/browse/OFBIZ-10145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16898881#comment-16898881 ] Nicolas Malin commented on OFBIZ-10145: --- I saw that my previous script loaded isn't correct and was an old version :( I restart the job : [^init-gradle-wrapper-with-backup-and-checksum.sh] With this last script it's better to see how I ensure that we download an attendee wrapper :) > Remove the Gradle wrapper from our release packages and add a step to our > build notes > - > > Key: OFBIZ-10145 > URL: https://issues.apache.org/jira/browse/OFBIZ-10145 > Project: OFBiz > Issue Type: Task > Components: Gradle >Affects Versions: 17.12.01, 16.11.06, 18.12.01 >Reporter: Jacques Le Roux >Assignee: Nicolas Malin >Priority: Blocker > Fix For: 17.12.01 > > Attachments: OFBIZ-10145-gradlew.patch, > OFBIZ-10145_wrapper_properties_check.patch, gradlew.bat.patch, > gradlew.bat.patch, gradlew.bat.patch, gradlew.bat.patch, > init-gradle-wrapper-R16.sh, init-gradle-wrapper-trunk-and-18.sh, > init-gradle-wrapper-trunk-and-18.sh, init-gradle-wrapper-trunk-and-18.sh, > init-gradle-wrapper-trunk-and-18.sh, > init-gradle-wrapper-with-backup-and-checksum.sh, init-gradle-wrapper.bat, > init-gradle-wrapper.ps1, init-gradle-wrapper.ps1, init-gradle-wrapper.sh, > init-gradle-wrapper.sh, init-gradle-wrapper.sh, init-gradle-wrapper.sh, > init-gradle-wrapper.sh, init-gradle-wrapper.sh, init-gradle-wrapper.sh, > init-gradlew-readme-R16.patch, init-gradlew-readme-R17.1.patch, > init-gradlew-readme-R17.1.patch, init-gradlew-readme.patch, > init-gradlew-readme.patch, release-16.11-without-gradlew.patch, > release-16.11-without-gradlew.patch > > > Following the discussion at http://markmail.org/message/nd7grfiyobjkfwae, > considering LEGAL-288 and based on a lazy consensus on dev ML, we want to > remove the gradle-wrapper.jar file from the next packaged releases and use > [~jacopoc]'s related proposition to document how to have Gradle working in > the main README.md file. > # Extract the archive file to your local directory. > # Download gradle-wrapper.jar and place it in the > OFBiz-root-dir/gradle/wrapper folder. > I'm not sure if we should recommend a link to download the > gradle-wrapper.jar. This might change in the future (versions, etc.), so > indeed maybe simply asking to download is enough, cf > https://www.google.com/search?q=gradle-wrapper.jar+download=UTF-8 > Also we need to add a point about removing gradle-wrapper.jar in > https://cwiki.apache.org/confluence/display/OFBIZ/Release+Management+Guide+for+OFBiz -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Commented] (OFBIZ-10145) Remove the Gradle wrapper from our release packages and add a step to our build notes
[ https://issues.apache.org/jira/browse/OFBIZ-10145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16898678#comment-16898678 ] Nicolas Malin commented on OFBIZ-10145: --- I tested your process [~jacopoc] on the next 16.11 release and it's work fine for me. Just a remark, in your patch replace << by doLast on th build.gradle. Is a relation with the current case or just an quick refactoring ? > Remove the Gradle wrapper from our release packages and add a step to our > build notes > - > > Key: OFBIZ-10145 > URL: https://issues.apache.org/jira/browse/OFBIZ-10145 > Project: OFBiz > Issue Type: Task > Components: Gradle >Affects Versions: 17.12.01, 16.11.06, 18.12.01 >Reporter: Jacques Le Roux >Assignee: Nicolas Malin >Priority: Blocker > Fix For: 17.12.01 > > Attachments: OFBIZ-10145-gradlew.patch, > OFBIZ-10145_wrapper_properties_check.patch, gradlew.bat.patch, > gradlew.bat.patch, gradlew.bat.patch, gradlew.bat.patch, > init-gradle-wrapper-R16.sh, init-gradle-wrapper-trunk-and-18.sh, > init-gradle-wrapper-trunk-and-18.sh, init-gradle-wrapper-trunk-and-18.sh, > init-gradle-wrapper-trunk-and-18.sh, init-gradle-wrapper.bat, > init-gradle-wrapper.ps1, init-gradle-wrapper.ps1, init-gradle-wrapper.sh, > init-gradle-wrapper.sh, init-gradle-wrapper.sh, init-gradle-wrapper.sh, > init-gradle-wrapper.sh, init-gradle-wrapper.sh, init-gradle-wrapper.sh, > init-gradlew-readme-R16.patch, init-gradlew-readme-R17.1.patch, > init-gradlew-readme-R17.1.patch, init-gradlew-readme.patch, > init-gradlew-readme.patch, release-16.11-without-gradlew.patch, > release-16.11-without-gradlew.patch > > > Following the discussion at http://markmail.org/message/nd7grfiyobjkfwae, > considering LEGAL-288 and based on a lazy consensus on dev ML, we want to > remove the gradle-wrapper.jar file from the next packaged releases and use > [~jacopoc]'s related proposition to document how to have Gradle working in > the main README.md file. > # Extract the archive file to your local directory. > # Download gradle-wrapper.jar and place it in the > OFBiz-root-dir/gradle/wrapper folder. > I'm not sure if we should recommend a link to download the > gradle-wrapper.jar. This might change in the future (versions, etc.), so > indeed maybe simply asking to download is enough, cf > https://www.google.com/search?q=gradle-wrapper.jar+download=UTF-8 > Also we need to add a point about removing gradle-wrapper.jar in > https://cwiki.apache.org/confluence/display/OFBIZ/Release+Management+Guide+for+OFBiz -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Commented] (OFBIZ-10145) Remove the Gradle wrapper from our release packages and add a step to our build notes
[
https://issues.apache.org/jira/browse/OFBIZ-10145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16896189#comment-16896189
]
Jacques Le Roux commented on OFBIZ-10145:
-
Hi Jacopo,
[As proposed
Nicolas|https://lists.apache.org/thread.html/54a5fa80f9b0e4186498f76b62a9d6adc9fd23e8a350fa2e1c702f83@%3Cdev.ofbiz.apache.org%3E]:
{quote}I'm in favor to keep an init-gradle-wrapper to help first discovery
without complex preparation and the script maintenance is really easy.
So we can have on documentation advisable part with install gradle from
official source and other part for unfamiliar people with quick start through
init-gradle-wrapper.
{quote}
I suggest we put the last init-gradle-wrapper scripts (both *nix and Windows)
in OFBIz root, to allow and easy UX. Though I believe init-gradle-wrapper.sh
should be simplified as is the init-gradle-wrapper.bat is to catch with the
README.MD content where I'd use
{quote}[Installing Gradle
manually]([https://docs.gradle.org/current/userguide/installation.html])
Alternatively you might run the init-gradle-wrapper script (either *nix or
Windows).
{quote}
I have updated [^release-16.11-without-gradlew.patch] for that.
> Remove the Gradle wrapper from our release packages and add a step to our
> build notes
> -
>
> Key: OFBIZ-10145
> URL: https://issues.apache.org/jira/browse/OFBIZ-10145
> Project: OFBiz
> Issue Type: Task
> Components: Gradle
>Affects Versions: 17.12.01, 16.11.06, 18.12.01
>Reporter: Jacques Le Roux
>Assignee: Nicolas Malin
>Priority: Blocker
> Fix For: 17.12.01
>
> Attachments: OFBIZ-10145-gradlew.patch,
> OFBIZ-10145_wrapper_properties_check.patch, gradlew.bat.patch,
> gradlew.bat.patch, gradlew.bat.patch, gradlew.bat.patch,
> init-gradle-wrapper-R16.sh, init-gradle-wrapper-trunk-and-18.sh,
> init-gradle-wrapper-trunk-and-18.sh, init-gradle-wrapper-trunk-and-18.sh,
> init-gradle-wrapper-trunk-and-18.sh, init-gradle-wrapper.bat,
> init-gradle-wrapper.ps1, init-gradle-wrapper.ps1, init-gradle-wrapper.sh,
> init-gradle-wrapper.sh, init-gradle-wrapper.sh, init-gradle-wrapper.sh,
> init-gradle-wrapper.sh, init-gradle-wrapper.sh, init-gradle-wrapper.sh,
> init-gradlew-readme-R16.patch, init-gradlew-readme-R17.1.patch,
> init-gradlew-readme-R17.1.patch, init-gradlew-readme.patch,
> init-gradlew-readme.patch, release-16.11-without-gradlew.patch,
> release-16.11-without-gradlew.patch
>
>
> Following the discussion at http://markmail.org/message/nd7grfiyobjkfwae,
> considering LEGAL-288 and based on a lazy consensus on dev ML, we want to
> remove the gradle-wrapper.jar file from the next packaged releases and use
> [~jacopoc]'s related proposition to document how to have Gradle working in
> the main README.md file.
> # Extract the archive file to your local directory.
> # Download gradle-wrapper.jar and place it in the
> OFBiz-root-dir/gradle/wrapper folder.
> I'm not sure if we should recommend a link to download the
> gradle-wrapper.jar. This might change in the future (versions, etc.), so
> indeed maybe simply asking to download is enough, cf
> https://www.google.com/search?q=gradle-wrapper.jar+download=UTF-8
> Also we need to add a point about removing gradle-wrapper.jar in
> https://cwiki.apache.org/confluence/display/OFBIZ/Release+Management+Guide+for+OFBiz
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
[jira] [Commented] (OFBIZ-10145) Remove the Gradle wrapper from our release packages and add a step to our build notes
[ https://issues.apache.org/jira/browse/OFBIZ-10145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16895978#comment-16895978 ] Jacopo Cappellato commented on OFBIZ-10145: --- In preparation for the publication of a new release from 16.11 I have prepared a patch that I would like to commit to the release branch 16.11 that provides instructions to the end user for downloading Gradle and preparing the Gradle wrapper. Please test it and let me know if it looks like the right approach (this is essentially what we have discussed in the dev mailing list). In order to test: # remove the following files (these will be removed from the release package): ## gradle/wrapper/gradle-wrapper.jar ## gradle/wrapper/gradle-wrapper.properties ## gradlew ## gradlew.bat # apply the patch release-16.11-without-gradlew.patch # follow the new instructions added to the section "System requirements" of the README file Thank you > Remove the Gradle wrapper from our release packages and add a step to our > build notes > - > > Key: OFBIZ-10145 > URL: https://issues.apache.org/jira/browse/OFBIZ-10145 > Project: OFBiz > Issue Type: Task > Components: Gradle >Affects Versions: 17.12.01, 16.11.06, 18.12.01 >Reporter: Jacques Le Roux >Assignee: Nicolas Malin >Priority: Blocker > Fix For: 17.12.01 > > Attachments: OFBIZ-10145-gradlew.patch, > OFBIZ-10145_wrapper_properties_check.patch, gradlew.bat.patch, > gradlew.bat.patch, gradlew.bat.patch, gradlew.bat.patch, > init-gradle-wrapper-R16.sh, init-gradle-wrapper-trunk-and-18.sh, > init-gradle-wrapper-trunk-and-18.sh, init-gradle-wrapper-trunk-and-18.sh, > init-gradle-wrapper-trunk-and-18.sh, init-gradle-wrapper.bat, > init-gradle-wrapper.ps1, init-gradle-wrapper.ps1, init-gradle-wrapper.sh, > init-gradle-wrapper.sh, init-gradle-wrapper.sh, init-gradle-wrapper.sh, > init-gradle-wrapper.sh, init-gradle-wrapper.sh, init-gradle-wrapper.sh, > init-gradlew-readme-R16.patch, init-gradlew-readme-R17.1.patch, > init-gradlew-readme-R17.1.patch, init-gradlew-readme.patch, > init-gradlew-readme.patch > > > Following the discussion at http://markmail.org/message/nd7grfiyobjkfwae, > considering LEGAL-288 and based on a lazy consensus on dev ML, we want to > remove the gradle-wrapper.jar file from the next packaged releases and use > [~jacopoc]'s related proposition to document how to have Gradle working in > the main README.md file. > # Extract the archive file to your local directory. > # Download gradle-wrapper.jar and place it in the > OFBiz-root-dir/gradle/wrapper folder. > I'm not sure if we should recommend a link to download the > gradle-wrapper.jar. This might change in the future (versions, etc.), so > indeed maybe simply asking to download is enough, cf > https://www.google.com/search?q=gradle-wrapper.jar+download=UTF-8 > Also we need to add a point about removing gradle-wrapper.jar in > https://cwiki.apache.org/confluence/display/OFBIZ/Release+Management+Guide+for+OFBiz -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Commented] (OFBIZ-10145) Remove the Gradle wrapper from our release packages and add a step to our build notes
[ https://issues.apache.org/jira/browse/OFBIZ-10145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16883873#comment-16883873 ] Jacques Le Roux commented on OFBIZ-10145: - Thanks Nicolas, Here are [^init-gradle-wrapper.ps1] [^init-gradle-wrapper.bat]. They are simple scripts for Windows. No fancy stuff, just the bare mininum to check if the wrapper is not yet there, if not download it from ASF repo . The idea is that init-gradle-wrapper.bat should never be changed simply copied in the root of the release package with init-gradle-wrapper.ps1. This init-gradle-wrapper.ps1 contains links to R16.11 in OFBiz repo. For R17, R18, etc. Just need to change that in the URLs. > Remove the Gradle wrapper from our release packages and add a step to our > build notes > - > > Key: OFBIZ-10145 > URL: https://issues.apache.org/jira/browse/OFBIZ-10145 > Project: OFBiz > Issue Type: Task > Components: Gradle >Affects Versions: 17.12.01, 16.11.06, 18.12.01 >Reporter: Jacques Le Roux >Assignee: Nicolas Malin >Priority: Blocker > Fix For: 17.12.01 > > Attachments: OFBIZ-10145-gradlew.patch, > OFBIZ-10145_wrapper_properties_check.patch, gradlew.bat.patch, > gradlew.bat.patch, gradlew.bat.patch, gradlew.bat.patch, > init-gradle-wrapper-R16.sh, init-gradle-wrapper-trunk-and-18.sh, > init-gradle-wrapper-trunk-and-18.sh, init-gradle-wrapper-trunk-and-18.sh, > init-gradle-wrapper-trunk-and-18.sh, init-gradle-wrapper.bat, > init-gradle-wrapper.ps1, init-gradle-wrapper.ps1, init-gradle-wrapper.sh, > init-gradle-wrapper.sh, init-gradle-wrapper.sh, init-gradle-wrapper.sh, > init-gradle-wrapper.sh, init-gradle-wrapper.sh, init-gradle-wrapper.sh, > init-gradlew-readme-R16.patch, init-gradlew-readme-R17.1.patch, > init-gradlew-readme-R17.1.patch, init-gradlew-readme.patch, > init-gradlew-readme.patch > > > Following the discussion at http://markmail.org/message/nd7grfiyobjkfwae, > considering LEGAL-288 and based on a lazy consensus on dev ML, we want to > remove the gradle-wrapper.jar file from the next packaged releases and use > [~jacopoc]'s related proposition to document how to have Gradle working in > the main README.md file. > # Extract the archive file to your local directory. > # Download gradle-wrapper.jar and place it in the > OFBiz-root-dir/gradle/wrapper folder. > I'm not sure if we should recommend a link to download the > gradle-wrapper.jar. This might change in the future (versions, etc.), so > indeed maybe simply asking to download is enough, cf > https://www.google.com/search?q=gradle-wrapper.jar+download=UTF-8 > Also we need to add a point about removing gradle-wrapper.jar in > https://cwiki.apache.org/confluence/display/OFBIZ/Release+Management+Guide+for+OFBiz -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Commented] (OFBIZ-10145) Remove the Gradle wrapper from our release packages and add a step to our build notes
[ https://issues.apache.org/jira/browse/OFBIZ-10145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16883849#comment-16883849 ] Nicolas Malin commented on OFBIZ-10145: --- Hello, I updated the sh script [^init-gradle-wrapper.sh] to manage for released version with : * download from github * if failed, resolved from apache ofbiz svn * realize a checksum to be sure When we released an ofbiz version, we just need to update the RELEASE and SHASUM_GRADLE_WRAPPER variables on the script to work fine > Remove the Gradle wrapper from our release packages and add a step to our > build notes > - > > Key: OFBIZ-10145 > URL: https://issues.apache.org/jira/browse/OFBIZ-10145 > Project: OFBiz > Issue Type: Task > Components: Gradle >Affects Versions: 17.12.01, 16.11.06, 18.12.01 >Reporter: Jacques Le Roux >Assignee: Nicolas Malin >Priority: Blocker > Fix For: 17.12.01 > > Attachments: OFBIZ-10145-gradlew.patch, > OFBIZ-10145_wrapper_properties_check.patch, gradlew.bat.patch, > gradlew.bat.patch, gradlew.bat.patch, gradlew.bat.patch, > init-gradle-wrapper-R16.sh, init-gradle-wrapper-trunk-and-18.sh, > init-gradle-wrapper-trunk-and-18.sh, init-gradle-wrapper-trunk-and-18.sh, > init-gradle-wrapper-trunk-and-18.sh, init-gradle-wrapper.ps1, > init-gradle-wrapper.sh, init-gradle-wrapper.sh, init-gradle-wrapper.sh, > init-gradle-wrapper.sh, init-gradle-wrapper.sh, init-gradle-wrapper.sh, > init-gradle-wrapper.sh, init-gradlew-readme-R16.patch, > init-gradlew-readme-R17.1.patch, init-gradlew-readme-R17.1.patch, > init-gradlew-readme.patch, init-gradlew-readme.patch > > > Following the discussion at http://markmail.org/message/nd7grfiyobjkfwae, > considering LEGAL-288 and based on a lazy consensus on dev ML, we want to > remove the gradle-wrapper.jar file from the next packaged releases and use > [~jacopoc]'s related proposition to document how to have Gradle working in > the main README.md file. > # Extract the archive file to your local directory. > # Download gradle-wrapper.jar and place it in the > OFBiz-root-dir/gradle/wrapper folder. > I'm not sure if we should recommend a link to download the > gradle-wrapper.jar. This might change in the future (versions, etc.), so > indeed maybe simply asking to download is enough, cf > https://www.google.com/search?q=gradle-wrapper.jar+download=UTF-8 > Also we need to add a point about removing gradle-wrapper.jar in > https://cwiki.apache.org/confluence/display/OFBIZ/Release+Management+Guide+for+OFBiz -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Commented] (OFBIZ-10145) Remove the Gradle wrapper from our release packages and add a step to our build notes
[ https://issues.apache.org/jira/browse/OFBIZ-10145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16880343#comment-16880343 ] Jacques Le Roux commented on OFBIZ-10145: - I'll now tackle the documentation changes... > Remove the Gradle wrapper from our release packages and add a step to our > build notes > - > > Key: OFBIZ-10145 > URL: https://issues.apache.org/jira/browse/OFBIZ-10145 > Project: OFBiz > Issue Type: Task > Components: Gradle >Affects Versions: 17.12.01, 16.11.06, 18.12.01 >Reporter: Jacques Le Roux >Assignee: Nicolas Malin >Priority: Blocker > Fix For: 17.12.01 > > Attachments: OFBIZ-10145-gradlew.patch, > OFBIZ-10145_wrapper_properties_check.patch, gradlew.bat.patch, > gradlew.bat.patch, gradlew.bat.patch, gradlew.bat.patch, > init-gradle-wrapper-R16.sh, init-gradle-wrapper-trunk-and-18.sh, > init-gradle-wrapper-trunk-and-18.sh, init-gradle-wrapper-trunk-and-18.sh, > init-gradle-wrapper-trunk-and-18.sh, init-gradle-wrapper.ps1, > init-gradle-wrapper.sh, init-gradle-wrapper.sh, init-gradle-wrapper.sh, > init-gradle-wrapper.sh, init-gradle-wrapper.sh, init-gradle-wrapper.sh, > init-gradlew-readme-R16.patch, init-gradlew-readme-R17.1.patch, > init-gradlew-readme-R17.1.patch, init-gradlew-readme.patch, > init-gradlew-readme.patch > > > Following the discussion at http://markmail.org/message/nd7grfiyobjkfwae, > considering LEGAL-288 and based on a lazy consensus on dev ML, we want to > remove the gradle-wrapper.jar file from the next packaged releases and use > [~jacopoc]'s related proposition to document how to have Gradle working in > the main README.md file. > # Extract the archive file to your local directory. > # Download gradle-wrapper.jar and place it in the > OFBiz-root-dir/gradle/wrapper folder. > I'm not sure if we should recommend a link to download the > gradle-wrapper.jar. This might change in the future (versions, etc.), so > indeed maybe simply asking to download is enough, cf > https://www.google.com/search?q=gradle-wrapper.jar+download=UTF-8 > Also we need to add a point about removing gradle-wrapper.jar in > https://cwiki.apache.org/confluence/display/OFBIZ/Release+Management+Guide+for+OFBiz -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-10145) Remove the Gradle wrapper from our release packages and add a step to our build notes
[ https://issues.apache.org/jira/browse/OFBIZ-10145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16880339#comment-16880339 ] Jacques Le Roux commented on OFBIZ-10145: - At revision: 1862745 I removed all changes done for OFBIZ-10145 so far. The wrapper stays in branches and trunk. Now all should be handled during the Release Management phase. > Remove the Gradle wrapper from our release packages and add a step to our > build notes > - > > Key: OFBIZ-10145 > URL: https://issues.apache.org/jira/browse/OFBIZ-10145 > Project: OFBiz > Issue Type: Task > Components: Gradle >Affects Versions: 17.12.01, 16.11.06, 18.12.01 >Reporter: Jacques Le Roux >Assignee: Nicolas Malin >Priority: Blocker > Fix For: 17.12.01 > > Attachments: OFBIZ-10145-gradlew.patch, > OFBIZ-10145_wrapper_properties_check.patch, gradlew.bat.patch, > gradlew.bat.patch, gradlew.bat.patch, gradlew.bat.patch, > init-gradle-wrapper-R16.sh, init-gradle-wrapper-trunk-and-18.sh, > init-gradle-wrapper-trunk-and-18.sh, init-gradle-wrapper-trunk-and-18.sh, > init-gradle-wrapper-trunk-and-18.sh, init-gradle-wrapper.ps1, > init-gradle-wrapper.sh, init-gradle-wrapper.sh, init-gradle-wrapper.sh, > init-gradle-wrapper.sh, init-gradle-wrapper.sh, init-gradle-wrapper.sh, > init-gradlew-readme-R16.patch, init-gradlew-readme-R17.1.patch, > init-gradlew-readme-R17.1.patch, init-gradlew-readme.patch, > init-gradlew-readme.patch > > > Following the discussion at http://markmail.org/message/nd7grfiyobjkfwae, > considering LEGAL-288 and based on a lazy consensus on dev ML, we want to > remove the gradle-wrapper.jar file from the next packaged releases and use > [~jacopoc]'s related proposition to document how to have Gradle working in > the main README.md file. > # Extract the archive file to your local directory. > # Download gradle-wrapper.jar and place it in the > OFBiz-root-dir/gradle/wrapper folder. > I'm not sure if we should recommend a link to download the > gradle-wrapper.jar. This might change in the future (versions, etc.), so > indeed maybe simply asking to download is enough, cf > https://www.google.com/search?q=gradle-wrapper.jar+download=UTF-8 > Also we need to add a point about removing gradle-wrapper.jar in > https://cwiki.apache.org/confluence/display/OFBIZ/Release+Management+Guide+for+OFBiz -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-10145) Remove the Gradle wrapper from our release packages and add a step to our build notes
[ https://issues.apache.org/jira/browse/OFBIZ-10145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16876015#comment-16876015 ] Jacques Le Roux commented on OFBIZ-10145: - Nicolas and I made some (minor in size) commits but it seems we are finally going to follow the proposal in the description. See this thread for details: https://s.apache.org/2Wla > Remove the Gradle wrapper from our release packages and add a step to our > build notes > - > > Key: OFBIZ-10145 > URL: https://issues.apache.org/jira/browse/OFBIZ-10145 > Project: OFBiz > Issue Type: Task > Components: Gradle >Affects Versions: 17.12.01, 16.11.06, 18.12.01 >Reporter: Jacques Le Roux >Assignee: Nicolas Malin >Priority: Blocker > Fix For: 17.12.01 > > Attachments: OFBIZ-10145-gradlew.patch, > OFBIZ-10145_wrapper_properties_check.patch, gradlew.bat.patch, > gradlew.bat.patch, gradlew.bat.patch, gradlew.bat.patch, > init-gradle-wrapper-R16.sh, init-gradle-wrapper-trunk-and-18.sh, > init-gradle-wrapper-trunk-and-18.sh, init-gradle-wrapper-trunk-and-18.sh, > init-gradle-wrapper-trunk-and-18.sh, init-gradle-wrapper.ps1, > init-gradle-wrapper.sh, init-gradle-wrapper.sh, init-gradle-wrapper.sh, > init-gradle-wrapper.sh, init-gradle-wrapper.sh, init-gradle-wrapper.sh, > init-gradlew-readme-R16.patch, init-gradlew-readme-R17.1.patch, > init-gradlew-readme-R17.1.patch, init-gradlew-readme.patch, > init-gradlew-readme.patch > > > Following the discussion at http://markmail.org/message/nd7grfiyobjkfwae, > considering LEGAL-288 and based on a lazy consensus on dev ML, we want to > remove the gradle-wrapper.jar file from the next packaged releases and use > [~jacopoc]'s related proposition to document how to have Gradle working in > the main README.md file. > # Extract the archive file to your local directory. > # Download gradle-wrapper.jar and place it in the > OFBiz-root-dir/gradle/wrapper folder. > I'm not sure if we should recommend a link to download the > gradle-wrapper.jar. This might change in the future (versions, etc.), so > indeed maybe simply asking to download is enough, cf > https://www.google.com/search?q=gradle-wrapper.jar+download=UTF-8 > Also we need to add a point about removing gradle-wrapper.jar in > https://cwiki.apache.org/confluence/display/OFBIZ/Release+Management+Guide+for+OFBiz -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-10145) Remove the Gradle wrapper from our release packages and add a step to our build notes
[ https://issues.apache.org/jira/browse/OFBIZ-10145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16871164#comment-16871164 ] Jacques Le Roux commented on OFBIZ-10145: - [^gradlew.bat.patch] is the last and simplest solution corresponding to my last proposition. It answers to Swapnil's concern about Gradle updates on trunk. I'll wait a community agreement before writing a wiki page explaining what to do when updating Gradle. If we agree I'll also update the [release management page|https://cwiki.apache.org/confluence/display/OFBIZ/Release+Management+Guide+for+OFBiz]. We need to create entries in https://svn.apache.org/repos/asf/ofbiz/tools/Buildbot/Gradle/Wrapper for each new release branch. > Remove the Gradle wrapper from our release packages and add a step to our > build notes > - > > Key: OFBIZ-10145 > URL: https://issues.apache.org/jira/browse/OFBIZ-10145 > Project: OFBiz > Issue Type: Task > Components: Gradle >Affects Versions: 17.12.01, 16.11.06, 18.12.01 >Reporter: Jacques Le Roux >Assignee: Nicolas Malin >Priority: Blocker > Fix For: 17.12.01 > > Attachments: OFBIZ-10145-gradlew.patch, > OFBIZ-10145_wrapper_properties_check.patch, gradlew.bat.patch, > gradlew.bat.patch, gradlew.bat.patch, init-gradle-wrapper-R16.sh, > init-gradle-wrapper-trunk-and-18.sh, init-gradle-wrapper-trunk-and-18.sh, > init-gradle-wrapper-trunk-and-18.sh, init-gradle-wrapper-trunk-and-18.sh, > init-gradle-wrapper.ps1, init-gradle-wrapper.sh, init-gradle-wrapper.sh, > init-gradle-wrapper.sh, init-gradle-wrapper.sh, init-gradle-wrapper.sh, > init-gradle-wrapper.sh, init-gradlew-readme-R16.patch, > init-gradlew-readme-R17.1.patch, init-gradlew-readme-R17.1.patch, > init-gradlew-readme.patch, init-gradlew-readme.patch > > > Following the discussion at http://markmail.org/message/nd7grfiyobjkfwae, > considering LEGAL-288 and based on a lazy consensus on dev ML, we want to > remove the gradle-wrapper.jar file from the next packaged releases and use > [~jacopoc]'s related proposition to document how to have Gradle working in > the main README.md file. > # Extract the archive file to your local directory. > # Download gradle-wrapper.jar and place it in the > OFBiz-root-dir/gradle/wrapper folder. > I'm not sure if we should recommend a link to download the > gradle-wrapper.jar. This might change in the future (versions, etc.), so > indeed maybe simply asking to download is enough, cf > https://www.google.com/search?q=gradle-wrapper.jar+download=UTF-8 > Also we need to add a point about removing gradle-wrapper.jar in > https://cwiki.apache.org/confluence/display/OFBIZ/Release+Management+Guide+for+OFBiz -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-10145) Remove the Gradle wrapper from our release packages and add a step to our build notes
[
https://issues.apache.org/jira/browse/OFBIZ-10145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16870277#comment-16870277
]
Swapnil M Mane commented on OFBIZ-10145:
Thanks [~jacques.le.roux] for your comments, all the points makes sense to me :)
As you already mentioned,
{quote}the user must have an Internet connexion
{quote}
This is only the point we need to think on, let's see what are the thoughts our
fellow team members.
Thanks!
> Remove the Gradle wrapper from our release packages and add a step to our
> build notes
> -
>
> Key: OFBIZ-10145
> URL: https://issues.apache.org/jira/browse/OFBIZ-10145
> Project: OFBiz
> Issue Type: Task
> Components: Gradle
>Affects Versions: 17.12.01, 16.11.06, 18.12.01
>Reporter: Jacques Le Roux
>Assignee: Nicolas Malin
>Priority: Blocker
> Fix For: 17.12.01
>
> Attachments: OFBIZ-10145-gradlew.patch,
> OFBIZ-10145_wrapper_properties_check.patch, gradlew.bat.patch,
> gradlew.bat.patch, init-gradle-wrapper-R16.sh,
> init-gradle-wrapper-trunk-and-18.sh, init-gradle-wrapper-trunk-and-18.sh,
> init-gradle-wrapper-trunk-and-18.sh, init-gradle-wrapper-trunk-and-18.sh,
> init-gradle-wrapper.ps1, init-gradle-wrapper.sh, init-gradle-wrapper.sh,
> init-gradle-wrapper.sh, init-gradle-wrapper.sh, init-gradle-wrapper.sh,
> init-gradle-wrapper.sh, init-gradlew-readme-R16.patch,
> init-gradlew-readme-R17.1.patch, init-gradlew-readme-R17.1.patch,
> init-gradlew-readme.patch, init-gradlew-readme.patch
>
>
> Following the discussion at http://markmail.org/message/nd7grfiyobjkfwae,
> considering LEGAL-288 and based on a lazy consensus on dev ML, we want to
> remove the gradle-wrapper.jar file from the next packaged releases and use
> [~jacopoc]'s related proposition to document how to have Gradle working in
> the main README.md file.
> # Extract the archive file to your local directory.
> # Download gradle-wrapper.jar and place it in the
> OFBiz-root-dir/gradle/wrapper folder.
> I'm not sure if we should recommend a link to download the
> gradle-wrapper.jar. This might change in the future (versions, etc.), so
> indeed maybe simply asking to download is enough, cf
> https://www.google.com/search?q=gradle-wrapper.jar+download=UTF-8
> Also we need to add a point about removing gradle-wrapper.jar in
> https://cwiki.apache.org/confluence/display/OFBIZ/Release+Management+Guide+for+OFBiz
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (OFBIZ-10145) Remove the Gradle wrapper from our release packages and add a step to our build notes
[ https://issues.apache.org/jira/browse/OFBIZ-10145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16870080#comment-16870080 ] Jacques Le Roux commented on OFBIZ-10145: - Hi Swapnil, I thought about it again. Actually what are we doing when we upgrade Gradle in trunk? We update the gradlew scripts and the wrapper files, eg see [r1776532|http://svn.apache.org/viewvc?view=revision=1776532] and [r1848062|http://svn.apache.org/viewvc?view=revision=1848062]. With the Windows way that's all we need to do. Just update gradlew.bat in the trunk and the wrapper files in tools. A change must though be done in current gradlew.bat: the wrapper must always be copied over in trunk from the tools, somehow like in Buildbot. Not a big deal, we speak about 50 Kb. Like before, to use the latest version of Gradle, the user must SVN update his/her working copy. There is only one drawback with this strategy, the user must have an Internet connexion. At some point it needs it: to SVN update the trunk. But later the connexion may be missing. A smal change in init-gradle-wrapper.ps1, [too catch the connexion error|https://stackoverflow.com/questions/19122378/powershell-web-request-without-throwing-exception-on-4xx-5xx] is enough. If the user did not run gradlew at the same moment than SVN updating, s/he must wait the next time a connexion is available to get the new Gradle version. In this case, I don't expect much issues with the possible but hopefully rare discrepancy between gradlew.bat and the wrapper. What do you think? > Remove the Gradle wrapper from our release packages and add a step to our > build notes > - > > Key: OFBIZ-10145 > URL: https://issues.apache.org/jira/browse/OFBIZ-10145 > Project: OFBiz > Issue Type: Task > Components: Gradle >Affects Versions: 17.12.01, 16.11.06, 18.12.01 >Reporter: Jacques Le Roux >Assignee: Nicolas Malin >Priority: Blocker > Fix For: 17.12.01 > > Attachments: OFBIZ-10145-gradlew.patch, > OFBIZ-10145_wrapper_properties_check.patch, gradlew.bat.patch, > gradlew.bat.patch, init-gradle-wrapper-R16.sh, > init-gradle-wrapper-trunk-and-18.sh, init-gradle-wrapper-trunk-and-18.sh, > init-gradle-wrapper-trunk-and-18.sh, init-gradle-wrapper-trunk-and-18.sh, > init-gradle-wrapper.ps1, init-gradle-wrapper.sh, init-gradle-wrapper.sh, > init-gradle-wrapper.sh, init-gradle-wrapper.sh, init-gradle-wrapper.sh, > init-gradle-wrapper.sh, init-gradlew-readme-R16.patch, > init-gradlew-readme-R17.1.patch, init-gradlew-readme-R17.1.patch, > init-gradlew-readme.patch, init-gradlew-readme.patch > > > Following the discussion at http://markmail.org/message/nd7grfiyobjkfwae, > considering LEGAL-288 and based on a lazy consensus on dev ML, we want to > remove the gradle-wrapper.jar file from the next packaged releases and use > [~jacopoc]'s related proposition to document how to have Gradle working in > the main README.md file. > # Extract the archive file to your local directory. > # Download gradle-wrapper.jar and place it in the > OFBiz-root-dir/gradle/wrapper folder. > I'm not sure if we should recommend a link to download the > gradle-wrapper.jar. This might change in the future (versions, etc.), so > indeed maybe simply asking to download is enough, cf > https://www.google.com/search?q=gradle-wrapper.jar+download=UTF-8 > Also we need to add a point about removing gradle-wrapper.jar in > https://cwiki.apache.org/confluence/display/OFBIZ/Release+Management+Guide+for+OFBiz -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-10145) Remove the Gradle wrapper from our release packages and add a step to our build notes
[
https://issues.apache.org/jira/browse/OFBIZ-10145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16869899#comment-16869899
]
Jacques Le Roux commented on OFBIZ-10145:
-
Hi Swapnil,
bq. we should also have existance check for gradle-wrapper.properties file.
I propose another change, please see below.
You are right about the Wrapper version for already installed trunk. Running
something like {{gradlew wrapper --gradle-version=5.0 --distribution-type=bin}}
(w/ --gradle-version changed when needed) in gradlew.bat after loading the
wrapper should be enough (ie before {{@rem Execute Gradle}}.
It took 35 sec on my machine the 1st time, then it's only 1 sec. Of course when
the version change that's another story, but it's then "expected". Something
similar could be done for *nix version, I guess. It applies to Buildbot as well
(w/o changing [ofbiz.conf
file|https://svn.apache.org/repos/infra/infrastructure/buildbot/aegis/buildmaster/master1/projects/ofbiz.conf]).
Unfortunately, I stumbled upon this [Gradle
bug|https://github.com/gradle/gradle/issues/7883] (ouch!) and I'll see later
how it's possible to do better.
Here is the current state: [^gradlew.bat.patch]
About gradle-wrapper.properties check. I changed the check to verify if the
gradle\wrapper directory exists, simpler ;) So we should remove this directory.
That's actually what I expected when I wrote {{md %APP_HOME%\gradle\wrapper}}
now replaced by {{md WRAPPER_CLASSPATH}}
> Remove the Gradle wrapper from our release packages and add a step to our
> build notes
> -
>
> Key: OFBIZ-10145
> URL: https://issues.apache.org/jira/browse/OFBIZ-10145
> Project: OFBiz
> Issue Type: Task
> Components: Gradle
>Affects Versions: 17.12.01, 16.11.06, 18.12.01
>Reporter: Jacques Le Roux
>Assignee: Nicolas Malin
>Priority: Blocker
> Fix For: 17.12.01
>
> Attachments: OFBIZ-10145-gradlew.patch,
> OFBIZ-10145_wrapper_properties_check.patch, gradlew.bat.patch,
> gradlew.bat.patch, init-gradle-wrapper-R16.sh,
> init-gradle-wrapper-trunk-and-18.sh, init-gradle-wrapper-trunk-and-18.sh,
> init-gradle-wrapper-trunk-and-18.sh, init-gradle-wrapper-trunk-and-18.sh,
> init-gradle-wrapper.ps1, init-gradle-wrapper.sh, init-gradle-wrapper.sh,
> init-gradle-wrapper.sh, init-gradle-wrapper.sh, init-gradle-wrapper.sh,
> init-gradle-wrapper.sh, init-gradlew-readme-R16.patch,
> init-gradlew-readme-R17.1.patch, init-gradlew-readme-R17.1.patch,
> init-gradlew-readme.patch, init-gradlew-readme.patch
>
>
> Following the discussion at http://markmail.org/message/nd7grfiyobjkfwae,
> considering LEGAL-288 and based on a lazy consensus on dev ML, we want to
> remove the gradle-wrapper.jar file from the next packaged releases and use
> [~jacopoc]'s related proposition to document how to have Gradle working in
> the main README.md file.
> # Extract the archive file to your local directory.
> # Download gradle-wrapper.jar and place it in the
> OFBiz-root-dir/gradle/wrapper folder.
> I'm not sure if we should recommend a link to download the
> gradle-wrapper.jar. This might change in the future (versions, etc.), so
> indeed maybe simply asking to download is enough, cf
> https://www.google.com/search?q=gradle-wrapper.jar+download=UTF-8
> Also we need to add a point about removing gradle-wrapper.jar in
> https://cwiki.apache.org/confluence/display/OFBIZ/Release+Management+Guide+for+OFBiz
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (OFBIZ-10145) Remove the Gradle wrapper from our release packages and add a step to our build notes
[ https://issues.apache.org/jira/browse/OFBIZ-10145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16869382#comment-16869382 ] Swapnil M Mane commented on OFBIZ-10145: Thanks so much [~jacques.le.roux] and [~soledad], this work is going in great direction :) I think, we should also have existance check for gradle-wrapper.properties file. Here is the patch [^OFBIZ-10145_wrapper_properties_check.patch] for same, please have a look. Thanks! > Remove the Gradle wrapper from our release packages and add a step to our > build notes > - > > Key: OFBIZ-10145 > URL: https://issues.apache.org/jira/browse/OFBIZ-10145 > Project: OFBiz > Issue Type: Task > Components: Gradle >Affects Versions: 17.12.01, 16.11.06, 18.12.01 >Reporter: Jacques Le Roux >Assignee: Nicolas Malin >Priority: Blocker > Fix For: 17.12.01 > > Attachments: OFBIZ-10145-gradlew.patch, > OFBIZ-10145_wrapper_properties_check.patch, gradlew.bat.patch, > init-gradle-wrapper-R16.sh, init-gradle-wrapper-trunk-and-18.sh, > init-gradle-wrapper-trunk-and-18.sh, init-gradle-wrapper-trunk-and-18.sh, > init-gradle-wrapper-trunk-and-18.sh, init-gradle-wrapper.ps1, > init-gradle-wrapper.sh, init-gradle-wrapper.sh, init-gradle-wrapper.sh, > init-gradle-wrapper.sh, init-gradle-wrapper.sh, init-gradle-wrapper.sh, > init-gradlew-readme-R16.patch, init-gradlew-readme-R17.1.patch, > init-gradlew-readme-R17.1.patch, init-gradlew-readme.patch, > init-gradlew-readme.patch > > > Following the discussion at http://markmail.org/message/nd7grfiyobjkfwae, > considering LEGAL-288 and based on a lazy consensus on dev ML, we want to > remove the gradle-wrapper.jar file from the next packaged releases and use > [~jacopoc]'s related proposition to document how to have Gradle working in > the main README.md file. > # Extract the archive file to your local directory. > # Download gradle-wrapper.jar and place it in the > OFBiz-root-dir/gradle/wrapper folder. > I'm not sure if we should recommend a link to download the > gradle-wrapper.jar. This might change in the future (versions, etc.), so > indeed maybe simply asking to download is enough, cf > https://www.google.com/search?q=gradle-wrapper.jar+download=UTF-8 > Also we need to add a point about removing gradle-wrapper.jar in > https://cwiki.apache.org/confluence/display/OFBIZ/Release+Management+Guide+for+OFBiz -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-10145) Remove the Gradle wrapper from our release packages and add a step to our build notes
[ https://issues.apache.org/jira/browse/OFBIZ-10145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16869338#comment-16869338 ] Nicolas Malin commented on OFBIZ-10145: --- Ok, I commit the first version on trunk at 1861766 > Remove the Gradle wrapper from our release packages and add a step to our > build notes > - > > Key: OFBIZ-10145 > URL: https://issues.apache.org/jira/browse/OFBIZ-10145 > Project: OFBiz > Issue Type: Task > Components: Gradle >Affects Versions: 17.12.01, 16.11.06, 18.12.01 >Reporter: Jacques Le Roux >Assignee: Nicolas Malin >Priority: Blocker > Fix For: 17.12.01 > > Attachments: OFBIZ-10145-gradlew.patch, gradlew.bat.patch, > init-gradle-wrapper-R16.sh, init-gradle-wrapper-trunk-and-18.sh, > init-gradle-wrapper-trunk-and-18.sh, init-gradle-wrapper-trunk-and-18.sh, > init-gradle-wrapper-trunk-and-18.sh, init-gradle-wrapper.ps1, > init-gradle-wrapper.sh, init-gradle-wrapper.sh, init-gradle-wrapper.sh, > init-gradle-wrapper.sh, init-gradle-wrapper.sh, init-gradle-wrapper.sh, > init-gradlew-readme-R16.patch, init-gradlew-readme-R17.1.patch, > init-gradlew-readme-R17.1.patch, init-gradlew-readme.patch, > init-gradlew-readme.patch > > > Following the discussion at http://markmail.org/message/nd7grfiyobjkfwae, > considering LEGAL-288 and based on a lazy consensus on dev ML, we want to > remove the gradle-wrapper.jar file from the next packaged releases and use > [~jacopoc]'s related proposition to document how to have Gradle working in > the main README.md file. > # Extract the archive file to your local directory. > # Download gradle-wrapper.jar and place it in the > OFBiz-root-dir/gradle/wrapper folder. > I'm not sure if we should recommend a link to download the > gradle-wrapper.jar. This might change in the future (versions, etc.), so > indeed maybe simply asking to download is enough, cf > https://www.google.com/search?q=gradle-wrapper.jar+download=UTF-8 > Also we need to add a point about removing gradle-wrapper.jar in > https://cwiki.apache.org/confluence/display/OFBIZ/Release+Management+Guide+for+OFBiz -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-10145) Remove the Gradle wrapper from our release packages and add a step to our build notes
[ https://issues.apache.org/jira/browse/OFBIZ-10145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16869307#comment-16869307 ] Jacques Le Roux commented on OFBIZ-10145: - Hi Nicolas, Yes that sounds good to me. There are 3 aspects to it: branches, demos and Buildbot. # Branches, we can indeed discuss on dev ML as you suggest. For Windows I just have to create dedicated init-gradle-wrapper.ps1 scripts by branches # Demos would follow since it would all depends on gradlew and added init-gradle-wrapper scripts # Buildbot uses tools as wrapper repo, it's already OK and works for 2 weeks, nothing needs to be changed > Remove the Gradle wrapper from our release packages and add a step to our > build notes > - > > Key: OFBIZ-10145 > URL: https://issues.apache.org/jira/browse/OFBIZ-10145 > Project: OFBiz > Issue Type: Task > Components: Gradle >Affects Versions: 17.12.01, 16.11.06, 18.12.01 >Reporter: Jacques Le Roux >Assignee: Nicolas Malin >Priority: Blocker > Fix For: 17.12.01 > > Attachments: OFBIZ-10145-gradlew.patch, gradlew.bat.patch, > init-gradle-wrapper-R16.sh, init-gradle-wrapper-trunk-and-18.sh, > init-gradle-wrapper-trunk-and-18.sh, init-gradle-wrapper-trunk-and-18.sh, > init-gradle-wrapper-trunk-and-18.sh, init-gradle-wrapper.ps1, > init-gradle-wrapper.sh, init-gradle-wrapper.sh, init-gradle-wrapper.sh, > init-gradle-wrapper.sh, init-gradle-wrapper.sh, init-gradle-wrapper.sh, > init-gradlew-readme-R16.patch, init-gradlew-readme-R17.1.patch, > init-gradlew-readme-R17.1.patch, init-gradlew-readme.patch, > init-gradlew-readme.patch > > > Following the discussion at http://markmail.org/message/nd7grfiyobjkfwae, > considering LEGAL-288 and based on a lazy consensus on dev ML, we want to > remove the gradle-wrapper.jar file from the next packaged releases and use > [~jacopoc]'s related proposition to document how to have Gradle working in > the main README.md file. > # Extract the archive file to your local directory. > # Download gradle-wrapper.jar and place it in the > OFBiz-root-dir/gradle/wrapper folder. > I'm not sure if we should recommend a link to download the > gradle-wrapper.jar. This might change in the future (versions, etc.), so > indeed maybe simply asking to download is enough, cf > https://www.google.com/search?q=gradle-wrapper.jar+download=UTF-8 > Also we need to add a point about removing gradle-wrapper.jar in > https://cwiki.apache.org/confluence/display/OFBIZ/Release+Management+Guide+for+OFBiz -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-10145) Remove the Gradle wrapper from our release packages and add a step to our build notes
[ https://issues.apache.org/jira/browse/OFBIZ-10145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16869279#comment-16869279 ] Nicolas Malin commented on OFBIZ-10145: --- Super Jacques, To move forward, I propose to commit on trunk only with your solution and open a discussion on the rule to resolve the gradle-wrapper.jar As it will be present on trunk it would be really easy to test and have an opinion. After the discussion, I perform on release branches > Remove the Gradle wrapper from our release packages and add a step to our > build notes > - > > Key: OFBIZ-10145 > URL: https://issues.apache.org/jira/browse/OFBIZ-10145 > Project: OFBiz > Issue Type: Task > Components: Gradle >Affects Versions: 17.12.01, 16.11.06, 18.12.01 >Reporter: Jacques Le Roux >Assignee: Nicolas Malin >Priority: Blocker > Fix For: 17.12.01 > > Attachments: OFBIZ-10145-gradlew.patch, gradlew.bat.patch, > init-gradle-wrapper-R16.sh, init-gradle-wrapper-trunk-and-18.sh, > init-gradle-wrapper-trunk-and-18.sh, init-gradle-wrapper-trunk-and-18.sh, > init-gradle-wrapper-trunk-and-18.sh, init-gradle-wrapper.ps1, > init-gradle-wrapper.sh, init-gradle-wrapper.sh, init-gradle-wrapper.sh, > init-gradle-wrapper.sh, init-gradle-wrapper.sh, init-gradle-wrapper.sh, > init-gradlew-readme-R16.patch, init-gradlew-readme-R17.1.patch, > init-gradlew-readme-R17.1.patch, init-gradlew-readme.patch, > init-gradlew-readme.patch > > > Following the discussion at http://markmail.org/message/nd7grfiyobjkfwae, > considering LEGAL-288 and based on a lazy consensus on dev ML, we want to > remove the gradle-wrapper.jar file from the next packaged releases and use > [~jacopoc]'s related proposition to document how to have Gradle working in > the main README.md file. > # Extract the archive file to your local directory. > # Download gradle-wrapper.jar and place it in the > OFBiz-root-dir/gradle/wrapper folder. > I'm not sure if we should recommend a link to download the > gradle-wrapper.jar. This might change in the future (versions, etc.), so > indeed maybe simply asking to download is enough, cf > https://www.google.com/search?q=gradle-wrapper.jar+download=UTF-8 > Also we need to add a point about removing gradle-wrapper.jar in > https://cwiki.apache.org/confluence/display/OFBIZ/Release+Management+Guide+for+OFBiz -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-10145) Remove the Gradle wrapper from our release packages and add a step to our build notes
[ https://issues.apache.org/jira/browse/OFBIZ-10145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16868307#comment-16868307 ] Jacques Le Roux commented on OFBIZ-10145: - With [^gradlew.bat.patch] there is now a new to handle a missing Gradle w/o the user noticing. So for Windows we don't need to change the documentation. I propose to do the same for *nix, et voilà. > Remove the Gradle wrapper from our release packages and add a step to our > build notes > - > > Key: OFBIZ-10145 > URL: https://issues.apache.org/jira/browse/OFBIZ-10145 > Project: OFBiz > Issue Type: Task > Components: Gradle >Affects Versions: 17.12.01, 16.11.06, 18.12.01 >Reporter: Jacques Le Roux >Assignee: Nicolas Malin >Priority: Blocker > Fix For: 17.12.01 > > Attachments: OFBIZ-10145-gradlew.patch, gradlew.bat.patch, > init-gradle-wrapper-R16.sh, init-gradle-wrapper-trunk-and-18.sh, > init-gradle-wrapper-trunk-and-18.sh, init-gradle-wrapper-trunk-and-18.sh, > init-gradle-wrapper-trunk-and-18.sh, init-gradle-wrapper.ps1, > init-gradle-wrapper.sh, init-gradle-wrapper.sh, init-gradle-wrapper.sh, > init-gradle-wrapper.sh, init-gradle-wrapper.sh, init-gradle-wrapper.sh, > init-gradlew-readme-R16.patch, init-gradlew-readme-R17.1.patch, > init-gradlew-readme-R17.1.patch, init-gradlew-readme.patch, > init-gradlew-readme.patch > > > Following the discussion at http://markmail.org/message/nd7grfiyobjkfwae, > considering LEGAL-288 and based on a lazy consensus on dev ML, we want to > remove the gradle-wrapper.jar file from the next packaged releases and use > [~jacopoc]'s related proposition to document how to have Gradle working in > the main README.md file. > # Extract the archive file to your local directory. > # Download gradle-wrapper.jar and place it in the > OFBiz-root-dir/gradle/wrapper folder. > I'm not sure if we should recommend a link to download the > gradle-wrapper.jar. This might change in the future (versions, etc.), so > indeed maybe simply asking to download is enough, cf > https://www.google.com/search?q=gradle-wrapper.jar+download=UTF-8 > Also we need to add a point about removing gradle-wrapper.jar in > https://cwiki.apache.org/confluence/display/OFBIZ/Release+Management+Guide+for+OFBiz -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-10145) Remove the Gradle wrapper from our release packages and add a step to our build notes
[ https://issues.apache.org/jira/browse/OFBIZ-10145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16867630#comment-16867630 ] Jacques Le Roux commented on OFBIZ-10145: - Nicolas, I was looking at what to do for Windows and I still think my proposition is good. Why? The argument you had, and I agreed about: bq. this introduce a hard rule for future to keep it during all time that a release version would be present on support. but actually we need to do that for Buildbot at least, as shown above, so our users can also use it. I also like the idea of (quoting myself): bq. call our init-gradle-wrapper scripts from both gradlew and gradlew.bat script if the Wrapper is not present. Then no need to ask our users to run the init-gradle-wrapper by hand. Using the starting script (gradlew or gradlew.bat) [is] enough. As said Swapnil about that: bq. In this way, life our users will became easy, no action will be required from their side. Don't you think we can should that? Anyway I let the community decide for this aspect. I'll use it to handle the WIndows side. I'll soon provide the patches for all branches. > Remove the Gradle wrapper from our release packages and add a step to our > build notes > - > > Key: OFBIZ-10145 > URL: https://issues.apache.org/jira/browse/OFBIZ-10145 > Project: OFBiz > Issue Type: Task > Components: Gradle >Affects Versions: 17.12.01, 16.11.06, 18.12.01 >Reporter: Jacques Le Roux >Assignee: Nicolas Malin >Priority: Blocker > Fix For: 17.12.01 > > Attachments: OFBIZ-10145-gradlew.patch, init-gradle-wrapper-R16.sh, > init-gradle-wrapper-trunk-and-18.sh, init-gradle-wrapper-trunk-and-18.sh, > init-gradle-wrapper-trunk-and-18.sh, init-gradle-wrapper-trunk-and-18.sh, > init-gradle-wrapper.ps1, init-gradle-wrapper.sh, init-gradle-wrapper.sh, > init-gradle-wrapper.sh, init-gradle-wrapper.sh, init-gradle-wrapper.sh, > init-gradle-wrapper.sh, init-gradlew-readme-R16.patch, > init-gradlew-readme-R17.1.patch, init-gradlew-readme-R17.1.patch, > init-gradlew-readme.patch, init-gradlew-readme.patch > > > Following the discussion at http://markmail.org/message/nd7grfiyobjkfwae, > considering LEGAL-288 and based on a lazy consensus on dev ML, we want to > remove the gradle-wrapper.jar file from the next packaged releases and use > [~jacopoc]'s related proposition to document how to have Gradle working in > the main README.md file. > # Extract the archive file to your local directory. > # Download gradle-wrapper.jar and place it in the > OFBiz-root-dir/gradle/wrapper folder. > I'm not sure if we should recommend a link to download the > gradle-wrapper.jar. This might change in the future (versions, etc.), so > indeed maybe simply asking to download is enough, cf > https://www.google.com/search?q=gradle-wrapper.jar+download=UTF-8 > Also we need to add a point about removing gradle-wrapper.jar in > https://cwiki.apache.org/confluence/display/OFBIZ/Release+Management+Guide+for+OFBiz -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-10145) Remove the Gradle wrapper from our release packages and add a step to our build notes
[ https://issues.apache.org/jira/browse/OFBIZ-10145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16867505#comment-16867505 ] Jacques Le Roux commented on OFBIZ-10145: - I can get the wrapper and its properties from https://github.com/gradle/gradle/tree/v5.0.0/gradle/wrapper and https://github.com/gradle/gradle/tree/v3.2.1/gradle/wrapper. But not https://github.com/gradle/gradle/tree/v2.13/gradle/wrapper. As often external services have an end. That's one of the reasons I copied our files in tools. After bad experiences (yes you GoOgle) I don't trust much external services life durations. I can find it at https://repo.spring.io/plugins-release/org/gradle/gradle-wrapper/2.13/gradle-wrapper-2.13.jar but not the properties. Anyway I can't see how it's better than having our own files copied somewhere. We need to change things when upgrading Gradle anyway. Copying 2 files is not that much work. Also, thinking about it, we only need my tools solution for Buildbot. Because there all start afresh. So the wrapper is missing each time. But not Gradle, it's there (with different versions) on the Builbot servers. That's why the wrapper, and only it, should be copied from tools. On the demo we should use init-gradle-wrapper.sh as in other environments (dev, production, etc.). Only Buildbot is a transient environment that we have to handle specifically. So rather than relying on an external service which can disappear in future, I stay with my proposition. :) I don't think we have a wiki page about "How to upgrade Gradle". I think we need one now and I will create it, notably for the tools update thing. > Remove the Gradle wrapper from our release packages and add a step to our > build notes > - > > Key: OFBIZ-10145 > URL: https://issues.apache.org/jira/browse/OFBIZ-10145 > Project: OFBiz > Issue Type: Task > Components: Gradle >Affects Versions: 17.12.01, 16.11.06, 18.12.01 >Reporter: Jacques Le Roux >Assignee: Nicolas Malin >Priority: Blocker > Fix For: 17.12.01 > > Attachments: OFBIZ-10145-gradlew.patch, init-gradle-wrapper-R16.sh, > init-gradle-wrapper-trunk-and-18.sh, init-gradle-wrapper-trunk-and-18.sh, > init-gradle-wrapper-trunk-and-18.sh, init-gradle-wrapper-trunk-and-18.sh, > init-gradle-wrapper.ps1, init-gradle-wrapper.sh, init-gradle-wrapper.sh, > init-gradle-wrapper.sh, init-gradle-wrapper.sh, init-gradle-wrapper.sh, > init-gradle-wrapper.sh, init-gradlew-readme-R16.patch, > init-gradlew-readme-R17.1.patch, init-gradlew-readme-R17.1.patch, > init-gradlew-readme.patch, init-gradlew-readme.patch > > > Following the discussion at http://markmail.org/message/nd7grfiyobjkfwae, > considering LEGAL-288 and based on a lazy consensus on dev ML, we want to > remove the gradle-wrapper.jar file from the next packaged releases and use > [~jacopoc]'s related proposition to document how to have Gradle working in > the main README.md file. > # Extract the archive file to your local directory. > # Download gradle-wrapper.jar and place it in the > OFBiz-root-dir/gradle/wrapper folder. > I'm not sure if we should recommend a link to download the > gradle-wrapper.jar. This might change in the future (versions, etc.), so > indeed maybe simply asking to download is enough, cf > https://www.google.com/search?q=gradle-wrapper.jar+download=UTF-8 > Also we need to add a point about removing gradle-wrapper.jar in > https://cwiki.apache.org/confluence/display/OFBIZ/Release+Management+Guide+for+OFBiz -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-10145) Remove the Gradle wrapper from our release packages and add a step to our build notes
[ https://issues.apache.org/jira/browse/OFBIZ-10145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16867315#comment-16867315 ] Jacques Le Roux commented on OFBIZ-10145: - Hi Nicolas, Don't worry, I'll handle the Windows side, you can go ahead. > Remove the Gradle wrapper from our release packages and add a step to our > build notes > - > > Key: OFBIZ-10145 > URL: https://issues.apache.org/jira/browse/OFBIZ-10145 > Project: OFBiz > Issue Type: Task > Components: Gradle >Affects Versions: 17.12.01, 16.11.06, 18.12.01 >Reporter: Jacques Le Roux >Assignee: Nicolas Malin >Priority: Blocker > Fix For: 17.12.01 > > Attachments: OFBIZ-10145-gradlew.patch, init-gradle-wrapper-R16.sh, > init-gradle-wrapper-trunk-and-18.sh, init-gradle-wrapper-trunk-and-18.sh, > init-gradle-wrapper-trunk-and-18.sh, init-gradle-wrapper-trunk-and-18.sh, > init-gradle-wrapper.ps1, init-gradle-wrapper.sh, init-gradle-wrapper.sh, > init-gradle-wrapper.sh, init-gradle-wrapper.sh, init-gradle-wrapper.sh, > init-gradle-wrapper.sh, init-gradlew-readme-R16.patch, > init-gradlew-readme-R17.1.patch, init-gradlew-readme-R17.1.patch, > init-gradlew-readme.patch, init-gradlew-readme.patch > > > Following the discussion at http://markmail.org/message/nd7grfiyobjkfwae, > considering LEGAL-288 and based on a lazy consensus on dev ML, we want to > remove the gradle-wrapper.jar file from the next packaged releases and use > [~jacopoc]'s related proposition to document how to have Gradle working in > the main README.md file. > # Extract the archive file to your local directory. > # Download gradle-wrapper.jar and place it in the > OFBiz-root-dir/gradle/wrapper folder. > I'm not sure if we should recommend a link to download the > gradle-wrapper.jar. This might change in the future (versions, etc.), so > indeed maybe simply asking to download is enough, cf > https://www.google.com/search?q=gradle-wrapper.jar+download=UTF-8 > Also we need to add a point about removing gradle-wrapper.jar in > https://cwiki.apache.org/confluence/display/OFBIZ/Release+Management+Guide+for+OFBiz -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-10145) Remove the Gradle wrapper from our release packages and add a step to our build notes
[ https://issues.apache.org/jira/browse/OFBIZ-10145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16867274#comment-16867274 ] Nicolas Malin commented on OFBIZ-10145: --- [~jacques.le.roux] I prepare the commit on trunk and do we need [^init-gradle-wrapper.ps1] finally or just [^init-gradle-wrapper.sh] is enough ? > Remove the Gradle wrapper from our release packages and add a step to our > build notes > - > > Key: OFBIZ-10145 > URL: https://issues.apache.org/jira/browse/OFBIZ-10145 > Project: OFBiz > Issue Type: Task > Components: Gradle >Affects Versions: 17.12.01, 16.11.06, 18.12.01 >Reporter: Jacques Le Roux >Assignee: Nicolas Malin >Priority: Blocker > Fix For: 17.12.01 > > Attachments: OFBIZ-10145-gradlew.patch, init-gradle-wrapper-R16.sh, > init-gradle-wrapper-trunk-and-18.sh, init-gradle-wrapper-trunk-and-18.sh, > init-gradle-wrapper-trunk-and-18.sh, init-gradle-wrapper-trunk-and-18.sh, > init-gradle-wrapper.ps1, init-gradle-wrapper.sh, init-gradle-wrapper.sh, > init-gradle-wrapper.sh, init-gradle-wrapper.sh, init-gradle-wrapper.sh, > init-gradle-wrapper.sh, init-gradlew-readme-R16.patch, > init-gradlew-readme-R17.1.patch, init-gradlew-readme-R17.1.patch, > init-gradlew-readme.patch, init-gradlew-readme.patch > > > Following the discussion at http://markmail.org/message/nd7grfiyobjkfwae, > considering LEGAL-288 and based on a lazy consensus on dev ML, we want to > remove the gradle-wrapper.jar file from the next packaged releases and use > [~jacopoc]'s related proposition to document how to have Gradle working in > the main README.md file. > # Extract the archive file to your local directory. > # Download gradle-wrapper.jar and place it in the > OFBiz-root-dir/gradle/wrapper folder. > I'm not sure if we should recommend a link to download the > gradle-wrapper.jar. This might change in the future (versions, etc.), so > indeed maybe simply asking to download is enough, cf > https://www.google.com/search?q=gradle-wrapper.jar+download=UTF-8 > Also we need to add a point about removing gradle-wrapper.jar in > https://cwiki.apache.org/confluence/display/OFBIZ/Release+Management+Guide+for+OFBiz -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-10145) Remove the Gradle wrapper from our release packages and add a step to our build notes
[ https://issues.apache.org/jira/browse/OFBIZ-10145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16866330#comment-16866330 ] Nicolas Malin commented on OFBIZ-10145: --- Nice :) I will work today today on > Remove the Gradle wrapper from our release packages and add a step to our > build notes > - > > Key: OFBIZ-10145 > URL: https://issues.apache.org/jira/browse/OFBIZ-10145 > Project: OFBiz > Issue Type: Task > Components: Gradle >Affects Versions: 17.12.01, 16.11.06, 18.12.01 >Reporter: Jacques Le Roux >Assignee: Jacques Le Roux >Priority: Blocker > Fix For: 17.12.01 > > Attachments: OFBIZ-10145-gradlew.patch, init-gradle-wrapper-R16.sh, > init-gradle-wrapper-trunk-and-18.sh, init-gradle-wrapper-trunk-and-18.sh, > init-gradle-wrapper-trunk-and-18.sh, init-gradle-wrapper-trunk-and-18.sh, > init-gradle-wrapper.ps1, init-gradle-wrapper.sh, init-gradle-wrapper.sh, > init-gradle-wrapper.sh, init-gradle-wrapper.sh, init-gradle-wrapper.sh, > init-gradlew-readme-R16.patch, init-gradlew-readme-R17.1.patch, > init-gradlew-readme-R17.1.patch, init-gradlew-readme.patch, > init-gradlew-readme.patch > > > Following the discussion at http://markmail.org/message/nd7grfiyobjkfwae, > considering LEGAL-288 and based on a lazy consensus on dev ML, we want to > remove the gradle-wrapper.jar file from the next packaged releases and use > [~jacopoc]'s related proposition to document how to have Gradle working in > the main README.md file. > # Extract the archive file to your local directory. > # Download gradle-wrapper.jar and place it in the > OFBiz-root-dir/gradle/wrapper folder. > I'm not sure if we should recommend a link to download the > gradle-wrapper.jar. This might change in the future (versions, etc.), so > indeed maybe simply asking to download is enough, cf > https://www.google.com/search?q=gradle-wrapper.jar+download=UTF-8 > Also we need to add a point about removing gradle-wrapper.jar in > https://cwiki.apache.org/confluence/display/OFBIZ/Release+Management+Guide+for+OFBiz -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-10145) Remove the Gradle wrapper from our release packages and add a step to our build notes
[
https://issues.apache.org/jira/browse/OFBIZ-10145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16866311#comment-16866311
]
Jacques Le Roux commented on OFBIZ-10145:
-
Hi Nicolas,
bq. this introduce a hard rule for future to keep it during all time that a
release version would be present on support.
You got a point there indeed. We will have to keep the versions which are used
by Buildbot and the demo but no more.
BTW, for them, instead of asking infra for help, we should now punctually use
{{gradlew wrapper --gradle-version x.y.z}} in our scripts when necessary. Then
Gradle will be automatically updated where it fits currently \o/
bq. After check a different solution I can suggest to download directly from
official gradle source:
https://github.com/gradle/gradle/tree/v5.0.0/gradle/wrapper and set the version
'v5.0.0' in own source code.
I agree sounds better
I think we are ready now :)
> Remove the Gradle wrapper from our release packages and add a step to our
> build notes
> -
>
> Key: OFBIZ-10145
> URL: https://issues.apache.org/jira/browse/OFBIZ-10145
> Project: OFBiz
> Issue Type: Task
> Components: Gradle
>Affects Versions: 17.12.01, 16.11.06, 18.12.01
>Reporter: Jacques Le Roux
>Assignee: Jacques Le Roux
>Priority: Blocker
> Fix For: 17.12.01
>
> Attachments: OFBIZ-10145-gradlew.patch, init-gradle-wrapper-R16.sh,
> init-gradle-wrapper-trunk-and-18.sh, init-gradle-wrapper-trunk-and-18.sh,
> init-gradle-wrapper-trunk-and-18.sh, init-gradle-wrapper-trunk-and-18.sh,
> init-gradle-wrapper.ps1, init-gradle-wrapper.sh, init-gradle-wrapper.sh,
> init-gradle-wrapper.sh, init-gradle-wrapper.sh, init-gradle-wrapper.sh,
> init-gradlew-readme-R16.patch, init-gradlew-readme-R17.1.patch,
> init-gradlew-readme-R17.1.patch, init-gradlew-readme.patch,
> init-gradlew-readme.patch
>
>
> Following the discussion at http://markmail.org/message/nd7grfiyobjkfwae,
> considering LEGAL-288 and based on a lazy consensus on dev ML, we want to
> remove the gradle-wrapper.jar file from the next packaged releases and use
> [~jacopoc]'s related proposition to document how to have Gradle working in
> the main README.md file.
> # Extract the archive file to your local directory.
> # Download gradle-wrapper.jar and place it in the
> OFBiz-root-dir/gradle/wrapper folder.
> I'm not sure if we should recommend a link to download the
> gradle-wrapper.jar. This might change in the future (versions, etc.), so
> indeed maybe simply asking to download is enough, cf
> https://www.google.com/search?q=gradle-wrapper.jar+download=UTF-8
> Also we need to add a point about removing gradle-wrapper.jar in
> https://cwiki.apache.org/confluence/display/OFBIZ/Release+Management+Guide+for+OFBiz
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (OFBIZ-10145) Remove the Gradle wrapper from our release packages and add a step to our build notes
[ https://issues.apache.org/jira/browse/OFBIZ-10145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16865613#comment-16865613 ] Nicolas Malin commented on OFBIZ-10145: --- :) I never told on a veto, just uncomfortable with this solution. But sure I noticed enhancement to download only the wrapper. I think the most point that disturb me, come from the way to download the wrapper https://svn.apache.org/repos/asf/ofbiz/tools/Buildbot/Gradle/Wrapper, this introduce a hard rule for future to keep it during all time that a release version would be present on support. After check a different solution I can suggest to download directly from official gradle source: https://github.com/gradle/gradle/tree/v5.0.0/gradle/wrapper and set the version 'v5.0.0' in own source code. For Buildbot and demo, I propose to manage them as production site as you suggest, I no problem with that because we have then hand on all step. > Remove the Gradle wrapper from our release packages and add a step to our > build notes > - > > Key: OFBIZ-10145 > URL: https://issues.apache.org/jira/browse/OFBIZ-10145 > Project: OFBiz > Issue Type: Task > Components: Gradle >Affects Versions: 17.12.01, 16.11.06, 18.12.01 >Reporter: Jacques Le Roux >Assignee: Jacques Le Roux >Priority: Blocker > Fix For: 17.12.01 > > Attachments: OFBIZ-10145-gradlew.patch, init-gradle-wrapper-R16.sh, > init-gradle-wrapper-trunk-and-18.sh, init-gradle-wrapper-trunk-and-18.sh, > init-gradle-wrapper-trunk-and-18.sh, init-gradle-wrapper-trunk-and-18.sh, > init-gradle-wrapper.ps1, init-gradle-wrapper.sh, init-gradle-wrapper.sh, > init-gradle-wrapper.sh, init-gradle-wrapper.sh, init-gradle-wrapper.sh, > init-gradlew-readme-R16.patch, init-gradlew-readme-R17.1.patch, > init-gradlew-readme-R17.1.patch, init-gradlew-readme.patch, > init-gradlew-readme.patch > > > Following the discussion at http://markmail.org/message/nd7grfiyobjkfwae, > considering LEGAL-288 and based on a lazy consensus on dev ML, we want to > remove the gradle-wrapper.jar file from the next packaged releases and use > [~jacopoc]'s related proposition to document how to have Gradle working in > the main README.md file. > # Extract the archive file to your local directory. > # Download gradle-wrapper.jar and place it in the > OFBiz-root-dir/gradle/wrapper folder. > I'm not sure if we should recommend a link to download the > gradle-wrapper.jar. This might change in the future (versions, etc.), so > indeed maybe simply asking to download is enough, cf > https://www.google.com/search?q=gradle-wrapper.jar+download=UTF-8 > Also we need to add a point about removing gradle-wrapper.jar in > https://cwiki.apache.org/confluence/display/OFBIZ/Release+Management+Guide+for+OFBiz -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-10145) Remove the Gradle wrapper from our release packages and add a step to our build notes
[ https://issues.apache.org/jira/browse/OFBIZ-10145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16864374#comment-16864374 ] Jacques Le Roux commented on OFBIZ-10145: - Hi Nicolas, As long as it's not released, I don't see a problem to have it in our repo and downloaded from there, be it for demos or by users even in production mode. BTW in production mode I guess people handle it in order to not have to download Gradle at each installation. I mean they use a shared location from where Gradle is used. AFAIK the ASF does not impose that you can't download ASL2 licensed jar from repos as long as it's not in a relase package. And even that is not striclty restricted as proves LEGAL-288; please re-read it, especially Mark Thomas comments (both of them). For a possible banwidth issue, gradle-wrapper.jar is only 55 Kb. Downloading Gradle and all the libs is another thing... That's why I suggest that we put a message to warn the user about the Gradle download. Later, for libs, I guess it's obvious from terminal content. So why do you feel it's a wrong idea? Of course other committer opinions would be good, but so far I don't see any reason for a veto. > Remove the Gradle wrapper from our release packages and add a step to our > build notes > - > > Key: OFBIZ-10145 > URL: https://issues.apache.org/jira/browse/OFBIZ-10145 > Project: OFBiz > Issue Type: Task > Components: Gradle >Affects Versions: 17.12.01, 16.11.06, 18.12.01 >Reporter: Jacques Le Roux >Assignee: Jacques Le Roux >Priority: Blocker > Fix For: 17.12.01 > > Attachments: OFBIZ-10145-gradlew.patch, init-gradle-wrapper-R16.sh, > init-gradle-wrapper-trunk-and-18.sh, init-gradle-wrapper-trunk-and-18.sh, > init-gradle-wrapper-trunk-and-18.sh, init-gradle-wrapper-trunk-and-18.sh, > init-gradle-wrapper.ps1, init-gradle-wrapper.sh, init-gradle-wrapper.sh, > init-gradle-wrapper.sh, init-gradle-wrapper.sh, init-gradle-wrapper.sh, > init-gradlew-readme-R16.patch, init-gradlew-readme-R17.1.patch, > init-gradlew-readme-R17.1.patch, init-gradlew-readme.patch, > init-gradlew-readme.patch > > > Following the discussion at http://markmail.org/message/nd7grfiyobjkfwae, > considering LEGAL-288 and based on a lazy consensus on dev ML, we want to > remove the gradle-wrapper.jar file from the next packaged releases and use > [~jacopoc]'s related proposition to document how to have Gradle working in > the main README.md file. > # Extract the archive file to your local directory. > # Download gradle-wrapper.jar and place it in the > OFBiz-root-dir/gradle/wrapper folder. > I'm not sure if we should recommend a link to download the > gradle-wrapper.jar. This might change in the future (versions, etc.), so > indeed maybe simply asking to download is enough, cf > https://www.google.com/search?q=gradle-wrapper.jar+download=UTF-8 > Also we need to add a point about removing gradle-wrapper.jar in > https://cwiki.apache.org/confluence/display/OFBIZ/Release+Management+Guide+for+OFBiz -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-10145) Remove the Gradle wrapper from our release packages and add a step to our build notes
[ https://issues.apache.org/jira/browse/OFBIZ-10145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16864221#comment-16864221 ] Nicolas Malin commented on OFBIZ-10145: --- I haven't doubt about this solution works and it's easy to implement. Despite all, I continue feeling the wrong good idea to keep and download the jar from own repository. Maybe we need to cross other commiter opinions ? > Remove the Gradle wrapper from our release packages and add a step to our > build notes > - > > Key: OFBIZ-10145 > URL: https://issues.apache.org/jira/browse/OFBIZ-10145 > Project: OFBiz > Issue Type: Task > Components: Gradle >Affects Versions: 17.12.01, 16.11.06, 18.12.01 >Reporter: Jacques Le Roux >Assignee: Jacques Le Roux >Priority: Blocker > Fix For: 17.12.01 > > Attachments: OFBIZ-10145-gradlew.patch, init-gradle-wrapper-R16.sh, > init-gradle-wrapper-trunk-and-18.sh, init-gradle-wrapper-trunk-and-18.sh, > init-gradle-wrapper-trunk-and-18.sh, init-gradle-wrapper-trunk-and-18.sh, > init-gradle-wrapper.ps1, init-gradle-wrapper.sh, init-gradle-wrapper.sh, > init-gradle-wrapper.sh, init-gradle-wrapper.sh, init-gradle-wrapper.sh, > init-gradlew-readme-R16.patch, init-gradlew-readme-R17.1.patch, > init-gradlew-readme-R17.1.patch, init-gradlew-readme.patch, > init-gradlew-readme.patch > > > Following the discussion at http://markmail.org/message/nd7grfiyobjkfwae, > considering LEGAL-288 and based on a lazy consensus on dev ML, we want to > remove the gradle-wrapper.jar file from the next packaged releases and use > [~jacopoc]'s related proposition to document how to have Gradle working in > the main README.md file. > # Extract the archive file to your local directory. > # Download gradle-wrapper.jar and place it in the > OFBiz-root-dir/gradle/wrapper folder. > I'm not sure if we should recommend a link to download the > gradle-wrapper.jar. This might change in the future (versions, etc.), so > indeed maybe simply asking to download is enough, cf > https://www.google.com/search?q=gradle-wrapper.jar+download=UTF-8 > Also we need to add a point about removing gradle-wrapper.jar in > https://cwiki.apache.org/confluence/display/OFBIZ/Release+Management+Guide+for+OFBiz -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-10145) Remove the Gradle wrapper from our release packages and add a step to our build notes
[ https://issues.apache.org/jira/browse/OFBIZ-10145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16861003#comment-16861003 ] Jacques Le Roux commented on OFBIZ-10145: - Hi Nicolas, bq. If we checkout ofbiz-framework and after download the wrapper from own repos, finally why remove the wrapper ? Because we don't want to distribute gradle-wrapper.jar. We release the branch, not the trunk nor the tools. See LEGAL-288 and re-read the description here if it's not clear enough. bq. I thinked that the binary would be resolve for a uri published by the owner. This is not mandatory. What is required is to not release external binaries. bq. Demo and buildbot problem need to be not related to ofbiz-framework source Since they use the release branches and trunk, from where we remove the external binaries (Gradle was adopted for this reason), we need to get the gradle-wrapper files from somewhere. Getting them from tools is the less possible expensible way. bq. gradle wrapper version need to be present with source code Yes that's why we have https://svn.apache.org/repos/asf/ofbiz/tools/Buildbot/Gradle/Wrapper bq. I fear that we take a hazardous shortcut There is nothing hazardous with my proposed solution :) And it works! > Remove the Gradle wrapper from our release packages and add a step to our > build notes > - > > Key: OFBIZ-10145 > URL: https://issues.apache.org/jira/browse/OFBIZ-10145 > Project: OFBiz > Issue Type: Task > Components: Gradle >Affects Versions: 17.12.01, 16.11.06, 18.12.01 >Reporter: Jacques Le Roux >Assignee: Jacques Le Roux >Priority: Blocker > Fix For: 17.12.01 > > Attachments: OFBIZ-10145-gradlew.patch, init-gradle-wrapper-R16.sh, > init-gradle-wrapper-trunk-and-18.sh, init-gradle-wrapper-trunk-and-18.sh, > init-gradle-wrapper-trunk-and-18.sh, init-gradle-wrapper-trunk-and-18.sh, > init-gradle-wrapper.ps1, init-gradle-wrapper.sh, init-gradle-wrapper.sh, > init-gradle-wrapper.sh, init-gradle-wrapper.sh, init-gradle-wrapper.sh, > init-gradlew-readme-R16.patch, init-gradlew-readme-R17.1.patch, > init-gradlew-readme-R17.1.patch, init-gradlew-readme.patch, > init-gradlew-readme.patch > > > Following the discussion at http://markmail.org/message/nd7grfiyobjkfwae, > considering LEGAL-288 and based on a lazy consensus on dev ML, we want to > remove the gradle-wrapper.jar file from the next packaged releases and use > [~jacopoc]'s related proposition to document how to have Gradle working in > the main README.md file. > # Extract the archive file to your local directory. > # Download gradle-wrapper.jar and place it in the > OFBiz-root-dir/gradle/wrapper folder. > I'm not sure if we should recommend a link to download the > gradle-wrapper.jar. This might change in the future (versions, etc.), so > indeed maybe simply asking to download is enough, cf > https://www.google.com/search?q=gradle-wrapper.jar+download=UTF-8 > Also we need to add a point about removing gradle-wrapper.jar in > https://cwiki.apache.org/confluence/display/OFBIZ/Release+Management+Guide+for+OFBiz -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-10145) Remove the Gradle wrapper from our release packages and add a step to our build notes
[ https://issues.apache.org/jira/browse/OFBIZ-10145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16860968#comment-16860968 ] Nicolas Malin commented on OFBIZ-10145: --- hmmm I didn't undertood the most valuable give by download the wrapper from ofbiz/tools/Buildbot/. If we checkout ofbiz-framework and after download the wrapper from own repos, finally why remove the wrapper ? Maybe I'm a wrong way, I thinked that the binary would be resolve for a uri published by the owner. For my point of view : * Demo and buildbot problem need to be not related to ofbiz-framework source * gradle wrapper version need to be present with source code I fear that we take a hazardous shortcut > Remove the Gradle wrapper from our release packages and add a step to our > build notes > - > > Key: OFBIZ-10145 > URL: https://issues.apache.org/jira/browse/OFBIZ-10145 > Project: OFBiz > Issue Type: Task > Components: Gradle >Affects Versions: 17.12.01, 16.11.06, 18.12.01 >Reporter: Jacques Le Roux >Assignee: Jacques Le Roux >Priority: Blocker > Fix For: 17.12.01 > > Attachments: OFBIZ-10145-gradlew.patch, init-gradle-wrapper-R16.sh, > init-gradle-wrapper-trunk-and-18.sh, init-gradle-wrapper-trunk-and-18.sh, > init-gradle-wrapper-trunk-and-18.sh, init-gradle-wrapper-trunk-and-18.sh, > init-gradle-wrapper.ps1, init-gradle-wrapper.sh, init-gradle-wrapper.sh, > init-gradle-wrapper.sh, init-gradle-wrapper.sh, init-gradle-wrapper.sh, > init-gradlew-readme-R16.patch, init-gradlew-readme-R17.1.patch, > init-gradlew-readme-R17.1.patch, init-gradlew-readme.patch, > init-gradlew-readme.patch > > > Following the discussion at http://markmail.org/message/nd7grfiyobjkfwae, > considering LEGAL-288 and based on a lazy consensus on dev ML, we want to > remove the gradle-wrapper.jar file from the next packaged releases and use > [~jacopoc]'s related proposition to document how to have Gradle working in > the main README.md file. > # Extract the archive file to your local directory. > # Download gradle-wrapper.jar and place it in the > OFBiz-root-dir/gradle/wrapper folder. > I'm not sure if we should recommend a link to download the > gradle-wrapper.jar. This might change in the future (versions, etc.), so > indeed maybe simply asking to download is enough, cf > https://www.google.com/search?q=gradle-wrapper.jar+download=UTF-8 > Also we need to add a point about removing gradle-wrapper.jar in > https://cwiki.apache.org/confluence/display/OFBIZ/Release+Management+Guide+for+OFBiz -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-10145) Remove the Gradle wrapper from our release packages and add a step to our build notes
[ https://issues.apache.org/jira/browse/OFBIZ-10145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16859169#comment-16859169 ] Swapnil M Mane commented on OFBIZ-10145: Thank you [~jacques.le.roux], I like the suggestion of calling init-gradle-wrapper script from both gradlew and gradlew.bat script. In this way, life our users will became easy, no action will be required from their side. And as you nicely mentioned we need to make sure we are handling the 'init-gradle-wrapper' script always while upgrading the gradle. Let's see what are the thoughts our fellow team members. Thanks! > Remove the Gradle wrapper from our release packages and add a step to our > build notes > - > > Key: OFBIZ-10145 > URL: https://issues.apache.org/jira/browse/OFBIZ-10145 > Project: OFBiz > Issue Type: Task > Components: Gradle >Affects Versions: 17.12.01, 16.11.06, 18.12.01 >Reporter: Jacques Le Roux >Assignee: Jacques Le Roux >Priority: Blocker > Fix For: 17.12.01 > > Attachments: OFBIZ-10145-gradlew.patch, init-gradle-wrapper-R16.sh, > init-gradle-wrapper-trunk-and-18.sh, init-gradle-wrapper-trunk-and-18.sh, > init-gradle-wrapper-trunk-and-18.sh, init-gradle-wrapper-trunk-and-18.sh, > init-gradle-wrapper.ps1, init-gradle-wrapper.sh, init-gradle-wrapper.sh, > init-gradle-wrapper.sh, init-gradle-wrapper.sh, init-gradle-wrapper.sh, > init-gradlew-readme-R16.patch, init-gradlew-readme-R17.1.patch, > init-gradlew-readme-R17.1.patch, init-gradlew-readme.patch, > init-gradlew-readme.patch > > > Following the discussion at http://markmail.org/message/nd7grfiyobjkfwae, > considering LEGAL-288 and based on a lazy consensus on dev ML, we want to > remove the gradle-wrapper.jar file from the next packaged releases and use > [~jacopoc]'s related proposition to document how to have Gradle working in > the main README.md file. > # Extract the archive file to your local directory. > # Download gradle-wrapper.jar and place it in the > OFBiz-root-dir/gradle/wrapper folder. > I'm not sure if we should recommend a link to download the > gradle-wrapper.jar. This might change in the future (versions, etc.), so > indeed maybe simply asking to download is enough, cf > https://www.google.com/search?q=gradle-wrapper.jar+download=UTF-8 > Also we need to add a point about removing gradle-wrapper.jar in > https://cwiki.apache.org/confluence/display/OFBIZ/Release+Management+Guide+for+OFBiz -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-10145) Remove the Gradle wrapper from our release packages and add a step to our build notes
[
https://issues.apache.org/jira/browse/OFBIZ-10145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16858650#comment-16858650
]
Jacques Le Roux commented on OFBIZ-10145:
-
Thanks Swapnil,
Yes this is what I thought about, your script looks good to me. Previouysly I
wrote:
bq. I even thought about hacking the gradlew scripts, then we would not need
init-gradle-wrapper at all. But those are generated with Gradle installation
and better keep them as delivered by Gradle.
I thought about it a bit more. We have those 2 scripts in our repo. When we
will update Gradle (using something like {{gradlew wrapper --gradle-version
5.4.1}}) Gradle may change those scripts. So if we put a call to our
init-gradle-wrapper scripts in them they will be removed. But it's then very
easy to put them again notably because we will have a copy of the preceding
version in our repo.
So I finally suggest that we call our init-gradle-wrapper scripts from both
gradlew and gradlew.bat script if the Wrapper is not present. Then no need to
ask our users to run the init-gradle-wrapper by hand using the starting script
(gradlew or gradlew.bat) would be enough.
I even suggest that we keep the message from init-gradle-wrapper.sh
bq. "Gradle is not found in your system, downloading it to instantiate the
wrapper."
to reassure the users about what's going on. The download can be long before
you can really use OFBiz, I'd even add a message explaining that.
> Remove the Gradle wrapper from our release packages and add a step to our
> build notes
> -
>
> Key: OFBIZ-10145
> URL: https://issues.apache.org/jira/browse/OFBIZ-10145
> Project: OFBiz
> Issue Type: Task
> Components: Gradle
>Affects Versions: 17.12.01, 16.11.06, 18.12.01
>Reporter: Jacques Le Roux
>Assignee: Jacques Le Roux
>Priority: Blocker
> Fix For: 17.12.01
>
> Attachments: OFBIZ-10145-gradlew.patch, init-gradle-wrapper-R16.sh,
> init-gradle-wrapper-trunk-and-18.sh, init-gradle-wrapper-trunk-and-18.sh,
> init-gradle-wrapper-trunk-and-18.sh, init-gradle-wrapper-trunk-and-18.sh,
> init-gradle-wrapper.ps1, init-gradle-wrapper.sh, init-gradle-wrapper.sh,
> init-gradle-wrapper.sh, init-gradle-wrapper.sh, init-gradle-wrapper.sh,
> init-gradlew-readme-R16.patch, init-gradlew-readme-R17.1.patch,
> init-gradlew-readme-R17.1.patch, init-gradlew-readme.patch,
> init-gradlew-readme.patch
>
>
> Following the discussion at http://markmail.org/message/nd7grfiyobjkfwae,
> considering LEGAL-288 and based on a lazy consensus on dev ML, we want to
> remove the gradle-wrapper.jar file from the next packaged releases and use
> [~jacopoc]'s related proposition to document how to have Gradle working in
> the main README.md file.
> # Extract the archive file to your local directory.
> # Download gradle-wrapper.jar and place it in the
> OFBiz-root-dir/gradle/wrapper folder.
> I'm not sure if we should recommend a link to download the
> gradle-wrapper.jar. This might change in the future (versions, etc.), so
> indeed maybe simply asking to download is enough, cf
> https://www.google.com/search?q=gradle-wrapper.jar+download=UTF-8
> Also we need to add a point about removing gradle-wrapper.jar in
> https://cwiki.apache.org/confluence/display/OFBIZ/Release+Management+Guide+for+OFBiz
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (OFBIZ-10145) Remove the Gradle wrapper from our release packages and add a step to our build notes
[
https://issues.apache.org/jira/browse/OFBIZ-10145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16858591#comment-16858591
]
Swapnil M Mane commented on OFBIZ-10145:
Hi [~jacques.le.roux] ,
Thank you for your efforts. :)
I see no harm in copying gradle-wrapper.jar and gradle-wrapper.properties from
our repository. (let's see what others say)
Based on your input, our updated script will look someting like this.
{code:java}
OFBIZ_HOME="$(pwd)"
GRADLE_WRAPPER_OFBIZ_PATH="$OFBIZ_HOME/gradle/"
WRAPPER_URL="http://svn.apache.org/repos/asf/ofbiz/tools/Buildbot/Gradle/Wrapper/trunk/gradle-wrapper.jar;
WRAPPER_PROPERTIES_URL="http://svn.apache.org/repos/asf/ofbiz/tools/Buildbot/Gradle/Wrapper/trunk/gradle-wrapper.properties;
whereIsBinary() {
whereis $1 | grep /
}
if [ ! -d "$GRADLE_WRAPPER_OFBIZ_PATH" ]; then
echo "Location seems to be incorrect, please run the 'sh
gradle/init-gradle-wrapper.sh' script from Apache OFBiz root.";
exit -1;
fi
if [ -n "$(whereIsBinary curl)" ]; then
GET_CMD="curl -o";
elif [ -n "$(whereIsBinary wget)" ]; then
GET_CMD="wget -O";
else
echo "No command curl or wget found, please install yourself.";
exit -1
fi
$GET_CMD "gradle/wrapper/gradle-wrapper.jar" $WRAPPER_URL
$GET_CMD "gradle/wrapper/gradle-wrapper.properties" $WRAPPER_PROPERTIES_URL
{code}
[~jacques.le.roux], [~soledad] and team,
Please feel free to share your thoughts on this updated script.
Thanks!
> Remove the Gradle wrapper from our release packages and add a step to our
> build notes
> -
>
> Key: OFBIZ-10145
> URL: https://issues.apache.org/jira/browse/OFBIZ-10145
> Project: OFBiz
> Issue Type: Task
> Components: Gradle
>Affects Versions: 17.12.01, 16.11.06, 18.12.01
>Reporter: Jacques Le Roux
>Assignee: Jacques Le Roux
>Priority: Blocker
> Fix For: 17.12.01
>
> Attachments: OFBIZ-10145-gradlew.patch, init-gradle-wrapper-R16.sh,
> init-gradle-wrapper-trunk-and-18.sh, init-gradle-wrapper-trunk-and-18.sh,
> init-gradle-wrapper-trunk-and-18.sh, init-gradle-wrapper-trunk-and-18.sh,
> init-gradle-wrapper.ps1, init-gradle-wrapper.sh, init-gradle-wrapper.sh,
> init-gradle-wrapper.sh, init-gradle-wrapper.sh, init-gradle-wrapper.sh,
> init-gradlew-readme-R16.patch, init-gradlew-readme-R17.1.patch,
> init-gradlew-readme-R17.1.patch, init-gradlew-readme.patch,
> init-gradlew-readme.patch
>
>
> Following the discussion at http://markmail.org/message/nd7grfiyobjkfwae,
> considering LEGAL-288 and based on a lazy consensus on dev ML, we want to
> remove the gradle-wrapper.jar file from the next packaged releases and use
> [~jacopoc]'s related proposition to document how to have Gradle working in
> the main README.md file.
> # Extract the archive file to your local directory.
> # Download gradle-wrapper.jar and place it in the
> OFBiz-root-dir/gradle/wrapper folder.
> I'm not sure if we should recommend a link to download the
> gradle-wrapper.jar. This might change in the future (versions, etc.), so
> indeed maybe simply asking to download is enough, cf
> https://www.google.com/search?q=gradle-wrapper.jar+download=UTF-8
> Also we need to add a point about removing gradle-wrapper.jar in
> https://cwiki.apache.org/confluence/display/OFBIZ/Release+Management+Guide+for+OFBiz
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (OFBIZ-10145) Remove the Gradle wrapper from our release packages and add a step to our build notes
[ https://issues.apache.org/jira/browse/OFBIZ-10145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16858035#comment-16858035 ] Jacques Le Roux commented on OFBIZ-10145: - Sorry Swapnil, I think we should go this way for all branches and so have to update the documentation again. Notably about Windows, I'll handle that part... > Remove the Gradle wrapper from our release packages and add a step to our > build notes > - > > Key: OFBIZ-10145 > URL: https://issues.apache.org/jira/browse/OFBIZ-10145 > Project: OFBiz > Issue Type: Task > Components: Gradle >Affects Versions: 17.12.01, 16.11.06, 18.12.01 >Reporter: Jacques Le Roux >Assignee: Jacques Le Roux >Priority: Blocker > Fix For: 17.12.01 > > Attachments: OFBIZ-10145-gradlew.patch, init-gradle-wrapper-R16.sh, > init-gradle-wrapper-trunk-and-18.sh, init-gradle-wrapper-trunk-and-18.sh, > init-gradle-wrapper-trunk-and-18.sh, init-gradle-wrapper-trunk-and-18.sh, > init-gradle-wrapper.ps1, init-gradle-wrapper.sh, init-gradle-wrapper.sh, > init-gradle-wrapper.sh, init-gradle-wrapper.sh, init-gradle-wrapper.sh, > init-gradlew-readme-R16.patch, init-gradlew-readme-R17.1.patch, > init-gradlew-readme-R17.1.patch, init-gradlew-readme.patch, > init-gradlew-readme.patch > > > Following the discussion at http://markmail.org/message/nd7grfiyobjkfwae, > considering LEGAL-288 and based on a lazy consensus on dev ML, we want to > remove the gradle-wrapper.jar file from the next packaged releases and use > [~jacopoc]'s related proposition to document how to have Gradle working in > the main README.md file. > # Extract the archive file to your local directory. > # Download gradle-wrapper.jar and place it in the > OFBiz-root-dir/gradle/wrapper folder. > I'm not sure if we should recommend a link to download the > gradle-wrapper.jar. This might change in the future (versions, etc.), so > indeed maybe simply asking to download is enough, cf > https://www.google.com/search?q=gradle-wrapper.jar+download=UTF-8 > Also we need to add a point about removing gradle-wrapper.jar in > https://cwiki.apache.org/confluence/display/OFBIZ/Release+Management+Guide+for+OFBiz -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-10145) Remove the Gradle wrapper from our release packages and add a step to our build notes
[
https://issues.apache.org/jira/browse/OFBIZ-10145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16858033#comment-16858033
]
Jacques Le Roux commented on OFBIZ-10145:
-
The work on Buildbot is done. I simply used {{wget}} to copy the Gradle Wrapper
files from tools repo. We will now need to test with the Wrapper removed,
should not be an issue, I used the -N wget parameter.
I finally thought about a Windows Powershell version of init-gradle-wrapper.sh,
by using the wrapper files in tools to handle the init. So, alike in Buildbot,
to get the wraper files I'll basically use something like:
{code:java}
if (! (Test-Path -Path ((Get-Item -Path ".\").FullName + "\gradle\"))) {
Write-Host "Location seems to be incorrect, please run the 'sh
gradle/init-gradle-wrapper.ps1' script from Apache OFBiz root.";
exit
}
# This uses PowerShell Invoke-WebRequest command (aliased as wget here)
# https is not used because we don't want users to be asked for a credential
(not sure about that, maybe https is OK)
wget -outf gradle\wrapper\gradle-wrapper.jar
http://svn.apache.org/repos/asf/ofbiz/tools/Buildbot/Gradle/Wrapper/trunk/gradle-wrapper.jar
wget -outf gradle\wrapper\gradle-wrapper.properties
http://svn.apache.org/repos/asf/ofbiz/tools/Buildbot/Gradle/Wrapper/trunk/gradle-wrapper.properties
{code}
[We can indeed easily load Gradle this
way|https://docs.gradle.org/current/userguide/gradle_wrapper.html]:
bq. The Wrapper is a script that invokes a declared version of Gradle,
downloading it beforehand if necessary.
I suggest we simplify init-gradle-wrapper.sh using the same idea. That's also
what the Wrapper is for after all.
Of course when upgrading Gradle in trunk we will need to update the files in
trunk tools repo. Only trunk because the Gradle version is freezed in releases
branches.
I even thought about hacking the gradlew scripts, then we would not need
init-gradle-wrapper at all. But those are generated with Gradle installation
and better keep them as delivered by Gradle.
Here is the Powershell script: [^init-gradle-wrapper.ps1]
> Remove the Gradle wrapper from our release packages and add a step to our
> build notes
> -
>
> Key: OFBIZ-10145
> URL: https://issues.apache.org/jira/browse/OFBIZ-10145
> Project: OFBiz
> Issue Type: Task
> Components: Gradle
>Affects Versions: 17.12.01, 16.11.06, 18.12.01
>Reporter: Jacques Le Roux
>Assignee: Jacques Le Roux
>Priority: Blocker
> Fix For: 17.12.01
>
> Attachments: OFBIZ-10145-gradlew.patch, init-gradle-wrapper-R16.sh,
> init-gradle-wrapper-trunk-and-18.sh, init-gradle-wrapper-trunk-and-18.sh,
> init-gradle-wrapper-trunk-and-18.sh, init-gradle-wrapper-trunk-and-18.sh,
> init-gradle-wrapper.ps1, init-gradle-wrapper.sh, init-gradle-wrapper.sh,
> init-gradle-wrapper.sh, init-gradle-wrapper.sh, init-gradle-wrapper.sh,
> init-gradlew-readme-R16.patch, init-gradlew-readme-R17.1.patch,
> init-gradlew-readme-R17.1.patch, init-gradlew-readme.patch,
> init-gradlew-readme.patch
>
>
> Following the discussion at http://markmail.org/message/nd7grfiyobjkfwae,
> considering LEGAL-288 and based on a lazy consensus on dev ML, we want to
> remove the gradle-wrapper.jar file from the next packaged releases and use
> [~jacopoc]'s related proposition to document how to have Gradle working in
> the main README.md file.
> # Extract the archive file to your local directory.
> # Download gradle-wrapper.jar and place it in the
> OFBiz-root-dir/gradle/wrapper folder.
> I'm not sure if we should recommend a link to download the
> gradle-wrapper.jar. This might change in the future (versions, etc.), so
> indeed maybe simply asking to download is enough, cf
> https://www.google.com/search?q=gradle-wrapper.jar+download=UTF-8
> Also we need to add a point about removing gradle-wrapper.jar in
> https://cwiki.apache.org/confluence/display/OFBIZ/Release+Management+Guide+for+OFBiz
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (OFBIZ-10145) Remove the Gradle wrapper from our release packages and add a step to our build notes
[ https://issues.apache.org/jira/browse/OFBIZ-10145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16857454#comment-16857454 ] Swapnil M Mane commented on OFBIZ-10145: Thank you [~jacopoc] for your comment. Hello team, We are using Gradle version 2.13 in R16. Added the [^init-gradle-wrapper-R16.sh] script for the same. I have tested it on my machine and everything is working expected. Also, markdown is used R16, update the README.md README.md.html files [^init-gradlew-readme-R16.patch] with the instruction. (Thanks [~jacques.le.roux] for your help in this) Please have a look. Thanks! > Remove the Gradle wrapper from our release packages and add a step to our > build notes > - > > Key: OFBIZ-10145 > URL: https://issues.apache.org/jira/browse/OFBIZ-10145 > Project: OFBiz > Issue Type: Task > Components: Gradle >Affects Versions: 17.12.01, 16.11.06, 18.12.01 >Reporter: Jacques Le Roux >Assignee: Jacques Le Roux >Priority: Blocker > Fix For: 17.12.01 > > Attachments: OFBIZ-10145-gradlew.patch, init-gradle-wrapper-R16.sh, > init-gradle-wrapper-trunk-and-18.sh, init-gradle-wrapper-trunk-and-18.sh, > init-gradle-wrapper-trunk-and-18.sh, init-gradle-wrapper-trunk-and-18.sh, > init-gradle-wrapper.sh, init-gradle-wrapper.sh, init-gradle-wrapper.sh, > init-gradle-wrapper.sh, init-gradle-wrapper.sh, > init-gradlew-readme-R16.patch, init-gradlew-readme-R17.1.patch, > init-gradlew-readme-R17.1.patch, init-gradlew-readme.patch, > init-gradlew-readme.patch > > > Following the discussion at http://markmail.org/message/nd7grfiyobjkfwae, > considering LEGAL-288 and based on a lazy consensus on dev ML, we want to > remove the gradle-wrapper.jar file from the next packaged releases and use > [~jacopoc]'s related proposition to document how to have Gradle working in > the main README.md file. > # Extract the archive file to your local directory. > # Download gradle-wrapper.jar and place it in the > OFBiz-root-dir/gradle/wrapper folder. > I'm not sure if we should recommend a link to download the > gradle-wrapper.jar. This might change in the future (versions, etc.), so > indeed maybe simply asking to download is enough, cf > https://www.google.com/search?q=gradle-wrapper.jar+download=UTF-8 > Also we need to add a point about removing gradle-wrapper.jar in > https://cwiki.apache.org/confluence/display/OFBIZ/Release+Management+Guide+for+OFBiz -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-10145) Remove the Gradle wrapper from our release packages and add a step to our build notes
[ https://issues.apache.org/jira/browse/OFBIZ-10145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16856779#comment-16856779 ] Jacques Le Roux commented on OFBIZ-10145: - Hi Jacopo, Yes indeed, this is part of the plan. BTW, I begin to work on the ofbiz.conf (Buildbot Script) > Remove the Gradle wrapper from our release packages and add a step to our > build notes > - > > Key: OFBIZ-10145 > URL: https://issues.apache.org/jira/browse/OFBIZ-10145 > Project: OFBiz > Issue Type: Task > Components: Gradle >Affects Versions: 17.12.01, 16.11.06, 18.12.01 >Reporter: Jacques Le Roux >Assignee: Jacques Le Roux >Priority: Blocker > Fix For: 17.12.01 > > Attachments: OFBIZ-10145-gradlew.patch, > init-gradle-wrapper-trunk-and-18.sh, init-gradle-wrapper-trunk-and-18.sh, > init-gradle-wrapper-trunk-and-18.sh, init-gradle-wrapper-trunk-and-18.sh, > init-gradle-wrapper.sh, init-gradle-wrapper.sh, init-gradle-wrapper.sh, > init-gradle-wrapper.sh, init-gradle-wrapper.sh, > init-gradlew-readme-R17.1.patch, init-gradlew-readme-R17.1.patch, > init-gradlew-readme.patch, init-gradlew-readme.patch > > > Following the discussion at http://markmail.org/message/nd7grfiyobjkfwae, > considering LEGAL-288 and based on a lazy consensus on dev ML, we want to > remove the gradle-wrapper.jar file from the next packaged releases and use > [~jacopoc]'s related proposition to document how to have Gradle working in > the main README.md file. > # Extract the archive file to your local directory. > # Download gradle-wrapper.jar and place it in the > OFBiz-root-dir/gradle/wrapper folder. > I'm not sure if we should recommend a link to download the > gradle-wrapper.jar. This might change in the future (versions, etc.), so > indeed maybe simply asking to download is enough, cf > https://www.google.com/search?q=gradle-wrapper.jar+download=UTF-8 > Also we need to add a point about removing gradle-wrapper.jar in > https://cwiki.apache.org/confluence/display/OFBIZ/Release+Management+Guide+for+OFBiz -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-10145) Remove the Gradle wrapper from our release packages and add a step to our build notes
[ https://issues.apache.org/jira/browse/OFBIZ-10145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16856421#comment-16856421 ] Jacopo Cappellato commented on OFBIZ-10145: --- The proposed solution looks great to me, thank you all. I would like to mention that soon we will probably publish a new release from 16.11 and for this reason we will need to backport this solution also to that branch. > Remove the Gradle wrapper from our release packages and add a step to our > build notes > - > > Key: OFBIZ-10145 > URL: https://issues.apache.org/jira/browse/OFBIZ-10145 > Project: OFBiz > Issue Type: Task > Components: Gradle >Affects Versions: 17.12.01, 16.11.06, 18.12.01 >Reporter: Jacques Le Roux >Assignee: Jacques Le Roux >Priority: Blocker > Fix For: 17.12.01 > > Attachments: OFBIZ-10145-gradlew.patch, > init-gradle-wrapper-trunk-and-18.sh, init-gradle-wrapper-trunk-and-18.sh, > init-gradle-wrapper-trunk-and-18.sh, init-gradle-wrapper-trunk-and-18.sh, > init-gradle-wrapper.sh, init-gradle-wrapper.sh, init-gradle-wrapper.sh, > init-gradle-wrapper.sh, init-gradle-wrapper.sh, > init-gradlew-readme-R17.1.patch, init-gradlew-readme-R17.1.patch, > init-gradlew-readme.patch, init-gradlew-readme.patch > > > Following the discussion at http://markmail.org/message/nd7grfiyobjkfwae, > considering LEGAL-288 and based on a lazy consensus on dev ML, we want to > remove the gradle-wrapper.jar file from the next packaged releases and use > [~jacopoc]'s related proposition to document how to have Gradle working in > the main README.md file. > # Extract the archive file to your local directory. > # Download gradle-wrapper.jar and place it in the > OFBiz-root-dir/gradle/wrapper folder. > I'm not sure if we should recommend a link to download the > gradle-wrapper.jar. This might change in the future (versions, etc.), so > indeed maybe simply asking to download is enough, cf > https://www.google.com/search?q=gradle-wrapper.jar+download=UTF-8 > Also we need to add a point about removing gradle-wrapper.jar in > https://cwiki.apache.org/confluence/display/OFBIZ/Release+Management+Guide+for+OFBiz -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-10145) Remove the Gradle wrapper from our release packages and add a step to our build notes
[
https://issues.apache.org/jira/browse/OFBIZ-10145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16854300#comment-16854300
]
Nicolas Malin commented on OFBIZ-10145:
---
Yes I make a mistake in my mind, gradlew isn't a binary ^^. Based on this new
analyse for me, I updated [^OFBIZ-10145-gradlew.patch] for gradlew, now to
start ofbiz the first time just './gradlew' like previously.
For demo I will change like this
{code}checkGradlew () {
if [ -d "$OFBIZ_DIR/gradle" ]; then
if [ ! -d "$OFBIZ_DIR/gradle/wrapper" ]; then
ln -s gradle/$2/gradle/wrapper $OFBIZ_DIR/gradle/wrapper
fi
fi
}
{code}
simple and easy :)
for buildbot, I dont' know yet
> Remove the Gradle wrapper from our release packages and add a step to our
> build notes
> -
>
> Key: OFBIZ-10145
> URL: https://issues.apache.org/jira/browse/OFBIZ-10145
> Project: OFBiz
> Issue Type: Task
> Components: Gradle
>Affects Versions: 17.12.01, 16.11.06, 18.12.01
>Reporter: Jacques Le Roux
>Assignee: Jacques Le Roux
>Priority: Blocker
> Fix For: 17.12.01
>
> Attachments: OFBIZ-10145-gradlew.patch,
> init-gradle-wrapper-trunk-and-18.sh, init-gradle-wrapper-trunk-and-18.sh,
> init-gradle-wrapper-trunk-and-18.sh, init-gradle-wrapper-trunk-and-18.sh,
> init-gradle-wrapper.sh, init-gradle-wrapper.sh, init-gradle-wrapper.sh,
> init-gradle-wrapper.sh, init-gradle-wrapper.sh,
> init-gradlew-readme-R17.1.patch, init-gradlew-readme-R17.1.patch,
> init-gradlew-readme.patch, init-gradlew-readme.patch
>
>
> Following the discussion at http://markmail.org/message/nd7grfiyobjkfwae,
> considering LEGAL-288 and based on a lazy consensus on dev ML, we want to
> remove the gradle-wrapper.jar file from the next packaged releases and use
> [~jacopoc]'s related proposition to document how to have Gradle working in
> the main README.md file.
> # Extract the archive file to your local directory.
> # Download gradle-wrapper.jar and place it in the
> OFBiz-root-dir/gradle/wrapper folder.
> I'm not sure if we should recommend a link to download the
> gradle-wrapper.jar. This might change in the future (versions, etc.), so
> indeed maybe simply asking to download is enough, cf
> https://www.google.com/search?q=gradle-wrapper.jar+download=UTF-8
> Also we need to add a point about removing gradle-wrapper.jar in
> https://cwiki.apache.org/confluence/display/OFBIZ/Release+Management+Guide+for+OFBiz
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (OFBIZ-10145) Remove the Gradle wrapper from our release packages and add a step to our build notes
[ https://issues.apache.org/jira/browse/OFBIZ-10145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16854299#comment-16854299 ] Swapnil M Mane commented on OFBIZ-10145: Hi [~jacques.le.roux], I liked the idea :) > Remove the Gradle wrapper from our release packages and add a step to our > build notes > - > > Key: OFBIZ-10145 > URL: https://issues.apache.org/jira/browse/OFBIZ-10145 > Project: OFBiz > Issue Type: Task > Components: Gradle >Affects Versions: 17.12.01, 16.11.06, 18.12.01 >Reporter: Jacques Le Roux >Assignee: Jacques Le Roux >Priority: Blocker > Fix For: 17.12.01 > > Attachments: init-gradle-wrapper-trunk-and-18.sh, > init-gradle-wrapper-trunk-and-18.sh, init-gradle-wrapper-trunk-and-18.sh, > init-gradle-wrapper-trunk-and-18.sh, init-gradle-wrapper.sh, > init-gradle-wrapper.sh, init-gradle-wrapper.sh, init-gradle-wrapper.sh, > init-gradle-wrapper.sh, init-gradlew-readme-R17.1.patch, > init-gradlew-readme-R17.1.patch, init-gradlew-readme.patch, > init-gradlew-readme.patch > > > Following the discussion at http://markmail.org/message/nd7grfiyobjkfwae, > considering LEGAL-288 and based on a lazy consensus on dev ML, we want to > remove the gradle-wrapper.jar file from the next packaged releases and use > [~jacopoc]'s related proposition to document how to have Gradle working in > the main README.md file. > # Extract the archive file to your local directory. > # Download gradle-wrapper.jar and place it in the > OFBiz-root-dir/gradle/wrapper folder. > I'm not sure if we should recommend a link to download the > gradle-wrapper.jar. This might change in the future (versions, etc.), so > indeed maybe simply asking to download is enough, cf > https://www.google.com/search?q=gradle-wrapper.jar+download=UTF-8 > Also we need to add a point about removing gradle-wrapper.jar in > https://cwiki.apache.org/confluence/display/OFBIZ/Release+Management+Guide+for+OFBiz -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-10145) Remove the Gradle wrapper from our release packages and add a step to our build notes
[ https://issues.apache.org/jira/browse/OFBIZ-10145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16853947#comment-16853947 ] Jacques Le Roux commented on OFBIZ-10145: - I had another even simpler idea. Why bother Infra? We can simply copy the OFBiz/gradle/wrapper directory in tools/buildbot/gradle/wrapper and in Buildbot copy it back to its place, et voilà. I have closed INFRA-18530 with more information there, actually copying it here: bq. I forgot that we have Gradle installed in /usr/lib/gradle/ on "lares_ubuntu" , "orcus_ubuntu" , "silvanus_ubuntu" as says INFRA-13202. Actually It's about Gradle to 3.2.1, I guess it's the same for Gradle 5.0. I'll work on https://svn.apache.org/repos/infra/infrastructure/buildbot/aegis/buildmaster/master1/projects/ofbiz.conf soon... > Remove the Gradle wrapper from our release packages and add a step to our > build notes > - > > Key: OFBIZ-10145 > URL: https://issues.apache.org/jira/browse/OFBIZ-10145 > Project: OFBiz > Issue Type: Task > Components: Gradle >Affects Versions: 17.12.01, 16.11.06, 18.12.01 >Reporter: Jacques Le Roux >Assignee: Jacques Le Roux >Priority: Blocker > Fix For: 17.12.01 > > Attachments: init-gradle-wrapper-trunk-and-18.sh, > init-gradle-wrapper-trunk-and-18.sh, init-gradle-wrapper-trunk-and-18.sh, > init-gradle-wrapper-trunk-and-18.sh, init-gradle-wrapper.sh, > init-gradle-wrapper.sh, init-gradle-wrapper.sh, init-gradle-wrapper.sh, > init-gradle-wrapper.sh, init-gradlew-readme-R17.1.patch, > init-gradlew-readme-R17.1.patch, init-gradlew-readme.patch, > init-gradlew-readme.patch > > > Following the discussion at http://markmail.org/message/nd7grfiyobjkfwae, > considering LEGAL-288 and based on a lazy consensus on dev ML, we want to > remove the gradle-wrapper.jar file from the next packaged releases and use > [~jacopoc]'s related proposition to document how to have Gradle working in > the main README.md file. > # Extract the archive file to your local directory. > # Download gradle-wrapper.jar and place it in the > OFBiz-root-dir/gradle/wrapper folder. > I'm not sure if we should recommend a link to download the > gradle-wrapper.jar. This might change in the future (versions, etc.), so > indeed maybe simply asking to download is enough, cf > https://www.google.com/search?q=gradle-wrapper.jar+download=UTF-8 > Also we need to add a point about removing gradle-wrapper.jar in > https://cwiki.apache.org/confluence/display/OFBIZ/Release+Management+Guide+for+OFBiz -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-10145) Remove the Gradle wrapper from our release packages and add a step to our build notes
[
https://issues.apache.org/jira/browse/OFBIZ-10145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16852808#comment-16852808
]
Jacques Le Roux commented on OFBIZ-10145:
-
To clarify after [this discussion on dev
ML|https://markmail.org/message/dbutcovs5jnh2km3]:
Actually the idea is to only remove the gradle/wrapper directory so in
init-gradle-wrapper.sh the test should be on the existence of this directory,
ie:
{{if [ ! -r "$OFBIZ_DIR/gradle/wrapper" ]; then}}
not
{{if [ ! -r "$OFBIZ_DIR/gradlew" ]; then}}
BTW I have updated INFRA-18530 with hopefully a much simpler possible solution
for Buildbot :)
> Remove the Gradle wrapper from our release packages and add a step to our
> build notes
> -
>
> Key: OFBIZ-10145
> URL: https://issues.apache.org/jira/browse/OFBIZ-10145
> Project: OFBiz
> Issue Type: Task
> Components: Gradle
>Affects Versions: 17.12.01, 16.11.06, 18.12.01
>Reporter: Jacques Le Roux
>Assignee: Jacques Le Roux
>Priority: Blocker
> Fix For: 17.12.01
>
> Attachments: init-gradle-wrapper-trunk-and-18.sh,
> init-gradle-wrapper-trunk-and-18.sh, init-gradle-wrapper-trunk-and-18.sh,
> init-gradle-wrapper-trunk-and-18.sh, init-gradle-wrapper.sh,
> init-gradle-wrapper.sh, init-gradle-wrapper.sh, init-gradle-wrapper.sh,
> init-gradle-wrapper.sh, init-gradlew-readme-R17.1.patch,
> init-gradlew-readme-R17.1.patch, init-gradlew-readme.patch,
> init-gradlew-readme.patch
>
>
> Following the discussion at http://markmail.org/message/nd7grfiyobjkfwae,
> considering LEGAL-288 and based on a lazy consensus on dev ML, we want to
> remove the gradle-wrapper.jar file from the next packaged releases and use
> [~jacopoc]'s related proposition to document how to have Gradle working in
> the main README.md file.
> # Extract the archive file to your local directory.
> # Download gradle-wrapper.jar and place it in the
> OFBiz-root-dir/gradle/wrapper folder.
> I'm not sure if we should recommend a link to download the
> gradle-wrapper.jar. This might change in the future (versions, etc.), so
> indeed maybe simply asking to download is enough, cf
> https://www.google.com/search?q=gradle-wrapper.jar+download=UTF-8
> Also we need to add a point about removing gradle-wrapper.jar in
> https://cwiki.apache.org/confluence/display/OFBIZ/Release+Management+Guide+for+OFBiz
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (OFBIZ-10145) Remove the Gradle wrapper from our release packages and add a step to our build notes
[ https://issues.apache.org/jira/browse/OFBIZ-10145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16851710#comment-16851710 ] Jacques Le Roux commented on OFBIZ-10145: - Thinking about it, I don't remember if we have access to Internet from Buildbot. Also it would be a pity to have to dowload Gradle for EACH build. I creaed INFRA-18530 for that... > Remove the Gradle wrapper from our release packages and add a step to our > build notes > - > > Key: OFBIZ-10145 > URL: https://issues.apache.org/jira/browse/OFBIZ-10145 > Project: OFBiz > Issue Type: Task > Components: Gradle >Affects Versions: 17.12.01, 16.11.06, 18.12.01 >Reporter: Jacques Le Roux >Assignee: Jacques Le Roux >Priority: Blocker > Fix For: 17.12.01 > > Attachments: init-gradle-wrapper-trunk-and-18.sh, > init-gradle-wrapper-trunk-and-18.sh, init-gradle-wrapper-trunk-and-18.sh, > init-gradle-wrapper-trunk-and-18.sh, init-gradle-wrapper.sh, > init-gradle-wrapper.sh, init-gradle-wrapper.sh, init-gradle-wrapper.sh, > init-gradle-wrapper.sh, init-gradlew-readme-R17.1.patch, > init-gradlew-readme-R17.1.patch, init-gradlew-readme.patch, > init-gradlew-readme.patch > > > Following the discussion at http://markmail.org/message/nd7grfiyobjkfwae, > considering LEGAL-288 and based on a lazy consensus on dev ML, we want to > remove the gradle-wrapper.jar file from the next packaged releases and use > [~jacopoc]'s related proposition to document how to have Gradle working in > the main README.md file. > # Extract the archive file to your local directory. > # Download gradle-wrapper.jar and place it in the > OFBiz-root-dir/gradle/wrapper folder. > I'm not sure if we should recommend a link to download the > gradle-wrapper.jar. This might change in the future (versions, etc.), so > indeed maybe simply asking to download is enough, cf > https://www.google.com/search?q=gradle-wrapper.jar+download=UTF-8 > Also we need to add a point about removing gradle-wrapper.jar in > https://cwiki.apache.org/confluence/display/OFBIZ/Release+Management+Guide+for+OFBiz -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-10145) Remove the Gradle wrapper from our release packages and add a step to our build notes
[ https://issues.apache.org/jira/browse/OFBIZ-10145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16851579#comment-16851579 ] Jacques Le Roux commented on OFBIZ-10145: - Thanks Nicolas, I must say I hastily made the R17 patch :). For demos, if we "simultaneously" commit your change in trunk.sh from r1859876 it should be OK. For Buildbot, I have indeed some work to do, so please wait, thanks... > Remove the Gradle wrapper from our release packages and add a step to our > build notes > - > > Key: OFBIZ-10145 > URL: https://issues.apache.org/jira/browse/OFBIZ-10145 > Project: OFBiz > Issue Type: Task > Components: Gradle >Affects Versions: 17.12.01, 16.11.06, 18.12.01 >Reporter: Jacques Le Roux >Assignee: Jacques Le Roux >Priority: Blocker > Fix For: 17.12.01 > > Attachments: init-gradle-wrapper-trunk-and-18.sh, > init-gradle-wrapper-trunk-and-18.sh, init-gradle-wrapper-trunk-and-18.sh, > init-gradle-wrapper-trunk-and-18.sh, init-gradle-wrapper.sh, > init-gradle-wrapper.sh, init-gradle-wrapper.sh, init-gradle-wrapper.sh, > init-gradle-wrapper.sh, init-gradlew-readme-R17.1.patch, > init-gradlew-readme-R17.1.patch, init-gradlew-readme.patch, > init-gradlew-readme.patch > > > Following the discussion at http://markmail.org/message/nd7grfiyobjkfwae, > considering LEGAL-288 and based on a lazy consensus on dev ML, we want to > remove the gradle-wrapper.jar file from the next packaged releases and use > [~jacopoc]'s related proposition to document how to have Gradle working in > the main README.md file. > # Extract the archive file to your local directory. > # Download gradle-wrapper.jar and place it in the > OFBiz-root-dir/gradle/wrapper folder. > I'm not sure if we should recommend a link to download the > gradle-wrapper.jar. This might change in the future (versions, etc.), so > indeed maybe simply asking to download is enough, cf > https://www.google.com/search?q=gradle-wrapper.jar+download=UTF-8 > Also we need to add a point about removing gradle-wrapper.jar in > https://cwiki.apache.org/confluence/display/OFBIZ/Release+Management+Guide+for+OFBiz -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-10145) Remove the Gradle wrapper from our release packages and add a step to our build notes
[ https://issues.apache.org/jira/browse/OFBIZ-10145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16851286#comment-16851286 ] Nicolas Malin commented on OFBIZ-10145: --- I corrected some link with the gradle version on [^init-gradlew-readme-R17.1.patch] Just before, If I understand, when I will commit, all build bot on trunk, 18 and 17 will be failed ? Do we need update them before or after ? > Remove the Gradle wrapper from our release packages and add a step to our > build notes > - > > Key: OFBIZ-10145 > URL: https://issues.apache.org/jira/browse/OFBIZ-10145 > Project: OFBiz > Issue Type: Task > Components: Gradle >Affects Versions: 17.12.01, 16.11.06, 18.12.01 >Reporter: Jacques Le Roux >Assignee: Jacques Le Roux >Priority: Blocker > Fix For: 17.12.01 > > Attachments: init-gradle-wrapper-trunk-and-18.sh, > init-gradle-wrapper-trunk-and-18.sh, init-gradle-wrapper-trunk-and-18.sh, > init-gradle-wrapper-trunk-and-18.sh, init-gradle-wrapper.sh, > init-gradle-wrapper.sh, init-gradle-wrapper.sh, init-gradle-wrapper.sh, > init-gradle-wrapper.sh, init-gradlew-readme-R17.1.patch, > init-gradlew-readme-R17.1.patch, init-gradlew-readme.patch, > init-gradlew-readme.patch > > > Following the discussion at http://markmail.org/message/nd7grfiyobjkfwae, > considering LEGAL-288 and based on a lazy consensus on dev ML, we want to > remove the gradle-wrapper.jar file from the next packaged releases and use > [~jacopoc]'s related proposition to document how to have Gradle working in > the main README.md file. > # Extract the archive file to your local directory. > # Download gradle-wrapper.jar and place it in the > OFBiz-root-dir/gradle/wrapper folder. > I'm not sure if we should recommend a link to download the > gradle-wrapper.jar. This might change in the future (versions, etc.), so > indeed maybe simply asking to download is enough, cf > https://www.google.com/search?q=gradle-wrapper.jar+download=UTF-8 > Also we need to add a point about removing gradle-wrapper.jar in > https://cwiki.apache.org/confluence/display/OFBIZ/Release+Management+Guide+for+OFBiz -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-10145) Remove the Gradle wrapper from our release packages and add a step to our build notes
[ https://issues.apache.org/jira/browse/OFBIZ-10145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16850793#comment-16850793 ] Swapnil M Mane commented on OFBIZ-10145: +1, thanks! > Remove the Gradle wrapper from our release packages and add a step to our > build notes > - > > Key: OFBIZ-10145 > URL: https://issues.apache.org/jira/browse/OFBIZ-10145 > Project: OFBiz > Issue Type: Task > Components: Gradle >Affects Versions: 17.12.01, 16.11.06, 18.12.01 >Reporter: Jacques Le Roux >Assignee: Jacques Le Roux >Priority: Blocker > Fix For: 17.12.01 > > Attachments: init-gradle-wrapper-trunk-and-18.sh, > init-gradle-wrapper-trunk-and-18.sh, init-gradle-wrapper-trunk-and-18.sh, > init-gradle-wrapper-trunk-and-18.sh, init-gradle-wrapper.sh, > init-gradle-wrapper.sh, init-gradle-wrapper.sh, init-gradle-wrapper.sh, > init-gradle-wrapper.sh, init-gradlew-readme-R17.1.patch, > init-gradlew-readme.patch, init-gradlew-readme.patch > > > Following the discussion at http://markmail.org/message/nd7grfiyobjkfwae, > considering LEGAL-288 and based on a lazy consensus on dev ML, we want to > remove the gradle-wrapper.jar file from the next packaged releases and use > [~jacopoc]'s related proposition to document how to have Gradle working in > the main README.md file. > # Extract the archive file to your local directory. > # Download gradle-wrapper.jar and place it in the > OFBiz-root-dir/gradle/wrapper folder. > I'm not sure if we should recommend a link to download the > gradle-wrapper.jar. This might change in the future (versions, etc.), so > indeed maybe simply asking to download is enough, cf > https://www.google.com/search?q=gradle-wrapper.jar+download=UTF-8 > Also we need to add a point about removing gradle-wrapper.jar in > https://cwiki.apache.org/confluence/display/OFBIZ/Release+Management+Guide+for+OFBiz -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-10145) Remove the Gradle wrapper from our release packages and add a step to our build notes
[ https://issues.apache.org/jira/browse/OFBIZ-10145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16850771#comment-16850771 ] Nicolas Malin commented on OFBIZ-10145: --- Ok thanks [~jacques.le.roux], I will commit soon > Remove the Gradle wrapper from our release packages and add a step to our > build notes > - > > Key: OFBIZ-10145 > URL: https://issues.apache.org/jira/browse/OFBIZ-10145 > Project: OFBiz > Issue Type: Task > Components: Gradle >Affects Versions: 17.12.01, 16.11.06, 18.12.01 >Reporter: Jacques Le Roux >Assignee: Jacques Le Roux >Priority: Blocker > Fix For: 17.12.01 > > Attachments: init-gradle-wrapper-trunk-and-18.sh, > init-gradle-wrapper-trunk-and-18.sh, init-gradle-wrapper-trunk-and-18.sh, > init-gradle-wrapper-trunk-and-18.sh, init-gradle-wrapper.sh, > init-gradle-wrapper.sh, init-gradle-wrapper.sh, init-gradle-wrapper.sh, > init-gradle-wrapper.sh, init-gradlew-readme-R17.1.patch, > init-gradlew-readme.patch, init-gradlew-readme.patch > > > Following the discussion at http://markmail.org/message/nd7grfiyobjkfwae, > considering LEGAL-288 and based on a lazy consensus on dev ML, we want to > remove the gradle-wrapper.jar file from the next packaged releases and use > [~jacopoc]'s related proposition to document how to have Gradle working in > the main README.md file. > # Extract the archive file to your local directory. > # Download gradle-wrapper.jar and place it in the > OFBiz-root-dir/gradle/wrapper folder. > I'm not sure if we should recommend a link to download the > gradle-wrapper.jar. This might change in the future (versions, etc.), so > indeed maybe simply asking to download is enough, cf > https://www.google.com/search?q=gradle-wrapper.jar+download=UTF-8 > Also we need to add a point about removing gradle-wrapper.jar in > https://cwiki.apache.org/confluence/display/OFBIZ/Release+Management+Guide+for+OFBiz -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-10145) Remove the Gradle wrapper from our release packages and add a step to our build notes
[ https://issues.apache.org/jira/browse/OFBIZ-10145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16850722#comment-16850722 ] Jacques Le Roux commented on OFBIZ-10145: - OK, I have updated [^init-gradlew-readme.patch] and created [^init-gradlew-readme-R17.1.patch] . For now it's the official way for Windows as long as nobody provides a init-gradle-wrapper.bat (or init-gradle-wrapper.ps1) file I think we are ready, aren't we? > Remove the Gradle wrapper from our release packages and add a step to our > build notes > - > > Key: OFBIZ-10145 > URL: https://issues.apache.org/jira/browse/OFBIZ-10145 > Project: OFBiz > Issue Type: Task > Components: Gradle >Affects Versions: 17.12.01, 16.11.06, 18.12.01 >Reporter: Jacques Le Roux >Assignee: Jacques Le Roux >Priority: Blocker > Fix For: 17.12.01 > > Attachments: init-gradle-wrapper-trunk-and-18.sh, > init-gradle-wrapper-trunk-and-18.sh, init-gradle-wrapper-trunk-and-18.sh, > init-gradle-wrapper-trunk-and-18.sh, init-gradle-wrapper.sh, > init-gradle-wrapper.sh, init-gradle-wrapper.sh, init-gradle-wrapper.sh, > init-gradle-wrapper.sh, init-gradlew-readme-R17.1.patch, > init-gradlew-readme.patch, init-gradlew-readme.patch > > > Following the discussion at http://markmail.org/message/nd7grfiyobjkfwae, > considering LEGAL-288 and based on a lazy consensus on dev ML, we want to > remove the gradle-wrapper.jar file from the next packaged releases and use > [~jacopoc]'s related proposition to document how to have Gradle working in > the main README.md file. > # Extract the archive file to your local directory. > # Download gradle-wrapper.jar and place it in the > OFBiz-root-dir/gradle/wrapper folder. > I'm not sure if we should recommend a link to download the > gradle-wrapper.jar. This might change in the future (versions, etc.), so > indeed maybe simply asking to download is enough, cf > https://www.google.com/search?q=gradle-wrapper.jar+download=UTF-8 > Also we need to add a point about removing gradle-wrapper.jar in > https://cwiki.apache.org/confluence/display/OFBIZ/Release+Management+Guide+for+OFBiz -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-10145) Remove the Gradle wrapper from our release packages and add a step to our build notes
[ https://issues.apache.org/jira/browse/OFBIZ-10145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16849460#comment-16849460 ] Swapnil M Mane commented on OFBIZ-10145: Thank you [~soledad], looks good to me! > Remove the Gradle wrapper from our release packages and add a step to our > build notes > - > > Key: OFBIZ-10145 > URL: https://issues.apache.org/jira/browse/OFBIZ-10145 > Project: OFBiz > Issue Type: Task > Components: Gradle >Affects Versions: 17.12.01, 16.11.06, 18.12.01 >Reporter: Jacques Le Roux >Assignee: Jacques Le Roux >Priority: Blocker > Fix For: 17.12.01 > > Attachments: init-gradle-wrapper-trunk-and-18.sh, > init-gradle-wrapper-trunk-and-18.sh, init-gradle-wrapper-trunk-and-18.sh, > init-gradle-wrapper-trunk-and-18.sh, init-gradle-wrapper.sh, > init-gradle-wrapper.sh, init-gradle-wrapper.sh, init-gradle-wrapper.sh, > init-gradle-wrapper.sh, init-gradlew-readme.patch > > > Following the discussion at http://markmail.org/message/nd7grfiyobjkfwae, > considering LEGAL-288 and based on a lazy consensus on dev ML, we want to > remove the gradle-wrapper.jar file from the next packaged releases and use > [~jacopoc]'s related proposition to document how to have Gradle working in > the main README.md file. > # Extract the archive file to your local directory. > # Download gradle-wrapper.jar and place it in the > OFBiz-root-dir/gradle/wrapper folder. > I'm not sure if we should recommend a link to download the > gradle-wrapper.jar. This might change in the future (versions, etc.), so > indeed maybe simply asking to download is enough, cf > https://www.google.com/search?q=gradle-wrapper.jar+download=UTF-8 > Also we need to add a point about removing gradle-wrapper.jar in > https://cwiki.apache.org/confluence/display/OFBIZ/Release+Management+Guide+for+OFBiz -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-10145) Remove the Gradle wrapper from our release packages and add a step to our build notes
[ https://issues.apache.org/jira/browse/OFBIZ-10145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16849449#comment-16849449 ] Nicolas Malin commented on OFBIZ-10145: --- Ok [~swapnilmmane] it's done for me I just update the error message with the good gradle version > Remove the Gradle wrapper from our release packages and add a step to our > build notes > - > > Key: OFBIZ-10145 > URL: https://issues.apache.org/jira/browse/OFBIZ-10145 > Project: OFBiz > Issue Type: Task > Components: Gradle >Affects Versions: 17.12.01, 16.11.06, 18.12.01 >Reporter: Jacques Le Roux >Assignee: Jacques Le Roux >Priority: Blocker > Fix For: 17.12.01 > > Attachments: init-gradle-wrapper-trunk-and-18.sh, > init-gradle-wrapper-trunk-and-18.sh, init-gradle-wrapper-trunk-and-18.sh, > init-gradle-wrapper-trunk-and-18.sh, init-gradle-wrapper.sh, > init-gradle-wrapper.sh, init-gradle-wrapper.sh, init-gradle-wrapper.sh, > init-gradle-wrapper.sh, init-gradlew-readme.patch > > > Following the discussion at http://markmail.org/message/nd7grfiyobjkfwae, > considering LEGAL-288 and based on a lazy consensus on dev ML, we want to > remove the gradle-wrapper.jar file from the next packaged releases and use > [~jacopoc]'s related proposition to document how to have Gradle working in > the main README.md file. > # Extract the archive file to your local directory. > # Download gradle-wrapper.jar and place it in the > OFBiz-root-dir/gradle/wrapper folder. > I'm not sure if we should recommend a link to download the > gradle-wrapper.jar. This might change in the future (versions, etc.), so > indeed maybe simply asking to download is enough, cf > https://www.google.com/search?q=gradle-wrapper.jar+download=UTF-8 > Also we need to add a point about removing gradle-wrapper.jar in > https://cwiki.apache.org/confluence/display/OFBIZ/Release+Management+Guide+for+OFBiz -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-10145) Remove the Gradle wrapper from our release packages and add a step to our build notes
[
https://issues.apache.org/jira/browse/OFBIZ-10145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16848625#comment-16848625
]
Swapnil M Mane commented on OFBIZ-10145:
Thanks [~jacques.le.roux], you are correct for R17 Gradle release should be
3.2.1 (I have done the suggested change in script and uploaded it again)
Hello [~soledad] and team,
I have done the following changes in script, please have a look
1.) Since we are putting the script at location $OFBIZ_HOME/gradle, I have
changed the GRADLE_WRAPPER_OFBIZ_PATH from
{code:java}
$OFBIZ_HOME/gradle/wrapper/{code}
to
{code:java}
$OFBIZ_HOME/gradle/{code}
otherwise script was giving the message "Location seems to be incorrect",
even when run from OFBiz root.
2.) Changed the Gradle release to 3.2.1 for R17.
3.) Done some improvements in messages which is to be shown to the user.
Please have a look and let me know your thoughts.
Thanks!
> Remove the Gradle wrapper from our release packages and add a step to our
> build notes
> -
>
> Key: OFBIZ-10145
> URL: https://issues.apache.org/jira/browse/OFBIZ-10145
> Project: OFBiz
> Issue Type: Task
> Components: Gradle
>Affects Versions: 17.12.01, 16.11.06, 18.12.01
>Reporter: Jacques Le Roux
>Assignee: Nicolas Malin
>Priority: Blocker
> Fix For: 17.12.01
>
> Attachments: init-gradle-wrapper-trunk-and-18.sh,
> init-gradle-wrapper-trunk-and-18.sh, init-gradle-wrapper-trunk-and-18.sh,
> init-gradle-wrapper.sh, init-gradle-wrapper.sh, init-gradle-wrapper.sh,
> init-gradle-wrapper.sh, init-gradlew-readme.patch
>
>
> Following the discussion at http://markmail.org/message/nd7grfiyobjkfwae,
> considering LEGAL-288 and based on a lazy consensus on dev ML, we want to
> remove the gradle-wrapper.jar file from the next packaged releases and use
> [~jacopoc]'s related proposition to document how to have Gradle working in
> the main README.md file.
> # Extract the archive file to your local directory.
> # Download gradle-wrapper.jar and place it in the
> OFBiz-root-dir/gradle/wrapper folder.
> I'm not sure if we should recommend a link to download the
> gradle-wrapper.jar. This might change in the future (versions, etc.), so
> indeed maybe simply asking to download is enough, cf
> https://www.google.com/search?q=gradle-wrapper.jar+download=UTF-8
> Also we need to add a point about removing gradle-wrapper.jar in
> https://cwiki.apache.org/confluence/display/OFBIZ/Release+Management+Guide+for+OFBiz
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (OFBIZ-10145) Remove the Gradle wrapper from our release packages and add a step to our build notes
[ https://issues.apache.org/jira/browse/OFBIZ-10145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16848209#comment-16848209 ] Jacques Le Roux commented on OFBIZ-10145: - Thanks Guys, What is [^init-gradle-wrapper.sh] (the one on top of the list today) for? It seems it should be for R17 but then RELEASE should not be 4.7 but 3.2.1 > Remove the Gradle wrapper from our release packages and add a step to our > build notes > - > > Key: OFBIZ-10145 > URL: https://issues.apache.org/jira/browse/OFBIZ-10145 > Project: OFBiz > Issue Type: Task > Components: Gradle >Affects Versions: 17.12.01, 16.11.06, 18.12.01 >Reporter: Jacques Le Roux >Assignee: Nicolas Malin >Priority: Blocker > Fix For: 17.12.01 > > Attachments: init-gradle-wrapper-trunk-and-18.sh, > init-gradle-wrapper-trunk-and-18.sh, init-gradle-wrapper.sh, > init-gradle-wrapper.sh, init-gradle-wrapper.sh, init-gradlew-readme.patch > > > Following the discussion at http://markmail.org/message/nd7grfiyobjkfwae, > considering LEGAL-288 and based on a lazy consensus on dev ML, we want to > remove the gradle-wrapper.jar file from the next packaged releases and use > [~jacopoc]'s related proposition to document how to have Gradle working in > the main README.md file. > # Extract the archive file to your local directory. > # Download gradle-wrapper.jar and place it in the > OFBiz-root-dir/gradle/wrapper folder. > I'm not sure if we should recommend a link to download the > gradle-wrapper.jar. This might change in the future (versions, etc.), so > indeed maybe simply asking to download is enough, cf > https://www.google.com/search?q=gradle-wrapper.jar+download=UTF-8 > Also we need to add a point about removing gradle-wrapper.jar in > https://cwiki.apache.org/confluence/display/OFBIZ/Release+Management+Guide+for+OFBiz -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-10145) Remove the Gradle wrapper from our release packages and add a step to our build notes
[ https://issues.apache.org/jira/browse/OFBIZ-10145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16847571#comment-16847571 ] Swapnil M Mane commented on OFBIZ-10145: As discussed over the OFBiz Slack chat group, documented the process to initializing gradle wrapper in README.adoc for Linux based OS, please refer init-gradlew-readme.patch file. Added TODO note for MS Windows OS, as time allows [~jacques.le.roux] will help us here, thanks so much Jacques! :) Thanks! > Remove the Gradle wrapper from our release packages and add a step to our > build notes > - > > Key: OFBIZ-10145 > URL: https://issues.apache.org/jira/browse/OFBIZ-10145 > Project: OFBiz > Issue Type: Task > Components: Gradle >Affects Versions: 17.12.01, 16.11.06, 18.12.01 >Reporter: Jacques Le Roux >Assignee: Nicolas Malin >Priority: Blocker > Fix For: 17.12.01 > > Attachments: init-gradle-wrapper-trunk-and-18.sh, > init-gradle-wrapper-trunk-and-18.sh, init-gradle-wrapper.sh, > init-gradle-wrapper.sh, init-gradle-wrapper.sh, init-gradlew-readme.patch > > > Following the discussion at http://markmail.org/message/nd7grfiyobjkfwae, > considering LEGAL-288 and based on a lazy consensus on dev ML, we want to > remove the gradle-wrapper.jar file from the next packaged releases and use > [~jacopoc]'s related proposition to document how to have Gradle working in > the main README.md file. > # Extract the archive file to your local directory. > # Download gradle-wrapper.jar and place it in the > OFBiz-root-dir/gradle/wrapper folder. > I'm not sure if we should recommend a link to download the > gradle-wrapper.jar. This might change in the future (versions, etc.), so > indeed maybe simply asking to download is enough, cf > https://www.google.com/search?q=gradle-wrapper.jar+download=UTF-8 > Also we need to add a point about removing gradle-wrapper.jar in > https://cwiki.apache.org/confluence/display/OFBIZ/Release+Management+Guide+for+OFBiz -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-10145) Remove the Gradle wrapper from our release packages and add a step to our build notes
[ https://issues.apache.org/jira/browse/OFBIZ-10145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16847559#comment-16847559 ] Nicolas Malin commented on OFBIZ-10145: --- I commited at revision r1859876 on ofbiz tools an improvement on support the gradlew init for trunk demo. > Remove the Gradle wrapper from our release packages and add a step to our > build notes > - > > Key: OFBIZ-10145 > URL: https://issues.apache.org/jira/browse/OFBIZ-10145 > Project: OFBiz > Issue Type: Task > Components: Gradle >Affects Versions: 17.12.01, 16.11.06, 18.12.01 >Reporter: Jacques Le Roux >Assignee: Nicolas Malin >Priority: Blocker > Fix For: 17.12.01 > > Attachments: init-gradle-wrapper-trunk-and-18.sh, > init-gradle-wrapper-trunk-and-18.sh, init-gradle-wrapper.sh, > init-gradle-wrapper.sh, init-gradle-wrapper.sh > > > Following the discussion at http://markmail.org/message/nd7grfiyobjkfwae, > considering LEGAL-288 and based on a lazy consensus on dev ML, we want to > remove the gradle-wrapper.jar file from the next packaged releases and use > [~jacopoc]'s related proposition to document how to have Gradle working in > the main README.md file. > # Extract the archive file to your local directory. > # Download gradle-wrapper.jar and place it in the > OFBiz-root-dir/gradle/wrapper folder. > I'm not sure if we should recommend a link to download the > gradle-wrapper.jar. This might change in the future (versions, etc.), so > indeed maybe simply asking to download is enough, cf > https://www.google.com/search?q=gradle-wrapper.jar+download=UTF-8 > Also we need to add a point about removing gradle-wrapper.jar in > https://cwiki.apache.org/confluence/display/OFBIZ/Release+Management+Guide+for+OFBiz -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-10145) Remove the Gradle wrapper from our release packages and add a step to our build notes
[
https://issues.apache.org/jira/browse/OFBIZ-10145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16847378#comment-16847378
]
Swapnil M Mane commented on OFBIZ-10145:
+1 to commit, I have tested both the scripts on trunk and release17. Everything
is working as expected for me.
Thank you [~soledad] for your work and everyone for your comments.
[~soledad]
Just a small improvement, since now we are removing the corrupt archive, we
should change the message
from
{code}
echo "\nThe gradle-5.0-bin.zip file is corrupted.\nPlease remove this file from
$OFBIZ_HOME/runtime/tmp location and run the script again."
{code}
to
{code}
echo "\nThe gradle-5.0-bin.zip file was corrupted thus it is removed from
$OFBIZ_HOME/runtime/tmp location.\nNow please run the script again."
{code}
> Remove the Gradle wrapper from our release packages and add a step to our
> build notes
> -
>
> Key: OFBIZ-10145
> URL: https://issues.apache.org/jira/browse/OFBIZ-10145
> Project: OFBiz
> Issue Type: Task
> Components: Gradle
>Affects Versions: 17.12.01, 16.11.06, 18.12.01
>Reporter: Jacques Le Roux
>Assignee: Nicolas Malin
>Priority: Blocker
> Fix For: 17.12.01
>
> Attachments: init-gradle-wrapper-trunk-and-18.sh,
> init-gradle-wrapper-trunk-and-18.sh, init-gradle-wrapper.sh,
> init-gradle-wrapper.sh, init-gradle-wrapper.sh
>
>
> Following the discussion at http://markmail.org/message/nd7grfiyobjkfwae,
> considering LEGAL-288 and based on a lazy consensus on dev ML, we want to
> remove the gradle-wrapper.jar file from the next packaged releases and use
> [~jacopoc]'s related proposition to document how to have Gradle working in
> the main README.md file.
> # Extract the archive file to your local directory.
> # Download gradle-wrapper.jar and place it in the
> OFBiz-root-dir/gradle/wrapper folder.
> I'm not sure if we should recommend a link to download the
> gradle-wrapper.jar. This might change in the future (versions, etc.), so
> indeed maybe simply asking to download is enough, cf
> https://www.google.com/search?q=gradle-wrapper.jar+download=UTF-8
> Also we need to add a point about removing gradle-wrapper.jar in
> https://cwiki.apache.org/confluence/display/OFBIZ/Release+Management+Guide+for+OFBiz
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (OFBIZ-10145) Remove the Gradle wrapper from our release packages and add a step to our build notes
[
https://issues.apache.org/jira/browse/OFBIZ-10145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16847350#comment-16847350
]
Nicolas Malin commented on OFBIZ-10145:
---
HI [~swapnilmmane] nice return :)
{quote}
So, to fix this, I removed the -b option from whereis command in script.
After this everything works like charm for me.
{quote}
The risk is that you have only documentation or configuration. in this case
{code}
whereIsBinary() {
whereis $1 | grep /
}
{code}
return not empty string
{code}
whereIsBinary() {
whereis -b $1 | grep /
}
{code}
return empty string. But it's a problem if you haven't it under Mac ...
I added your suggest on the script with a delete of corrupt archive before
[^init-gradle-wrapper-trunk-and-18.sh]
if it's ok for you we can commit this on trunk, release18 and release17
> Remove the Gradle wrapper from our release packages and add a step to our
> build notes
> -
>
> Key: OFBIZ-10145
> URL: https://issues.apache.org/jira/browse/OFBIZ-10145
> Project: OFBiz
> Issue Type: Task
> Components: Gradle
>Affects Versions: 17.12.01, 16.11.06, 18.12.01
>Reporter: Jacques Le Roux
>Assignee: Nicolas Malin
>Priority: Blocker
> Fix For: 17.12.01
>
> Attachments: init-gradle-wrapper-trunk-and-18.sh,
> init-gradle-wrapper.sh, init-gradle-wrapper.sh
>
>
> Following the discussion at http://markmail.org/message/nd7grfiyobjkfwae,
> considering LEGAL-288 and based on a lazy consensus on dev ML, we want to
> remove the gradle-wrapper.jar file from the next packaged releases and use
> [~jacopoc]'s related proposition to document how to have Gradle working in
> the main README.md file.
> # Extract the archive file to your local directory.
> # Download gradle-wrapper.jar and place it in the
> OFBiz-root-dir/gradle/wrapper folder.
> I'm not sure if we should recommend a link to download the
> gradle-wrapper.jar. This might change in the future (versions, etc.), so
> indeed maybe simply asking to download is enough, cf
> https://www.google.com/search?q=gradle-wrapper.jar+download=UTF-8
> Also we need to add a point about removing gradle-wrapper.jar in
> https://cwiki.apache.org/confluence/display/OFBIZ/Release+Management+Guide+for+OFBiz
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (OFBIZ-10145) Remove the Gradle wrapper from our release packages and add a step to our build notes
[
https://issues.apache.org/jira/browse/OFBIZ-10145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16829422#comment-16829422
]
Swapnil M Mane commented on OFBIZ-10145:
Thanks, everyone for detailed discussion.
Loved your work [~soledad] ! :)
Here are my inputs and details on minor issue I faced
+*Issue faced:*+
The whereis -b $1 | grep / command in my machine is giving following error
{code:java}
whereis: illegal option -- b
usage: whereis program [...]{code}
I am using Mac, here are details of my OS
*macOS Mojave*
*Version 10.14.3 (18D109)*
I can understand that we used -b to search only for binaries in the script.
I also checked the manual of whereis command on mac using command
{code:java}
man whereis{code}
It also don't show -b option for whereis command on mac. (I know it generally
works for Linux based OS).
So, to fix this, I removed the -b option from whereis command in script.
After this everything works like charm for me.
Is anybody faced the same issue on the Mac?
+*Suggestion/Improvement:*+
When I run the script the first time (after above fix), it starts downloading
gradle. Now before completing the download, I mistakenly stop the downloading
by terminating the download process.
After this, I run the *init-gradle-wrapper-trunk-and-18.sh* script *again*.
But this time I got following error
{code:java}
Archive: gradle-5.0-bin.zip
End-of-central-directory signature not found. Either this file is not
a zipfile, or it constitutes one disk of a multi-part archive. In the
latter case the central directory and zipfile comment will be found on
the last disk(s) of this archive.
unzip: cannot find zipfile directory in one of gradle-5.0-bin.zip or
gradle-5.0-bin.zip.zip, and cannot find gradle-5.0-bin.zip.ZIP, period.
init-gradle-wrapper-trunk-and-18.sh: line 63:
./runtime/tmp/gradle-5.0/bin/gradle: No such file or directory{code}
Since my *gradle-5.0-bin.zip* was corrupted because I stoped the download
process in between.
The command
{code:java}
unzip gradle-5.0-bin.zip{code}
throws the above error.
To fix this, I removed the corrupted file and run the script again,and
everything worked as expected.
We can do an improvement here, after running the command *unzip
gradle-5.0-bin.zip*
If it fails, we can show the message to the user to remove the corrupted file
and run the script again.
Here is suggested code improvement
{code:java}
unzip $GRADLE_ZIP_RELEASE;
if [ $? -eq 0 ]; then
cd ../..
./runtime/tmp/$GRADLE_RELEASE/bin/$CMD_INIT_WRAPPER
else
echo "\nThe gradle-5.0-bin.zip file is corrupted.\nPlease remove this file
from
$OFBIZ_HOME/runtime/tmp location and run the script again."
fi{code}
Please feel free to share your thoughts on this.
Nice work [~soledad] , thanks again!
> Remove the Gradle wrapper from our release packages and add a step to our
> build notes
> -
>
> Key: OFBIZ-10145
> URL: https://issues.apache.org/jira/browse/OFBIZ-10145
> Project: OFBiz
> Issue Type: Task
> Components: Gradle
>Affects Versions: 17.12.01, 16.11.06, 18.12.01
>Reporter: Jacques Le Roux
>Assignee: Jacques Le Roux
>Priority: Blocker
> Fix For: 17.12.01
>
> Attachments: init-gradle-wrapper-trunk-and-18.sh,
> init-gradle-wrapper.sh, init-gradle-wrapper.sh
>
>
> Following the discussion at http://markmail.org/message/nd7grfiyobjkfwae,
> considering LEGAL-288 and based on a lazy consensus on dev ML, we want to
> remove the gradle-wrapper.jar file from the next packaged releases and use
> [~jacopoc]'s related proposition to document how to have Gradle working in
> the main README.md file.
> # Extract the archive file to your local directory.
> # Download gradle-wrapper.jar and place it in the
> OFBiz-root-dir/gradle/wrapper folder.
> I'm not sure if we should recommend a link to download the
> gradle-wrapper.jar. This might change in the future (versions, etc.), so
> indeed maybe simply asking to download is enough, cf
> https://www.google.com/search?q=gradle-wrapper.jar+download=UTF-8
> Also we need to add a point about removing gradle-wrapper.jar in
> https://cwiki.apache.org/confluence/display/OFBIZ/Release+Management+Guide+for+OFBiz
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (OFBIZ-10145) Remove the Gradle wrapper from our release packages and add a step to our build notes
[ https://issues.apache.org/jira/browse/OFBIZ-10145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16764738#comment-16764738 ] Nicolas Malin commented on OFBIZ-10145: --- Hello, I updated the script with a version for 17.12 [^init-gradle-wrapper.sh] and an other for 18.12 and trunk [^init-gradle-wrapper-trunk-and-18.sh] I will check the documentation > Remove the Gradle wrapper from our release packages and add a step to our > build notes > - > > Key: OFBIZ-10145 > URL: https://issues.apache.org/jira/browse/OFBIZ-10145 > Project: OFBiz > Issue Type: Task > Components: Gradle >Affects Versions: 17.12.01 >Reporter: Jacques Le Roux >Assignee: Jacques Le Roux >Priority: Blocker > Fix For: 17.12.01 > > Attachments: init-gradle-wrapper-trunk-and-18.sh, > init-gradle-wrapper.sh, init-gradle-wrapper.sh > > > Following the discussion at http://markmail.org/message/nd7grfiyobjkfwae, > considering LEGAL-288 and based on a lazy consensus on dev ML, we want to > remove the gradle-wrapper.jar file from the next packaged releases and use > [~jacopoc]'s related proposition to document how to have Gradle working in > the main README.md file. > # Extract the archive file to your local directory. > # Download gradle-wrapper.jar and place it in the > OFBiz-root-dir/gradle/wrapper folder. > I'm not sure if we should recommend a link to download the > gradle-wrapper.jar. This might change in the future (versions, etc.), so > indeed maybe simply asking to download is enough, cf > https://www.google.com/search?q=gradle-wrapper.jar+download=UTF-8 > Also we need to add a point about removing gradle-wrapper.jar in > https://cwiki.apache.org/confluence/display/OFBIZ/Release+Management+Guide+for+OFBiz -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-10145) Remove the Gradle wrapper from our release packages and add a step to our build notes
[ https://issues.apache.org/jira/browse/OFBIZ-10145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16761655#comment-16761655 ] Michael Brohl commented on OFBIZ-10145: --- Is the release version correct? The script states gradle-4.7 and I think we are on 5.0 on trunke and different versions on 17.12/18.12. I think we should backport and manually correct the version then. It would be great if someone could provide a windows batch file in due time because out of experience, this will be another showstopper for less technically experienced users. > Remove the Gradle wrapper from our release packages and add a step to our > build notes > - > > Key: OFBIZ-10145 > URL: https://issues.apache.org/jira/browse/OFBIZ-10145 > Project: OFBiz > Issue Type: Task > Components: Gradle >Affects Versions: 17.12.01 >Reporter: Jacques Le Roux >Assignee: Jacques Le Roux >Priority: Blocker > Fix For: 17.12.01 > > Attachments: init-gradle-wrapper.sh > > > Following the discussion at http://markmail.org/message/nd7grfiyobjkfwae, > considering LEGAL-288 and based on a lazy consensus on dev ML, we want to > remove the gradle-wrapper.jar file from the next packaged releases and use > [~jacopoc]'s related proposition to document how to have Gradle working in > the main README.md file. > # Extract the archive file to your local directory. > # Download gradle-wrapper.jar and place it in the > OFBiz-root-dir/gradle/wrapper folder. > I'm not sure if we should recommend a link to download the > gradle-wrapper.jar. This might change in the future (versions, etc.), so > indeed maybe simply asking to download is enough, cf > https://www.google.com/search?q=gradle-wrapper.jar+download=UTF-8 > Also we need to add a point about removing gradle-wrapper.jar in > https://cwiki.apache.org/confluence/display/OFBIZ/Release+Management+Guide+for+OFBiz -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-10145) Remove the Gradle wrapper from our release packages and add a step to our build notes
[ https://issues.apache.org/jira/browse/OFBIZ-10145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16761650#comment-16761650 ] Jacques Le Roux commented on OFBIZ-10145: - Hi Nico, For me it's a blocker, because it's related with the releasing process (see the description for a clearer explanation). So it should be not only backported to R18 but also R17, thanks. > Remove the Gradle wrapper from our release packages and add a step to our > build notes > - > > Key: OFBIZ-10145 > URL: https://issues.apache.org/jira/browse/OFBIZ-10145 > Project: OFBiz > Issue Type: Task > Components: Gradle >Affects Versions: 17.12.01 >Reporter: Jacques Le Roux >Assignee: Jacques Le Roux >Priority: Blocker > Fix For: 17.12.01 > > Attachments: init-gradle-wrapper.sh > > > Following the discussion at http://markmail.org/message/nd7grfiyobjkfwae, > considering LEGAL-288 and based on a lazy consensus on dev ML, we want to > remove the gradle-wrapper.jar file from the next packaged releases and use > [~jacopoc]'s related proposition to document how to have Gradle working in > the main README.md file. > # Extract the archive file to your local directory. > # Download gradle-wrapper.jar and place it in the > OFBiz-root-dir/gradle/wrapper folder. > I'm not sure if we should recommend a link to download the > gradle-wrapper.jar. This might change in the future (versions, etc.), so > indeed maybe simply asking to download is enough, cf > https://www.google.com/search?q=gradle-wrapper.jar+download=UTF-8 > Also we need to add a point about removing gradle-wrapper.jar in > https://cwiki.apache.org/confluence/display/OFBIZ/Release+Management+Guide+for+OFBiz -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-10145) Remove the Gradle wrapper from our release packages and add a step to our build notes
[ https://issues.apache.org/jira/browse/OFBIZ-10145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16761640#comment-16761640 ] Nicolas Malin commented on OFBIZ-10145: --- Ok I will commit it soon and complete the documentation for unix. I prefer left the documentation for windows by windows user ;) Do we backport it on branch 18 ? > Remove the Gradle wrapper from our release packages and add a step to our > build notes > - > > Key: OFBIZ-10145 > URL: https://issues.apache.org/jira/browse/OFBIZ-10145 > Project: OFBiz > Issue Type: Task > Components: Gradle >Affects Versions: 17.12.01 >Reporter: Jacques Le Roux >Assignee: Jacques Le Roux >Priority: Blocker > Fix For: 17.12.01 > > Attachments: init-gradle-wrapper.sh > > > Following the discussion at http://markmail.org/message/nd7grfiyobjkfwae, > considering LEGAL-288 and based on a lazy consensus on dev ML, we want to > remove the gradle-wrapper.jar file from the next packaged releases and use > [~jacopoc]'s related proposition to document how to have Gradle working in > the main README.md file. > # Extract the archive file to your local directory. > # Download gradle-wrapper.jar and place it in the > OFBiz-root-dir/gradle/wrapper folder. > I'm not sure if we should recommend a link to download the > gradle-wrapper.jar. This might change in the future (versions, etc.), so > indeed maybe simply asking to download is enough, cf > https://www.google.com/search?q=gradle-wrapper.jar+download=UTF-8 > Also we need to add a point about removing gradle-wrapper.jar in > https://cwiki.apache.org/confluence/display/OFBIZ/Release+Management+Guide+for+OFBiz -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-10145) Remove the Gradle wrapper from our release packages and add a step to our build notes
[ https://issues.apache.org/jira/browse/OFBIZ-10145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16761635#comment-16761635 ] Jacques Le Roux commented on OFBIZ-10145: - Hi Deepak, All I think we should not wait for a Windows script, a documentation would suffice for now. Either reusing this Jira (preferred) or a new Jira for the Windows script would be OK > Remove the Gradle wrapper from our release packages and add a step to our > build notes > - > > Key: OFBIZ-10145 > URL: https://issues.apache.org/jira/browse/OFBIZ-10145 > Project: OFBiz > Issue Type: Task > Components: Gradle >Affects Versions: 17.12.01 >Reporter: Jacques Le Roux >Assignee: Jacques Le Roux >Priority: Blocker > Fix For: 17.12.01 > > Attachments: init-gradle-wrapper.sh > > > Following the discussion at http://markmail.org/message/nd7grfiyobjkfwae, > considering LEGAL-288 and based on a lazy consensus on dev ML, we want to > remove the gradle-wrapper.jar file from the next packaged releases and use > [~jacopoc]'s related proposition to document how to have Gradle working in > the main README.md file. > # Extract the archive file to your local directory. > # Download gradle-wrapper.jar and place it in the > OFBiz-root-dir/gradle/wrapper folder. > I'm not sure if we should recommend a link to download the > gradle-wrapper.jar. This might change in the future (versions, etc.), so > indeed maybe simply asking to download is enough, cf > https://www.google.com/search?q=gradle-wrapper.jar+download=UTF-8 > Also we need to add a point about removing gradle-wrapper.jar in > https://cwiki.apache.org/confluence/display/OFBIZ/Release+Management+Guide+for+OFBiz -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-10145) Remove the Gradle wrapper from our release packages and add a step to our build notes
[ https://issues.apache.org/jira/browse/OFBIZ-10145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16759370#comment-16759370 ] Deepak Dixit commented on OFBIZ-10145: -- Can we conclude this ticket? It solution looks good we can commit it. > Remove the Gradle wrapper from our release packages and add a step to our > build notes > - > > Key: OFBIZ-10145 > URL: https://issues.apache.org/jira/browse/OFBIZ-10145 > Project: OFBiz > Issue Type: Task > Components: Gradle >Affects Versions: Trunk >Reporter: Jacques Le Roux >Assignee: Jacques Le Roux >Priority: Blocker > Fix For: 17.12.01 > > Attachments: init-gradle-wrapper.sh > > > Following the discussion at http://markmail.org/message/nd7grfiyobjkfwae, > considering LEGAL-288 and based on a lazy consensus on dev ML, we want to > remove the gradle-wrapper.jar file from the next packaged releases and use > [~jacopoc]'s related proposition to document how to have Gradle working in > the main README.md file. > # Extract the archive file to your local directory. > # Download gradle-wrapper.jar and place it in the > OFBiz-root-dir/gradle/wrapper folder. > I'm not sure if we should recommend a link to download the > gradle-wrapper.jar. This might change in the future (versions, etc.), so > indeed maybe simply asking to download is enough, cf > https://www.google.com/search?q=gradle-wrapper.jar+download=UTF-8 > Also we need to add a point about removing gradle-wrapper.jar in > https://cwiki.apache.org/confluence/display/OFBIZ/Release+Management+Guide+for+OFBiz -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-10145) Remove the Gradle wrapper from our release packages and add a step to our build notes
[ https://issues.apache.org/jira/browse/OFBIZ-10145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16538759#comment-16538759 ] Jacques Le Roux commented on OFBIZ-10145: - Do we want this as a blocker for the next release? > Remove the Gradle wrapper from our release packages and add a step to our > build notes > - > > Key: OFBIZ-10145 > URL: https://issues.apache.org/jira/browse/OFBIZ-10145 > Project: OFBiz > Issue Type: Task > Components: Gradle >Affects Versions: Trunk >Reporter: Jacques Le Roux >Priority: Major > Fix For: 17.12.01 > > Attachments: init-gradle-wrapper.sh > > > Following the discussion at http://markmail.org/message/nd7grfiyobjkfwae, > considering LEGAL-288 and based on a lazy consensus on dev ML, we want to > remove the gradle-wrapper.jar file from the next packaged releases and use > [~jacopoc]'s related proposition to document how to have Gradle working in > the main README.md file. > # Extract the archive file to your local directory. > # Download gradle-wrapper.jar and place it in the > OFBiz-root-dir/gradle/wrapper folder. > I'm not sure if we should recommend a link to download the > gradle-wrapper.jar. This might change in the future (versions, etc.), so > indeed maybe simply asking to download is enough, cf > https://www.google.com/search?q=gradle-wrapper.jar+download=UTF-8 > Also we need to add a point about removing gradle-wrapper.jar in > https://cwiki.apache.org/confluence/display/OFBIZ/Release+Management+Guide+for+OFBiz -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-10145) Remove the Gradle wrapper from our release packages and add a step to our build notes
[ https://issues.apache.org/jira/browse/OFBIZ-10145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16538300#comment-16538300 ] Pierre Smits commented on OFBIZ-10145: -- I like this solution. It will minimize manual actions. > Remove the Gradle wrapper from our release packages and add a step to our > build notes > - > > Key: OFBIZ-10145 > URL: https://issues.apache.org/jira/browse/OFBIZ-10145 > Project: OFBiz > Issue Type: Task > Components: Gradle >Affects Versions: Trunk >Reporter: Jacques Le Roux >Priority: Major > Fix For: 17.12.01 > > Attachments: init-gradle-wrapper.sh > > > Following the discussion at http://markmail.org/message/nd7grfiyobjkfwae, > considering LEGAL-288 and based on a lazy consensus on dev ML, we want to > remove the gradle-wrapper.jar file from the next packaged releases and use > [~jacopoc]'s related proposition to document how to have Gradle working in > the main README.md file. > # Extract the archive file to your local directory. > # Download gradle-wrapper.jar and place it in the > OFBiz-root-dir/gradle/wrapper folder. > I'm not sure if we should recommend a link to download the > gradle-wrapper.jar. This might change in the future (versions, etc.), so > indeed maybe simply asking to download is enough, cf > https://www.google.com/search?q=gradle-wrapper.jar+download=UTF-8 > Also we need to add a point about removing gradle-wrapper.jar in > https://cwiki.apache.org/confluence/display/OFBIZ/Release+Management+Guide+for+OFBiz -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-10145) Remove the Gradle wrapper from our release packages and add a step to our build notes
[ https://issues.apache.org/jira/browse/OFBIZ-10145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16481892#comment-16481892 ] Jacques Le Roux commented on OFBIZ-10145: - Hi Nicolas, That seems indeed doable for Windows > Remove the Gradle wrapper from our release packages and add a step to our > build notes > - > > Key: OFBIZ-10145 > URL: https://issues.apache.org/jira/browse/OFBIZ-10145 > Project: OFBiz > Issue Type: Task > Components: Gradle >Affects Versions: Trunk >Reporter: Jacques Le Roux >Priority: Major > Fix For: 17.12.01 > > Attachments: init-gradle-wrapper.sh > > > Following the discussion at http://markmail.org/message/nd7grfiyobjkfwae, > considering LEGAL-288 and based on a lazy consensus on dev ML, we want to > remove the gradle-wrapper.jar file from the next packaged releases and use > [~jacopoc]'s related proposition to document how to have Gradle working in > the main README.md file. > # Extract the archive file to your local directory. > # Download gradle-wrapper.jar and place it in the > OFBiz-root-dir/gradle/wrapper folder. > I'm not sure if we should recommend a link to download the > gradle-wrapper.jar. This might change in the future (versions, etc.), so > indeed maybe simply asking to download is enough, cf > https://www.google.com/search?q=gradle-wrapper.jar+download=UTF-8 > Also we need to add a point about removing gradle-wrapper.jar in > https://cwiki.apache.org/confluence/display/OFBIZ/Release+Management+Guide+for+OFBiz -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-10145) Remove the Gradle wrapper from our release packages and add a step to our build notes
[
https://issues.apache.org/jira/browse/OFBIZ-10145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16480679#comment-16480679
]
Nicolas Malin commented on OFBIZ-10145:
---
Hello,
I started a download script for unix [^init-gradle-wrapper.sh] to set on
directory $OFBIZ_HOME/gradle/ and run like
{code}
sh gradle/init-gradle-wrapper.sh
./gradlew
{code}
it's simple and just a try. Peraphs it's possible to realize the same for
windows
> Remove the Gradle wrapper from our release packages and add a step to our
> build notes
> -
>
> Key: OFBIZ-10145
> URL: https://issues.apache.org/jira/browse/OFBIZ-10145
> Project: OFBiz
> Issue Type: Task
> Components: Gradle
>Affects Versions: Trunk
>Reporter: Jacques Le Roux
>Priority: Major
> Fix For: 17.12.01
>
> Attachments: init-gradle-wrapper.sh
>
>
> Following the discussion at http://markmail.org/message/nd7grfiyobjkfwae,
> considering LEGAL-288 and based on a lazy consensus on dev ML, we want to
> remove the gradle-wrapper.jar file from the next packaged releases and use
> [~jacopoc]'s related proposition to document how to have Gradle working in
> the main README.md file.
> # Extract the archive file to your local directory.
> # Download gradle-wrapper.jar and place it in the
> OFBiz-root-dir/gradle/wrapper folder.
> I'm not sure if we should recommend a link to download the
> gradle-wrapper.jar. This might change in the future (versions, etc.), so
> indeed maybe simply asking to download is enough, cf
> https://www.google.com/search?q=gradle-wrapper.jar+download=UTF-8
> Also we need to add a point about removing gradle-wrapper.jar in
> https://cwiki.apache.org/confluence/display/OFBIZ/Release+Management+Guide+for+OFBiz
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (OFBIZ-10145) Remove the Gradle wrapper from our release packages and add a step to our build notes
[ https://issues.apache.org/jira/browse/OFBIZ-10145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16315384#comment-16315384 ] Jacques Le Roux commented on OFBIZ-10145: - OK got it, WIndows users will have to download it :D. A cursory documentation should be enough. > Remove the Gradle wrapper from our release packages and add a step to our > build notes > - > > Key: OFBIZ-10145 > URL: https://issues.apache.org/jira/browse/OFBIZ-10145 > Project: OFBiz > Issue Type: Task > Components: Gradle >Affects Versions: Trunk >Reporter: Jacques Le Roux > Fix For: 17.12.01 > > > Following the discussion at http://markmail.org/message/nd7grfiyobjkfwae, > considering LEGAL-288 and based on a lazy consensus on dev ML, we want to > remove the gradle-wrapper.jar file from the next packaged releases and use > [~jacopoc]'s related proposition to document how to have Gradle working in > the main README.md file. > # Extract the archive file to your local directory. > # Download gradle-wrapper.jar and place it in the > OFBiz-root-dir/gradle/wrapper folder. > I'm not sure if we should recommend a link to download the > gradle-wrapper.jar. This might change in the future (versions, etc.), so > indeed maybe simply asking to download is enough, cf > https://www.google.com/search?q=gradle-wrapper.jar+download=UTF-8 > Also we need to add a point about removing gradle-wrapper.jar in > https://cwiki.apache.org/confluence/display/OFBIZ/Release+Management+Guide+for+OFBiz -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (OFBIZ-10145) Remove the Gradle wrapper from our release packages and add a step to our build notes
[ https://issues.apache.org/jira/browse/OFBIZ-10145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16315362#comment-16315362 ] Michael Brohl commented on OFBIZ-10145: --- Let's hope that someone using windows will provide something similar as a batch file :-) We should do as much as possible to make it easy for users to get started. So we should provide proper documentation for a manual download/install as well as convenience scripts where possible. > Remove the Gradle wrapper from our release packages and add a step to our > build notes > - > > Key: OFBIZ-10145 > URL: https://issues.apache.org/jira/browse/OFBIZ-10145 > Project: OFBiz > Issue Type: Task > Components: Gradle >Affects Versions: Trunk >Reporter: Jacques Le Roux > Fix For: 17.12.01 > > > Following the discussion at http://markmail.org/message/nd7grfiyobjkfwae, > considering LEGAL-288 and based on a lazy consensus on dev ML, we want to > remove the gradle-wrapper.jar file from the next packaged releases and use > [~jacopoc]'s related proposition to document how to have Gradle working in > the main README.md file. > # Extract the archive file to your local directory. > # Download gradle-wrapper.jar and place it in the > OFBiz-root-dir/gradle/wrapper folder. > I'm not sure if we should recommend a link to download the > gradle-wrapper.jar. This might change in the future (versions, etc.), so > indeed maybe simply asking to download is enough, cf > https://www.google.com/search?q=gradle-wrapper.jar+download=UTF-8 > Also we need to add a point about removing gradle-wrapper.jar in > https://cwiki.apache.org/confluence/display/OFBIZ/Release+Management+Guide+for+OFBiz -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (OFBIZ-10145) Remove the Gradle wrapper from our release packages and add a step to our build notes
[ https://issues.apache.org/jira/browse/OFBIZ-10145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16315360#comment-16315360 ] Jacques Le Roux commented on OFBIZ-10145: - You mean something like https://github.com/apache/bigtop/blob/master/gradlew ? But then what about Windows users? > Remove the Gradle wrapper from our release packages and add a step to our > build notes > - > > Key: OFBIZ-10145 > URL: https://issues.apache.org/jira/browse/OFBIZ-10145 > Project: OFBiz > Issue Type: Task > Components: Gradle >Affects Versions: Trunk >Reporter: Jacques Le Roux > Fix For: 17.12.01 > > > Following the discussion at http://markmail.org/message/nd7grfiyobjkfwae, > considering LEGAL-288 and based on a lazy consensus on dev ML, we want to > remove the gradle-wrapper.jar file from the next packaged releases and use > [~jacopoc]'s related proposition to document how to have Gradle working in > the main README.md file. > # Extract the archive file to your local directory. > # Download gradle-wrapper.jar and place it in the > OFBiz-root-dir/gradle/wrapper folder. > I'm not sure if we should recommend a link to download the > gradle-wrapper.jar. This might change in the future (versions, etc.), so > indeed maybe simply asking to download is enough, cf > https://www.google.com/search?q=gradle-wrapper.jar+download=UTF-8 > Also we need to add a point about removing gradle-wrapper.jar in > https://cwiki.apache.org/confluence/display/OFBIZ/Release+Management+Guide+for+OFBiz -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (OFBIZ-10145) Remove the Gradle wrapper from our release packages and add a step to our build notes
[ https://issues.apache.org/jira/browse/OFBIZ-10145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16315340#comment-16315340 ] Michael Brohl commented on OFBIZ-10145: --- I think we should provide a download script like it is mentioned in the first message of the linked thread. Our users, especially those who are new to OFBiz, often have basic problems to get started and simply removing the wrapper would add more hurdles before an easy start. > Remove the Gradle wrapper from our release packages and add a step to our > build notes > - > > Key: OFBIZ-10145 > URL: https://issues.apache.org/jira/browse/OFBIZ-10145 > Project: OFBiz > Issue Type: Task > Components: Gradle >Affects Versions: Trunk >Reporter: Jacques Le Roux > Fix For: 17.12.01 > > > Following the discussion at http://markmail.org/message/nd7grfiyobjkfwae, > considering LEGAL-288 and based on a lazy consensus on dev ML, we want to > remove the gradle-wrapper.jar file from the next packaged releases and use > [~jacopoc]'s related proposition to document how to have Gradle working in > the main README.md file. > # Extract the archive file to your local directory. > # Download gradle-wrapper.jar and place it in the > OFBiz-root-dir/gradle/wrapper folder. > I'm not sure if we should recommend a link to download the > gradle-wrapper.jar. This might change in the future (versions, etc.), so > indeed maybe simply asking to download is enough, cf > https://www.google.com/search?q=gradle-wrapper.jar+download=UTF-8 > Also we need to add a point about removing gradle-wrapper.jar in > https://cwiki.apache.org/confluence/display/OFBIZ/Release+Management+Guide+for+OFBiz -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (OFBIZ-10145) Remove the Gradle wrapper from our release packages and add a step to our build notes
[ https://issues.apache.org/jira/browse/OFBIZ-10145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16315268#comment-16315268 ] Jacques Le Roux commented on OFBIZ-10145: - If nobody is against I'll do so before next weekend... > Remove the Gradle wrapper from our release packages and add a step to our > build notes > - > > Key: OFBIZ-10145 > URL: https://issues.apache.org/jira/browse/OFBIZ-10145 > Project: OFBiz > Issue Type: Task > Components: Gradle >Affects Versions: Trunk >Reporter: Jacques Le Roux > Fix For: 17.12.01 > > > Following the discussion at http://markmail.org/message/nd7grfiyobjkfwae, > considering LEGAL-288 and based on a lazy consensus on dev ML, we want to > remove the gradle-wrapper.jar file from the next packaged releases and use > [~jacopoc]'s related proposition to document how to have Gradle working in > the main README.md file. > # Extract the archive file to your local directory. > # Download gradle-wrapper.jar and place it in the > OFBiz-root-dir/gradle/wrapper folder. > I'm not sure if we should recommend a link to download the > gradle-wrapper.jar. This might change in the future (versions, etc.), so > indeed maybe simply asking to download is enough, cf > https://www.google.com/search?q=gradle-wrapper.jar+download=UTF-8 > Also we need to add a point about removing gradle-wrapper.jar in > https://cwiki.apache.org/confluence/display/OFBIZ/Release+Management+Guide+for+OFBiz -- This message was sent by Atlassian JIRA (v6.4.14#64029)
