[jira] [Commented] (OFBIZ-9219) Delete obsolete branches
[ https://issues.apache.org/jira/browse/OFBIZ-9219?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15875715#comment-15875715 ] Jacopo Cappellato commented on OFBIZ-9219: -- [~jacques.le.roux] yes, now I remember: it was for managing the OFBiz website using the content manager that has been created by Infra; when it was made available I did the request and created the branch to host the content but we didn't implement it. For now we could just keep it as is. > Delete obsolete branches > > > Key: OFBIZ-9219 > URL: https://issues.apache.org/jira/browse/OFBIZ-9219 > Project: OFBiz > Issue Type: Improvement >Reporter: Jacques Le Roux >Assignee: Jacques Le Roux >Priority: Trivial > > At https://s.apache.org/k7pD in relation with INFRA-13497 we discussed the > opportunity to clean the branches in OFBiz: > bq. I think we should remove a lot of useless and old confusing branches in > svn > Here is a list of branches. In a first pass, I checked the branches I propose > to remove, please comment, thanks. > |Branch |To drop | > |2013_RemoveJavolution| x| > |2015ScreenWidgetRedesign |x | > |20111205EmailHandling| x| > |20120209RemoveBsh| x| > |20120329_portletWidget | x| > |Dojo1.4 | x| > |OFBIZ-4098-make-cache-pluggable | | > |OFBIZ-5312-ofbiz-ecommerce-seo-2013-10-23| x| > |OFBIZ-6270 | x| > |OFBIZ-6271 | x| > |OFBIZ-6275 | x| > |Webhelp-2012-12-07 | | > |addBirt | x| > |addbirt | x| > |boostrap_theme | | > |dojo1.4 | x| > |executioncontext20090716 | x| > |executioncontext20090812 | x| > |executioncontext20091231 | x| > |framework-api-cleanup| x| > |frontendNewTheme2013-05-10 | | > |htmlfive_20110529| | > |improved-entityengine-features-20120528 | | > |jackrabbit20100709 | x| > |jackrabbit20120501 | | > |jquery | x| > |json-integration-refactoring | | > |multitenant20100310 | | > |new_branch | x| > |release4.0 | | > |release09.04 | | > |release10.04 | | > |release11.04 | | > |release12.04 | | > |release13.07 | | > |release14.12 | | > |release15.12 | | > |release16.11 | | > |trunk| | > |typecheckcleanup200810 | x| > |webhelp-2012-12-07 | | > |beforejQuery | x| > |beforeSvnRestructuring | | > |beforeGradle | | > |RemovingPOS | | > |REL-16.11.01 | | > |REL-13.07.03 | | > |REL-13.07.02 | | > |REL-13.07.01 | | > |REL-12.04.06 | | > |REL-12.04.05 | | > |REL-12.04.04 | | > |REL-12.04.03 | | > |REL-12.04.02 | | > |REL-12.04.01 | | > |REL-11.04.06 | | > |REL-11.04.05 | | > |REL-11.04.04 | | > |REL-11.04.03 | | > |REL-11.04.02 | | > |REL-11.04.01 | | > |REL-10.04.06 | | > |REL-10.04.05 | | > |REL-10.04.04 | | > |REL-10.04.03 | | > |REL-10.04.02 | | > |REL-10.04| | > |REL-09.04.02 | | > |REL-09.04.01 | | > |REL-09.04| | > |REL-4.0 | | > I also wrote in the same email: > bq. document the fact in GitHub that the ofbiz-framework/trunk is the new > trunk. But how I'm still unsure, I guess at top of the README.MD ? > Please comment on this aspect too, and create a new Jira if you feel the need. -- This message was sent by Atlassian JIRA
[jira] [Commented] (OFBIZ-4514) Taxes are not handled correctly when creating accounting transactions from purchase invoices
[ https://issues.apache.org/jira/browse/OFBIZ-4514?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15859156#comment-15859156 ] Jacopo Cappellato commented on OFBIZ-4514: -- [~paul_foxworthy] we should also commit part of this patch with OFBIZ-6330 > Taxes are not handled correctly when creating accounting transactions from > purchase invoices > > > Key: OFBIZ-4514 > URL: https://issues.apache.org/jira/browse/OFBIZ-4514 > Project: OFBiz > Issue Type: Bug > Components: accounting >Affects Versions: Trunk >Reporter: Martin Kreidenweis >Priority: Trivial > Labels: VAT, tax > Attachments: OFBIZ-4514.patch > > > Taxes are not handled correctly when creating accounting transactions from > purchase invoices in GeneralLedgerServices#createAcctgTransForPurchaseInvoice -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (OFBIZ-6330) The invoiceTaxTotal value is missing from createAcctgTransForPurchaseInvoice service
[
https://issues.apache.org/jira/browse/OFBIZ-6330?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15859151#comment-15859151
]
Jacopo Cappellato commented on OFBIZ-6330:
--
[~paul_foxworthy] I agree with the fix you have proposed: the same code that is
already used by the createAcctgTransForSalesInvoice should be applied to the
return and purchase services. And your patch does this.
I would also apologize with [~kongrath] for having missed this valid
contribution. Thank you Kongrath.
> The invoiceTaxTotal value is missing from createAcctgTransForPurchaseInvoice
> service
>
>
> Key: OFBIZ-6330
> URL: https://issues.apache.org/jira/browse/OFBIZ-6330
> Project: OFBiz
> Issue Type: Bug
> Components: accounting
>Affects Versions: Trunk
>Reporter: Kongrath Suankaewmanee
>Assignee: Paul Foxworthy
> Attachments: GeneralLedgerServices.patch,
> OFBIZ-6330_TaxAccountingOnPurchasesAndReturns.patch
>
>
> Hi All,
> Scenario: The sum of debit and credit in InvoiceAcctgTransEntriesPdf of
> purchase invoice are not equal.
> Question: I'm not sure why the createAcctgTransForPurchaseInvoice service did
> not call the method to get invoiceTaxTotal.
> class-name="org.ofbiz.accounting.invoice.InvoiceWorker"
> ret-field="invoiceTaxTotal">
>
>
> And the invoiceTaxTotal value needs to add to totalAmountFromInvoice via code
> below:
> decimal-scale="${ledgerDecimals}" rounding-mode="${roundingMode}">
>
>
>
>
>
> That it should work like the createAcctgTransForSalesInvoice service of the
> sales invoice.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (OFBIZ-7918) Improve Dutch labels regarding accounting reports
[ https://issues.apache.org/jira/browse/OFBIZ-7918?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15434657#comment-15434657 ] Jacopo Cappellato commented on OFBIZ-7918: -- but once you are done, and your message in the dev list soliciting feedback from committers seems to suggest that you are, you should unassign the ticket. > Improve Dutch labels regarding accounting reports > - > > Key: OFBIZ-7918 > URL: https://issues.apache.org/jira/browse/OFBIZ-7918 > Project: OFBiz > Issue Type: Improvement > Components: accounting >Affects Versions: Trunk >Reporter: Pierre Smits >Assignee: Pierre Smits > Attachments: OFBIZ-7918-AccountingUiLabels.xml.patch > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-7918) Improve Dutch labels regarding accounting reports
[ https://issues.apache.org/jira/browse/OFBIZ-7918?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15434651#comment-15434651 ] Jacopo Cappellato commented on OFBIZ-7918: -- Pierre, as I have already mentioned to you in another Jira ticket yesterday [*], when you contribute a patch, you should base it on a pristine version of the trunk (or branch) you are willing to contribute to. [*] https://issues.apache.org/jira/browse/OFBIZ-7016?focusedCommentId=15432278=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-15432278 > Improve Dutch labels regarding accounting reports > - > > Key: OFBIZ-7918 > URL: https://issues.apache.org/jira/browse/OFBIZ-7918 > Project: OFBiz > Issue Type: Improvement > Components: accounting >Affects Versions: Trunk >Reporter: Pierre Smits >Assignee: Pierre Smits > Attachments: OFBIZ-7918-AccountingUiLabels.xml.patch > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Comment Edited] (OFBIZ-8142) A series of cleanups related to OFBiz servlet filters
[ https://issues.apache.org/jira/browse/OFBIZ-8142?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15465406#comment-15465406 ] Jacopo Cappellato edited comment on OFBIZ-8142 at 9/6/16 7:09 AM: -- Committed in trunk at rev. 1759332, 1759368 was (Author: jacopoc): Committed in trunk at rev. 1759332 > A series of cleanups related to OFBiz servlet filters > - > > Key: OFBIZ-8142 > URL: https://issues.apache.org/jira/browse/OFBIZ-8142 > Project: OFBiz > Issue Type: Improvement > Components: framework >Reporter: Jacopo Cappellato >Assignee: Jacopo Cappellato >Priority: Minor > Fix For: Upcoming Branch > > > * removed an unused web filter (UrlRegexpContextFilter) > * moved a series of methods from ContextFilter to WebAppUtil, where they make > more sense; changed one of them to be a static method > * made private some methods of ContextFilter and WebAppUtil because they were > not used outside of their classes > * introduced a constant for the "control" mount point > * moved public fields and methods from the ContentUrlFilter to the > OfbizContentAltUrlTransforms and made them private (since they are only used > by this class) > * no more need for the UrlServletHelper to extend the ContextFilter -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (OFBIZ-8179) Enhance DBCPConnectionFactory to implement a TransactionFactory and remove the geronimo component
[ https://issues.apache.org/jira/browse/OFBIZ-8179?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacopo Cappellato updated OFBIZ-8179: - Attachment: OFBIZ-8179.patch > Enhance DBCPConnectionFactory to implement a TransactionFactory and remove > the geronimo component > - > > Key: OFBIZ-8179 > URL: https://issues.apache.org/jira/browse/OFBIZ-8179 > Project: OFBiz > Issue Type: Improvement > Components: framework >Affects Versions: Trunk >Reporter: Jacopo Cappellato >Assignee: Jacopo Cappellato >Priority: Minor > Attachments: OFBIZ-8179.patch, > TransactionConnectionFactory-before-after.png > > > Made the DBCPConnectionFactory an implementation of TransactionFactory by > moving the code from the GeronimoTransactionFactory. > With this change the geronimo component is no more required. > Without any functional change, this design simplifies greatly the calls and > component dependencies because it removes a cyclic dependency between entity > and geronimo components (see diagram attached that explain the architecture > before and after this change). -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (OFBIZ-7935) Move 3rd party shipping integrations from product application to specialpurpose
[ https://issues.apache.org/jira/browse/OFBIZ-7935?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacopo Cappellato updated OFBIZ-7935: - Summary: Move 3rd party shipping integrations from product application to specialpurpose (was: Move 3rd party shipping integrations from product application to sepcialpurpose) > Move 3rd party shipping integrations from product application to > specialpurpose > --- > > Key: OFBIZ-7935 > URL: https://issues.apache.org/jira/browse/OFBIZ-7935 > Project: OFBiz > Issue Type: Improvement > Components: product >Affects Versions: Trunk >Reporter: Mridul Pathak >Assignee: Mridul Pathak > > This is a placeholder issue to capture all sub tasks for removing 3rd party > shipping integrations from product application and moving to a new component > in special purpose. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (OFBIZ-8179) Enhance DBCPConnectionFactory to implement a TransactionFactory and remove the geronimo component
Jacopo Cappellato created OFBIZ-8179: Summary: Enhance DBCPConnectionFactory to implement a TransactionFactory and remove the geronimo component Key: OFBIZ-8179 URL: https://issues.apache.org/jira/browse/OFBIZ-8179 Project: OFBiz Issue Type: Improvement Components: framework Affects Versions: Trunk Reporter: Jacopo Cappellato Assignee: Jacopo Cappellato Priority: Minor Made the DBCPConnectionFactory an implementation of TransactionFactory by moving the code from the GeronimoTransactionFactory. With this change the geronimo component is no more required. Without any functional change, this design simplifies greatly the calls and component dependencies because it removes a cyclic dependency between entity and geronimo components (see diagram attached that explain the architecture before and after this change). -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (OFBIZ-8179) Enhance DBCPConnectionFactory to implement a TransactionFactory and remove the geronimo component
[ https://issues.apache.org/jira/browse/OFBIZ-8179?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacopo Cappellato updated OFBIZ-8179: - Attachment: TransactionConnectionFactory-before-after.png > Enhance DBCPConnectionFactory to implement a TransactionFactory and remove > the geronimo component > - > > Key: OFBIZ-8179 > URL: https://issues.apache.org/jira/browse/OFBIZ-8179 > Project: OFBiz > Issue Type: Improvement > Components: framework >Affects Versions: Trunk >Reporter: Jacopo Cappellato >Assignee: Jacopo Cappellato >Priority: Minor > Attachments: TransactionConnectionFactory-before-after.png > > > Made the DBCPConnectionFactory an implementation of TransactionFactory by > moving the code from the GeronimoTransactionFactory. > With this change the geronimo component is no more required. > Without any functional change, this design simplifies greatly the calls and > component dependencies because it removes a cyclic dependency between entity > and geronimo components (see diagram attached that explain the architecture > before and after this change). -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (OFBIZ-8224) Removal of support for the Bean Scripting Framework (BSF)
Jacopo Cappellato created OFBIZ-8224: Summary: Removal of support for the Bean Scripting Framework (BSF) Key: OFBIZ-8224 URL: https://issues.apache.org/jira/browse/OFBIZ-8224 Project: OFBiz Issue Type: Improvement Components: framework Affects Versions: Trunk Reporter: Jacopo Cappellato Assignee: Jacopo Cappellato Priority: Minor The attached patch removes the support for Bean Scripting Framework (BSF) from the OFBiz framework: as far as I know no application code was using this since several years and there are better and more modern tools nowadays. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (OFBIZ-8224) Removal of support for the Bean Scripting Framework (BSF)
[ https://issues.apache.org/jira/browse/OFBIZ-8224?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacopo Cappellato updated OFBIZ-8224: - Attachment: bsf-removal.patch > Removal of support for the Bean Scripting Framework (BSF) > - > > Key: OFBIZ-8224 > URL: https://issues.apache.org/jira/browse/OFBIZ-8224 > Project: OFBiz > Issue Type: Improvement > Components: framework >Affects Versions: Trunk >Reporter: Jacopo Cappellato >Assignee: Jacopo Cappellato >Priority: Minor > Attachments: bsf-removal.patch > > > The attached patch removes the support for Bean Scripting Framework (BSF) > from the OFBiz framework: as far as I know no application code was using this > since several years and there are better and more modern tools nowadays. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Assigned] (OFBIZ-5897) ContentServicesComplex.getAssocAndContentAndDataResourceMethod and its Cache method is not consitent.
[ https://issues.apache.org/jira/browse/OFBIZ-5897?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacopo Cappellato reassigned OFBIZ-5897: Assignee: Deepak Dixit (was: Jacopo Cappellato) Deepak, since you are the reporter of this old ticket, could you please check if it can be closed? Thanks. > ContentServicesComplex.getAssocAndContentAndDataResourceMethod and its Cache > method is not consitent. > - > > Key: OFBIZ-5897 > URL: https://issues.apache.org/jira/browse/OFBIZ-5897 > Project: OFBiz > Issue Type: Improvement > Components: content >Affects Versions: Release Branch 13.07, Trunk >Reporter: Deepak Dixit >Assignee: Deepak Dixit > > ContentServicesComplex has two method > getAssocAndContentAndDataResourceMethod and > getAssocAndContentAndDataResourceCacheMethod, these method are not > consistent. Ideally both method should have to use same mechanism to fetch > the data, only difference should be Cache method should have to use > cache=true. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-8179) Enhance DBCPConnectionFactory to implement a TransactionFactory and remove the geronimo component
[
https://issues.apache.org/jira/browse/OFBIZ-8179?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15479392#comment-15479392
]
Jacopo Cappellato commented on OFBIZ-8179:
--
[~taher] I think you are referring to:
{code}
+
{code}
I have commented it out because it is not required setting and it is not
specifically required by the new transaction-factory.
I agree with you that it is better to remove it rather than leaving it
commented out.
Thanks
> Enhance DBCPConnectionFactory to implement a TransactionFactory and remove
> the geronimo component
> -
>
> Key: OFBIZ-8179
> URL: https://issues.apache.org/jira/browse/OFBIZ-8179
> Project: OFBiz
> Issue Type: Improvement
> Components: framework
>Affects Versions: Trunk
>Reporter: Jacopo Cappellato
>Assignee: Jacopo Cappellato
>Priority: Minor
> Attachments: OFBIZ-8179.patch,
> TransactionConnectionFactory-before-after.png
>
>
> Made the DBCPConnectionFactory an implementation of TransactionFactory by
> moving the code from the GeronimoTransactionFactory.
> With this change the geronimo component is no more required.
> Without any functional change, this design simplifies greatly the calls and
> component dependencies because it removes a cyclic dependency between entity
> and geronimo components (see diagram attached that explain the architecture
> before and after this change).
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Closed] (OFBIZ-8224) Removal of support for the Bean Scripting Framework (BSF)
[ https://issues.apache.org/jira/browse/OFBIZ-8224?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacopo Cappellato closed OFBIZ-8224. Resolution: Fixed Fix Version/s: Upcoming Branch Implemented in rev. 1760384 > Removal of support for the Bean Scripting Framework (BSF) > - > > Key: OFBIZ-8224 > URL: https://issues.apache.org/jira/browse/OFBIZ-8224 > Project: OFBiz > Issue Type: Improvement > Components: framework >Affects Versions: Trunk >Reporter: Jacopo Cappellato >Assignee: Jacopo Cappellato >Priority: Minor > Fix For: Upcoming Branch > > Attachments: bsf-removal.patch > > > The attached patch removes the support for Bean Scripting Framework (BSF) > from the OFBiz framework: as far as I know no application code was using this > since several years and there are better and more modern tools nowadays. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-8179) Enhance DBCPConnectionFactory to implement a TransactionFactory and remove the geronimo component
[ https://issues.apache.org/jira/browse/OFBIZ-8179?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15484256#comment-15484256 ] Jacopo Cappellato commented on OFBIZ-8179: -- Thanks for all your feedback and reviews. I ended up committing a different version of my patch, in order to address Scott's comment: see rev. 1760376 With this fix I have removed the cyclic dependency between the two components; I didn't simplify the chain of calls required to get a connection from GeronimoTransactionFactory+DBCPConnectionFactory in order to maintain the flexibility to replace one of the two factories. We could revisit this discussion if/when we will have a measure that tells that direct calls improve the performance. > Enhance DBCPConnectionFactory to implement a TransactionFactory and remove > the geronimo component > - > > Key: OFBIZ-8179 > URL: https://issues.apache.org/jira/browse/OFBIZ-8179 > Project: OFBiz > Issue Type: Improvement > Components: framework >Affects Versions: Trunk >Reporter: Jacopo Cappellato >Assignee: Jacopo Cappellato >Priority: Minor > Fix For: Upcoming Branch > > Attachments: OFBIZ-8179.patch, > TransactionConnectionFactory-before-after.png > > > Made the DBCPConnectionFactory an implementation of TransactionFactory by > moving the code from the GeronimoTransactionFactory. > With this change the geronimo component is no more required. > Without any functional change, this design simplifies greatly the calls and > component dependencies because it removes a cyclic dependency between entity > and geronimo components (see diagram attached that explain the architecture > before and after this change). -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Closed] (OFBIZ-8179) Enhance DBCPConnectionFactory to implement a TransactionFactory and remove the geronimo component
[ https://issues.apache.org/jira/browse/OFBIZ-8179?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacopo Cappellato closed OFBIZ-8179. Resolution: Fixed Fix Version/s: Upcoming Branch > Enhance DBCPConnectionFactory to implement a TransactionFactory and remove > the geronimo component > - > > Key: OFBIZ-8179 > URL: https://issues.apache.org/jira/browse/OFBIZ-8179 > Project: OFBiz > Issue Type: Improvement > Components: framework >Affects Versions: Trunk >Reporter: Jacopo Cappellato >Assignee: Jacopo Cappellato >Priority: Minor > Fix For: Upcoming Branch > > Attachments: OFBIZ-8179.patch, > TransactionConnectionFactory-before-after.png > > > Made the DBCPConnectionFactory an implementation of TransactionFactory by > moving the code from the GeronimoTransactionFactory. > With this change the geronimo component is no more required. > Without any functional change, this design simplifies greatly the calls and > component dependencies because it removes a cyclic dependency between entity > and geronimo components (see diagram attached that explain the architecture > before and after this change). -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-8319) viewing product sample page causes exception
[ https://issues.apache.org/jira/browse/OFBIZ-8319?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15544858#comment-15544858 ] Jacopo Cappellato commented on OFBIZ-8319: -- Wai, could you please try if the commit 1763251 fixed the issue? It seems to be working for me now. Thanks > viewing product sample page causes exception > > > Key: OFBIZ-8319 > URL: https://issues.apache.org/jira/browse/OFBIZ-8319 > Project: OFBiz > Issue Type: Bug > Components: specialpurpose/ecommerce >Affects Versions: Trunk >Reporter: Wai >Assignee: Rohit Koushal > > -set general.properties/multitenant=Y > -go to > https://localhost:8443/catalog/control/EditProductFeatures?productId=WG-9943 > -click on 'product page' link > -error page shows... > java.lang.NullPointerException > org.apache.ofbiz.entity.util.EntityQuery.query(EntityQuery.java:455) > org.apache.ofbiz.entity.util.EntityQuery.queryList(EntityQuery.java:380) > org.apache.ofbiz.product.category.CategoryWorker.getRelatedCategoriesRet(CategoryWorker.java:150) > > org.apache.ofbiz.product.category.CategoryWorker.getRelatedCategoriesRet(CategoryWorker.java:139) > org.apache.ofbiz.product.category.CatalogUrlFilter.doFilter(CatalogUrlFilter.java:229) > > org.apache.ofbiz.webapp.control.ContextFilter.doFilter(ContextFilter.java:209) > It seems that when ofbiz is set to multitenant mode and the tenant associated > with tenantId=null does this issue occur. I don't know if it should be a > configuration issue or a bug. This did not occur prior to the implementation > of the ControlFilter and ContextFilter of r1761304. > How should the tenant associated with tenantId=null be used? Is it consider > special or it is used just like any other tenant? -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-6625) EcomSEO generates an error when used in multi-tenancy setup
[
https://issues.apache.org/jira/browse/OFBIZ-6625?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15554839#comment-15554839
]
Jacopo Cappellato commented on OFBIZ-6625:
--
Would any of you please test if this issue is fixed in current trunk?
Thanks
> EcomSEO generates an error when used in multi-tenancy setup
> ---
>
> Key: OFBIZ-6625
> URL: https://issues.apache.org/jira/browse/OFBIZ-6625
> Project: OFBiz
> Issue Type: Bug
> Components: specialpurpose/ecommerce
>Affects Versions: Trunk
>Reporter: Pierre Smits
>Assignee: Jacques Le Roux
>Priority: Critical
> Labels: multi-tenant
> Fix For: Upcoming Branch
>
> Attachments: seocontextfilter.patch
>
>
> When using the ecomseo application of the ecommerce component in a tenant the
> tenant entity can't be accessed, and the following error is returned.
> {code} [java] 2015-09-17 22:44:33,906 |http-bio-8443-exec-8
> |GenericDelegator |I| Can't access entity of entityGroup =
> org.ofbiz.tenant using tenant delegator default#enantId, use base delegator
> instead
> [java] 2015-09-17 22:44:33,906 |http-bio-8443-exec-8 |GenericDelegator
>|E| Failure in findByCondition operation for entity [Tenant]:
> org.ofbiz.entity.GenericEntityException: There is no datasource (Helper)
> configured for the entity-group [org.ofbiz.tenant]; was trying to find
> datasource (helper) for entity [Tenant]. Rolling back transaction.
> [java] org.ofbiz.entity.GenericEntityException: There is no datasource
> (Helper) configured for the entity-group [org.ofbiz.tenant]; was trying to
> find datasource (helper) for entity [Tenant]
> [java] at
> org.ofbiz.entity.GenericDelegator.getEntityHelper(GenericDelegator.java:544)
> ~[ofbiz-entity.jar:?]
> [java] at
> org.ofbiz.entity.GenericDelegator.find(GenericDelegator.java:1774)
> ~[ofbiz-entity.jar:?]
> [java] at
> org.ofbiz.entity.GenericDelegator.findList(GenericDelegator.java:1811)
> [ofbiz-entity.jar:?]
> [java] at
> org.ofbiz.product.category.SeoContextFilter.doFilter(SeoContextFilter.java:300)
> [ofbiz-product.jar:?]
> [java] at
> org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:241)
> [tomcat-7.0.59-catalina.jar:7.0.59]
> [java] at
> org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:208)
> [tomcat-7.0.59-catalina.jar:7.0.59]
> [java] at
> org.ofbiz.product.category.SeoContentUrlFilter.doFilter(SeoContentUrlFilter.java:105)
> [ofbiz-product.jar:?]
> [java] at
> org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:241)
> [tomcat-7.0.59-catalina.jar:7.0.59]
> [java] at
> org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:208)
> [tomcat-7.0.59-catalina.jar:7.0.59]
> [java] at
> org.ofbiz.product.category.CatalogUrlFilter.doFilter(CatalogUrlFilter.java:338)
> [ofbiz-product.jar:?]
> [java] at
> org.ofbiz.product.category.CatalogUrlSeoFilter.doFilter(CatalogUrlSeoFilter.java:68)
> [ofbiz-product.jar:?]
> [java] at
> org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:241)
> [tomcat-7.0.59-catalina.jar:7.0.59]
> [java] at
> org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:208)
> [tomcat-7.0.59-catalina.jar:7.0.59]
> [java] at
> org.apache.catalina.core.StandardWrapperValve.invoke(StandardWrapperValve.java:220)
> [tomcat-7.0.59-catalina.jar:7.0.59]
> [java] at
> org.apache.catalina.core.StandardContextValve.invoke(StandardContextValve.java:122)
> [tomcat-7.0.59-catalina.jar:7.0.59]
> [java] at
> org.apache.catalina.authenticator.AuthenticatorBase.invoke(AuthenticatorBase.java:504)
> [tomcat-7.0.59-catalina.jar:7.0.59]
> [java] at
> org.apache.catalina.core.StandardHostValve.invoke(StandardHostValve.java:170)
> [tomcat-7.0.59-catalina.jar:7.0.59]
> [java] at
> org.apache.catalina.valves.ErrorReportValve.invoke(ErrorReportValve.java:103)
> [tomcat-7.0.59-catalina.jar:7.0.59]
> [java] at
> org.apache.catalina.core.StandardEngineValve.invoke(StandardEngineValve.java:116)
> [tomcat-7.0.59-catalina.jar:7.0.59]
> [java] at
> org.apache.catalina.valves.AccessLogValve.invoke(AccessLogValve.java:950)
> [tomcat-7.0.59-catalina.jar:7.0.59]
> [java] at
> org.apache.catalina.connector.CoyoteAdapter.service(CoyoteAdapter.java:421)
> [tomcat-7.0.59-catalina.jar:7.0.59]
> [java] at
> org.apache.coyote.http11.AbstractHttp11Processor.process(AbstractHttp11Processor.java:1074)
> [tomcat-7.0.59-tomcat-coyote.jar:7.0.59]
> [java] at
[jira] [Closed] (OFBIZ-8338) Tenant - /ecommerce Nullpointer
[ https://issues.apache.org/jira/browse/OFBIZ-8338?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacopo Cappellato closed OFBIZ-8338. Resolution: Fixed > Tenant - /ecommerce Nullpointer > --- > > Key: OFBIZ-8338 > URL: https://issues.apache.org/jira/browse/OFBIZ-8338 > Project: OFBiz > Issue Type: Bug >Reporter: Ingo Wolfmayr >Assignee: Jacopo Cappellato > Attachments: error.txt > > > Current trunk in tenant mode - one tenant with demo data > When uploading an image for a product the following error appears: > SEVERE: Servlet.service() for servlet [default] in context with path > [/ecommerce] threw exception > java.lang.NullPointerException > The /ecommerce app is not accessible. > The full error message attached -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-8319) viewing product sample page causes exception
[ https://issues.apache.org/jira/browse/OFBIZ-8319?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15547541#comment-15547541 ] Jacopo Cappellato commented on OFBIZ-8319: -- Wonderful, thank you! > viewing product sample page causes exception > > > Key: OFBIZ-8319 > URL: https://issues.apache.org/jira/browse/OFBIZ-8319 > Project: OFBiz > Issue Type: Bug > Components: specialpurpose/ecommerce >Affects Versions: Trunk >Reporter: Wai >Assignee: Rohit Koushal > > -set general.properties/multitenant=Y > -go to > https://localhost:8443/catalog/control/EditProductFeatures?productId=WG-9943 > -click on 'product page' link > -error page shows... > java.lang.NullPointerException > org.apache.ofbiz.entity.util.EntityQuery.query(EntityQuery.java:455) > org.apache.ofbiz.entity.util.EntityQuery.queryList(EntityQuery.java:380) > org.apache.ofbiz.product.category.CategoryWorker.getRelatedCategoriesRet(CategoryWorker.java:150) > > org.apache.ofbiz.product.category.CategoryWorker.getRelatedCategoriesRet(CategoryWorker.java:139) > org.apache.ofbiz.product.category.CatalogUrlFilter.doFilter(CatalogUrlFilter.java:229) > > org.apache.ofbiz.webapp.control.ContextFilter.doFilter(ContextFilter.java:209) > It seems that when ofbiz is set to multitenant mode and the tenant associated > with tenantId=null does this issue occur. I don't know if it should be a > configuration issue or a bug. This did not occur prior to the implementation > of the ControlFilter and ContextFilter of r1761304. > How should the tenant associated with tenantId=null be used? Is it consider > special or it is used just like any other tenant? -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-7972) Create a (PoC) plugin system for OFBiz based on Gradle
[ https://issues.apache.org/jira/browse/OFBIZ-7972?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15492598#comment-15492598 ] Jacopo Cappellato commented on OFBIZ-7972: -- I like it. I am looking forward at seeing this code in our repo: after that it will be easier to test it and paly with it and gather further feedback and enhancements from the community. > Create a (PoC) plugin system for OFBiz based on Gradle > -- > > Key: OFBIZ-7972 > URL: https://issues.apache.org/jira/browse/OFBIZ-7972 > Project: OFBiz > Issue Type: Improvement >Affects Versions: Upcoming Branch >Reporter: Taher Alkhateeb >Assignee: Taher Alkhateeb >Priority: Minor > Labels: plugin, proof-of-concept, system > Attachments: OFBIZ-7972.patch, OFBIZ-7972.patch, OFBIZ-7972.patch > > > This JIRA houses the attempt to create a plugin system for OFBiz based on > gradle. The plugin system should have the following features: > - It is independent of the version control system, file system, operating > system and any other environment tools surrounding OFBiz. Instead, it should > be fully integrated with OFBiz. > - It should unify the way OFBiz is extended, both for official supported > plugins and for third party plugins > - The plugin system takes advantage of the concept of a "component" in OFBiz > and utilize it as the building block for plugins > - The plugin system supports the concepts of "Repository" and "Dependency > Management". If possible, the plugin system will utilize these concepts > directly from Gradle instead of writing them from scratch. > The initial API for the plugin system will be small and expands as needed. > The API should include the following gradle tasks: > - createPlugin: creates a new plugin based on templates and place it in the > plugins directory > - installPlugin: Activate a plugin and run Install. Plugin must exist in > /specialpurpose > - uninstallPlugin: Deactivate a plugin and run its uninstall script > - publishPlugin: publish a plugin to local maven repository > - pullPlugin: download a plugin with its dependencies (plugins) from a > repository and install them -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Closed] (OFBIZ-5636) Add WorkEffort Timesheet to Invoice or to New Invoice does not work
[ https://issues.apache.org/jira/browse/OFBIZ-5636?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacopo Cappellato closed OFBIZ-5636. Resolution: Fixed > Add WorkEffort Timesheet to Invoice or to New Invoice does not work > --- > > Key: OFBIZ-5636 > URL: https://issues.apache.org/jira/browse/OFBIZ-5636 > Project: OFBiz > Issue Type: Bug > Components: workeffort >Affects Versions: Release Branch 11.04, Release Branch 12.04, Release > Branch 13.07, Trunk > Environment: Windows >Reporter: Ahmad Ludin >Assignee: Jacopo Cappellato >Priority: Minor > Labels: WorkEffort, timesheet > Attachments: OFBIZ-5636.patch > > > In work effort menu, My time, create a time sheet with time entries, then to > add the time entries to an existing Invoice or a New invoice throws the > following error. Note: Time entries to invoice from scrum and projectmgr > application works. > Error running the simple-method: Entity value not found with name: workEffort > Method = createTimeEntryInvoiceItemsInline, File = > file:/applications/workeffort/script/org/ofbiz/workeffort/timesheet/TimesheetServices.xml, > Element = , Line 160null -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Assigned] (OFBIZ-5636) Add WorkEffort Timesheet to Invoice or to New Invoice does not work
[ https://issues.apache.org/jira/browse/OFBIZ-5636?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacopo Cappellato reassigned OFBIZ-5636: Assignee: Jacopo Cappellato (was: Avnindra Sharma) Fix in trunk with rev. 1761309 > Add WorkEffort Timesheet to Invoice or to New Invoice does not work > --- > > Key: OFBIZ-5636 > URL: https://issues.apache.org/jira/browse/OFBIZ-5636 > Project: OFBiz > Issue Type: Bug > Components: workeffort >Affects Versions: Release Branch 11.04, Release Branch 12.04, Release > Branch 13.07, Trunk > Environment: Windows >Reporter: Ahmad Ludin >Assignee: Jacopo Cappellato >Priority: Minor > Labels: WorkEffort, timesheet > Attachments: OFBIZ-5636.patch > > > In work effort menu, My time, create a time sheet with time entries, then to > add the time entries to an existing Invoice or a New invoice throws the > following error. Note: Time entries to invoice from scrum and projectmgr > application works. > Error running the simple-method: Entity value not found with name: workEffort > Method = createTimeEntryInvoiceItemsInline, File = > file:/applications/workeffort/script/org/ofbiz/workeffort/timesheet/TimesheetServices.xml, > Element = , Line 160null -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-7480) Require check on Create Facility Content Screen
[ https://issues.apache.org/jira/browse/OFBIZ-7480?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15500594#comment-15500594 ] Jacopo Cappellato commented on OFBIZ-7480: -- Hi [~avnindra.sharma] you are indeed right! Are you going to provide the patch for the Facility Content screen or I should close this issue? Thanks Jacopo > Require check on Create Facility Content Screen > --- > > Key: OFBIZ-7480 > URL: https://issues.apache.org/jira/browse/OFBIZ-7480 > Project: OFBiz > Issue Type: Improvement >Reporter: Avnindra Sharma >Assignee: Jacopo Cappellato >Priority: Minor > Fix For: Trunk > > Attachments: OFBIZ-7480.patch > > > Navigate to Content in facilities and add Facility Content. Require check is > not there on mandatory fields. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-8250) SvnInfo.ftl and GitInfo.ftl are not generated by default
[ https://issues.apache.org/jira/browse/OFBIZ-8250?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15501253#comment-15501253 ] Jacopo Cappellato commented on OFBIZ-8250: -- I don't see a problem with the header, since it is a comment that doesn't cause any confusion or issue while reviewing or applying the patch. > SvnInfo.ftl and GitInfo.ftl are not generated by default > > > Key: OFBIZ-8250 > URL: https://issues.apache.org/jira/browse/OFBIZ-8250 > Project: OFBiz > Issue Type: Bug > Components: ALL APPLICATIONS >Affects Versions: Trunk >Reporter: Michael Brohl >Assignee: Michael Brohl >Priority: Minor > Fix For: Upcoming Branch > > Attachments: OFBIZ-8250-2.patch, OFBIZ-8250.patch > > > The two files are not generated which results in an FTL stacktrace in the > footer of the backend applications. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-8250) SvnInfo.ftl and GitInfo.ftl are not generated by default
[ https://issues.apache.org/jira/browse/OFBIZ-8250?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15502792#comment-15502792 ] Jacopo Cappellato commented on OFBIZ-8250: -- Thank you [~mbrohl] for providing the fix for this annoying error; it was bothering me so thanks for taking the time to implement the patch! > SvnInfo.ftl and GitInfo.ftl are not generated by default > > > Key: OFBIZ-8250 > URL: https://issues.apache.org/jira/browse/OFBIZ-8250 > Project: OFBiz > Issue Type: Bug > Components: ALL APPLICATIONS >Affects Versions: Trunk >Reporter: Michael Brohl >Assignee: Michael Brohl >Priority: Minor > Fix For: Upcoming Branch > > Attachments: Image 014.png, OFBIZ-8250-2.patch, OFBIZ-8250.patch > > > The two files are not generated which results in an FTL stacktrace in the > footer of the backend applications. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Assigned] (OFBIZ-5169) Removing Javolution from framework components
[ https://issues.apache.org/jira/browse/OFBIZ-5169?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacopo Cappellato reassigned OFBIZ-5169: Assignee: Jacopo Cappellato > Removing Javolution from framework components > - > > Key: OFBIZ-5169 > URL: https://issues.apache.org/jira/browse/OFBIZ-5169 > Project: OFBiz > Issue Type: Improvement > Components: framework >Affects Versions: Trunk >Reporter: Varun Bhansaly >Assignee: Jacopo Cappellato >Priority: Minor > Attachments: framework-FastList-removed.patch > > > a. Remove static instances of Javolution objects. > b. Remove other uses of Javolution objects. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (OFBIZ-5169) Removing Javolution from framework components
[ https://issues.apache.org/jira/browse/OFBIZ-5169?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacopo Cappellato updated OFBIZ-5169: - Fix Version/s: Upcoming Branch > Removing Javolution from framework components > - > > Key: OFBIZ-5169 > URL: https://issues.apache.org/jira/browse/OFBIZ-5169 > Project: OFBiz > Issue Type: Improvement > Components: framework >Affects Versions: Trunk >Reporter: Varun Bhansaly >Assignee: Jacopo Cappellato >Priority: Minor > Fix For: Upcoming Branch > > Attachments: framework-FastList-removed.patch > > > a. Remove static instances of Javolution objects. > b. Remove other uses of Javolution objects. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Closed] (OFBIZ-5169) Removing Javolution from framework components
[ https://issues.apache.org/jira/browse/OFBIZ-5169?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacopo Cappellato closed OFBIZ-5169. Resolution: Fixed EntitySaxReader has been converted and Javolution removed in rev. 1762079. Please help testing the xml data import (in its various forms) and report any issues you may discover since I had to implement several changes in EntitySaxReader (which is the class responsible for most of the xml data loading in OFBiz). > Removing Javolution from framework components > - > > Key: OFBIZ-5169 > URL: https://issues.apache.org/jira/browse/OFBIZ-5169 > Project: OFBiz > Issue Type: Improvement > Components: framework >Affects Versions: Trunk >Reporter: Varun Bhansaly >Assignee: Jacopo Cappellato >Priority: Minor > Attachments: framework-FastList-removed.patch > > > a. Remove static instances of Javolution objects. > b. Remove other uses of Javolution objects. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-6243) Have a readme in every component
[ https://issues.apache.org/jira/browse/OFBIZ-6243?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15512680#comment-15512680 ] Jacopo Cappellato commented on OFBIZ-6243: -- It is concerning that, rather than listening to another committer's constructive review, Jacques decided to ignore and do the commit. Vetoing a commit is always an unpleasant event that happened very few times in the history of OFBiz and I hope we will not have to go into this direction this time. > Have a readme in every component > > > Key: OFBIZ-6243 > URL: https://issues.apache.org/jira/browse/OFBIZ-6243 > Project: OFBiz > Issue Type: Improvement > Components: ALL COMPONENTS >Affects Versions: Trunk >Reporter: Pierre Smits >Assignee: Jacques Le Roux >Priority: Minor > Fix For: Upcoming Branch > > > A readme should be the first starting point of each component for developers > have references to the placeholder in the wiki, in jira and in svn/viewvc -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-8292) Use ignore_missing option of the <#include Freemarker directive when fixed
[ https://issues.apache.org/jira/browse/OFBIZ-8292?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15506794#comment-15506794 ] Jacopo Cappellato commented on OFBIZ-8292: -- Fix committed in trunk with rev. 1761586 > Use ignore_missing option of the <#include Freemarker directive when fixed > -- > > Key: OFBIZ-8292 > URL: https://issues.apache.org/jira/browse/OFBIZ-8292 > Project: OFBiz > Issue Type: Improvement > Components: framework >Affects Versions: Trunk >Reporter: Jacques Le Roux >Assignee: Jacques Le Roux >Priority: Trivial > > Working on OFBIZ-8250 and after Deepak at OFBIZ-7942 (too bad I missed that > :/) I found that the ignore_missing option of the <#include Freemarker > directive does not work. I reported to the Freemarker incubating project. > Hopefully this will be fixed. It will then remove the need of creating empty > files for the svn and git info footers when building. > In the meantime I'll provide the change in the themes footers. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-7264) Use ShoppingCartEvents.getCartObject() to get shopping cart
[
https://issues.apache.org/jira/browse/OFBIZ-7264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15498625#comment-15498625
]
Jacopo Cappellato commented on OFBIZ-7264:
--
While I agree that the changes proposed in this patch should be committed, it
would be useful to double check if any of the client code that is modified was
performing a null check on the cart object: if this is the case, then we should
either remove the redundant check or do not modify the client code if the logic
in case of a null cart object is relevant: I am saying this because
getCartObject will actually create a new cart if one is not found while
request.getAttribute("shoppingCart") obviously doesn't.
> Use ShoppingCartEvents.getCartObject() to get shopping cart
>
>
> Key: OFBIZ-7264
> URL: https://issues.apache.org/jira/browse/OFBIZ-7264
> Project: OFBiz
> Issue Type: Improvement
>Reporter: Deepak Dixit
>Assignee: Jacopo Cappellato
> Attachments: OFBIZ-7264.patch
>
>
> As per current code base in many places shoppingcart is get directly from
> session, we have method getCartObject() in ShoppingCartEvetns.java to get the
> shoppingcart.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (OFBIZ-7264) Use ShoppingCartEvents.getCartObject() to get shopping cart
[
https://issues.apache.org/jira/browse/OFBIZ-7264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15498618#comment-15498618
]
Jacopo Cappellato commented on OFBIZ-7264:
--
I think there is an issue in this patch:
{code}
Index:
applications/order/src/org/ofbiz/order/shoppingcart/ShoppingCartEvents.java
===
--- applications/order/src/org/ofbiz/order/shoppingcart/ShoppingCartEvents.java
(revision 1748917)
+++ applications/order/src/org/ofbiz/order/shoppingcart/ShoppingCartEvents.java
(working copy)
@@ -949,7 +949,7 @@
/** Gets or creates the shopping cart object */
public static ShoppingCart getCartObject(HttpServletRequest request,
Locale locale, String currencyUom) {
LocalDispatcher dispatcher = (LocalDispatcher)
request.getAttribute("dispatcher");
-ShoppingCart cart = (ShoppingCart)
request.getAttribute("shoppingCart");
+ShoppingCart cart = getCartObject(request);
HttpSession session = request.getSession(true);
if (cart == null) {
cart = (ShoppingCart) session.getAttribute("shoppingCart");
{code}
The above change would end up in a call loop of getCartObject calls.
> Use ShoppingCartEvents.getCartObject() to get shopping cart
>
>
> Key: OFBIZ-7264
> URL: https://issues.apache.org/jira/browse/OFBIZ-7264
> Project: OFBiz
> Issue Type: Improvement
>Reporter: Deepak Dixit
>Assignee: Jacopo Cappellato
> Attachments: OFBIZ-7264.patch
>
>
> As per current code base in many places shoppingcart is get directly from
> session, we have method getCartObject() in ShoppingCartEvetns.java to get the
> shoppingcart.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Assigned] (OFBIZ-7264) Use ShoppingCartEvents.getCartObject() to get shopping cart
[ https://issues.apache.org/jira/browse/OFBIZ-7264?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacopo Cappellato reassigned OFBIZ-7264: Assignee: Jacopo Cappellato (was: Deepak Dixit) > Use ShoppingCartEvents.getCartObject() to get shopping cart > > > Key: OFBIZ-7264 > URL: https://issues.apache.org/jira/browse/OFBIZ-7264 > Project: OFBiz > Issue Type: Improvement >Reporter: Deepak Dixit >Assignee: Jacopo Cappellato > Attachments: OFBIZ-7264.patch > > > As per current code base in many places shoppingcart is get directly from > session, we have method getCartObject() in ShoppingCartEvetns.java to get the > shoppingcart. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Assigned] (OFBIZ-8232) Improve Dutch labels for commonext component
[ https://issues.apache.org/jira/browse/OFBIZ-8232?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacopo Cappellato reassigned OFBIZ-8232: Assignee: Jacopo Cappellato > Improve Dutch labels for commonext component > > > Key: OFBIZ-8232 > URL: https://issues.apache.org/jira/browse/OFBIZ-8232 > Project: OFBiz > Issue Type: Improvement > Components: commonext >Affects Versions: Trunk >Reporter: Pierre Smits >Assignee: Jacopo Cappellato >Priority: Minor > Labels: labels, refactoring > Attachments: OFBIZ-8232-CommonExtUiLabels.xml.patch > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Assigned] (OFBIZ-7698) Remove un-used variables from Java and Groovy files.
[ https://issues.apache.org/jira/browse/OFBIZ-7698?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacopo Cappellato reassigned OFBIZ-7698: Assignee: Jacopo Cappellato > Remove un-used variables from Java and Groovy files. > > > Key: OFBIZ-7698 > URL: https://issues.apache.org/jira/browse/OFBIZ-7698 > Project: OFBiz > Issue Type: Improvement > Components: ALL COMPONENTS >Reporter: Deepak Nigam >Assignee: Jacopo Cappellato > > In many files we have some unused variables which are overhead for the > system, we can remove these variables. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Assigned] (OFBIZ-7881) Remove unused variables from java files of accounting component
[ https://issues.apache.org/jira/browse/OFBIZ-7881?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacopo Cappellato reassigned OFBIZ-7881: Assignee: Jacopo Cappellato > Remove unused variables from java files of accounting component > --- > > Key: OFBIZ-7881 > URL: https://issues.apache.org/jira/browse/OFBIZ-7881 > Project: OFBiz > Issue Type: Sub-task > Components: accounting >Reporter: Pradhan Yash Sharma >Assignee: Jacopo Cappellato >Priority: Minor > Fix For: Trunk > > Attachments: OFBIZ-7881.patch > > > Remove unused variables from java files of accounting component. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Closed] (OFBIZ-7698) Remove un-used variables from Java and Groovy files.
[ https://issues.apache.org/jira/browse/OFBIZ-7698?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacopo Cappellato closed OFBIZ-7698. Resolution: Fixed Fix Version/s: Upcoming Branch > Remove un-used variables from Java and Groovy files. > > > Key: OFBIZ-7698 > URL: https://issues.apache.org/jira/browse/OFBIZ-7698 > Project: OFBiz > Issue Type: Improvement > Components: ALL COMPONENTS >Reporter: Deepak Nigam >Assignee: Jacopo Cappellato > Fix For: Upcoming Branch > > > In many files we have some unused variables which are overhead for the > system, we can remove these variables. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-7480) Require check on Create Facility Content Screen
[ https://issues.apache.org/jira/browse/OFBIZ-7480?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15498788#comment-15498788 ] Jacopo Cappellato commented on OFBIZ-7480: -- Patch committed with rev. 1761190, thanks Avnindra > Require check on Create Facility Content Screen > --- > > Key: OFBIZ-7480 > URL: https://issues.apache.org/jira/browse/OFBIZ-7480 > Project: OFBiz > Issue Type: Improvement >Reporter: Avnindra Sharma >Assignee: Jacopo Cappellato >Priority: Minor > Fix For: Trunk > > Attachments: OFBIZ-7480.patch > > > Navigate to Content in facilities and add Facility Content. Require check is > not there on mandatory fields. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Assigned] (OFBIZ-7887) Remove unused variables from java files of order component
[ https://issues.apache.org/jira/browse/OFBIZ-7887?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacopo Cappellato reassigned OFBIZ-7887: Assignee: Jacopo Cappellato > Remove unused variables from java files of order component > -- > > Key: OFBIZ-7887 > URL: https://issues.apache.org/jira/browse/OFBIZ-7887 > Project: OFBiz > Issue Type: Sub-task > Components: order >Affects Versions: Trunk >Reporter: Pradhan Yash Sharma >Assignee: Jacopo Cappellato >Priority: Minor > Attachments: OFBIZ-7887.patch > > > Remove unused variables from java files of order component -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Assigned] (OFBIZ-8222) Edit Calendar Exception week for "Calendar" is broken
[ https://issues.apache.org/jira/browse/OFBIZ-8222?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacopo Cappellato reassigned OFBIZ-8222: Assignee: Jacopo Cappellato (was: Avnindra Sharma) > Edit Calendar Exception week for "Calendar" is broken > -- > > Key: OFBIZ-8222 > URL: https://issues.apache.org/jira/browse/OFBIZ-8222 > Project: OFBiz > Issue Type: Bug > Components: manufacturing >Reporter: Avnindra Sharma >Assignee: Jacopo Cappellato > Fix For: Trunk > > Attachments: OFBIZ-8222.patch, screenshot-1.png > > > In manufacturing component, navigate to calendar sub bar and there navigate > to Exception week. The screen is broken. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Closed] (OFBIZ-7464) Require check on Add Facility Party Role Screen
[ https://issues.apache.org/jira/browse/OFBIZ-7464?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacopo Cappellato closed OFBIZ-7464. Resolution: Fixed Fix Version/s: Upcoming Branch Thanks Avninda, your patch is in with rev. 1761187 > Require check on Add Facility Party Role Screen > --- > > Key: OFBIZ-7464 > URL: https://issues.apache.org/jira/browse/OFBIZ-7464 > Project: OFBiz > Issue Type: Sub-task >Reporter: Avnindra Sharma >Assignee: Jacopo Cappellato >Priority: Minor > Fix For: Upcoming Branch > > Attachments: OFBIZ-7464.patch > > > Navigate to Add Facility Party Role screen, no require check is there on > mandatory fields. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Assigned] (OFBIZ-7884) Remove unused variables from java files of content component
[ https://issues.apache.org/jira/browse/OFBIZ-7884?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacopo Cappellato reassigned OFBIZ-7884: Assignee: Jacopo Cappellato > Remove unused variables from java files of content component > > > Key: OFBIZ-7884 > URL: https://issues.apache.org/jira/browse/OFBIZ-7884 > Project: OFBiz > Issue Type: Sub-task > Components: content >Affects Versions: Trunk >Reporter: Pradhan Yash Sharma >Assignee: Jacopo Cappellato >Priority: Minor > Attachments: OFBIZ-7884.patch > > > Remove unused variables from java files of content component. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Assigned] (OFBIZ-7886) Remove unused variables from java files of workeffort component
[ https://issues.apache.org/jira/browse/OFBIZ-7886?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacopo Cappellato reassigned OFBIZ-7886: Assignee: Jacopo Cappellato > Remove unused variables from java files of workeffort component > --- > > Key: OFBIZ-7886 > URL: https://issues.apache.org/jira/browse/OFBIZ-7886 > Project: OFBiz > Issue Type: Sub-task > Components: workeffort >Affects Versions: Trunk >Reporter: Pradhan Yash Sharma >Assignee: Jacopo Cappellato >Priority: Minor > Attachments: OFBIZ-7886.patch > > > Remove unused variables from java files of workeffort component -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Assigned] (OFBIZ-7885) Remove unused variables from java files of product component
[ https://issues.apache.org/jira/browse/OFBIZ-7885?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacopo Cappellato reassigned OFBIZ-7885: Assignee: Jacopo Cappellato > Remove unused variables from java files of product component > > > Key: OFBIZ-7885 > URL: https://issues.apache.org/jira/browse/OFBIZ-7885 > Project: OFBiz > Issue Type: Sub-task > Components: product >Affects Versions: Trunk >Reporter: Pradhan Yash Sharma >Assignee: Jacopo Cappellato >Priority: Minor > Attachments: OFBIZ-7885.patch > > > Remove unused variables from java files of product component. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Closed] (OFBIZ-7885) Remove unused variables from java files of product component
[ https://issues.apache.org/jira/browse/OFBIZ-7885?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacopo Cappellato closed OFBIZ-7885. Resolution: Fixed Fix Version/s: Upcoming Branch Thanks Pradhan, your patch is in rev. 1761176 > Remove unused variables from java files of product component > > > Key: OFBIZ-7885 > URL: https://issues.apache.org/jira/browse/OFBIZ-7885 > Project: OFBiz > Issue Type: Sub-task > Components: product >Affects Versions: Trunk >Reporter: Pradhan Yash Sharma >Assignee: Jacopo Cappellato >Priority: Minor > Fix For: Upcoming Branch > > Attachments: OFBIZ-7885.patch > > > Remove unused variables from java files of product component. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-7480) Require check on Create Facility Content Screen
[ https://issues.apache.org/jira/browse/OFBIZ-7480?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15498781#comment-15498781 ] Jacopo Cappellato commented on OFBIZ-7480: -- The patch attached here addresses a different issue of the one reported: it fixes the Edit Facility Screen. If you have also the fix for the Facility Content screen please attach it to this ticket. Also, it would be nice to have a fix also for the Create Facility screen. https://localhost:8443/facility/control/CreateFacility > Require check on Create Facility Content Screen > --- > > Key: OFBIZ-7480 > URL: https://issues.apache.org/jira/browse/OFBIZ-7480 > Project: OFBiz > Issue Type: Improvement >Reporter: Avnindra Sharma >Assignee: Jacopo Cappellato >Priority: Minor > Fix For: Trunk > > Attachments: OFBIZ-7480.patch > > > Navigate to Content in facilities and add Facility Content. Require check is > not there on mandatory fields. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Closed] (OFBIZ-8232) Improve Dutch labels for commonext component
[ https://issues.apache.org/jira/browse/OFBIZ-8232?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacopo Cappellato closed OFBIZ-8232. Resolution: Fixed Fix Version/s: Upcoming Branch Thanks Pierre, committed in rev. 1761168 > Improve Dutch labels for commonext component > > > Key: OFBIZ-8232 > URL: https://issues.apache.org/jira/browse/OFBIZ-8232 > Project: OFBiz > Issue Type: Improvement > Components: commonext >Affects Versions: Trunk >Reporter: Pierre Smits >Assignee: Jacopo Cappellato >Priority: Minor > Labels: labels, refactoring > Fix For: Upcoming Branch > > Attachments: OFBIZ-8232-CommonExtUiLabels.xml.patch > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Closed] (OFBIZ-7881) Remove unused variables from java files of accounting component
[ https://issues.apache.org/jira/browse/OFBIZ-7881?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacopo Cappellato closed OFBIZ-7881. Resolution: Fixed Fix Version/s: (was: Trunk) Upcoming Branch Thanks Pradhan, your patch is in rev. 1761176 > Remove unused variables from java files of accounting component > --- > > Key: OFBIZ-7881 > URL: https://issues.apache.org/jira/browse/OFBIZ-7881 > Project: OFBiz > Issue Type: Sub-task > Components: accounting >Reporter: Pradhan Yash Sharma >Assignee: Jacopo Cappellato >Priority: Minor > Fix For: Upcoming Branch > > Attachments: OFBIZ-7881.patch > > > Remove unused variables from java files of accounting component. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Closed] (OFBIZ-8222) Edit Calendar Exception week for "Calendar" is broken
[ https://issues.apache.org/jira/browse/OFBIZ-8222?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacopo Cappellato closed OFBIZ-8222. Resolution: Fixed Fix Version/s: (was: Trunk) Upcoming Branch Thank you Avnindra, your patch is in trunk with rev. 1761196 > Edit Calendar Exception week for "Calendar" is broken > -- > > Key: OFBIZ-8222 > URL: https://issues.apache.org/jira/browse/OFBIZ-8222 > Project: OFBiz > Issue Type: Bug > Components: manufacturing >Reporter: Avnindra Sharma >Assignee: Jacopo Cappellato > Fix For: Upcoming Branch > > Attachments: OFBIZ-8222.patch, screenshot-1.png > > > In manufacturing component, navigate to calendar sub bar and there navigate > to Exception week. The screen is broken. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-7970) Reorder the component loading in the application stack
[ https://issues.apache.org/jira/browse/OFBIZ-7970?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15432375#comment-15432375 ] Jacopo Cappellato commented on OFBIZ-7970: -- This is just one example of two components that are interdependent and the order in which they are loaded is not relevant: in order to work properly the system needs both. A better solution would be to start thinking about refactoring completely our "applications": # the webapps could be merged into one "backend" application (in which permissions drives the screens/services available to users) # the services (that are interdependent) are grouped into one component but they could still be kept into separate files, as it is now, to categorize them (product, party, workeffort, accounting etc...); similarly to what we did with the "datamodel" component > Reorder the component loading in the application stack > -- > > Key: OFBIZ-7970 > URL: https://issues.apache.org/jira/browse/OFBIZ-7970 > Project: OFBiz > Issue Type: Improvement > Components: ALL APPLICATIONS >Affects Versions: Trunk >Reporter: Pierre Smits >Assignee: Pierre Smits > Attachments: OFBIZ-7970-component-load.xml-v2.patch, > OFBIZ-7970-component-load.xml.patch > > > While working on the demo data in the ecommerce component, I noticed that the > order of components in the application stack are not ordered correctly. > This is related to OFBIZ-7016 -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-8338) Tenant - /ecommerce Nullpointer
[ https://issues.apache.org/jira/browse/OFBIZ-8338?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15532347#comment-15532347 ] Jacopo Cappellato commented on OFBIZ-8338: -- Thank you for the report [~iwolf]! I suspect it may be cause by my recent refactoring (which is a work in progress) of the web filter chains of OFBiz. I am looking at it now, the error log was useful but it would greatly help if you could also provide the steps to recreate the issue (i.e. which screen you have used etc..) Thank you > Tenant - /ecommerce Nullpointer > --- > > Key: OFBIZ-8338 > URL: https://issues.apache.org/jira/browse/OFBIZ-8338 > Project: OFBiz > Issue Type: Bug >Reporter: Ingo Wolfmayr >Assignee: Jacopo Cappellato > Attachments: error.txt > > > Current trunk in tenant mode - one tenant with demo data > When uploading an image for a product the following error appears: > SEVERE: Servlet.service() for servlet [default] in context with path > [/ecommerce] threw exception > java.lang.NullPointerException > The /ecommerce app is not accessible. > The full error message attached -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Assigned] (OFBIZ-8338) Tenant - /ecommerce Nullpointer
[ https://issues.apache.org/jira/browse/OFBIZ-8338?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacopo Cappellato reassigned OFBIZ-8338: Assignee: Jacopo Cappellato > Tenant - /ecommerce Nullpointer > --- > > Key: OFBIZ-8338 > URL: https://issues.apache.org/jira/browse/OFBIZ-8338 > Project: OFBiz > Issue Type: Bug >Reporter: Ingo Wolfmayr >Assignee: Jacopo Cappellato > Attachments: error.txt > > > Current trunk in tenant mode - one tenant with demo data > When uploading an image for a product the following error appears: > SEVERE: Servlet.service() for servlet [default] in context with path > [/ecommerce] threw exception > java.lang.NullPointerException > The /ecommerce app is not accessible. > The full error message attached -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-6625) EcomSEO generates an error when used in multi-tenancy setup
[
https://issues.apache.org/jira/browse/OFBIZ-6625?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15588068#comment-15588068
]
Jacopo Cappellato commented on OFBIZ-6625:
--
OFBIZ-8338 and OFBIZ-8319
> EcomSEO generates an error when used in multi-tenancy setup
> ---
>
> Key: OFBIZ-6625
> URL: https://issues.apache.org/jira/browse/OFBIZ-6625
> Project: OFBiz
> Issue Type: Bug
> Components: specialpurpose/ecommerce
>Affects Versions: Trunk
>Reporter: Pierre Smits
>Assignee: Jacques Le Roux
> Labels: multi-tenant
> Fix For: Upcoming Branch
>
> Attachments: seocontextfilter.patch
>
>
> When using the ecomseo application of the ecommerce component in a tenant the
> tenant entity can't be accessed, and the following error is returned.
> {code} [java] 2015-09-17 22:44:33,906 |http-bio-8443-exec-8
> |GenericDelegator |I| Can't access entity of entityGroup =
> org.ofbiz.tenant using tenant delegator default#enantId, use base delegator
> instead
> [java] 2015-09-17 22:44:33,906 |http-bio-8443-exec-8 |GenericDelegator
>|E| Failure in findByCondition operation for entity [Tenant]:
> org.ofbiz.entity.GenericEntityException: There is no datasource (Helper)
> configured for the entity-group [org.ofbiz.tenant]; was trying to find
> datasource (helper) for entity [Tenant]. Rolling back transaction.
> [java] org.ofbiz.entity.GenericEntityException: There is no datasource
> (Helper) configured for the entity-group [org.ofbiz.tenant]; was trying to
> find datasource (helper) for entity [Tenant]
> [java] at
> org.ofbiz.entity.GenericDelegator.getEntityHelper(GenericDelegator.java:544)
> ~[ofbiz-entity.jar:?]
> [java] at
> org.ofbiz.entity.GenericDelegator.find(GenericDelegator.java:1774)
> ~[ofbiz-entity.jar:?]
> [java] at
> org.ofbiz.entity.GenericDelegator.findList(GenericDelegator.java:1811)
> [ofbiz-entity.jar:?]
> [java] at
> org.ofbiz.product.category.SeoContextFilter.doFilter(SeoContextFilter.java:300)
> [ofbiz-product.jar:?]
> [java] at
> org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:241)
> [tomcat-7.0.59-catalina.jar:7.0.59]
> [java] at
> org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:208)
> [tomcat-7.0.59-catalina.jar:7.0.59]
> [java] at
> org.ofbiz.product.category.SeoContentUrlFilter.doFilter(SeoContentUrlFilter.java:105)
> [ofbiz-product.jar:?]
> [java] at
> org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:241)
> [tomcat-7.0.59-catalina.jar:7.0.59]
> [java] at
> org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:208)
> [tomcat-7.0.59-catalina.jar:7.0.59]
> [java] at
> org.ofbiz.product.category.CatalogUrlFilter.doFilter(CatalogUrlFilter.java:338)
> [ofbiz-product.jar:?]
> [java] at
> org.ofbiz.product.category.CatalogUrlSeoFilter.doFilter(CatalogUrlSeoFilter.java:68)
> [ofbiz-product.jar:?]
> [java] at
> org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:241)
> [tomcat-7.0.59-catalina.jar:7.0.59]
> [java] at
> org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:208)
> [tomcat-7.0.59-catalina.jar:7.0.59]
> [java] at
> org.apache.catalina.core.StandardWrapperValve.invoke(StandardWrapperValve.java:220)
> [tomcat-7.0.59-catalina.jar:7.0.59]
> [java] at
> org.apache.catalina.core.StandardContextValve.invoke(StandardContextValve.java:122)
> [tomcat-7.0.59-catalina.jar:7.0.59]
> [java] at
> org.apache.catalina.authenticator.AuthenticatorBase.invoke(AuthenticatorBase.java:504)
> [tomcat-7.0.59-catalina.jar:7.0.59]
> [java] at
> org.apache.catalina.core.StandardHostValve.invoke(StandardHostValve.java:170)
> [tomcat-7.0.59-catalina.jar:7.0.59]
> [java] at
> org.apache.catalina.valves.ErrorReportValve.invoke(ErrorReportValve.java:103)
> [tomcat-7.0.59-catalina.jar:7.0.59]
> [java] at
> org.apache.catalina.core.StandardEngineValve.invoke(StandardEngineValve.java:116)
> [tomcat-7.0.59-catalina.jar:7.0.59]
> [java] at
> org.apache.catalina.valves.AccessLogValve.invoke(AccessLogValve.java:950)
> [tomcat-7.0.59-catalina.jar:7.0.59]
> [java] at
> org.apache.catalina.connector.CoyoteAdapter.service(CoyoteAdapter.java:421)
> [tomcat-7.0.59-catalina.jar:7.0.59]
> [java] at
> org.apache.coyote.http11.AbstractHttp11Processor.process(AbstractHttp11Processor.java:1074)
> [tomcat-7.0.59-tomcat-coyote.jar:7.0.59]
> [java] at
>
[jira] [Commented] (OFBIZ-6625) EcomSEO generates an error when used in multi-tenancy setup
[
https://issues.apache.org/jira/browse/OFBIZ-6625?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15585552#comment-15585552
]
Jacopo Cappellato commented on OFBIZ-6625:
--
I have fixed the error (reported in this ticket) that was introduced by my
recent refactoring: after my fix the behavior of the ecommerce application
should be the same as before the refactoring.
My refactoring and my fix are not relevant in the context of enabling the
ecommerce application to work in multitenant mode.
> EcomSEO generates an error when used in multi-tenancy setup
> ---
>
> Key: OFBIZ-6625
> URL: https://issues.apache.org/jira/browse/OFBIZ-6625
> Project: OFBiz
> Issue Type: Bug
> Components: specialpurpose/ecommerce
>Affects Versions: Trunk
>Reporter: Pierre Smits
>Assignee: Jacques Le Roux
>Priority: Critical
> Labels: multi-tenant
> Fix For: Upcoming Branch
>
> Attachments: seocontextfilter.patch
>
>
> When using the ecomseo application of the ecommerce component in a tenant the
> tenant entity can't be accessed, and the following error is returned.
> {code} [java] 2015-09-17 22:44:33,906 |http-bio-8443-exec-8
> |GenericDelegator |I| Can't access entity of entityGroup =
> org.ofbiz.tenant using tenant delegator default#enantId, use base delegator
> instead
> [java] 2015-09-17 22:44:33,906 |http-bio-8443-exec-8 |GenericDelegator
>|E| Failure in findByCondition operation for entity [Tenant]:
> org.ofbiz.entity.GenericEntityException: There is no datasource (Helper)
> configured for the entity-group [org.ofbiz.tenant]; was trying to find
> datasource (helper) for entity [Tenant]. Rolling back transaction.
> [java] org.ofbiz.entity.GenericEntityException: There is no datasource
> (Helper) configured for the entity-group [org.ofbiz.tenant]; was trying to
> find datasource (helper) for entity [Tenant]
> [java] at
> org.ofbiz.entity.GenericDelegator.getEntityHelper(GenericDelegator.java:544)
> ~[ofbiz-entity.jar:?]
> [java] at
> org.ofbiz.entity.GenericDelegator.find(GenericDelegator.java:1774)
> ~[ofbiz-entity.jar:?]
> [java] at
> org.ofbiz.entity.GenericDelegator.findList(GenericDelegator.java:1811)
> [ofbiz-entity.jar:?]
> [java] at
> org.ofbiz.product.category.SeoContextFilter.doFilter(SeoContextFilter.java:300)
> [ofbiz-product.jar:?]
> [java] at
> org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:241)
> [tomcat-7.0.59-catalina.jar:7.0.59]
> [java] at
> org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:208)
> [tomcat-7.0.59-catalina.jar:7.0.59]
> [java] at
> org.ofbiz.product.category.SeoContentUrlFilter.doFilter(SeoContentUrlFilter.java:105)
> [ofbiz-product.jar:?]
> [java] at
> org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:241)
> [tomcat-7.0.59-catalina.jar:7.0.59]
> [java] at
> org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:208)
> [tomcat-7.0.59-catalina.jar:7.0.59]
> [java] at
> org.ofbiz.product.category.CatalogUrlFilter.doFilter(CatalogUrlFilter.java:338)
> [ofbiz-product.jar:?]
> [java] at
> org.ofbiz.product.category.CatalogUrlSeoFilter.doFilter(CatalogUrlSeoFilter.java:68)
> [ofbiz-product.jar:?]
> [java] at
> org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:241)
> [tomcat-7.0.59-catalina.jar:7.0.59]
> [java] at
> org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:208)
> [tomcat-7.0.59-catalina.jar:7.0.59]
> [java] at
> org.apache.catalina.core.StandardWrapperValve.invoke(StandardWrapperValve.java:220)
> [tomcat-7.0.59-catalina.jar:7.0.59]
> [java] at
> org.apache.catalina.core.StandardContextValve.invoke(StandardContextValve.java:122)
> [tomcat-7.0.59-catalina.jar:7.0.59]
> [java] at
> org.apache.catalina.authenticator.AuthenticatorBase.invoke(AuthenticatorBase.java:504)
> [tomcat-7.0.59-catalina.jar:7.0.59]
> [java] at
> org.apache.catalina.core.StandardHostValve.invoke(StandardHostValve.java:170)
> [tomcat-7.0.59-catalina.jar:7.0.59]
> [java] at
> org.apache.catalina.valves.ErrorReportValve.invoke(ErrorReportValve.java:103)
> [tomcat-7.0.59-catalina.jar:7.0.59]
> [java] at
> org.apache.catalina.core.StandardEngineValve.invoke(StandardEngineValve.java:116)
> [tomcat-7.0.59-catalina.jar:7.0.59]
> [java] at
> org.apache.catalina.valves.AccessLogValve.invoke(AccessLogValve.java:950)
> [tomcat-7.0.59-catalina.jar:7.0.59]
> [java] at
>
[jira] [Updated] (OFBIZ-8617) Lookup of initial account in new opportunity doesn't work
[ https://issues.apache.org/jira/browse/OFBIZ-8617?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacopo Cappellato updated OFBIZ-8617: - Fix Version/s: (was: Release Branch 16.11) > Lookup of initial account in new opportunity doesn't work > - > > Key: OFBIZ-8617 > URL: https://issues.apache.org/jira/browse/OFBIZ-8617 > Project: OFBiz > Issue Type: Bug > Components: marketing >Affects Versions: Trunk, Release Branch 15.12 >Reporter: Pierre Smits >Assignee: Deepak Dixit > Fix For: Release Branch 13.07, Release Branch 14.12, 16.11.01, > Release Branch 15.12 > > > When creating a new opportunity, and the user wants to fill out the field of > the initial account no account is shown in type-ahead > see https://ofbiz-vm2.apache.org:8443/sfa/control/EditSalesOpportunity -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (OFBIZ-8342) ConfigXMLReader doesn't verify if "transaction-timeout" is set before trying to unbox
[
https://issues.apache.org/jira/browse/OFBIZ-8342?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jacopo Cappellato updated OFBIZ-8342:
-
Fix Version/s: (was: Release Branch 16.11)
> ConfigXMLReader doesn't verify if "transaction-timeout" is set before trying
> to unbox
> -
>
> Key: OFBIZ-8342
> URL: https://issues.apache.org/jira/browse/OFBIZ-8342
> Project: OFBiz
> Issue Type: Bug
>Affects Versions: Trunk
>Reporter: Valery Chenzo
>Assignee: Jacques Le Roux
> Fix For: 16.11.01
>
> Attachments: transactionTimeout.patch
>
>
> site-conf.xsd doesn't define *transaction-timeout* as being mandatory but
> ConfigXMLReader treats it as one and in the absence of the attribute an
> exception is being thrown causing the application to break.
> Stacktrace:
> {code}
> java.lang.NumberFormatException: For input string: ""
>
> java.lang.NumberFormatException.forInputString(NumberFormatException.java:65)
> java.lang.Integer.parseInt(Integer.java:592)
> java.lang.Integer.valueOf(Integer.java:766)
>
> org.apache.ofbiz.webapp.control.ConfigXMLReader$Event.(ConfigXMLReader.java:514)
>
> org.apache.ofbiz.webapp.control.ConfigXMLReader$RequestMap.(ConfigXMLReader.java:573)
>
> org.apache.ofbiz.webapp.control.ConfigXMLReader$ControllerConfig.loadRequestMap(ConfigXMLReader.java:487)
>
> org.apache.ofbiz.webapp.control.ConfigXMLReader$ControllerConfig.(ConfigXMLReader.java:203)
>
> org.apache.ofbiz.webapp.control.ConfigXMLReader.getControllerConfig(ConfigXMLReader.java:144)
>
> org.apache.ofbiz.webapp.control.RequestHandler.(RequestHandler.java:91)
>
> org.apache.ofbiz.webapp.control.RequestHandler.getRequestHandler(RequestHandler.java:81)
>
> org.apache.ofbiz.webapp.control.ControlServlet.getRequestHandler(ControlServlet.java:326)
>
> org.apache.ofbiz.webapp.control.ControlServlet.init(ControlServlet.java:77)
>
> org.apache.catalina.authenticator.AuthenticatorBase.invoke(AuthenticatorBase.java:502)
>
> org.apache.catalina.valves.ErrorReportValve.invoke(ErrorReportValve.java:79)
>
> org.apache.catalina.valves.AbstractAccessLogValve.invoke(AbstractAccessLogValve.java:616)
>
> org.apache.catalina.connector.CoyoteAdapter.service(CoyoteAdapter.java:528)
>
> org.apache.coyote.http11.AbstractHttp11Processor.process(AbstractHttp11Processor.java:1100)
>
> org.apache.coyote.AbstractProtocol$AbstractConnectionHandler.process(AbstractProtocol.java:687)
>
> org.apache.tomcat.util.net.NioEndpoint$SocketProcessor.doRun(NioEndpoint.java:1520)
>
> org.apache.tomcat.util.net.NioEndpoint$SocketProcessor.run(NioEndpoint.java:1476)
>
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
>
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
>
> org.apache.tomcat.util.threads.TaskThread$WrappingRunnable.run(TaskThread.java:61)
> java.lang.Thread.run(Thread.java:745)
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (OFBIZ-9125) Errormessage is displayed twice in LoginEvents.java
[ https://issues.apache.org/jira/browse/OFBIZ-9125?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacopo Cappellato updated OFBIZ-9125: - Fix Version/s: (was: Release Branch 16.11) (was: 16.11.01) 16.11.02 > Errormessage is displayed twice in LoginEvents.java > --- > > Key: OFBIZ-9125 > URL: https://issues.apache.org/jira/browse/OFBIZ-9125 > Project: OFBiz > Issue Type: Bug > Components: framework >Affects Versions: Release Branch 13.07, Trunk >Reporter: Heiko Elberg >Assignee: Jacques Le Roux > Fix For: Release Branch 13.07, Release Branch 14.12, Release > Branch 15.12, 16.11.02 > > Attachments: OFBIZ-9125_Errormessage is displayed twice in > LoginEvents.java.patch > > > Issue: > The errormessage "The password does not match the pattern" is called twice in > LoginServices.java. > Fix: > Delete second assignment for variable "errMsg". -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (OFBIZ-9126) SimpleMethod: Problem with Variables in key-fields
[ https://issues.apache.org/jira/browse/OFBIZ-9126?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacopo Cappellato updated OFBIZ-9126: - Fix Version/s: (was: Release Branch 16.11) (was: Trunk) 16.11.02 Upcoming Release > SimpleMethod: Problem with Variables in key-fields > -- > > Key: OFBIZ-9126 > URL: https://issues.apache.org/jira/browse/OFBIZ-9126 > Project: OFBiz > Issue Type: Bug >Affects Versions: Trunk >Reporter: Mirko Vogelsmeier >Assignee: Jacques Le Roux > Fix For: Upcoming Release, 16.11.02 > > Attachments: FlexibleMessage.java-ofbiz-9126.patch > > > I found that issue using ContactMechServices for updateContactMech: > The default-message is dynamically set regarding to what contactMechType you > are using. > The problem was that the variable in property-field was never evaluated as > that. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (OFBIZ-7348) Upgrade Tomcat to 8.5.3 (or 8.0.36)
[
https://issues.apache.org/jira/browse/OFBIZ-7348?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jacopo Cappellato updated OFBIZ-7348:
-
Fix Version/s: (was: Release Branch 16.11)
> Upgrade Tomcat to 8.5.3 (or 8.0.36)
> ---
>
> Key: OFBIZ-7348
> URL: https://issues.apache.org/jira/browse/OFBIZ-7348
> Project: OFBiz
> Issue Type: Sub-task
> Components: framework
>Affects Versions: Trunk
>Reporter: Jacques Le Roux
>Assignee: Jacques Le Roux
>Priority: Trivial
> Fix For: 16.11.01
>
>
> Quoting announcement on annou...@apache.org and other channels:
> {quote}
> This is the first stable release of the 8.5.x branch. Tomcat 8.x users
> should now use 8.5.x releases in preference to 8.0.x releases.
> Apache Tomcat 8.5.x is intended to replace 8.0.x and includes new
> features pulled forward from the 9.0.x branch. The notable changes since
> 8.5.2 include:
> * Ensure error will not be thrown during deployment when scanning jar
> files with no or invalid MANIFEST.MF files.
> * Improvements to memory leak detection and prevention
> * The HTTP Server header is no longer set by default
> Please refer to the change log for the complete list of changes:
> http://tomcat.apache.org/tomcat-8.5-doc/changelog.html
> Downloads:
> http://tomcat.apache.org/download-80.cgi
> {quote}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (OFBIZ-7061) Autocompletion for Compound Widget
[
https://issues.apache.org/jira/browse/OFBIZ-7061?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15731378#comment-15731378
]
Jacopo Cappellato commented on OFBIZ-7061:
--
I just wanted to mention that you should also take care of including all the
changes (if any) to the modified files that happened after the 9 commits (as
part of other unrelated modifications).
> Autocompletion for Compound Widget
> --
>
> Key: OFBIZ-7061
> URL: https://issues.apache.org/jira/browse/OFBIZ-7061
> Project: OFBiz
> Issue Type: Improvement
> Components: framework
>Affects Versions: Trunk
>Reporter: james yong
>Assignee: Jacques Le Roux
>Priority: Minor
> Fix For: 16.11.01
>
> Attachments: OFBIZ-7061-minilang-schema.patch, OFBIZ-7061.patch,
> OFBIZ-7061.patch, OFBIZ-7061.patch
>
>
> I am trying to enable auto-completion when coding compound widget.
> My plan as follows:
> 1. The following xsd will be modified to use namespace
> site-conf.xsd
> widget-form.xsd
> widget-screen.xsd
> widget-menu.xsd
> simple-methods.xsd
> For example, in site-conf.xsd, we add the following document level attribute
> {code}
> xmlns="http://ofbiz.apache.org/sc;
> targetNamespace="http://ofbiz.apache.org/sc;
> {code}
> 2. Import the above schema into compound-widgets.xsd so that compound widgets
> use only one consolidated schema.
> 3. Update ExampleCompoundWidgets.xml to use the new compound-widgets.xsd. For
> example
> {code}
> http://www.w3.org/2001/XMLSchema-instance;
> xmlns:sc="http://ofbiz.apache.org/sc;
> xmlns:m="http://ofbiz.apache.org/m;
> xmlns:s="http://ofbiz.apache.org/s;
> xmlns:f="http://ofbiz.apache.org/f;
> xmlns:sm="http://ofbiz.apache.org/sm;
>
> xsi:noNamespaceSchemaLocation="http://ofbiz.apache.org/dtds/compound-widgets.xsd;>
>
>
>
> path="component://example/widget/example/ExampleCompoundWidgets.xml"/>
>
>
> auth="true"/> value="CompoundWidgets2"/>
>
> page="component://example/widget/example/ExampleCompoundWidgets.xml#CompoundWidgets1"/>
> page="component://example/widget/example/ExampleCompoundWidgets.xml#CompoundWidgets2"/>
>
> .. the rest
> {code}
> 4. Change java code to support reading xml with namespace (i.e. xml for
> compound widgets)
> 5. Update the attributes at document level for rest of the controllers,
> menus, forms, simple methods and screens. Current setting will not work for
> schema with a namespace. For example, in controller.xml, we will change
> {code}
> xsi:noNamespaceSchemaLocation="http://ofbiz.apache.org/dtds/site-conf.xsd”
> {code}
> to
> {code}
> xmlns="http://ofbiz.apache.org/sc”
> xsi:schemaLocation="http://ofbiz.apache.org/dtds/site-conf-ns.xsd”>
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (OFBIZ-7061) Autocompletion for Compound Widget
[
https://issues.apache.org/jira/browse/OFBIZ-7061?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15728579#comment-15728579
]
Jacopo Cappellato commented on OFBIZ-7061:
--
Are you suggesting to revert the 9 commits?
> Autocompletion for Compound Widget
> --
>
> Key: OFBIZ-7061
> URL: https://issues.apache.org/jira/browse/OFBIZ-7061
> Project: OFBiz
> Issue Type: Improvement
> Components: framework
>Affects Versions: Trunk
>Reporter: james yong
>Assignee: Jacques Le Roux
>Priority: Minor
> Fix For: 16.11.01
>
> Attachments: OFBIZ-7061-minilang-schema.patch, OFBIZ-7061.patch,
> OFBIZ-7061.patch, OFBIZ-7061.patch
>
>
> I am trying to enable auto-completion when coding compound widget.
> My plan as follows:
> 1. The following xsd will be modified to use namespace
> site-conf.xsd
> widget-form.xsd
> widget-screen.xsd
> widget-menu.xsd
> simple-methods.xsd
> For example, in site-conf.xsd, we add the following document level attribute
> {code}
> xmlns="http://ofbiz.apache.org/sc;
> targetNamespace="http://ofbiz.apache.org/sc;
> {code}
> 2. Import the above schema into compound-widgets.xsd so that compound widgets
> use only one consolidated schema.
> 3. Update ExampleCompoundWidgets.xml to use the new compound-widgets.xsd. For
> example
> {code}
> http://www.w3.org/2001/XMLSchema-instance;
> xmlns:sc="http://ofbiz.apache.org/sc;
> xmlns:m="http://ofbiz.apache.org/m;
> xmlns:s="http://ofbiz.apache.org/s;
> xmlns:f="http://ofbiz.apache.org/f;
> xmlns:sm="http://ofbiz.apache.org/sm;
>
> xsi:noNamespaceSchemaLocation="http://ofbiz.apache.org/dtds/compound-widgets.xsd;>
>
>
>
> path="component://example/widget/example/ExampleCompoundWidgets.xml"/>
>
>
> auth="true"/> value="CompoundWidgets2"/>
>
> page="component://example/widget/example/ExampleCompoundWidgets.xml#CompoundWidgets1"/>
> page="component://example/widget/example/ExampleCompoundWidgets.xml#CompoundWidgets2"/>
>
> .. the rest
> {code}
> 4. Change java code to support reading xml with namespace (i.e. xml for
> compound widgets)
> 5. Update the attributes at document level for rest of the controllers,
> menus, forms, simple methods and screens. Current setting will not work for
> schema with a namespace. For example, in controller.xml, we will change
> {code}
> xsi:noNamespaceSchemaLocation="http://ofbiz.apache.org/dtds/site-conf.xsd”
> {code}
> to
> {code}
> xmlns="http://ofbiz.apache.org/sc”
> xsi:schemaLocation="http://ofbiz.apache.org/dtds/site-conf-ns.xsd”>
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (OFBIZ-7061) Autocompletion for Compound Widget
[
https://issues.apache.org/jira/browse/OFBIZ-7061?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15728979#comment-15728979
]
Jacopo Cappellato commented on OFBIZ-7061:
--
ok, I am fine with it.
My only concern is that we may miss any changes done to the files after this
ticket.
If you are going to implement what you have proposed please consider the above.
> Autocompletion for Compound Widget
> --
>
> Key: OFBIZ-7061
> URL: https://issues.apache.org/jira/browse/OFBIZ-7061
> Project: OFBiz
> Issue Type: Improvement
> Components: framework
>Affects Versions: Trunk
>Reporter: james yong
>Assignee: Jacques Le Roux
>Priority: Minor
> Fix For: 16.11.01
>
> Attachments: OFBIZ-7061-minilang-schema.patch, OFBIZ-7061.patch,
> OFBIZ-7061.patch, OFBIZ-7061.patch
>
>
> I am trying to enable auto-completion when coding compound widget.
> My plan as follows:
> 1. The following xsd will be modified to use namespace
> site-conf.xsd
> widget-form.xsd
> widget-screen.xsd
> widget-menu.xsd
> simple-methods.xsd
> For example, in site-conf.xsd, we add the following document level attribute
> {code}
> xmlns="http://ofbiz.apache.org/sc;
> targetNamespace="http://ofbiz.apache.org/sc;
> {code}
> 2. Import the above schema into compound-widgets.xsd so that compound widgets
> use only one consolidated schema.
> 3. Update ExampleCompoundWidgets.xml to use the new compound-widgets.xsd. For
> example
> {code}
> http://www.w3.org/2001/XMLSchema-instance;
> xmlns:sc="http://ofbiz.apache.org/sc;
> xmlns:m="http://ofbiz.apache.org/m;
> xmlns:s="http://ofbiz.apache.org/s;
> xmlns:f="http://ofbiz.apache.org/f;
> xmlns:sm="http://ofbiz.apache.org/sm;
>
> xsi:noNamespaceSchemaLocation="http://ofbiz.apache.org/dtds/compound-widgets.xsd;>
>
>
>
> path="component://example/widget/example/ExampleCompoundWidgets.xml"/>
>
>
> auth="true"/> value="CompoundWidgets2"/>
>
> page="component://example/widget/example/ExampleCompoundWidgets.xml#CompoundWidgets1"/>
> page="component://example/widget/example/ExampleCompoundWidgets.xml#CompoundWidgets2"/>
>
> .. the rest
> {code}
> 4. Change java code to support reading xml with namespace (i.e. xml for
> compound widgets)
> 5. Update the attributes at document level for rest of the controllers,
> menus, forms, simple methods and screens. Current setting will not work for
> schema with a namespace. For example, in controller.xml, we will change
> {code}
> xsi:noNamespaceSchemaLocation="http://ofbiz.apache.org/dtds/site-conf.xsd”
> {code}
> to
> {code}
> xmlns="http://ofbiz.apache.org/sc”
> xsi:schemaLocation="http://ofbiz.apache.org/dtds/site-conf-ns.xsd”>
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (OFBIZ-7061) Autocompletion for Compound Widget
[
https://issues.apache.org/jira/browse/OFBIZ-7061?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15726400#comment-15726400
]
Jacopo Cappellato commented on OFBIZ-7061:
--
It is annoying that because of the disordered way in which this task has been
managed we have lost the history of changes to most of the OFBiz widget xsd
files: thru a series of commits files like widget-screen.xsd have been copied
and renamed (without using the svn copy command) then the originals have been
deleted, then their copies have been renamed back to the original names.
> Autocompletion for Compound Widget
> --
>
> Key: OFBIZ-7061
> URL: https://issues.apache.org/jira/browse/OFBIZ-7061
> Project: OFBiz
> Issue Type: Improvement
> Components: framework
>Affects Versions: Trunk
>Reporter: james yong
>Assignee: Jacques Le Roux
>Priority: Minor
> Fix For: 16.11.01
>
> Attachments: OFBIZ-7061-minilang-schema.patch, OFBIZ-7061.patch,
> OFBIZ-7061.patch, OFBIZ-7061.patch
>
>
> I am trying to enable auto-completion when coding compound widget.
> My plan as follows:
> 1. The following xsd will be modified to use namespace
> site-conf.xsd
> widget-form.xsd
> widget-screen.xsd
> widget-menu.xsd
> simple-methods.xsd
> For example, in site-conf.xsd, we add the following document level attribute
> {code}
> xmlns="http://ofbiz.apache.org/sc;
> targetNamespace="http://ofbiz.apache.org/sc;
> {code}
> 2. Import the above schema into compound-widgets.xsd so that compound widgets
> use only one consolidated schema.
> 3. Update ExampleCompoundWidgets.xml to use the new compound-widgets.xsd. For
> example
> {code}
> http://www.w3.org/2001/XMLSchema-instance;
> xmlns:sc="http://ofbiz.apache.org/sc;
> xmlns:m="http://ofbiz.apache.org/m;
> xmlns:s="http://ofbiz.apache.org/s;
> xmlns:f="http://ofbiz.apache.org/f;
> xmlns:sm="http://ofbiz.apache.org/sm;
>
> xsi:noNamespaceSchemaLocation="http://ofbiz.apache.org/dtds/compound-widgets.xsd;>
>
>
>
> path="component://example/widget/example/ExampleCompoundWidgets.xml"/>
>
>
> auth="true"/> value="CompoundWidgets2"/>
>
> page="component://example/widget/example/ExampleCompoundWidgets.xml#CompoundWidgets1"/>
> page="component://example/widget/example/ExampleCompoundWidgets.xml#CompoundWidgets2"/>
>
> .. the rest
> {code}
> 4. Change java code to support reading xml with namespace (i.e. xml for
> compound widgets)
> 5. Update the attributes at document level for rest of the controllers,
> menus, forms, simple methods and screens. Current setting will not work for
> schema with a namespace. For example, in controller.xml, we will change
> {code}
> xsi:noNamespaceSchemaLocation="http://ofbiz.apache.org/dtds/site-conf.xsd”
> {code}
> to
> {code}
> xmlns="http://ofbiz.apache.org/sc”
> xsi:schemaLocation="http://ofbiz.apache.org/dtds/site-conf-ns.xsd”>
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (OFBIZ-8337) Refactor and simplify the startup sequence in OFBiz
[ https://issues.apache.org/jira/browse/OFBIZ-8337?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15721692#comment-15721692 ] Jacopo Cappellato commented on OFBIZ-8337: -- I have applied and tested your latest patch and I didn't spot any issues with it. Thank you. > Refactor and simplify the startup sequence in OFBiz > --- > > Key: OFBIZ-8337 > URL: https://issues.apache.org/jira/browse/OFBIZ-8337 > Project: OFBiz > Issue Type: Improvement > Components: base, start >Affects Versions: Upcoming Release >Reporter: Taher Alkhateeb >Assignee: Taher Alkhateeb >Priority: Minor > Attachments: OFBIZ-8337-2.patch, OFBIZ-8337-3.patch, > OFBIZ-8337-3.patch, OFBIZ-8337.patch > > > The startup sequence in OFBiz is highly complex and requires improvements on > multiple levels including: > - The entire classpath buildup logic and > org.apache.ofbiz.base.start.Classpath needs to be removed. The original idea > of classpath isolation between the components created many more problems than > it solved, and right now the classpath construction is the responsibility of > the build system. > - The custom classloader needs to be removed as well together with the > classpath mentioned above. > - The StartupLoader interface should remove the start() method and just have > two methods, load and unload. > - The startup sequence should have only one StartupLoader, not an array of > startup loaders. This StartupLoader (implemented as ContainerLoader) is the > only class responsible for bootstrapping OFBiz > - The ContainerLoader needs to be completely refactored, not only to remove > the start() method but also to cleanup the very messy logic currently > residing there. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-8337) Refactor and simplify the startup sequence in OFBiz
[ https://issues.apache.org/jira/browse/OFBIZ-8337?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15711580#comment-15711580 ] Jacopo Cappellato commented on OFBIZ-8337: -- Thanks for the insight Taher! I will have to look again at the classloader code we have since it is a long time since I did. I would recommend that you commit this work and we postpone the further (if any) work to remove NativeLibClassLoader after your commit. > Refactor and simplify the startup sequence in OFBiz > --- > > Key: OFBIZ-8337 > URL: https://issues.apache.org/jira/browse/OFBIZ-8337 > Project: OFBiz > Issue Type: Improvement > Components: base, start >Affects Versions: Upcoming Release >Reporter: Taher Alkhateeb >Assignee: Taher Alkhateeb >Priority: Minor > Attachments: OFBIZ-8337-2.patch, OFBIZ-8337.patch > > > The startup sequence in OFBiz is highly complex and requires improvements on > multiple levels including: > - The entire classpath buildup logic and > org.apache.ofbiz.base.start.Classpath needs to be removed. The original idea > of classpath isolation between the components created many more problems than > it solved, and right now the classpath construction is the responsibility of > the build system. > - The custom classloader needs to be removed as well together with the > classpath mentioned above. > - The StartupLoader interface should remove the start() method and just have > two methods, load and unload. > - The startup sequence should have only one StartupLoader, not an array of > startup loaders. This StartupLoader (implemented as ContainerLoader) is the > only class responsible for bootstrapping OFBiz > - The ContainerLoader needs to be completely refactored, not only to remove > the start() method but also to cleanup the very messy logic currently > residing there. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-8337) Refactor and simplify the startup sequence in OFBiz
[ https://issues.apache.org/jira/browse/OFBIZ-8337?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15708700#comment-15708700 ] Jacopo Cappellato commented on OFBIZ-8337: -- [~taher] thanks for your work. I have reviewed your patch which looks great and also applied it to my local environment: smoke testing was successful. I suggest to commit it to trunk to perform some more tests and plan for the next incremental steps. One of these could be that of getting rid completely of the custom NativeLibClassloader and remove the code that calls its addNativeClassPath(...) method: it will be one step in the direction of having a simpler to deploy system. > Refactor and simplify the startup sequence in OFBiz > --- > > Key: OFBIZ-8337 > URL: https://issues.apache.org/jira/browse/OFBIZ-8337 > Project: OFBiz > Issue Type: Improvement > Components: base, start >Affects Versions: Upcoming Release >Reporter: Taher Alkhateeb >Assignee: Taher Alkhateeb >Priority: Minor > Attachments: OFBIZ-8337-2.patch, OFBIZ-8337.patch > > > The startup sequence in OFBiz is highly complex and requires improvements on > multiple levels including: > - The entire classpath buildup logic and > org.apache.ofbiz.base.start.Classpath needs to be removed. The original idea > of classpath isolation between the components created many more problems than > it solved, and right now the classpath construction is the responsibility of > the build system. > - The custom classloader needs to be removed as well together with the > classpath mentioned above. > - The StartupLoader interface should remove the start() method and just have > two methods, load and unload. > - The startup sequence should have only one StartupLoader, not an array of > startup loaders. This StartupLoader (implemented as ContainerLoader) is the > only class responsible for bootstrapping OFBiz > - The ContainerLoader needs to be completely refactored, not only to remove > the start() method but also to cleanup the very messy logic currently > residing there. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-9325) Error in Party Manager->Parties->SHOPPING LIST->QUICK ADD TO SHOPPING LIST section
[
https://issues.apache.org/jira/browse/OFBIZ-9325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15974692#comment-15974692
]
Jacopo Cappellato commented on OFBIZ-9325:
--
[~tzngvi] I can reproduce the error you have reported but, due to limited time,
I could not find the root cause of it.
In the meantime you could check other similar screens that use the
renderLookupField macro and works properly even after my changes, for example:
https://localhost:8443/catalog/control/EditProductPromoRules?productPromoId=9022
By analyzing and comparing the ones that work with the ones that fail we may
gather useful clues for a proper fix.
I hope it helps
> Error in Party Manager->Parties->SHOPPING LIST->QUICK ADD TO SHOPPING LIST
> section
> --
>
> Key: OFBIZ-9325
> URL: https://issues.apache.org/jira/browse/OFBIZ-9325
> Project: OFBiz
> Issue Type: Bug
> Components: party
>Affects Versions: Trunk
>Reporter: Wei Zhang
>Assignee: Jacopo Cappellato
>Priority: Minor
>
> To reproduce it:
> 1. Open partymgr/control/editShoppingList?partyId=admin
> 2. Add a product to shopping list in QUICK ADD TO SHOPPING LIST section by
> clicking ADD TO SHOPPING LIST button
> 3. You should be able to get error message below
> _The following has evaluated to null or missing: ==> renderLookupField [in
> template "component://common/template/includes/HtmlTemplate.ftl" at line 38,
> column 5] Tip: If the failing expression is known to be legally refer to
> something that's sometimes null or missing, either specify a default value
> like myOptionalVar!myDefault, or use <#if
> myOptionalVar??>when-present<#else>when-missing. (These only cover the last
> step of the expression; to cover the whole expression, use parenthesis:
> (myOptionalVar.foo)!myDefault, (myOptionalVar.foo)?? FTL stack
> trace ("~" means nesting-related): - Failed at: @renderLookupField name,
> formName, fi... [in template
> "component://common/template/includes/HtmlTemplate.ftl" in macro
> "lookupField" at line 38, column 3] - Reached through:
> @htmlTemplate.lookupField formName="a... [in template
> "component://party/template/party/EditShoppingList.ftl" at line 256, column
> 7] _
> [~jacopoc] Can you please check it? As I dont understand your commits in
> 1785581 and 1762227. Thanks.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (OFBIZ-9325) Error in Party Manager->Parties->SHOPPING LIST->QUICK ADD TO SHOPPING LIST section
[
https://issues.apache.org/jira/browse/OFBIZ-9325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15976183#comment-15976183
]
Jacopo Cappellato commented on OFBIZ-9325:
--
Hi Wei,
the error was actually in the specific template, not in the framework. In fact
the templates should not explicitly import HtmlTemplate.ftl since this, after
my changes, is transparently done by the framework.
In my commit 1792018 I have fixed the screen by removing the import and by
improving the prevNext macro; since the same issue was present in another
screen, I have fixed that one too.
It would be great if you could test and confirm that the system works as you
expect.
Jacopo
> Error in Party Manager->Parties->SHOPPING LIST->QUICK ADD TO SHOPPING LIST
> section
> --
>
> Key: OFBIZ-9325
> URL: https://issues.apache.org/jira/browse/OFBIZ-9325
> Project: OFBiz
> Issue Type: Bug
> Components: party
>Affects Versions: Trunk
>Reporter: Wei Zhang
>Assignee: Jacopo Cappellato
>Priority: Minor
>
> To reproduce it:
> 1. Open partymgr/control/editShoppingList?partyId=admin
> 2. Add a product to shopping list in QUICK ADD TO SHOPPING LIST section by
> clicking ADD TO SHOPPING LIST button
> 3. You should be able to get error message below
> _The following has evaluated to null or missing: ==> renderLookupField [in
> template "component://common/template/includes/HtmlTemplate.ftl" at line 38,
> column 5] Tip: If the failing expression is known to be legally refer to
> something that's sometimes null or missing, either specify a default value
> like myOptionalVar!myDefault, or use <#if
> myOptionalVar??>when-present<#else>when-missing. (These only cover the last
> step of the expression; to cover the whole expression, use parenthesis:
> (myOptionalVar.foo)!myDefault, (myOptionalVar.foo)?? FTL stack
> trace ("~" means nesting-related): - Failed at: @renderLookupField name,
> formName, fi... [in template
> "component://common/template/includes/HtmlTemplate.ftl" in macro
> "lookupField" at line 38, column 3] - Reached through:
> @htmlTemplate.lookupField formName="a... [in template
> "component://party/template/party/EditShoppingList.ftl" at line 256, column
> 7] _
> [~jacopoc] Can you please check it? As I dont understand your commits in
> 1785581 and 1762227. Thanks.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (OFBIZ-7120) Multisite support in specialpurpose/cmssite
[ https://issues.apache.org/jira/browse/OFBIZ-7120?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15972344#comment-15972344 ] Jacopo Cappellato commented on OFBIZ-7120: -- [~rehan.khan], your patches look good to me. > Multisite support in specialpurpose/cmssite > --- > > Key: OFBIZ-7120 > URL: https://issues.apache.org/jira/browse/OFBIZ-7120 > Project: OFBiz > Issue Type: New Feature > Components: cmssite >Affects Versions: Trunk >Reporter: Pranay Pandey >Assignee: Mohammed Rehan Khan > Fix For: 16.11.01 > > Attachments: OFBIZ-7120-1.patch, OFBIZ-7120-1.patch, > OFBIZ-7120-2.patch, OFBIZ-7120-2.patch, OFBIZ-7120-branch-16.11.patch, > OFBIZ-7120-framework.patch > > > Idea is to implement a WebSiteFilter in specialpurose/cmssite component which > can demonstrate OFBiz CMS ability to serve multiple websites with single > webapp. > To demonstrate WebSiteFilter usage, will also be adding sample website data, > in addition to the one we already have. > Originally this idea and implementation is from [~lektran]. I will be > providing the patch for review and acceptance by the community. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (OFBIZ-9492) Tax Authorities need two GL accounts for sales and purchases
[ https://issues.apache.org/jira/browse/OFBIZ-9492?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16085566#comment-16085566 ] Jacopo Cappellato commented on OFBIZ-9492: -- Thank you [~paul_foxworthy], I agree with the need to implement this requirement and with your design proposal. One possible alternative to the creation of the enumeration records and fields would be that of creating a new entity TaxAuthorityGlAccountType and then add the two records there. I don't have a strong preference but I wanted to mention it just for the records. > Tax Authorities need two GL accounts for sales and purchases > > > Key: OFBIZ-9492 > URL: https://issues.apache.org/jira/browse/OFBIZ-9492 > Project: OFBiz > Issue Type: Improvement > Components: accounting >Affects Versions: Trunk >Reporter: Paul Foxworthy >Assignee: Paul Foxworthy > Labels: accounting, vat > > In jurisdictions with Value Added Tax, you need to track tax you have paid on > purchases, and tax you have collected with sales. When you report to a tax > authority, you pay them the difference between the two, i.e. you pay tax on > the value added, not on your inputs. > OFBiz has an entity, TaxAuthorityGlAccount (TAGLA), which currently assumes > the GL account is for a sale. > We need to extend OFBiz so it is possible to find two GL accounts for a tax > authority, one for sales and one for purchases. > I propose: > - Define a new Enumeration for the direction of a transaction. I suggest > calling the Enumeration TAGLADIR, with two values TAGLADIR_INCOMING > and TAGLADIR_OUTGOING. > We could reuse an existing indication of the direction of a transaction, > for example the GlAccountClassIds INCOME and EXPENSE. However, when we receive > income from a sale, we would incur a tax *liability*, and the GL account for > that > would be a liability account. So I think it would be less confusing to have a > separate enum here that's just for TAGLA. > - add a new attribute to the TaxAuthorityGlAccount entity for the direction > of the transaction. > The new attribute should be included in the primary key. > - Add a new service in TaxAuthorityServices named getTaxAuthorityGlAccountId > which > looks up a TAGLA given primary key values, including the direction > - There are two places in TaxAuthorityServices that would call > getTaxAuthorityGlAccountId: getTaxAdjustments and getItemTaxAdjustments, one > for orders, and the other for invoice item types. The direction can be > inferred from the order type or the invoice item type > - createAcctgTransForPurchaseInvoice and > createAcctgTransForCustomerReturnInvoice > should use getTaxAuthorityGlAccountId > - createAcctgTransactionForSalesInvoice should be rewritten to use > getTaxAuthorityGlAccountId. > I am working on a patch to do this, but I'd like your thoughts on my proposal -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (OFBIZ-9496) MySql Database related warning related to DATETIME filed
[
https://issues.apache.org/jira/browse/OFBIZ-9496?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16092800#comment-16092800
]
Jacopo Cappellato commented on OFBIZ-9496:
--
The warning message generated by OFBiz is a false positive caused by the fact
that the way OFBiz performs the check is too simplistic: OFBiz parses for the
content of the "()" in the fieldtype mapping and assumes that it is the column
size.
However, in MySQL and possibly other database management systems, this is only
true for varchar field definitions but not for datetime fields.
The column size for DATETIME(3) is not 3.
We should probably refactor the code in DatabaseUtil to compare the SQL field
type from the JDBC driver, if possible to retrieve, (i.e. from the database)
with the whole content (without any sting manipulation) of the attribute
sql-type of the element field-type-def type (in fieldtype*.xml) i.e.
"DATETIME(3)"; if they differ then a warning should be printed.
In this way we will have a more generic, simpler and more reliable tool to spot
differences in the database
> MySql Database related warning related to DATETIME filed
>
>
> Key: OFBIZ-9496
> URL: https://issues.apache.org/jira/browse/OFBIZ-9496
> Project: OFBiz
> Issue Type: Improvement
>Reporter: Deepak Dixit
>Priority: Minor
>
> Here are the following warnings that we are getting for all the datetime
> related filed.
> this is due to incorrect handling of database filed type comparison in
> DatabaseUtil.java
> {code}
> 2017-07-18 12:30:19,137 |OFBiz-batch-2|DatabaseUtil
> |W| Column [LAST_UPDATED_TX_STAMP] of table [RUNTIME_DATA] of entity
> [RuntimeData] has a column size of [19] in the database, but is defined to
> have a column size of [3] in the entity definition.
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (OFBIZ-9523) Improve groovy DSL : runService call makeValidContext
[
https://issues.apache.org/jira/browse/OFBIZ-9523?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16097980#comment-16097980
]
Jacopo Cappellato commented on OFBIZ-9523:
--
Thank you Nicolas, it looks really good to me!
One minor detail: when we call runSync we can probably reuse the local variable
"dispatcher" rather then calling again binding.getVariable(...).
> Improve groovy DSL : runService call makeValidContext
> -
>
> Key: OFBIZ-9523
> URL: https://issues.apache.org/jira/browse/OFBIZ-9523
> Project: OFBiz
> Issue Type: Improvement
> Components: framework
>Affects Versions: Trunk
> Environment: When you call run service with groovy, you need to be
> sure that all parametes are good for the service call.
> I propose to simplify this dsl with an automatic parameters check so you can
> call directly like that
> {code}
> run service : createProduct, with: context
> {code}
>Reporter: Nicolas Malin
>Assignee: Nicolas Malin
> Attachments: OFBIZ-9523.patch
>
>
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Updated] (OFBIZ-9496) MySql Database related warning related to DATETIME filed
[
https://issues.apache.org/jira/browse/OFBIZ-9496?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jacopo Cappellato updated OFBIZ-9496:
-
Attachment: OFBIZ-9496.patch
This is a workaround to fix the warning.
> MySql Database related warning related to DATETIME filed
>
>
> Key: OFBIZ-9496
> URL: https://issues.apache.org/jira/browse/OFBIZ-9496
> Project: OFBiz
> Issue Type: Improvement
>Reporter: Deepak Dixit
>Priority: Minor
> Attachments: OFBIZ-9496.patch
>
>
> Here are the following warnings that we are getting for all the datetime
> related filed.
> this is due to incorrect handling of database filed type comparison in
> DatabaseUtil.java
> {code}
> 2017-07-18 12:30:19,137 |OFBiz-batch-2|DatabaseUtil
> |W| Column [LAST_UPDATED_TX_STAMP] of table [RUNTIME_DATA] of entity
> [RuntimeData] has a column size of [19] in the database, but is defined to
> have a column size of [3] in the entity definition.
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Closed] (OFBIZ-9526) MRP generates duplicate requirements when items are initially under minimum quantity and have with pending approved purchase orders.
[ https://issues.apache.org/jira/browse/OFBIZ-9526?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacopo Cappellato closed OFBIZ-9526. Resolution: Fixed Fix Version/s: 16.11.04 Fix committed in trunk with rev. 1802766 and in release branch 14.11 with rev. 1802773. > MRP generates duplicate requirements when items are initially under minimum > quantity and have with pending approved purchase orders. > > > Key: OFBIZ-9526 > URL: https://issues.apache.org/jira/browse/OFBIZ-9526 > Project: OFBiz > Issue Type: Bug > Components: manufacturing >Affects Versions: Trunk, 16.11.03 >Reporter: Jacopo Cappellato >Assignee: Jacopo Cappellato > Fix For: 16.11.04 > > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Created] (OFBIZ-9525) MRP incorrectly computes quantity already received in open purchase order shipments
Jacopo Cappellato created OFBIZ-9525: Summary: MRP incorrectly computes quantity already received in open purchase order shipments Key: OFBIZ-9525 URL: https://issues.apache.org/jira/browse/OFBIZ-9525 Project: OFBiz Issue Type: Bug Components: manufacturing Affects Versions: Trunk Reporter: Jacopo Cappellato Assignee: Jacopo Cappellato The MRP algorithm incorrectly computes the quantity of items partially received in a purchase shipment because it leverages the OrderReadHelper.getItemShippedQuantity(...) method that is intended to be used to count the quantity shipped of a sales order. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Created] (OFBIZ-9526) MRP generates duplicate requirements when items are initially under minimum quantity and have with pending approved purchase orders.
Jacopo Cappellato created OFBIZ-9526: Summary: MRP generates duplicate requirements when items are initially under minimum quantity and have with pending approved purchase orders. Key: OFBIZ-9526 URL: https://issues.apache.org/jira/browse/OFBIZ-9526 Project: OFBiz Issue Type: Bug Components: manufacturing Affects Versions: 16.11.03, Trunk Reporter: Jacopo Cappellato Assignee: Jacopo Cappellato -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (OFBIZ-9525) MRP incorrectly computes quantity already received in open purchase order shipments
[ https://issues.apache.org/jira/browse/OFBIZ-9525?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacopo Cappellato updated OFBIZ-9525: - Affects Version/s: 16.11.03 > MRP incorrectly computes quantity already received in open purchase order > shipments > --- > > Key: OFBIZ-9525 > URL: https://issues.apache.org/jira/browse/OFBIZ-9525 > Project: OFBiz > Issue Type: Bug > Components: manufacturing >Affects Versions: Trunk, 16.11.03 >Reporter: Jacopo Cappellato >Assignee: Jacopo Cappellato > > The MRP algorithm incorrectly computes the quantity of items partially > received in a purchase shipment because it leverages the > OrderReadHelper.getItemShippedQuantity(...) method that is intended to be > used to count the quantity shipped of a sales order. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Assigned] (OFBIZ-9324) Accounting_quantity_diff <-- Item variance
[ https://issues.apache.org/jira/browse/OFBIZ-9324?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacopo Cappellato reassigned OFBIZ-9324: Assignee: Jacopo Cappellato > Accounting_quantity_diff <-- Item variance > -- > > Key: OFBIZ-9324 > URL: https://issues.apache.org/jira/browse/OFBIZ-9324 > Project: OFBiz > Issue Type: Bug > Components: accounting >Affects Versions: Trunk >Reporter: Ingo Wolfmayr >Assignee: Jacopo Cappellato > > 1. Shipment Receipt: 1 Piece for 15$ (Facility --> Receive Inventory) > 2. Item Variance: 1 Piece (via physical inventory on inventory item -1 > ATP, -1 QOH) - item lost > Step 1 > * increases the ACCOUNTING_QUANTITY --> ACCOUNTING_QUANTITY_DIFF = 1 > * creates an accounting transaction --> INVENTORY +1 (15$ Credit) > Step 2 > * ACCOUNTING_QUANTITY no change > * creates an accounting transaction --> INVENTORY -1 (15$ Debit) > Therefore the ITEM VALUATION report still shows 15$ / 1 Accounting Quanity > sum after step two. > Inventory variance should affect the accounting quantity. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (OFBIZ-9324) Accounting_quantity_diff <-- Item variance
[ https://issues.apache.org/jira/browse/OFBIZ-9324?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15982849#comment-15982849 ] Jacopo Cappellato commented on OFBIZ-9324: -- Fixed in rev. 1792609 [~iwolf] thanks for your detailed report, it was really useful. It would be great if you could perform further tests and confirm if it works for you. > Accounting_quantity_diff <-- Item variance > -- > > Key: OFBIZ-9324 > URL: https://issues.apache.org/jira/browse/OFBIZ-9324 > Project: OFBiz > Issue Type: Bug > Components: accounting >Affects Versions: Trunk >Reporter: Ingo Wolfmayr >Assignee: Jacopo Cappellato > > 1. Shipment Receipt: 1 Piece for 15$ (Facility --> Receive Inventory) > 2. Item Variance: 1 Piece (via physical inventory on inventory item -1 > ATP, -1 QOH) - item lost > Step 1 > * increases the ACCOUNTING_QUANTITY --> ACCOUNTING_QUANTITY_DIFF = 1 > * creates an accounting transaction --> INVENTORY +1 (15$ Credit) > Step 2 > * ACCOUNTING_QUANTITY no change > * creates an accounting transaction --> INVENTORY -1 (15$ Debit) > Therefore the ITEM VALUATION report still shows 15$ / 1 Accounting Quanity > sum after step two. > Inventory variance should affect the accounting quantity. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (OFBIZ-9185) The deleteWorkEffort service is incomplete and even wrong
[
https://issues.apache.org/jira/browse/OFBIZ-9185?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16116406#comment-16116406
]
Jacopo Cappellato commented on OFBIZ-9185:
--
Hi [~jacques.le.roux],
in that old commit I have renamed a broken link
(removeWorkEffort-->deleteWorkEffort) so that the existing "delete" link could
work. However, as it has been already commented in this ticket, the service as
is now is not very useful and we could either improve it or remove (I don't
have a strong opinion).
> The deleteWorkEffort service is incomplete and even wrong
> -
>
> Key: OFBIZ-9185
> URL: https://issues.apache.org/jira/browse/OFBIZ-9185
> Project: OFBiz
> Issue Type: Bug
> Components: workeffort
>Affects Versions: Trunk
>Reporter: Jacques Le Roux
>Priority: Minor
>
> This issue is very old (pre Apache) so all versions are affected (I just
> tested with R09.04)
> When you try to delete a Workeffort which has an established relationship
> with a RuntimeData or any of the entities Workeffort has a relation with (eg
> NoteData, RecurrenceInfo) using the the deleteWorkEffort service this one
> fails
> Also from my experience CustRequestWorkEffort is missing in deleteWorkEffort,
> would be to add
> {code}
> relation-name="CustRequestWorkEffort"/>
> {code}
> Besides (minor) ApplicationSandbox is maybe missing in the implementation of
> deleteWorkEffort.
> There is indeed a workeffortId in ApplicationSandbox.
> So ApplicationSandbox is indirectly linked to Workeffort by RuntimeData.
> But it can anyway be deleted by a simple delete-by-and (or alike), so not a
> problem for deleteWorkEffort, though this case could be handled there also.
> Summary: the deleteWorkEffort service needs more work. The only solution I
> see is to remove the FK from the Workeffort (ie put null in the related field
> if it's not) and then deleted the related entity instead of directly calling
> remove-related
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (OFBIZ-9324) Accounting_quantity_diff <-- Item variance
[ https://issues.apache.org/jira/browse/OFBIZ-9324?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16010431#comment-16010431 ] Jacopo Cappellato commented on OFBIZ-9324: -- Backported to 16.11 in rev. 1795165 > Accounting_quantity_diff <-- Item variance > -- > > Key: OFBIZ-9324 > URL: https://issues.apache.org/jira/browse/OFBIZ-9324 > Project: OFBiz > Issue Type: Bug > Components: accounting >Affects Versions: Trunk >Reporter: Ingo Wolfmayr >Assignee: Jacopo Cappellato > > 1. Shipment Receipt: 1 Piece for 15$ (Facility --> Receive Inventory) > 2. Item Variance: 1 Piece (via physical inventory on inventory item -1 > ATP, -1 QOH) - item lost > Step 1 > * increases the ACCOUNTING_QUANTITY --> ACCOUNTING_QUANTITY_DIFF = 1 > * creates an accounting transaction --> INVENTORY +1 (15$ Credit) > Step 2 > * ACCOUNTING_QUANTITY no change > * creates an accounting transaction --> INVENTORY -1 (15$ Debit) > Therefore the ITEM VALUATION report still shows 15$ / 1 Accounting Quanity > sum after step two. > Inventory variance should affect the accounting quantity. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Updated] (OFBIZ-9145) Greater precise value overriding price in order
[ https://issues.apache.org/jira/browse/OFBIZ-9145?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacopo Cappellato updated OFBIZ-9145: - Fix Version/s: (was: 16.11.02) > Greater precise value overriding price in order > --- > > Key: OFBIZ-9145 > URL: https://issues.apache.org/jira/browse/OFBIZ-9145 > Project: OFBiz > Issue Type: Improvement > Components: order >Affects Versions: Release Branch 13.07, Release Branch 14.12, Trunk, > 16.11.01, Release Branch 15.12 > Environment: OSX >Reporter: Oleg Andreyev >Priority: Minor > Fix For: Trunk > > Attachments: ovr_price_precisely.diff > > > I encounter a problem when try to re-enter orders originally created in > another system (not ofbiz). And I found some cases when it's not possible to > reproduce it exactly due to some promo rules triggered in this another > system. But I must. Difference .01 is important. > Solution would be if I can change the unit price in an existing order using > value with 3 digits after decimal point. I found that if I add new order item > and check "Override" price I am able to enter more precise values, but if I > update unit price in an existing order item I am not. updateOrderItems rounds > it to 2 digits. Exactly the same intention but works differently. > This makes me think we can remove rounding in second case. I believe if user > want to change the unit price he knows why. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Updated] (OFBIZ-9279) Sort Links in Lookup for Owner Content Id causes unwanted behaviour on Find Content page
[ https://issues.apache.org/jira/browse/OFBIZ-9279?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacopo Cappellato updated OFBIZ-9279: - Fix Version/s: (was: 16.11.02) > Sort Links in Lookup for Owner Content Id causes unwanted behaviour on Find > Content page > > > Key: OFBIZ-9279 > URL: https://issues.apache.org/jira/browse/OFBIZ-9279 > Project: OFBiz > Issue Type: Bug >Reporter: Aditya Sharma >Assignee: Aditya Sharma > Fix For: Release Branch 14.12, Release Branch 15.12, Upcoming > Release > > Attachments: OFBIZ-9279.patch, screenshot-1.png > > > How to reproduce : > 1. Log in the Content component > 2. Go to the Content tab. https://localhost:8443/content/control/findContent > 3. In the search form, open the lookup of the field ' Owner Content Id ' > 4. Click on any of the table header links to sort the table. Results will be > displayed on a new unstyled window closing the Lookup dialog. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Closed] (OFBIZ-9324) Accounting_quantity_diff <-- Item variance
[ https://issues.apache.org/jira/browse/OFBIZ-9324?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacopo Cappellato closed OFBIZ-9324. Resolution: Fixed Fix Version/s: 16.11.02 > Accounting_quantity_diff <-- Item variance > -- > > Key: OFBIZ-9324 > URL: https://issues.apache.org/jira/browse/OFBIZ-9324 > Project: OFBiz > Issue Type: Bug > Components: accounting >Affects Versions: Trunk >Reporter: Ingo Wolfmayr >Assignee: Jacopo Cappellato > Fix For: 16.11.02 > > > 1. Shipment Receipt: 1 Piece for 15$ (Facility --> Receive Inventory) > 2. Item Variance: 1 Piece (via physical inventory on inventory item -1 > ATP, -1 QOH) - item lost > Step 1 > * increases the ACCOUNTING_QUANTITY --> ACCOUNTING_QUANTITY_DIFF = 1 > * creates an accounting transaction --> INVENTORY +1 (15$ Credit) > Step 2 > * ACCOUNTING_QUANTITY no change > * creates an accounting transaction --> INVENTORY -1 (15$ Debit) > Therefore the ITEM VALUATION report still shows 15$ / 1 Accounting Quanity > sum after step two. > Inventory variance should affect the accounting quantity. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Updated] (OFBIZ-7473) Induce Model XML from Database throws exception
[ https://issues.apache.org/jira/browse/OFBIZ-7473?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacopo Cappellato updated OFBIZ-7473: - Fix Version/s: (was: 16.11.02) > Induce Model XML from Database throws exception > --- > > Key: OFBIZ-7473 > URL: https://issues.apache.org/jira/browse/OFBIZ-7473 > Project: OFBiz > Issue Type: Bug > Components: framework/webtools >Affects Versions: Trunk >Reporter: Gopal Yadav >Assignee: Jacques Le Roux > Fix For: Upcoming Release > > Attachments: OFBIZ-7473.patch > > > Go to Webtools -> Import/Export -> Induce Model XML from Database > (https://localhost:8443/webtools/control/view/ModelInduceFromDb) > An exception is thrown: javax.servlet.ServletException: File > [/entity/ModelInduceFromDb.jsp] not found. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (OFBIZ-9392) Refactor CatalinaContainer
[ https://issues.apache.org/jira/browse/OFBIZ-9392?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16055232#comment-16055232 ] Jacopo Cappellato commented on OFBIZ-9392: -- I have reviewed the patch and it looks good to me, thank you for your work! I suggest to commit the work to trunk: further tests and enhancements can be done there. > Refactor CatalinaContainer > -- > > Key: OFBIZ-9392 > URL: https://issues.apache.org/jira/browse/OFBIZ-9392 > Project: OFBiz > Issue Type: Improvement > Components: framework >Reporter: Taher Alkhateeb >Assignee: Taher Alkhateeb >Priority: Minor > Attachments: OFBIZ-9392.patch, OFBIZ-9392.patch, OFBIZ-9392.patch, > OFBIZ-9392.patch > > > The implementation of CatalinaContainer.java is currently very verbose, has > replicated code, and is difficult to navigate. > The objective of this JIRA is to breakup the logic into smaller manageable > functions to allow for further enhancements in the future. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (OFBIZ-9305) change debug.properties property value cause ofbiz can't start
[
https://issues.apache.org/jira/browse/OFBIZ-9305?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jacopo Cappellato updated OFBIZ-9305:
-
Affects Version/s: 16.11.02
> change debug.properties property value cause ofbiz can't start
> --
>
> Key: OFBIZ-9305
> URL: https://issues.apache.org/jira/browse/OFBIZ-9305
> Project: OFBiz
> Issue Type: Bug
> Components: ALL APPLICATIONS
>Affects Versions: 16.11.01, 16.11.02
> Environment: windows 10 x64.
>Reporter: William Wang
> Attachments:
> TEST-org.apache.ofbiz.entity.util.EntitySaxReaderTests.xml
>
>
> change apache-ofbiz-16.11.01\framework\base\config\debug.properties
> print.verbose=false to print.verbose=true
> restart ofbiz with command line:gradlew.bat ofbiz get error happend;
> {code}
> org.apache.ofbiz.base.util.UtilCodecTests > testCheckStringForHtmlStrictNone
> STANDARD_OUT
> 11:07:31.743 [Test worker] ERROR org.apache.ofbiz.base.util.UtilCodec -
> Canonicalization (format consistency, character escaping that is mixed or
> double, etc) error for attribute named [double-encoding], String
> [%2%353Cscript]: org.apache.ofbiz.base.util.UtilCodec$IntrusionException:
> Input validation failure
> org.apache.ofbiz.entity.util.EntitySaxReaderTests > parse STANDARD_OUT
> 11:07:42.509 [Test worker] ERROR
> org.apache.ofbiz.entity.util.EntitySaxReader - An error occurred saving the
> data, rolling back transaction (true)
> java.lang.NullPointerException
> at
> org.apache.ofbiz.entity.util.EntitySaxReader.endElement(EntitySaxReader.java:404)
> ~[main/:?]
> at org.apache.xerces.parsers.AbstractSAXParser.endElement(Unknown
> Source) ~[xercesImpl-2.9.1.jar:?]
> at
> org.apache.xerces.parsers.AbstractXMLDocumentParser.emptyElement(Unknown
> Source) ~[xercesImpl-2.9.1.jar:?]
> at
> org.apache.xerces.impl.XMLDocumentFragmentScannerImpl.scanStartElement(Unknown
> Source) ~[xercesImpl-2.9.1.jar:?]
> at
> org.apache.xerces.impl.XMLDocumentFragmentScannerImpl$FragmentContentDispatcher.dispatch(Unknown
> Source) ~[xercesImpl-2.9.1.jar:?]
> at
> org.apache.xerces.impl.XMLDocumentFragmentScannerImpl.scanDocument(Unknown
> Source) ~[xercesImpl-2.9.1.jar:?]
> at org.apache.xerces.parsers.XML11Configuration.parse(Unknown Source)
> ~[xercesImpl-2.9.1.jar:?]
> at org.apache.xerces.parsers.XML11Configuration.parse(Unknown Source)
> ~[xercesImpl-2.9.1.jar:?]
> at org.apache.xerces.parsers.XMLParser.parse(Unknown Source)
> ~[xercesImpl-2.9.1.jar:?]
> at org.apache.xerces.parsers.AbstractSAXParser.parse(Unknown Source)
> ~[xercesImpl-2.9.1.jar:?]
> at org.apache.xerces.jaxp.SAXParserImpl$JAXPSAXParser.parse(Unknown
> Source) ~[xercesImpl-2.9.1.jar:?]
> at org.apache.xerces.jaxp.SAXParserImpl.parse(Unknown Source)
> ~[xercesImpl-2.9.1.jar:?]
> at javax.xml.parsers.SAXParser.parse(SAXParser.java:195)
> ~[?:1.8.0_121]
> at
> org.apache.ofbiz.entity.util.EntitySaxReader.parse(EntitySaxReader.java:225)
> [main/:?]
> at
> org.apache.ofbiz.entity.util.EntitySaxReader.parse(EntitySaxReader.java:186)
> [main/:?]
> at
> org.apache.ofbiz.entity.util.EntitySaxReaderTests.parse(EntitySaxReaderTests.java:62)
> [test/:?]
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> ~[?:1.8.0_121]
> at
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> ~[?:1.8.0_121]
> at
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> ~[?:1.8.0_121]
> at java.lang.reflect.Method.invoke(Method.java:498) ~[?:1.8.0_121]
> at
> org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:45)
> [junit-dep-4.10.jar:?]
> at
> org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:15)
> [junit-dep-4.10.jar:?]
> at
> org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:42)
> [junit-dep-4.10.jar:?]
> at
> org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:20)
> [junit-dep-4.10.jar:?]
> at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:263)
> [junit-dep-4.10.jar:?]
> at
> org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:68)
> [junit-dep-4.10.jar:?]
> at
> org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:47)
> [junit-dep-4.10.jar:?]
> at org.junit.runners.ParentRunner$3.run(ParentRunner.java:231)
> [junit-dep-4.10.jar:?]
> at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:60)
> [junit-dep-4.10.jar:?]
> at
[jira] [Updated] (OFBIZ-9305) change debug.properties property value cause ofbiz can't start
[
https://issues.apache.org/jira/browse/OFBIZ-9305?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jacopo Cappellato updated OFBIZ-9305:
-
Fix Version/s: 16.11.03
> change debug.properties property value cause ofbiz can't start
> --
>
> Key: OFBIZ-9305
> URL: https://issues.apache.org/jira/browse/OFBIZ-9305
> Project: OFBiz
> Issue Type: Bug
> Components: ALL APPLICATIONS
>Affects Versions: 16.11.01, 16.11.02
> Environment: windows 10 x64.
>Reporter: William Wang
>Assignee: Jacopo Cappellato
> Fix For: 16.11.03
>
> Attachments:
> TEST-org.apache.ofbiz.entity.util.EntitySaxReaderTests.xml
>
>
> change apache-ofbiz-16.11.01\framework\base\config\debug.properties
> print.verbose=false to print.verbose=true
> restart ofbiz with command line:gradlew.bat ofbiz get error happend;
> {code}
> org.apache.ofbiz.base.util.UtilCodecTests > testCheckStringForHtmlStrictNone
> STANDARD_OUT
> 11:07:31.743 [Test worker] ERROR org.apache.ofbiz.base.util.UtilCodec -
> Canonicalization (format consistency, character escaping that is mixed or
> double, etc) error for attribute named [double-encoding], String
> [%2%353Cscript]: org.apache.ofbiz.base.util.UtilCodec$IntrusionException:
> Input validation failure
> org.apache.ofbiz.entity.util.EntitySaxReaderTests > parse STANDARD_OUT
> 11:07:42.509 [Test worker] ERROR
> org.apache.ofbiz.entity.util.EntitySaxReader - An error occurred saving the
> data, rolling back transaction (true)
> java.lang.NullPointerException
> at
> org.apache.ofbiz.entity.util.EntitySaxReader.endElement(EntitySaxReader.java:404)
> ~[main/:?]
> at org.apache.xerces.parsers.AbstractSAXParser.endElement(Unknown
> Source) ~[xercesImpl-2.9.1.jar:?]
> at
> org.apache.xerces.parsers.AbstractXMLDocumentParser.emptyElement(Unknown
> Source) ~[xercesImpl-2.9.1.jar:?]
> at
> org.apache.xerces.impl.XMLDocumentFragmentScannerImpl.scanStartElement(Unknown
> Source) ~[xercesImpl-2.9.1.jar:?]
> at
> org.apache.xerces.impl.XMLDocumentFragmentScannerImpl$FragmentContentDispatcher.dispatch(Unknown
> Source) ~[xercesImpl-2.9.1.jar:?]
> at
> org.apache.xerces.impl.XMLDocumentFragmentScannerImpl.scanDocument(Unknown
> Source) ~[xercesImpl-2.9.1.jar:?]
> at org.apache.xerces.parsers.XML11Configuration.parse(Unknown Source)
> ~[xercesImpl-2.9.1.jar:?]
> at org.apache.xerces.parsers.XML11Configuration.parse(Unknown Source)
> ~[xercesImpl-2.9.1.jar:?]
> at org.apache.xerces.parsers.XMLParser.parse(Unknown Source)
> ~[xercesImpl-2.9.1.jar:?]
> at org.apache.xerces.parsers.AbstractSAXParser.parse(Unknown Source)
> ~[xercesImpl-2.9.1.jar:?]
> at org.apache.xerces.jaxp.SAXParserImpl$JAXPSAXParser.parse(Unknown
> Source) ~[xercesImpl-2.9.1.jar:?]
> at org.apache.xerces.jaxp.SAXParserImpl.parse(Unknown Source)
> ~[xercesImpl-2.9.1.jar:?]
> at javax.xml.parsers.SAXParser.parse(SAXParser.java:195)
> ~[?:1.8.0_121]
> at
> org.apache.ofbiz.entity.util.EntitySaxReader.parse(EntitySaxReader.java:225)
> [main/:?]
> at
> org.apache.ofbiz.entity.util.EntitySaxReader.parse(EntitySaxReader.java:186)
> [main/:?]
> at
> org.apache.ofbiz.entity.util.EntitySaxReaderTests.parse(EntitySaxReaderTests.java:62)
> [test/:?]
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> ~[?:1.8.0_121]
> at
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> ~[?:1.8.0_121]
> at
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> ~[?:1.8.0_121]
> at java.lang.reflect.Method.invoke(Method.java:498) ~[?:1.8.0_121]
> at
> org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:45)
> [junit-dep-4.10.jar:?]
> at
> org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:15)
> [junit-dep-4.10.jar:?]
> at
> org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:42)
> [junit-dep-4.10.jar:?]
> at
> org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:20)
> [junit-dep-4.10.jar:?]
> at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:263)
> [junit-dep-4.10.jar:?]
> at
> org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:68)
> [junit-dep-4.10.jar:?]
> at
> org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:47)
> [junit-dep-4.10.jar:?]
> at org.junit.runners.ParentRunner$3.run(ParentRunner.java:231)
> [junit-dep-4.10.jar:?]
> at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:60)
>
[jira] [Commented] (OFBIZ-9305) change debug.properties property value cause ofbiz can't start
[
https://issues.apache.org/jira/browse/OFBIZ-9305?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16057298#comment-16057298
]
Jacopo Cappellato commented on OFBIZ-9305:
--
Thank you William!
This issue has been fixed in trunk with revision 1799417 and in 16.03 with
revision 1799419
> change debug.properties property value cause ofbiz can't start
> --
>
> Key: OFBIZ-9305
> URL: https://issues.apache.org/jira/browse/OFBIZ-9305
> Project: OFBiz
> Issue Type: Bug
> Components: ALL APPLICATIONS
>Affects Versions: 16.11.01, 16.11.02
> Environment: windows 10 x64.
>Reporter: William Wang
>Assignee: Jacopo Cappellato
> Fix For: 16.11.03
>
> Attachments:
> TEST-org.apache.ofbiz.entity.util.EntitySaxReaderTests.xml
>
>
> change apache-ofbiz-16.11.01\framework\base\config\debug.properties
> print.verbose=false to print.verbose=true
> restart ofbiz with command line:gradlew.bat ofbiz get error happend;
> {code}
> org.apache.ofbiz.base.util.UtilCodecTests > testCheckStringForHtmlStrictNone
> STANDARD_OUT
> 11:07:31.743 [Test worker] ERROR org.apache.ofbiz.base.util.UtilCodec -
> Canonicalization (format consistency, character escaping that is mixed or
> double, etc) error for attribute named [double-encoding], String
> [%2%353Cscript]: org.apache.ofbiz.base.util.UtilCodec$IntrusionException:
> Input validation failure
> org.apache.ofbiz.entity.util.EntitySaxReaderTests > parse STANDARD_OUT
> 11:07:42.509 [Test worker] ERROR
> org.apache.ofbiz.entity.util.EntitySaxReader - An error occurred saving the
> data, rolling back transaction (true)
> java.lang.NullPointerException
> at
> org.apache.ofbiz.entity.util.EntitySaxReader.endElement(EntitySaxReader.java:404)
> ~[main/:?]
> at org.apache.xerces.parsers.AbstractSAXParser.endElement(Unknown
> Source) ~[xercesImpl-2.9.1.jar:?]
> at
> org.apache.xerces.parsers.AbstractXMLDocumentParser.emptyElement(Unknown
> Source) ~[xercesImpl-2.9.1.jar:?]
> at
> org.apache.xerces.impl.XMLDocumentFragmentScannerImpl.scanStartElement(Unknown
> Source) ~[xercesImpl-2.9.1.jar:?]
> at
> org.apache.xerces.impl.XMLDocumentFragmentScannerImpl$FragmentContentDispatcher.dispatch(Unknown
> Source) ~[xercesImpl-2.9.1.jar:?]
> at
> org.apache.xerces.impl.XMLDocumentFragmentScannerImpl.scanDocument(Unknown
> Source) ~[xercesImpl-2.9.1.jar:?]
> at org.apache.xerces.parsers.XML11Configuration.parse(Unknown Source)
> ~[xercesImpl-2.9.1.jar:?]
> at org.apache.xerces.parsers.XML11Configuration.parse(Unknown Source)
> ~[xercesImpl-2.9.1.jar:?]
> at org.apache.xerces.parsers.XMLParser.parse(Unknown Source)
> ~[xercesImpl-2.9.1.jar:?]
> at org.apache.xerces.parsers.AbstractSAXParser.parse(Unknown Source)
> ~[xercesImpl-2.9.1.jar:?]
> at org.apache.xerces.jaxp.SAXParserImpl$JAXPSAXParser.parse(Unknown
> Source) ~[xercesImpl-2.9.1.jar:?]
> at org.apache.xerces.jaxp.SAXParserImpl.parse(Unknown Source)
> ~[xercesImpl-2.9.1.jar:?]
> at javax.xml.parsers.SAXParser.parse(SAXParser.java:195)
> ~[?:1.8.0_121]
> at
> org.apache.ofbiz.entity.util.EntitySaxReader.parse(EntitySaxReader.java:225)
> [main/:?]
> at
> org.apache.ofbiz.entity.util.EntitySaxReader.parse(EntitySaxReader.java:186)
> [main/:?]
> at
> org.apache.ofbiz.entity.util.EntitySaxReaderTests.parse(EntitySaxReaderTests.java:62)
> [test/:?]
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> ~[?:1.8.0_121]
> at
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> ~[?:1.8.0_121]
> at
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> ~[?:1.8.0_121]
> at java.lang.reflect.Method.invoke(Method.java:498) ~[?:1.8.0_121]
> at
> org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:45)
> [junit-dep-4.10.jar:?]
> at
> org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:15)
> [junit-dep-4.10.jar:?]
> at
> org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:42)
> [junit-dep-4.10.jar:?]
> at
> org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:20)
> [junit-dep-4.10.jar:?]
> at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:263)
> [junit-dep-4.10.jar:?]
> at
> org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:68)
> [junit-dep-4.10.jar:?]
> at
> org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:47)
> [junit-dep-4.10.jar:?]
> at org.junit.runners.ParentRunner$3.run(ParentRunner.java:231)
[jira] [Assigned] (OFBIZ-9305) change debug.properties property value cause ofbiz can't start
[
https://issues.apache.org/jira/browse/OFBIZ-9305?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jacopo Cappellato reassigned OFBIZ-9305:
Assignee: Jacopo Cappellato
> change debug.properties property value cause ofbiz can't start
> --
>
> Key: OFBIZ-9305
> URL: https://issues.apache.org/jira/browse/OFBIZ-9305
> Project: OFBiz
> Issue Type: Bug
> Components: ALL APPLICATIONS
>Affects Versions: 16.11.01, 16.11.02
> Environment: windows 10 x64.
>Reporter: William Wang
>Assignee: Jacopo Cappellato
> Attachments:
> TEST-org.apache.ofbiz.entity.util.EntitySaxReaderTests.xml
>
>
> change apache-ofbiz-16.11.01\framework\base\config\debug.properties
> print.verbose=false to print.verbose=true
> restart ofbiz with command line:gradlew.bat ofbiz get error happend;
> {code}
> org.apache.ofbiz.base.util.UtilCodecTests > testCheckStringForHtmlStrictNone
> STANDARD_OUT
> 11:07:31.743 [Test worker] ERROR org.apache.ofbiz.base.util.UtilCodec -
> Canonicalization (format consistency, character escaping that is mixed or
> double, etc) error for attribute named [double-encoding], String
> [%2%353Cscript]: org.apache.ofbiz.base.util.UtilCodec$IntrusionException:
> Input validation failure
> org.apache.ofbiz.entity.util.EntitySaxReaderTests > parse STANDARD_OUT
> 11:07:42.509 [Test worker] ERROR
> org.apache.ofbiz.entity.util.EntitySaxReader - An error occurred saving the
> data, rolling back transaction (true)
> java.lang.NullPointerException
> at
> org.apache.ofbiz.entity.util.EntitySaxReader.endElement(EntitySaxReader.java:404)
> ~[main/:?]
> at org.apache.xerces.parsers.AbstractSAXParser.endElement(Unknown
> Source) ~[xercesImpl-2.9.1.jar:?]
> at
> org.apache.xerces.parsers.AbstractXMLDocumentParser.emptyElement(Unknown
> Source) ~[xercesImpl-2.9.1.jar:?]
> at
> org.apache.xerces.impl.XMLDocumentFragmentScannerImpl.scanStartElement(Unknown
> Source) ~[xercesImpl-2.9.1.jar:?]
> at
> org.apache.xerces.impl.XMLDocumentFragmentScannerImpl$FragmentContentDispatcher.dispatch(Unknown
> Source) ~[xercesImpl-2.9.1.jar:?]
> at
> org.apache.xerces.impl.XMLDocumentFragmentScannerImpl.scanDocument(Unknown
> Source) ~[xercesImpl-2.9.1.jar:?]
> at org.apache.xerces.parsers.XML11Configuration.parse(Unknown Source)
> ~[xercesImpl-2.9.1.jar:?]
> at org.apache.xerces.parsers.XML11Configuration.parse(Unknown Source)
> ~[xercesImpl-2.9.1.jar:?]
> at org.apache.xerces.parsers.XMLParser.parse(Unknown Source)
> ~[xercesImpl-2.9.1.jar:?]
> at org.apache.xerces.parsers.AbstractSAXParser.parse(Unknown Source)
> ~[xercesImpl-2.9.1.jar:?]
> at org.apache.xerces.jaxp.SAXParserImpl$JAXPSAXParser.parse(Unknown
> Source) ~[xercesImpl-2.9.1.jar:?]
> at org.apache.xerces.jaxp.SAXParserImpl.parse(Unknown Source)
> ~[xercesImpl-2.9.1.jar:?]
> at javax.xml.parsers.SAXParser.parse(SAXParser.java:195)
> ~[?:1.8.0_121]
> at
> org.apache.ofbiz.entity.util.EntitySaxReader.parse(EntitySaxReader.java:225)
> [main/:?]
> at
> org.apache.ofbiz.entity.util.EntitySaxReader.parse(EntitySaxReader.java:186)
> [main/:?]
> at
> org.apache.ofbiz.entity.util.EntitySaxReaderTests.parse(EntitySaxReaderTests.java:62)
> [test/:?]
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> ~[?:1.8.0_121]
> at
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> ~[?:1.8.0_121]
> at
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> ~[?:1.8.0_121]
> at java.lang.reflect.Method.invoke(Method.java:498) ~[?:1.8.0_121]
> at
> org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:45)
> [junit-dep-4.10.jar:?]
> at
> org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:15)
> [junit-dep-4.10.jar:?]
> at
> org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:42)
> [junit-dep-4.10.jar:?]
> at
> org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:20)
> [junit-dep-4.10.jar:?]
> at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:263)
> [junit-dep-4.10.jar:?]
> at
> org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:68)
> [junit-dep-4.10.jar:?]
> at
> org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:47)
> [junit-dep-4.10.jar:?]
> at org.junit.runners.ParentRunner$3.run(ParentRunner.java:231)
> [junit-dep-4.10.jar:?]
> at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:60)
> [junit-dep-4.10.jar:?]
> at
[jira] [Commented] (OFBIZ-9380) renderDateTimeField works in IE, not working with lastest Chrome
[
https://issues.apache.org/jira/browse/OFBIZ-9380?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16024924#comment-16024924
]
Jacopo Cappellato commented on OFBIZ-9380:
--
Thank you for the report [~chuck_kosta].
I have tried to recreate the bug using the demo data and the out-of-the-box
application; here are the steps I have followed:
1) setup an instance of OFBiz 14.12 with demo data (./ant clean-all load-demo
start)
2) go to Catalog->Promos->select the first promotion and then select the
"stores" tab; here is a shortcut (authenticate as admin/ofbiz):
https://localhost:8443/catalog/control/EditProductPromoStores?productPromoId=9020
3) in the screen, the input box with column named "THROUGH DATE" is rendered
using the @htmlTemplate.renderDateTimeField macro (see the file
EditProductPromoStores.ftl)
4) select a date value and submit the form; the data is saved in the database
I have tested it with Chrome.
Could you please confirm if you can run the same steps? You could compare the
fields set in this macro cal with the ones that you set in your screen and
hopefully this will provide some clues about the nature of the issue.
> renderDateTimeField works in IE, not working with lastest Chrome
>
>
> Key: OFBIZ-9380
> URL: https://issues.apache.org/jira/browse/OFBIZ-9380
> Project: OFBiz
> Issue Type: Bug
>Affects Versions: Release Branch 14.12
>Reporter: Chuck Kosta
>
> {code}
> <@htmlTemplate.renderDateTimeField ... />
> {code}
> Works correctly in IE; but in firefox and chrome, it ignores the values when
> sent to an entity updating service call. The page gets refreshed with the
> original date.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (OFBIZ-9833) Token Based Authentication
[ https://issues.apache.org/jira/browse/OFBIZ-9833?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16198364#comment-16198364 ] Jacopo Cappellato commented on OFBIZ-9833: -- Thank you Jacques. Deepak, I know you have also implemented a lightweight but complete solution to provide a web token authentication mechanism for clients performing API calls to OFBiz: it would be great if you could share it here for community review. > Token Based Authentication > -- > > Key: OFBIZ-9833 > URL: https://issues.apache.org/jira/browse/OFBIZ-9833 > Project: OFBiz > Issue Type: New Feature >Reporter: Deepak Dixit >Assignee: Jacques Le Roux > Attachments: JSON Web Tokens.pdf, Token Based Authentication in > Apache OfBiz.pdf, Token Based Authentication.pdf, rfc7519.pdf > > > Here is dev list discussion for token based authentication work: > http://markmail.org/message/vyskeh2wujqpkbwg -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (OFBIZ-9500) Maintain accountingQuantity for all COGS valuation methods
[ https://issues.apache.org/jira/browse/OFBIZ-9500?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16199945#comment-16199945 ] Jacopo Cappellato commented on OFBIZ-9500: -- I have voted for this issue! [~paul_foxworthy]'s description of the current situation and the proposed fix is perfect. On a side note, there are other processes (alternative use cases/corner cases) that may introduce some errors in the accounting quantity values; but we will analyze and fix them after the above changes have been introduced as suggested by Paul. > Maintain accountingQuantity for all COGS valuation methods > -- > > Key: OFBIZ-9500 > URL: https://issues.apache.org/jira/browse/OFBIZ-9500 > Project: OFBiz > Issue Type: Improvement > Components: accounting, order, product >Affects Versions: Trunk >Reporter: Paul Foxworthy >Assignee: Paul Foxworthy > Labels: accounting, inventory, stock, valuation > > From > http://ofbiz.135035.n4.nabble.com/AccountingQuantity-COGS-method-and-inventory-valuation-td4700867.html > *Why accounting quantity?* > When inventory is shipped, there's an accounting transaction that debits the > inventory on hand value and credits Cost of Goods Sold (COGS). > There's more than one way of deciding what value is added to COGS. > First and most obvious is the actual cost of the inventory item. But > companies may prefer other strategies. OFBiz has the option of three others: > average cost, first-in-first-out or last-in-first-out. There's a nice survey > of _why_ you might choose one of these at > http://www.dummies.com/business/operations-management/choosing-an-accounting-method-for-the-cost-of-goods-sold-expense/, > > http://www.dummies.com/business/accounting/the-fifo-method-for-cost-of-goods-sold/, > > http://www.dummies.com/business/accounting/the-lifo-method-for-cost-of-goods-sold/ > > Note that if you choose anything other than inventory item cost, the money > amount transferred to the COGS account may be *different* to the cost price > of the inventory items being shipped. When you choose FIFO or LIFO, the > amount may have originated from a different inventory item, received at a > different time. > *Current situation in OFBiz* > The cogsMethodId field in the PartyAcctgPreference entity is a enum with four > possible values: COGS_INV_COST, COGS_AVG_COST, COGS_FIFO, COGS_LIFO.. > The accountingQuantity field in the InventoryItem entity and > accountingQuantityDiff in the InventoryItemDetail entity track the quantity > of an item still "live" for the purpose of inventory valuation and COGS. > In the service createAcctgTransForShipmentReceipt implemented in > /applications/accounting/minilang/ledger/GeneralLedgerServices.xml > (http://svn.apache.org/viewvc/ofbiz/ofbiz-framework/trunk/applications/accounting/minilang/ledger/GeneralLedgerServices.xml?view=markup#l1306) > > the accountingQuantity is always set to the same value as the quantity > received (i.e. the same as the quantityOnHand) for a newly received inventory > item regardless of the COGS method. > When items are shipped, the service createAcctgTransForSalesShipmentIssuance > will only reduce the accounting quantity if the COGS method is FIFO or LIFO > (http://svn.apache.org/viewvc/ofbiz/ofbiz-framework/trunk/applications/accounting/minilang/ledger/GeneralLedgerServices.xml?view=markup#l1127). > With FIFO, when an item is shipped, inventory items for the product with a > non-zero accounting quantity are found sorted from earliest to latest > received. The quantity of the item shipped must be decremented from the > accounting quantities, starting with the earliest. Similarly, with LIFO, > items are sorted from latest to earliest, and the latest item or items are > decremented. > In other words, if you have chosen a COGS method of COGS_INV_COST or > COGS_AVG_COST, the accounting quantity is meaningless and in OFBiz as of > now, should be ignored. > And yet, the Inventory Valuation report uses accounting quantity, regardless > of the the COGS method > (http://svn.apache.org/viewvc/ofbiz/trunk/applications/accounting/widget/ReportFinancialSummaryForms.xml?view=markup#l535). > In other words, the Inventory Valuation report is broken for COGS methods of > COGS_INV_COST or COGS_AVG_COST. > *What should happen* > The Inventory Valuation report, and anybody else who cares, should always be > able to trust the accounting quantity. For COGS_INV_COST and COGS_AVG_COST, > maintaining the accounting quantity is simple - > createAcctgTransForSalesShipmentIssuanceit should just adjust it to match the > remaining quantity on hand. > No matter what the COGS method, the total accounting quantity for a product > across all inventory items should always be equal to the total
[jira] [Closed] (OFBIZ-9525) MRP incorrectly computes quantity already received in open purchase order shipments
[ https://issues.apache.org/jira/browse/OFBIZ-9525?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacopo Cappellato closed OFBIZ-9525. > MRP incorrectly computes quantity already received in open purchase order > shipments > --- > > Key: OFBIZ-9525 > URL: https://issues.apache.org/jira/browse/OFBIZ-9525 > Project: OFBiz > Issue Type: Bug > Components: manufacturing >Affects Versions: Trunk, 16.11.03 >Reporter: Jacopo Cappellato >Assignee: Jacopo Cappellato > Fix For: Upcoming Release, 16.11.04 > > Attachments: OFBIZ-9525_14.12.patch, OFBIZ-9525_trunk.patch > > > The MRP algorithm incorrectly computes the quantity of items partially > received in a purchase shipment because it leverages the > OrderReadHelper.getItemShippedQuantity(...) method that is intended to be > used to count the quantity shipped of a sales order. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (OFBIZ-9525) MRP incorrectly computes quantity already received in open purchase order shipments
[ https://issues.apache.org/jira/browse/OFBIZ-9525?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16151826#comment-16151826 ] Jacopo Cappellato commented on OFBIZ-9525: -- Amit, I see that in the proposed patch you have added a try/catch block with an empty catch block: it would be better to suppress it completely or, if there is a use case, add behavior to the block (e.g. add a log statement etc...). > MRP incorrectly computes quantity already received in open purchase order > shipments > --- > > Key: OFBIZ-9525 > URL: https://issues.apache.org/jira/browse/OFBIZ-9525 > Project: OFBiz > Issue Type: Bug > Components: manufacturing >Affects Versions: Trunk, 16.11.03 >Reporter: Jacopo Cappellato >Assignee: Jacopo Cappellato > Attachments: OFBIZ-9525_14.12.patch, OFBIZ-9525_trunk.diff > > > The MRP algorithm incorrectly computes the quantity of items partially > received in a purchase shipment because it leverages the > OrderReadHelper.getItemShippedQuantity(...) method that is intended to be > used to count the quantity shipped of a sales order. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Created] (OFBIZ-10054) Product content management screen doesn't validate trusted users' input
Jacopo Cappellato created OFBIZ-10054: - Summary: Product content management screen doesn't validate trusted users' input Key: OFBIZ-10054 URL: https://issues.apache.org/jira/browse/OFBIZ-10054 Project: OFBiz Issue Type: Improvement Components: product Affects Versions: Release Branch 16.11, Trunk Reporter: Jacopo Cappellato Steps to recreate: 1) go to (authenticate with admin/ofbiz): https://localhost:8443/catalog/control/EditProductContent?productId=WG- 2) set the content of the field labeled "Large Image" to: non_existent.foo onerror=alert(Hi!); 3) visit the url: https://localhost:8443/ecommerce/control/product?product_id=WG- A popup message will appear with the "Hi!". Thanks to Loris Nardo for the report. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (OFBIZ-10304) The "request" attribute type of the userLogin service is wrong
[
https://issues.apache.org/jira/browse/OFBIZ-10304?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16465564#comment-16465564
]
Jacopo Cappellato commented on OFBIZ-10304:
---
Hi [~jacques.le.roux] I think tow that we have resolved 10036 we can safely
apply the patch OFBIZ-10304-new.patch
> The "request" attribute type of the userLogin service is wrong
> --
>
> Key: OFBIZ-10304
> URL: https://issues.apache.org/jira/browse/OFBIZ-10304
> Project: OFBiz
> Issue Type: Bug
> Components: framework
>Affects Versions: Trunk, 17.12.01
>Reporter: Jacques Le Roux
>Assignee: Jacques Le Roux
>Priority: Blocker
> Fix For: 17.12.01
>
> Attachments: OFBIZ-10304.patch
>
>
> I commited
> [http://svn.apache.org/viewvc/ofbiz/ofbiz-framework/trunk/framework/webapp/src/main/java/org/apache/ofbiz/webapp/control/ContextFilter.java?r1=1813679=1813678=1813679]
> which I guess forced (or allowed?) James Yong to use the
> javax.servlet.http.HttpServletRequest as type of "request" attribute of the
> userLogin service at
> [http://svn.apache.org/viewvc/ofbiz/ofbiz-framework/trunk/framework/common/servicedef/services.xml?r1=1819133=1819132=1819133]
> Else it would (should?) have been
> type="org.apache.catalina.connector.RequestFacade" optional="true"/>
> Now I need to revert/remove the wrapper in ContextFilter which is useless and
> silly (my bad).
> {color:#ff}-After a deeper investigation today (saturday 2019-03-24) the
> right solution is now attached as a patch-
> UPDATE: we had a discussion on this subject at
> [https://markmail.org/message/4jwrnbhpapb4ncrd] and Scott suggested to rather
> temporary use the child element of the
> element. Temporary because the definitive solution (w/o using
> ) could be either to update to Tomcat 9 (preferred) or even
> downgrade to Tomcat 8. I guess nobody really want the later because only the
> trunk and not yet released R17.12 branch are concerned.{color}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (OFBIZ-10304) The "request" attribute type of the userLogin service is wrong
[
https://issues.apache.org/jira/browse/OFBIZ-10304?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jacopo Cappellato updated OFBIZ-10304:
--
Attachment: OFBIZ-10304-new.patch
> The "request" attribute type of the userLogin service is wrong
> --
>
> Key: OFBIZ-10304
> URL: https://issues.apache.org/jira/browse/OFBIZ-10304
> Project: OFBiz
> Issue Type: Bug
> Components: framework
>Affects Versions: Trunk, 17.12.01
>Reporter: Jacques Le Roux
>Assignee: Jacques Le Roux
>Priority: Blocker
> Fix For: 17.12.01
>
> Attachments: OFBIZ-10304-new.patch, OFBIZ-10304.patch
>
>
> I commited
> [http://svn.apache.org/viewvc/ofbiz/ofbiz-framework/trunk/framework/webapp/src/main/java/org/apache/ofbiz/webapp/control/ContextFilter.java?r1=1813679=1813678=1813679]
> which I guess forced (or allowed?) James Yong to use the
> javax.servlet.http.HttpServletRequest as type of "request" attribute of the
> userLogin service at
> [http://svn.apache.org/viewvc/ofbiz/ofbiz-framework/trunk/framework/common/servicedef/services.xml?r1=1819133=1819132=1819133]
> Else it would (should?) have been
> type="org.apache.catalina.connector.RequestFacade" optional="true"/>
> Now I need to revert/remove the wrapper in ContextFilter which is useless and
> silly (my bad).
> {color:#ff}-After a deeper investigation today (saturday 2019-03-24) the
> right solution is now attached as a patch-
> UPDATE: we had a discussion on this subject at
> [https://markmail.org/message/4jwrnbhpapb4ncrd] and Scott suggested to rather
> temporary use the child element of the
> element. Temporary because the definitive solution (w/o using
> ) could be either to update to Tomcat 9 (preferred) or even
> downgrade to Tomcat 8. I guess nobody really want the later because only the
> trunk and not yet released R17.12 branch are concerned.{color}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
