[jira] [Commented] (OAK-8111) Create read-only DocumentNodeStore for oak-run recovery dry run

2019-05-23 Thread Julian Reschke (JIRA) 


[ 
https://issues.apache.org/jira/browse/OAK-8111?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16846693#comment-16846693
 ] 

Julian Reschke commented on OAK-8111:
-

trunk: [r1859780|http://svn.apache.org/r1859780] (1.12.0) 
[r1857010|http://svn.apache.org/r1857010] 
[r1855776|http://svn.apache.org/r1855776]
1.10: [r1857013|http://svn.apache.org/r1857013] 
[r1857009|http://svn.apache.org/r1857009]
1.8: (1.8.13) [r1857017|http://svn.apache.org/r1857017]


> Create read-only DocumentNodeStore for oak-run recovery dry run
> ---
>
> Key: OAK-8111
> URL: https://issues.apache.org/jira/browse/OAK-8111
> Project: Jackrabbit Oak
>  Issue Type: Improvement
>  Components: oak-run
>Reporter: Marcel Reutegger
>Assignee: Julian Reschke
>Priority: Minor
>  Labels: candidate_oak_1_6
> Fix For: 1.12.0, 1.8.13, 1.10.3
>
> Attachments: OAK-8111-2.diff, OAK-8111.diff, OAK-8111.diff, 
> OAK-8111.diff, OAK-8111.diff
>
>
> The oak-run recovery command always creates a read-write DocumentNodeStore 
> even when the dryRun flag is set. In dryRun mode, the command should create a 
> read-only DocumentNodeStore.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (OAK-8111) Create read-only DocumentNodeStore for oak-run recovery dry run

2019-03-18 Thread Julian Reschke (JIRA) 


[ 
https://issues.apache.org/jira/browse/OAK-8111?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16795135#comment-16795135
 ] 

Julian Reschke commented on OAK-8111:
-

trunk: [r1855776|http://svn.apache.org/r1855776]

> Create read-only DocumentNodeStore for oak-run recovery dry run
> ---
>
> Key: OAK-8111
> URL: https://issues.apache.org/jira/browse/OAK-8111
> Project: Jackrabbit Oak
>  Issue Type: Improvement
>  Components: oak-run
>Reporter: Marcel Reutegger
>Assignee: Julian Reschke
>Priority: Minor
>  Labels: candidate_oak_1_10, candidate_oak_1_8
> Fix For: 1.12, 1.11.0
>
> Attachments: OAK-8111-2.diff, OAK-8111.diff, OAK-8111.diff, 
> OAK-8111.diff, OAK-8111.diff
>
>
> The oak-run recovery command always creates a read-write DocumentNodeStore 
> even when the dryRun flag is set. In dryRun mode, the command should create a 
> read-only DocumentNodeStore.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (OAK-8111) Create read-only DocumentNodeStore for oak-run recovery dry run

2019-03-18 Thread Marcel Reutegger (JIRA) 


[ 
https://issues.apache.org/jira/browse/OAK-8111?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16795075#comment-16795075
 ] 

Marcel Reutegger commented on OAK-8111:
---

Yes, please. Feel free to commit.

> Create read-only DocumentNodeStore for oak-run recovery dry run
> ---
>
> Key: OAK-8111
> URL: https://issues.apache.org/jira/browse/OAK-8111
> Project: Jackrabbit Oak
>  Issue Type: Improvement
>  Components: oak-run
>Reporter: Marcel Reutegger
>Assignee: Julian Reschke
>Priority: Minor
>  Labels: candidate_oak_1_10, candidate_oak_1_8
> Fix For: 1.12
>
> Attachments: OAK-8111-2.diff, OAK-8111.diff, OAK-8111.diff, 
> OAK-8111.diff, OAK-8111.diff
>
>
> The oak-run recovery command always creates a read-write DocumentNodeStore 
> even when the dryRun flag is set. In dryRun mode, the command should create a 
> read-only DocumentNodeStore.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (OAK-8111) Create read-only DocumentNodeStore for oak-run recovery dry run

2019-03-18 Thread Julian Reschke (JIRA) 


[ 
https://issues.apache.org/jira/browse/OAK-8111?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16795073#comment-16795073
 ] 

Julian Reschke commented on OAK-8111:
-

[~mreutegg] - LGTM - should I commit the oatch?

> Create read-only DocumentNodeStore for oak-run recovery dry run
> ---
>
> Key: OAK-8111
> URL: https://issues.apache.org/jira/browse/OAK-8111
> Project: Jackrabbit Oak
>  Issue Type: Improvement
>  Components: oak-run
>Reporter: Marcel Reutegger
>Assignee: Julian Reschke
>Priority: Minor
>  Labels: candidate_oak_1_10, candidate_oak_1_8
> Fix For: 1.12
>
> Attachments: OAK-8111-2.diff, OAK-8111.diff, OAK-8111.diff, 
> OAK-8111.diff, OAK-8111.diff
>
>
> The oak-run recovery command always creates a read-write DocumentNodeStore 
> even when the dryRun flag is set. In dryRun mode, the command should create a 
> read-only DocumentNodeStore.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (OAK-8111) Create read-only DocumentNodeStore for oak-run recovery dry run

2019-03-07 Thread Marcel Reutegger (JIRA) 


[ 
https://issues.apache.org/jira/browse/OAK-8111?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16786981#comment-16786981
 ] 

Marcel Reutegger commented on OAK-8111:
---

A few comments:

The cast to DocumentNodeStore is unnecessary because the builder already 
returns a DocumentNodeStore. I would also add the state close to the clusterId 
in the list of clusterIds. This makes it more obvious which one can be used to 
run the recovery. The command cannot run in read-write mode on an active 
clusterId.
See my patch: [^OAK-8111-2.diff].

> Create read-only DocumentNodeStore for oak-run recovery dry run
> ---
>
> Key: OAK-8111
> URL: https://issues.apache.org/jira/browse/OAK-8111
> Project: Jackrabbit Oak
>  Issue Type: Improvement
>  Components: oak-run
>Reporter: Marcel Reutegger
>Assignee: Julian Reschke
>Priority: Minor
>  Labels: candidate_oak_1_10, candidate_oak_1_8
> Fix For: 1.12
>
> Attachments: OAK-8111-2.diff, OAK-8111.diff, OAK-8111.diff, 
> OAK-8111.diff, OAK-8111.diff
>
>
> The oak-run recovery command always creates a read-write DocumentNodeStore 
> even when the dryRun flag is set. In dryRun mode, the command should create a 
> read-only DocumentNodeStore.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (OAK-8111) Create read-only DocumentNodeStore for oak-run recovery dry run

2019-03-07 Thread Julian Reschke (JIRA) 


[ 
https://issues.apache.org/jira/browse/OAK-8111?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16786710#comment-16786710
 ] 

Julian Reschke commented on OAK-8111:
-

[^OAK-8111.diff] - new patch that makes {{--clusterId}} a required parameter.

> Create read-only DocumentNodeStore for oak-run recovery dry run
> ---
>
> Key: OAK-8111
> URL: https://issues.apache.org/jira/browse/OAK-8111
> Project: Jackrabbit Oak
>  Issue Type: Improvement
>  Components: oak-run
>Reporter: Marcel Reutegger
>Assignee: Julian Reschke
>Priority: Minor
>  Labels: candidate_oak_1_10, candidate_oak_1_8
> Fix For: 1.12
>
> Attachments: OAK-8111.diff, OAK-8111.diff, OAK-8111.diff, 
> OAK-8111.diff
>
>
> The oak-run recovery command always creates a read-write DocumentNodeStore 
> even when the dryRun flag is set. In dryRun mode, the command should create a 
> read-only DocumentNodeStore.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (OAK-8111) Create read-only DocumentNodeStore for oak-run recovery dry run

2019-03-07 Thread Julian Reschke (JIRA) 


[ 
https://issues.apache.org/jira/browse/OAK-8111?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16786539#comment-16786539
 ] 

Julian Reschke commented on OAK-8111:
-

bq. The clusterId will be arbitrary when started without --clusterId and in 
read-write mode. When all clusterIds are active, this won't do anything useful 
but only create a new clusterId and run recovery for it.

Well, it's not entirely arbitrary, but I see what you mean.

So let's make --clusterId required for this command. Will update that patch.

> Create read-only DocumentNodeStore for oak-run recovery dry run
> ---
>
> Key: OAK-8111
> URL: https://issues.apache.org/jira/browse/OAK-8111
> Project: Jackrabbit Oak
>  Issue Type: Improvement
>  Components: oak-run
>Reporter: Marcel Reutegger
>Assignee: Julian Reschke
>Priority: Minor
>  Labels: candidate_oak_1_10, candidate_oak_1_8
> Fix For: 1.12
>
> Attachments: OAK-8111.diff, OAK-8111.diff, OAK-8111.diff
>
>
> The oak-run recovery command always creates a read-write DocumentNodeStore 
> even when the dryRun flag is set. In dryRun mode, the command should create a 
> read-only DocumentNodeStore.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (OAK-8111) Create read-only DocumentNodeStore for oak-run recovery dry run

2019-03-07 Thread Marcel Reutegger (JIRA) 


[ 
https://issues.apache.org/jira/browse/OAK-8111?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16786521#comment-16786521
 ] 

Marcel Reutegger commented on OAK-8111:
---

bq. Yes, but should this be done in the context of this ticket?

Not necessarily. We can also move it to a separate issue.

bq. Why do you say "arbitrary"?

The clusterId will be arbitrary when started without --clusterId and in 
read-write mode. When all clusterIds are active, this won't do anything useful 
but only create a new clusterId and run recovery for it.

> Create read-only DocumentNodeStore for oak-run recovery dry run
> ---
>
> Key: OAK-8111
> URL: https://issues.apache.org/jira/browse/OAK-8111
> Project: Jackrabbit Oak
>  Issue Type: Improvement
>  Components: oak-run
>Reporter: Marcel Reutegger
>Assignee: Julian Reschke
>Priority: Minor
>  Labels: candidate_oak_1_10, candidate_oak_1_8
> Fix For: 1.12
>
> Attachments: OAK-8111.diff, OAK-8111.diff, OAK-8111.diff
>
>
> The oak-run recovery command always creates a read-write DocumentNodeStore 
> even when the dryRun flag is set. In dryRun mode, the command should create a 
> read-only DocumentNodeStore.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (OAK-8111) Create read-only DocumentNodeStore for oak-run recovery dry run

2019-03-07 Thread Julian Reschke (JIRA) 


[ 
https://issues.apache.org/jira/browse/OAK-8111?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16786509#comment-16786509
 ] 

Julian Reschke commented on OAK-8111:
-

bq. I like Vikas idea about creating the DocumentNodeStore in read-only mode by 
default and require a user to explicitly specify the read-write mode. This 
changes behaviour and basically means dryRun is ignored, but I think it may be 
worth it.

Yes, but should this be done in the context of this ticket?

bq. I would also make the --clusterId required. Just using an arbitrary 
available clusterId does not seem useful for the recovery command.

Why do you say "arbitrary"? With the current patch, when "dryRun" is specified, 
--clusterId de facto becomes required.

bq. As for the question what clusterIds are available, I suggest we create a 
separate command that lists the clusterIds, their state and additional 
information like lease end, etc.

We can split that off, but I'd still think that outputting the information  
automatically in this case is still a good idea.

> Create read-only DocumentNodeStore for oak-run recovery dry run
> ---
>
> Key: OAK-8111
> URL: https://issues.apache.org/jira/browse/OAK-8111
> Project: Jackrabbit Oak
>  Issue Type: Improvement
>  Components: oak-run
>Reporter: Marcel Reutegger
>Assignee: Julian Reschke
>Priority: Minor
>  Labels: candidate_oak_1_10, candidate_oak_1_8
> Fix For: 1.12
>
> Attachments: OAK-8111.diff, OAK-8111.diff, OAK-8111.diff
>
>
> The oak-run recovery command always creates a read-write DocumentNodeStore 
> even when the dryRun flag is set. In dryRun mode, the command should create a 
> read-only DocumentNodeStore.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (OAK-8111) Create read-only DocumentNodeStore for oak-run recovery dry run

2019-03-07 Thread Marcel Reutegger (JIRA) 


[ 
https://issues.apache.org/jira/browse/OAK-8111?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16786496#comment-16786496
 ] 

Marcel Reutegger commented on OAK-8111:
---

I like Vikas idea about creating the DocumentNodeStore in read-only mode by 
default and require a user to explicitly specify the read-write mode. This 
changes behaviour and basically means dryRun is ignored, but I think it may be 
worth it.

I would also make the --clusterId required. Just using an arbitrary available 
clusterId does not seem useful for the recovery command.

As for the question what clusterIds are available, I suggest we create a 
separate command that lists the clusterIds, their state and additional 
information like lease end, etc.

> Create read-only DocumentNodeStore for oak-run recovery dry run
> ---
>
> Key: OAK-8111
> URL: https://issues.apache.org/jira/browse/OAK-8111
> Project: Jackrabbit Oak
>  Issue Type: Improvement
>  Components: oak-run
>Reporter: Marcel Reutegger
>Assignee: Julian Reschke
>Priority: Minor
>  Labels: candidate_oak_1_10, candidate_oak_1_8
> Fix For: 1.12
>
> Attachments: OAK-8111.diff, OAK-8111.diff, OAK-8111.diff
>
>
> The oak-run recovery command always creates a read-write DocumentNodeStore 
> even when the dryRun flag is set. In dryRun mode, the command should create a 
> read-only DocumentNodeStore.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (OAK-8111) Create read-only DocumentNodeStore for oak-run recovery dry run

2019-03-06 Thread Julian Reschke (JIRA) 


[ 
https://issues.apache.org/jira/browse/OAK-8111?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16786377#comment-16786377
 ] 

Julian Reschke commented on OAK-8111:
-

Simplified patch that removes the generic change to NodeStoreOptions: 
https://issues.apache.org/jira/secure/attachment/12961496/OAK-8111.diff

[~catholicon], [~mreutegg] - feedback appreciated.

> Create read-only DocumentNodeStore for oak-run recovery dry run
> ---
>
> Key: OAK-8111
> URL: https://issues.apache.org/jira/browse/OAK-8111
> Project: Jackrabbit Oak
>  Issue Type: Improvement
>  Components: oak-run
>Reporter: Marcel Reutegger
>Assignee: Julian Reschke
>Priority: Minor
>  Labels: candidate_oak_1_10, candidate_oak_1_8
> Fix For: 1.12
>
> Attachments: OAK-8111.diff, OAK-8111.diff, OAK-8111.diff
>
>
> The oak-run recovery command always creates a read-write DocumentNodeStore 
> even when the dryRun flag is set. In dryRun mode, the command should create a 
> read-only DocumentNodeStore.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (OAK-8111) Create read-only DocumentNodeStore for oak-run recovery dry run

2019-03-06 Thread Julian Reschke (JIRA) 


[ 
https://issues.apache.org/jira/browse/OAK-8111?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16786155#comment-16786155
 ] 

Julian Reschke commented on OAK-8111:
-

The approach to modify the generic NodeStoreOptions may not be needed, given 
the fact that we actually get a Builder and would be able to modify it based on 
the dryRun flag.

I can simplify the change tomorrow to isolate the code change in the 
RecoveryCommand; and then we could discuss further changes separately.

> Create read-only DocumentNodeStore for oak-run recovery dry run
> ---
>
> Key: OAK-8111
> URL: https://issues.apache.org/jira/browse/OAK-8111
> Project: Jackrabbit Oak
>  Issue Type: Improvement
>  Components: oak-run
>Reporter: Marcel Reutegger
>Assignee: Julian Reschke
>Priority: Minor
>  Labels: candidate_oak_1_10, candidate_oak_1_8
> Fix For: 1.12
>
> Attachments: OAK-8111.diff, OAK-8111.diff
>
>
> The oak-run recovery command always creates a read-write DocumentNodeStore 
> even when the dryRun flag is set. In dryRun mode, the command should create a 
> read-only DocumentNodeStore.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (OAK-8111) Create read-only DocumentNodeStore for oak-run recovery dry run

2019-03-06 Thread Vikas Saurabh (JIRA) 


[ 
https://issues.apache.org/jira/browse/OAK-8111?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16786128#comment-16786128
 ] 

Vikas Saurabh commented on OAK-8111:


Talked to [~reschke] (jira doesn't seem to be working for me) and it seems I 
created some confusion as I was looking at the patch in context of this issue.

What I was arguing was that for this issue, readOnly/read-write should be 
"implied" like dryRun.
[~reschke] pointed me to the fact that I was trying to touch on arg parsing in 
the patch is common change to node store builder and hence isn't bound to this 
particular issue.

So, here's another go at a proposal:
* I feel that option parsing should default to read-only and go read-write only 
if defined explicitly. This would be a breaking change but if we log sufficient 
information about how to enable read-write mode (as we do for oak-run console) 
I think we should be ok. My reasoning to tend towards default read-only is that 
we won't accidentally write to a repo
* in context of this issue - I think dryRun should define whether node store is 
initialized as read-only as ead-write. Explicitly requiring another flag isn't 
useful in either case (dryRun should be read-only... non-dryRun needs to write 
anyway in almost all cases)

> Create read-only DocumentNodeStore for oak-run recovery dry run
> ---
>
> Key: OAK-8111
> URL: https://issues.apache.org/jira/browse/OAK-8111
> Project: Jackrabbit Oak
>  Issue Type: Improvement
>  Components: oak-run
>Reporter: Marcel Reutegger
>Assignee: Julian Reschke
>Priority: Minor
>  Labels: candidate_oak_1_10, candidate_oak_1_8
> Fix For: 1.12
>
> Attachments: OAK-8111.diff, OAK-8111.diff
>
>
> The oak-run recovery command always creates a read-write DocumentNodeStore 
> even when the dryRun flag is set. In dryRun mode, the command should create a 
> read-only DocumentNodeStore.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (OAK-8111) Create read-only DocumentNodeStore for oak-run recovery dry run

2019-03-06 Thread Vikas Saurabh (JIRA) 


[ 
https://issues.apache.org/jira/browse/OAK-8111?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16786100#comment-16786100
 ] 

Vikas Saurabh commented on OAK-8111:


[~reschke], I just meant that with the patch (and in context of dryRun)
* not giving {{--readOnly}} would default to read-only mode
* explicitly giving {{--readOnly}} arg also enables read-only mode

So, afaics, there's no way to enable read-write mode. So, we should either tie 
read-only to dryRun (I don't see much value in readOnly mode in non-dry-run 
mode) or we should probably have a read-write flag with recovery always going 
to readOnly in default case (with/out dry-run).

Btw, read-write flag would also align with already existing flag that is used 
for console command and hence would avoid some parameter bloat on part of 
oak-run.

All that said, I'd prefer no extra flags require and overload dryRun to deduce 
the read-only or read-write mode.

> Create read-only DocumentNodeStore for oak-run recovery dry run
> ---
>
> Key: OAK-8111
> URL: https://issues.apache.org/jira/browse/OAK-8111
> Project: Jackrabbit Oak
>  Issue Type: Improvement
>  Components: oak-run
>Reporter: Marcel Reutegger
>Assignee: Julian Reschke
>Priority: Minor
>  Labels: candidate_oak_1_10, candidate_oak_1_8
> Fix For: 1.12
>
> Attachments: OAK-8111.diff, OAK-8111.diff
>
>
> The oak-run recovery command always creates a read-write DocumentNodeStore 
> even when the dryRun flag is set. In dryRun mode, the command should create a 
> read-only DocumentNodeStore.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (OAK-8111) Create read-only DocumentNodeStore for oak-run recovery dry run

2019-03-06 Thread Julian Reschke (JIRA) 


[ 
https://issues.apache.org/jira/browse/OAK-8111?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16785850#comment-16785850
 ] 

Julian Reschke commented on OAK-8111:
-

[~catholicon] - not sure what the problem is that you see. Could you expand on 
that?

> Create read-only DocumentNodeStore for oak-run recovery dry run
> ---
>
> Key: OAK-8111
> URL: https://issues.apache.org/jira/browse/OAK-8111
> Project: Jackrabbit Oak
>  Issue Type: Improvement
>  Components: oak-run
>Reporter: Marcel Reutegger
>Assignee: Julian Reschke
>Priority: Minor
>  Labels: candidate_oak_1_10, candidate_oak_1_8
> Fix For: 1.12
>
> Attachments: OAK-8111.diff, OAK-8111.diff
>
>
> The oak-run recovery command always creates a read-write DocumentNodeStore 
> even when the dryRun flag is set. In dryRun mode, the command should create a 
> read-only DocumentNodeStore.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (OAK-8111) Create read-only DocumentNodeStore for oak-run recovery dry run

2019-03-06 Thread Julian Reschke (JIRA) 


[ 
https://issues.apache.org/jira/browse/OAK-8111?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16785848#comment-16785848
 ] 

Julian Reschke commented on OAK-8111:
-

Revised patch: 
https://issues.apache.org/jira/secure/attachment/12961419/OAK-8111.diff

Note that when in read only mode the {{DocumentNodeStore}} will return a 
clusterId of zero, so in that case the user will need to explicitly specify one 
using {{--clusterId}}.

I tried to help with that, example output:

{noformat}
Apache Jackrabbit Oak 1.12-SNAPSHOT
(dryRun specified, defaulting to --readOnly)
DocumentNodeStore is in read-only mode, use --clusterId to select a non-null 
clusterId...
Existing entries in the clusternodes collection:
1: {instance=C:\projects\apache\oak\trunk\oak-run, 
lastWrittenRootRev=r16953d11461-0-1, machine=mac:1803733fd6b0, 
_collisionsModCount=0, startTime=1551889404902, _id=1, state=null, 
leaseEnd=null, _modified=0, _modCount=22, oakVersion=1.12-SNAPSHOT, info=id: 1, 
startTime: 1551889404902, machineId: mac:1803733fd6b0, instanceId: 
C:\projects\apache\oak\trunk\oak-run, pid: 19192, uuid: 
7a457479-25cd-4b00-86ec-2baebefc6724, readWriteMode: null, leaseCheckMode: 
STRICT, state: ACTIVE, oakVersion: 1.12-SNAPSHOT, formatVersion: 1.8.0}

{noformat}

> Create read-only DocumentNodeStore for oak-run recovery dry run
> ---
>
> Key: OAK-8111
> URL: https://issues.apache.org/jira/browse/OAK-8111
> Project: Jackrabbit Oak
>  Issue Type: Improvement
>  Components: oak-run
>Reporter: Marcel Reutegger
>Assignee: Julian Reschke
>Priority: Minor
>  Labels: candidate_oak_1_10, candidate_oak_1_8
> Fix For: 1.12
>
> Attachments: OAK-8111.diff, OAK-8111.diff
>
>
> The oak-run recovery command always creates a read-write DocumentNodeStore 
> even when the dryRun flag is set. In dryRun mode, the command should create a 
> read-only DocumentNodeStore.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (OAK-8111) Create read-only DocumentNodeStore for oak-run recovery dry run

2019-03-06 Thread Vikas Saurabh (JIRA) 


[ 
https://issues.apache.org/jira/browse/OAK-8111?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16785765#comment-16785765
 ] 

Vikas Saurabh commented on OAK-8111:


I think that should be read write spec, right? As the patch currently stands, 
recovery can only run in read only mode.

> Create read-only DocumentNodeStore for oak-run recovery dry run
> ---
>
> Key: OAK-8111
> URL: https://issues.apache.org/jira/browse/OAK-8111
> Project: Jackrabbit Oak
>  Issue Type: Improvement
>  Components: oak-run
>Reporter: Marcel Reutegger
>Assignee: Julian Reschke
>Priority: Minor
>  Labels: candidate_oak_1_10, candidate_oak_1_8
> Fix For: 1.12
>
> Attachments: OAK-8111.diff
>
>
> The oak-run recovery command always creates a read-write DocumentNodeStore 
> even when the dryRun flag is set. In dryRun mode, the command should create a 
> read-only DocumentNodeStore.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (OAK-8111) Create read-only DocumentNodeStore for oak-run recovery dry run

2019-03-06 Thread Julian Reschke (JIRA) 


[ 
https://issues.apache.org/jira/browse/OAK-8111?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16785728#comment-16785728
 ] 

Julian Reschke commented on OAK-8111:
-

Proposed patch: 
https://issues.apache.org/jira/secure/attachment/12961412/OAK-8111.diff

> Create read-only DocumentNodeStore for oak-run recovery dry run
> ---
>
> Key: OAK-8111
> URL: https://issues.apache.org/jira/browse/OAK-8111
> Project: Jackrabbit Oak
>  Issue Type: Improvement
>  Components: oak-run
>Reporter: Marcel Reutegger
>Assignee: Julian Reschke
>Priority: Minor
> Fix For: 1.12
>
> Attachments: OAK-8111.diff
>
>
> The oak-run recovery command always creates a read-write DocumentNodeStore 
> even when the dryRun flag is set. In dryRun mode, the command should create a 
> read-only DocumentNodeStore.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (OAK-8111) Create read-only DocumentNodeStore for oak-run recovery dry run

2019-03-06 Thread Julian Reschke (JIRA) 


[ 
https://issues.apache.org/jira/browse/OAK-8111?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16785634#comment-16785634
 ] 

Julian Reschke commented on OAK-8111:
-

Proposal: add readOnly spec to {{Utils.NodeStoreOptions}}.

> Create read-only DocumentNodeStore for oak-run recovery dry run
> ---
>
> Key: OAK-8111
> URL: https://issues.apache.org/jira/browse/OAK-8111
> Project: Jackrabbit Oak
>  Issue Type: Improvement
>  Components: oak-run
>Reporter: Marcel Reutegger
>Assignee: Julian Reschke
>Priority: Minor
> Fix For: 1.12
>
>
> The oak-run recovery command always creates a read-write DocumentNodeStore 
> even when the dryRun flag is set. In dryRun mode, the command should create a 
> read-only DocumentNodeStore.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)