Re: [RFC]: libiscsi patch to support cxgb3i on older RHEL-5/SLES-10
Mike Christie wrote: A signature is not going to help you understand that patch will it? :) I do not think a changelog will help either since it is the first version of a RFC patch. Mike, signature is needed and helpful, I assume you sign all the patches you send to James, isn't it... change log is always needed and helpful, specifically, when you send someone an RFC, anyway, to your question From the subject of the mail and the body it looks like Rakesh is trying to port libiscsi to older distro kernels (RHEL 5 and SLES 10 based) so he can support cxgb3i on them. I am just asking you guys if you also need RHEL 4 and SLES 9 support. I am not aware to special need to support rh4 and sles9 Or. --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups open-iscsi group. To post to this group, send email to open-iscsi@googlegroups.com To unsubscribe from this group, send email to open-iscsi+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/open-iscsi -~--~~~~--~~--~--~---
[PATCH] Fix compilation warnings in usr/kernel code
Fix compilation warnings and modify the Makefiles to treat
warnings as errors.
Signed-off-by: Erez Zilber erezzi.l...@gmail.com
--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups
open-iscsi group.
To post to this group, send email to open-iscsi@googlegroups.com
To unsubscribe from this group, send email to
open-iscsi+unsubscr...@googlegroups.com
For more options, visit this group at http://groups.google.com/group/open-iscsi
-~--~~~~--~~--~--~---
From 6c97d8d941fa9caaae42f01d686465d8b49f Mon Sep 17 00:00:00 2001
From: Erez Zilber erezzi.l...@gmail.com
Date: Thu, 3 Sep 2009 14:12:27 +0300
Subject: [PATCH] Fix compilation warnings in usr/kernel code
Fix compilation warnings and modify the Makefiles to treat
warnings as errors.
Signed-off-by: Erez Zilber erezzi.l...@gmail.com
---
kernel/2.6.14-23_compat.patch| 106 ++
kernel/Makefile |2 +-
kernel/libiscsi.c|3 +-
usr/Makefile |2 +-
usr/auth.c | 34 +---
usr/iface.c | 38 --
usr/iscsid.c | 22 +++-
usr/log.c| 34
usr/mgmt_ipc.c |9 +++-
usr/strings.c|2 +-
usr/util.c | 26 --
utils/Makefile |2 +-
utils/fwparam_ibft/fwparam_ppc.c |7 ++-
utils/sysdeps/Makefile |2 +-
14 files changed, 157 insertions(+), 132 deletions(-)
diff --git a/kernel/2.6.14-23_compat.patch b/kernel/2.6.14-23_compat.patch
index ab233bb..4b02d2e 100644
--- a/kernel/2.6.14-23_compat.patch
+++ b/kernel/2.6.14-23_compat.patch
@@ -1,8 +1,8 @@
diff --git a/iscsi_tcp.c b/iscsi_tcp.c
-index caa116c..71df5b9 100644
+index bce1594..c46888d 100644
--- a/iscsi_tcp.c
+++ b/iscsi_tcp.c
-@@ -456,11 +456,9 @@ static int iscsi_sw_tcp_pdu_init(struct iscsi_task *task,
+@@ -460,11 +460,9 @@ static int iscsi_sw_tcp_pdu_init(struct iscsi_task *task,
if (!task-sc)
iscsi_sw_tcp_send_linear_data_prep(conn, task-data, count);
else {
@@ -17,7 +17,7 @@ index caa116c..71df5b9 100644
}
if (err) {
-@@ -793,7 +791,11 @@ iscsi_sw_tcp_session_create(struct iscsi_endpoint *ep, uint16_t cmds_max,
+@@ -797,7 +795,11 @@ iscsi_sw_tcp_session_create(struct iscsi_endpoint *ep, uint16_t cmds_max,
shost-max_lun = iscsi_max_lun;
shost-max_id = 0;
shost-max_channel = 0;
@@ -29,7 +29,7 @@ index caa116c..71df5b9 100644
if (iscsi_host_add(shost, NULL))
goto free_host;
-@@ -832,12 +834,6 @@ static void iscsi_sw_tcp_session_destroy(struct iscsi_cls_session *cls_session)
+@@ -836,12 +838,6 @@ static void iscsi_sw_tcp_session_destroy(struct iscsi_cls_session *cls_session)
iscsi_host_free(shost);
}
@@ -42,7 +42,7 @@ index caa116c..71df5b9 100644
static int iscsi_sw_tcp_slave_configure(struct scsi_device *sdev)
{
blk_queue_bounce_limit(sdev-request_queue, BLK_BOUNCE_ANY);
-@@ -846,6 +842,9 @@ static int iscsi_sw_tcp_slave_configure(struct scsi_device *sdev)
+@@ -850,6 +846,9 @@ static int iscsi_sw_tcp_slave_configure(struct scsi_device *sdev)
}
static struct scsi_host_template iscsi_sw_tcp_sht = {
@@ -52,7 +52,7 @@ index caa116c..71df5b9 100644
.module = THIS_MODULE,
.name = iSCSI Initiator over TCP/IP,
.queuecommand = iscsi_queuecommand,
-@@ -856,9 +855,8 @@ static struct scsi_host_template iscsi_sw_tcp_sht = {
+@@ -860,9 +859,8 @@ static struct scsi_host_template iscsi_sw_tcp_sht = {
.cmd_per_lun = ISCSI_DEF_CMD_PER_LUN,
.eh_abort_handler = iscsi_eh_abort,
.eh_device_reset_handler= iscsi_eh_device_reset,
@@ -77,7 +77,7 @@ index f9a4044..ab20530 100644
#include libiscsi_tcp.h
diff --git a/libiscsi.c b/libiscsi.c
-index fe4b66e..6217f76 100644
+index 223a5b8..161c971 100644
--- a/libiscsi.c
+++ b/libiscsi.c
@@ -24,7 +24,10 @@
@@ -91,7 +91,7 @@ index fe4b66e..6217f76 100644
#include asm/unaligned.h
#include net/tcp.h
#include scsi/scsi_cmnd.h
-@@ -60,6 +63,8 @@ MODULE_PARM_DESC(debug_libiscsi, Turn on debugging for libiscsi module.
+@@ -83,6 +86,8 @@ MODULE_PARM_DESC(debug_libiscsi_eh,
__func__, ##arg); \
} while (0);
@@ -100,7 +100,7 @@ index fe4b66e..6217f76 100644
/* Serial Number Arithmetic, 32 bits, less than, RFC1982 */
#define SNA32_CHECK 2147483648UL
-@@ -229,7 +234,7 @@ static int iscsi_prep_bidi_ahs(struct iscsi_task *task)
+@@ -252,7 +257,7 @@ static int iscsi_prep_bidi_ahs(struct iscsi_task *task)
sizeof(rlen_ahdr-reserved));
rlen_ahdr-ahstype = ISCSI_AHSTYPE_RLENGTH;
rlen_ahdr-reserved = 0;
@@ -109,7 +109,7 @@ index fe4b66e..6217f76 100644
ISCSI_DBG_SESSION(task-conn-session,
bidi-in rlen_ahdr-read_length(%d)
-@@ -300,7 +305,7 @@ static int iscsi_prep_scsi_cmd_pdu(struct iscsi_task
Re: [PATCH] Fix compilation warnings in usr/kernel code
On Thu, Sep 3, 2009 at 7:21 PM, Erez Zilbererezzi.l...@gmail.com wrote: Fix compilation warnings and modify the Makefiles to treat warnings as errors. Signed-off-by: Erez Zilber erezzi.l...@gmail.com 2 comments about this patch: 1. I'm not familiar enough with the fwparam_ibft code, so I didn't add the -Werror flag to the Makefile. There are still compilation warnings in that code. 2. I was able to test it on CentOS 5.3 kubuntu 9.04 only. If anyone can test it on other kernels and submit fixes, it would be great. Erez --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups open-iscsi group. To post to this group, send email to open-iscsi@googlegroups.com To unsubscribe from this group, send email to open-iscsi+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/open-iscsi -~--~~~~--~~--~--~---
Re: [RFC]: libiscsi patch to support cxgb3i on older RHEL-5/SLES-10
On 09/03/2009 07:58 AM, Or Gerlitz wrote: Mike Christie wrote: A signature is not going to help you understand that patch will it? :) I do not think a changelog will help either since it is the first version of a RFC patch. Mike, signature is needed and helpful, I assume you sign all the patches For sig do you mean the Sign-off line? I do not require sigs for userspace or open-iscsi.org patches. Check out the git logs and you will see some patches have them but most do not. If you mean sig as in a patch description then there was one. you send to James, isn't it... change log is always needed and helpful, I was just saying the change log at that point would only say - v1 sent initial patch. And I do not think that tells you anything. specifically, when you send someone an RFC, anyway, to your question From the subject of the mail and the body it looks like Rakesh is trying to port libiscsi to older distro kernels (RHEL 5 and SLES 10 based) so he can support cxgb3i on them. I am just asking you guys if you also need RHEL 4 and SLES 9 support. I am not aware to special need to support rh4 and sles9 Or. --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups open-iscsi group. To post to this group, send email to open-iscsi@googlegroups.com To unsubscribe from this group, send email to open-iscsi+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/open-iscsi -~--~~~~--~~--~--~---
Re: [PATCH] Fix compilation warnings in usr/kernel code
On 09/03/2009 11:21 AM, Erez Zilber wrote: Fix compilation warnings and modify the Makefiles to treat warnings as errors. Signed-off-by: Erez Zilber erezzi.l...@gmail.com Thanks. I get this compilation error on fedora 10. We used to get a warning about it not being initialized and upstream we did this patch. Is this just a bug in my compiler? @@ -693,6 +692,7 @@ int iscsi_add_session(struct iscsi_cls_session *session, unsigned int target_id) Too many iscsi targets. Max number of targets is %d.\n, ISCSI_MAX_TARGET - 1); + err = -EOVERFLOW; goto release_host; } } make make -C /lib/modules/2.6.29.4-167.fc11.x86_64/build M=`pwd` KBUILD_OUTPUT= V=0 modules make[1]: Entering directory `/usr/src/kernels/2.6.29.4-167.fc11.x86_64' CC [M] /home/mnc/kernel/iscsi/open-iscsi/devel/open-iscsi/kernel/scsi_transport_iscsi.o cc1: warnings being treated as errors /home/mnc/kernel/iscsi/open-iscsi/devel/open-iscsi/kernel/scsi_transport_iscsi.c: In function ‘iscsi_add_session’: /home/mnc/kernel/iscsi/open-iscsi/devel/open-iscsi/kernel/scsi_transport_iscsi.c:678: error: ‘err’ may be used uninitialized in this function make[2]: *** [/home/mnc/kernel/iscsi/open-iscsi/devel/open-iscsi/kernel/scsi_transport_iscsi.o] Error 1 make[1]: *** [_module_/home/mnc/kernel/iscsi/open-iscsi/devel/open-iscsi/kernel] Error 2 make[1]: Leaving directory `/usr/src/kernels/2.6.29.4-167.fc11.x86_64' --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups open-iscsi group. To post to this group, send email to open-iscsi@googlegroups.com To unsubscribe from this group, send email to open-iscsi+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/open-iscsi -~--~~~~--~~--~--~---
Re: [PATCH] start iscsid when needed
On 02/07/2009 12:32 AM, Mike Christie wrote: This patch is from Fedora. The problem is that some distros are starting iscsid in anticipation that iscsi might be needed, and it turns out it might never be :( So this patch has the iscsi tools start iscsid only when they first need it for login/discovery. The original patch had some Fedora start command hardcoded. I modified that patch so in the attached, you set the startup command in /etc/iscsi/iscsid.conf. For upstream I just have it start iscsid. When I merge the patch I will modify it to run some command in the init script so that everything gets set up right (subsys locks get touched, and modules are loaded). Merged in commit dd61cb863559297b89b5b41f7320760372883b1c for the next release. Thanks Hans. Sorry for the long wait. Working on libiscsi. --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups open-iscsi group. To post to this group, send email to open-iscsi@googlegroups.com To unsubscribe from this group, send email to open-iscsi+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/open-iscsi -~--~~~~--~~--~--~---
