[Bug 1396790] Review Request: gnome-shell-extension-freon - GNOME Shell extension to display system temperature , voltage, and fan speed

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1396790

Fabian Affolter  changed:

   What|Removed |Added

 CC||m...@fabian-affolter.ch



--- Comment #1 from Fabian Affolter  ---
$ wget
https://gitlab.com/terrycloth/packaging-gnome-shell-extension-freon/raw/master/gnome-shell-extension-freon.spec
--2016-11-21 08:01:50-- 
https://gitlab.com/terrycloth/packaging-gnome-shell-extension-freon/raw/master/gnome-shell-extension-freon.spec
Resolving gitlab.com (gitlab.com)... 104.210.2.228
Connecting to gitlab.com (gitlab.com)|104.210.2.228|:443... connected.
HTTP request sent, awaiting response... 404 Not Found
2016-11-21 08:01:51 ERROR 404: Not Found.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1396139] Review Request: libmad - MPEG audio decoder library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1396139



--- Comment #7 from Neal Gompa  ---
fedora-review went mostly okay, there were a few points, though:

* COPYRIGHT needs to be under %license, not %doc

* Can you please put a comment explaining the arch-specific patch?
libmad.src: W: %ifarch-applied-patch Patch0: libmad-0.15.1b-multiarch.patch

* Sources are missing from the libmad-debuginfo subpackage. This needs to be
fixed.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1365319] Review Request: EPEL vcftools - newest version 0.1.14

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1365319

Fedora Update System  changed:

   What|Removed |Added

   Fixed In Version|vcftools-0.1.14-1.fc25  |vcftools-0.1.14-1.fc25
   |vcftools-0.1.14-1.fc23  |vcftools-0.1.14-1.fc23
   ||vcftools-0.1.14-1.fc24



--- Comment #11 from Fedora Update System  ---
vcftools-0.1.14-1.fc24 has been pushed to the Fedora 24 stable repository. If
problems still persist, please make note of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1009654] Review Request: tempus-fugit - Java classes for temporal testing and concurrency

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1009654



--- Comment #21 from Fedora Update System  ---
tempus-fugit-1.2-0.1.SNAPSHOT.fc24 has been pushed to the Fedora 24 stable
repository. If problems still persist, please make note of it in this bug
report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1386938] Review Request: libprelude - Prelude Library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1386938



--- Comment #12 from Zbigniew Jędrzejewski-Szmek  ---
# Force default attrs because libprelude force others
%defattr(- , root, root, 755)
→ I think you don't need this anymore.

%{python3_sitearch}/_prelude.*so
%{python3_sitearch}/prelude.py
→ Not a packaging issue, but still something to reconsider upstream. I think
putting a private module at the top level is rather ugly. Imaging the mess if
everybody did that ;). Why not structure this as
%{python3_sitearch}/prelude/__init__.py
%{python3_sitearch}/prelude/_prelude.*so
? (Please note that I'm just complaining here, this review is not contingent on
this in any way.)

BR: perl-generators is needed according to
http://fedoraproject.org/wiki/Packaging:Perl#Build_Dependencies,
and also R: perl(:MODULE_COMPAT), see
http://fedoraproject.org/wiki/Packaging:Perl#Versioned_MODULE_COMPAT_Requires.

- Provides: bundled(gnulib) in place as required.
  Note: Bundled gnulib but no Provides: bundled(gnulib)
  See:
 
http://fedoraproject.org/wiki/Packaging:No_Bundled_Libraries#Requirement_if_you_bundle

- Note: License file LICENSE.README is not marked as %license
Yeah, it seems reasonable to include that in %license too.
Same goes for HACKING.README.

- Large documentation must go in a -doc subpackage. Large could be size
  (~1MB) or number of files.
  Note: Documentation size is 5703680 bytes in 53 files.
  See:
  http://fedoraproject.org/wiki/Packaging/Guidelines#PackageDocumentation

I'm not sure how exactly fedora-review arrives at this number, but it seems
that there's indeed a few MBs of documentation. You might want to split out
libprelude-doc subpackage with /usr/share/doc/libprelude-devel/libprelude.
(Also not that there's an extra level of directories nesting here that looks
accidental.)

rpmlint also says:
libprelude-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/libprelude-3.1.0/src/libprelude-error/code-to-errno.h
libprelude-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/libprelude-3.1.0/src/libprelude-error/err-sources.h
libprelude-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/libprelude-3.1.0/src/libprelude-error/strsource.c
libprelude-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/libprelude-3.1.0/src/libprelude-error/code-from-errno.h
libprelude-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/libprelude-3.1.0/src/libprelude-error/err-codes.h
libprelude-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/libprelude-3.1.0/src/libprelude-error/strerror.c
It's not a big issue, but probably to fix upstream at some point.

libprelude.x86_64: W: crypto-policy-non-compliance-gnutls-2
/usr/lib64/libprelude.so.23.3.0 gnutls_priority_init
prelude-tools.x86_64: W: crypto-policy-non-compliance-gnutls-1
/usr/bin/prelude-admin gnutls_priority_set_direct

This one is a bigger problem. It's been a while since I looked at the details,
but basically you need to call gnutls_set_default_priority or 
gnutls_priority_set_direct("@SYSTEM")
[https://fedoraproject.org/wiki/Packaging:CryptoPolicies]. If this policy does
not apply to this package for some reason, please explain in a comment in the
spec file. Looking at ./prelude-admin/server.c, it should be easy enough to
patch.

libprelude.x86_64: W: unused-direct-shlib-dependency
/usr/lib64/libprelude.so.23.3.0 /lib64/libdl.so.2
libprelude.x86_64: W: unused-direct-shlib-dependency
/usr/lib64/libprelude.so.23.3.0 /lib64/libgpg-error.so.0
libprelude.x86_64: W: unused-direct-shlib-dependency
/usr/lib64/libpreludecpp.so.8.1.0 /lib64/libgnutls.so.30
libprelude.x86_64: W: unused-direct-shlib-dependency
/usr/lib64/libpreludecpp.so.8.1.0 /lib64/libgcrypt.so.20
libprelude.x86_64: W: unused-direct-shlib-dependency
/usr/lib64/libpreludecpp.so.8.1.0 /lib64/libdl.so.2
libprelude.x86_64: W: unused-direct-shlib-dependency
/usr/lib64/libpreludecpp.so.8.1.0 /lib64/libgpg-error.so.0
libprelude.x86_64: W: unused-direct-shlib-dependency
/usr/lib64/libpreludecpp.so.8.1.0 /lib64/libltdl.so.7
libprelude.x86_64: W: unused-direct-shlib-dependency
/usr/lib64/libpreludecpp.so.8.1.0 /lib64/libm.so.6

Overlinking? Not a big issue, because those libraries are going to be installed
anyway, but removing it might reduce memory usage and startup time but some
minuscule amount.

And one more suggestion for upstream reconsideration:
custom autoconf macros are horrible. The problem is that any project that wants
to use them, must either bundle them (which is annoying if you have more than
two or three dependencies), or wrap the calls to those macros in ugly and
brittle m4 macros for the case when the dependency is not installed. Please
consider providing a pkgconfig file, which is easier to write, easier to use,
and as a bonus, works with other build systems like meson. (Please note that
I'm just complaining here, this review is not contingent on this in any way.)

-- 
You are receiving this mail because:
You are on the CC list for 

[Bug 1387447] Review Request: php-sentry - PHP client for Sentry

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1387447



--- Comment #25 from Fedora Update System  ---
php-sentry-0.22.0-1.el7 has been pushed to the Fedora EPEL 7 stable repository.
If problems still persist, please make note of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1350257] Review Request: petsc - Portable Extensible Toolkit for Scientific Computation

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1350257
Bug 1350257 depends on bug 1382916, which changed state.

Bug 1382916 Summary: 64-bit interface version of openblas is not using 64-bit 
integers
https://bugzilla.redhat.com/show_bug.cgi?id=1382916

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1396513] Review Request: nitrokey-app - Nitrokey's Application

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1396513



--- Comment #6 from Fedora Update System  ---
nitrokey-app-0.5.1-1.fc25 has been submitted as an update to Fedora 25.
https://bodhi.fedoraproject.org/updates/FEDORA-2016-e29a5887ae

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1396513] Review Request: nitrokey-app - Nitrokey's Application

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1396513

Fedora Update System  changed:

   What|Removed |Added

 Status|POST|MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1396513] Review Request: nitrokey-app - Nitrokey's Application

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1396513



--- Comment #5 from Fedora Update System  ---
nitrokey-app-0.5.1-1.fc24 has been submitted as an update to Fedora 24.
https://bodhi.fedoraproject.org/updates/FEDORA-2016-94dfc033bb

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1396847] Review Request: screencloud - Easy to use screenshot sharing application

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1396847

Igor Gnatenko  changed:

   What|Removed |Added

  Alias||screencloud



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1396847] Review Request: screencloud - Easy to use screenshot sharing application

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1396847

Igor Gnatenko  changed:

   What|Removed |Added

 Depends On||1396846, 1394149




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1394149
[Bug 1394149] pythonqt: Switch to Python 3
https://bugzilla.redhat.com/show_bug.cgi?id=1396846
[Bug 1396846] [PATCH] Update to 3.1; Switch to Qt5; Switch to Python3
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1396847] New: Review Request: screencloud - Easy to use screenshot sharing application

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1396847

Bug ID: 1396847
   Summary: Review Request: screencloud - Easy to use screenshot
sharing application
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: ignate...@redhat.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL: https://ignatenkobrain.fedorapeople.org/for-review/screencloud.spec
SRPM URL:
https://ignatenkobrain.fedorapeople.org/for-review/screencloud-1.3.1-1.fc26.src.rpm
Description:
Easy to use screenshot sharing application.

Take a screenshot using one of the 3 hotkeys or simply click the
ScreenCloud tray icon. You can choose where you want to save your screenshot.

If you choose to upload your screenshot to the screencloud website, a link
will automatically be copied to your clipboard. You can share this link with
your friends or colleagues via email or in an IM conversation.
All they have to do is click the link and look at your screenshot.

ScreenCloud also offers FTP and SFTP uploading if you want to use
your own server.
Fedora Account System Username: ignatenkobrain

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1392950] Review Request: qclib - Provides a C API for extraction of system information for Linux on z Systems

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1392950

Thomas Andrejak  changed:

   What|Removed |Added

 CC||thomas.andre...@gmail.com



--- Comment #1 from Thomas Andrejak  ---
Hello

I'm not a packager yet, hence the review is unofficial. Also, I do not have
s390 or s390x so I can't build it but I have some comments.

- Summary:
I propose to remove "Provides a "

- Source0:
At the end, you should use %{name}-%{version}.tgz

- Patch0:
Also, use %{version}

- In %package, do not specify the group

- In %package, I think you have to add the %{?_isa} to requires

- %package static
Provides:foo-static = %{version}-%{release} <== Typo for "foo" ?

- %prep
I think you can use %autosetup

- %files doc
Is there a reason you are using a different license file than "%files"

Regards

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1346407] Review Request: stress-ng - Stress test a computer system in various ways

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1346407

Igor Gnatenko  changed:

   What|Removed |Added

  Flags|needinfo?(ignatenko@redhat. |
   |com)|



--- Comment #13 from Igor Gnatenko  ---
btw, license is GPLv2+, not GPLv2

I didn't check exact build, but otherwise looks good.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1389971] Review Request: Elemental - distributed-memory dense and sparse-direct linear algebra and optimizatio

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1389971



--- Comment #18 from Ryan H. Lewis (rhl)  ---
The current spec file:
https://raw.githubusercontent.com/elemental/Elemental/master/redhat/elemental.spec

builds green:
https://copr-be.cloud.fedoraproject.org/results/rhl/elemental/fedora-24-x86_64/00479039-elemental/

the copr page for all the other environments is here:
https://copr.fedorainfracloud.org/coprs/rhl/elemental/build/479039/

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1323214] Review Request: git-evtag - Strong GPG verification of git tags

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1323214



--- Comment #11 from Fedora Update System  ---
git-evtag-2016.1-1.fc24 has been submitted as an update to Fedora 24.
https://bodhi.fedoraproject.org/updates/FEDORA-2016-66b8607f19

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1323214] Review Request: git-evtag - Strong GPG verification of git tags

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1323214

Fedora Update System  changed:

   What|Removed |Added

 Status|POST|MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1323214] Review Request: git-evtag - Strong GPG verification of git tags

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1323214



--- Comment #10 from Fedora Update System  ---
git-evtag-2016.1-1.fc25 has been submitted as an update to Fedora 25.
https://bodhi.fedoraproject.org/updates/FEDORA-2016-38e351d6f2

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1187084] Review Request: electrum - a lightweight Bitcoin client

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1187084

Jonny Heggheim  changed:

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 Resolution|--- |NEXTRELEASE
Last Closed||2016-11-20 15:00:44



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1187084] Review Request: electrum - a lightweight Bitcoin client

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1187084



--- Comment #33 from Jonny Heggheim  ---
(In reply to Samuel Gyger from comment #32)
> Thank you for taking over and making this happen so fast. Appreciate this.

You're welcome!


It would be great if more users could test the build on Fedora 25:
> sudo dnf install electrum --enablerepo=updates-testing

And provided feedback on bodhi:
https://bodhi.fedoraproject.org/updates/FEDORA-2016-e5dbc775ab

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1389016] Review Request: libxsmm - Library for small matrix-matrix multiplications on Intel x86_64 (e.g. for cp2k)

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1389016



--- Comment #36 from Fedora Update System  ---
libxsmm-1.5.2-2.fc24 has been pushed to the Fedora 24 testing repository. If
problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2016-e9e3962e27

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1374899] Review Request: quassel-irssi - An irssi plugin to connect to quassel core

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1374899



--- Comment #2 from Ben Rosser  ---
Updated package; the patch above was merged and quasselc has been accepted into
the repositories, so I've polished and cleaned this one up based on the review
of quasselc.

Spec URL:
https://tc01.fedorapeople.org/quassel/quassel-irssi/quassel-irssi.spec
SRPM URL:
https://tc01.fedorapeople.org/quassel/quassel-irssi/quassel-irssi-0-1.20161120gitcbd9bd7.fc24.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1374898] Review Request: quasselc - API to access a Quassel Core in pure C

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1374898



--- Comment #12 from Fedora Update System  ---
quasselc-0-1.20160909gitfcd9669.el7 has been submitted as an update to Fedora
EPEL 7. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-944a599e8f

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1374898] Review Request: quasselc - API to access a Quassel Core in pure C

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1374898



--- Comment #11 from Fedora Update System  ---
quasselc-0-1.20160909gitfcd9669.fc24 has been submitted as an update to Fedora
24. https://bodhi.fedoraproject.org/updates/FEDORA-2016-52876b00d4

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1374898] Review Request: quasselc - API to access a Quassel Core in pure C

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1374898



--- Comment #10 from Fedora Update System  ---
quasselc-0-1.20160909gitfcd9669.fc25 has been submitted as an update to Fedora
25. https://bodhi.fedoraproject.org/updates/FEDORA-2016-e77aa3e943

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1374898] Review Request: quasselc - API to access a Quassel Core in pure C

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1374898

Fedora Update System  changed:

   What|Removed |Added

 Status|POST|MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1365319] Review Request: EPEL vcftools - newest version 0.1.14

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1365319

Fedora Update System  changed:

   What|Removed |Added

   Fixed In Version|vcftools-0.1.14-1.fc25  |vcftools-0.1.14-1.fc25
   ||vcftools-0.1.14-1.fc23



--- Comment #10 from Fedora Update System  ---
vcftools-0.1.14-1.fc23 has been pushed to the Fedora 23 stable repository. If
problems still persist, please make note of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1396819] Review Request: libkcapi - User space interface to the Linux Kernel Crypto API

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1396819



--- Comment #9 from Zbigniew Jędrzejewski-Szmek  ---
(In reply to Thomas Andrejak from comment #8)
> For %doc and manpages, in
> https://fedoraproject.org/wiki/Packaging:Guidelines#Manpages the example do
> not put the %doc macro. That's why I said it. The wiki is wrong ?

There's no clear-cut guideline. In the example it's a page in section 1, so it
makes some sense to install it even with --nodoc. It is also quite likely that
%doc was simply forgotten. It's hard to say. Also note that the example is just
that, it's the text that is authoritative.

> > - %build
> > Why are you forcing cflags instead of making patchs ?
> 
> Hm, I don't understand. Why should I make patches?
> => I don't think that overwriting CFLAGS is a good thing because the
> environment can set it. (I may think wrong). For example for hardening. So I
> try to never do this and prefer patch makefile or other file to do what I
> need to do.

To patch, to sed, or to set variables, is just a mechanism. Most things can be
achieved with any of them, it's just a question which is the most convenient.
In this case, I'd say, settings CLFAGS *is* that.

Note that the hardening flags are used (via %optflags). This should always be
verified by looking at the build log:

gcc -fPIC -std=gnu99 -O2 -g -pipe -Wall -Werror=format-security
-Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector-strong
--param=ssp-buffer-size=4 -grecord-gcc-switches
-specs=/usr/lib/rpm/redhat/redhat-hardened-cc1 -m64 -fwrapv -fvisibility=hidden
  -c -o kdf.o kdf.c

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1386938] Review Request: libprelude - Prelude Library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1386938



--- Comment #11 from Thomas Andrejak  ---
Here is the new version

SRPM :
https://copr-be.cloud.fedoraproject.org/results/totol/Prelude/fedora-rawhide-x86_64/00479026-libprelude/libprelude-3.1.0-24.fc26.src.rpm
SPEC : https://www.prelude-siem.org/pkg/src/3.1.0/libprelude.spec

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1391334] Review Request: freeorion - Turn-based space empire and galactic conquest (4X) computer game

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1391334



--- Comment #4 from Link Dupont  ---
Updated Spec and SRPM:

Spec URL:
https://fedorapeople.org/cgit/linkdupont/public_git/freeorion.git/plain/freeorion.spec
SRPM URL:
https://fedorapeople.org/~linkdupont/srpms/freeorion-0.4.6-3.fc26.src.rpm

I have a koji scratch build pending:
http://koji.fedoraproject.org/koji/taskinfo?taskID=16546329

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1391334] Review Request: freeorion - Turn-based space empire and galactic conquest (4X) computer game

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1391334



--- Comment #3 from Antonio Trande  ---
(In reply to Link Dupont from comment #2)
> Thank you for the review! This raised a couple questions when I was
> examining the issues.
> 
> 1) FreeOrion appears to bundle libGiGi
> FreeOrion bundles libGiGi. There is an external libGiGi project, but during
> my research, I found that Debian supports bundling libGiGi with their
> freeorion package. This excerpt from their README.source file:
> 
> Bundled GG (libgigi) library:
>  At the moment GG is not feasible to maintain separately:
>   * It is used exclusively by freeorion.
>   * FreeOrion maintains a fork of GG in FreeOrion's source tree.
>   * FreeOrion's GG fork is better maintained and needs less patches.
> * For example the original libgigi library doesn't build with gcc-4.7
>   (requires gcc-4.6) while from FreeOrion's source tree
>   it builds fine with gcc-4.7 and doesn't need the "vector.patch".
>   * GG is not a proper library (more like a plugin) and therefore
> not suitable for packaging as a standalone libgigi(-dev) package.
> 
> Would I need to submit a bundle library exception to the FPC for this?

No; libGiGi is not officially packed on Fedora, it's simply a library provided
by freeorion.

> 
> 2) FSF address incorrect
> 
> I noticed a rpmlint warning about an incorrect FSF address. When I looked at
> the COPYING file shipped by upstream, it does have the correct address. The
> only difference was a comma (,) inserted between the ZIP code and the
> country. I feel like ignoring this lint error is okay, since the address is
> correct, just formatted funny.

Don't modify the FSF address youself, but point out these lacks to upstream.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1391334] Review Request: freeorion - Turn-based space empire and galactic conquest (4X) computer game

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1391334



--- Comment #2 from Link Dupont  ---
Thank you for the review! This raised a couple questions when I was examining
the issues.

1) FreeOrion appears to bundle libGiGi
FreeOrion bundles libGiGi. There is an external libGiGi project, but during my
research, I found that Debian supports bundling libGiGi with their freeorion
package. This excerpt from their README.source file:

Bundled GG (libgigi) library:
 At the moment GG is not feasible to maintain separately:
  * It is used exclusively by freeorion.
  * FreeOrion maintains a fork of GG in FreeOrion's source tree.
  * FreeOrion's GG fork is better maintained and needs less patches.
* For example the original libgigi library doesn't build with gcc-4.7
  (requires gcc-4.6) while from FreeOrion's source tree
  it builds fine with gcc-4.7 and doesn't need the "vector.patch".
  * GG is not a proper library (more like a plugin) and therefore
not suitable for packaging as a standalone libgigi(-dev) package.

Would I need to submit a bundle library exception to the FPC for this?

2) FSF address incorrect

I noticed a rpmlint warning about an incorrect FSF address. When I looked at
the COPYING file shipped by upstream, it does have the correct address. The
only difference was a comma (,) inserted between the ZIP code and the country.
I feel like ignoring this lint error is okay, since the address is correct,
just formatted funny.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1396216] Review Request: aalto-xml - Ultra-high performance non-blocking XML processor (Stax/Stax2 , SAX/SAX2)

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1396216



--- Comment #3 from gil cattaneo  ---
And also
https://fedoraproject.org/wiki/Packaging:LicensingGuidelines#Subpackage_Licensing

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1396216] Review Request: aalto-xml - Ultra-high performance non-blocking XML processor (Stax/Stax2 , SAX/SAX2)

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1396216



--- Comment #2 from gil cattaneo  ---
(In reply to Thomas Andrejak from comment #1)
> I'm not a packager yet, hence the review is unofficial.
> 
> - Be carefull with 80 columns, even in comments, but when you have space
> (%description), use it
? i dont care about this ...
> - On my side, http://wiki.fasterxml.com/AaltoHome is not working
At the moment fasterxml site is offline
> - In %description javadoc, use a more interesting description (We already
> now that this is a package, and this is the javadoc) or use the same
> description as the main package
For me is fine so ...
> - Why are you doing this :
> mv release-notes/asl/ASL2.0 LICENSE
> mv release-notes/asl/LICENSE NOTICE
> 
> in %files you can use %licence with path
No, thanks
> - %files javadoc : %license is only required in main package
NOT true
Before add others comment, please, read our Java packaging guideline/s, and are
available here
https://fedora-java.github.io/howto/latest/
https://fedoraproject.org/wiki/Packaging:Java
Thanks and regards
> Regards

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1323214] Review Request: git-evtag - Strong GPG verification of git tags

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1323214



--- Comment #9 from Jon Ciesla  ---
Package request has been approved:
https://admin.fedoraproject.org/pkgdb/package/rpms/git-evtag

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1346407] Review Request: stress-ng - Stress test a computer system in various ways

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1346407



--- Comment #12 from Jon Ciesla  ---
Package request has been approved:
https://admin.fedoraproject.org/pkgdb/package/rpms/stress-ng

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1396819] Review Request: libkcapi - User space interface to the Linux Kernel Crypto API

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1396819



--- Comment #8 from Thomas Andrejak  ---
For %doc and manpages, in
https://fedoraproject.org/wiki/Packaging:Guidelines#Manpages the example do not
put the %doc macro. That's why I said it. The wiki is wrong ?




> - %build
> Why are you forcing cflags instead of making patchs ?

Hm, I don't understand. Why should I make patches?
=> I don't think that overwriting CFLAGS is a good thing because the
environment can set it. (I may think wrong). For example for hardening. So I
try to never do this and prefer patch makefile or other file to do what I need
to do.




> - manpage should go to main package

I don't think so. Those are all man pages in section 3, only useful for
development.
=> Also in https://fedoraproject.org/wiki/Packaging:Guidelines#Manpages , the
example put manpage in main package. But you are right, this man page is for
developpeurs, not users. I agree with you.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1396331] Review Request: elfio - C++ library for reading and generating ELF files

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1396331



--- Comment #3 from Jon Ciesla  ---
Package request has been approved:
https://admin.fedoraproject.org/pkgdb/package/rpms/elfio

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1374898] Review Request: quasselc - API to access a Quassel Core in pure C

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1374898



--- Comment #9 from Jon Ciesla  ---
Package request has been approved:
https://admin.fedoraproject.org/pkgdb/package/rpms/quasselc

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1396819] Review Request: libkcapi - User space interface to the Linux Kernel Crypto API

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1396819



--- Comment #7 from Zbigniew Jędrzejewski-Szmek  ---
Updated in place:
* Sun Nov 20 2016 Zbigniew Jędrzejewski-Szmek  - 0.12.0-1
- Add more patches and link to upstream pull request
- Update %%description
- Drop valgrind invocation, it wasn't helping
- Skip tests on 32 bits
- Add BSD license file for completeness

Spec URL: http://in.waw.pl/~zbyszek/fedora/libkcapi.spec
SRPM URL: http://in.waw.pl/~zbyszek/fedora/libkcapi-0.12.0-1.fc26.src.rpm
koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=16545948

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1396513] Review Request: nitrokey-app - Nitrokey's Application

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1396513



--- Comment #4 from Jon Ciesla  ---
Package request has been approved:
https://admin.fedoraproject.org/pkgdb/package/rpms/nitrokey-app

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1396817] Review Request: setlock - a go port of setlock ( an utility of daemontools)

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1396817



--- Comment #2 from Thomas Andrejak  ---
is there a reason that you do not use %gobuild and %gotest ?

Because without this, I have this error :
+ go build cmd/setlock/setlock.go
# command-line-arguments
cmd/setlock/setlock.go:9:20: error: import file './../../go-setlock' not found
  "./../../go-setlock"

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1396819] Review Request: libkcapi - User space interface to the Linux Kernel Crypto API

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1396819



--- Comment #6 from Zbigniew Jędrzejewski-Szmek  ---
(In reply to Thomas Andrejak from comment #3)
> - %doc %{_mandir}/man3/kcapi_*.3*
> => man pages are not %doc

Oh, I misread. I though you meant that I forgot to put %doc on those pages, not
that I should remove it. I don't see why you think %doc is not applicable, this
is clearly documentation.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1396819] Review Request: libkcapi - User space interface to the Linux Kernel Crypto API

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1396819



--- Comment #5 from Zbigniew Jędrzejewski-Szmek  ---
(In reply to Thomas Andrejak from comment #3)
> I'm not a packager yet, hence the review is unofficial.
> 
> - Patchs
> https://fedoraproject.org/wiki/Packaging:Guidelines#Patch_Guidelines
> Patch01 -> Patch1
> 0001 -> remove 0001, etc
> 0002-build-sys-create-all-destination-directories-and-do-.patch -> why an
> ending - ?
> For each patch, please add the issue URL to upstream

That's a git thing, it truncates patch subjects at a certain width.

I'll add a link to the upstream PR.

> - %descriptiondevel
> The %{name}-devel package contains header files for developing
> applications that use %{name}.
> => Header files for developing applications that use %{name}
OK.

> - %build
> Why are you forcing cflags instead of making patchs ?

Hm, I don't understand. Why should I make patches?

> 
> - %check
> %ifarch aarch64
> ./test.sh || :
> %else
> ./test.sh || :
> %endif
> => why this "if" with same inside block ?

Typo ;)

> - %license
> Have you forgotten COPYING.bsd ?

No, COPYING already contains the text of the BSD license. But I guess it's
safer to include both, I'll add it COPYING.bsd too.

> - %doc %{_mandir}/man3/kcapi_*.3*
> => man pages are not %doc

Indeed, will fix.

(In reply to Thomas Andrejak from comment #4)
> Also :
> 
> - BuildRequires gcc make are not needed

No, fedora-review is misleading you. This changed a few months ago.
See https://fedoraproject.org/wiki/Packaging:Guidelines#BuildRequires_2.

> - manpage should go to main package

I don't think so. Those are all man pages in section 3, only useful for
development.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1396819] Review Request: libkcapi - User space interface to the Linux Kernel Crypto API

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1396819



--- Comment #4 from Thomas Andrejak  ---
Also :

- BuildRequires gcc make are not needed

- manpage should go to main package

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1396817] Review Request: setlock - a go port of setlock ( an utility of daemontools)

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1396817

Thomas Andrejak  changed:

   What|Removed |Added

 CC||thomas.andre...@gmail.com



--- Comment #1 from Thomas Andrejak  ---
I'm not a packager yet, hence the review is unofficial.

- Summary:
Start with an upcase

- Patch0:
Please add the URL to the upstream issue

- %files
Why are you forcing defattr, it should be OK by default
LICENSE is not a %doc but a %license

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1396819] Review Request: libkcapi - User space interface to the Linux Kernel Crypto API

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1396819

Thomas Andrejak  changed:

   What|Removed |Added

 CC||thomas.andre...@gmail.com



--- Comment #3 from Thomas Andrejak  ---
I'm not a packager yet, hence the review is unofficial.

- Patchs
https://fedoraproject.org/wiki/Packaging:Guidelines#Patch_Guidelines
Patch01 -> Patch1
0001 -> remove 0001, etc
0002-build-sys-create-all-destination-directories-and-do-.patch -> why an
ending - ?
For each patch, please add the issue URL to upstream

- %descriptiondevel
The %{name}-devel package contains header files for developing
applications that use %{name}.
=> Header files for developing applications that use %{name}

- %build
Why are you forcing cflags instead of making patchs ?

- %check
%ifarch aarch64
./test.sh || :
%else
./test.sh || :
%endif
=> why this "if" with same inside block ?

- %license
Have you forgotten COPYING.bsd ?

- %doc %{_mandir}/man3/kcapi_*.3*
=> man pages are not %doc

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1396819] Review Request: libkcapi - User space interface to the Linux Kernel Crypto API

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1396819



--- Comment #2 from Zbigniew Jędrzejewski-Szmek  ---
See also: https://github.com/smuellerDD/libkcapi/pull/5

SONAME is set during build:
gcc -shared -Wl,-soname,libkcapi.so.0 -o libkcapi.so.0.12.0 kcapi-kernel-if.o
kdf.o -Wl,-z,relro,-z,now -Wl,--version-script,version.lds  
I think this is correct.

Pfff, I forgot about valgrind. But this is a debugging measure anyway,
hopefully it'll go away soon.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1346407] Review Request: stress-ng - Stress test a computer system in various ways

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1346407

Sascha Spreitzer  changed:

   What|Removed |Added

  Flags||needinfo?(ignatenko@redhat.
   ||com)



--- Comment #11 from Sascha Spreitzer  ---
Spec URL: https://git.spreitzer.ch/sspreitzer/snippets/snippets/3/raw
SRPM URL:
https://kojipkgs.fedoraproject.org//work/tasks/5396/16545396/stress-ng-0.07.05-2.fc26.src.rpm

Koji task: http://koji.fedoraproject.org/koji/taskinfo?taskID=16545395

Recommendations included

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1396819] Review Request: libkcapi - User space interface to the Linux Kernel Crypto API

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1396819



--- Comment #1 from Igor Gnatenko  ---
- BuildRequires: valgrind
actually it's available not on all arches, so you can wrap it with %ifarch
%{valgrind_arches} (same in %check)

- ln -s libkcapi.so.0 %{buildroot}%{_libdir}/libkcapi.so
I'm not sure what SONAME that library will have (I guess wrong)

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1396819] New: Review Request: libkcapi - User space interface to the Linux Kernel Crypto API

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1396819

Bug ID: 1396819
   Summary: Review Request: libkcapi - User space interface to the
Linux Kernel Crypto API
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: zbys...@in.waw.pl
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL: http://in.waw.pl/~zbyszek/fedora/libkcapi.spec
SRPM URL: http://in.waw.pl/~zbyszek/fedora/libkcapi-0.12.0-1.fc26.src.rpm
Description:
libkcapi allows user-space to access the Linux kernel crypto API.

This library uses the netlink interface and exports easy to use APIs
so that a developer does not need to consider the low-level netlink
interface handling.

The library does not implement any cipher algorithms. All consumer
requests are sent to the kernel for processing. Results from the
kernel crypto API are returned to the consumer via the library API.

The kernel interface and therefore this library can be used by
unprivileged processes.

Fedora Account System Username: zbyszek
koji build w/o arm64:
http://koji.fedoraproject.org/koji/taskinfo?taskID=16538967
(Note that the build seems stuck on all 32bit arches, I'm looking into this.)

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1396817] Review Request: setlock - a go port of setlock ( an utility of daemontools)

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1396817

IWAI, Masaharu  changed:

   What|Removed |Added

 Blocks||177841 (FE-NEEDSPONSOR)




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=177841
[Bug 177841] Tracker: Review requests from new Fedora packagers who need a
sponsor
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1396817] New: Review Request: setlock - a go port of setlock ( an utility of daemontools)

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1396817

Bug ID: 1396817
   Summary: Review Request: setlock - a go port of setlock (an
utility of daemontools)
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Assignee: nob...@fedoraproject.org
  Reporter: iwaim@gmail.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL:
https://raw.githubusercontent.com/iwaim/fedora-pkgs/master/review/go-setlock/setlock.spec
SRPM URL:
https://raw.githubusercontent.com/iwaim/fedora-pkgs/master/review/go-setlock/setlock-1.3.0-1.fc23.src.rpm
Description: go-setlock is a go port of setlock (an utility of daemontools).
Fedora Account System Username: iwaim

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1396406] Review Request: libebur128 - A library that implements the EBU R 128 standard for loudness normalization

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1396406

Sascha Spreitzer  changed:

   What|Removed |Added

  Flags||fedora-review?



--- Comment #2 from Sascha Spreitzer  ---
Going to review this

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1346407] Review Request: stress-ng - Stress test a computer system in various ways

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1346407



--- Comment #10 from Igor Gnatenko  ---
* [RECOMMENDED] make %{?_smp_mflags} -> %make_build
* [MINOR] make %{?_smp_mflags} is not needed in %install
* [CRITICAL] LDFLAGS are ignored
* [RECOMMENDED] %{_mandir}/man1/stress-ng.1.gz -> %{_mandir}/man1/stress-ng.1*

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1396478] Review Request: daala - Daala video compression

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1396478

Sascha Spreitzer  changed:

   What|Removed |Added

  Flags||fedora-review?



--- Comment #1 from Sascha Spreitzer  ---
Going to review this

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1396216] Review Request: aalto-xml - Ultra-high performance non-blocking XML processor (Stax/Stax2 , SAX/SAX2)

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1396216

Thomas Andrejak  changed:

   What|Removed |Added

 CC||thomas.andre...@gmail.com



--- Comment #1 from Thomas Andrejak  ---
I'm not a packager yet, hence the review is unofficial.

- Be carefull with 80 columns, even in comments, but when you have space
(%description), use it

- On my side, http://wiki.fasterxml.com/AaltoHome is not working

- In %description javadoc, use a more interesting description (We already now
that this is a package, and this is the javadoc) or use the same description as
the main package

- Why are you doing this :
mv release-notes/asl/ASL2.0 LICENSE
mv release-notes/asl/LICENSE NOTICE

in %files you can use %licence with path

- %files javadoc : %license is only required in main package

Regards

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1346407] Review Request: stress-ng - Stress test a computer system in various ways

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1346407



--- Comment #9 from Sascha Spreitzer  ---
http://koji.fedoraproject.org/koji/taskinfo?taskID=16545046

builds perfectly now

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1387447] Review Request: php-sentry - PHP client for Sentry

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1387447



--- Comment #24 from Fedora Update System  ---
php-sentry-0.22.0-1.el6 has been pushed to the Fedora EPEL 6 stable repository.
If problems still persist, please make note of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1353169] Review Request: python-nikola - A static website and blog generator

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1353169

Neal Gompa  changed:

   What|Removed |Added

  Flags||fedora-review?



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1353169] Review Request: python-nikola - A static website and blog generator

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1353169

Neal Gompa  changed:

   What|Removed |Added

 CC||jama...@fc.up.pt
  Flags||needinfo?(jama...@fc.up.pt)



--- Comment #17 from Neal Gompa  ---
@Jose:

Are you still interested in reviving nikola?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1343977] Review Request: rubygem-asciidoctor-mallard - A Project Mallard converter for AsciiDoc

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1343977

Tummala Dhanvi (c0mrad3)  changed:

   What|Removed |Added

  Flags||needinfo?(vondruch@redhat.c
   ||om)



--- Comment #12 from Tummala Dhanvi (c0mrad3)  ---
> 
> 
> > > * Package version
> > >   - Please use proper version scheme. The package version should be 
> > > probably
> > > just "0.1.0" while the release should be "0.1.dev".
> > >   - The versioning is documented in detail here [2].
> > I upstream had it versioning like that
> > https://github.com/asciidoctor/asciidoctor-mallard/blob/master/lib/
> > asciidoctor-mallard/version.rb
> > 
> > but I have updated it to 0.1.dev
> 
> Please read the [2] carefully. You have to ensure update path. E.g. the
> original VR you used was "0.1.0.dev-1". If the upstream released stable
> version "0.1.0", your VR would become "0.1.0.dev-1" and this is what RPM
> thinks about the versions:
> 
> ```
> $ rpmdev-vercmp 0.1.0.dev-1 0.1.0-1
> 0.1.0.dev-1 > 0.1.0-1
> ```
> 
> That means the newer version would never get installed. Hence I suggested to
> use just "0.1.0" while the release should be "0.1.dev". In the .spec file,
> it would look like:
> 
> ```
> Version: 0.1.0
> Release: 0.1.dev%{?dist}
> ```
> 
> Which makes the upgrade path correct:
> 
> ```
> $ rpmdev-vercmp 0.1.0-0.1.dev 0.1.0-1
> 0.1.0-0.1.dev < 0.1.0-1
> ```
> 
> Again, please read the [2] carefully (although I admit it is not easy read,
> but hopefully this will get simplified in the future).
Got it right this time!
> 
> > > * Test suite
> > >   - Well, the line you used is just part of the story. You can see that 
> > > there
> > > is nothing which would indicated, that the test suite was executed. 
> > > You
> > > should use following line:
> > > 
> > > ```
> > > ruby -Ilib -e 'Dir.glob "./test/*_test.rb", (:require)'
> > > ```
> > > 
> > >   - Unfortunately, there seems to be dependency on asciidoctor-doctest, 
> > > which
> > > is not in Fedora yet. Since it has quite lot of dependencies, it is
> > > probably not worth of packaging ATM, but all this should be 
> > > documented.
> > >   - Instead of execution of test suite, you should consider to provide at
> > > least
> > > some sanity test, e.g. try to convert some document from AsciiDoc to
> > > Mallard using the %{gem_instdir}/bin/asciidoctor-mallard
> > > 
> > Can you please explain me a bit more about how to get it right ? 
> > 
> > URL: https://dhanvi.fedorapeople.org/packages/asciidoctor-mallard/
> 
> My idea was to do something as simple as shipping some simple AsciiDoc file
> as Source1 and trying the conversion, e.g. the %check section could look
> like:
> 
> ```
> %check
> pushd .%{gem_instdir}
> # There is no rubygem-asciidoctor-doctest in Fedora yet, which is needed
> # for test suite.
> # ruby -Ilib -e 'Dir.glob "./test/*_test.rb", (:require)'
> 
> bin/asciidoctor-mallard %{SOURCE1} -o test.output
> popd
> 
> ```
> 
> This is the simplest test you can do, since if the conversion fails for
> whatever reason, the build should break.
> 
> On top of that, you can check for the consistency of the output by
> calculating hash of the output, e.g. you can add the following line there:
> 
> ```
> sha256sum test.output | grep
> "870474333c6f4e41238f923f1d27c7688c86b6463db39725e076fc5f05fe2520" 
> ```
done it using the example given in the README
> 
> Of course you have to use correct hash, based on the content of the
> %{SOURCE1} file you are going to use. Or you can choose to test any other
> bit of the file content, if you consider it important.
> 
> 
> BTW just running "bin/asciidoctor-mallard" will fail the build ATM, since
> there is apparently some bug (undefined method `size' for nil:NilClass).
> 
This might be due to the requirements of rubygem-asciidoctor which I missed,
also 

`
ruby ./bin/asciidoctor-mallard
`

works.

URL: https://dhanvi.fedorapeople.org/packages/asciidoctor-mallard/

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1155793] Review Request: hyperrogue - An SDL roguelike in a non-euclidean world

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1155793



--- Comment #29 from nobra...@gmail.com ---
Concerning SDL2, I simply don't know. I'm not at all a c/c++ dev :p

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1155793] Review Request: hyperrogue - An SDL roguelike in a non-euclidean world

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1155793



--- Comment #28 from nobra...@gmail.com ---
Hi,

I have just noticed the savepng file is under zlib, I added it as a bundled
lib, and update the license tag.
I have updated the previous link.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1372893] Review Request: python-parquet - Python implementation of the Parquet file format

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1372893

Igor Gnatenko  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED



--- Comment #1 from Igor Gnatenko  ---
William, feel free to start review ;) And thanks a lot for other reviews!

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1372889] Review Request: python-thriftpy - Pure Python implementation of Apache Thrift

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1372889



--- Comment #3 from Fedora Update System  ---
python-thriftpy-0.3.9-1.fc25 python-toro-1.0.1-1.fc25 has been submitted as an
update to Fedora 25.
https://bodhi.fedoraproject.org/updates/FEDORA-2016-b4362aee1c

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1372889] Review Request: python-thriftpy - Pure Python implementation of Apache Thrift

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1372889

Fedora Update System  changed:

   What|Removed |Added

 Status|POST|MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1372889] Review Request: python-thriftpy - Pure Python implementation of Apache Thrift

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1372889

Igor Gnatenko  changed:

   What|Removed |Added

 Status|NEW |POST



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1372888] Review Request: python-toro - Synchronization primitives for Tornado coroutines

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1372888



--- Comment #3 from Fedora Update System  ---
python-toro-1.0.1-1.fc25 has been submitted as an update to Fedora 25.
https://bodhi.fedoraproject.org/updates/FEDORA-2016-b4362aee1c

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1372888] Review Request: python-toro - Synchronization primitives for Tornado coroutines

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1372888

Fedora Update System  changed:

   What|Removed |Added

 Status|POST|MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1372888] Review Request: python-toro - Synchronization primitives for Tornado coroutines

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1372888

Igor Gnatenko  changed:

   What|Removed |Added

 Status|NEW |POST



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1352972] Review Request: python-twine - Collection of utilities for interacting with PyPI

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1352972

Igor Gnatenko  changed:

   What|Removed |Added

 Status|NEW |CLOSED
 Resolution|--- |CURRENTRELEASE
Last Closed||2016-11-20 05:02:18



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1336159] Review Request: golang-github-rubyist-tracerx - Output tracing information in your Go app based on environment variables

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1336159

Igor Gnatenko  changed:

   What|Removed |Added

 Status|ASSIGNED|POST



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1396761] Review Request: rofi - A window switcher, run dialog and dmenu replacement

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1396761



--- Comment #4 from Igor Gnatenko  ---
SPEC: https://ignatenkobrain.fedorapeople.org/for-review/rofi.spec
SRPM:
https://ignatenkobrain.fedorapeople.org/for-review/rofi-1.2.0-1.fc26.src.rpm

Fixed all above and updated to 1.2.0. Also fixed couple of rpmlint complaints.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1396761] Review Request: rofi - A window switcher, run dialog and dmenu replacement

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1396761



--- Comment #3 from Till Maas  ---
Also there is a newer upstream release: 1.2.0

And the upstream page says it needs a new maintainer :-(

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1396761] Review Request: rofi - A window switcher, run dialog and dmenu replacement

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1396761



--- Comment #2 from Till Maas  ---
- The SRPM URL does not work, the rofi directory does not exist at
https://copr-be.cloud.fedoraproject.org/results/region51/
- It would be better to use %{_mandir}/man1/%{name}.1* instead of
%{_mandir}/man1/%{name}.1.* as a pattern for the manpage to make it also work
if manpages are not compressed.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1350029] Review Request: libi40iw - userspace rdma library for Intel Ethernet Connection X722

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1350029

Igor Gnatenko  changed:

   What|Removed |Added

 Status|ASSIGNED|POST
  Flags||needinfo?(tatyana.e.nikolov
   ||a...@intel.com)



--- Comment #28 from Igor Gnatenko  ---
ping?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org