[Bug 1310434] Review Request: python-wxpython4 - new implementation of wxPython (Phoenix)

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1310434



--- Comment #1 from Scott Talbert  ---
Spec URL: https://www.techie.net/~talbert/python-wxpython4.spec
SRPM URL: https://www.techie.net/~talbert/python-wxpython4-4.0.1-1.fc28.src.rpm
Description: wxPython4 is a is a new implementation of wxPython focused on
improving speed, maintainability and extensibility. Just like "Classic"
wxPython it wraps the wxWidgets C++ toolkit and provides access to the user
interface portions of the wx API, enabling Python applications to have a GUI on
Windows, Macs or Unix systems with a native look and feel and requiring very
little (if any) platform specific code.
Fedora Account System Username: swt2c

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1310434] Review Request: python-wxpython4 - new implementation of wxPython (Phoenix)

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1310434

Scott Talbert  changed:

   What|Removed |Added

 Whiteboard|NotReady|



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1310434] Review Request: python-wxpython4 - new implementation of wxPython (Phoenix)

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1310434

Scott Talbert  changed:

   What|Removed |Added

Summary|Review Request: |Review Request:
   |wxPython-Phoenix - new  |python-wxpython4 - new
   |implementation of wxPython  |implementation of wxPython
   ||(Phoenix)



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1536782] Review Request: golang-github-cryptix-wav - golang wav reader and writer

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1536782



--- Comment #2 from sensor@gmail.com ---
SPEC:
https://copr-be.cloud.fedoraproject.org/results/mosquito/deepin/fedora-27-x86_64/00713241-golang-github-cryptix-wav/golang-github-cryptix-wav.spec
SRPM:
https://copr-be.cloud.fedoraproject.org/results/mosquito/deepin/fedora-27-x86_64/00713241-golang-github-cryptix-wav/golang-github-cryptix-wav-0-0.1.20171018git7b3d650.fc27.src.rpm

I fixed it, thank you. Please review again.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1544081] New: Review Request: grc - Generic Colorizer

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1544081

Bug ID: 1544081
   Summary: Review Request: grc - Generic Colorizer
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: robinlee.s...@gmail.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL: https://cheeselee.fedorapeople.org/grc.spec
SRPM URL: https://cheeselee.fedorapeople.org/grc-1.11.1-1.fc28.src.rpm
Description:
Generic Colorizer is yet another colorizer for beautifying your log files or
output of commands.
Fedora Account System Username: cheeselee

Note that there is a retired package with the same name but different source.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1525694] Review Request: golang-github-bitly-go-simplejson - Go package to interact with arbitrary JSON

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1525694



--- Comment #6 from Fedora Update System  ---
golang-github-bitly-go-simplejson-0.5.0-2.fc26 has been submitted as an update
to Fedora 26. https://bodhi.fedoraproject.org/updates/FEDORA-2018-84a1820855

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1525696] Review Request: golang-github-nwidger-jsoncolor - Colorized JSON output for Go

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1525696



--- Comment #6 from Fedora Update System  ---
golang-github-nwidger-jsoncolor-0-0.2.20170215git75a6de4.fc26 has been
submitted as an update to Fedora 26.
https://bodhi.fedoraproject.org/updates/FEDORA-2018-18c9ba5ad3

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1542646] Review Request: patool - Portable command line archive file manager

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1542646



--- Comment #9 from Fedora Update System  ---
patool-1.12-1.fc26 has been submitted as an update to Fedora 26.
https://bodhi.fedoraproject.org/updates/FEDORA-2018-aabb305a90

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1543989] Review Request: rust-structopt - Parse command line argument by defining a struct

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1543989

Robert-André Mauchin  changed:

   What|Removed |Added

 Status|NEW |POST
 CC||zebo...@gmail.com
   Assignee|nob...@fedoraproject.org|zebo...@gmail.com
  Flags||fedora-review+



--- Comment #1 from Robert-André Mauchin  ---
 - License OK
 - Latest version packaged
 - Builds in mock
 - No RPMLint errors

Package approved.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1525698] Review Request: jid - Json Incremental Digger

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1525698



--- Comment #6 from Fedora Update System  ---
jid-0.7.2-1.fc27 has been submitted as an update to Fedora 27.
https://bodhi.fedoraproject.org/updates/FEDORA-2018-61e8dd7f23

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1525698] Review Request: jid - Json Incremental Digger

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1525698

Fedora Update System  changed:

   What|Removed |Added

 Status|POST|MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1542646] Review Request: patool - Portable command line archive file manager

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1542646



--- Comment #8 from Fedora Update System  ---
patool-1.12-1.fc27 has been submitted as an update to Fedora 27.
https://bodhi.fedoraproject.org/updates/FEDORA-2018-3a91b279e2

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1542646] Review Request: patool - Portable command line archive file manager

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1542646

Fedora Update System  changed:

   What|Removed |Added

 Status|POST|MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1543987] Review Request: rust-structopt-derive - Parse command line argument by defining a struct, derive crate

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1543987

Robert-André Mauchin  changed:

   What|Removed |Added

 Status|NEW |POST
 CC||zebo...@gmail.com
   Assignee|nob...@fedoraproject.org|zebo...@gmail.com
  Flags||fedora-review+



--- Comment #1 from Robert-André Mauchin  ---
 - License OK
 - Latest version packaged
 - Builds in mock
 - No RPMLint errors

Package approved.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1494914] Review Request: rspamd - Rapid spam filtering system

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1494914

Robert-André Mauchin  changed:

   What|Removed |Added

 CC||i...@cicku.me



--- Comment #3 from Robert-André Mauchin  ---
*** Bug 1023690 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1023690] Review Request: rspamd - Fast, free and open-source spam filtering system

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1023690

Robert-André Mauchin  changed:

   What|Removed |Added

 Status|NEW |CLOSED
 CC||zebo...@gmail.com
 Resolution|--- |DUPLICATE
Last Closed||2018-02-09 16:52:58



--- Comment #7 from Robert-André Mauchin  ---


*** This bug has been marked as a duplicate of bug 1494914 ***

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1543377] Review Request: python3-saml - Add SAML support to your Python software using this library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1543377

Robert-André Mauchin  changed:

   What|Removed |Added

 Status|NEW |POST
 CC||zebo...@gmail.com
   Assignee|nob...@fedoraproject.org|zebo...@gmail.com
  Flags||fedora-review+



--- Comment #1 from Robert-André Mauchin  ---
Package approved.


Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed



= MUST items =

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: "MIT/X11 (BSD like)", "BSD (unspecified)", "Unknown or
 generated". 250 files have unknown license. Detailed output of
 licensecheck in /home/bob/packaging/review/python3-saml/review-
 python3-saml/licensecheck.txt
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 71680 bytes in 1 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: No rpmlint messages.
[x]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
 provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
 %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

Python:
[x]: Python eggs must not download any dependencies during the build
 process.
[x]: A package which is used by another package via an egg interface should
 provide egg info.
[x]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel or python3-devel
[x]: Binary eggs must be removed in %prep

= SHOULD items =

Generic:
[-]: If the source package does not include license text(s) as a separate
 file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[?]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[x]: Patches link to upstream bugs/comments/lists or are otherwise
 justified.
[-]: Description and summary sections in the package spec file contains
 translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
 architectures.
[x]: %check is present and all tests pass.
[x]: Packages should try 

[Bug 1538658] Review Request: python-anyconfig - common API to load and dump configuration files

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1538658



--- Comment #12 from Zbigniew Jędrzejewski-Szmek  ---
(In reply to Brett Lentz from comment #11)
> (In reply to Zbigniew Jędrzejewski-Szmek from comment #10)
> > > %global sum Python library to load and dump configuration files in 
> > > various formats
> > Using normal Summary: and then %summary subsequently saves one line ;)
> > 
> 
> Not true. The summary is used in 3 places because of the python2 & python3
> sub-packaged. The macro saves copy/pasting the same text in 3 places.  :)

I didn't mean copying the text three times. I meant something like this:
Summary: blah blah blah
...
Summary: %summary
...
Summary: %summary

Macro %summary is automatically defined to the contents of the last Summary
line.

> > During build I see the following error:
> > > import cbor
> > > ImportError: No module named cbor
> > Is some dependency missing?
> > 
> 
> There is support for a backend (cbor) that does not currently have a package
> in Fedora. If it's okay with you, I'd prefer to not block this package on
> the one missing backend.
> 
> This anyconfig package is a dependency of the package I'm ultimately looking
> to get into Fedora (molecule). However, anyconfig's support for cbor is not
> a part of my critical path.
> 
> I am willing to work on a python-cbor package after anyconfig is in Fedora,
> if that works for you.

Sure, whatever works. There is no obligation to package everything possible. If
something is an optional dependency, it's entirely reasonable to leave it for
later or to somebody else who actually needs it.

> > and later:
> > > toml.py:docstring of 
> > > anyconfig.backend.toml.Parser._load_from_stream_fn:6: WARNING: Definition 
> > > list ends without a blank line; unexpected unindent.
> > > /builddir/build/BUILD/python-anyconfig-RELEASE_0.9.3/anyconfig/backend/xml.py:docstring
> > >  of anyconfig.backend.xml._tweak_ns:4: WARNING: Field list ends without a 
> > > blank line; unexpected unindent.
> > > /builddir/build/BUILD/python-anyconfig-RELEASE_0.9.3/docs/api/anyconfig.cli.rst:4:
> > >  WARNING: autodoc: failed to import module u'anyconfig.cli'; the 
> > > following exception was raised:
> > > Traceback (most recent call last):
> > >   File "/usr/lib/python2.7/site-packages/sphinx/ext/autodoc.py", line 
> > > 658, in import_object
> > > __import__(self.modname)
> > >   File 
> > > "/builddir/build/BUILD/python-anyconfig-RELEASE_0.9.3/anyconfig/cli.py", 
> > > line 42, in 
> > > sys.stdout = codecs.getwriter(_ENCODING)(sys.stdout)
> > >   File "/usr/lib64/python2.7/codecs.py", line 1009, in getwriter
> > > return lookup(encoding).streamwriter
> > > TypeError: lookup() argument 1 must be string, not None
> > > done
> > 
> This looks like a bug in the docs. I'll point it out to upstream.
Great.

> > And now the hard part: what is the difference in behaviour or output between
> > anyconfig-2 and anyconfig-3?
> 
> There is no difference, AFAICS.
OK. If there is no difference, then only one version of the executable should
be packed. See
https://fedoraproject.org/wiki/Packaging:Python#Executables_in_.2Fusr.2Fbin:
> If the executables provide the same functionality independent of whether they 
> are run on top of Python 2 or Python 3, then only the Python 3 version of the 
> executable should be packaged.

You went through the effort to get the symlinks right, but it now seems that
not actually necessary ;(

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1520584] Review Request: perl-MooseX-Types-NetAddr-IP - NetAddr:: IP related types and coercions for Moose

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1520584



--- Comment #11 from Fedora Update System  ---
perl-MooseX-Types-NetAddr-IP-0.07-2.el7 has been submitted as an update to
Fedora EPEL 7.
https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2018-1fc7101641

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1538658] Review Request: python-anyconfig - common API to load and dump configuration files

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1538658



--- Comment #11 from Brett Lentz  ---
(In reply to Zbigniew Jędrzejewski-Szmek from comment #10)
> I'll take the review.
> 

Great! Thanks!

> > %global sum Python library to load and dump configuration files in various 
> > formats
> Using normal Summary: and then %summary subsequently saves one line ;)
> 

Not true. The summary is used in 3 places because of the python2 & python3
sub-packaged. The macro saves copy/pasting the same text in 3 places.  :)


> > %global debug_package %{nil}
> That looks suspicious. Why do you need this?
> Package builds fine without it.

Removed.

> 
> > %{__rm}
> Eh, using a macro here is entirely pointless. It just makes the commands
> harder to read (and longer). The guidelines say that macros should be used
> for some *directories*
> [https://fedoraproject.org/wiki/Packaging:Guidelines#Macros], but even that
> makes little sense nowadays.
> 

Fixed.

> > https://github.com/ssato/%{name}
> I know people love macros, but this makes it impossible to just click on
> this and open it in a browser… It's a matter of preference, but I don't see
> the advantage of using a macro here.
> 

Fixed.

> > Source0:%{url}/archive/RELEASE-%{version}.tar.gz
> This should be ...RELEASE_{%version}...
> 

Fixed.

> > %defattr(-,root,root,-)
> Not necessary in Fedora and somewhat recent RHEL.
> 

Fixed

> - Large documentation must go in a -doc subpackage. Large could be size
>   (~1MB) or number of files.
>   Note: Documentation size is 2662400 bytes in 126 files.
>   See:
>   http://fedoraproject.org/wiki/Packaging/Guidelines#PackageDocumentation
> 
> It'd be nice to split out a python-anyconfig-doc subpackage with the docs.
> 

Fixed.

> 
> During build I see the following error:
> > import cbor
> > ImportError: No module named cbor
> Is some dependency missing?
> 

There is support for a backend (cbor) that does not currently have a package in
Fedora. If it's okay with you, I'd prefer to not block this package on the one
missing backend.

This anyconfig package is a dependency of the package I'm ultimately looking to
get into Fedora (molecule). However, anyconfig's support for cbor is not a part
of my critical path.

I am willing to work on a python-cbor package after anyconfig is in Fedora, if
that works for you.


> and later:
> > toml.py:docstring of anyconfig.backend.toml.Parser._load_from_stream_fn:6: 
> > WARNING: Definition list ends without a blank line; unexpected unindent.
> > /builddir/build/BUILD/python-anyconfig-RELEASE_0.9.3/anyconfig/backend/xml.py:docstring
> >  of anyconfig.backend.xml._tweak_ns:4: WARNING: Field list ends without a 
> > blank line; unexpected unindent.
> > /builddir/build/BUILD/python-anyconfig-RELEASE_0.9.3/docs/api/anyconfig.cli.rst:4:
> >  WARNING: autodoc: failed to import module u'anyconfig.cli'; the following 
> > exception was raised:
> > Traceback (most recent call last):
> >   File "/usr/lib/python2.7/site-packages/sphinx/ext/autodoc.py", line 658, 
> > in import_object
> > __import__(self.modname)
> >   File 
> > "/builddir/build/BUILD/python-anyconfig-RELEASE_0.9.3/anyconfig/cli.py", 
> > line 42, in 
> > sys.stdout = codecs.getwriter(_ENCODING)(sys.stdout)
> >   File "/usr/lib64/python2.7/codecs.py", line 1009, in getwriter
> > return lookup(encoding).streamwriter
> > TypeError: lookup() argument 1 must be string, not None
> > done
> 


This looks like a bug in the docs. I'll point it out to upstream.


> And now the hard part: what is the difference in behaviour or output between
> anyconfig-2 and anyconfig-3?

There is no difference, AFAICS.

> 
> And also (a question for upstream): why is the executable called
> "anyconfig_cli" and not just "anyconfig"?

Fixed in the spec until it's fixed upstream.


I've updated the spec and srpm. Same URLs as in comment #7.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1539209] Review Request: ddgr - DuckDuckGo from the terminal

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1539209



--- Comment #7 from Fedora Update System  ---
ddgr-1.2-1.fc26 has been submitted as an update to Fedora 26.
https://bodhi.fedoraproject.org/updates/FEDORA-2018-bcd841f6d6

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1539209] Review Request: ddgr - DuckDuckGo from the terminal

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1539209

Fedora Update System  changed:

   What|Removed |Added

 Status|NEW |MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1539209] Review Request: ddgr - DuckDuckGo from the terminal

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1539209



--- Comment #6 from Fedora Update System  ---
ddgr-1.2-1.fc27 has been submitted as an update to Fedora 27.
https://bodhi.fedoraproject.org/updates/FEDORA-2018-1ed409d72c

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1543578] Review Request: php-deepdiver-zipstreamer - package maintained fork of PHPZipStreamer

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1543578



--- Comment #4 from Christian Glombek  ---
Current build:

Spec URL:
https://copr-be.cloud.fedoraproject.org/results/lorbus/php-deepdiver-zipstreamer/fedora-27-x86_64/00713084-php-deepdiver-zipstreamer/php-deepdiver-zipstreamer.spec

SRPM URL:
https://copr-be.cloud.fedoraproject.org/results/lorbus/php-deepdiver-zipstreamer/fedora-27-x86_64/00713084-php-deepdiver-zipstreamer/php-deepdiver-zipstreamer-1.1.0-1.fc27.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1542650] Review Request: QEverCloud - Unofficial Evernote Cloud API for Qt5

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1542650



--- Comment #3 from Robert-André Mauchin  ---

> It looks as though the test binary "test_QEverCloud" is indeed getting built 
> according to the log file. Is it possible to run these in %check?

Good catch. I added the test and it is successful.


> This was recently discussed on the devel list. The takeaway from the change 
> proposal page seems to be that this is fine if you only want to support 
> Fedora 28+, but if you want to backport this to older releases, make sure to 
> add the ldconfig post scriplets (or use the new macros):

I added %ldconfig_scriptlets as I intend to support F27.

> You're missing a 'BuildArch: noarch' for the doc package.

Yes, thank you.

> it should just depend on qt5-qtbase.

-doc now depends on qt5-qtbase.


Spec URL:
https://raw.githubusercontent.com/eclipseo/packaging/9a4c14d/qevercloud.spec
SRPM URL:
https://copr-be.cloud.fedoraproject.org/results/eclipseo/quentier/fedora-rawhide-x86_64/00713062-qevercloud/qevercloud-4.0.0-1.fc28.src.rpm

SPEC diff:
https://github.com/eclipseo/packaging/commit/9a4c14d6fc5a25421f7676e895481ef2331cbfa8#diff-a88471a36243d712706fbf604f44a45f

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1542902] Review Request: php-pecl-redis4 - Extension for communicating with the Redis key-value store

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1542902

Robert-André Mauchin  changed:

   What|Removed |Added

 Status|NEW |POST
   Assignee|nob...@fedoraproject.org|zebo...@gmail.com
  Flags||fedora-review+



--- Comment #5 from Robert-André Mauchin  ---
Sorry for the delay, I was ill.

Everything seems ok now. Package approved.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1519749] Review request: qdigidoc - Estonian digital signature application

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1519749

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #10 from Fedora Update System  ---
qdigidoc-3.13.5-3.fc27 has been pushed to the Fedora 27 testing repository. If
problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2018-8d148ceb02

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1542663] Review Request: bitlbee-discord - Bitlbee plugin for Discord

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1542663



--- Comment #8 from Fedora Update System  ---
bitlbee-discord-0.4.1-2.fc27 has been pushed to the Fedora 27 testing
repository. If problems still persist, please make note of it in this bug
report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2018-829e7a235a

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1542931] Review Request: cri-tools - CLI and validation tools for Container Runtime Interface

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1542931

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #6 from Fedora Update System  ---
cri-tools-1.0.0-2.alpha.0.git653cc8c.fc27 has been pushed to the Fedora 27
testing repository. If problems still persist, please make note of it in this
bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2018-218e0f9890

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1542663] Review Request: bitlbee-discord - Bitlbee plugin for Discord

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1542663

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #7 from Fedora Update System  ---
bitlbee-discord-0.4.1-2.fc26 has been pushed to the Fedora 26 testing
repository. If problems still persist, please make note of it in this bug
report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2018-e3cf77ed71

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1539209] Review Request: ddgr - DuckDuckGo from the terminal

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1539209



--- Comment #5 from Gwyn Ciesla  ---
(fedrepo-req-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/ddgr. You may commit to the branch "f27" in
about 10 minutes.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1543989] Review Request: rust-structopt - Parse command line argument by defining a struct

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1543989

Igor Gnatenko  changed:

   What|Removed |Added

 Depends On||1543987
   ||(rust-structopt-derive)




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1543987
[Bug 1543987] Review Request: rust-structopt-derive - Parse command line
argument by defining a struct, derive crate
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1543987] Review Request: rust-structopt-derive - Parse command line argument by defining a struct, derive crate

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1543987

Igor Gnatenko  changed:

   What|Removed |Added

 Blocks||1543989 (rust-structopt)




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1543989
[Bug 1543989] Review Request: rust-structopt - Parse command line argument
by defining a struct
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1543989] New: Review Request: rust-structopt - Parse command line argument by defining a struct

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1543989

Bug ID: 1543989
   Summary: Review Request: rust-structopt - Parse command line
argument by defining a struct
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Assignee: nob...@fedoraproject.org
  Reporter: ignate...@redhat.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL:
https://ignatenkobrain.fedorapeople.org/for-review/rust-structopt.spec
SRPM URL:
https://ignatenkobrain.fedorapeople.org/for-review/rust-structopt-0.1.7-1.fc28.src.rpm
Description:
Parse command line argument by defining a struct.
Fedora Account System Username: ignatenkobrain

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1543987] New: Review Request: rust-structopt-derive - Parse command line argument by defining a struct, derive crate

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1543987

Bug ID: 1543987
   Summary: Review Request: rust-structopt-derive - Parse command
line argument by defining a struct, derive crate
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Assignee: nob...@fedoraproject.org
  Reporter: ignate...@redhat.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL:
https://ignatenkobrain.fedorapeople.org/for-review/rust-structopt-derive.spec
SRPM URL:
https://ignatenkobrain.fedorapeople.org/for-review/rust-structopt-derive-0.1.6-1.fc28.src.rpm
Description:
Parse command line argument by defining a struct, derive crate.
Fedora Account System Username: ignatenkobrain

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1492475] Review Request: aftertheflood-sparks-fonts - a font to display charts within text

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1492475



--- Comment #9 from Robert-André Mauchin  ---
> Can you still not build from source? I see some sources in the archive right 
> now.

I can't build from source as I said before, they are compiled with makeotf,
part of Adobe Font Development Kit for OpenType (AFDKO), a non free software.

> Are not Bar and Dot separate families, and thus should be packaged 
> separately? 

Yes, maybe, this is more complicated to implement.

> There's also something wrong with either the metrics or LO, because if I type 
> out the example using Sparks Bar Medium (and *some* of the other weights), 
> the cursor ends up a little short (as does the highlight if I select 
> everything.)

I can't do much about this.



SPEC URL:
https://raw.githubusercontent.com/eclipseo/packaging/e8a2a48/aftertheflood-sparks-fonts.spec
SRPM URL:
https://copr-be.cloud.fedoraproject.org/results/eclipseo/aftertheflood-sparks/fedora-rawhide-x86_64/00713037-aftertheflood-sparks-fonts/aftertheflood-sparks-fonts-2.0-1.fc28.src.rpm

SPEC diff:
https://github.com/eclipseo/packaging/commit/e8a2a489ca56de1645e07cd8ba384af819ed48b5#diff-e272db7fccba87eda45a3aa43baacdc1

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1539134] Review Request: bouncycastle1.58 - Bouncy Castle Cryptography APIs for Java

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1539134

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #8 from Fedora Update System  ---
bouncycastle1.58-1.58-1.el6, canl-java-2.5.0-2.el6, jglobus-2.1.0-5.el6,
voms-api-java-3.3.0-1.el6, voms-clients-java-3.3.0-1.el6 has been pushed to the
Fedora EPEL 6 testing repository. If problems still persist, please make note
of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2018-71db8f6f28

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1543813] Review Request: pwkickstart - generate kickstart passwords

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1543813

Neal Gompa  changed:

   What|Removed |Added

Summary|Review Request: pwkickstart |Review Request: pwkickstart
   |- generate kickstart|- generate kickstart
   |passwords (TRIVIAL SPEC)|passwords



--- Comment #1 from Neal Gompa  ---
Review notes:

[x] Package follows packaging guidelines
[x] Installs and runs correctly
[x] Licensing is correctly denoted and license file is correctly installed
[!] Ambiguous Python dependency

Please ensure the correct Python version is selected. Python 3 is preferred if
at all possible.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1543813] Review Request: pwkickstart - generate kickstart passwords ( TRIVIAL SPEC)

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1543813

Neal Gompa  changed:

   What|Removed |Added

 CC||ngomp...@gmail.com
   Assignee|nob...@fedoraproject.org|ngomp...@gmail.com
  Flags||fedora-review?



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1536852] Review Request: molsketch - Molecular Structures Editor

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1536852



--- Comment #28 from Alexander Ploumistos  ---
Spec URL: https://alexpl.fedorapeople.org/packages/Molsketch/molsketch.spec
SRPM URL:
https://alexpl.fedorapeople.org/packages/Molsketch/molsketch-0.5.1-6.fc28.src.rpm

rawhide scratch build:
https://koji.fedoraproject.org/koji/taskinfo?taskID=24893031
f27 scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=24893587

I used Hendrik's latest snapshot and it seems there aren't any unversioned
shared object files any more, so I had to adjust. I've only added the .so files
to the regular package.

OpenBabel-dependent stuff work.

I still get the "useless-provides debuginfo(build-id)" error for
molsketch-debuginfo.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1539189] Review Request: golang-github-zyedidia-pty - PTY interface for Go

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1539189



--- Comment #4 from Robert-André Mauchin  ---
I already asked for two previous packages, the dev doesn't want to upstream is
custom mod, says it would slow done the dev of his app.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1542522] Review Request: jsonnet - a data templating language

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1542522

Iwicki Artur  changed:

   What|Removed |Added

 CC||fed...@svgames.pl



--- Comment #1 from Iwicki Artur  ---
>Group: Development/Languages
The Group: tag is not used in Fedora.
https://fedoraproject.org/wiki/Packaging:Guidelines#Tags_and_Sections

>License: Apache-2.0
The correct identifier for the Apache Software Licence v.2.0 in Fedora is "ASL
2.0".
https://fedoraproject.org/wiki/Licensing:Main#Good_Licenses

>%package devel
As a general rule, devel packages should have a "Requires: %{name}%{?_isa} =
%{version}-%{release}"; this ensures that you can't install devel headers for a
different version of the library than the .so files provide.

>%package lib
Someone correct me if I'm wrong, but I think the preferred way is to have
"libSOMETHING", like "%package -n libjsonnet". The development headers would
then become "%package -n libjsonnet-devel".

>%if 0%{?fedora} >= 21
>%package python3
Seeing how Fedora 25 has been put to its grave almost two months ago, this
conditional can be removed.

>%{__make}
It is preferred to use non-macro forms of system executables.
https://fedoraproject.org/wiki/Packaging:Guidelines#Macros

You should also include the licence text in the packages, by putting the
following in %files: "%license LICENSE"
https://fedoraproject.org/wiki/Packaging:LicensingGuidelines#License_Text

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1543813] New: Review Request: pwkickstart - generate kickstart passwords (TRIVIAL SPEC)

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1543813

Bug ID: 1543813
   Summary: Review Request: pwkickstart - generate kickstart
passwords (TRIVIAL SPEC)
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: l...@redhat.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL:
https://raw.githubusercontent.com/lzap/spec_reviews/master/pwkickstart.spec
SRPM URL:
https://lzap.fedorapeople.org/fedora-packaging/pwkickstart/1.0.1/pwkickstart-1.0.1-1.fc27.src.rpm
Description: generate kickstart passwords
Fedora Account System Username: lzap

Thanks!

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1517243] Review Request: grace - Numerical Data Processing and Visualization Tool

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1517243

Zbigniew Jędrzejewski-Szmek  changed:

   What|Removed |Added

 Status|NEW |CLOSED
 Resolution|--- |NOTABUG
Last Closed||2018-02-09 04:42:14



--- Comment #8 from Zbigniew Jędrzejewski-Szmek  ---
If you want to carry this forward, you'll need to gain Fedora packager
privileges. Have you done reviews of other packages? Please paste some links
here.

I'll close this bug, because a new review is not necessary. Existing package
needs to be updated instead.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1542902] Review Request: php-pecl-redis4 - Extension for communicating with the Redis key-value store

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1542902



--- Comment #4 from Remi Collet  ---
OK, the s390x issue seems to be temporary, and fixed by the mass rebuild.
see https://github.com/phpredis/phpredis/issues/1305

So
https://git.remirepo.net/cgit/rpms/php/pecl/php-pecl-redis4.git/commit/?id=edf927c4d781392328149527778d789716415ab9

Scratch build:
http://rpms.remirepo.net/SRPMS/php-pecl-redis4-4.0.0~RC1-4.fedora.src.rpm

Spec URL:
https://git.remirepo.net/cgit/rpms/php/pecl/php-pecl-redis4.git/plain/php-pecl-redis4.spec?id=edf927c4d781392328149527778d789716415ab9
SRPM URL:
http://rpms.remirepo.net/SRPMS/php-pecl-redis4-4.0.0~RC1-4.fedora.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1526705] Review Request: python-f5-icontrol-rest - F5 BIG-IP iControl REST API client

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1526705

Zbigniew Jędrzejewski-Szmek  changed:

   What|Removed |Added

 CC||zbys...@in.waw.pl



--- Comment #2 from Zbigniew Jędrzejewski-Szmek  ---
Ping?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1538658] Review Request: python-anyconfig - common API to load and dump configuration files

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1538658

Zbigniew Jędrzejewski-Szmek  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||zbys...@in.waw.pl
   Assignee|nob...@fedoraproject.org|zbys...@in.waw.pl



--- Comment #10 from Zbigniew Jędrzejewski-Szmek  ---
I'll take the review.

> %global sum Python library to load and dump configuration files in various 
> formats
Using normal Summary: and then %summary subsequently saves one line ;)

> %global debug_package %{nil}
That looks suspicious. Why do you need this?
Package builds fine without it.

> %{__rm}
Eh, using a macro here is entirely pointless. It just makes the commands harder
to read (and longer). The guidelines say that macros should be used for some
*directories* [https://fedoraproject.org/wiki/Packaging:Guidelines#Macros], but
even that makes little sense nowadays.

> https://github.com/ssato/%{name}
I know people love macros, but this makes it impossible to just click on this
and open it in a browser… It's a matter of preference, but I don't see the
advantage of using a macro here.

> Source0:%{url}/archive/RELEASE-%{version}.tar.gz
This should be ...RELEASE_{%version}...

> %defattr(-,root,root,-)
Not necessary in Fedora and somewhat recent RHEL.

- Large documentation must go in a -doc subpackage. Large could be size
  (~1MB) or number of files.
  Note: Documentation size is 2662400 bytes in 126 files.
  See:
  http://fedoraproject.org/wiki/Packaging/Guidelines#PackageDocumentation

It'd be nice to split out a python-anyconfig-doc subpackage with the docs.


During build I see the following error:
> import cbor
> ImportError: No module named cbor
Is some dependency missing?

and later:
> toml.py:docstring of anyconfig.backend.toml.Parser._load_from_stream_fn:6: 
> WARNING: Definition list ends without a blank line; unexpected unindent.
> /builddir/build/BUILD/python-anyconfig-RELEASE_0.9.3/anyconfig/backend/xml.py:docstring
>  of anyconfig.backend.xml._tweak_ns:4: WARNING: Field list ends without a 
> blank line; unexpected unindent.
> /builddir/build/BUILD/python-anyconfig-RELEASE_0.9.3/docs/api/anyconfig.cli.rst:4:
>  WARNING: autodoc: failed to import module u'anyconfig.cli'; the following 
> exception was raised:
> Traceback (most recent call last):
>   File "/usr/lib/python2.7/site-packages/sphinx/ext/autodoc.py", line 658, in 
> import_object
> __import__(self.modname)
>   File 
> "/builddir/build/BUILD/python-anyconfig-RELEASE_0.9.3/anyconfig/cli.py", line 
> 42, in 
> sys.stdout = codecs.getwriter(_ENCODING)(sys.stdout)
>   File "/usr/lib64/python2.7/codecs.py", line 1009, in getwriter
> return lookup(encoding).streamwriter
> TypeError: lookup() argument 1 must be string, not None
> done

And now the hard part: what is the difference in behaviour or output between
anyconfig-2 and anyconfig-3?

And also (a question for upstream): why is the executable called
"anyconfig_cli" and not just "anyconfig"?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1543334] Review Request: python-xmlsec - Python bindings for the XML Security Library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1543334

Zbigniew Jędrzejewski-Szmek  changed:

   What|Removed |Added

 Status|NEW |POST
 CC||zbys...@in.waw.pl
   Assignee|nob...@fedoraproject.org|zbys...@in.waw.pl
  Flags||fedora-review+



--- Comment #1 from Zbigniew Jędrzejewski-Szmek  ---
> %global sum Python bindings for the XML Security Library
Using normal Summary: and then %summary subsequently saves one line ;)

BuildRequires should be on separate lines.
Items in %{py2_dist} too — it's too easy to miss something otherwise.

A slightly longer %description would be nice...

+ package name is OK
+ license is acceptable (MIT)
+ license is specified correctly
+ builds and installs OK
+ P/R/BR look OK
+ %python_provide macros are present
+ fedora-review finds no issues

Package is APPROVED.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org