Re: [pgadmin-hackers] pgAdmin IV- Testing framework: Enhanced Test Result Summary

[Dave Page]

Hi

On Fri, Sep 16, 2016 at 2:37 PM, Navnath Gadakh
 wrote:
> Hi Dave,
>  Please find the patch for the enhanced test result summary for testing
> framework. The code for this, was completed before drop object's
> functionality & independent from drop objects work.
> Drop objects work will take time, I am working on that for remaining nodes.
> Meanwhile, we go ahead with enhanced test summary.
>
> To run the test suite follow the commands
> 1. python regression/runtests.py --pkg browser.server_groups.servers
> 2. python regression/runtests.py --pkg
> browser.server_groups.servers.databases

I'm seeing some issues with this patch:

- There are updates to config.py and setup.py that shouldn't be there.
- I get this error at the end of a successful test run:

Test Result Summary

Regression - PG 9.4: 25 tests passed, 0 tests failed


Please check output in file:
/Users/dpage/git/pgadmin4/web/regression/regression.log
Error in atexit._run_exitfuncs:
Traceback (most recent call last):
  File 
"/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/atexit.py",
line 24, in _run_exitfuncs
func(*targs, **kargs)
  File "/Users/dpage/git/pgadmin4/web/regression/test_utils.py", line
360, in drop_objects
file_name, sys.exc_traceback.tb_lineno, exception))
Exception: test_utils.py: line:337 'NoneType' object has no attribute
'__getitem__'
Error in sys.exitfunc:
Traceback (most recent call last):
  File 
"/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/atexit.py",
line 24, in _run_exitfuncs
func(*targs, **kargs)
  File "/Users/dpage/git/pgadmin4/web/regression/test_utils.py", line
360, in drop_objects
file_name, sys.exc_traceback.tb_lineno, exception))
Exception: test_utils.py: line:337 'NoneType' object has no attribute
'__getitem__'

-- 
Dave Page
VP, Chief Architect, Tools & Installers
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

Re: [pgadmin-hackers] PATCH: To fix the issue in various node for special character (pgAdmin4)

[Dave Page]

Thanks, applied.

On Fri, Sep 16, 2016 at 3:22 PM, Murtuza Zabuawala
 wrote:
> Hi,
>
> PFA minor patch which will fix the issue where user was not able to create
> objects if parent schema has special characters in it.
> RM#1598
>
> Issue:
> We had escape special character in labels to prevent XSS Vulnerability in
> node browser tree which cause this issue.
>
>
> --
> Regards,
> Murtuza Zabuawala
> EnterpriseDB: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
>
> --
> Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgadmin-hackers
>



-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

[pgadmin-hackers] pgAdmin 4 commit: Allow creation of objects in schemas with special cha

[Dave Page]

Allow creation of objects in schemas with special chars in the name. Fixes #1598

This was caused through generation of SQL based on HTML-escaped labels, not the 
raw versions.

Branch
--
master

Details
---
http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=fc5ce22de90b214e890d330f1760ae590ccb45c4
Author: Murtuza Zabuawala 

Modified Files
--
.../databases/schemas/collations/templates/collation/js/collation.js  | 2 +-
.../foreign_tables/templates/foreign_tables/js/foreign_tables.js  | 2 +-
.../databases/schemas/sequences/templates/sequence/js/sequence.js | 2 +-
.../databases/schemas/synonyms/templates/synonym/js/synonym.js| 4 ++--
.../servers/databases/schemas/tables/templates/table/js/table.js  | 2 +-
.../servers/databases/schemas/types/templates/type/js/type.js | 2 +-
.../servers/databases/schemas/views/templates/mview/js/mview.js   | 2 +-
.../servers/databases/schemas/views/templates/view/js/view.js | 2 +-
8 files changed, 9 insertions(+), 9 deletions(-)


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

Re: [pgadmin-hackers] PATCH: To fix the performance of delete operation (pgAdmin4)

[Dave Page]

Thanks - committed with a couple of changes:

- I re-formatted the SQL
- s/lables/labels

Awesome speedup BTW - deleting 25K rows went from >10 minutes to
virtually instant. Good work.

On Fri, Sep 16, 2016 at 12:34 PM, Murtuza Zabuawala
 wrote:
> Hi Dave,
>
> Please find updated patch.
>
>
> Regards,
> Murtuza
>
> --
> Regards,
> Murtuza Zabuawala
> EnterpriseDB: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
> On Fri, Sep 16, 2016 at 3:31 PM, Dave Page  wrote:
>>
>> Can you rebase this please?
>>
>> Thanks.
>>
>> On Thu, Sep 15, 2016 at 11:08 AM, Murtuza Zabuawala
>>  wrote:
>> > Hi,
>> >
>> > PFA patch to fix the issue of slow performance while deleting rows from
>> > grid.
>> > RM#1696
>> >
>> > Issue:
>> > As per logic implemented for Backgrid, we were deleting individual rows,
>> > means If user selects 100 rows to delete then we were rendering sql
>> > template
>> > 100 times to generate sql for each individual rows and then execute all
>> > 100
>> > delete statements one by one due to which we were getting poor
>> > performance.
>> >
>> > Please review.
>> >
>> > --
>> > Regards,
>> > Murtuza Zabuawala
>> > EnterpriseDB: http://www.enterprisedb.com
>> > The Enterprise PostgreSQL Company
>> >
>> >
>> > --
>> > Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
>> > To make changes to your subscription:
>> > http://www.postgresql.org/mailpref/pgadmin-hackers
>> >
>>
>>
>>
>> --
>> Dave Page
>> Blog: http://pgsnake.blogspot.com
>> Twitter: @pgsnake
>>
>> EnterpriseDB UK: http://www.enterprisedb.com
>> The Enterprise PostgreSQL Company
>
>



-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

[pgadmin-hackers] pgAdmin 4 commit: Bulk delete rows in SlickGrid. Fixes #1696

[Dave Page]

Bulk delete rows in SlickGrid. Fixes #1696

Branch
--
master

Details
---
http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=c044af95856500bcd01284db7f6c3afc1c9a3e4f
Author: Murtuza Zabuawala 

Modified Files
--
web/pgadmin/tools/sqleditor/command.py | 27 --
.../sqleditor/templates/sqleditor/js/sqleditor.js  | 20 +++-
.../templates/sqleditor/sql/9.1_plus/delete.sql| 17 ++
3 files changed, 47 insertions(+), 17 deletions(-)


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

[pgadmin-hackers] pgAdmin 4 commit: Fix an issue where several default privileges cause e

[Dave Page]

Fix an issue where several default privileges cause error on database. Fixes 
#1670

Branch
--
master

Details
---
http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=c5f04d03c62efff8eb25c1dbc1e5283804d7de2f
Author: Murtuza Zabuawala 

Modified Files
--
.../schema/pg/9.1_plus/sql/properties.sql  | 21 ---
.../schema/pg/9.2_plus/sql/properties.sql  | 28 +---
.../schema/ppas/9.1_plus/sql/properties.sql| 21 ---
.../schema/ppas/9.2_plus/sql/properties.sql| 28 +---
.../databases/sql/9.1_plus/properties.sql  | 21 ---
.../databases/sql/9.2_plus/properties.sql  | 30 ++
.../databases/sql/9.3_plus/properties.sql  | 30 ++
7 files changed, 152 insertions(+), 27 deletions(-)


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

Re: [pgadmin-hackers] PATCH: To fix the isssue where several default privileges cause error (pgAdmin4)

[Dave Page]

Thanks, applied.

On Fri, Sep 16, 2016 at 12:17 PM, Murtuza Zabuawala
 wrote:
> Hi,
>
>
> PFA patch to fix the issue where several default privileges cause error on
> database.
> RM#1670
>
> Issue:
> There were multiple rows returned by subquery that was the issue.
>
> --
> Regards,
> Murtuza Zabuawala
> EnterpriseDB: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
>
> --
> Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgadmin-hackers
>



-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

Re: [pgadmin-hackers] [pgAdmin4][Patch]: RM1595 - "no results to fetch error" displayed if modify definition with other table

[Dave Page]

Thanks, applied.

On Fri, Sep 16, 2016 at 11:14 AM, Surinder Kumar
 wrote:
> Hi
>
> Issues fixed:
>
> 1) Creating a m-view with definition and then updating view with new
> definition, it results into an error "No results to fetch".
>
> 2) When definition of m-view is updated, it creates a new m-view with
> different OID, but it wasn't updating the old OID with new OID of tree node
> in tree view. thus on switching to another tab (e.g.: sql), it throws
> message "Cannot find materialized view".
>
> Please find attached patch and review.
>
> Thanks,
> Surinder Kumar
>
>
> --
> Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgadmin-hackers
>



-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

[pgadmin-hackers] pgAdmin 4 commit: Fix updating of matview definitions. Fixes #1595

[Dave Page]

Fix updating of matview definitions. Fixes #1595

Branch
--
master

Details
---
http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=92bc312d2dc58923c4463569edd83f8f2242304f
Author: Surinder Kumar 

Modified Files
--
.../servers/databases/schemas/views/__init__.py|  2 +-
.../browser/templates/browser/js/browser.js| 26 ++
2 files changed, 18 insertions(+), 10 deletions(-)


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

Re: [pgadmin-hackers] Lack of activity indicator over slow connections (pgadmin4)

[Magnus Hagander]

On Fri, Sep 16, 2016 at 3:35 AM, Dave Page  wrote:

> Ashesh, Murtuza, Surinder,
>
> Any thoughts on how we can achieve this easily, and where we're
> lacking notifications? We did have activity notification in the
> treeview, but that never worked overly well and now I come to think of
> it, I don't recall seeing it recently. I'm thinking we need something:
>
> - On treeview node click
>
> - On dialogue open and OK
>
> - On Wizard steps
>
> - Possibly in the debugger, when stepping?
>
> I would think all that we need is to set the mouse cursor to 'progress'.
>
>
Actually, the treeview spinner worked most of them time.  I'm not sure if
it worked all the time - I didn't check that carefully - but it did work
most of the mtime.

But basically whatever *else* I clicked was the problem. In particular
clicking the tabs out right, with the "Properties" and "SQL" tabs being the
ones I used and they were extremely slow over the high latency connection
(I measured almost 4 minutes as the worst time to load a SQL pane for a
table with 11 columns and a couple of indexes and triggers) with lack of
feedback.

-- 
 Magnus Hagander
 Me: http://www.hagander.net/
 Work: http://www.redpill-linpro.com/

[pgadmin-hackers] PATCH: To fix the issue in various node for special character (pgAdmin4)

[Murtuza Zabuawala]

Hi,

PFA minor patch which will fix the issue where user was not able to create
objects if parent schema has special characters in it.
RM#1598

*Issue:*
We had escape special character in labels to prevent XSS Vulnerability in
node browser tree which cause this issue.


--
Regards,
Murtuza Zabuawala
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


RM_1598.patch
Description: Binary data

-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

[pgadmin-hackers] pgAdmin IV- Testing framework: Enhanced Test Result Summary

[Navnath Gadakh]

Hi Dave,
 Please find the patch for the enhanced test result summary for testing
framework. The code for this, was completed before drop object's
functionality & independent from drop objects work.
Drop objects work will take time, I am working on that for remaining
nodes. Meanwhile,
we go ahead with enhanced test summary.

*To run the test suite follow the commands*
1. python regression/runtests.py --pkg browser.server_groups.servers
2. python regression/runtests.py --pkg
browser.server_groups.servers.databases


-- 
Thanks,
Navnath Gadakh
Software Engineer
EnterpriseDB Corporation
Mobile: +91 9975389878


enhanced_testresult_summary.patch
Description: Binary data

-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

Re: [pgadmin-hackers] PATCH: To fix the performance of delete operation (pgAdmin4)

[Murtuza Zabuawala]

Hi Dave,

Please find updated patch.


Regards,
Murtuza

--
Regards,
Murtuza Zabuawala
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

On Fri, Sep 16, 2016 at 3:31 PM, Dave Page  wrote:

> Can you rebase this please?
>
> Thanks.
>
> On Thu, Sep 15, 2016 at 11:08 AM, Murtuza Zabuawala
>  wrote:
> > Hi,
> >
> > PFA patch to fix the issue of slow performance while deleting rows from
> > grid.
> > RM#1696
> >
> > Issue:
> > As per logic implemented for Backgrid, we were deleting individual rows,
> > means If user selects 100 rows to delete then we were rendering sql
> template
> > 100 times to generate sql for each individual rows and then execute all
> 100
> > delete statements one by one due to which we were getting poor
> performance.
> >
> > Please review.
> >
> > --
> > Regards,
> > Murtuza Zabuawala
> > EnterpriseDB: http://www.enterprisedb.com
> > The Enterprise PostgreSQL Company
> >
> >
> > --
> > Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
> > To make changes to your subscription:
> > http://www.postgresql.org/mailpref/pgadmin-hackers
> >
>
>
>
> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>


RM_1696_v2.patch
Description: Binary data

-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

[pgadmin-hackers] PATCH: To fix the isssue where several default privileges cause error (pgAdmin4)

[Murtuza Zabuawala]

Hi,


PFA patch to fix the issue where several default privileges cause error on
database.
RM#1670

*Issue:*
There were multiple rows returned by subquery that was the issue.

--
Regards,
Murtuza Zabuawala
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


RM_1670.patch
Description: Binary data

-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

Re: [pgadmin-hackers] Sequence queries on pg_depend lacking classid filter

[Dave Page]

Thanks - committed with a minor change to remove a duplicate WHERE
clause that you added to one of the queries.

On Thu, Sep 15, 2016 at 5:22 PM, Magnus Hagander  wrote:
> There are a number of cases where queries in both pgadmin4 and pgadmin3 are
> done against pg_depend but falis to constrain the query on classid.
>
> In particular, if for example a constraint and a sequence exists with the
> same oid (which is perfectly valid, as they are in different tables), a
> column will suddenly refer sequences that are completely incorrect. When we
> look up sequences, we have to make sure we only match dependencies against
> pg_class.
>
> AFAICT, the following patch catches the important ones. I could go ahead and
> push it, but given that we're in RC I'd appreciate a round of review before
> doing that, even though it looks fairly simple.
>
> I've got the same changes in a patch to pgadmin3, as these queries are
> basically a copy/paste from there. But let's focus the review on the one for
> pgadmin4 :)
>
> --
>  Magnus Hagander
>  Me: http://www.hagander.net/
>  Work: http://www.redpill-linpro.com/
>
>
> --
> Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgadmin-hackers
>



-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

[pgadmin-hackers] pgAdmin 4 commit: Add classid filter to queries on pg_depend. Fixes #17

[Dave Page]

Add classid filter to queries on pg_depend. Fixes #1705

There are a number of cases where queries in both pgadmin4 and pgadmin3 are 
done against pg_depend but falis to constrain the query on classid.

In particular, if for example a constraint and a sequence exists with the same 
oid (which is perfectly valid, as they are in different tables), a column will 
suddenly refer sequences that are completely incorrect. When we look up 
sequences, we have to make sure we only match dependencies against pg_class.

Branch
--
master

Details
---
http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=ce20dbc25a393004c5249d946f9a85a691cacd48
Author: Magnus Hagander 

Modified Files
--
.../columns/templates/catalog_object_column/sql/9.1_plus/properties.sql | 2 +-
.../schemas/tables/templates/column/sql/9.1_plus/is_referenced.sql  | 1 +
.../databases/schemas/tables/templates/column/sql/9.1_plus/nodes.sql| 2 +-
.../schemas/tables/templates/column/sql/9.1_plus/properties.sql | 2 +-
.../schemas/tables/templates/column/sql/9.2_plus/is_referenced.sql  | 1 +
.../databases/schemas/tables/templates/column/sql/9.2_plus/nodes.sql| 2 +-
.../schemas/tables/templates/column/sql/9.2_plus/properties.sql | 2 +-
7 files changed, 7 insertions(+), 5 deletions(-)


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

Re: [pgadmin-hackers] Documentation patch for pgAdmin 4

[Dave Page]

Thanks - applied!

On Thu, Sep 15, 2016 at 3:55 PM, Susan Douglas
 wrote:
> Hi All,
>
> The attached patch contains updates to the doc files to add new dialogs, and 
> update minor changes on existing dialogs.  Let me know if there are any 
> problems!
>
> Thanks!
>
> -- Susan
>



-- 
Dave Page
VP, Chief Architect, Tools & Installers
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

[pgadmin-hackers] [pgAdmin4][Patch]: RM1595 - "no results to fetch error" displayed if modify definition with other table

[Surinder Kumar]

Hi

*Issues fixed:*

1) Creating a m-view with *definition* and then updating view with* new
definition,* it results into an error *"No results to fetch"*.

2) When definition of m-view is updated, it creates a new m-view with
different OID, but it wasn't updating the old OID with new OID of tree node
in tree view. thus on switching to another tab (e.g.: sql), it throws
message *"Cannot find materialized view"*.

Please find attached patch and review.

Thanks,
Surinder Kumar


RM1595.patch
Description: Binary data

-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

[pgadmin-hackers] pgAdmin 4 commit: Documentation update

[Dave Page]

Documentation update

Branch
--
master

Details
---
http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=3f98e6c207bc8f04497342f69718e8a2cf6ef2ec
Author: Susan Douglas 

Modified Files
--
docs/en_US/browser.rst   |   6 +--
docs/en_US/check_dialog.rst  |   3 +-
docs/en_US/collation_dialog.rst  |   2 +-
docs/en_US/images/language_definition.png| Bin 0 -> 59442 bytes
docs/en_US/images/language_general.png   | Bin 0 -> 49166 bytes
docs/en_US/images/language_security.png  | Bin 0 -> 58487 bytes
docs/en_US/images/package_code.png   | Bin 0 -> 36357 bytes
docs/en_US/images/package_general.png| Bin 0 -> 37158 bytes
docs/en_US/images/package_security.png   | Bin 0 -> 41600 bytes
docs/en_US/images/resource_group_general.png | Bin 29904 -> 42742 bytes
docs/en_US/images/resource_group_sql.png | Bin 45664 -> 73090 bytes
docs/en_US/images/synonym_general.png| Bin 0 -> 61604 bytes
docs/en_US/images/synonym_sql.png| Bin 0 -> 50758 bytes
docs/en_US/language_dialog.rst   |  69 +++
docs/en_US/managing_database_objects.rst |   5 +-
docs/en_US/package_dialog.rst|  56 ++
docs/en_US/synonym_dialog.rst|  43 +
17 files changed, 178 insertions(+), 6 deletions(-)


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

[pgadmin-hackers] pgAdmin 4 commit: Fix a syntax error when creating a trigger function o

[Dave Page]

Fix a syntax error when creating a trigger function on PPAS 9.5+. Fixes #1600

Branch
--
master

Details
---
http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=165b93a968e0f78e92260a39fd408a94ffd4a66f
Author: Surinder Kumar 

Modified Files
--
.../functions/templates/trigger_function/ppas/sql/9.5_plus/create.sql   | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

Re: [pgadmin-hackers] [pgAdmin4][Patch]: RM1600 - Trigger function is not being created in EPAS 9.6 and PPAS-9.5 server

[Dave Page]

Thanks, applied.

On Thu, Sep 15, 2016 at 1:05 PM, Surinder Kumar
 wrote:
> Hi
>
> An extra comma at the end of function statement results in Syntax Error
> while saving.
>
> Please find attached patch and review.
>
>
> Thanks,
> Surinder Kumar
>
>
> --
> Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgadmin-hackers
>



-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

Re: [pgadmin-hackers] [pgAdmin4][Patch]: RM1669 - Cannot remove nor change length definition on column in "The Table Dialog"

[Dave Page]

Thanks, committed.

On Thu, Sep 15, 2016 at 11:21 AM, Surinder Kumar
 wrote:
> Hi
>
> Please find attached patch.
>>
>> Add proper check for the column length and precision in Jinja template.
>
>
> Please review.
>
>
> Thanks,
> Surinder Kumar
>
>
> --
> Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgadmin-hackers
>



-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

[pgadmin-hackers] pgAdmin 4 commit: Fix an issue when changing the length of a column in

[Dave Page]

Fix an issue when changing the length of a column in the table dialogue. Fixes 
#1669

Branch
--
master

Details
---
http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=1ce5b38f4a099ed90f3ab8c15ebd778252fe0104
Author: Surinder Kumar 

Modified Files
--
.../schemas/tables/templates/column/sql/9.1_plus/update.sql| 7 +++
.../schemas/tables/templates/column/sql/9.2_plus/update.sql| 6 +++---
2 files changed, 6 insertions(+), 7 deletions(-)


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

Re: [pgadmin-hackers] PATCH: To fix the performance of delete operation (pgAdmin4)

[Dave Page]

Can you rebase this please?

Thanks.

On Thu, Sep 15, 2016 at 11:08 AM, Murtuza Zabuawala
 wrote:
> Hi,
>
> PFA patch to fix the issue of slow performance while deleting rows from
> grid.
> RM#1696
>
> Issue:
> As per logic implemented for Backgrid, we were deleting individual rows,
> means If user selects 100 rows to delete then we were rendering sql template
> 100 times to generate sql for each individual rows and then execute all 100
> delete statements one by one due to which we were getting poor performance.
>
> Please review.
>
> --
> Regards,
> Murtuza Zabuawala
> EnterpriseDB: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
>
> --
> Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgadmin-hackers
>



-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

Re: [pgadmin-hackers] Finalizing pgadmin4 RPM work

[Devrim Gündüz]

Hi Seçkin,

On Fri, 2016-09-16 at 11:42 +0300, Seçkin Alan wrote:
> https://git.postgresql.org/gitweb/?p=pgrpms.git;a=blob;f=rpm/redhat/9.6/pgadm
> in4/F-
> 24/pgadmin4.desktop.in;h=362c0368fe54bd9b83fa55f57458af150d7d0942;hb=ad00835b
> 6bb3615eebde2f253ebef438d3c27d48
> 
> Could you look this file ?
> 
> this variable is incorrect
> Name=pgAdmin III
> 
> Its should be
> Name=pgAdmin 4
> or
> Name=pgAdmin IV

Good catch! Fixed, thanks!

Cheers,
-- 
Devrim GÜNDÜZ
EnterpriseDB: http://www.enterprisedb.com
PostgreSQL Danışmanı/Consultant, Red Hat Certified Engineer
Twitter: @DevrimGunduz , @DevrimGunduzTR


signature.asc
Description: This is a digitally signed message part

[pgadmin-hackers] pgAdmin 4 commit: Fix an issue in the Query Tool which causes it to han

[Dave Page]

Fix an issue in the Query Tool which causes it to hang in some installations of 
Chrome 53.0.2785.116 on Mac.

This commit also modifies the Query Tool to load SlickGrid using require.js.

Branch
--
master

Details
---
http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=2f32427c59a4ad9d1969097dbaead6d7c7224f03
Author: Ashesh Vashi 

Modified Files
--
web/pgadmin/templates/base.html|  38 +-
.../sqleditor/templates/sqleditor/js/sqleditor.js  | 793 +
2 files changed, 499 insertions(+), 332 deletions(-)


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

Re: [pgadmin-hackers] Finalizing pgadmin4 RPM work

[Dave Page]

pgAdmin 4 is the correct speeling :-)

On Fri, Sep 16, 2016 at 9:42 AM, Seçkin Alan  wrote:
> Hi Devrim,
>
> https://git.postgresql.org/gitweb/?p=pgrpms.git;a=blob;f=rpm/redhat/9.6/pgadmin4/F-24/pgadmin4.desktop.in;h=362c0368fe54bd9b83fa55f57458af150d7d0942;hb=ad00835b6bb3615eebde2f253ebef438d3c27d48
>
> Could you look this file ?
>
> this variable is incorrect
> Name=pgAdmin III
>
> Its should be
> Name=pgAdmin 4
> or
> Name=pgAdmin IV
>
> Thanks.
>
> On Fri, Sep 16, 2016 at 11:17 AM, Devrim Gündüz  wrote:
>>
>> Hi,
>>
>> On Mon, 2016-09-12 at 11:46 +0100, Dave Page wrote:
>>>
>>> Awesome - thanks Devrim! I owe you a nice cool glass of spring water :-)
>>
>> \o/ Can't wait ;)
>>
>>> Let me know when packages available and ready to use, and I'll add a
>>> page to the website to point people at them.
>>
>> They are currently available for 9.6 only, on yum.postgresql.org. All testing
>> has been good so far. Feel free to add info to pgadmin website. I am planning
>> to write a short blog post about that soon, about installation instructions,
>> running, etc.
>>
>> Cheers,
>> --
>> Devrim GÜNDÜZ
>> EnterpriseDB: http://www.enterprisedb.com
>> PostgreSQL Danışmanı/Consultant, Red Hat Certified Engineer
>> Twitter: @DevrimGunduz , @DevrimGunduzTR
>
>
>
> --
> Seçkin ALAN
> http://sckn.org



-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

Re: [pgadmin-hackers] Finalizing pgadmin4 RPM work

[Seçkin Alan]

Hi Devrim,

https://git.postgresql.org/gitweb/?p=pgrpms.git;a=blob;f=rpm/redhat/9.6/pgadmin4/F-24/pgadmin4.desktop.in;h=362c0368fe54bd9b83fa55f57458af150d7d0942;hb=ad00835b6bb3615eebde2f253ebef438d3c27d48

Could you look this file ?

this variable is incorrect
Name=pgAdmin III

Its should be
Name=pgAdmin 4
or
Name=pgAdmin IV

Thanks.

On Fri, Sep 16, 2016 at 11:17 AM, Devrim Gündüz  wrote:
>
> Hi,
>
> On Mon, 2016-09-12 at 11:46 +0100, Dave Page wrote:
>>
>> Awesome - thanks Devrim! I owe you a nice cool glass of spring water :-)
>
> \o/ Can't wait ;)
>
>> Let me know when packages available and ready to use, and I'll add a
>> page to the website to point people at them.
>
> They are currently available for 9.6 only, on yum.postgresql.org. All testing
> has been good so far. Feel free to add info to pgadmin website. I am planning
> to write a short blog post about that soon, about installation instructions,
> running, etc.
>
> Cheers,
> --
> Devrim GÜNDÜZ
> EnterpriseDB: http://www.enterprisedb.com
> PostgreSQL Danışmanı/Consultant, Red Hat Certified Engineer
> Twitter: @DevrimGunduz , @DevrimGunduzTR



-- 
Seçkin ALAN
http://sckn.org


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

Re: [pgadmin-hackers] Lack of activity indicator over slow connections (pgadmin4)

[Dave Page]

Ashesh, Murtuza, Surinder,

Any thoughts on how we can achieve this easily, and where we're
lacking notifications? We did have activity notification in the
treeview, but that never worked overly well and now I come to think of
it, I don't recall seeing it recently. I'm thinking we need something:

- On treeview node click

- On dialogue open and OK

- On Wizard steps

- Possibly in the debugger, when stepping?

I would think all that we need is to set the mouse cursor to 'progress'.

Thoughts?

On Thu, Sep 15, 2016 at 3:50 PM, Magnus Hagander  wrote:
> I've been using pgadmin4 a bit recently over really slow and in particular
> long-latency connections (double-vpns across the atlantic..)
>
> What I've noticed is that there appears to be zero feedback while things are
> running. In this case, the slow link was between pgadmin4 and the database
> it's connected do, but I'd expect similar issues when it's pgadmin that's
> far away from the browser.
>
> Basically, clicking on a node in the tree, it took 15-20 seconds before the
> SQL pane updated (or the properties pane). During this time, there is *zero*
> feedback that something is going on, unless I open up developer mode. Which,
> in fact, I did a couple of times to look at the console thinking it had
> crashed rather than was just doing something.
>
> In my case I did the "classic end user" and ended up clicking at a couple of
> different things to see if anything works at all, which of course made
> things even more confusing. But that's exactly the kind of thing that end
> users will do.
>
> I think that's going to cause a *lot* of confusion. There should really be
> *some* level of feedback.
>
> I think a very good choice would be if it's possible to make it do nothing
> by default but if a request takes more than say 1 second, a spinner can show
> up to show that it's actually *doing* something.
>
> --
>  Magnus Hagander
>  Me: http://www.hagander.net/
>  Work: http://www.redpill-linpro.com/



-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

Re: [pgadmin-hackers] Finalizing pgadmin4 RPM work

[Devrim Gündüz]

Hi,

On Mon, 2016-09-12 at 11:46 +0100, Dave Page wrote:
> 
> Awesome - thanks Devrim! I owe you a nice cool glass of spring water :-)

\o/ Can't wait ;)

> Let me know when packages available and ready to use, and I'll add a
> page to the website to point people at them.

They are currently available for 9.6 only, on yum.postgresql.org. All testing
has been good so far. Feel free to add info to pgadmin website. I am planning
to write a short blog post about that soon, about installation instructions,
running, etc.

Cheers,
-- 
Devrim GÜNDÜZ
EnterpriseDB: http://www.enterprisedb.com
PostgreSQL Danışmanı/Consultant, Red Hat Certified Engineer
Twitter: @DevrimGunduz , @DevrimGunduzTR


signature.asc
Description: This is a digitally signed message part

Re: [pgadmin-hackers] python-click dependency

[Devrim Gündüz]

Hi,

On Mon, 2016-09-12 at 09:21 +0100, Dave Page wrote:
> Ah, OK - added to requirements.

Thanks dude!

Cheers,
-- 
Devrim GÜNDÜZ
EnterpriseDB: http://www.enterprisedb.com
PostgreSQL Danışmanı/Consultant, Red Hat Certified Engineer
Twitter: @DevrimGunduz , @DevrimGunduzTR


signature.asc
Description: This is a digitally signed message part