D11253: Add the word "Wallpaper" into the context and Toolbox menus to help users figure out how to change the wallpaper

[Richard Bowen]

richardbowen added a comment.


  I wonder if one should dumb down the interface to accommodate this word 
scanning habit, where one doesn't really read stuff one just scans the screen 
for a keyword and then gets frustrated when the keyword (like "Wallpaper") 
doesn't show up . Well if it works then fine. The proposed text is quite long 
though.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D11253

To: ngraham, #plasma, davidedmundson
Cc: richardbowen, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D11253: Add the word "Wallpaper" into the context and Toolbox menus to help users figure out how to change the wallpaper

[Nathaniel Graham]

ngraham added a comment.


  In D11253#223747 , @richardbowen 
wrote:
  
  > Windows has the word "Personalize" which is quite descriptive. "Customize 
Desktop" sounds fine as well. but I think the word "Configure" is used more 
often throughtout the Plasma desktop.
  >
  > How often do you see users complaining about not knowing how to set the 
wallpaper?
  
  
  Often. Here's an example I just stumbled upon tonight: 
https://www.reddit.com/r/gnome/comments/8360xr/gnome_is_design/dvh9reu/
  
  > They also throw so many functionalities at your face, but basic things like 
right-click and set as wallpaper is not there. Kde was built by developers for 
developers.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D11253

To: ngraham, #plasma, davidedmundson
Cc: richardbowen, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D11253: Add the word "Wallpaper" into the context and Toolbox menus to help users figure out how to change the wallpaper

[Richard Bowen]

richardbowen added a comment.


  Windows has the word "Personalize" which is quite descriptive. "Customize 
Desktop" sounds fine as well. but I think the word "Configure" is used more 
often throughtout the Plasma desktop.
  
  How often do you see users complaining about not knowing how to set the 
wallpaper? If they know what a desktop is then they should be able to figure it 
out. Similar to Windows it is accessed via a right click context menu.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D11253

To: ngraham, #plasma, davidedmundson
Cc: richardbowen, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D11253: Add the word "Wallpaper" into the context and Toolbox menus to help users figure out how to change the wallpaper

[Nathaniel Graham]

ngraham created this revision.
ngraham added reviewers: Plasma, davidedmundson.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
ngraham requested review of this revision.

REVISION SUMMARY
  It comes up a lot online that users have difficulty figuring out how to 
change the wallpaper. Yes, really! I'm serious! This baffles people like us 
because there's a totally simple way: right-click on the Desktop or left-click 
on the Desktop Toolbox and choose "Configure Desktop". However since that menu 
item doesn't have the word "Wallpaper" in it, a lot of users never seem to make 
the mental leap that Wallpapers are associated with the Desktop, and instead 
conclude that there's no way to change the wallpaper, since they can't find it 
in System Settings, either.
  
  This patch updates the menu item to add the word "Wallpaper", making the 
presence of the feature hugely more obvious.
  
  CCBUG: 391485

TEST PLAN
  Now more obvious in the Desktop Toolbox menu:
  
  Now more obvious in the context menu:

REPOSITORY
  R119 Plasma Desktop

BRANCH
  add-the-word-wallpaper-so-people-actually-get-it (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D11253

AFFECTED FILES
  containments/desktop/package/contents/ui/main.qml

To: ngraham, #plasma, davidedmundson
Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D11233: Ordered system tray

[Nathaniel Graham]

ngraham added a comment.


  In D11233#223661 , @broulik wrote:
  
  > Drag and drop might be an acceptable way to rearrange them but then I think 
we should just have a smarter more predictable sorting logic (currently it's on 
a first come first serve basis) and the need for this should go away.
  
  
  ...As long as we can ensure that things come and are served in the same order 
every time, because muscle memory is important.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D11233

To: wsdfhjxc, #plasma_workspaces, #plasma, #vdg
Cc: broulik, ngraham, anthonyfieroni, Pitel, alexeymin, plasma-devel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D11214: Don't let the selection text overlap the Update button

[Nathaniel Graham]

ngraham added a comment.


  So you prefer this one to D11218 ? Note 
that we do lose the "n updates not selected" text with this approach.

REPOSITORY
  R134 Discover Software Store

BRANCH
  never-overlap-update-button (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D11214

To: ngraham, #discover_software_store, apol
Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D11233: Ordered system tray

[Kai Uwe Broulik]

broulik added a comment.


  Before the rewrite in Plasma 5.7 System Tray icons were automatically sorted 
based on their type (e.g. Hardware stuff, applications, Status indicators) so 
the positions were somewhat consistent. I don't really like the idea of adding 
a huge save and restoration logic to an already fragile codebase, let alone 
arrows to rearrange them manually.
  
  Drag and drop might be an acceptable way to rearrange them but then I think 
we should just have a smarter more predictable sorting logic (currently it's on 
a first come first serve basis) and the need for this should go away.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D11233

To: wsdfhjxc, #plasma_workspaces, #plasma, #vdg
Cc: broulik, ngraham, anthonyfieroni, Pitel, alexeymin, plasma-devel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D11180: Reverse tooltip colors for Breeze colorscheme

[Kai Uwe Broulik]

broulik added a comment.


  I also prefer the higher contrast of dark tooltips. There shouldn't be any 
action/symbolic dark icons in tooltips to begin with. Fonts has a different 
icon for me here but that might be a high-di issue. How about we "fix" System 
Settings to use the Selected icon state for tooltip icons, that will use the 
highlighted one like in hovered menu items. That might cause issues in other 
configurations then but it fixes the default case.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D11180

To: rwurth, #breeze
Cc: broulik, progwolff, ngraham, rwurth, plasma-devel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

[Powerdevil] [Bug 362831] Do not increase brightness when entering low battery mode

[Nate Graham]

https://bugs.kde.org/show_bug.cgi?id=362831

Nate Graham  changed:

   What|Removed |Added

 CC||shaloksha...@protonmail.ch

--- Comment #7 from Nate Graham  ---
*** Bug 381387 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Powerdevil] [Bug 306425] Screen brightness reset to max after login

[Nate Graham]

https://bugs.kde.org/show_bug.cgi?id=306425

Nate Graham  changed:

   What|Removed |Added

 CC||mklape...@kde.org

--- Comment #8 from Nate Graham  ---
*** Bug 357045 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Powerdevil] [Bug 357045] Remember brigthness level between logins

[Nate Graham]

https://bugs.kde.org/show_bug.cgi?id=357045

Nate Graham  changed:

   What|Removed |Added

 Resolution|--- |DUPLICATE
 CC||n...@kde.org
 Status|UNCONFIRMED |RESOLVED

--- Comment #2 from Nate Graham  ---
Right, just uncheck the "Screen Brightness" setting, and then powerdevil won't
mess with your brightness level at all.

*** This bug has been marked as a duplicate of bug 306425 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Powerdevil] [Bug 306425] Screen brightness reset to max after login

[Nate Graham]

https://bugs.kde.org/show_bug.cgi?id=306425

Nate Graham  changed:

   What|Removed |Added

 CC||bugs.kde@falkensweb.com

--- Comment #7 from Nate Graham  ---
*** Bug 350258 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Powerdevil] [Bug 350258] Screen brightness is not remembered

[Nate Graham]

https://bugs.kde.org/show_bug.cgi?id=350258

Nate Graham  changed:

   What|Removed |Added

 Status|CONFIRMED   |RESOLVED
 CC||n...@kde.org
 Resolution|--- |DUPLICATE

--- Comment #8 from Nate Graham  ---
Just uncheck the "Brightness" checkboxes and then Powerdevil won't override
your brightness settings on login. This works flawlessly for me in 5.12.3.

*** This bug has been marked as a duplicate of bug 306425 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Powerdevil] [Bug 362831] Do not increase brightness when entering low battery mode

[Nate Graham]

https://bugs.kde.org/show_bug.cgi?id=362831

--- Comment #6 from Nate Graham  ---
LOL! I mean 5.12.3, of course.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Powerdevil] [Bug 362831] Do not increase brightness when entering low battery mode

[Piotr Kloc]

https://bugs.kde.org/show_bug.cgi?id=362831

--- Comment #5 from Piotr Kloc  ---
(In reply to Nate Graham from comment #3)
> Can confirm with Plasma 5.13.3 that when the brightness is lower than the
> level set for low battery mode, the brightness is not increased when
> entering low battery mode.

May I have some time with your time machine, please?

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Powerdevil] [Bug 306425] Screen brightness reset to max after login

[Nate Graham]

https://bugs.kde.org/show_bug.cgi?id=306425

Nate Graham  changed:

   What|Removed |Added

 CC||n...@kde.org
 Status|UNCONFIRMED |RESOLVED
 Resolution|--- |FIXED

--- Comment #6 from Nate Graham  ---
Can't reproduce in Plasma 5.13.3: If I set the brightness to some arbitrary
level, uncheck the Brightness checkboxes in Powerdevil, and then reboot, the
system come up at whatever brightness level it had when I rebooted it.

-- 
You are receiving this mail because:
You are the assignee for the bug.

D11233: Ordered system tray

[Nathaniel Graham]

ngraham added a comment.


  Conceptually, +1 from me. No comment about the code.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D11233

To: wsdfhjxc, #plasma_workspaces, #plasma, #vdg
Cc: ngraham, anthonyfieroni, Pitel, alexeymin, plasma-devel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

[Powerdevil] [Bug 371514] Ambiguous "Wireless power saving" in Energy Saving

[Nate Graham]

https://bugs.kde.org/show_bug.cgi?id=371514

Nate Graham  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 CC||n...@kde.org
 Status|UNCONFIRMED |RESOLVED

--- Comment #2 from Nate Graham  ---
It's powerdevil. The UI has been improved here to just say "Wireless" as a
category header, and there are individual entries with more descriptive names.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Powerdevil] [Bug 377046] Switch brightness levels smoothly, not instantaneously

[Nate Graham]

https://bugs.kde.org/show_bug.cgi?id=377046

Nate Graham  changed:

   What|Removed |Added

   Severity|normal  |wishlist
 CC||n...@kde.org
Summary|smooth brightness switch|Switch brightness levels
   ||smoothly, not
   ||instantaneously
   Keywords||junior-jobs

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Powerdevil] [Bug 362831] Do not increase brightness when entering low battery mode

[Nate Graham]

https://bugs.kde.org/show_bug.cgi?id=362831

Nate Graham  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 Status|UNCONFIRMED |RESOLVED
 CC||n...@kde.org

--- Comment #3 from Nate Graham  ---
Can confirm with Plasma 5.13.3 that when the brightness is lower than the level
set for low battery mode, the brightness is not increased when entering low
battery mode.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Powerdevil] [Bug 377673] Brightness gets brighter when low battery

[Nate Graham]

https://bugs.kde.org/show_bug.cgi?id=377673

Nate Graham  changed:

   What|Removed |Added

 Resolution|--- |DUPLICATE
 CC||n...@kde.org
 Status|UNCONFIRMED |RESOLVED

--- Comment #2 from Nate Graham  ---


*** This bug has been marked as a duplicate of bug 362831 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Powerdevil] [Bug 362831] Do not increase brightness when entering low battery mode

[Nate Graham]

https://bugs.kde.org/show_bug.cgi?id=362831

Nate Graham  changed:

   What|Removed |Added

 CC||frmdst...@gmail.com

--- Comment #4 from Nate Graham  ---
*** Bug 377673 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.

D11180: Reverse tooltip colors for Breeze colorscheme

[Nathaniel Graham]

ngraham added a comment.


  Would you mind using standard Breeze colors and shadows when posting 
screenshots that depict visual changes? That makes it easier to see what's 
actually been changed.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D11180

To: rwurth, #breeze
Cc: progwolff, ngraham, rwurth, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D11233: Ordered system tray

[Wojciech Stachurski]

wsdfhjxc updated this revision to Diff 29275.
wsdfhjxc added a comment.


  - Squashed commit of the following:
  - Use theme based icons instead of char glyph labels for buttons
  - Use QRegularExpression instead of QRegExp

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11233?vs=29236=29275

BRANCH
  ordered-systemtray

REVISION DETAIL
  https://phabricator.kde.org/D11233

AFFECTED FILES
  applets/systemtray/package/contents/config/main.xml
  applets/systemtray/package/contents/ui/ConfigEntries.qml
  applets/systemtray/package/contents/ui/items/AbstractItem.qml
  applets/systemtray/package/contents/ui/items/StatusNotifierItem.qml
  applets/systemtray/package/contents/ui/main.qml
  applets/systemtray/systemtray.cpp
  applets/systemtray/systemtray.h

To: wsdfhjxc, #plasma_workspaces, #plasma, #vdg
Cc: ngraham, anthonyfieroni, Pitel, alexeymin, plasma-devel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D11240: Introduce a new config entry for auto and shown item ordered list

[Wojciech Stachurski]

wsdfhjxc abandoned this revision.
wsdfhjxc added a comment.


  Sorry, I've messed something while playing with Arcanist.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D11240

To: wsdfhjxc
Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D11240: Introduce a new config entry for auto and shown item ordered list

[Wojciech Stachurski]

wsdfhjxc created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
wsdfhjxc requested review of this revision.

REVISION SUMMARY
  Introduce a new abstract item ordered list position property
  
  Provide a method for registering an item in the ordered item list
  
  Place active items in the visible tray at their remembered positions
  
  Register an active item in the ordered list if it isn't there yet
  
  Try to update the item order and visibility if its position changes
  
  Add the new config entry reference
  
  Add global buffers for shown, hidden and ordered items
  
  Add methods for initializing, accessing and rearranging items
  
  Add methods for saving the items in config
  
  Initialize and swap table content data retrieving method
  
  Create a new table column with positioning controls
  
  Use item buffers to determinate the current item state
  
  Use proper methods for switching the item state
  
  Visually distinct disabled (yet present) items
  
  Fix indentation
  
  Implement regexp based item id trimming
  
  Make position property read only
  
  Remove unnecessary conditional skip
  
  Wait for proper item id before registering it
  
  Prevent pushing idless items into configuration list
  
  Reimplement support for dynamically updated configuration
  
  Move timer definition
  
  Remove redundant method calls
  
  Update the config page on delayed notifier appearance
  
  Change positioning buttons ids
  
  Change disabled property name to inactive
  
  Put forced model view refresh code into a function
  
  Add an option to forget inactive item entries
  
  Revert "Update the config page on delayed notifier appearance"
  
  This reverts commit 6ee666c777501a9d7c554c59375ae6b77d3d518a.
  
  Keep reloading the item config entries until idless items get ids
  
  Merge branch 'master' into systemtray-ordered
  
  Don't bother with hidden state if all items are force shown
  
  Fix item list view scroll after moving an item
  
  Use theme based icons instead of char glyph labels for buttons
  
  Use QRegularExpression instead of QRegExp

REPOSITORY
  R120 Plasma Workspace

BRANCH
  systemtray-ordered

REVISION DETAIL
  https://phabricator.kde.org/D11240

AFFECTED FILES
  applets/systemtray/package/contents/config/main.xml
  applets/systemtray/package/contents/ui/ConfigEntries.qml
  applets/systemtray/package/contents/ui/items/AbstractItem.qml
  applets/systemtray/package/contents/ui/items/StatusNotifierItem.qml
  applets/systemtray/package/contents/ui/main.qml
  applets/systemtray/systemtray.cpp
  applets/systemtray/systemtray.h

To: wsdfhjxc
Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D11233: Ordered system tray

[Anthony Fieroni]

anthonyfieroni added inline comments.

INLINE COMMENTS

> ConfigEntries.qml:464
> +  (shownAutoItems[0].taskId != modelData.taskId))
> +text: "▲"
> +width: 30

icon: "arrow-up"

> ConfigEntries.qml:478
> +   != modelData.taskId))
> +text: "▼"
> +width: 30

icon: "arrow-down"

> systemtray.cpp:589
> +for (auto  : itemIdTrimmingRegExpRules) {
> +result = itemId.remove(QRegExp(regExp));
> +if (!QString::compare(result, itemId)) {

Use QRegularExpression instead

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D11233

To: wsdfhjxc, #plasma_workspaces, #plasma, #vdg
Cc: anthonyfieroni, Pitel, alexeymin, plasma-devel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D11065: [Active Window Control] Slightly fix vertical alignment of window name

[Andres Betts]

abetts added a comment.


  +1

REPOSITORY
  R884 Active Window Control Applet for Plasma

BRANCH
  realign

REVISION DETAIL
  https://phabricator.kde.org/D11065

To: Pitel, #plasma, martinkostolny
Cc: abetts, broulik, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, sebas, apol, mart

D11235: [DrKonqi] Request change of ptrace scope from KCrash

[Christoph Roick]

croick added inline comments.

INLINE COMMENTS

> crashtest.cpp:138
>  
> -  //start drkonqi directly so that drkonqi's output goes to the console
> -  KCrash::CrashFlags flags = KCrash::AlwaysDirectly;

That reasoning does not seem to be true. The output can still be read when 
started "normally".

REPOSITORY
  R871 DrKonqi

REVISION DETAIL
  https://phabricator.kde.org/D11235

To: croick, #plasma_workspaces, #frameworks
Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D11235: [DrKonqi] Request change of ptrace scope from KCrash

[Christoph Roick]

croick updated this revision to Diff 29249.
croick added a comment.


  - remove superfluous include

REPOSITORY
  R871 DrKonqi

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11235?vs=29247=29249

BRANCH
  ptracer

REVISION DETAIL
  https://phabricator.kde.org/D11235

AFFECTED FILES
  src/CMakeLists.txt
  src/debuggerlaunchers.cpp
  src/debuggerlaunchers.h
  src/queryptrace.cpp
  src/queryptrace.h
  src/tests/crashtest/crashtest.cpp

To: croick, #plasma_workspaces, #frameworks
Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D11065: [Active Window Control] Slightly fix vertical alignment of window name

[Martin Kostolný]

martinkostolny accepted this revision.
martinkostolny added a comment.
This revision is now accepted and ready to land.


  Perfect, thanks!

REPOSITORY
  R884 Active Window Control Applet for Plasma

BRANCH
  realign

REVISION DETAIL
  https://phabricator.kde.org/D11065

To: Pitel, #plasma, martinkostolny
Cc: broulik, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D11235: [DrKonqi] Request change of ptrace scope from KCrash

[Christoph Roick]

croick created this revision.
croick added reviewers: Plasma: Workspaces, Frameworks.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
croick requested review of this revision.

REVISION SUMMARY
  - In Linux recent kernels only allow attaching of processes to a debugger, if
- the right to attach to processes is enabled system-wide
- the debugger is a child process of the debuggee
- or the debuggee grants access by a call to prctl(PR_SET_PTRACER, 
debugger_pid, 0, 0, 0);
  - DrKonqi cannot do this directly, so it will ask the debuggee to do so by a 
socket connection.
  - When the debugger has finished, the access is requested back to DrKonqi to 
allow internal backtraces again.

TEST PLAN
  - try to attach the debugged process to gdb or KDevelop by using the debug 
button: operation will not be permitted
  - apply corresponding patches to KCrash and DrKonqi
  - the process can now be debugged
  - after detaching the process again, a backtrace can be created using the 
DrKonqi dialog as usual

REPOSITORY
  R871 DrKonqi

BRANCH
  ptracer

REVISION DETAIL
  https://phabricator.kde.org/D11235

AFFECTED FILES
  src/CMakeLists.txt
  src/debuggerlaunchers.cpp
  src/debuggerlaunchers.h
  src/queryptrace.cpp
  src/queryptrace.h
  src/tests/crashtest/crashtest.cpp

To: croick, #plasma_workspaces, #frameworks
Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D11234: [DrKonqi] Show debug button when KDevelop session is running

[Christoph Roick]

croick created this revision.
croick added reviewers: Plasma: Workspaces, apol, mwolff.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
croick requested review of this revision.

REVISION SUMMARY
  - independently of the config setting in drkonqirc propose debugging with 
KDevelop if a session is available
  - default debugger is only displayed if ShowDebugButton=true in [DrKonqi]
  - button is the first action button to be displayed
  - fix adding/removing of the button to the button box

TEST PLAN
  - set ShowDebugButton=false, have no KDevelop session running
  - force a crash (using src/tests/crashtest for instance)
  - DrKonqi shows no debug button
  - start a KDevelop session
  - the button appears with the KDevelop session selectable
  - quit DrKonqi, set ShowDebugButton=true
  - crash again, the button now always is visible, including the default 
debugger as a selection

REPOSITORY
  R871 DrKonqi

BRANCH
  nicebutton

REVISION DETAIL
  https://phabricator.kde.org/D11234

AFFECTED FILES
  src/drkonqidialog.cpp

To: croick, #plasma_workspaces, apol, mwolff
Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D11233: Ordered system tray

[Wojciech Stachurski]

wsdfhjxc created this revision.
wsdfhjxc added a reviewer: Plasma: Workspaces.
wsdfhjxc added a project: Plasma: Workspaces.
Restricted Application edited projects, added Plasma; removed Plasma: 
Workspaces.
Restricted Application added a subscriber: plasma-devel.
wsdfhjxc requested review of this revision.

REVISION SUMMARY
  Hello.
  
  I've switched to Plasma quite recently and I'm really liking it, but the one 
thing that irritates me a little bit is the system tray not remembering its 
item positions. This results in a random icon placement, mostly for 
applications other than embedded plasmoids (e.g. KMail, Dropbox, Redshift and 
other StatusNotifier items), at every boot. I guess this behavior doesn't seem 
to be an issue for most users, as there is not much community pressure on this 
one, but only a couple of topics I've found on Reddit and maybe another single 
one on KDE Community Forums. Still, the system tray feels more comfortable to 
use if it can be consistent all the time and if its items can be placed the way 
one wants to, as it may have influence on workflow and desktop's visual 
aesthetics. Furthermore, even Microsoft Windows allows system tray item order 
configuration.
  
  Having said that, I've done some research and managed to get the system tray 
positioning and configuration changed in a few places, so it remembers item 
positions and lets the user manually arrange the order of non-hidden items. In 
short, a new config list-type property is introduced to store all items with 
shown or auto visibility state and in user defined order. Items that are no 
longer loaded (and which are inactive at a time) are also remembered, so they 
can be positioned properly when they are loaded eventually. The elements tab in 
system tray settings contains positioning buttons for each non-hidden item in 
the list. The item list is refreshed every time a new plasmoid or 
StatusNotifier is registered or unregistered (well, maybe not every time, there 
is still some inconsistency). The overall result of the above changes is 
visible in the video attached below.
  
  F5749559: Ordered system tray.mp4 
  
  Now, I obviously do realize that this patch in its form is unacceptable to 
get into upstream, as its all hackish workaround to an existing system tray 
codebase. Honestly, my intention here is not really to contribute code of 
dubious quality, but to indicate the issue and provide some ideas and a working 
example to resolve it. I hope you will investigate this further at some point 
of Plasma development and maybe someone with appropriate knowledge and skills 
will consider implementing such a mechanism in a proper way, so the users could 
benefit from it.
  
  Thanks in advance!
  
  (BTW, both Kubuntu 17.10 with backports and KDE Neon Developer Edition seem 
to suffer from plasmashell crash after closing the system tray configuration 
window with elements tab beign open and clicking on any plasmoid in system tray 
afterwards. This is probably caused by bug 383828)

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D11233

AFFECTED FILES
  applets/systemtray/package/contents/config/main.xml
  applets/systemtray/package/contents/ui/ConfigEntries.qml
  applets/systemtray/package/contents/ui/items/AbstractItem.qml
  applets/systemtray/package/contents/ui/items/StatusNotifierItem.qml
  applets/systemtray/package/contents/ui/main.qml
  applets/systemtray/systemtray.cpp
  applets/systemtray/systemtray.h

To: wsdfhjxc, #plasma_workspaces
Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D3484: Center systemmonitor window properly on multi-screen setup

[Valeriy Malov]

This revision was not accepted when it landed; it landed in state "Needs 
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit R120:ad5b9e98b1f2: Center systemmonitor window properly on 
multi-screen setup (authored by valeriymalov).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D3484?vs=29239=29240

REVISION DETAIL
  https://phabricator.kde.org/D3484

AFFECTED FILES
  systemmonitor/ksystemactivitydialog.cpp
  systemmonitor/ksystemactivitydialog.h

To: valeriymalov, #plasma_workspaces, aacid, mart
Cc: davidedmundson, sebas, aacid, graesslin, plasma-devel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, apol, mart

D3484: Center systemmonitor window properly on multi-screen setup

[Valeriy Malov]

valeriymalov updated this revision to Diff 29239.
valeriymalov added a comment.


  another rebase

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D3484?vs=28410=29239

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D3484

AFFECTED FILES
  systemmonitor/ksystemactivitydialog.cpp
  systemmonitor/ksystemactivitydialog.h

To: valeriymalov, #plasma_workspaces, aacid, mart
Cc: davidedmundson, sebas, aacid, graesslin, plasma-devel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, apol, mart

D11180: Reverse tooltip colors for Breeze colorscheme

[Richard Wurth]

rwurth added a comment.


  I think they both look fine, this is just a suggestion because the icons 
aren't showing up. I tested this a little further and it looks like if a change 
were to be made it would probably also need to be applied to the breeze gtk 
theme as the qt breeze colors aren't applied to the gtk counterparts. Another 
solutions would be to not use monochrome icons in tooltips, or to use the 
correct ones based on the background color.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D11180

To: rwurth, #breeze
Cc: progwolff, ngraham, rwurth, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D11180: Reverse tooltip colors for Breeze colorscheme

[Julian Wolff]

progwolff added a comment.


  I remember that the dark tooltips felt strange to me when I started using 
breeze.
  Now that I am used to it, I actually prefer the dark tooltips because of 
their high contrast to the other GUI elements.
  
  But as breeze dark uses dark tooltips too, this change seems reasonable and 
should fix the issue. (Breeze icons will never be too light, as they would be 
invisible on the usual GUI elements then.)
  
  Could you give WindowBackground (239,240,241) and WindowText (35,38,39) a 
try? Breeze dark uses them too, and in my opinion the resulting tooltip stands 
out a little more.
  
  #VDG  What do you think?

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D11180

To: rwurth, #breeze
Cc: progwolff, ngraham, rwurth, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

[Powerdevil] [Bug 365100] Power button ignored

[Gordan Krešić]

https://bugs.kde.org/show_bug.cgi?id=365100

--- Comment #4 from Gordan Krešić  ---
Plasma 5.12.2, Kubuntu 17.10, bug is still here.

I can provide any additional info, if someone tell me what is needed.

Laptop is rather common: ThinkPad T460p.

-- 
You are receiving this mail because:
You are the assignee for the bug.

D7537: KDE logout screen - change black icons & texts to white/greyish

[Radek Hušek]

Pitel added a comment.


  I guess I am not that confused anymore -- with normal color group the color 
of text (outside of buttons) is determined by text color theme setting but with 
complementary group by button text color.
  
  I think correct solution would be to construct `ColorScope` with `textColor` 
set to default text color if it is not too dark and white otherwise (the 
background color is handled in similar way). The problem is I do not see any 
way to construct `ColorScope` with custom colors -- it always takes colors from 
some color group of current theme.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D7537

To: pekkah, #plasma_workspaces, #plasma, #breeze, mart
Cc: Pitel, mvourlakos, ngraham, mart, bshah, #breeze, pekkah, 
#plasma_workspaces, plasma-devel, #plasma, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol

D7537: KDE logout screen - change black icons & texts to white/greyish

[Radek Hušek]

Pitel added a comment.


  @mvourlakos I did some more testing and I am really confused. The important 
color seems to be button text color in Plasma theme setting. Results:
  
  With `colorGroup: PlasmaCore.Theme.ComplementaryColorGroup` (which is 
currently hardcoded):
  
  - with white button text color: all text is white -- OK
  - with black button text color: all text is black -- not OK for text outside 
of buttons
  
  With `colorGroup: PlasmaCore.Theme.NormalColorGroup` (or just deleting 
`colorGroup` property):
  
  - with white button text color: all text is white -- OK
  - with black button text color: text on buttons is black, other text is white 
-- OK
  
  I have no idea why button text color affects color of text outside of buttons 
with Complementary color group but does not affect it with Normal.
  
  (By buttons I mean OK and Cancel who draw their backgrounds.)

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D7537

To: pekkah, #plasma_workspaces, #plasma, #breeze, mart
Cc: Pitel, mvourlakos, ngraham, mart, bshah, #breeze, pekkah, 
#plasma_workspaces, plasma-devel, #plasma, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol

D7537: KDE logout screen - change black icons & texts to white/greyish

[Michail Vourlakos]

mvourlakos added a comment.


  @Pitel how did you manage to reproduce this, with what color theme? In my 
system logout screen always appears whitish in master branch

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D7537

To: pekkah, #plasma_workspaces, #plasma, #breeze, mart
Cc: Pitel, mvourlakos, ngraham, mart, bshah, #breeze, pekkah, 
#plasma_workspaces, plasma-devel, #plasma, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol