D11533: [kstyle] create shadow tiles more explicitly

[Vlad Zagorodniy]

zzag added a comment.


  Well, after thinking for a while, I think shadowTiles should be called in 
loadConfig. It doesn't make much sense to create something in reset method.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D11533

To: zzag, #breeze, hpereiradacosta
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D9792: even slimmer scrollbars

[Vlad Zagorodniy]

zzag added a comment.


  I'm sorry, but these scrollbars have too thin sliders.
  
  F5801991: scrollbar.png 
  
  Slider occupies only 15% of space in horizontal direction, that's a "big" 
waste of space.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D9792

To: mart, #plasma, #kirigami, #vdg, hpereiradacosta, abetts
Cc: zzag, rikmills, davidedmundson, ngraham, colomar, abetts, plasma-devel, 
ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, 
mart, hein

D11533: [kstyle] create shadow tiles more explicitly

[Vlad Zagorodniy]

zzag updated this revision to Diff 31774.
zzag added a comment.


  Call shadowTiles in the reset method.

REPOSITORY
  R31 Breeze

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11533?vs=30066=31774

BRANCH
  explicit-shadow-creation

REVISION DETAIL
  https://phabricator.kde.org/D11533

AFFECTED FILES
  kstyle/breezeshadowhelper.cpp

To: zzag, #breeze, hpereiradacosta
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D12069: Implement a keyboard selector plasmoid

[Eike Hein]

hein added a comment.


  Dated shots but relevant: 
https://blogs.gnome.org/mclasen/2012/09/21/input-sources-in-gnome/

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D12069

To: apol, #plasma
Cc: hein, graesslin, broulik, davidedmundson, plasma-devel, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D12069: Implement a keyboard selector plasmoid

[Eike Hein]

hein added a comment.


  In D12069#243315 , @davidedmundson 
wrote:
  
  > Is that something that can happen now?
  
  
  We have a GSoC project in the Ideas list this year that's aimed at it, and 
there are other Linux desktops that prove it's possible (e.g. Gnome has this).
  
  The goal is to evolve the keyboard settings in System Settings towards 
managing input languages, the way it's done in the products of most of our 
competitors (both free and proprietary). The general workflow is to add an 
input language, then select the keyboard layout for it. This is incidentally 
exactly how the config UI for something like ibus/fcitx works. In Plasma, 
currently you need to reach this via the panel widget. Via the GSoC project, we 
want to bring it to System Settings instead. kimpanel can then run kcmshell. 
Life will be good.
  
  Since not all systems have an IM daemon running (although increasingly Linux 
systems run one by default, e.g. Gnome does for globally available emoji 
input), the KCM will need to have modes where it either backchannels to the IM 
daemon for configuration or uses xkb as before. On Wayland the situation is a 
little bit different since the compositor is always in charge of the layout, so 
it will need to talk both to KWin and the IM daemon. The details of this are 
still up on the air: That's why it's a multi-month project.
  
  Just like the KCM will fall back to xkb on IM daemon-less systems, it makes 
sense to pursue this architecture as far as the panel indicators are concerned. 
It's long been known that the redundancy/conflict between kimpanel and the 
keyboard layout indicator will eventually need to be resolved/collapsed. The 
problems we're having:
  
  - We have support for automagically adding the keyboard layout indicator when 
needed, but we lack this for kimpanel. We currently add kimpanel to the default 
panel on first logon based on a locale white list. But if you do first logon on 
an English-language system and later add, say, Chinese input (which in lieu of 
the GSoC project you currently need to do painfully in a manual sysadmin 
fashion), you need to manually add the widget. It's a TODO to make this 
automatic.
  
  - When an IM daemon is in use, the keyboard layout indicator currently 
becomes useless on X11 (because the IM daemon takes over keyboard layout 
management). But when the IM daemon goes away, it becomes useful again. 
Currently the user needs to do lots of manual steps to switch between them. 
Add/remove/hide one or the other, etc.
  
  It therefore IMHO makes sense to put the layout indicator into kimpanel as a 
fallback codepath (and on Wayland we'd currently always use this fallback until 
we figure out IM there properly). If the reaction to this is "eww, I don't 
understand kimpanel and I don't want to touch it", then that's exactly the 
problem: We need more core devs to review and improve kimpanel and integrate it 
properly into the core offering. It does things we need (our users rely on it), 
but it's currently developed largely in isolation and poorly integrated. That 
this is one of the few areas where we still ship two redundant/overlapping UI 
solutions is telling.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D12069

To: apol, #plasma
Cc: hein, graesslin, broulik, davidedmundson, plasma-devel, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D12069: Implement a keyboard selector plasmoid

[David Edmundson]

davidedmundson added a comment.


  > once we switch to a proper model of managing input languages vs. just 
keyboard layouts in the workspace.
  
  Is that something that can happen now?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D12069

To: apol, #plasma
Cc: hein, graesslin, broulik, davidedmundson, plasma-devel, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D12069: Implement a keyboard selector plasmoid

[Eike Hein]

hein added a comment.


  It's long been known that the keyboard layout switcher SNI is legacy stuff 
and will eventually become redundant with the Input Method Panel widget once we 
switch to a proper model of managing input languages vs. just keyboard layouts 
in the workspace.
  
  I suggest this be discarded and instead keyboard layout switching be added to 
the IMP widget as a fallback when an IM daemon is not running (when one is 
running it effectively takes over keyboard layout management at least on X11, 
and so the SNI always became completely useless to IM users). This would have 
the benefits of:
  
  - ... putting us on a path towards the proper unification we need
  - ... getting more of the core Plasma devs to review and work on the IMP 
code, which we need to be of prime quality (it's in p-d, it's on the default 
panel in many locales, and soon likely will be for all of them for emoji input)
  
  This is also important for our plans for the Virtual Keyboard down the road, 
where we want to embed the IMP widget to do the language/layout switching and 
reuse important toggles (like full/half-width character modes).
  
  This request as-is is new work that reimplements a known-to-be-broken thing, 
which is not great because new work should always go towards planned 
improvements.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D12069

To: apol, #plasma
Cc: hein, graesslin, broulik, davidedmundson, plasma-devel, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

KDE CI: Plasma plasma-vault kf5-qt5 FreeBSDQt5.9 - Build # 16 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma%20plasma-vault%20kf5-qt5%20FreeBSDQt5.9/16/
 Project:
Plasma plasma-vault kf5-qt5 FreeBSDQt5.9
 Date of build:
Mon, 09 Apr 2018 17:44:52 +
 Build duration:
2 min 7 sec and counting
   CONSOLE OUTPUT
  [...truncated 62.61 KB...]SHELL = '/usr/local/bin/bash'MM_CHARSET= 'UTF-8'WORKSPACE = '/usr/home/jenkins/workspace/Plasma plasma-vault kf5-qt5 FreeBSDQt5.9'JOB_NAME  = 'Plasma plasma-vault kf5-qt5 FreeBSDQt5.9'STAGE_NAME= 'Configuring Build'XDG_CURRENT_DESKTOP   = 'KDE'PWD   = '/usr/home/jenkins/workspace/Plasma plasma-vault kf5-qt5 FreeBSDQt5.9'USER  = 'jenkins'PATH  = '/usr/home/jenkins/install-prefix/bin:/sbin:/bin:/usr/sbin:/usr/bin:/usr/local/sbin:/usr/local/bin:/usr/home/jenkins//bin'BLOCKSIZE = 'K'BUILD_ID  = '16'_ = '/usr/local/bin/java'BUILD_DISPLAY_NAME= '#16'XDG_CONFIG_DIRS   = '/usr/home/jenkins/install-prefix/etc/xdg:/usr/local/etc/xdg'QT_SELECT = 'qt5'LD_LIBRARY_PATH   = '/usr/home/jenkins/install-prefix/lib'LANG  = 'en_US.UTF-8'QML2_IMPORT_PATH  = '/usr/home/jenkins/install-prefix/lib/qml'JOB_BASE_NAME = 'Plasma plasma-vault kf5-qt5 FreeBSDQt5.9'BUILD_NUMBER  = '16'RUN_DISPLAY_URL   = 'https://build.kde.org/job/Plasma%20plasma-vault%20kf5-qt5%20FreeBSDQt5.9/16/display/redirect'XDG_DATA_DIRS = '/usr/home/jenkins/install-prefix/share:/usr/share:/usr/local/share'CMAKE_PREFIX_PATH = '/usr/home/jenkins/install-prefix:/usr/:/usr/local/'HUDSON_HOME   = '/home/production/data'NODE_NAME = 'FreeBSD Builder 2'LOGNAME   = 'jenkins'EXECUTOR_NUMBER   = '0'HOME  = '/usr/home/jenkins/'HUDSON_URL= 'https://build.kde.org/'PKG_CONFIG_PATH   = '/usr/home/jenkins/install-prefix/lib/pkgconfig:/usr/libdata/pkgconfig:/usr/local/libdata/pkgconfig'JOB_URL   = 'https://build.kde.org/job/Plasma%20plasma-vault%20kf5-qt5%20FreeBSDQt5.9/'ASAN_OPTIONS  = 'detect_leaks=0:new_delete_type_mismatch=0:detect_odr_violation=0:stack-use-after-scope=0:alloc_dealloc_mismatch=0:symbolize=1'JAVA_HOME = '/usr/local/openjdk8-jre'NODE_LABELS   = 'FreeBSD Builder 2 FreeBSDQt5.9'JENKINS_URL   = 'https://build.kde.org/'JENKINS_NODE_COOKIE   = 'e916f3d7-7951-4f48-8f59-20c987f9fc94'BUILD_URL = 'https://build.kde.org/job/Plasma%20plasma-vault%20kf5-qt5%20FreeBSDQt5.9/16/'RUN_CHANGES_DISPLAY_URL   = 'https://build.kde.org/job/Plasma%20plasma-vault%20kf5-qt5%20FreeBSDQt5.9/16/display/redirect?page=changes'BUILD_TAG = 'jenkins-Plasma plasma-vault kf5-qt5 FreeBSDQt5.9-16'SHLVL = '1'QT_PLUGIN_PATH= '/usr/home/jenkins/install-prefix/lib/plugins'== Commencing Configuration:cmake -DCMAKE_BUILD_TYPE=Debug -DECM_ENABLE_SANITIZERS='address' -DBUILD_TESTING=ON -DCMAKE_INSTALL_PREFIX="/usr/home/jenkins//install-prefix/"  "/usr/home/jenkins/workspace/Plasma plasma-vault kf5-qt5 FreeBSDQt5.9"-- The C compiler identification is Clang 4.0.0-- The CXX compiler identification is Clang 4.0.0-- Check for working C compiler: /usr/bin/cc-- Check for working C compiler: /usr/bin/cc -- works-- Detecting C compiler ABI info-- Detecting C compiler ABI info - done-- Detecting C compile features-- Detecting C compile features - done-- Check for working CXX compiler: /usr/bin/c++-- Check for working CXX compiler: /usr/bin/c++ -- works-- Detecting CXX compiler ABI info-- Detecting CXX compiler ABI info - done-- Detecting CXX compile features-- Detecting CXX compile features - done-- -- Could not set up the appstream test. appstreamcli is missing.-- Looking for __GLIBC__-- Looking for __GLIBC__ - not found-- Performing Test _OFFT_IS_64BIT-- Performing Test _OFFT_IS_64BIT - Success-- Performing Test HAVE_DATE_TIME-- Performing Test HAVE_DATE_TIME - Success-- Found KF5Activities: /usr/home/jenkins/install-prefix/lib/cmake/KF5Activities/KF5ActivitiesConfig.cmake (found version "5.45.0") -- Found KF5Config: /usr/home/jenkins/install-prefix/lib/cmake/KF5Config/KF5ConfigConfig.cmake (found version "5.45.0") -- Found KF5ConfigWidgets: /usr/home/jenkins/install-prefix/lib/cmake/KF5ConfigWidgets/KF5ConfigWidgetsConfig.cmake (found version "5.45.0") -- Found KF5CoreAddons: /usr/home/jenkins/install-prefix/lib/cmake/KF5CoreAddons/KF5CoreAddonsConfig.cmake (found version "5.45.0") -- Found KF5DBusAddons: /usr/home/jenkins/install-prefix/lib/cmake/KF5DBusAddons/KF5DBusAddonsConfig.cmake (found version "5.45.0") -- Found Gettext: /usr/local/bin/msgmerge (found version "0.19.8.1") -- Found KF5I18n: 

D12069: Implement a keyboard selector plasmoid

[Martin Flöser]

graesslin added inline comments.

INLINE COMMENTS

> davidedmundson wrote in main.qml:42
> "apl" and "mao" are 3 letters.
> No idea what either of those mean, it's just in the list.

I'm not sure whether a substring is the correct solution anyhow. On Wayland we 
get a proper name like German, but that doesn't match the short name which 
would be de.

That's also the reason why the sni doesn't support flags: I didn't find a 
trivial solution to map to iso codes.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D12069

To: apol, #plasma
Cc: graesslin, broulik, davidedmundson, plasma-devel, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D12072: use ConstrainedSquare as formFactor

[Kai Uwe Broulik]

broulik requested changes to this revision.
broulik added a comment.
This revision now requires changes to proceed.


  This doesn't work.
  
  - ```Containment::restore(KConfigGroup&)``` overwrites it with the form 
factor stored in config
  - ```SystemTrayContainer``` also overwrites it depending on the container's 
form factor

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D12072

To: mart, #plasma, broulik
Cc: broulik, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D11533: [kstyle] create shadow tiles more explicitly

[Vlad Zagorodniy]

zzag added a comment.


  In D11533#243257 , 
@hpereiradacosta wrote:
  
  > Hi Vlad,
  
  
  Hi! :)
  
  > Second: I agree that the current code is bug prone, but your foreseen 
change is not satisfactory either. 
  >  The idea with the current code was to try create the shadows only "once" 
and if it fails for some reason, leave it failed for all widgets for which it 
is requested. 
  >  In your modified code however, if the creation of shadowtiles fails once, 
it keeps being called over and over again for each new widget. 
  >  I think this should be avoided.
  
  I've tried to preserve old behavior. The current code is always trying to 
create shadows.
  
  > One solution is possibly to call shadowTiles once and only once, in 
breezeStyle::loadConfiguration, and just test whether it is valid whenever 
used. 
  >  what do you think ?
  
  Yes, that's a good idea. How about calling `shadowTiles` in 
`ShadowHelper::reset()`?

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D11533

To: zzag, #breeze, hpereiradacosta
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D11289: checkable FormLayout items

[Julian Wolff]

This revision was automatically updated to reflect the committed changes.
Closed by commit R169:6ac4e62002ae: checkable FormLayout items (authored by 
progwolff).

REPOSITORY
  R169 Kirigami

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11289?vs=29937=31751

REVISION DETAIL
  https://phabricator.kde.org/D11289

AFFECTED FILES
  examples/gallerydata/contents/ui/gallery/FormLayoutGallery.qml
  src/controls/templates/FormLayout.qml
  src/formlayoutattached.cpp
  src/formlayoutattached.h

To: progwolff, #vdg, #kirigami, mart
Cc: mart, ngraham, plasma-devel, apol, davidedmundson, hein

D12072: use ConstrainedSquare as formFactor

[Marco Martin]

mart created this revision.
mart added a reviewer: Plasma.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
mart requested review of this revision.

REVISION SUMMARY
  all systray applets will be in the constrainedsquare formfactor,
  as they can't grow neither horizontally nor vertically

TEST PLAN
  default applets seems to work unchanged

REPOSITORY
  R120 Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D12072

AFFECTED FILES
  applets/systemtray/systemtray.cpp

To: mart, #plasma
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D11533: [kstyle] create shadow tiles more explicitly

[Hugo Pereira Da Costa]

hpereiradacosta added a comment.


  Hi Vlad,
  
  First sorry for the late answer !
  Second: I agree that the current code is bug prone, but your foreseen change 
is not satisfactory either. 
  The idea with the current code was to try create the shadows only "once" and 
if it fails for some reason, leave it failed for all widgets for which it is 
requested. 
  In your modified code however, if the creation of shadowtiles fails once, it 
keeps being called over and over again for each new widget. 
  I think this should be avoided. 
  One solution is possibly to call shadowTiles once and only once, in 
breezeStyle::loadConfiguration, and just test whether it is valid whenever 
used. 
  what do you think ?

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D11533

To: zzag, #breeze, hpereiradacosta
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D12069: Implement a keyboard selector plasmoid

[Kai Uwe Broulik]

broulik added inline comments.

INLINE COMMENTS

> main.qml:38
> +Plasmoid.preferredRepresentation: Plasmoid.compactRepresentation
> +Plasmoid.compactRepresentation: PlasmaComponents.Label {
> +fontSizeMode: Text.Fit

Also set `height: undefined`, I've seen issues where `Text.Fit` fails to shrink 
fully due to `PlasmaComponents.Label` default height

> davidedmundson wrote in main.qml:40
> can you use smallestReadableFont?

`theme.smallestFont` that is

> main.qml:48
> +anchors.fill: parent
> +hoverEnabled: true
> +

Unused

> main.qml:54
> +
> +Plasmoid.status: layout.layouts.length>1 ? PlasmaCore.Types.ActiveStatus 
> : PlasmaCore.Types.PassiveStatus
> +Plasmoid.toolTipMainText: i18n("Keyboard Layout")

Coding style, spaces

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D12069

To: apol, #plasma
Cc: broulik, davidedmundson, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D12069: Implement a keyboard selector plasmoid

[David Edmundson]

davidedmundson added a comment.


  > Mimics the behavior of the status notifier item
  
  The keyboard kded module when it's used on X has one more option for its SNI
  
  - show flag
  - show label
  - show label on flag
  
  "show layout indicator" and "show for single layout" become just normal 
plasmoid management.

INLINE COMMENTS

> main.qml:40
> +fontSizeMode: Text.Fit
> +minimumPixelSize: 10
> +font.pixelSize: 72

can you use smallestReadableFont?

> main.qml:42
> +font.pixelSize: 72
> +text: layout.currentLayout.substr(0, 2).toLowerCase()
> +verticalAlignment: Qt.AlignVCenter

"apl" and "mao" are 3 letters.
No idea what either of those mean, it's just in the list.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D12069

To: apol, #plasma
Cc: davidedmundson, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D11955: [Folder View] Set Refresh shortcut on Refresh/Reload

[Kai Uwe Broulik]

broulik planned changes to this revision.
broulik added a comment.


  I just noticed that `setUsedByContainment` actually renames the "reload" 
action to "Refresh desktop", so "refresh" is essentially useless.
  Will refactor this to get rid of the dedicated "Refresh" action and just use 
"Reload" everywhere (with appropriate name as is currently done in the code 
already)

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D11955

To: broulik, #plasma, hein
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D12069: Implement a keyboard selector plasmoid

[Aleix Pol Gonzalez]

apol created this revision.
apol added a reviewer: Plasma.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
apol requested review of this revision.

REVISION SUMMARY
  Mimics the behavior of the status notifier item

REPOSITORY
  R120 Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D12069

AFFECTED FILES
  applets/CMakeLists.txt
  applets/keyboardselector/Messages.sh
  applets/keyboardselector/contents/ui/main.qml
  applets/keyboardselector/metadata.desktop

To: apol, #plasma
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

Monday meeting minutes

[Marco Martin]

Kai Uwe:
* Bugfixing in Folder View
* Fixed System Settings section headings font (Qt bug with font.bold
vs font.weight priority)
* Added "aboutToShow" signal for ToolTipArea, allows to defer heavy
lifting to when the tooltip is actually shown (vs containsMouse)
* Profiling in Dolphin
* Tried to fix undo move to trash in desktop not working caused by
(once again..) URL rewriting, D11987 but that's still not enough to
fix it
* Fix for blur background filling caused by Image wallpaper rewrite: D11981
* Performance improvement for file dialog: D11948
* Will add QtQuickSettings to System Settings since it has a lot of
QML stuff nowadays
* Made a patch for QtDBus to allow interactive authorization
https://codereview.qt-project.org/#/c/225143/
** needed for new logind and other calls, such as "reboot to firmware
setup" I've also been working on
** will try to get the Qt patch cleaned up this week

Riddell:
* spoken with Mirko about the sprint, needs somebody keeping the office key
* finding details of kde office warmup party to coordinate with who is
still at the sprint then

Roman:
Working on T4465. Thinking about the right library structure. Current
progress here: 
https://cgit.kde.org/clones/plasma-workspace/romangilg/plasma-workspace.git/log/?h=colorCorrectIndividualOutputs

David:
* Mostly Qt stuff this week:
* Had some fallout from my Qt nvidia patch - hopefully now all fixed.
Mostly all merged now.
* Finally had that Qt memory leak patch merged (visible on slideshow wallpaper)
* wrote a QtDbus patch allowing for wildcards in QDBusService (waiting
on Kai to review before tagging proper people)
* this morning fixed a very boring crash in plasma framework
https://bugs.kde.org/show_bug.cgi?id=391642#c6

Eike:
* Short week due to holiday on Monday and taking another day off for
personal stuff
* [SysSe] Finished Language KCM port, need to re-read and Phab
** We don't have a drag-reorderable list in Kirigami yet, so I did
without it for now (Up/Down buttons)
* Leaving for Berlin on the 12th, vacation until 17th, some more vacay
after the board meeting (28th+29th) in Berlin, then back in Seoul and
at work on the 3rd

Marco:
* finished up a new api for libplasma to make containments and
activities bookkeeping easier on shellcorona, will push this week as
frameworks has been released
* ksplash themes standalone and ghns ui on systemsettings splash
module: they are still shared with lnf, but lnf module won't list
themes with just a splash
* Kirigami: DesktopIcon now used on all styles (except plasma svg
theme where the identical IconItem is used)
* Working with VDG on a new lockscreen look D11928

D12003: Fix displaying OpenGL info on wayland: do not require OpenGL 3.2

[Alexey Min]

This revision was automatically updated to reflect the committed changes.
Closed by commit R102:702c7ca86e94: Fix displaying OpenGL info on wayland: do 
not require OpenGL 3.2 (authored by alexeymin).

REPOSITORY
  R102 KInfoCenter

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D12003?vs=31536=31731

REVISION DETAIL
  https://phabricator.kde.org/D12003

AFFECTED FILES
  Modules/opengl/opengl.cpp

To: alexeymin, #plasma, graesslin, davidedmundson
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D12000: [ProcessModel] Return invalid QVariant() for when window is not known

[Kai Uwe Broulik]

This revision was automatically updated to reflect the committed changes.
Closed by commit R111:e3ea3c840d6f: [ProcessModel] Return invalid QVariant() 
for when window is not known (authored by broulik).

REPOSITORY
  R111 KSysguard Library

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D12000?vs=31526=31730

REVISION DETAIL
  https://phabricator.kde.org/D12000

AFFECTED FILES
  processui/ProcessModel.cpp

To: broulik, #plasma, davidedmundson
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D12063: Add a hidden config option for showing icons on the root level of the menu

[Albert Astals Cid]

aacid updated this revision to Diff 31725.
aacid added a comment.


  Update commit author to kdab.com hat

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D12063?vs=31723=31725

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D12063

AFFECTED FILES
  applets/kicker/package/contents/config/main.xml
  applets/kicker/package/contents/ui/MenuRepresentation.qml

To: aacid, hein
Cc: plasma-devel, #plasma, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D12063: Add a hidden config option for showing icons on the root level of the menu

[Albert Astals Cid]

aacid created this revision.
aacid added a reviewer: hein.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
aacid requested review of this revision.

TEST PLAN
  - Menu looks the same with new code
  - Menu has icons if changing default value on the config file

REPOSITORY
  R119 Plasma Desktop

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D12063

AFFECTED FILES
  applets/kicker/package/contents/config/main.xml
  applets/kicker/package/contents/ui/MenuRepresentation.qml

To: aacid, hein
Cc: plasma-devel, #plasma, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart