date:20200203

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Plasma/job/plasma-framework/job/kf5-qt5%20FreeBSDQt5.13/154/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Tue, 04 Feb 2020 07:32:31 +
 Build duration:
6 min 59 sec and counting
   JUnit Tests
  Name: projectroot Failed: 0 test(s), Passed: 11 test(s), Skipped: 0 test(s), Total: 11 test(s)

KDE CI: Plasma » plasma-framework » kf5-qt5 SUSEQt5.12 - Build # 289 - Fixed!

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Plasma/job/plasma-framework/job/kf5-qt5%20SUSEQt5.12/289/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Tue, 04 Feb 2020 07:32:31 +
 Build duration:
6 min 17 sec and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5Plasma-5.67.0.xmlacc/KF5PlasmaQuick-5.67.0.xmlcompat_reports/KF5Plasma_compat_report.htmllogs/KF5Plasma/5.67.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 0 test(s), Passed: 11 test(s), Skipped: 0 test(s), Total: 11 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report50%
(9/18)37%
(47/126)37%
(47/126)35%
(4657/13359)26%
(2521/9706)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests92%
(11/12)92%
(11/12)95%
(869/916)52%
(439/852)src.declarativeimports.calendar0%
(0/6)0%
(0/6)0%
(0/472)0%
(0/245)src.declarativeimports.core44%
(7/16)44%
(7/16)34%
(774/2307)26%
(396/1499)src.declarativeimports.plasmacomponents0%
(0/6)0%
(0/6)0%
(0/518)0%
(0/207)src.declarativeimports.plasmaextracomponents0%
(0/3)0%
(0/3)0%
(0/42)0%
(0/22)src.declarativeimports.platformcomponents0%
(0/3)0%
(0/3)0%
(0/59)0%
(0/14)src.declarativeimports.platformcomponents.utils0%
(0/2)0%
(0/2)0%
(0/14)0%
(0/2)src.plasma45%
(10/22)45%
(10/22)43%
(1520/3565)33%
(952/2894)src.plasma.packagestructure43%
(3/7)43%
(3/7)36%
(49/137)42%
(5/12)src.plasma.private39%
(7/18)39%
(7/18)47%
(746/1576)35%
(370/1045)src.plasma.scripting67%
(2/3)67%
(2/3)26%
(46/176)18%
(19/105)src.plasmapkg0%
(0/1)0%
(0/1)0%
(0/45)0%
(0/40)src.plasmaquick38%
(5/13)38%
(5/13)29%
(609/2086)19%
(335/1737)src.plasmaquick.private50%
(1/2)50%
(1/2)29%
(31/106)36%
(5/14)src.scriptengines.qml.plasmoid14%
(1/7)14%
(1/7)1%
(13/1185)0%
(0/994)tests.dpi0%
(0/2)0%
(0/2)0%
(0/21)0%
(0/2)tests.kplugins0%

KDE CI: Plasma » plasma-framework » stable-kf5-qt5 FreeBSDQt5.13 - Build # 155 - Fixed!

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Plasma/job/plasma-framework/job/stable-kf5-qt5%20FreeBSDQt5.13/155/
 Project:
stable-kf5-qt5 FreeBSDQt5.13
 Date of build:
Tue, 04 Feb 2020 07:32:31 +
 Build duration:
5 min 37 sec and counting
   JUnit Tests
  Name: projectroot Failed: 0 test(s), Passed: 11 test(s), Skipped: 0 test(s), Total: 11 test(s)

KDE CI: Plasma » plasma-framework » stable-kf5-qt5 SUSEQt5.12 - Build # 284 - Fixed!

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Plasma/job/plasma-framework/job/stable-kf5-qt5%20SUSEQt5.12/284/
 Project:
stable-kf5-qt5 SUSEQt5.12
 Date of build:
Tue, 04 Feb 2020 07:32:31 +
 Build duration:
4 min 42 sec and counting
   BUILD ARTIFACTS
  acc/KF5Plasma-5.67.0.xmllogs/KF5Plasma/5.67.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 0 test(s), Passed: 11 test(s), Skipped: 0 test(s), Total: 11 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report50%
(9/18)37%
(47/126)37%
(47/126)35%
(4657/13359)26%
(2521/9706)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests92%
(11/12)92%
(11/12)95%
(869/916)52%
(439/852)src.declarativeimports.calendar0%
(0/6)0%
(0/6)0%
(0/472)0%
(0/245)src.declarativeimports.core44%
(7/16)44%
(7/16)34%
(774/2307)26%
(396/1499)src.declarativeimports.plasmacomponents0%
(0/6)0%
(0/6)0%
(0/518)0%
(0/207)src.declarativeimports.plasmaextracomponents0%
(0/3)0%
(0/3)0%
(0/42)0%
(0/22)src.declarativeimports.platformcomponents0%
(0/3)0%
(0/3)0%
(0/59)0%
(0/14)src.declarativeimports.platformcomponents.utils0%
(0/2)0%
(0/2)0%
(0/14)0%
(0/2)src.plasma45%
(10/22)45%
(10/22)43%
(1520/3565)33%
(952/2894)src.plasma.packagestructure43%
(3/7)43%
(3/7)36%
(49/137)42%
(5/12)src.plasma.private39%
(7/18)39%
(7/18)47%
(746/1576)35%
(370/1045)src.plasma.scripting67%
(2/3)67%
(2/3)26%
(46/176)18%
(19/105)src.plasmapkg0%
(0/1)0%
(0/1)0%
(0/45)0%
(0/40)src.plasmaquick38%
(5/13)38%
(5/13)29%
(609/2086)19%
(335/1737)src.plasmaquick.private50%
(1/2)50%
(1/2)29%
(31/106)36%
(5/14)src.scriptengines.qml.plasmoid14%
(1/7)14%
(1/7)1%
(13/1185)0%
(0/994)tests.dpi0%
(0/2)0%
(0/2)0%
(0/21)0%
(0/2)tests.kplugins0%
(0/2)0%
(0/2)0%

KDE CI: Plasma » plasma-framework » stable-kf5-qt5 FreeBSDQt5.13 - Build # 154 - Failure!

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma/job/plasma-framework/job/stable-kf5-qt5%20FreeBSDQt5.13/154/
 Project:
stable-kf5-qt5 FreeBSDQt5.13
 Date of build:
Tue, 04 Feb 2020 05:55:09 +
 Build duration:
1 hr 1 min and counting
   CONSOLE OUTPUT
  [...truncated 1165 lines...][2020-02-04T06:56:59.600Z] [2020-02-04T06:56:59.600Z] ld: error: undefined symbol: DropMenu::setUrls(QList const&)[2020-02-04T06:56:59.600Z] >>> referenced by containmentinterface.cpp:472 (/usr/home/jenkins/workspace/Plasma/plasma-framework/stable-kf5-qt5 FreeBSDQt5.13/src/scriptengines/qml/plasmoid/containmentinterface.cpp:472)[2020-02-04T06:56:59.600Z] >>>   CMakeFiles/plasma_appletscript_declarative.dir/plasmoid/containmentinterface.cpp.o:(ContainmentInterface::processMimeData(QMimeData*, int, int, KIO::DropJob*))[2020-02-04T06:56:59.600Z] [2020-02-04T06:56:59.600Z] ld: error: undefined symbol: DropMenu::setMultipleMimetypes(bool)[2020-02-04T06:56:59.600Z] >>> referenced by containmentinterface.cpp:482 (/usr/home/jenkins/workspace/Plasma/plasma-framework/stable-kf5-qt5 FreeBSDQt5.13/src/scriptengines/qml/plasmoid/containmentinterface.cpp:482)[2020-02-04T06:56:59.600Z] >>>   CMakeFiles/plasma_appletscript_declarative.dir/plasmoid/containmentinterface.cpp.o:(ContainmentInterface::processMimeData(QMimeData*, int, int, KIO::DropJob*))[2020-02-04T06:56:59.600Z] [2020-02-04T06:56:59.600Z] ld: error: undefined symbol: DropMenu::urls() const[2020-02-04T06:56:59.600Z] >>> referenced by containmentinterface.cpp:489 (/usr/home/jenkins/workspace/Plasma/plasma-framework/stable-kf5-qt5 FreeBSDQt5.13/src/scriptengines/qml/plasmoid/containmentinterface.cpp:489)[2020-02-04T06:56:59.600Z] >>>   CMakeFiles/plasma_appletscript_declarative.dir/plasmoid/containmentinterface.cpp.o:(ContainmentInterface::processMimeData(QMimeData*, int, int, KIO::DropJob*))[2020-02-04T06:56:59.600Z] [2020-02-04T06:56:59.600Z] ld: error: undefined symbol: DropMenu::addAction(QAction*)[2020-02-04T06:56:59.600Z] >>> referenced by containmentinterface.cpp:535 (/usr/home/jenkins/workspace/Plasma/plasma-framework/stable-kf5-qt5 FreeBSDQt5.13/src/scriptengines/qml/plasmoid/containmentinterface.cpp:535)[2020-02-04T06:56:59.600Z] >>>   CMakeFiles/plasma_appletscript_declarative.dir/plasmoid/containmentinterface.cpp.o:(ContainmentInterface::processMimeData(QMimeData*, int, int, KIO::DropJob*))[2020-02-04T06:56:59.886Z] [2020-02-04T06:56:59.886Z] ld: error: undefined symbol: DropMenu::show()[2020-02-04T06:56:59.886Z] >>> referenced by containmentinterface.cpp:545 (/usr/home/jenkins/workspace/Plasma/plasma-framework/stable-kf5-qt5 FreeBSDQt5.13/src/scriptengines/qml/plasmoid/containmentinterface.cpp:545)[2020-02-04T06:56:59.886Z] >>>   CMakeFiles/plasma_appletscript_declarative.dir/plasmoid/containmentinterface.cpp.o:(ContainmentInterface::processMimeData(QMimeData*, int, int, KIO::DropJob*))[2020-02-04T06:56:59.886Z] [2020-02-04T06:56:59.886Z] ld: error: undefined symbol: DropMenu::show()[2020-02-04T06:56:59.886Z] >>> referenced by containmentinterface.cpp:561 (/usr/home/jenkins/workspace/Plasma/plasma-framework/stable-kf5-qt5 FreeBSDQt5.13/src/scriptengines/qml/plasmoid/containmentinterface.cpp:561)[2020-02-04T06:56:59.886Z] >>>   CMakeFiles/plasma_appletscript_declarative.dir/plasmoid/containmentinterface.cpp.o:(ContainmentInterface::clearDataForMimeJob(KIO::Job*))[2020-02-04T06:56:59.886Z] [2020-02-04T06:56:59.886Z] ld: error: undefined symbol: DropMenu::urls() const[2020-02-04T06:56:59.886Z] >>> referenced by containmentinterface.cpp:563 (/usr/home/jenkins/workspace/Plasma/plasma-framework/stable-kf5-qt5 FreeBSDQt5.13/src/scriptengines/qml/plasmoid/containmentinterface.cpp:563)[2020-02-04T06:56:59.886Z] >>>   CMakeFiles/plasma_appletscript_declarative.dir/plasmoid/containmentinterface.cpp.o:(ContainmentInterface::clearDataForMimeJob(KIO::Job*))[2020-02-04T06:56:59.886Z] [2020-02-04T06:56:59.886Z] ld: error: undefined symbol: DropMenu::dropPoint() const[2020-02-04T06:56:59.886Z] >>> referenced by containmentinterface.cpp:594 (/usr/home/jenkins/workspace/Plasma/plasma-framework/stable-kf5-qt5 FreeBSDQt5.13/src/scriptengines/qml/plasmoid/containmentinterface.cpp:594)[2020-02-04T06:56:59.886Z] >>>   CMakeFiles/plasma_appletscript_declarative.dir/plasmoid/containmentinterface.cpp.o:(ContainmentInterface::mimeTypeRetrieved(KIO::Job*, QString const&))[2020-02-04T06:56:59.886Z] [2020-02-04T06:56:59.886Z] ld: error: undefined symbol: DropMenu::isMultipleMimetypes() const[2020-02-04T06:56:59.886Z] >>> referenced by containmentinterface.cpp:615 (/usr/home/jenkins/workspace/Plasma/plasma-framework/stable-kf5-qt5 FreeBSDQt5.13/src/scriptengines/qml/plasmoid/containmentinterface.cpp:615)[2020-02-04T06:56:59.886Z] >>>

KDE CI: Plasma » plasma-framework » kf5-qt5 FreeBSDQt5.13 - Build # 153 - Failure!

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma/job/plasma-framework/job/kf5-qt5%20FreeBSDQt5.13/153/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Tue, 04 Feb 2020 05:55:09 +
 Build duration:
1 hr 1 min and counting
   CONSOLE OUTPUT
  [...truncated 1141 lines...][2020-02-04T06:56:29.224Z] >>>   CMakeFiles/plasma_appletscript_declarative.dir/plasmoid/containmentinterface.cpp.o:(ContainmentInterface::processMimeData(QMimeData*, int, int, KIO::DropJob*))[2020-02-04T06:56:29.224Z] [2020-02-04T06:56:29.224Z] ld: error: undefined symbol: DropMenu::setMultipleMimetypes(bool)[2020-02-04T06:56:29.224Z] >>> referenced by containmentinterface.cpp:482 (/usr/home/jenkins/workspace/Plasma/plasma-framework/kf5-qt5 FreeBSDQt5.13/src/scriptengines/qml/plasmoid/containmentinterface.cpp:482)[2020-02-04T06:56:29.224Z] >>>   CMakeFiles/plasma_appletscript_declarative.dir/plasmoid/containmentinterface.cpp.o:(ContainmentInterface::processMimeData(QMimeData*, int, int, KIO::DropJob*))[2020-02-04T06:56:29.224Z] [2020-02-04T06:56:29.224Z] ld: error: undefined symbol: DropMenu::urls() const[2020-02-04T06:56:29.224Z] >>> referenced by containmentinterface.cpp:489 (/usr/home/jenkins/workspace/Plasma/plasma-framework/kf5-qt5 FreeBSDQt5.13/src/scriptengines/qml/plasmoid/containmentinterface.cpp:489)[2020-02-04T06:56:29.224Z] >>>   CMakeFiles/plasma_appletscript_declarative.dir/plasmoid/containmentinterface.cpp.o:(ContainmentInterface::processMimeData(QMimeData*, int, int, KIO::DropJob*))[2020-02-04T06:56:29.224Z] [2020-02-04T06:56:29.224Z] ld: error: undefined symbol: DropMenu::addAction(QAction*)[2020-02-04T06:56:29.224Z] >>> referenced by containmentinterface.cpp:535 (/usr/home/jenkins/workspace/Plasma/plasma-framework/kf5-qt5 FreeBSDQt5.13/src/scriptengines/qml/plasmoid/containmentinterface.cpp:535)[2020-02-04T06:56:29.224Z] >>>   CMakeFiles/plasma_appletscript_declarative.dir/plasmoid/containmentinterface.cpp.o:(ContainmentInterface::processMimeData(QMimeData*, int, int, KIO::DropJob*))[2020-02-04T06:56:29.224Z] [2020-02-04T06:56:29.224Z] ld: error: undefined symbol: DropMenu::show()[2020-02-04T06:56:29.224Z] >>> referenced by containmentinterface.cpp:545 (/usr/home/jenkins/workspace/Plasma/plasma-framework/kf5-qt5 FreeBSDQt5.13/src/scriptengines/qml/plasmoid/containmentinterface.cpp:545)[2020-02-04T06:56:29.224Z] >>>   CMakeFiles/plasma_appletscript_declarative.dir/plasmoid/containmentinterface.cpp.o:(ContainmentInterface::processMimeData(QMimeData*, int, int, KIO::DropJob*))[2020-02-04T06:56:29.224Z] [2020-02-04T06:56:29.224Z] ld: error: undefined symbol: DropMenu::show()[2020-02-04T06:56:29.224Z] >>> referenced by containmentinterface.cpp:561 (/usr/home/jenkins/workspace/Plasma/plasma-framework/kf5-qt5 FreeBSDQt5.13/src/scriptengines/qml/plasmoid/containmentinterface.cpp:561)[2020-02-04T06:56:29.224Z] >>>   CMakeFiles/plasma_appletscript_declarative.dir/plasmoid/containmentinterface.cpp.o:(ContainmentInterface::clearDataForMimeJob(KIO::Job*))[2020-02-04T06:56:29.224Z] [2020-02-04T06:56:29.224Z] ld: error: undefined symbol: DropMenu::urls() const[2020-02-04T06:56:29.224Z] >>> referenced by containmentinterface.cpp:563 (/usr/home/jenkins/workspace/Plasma/plasma-framework/kf5-qt5 FreeBSDQt5.13/src/scriptengines/qml/plasmoid/containmentinterface.cpp:563)[2020-02-04T06:56:29.224Z] >>>   CMakeFiles/plasma_appletscript_declarative.dir/plasmoid/containmentinterface.cpp.o:(ContainmentInterface::clearDataForMimeJob(KIO::Job*))[2020-02-04T06:56:29.224Z] [2020-02-04T06:56:29.224Z] ld: error: undefined symbol: DropMenu::dropPoint() const[2020-02-04T06:56:29.224Z] >>> referenced by containmentinterface.cpp:594 (/usr/home/jenkins/workspace/Plasma/plasma-framework/kf5-qt5 FreeBSDQt5.13/src/scriptengines/qml/plasmoid/containmentinterface.cpp:594)[2020-02-04T06:56:29.224Z] >>>   CMakeFiles/plasma_appletscript_declarative.dir/plasmoid/containmentinterface.cpp.o:(ContainmentInterface::mimeTypeRetrieved(KIO::Job*, QString const&))[2020-02-04T06:56:29.224Z] [2020-02-04T06:56:29.224Z] ld: error: undefined symbol: DropMenu::isMultipleMimetypes() const[2020-02-04T06:56:29.224Z] >>> referenced by containmentinterface.cpp:615 (/usr/home/jenkins/workspace/Plasma/plasma-framework/kf5-qt5 FreeBSDQt5.13/src/scriptengines/qml/plasmoid/containmentinterface.cpp:615)[2020-02-04T06:56:29.224Z] >>>   CMakeFiles/plasma_appletscript_declarative.dir/plasmoid/containmentinterface.cpp.o:(ContainmentInterface::mimeTypeRetrieved(KIO::Job*, QString const&))[2020-02-04T06:56:29.224Z] [2020-02-04T06:56:29.224Z] ld: error: undefined symbol: DropMenu::addAction(QAction*)[2020-02-04T06:56:29.224Z] >>> referenced by containmentinterface.cpp:620 (/usr/home/jenkins/workspace/Plasma/plasma-framework/kf5-qt5 FreeBSDQt5.13/src/scriptengines/qml/plasmoid/containmentinterface.cpp:620)[2020-02-04T06:56:29.224Z] >>>

KDE CI: Plasma » plasma-framework » stable-kf5-qt5 SUSEQt5.12 - Build # 283 - Failure!

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma/job/plasma-framework/job/stable-kf5-qt5%20SUSEQt5.12/283/
 Project:
stable-kf5-qt5 SUSEQt5.12
 Date of build:
Tue, 04 Feb 2020 05:55:08 +
 Build duration:
18 min and counting
   CONSOLE OUTPUT
  [...truncated 1122 lines...][2020-02-04T06:13:27.520Z] [ 87%] Linking CXX shared module ../../../bin/kpackage/packagestructure/plasmageneric_packagestructure.so[2020-02-04T06:13:27.520Z] [ 87%] Built target plasmageneric_packagestructure[2020-02-04T06:13:27.520Z] [ 87%] Generating qrc_shaders.cpp[2020-02-04T06:13:27.775Z] Scanning dependencies of target corebindingsplugin[2020-02-04T06:13:27.775Z] [ 87%] Building CXX object src/declarativeimports/core/CMakeFiles/corebindingsplugin.dir/corebindingsplugin_autogen/mocs_compilation.cpp.o[2020-02-04T06:13:31.041Z] [ 88%] Building CXX object src/declarativeimports/core/CMakeFiles/corebindingsplugin.dir/corebindingsplugin.cpp.o[2020-02-04T06:13:31.041Z] Scanning dependencies of target plasma_appletscript_declarative[2020-02-04T06:13:31.041Z] [ 88%] Building CXX object src/scriptengines/qml/CMakeFiles/plasma_appletscript_declarative.dir/plasma_appletscript_declarative_autogen/mocs_compilation.cpp.o[2020-02-04T06:13:31.969Z] Scanning dependencies of target dialogstatetest_autogen[2020-02-04T06:13:32.229Z] [ 88%] Automatic MOC for target dialogstatetest[2020-02-04T06:13:32.485Z] [ 88%] Built target dialogstatetest_autogen[2020-02-04T06:13:32.485Z] [ 89%] Building CXX object src/scriptengines/qml/CMakeFiles/plasma_appletscript_declarative.dir/plasmoid/declarativeappletscript.cpp.o[2020-02-04T06:13:32.485Z] Scanning dependencies of target dialogqmltest_autogen[2020-02-04T06:13:32.485Z] Scanning dependencies of target iconitemtest_autogen[2020-02-04T06:13:32.485Z] [ 89%] Automatic MOC for target dialogqmltest[2020-02-04T06:13:32.485Z] [ 89%] Automatic MOC for target iconitemtest[2020-02-04T06:13:32.485Z] [ 89%] Building CXX object src/scriptengines/qml/CMakeFiles/plasma_appletscript_declarative.dir/plasmoid/appletinterface.cpp.o[2020-02-04T06:13:33.073Z] [ 89%] Built target iconitemtest_autogen[2020-02-04T06:13:33.073Z] Scanning dependencies of target pluginloadertest_autogen[2020-02-04T06:13:33.073Z] [ 89%] Automatic MOC for target pluginloadertest[2020-02-04T06:13:33.073Z] [ 89%] Built target dialogqmltest_autogen[2020-02-04T06:13:33.336Z] Scanning dependencies of target framesvgtest[2020-02-04T06:13:33.336Z] [ 89%] Building CXX object autotests/CMakeFiles/framesvgtest.dir/framesvgtest_autogen/mocs_compilation.cpp.o[2020-02-04T06:13:33.336Z] [ 89%] Built target pluginloadertest_autogen[2020-02-04T06:13:33.596Z] Scanning dependencies of target iconitemtest[2020-02-04T06:13:33.596Z] [ 90%] Building CXX object autotests/CMakeFiles/iconitemtest.dir/iconitemtest_autogen/mocs_compilation.cpp.o[2020-02-04T06:13:33.865Z] [ 90%] Building CXX object src/scriptengines/qml/CMakeFiles/plasma_appletscript_declarative.dir/plasmoid/containmentinterface.cpp.o[2020-02-04T06:13:38.161Z] [ 90%] Building CXX object src/declarativeimports/core/CMakeFiles/corebindingsplugin.dir/colorscope.cpp.o[2020-02-04T06:13:38.421Z] [ 90%] Building CXX object autotests/CMakeFiles/framesvgtest.dir/framesvgtest.cpp.o[2020-02-04T06:13:38.680Z] [ 90%] Building CXX object autotests/CMakeFiles/iconitemtest.dir/iconitemtest.cpp.o[2020-02-04T06:13:41.218Z] [ 90%] Building CXX object src/declarativeimports/core/CMakeFiles/corebindingsplugin.dir/datamodel.cpp.o[2020-02-04T06:13:41.475Z] [ 90%] Linking CXX executable ../bin/framesvgtest[2020-02-04T06:13:42.404Z] [ 90%] Building CXX object src/scriptengines/qml/CMakeFiles/plasma_appletscript_declarative.dir/plasmoid/wallpaperinterface.cpp.o[2020-02-04T06:13:42.404Z] [ 90%] Built target framesvgtest[2020-02-04T06:13:43.343Z] [ 90%] Linking CXX executable ../bin/iconitemtest[2020-02-04T06:13:44.272Z] [ 90%] Built target iconitemtest[2020-02-04T06:13:45.215Z] [ 91%] Linking CXX shared module ../../../bin/plasma_appletscript_declarative.so[2020-02-04T06:13:45.215Z] [ 91%] Building CXX object src/declarativeimports/core/CMakeFiles/corebindingsplugin.dir/datasource.cpp.o[2020-02-04T06:13:45.790Z] /usr/lib64/gcc/x86_64-suse-linux/9/../../../../x86_64-suse-linux/bin/ld: CMakeFiles/plasma_appletscript_declarative.dir/plasmoid/containmentinterface.cpp.o: in function `ContainmentInterface::processMimeData(QMimeData*, int, int, KIO::DropJob*)':[2020-02-04T06:13:45.790Z] /home/jenkins/workspace/Plasma/plasma-framework/stable-kf5-qt5 SUSEQt5.12/src/scriptengines/qml/plasmoid/containmentinterface.cpp:444: undefined reference to `DropMenu::DropMenu(KIO::DropJob*, QPoint const&, ContainmentInterface*)'[2020-02-04T06:13:45.790Z] /usr/lib64/gcc/x86_64-suse-linux/9/../../../../x86_64-suse-linux/bin/ld: /home/jenkins/workspace/Plasma/plasma-framework/stable-kf5-qt5 SUSEQt5.12/src/scriptengines/qml/plasmoid/containmentinterface.cpp:472: undefined reference to `DropMenu::setUrls(QList

KDE CI: Plasma » plasma-framework » kf5-qt5 SUSEQt5.12 - Build # 288 - Failure!

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma/job/plasma-framework/job/kf5-qt5%20SUSEQt5.12/288/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Tue, 04 Feb 2020 05:55:08 +
 Build duration:
16 min and counting
   CONSOLE OUTPUT
  [...truncated 946 lines...][2020-02-04T06:11:11.662Z] [ 58%] Building CXX object src/declarativeimports/plasmacomponents/CMakeFiles/plasmacomponentsplugin.dir/enums.cpp.o[2020-02-04T06:11:12.229Z] [ 58%] Building CXX object src/declarativeimports/plasmacomponents/CMakeFiles/plasmacomponentsplugin.dir/qmenu.cpp.o[2020-02-04T06:11:13.615Z] [ 58%] Building CXX object src/declarativeimports/plasmacomponents/CMakeFiles/plasmacomponentsplugin.dir/qmenuitem.cpp.o[2020-02-04T06:11:14.545Z] [ 59%] Linking CXX shared library ../../../bin/libplasmacomponentsplugin.so[2020-02-04T06:11:15.111Z] [ 59%] Built target plasmacomponentsplugin[2020-02-04T06:11:15.111Z] Scanning dependencies of target plasmaextracomponentsplugin[2020-02-04T06:11:15.111Z] [ 59%] Building CXX object src/declarativeimports/plasmaextracomponents/CMakeFiles/plasmaextracomponentsplugin.dir/plasmaextracomponentsplugin_autogen/mocs_compilation.cpp.o[2020-02-04T06:11:16.047Z] [ 59%] Building CXX object src/declarativeimports/plasmaextracomponents/CMakeFiles/plasmaextracomponentsplugin.dir/appbackgroundprovider.cpp.o[2020-02-04T06:11:16.980Z] [ 59%] Building CXX object src/declarativeimports/plasmaextracomponents/CMakeFiles/plasmaextracomponentsplugin.dir/plasmaextracomponentsplugin.cpp.o[2020-02-04T06:11:18.421Z] [ 60%] Building CXX object src/declarativeimports/plasmaextracomponents/CMakeFiles/plasmaextracomponentsplugin.dir/fallbackcomponent.cpp.o[2020-02-04T06:11:18.986Z] [ 60%] Linking CXX shared library ../../../bin/libplasmaextracomponentsplugin.so[2020-02-04T06:11:19.551Z] [ 60%] Built target plasmaextracomponentsplugin[2020-02-04T06:11:19.551Z] Scanning dependencies of target plasma_appletscript_declarative_autogen[2020-02-04T06:11:19.551Z] [ 60%] Generating plasma-scriptengine-applet-declarative.json[2020-02-04T06:11:19.551Z] About to parse service type file "/home/jenkins/workspace/Plasma/plasma-framework/kf5-qt5 SUSEQt5.12/src/plasma/data/servicetypes/plasma-scriptengine.desktop"[2020-02-04T06:11:19.551Z] Found property definition "X-Plasma-ComponentTypes" with type "QStringList"[2020-02-04T06:11:19.551Z] Found property definition "X-Plasma-PackageFormat" with type "QString"[2020-02-04T06:11:19.551Z] Unknown property type for key "X-EngineName" -> falling back to string[2020-02-04T06:11:19.551Z] Unknown property type for key "X-Plasma-API" -> falling back to string[2020-02-04T06:11:19.551Z] Generated  "/home/jenkins/workspace/Plasma/plasma-framework/kf5-qt5 SUSEQt5.12/build/src/scriptengines/qml/plasma-scriptengine-applet-declarative.json"[2020-02-04T06:11:19.551Z] [ 60%] Automatic MOC for target plasma_appletscript_declarative[2020-02-04T06:11:20.127Z] [ 60%] Built target plasma_appletscript_declarative_autogen[2020-02-04T06:11:20.127Z] Scanning dependencies of target framesvgtest_autogen[2020-02-04T06:11:20.127Z] [ 60%] Automatic MOC for target framesvgtest[2020-02-04T06:11:20.385Z] [ 60%] Built target framesvgtest_autogen[2020-02-04T06:11:20.385Z] Scanning dependencies of target pluginloadertest_autogen[2020-02-04T06:11:20.385Z] [ 60%] Automatic MOC for target pluginloadertest[2020-02-04T06:11:20.641Z] [ 60%] Built target pluginloadertest_autogen[2020-02-04T06:11:20.641Z] Scanning dependencies of target iconitemtest_autogen[2020-02-04T06:11:20.899Z] [ 60%] Automatic MOC for target iconitemtest[2020-02-04T06:11:21.159Z] [ 60%] Built target iconitemtest_autogen[2020-02-04T06:11:21.159Z] Scanning dependencies of target dialogqmltest_autogen[2020-02-04T06:11:21.159Z] [ 60%] Automatic MOC for target dialogqmltest[2020-02-04T06:11:21.418Z] [ 60%] Built target dialogqmltest_autogen[2020-02-04T06:11:21.418Z] Scanning dependencies of target dialogstatetest_autogen[2020-02-04T06:11:21.418Z] [ 60%] Automatic MOC for target dialogstatetest[2020-02-04T06:11:21.677Z] [ 60%] Built target dialogstatetest_autogen[2020-02-04T06:11:21.677Z] Scanning dependencies of target themetest_autogen[2020-02-04T06:11:21.677Z] [ 61%] Automatic MOC for target themetest[2020-02-04T06:11:21.934Z] [ 61%] Built target themetest_autogen[2020-02-04T06:11:22.193Z] Scanning dependencies of target dialognativetest_autogen[2020-02-04T06:11:22.193Z] [ 61%] Automatic MOC for target dialognativetest[2020-02-04T06:11:22.455Z] [ 61%] Built target dialognativetest_autogen[2020-02-04T06:11:22.455Z] Scanning dependencies of target configmodeltest_autogen[2020-02-04T06:11:22.455Z] [ 61%] Automatic MOC for target configmodeltest[2020-02-04T06:11:22.715Z] [ 61%] Built target configmodeltest_autogen[2020-02-04T06:11:22.715Z] Scanning dependencies of target corebindingsplugin_autogen[2020-02-04T06:11:22.977Z] [ 61%] Automatic MOC for target corebindingsplugin[2020-02-04T06:11:23.540Z] [ 61%] Built target

D26514: Delay popup when dropping things into containments

2020-02-03 Thread Tranter Madi

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:36e918b09780: Delay popup when dropping things into 
containments (authored by trmdi).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26514?vs=74264=74978

REVISION DETAIL
  https://phabricator.kde.org/D26514

AFFECTED FILES
  containments/desktop/package/contents/ui/FolderView.qml
  containments/desktop/plugins/folder/foldermodel.cpp
  containments/desktop/plugins/folder/foldermodel.h

To: trmdi, #plasma, davidedmundson, broulik, hein
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27149: Scroll the truncated song/artist text when long hovering over it

2020-02-03 Thread Carson Black

cblack added a comment.


  Be sure to add a copyright/license header to the new QML file you added.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  add-tooltip-textWrapper (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27149

To: trmdi, #plasma, #vdg, ndavis
Cc: cblack, ndavis, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27149: Scroll the truncated song/artist text when long hovering over it

2020-02-03 Thread Noah Davis

ndavis accepted this revision.
ndavis added a comment.
This revision is now accepted and ready to land.


  +1

REPOSITORY
  R119 Plasma Desktop

BRANCH
  add-tooltip-textWrapper (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27149

To: trmdi, #plasma, #vdg, ndavis
Cc: ndavis, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27149: Scroll the truncated song/artist text when long hovering over it

2020-02-03 Thread Tranter Madi

trmdi created this revision.
trmdi added reviewers: Plasma, VDG.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
trmdi requested review of this revision.

REVISION SUMMARY
  - When the text is truncated, we could hover over it to read the full text

TEST PLAN
  Everything works well

REPOSITORY
  R119 Plasma Desktop

BRANCH
  add-tooltip-textWrapper (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27149

AFFECTED FILES
  applets/taskmanager/package/contents/ui/TextWrapper.qml
  applets/taskmanager/package/contents/ui/ToolTipInstance.qml

To: trmdi, #plasma, #vdg
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27143: moved do not disturb to the bottom

gvgeo added a comment.


  Calling it footer would be more appropriate now instead of header.
  
  But when there is a separate qml, it is called Toolbar.
  And other applets(e.g. volume), don't mention any name.
  Can we choose a single name(or style)?

REPOSITORY
  R120 Plasma Workspace

BRANCH
  bottom_notification_options (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27143

To: niccolove, ngraham, broulik, #plasma
Cc: gvgeo, plasma-devel, manueljlin, Orage, LeGast00n, The-Feren-OS-Dev, 
cblack, konkinartem, ian, jguidon, hannahk, Ghost6, jraleigh, zachus, MrPepe, 
fbampaloukas, squeakypancakes, alexde, IohannesPetros, GB_2, trickyricky26, 
ragreen, crozbo, ndavis, ZrenBot, firef, ngraham, alexeymin, skadinna, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, aaronhoneycutt, abetts, 
sebas, apol, ahiemstra, mbohlender, mart

D27117: [Applet]Fix device label problems

gvgeo updated this revision to Diff 74971.
gvgeo edited the summary of this revision.
gvgeo added a comment.


  Add comment

REPOSITORY
  R115 Plasma Audio Volume Applet

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27117?vs=74936=74971

BRANCH
  labelWidth2 (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27117

AFFECTED FILES
  applet/contents/ui/ListItemBase.qml

To: gvgeo, #plasma, #vdg, drosca, ngraham, davidedmundson
Cc: cfeck, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27117: [Applet]Fix device label problems

ngraham added a comment.


  Ah I see why you did it then. That makes some sense. Can you add a comment 
explaining this?

REPOSITORY
  R115 Plasma Audio Volume Applet

REVISION DETAIL
  https://phabricator.kde.org/D27117

To: gvgeo, #plasma, #vdg, drosca, ngraham, davidedmundson
Cc: cfeck, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27117: [Applet]Fix device label problems

gvgeo added a comment.


  It works like you said. The problem is that will be too easy, accidentally to 
change the default device. It is not right for the empty space, without any 
indication, to change your device.

REPOSITORY
  R115 Plasma Audio Volume Applet

REVISION DETAIL
  https://phabricator.kde.org/D27117

To: gvgeo, #plasma, #vdg, drosca, ngraham, davidedmundson
Cc: cfeck, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27138: [Applet]Restore naming convention for devices.

gvgeo added a comment.


  In D27138#605645 , @ngraham wrote:
  
  > > Makes 1 check and apply both for playback and recording devices.
  >
  > Are you sure that makes sense? If I have two outputs but only one input (a 
common setup) then I don't want my microphone having an unnecessarily long 
description. Might be nicer to keep the current approach of checking for 
multiple inputs and outputs separately IMO.
  
  
  And maybe wander which device has the mic.
  I would love to hear from others, If they have a preference on this. 2 
separate checks or 1 ?
  
  I will make the change later.

REPOSITORY
  R115 Plasma Audio Volume Applet

REVISION DETAIL
  https://phabricator.kde.org/D27138

To: gvgeo, #plasma, #vdg, drosca, ngraham
Cc: cgiboudeaux, broulik, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra, mart

D25006: Make sure -dpi value is valid

2020-02-03 Thread Gabriel Craciunescu

gcraciunescu marked 2 inline comments as done.
gcraciunescu added a comment.


  In D25006#605578 , @filipf wrote:
  
  > David's suggestion to just turn `dpiValue` into an int sounds sensible to 
me. @gcraciunescu do you want to finish this patch?
  
  
  I think you guys need to agree on something first. I don' mind if someone 
else commits a fix for that.

REPOSITORY
  R123 SDDM Configuration Panel (KCM)

REVISION DETAIL
  https://phabricator.kde.org/D25006

To: gcraciunescu, filipf, #plasma, ngraham, davidedmundson
Cc: davidedmundson, ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27077: [RFC] [Logout screen] Shorten timeout to 10 seconds

ngraham abandoned this revision.
ngraham added a comment.


  All right, sounds like this isn't a clear winner.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D27077

To: ngraham, #vdg, #plasma
Cc: ahiemstra, rikmills, broulik, cfeck, davidedmundson, plasma-devel, Orage, 
LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, 
ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D27144: Moved toggles to the bottom according to T10470

ngraham requested changes to this revision.
ngraham added a comment.
This revision now requires changes to proceed.


  Now when Bluetooth is on but there are no devices, the applet looks like this:
  
  F8083748: Screenshot_20200203_150046.png 

  
  This popup should really be written with layouts instead of anchors; then it 
would be trivial to just add an item in the middle with `Layout.fillWidth: 
true` in it. As-is, you'll need to approximate that with anchors.
  
  Or you could rewrite it with Layouts first, and then do this afterwards.
  
  Your call.

REPOSITORY
  R97 Bluedevil

REVISION DETAIL
  https://phabricator.kde.org/D27144

To: niccolove, #plasma, #vdg, ngraham
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27138: [Applet]Restore naming convention for devices.

ngraham added a comment.


  > Makes 1 check and apply both for playback and recording devices.
  
  Are you sure that makes sense? If I have two outputs but only one input (a 
common setup) then I don't want my microphone having an unnecessarily long 
description. Might be nicer to keep the current approach of checking for 
multiple inputs and outputs separately IMO.

REPOSITORY
  R115 Plasma Audio Volume Applet

REVISION DETAIL
  https://phabricator.kde.org/D27138

To: gvgeo, #plasma, #vdg, drosca, ngraham
Cc: cgiboudeaux, broulik, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra, mart

D27117: [Applet]Fix device label problems

ngraham requested changes to this revision.
ngraham added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> ngraham wrote in ListItemBase.qml:120
> This feels wrong. The radio button shouldn't need a maximum width set on it.

Replace this line with `Layout.fillWidth: true`. This works because `soloLabel` 
and `defaultButton` will never be visible at the same time; when `soloLabel` 
isn't visible, then the radio button's label will be the item that's filling 
the width.

REPOSITORY
  R115 Plasma Audio Volume Applet

REVISION DETAIL
  https://phabricator.kde.org/D27117

To: gvgeo, #plasma, #vdg, drosca, ngraham, davidedmundson
Cc: cfeck, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27136: [Cuttlefish] Remove last traces of themes and plasma themes

ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  Makes sense to me since we actually don't have a UI for this anymore, so the 
code is orphaned.

REPOSITORY
  R118 Plasma SDK

BRANCH
  remove-plasma

REVISION DETAIL
  https://phabricator.kde.org/D27136

To: davidre, #plasma, ngraham
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27144: Moved toggles to the bottom according to T10470

2020-02-03 Thread Niccolò Venerandi

niccolove created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
niccolove requested review of this revision.

REPOSITORY
  R97 Bluedevil

BRANCH
  move_toggle_to_bottom (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27144

AFFECTED FILES
  src/applet/package/contents/ui/FullRepresentation.qml
  src/applet/package/contents/ui/Toolbar.qml

To: niccolove
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26895: Introduce an Info Center mode

ngraham added a comment.


  In D26895#605255 , @ovichiro wrote:
  
  > Not sure it's my place to do so, but I'd like to make a small comment.  
  >  Instead of passing `mode` around and all the `if` statements, wouldn't it 
be better to have a single decision point in `main.cpp`, like a factory class?  
  >  Use polymorphism and create something like `InfoCenter : CommonParent`, 
`SystemSettings : CommonParent`, each knowing how to initialize their 
`KAboutData`, GUI elements, icons etc.?  
  >  And in `main.cpp` do something like `CommonParent * commonParent = new 
InfoCenter() // or new SystemSettings()` and use that instead of `mode`.  
  >  Further down the road, if you need to add something to system settings, 
you could do it in the SystemSettings class maybe and not have to add another 
`if` to remove it from the InfoCenter part. Just a thought, not sure if it fits.
  
  
  Sounds sensible. Would you like to submit a patch?

REPOSITORY
  R124 System Settings

REVISION DETAIL
  https://phabricator.kde.org/D26895

To: mart, #plasma, davidedmundson
Cc: ngraham, ovichiro, meven, davidedmundson, broulik, plasma-devel, Orage, 
LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, 
ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, ahiemstra, mart

D27142: Have authhelper define config file paths on its own

davidedmundson added inline comments.

INLINE COMMENTS

> sddmkcm.cpp:55
>  
> -mSddmConfig = 
> KSharedConfig::openConfig(QStringLiteral(SDDM_CONFIG_FILE), 
> KConfig::CascadeConfig);
> +mSddmConfig = KSharedConfig::openConfig(QString 
> {QLatin1String(SDDM_CONFIG_DIR "/") + QStringLiteral("kde_settings.conf")}, 
> KConfig::CascadeConfig);
>  

I don't think this is right.

This file is added below:

  systemConfigFiles = 
QDir(QLatin1String(SDDM_SYSTEM_CONFIG_DIR)).entryList(QDir::Files | 
QDir::NoDotAndDotDot, QDir::LocaleAware);

loops through every file in /etc/sddm.conf.d

REPOSITORY
  R123 SDDM Configuration Panel (KCM)

REVISION DETAIL
  https://phabricator.kde.org/D27142

To: filipf, #plasma, davidedmundson
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27143: moved do not disturb to the bottom

2020-02-03 Thread Niccolò Venerandi

niccolove created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
niccolove requested review of this revision.

REVISION SUMMARY
  As per T10470 , I moved the notification 
do not disturb buttons to the bottom

TEST PLAN
  *just a sec*

REPOSITORY
  R120 Plasma Workspace

BRANCH
  bottom_notification_options (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27143

AFFECTED FILES
  applets/notifications/package/contents/ui/FullRepresentation.qml

To: niccolove
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26813: Have user-manager write to SDDM's new config file

filipf planned changes to this revision.
filipf added inline comments.

INLINE COMMENTS

> accountmodel.cpp:45
>  {
> -KConfig config(QStringLiteral(SDDM_CONFIG_FILE));
> +KConfig config(QStringLiteral("kde_settings"));
>  m_autoLoginUser = config.group("Autologin").readEntry("User", QString());

actually this is wrong I don't know what to specify without typing out the 
path here again

REPOSITORY
  R128 User Manager

REVISION DETAIL
  https://phabricator.kde.org/D26813

To: filipf, #plasma, davidedmundson, ngraham
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25006: Make sure -dpi value is valid

filipf added a comment.


  David's suggestion to just turn `dpiValue` into an int sounds sensible to me. 
@gcraciunescu do you want to finish this patch?

REPOSITORY
  R123 SDDM Configuration Panel (KCM)

REVISION DETAIL
  https://phabricator.kde.org/D25006

To: gcraciunescu, filipf, #plasma, ngraham, davidedmundson
Cc: davidedmundson, ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26813: Have user-manager write to SDDM's new config file

filipf added a comment.


  In D26813#598252 , @davidedmundson 
wrote:
  
  > We could move the full file path to the helper rather than having the 
calling user send it.
  >  I'll be more secure that way.
  
  
  This should work now with the dependent revision.

REPOSITORY
  R128 User Manager

BRANCH
  write-autologin-right (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D26813

To: filipf, #plasma, davidedmundson, ngraham
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27142: Have authhelper

filipf created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
filipf requested review of this revision.

REVISION SUMMARY
  Suggested for D26813 . Prerequiste if 
user-manager is to not send any SDDM config file path on its own.
  
  The config file paths are now defined in the authhelper as opposed to being 
sent in a variant map from the main kcm file.
  
  I also edited paths in that main file because they were wrong.
  
  This does not yet solve bug 414396.
  
  CC-BUG: 342722

REPOSITORY
  R123 SDDM Configuration Panel (KCM)

BRANCH
  decoupled-config-path (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27142

AFFECTED FILES
  sddmauthhelper.cpp
  src/sddmkcm.cpp

To: filipf
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26813: Have user-manager write to SDDM's new config file

filipf updated this revision to Diff 74954.
filipf added a comment.


  don't define any sort of sddm config file path in user manager (needs an 
additional sddm patch I'm going to send in now)

REPOSITORY
  R128 User Manager

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26813?vs=74035=74954

BRANCH
  write-autologin-right (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D26813

AFFECTED FILES
  src/lib/accountmodel.cpp

To: filipf, #plasma, davidedmundson, ngraham
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27037: [Notifications] Fixup setSourceModel

davidedmundson added a comment.


  QAbstractSortFilterProxyModel has docs that say you need it, but 
QSortFilterProxyModel which you inherit from does reset the model in 
setSourceModel.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D27037

To: broulik, #plasma
Cc: davidedmundson, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27117: [Applet]Fix device label problems

gvgeo added a subscriber: cfeck.
gvgeo added a comment.


  Tried couple themes, but could not reproduce the color problem. 
https://bugs.kde.org/show_bug.cgi?id=417106
  Hopefully this change make sense.

INLINE COMMENTS

> ListItemBase.qml:126
>  
> -Label {
> +PlasmaComponents3.Label {
>  id: soloLabel

Is this all it needs to fix text color bug?

REPOSITORY
  R115 Plasma Audio Volume Applet

REVISION DETAIL
  https://phabricator.kde.org/D27117

To: gvgeo, #plasma, #vdg, drosca, ngraham, davidedmundson
Cc: cfeck, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27079: Don't escape search text in search page title

ngraham updated this revision to Diff 74948.
ngraham added a comment.


  Just strip all html tags

REPOSITORY
  R134 Discover Software Store

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27079?vs=74822=74948

BRANCH
  show-search-text-un-escaped (branched from Plasma/5.18)

REVISION DETAIL
  https://phabricator.kde.org/D27079

AFFECTED FILES
  discover/qml/ApplicationsListPage.qml

To: ngraham, #vdg, #discover_software_store, apol
Cc: plasma-devel, apol, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, ahiemstra, mart

D27138: [Applet]Restore naming convention for devices.

gvgeo created this revision.
gvgeo added reviewers: Plasma, VDG, drosca, ngraham.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
gvgeo requested review of this revision.

REVISION SUMMARY
  Restores naming convention for devices, before the Layout update.
  Display both device name and port if there is more than one device.
  Makes 1 check and apply both for playback and recording devices.

REPOSITORY
  R115 Plasma Audio Volume Applet

BRANCH
  devicesCount (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27138

AFFECTED FILES
  applet/contents/ui/DeviceListItem.qml
  applet/contents/ui/main.qml

To: gvgeo, #plasma, #vdg, drosca, ngraham
Cc: cgiboudeaux, broulik, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra, mart

D27079: Don't escape search text in search page title

2020-02-03 Thread Aleix Pol Gonzalez

apol added a comment.


  They shouldn't that doesn't mean we should style it when they do.

REPOSITORY
  R134 Discover Software Store

REVISION DETAIL
  https://phabricator.kde.org/D27079

To: ngraham, #vdg, #discover_software_store, apol
Cc: plasma-devel, apol, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, ahiemstra, mart

D26895: Introduce an Info Center mode

2020-02-03 Thread Ovidiu Chi

ovichiro added inline comments.

INLINE COMMENTS

> main.cpp:68
> +aboutData = KAboutData(QStringLiteral("systemsettings"), 
> i18n("System Settings"), QLatin1String(PROJECT_VERSION), i18n("Central 
> configuration center by KDE."), KAboutLicense::GPL, i18n("(c) 2009, Ben 
> Cooksley"));
> +aboutData.addAuthor(i18n("Ben Cooksley"), i18n("Maintainer"), 
> QStringLiteral("bcooks...@kde.org"));
> +aboutData.addAuthor(i18n("Mathias Soeken"), i18n("Developer"), 
> QStringLiteral("msoe...@informatik.uni-bremen.de"));

The authors should maybe be moved outside if-else since they are the same for 
both branches.

REPOSITORY
  R124 System Settings

REVISION DETAIL
  https://phabricator.kde.org/D26895

To: mart, #plasma, davidedmundson
Cc: ovichiro, meven, davidedmundson, broulik, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, 
ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, ahiemstra, mart

D27079: Don't escape search text in search page title

ngraham added a comment.


  Why would the user enter `my potato`?

REPOSITORY
  R134 Discover Software Store

REVISION DETAIL
  https://phabricator.kde.org/D27079

To: ngraham, #vdg, #discover_software_store, apol
Cc: plasma-devel, apol, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, ahiemstra, mart

D26891: Upgrade theme to Breeze GTK on startup

2020-02-03 Thread Fabian Vogt

fvogt accepted this revision.
fvogt added a comment.


  In D26891#605464 , @ngraham wrote:
  
  > LGTM now. @meven and @fvogt, you good with this too?
  
  
  Not sure what the rename was about, but yes, still LGTM.

REPOSITORY
  R99 KDE Gtk Configuration Tool

BRANCH
  apply-theme-on-startup (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D26891

To: gikari, fvogt, ngraham
Cc: ngraham, meven, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26891: Upgrade theme to Breeze GTK on startup

ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  LGTM now. @meven and @fvogt, you good with this too?

REPOSITORY
  R99 KDE Gtk Configuration Tool

BRANCH
  apply-theme-on-startup (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D26891

To: gikari, fvogt, ngraham
Cc: ngraham, meven, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27137: Handle spawning kinfocenter with a full path

ngraham added a comment.


  If you manually create a symlink called `my-kinfocenter` that points to 
`systemsettings` then clearly you're actually trying to make kinfocenter open 
just with a different binary name for your own convenience, so this new code is 
actually more correct.

REPOSITORY
  R124 System Settings

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D27137

To: davidedmundson, #plasma, ngraham
Cc: pino, ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27137: Handle spawning kinfocenter with a full path

2020-02-03 Thread Pino Toscano

pino added a comment.


  In D27137#605459 , @davidedmundson 
wrote:
  
  > If you run /usr/bin/my-kinfocenter you wouldn't spawn this executable in 
the first place
  
  
  Hello symlink my old friend...

REPOSITORY
  R124 System Settings

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D27137

To: davidedmundson, #plasma, ngraham
Cc: pino, ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27137: Handle spawning kinfocenter with a full path

davidedmundson added a comment.


  If you run /usr/bin/my-kinfocenter you wouldn't spawn this executable in the 
first place

REPOSITORY
  R124 System Settings

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D27137

To: davidedmundson, #plasma, ngraham
Cc: pino, ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27137: Handle spawning kinfocenter with a full path

2020-02-03 Thread Pino Toscano

pino added inline comments.

INLINE COMMENTS

> main.cpp:42
> +BaseMode::ApplicationMode mode = BaseMode::SystemSettings;
> +if (executableName.endsWith(QLatin1String("kinfocenter"))) {
> +binaryName = QStringLiteral("kinfocenter");

This will consider also `/usr/bin/my-kinfocenter` as kinfocenter, which is 
definitely not what you want.

REPOSITORY
  R124 System Settings

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D27137

To: davidedmundson, #plasma, ngraham
Cc: pino, ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27137: Handle spawning kinfocenter with a full path

ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  Nice fix.

REPOSITORY
  R124 System Settings

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D27137

To: davidedmundson, #plasma, ngraham
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27137: Handle spawning kinfocenter with a full path

davidedmundson created this revision.
davidedmundson added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
davidedmundson requested review of this revision.

REVISION SUMMARY
  /usr/bin/kinfocenter doesn't match "kinfocenter"
  
  it also cannot be using as the binaryName in the rest of this method.

TEST PLAN
  Launched
  systemsettings5
  kinfocenter
  /opt/kde5/bin/kinfocenter

REPOSITORY
  R124 System Settings

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D27137

AFFECTED FILES
  app/main.cpp

To: davidedmundson, #plasma
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27136: [Cuttlefish] Remove last traces of themes and plasma themes

2020-02-03 Thread David Redondo

davidre created this revision.
davidre added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
davidre requested review of this revision.

REVISION SUMMARY
  As far as I can tell plasma theme support was only used for a checkbox to 
override
  icons with plasma icons from the current plasma theme. Also icons with names 
in
  the plasma but not icon theme were shown at the bottom of the grid. This was
  removed with 727fd286bca468d093218b507e0516b59c237284 
. 
Themeexplorer is probably
  the right place anyways to view plasma theme icons. Different icon themes were
  never supported?

TEST PLAN
  No difference

REPOSITORY
  R118 Plasma SDK

BRANCH
  remove-plasma

REVISION DETAIL
  https://phabricator.kde.org/D27136

AFFECTED FILES
  cuttlefish/package/contents/ui/SvgGrid.qml
  cuttlefish/package/contents/ui/cuttlefish.qml
  cuttlefish/src/iconmodel.cpp
  cuttlefish/src/iconmodel.h

To: davidre, #plasma
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27090: Replace config.h with target_compile_definitions

2020-02-03 Thread Aleix Pol Gonzalez

apol added a comment.


  I wouldn't say it's simpler. If anything it's easier to inspect the value 
that is being passed from your editor.

REPOSITORY
  R99 KDE Gtk Configuration Tool

REVISION DETAIL
  https://phabricator.kde.org/D27090

To: gikari
Cc: apol, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, ahiemstra, mart

D27079: Don't escape search text in search page title

2020-02-03 Thread Aleix Pol Gonzalez

apol added a comment.


  Because if you enter `my potato` it gets styled, which shouldn't 
happen.
  
  I suggest just doing the following:
  
diff --git a/discover/qml/ApplicationsListPage.qml 
b/discover/qml/ApplicationsListPage.qml
index 4445a195..e094b667 100644
--- a/discover/qml/ApplicationsListPage.qml
+++ b/discover/qml/ApplicationsListPage.qml
@@ -52,11 +52,8 @@ DiscoverPage {
 
 function escapeHtml(unsafe) {
 return unsafe
-.replace(/&/g, "")
 .replace(//g, "")
-.replace(/"/g, "")
-.replace(/'/g, "");
+.replace(/>/g, "");
 }
 
 background: Rectangle {

REPOSITORY
  R134 Discover Software Store

REVISION DETAIL
  https://phabricator.kde.org/D27079

To: ngraham, #vdg, #discover_software_store, apol
Cc: plasma-devel, apol, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, ahiemstra, mart

D27134: [Notifications] Don't dodge notification popups

ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  Clever!

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D27134

To: broulik, #plasma, ngraham
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27135: Add PagePoolAction to QRC file

2020-02-03 Thread Mason McParlane

masonm created this revision.
masonm added a reviewer: VDG.
masonm added projects: Kirigami, VDG.
Herald added a subscriber: plasma-devel.
masonm requested review of this revision.

REVISION SUMMARY
  Missing PagePoolAction causes crash on static builds

TEST PLAN
  Create/launch static build before and after. Before will crash due to missing 
PagePoolAction.qml file.

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D27135

AFFECTED FILES
  kirigami.qrc.in

To: masonm, #vdg
Cc: plasma-devel, manueljlin, Orage, cblack, konkinartem, ian, jguidon, 
hannahk, Ghost6, jraleigh, MrPepe, fbampaloukas, squeakypancakes, alexde, 
IohannesPetros, GB_2, trickyricky26, domson, crozbo, dkardarakos, ndavis, 
firef, ngraham, skadinna, aaronhoneycutt, apol, ahiemstra, davidedmundson, 
mbohlender, mart, hein

D27134: [Notifications] Don't dodge notification popups

broulik updated this revision to Diff 74941.
broulik added a comment.


  - Remove check for self since we know that this is always a popup

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27134?vs=74939=74941

REVISION DETAIL
  https://phabricator.kde.org/D27134

AFFECTED FILES
  applets/notifications/package/contents/ui/global/Globals.qml

To: broulik, #plasma
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27134: [Notifications] Don't dodge notification popups

broulik created this revision.
broulik added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
broulik requested review of this revision.

REVISION SUMMARY
  This wasn't an issue before as notification popups could never have focus.
  However, now with quick reply, they can, leading to funky results and gaps 
when a notification appears while answering another one.

TEST PLAN
  5.18 please
  
  - Ran `sleep 3; notify-send foo bar` and then spawned a quick reply 
notification and clicked the text field.
  
  Previously I Would end up with weird situations like this, where the new 
notification popup would try to avoid the focussed popup, which then would also 
shift downwards to avoid the other popup, etc
  F8080601: Screenshot_20200203_174039.PNG 

  With this patch they are always placed correctly.
  
  They still avoid systray popups and the calendar as before

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D27134

AFFECTED FILES
  applets/notifications/package/contents/ui/global/Globals.qml

To: broulik, #plasma
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27117: [Applet]Fix device label problems

gvgeo updated this revision to Diff 74936.
gvgeo edited the test plan for this revision.
gvgeo added a comment.


  Code style

REPOSITORY
  R115 Plasma Audio Volume Applet

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27117?vs=74933=74936

BRANCH
  labelWidth2 (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27117

AFFECTED FILES
  applet/contents/ui/ListItemBase.qml

To: gvgeo, #plasma, #vdg, drosca, ngraham, davidedmundson
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27131: [Applet]Fix device label problems

gvgeo abandoned this revision.
gvgeo added a comment.


  A mistake...

REPOSITORY
  R115 Plasma Audio Volume Applet

REVISION DETAIL
  https://phabricator.kde.org/D27131

To: gvgeo, #plasma, #vdg, drosca, ngraham, davidedmundson
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27131: [Applet]Fix device label problems

gvgeo created this revision.
gvgeo added reviewers: Plasma, VDG, drosca, ngraham, davidedmundson.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
gvgeo requested review of this revision.

REVISION SUMMARY
  Limit label maximum width, to avoid breaking UI.
  Change label to use plasma components 3, for theme color compatibility.
  Use of implicit sizes, to avoid binding loops.
  
  Note: Didn't make use fillWidth because we need the button area to be
  only on the text, and not in the empty area.

TEST PLAN
  Use applet outside of systemtray and limit it's width.
  If device description is not long enough, enable in the configuration
  "Add virtual output device for simultaneous output on all local sound cars".
  Before: Hamburger menu moves to the right, and there is no eliding.
  After: Proper display.
  
  BUG: 417074
  BUG: 417106

REPOSITORY
  R115 Plasma Audio Volume Applet

BRANCH
  labelWidth2 (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27131

AFFECTED FILES
  applet/contents/ui/ListItemBase.qml

To: gvgeo, #plasma, #vdg, drosca, ngraham, davidedmundson
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27117: [Applet]Fix long device name

gvgeo updated this revision to Diff 74933.
gvgeo added a comment.


  Simplify.
  Fix label color issues.

REPOSITORY
  R115 Plasma Audio Volume Applet

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27117?vs=74898=74933

BRANCH
  labelWidth2 (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27117

AFFECTED FILES
  applet/contents/ui/ListItemBase.qml

To: gvgeo, #plasma, #vdg, drosca, ngraham, davidedmundson
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27126: [SNI] Fix race condition in item registration

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:31303ad3542b: [SNI] Fix race condition in item 
registration (authored by kmaterka).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27126?vs=74929=74932

REVISION DETAIL
  https://phabricator.kde.org/D27126

AFFECTED FILES
  statusnotifierwatcher/statusnotifierwatcher.cpp

To: kmaterka, #plasma_workspaces, #plasma, davidedmundson
Cc: davidedmundson, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27130: [Notifications] For group parents combine the child bodies

broulik created this revision.
broulik added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
broulik requested review of this revision.

REVISION SUMMARY
  This enables some basic grouping when pointing a list at the group parents 
instead of the individual child elements.
  Effectively unused right now (popups don't group and history only shows the 
application name for sections) but this is in preparation for being able to 
have groups in the popup as well.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D27130

AFFECTED FILES
  libnotificationmanager/notificationgroupingproxymodel.cpp

To: broulik, #plasma
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27126: [SNI] Fix race condition in item registration

davidedmundson accepted this revision.
davidedmundson added inline comments.
This revision is now accepted and ready to land.

INLINE COMMENTS

> kmaterka wrote in statusnotifierwatcher.cpp:69
> Is this OK? Are mid-method returns allowed?

They are

REPOSITORY
  R120 Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D27126

To: kmaterka, #plasma_workspaces, #plasma, davidedmundson
Cc: davidedmundson, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27129: [Notifications] Allow expiring an entire group

broulik updated this revision to Diff 74930.
broulik added a comment.


  - Don't expire when already expired

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27129?vs=74928=74930

REVISION DETAIL
  https://phabricator.kde.org/D27129

AFFECTED FILES
  libnotificationmanager/notifications.cpp

To: broulik, #plasma
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27126: [SNI] Fix race condition in item registration

kmaterka added inline comments.

INLINE COMMENTS

> statusnotifierwatcher.cpp:69
> +if (m_registeredServices.contains(notifierItemId)) {
> +return;
> +}

Is this OK? Are mid-method returns allowed?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D27126

To: kmaterka, #plasma_workspaces, #plasma
Cc: davidedmundson, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27129: [Notifications] Allow expiring an entire group

broulik created this revision.
broulik added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
broulik requested review of this revision.

REVISION SUMMARY
  Similar to how we can close an entire group at once.
  This is in preparation for being able to have groups in the popup as well.

TEST PLAN
  - Invoked expire on a group, had all items expire

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D27129

AFFECTED FILES
  libnotificationmanager/notifications.cpp

To: broulik, #plasma
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27126: [SNI] Fix race condition in item registration

kmaterka updated this revision to Diff 74929.
kmaterka added a comment.


  Updated the code. This time I was not event able to reproduce race condition. 
Is something like this OK?

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27126?vs=74924=74929

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D27126

AFFECTED FILES
  statusnotifierwatcher/statusnotifierwatcher.cpp

To: kmaterka, #plasma_workspaces, #plasma
Cc: davidedmundson, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27128: [Cuttlefish] --warnings

2020-02-03 Thread David Redondo

This revision was automatically updated to reflect the committed changes.
Closed by commit R118:fcd8b650d119: [Cuttlefish] --warnings (authored by 
davidre).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D27128?vs=74926=74927#toc

REPOSITORY
  R118 Plasma SDK

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27128?vs=74926=74927

REVISION DETAIL
  https://phabricator.kde.org/D27128

AFFECTED FILES
  cuttlefish/package/contents/ui/IconGridDelegate.qml

To: davidre, ngraham
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27117: [Applet]Fix long device name

gvgeo planned changes to this revision.
gvgeo added inline comments.

INLINE COMMENTS

> ListItemBase.qml:132
>  id: soloLabel
> +Layout.maximumWidth: 
> defaultButton.Layout.maximumWidth
>  text: defaultButton.text

This will also solve the complexity of this patch.

REPOSITORY
  R115 Plasma Audio Volume Applet

REVISION DETAIL
  https://phabricator.kde.org/D27117

To: gvgeo, #plasma, #vdg, drosca, ngraham, davidedmundson
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D14562: Introduce Theme.smallestFont

2020-02-03 Thread Marco Martin

mart added inline comments.

INLINE COMMENTS

> volkov wrote in kirigamiplugin.cpp:173
> So, should it be registered for both versions 2.2 and 2.6?
> I tried to use revisions, but it looks like they don't work for properties of 
> attached property objects:
> https://doc.qt.io/qt-5/qtqml-cppintegration-definetypes.html#type-revisions-and-versions
> One can import kirigami 2.2 and use smallestFont.

Register it just for 2.2 and forget about revisions.
They're a broken concept and they will be removed in Qt6 anyways

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D14562

To: volkov, #kirigami, mart
Cc: mart, plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, ngraham, apol, 
ahiemstra, davidedmundson, hein

D27128: [Cuttlefish] --warnings

ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  5.18 please

REPOSITORY
  R118 Plasma SDK

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D27128

To: davidre, ngraham
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27057: Solid-device-automounter/kcm: Enable/Disable columns automount onLogin/onAttached depending on corresponding checkbox

ngraham added a comment.


  Conceptually +1.
  
  It's not related to this patch, but looking at the table, it would be nice to 
move from a tree view into a list view with section headers, like how the 
GLobal Shortcuts KCM does.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D27057

To: meven, #plasma, ervin, ngraham, broulik
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27117: [Applet]Fix long device name

ngraham added inline comments.

INLINE COMMENTS

> ListItemBase.qml:120
>  id: defaultButton
> +Layout.maximumWidth: controlsRow.width - 
> (clientIcon.visible ? clientIcon.width + units.smallSpacing : 0)
> +  - (contextMenuButton.visible ? 
> contextMenuButton.implicitWidth + units.smallSpacing : 0)

This feels wrong. The radio button shouldn't need a maximum width set on it.

> ListItemBase.qml:132
>  id: soloLabel
> +Layout.maximumWidth: 
> defaultButton.Layout.maximumWidth
>  text: defaultButton.text

Instead of giving this label a maximum width, maybe you could just have it be 
the item in the layout that gets `Layout.fillWidth: true` and then remove the 
`Item` below it

REPOSITORY
  R115 Plasma Audio Volume Applet

REVISION DETAIL
  https://phabricator.kde.org/D27117

To: gvgeo, #plasma, #vdg, drosca, ngraham, davidedmundson
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27036: KApiDox: add "Plasma Workspaces Libraries" group info

2020-02-03 Thread Friedrich W. H. Kossebau

kossebau resigned from this revision.
kossebau added a comment.


  Good. So stepping out here :)

REPOSITORY
  R129 Window Decoration Library

REVISION DETAIL
  https://phabricator.kde.org/D27036

To: davidedmundson, #plasma
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27128: [Cuttlefish] --warnings

2020-02-03 Thread David Redondo

davidre created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
davidre requested review of this revision.

REPOSITORY
  R118 Plasma SDK

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D27128

AFFECTED FILES
  cuttlefish/package/contents/ui/IconGridDelegate.qml

To: davidre
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27127: Solid-device-automounter/kcm: Use KConfigXT in ui

2020-02-03 Thread Méven Car

meven created this revision.
meven added reviewers: ervin, ngraham, Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
meven requested review of this revision.

REVISION SUMMARY
  - Make default button work
  - Move connection from cpp to .ui
  - Slight label change

TEST PLAN
  Use default button

REPOSITORY
  R119 Plasma Desktop

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D27127

AFFECTED FILES
  solid-device-automounter/kcm/DeviceAutomounterKCM.cpp
  solid-device-automounter/kcm/DeviceAutomounterKCM.h
  solid-device-automounter/kcm/DeviceAutomounterKCM.ui

To: meven, ervin, ngraham, #plasma
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26895: Introduce an Info Center mode

2020-02-03 Thread Ovidiu Chi

ovichiro added a comment.


  Not sure it's my place to do so, but I'd like to make a small comment.  
  Instead of passing `mode` around and all the `if` statements, wouldn't it be 
better to have a single decision point in `main.cpp`, like a factory class?  
  Use polymorphism and create something like `InfoCenter : CommonParent`, 
`SystemSettings : CommonParent`, each knowing how to initialize their 
`KAboutData`, GUI elements, icons etc.?  
  And in `main.cpp` do something like `CommonParent * commonParent = new 
InfoCenter() // or new SystemSettings()` and use that instead of `mode`.  
  Further down the road, if you need to add something to system settings, you 
could do it in the SystemSettings class maybe and not have to add another `if` 
to remove it from the InfoCenter part. Just a thought, not sure if it fits.

REPOSITORY
  R124 System Settings

REVISION DETAIL
  https://phabricator.kde.org/D26895

To: mart, #plasma, davidedmundson
Cc: ovichiro, meven, davidedmundson, broulik, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, 
ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, ahiemstra, mart

D27126: [SNI] Fix race condition in item registration

davidedmundson added a comment.


  Well identified, it is racey.
  
  But the solution seems off
  
  on line 68 we check
  on line 75 we implicitly check again
  now we're checking a 3rd time!
  
  I think we can instead solve it with some re-arranging
  
 m_serviceWatcher->addWatchedService(service);
 if 
(QDBusConnection::sessionBus().interface()->isServiceRegistered(service).value())
  {
  // as before except for the moved line
} else {
  m_serviceWatcher->removeWatchedService(service);
}

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D27126

To: kmaterka, #plasma_workspaces, #plasma
Cc: davidedmundson, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27077: [RFC] [Logout screen] Shorten timeout to 10 seconds

2020-02-03 Thread Arjen Hiemstra

ahiemstra added a comment.


  > So maybe this isn't actually a destructive action at all. After all, an app 
with unsaved changes or active processed will block the logout/shutdown absent 
user interaction.
  
  That only happens if you happen to have unsaved changes. Many applications 
will simply abort any active ongoing process when asked to shutdown. The entire 
thing is a destructive action because of the major workflow interruption it 
causes, not necessarily only because of the risk of losing data.
  
  > Windows no longer even uses a "confirm logout" dialog anymore AFAIK. 
However macOS does, with a 60-second timeout.
  
  And opinions are quite mixed on whether that was a good idea or not. See 
https://social.technet.microsoft.com/Forums/lync/en-US/9cf7e889-20bd-442e-bd4a-4d23a6e10ba6/windows-7-confirmation-when-clicking-shutdown
 for example.
  
  > If I think about it a bit more, what makes sense to me is to never show the 
logout screen in response to a user-initiated action to choose a specific 
action (e.g. choose log out, shut down, etc from Kickoff). In this case, the 
user already knows what they want to happen and asking them to confirm is just 
annoying. However, when pressing the power button, the multi-option screen 
should be shown by default, with no timeout at all so you need to deliberately 
choose an option.
  
  This is making a big assumption: That you never end up accidentally clicking 
one of the shutdown options. I do not think that is true at all, I know I have 
done this. In addition, with the proposed changes in 
https://phabricator.kde.org/T12192 I can see that happening much more often.
  
  For people that are really bothered by it, we already have the option to not 
ask for confirmation. I do not think we should remove the confirmation, though 
I do not have a strong opinion on whether there should be a timeout or how long 
that timeout should be.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D27077

To: ngraham, #vdg, #plasma
Cc: ahiemstra, rikmills, broulik, cfeck, davidedmundson, plasma-devel, Orage, 
LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, 
ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D27126: [SNI] Fix race condition in item registration

kmaterka added a comment.


  It is hard to reproduce, but with enough tries you should get empty items in 
"hidden" area of system tray. I used this script:
  
for i in `seq 1 100`; do
echo $i
telegram-desktop &
sleep 2
killall telegram-desktop
done

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D27126

To: kmaterka, #plasma_workspaces, #plasma
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27126: [SNI] Fix race condition in item registration

kmaterka created this revision.
kmaterka added reviewers: Plasma: Workspaces, Plasma.
kmaterka added a project: Plasma.
kmaterka requested review of this revision.

REVISION SUMMARY
  If StatusNotifierItem is registered and then immediately destroyed, it is 
possible that QDBusServiceWatcher will not emit the serviceUnregistered signal.
  Add an additional check to avoid such situations.
  
  BUG: 416652
  FIXED-IN: 5.18.0

TEST PLAN
  Telegram should not add empty items.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D27126

AFFECTED FILES
  statusnotifierwatcher/statusnotifierwatcher.cpp

To: kmaterka, #plasma_workspaces, #plasma
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27057: Solid-device-automounter/kcm: Enable/Disable columns automount onLogin/onAttached depending on corresponding checkbox

2020-02-03 Thread Méven Car

meven updated this revision to Diff 74920.
meven added a comment.


  Improved flag function

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27057?vs=74782=74920

BRANCH
  onattabch

REVISION DETAIL
  https://phabricator.kde.org/D27057

AFFECTED FILES
  solid-device-automounter/kcm/DeviceAutomounterKCM.cpp
  solid-device-automounter/kcm/DeviceModel.cpp
  solid-device-automounter/kcm/DeviceModel.h

To: meven, #plasma, ervin, ngraham, broulik
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

Re: The Role of KInfoCenter

I agree with your sentiment. Putting a command line tool in a window is useless.

I think there is scope for /something/ even if it's not the current state.

The system information page is really good
The energy page is really good (as a concept at least. The graph
implementation isn't something I can be proud of)

As for the PCI and USB devices:
I think it's a reasonable debugging level to want to find out if my
printer doesn't work because print-manager can't see it, or the
computer can't see the device at all.
That's something I can easily imagine a non-command-line user wanting to do.

I think the added value that we can bring over the command line tools
is reducing the noise and selecting what's useful.

So IMHO USB should hide the hubs, just have name and manufacturer of
devices and that's all.
Then it's actually useful again. I'd probably use that myself.

David

D26271: [Applet]Update layout based on T10470

gvgeo added a comment.


  Change to implicitHeight in D27117 .
  
  That line should be in D26574 , messed up 
splitting the patches.
  It keeps the height of the row fixed, so that it won't change when the button 
gets hidden.

REPOSITORY
  R115 Plasma Audio Volume Applet

REVISION DETAIL
  https://phabricator.kde.org/D26271

To: gvgeo, #vdg, #plasma, manueljlin, drosca, ngraham
Cc: davidedmundson, cfeck, ndavis, filipf, ngraham, plasma-devel, Orage, 
LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, 
ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, ahiemstra, mart

The Role of KInfoCenter

2020-02-03 Thread Harald Sitter

Ahoi!

I was hoping we can have a bikeshed discussion about KInfoCenter :)

The past couple of weeks I've been spending some time on KIC and what
became apparent quickly is that I have not the faintest idea who the
application is for, or when/how one would use it. That makes it nigh
impossible to say whether a wish fits into the vision of the
application, or even where to take the application in the future in
general.

For example the OpenGL module

It's a treeview of data you'll approximately find in glxinfo (+some
additional data on EGL and GLU). Costs about 800 SLOC and requires
next to no maintenance. On paper that's grand.
But who of our design personas would use it for what purpose? [1]
Who would use it for anything other than maybe looking at the backing
kernel module?
Or perhaps more importantly: even if we assume that **someone** who's
not necessarily part of the personas finds this information useful:
Why ever would they use the GUI to look at that when they can get this
information out of the glxinfo tool which then also allows them to
apply processing to the output, to, for example, grep for what they
want to know?
The GUI has all the disadvantages of the CLI tool (dump of all
remotely extractable information even when 99% is useless noise)
without any of the advantages that you naturally get with from being
on a terminal (piping every which way to mold the data). So, what is
it good for?

This applies to most modules really. Take a look at the Interrupts
module or the PCI module. I don't see a casual user going there (cause
it's daunting technobabble), a power user likely wouldn't go there
either (cause it's inferior to terminal tools), that kinda leaves the
in-betweens. But why would they look at this data? What would they do
with it? What's the use case?

In lieu of an explanation for KIC's "reason to be", as it were, what
do we think KIC should be?
Why shouldn't its useful functionality not part of system settings, or
possibly ksysguard? For example the new smb module I wrote [2] could
easily have 'add/remove share' and 'mount/unmount share'
functionality, it'd be way more useful that way, but then it's
suddenly a settings module... Meanwhile the advanced memory
information of the Memory module seems to largely replicate
information we already have in ksysguard, and when looking at this
data it entirely stands to reason that if I see that I'm low on RAM I
may want to know what is eating it and possibly kill it.

In short: KIC makes me go "???" and, thinking back, it always has.
It's nice to look at and feel like a hacker but its functionality
eludes me.

(looking at it and feeling like a hacker may be entirely worthwhile,
but then I'd revisit the code cost of the modules and make them text
views of CLI tool output directly)

[1] https://community.kde.org/Plasma/Workspace_Sprint/Personas
[2]
https://phabricator.kde.org/file/data/csr6d4o5h5cdl23zqm6h/PHID-FILE-tij25pcl4cajzm4bfdbo/Screenshot_20200131_132853.png

D27073: [Colors KCM] Consider settings dirty if currently active scheme is edited

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:ec4dd2cc7ad0: [Colors KCM] Consider settings dirty if 
currently active scheme is edited (authored by broulik).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27073?vs=74809=74900

REVISION DETAIL
  https://phabricator.kde.org/D27073

AFFECTED FILES
  kcms/colors/colors.cpp
  kcms/colors/colors.h

To: broulik, #plasma, crossi, ervin
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27072: [Colors KCM] Fix roles mixup

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:43001f7977af: [Colors KCM] Fix roles mixup (authored by 
broulik).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27072?vs=74807=74899

REVISION DETAIL
  https://phabricator.kde.org/D27072

AFFECTED FILES
  kcms/colors/colors.cpp
  kcms/colors/colors.h
  kcms/colors/filterproxymodel.cpp

To: broulik, #plasma, ngraham
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27117: [Applet]Fix long device name

gvgeo added a comment.


  @ davidedmundson Is this monstrosity correct? I tried to avoid binding loops 
by setting minimum maximum sizes. And the origin of the values is 
contextMenuButton.implicitHeight.

REPOSITORY
  R115 Plasma Audio Volume Applet

REVISION DETAIL
  https://phabricator.kde.org/D27117

To: gvgeo, #plasma, #vdg, drosca, ngraham, davidedmundson
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27117: [Applet]Fix long device name

gvgeo added inline comments.

INLINE COMMENTS

> ListItemBase.qml:111
>  id: column
> -spacing: 0
> +Layout.minimumHeight: contextMenuButton.implicitHeight * 2 + 
> units.smallSpacing
> +Layout.maximumHeight: Layout.minimumHeight

With testing I found 5 pixel spacing. But couldn't trace where it comes from, 
maybe padding around items?. Used smallSpacing instead to avoid another magic 
number.

REPOSITORY
  R115 Plasma Audio Volume Applet

REVISION DETAIL
  https://phabricator.kde.org/D27117

To: gvgeo, #plasma, #vdg, drosca, ngraham, davidedmundson
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27117: [Applet]Fix long device name

gvgeo created this revision.
gvgeo added reviewers: Plasma, VDG, drosca, ngraham, davidedmundson.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
gvgeo requested review of this revision.

REVISION SUMMARY
  Limit label maximum width.
  Set and use implicit sizes to avoid binding loops.
  
  Note: Didn't make use fillWidth because we need the button area to be
  only on the text, and not in the empty area.

TEST PLAN
  Use applet outside of systemtray and limit it's width.
  If device description is not long enough, enable in the configuration
  "Add virtual output device for simultaneous output on all local sound cars".
  Before: Hamburger menu moves to the right, and there is no eliding.
  After: Proper display.
  
  BUG: 417074

REPOSITORY
  R115 Plasma Audio Volume Applet

BRANCH
  labelWidth (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27117

AFFECTED FILES
  applet/contents/ui/ListItemBase.qml

To: gvgeo, #plasma, #vdg, drosca, ngraham, davidedmundson
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27073: [Colors KCM] Consider settings dirty if currently active scheme is edited

2020-02-03 Thread Cyril Rossi

crossi accepted this revision.
crossi added a comment.
This revision is now accepted and ready to land.


  Both patch applied and tested, it works for me.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D27073

To: broulik, #plasma, crossi, ervin
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27116: KCM/Component email: simplify code, add a const

2020-02-03 Thread Méven Car

meven created this revision.
meven added reviewers: Plasma, ervin.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
meven requested review of this revision.

REVISION SUMMARY
  Clean up adding entries for Added Associations section of mimeapplist
  Just find the application set if it is not found by the normal query.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D27116

AFFECTED FILES
  kcms/componentchooser/componentchooseremail.cpp

To: meven, #plasma, ervin
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27113: Delete cache when resetting user settings