Re: Gamepad KCM

[Jeremy Whiting]

On Sun, Jul 30, 2023 at 1:30 AM David Edmundson 
wrote:

> b) merge it into the gamepad-kcm repo itself
>
> I would suggest doing this. It'll be easiest for future gamepad-kcm
> devs to find than any other repo, and means it'll be obvious if it
> ever becomes obsoleted.
>

Ok, I've copied it into gamepad-kcm and added the needed .reuse changes for
it. Also updated the README.md file for it.

Hopefully with those, anyone should see how to add new gamepad types.


> David
>

Gamepad KCM

[Jeremy Whiting]

Hello,

For the past while Josh and I have spent some time working on a new gamepad
kcm. It currently lives here [1] but we'd like to move it to plasma after a
review period. It also uses an inkscape plugin to export parts of an svg
file to svg images and a qml file for a given gamepad type. The inkscape
plugin lives here [2]. I think it would make sense to either move that into
plasma/ also or either a) into some other tools prefix (do we have one? I
haven't looked in ages) or b) merge it into the gamepad-kcm repo itself. I
think any of those options makes sense to me. Once it has an official
landing place I'll add to the gamepad-kcm readme file how it works, how to
use it, where to get it, etc.

I found xwaylandvideobridge had an issue with a checklist, (not sure if
there's a way to add templates like that to gamepad-kcm, tried by adding
.gitlab-ci.yml and .kde-ci.yml, but no templates appeared, so copy/pasted
and edited) to create
https://invent.kde.org/redstrate/gamepad-kcm/-/issues/1 for tracking
progress/what's still needed I guess.

BR,
Jeremy

1: https://invent.kde.org/redstrate/gamepad-kcm
2: https://invent.kde.org/redstrate/inkscape-gamepad-extension

D24276: Add text to speech functionality to klipper.

[Jeremy Whiting]

whiting added a comment.


  In D24276#548330 , @mart wrote:
  
  > this only affects the old standalone executable, right?
  
  
  Um, I guess so. I didn't realize there was something else...

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D24276

To: whiting, davidedmundson, gladhorn, #plasma_accessibility, #plasma
Cc: mart, ndavis, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra

D24276: Add text to speech functionality to klipper.

[Jeremy Whiting]

whiting updated this revision to Diff 67585.
whiting added a comment.


  - Add speech synthesis engine selection combobox to general klipper settings 
page.
  
  Rebased on master.

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24276?vs=66980=67585

BRANCH
  speech

REVISION DETAIL
  https://phabricator.kde.org/D24276

AFFECTED FILES
  CMakeLists.txt
  klipper/CMakeLists.txt
  klipper/configdialog.cpp
  klipper/generalconfig.ui
  klipper/klipper.cpp
  klipper/klipper.h
  klipper/klipper.kcfg
  klipper/tts.cpp
  klipper/tts.h

To: whiting, davidedmundson, gladhorn, #plasma_accessibility, #plasma
Cc: ndavis, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24276: Add text to speech functionality to klipper.

[Jeremy Whiting]

whiting added a comment.


  Does anyone have any opinion on this change?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D24276

To: whiting, davidedmundson, gladhorn, #plasma_accessibility, #plasma
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D24276: Add text to speech functionality to klipper.

[Jeremy Whiting]

whiting updated this revision to Diff 66980.
whiting added a comment.


  - Add speech synthesis engine selection combobox to general klipper settings 
page.

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24276?vs=66978=66980

BRANCH
  speech

REVISION DETAIL
  https://phabricator.kde.org/D24276

AFFECTED FILES
  CMakeLists.txt
  klipper/CMakeLists.txt
  klipper/configdialog.cpp
  klipper/generalconfig.ui
  klipper/klipper.cpp
  klipper/klipper.h
  klipper/klipper.kcfg
  klipper/tts.cpp
  klipper/tts.h

To: whiting, davidedmundson, gladhorn
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D24276: Add text to speech functionality to klipper.

[Jeremy Whiting]

whiting created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
whiting requested review of this revision.

REVISION SUMMARY
  Add action with global shortcut to speak text selection and another
  to speak clipboard contents.
  Add another action to stop speaking.
  Add another action to pause/resume speaking.
  Add a setting to klipper for the QTextToSpeech engine to use, if it
  changes reload the QTTS object with the chosen engine.
  
  TODO: Add a ui element to allow selecting the tts engine.
  Make a kcm to allow configuration of speech-dispatcher with a gui
  and add a button next to the klipper engine config if speechd is
  selected to launch kcm for further configuration.
  Possibly disable keyboard shortcuts by default so users don't
  accidentally trigger speech features.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  speech

REVISION DETAIL
  https://phabricator.kde.org/D24276

AFFECTED FILES
  CMakeLists.txt
  klipper/CMakeLists.txt
  klipper/klipper.cpp
  klipper/klipper.h
  klipper/klipper.kcfg
  klipper/tts.cpp
  klipper/tts.h

To: whiting
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D24224: Start of the accessibility KCM

[Jeremy Whiting]

whiting added a comment.


  Thanks for taking this on Tomaz, Just throwing some ideas out but if it would 
help to have less tabs it might be useful to put all the keyboard features on 
one tab called Keyboard instead of the 3 it has now (Modifier Keys, Keyboard 
Filters and Activation Gestures) The top groupbox of Activation Gestures items 
could be moved to their respective groupboxes also so there are less groupboxes 
on the Keyboard tab than before on these 3 tabs.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D24224

To: tcanabrava
Cc: whiting, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

[Differential] [Commented On] D2409: Update Color KCM

[whiting (Jeremy Whiting)]

whiting added a comment.


  I like it. Nice work. I agree I would change Config Scheme to Edit Scheme.

REPOSITORY
  rPLASMADESKTOP Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D2409

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: ochurlaud, #plasma, andreask, #vdg, mart
Cc: whiting, colomar, andreaska, plasma-devel, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas

Re: Review Request 127828: Remove .desktop file, it is unused and unhelpful as the app is called by ssh-add not run directly

[Jeremy Whiting]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127828/#review95162
---


Ship it!




Ship It!

- Jeremy Whiting


On May 4, 2016, 6:03 a.m., Jonathan Riddell wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127828/
> ---
> 
> (Updated May 4, 2016, 6:03 a.m.)
> 
> 
> Review request for Plasma, Andreas Kainz and Jeremy Whiting.
> 
> 
> Repository: ksshaskpass
> 
> 
> Description
> ---
> 
> Remove .desktop file, it is unused and unhelpful as the app is called by 
> ssh-add not run directly
> 
> 
> Diffs
> -
> 
>   CMakeLists.txt 605a707 
>   src/org.kde.ksshaskpass.desktop 40230ca 
> 
> Diff: https://git.reviewboard.kde.org/r/127828/diff/
> 
> 
> Testing
> ---
> 
> none
> 
> 
> Thanks,
> 
> Jonathan Riddell
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: remove khelpcenter from next Plasma release?

[Jeremy Whiting]

As an application developer I agree it makes sense to have khelpcenter
released with KDE Applications. I also agree with Albert's point that
having online documentation isn't the best since it could be newer
than what's actually running. People using LTS distributions or
"stable" variants of less often released distributions will have very
old (to those of us that run from git) versions of stuff. Having
online documentation for plasma 5.7 to look at while you're running
plasma 4 would just confuse.

Also, thanks Luigi for stepping up to maintain it.

BR,
Jeremy

On Tue, Mar 15, 2016 at 4:11 PM, Luigi Toscano  wrote:
> Luigi Toscano ha scritto:
>> On Wednesday 09 of March 2016 16:50:39 Sebastian Kügler wrote:
>>> On Wednesday, March 09, 2016 17:30:01 Luigi Toscano wrote:
> Let me cut right to the chase, do you want to maintain it? Does it need
> to
> be in Plasma?

 Yes, I can maintain it. In fact many features come from components I
 already  control.

> You're right that Plasma devs don't seem to want it, I thought my
> initial
> email made that pretty clear. We do think that disconnected systems are
> rather a fringe case, and that our time and effort is better spent on
> other
> things.

 Then the question still holds: with a maintainer, does it have a place in
 Plasma? I'm not talking about an hypothetical time and effort for
 maintaining  this offline use case (which will continue to be 0) but in
 the
 light of the statement above. In other words, if the question mark in the
 subject is real or rhetorical.
 I'm ready for both possible outcomes.
>>>
>>> Ah OK, sorry for misunderstanding it.
>>>
>>> I think there are the following options:
>>>
>>> 1) keeping it in Plasma with maintainer
>>> 2) keeping it outside of Plasma with maintainer
>>> 3) moving it to unmaintained (that's basically killing it)
>>> 4) keeping the status quo (not wanted)
>>>
>>> My personal preference would be an optional component (hence Extragear),
>>> since I think that the vast majority of users has web access, so
>>> khelpcenter isn't necessary and only adds to our maintainance burden
>>> without much gain in those cases.
>>
>> My offer stands and we can rule out 4) and 3).
>> Note that 2) could also mean a move to Applications (from your point of view
>> it does not matter too much).
>> The case 1) shouldn't add maintenance anyway as the maintainer is identified.
>>
>>>
>>> If we can move from 4) to 1) (so status quo but with maintainer), that would
>>> already be an improvement of course.
>>>
>>> The question mark was honest, we haven't made a decision on it, but
>>> different people do have expressed a preference for not shipping it (as or
>>> by default in Plasma releases). We may have missed important points, and we
>>> don't want to just kick things out unilaterally.
>>
>> I think we can leave some time for other people to comment. The shortest
>> deadline of all possibilities is the one for moving into Applications, and
>> there are still 8 days before the dependency freeze and two weeks before the
>> branch.
>
> Any other comment from anyone else?
>
> Ciao
> --
> Luigi
> ___
> Plasma-devel mailing list
> Plasma-devel@kde.org
> https://mail.kde.org/mailman/listinfo/plasma-devel
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 125662: mangonel: Initial port to Qt5/KF5

[Jeremy Whiting]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125662/
---

(Updated Oct. 30, 2015, 5:53 a.m.)


Status
--

This change has been marked as submitted.


Review request for Plasma and Martin Tobias Holmedahl Sandsmark.


Repository: mangonel


Description
---

Port of Mangonel to Qt5/KF5


Diffs
-

  CMakeLists.txt fec95da 
  Label.cpp 136f70b 
  Mangonel.h 9c8a32f 
  Mangonel.cpp 63e10ab 
  main.cpp 1b0c4a3 
  providers/Applications.cpp 7674a97 
  providers/Paths.cpp 713aba3 

Diff: https://git.reviewboard.kde.org/r/125662/diff/


Testing
---

It builds and runs, but looks a bit strange since it's a plani QWidget. (Maybe 
we could say it's using Material design and call it good, dunno :p)


File Attachments


screenshot
  
https://git.reviewboard.kde.org/media/uploaded/files/2015/10/16/2f8f36d8-dea2-4679-8826-96ebbaa8c8e9__mangonel.png


Thanks,

Jeremy Whiting

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 125622: Use better guard against recursion when changing volume with sliders

[Jeremy Whiting]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125622/#review87738
---


Sorry I put the wrong review number on the commit for 125662

- Jeremy Whiting


On Oct. 15, 2015, 8:12 a.m., David Rosca wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125622/
> ---
> 
> (Updated Oct. 15, 2015, 8:12 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-pa
> 
> 
> Description
> ---
> 
> As noted in https://git.reviewboard.kde.org/r/125088/, this should fix 
> acessibility on volume sliders.
> This also fixes changing the volume with keyboard (when slider has focus).
> 
> 
> Diffs
> -
> 
>   applet/contents/ui/ListItemBase.qml 54f6eb0 
>   src/kcm/package/contents/ui/VolumeSlider.qml da77315 
> 
> Diff: https://git.reviewboard.kde.org/r/125622/diff/
> 
> 
> Testing
> ---
> 
> Changing volume in applet still works + it fixes changing volume in kcm (i 
> broke it with last commit - there is no setVolume() in kcm VolumeSlider).
> 
> 
> Thanks,
> 
> David Rosca
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request 125662: mangonel: Initial port to Qt5/KF5

[Jeremy Whiting]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125662/
---

Review request for Plasma and Martin Tobias Holmedahl Sandsmark.


Repository: mangonel


Description
---

Port of Mangonel to Qt5/KF5


Diffs
-

  CMakeLists.txt fec95da 
  Label.cpp 136f70b 
  Mangonel.h 9c8a32f 
  Mangonel.cpp 63e10ab 
  main.cpp 1b0c4a3 
  providers/Applications.cpp 7674a97 
  providers/Paths.cpp 713aba3 

Diff: https://git.reviewboard.kde.org/r/125662/diff/


Testing
---

It builds and runs, but looks a bit strange since it's a plani QWidget. (Maybe 
we could say it's using Material design and call it good, dunno :p)


Thanks,

Jeremy Whiting

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 125662: mangonel: Initial port to Qt5/KF5

[Jeremy Whiting]

> On Oct. 16, 2015, 9:58 a.m., Martin Klapetek wrote:
> > Screenshots? ;)

Ok, added a screenshot with breeze dark theme, The colors look ok, but I guess 
Plasma::Dialog may have done some rounded corners or something iirc to make it 
look a bit better or added transparency or something.


- Jeremy


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125662/#review86929
---


On Oct. 16, 2015, 9:42 a.m., Jeremy Whiting wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125662/
> ---
> 
> (Updated Oct. 16, 2015, 9:42 a.m.)
> 
> 
> Review request for Plasma and Martin Tobias Holmedahl Sandsmark.
> 
> 
> Repository: mangonel
> 
> 
> Description
> ---
> 
> Port of Mangonel to Qt5/KF5
> 
> 
> Diffs
> -
> 
>   CMakeLists.txt fec95da 
>   Label.cpp 136f70b 
>   Mangonel.h 9c8a32f 
>   Mangonel.cpp 63e10ab 
>   main.cpp 1b0c4a3 
>   providers/Applications.cpp 7674a97 
>   providers/Paths.cpp 713aba3 
> 
> Diff: https://git.reviewboard.kde.org/r/125662/diff/
> 
> 
> Testing
> ---
> 
> It builds and runs, but looks a bit strange since it's a plani QWidget. 
> (Maybe we could say it's using Material design and call it good, dunno :p)
> 
> 
> Thanks,
> 
> Jeremy Whiting
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 125662: mangonel: Initial port to Qt5/KF5

[Jeremy Whiting]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125662/
---

(Updated Oct. 16, 2015, 10:04 a.m.)


Review request for Plasma and Martin Tobias Holmedahl Sandsmark.


Repository: mangonel


Description
---

Port of Mangonel to Qt5/KF5


Diffs
-

  CMakeLists.txt fec95da 
  Label.cpp 136f70b 
  Mangonel.h 9c8a32f 
  Mangonel.cpp 63e10ab 
  main.cpp 1b0c4a3 
  providers/Applications.cpp 7674a97 
  providers/Paths.cpp 713aba3 

Diff: https://git.reviewboard.kde.org/r/125662/diff/


Testing
---

It builds and runs, but looks a bit strange since it's a plani QWidget. (Maybe 
we could say it's using Material design and call it good, dunno :p)


File Attachments (updated)


screenshot
  
https://git.reviewboard.kde.org/media/uploaded/files/2015/10/16/2f8f36d8-dea2-4679-8826-96ebbaa8c8e9__mangonel.png


Thanks,

Jeremy Whiting

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: new mobile image, oh it's gorgeous

[Jeremy Whiting]

neon.png seems to be missing. Just FYI.

On Mon, Sep 21, 2015 at 5:09 PM, Jonathan Riddell  wrote:
> I rebuilt all the packages in mobile kci to give a new image,
> 20150921.213107,version=3
>
> http://kubuntu.plasma-mobile.org/
>
> with mirror up at
> http://mobile.edinburghlinux.co.uk/
>
> Jonathan
> ___
> Plasma-devel mailing list
> Plasma-devel@kde.org
> https://mail.kde.org/mailman/listinfo/plasma-devel
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Adding further modules to api.kde.org

[Jeremy Whiting]

Martin,

I took a look at this as part of the gardening documentation websites,
but I didn't get very far. The code that runs this and ebn is in
kde:websites/quality-kde-org and is pretty outdated unfortunately.
Actually now that Allen Winter is back maybe he could add it (Added
him to cc)? What I tried here during gardening which I couldn't get to
work locally was:

1. Install it (I had some trouble with the perl based installer
putting files in different places than expected, maybe perl itself
changed over the years?)
2. Once I manually copied some files to places where they were
expected I couldn't figure out how to manually run the doc generator,
the --help documentation mentioned what arguments to use, but it
wasn't obvious what I should put for my Qt documentation paths and
such somehow, so I didn't try anything further.

It would be awesome to have what used to be in KDE SC on api.kde.org
again. We have many libraries that aren't frameworks that are Qt5/KF5
based which would be good to show on there imo.

BR,
Jeremy

On Thu, Sep 10, 2015 at 2:57 AM, Martin Graesslin  wrote:
> Hi all,
>
> back in KDE4 days the workspace libraries were listed on api.kde.org [1]. But
> for the current version we don't have any API docs available. The section
> "Other KDE Software" [2] lists KDE Support, KDE Extragear and Playground but
> apparently nothing from what used to be KDE SC.
>
> Does anybody know how I can get our KDE Workspaces listed there again? I'm in
> particular interested in getting KWayland API documentation published.
>
> If nobody knows: does anyone know who needs to be poked.
>
> Cheers
> Martin
>
> [1] http://api.kde.org/4.x-api/kde-workspace-apidocs/
> [2] http://api.kde.org/other.php
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Adding further modules to api.kde.org

[Jeremy Whiting]

Well, it's not even just about workspace, we had in kde4 times kdeedu,
kdegames, etc. etc. all on api.kde.org. Not all of it was api per se
(I don't know anyone that would want to read the apidocs for kanagram
for example, except to know how it's internals work or used to work
when hacking on it). Currently we only show frameworks and other. This
misses a lot of useful documentation, nothing is there about
libkomparediff2, libkeduvocdocument, libkdegames, etc. since those
aren't generated anymore for some reason.

A good idea that Ben suggested when the gardening project started was
having the apidocs generate on commit, rather than regenerating
everything every night at a specified time. A lot of the sources don't
actually change very often, so rebuilding part of the apidocs when the
code or it's doxygen comments change would make a lot of sense.

BR,
Jeremy

On Thu, Sep 10, 2015 at 11:05 AM, Adriaan de Groot <gr...@kde.org> wrote:
> On Thursday 10 September 2015 06:07:40 Jeremy Whiting wrote:
>> It would be awesome to have what used to be in KDE SC on api.kde.org
>> again. We have many libraries that aren't frameworks that are Qt5/KF5
>> based which would be good to show on there imo.
>
> Perhaps half of this is figuring out what actually constitutes the "Workspace
> API" that would be interesting here and how to subsequently pull information
> out of the metadata-services that we have (src-build? projects.kde.org? I
> don't know, I haven't followed very closely what lives where now).
>
>
>
> [ade] (who is now reminded that the original ebn domain is expiring and needs
> renewal, yeah)
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Adding further modules to api.kde.org

[Jeremy Whiting]

Allen,

Those are both KDE4 versions of workspace stuff. I don't see any place
where kf5 versions are.

BR,
Jeremy

On Thu, Sep 10, 2015 at 1:50 PM, Allen Winter  wrote:
> On Thursday, September 10, 2015 10:57:10 AM Martin Graesslin wrote:
>> Hi all,
>>
>> back in KDE4 days the workspace libraries were listed on api.kde.org [1]. But
>> for the current version we don't have any API docs available. The section
>> "Other KDE Software" [2] lists KDE Support, KDE Extragear and Playground but
>> apparently nothing from what used to be KDE SC.
>>
>> Does anybody know how I can get our KDE Workspaces listed there again? I'm in
>> particular interested in getting KWayland API documentation published.
>>
>> If nobody knows: does anyone know who needs to be poked.
>>
>
> http://api.kde.org/4.x-api/workspace-apidocs/ exists
> The KDE SC stuff is shown under "KDE4 Versions" 
> http://api.kde.org/history4.php
>
> I do notice that under the various KDE 4.foo tables we don't have a workspace 
> entry
> we have kde-workspace, but not workspace.  seems like kde-workspace and 
> workspace are similar.
>
> I'm not sure there's anything to fix.
>
> -Allen
>
>
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 125060: Added .gitignore

[Jeremy Whiting]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125060/#review84884
---

Ship it!


Ship It!

- Jeremy Whiting


On Sept. 5, 2015, 2:01 p.m., Ovidiu-Florin BOGDAN wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125060/
> ---
> 
> (Updated Sept. 5, 2015, 2:01 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> ---
> 
> Added .gitignore to ignore KDevelop projects.
> 
> 
> Diffs
> -
> 
>   kcms/baloo/.gitignore PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/125060/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Ovidiu-Florin BOGDAN
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 125041: Move kaccess into separate source directory

[Jeremy Whiting]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125041/#review84804
---

Ship it!


Ship It!

- Jeremy Whiting


On Sept. 3, 2015, 4:53 p.m., Alexander Potashev wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125041/
> ---
> 
> (Updated Sept. 3, 2015, 4:53 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> ---
> 
> * kaccess does not belong to KCMs.
> * This move also streamlines setting of separate translation domains for
> kaccess and kcmaccess.
> 
> 
> Diffs
> -
> 
>   CMakeLists.txt e95b2926732ab0701aca7e75becb9a5652cd0283 
>   kaccess/CMakeLists.txt PRE-CREATION 
>   kaccess/Messages.sh PRE-CREATION 
>   kcms/access/CMakeLists.txt e2f7c0d233111266584582ae60b39e21a80a45aa 
>   kcms/access/Messages.sh b0167223aa30d8ea560a99a9d1c707ed03523677 
>   kcms/access/kaccess.cpp  
>   kcms/access/kaccess.desktop  
>   kcms/access/kaccess.h  
>   kcms/access/kaccess.notifyrc  
>   kcms/access/main.cpp  
> 
> Diff: https://git.reviewboard.kde.org/r/125041/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Alexander Potashev
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 124114: Add "Lock Screen" to desktop toolbox

[Jeremy Whiting]

> On June 16, 2015, 9:29 p.m., David Edmundson wrote:
> > > This does not check KAuthorized before to hide the entry but neither does 
> > > the context menu.
> > 
> > Well that's a bit rubbish. 
> > Ship this, but lets remember to fix both, poke me if it gets near release 
> > and I haven't.
> > 
> > BTW, is it possible to power this menu from the QActions we have in Plasma, 
> > I haven't looked but it should reduce some code?
> 
> Kai Uwe Broulik wrote:
> I don't know, the context menu containment action generates a bunch of 
> QActions as well as the global shortcuts

Kai, David, Any update on this?


- Jeremy


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124114/#review81518
---


On June 16, 2015, 2:18 p.m., Kai Uwe Broulik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124114/
> ---
> 
> (Updated June 16, 2015, 2:18 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> ---
> 
> It used to be present in 4.x and makes it consistent with what the context 
> menu provides. This does not check KAuthorized before to hide the entry but 
> neither does the context menu. As suggested in 
> https://forum.kde.org/viewtopic.php?f=289=126770
> 
> 
> Diffs
> -
> 
>   toolboxes/desktoptoolbox/contents/ui/ToolBoxItem.qml c2a36e9 
> 
> Diff: https://git.reviewboard.kde.org/r/124114/diff/
> 
> 
> Testing
> ---
> 
> Works
> 
> 
> File Attachments
> 
> 
> Lock screen entry
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/06/16/1c037bef-4280-4da8-bf9c-7cdc3d0e37b6__lockscreentoolbox.png
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Breeze] [Bug 351875] Some drop-down menus don't inherit the correct color value from Breeze-Dark theme.

[Jeremy Whiting]

https://bugs.kde.org/show_bug.cgi?id=351875

Jeremy Whiting <jpwhit...@kde.org> changed:

   What|Removed |Added

 CC||jpwhit...@kde.org

--- Comment #3 from Jeremy Whiting <jpwhit...@kde.org> ---
Created attachment 94306
  --> https://bugs.kde.org/attachment.cgi?id=94306=edit
screenshot showing the white on white text in comboboxes in icon taskbar
settings with breeze dark theme

Here's a screenshot of how it looks here.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Breeze] [Bug 351875] Some drop-down menus don't inherit the correct color value from Breeze-Dark theme.

[Jeremy Whiting]

https://bugs.kde.org/show_bug.cgi?id=351875

--- Comment #5 from Jeremy Whiting <jpwhit...@kde.org> ---
Yes, I've rebooted twice or more since I switched to Breeze Dark theme.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 124959: Shorten labels of QCheckBox so the accessibility kcm won't need a scrollbar.

[Jeremy Whiting]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124959/
---

(Updated Aug. 28, 2015, 12:25 p.m.)


Status
--

This change has been marked as submitted.


Review request for Plasma.


Changes
---

Submitted with commit 78644357249af839cecc421f25b557e32ea2345b by Jeremy 
Whiting to branch master.


Bugs: 339407
https://bugs.kde.org/show_bug.cgi?id=339407


Repository: plasma-desktop


Description
---

BUG:339407


Diffs
-

  kcms/access/accessibility.ui 7d5222036ab91f0d71d2779236c5d95d6c084c35 

Diff: https://git.reviewboard.kde.org/r/124959/diff/


Testing
---

Opened the kcm as per the bug report and horizontal scrollbars are gone. We 
should probably think about shortening the wording even more though or 
simplifying this kcm a bit.


Thanks,

Jeremy Whiting

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 124799: Add look and feel package for Breeze Dark theme.

[Jeremy Whiting]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124799/
---

(Updated Aug. 27, 2015, 7:19 p.m.)


Status
--

This change has been marked as submitted.


Review request for Plasma, andreas kainz and Sebastian Kügler.


Repository: breeze


Description
---

Adds a Breeze Dark look and feel package.


Diffs
-

  lookandfeel.dark/metadata.desktop PRE-CREATION 
  lookandfeel.dark/contents/previews/preview.png PRE-CREATION 
  CMakeLists.txt aaae1ab9e242d7d4f9e1fb91990eef139668de74 
  lookandfeel.dark/contents/defaults PRE-CREATION 

Diff: https://git.reviewboard.kde.org/r/124799/diff/


Testing
---

Switching between breeze, breeze dark, and oxygen works. Crash has been fixed 
today by dfaure in kiconthemes.


Thanks,

Jeremy Whiting

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request 124959: Shorten labels of QCheckBox so the accessibility kcm won't need a scrollbar.

[Jeremy Whiting]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124959/
---

Review request for Plasma.


Bugs: 339407
https://bugs.kde.org/show_bug.cgi?id=339407


Repository: plasma-desktop


Description
---

BUG:339407


Diffs
-

  kcms/access/accessibility.ui 7d5222036ab91f0d71d2779236c5d95d6c084c35 

Diff: https://git.reviewboard.kde.org/r/124959/diff/


Testing
---

Opened the kcm as per the bug report and horizontal scrollbars are gone. We 
should probably think about shortening the wording even more though or 
simplifying this kcm a bit.


Thanks,

Jeremy Whiting

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 124872: Default to Breeze colors

[Jeremy Whiting]

 On Aug. 24, 2015, 12:13 a.m., Martin Gräßlin wrote:
  I must say I'm rather shocked at how this is implemented. Would it be 
  possible to move the defaults into our QPT plugin, so that these defaults 
  are only applied if running on a platform with our plugin, otherwise it 
  picks Qt defaults?

IMO it would also probably be good if we had some way of making the default 
based on the actual color scheme rather than having it have a copy of all the 
colors from the scheme. That way if Breeze.colors ever changes we don't either 
a) need to update this also or b) get mismatch between Default and Breeze in 
the colors kcm ui.


- Jeremy


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124872/#review84241
---


On Aug. 21, 2015, 3:35 p.m., Kai Uwe Broulik wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://git.reviewboard.kde.org/r/124872/
 ---
 
 (Updated Aug. 21, 2015, 3:35 p.m.)
 
 
 Review request for KDE Frameworks, Plasma and KDE Usability.
 
 
 Bugs: 351530
 https://bugs.kde.org/show_bug.cgi?id=351530
 
 
 Repository: kconfigwidgets
 
 
 Description
 ---
 
 This makes KColorScheme return Breeze colors by default, ie. choosing 
 Default in Colors KCM is no longer Oxygen.
 
 
 Diffs
 -
 
   src/kcolorscheme.cpp f1ec1e3 
 
 Diff: https://git.reviewboard.kde.org/r/124872/diff/
 
 
 Testing
 ---
 
 Seems to look right, typos reserved :)
 
 Only thing missing now is the window decoration which is set in the WM 
 section of kdeglobals by the breeze.colors but KWin defaults to highlight 
 colors, so it stays blue.
 
 
 Thanks,
 
 Kai Uwe Broulik
 


___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 124885: Fix issues in translation control module

[Jeremy Whiting]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124885/#review84202
---

Ship it!


Ship It!

- Jeremy Whiting


On Aug. 22, 2015, 6:34 p.m., Albert Astals Cid wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://git.reviewboard.kde.org/r/124885/
 ---
 
 (Updated Aug. 22, 2015, 6:34 p.m.)
 
 
 Review request for Plasma.
 
 
 Bugs: 345761 and 347956
 https://bugs.kde.org/show_bug.cgi?id=345761
 https://bugs.kde.org/show_bug.cgi?id=347956
 
 
 Repository: plasma-desktop
 
 
 Description
 ---
 
 Fixes two problems:
  * Variants not being shown up, i.e. ca ca@valencia showing up both as 
 català
  * pt showing up as português do Brasil
 
 For the first one i've went the easy route of adding the languageCode if 
 there's an @ in it
 For pt i hard to hard code it since i found no other way to make Qt 
 understand that for pt we mean portuguese from portugal
 
 
 Diffs
 -
 
   kcms/translations/kcmtranslations.cpp e5024e2 
 
 Diff: https://git.reviewboard.kde.org/r/124885/diff/
 
 
 Testing
 ---
 
 
 Thanks,
 
 Albert Astals Cid
 


___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 124885: Fix issues in translation control module

[Jeremy Whiting]

 On Aug. 22, 2015, 7:47 p.m., Jeremy Whiting wrote:
  Ship It!

Incidentally, the pt issue sounds like a QLocale bug, do we need to find one or 
file a new one for that probably?


- Jeremy


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124885/#review84202
---


On Aug. 22, 2015, 6:34 p.m., Albert Astals Cid wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://git.reviewboard.kde.org/r/124885/
 ---
 
 (Updated Aug. 22, 2015, 6:34 p.m.)
 
 
 Review request for Plasma.
 
 
 Bugs: 345761 and 347956
 https://bugs.kde.org/show_bug.cgi?id=345761
 https://bugs.kde.org/show_bug.cgi?id=347956
 
 
 Repository: plasma-desktop
 
 
 Description
 ---
 
 Fixes two problems:
  * Variants not being shown up, i.e. ca ca@valencia showing up both as 
 català
  * pt showing up as português do Brasil
 
 For the first one i've went the easy route of adding the languageCode if 
 there's an @ in it
 For pt i hard to hard code it since i found no other way to make Qt 
 understand that for pt we mean portuguese from portugal
 
 
 Diffs
 -
 
   kcms/translations/kcmtranslations.cpp e5024e2 
 
 Diff: https://git.reviewboard.kde.org/r/124885/diff/
 
 
 Testing
 ---
 
 
 Thanks,
 
 Albert Astals Cid
 


___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 124872: Default to Breeze colors

[Jeremy Whiting]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124872/#review84166
---

Ship it!


Ship It!

- Jeremy Whiting


On Aug. 21, 2015, 3:35 p.m., Kai Uwe Broulik wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://git.reviewboard.kde.org/r/124872/
 ---
 
 (Updated Aug. 21, 2015, 3:35 p.m.)
 
 
 Review request for KDE Frameworks, Plasma and KDE Usability.
 
 
 Bugs: 351530
 https://bugs.kde.org/show_bug.cgi?id=351530
 
 
 Repository: kconfigwidgets
 
 
 Description
 ---
 
 This makes KColorScheme return Breeze colors by default, ie. choosing 
 Default in Colors KCM is no longer Oxygen.
 
 
 Diffs
 -
 
   src/kcolorscheme.cpp f1ec1e3 
 
 Diff: https://git.reviewboard.kde.org/r/124872/diff/
 
 
 Testing
 ---
 
 Seems to look right, typos reserved :)
 
 Only thing missing now is the window decoration which is set in the WM 
 section of kdeglobals by the breeze.colors but KWin defaults to highlight 
 colors, so it stays blue.
 
 
 Thanks,
 
 Kai Uwe Broulik
 


___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 124799: Add look and feel package for Breeze Dark theme.

[Jeremy Whiting]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124799/
---

(Updated Aug. 20, 2015, 7:54 p.m.)


Review request for Plasma, andreas kainz and Sebastian Kügler.


Changes
---

Removed Keywords line from .desktop file.


Repository: breeze


Description
---

Adds a Breeze Dark look and feel package.


Diffs (updated)
-

  lookandfeel.dark/metadata.desktop PRE-CREATION 
  lookandfeel.dark/contents/previews/preview.png PRE-CREATION 
  CMakeLists.txt aaae1ab9e242d7d4f9e1fb91990eef139668de74 
  lookandfeel.dark/contents/defaults PRE-CREATION 

Diff: https://git.reviewboard.kde.org/r/124799/diff/


Testing
---

Switching between breeze, breeze dark, and oxygen works. Crash has been fixed 
today by dfaure in kiconthemes.


Thanks,

Jeremy Whiting

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 124799: Add look and feel package for Breeze Dark theme.

[Jeremy Whiting]

On Aug. 20, 2015, 7:15 p.m., Jeremy Whiting wrote:
  The main Breeze lf is in plasma-workspace. 
  Do we want them together?

Sebas suggested it go into breeze since that's where the other breeze dark 
stuff lives. I'm fine either way tbh.


- Jeremy


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124799/#review84121
---


On Aug. 18, 2015, 4:56 p.m., Jeremy Whiting wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://git.reviewboard.kde.org/r/124799/
 ---
 
 (Updated Aug. 18, 2015, 4:56 p.m.)
 
 
 Review request for Plasma, andreas kainz and Sebastian Kügler.
 
 
 Repository: breeze
 
 
 Description
 ---
 
 Adds a Breeze Dark look and feel package.
 
 
 Diffs
 -
 
   CMakeLists.txt aaae1ab9e242d7d4f9e1fb91990eef139668de74 
   lookandfeel.dark/contents/defaults PRE-CREATION 
   lookandfeel.dark/contents/previews/preview.png PRE-CREATION 
   lookandfeel.dark/metadata.desktop PRE-CREATION 
 
 Diff: https://git.reviewboard.kde.org/r/124799/diff/
 
 
 Testing
 ---
 
 Switching between breeze, breeze dark, and oxygen works. Crash has been fixed 
 today by dfaure in kiconthemes.
 
 
 Thanks,
 
 Jeremy Whiting
 


___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 124799: Add look and feel package for Breeze Dark theme.

[Jeremy Whiting]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124799/
---

(Updated Aug. 18, 2015, 4:56 p.m.)


Review request for Plasma, andreas kainz and Sebastian Kügler.


Summary (updated)
-

Add look and feel package for Breeze Dark theme.


Repository: breeze


Description (updated)
---

Adds a Breeze Dark look and feel package.


Diffs
-

  CMakeLists.txt aaae1ab9e242d7d4f9e1fb91990eef139668de74 
  lookandfeel.dark/contents/defaults PRE-CREATION 
  lookandfeel.dark/contents/previews/preview.png PRE-CREATION 
  lookandfeel.dark/metadata.desktop PRE-CREATION 

Diff: https://git.reviewboard.kde.org/r/124799/diff/


Testing (updated)
---

Switching between breeze, breeze dark, and oxygen works. Crash has been fixed 
today by dfaure in kiconthemes.


Thanks,

Jeremy Whiting

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 124799: WIP: Add look and feel package for Breeze Dark theme.

[Jeremy Whiting]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124799/
---

(Updated Aug. 18, 2015, 8:55 a.m.)


Review request for Plasma, andreas kainz and Sebastian Kügler.


Changes
---

Removed Messages.sh which isn't needed anymore.


Repository: breeze


Description
---

2 problems:
1. Switching themes causes konversation, krunner, and other applications to 
crash when applying the theme somehow.
2. The screenshots and assets are all copied directly from plasma-workspace, so 
the tooltip and such are wrong.


Diffs (updated)
-

  CMakeLists.txt aaae1ab9e242d7d4f9e1fb91990eef139668de74 
  lookandfeel.dark/contents/defaults PRE-CREATION 
  lookandfeel.dark/contents/previews/preview.png PRE-CREATION 
  lookandfeel.dark/metadata.desktop PRE-CREATION 

Diff: https://git.reviewboard.kde.org/r/124799/diff/


Testing
---

Switching between breeze, breeze dark, and oxygen seem to work, though some 
artifacts are left in some applications and some others crash for some reason. 
The backtrace looks like this:

Application: Konversation (konversation), signal: Segmentation fault
Using host libthread_db library /usr/lib/libthread_db.so.1.
[Current thread is 1 (Thread 0x7f76e0f69840 (LWP 3767))]

Thread 2 (Thread 0x7f76c894d700 (LWP 3769)):
#0  0x7f76d8dc318d in poll () from /usr/lib/libc.so.6
#1  0x7f76d485bc7c in ?? () from /usr/lib/libglib-2.0.so.0
#2  0x7f76d485bd8c in g_main_context_iteration () from 
/usr/lib/libglib-2.0.so.0
#3  0x7f76d9c0f25b in 
QEventDispatcherGlib::processEvents(QFlagsQEventLoop::ProcessEventsFlag) () 
from /usr/lib/libQt5Core.so.5
#4  0x7f76d9bb626a in 
QEventLoop::exec(QFlagsQEventLoop::ProcessEventsFlag) () from 
/usr/lib/libQt5Core.so.5
#5  0x7f76d99d2af4 in QThread::exec() () from /usr/lib/libQt5Core.so.5
#6  0x7f76d99d7a9e in ?? () from /usr/lib/libQt5Core.so.5
#7  0x7f76d63204a4 in start_thread () from /usr/lib/libpthread.so.0
#8  0x7f76d8dcc12d in clone () from /usr/lib/libc.so.6

Thread 1 (Thread 0x7f76e0f69840 (LWP 3767)):
[KCrash Handler]
#6  0x7f76dade2f72 in QApplication::setStyle(QStyle*) () from 
/usr/lib/libQt5Widgets.so.5
#7  0x7f76dade3f06 in QApplication::setStyle(QString const) () from 
/usr/lib/libQt5Widgets.so.5
#8  0x7f76c9c34733 in KHintsSettings::slotNotifyChange (this=0x1eef110, 
type=2, arg=0) at 
/home/jeremy/devel/kde/src/frameworks/frameworkintegration/src/platformtheme/khintssettings.cpp:274
#9  0x7f76c9c47007 in KHintsSettings::qt_static_metacall (_o=0x1eef110, 
_c=QMetaObject::InvokeMetaMethod, _id=3, _a=0x7fff0c69d1d0) at 
/home/jeremy/devel/kde/build/frameworks/frameworkintegration/src/platformtheme/moc_khintssettings.cpp:85
#10 0x7f76c9c47100 in KHintsSettings::qt_metacall (this=0x1eef110, 
_c=QMetaObject::InvokeMetaMethod, _id=3, _a=0x7fff0c69d1d0) at 
/home/jeremy/devel/kde/build/frameworks/frameworkintegration/src/platformtheme/moc_khintssettings.cpp:117
#11 0x7f76da29c293 in ?? () from /usr/lib/libQt5DBus.so.5
#12 0x7f76d9be7eb1 in QObject::event(QEvent*) () from 
/usr/lib/libQt5Core.so.5
#13 0x7f76dade100c in QApplicationPrivate::notify_helper(QObject*, QEvent*) 
() from /usr/lib/libQt5Widgets.so.5
#14 0x7f76dade64e6 in QApplication::notify(QObject*, QEvent*) () from 
/usr/lib/libQt5Widgets.so.5
#15 0x7f76d9bb889b in QCoreApplication::notifyInternal(QObject*, QEvent*) 
() from /usr/lib/libQt5Core.so.5
#16 0x7f76d9bbac96 in QCoreApplicationPrivate::sendPostedEvents(QObject*, 
int, QThreadData*) () from /usr/lib/libQt5Core.so.5
#17 0x7f76d9c0ee33 in ?? () from /usr/lib/libQt5Core.so.5
#18 0x7f76d485b9fd in g_main_context_dispatch () from 
/usr/lib/libglib-2.0.so.0
#19 0x7f76d485bce0 in ?? () from /usr/lib/libglib-2.0.so.0
#20 0x7f76d485bd8c in g_main_context_iteration () from 
/usr/lib/libglib-2.0.so.0
#21 0x7f76d9c0f23f in 
QEventDispatcherGlib::processEvents(QFlagsQEventLoop::ProcessEventsFlag) () 
from /usr/lib/libQt5Core.so.5
#22 0x7f76d9bb626a in 
QEventLoop::exec(QFlagsQEventLoop::ProcessEventsFlag) () from 
/usr/lib/libQt5Core.so.5
#23 0x7f76d9bbe20c in QCoreApplication::exec() () from 
/usr/lib/libQt5Core.so.5
#24 0x004cbb35 in main (argc=1, argv=optimized out) at 
/home/jeremy/devel/kde/src/extragear/network/konversation/src/main.cpp:160


Thanks,

Jeremy Whiting

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 124799: WIP: Add look and feel package for Breeze Dark theme.

[Jeremy Whiting]

 On Aug. 18, 2015, 7:58 a.m., Kai Uwe Broulik wrote:
  lookandfeel.dark/Messages.sh, lines 2-3
  https://git.reviewboard.kde.org/r/124799/diff/2/?file=396154#file396154line2
 
  Is this still needed?

Heh, no, probably not.


- Jeremy


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124799/#review83990
---


On Aug. 18, 2015, 7:55 a.m., Jeremy Whiting wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://git.reviewboard.kde.org/r/124799/
 ---
 
 (Updated Aug. 18, 2015, 7:55 a.m.)
 
 
 Review request for Plasma, andreas kainz and Sebastian Kügler.
 
 
 Repository: breeze
 
 
 Description
 ---
 
 2 problems:
 1. Switching themes causes konversation, krunner, and other applications to 
 crash when applying the theme somehow.
 2. The screenshots and assets are all copied directly from plasma-workspace, 
 so the tooltip and such are wrong.
 
 
 Diffs
 -
 
   CMakeLists.txt aaae1ab9e242d7d4f9e1fb91990eef139668de74 
   lookandfeel.dark/Messages.sh PRE-CREATION 
   lookandfeel.dark/contents/defaults PRE-CREATION 
   lookandfeel.dark/contents/previews/preview.png PRE-CREATION 
   lookandfeel.dark/metadata.desktop PRE-CREATION 
 
 Diff: https://git.reviewboard.kde.org/r/124799/diff/
 
 
 Testing
 ---
 
 Switching between breeze, breeze dark, and oxygen seem to work, though some 
 artifacts are left in some applications and some others crash for some 
 reason. The backtrace looks like this:
 
 Application: Konversation (konversation), signal: Segmentation fault
 Using host libthread_db library /usr/lib/libthread_db.so.1.
 [Current thread is 1 (Thread 0x7f76e0f69840 (LWP 3767))]
 
 Thread 2 (Thread 0x7f76c894d700 (LWP 3769)):
 #0  0x7f76d8dc318d in poll () from /usr/lib/libc.so.6
 #1  0x7f76d485bc7c in ?? () from /usr/lib/libglib-2.0.so.0
 #2  0x7f76d485bd8c in g_main_context_iteration () from 
 /usr/lib/libglib-2.0.so.0
 #3  0x7f76d9c0f25b in 
 QEventDispatcherGlib::processEvents(QFlagsQEventLoop::ProcessEventsFlag) () 
 from /usr/lib/libQt5Core.so.5
 #4  0x7f76d9bb626a in 
 QEventLoop::exec(QFlagsQEventLoop::ProcessEventsFlag) () from 
 /usr/lib/libQt5Core.so.5
 #5  0x7f76d99d2af4 in QThread::exec() () from /usr/lib/libQt5Core.so.5
 #6  0x7f76d99d7a9e in ?? () from /usr/lib/libQt5Core.so.5
 #7  0x7f76d63204a4 in start_thread () from /usr/lib/libpthread.so.0
 #8  0x7f76d8dcc12d in clone () from /usr/lib/libc.so.6
 
 Thread 1 (Thread 0x7f76e0f69840 (LWP 3767)):
 [KCrash Handler]
 #6  0x7f76dade2f72 in QApplication::setStyle(QStyle*) () from 
 /usr/lib/libQt5Widgets.so.5
 #7  0x7f76dade3f06 in QApplication::setStyle(QString const) () from 
 /usr/lib/libQt5Widgets.so.5
 #8  0x7f76c9c34733 in KHintsSettings::slotNotifyChange (this=0x1eef110, 
 type=2, arg=0) at 
 /home/jeremy/devel/kde/src/frameworks/frameworkintegration/src/platformtheme/khintssettings.cpp:274
 #9  0x7f76c9c47007 in KHintsSettings::qt_static_metacall (_o=0x1eef110, 
 _c=QMetaObject::InvokeMetaMethod, _id=3, _a=0x7fff0c69d1d0) at 
 /home/jeremy/devel/kde/build/frameworks/frameworkintegration/src/platformtheme/moc_khintssettings.cpp:85
 #10 0x7f76c9c47100 in KHintsSettings::qt_metacall (this=0x1eef110, 
 _c=QMetaObject::InvokeMetaMethod, _id=3, _a=0x7fff0c69d1d0) at 
 /home/jeremy/devel/kde/build/frameworks/frameworkintegration/src/platformtheme/moc_khintssettings.cpp:117
 #11 0x7f76da29c293 in ?? () from /usr/lib/libQt5DBus.so.5
 #12 0x7f76d9be7eb1 in QObject::event(QEvent*) () from 
 /usr/lib/libQt5Core.so.5
 #13 0x7f76dade100c in QApplicationPrivate::notify_helper(QObject*, 
 QEvent*) () from /usr/lib/libQt5Widgets.so.5
 #14 0x7f76dade64e6 in QApplication::notify(QObject*, QEvent*) () from 
 /usr/lib/libQt5Widgets.so.5
 #15 0x7f76d9bb889b in QCoreApplication::notifyInternal(QObject*, QEvent*) 
 () from /usr/lib/libQt5Core.so.5
 #16 0x7f76d9bbac96 in QCoreApplicationPrivate::sendPostedEvents(QObject*, 
 int, QThreadData*) () from /usr/lib/libQt5Core.so.5
 #17 0x7f76d9c0ee33 in ?? () from /usr/lib/libQt5Core.so.5
 #18 0x7f76d485b9fd in g_main_context_dispatch () from 
 /usr/lib/libglib-2.0.so.0
 #19 0x7f76d485bce0 in ?? () from /usr/lib/libglib-2.0.so.0
 #20 0x7f76d485bd8c in g_main_context_iteration () from 
 /usr/lib/libglib-2.0.so.0
 #21 0x7f76d9c0f23f in 
 QEventDispatcherGlib::processEvents(QFlagsQEventLoop::ProcessEventsFlag) () 
 from /usr/lib/libQt5Core.so.5
 #22 0x7f76d9bb626a in 
 QEventLoop::exec(QFlagsQEventLoop::ProcessEventsFlag) () from 
 /usr/lib/libQt5Core.so.5
 #23 0x7f76d9bbe20c in QCoreApplication::exec() () from 
 /usr/lib/libQt5Core.so.5
 #24 0x004cbb35 in main (argc=1, argv=optimized out) at 
 /home

Re: Review Request 124799: WIP: Add look and feel package for Breeze Dark theme.

[Jeremy Whiting]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124799/
---

(Updated Aug. 18, 2015, 8:56 a.m.)


Review request for Plasma, andreas kainz and Sebastian Kügler.


Repository: breeze


Description (updated)
---

One bug easily shown by this, but unrelated: switching icon themes causes 
konversation, krunner, and other applications to crash when applying the theme 
somehow.


Diffs
-

  CMakeLists.txt aaae1ab9e242d7d4f9e1fb91990eef139668de74 
  lookandfeel.dark/contents/defaults PRE-CREATION 
  lookandfeel.dark/contents/previews/preview.png PRE-CREATION 
  lookandfeel.dark/metadata.desktop PRE-CREATION 

Diff: https://git.reviewboard.kde.org/r/124799/diff/


Testing
---

Switching between breeze, breeze dark, and oxygen seem to work, though some 
artifacts are left in some applications and some others crash for some reason. 
The backtrace looks like this:

Application: Konversation (konversation), signal: Segmentation fault
Using host libthread_db library /usr/lib/libthread_db.so.1.
[Current thread is 1 (Thread 0x7f76e0f69840 (LWP 3767))]

Thread 2 (Thread 0x7f76c894d700 (LWP 3769)):
#0  0x7f76d8dc318d in poll () from /usr/lib/libc.so.6
#1  0x7f76d485bc7c in ?? () from /usr/lib/libglib-2.0.so.0
#2  0x7f76d485bd8c in g_main_context_iteration () from 
/usr/lib/libglib-2.0.so.0
#3  0x7f76d9c0f25b in 
QEventDispatcherGlib::processEvents(QFlagsQEventLoop::ProcessEventsFlag) () 
from /usr/lib/libQt5Core.so.5
#4  0x7f76d9bb626a in 
QEventLoop::exec(QFlagsQEventLoop::ProcessEventsFlag) () from 
/usr/lib/libQt5Core.so.5
#5  0x7f76d99d2af4 in QThread::exec() () from /usr/lib/libQt5Core.so.5
#6  0x7f76d99d7a9e in ?? () from /usr/lib/libQt5Core.so.5
#7  0x7f76d63204a4 in start_thread () from /usr/lib/libpthread.so.0
#8  0x7f76d8dcc12d in clone () from /usr/lib/libc.so.6

Thread 1 (Thread 0x7f76e0f69840 (LWP 3767)):
[KCrash Handler]
#6  0x7f76dade2f72 in QApplication::setStyle(QStyle*) () from 
/usr/lib/libQt5Widgets.so.5
#7  0x7f76dade3f06 in QApplication::setStyle(QString const) () from 
/usr/lib/libQt5Widgets.so.5
#8  0x7f76c9c34733 in KHintsSettings::slotNotifyChange (this=0x1eef110, 
type=2, arg=0) at 
/home/jeremy/devel/kde/src/frameworks/frameworkintegration/src/platformtheme/khintssettings.cpp:274
#9  0x7f76c9c47007 in KHintsSettings::qt_static_metacall (_o=0x1eef110, 
_c=QMetaObject::InvokeMetaMethod, _id=3, _a=0x7fff0c69d1d0) at 
/home/jeremy/devel/kde/build/frameworks/frameworkintegration/src/platformtheme/moc_khintssettings.cpp:85
#10 0x7f76c9c47100 in KHintsSettings::qt_metacall (this=0x1eef110, 
_c=QMetaObject::InvokeMetaMethod, _id=3, _a=0x7fff0c69d1d0) at 
/home/jeremy/devel/kde/build/frameworks/frameworkintegration/src/platformtheme/moc_khintssettings.cpp:117
#11 0x7f76da29c293 in ?? () from /usr/lib/libQt5DBus.so.5
#12 0x7f76d9be7eb1 in QObject::event(QEvent*) () from 
/usr/lib/libQt5Core.so.5
#13 0x7f76dade100c in QApplicationPrivate::notify_helper(QObject*, QEvent*) 
() from /usr/lib/libQt5Widgets.so.5
#14 0x7f76dade64e6 in QApplication::notify(QObject*, QEvent*) () from 
/usr/lib/libQt5Widgets.so.5
#15 0x7f76d9bb889b in QCoreApplication::notifyInternal(QObject*, QEvent*) 
() from /usr/lib/libQt5Core.so.5
#16 0x7f76d9bbac96 in QCoreApplicationPrivate::sendPostedEvents(QObject*, 
int, QThreadData*) () from /usr/lib/libQt5Core.so.5
#17 0x7f76d9c0ee33 in ?? () from /usr/lib/libQt5Core.so.5
#18 0x7f76d485b9fd in g_main_context_dispatch () from 
/usr/lib/libglib-2.0.so.0
#19 0x7f76d485bce0 in ?? () from /usr/lib/libglib-2.0.so.0
#20 0x7f76d485bd8c in g_main_context_iteration () from 
/usr/lib/libglib-2.0.so.0
#21 0x7f76d9c0f23f in 
QEventDispatcherGlib::processEvents(QFlagsQEventLoop::ProcessEventsFlag) () 
from /usr/lib/libQt5Core.so.5
#22 0x7f76d9bb626a in 
QEventLoop::exec(QFlagsQEventLoop::ProcessEventsFlag) () from 
/usr/lib/libQt5Core.so.5
#23 0x7f76d9bbe20c in QCoreApplication::exec() () from 
/usr/lib/libQt5Core.so.5
#24 0x004cbb35 in main (argc=1, argv=optimized out) at 
/home/jeremy/devel/kde/src/extragear/network/konversation/src/main.cpp:160


Thanks,

Jeremy Whiting

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 124799: WIP: Add look and feel package for Breeze Dark theme.

[Jeremy Whiting]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124799/
---

(Updated Aug. 18, 2015, 7:55 a.m.)


Review request for Plasma, andreas kainz and Sebastian Kügler.


Changes
---

Removed all duplicates and use fallback instead. Updated preview image to show 
how dark will look.


Repository: breeze


Description
---

2 problems:
1. Switching themes causes konversation, krunner, and other applications to 
crash when applying the theme somehow.
2. The screenshots and assets are all copied directly from plasma-workspace, so 
the tooltip and such are wrong.


Diffs (updated)
-

  CMakeLists.txt aaae1ab9e242d7d4f9e1fb91990eef139668de74 
  lookandfeel.dark/Messages.sh PRE-CREATION 
  lookandfeel.dark/contents/defaults PRE-CREATION 
  lookandfeel.dark/contents/previews/preview.png PRE-CREATION 
  lookandfeel.dark/metadata.desktop PRE-CREATION 

Diff: https://git.reviewboard.kde.org/r/124799/diff/


Testing
---

Switching between breeze, breeze dark, and oxygen seem to work, though some 
artifacts are left in some applications and some others crash for some reason. 
The backtrace looks like this:

Application: Konversation (konversation), signal: Segmentation fault
Using host libthread_db library /usr/lib/libthread_db.so.1.
[Current thread is 1 (Thread 0x7f76e0f69840 (LWP 3767))]

Thread 2 (Thread 0x7f76c894d700 (LWP 3769)):
#0  0x7f76d8dc318d in poll () from /usr/lib/libc.so.6
#1  0x7f76d485bc7c in ?? () from /usr/lib/libglib-2.0.so.0
#2  0x7f76d485bd8c in g_main_context_iteration () from 
/usr/lib/libglib-2.0.so.0
#3  0x7f76d9c0f25b in 
QEventDispatcherGlib::processEvents(QFlagsQEventLoop::ProcessEventsFlag) () 
from /usr/lib/libQt5Core.so.5
#4  0x7f76d9bb626a in 
QEventLoop::exec(QFlagsQEventLoop::ProcessEventsFlag) () from 
/usr/lib/libQt5Core.so.5
#5  0x7f76d99d2af4 in QThread::exec() () from /usr/lib/libQt5Core.so.5
#6  0x7f76d99d7a9e in ?? () from /usr/lib/libQt5Core.so.5
#7  0x7f76d63204a4 in start_thread () from /usr/lib/libpthread.so.0
#8  0x7f76d8dcc12d in clone () from /usr/lib/libc.so.6

Thread 1 (Thread 0x7f76e0f69840 (LWP 3767)):
[KCrash Handler]
#6  0x7f76dade2f72 in QApplication::setStyle(QStyle*) () from 
/usr/lib/libQt5Widgets.so.5
#7  0x7f76dade3f06 in QApplication::setStyle(QString const) () from 
/usr/lib/libQt5Widgets.so.5
#8  0x7f76c9c34733 in KHintsSettings::slotNotifyChange (this=0x1eef110, 
type=2, arg=0) at 
/home/jeremy/devel/kde/src/frameworks/frameworkintegration/src/platformtheme/khintssettings.cpp:274
#9  0x7f76c9c47007 in KHintsSettings::qt_static_metacall (_o=0x1eef110, 
_c=QMetaObject::InvokeMetaMethod, _id=3, _a=0x7fff0c69d1d0) at 
/home/jeremy/devel/kde/build/frameworks/frameworkintegration/src/platformtheme/moc_khintssettings.cpp:85
#10 0x7f76c9c47100 in KHintsSettings::qt_metacall (this=0x1eef110, 
_c=QMetaObject::InvokeMetaMethod, _id=3, _a=0x7fff0c69d1d0) at 
/home/jeremy/devel/kde/build/frameworks/frameworkintegration/src/platformtheme/moc_khintssettings.cpp:117
#11 0x7f76da29c293 in ?? () from /usr/lib/libQt5DBus.so.5
#12 0x7f76d9be7eb1 in QObject::event(QEvent*) () from 
/usr/lib/libQt5Core.so.5
#13 0x7f76dade100c in QApplicationPrivate::notify_helper(QObject*, QEvent*) 
() from /usr/lib/libQt5Widgets.so.5
#14 0x7f76dade64e6 in QApplication::notify(QObject*, QEvent*) () from 
/usr/lib/libQt5Widgets.so.5
#15 0x7f76d9bb889b in QCoreApplication::notifyInternal(QObject*, QEvent*) 
() from /usr/lib/libQt5Core.so.5
#16 0x7f76d9bbac96 in QCoreApplicationPrivate::sendPostedEvents(QObject*, 
int, QThreadData*) () from /usr/lib/libQt5Core.so.5
#17 0x7f76d9c0ee33 in ?? () from /usr/lib/libQt5Core.so.5
#18 0x7f76d485b9fd in g_main_context_dispatch () from 
/usr/lib/libglib-2.0.so.0
#19 0x7f76d485bce0 in ?? () from /usr/lib/libglib-2.0.so.0
#20 0x7f76d485bd8c in g_main_context_iteration () from 
/usr/lib/libglib-2.0.so.0
#21 0x7f76d9c0f23f in 
QEventDispatcherGlib::processEvents(QFlagsQEventLoop::ProcessEventsFlag) () 
from /usr/lib/libQt5Core.so.5
#22 0x7f76d9bb626a in 
QEventLoop::exec(QFlagsQEventLoop::ProcessEventsFlag) () from 
/usr/lib/libQt5Core.so.5
#23 0x7f76d9bbe20c in QCoreApplication::exec() () from 
/usr/lib/libQt5Core.so.5
#24 0x004cbb35 in main (argc=1, argv=optimized out) at 
/home/jeremy/devel/kde/src/extragear/network/konversation/src/main.cpp:160


Thanks,

Jeremy Whiting

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Minutes Monday Plasma Hangout

[Jeremy Whiting]

On Mon, Aug 17, 2015 at 4:42 AM, Sebastian Kügler se...@kde.org wrote:
 Present: Bhushan, David, Jens, Kai Uwe, Martin G, Ozark, Sebastian
 Date: 17 August, 2015

 Bhushan:
 - working on apps, first off comic book reader
 - Looked into Plasma Moible on Archlinux: 
 https://github.com/bhush9/plasma-arch

 David:
 - fixed some shoddy porting
 - Fixed translations
 - Fixed a bug in KScreen
 - 5.4 looks pretty good, probably not a log of real bugs (or too little
 testing!)
 - will fix davetray after 5.4 is out


 Jens:
 - visited GUADEC, GNOME struggles with many of the same problems as KDE does

Which problems are you referring to specifically? For those of us that
weren't at GUADEC and are curious.


 Kai Uwe:
 - Fixes here and there
 - interfaces powerdevil with his ambient light sensor in a hackish way
 - tried Skeyer, gesture-based keyboard which comes with a maliit plugin
 [1] https://saidinesh5.wordpress.com/2014/05/20/on-the-way-to-skeyer/
 [2] https://bitbucket.org/skeyer/skeyer/

 Martin:
 - Working on KWin QPA progressing well
 - now working on input devices
 - looking into the OpenGL story right now

 Sebas:
 - Worked on KScreen/Wayland wl protocol for disconnected outputs w/ Martin
 - Discussed merge plans with dvratil (either wayland-integration or
 libkscreen)
 - Finalized Plasma Mobile vision
 - Worked a lot on docs for Plasma Mobile (see wiki)
 - will do more docs
 - more phabricator (task workflow basics are there, migrate more, then move on
 to code reviews)
 - interview this afternoon
 - finalize


 --
 sebas

 http://www.kde.org | http://vizZzion.org | GPG Key ID: 9119 0EF9
 ___
 Plasma-devel mailing list
 Plasma-devel@kde.org
 https://mail.kde.org/mailman/listinfo/plasma-devel
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request 124799: WIP: Add look and feel package for Breeze Dark theme.

[Jeremy Whiting]

 in QThread::exec() () from /usr/lib/libQt5Core.so.5
#6  0x7f76d99d7a9e in ?? () from /usr/lib/libQt5Core.so.5
#7  0x7f76d63204a4 in start_thread () from /usr/lib/libpthread.so.0
#8  0x7f76d8dcc12d in clone () from /usr/lib/libc.so.6

Thread 1 (Thread 0x7f76e0f69840 (LWP 3767)):
[KCrash Handler]
#6  0x7f76dade2f72 in QApplication::setStyle(QStyle*) () from 
/usr/lib/libQt5Widgets.so.5
#7  0x7f76dade3f06 in QApplication::setStyle(QString const) () from 
/usr/lib/libQt5Widgets.so.5
#8  0x7f76c9c34733 in KHintsSettings::slotNotifyChange (this=0x1eef110, 
type=2, arg=0) at 
/home/jeremy/devel/kde/src/frameworks/frameworkintegration/src/platformtheme/khintssettings.cpp:274
#9  0x7f76c9c47007 in KHintsSettings::qt_static_metacall (_o=0x1eef110, 
_c=QMetaObject::InvokeMetaMethod, _id=3, _a=0x7fff0c69d1d0) at 
/home/jeremy/devel/kde/build/frameworks/frameworkintegration/src/platformtheme/moc_khintssettings.cpp:85
#10 0x7f76c9c47100 in KHintsSettings::qt_metacall (this=0x1eef110, 
_c=QMetaObject::InvokeMetaMethod, _id=3, _a=0x7fff0c69d1d0) at 
/home/jeremy/devel/kde/build/frameworks/frameworkintegration/src/platformtheme/moc_khintssettings.cpp:117
#11 0x7f76da29c293 in ?? () from /usr/lib/libQt5DBus.so.5
#12 0x7f76d9be7eb1 in QObject::event(QEvent*) () from 
/usr/lib/libQt5Core.so.5
#13 0x7f76dade100c in QApplicationPrivate::notify_helper(QObject*, QEvent*) 
() from /usr/lib/libQt5Widgets.so.5
#14 0x7f76dade64e6 in QApplication::notify(QObject*, QEvent*) () from 
/usr/lib/libQt5Widgets.so.5
#15 0x7f76d9bb889b in QCoreApplication::notifyInternal(QObject*, QEvent*) 
() from /usr/lib/libQt5Core.so.5
#16 0x7f76d9bbac96 in QCoreApplicationPrivate::sendPostedEvents(QObject*, 
int, QThreadData*) () from /usr/lib/libQt5Core.so.5
#17 0x7f76d9c0ee33 in ?? () from /usr/lib/libQt5Core.so.5
#18 0x7f76d485b9fd in g_main_context_dispatch () from 
/usr/lib/libglib-2.0.so.0
#19 0x7f76d485bce0 in ?? () from /usr/lib/libglib-2.0.so.0
#20 0x7f76d485bd8c in g_main_context_iteration () from 
/usr/lib/libglib-2.0.so.0
#21 0x7f76d9c0f23f in 
QEventDispatcherGlib::processEvents(QFlagsQEventLoop::ProcessEventsFlag) () 
from /usr/lib/libQt5Core.so.5
#22 0x7f76d9bb626a in 
QEventLoop::exec(QFlagsQEventLoop::ProcessEventsFlag) () from 
/usr/lib/libQt5Core.so.5
#23 0x7f76d9bbe20c in QCoreApplication::exec() () from 
/usr/lib/libQt5Core.so.5
#24 0x004cbb35 in main (argc=1, argv=optimized out) at 
/home/jeremy/devel/kde/src/extragear/network/konversation/src/main.cpp:160


Thanks,

Jeremy Whiting

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 124799: WIP: Add look and feel package for Breeze Dark theme.

[Jeremy Whiting]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124799/#review83971
---


I'm also able to create the same crashes by just changing the Icon theme, 
some backtraces show some things in KIconLoader also. Seems the icon theme 
changing is what's causing these crashes.

- Jeremy Whiting


On Aug. 17, 2015, 6:55 p.m., Jeremy Whiting wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://git.reviewboard.kde.org/r/124799/
 ---
 
 (Updated Aug. 17, 2015, 6:55 p.m.)
 
 
 Review request for Plasma, andreas kainz and Sebastian Kügler.
 
 
 Repository: breeze
 
 
 Description
 ---
 
 2 problems:
 1. Switching themes causes konversation, krunner, and other applications to 
 crash when applying the theme somehow.
 2. The screenshots and assets are all copied directly from plasma-workspace, 
 so the tooltip and such are wrong.
 
 
 Diffs
 -
 
   CMakeLists.txt aaae1ab9e242d7d4f9e1fb91990eef139668de74 
   lookandfeel.dark/Messages.sh PRE-CREATION 
   lookandfeel.dark/contents/components/BreezeBlock.qml PRE-CREATION 
   lookandfeel.dark/contents/components/BreezeHeading.qml PRE-CREATION 
   lookandfeel.dark/contents/components/BreezeLabel.qml PRE-CREATION 
   lookandfeel.dark/contents/components/InfoPane.qml PRE-CREATION 
   lookandfeel.dark/contents/components/KeyboardLayoutButton.qml PRE-CREATION 
   lookandfeel.dark/contents/components/LogoutOptions.qml PRE-CREATION 
   lookandfeel.dark/contents/components/LogoutScreen.qml PRE-CREATION 
   lookandfeel.dark/contents/components/UserDelegate.qml PRE-CREATION 
   lookandfeel.dark/contents/components/UserList.qml PRE-CREATION 
   lookandfeel.dark/contents/components/UserSelect.qml PRE-CREATION 
   lookandfeel.dark/contents/components/artwork/README.txt PRE-CREATION 
   lookandfeel.dark/contents/components/artwork/background.png PRE-CREATION 
   lookandfeel.dark/contents/components/artwork/logout_primary.svgz 
 PRE-CREATION 
   lookandfeel.dark/contents/components/artwork/restart_primary.svgz 
 PRE-CREATION 
   lookandfeel.dark/contents/components/artwork/shutdown_primary.svgz 
 PRE-CREATION 
   lookandfeel.dark/contents/defaults PRE-CREATION 
   lookandfeel.dark/contents/desktopswitcher/DesktopSwitcher.qml PRE-CREATION 
   lookandfeel.dark/contents/lockscreen/LockScreen.qml PRE-CREATION 
   lookandfeel.dark/contents/loginmanager/Main.qml PRE-CREATION 
   lookandfeel.dark/contents/loginmanager/README.txt PRE-CREATION 
   lookandfeel.dark/contents/loginmanager/breeze.jpg PRE-CREATION 
   lookandfeel.dark/contents/loginmanager/dummydata/screenModel.qml 
 PRE-CREATION 
   lookandfeel.dark/contents/loginmanager/dummydata/sddm.qml PRE-CREATION 
   lookandfeel.dark/contents/loginmanager/dummydata/sessionModel.qml 
 PRE-CREATION 
   lookandfeel.dark/contents/loginmanager/dummydata/userModel.qml PRE-CREATION 
   lookandfeel.dark/contents/loginmanager/metadata.desktop PRE-CREATION 
   lookandfeel.dark/contents/loginmanager/theme.conf PRE-CREATION 
   lookandfeel.dark/contents/logout/Logout.qml PRE-CREATION 
   lookandfeel.dark/contents/logout/dummydata/screenGeometry.qml PRE-CREATION 
   lookandfeel.dark/contents/osd/Osd.qml PRE-CREATION 
   lookandfeel.dark/contents/osd/OsdItem.qml PRE-CREATION 
   lookandfeel.dark/contents/previews/desktopswitcher.png PRE-CREATION 
   lookandfeel.dark/contents/previews/lockscreen.png PRE-CREATION 
   lookandfeel.dark/contents/previews/loginmanager.png PRE-CREATION 
   lookandfeel.dark/contents/previews/preview.png PRE-CREATION 
   lookandfeel.dark/contents/previews/runcommand.png PRE-CREATION 
   lookandfeel.dark/contents/previews/splash.png PRE-CREATION 
   lookandfeel.dark/contents/previews/userswitcher.png PRE-CREATION 
   lookandfeel.dark/contents/previews/windowdecoration.png PRE-CREATION 
   lookandfeel.dark/contents/previews/windowswitcher.png PRE-CREATION 
   lookandfeel.dark/contents/runcommand/RunCommand.qml PRE-CREATION 
   lookandfeel.dark/contents/splash/CMakeLists.txt PRE-CREATION 
   lookandfeel.dark/contents/splash/Splash.qml PRE-CREATION 
   lookandfeel.dark/contents/splash/images/kde.svgz PRE-CREATION 
   lookandfeel.dark/contents/userswitcher/UserSwitcher.qml PRE-CREATION 
   lookandfeel.dark/contents/windowdecoration/WindowDecoration.qml 
 PRE-CREATION 
   lookandfeel.dark/contents/windowswitcher/WindowSwitcher.qml PRE-CREATION 
   lookandfeel.dark/metadata.desktop PRE-CREATION 
 
 Diff: https://git.reviewboard.kde.org/r/124799/diff/
 
 
 Testing
 ---
 
 Switching between breeze, breeze dark, and oxygen seem to work, though some 
 artifacts are left in some applications and some others crash for some 
 reason. The backtrace looks like this:
 
 Application: Konversation (konversation), signal: Segmentation fault
 Using

Re: Review Request 124534: ksmserver: restore support for autostart scripts; migrate them from the KDE4 dir

[Jeremy Whiting]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124534/#review83236
---

Ship it!


Ship It!

- Jeremy Whiting


On July 31, 2015, 7:03 a.m., David Faure wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://git.reviewboard.kde.org/r/124534/
 ---
 
 (Updated July 31, 2015, 7:03 a.m.)
 
 
 Review request for Plasma and Vishesh Handa.
 
 
 Repository: plasma-workspace
 
 
 Description
 ---
 
 Commit f913e251fe6 removed this, due to a porting bug: both klauncher
 (XDG autostart using .desktop files) and ksmserver (kde-specific scripts)
 were ported to look at the same directory (~/.config/autostart),
 leading to double autostart. The right fix, however, is to use
 a different directory for scripts, I called it ~/.config/autostart-scripts.
 
 BUG: 338242
 REVIEW: 124534
 
 
 Diffs
 -
 
   ksmserver/server.h 2176aa1c9a6505773b61354dee6fd547fdf5841e 
   ksmserver/startup.cpp 531e88b4257901e890f16c23761d2c0aa538d524 
 
 Diff: https://git.reviewboard.kde.org/r/124534/diff/
 
 
 Testing
 ---
 
 Logged out and back in many times :)
 
 My autostart folder got copied correctly, including symlinks
 
 
 Thanks,
 
 David Faure
 


___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 121097: Add a FileDialog to choose the image for fifteenpuzzle.

[Jeremy Whiting]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121097/
---

(Updated April 3, 2015, 1:35 p.m.)


Status
--

This change has been discarded.


Review request for Plasma, David Edmundson, Eike Hein, and Marco Martin.


Repository: kdeplasma-addons


Description
---

Somehow this doesn't show the FileDialog here, not sure if it's a local problem 
though.


Diffs
-

  applets/fifteenPuzzle/package/contents/ui/configAppearance.qml 
5dfd2317bdc26849d1705e8826510bd05176b963 

Diff: https://git.reviewboard.kde.org/r/121097/diff/


Testing
---

Doesn't work here, but I'm hoping it's just a local problem.


Thanks,

Jeremy Whiting

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 123079: digitalclock: Don't reverse js timezone offset when using to generate utc from local time.

[Jeremy Whiting]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123079/
---

(Updated March 20, 2015, 11:51 a.m.)


Status
--

This change has been marked as submitted.


Review request for Plasma and Martin Klapetek.


Changes
---

Submitted with commit 0b82fc7e455bdc2c4b419c26e1f5349205c25a65 by Jeremy 
Whiting to branch Plasma/5.2.


Repository: plasma-workspace


Description
---

digitalclock: Don't reverse js timezone offset when using to generate utc from 
local time.


Diffs
-

  applets/digital-clock/package/contents/ui/DigitalClock.qml 
1292f730467d43a331d1253a3872d41ebe2d59c1 

Diff: https://git.reviewboard.kde.org/r/123079/diff/


Testing
---

In this place we are using the offset to calculate utc from the local time. My 
timezone is -6 and my getTimezoneOffset is 360. To take my local time and get 
utc, we need to add 6 hours, not subtract 6 hours. We could either subtract the 
reverse of the js value, or just add it directly.

My local time in the tooltip has the right time now. All others are also 
calculated correctly now.


Thanks,

Jeremy Whiting

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request 123079: digitalclock: Don't reverse js timezone offset when using to generate utc from local time.

[Jeremy Whiting]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123079/
---

Review request for Plasma and Martin Klapetek.


Repository: plasma-workspace


Description
---

digitalclock: Don't reverse js timezone offset when using to generate utc from 
local time.


Diffs
-

  applets/digital-clock/package/contents/ui/DigitalClock.qml 
1292f730467d43a331d1253a3872d41ebe2d59c1 

Diff: https://git.reviewboard.kde.org/r/123079/diff/


Testing
---

In this place we are using the offset to calculate utc from the local time. My 
timezone is -6 and my getTimezoneOffset is 360. To take my local time and get 
utc, we need to add 6 hours, not subtract 6 hours. We could either subtract the 
reverse of the js value, or just add it directly.

My local time in the tooltip has the right time now. All others are also 
calculated correctly now.


Thanks,

Jeremy Whiting

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Plasma Workspace Wallpapers] [Bug 344586] No download and setting of new wallpapers, themes and so on possible.

[Jeremy Whiting]

https://bugs.kde.org/show_bug.cgi?id=344586

Jeremy Whiting jpwhit...@kde.org changed:

   What|Removed |Added

 Resolution|--- |DUPLICATE
 CC||jpwhit...@kde.org
 Status|UNCONFIRMED |RESOLVED

--- Comment #1 from Jeremy Whiting jpwhit...@kde.org ---
The first half of your bug is solved in recent packages. The second half is a
duplicate of bug 334963.

*** This bug has been marked as a duplicate of bug 334963 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 122823: Avoid KDE4 lingo in colors kcm

[Jeremy Whiting]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122823/#review77038
---

Ship it!


Ship It!

- Jeremy Whiting


On March 4, 2015, 6:49 p.m., Sebastian Kügler wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://git.reviewboard.kde.org/r/122823/
 ---
 
 (Updated March 4, 2015, 6:49 p.m.)
 
 
 Review request for Plasma.
 
 
 Repository: plasma-desktop
 
 
 Description
 ---
 
 Avoid KDE4 lingo in colors kcm
 
 non-Qt applications is technically more correct since we're using the 
 frameworksintegration Qt platform plugin. This also avoids the KDE4 lingo 
 in the ui.
 
 
 Diffs
 -
 
   kcms/colors/colorsettings.ui 705d9b8cf6ca4f07975bff924813ff25957a9bd5 
   kcms/colors/colorscm.cpp 463e90ba427c8e6fe9c9f2530291b2613455c0a7 
 
 Diff: https://git.reviewboard.kde.org/r/122823/diff/
 
 
 Testing
 ---
 
 Checked if the checkbox's label is updated in the KCM.
 
 
 Thanks,
 
 Sebastian Kügler
 


___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 122464: Remove bell kcm

[Jeremy Whiting]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122464/#review75561
---

Ship it!


Ship It!

- Jeremy Whiting


On Feb. 7, 2015, 5:55 a.m., Frederik Gladhorn wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://git.reviewboard.kde.org/r/122464/
 ---
 
 (Updated Feb. 7, 2015, 5:55 a.m.)
 
 
 Review request for Plasma.
 
 
 Repository: plasma-desktop
 
 
 Description
 ---
 
 The kcm sets up the xbell, but konsole for example doesn't use the 
 xbell but knotify. The code is also xcb only, I have no idea if it could
 be ported to wayland. For users the knotify way of treating the bell 
 (visual/sound/custom executable) should satisfy all needs.
 
 Then there is also the accessibility kcm allowing to switch on and off 
 the system bell (using xbell as well) and allowing to flash the screen 
 in a color (I could not get that one to work, neither using xterm nor 
 konsole).
 
 A recent discussion on the accessibility mailing list also gave no real use 
 case for this duplicate kcm to exist.
 
 http://lists.kde.org/?t=14202382732r=1w=2
 
 
 Diffs
 -
 
   kcms/CMakeLists.txt 06056cd 
   kcms/bell/CMakeLists.txt f2ebe19 
   kcms/bell/Messages.sh cb6a478 
   kcms/bell/bell.cpp 1c4f552 
   kcms/bell/bell.desktop f1cd552 
   kcms/bell/bell.h fda09b5 
 
 Diff: https://git.reviewboard.kde.org/r/122464/diff/
 
 
 Testing
 ---
 
 
 Thanks,
 
 Frederik Gladhorn
 


___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 122467: Add open wallpaper action

[Jeremy Whiting]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122467/#review75575
---

Ship it!


Ship It!

- Jeremy Whiting


On Feb. 7, 2015, 1:19 p.m., Kai Uwe Broulik wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://git.reviewboard.kde.org/r/122467/
 ---
 
 (Updated Feb. 7, 2015, 1:19 p.m.)
 
 
 Review request for Plasma.
 
 
 Bugs: 343854
 https://bugs.kde.org/show_bug.cgi?id=343854
 
 
 Repository: plasma-workspace
 
 
 Description
 ---
 
 This restores the Open Wallpaper action we had in the 4.x slideshow
 
 
 Diffs
 -
 
   wallpapers/image/imagepackage/contents/ui/main.qml 1378d54 
 
 Diff: https://git.reviewboard.kde.org/r/122467/diff/
 
 
 Testing
 ---
 
 Slideshow configured, right click on desktop, chose Open Wallpaper, image 
 opened in the default application.
 
 
 Thanks,
 
 Kai Uwe Broulik
 


___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 121833: add reviewboardrc, targets kdeframeworks and plasma groups

[Jeremy Whiting]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121833/#review73077
---

Ship it!


Ship It!

- Jeremy Whiting


On Jan. 4, 2015, 8:19 a.m., Harald Sitter wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://git.reviewboard.kde.org/r/121833/
 ---
 
 (Updated Jan. 4, 2015, 8:19 a.m.)
 
 
 Review request for KDE Frameworks and Plasma.
 
 
 Repository: kpackage
 
 
 Description
 ---
 
 add reviewbaordrc, targets kdeframeworks and plasma groups
 
 
 Diffs
 -
 
   .reviewboardrc PRE-CREATION 
 
 Diff: https://git.reviewboard.kde.org/r/121833/diff/
 
 
 Testing
 ---
 
 made this here review request
 
 
 Thanks,
 
 Harald Sitter
 


___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Plasma 5.2 parts

[Jeremy Whiting]

Also possibly ksshaskpass, which has been in kdereview since early november.

On Thu, Dec 11, 2014 at 7:11 AM, Jonathan Riddell j...@jriddell.org wrote:

 On Thu, Dec 11, 2014 at 03:09:10PM +0100, Daniel Vrátil wrote:
  Yes. I'll submit kscreen and libkscreen for review and move it to
 workspace,
  as we discussed.

 libkscreen is in already, just kscreen to review/move

 Jonathan
 ___
 Plasma-devel mailing list
 Plasma-devel@kde.org
 https://mail.kde.org/mailman/listinfo/plasma-devel

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 121424: [GCI2014]Porting Accessibility Config Module away from KDELibs4Support

[Jeremy Whiting]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121424/#review71826
---

Ship it!


Ship It!

- Jeremy Whiting


On Dec. 11, 2014, 1:52 p.m., Toby Chen wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://git.reviewboard.kde.org/r/121424/
 ---
 
 (Updated Dec. 11, 2014, 1:52 p.m.)
 
 
 Review request for Plasma and David Edmundson.
 
 
 Repository: plasma-desktop
 
 
 Description
 ---
 
 Remove the depencence on KDELibs4Support form KCMAccess
 
 
 Diffs
 -
 
   kcms/access/main.cpp 09864fc 
   kcms/access/CMakeLists.txt 64b1cc9 
   kcms/access/kaccess.h 716bfcf 
   kcms/access/kaccess.cpp aea6f86 
   kcms/access/kcmaccess.h d3cb40f 
   kcms/access/kcmaccess.cpp 6c8bc65 
 
 Diff: https://git.reviewboard.kde.org/r/121424/diff/
 
 
 Testing
 ---
 
 I have ran kcmshell5 kcmaccess, did see no problem.
 Accessiblity features work fine.
 
 
 Thanks,
 
 Toby Chen
 


___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 121453: Cache QTimeZone for the lifespan of the TimeSource don't recreate every minute

[Jeremy Whiting]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121453/#review71827
---

Ship it!


Ship It!

- Jeremy Whiting


On Dec. 11, 2014, 2:30 p.m., David Edmundson wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://git.reviewboard.kde.org/r/121453/
 ---
 
 (Updated Dec. 11, 2014, 2:30 p.m.)
 
 
 Review request for Plasma.
 
 
 Repository: plasma-workspace
 
 
 Description
 ---
 
 cache QTimeZone for the lifespan of the TimeSource don't recreate every minute
 
 QTimeZone::systemTimeZoneId() will open /etc/localtime every single time it 
 is called.
 
 We are calling this in ::updateTime which happens every single minute.
 
 
 Diffs
 -
 
   dataengines/time/timesource.h 5ee1ef6 
   dataengines/time/timesource.cpp 934ed49 
 
 Diff: https://git.reviewboard.kde.org/r/121453/diff/
 
 
 Testing
 ---
 
 Ran strace -e open plasmashell without crying
 
 Selected a few zones and mouse-wheeled between them.
 
 
 Thanks,
 
 David Edmundson
 


___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 121424: [GCI2014]Porting Accessibility Config Module away from KDELibs4Support

[Jeremy Whiting]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121424/#review71751
---



kcms/access/kaccess.h
https://git.reviewboard.kde.org/r/121424/#comment50029

Why is QAbstractButton needed here? I don't see it used in the header file 
anywhere.



kcms/access/kcmaccess.h
https://git.reviewboard.kde.org/r/121424/#comment50031

I don't see any need for a new configChanged slot that takes a double, all 
it does is the same thing as the original configChanged.



kcms/access/kcmaccess.cpp
https://git.reviewboard.kde.org/r/121424/#comment50030

This should just be removed, you created a QLabel with this text, no need 
for a commented out line from the old KNumInput api.


- Jeremy Whiting


On Dec. 10, 2014, 2:31 p.m., Toby Chen wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://git.reviewboard.kde.org/r/121424/
 ---
 
 (Updated Dec. 10, 2014, 2:31 p.m.)
 
 
 Review request for Plasma and David Edmundson.
 
 
 Repository: plasma-desktop
 
 
 Description
 ---
 
 [GCI2014]Remove the depencence on KDELibs4Support form KCMAccess
 
 
 Diffs
 -
 
   kcms/access/main.cpp 09864fc 
   kcms/access/kcmaccess.h d3cb40f 
   kcms/access/kcmaccess.cpp 6c8bc65 
   kcms/access/kaccess.h 716bfcf 
   kcms/access/kaccess.cpp aea6f86 
   kcms/access/CMakeLists.txt 64b1cc9 
 
 Diff: https://git.reviewboard.kde.org/r/121424/diff/
 
 
 Testing
 ---
 
 I have ran kcmshell5 kcmaccess, did see no problem.
 
 
 Thanks,
 
 Toby Chen
 


___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 121357: Don't allow changing the volume when playing a notification

[Jeremy Whiting]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121357/#review71371
---

Ship it!


I agree.

- Jeremy Whiting


On Dec. 4, 2014, 2:23 p.m., Albert Astals Cid wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://git.reviewboard.kde.org/r/121357/
 ---
 
 (Updated Dec. 4, 2014, 2:23 p.m.)
 
 
 Review request for Plasma and David Edmundson.
 
 
 Repository: plasma-desktop
 
 
 Description
 ---
 
 Playing a notification is that, playing a notification. It is the user 
 responsability to change the volume to their liking.
 
 Suggested by David in https://git.reviewboard.kde.org/r/121278/
 
 Goes hand in hand with https://git.reviewboard.kde.org/r/121356/
 
 
 Diffs
 -
 
   kcms/knotify/playersettings.ui 54bb627 
   kcms/knotify/knotify.cpp b05c011 
 
 Diff: https://git.reviewboard.kde.org/r/121357/diff/
 
 
 Testing
 ---
 
 
 Thanks,
 
 Albert Astals Cid
 


___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request 121298: Remove KGlobal check and KComponentData object that overrode applications KAboutData when showing dialogs.

[Jeremy Whiting]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121298/
---

Review request for Plasma.


Repository: plasma-desktop


Description
---

Remove KGlobal check and KComponentData object that overrode applications 
KAboutData when showing dialogs.


Diffs
-

  attica-kde/kdeplugin/kdeplatformdependent.cpp 
4ade04c85db0c3efc0070bd0f288b16f3bd5882e 

Diff: https://git.reviewboard.kde.org/r/121298/diff/


Testing
---

Before this change any application that used knewstuff (and thus this plugin) 
showing a dialog would get -- attica_kde in the titlebar of the dialog. (run 
kanagram or blinken and show the about dialog to see).
With this change it correctly shows the application name there instead.


Thanks,

Jeremy Whiting

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 121298: Remove KGlobal check and KComponentData object that overrode applications KAboutData when showing dialogs.

[Jeremy Whiting]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121298/
---

(Updated Nov. 30, 2014, 9:58 p.m.)


Status
--

This change has been marked as submitted.


Review request for Plasma.


Repository: plasma-desktop


Description
---

Remove KGlobal check and KComponentData object that overrode applications 
KAboutData when showing dialogs.


Diffs
-

  attica-kde/kdeplugin/kdeplatformdependent.cpp 
4ade04c85db0c3efc0070bd0f288b16f3bd5882e 

Diff: https://git.reviewboard.kde.org/r/121298/diff/


Testing
---

Before this change any application that used knewstuff (and thus this plugin) 
showing a dialog would get -- attica_kde in the titlebar of the dialog. (run 
kanagram or blinken and show the about dialog to see).
With this change it correctly shows the application name there instead.


Thanks,

Jeremy Whiting

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 121161: Set KIO::Integration::AccessManager to null so we don't crash on close.

[Jeremy Whiting]

 On Nov. 17, 2014, 2:45 p.m., Thomas Lübking wrote:
  attica-kde/kdeplugin/kdeplatformdependent.cpp, line 56
  https://git.reviewboard.kde.org/r/121161/diff/2/?file=328928#file328928line56
 
  is
  
  KdePlatformDependent::~KdePlatformDependent()
  {
 if (QCoreApplication::closingDown())
m_accessManager-setParent(nullptr);
  }
  
  sufficient?
 
 Albert Astals Cid wrote:
 Isn't that a more complex way of doing the same?
 
 Thomas Lübking wrote:
 Depends on whether KdePlatformDependent is ever deleted in a running 
 application (where the leak would really matter)
 If not, then yes: superfluous complication.
 
 Jeremy Whiting wrote:
 Did I hear a Ship it! in there somewhere?
 
 Thomas Lübking wrote:
 Leaving aside that don't maintain the attica plugin, you have a +1 from 
 here, IF
 a) the conditional reparent on destruction is not sufficient (doesn't 
 work)
OR
 b) KdePlatformDependent object(s) are not supposed to be deleted during 
 the runtime of the application
 
 Ie. if the leak is inevitable or only theoretical.

Yep, I'm one of the attica and knewstuff maintainers and got the plugin to load 
recently, then hit this crash on close, so trying to fix it. The code in the 
plugin is only built with the plugin, so shouldn't be used besides as a plugin.

The conditional reparent probably works too, but as Albert said it's just a 
more complicated way of doing the same thing.


- Jeremy


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121161/#review70542
---


On Nov. 17, 2014, 2:11 p.m., Jeremy Whiting wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://git.reviewboard.kde.org/r/121161/
 ---
 
 (Updated Nov. 17, 2014, 2:11 p.m.)
 
 
 Review request for kdelibs and Plasma.
 
 
 Repository: plasma-desktop
 
 
 Description
 ---
 
 Plugin unload order was making the attica_kde plugin crash on close,
 this works around it by leaking one AccessManager.
 
 
 Diffs
 -
 
   attica-kde/kdeplugin/kdeplatformdependent.cpp 
 489c03b18b7bb940007ab51cb197105fbc25de9f 
 
 Diff: https://git.reviewboard.kde.org/r/121161/diff/
 
 
 Testing
 ---
 
 knewstuff tests no longer crash on close.
 
 
 Thanks,
 
 Jeremy Whiting
 


___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 121161: Set KIO::Integration::AccessManager to null so we don't crash on close.

[Jeremy Whiting]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121161/
---

(Updated Nov. 18, 2014, 7:30 p.m.)


Status
--

This change has been marked as submitted.


Review request for kdelibs and Plasma.


Repository: plasma-desktop


Description
---

Plugin unload order was making the attica_kde plugin crash on close,
this works around it by leaking one AccessManager.


Diffs
-

  attica-kde/kdeplugin/kdeplatformdependent.cpp 
489c03b18b7bb940007ab51cb197105fbc25de9f 

Diff: https://git.reviewboard.kde.org/r/121161/diff/


Testing
---

knewstuff tests no longer crash on close.


Thanks,

Jeremy Whiting

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request 121161: Set KIO::Integration::AccessManager to null so we don't crash on close.

[Jeremy Whiting]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121161/
---

Review request for kdelibs and Plasma.


Repository: plasma-desktop


Description
---

Plugin unload order was making the attica_kde plugin crash on close,
this works around it by leaking one AccessManager.


Diffs
-

  attica-kde/kdeplugin/kdeplatformdependent.cpp 
489c03b18b7bb940007ab51cb197105fbc25de9f 

Diff: https://git.reviewboard.kde.org/r/121161/diff/


Testing
---

knewstuff tests no longer crash on close.


Thanks,

Jeremy Whiting

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 121161: Set KIO::Integration::AccessManager to null so we don't crash on close.

[Jeremy Whiting]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121161/
---

(Updated Nov. 17, 2014, 2:11 p.m.)


Review request for Plasma.


Changes
---

Added FIXME comment.


Repository: plasma-desktop


Description
---

Plugin unload order was making the attica_kde plugin crash on close,
this works around it by leaking one AccessManager.


Diffs (updated)
-

  attica-kde/kdeplugin/kdeplatformdependent.cpp 
489c03b18b7bb940007ab51cb197105fbc25de9f 

Diff: https://git.reviewboard.kde.org/r/121161/diff/


Testing
---

knewstuff tests no longer crash on close.


Thanks,

Jeremy Whiting

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 121161: Set KIO::Integration::AccessManager to null so we don't crash on close.

[Jeremy Whiting]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121161/
---

(Updated Nov. 17, 2014, 2:11 p.m.)


Review request for kdelibs and Plasma.


Repository: plasma-desktop


Description
---

Plugin unload order was making the attica_kde plugin crash on close,
this works around it by leaking one AccessManager.


Diffs
-

  attica-kde/kdeplugin/kdeplatformdependent.cpp 
489c03b18b7bb940007ab51cb197105fbc25de9f 

Diff: https://git.reviewboard.kde.org/r/121161/diff/


Testing
---

knewstuff tests no longer crash on close.


Thanks,

Jeremy Whiting

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 121161: Set KIO::Integration::AccessManager to null so we don't crash on close.

[Jeremy Whiting]

 On Nov. 17, 2014, 2:45 p.m., Thomas Lübking wrote:
  attica-kde/kdeplugin/kdeplatformdependent.cpp, line 56
  https://git.reviewboard.kde.org/r/121161/diff/2/?file=328928#file328928line56
 
  is
  
  KdePlatformDependent::~KdePlatformDependent()
  {
 if (QCoreApplication::closingDown())
m_accessManager-setParent(nullptr);
  }
  
  sufficient?
 
 Albert Astals Cid wrote:
 Isn't that a more complex way of doing the same?
 
 Thomas Lübking wrote:
 Depends on whether KdePlatformDependent is ever deleted in a running 
 application (where the leak would really matter)
 If not, then yes: superfluous complication.

Did I hear a Ship it! in there somewhere?


- Jeremy


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121161/#review70542
---


On Nov. 17, 2014, 2:11 p.m., Jeremy Whiting wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://git.reviewboard.kde.org/r/121161/
 ---
 
 (Updated Nov. 17, 2014, 2:11 p.m.)
 
 
 Review request for kdelibs and Plasma.
 
 
 Repository: plasma-desktop
 
 
 Description
 ---
 
 Plugin unload order was making the attica_kde plugin crash on close,
 this works around it by leaking one AccessManager.
 
 
 Diffs
 -
 
   attica-kde/kdeplugin/kdeplatformdependent.cpp 
 489c03b18b7bb940007ab51cb197105fbc25de9f 
 
 Diff: https://git.reviewboard.kde.org/r/121161/diff/
 
 
 Testing
 ---
 
 knewstuff tests no longer crash on close.
 
 
 Thanks,
 
 Jeremy Whiting
 


___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request 121114: Add Q_PLUGIN_METADATA so the attica_kde.so plugin can be loaded by QPluginLoader.

[Jeremy Whiting]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121114/
---

Review request for Plasma.


Repository: plasma-desktop


Description
---

Add Q_PLUGIN_METADATA so the attica_kde.so plugin can be loaded by 
QPluginLoader.


Diffs
-

  attica-kde/kdeplugin/kdeplatformdependent.h 
69883dba4d24567a4787ebc8217beab0723891ea 

Diff: https://git.reviewboard.kde.org/r/121114/diff/


Testing
---

Before this attica would try to load the plugin (if it was installed in the 
right place, I've another attica patch to fix that) but failed because 
QPluginLoader::instance() would return null without this.

Now it works (with my attica patch)


Thanks,

Jeremy Whiting

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 120949: Add imageprovider to fifteenpuzzle.

[Jeremy Whiting]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120949/
---

(Updated Nov. 10, 2014, 5:57 p.m.)


Status
--

This change has been marked as submitted.


Review request for Plasma.


Repository: kdeplasma-addons


Description
---

ImageProvider plugin start, pieceWidth and pieceHeight are both 30 for now,
but need to come from the qml. This is a first attempt posting to get
feedback about the approach etc.


Diffs
-

  applets/fifteenPuzzle/package/contents/ui/main.qml 
c76eaeb4d936fe917d99375722905c2f002c33e6 
  applets/fifteenPuzzle/plugin/fifteenimageprovider.h PRE-CREATION 
  applets/fifteenPuzzle/plugin/fifteenimageprovider.cpp PRE-CREATION 
  applets/fifteenPuzzle/plugin/fifteenpuzzleplugin.h PRE-CREATION 
  applets/fifteenPuzzle/plugin/fifteenpuzzleplugin.cpp PRE-CREATION 
  applets/fifteenPuzzle/plugin/qmldir PRE-CREATION 
  applets/fifteenPuzzle/CMakeLists.txt c7e6a718a6211e0cde1121609ed28ec0fe8448f7 
  applets/fifteenPuzzle/package/contents/config/main.xml 
0dd804a12ddb0c7c2daaced1b92582f0deff494f 
  applets/fifteenPuzzle/package/contents/ui/FifteenPuzzle.qml 
bf9581bd78c1c7690fc16f01e440adad0fc98766 
  applets/fifteenPuzzle/package/contents/ui/Piece.qml 
c386570aebdf4323e3132aa05445b38383149dea 
  applets/fifteenPuzzle/package/contents/ui/configAppearance.qml 
d78c91b6e4182a2e461c1ee355b6ad30b63fbc68 

Diff: https://git.reviewboard.kde.org/r/120949/diff/


Testing
---

It builds and runs, currently doesn't shuffle, to test the result image works 
and appears.


Thanks,

Jeremy Whiting

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request 121097: Add a FileDialog to choose the image for fifteenpuzzle.

[Jeremy Whiting]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121097/
---

Review request for Plasma, David Edmundson, Eike Hein, and Marco Martin.


Repository: kdeplasma-addons


Description
---

Somehow this doesn't show the FileDialog here, not sure if it's a local problem 
though.


Diffs
-

  applets/fifteenPuzzle/package/contents/ui/configAppearance.qml 
5dfd2317bdc26849d1705e8826510bd05176b963 

Diff: https://git.reviewboard.kde.org/r/121097/diff/


Testing
---

Doesn't work here, but I'm hoping it's just a local problem.


Thanks,

Jeremy Whiting

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 121058: Don't put scripts from ~/.config/autostart in autostart kcm list.

[Jeremy Whiting]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121058/
---

(Updated Nov. 8, 2014, 11:59 p.m.)


Status
--

This change has been marked as submitted.


Review request for Plasma and Luca Beltrame.


Repository: plasma-desktop


Description
---

KLauncher doesn't start these, so we shouldn't list them.


Diffs
-

  kcms/autostart/autostart.cpp 8fe81ad7fc752936cd8ba1c799ad06bafd2c4006 

Diff: https://git.reviewboard.kde.org/r/121058/diff/


Testing
---

an executable script (ssh-add.sh) in ~/.config/autostart/ doesn't appear in the 
kcm here anymore.


Thanks,

Jeremy Whiting

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Autostart scripts (ksmserver problem)

[Jeremy Whiting]

Martin,

After further testing yesterday evening it seems placing scripts
(executable files) in ~/.config/plasma-workspace/env/ works fine.
These also correctly appear in the autostart kcm. The only confusion
left that I see is that scripts placed into ~/.config/autostart appear
in the kcm, but we aren't launching them, so shouldn't show those in
the kcm in my opinion.

BR,
Jeremy


On Fri, Nov 7, 2014 at 3:02 AM, Martin Yrjölä martin.yrj...@gmail.com wrote:
 On Fri, Nov 7, 2014 at 8:48 AM, Jeremy Whiting jpwhit...@kde.org wrote:
 IMO we have two problems here.

 1. the autostart kcm is showing scripts from ~/.config/autostart which
 kinit doesn't start. since ~/.config/autostart is an xdg path that is
 only meant to start .desktop files we probably shouldn't be showing
 scripts in the kcm that we don't start.
 2. Users with scripts in ~/.kde/Autostart will want a place to
 drop/move their scripts when moving to plasma-next. One solution to
 this would be to loudly document that each script needs a .desktop
 file created to actually launch it (easily done in the autostart kcm).
 Another probably better solution would be to define a place where
 ksmserver would look and execute or source scripts such as
 ~/.config/ksmserver-autostart or something.

 I'll work up a patch for 1 tomorrow, as that shouldn't be hard to not
 show those files.

 Thoughts?
 Jeremy


 Hi Jeremy!

 There's a ticket about this were I'm assigned
 https://bugs.kde.org/show_bug.cgi?id=338242

 I haven't made big strides on this issue as I have been terribly busy.
 It would be wonderful if you can come up with a patch to solve the
 issue.

 The proposed solutions in the ticket is to move all autostart
 functionality from kinit to ksmserver and after that add support for
 scripts. However I also like your solution of introducing a
 ~/.config/ksmserver-autostart directory that is managed by the
 autostart kcm and then the scripts are launched at the appropriate
 time in plasma-workspace/ksmserver/startup.cpp.

 Do you want to step up and get the ticket assigned to you Jeremy?

 Best regards,
 Martin Yrjölä
 ___
 Plasma-devel mailing list
 Plasma-devel@kde.org
 https://mail.kde.org/mailman/listinfo/plasma-devel
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request 121058: Don't put scripts from ~/.config/autostart in autostart kcm list.

[Jeremy Whiting]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121058/
---

Review request for kdelibs, Plasma and Luca Beltrame.


Repository: plasma-desktop


Description
---

KLauncher doesn't start these, so we shouldn't list them.


Diffs
-

  kcms/autostart/autostart.cpp 8fe81ad7fc752936cd8ba1c799ad06bafd2c4006 

Diff: https://git.reviewboard.kde.org/r/121058/diff/


Testing
---

an executable script (ssh-add.sh) in ~/.config/autostart/ doesn't appear in the 
kcm here anymore.


Thanks,

Jeremy Whiting

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 121058: Don't put scripts from ~/.config/autostart in autostart kcm list.

[Jeremy Whiting]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121058/
---

(Updated Nov. 7, 2014, 3:31 p.m.)


Review request for Plasma and Luca Beltrame.


Changes
---

Updated as per review.


Repository: plasma-desktop


Description
---

KLauncher doesn't start these, so we shouldn't list them.


Diffs (updated)
-

  kcms/autostart/autostart.cpp 8fe81ad7fc752936cd8ba1c799ad06bafd2c4006 

Diff: https://git.reviewboard.kde.org/r/121058/diff/


Testing
---

an executable script (ssh-add.sh) in ~/.config/autostart/ doesn't appear in the 
kcm here anymore.


Thanks,

Jeremy Whiting

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 121058: Don't put scripts from ~/.config/autostart in autostart kcm list.

[Jeremy Whiting]

 On Nov. 7, 2014, 3:26 p.m., Thomas Lübking wrote:
  kcms/autostart/autostart.cpp, line 214
  https://git.reviewboard.kde.org/r/121058/diff/1/?file=327176#file327176line214
 
  maybe cache that in a bool in the outer loop

Good idea.


- Jeremy


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121058/#review70018
---


On Nov. 7, 2014, 3:31 p.m., Jeremy Whiting wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://git.reviewboard.kde.org/r/121058/
 ---
 
 (Updated Nov. 7, 2014, 3:31 p.m.)
 
 
 Review request for Plasma and Luca Beltrame.
 
 
 Repository: plasma-desktop
 
 
 Description
 ---
 
 KLauncher doesn't start these, so we shouldn't list them.
 
 
 Diffs
 -
 
   kcms/autostart/autostart.cpp 8fe81ad7fc752936cd8ba1c799ad06bafd2c4006 
 
 Diff: https://git.reviewboard.kde.org/r/121058/diff/
 
 
 Testing
 ---
 
 an executable script (ssh-add.sh) in ~/.config/autostart/ doesn't appear in 
 the kcm here anymore.
 
 
 Thanks,
 
 Jeremy Whiting
 


___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 121058: Don't put scripts from ~/.config/autostart in autostart kcm list.

[Jeremy Whiting]

 On Nov. 7, 2014, 3:34 p.m., Thomas Lübking wrote:
  kcms/autostart/autostart.cpp, line 174
  https://git.reviewboard.kde.org/r/121058/diff/2/?file=327177#file327177line174
 
  I don't want to be annoyin, but isAutostart in Autostart::load() 
  and below autostartdir is probably suboptimal ;-)
  
  requiresServiceFile or similar?

how about inScriptSupportedDir ?


- Jeremy


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121058/#review70020
---


On Nov. 7, 2014, 3:31 p.m., Jeremy Whiting wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://git.reviewboard.kde.org/r/121058/
 ---
 
 (Updated Nov. 7, 2014, 3:31 p.m.)
 
 
 Review request for Plasma and Luca Beltrame.
 
 
 Repository: plasma-desktop
 
 
 Description
 ---
 
 KLauncher doesn't start these, so we shouldn't list them.
 
 
 Diffs
 -
 
   kcms/autostart/autostart.cpp 8fe81ad7fc752936cd8ba1c799ad06bafd2c4006 
 
 Diff: https://git.reviewboard.kde.org/r/121058/diff/
 
 
 Testing
 ---
 
 an executable script (ssh-add.sh) in ~/.config/autostart/ doesn't appear in 
 the kcm here anymore.
 
 
 Thanks,
 
 Jeremy Whiting
 


___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 121058: Don't put scripts from ~/.config/autostart in autostart kcm list.

[Jeremy Whiting]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121058/
---

(Updated Nov. 7, 2014, 8:09 p.m.)


Review request for Plasma and Luca Beltrame.


Changes
---

Updated as per review.


Repository: plasma-desktop


Description
---

KLauncher doesn't start these, so we shouldn't list them.


Diffs (updated)
-

  kcms/autostart/autostart.cpp 8fe81ad7fc752936cd8ba1c799ad06bafd2c4006 

Diff: https://git.reviewboard.kde.org/r/121058/diff/


Testing
---

an executable script (ssh-add.sh) in ~/.config/autostart/ doesn't appear in the 
kcm here anymore.


Thanks,

Jeremy Whiting

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Autostart scripts (ksmserver problem)

[Jeremy Whiting]

IMO we have two problems here.

1. the autostart kcm is showing scripts from ~/.config/autostart which
kinit doesn't start. since ~/.config/autostart is an xdg path that is
only meant to start .desktop files we probably shouldn't be showing
scripts in the kcm that we don't start.
2. Users with scripts in ~/.kde/Autostart will want a place to
drop/move their scripts when moving to plasma-next. One solution to
this would be to loudly document that each script needs a .desktop
file created to actually launch it (easily done in the autostart kcm).
Another probably better solution would be to define a place where
ksmserver would look and execute or source scripts such as
~/.config/ksmserver-autostart or something.

I'll work up a patch for 1 tomorrow, as that shouldn't be hard to not
show those files.

Thoughts?
Jeremy

On Tue, Aug 19, 2014 at 1:59 AM, Martin Yrjölä martin.yrj...@gmail.com wrote:



 On Wed, Aug 13, 2014 at 11:01 PM, Martin Yrjölä martin.yrj...@gmail.com
 wrote:


 hmm, so it seems the best option is to Add support for scripts in kinit?


 I submitted a patch to kinit in https://git.reviewboard.kde.org/r/119773/.

 David Faure commented that this issue should be solved in the workspace. As
 the xdg autostart standard only mentions desktop-files, should we make the
 Add script-button in the  Autostart KCM generate a desktop-file for the
 given script in the autostart-folder? Then we would only need to make
 changes to the Autostart KCM. The downside is that then we don't support
 console users that used to symlink their scripts to the autostart directory.
 I'm willing to provide a patch if we can settle on a solution. There's also
 a bug report for this: https://bugs.kde.org/show_bug.cgi?id=338242

 -Martin Yrjölä

 ___
 Plasma-devel mailing list
 Plasma-devel@kde.org
 https://mail.kde.org/mailman/listinfo/plasma-devel

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 120949: Add imageprovider to fifteenpuzzle.

[Jeremy Whiting]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120949/
---

(Updated Nov. 5, 2014, 7:23 p.m.)


Review request for Plasma.


Changes
---

Updated as per review. Image Provider no longer needs to be added to the 
context since all attributes come through the id when requesting images.
It works well here, though maybe a file chooser dialog should be added to pick 
an image with a gui.


Repository: kdeplasma-addons


Description
---

ImageProvider plugin start, pieceWidth and pieceHeight are both 30 for now,
but need to come from the qml. This is a first attempt posting to get
feedback about the approach etc.


Diffs (updated)
-

  applets/fifteenPuzzle/package/contents/ui/main.qml 
c76eaeb4d936fe917d99375722905c2f002c33e6 
  applets/fifteenPuzzle/plugin/fifteenimageprovider.h PRE-CREATION 
  applets/fifteenPuzzle/plugin/fifteenimageprovider.cpp PRE-CREATION 
  applets/fifteenPuzzle/plugin/fifteenpuzzleplugin.h PRE-CREATION 
  applets/fifteenPuzzle/plugin/fifteenpuzzleplugin.cpp PRE-CREATION 
  applets/fifteenPuzzle/plugin/qmldir PRE-CREATION 
  applets/fifteenPuzzle/CMakeLists.txt c7e6a718a6211e0cde1121609ed28ec0fe8448f7 
  applets/fifteenPuzzle/package/contents/config/main.xml 
0dd804a12ddb0c7c2daaced1b92582f0deff494f 
  applets/fifteenPuzzle/package/contents/ui/FifteenPuzzle.qml 
bf9581bd78c1c7690fc16f01e440adad0fc98766 
  applets/fifteenPuzzle/package/contents/ui/Piece.qml 
c386570aebdf4323e3132aa05445b38383149dea 
  applets/fifteenPuzzle/package/contents/ui/configAppearance.qml 
d78c91b6e4182a2e461c1ee355b6ad30b63fbc68 

Diff: https://git.reviewboard.kde.org/r/120949/diff/


Testing
---

It builds and runs, currently doesn't shuffle, to test the result image works 
and appears.


Thanks,

Jeremy Whiting

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 120949: Add imageprovider to fifteenpuzzle.

[Jeremy Whiting]

 On Nov. 3, 2014, 2:51 a.m., Marco Martin wrote:
  looks a bit overkill?

Marco,

Can you be more specific? which bit is overkill?


- Jeremy


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120949/#review69718
---


On Nov. 2, 2014, 3:09 p.m., Jeremy Whiting wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://git.reviewboard.kde.org/r/120949/
 ---
 
 (Updated Nov. 2, 2014, 3:09 p.m.)
 
 
 Review request for Plasma.
 
 
 Repository: kdeplasma-addons
 
 
 Description
 ---
 
 ImageProvider plugin start, pieceWidth and pieceHeight are both 30 for now,
 but need to come from the qml. This is a first attempt posting to get
 feedback about the approach etc.
 
 
 Diffs
 -
 
   applets/fifteenPuzzle/package/contents/config/main.xml 
 0dd804a12ddb0c7c2daaced1b92582f0deff494f 
   applets/fifteenPuzzle/package/contents/ui/FifteenPuzzle.qml 
 bf9581bd78c1c7690fc16f01e440adad0fc98766 
   applets/fifteenPuzzle/package/contents/ui/Piece.qml 
 c386570aebdf4323e3132aa05445b38383149dea 
   applets/fifteenPuzzle/package/contents/ui/configAppearance.qml 
 d78c91b6e4182a2e461c1ee355b6ad30b63fbc68 
   applets/fifteenPuzzle/package/contents/ui/main.qml 
 c76eaeb4d936fe917d99375722905c2f002c33e6 
   applets/fifteenPuzzle/plugin/fifteenimageprovider.h PRE-CREATION 
   applets/fifteenPuzzle/plugin/fifteenimageprovider.cpp PRE-CREATION 
   applets/fifteenPuzzle/plugin/fifteenpuzzleplugin.h PRE-CREATION 
   applets/fifteenPuzzle/plugin/fifteenpuzzleplugin.cpp PRE-CREATION 
   applets/fifteenPuzzle/plugin/qmldir PRE-CREATION 
   applets/fifteenPuzzle/CMakeLists.txt 
 c7e6a718a6211e0cde1121609ed28ec0fe8448f7 
 
 Diff: https://git.reviewboard.kde.org/r/120949/diff/
 
 
 Testing
 ---
 
 It builds and runs, currently doesn't shuffle, to test the result image works 
 and appears.
 
 
 Thanks,
 
 Jeremy Whiting
 


___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 120949: Add imageprovider to fifteenpuzzle.

[Jeremy Whiting]

 On Nov. 3, 2014, 1:47 a.m., Sebastian Kügler wrote:
  What's the purpose of this approach?

It was the only way I could think of to split the image, I'm open to better 
ideas though.


- Jeremy


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120949/#review69707
---


On Nov. 2, 2014, 3:09 p.m., Jeremy Whiting wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://git.reviewboard.kde.org/r/120949/
 ---
 
 (Updated Nov. 2, 2014, 3:09 p.m.)
 
 
 Review request for Plasma.
 
 
 Repository: kdeplasma-addons
 
 
 Description
 ---
 
 ImageProvider plugin start, pieceWidth and pieceHeight are both 30 for now,
 but need to come from the qml. This is a first attempt posting to get
 feedback about the approach etc.
 
 
 Diffs
 -
 
   applets/fifteenPuzzle/package/contents/config/main.xml 
 0dd804a12ddb0c7c2daaced1b92582f0deff494f 
   applets/fifteenPuzzle/package/contents/ui/FifteenPuzzle.qml 
 bf9581bd78c1c7690fc16f01e440adad0fc98766 
   applets/fifteenPuzzle/package/contents/ui/Piece.qml 
 c386570aebdf4323e3132aa05445b38383149dea 
   applets/fifteenPuzzle/package/contents/ui/configAppearance.qml 
 d78c91b6e4182a2e461c1ee355b6ad30b63fbc68 
   applets/fifteenPuzzle/package/contents/ui/main.qml 
 c76eaeb4d936fe917d99375722905c2f002c33e6 
   applets/fifteenPuzzle/plugin/fifteenimageprovider.h PRE-CREATION 
   applets/fifteenPuzzle/plugin/fifteenimageprovider.cpp PRE-CREATION 
   applets/fifteenPuzzle/plugin/fifteenpuzzleplugin.h PRE-CREATION 
   applets/fifteenPuzzle/plugin/fifteenpuzzleplugin.cpp PRE-CREATION 
   applets/fifteenPuzzle/plugin/qmldir PRE-CREATION 
   applets/fifteenPuzzle/CMakeLists.txt 
 c7e6a718a6211e0cde1121609ed28ec0fe8448f7 
 
 Diff: https://git.reviewboard.kde.org/r/120949/diff/
 
 
 Testing
 ---
 
 It builds and runs, currently doesn't shuffle, to test the result image works 
 and appears.
 
 
 Thanks,
 
 Jeremy Whiting
 


___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request 120949: Add imageprovider to fifteenpuzzle.

[Jeremy Whiting]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120949/
---

Review request for Plasma.


Repository: kdeplasma-addons


Description
---

ImageProvider plugin start, pieceWidth and pieceHeight are both 30 for now,
but need to come from the qml. This is a first attempt posting to get
feedback about the approach etc.


Diffs
-

  applets/fifteenPuzzle/package/contents/config/main.xml 
0dd804a12ddb0c7c2daaced1b92582f0deff494f 
  applets/fifteenPuzzle/package/contents/ui/FifteenPuzzle.qml 
bf9581bd78c1c7690fc16f01e440adad0fc98766 
  applets/fifteenPuzzle/package/contents/ui/Piece.qml 
c386570aebdf4323e3132aa05445b38383149dea 
  applets/fifteenPuzzle/package/contents/ui/configAppearance.qml 
d78c91b6e4182a2e461c1ee355b6ad30b63fbc68 
  applets/fifteenPuzzle/package/contents/ui/main.qml 
c76eaeb4d936fe917d99375722905c2f002c33e6 
  applets/fifteenPuzzle/plugin/fifteenimageprovider.h PRE-CREATION 
  applets/fifteenPuzzle/plugin/fifteenimageprovider.cpp PRE-CREATION 
  applets/fifteenPuzzle/plugin/fifteenpuzzleplugin.h PRE-CREATION 
  applets/fifteenPuzzle/plugin/fifteenpuzzleplugin.cpp PRE-CREATION 
  applets/fifteenPuzzle/plugin/qmldir PRE-CREATION 
  applets/fifteenPuzzle/CMakeLists.txt c7e6a718a6211e0cde1121609ed28ec0fe8448f7 

Diff: https://git.reviewboard.kde.org/r/120949/diff/


Testing
---

It builds and runs, currently doesn't shuffle, to test the result image works 
and appears.


Thanks,

Jeremy Whiting

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 120806: Port fifteenPuzzle applet to qml and plasma 5.

[Jeremy Whiting]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120806/
---

(Updated Oct. 29, 2014, 6:23 p.m.)


Status
--

This change has been marked as submitted.


Review request for Plasma and David Edmundson.


Repository: kdeplasma-addons


Description
---

Config options from previous c++ version kept though names are a bit diferent.
Images not yet supported.
Puzzle starts at 0 in the top left corner, maybe should start with 1 in the 
corner though.

This is my first port to plasma qml, so I may have used some of the non 
suggested/recommended components, if so let me know and I'll fix it.


Diffs
-

  applets/CMakeLists.txt 63e6e25628d18ee474231acd2a21711841dee592 
  applets/fifteenPuzzle/CMakeLists.txt 04d5e55fd246684855d49484f1233dac054a0124 
  applets/fifteenPuzzle/Messages.sh PRE-CREATION 
  applets/fifteenPuzzle/icons/CMakeLists.txt 
106884f432c1d1e0b0584959af854c79ede4ea6d 
  applets/fifteenPuzzle/icons/hisc-app-fifteenpuzzle.svgz  
  applets/fifteenPuzzle/images/blanksquare.svg  
  applets/fifteenPuzzle/package/contents/config/config.qml PRE-CREATION 
  applets/fifteenPuzzle/package/contents/config/main.xml PRE-CREATION 
  applets/fifteenPuzzle/package/contents/ui/ColorPicker.qml PRE-CREATION 
  applets/fifteenPuzzle/package/contents/ui/FifteenPuzzle.qml PRE-CREATION 
  applets/fifteenPuzzle/package/contents/ui/Piece.qml PRE-CREATION 
  applets/fifteenPuzzle/package/contents/ui/configAppearance.qml PRE-CREATION 
  applets/fifteenPuzzle/package/contents/ui/main.qml PRE-CREATION 
  applets/fifteenPuzzle/plasma-applet-fifteenPuzzle.desktop 
513cc0084df7247a520807620361b0426623727e 
  applets/fifteenPuzzle/src/Messages.sh 
bab24ae73049f37d9693cf062eaaa98ca1e6bab0 
  applets/fifteenPuzzle/src/fifteen.h 2a27f5b109988003de45fb64c457484ebdfdbc8b 
  applets/fifteenPuzzle/src/fifteen.cpp 
ebdcf2c0756a17ea174c0fc5fd106e157b223063 
  applets/fifteenPuzzle/src/fifteenPuzzle.h 
cf7885380f0e152d51cf2dc7557444e9b425b596 
  applets/fifteenPuzzle/src/fifteenPuzzle.cpp 
8a1528988f3e693d20179db4a209309b0aad87fd 
  applets/fifteenPuzzle/src/fifteenPuzzleConfig.ui 
ff82f331db4cee2d66f526954be63f0f5d81d250 
  applets/fifteenPuzzle/src/piece.h d0e58d0f9d38d4a1ef2110b974b3f4f6938293e1 
  applets/fifteenPuzzle/src/piece.cpp 2efb72ecf69d9beaa53367bc2f3c9cee88238f28 
  applets/systemloadviewer/package/contents/ui/ColorPicker.qml 
92062db546dcff67f930d4888180f4e753798c27 

Diff: https://git.reviewboard.kde.org/r/120806/diff/


Testing
---

I've tested it with plasmoidviewer -a org.kde.plasma.fifteenpuzzle. 

The icon is not working in the widget adder, not sure where to install that to 
for it to work.
Images not supported yet, though they are in the config, maybe should remove 
from config until they are supported?


Thanks,

Jeremy Whiting

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 120806: Port fifteenPuzzle applet to qml and plasma 5.

[Jeremy Whiting]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120806/
---

(Updated Oct. 28, 2014, 11:47 a.m.)


Review request for Plasma and David Edmundson.


Changes
---

Set a minimum size on the applet and set switchWidth and switchHeight so it 
will become an icon when it's too small to look decent.


Repository: kdeplasma-addons


Description
---

Config options from previous c++ version kept though names are a bit diferent.
Images not yet supported.
Puzzle starts at 0 in the top left corner, maybe should start with 1 in the 
corner though.

This is my first port to plasma qml, so I may have used some of the non 
suggested/recommended components, if so let me know and I'll fix it.


Diffs (updated)
-

  applets/CMakeLists.txt 63e6e25628d18ee474231acd2a21711841dee592 
  applets/fifteenPuzzle/CMakeLists.txt 04d5e55fd246684855d49484f1233dac054a0124 
  applets/fifteenPuzzle/Messages.sh PRE-CREATION 
  applets/fifteenPuzzle/icons/CMakeLists.txt 
106884f432c1d1e0b0584959af854c79ede4ea6d 
  applets/fifteenPuzzle/icons/hisc-app-fifteenpuzzle.svgz  
  applets/fifteenPuzzle/images/blanksquare.svg  
  applets/fifteenPuzzle/package/contents/config/config.qml PRE-CREATION 
  applets/fifteenPuzzle/package/contents/config/main.xml PRE-CREATION 
  applets/fifteenPuzzle/package/contents/ui/ColorPicker.qml PRE-CREATION 
  applets/fifteenPuzzle/package/contents/ui/FifteenPuzzle.qml PRE-CREATION 
  applets/fifteenPuzzle/package/contents/ui/Piece.qml PRE-CREATION 
  applets/fifteenPuzzle/package/contents/ui/configAppearance.qml PRE-CREATION 
  applets/fifteenPuzzle/package/contents/ui/main.qml PRE-CREATION 
  applets/fifteenPuzzle/plasma-applet-fifteenPuzzle.desktop 
513cc0084df7247a520807620361b0426623727e 
  applets/fifteenPuzzle/src/Messages.sh 
bab24ae73049f37d9693cf062eaaa98ca1e6bab0 
  applets/fifteenPuzzle/src/fifteen.h 2a27f5b109988003de45fb64c457484ebdfdbc8b 
  applets/fifteenPuzzle/src/fifteen.cpp 
ebdcf2c0756a17ea174c0fc5fd106e157b223063 
  applets/fifteenPuzzle/src/fifteenPuzzle.h 
cf7885380f0e152d51cf2dc7557444e9b425b596 
  applets/fifteenPuzzle/src/fifteenPuzzle.cpp 
8a1528988f3e693d20179db4a209309b0aad87fd 
  applets/fifteenPuzzle/src/fifteenPuzzleConfig.ui 
ff82f331db4cee2d66f526954be63f0f5d81d250 
  applets/fifteenPuzzle/src/piece.h d0e58d0f9d38d4a1ef2110b974b3f4f6938293e1 
  applets/fifteenPuzzle/src/piece.cpp 2efb72ecf69d9beaa53367bc2f3c9cee88238f28 
  applets/systemloadviewer/package/contents/ui/ColorPicker.qml 
92062db546dcff67f930d4888180f4e753798c27 

Diff: https://git.reviewboard.kde.org/r/120806/diff/


Testing
---

I've tested it with plasmoidviewer -a org.kde.plasma.fifteenpuzzle. 

The icon is not working in the widget adder, not sure where to install that to 
for it to work.
Images not supported yet, though they are in the config, maybe should remove 
from config until they are supported?


Thanks,

Jeremy Whiting

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 120806: Port fifteenPuzzle applet to qml and plasma 5.

[Jeremy Whiting]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120806/
---

(Updated Oct. 28, 2014, 11:48 a.m.)


Review request for Plasma and David Edmundson.


Changes
---

Add minimum size and set switch to the minimum size so it becomes an icon at 
smaller sizes.


Repository: kdeplasma-addons


Description
---

Config options from previous c++ version kept though names are a bit diferent.
Images not yet supported.
Puzzle starts at 0 in the top left corner, maybe should start with 1 in the 
corner though.

This is my first port to plasma qml, so I may have used some of the non 
suggested/recommended components, if so let me know and I'll fix it.


Diffs
-

  applets/CMakeLists.txt 63e6e25628d18ee474231acd2a21711841dee592 
  applets/fifteenPuzzle/CMakeLists.txt 04d5e55fd246684855d49484f1233dac054a0124 
  applets/fifteenPuzzle/Messages.sh PRE-CREATION 
  applets/fifteenPuzzle/icons/CMakeLists.txt 
106884f432c1d1e0b0584959af854c79ede4ea6d 
  applets/fifteenPuzzle/icons/hisc-app-fifteenpuzzle.svgz  
  applets/fifteenPuzzle/images/blanksquare.svg  
  applets/fifteenPuzzle/package/contents/config/config.qml PRE-CREATION 
  applets/fifteenPuzzle/package/contents/config/main.xml PRE-CREATION 
  applets/fifteenPuzzle/package/contents/ui/ColorPicker.qml PRE-CREATION 
  applets/fifteenPuzzle/package/contents/ui/FifteenPuzzle.qml PRE-CREATION 
  applets/fifteenPuzzle/package/contents/ui/Piece.qml PRE-CREATION 
  applets/fifteenPuzzle/package/contents/ui/configAppearance.qml PRE-CREATION 
  applets/fifteenPuzzle/package/contents/ui/main.qml PRE-CREATION 
  applets/fifteenPuzzle/plasma-applet-fifteenPuzzle.desktop 
513cc0084df7247a520807620361b0426623727e 
  applets/fifteenPuzzle/src/Messages.sh 
bab24ae73049f37d9693cf062eaaa98ca1e6bab0 
  applets/fifteenPuzzle/src/fifteen.h 2a27f5b109988003de45fb64c457484ebdfdbc8b 
  applets/fifteenPuzzle/src/fifteen.cpp 
ebdcf2c0756a17ea174c0fc5fd106e157b223063 
  applets/fifteenPuzzle/src/fifteenPuzzle.h 
cf7885380f0e152d51cf2dc7557444e9b425b596 
  applets/fifteenPuzzle/src/fifteenPuzzle.cpp 
8a1528988f3e693d20179db4a209309b0aad87fd 
  applets/fifteenPuzzle/src/fifteenPuzzleConfig.ui 
ff82f331db4cee2d66f526954be63f0f5d81d250 
  applets/fifteenPuzzle/src/piece.h d0e58d0f9d38d4a1ef2110b974b3f4f6938293e1 
  applets/fifteenPuzzle/src/piece.cpp 2efb72ecf69d9beaa53367bc2f3c9cee88238f28 
  applets/systemloadviewer/package/contents/ui/ColorPicker.qml 
92062db546dcff67f930d4888180f4e753798c27 

Diff: https://git.reviewboard.kde.org/r/120806/diff/


Testing
---

I've tested it with plasmoidviewer -a org.kde.plasma.fifteenpuzzle. 

The icon is not working in the widget adder, not sure where to install that to 
for it to work.
Images not supported yet, though they are in the config, maybe should remove 
from config until they are supported?


Thanks,

Jeremy Whiting

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 120806: Port fifteenPuzzle applet to qml and plasma 5.

[Jeremy Whiting]

 On Oct. 26, 2014, 4:14 p.m., David Edmundson wrote:
  applets/fifteenPuzzle/package/contents/config/config.qml, line 2
  https://git.reviewboard.kde.org/r/120806/diff/1/?file=322089#file322089line2
 
  This guy gets everywhere.

Yep, I copied config.qml from fuzzyclock, so left the copyrights from there.


 On Oct. 26, 2014, 4:14 p.m., David Edmundson wrote:
  applets/fifteenPuzzle/package/contents/ui/FifteenPuzzle.qml, line 176
  https://git.reviewboard.kde.org/r/120806/diff/1/?file=322092#file322092line176
 
  there's a format time in kdeclarative somewhere.
  
  Some languages might not use :

I thought this was ok since it's wrapped in i18n, translators will set it to 
whatever they use in their locale, no?


- Jeremy


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120806/#review69173
---


On Oct. 25, 2014, 11:48 p.m., Jeremy Whiting wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://git.reviewboard.kde.org/r/120806/
 ---
 
 (Updated Oct. 25, 2014, 11:48 p.m.)
 
 
 Review request for Plasma and David Edmundson.
 
 
 Repository: kdeplasma-addons
 
 
 Description
 ---
 
 Config options from previous c++ version kept though names are a bit diferent.
 Images not yet supported.
 Puzzle starts at 0 in the top left corner, maybe should start with 1 in the 
 corner though.
 
 This is my first port to plasma qml, so I may have used some of the non 
 suggested/recommended components, if so let me know and I'll fix it.
 
 
 Diffs
 -
 
   applets/fifteenPuzzle/src/Messages.sh 
 bab24ae73049f37d9693cf062eaaa98ca1e6bab0 
   applets/fifteenPuzzle/src/fifteen.h 
 2a27f5b109988003de45fb64c457484ebdfdbc8b 
   applets/fifteenPuzzle/src/fifteen.cpp 
 ebdcf2c0756a17ea174c0fc5fd106e157b223063 
   applets/fifteenPuzzle/src/fifteenPuzzle.h 
 cf7885380f0e152d51cf2dc7557444e9b425b596 
   applets/fifteenPuzzle/src/fifteenPuzzle.cpp 
 8a1528988f3e693d20179db4a209309b0aad87fd 
   applets/fifteenPuzzle/src/fifteenPuzzleConfig.ui 
 ff82f331db4cee2d66f526954be63f0f5d81d250 
   applets/fifteenPuzzle/src/piece.h d0e58d0f9d38d4a1ef2110b974b3f4f6938293e1 
   applets/fifteenPuzzle/src/piece.cpp 
 2efb72ecf69d9beaa53367bc2f3c9cee88238f28 
   applets/fifteenPuzzle/package/contents/config/main.xml PRE-CREATION 
   applets/fifteenPuzzle/package/contents/ui/ColorPicker.qml PRE-CREATION 
   applets/fifteenPuzzle/package/contents/ui/FifteenPuzzle.qml PRE-CREATION 
   applets/fifteenPuzzle/package/contents/ui/Piece.qml PRE-CREATION 
   applets/fifteenPuzzle/package/contents/ui/configAppearance.qml PRE-CREATION 
   applets/fifteenPuzzle/package/contents/ui/main.qml PRE-CREATION 
   applets/fifteenPuzzle/plasma-applet-fifteenPuzzle.desktop 
 513cc0084df7247a520807620361b0426623727e 
   applets/fifteenPuzzle/icons/CMakeLists.txt 
 106884f432c1d1e0b0584959af854c79ede4ea6d 
   applets/fifteenPuzzle/icons/hisc-app-fifteenpuzzle.svgz  
   applets/fifteenPuzzle/images/blanksquare.svg  
   applets/fifteenPuzzle/package/contents/config/config.qml PRE-CREATION 
   applets/CMakeLists.txt 63e6e25628d18ee474231acd2a21711841dee592 
   applets/fifteenPuzzle/CMakeLists.txt 
 04d5e55fd246684855d49484f1233dac054a0124 
   applets/fifteenPuzzle/Messages.sh PRE-CREATION 
 
 Diff: https://git.reviewboard.kde.org/r/120806/diff/
 
 
 Testing
 ---
 
 I've tested it with plasmoidviewer -a org.kde.plasma.fifteenpuzzle. 
 
 The icon is not working in the widget adder, not sure where to install that 
 to for it to work.
 Images not supported yet, though they are in the config, maybe should remove 
 from config until they are supported?
 
 
 Thanks,
 
 Jeremy Whiting
 


___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 120806: Port fifteenPuzzle applet to qml and plasma 5.

[Jeremy Whiting]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120806/
---

(Updated Oct. 27, 2014, 10:05 a.m.)


Review request for Plasma and David Edmundson.


Changes
---

Fixed most items pointed out and fixed fillBoard when size changes.


Repository: kdeplasma-addons


Description
---

Config options from previous c++ version kept though names are a bit diferent.
Images not yet supported.
Puzzle starts at 0 in the top left corner, maybe should start with 1 in the 
corner though.

This is my first port to plasma qml, so I may have used some of the non 
suggested/recommended components, if so let me know and I'll fix it.


Diffs (updated)
-

  applets/fifteenPuzzle/src/fifteenPuzzleConfig.ui 
ff82f331db4cee2d66f526954be63f0f5d81d250 
  applets/fifteenPuzzle/src/fifteenPuzzle.cpp 
8a1528988f3e693d20179db4a209309b0aad87fd 
  applets/CMakeLists.txt 63e6e25628d18ee474231acd2a21711841dee592 
  applets/fifteenPuzzle/CMakeLists.txt 04d5e55fd246684855d49484f1233dac054a0124 
  applets/fifteenPuzzle/Messages.sh PRE-CREATION 
  applets/fifteenPuzzle/icons/CMakeLists.txt 
106884f432c1d1e0b0584959af854c79ede4ea6d 
  applets/fifteenPuzzle/icons/hisc-app-fifteenpuzzle.svgz  
  applets/fifteenPuzzle/images/blanksquare.svg  
  applets/fifteenPuzzle/package/contents/config/config.qml PRE-CREATION 
  applets/fifteenPuzzle/package/contents/config/main.xml PRE-CREATION 
  applets/systemloadviewer/package/contents/ui/ColorPicker.qml 
92062db546dcff67f930d4888180f4e753798c27 
  applets/fifteenPuzzle/src/piece.h d0e58d0f9d38d4a1ef2110b974b3f4f6938293e1 
  applets/fifteenPuzzle/src/piece.cpp 2efb72ecf69d9beaa53367bc2f3c9cee88238f28 
  applets/fifteenPuzzle/src/fifteenPuzzle.h 
cf7885380f0e152d51cf2dc7557444e9b425b596 
  applets/fifteenPuzzle/package/contents/ui/configAppearance.qml PRE-CREATION 
  applets/fifteenPuzzle/package/contents/ui/main.qml PRE-CREATION 
  applets/fifteenPuzzle/plasma-applet-fifteenPuzzle.desktop 
513cc0084df7247a520807620361b0426623727e 
  applets/fifteenPuzzle/src/Messages.sh 
bab24ae73049f37d9693cf062eaaa98ca1e6bab0 
  applets/fifteenPuzzle/src/fifteen.h 2a27f5b109988003de45fb64c457484ebdfdbc8b 
  applets/fifteenPuzzle/src/fifteen.cpp 
ebdcf2c0756a17ea174c0fc5fd106e157b223063 
  applets/fifteenPuzzle/package/contents/ui/ColorPicker.qml PRE-CREATION 
  applets/fifteenPuzzle/package/contents/ui/FifteenPuzzle.qml PRE-CREATION 
  applets/fifteenPuzzle/package/contents/ui/Piece.qml PRE-CREATION 

Diff: https://git.reviewboard.kde.org/r/120806/diff/


Testing
---

I've tested it with plasmoidviewer -a org.kde.plasma.fifteenpuzzle. 

The icon is not working in the widget adder, not sure where to install that to 
for it to work.
Images not supported yet, though they are in the config, maybe should remove 
from config until they are supported?


Thanks,

Jeremy Whiting

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 120806: Port fifteenPuzzle applet to qml and plasma 5.

[Jeremy Whiting]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120806/
---

(Updated Oct. 27, 2014, 2:29 p.m.)


Review request for Plasma and David Edmundson.


Changes
---

Updated with feedback. All issues fixed, hours are showing in the timer with 
FoldHours, but that could be a bug in KFormat or something.


Repository: kdeplasma-addons


Description
---

Config options from previous c++ version kept though names are a bit diferent.
Images not yet supported.
Puzzle starts at 0 in the top left corner, maybe should start with 1 in the 
corner though.

This is my first port to plasma qml, so I may have used some of the non 
suggested/recommended components, if so let me know and I'll fix it.


Diffs (updated)
-

  applets/CMakeLists.txt 63e6e25628d18ee474231acd2a21711841dee592 
  applets/fifteenPuzzle/CMakeLists.txt 04d5e55fd246684855d49484f1233dac054a0124 
  applets/fifteenPuzzle/Messages.sh PRE-CREATION 
  applets/fifteenPuzzle/icons/CMakeLists.txt 
106884f432c1d1e0b0584959af854c79ede4ea6d 
  applets/fifteenPuzzle/icons/hisc-app-fifteenpuzzle.svgz  
  applets/fifteenPuzzle/images/blanksquare.svg  
  applets/fifteenPuzzle/package/contents/config/config.qml PRE-CREATION 
  applets/fifteenPuzzle/package/contents/config/main.xml PRE-CREATION 
  applets/fifteenPuzzle/package/contents/ui/ColorPicker.qml PRE-CREATION 
  applets/fifteenPuzzle/package/contents/ui/FifteenPuzzle.qml PRE-CREATION 
  applets/fifteenPuzzle/package/contents/ui/Piece.qml PRE-CREATION 
  applets/fifteenPuzzle/package/contents/ui/configAppearance.qml PRE-CREATION 
  applets/fifteenPuzzle/package/contents/ui/main.qml PRE-CREATION 
  applets/fifteenPuzzle/plasma-applet-fifteenPuzzle.desktop 
513cc0084df7247a520807620361b0426623727e 
  applets/fifteenPuzzle/src/Messages.sh 
bab24ae73049f37d9693cf062eaaa98ca1e6bab0 
  applets/fifteenPuzzle/src/fifteen.h 2a27f5b109988003de45fb64c457484ebdfdbc8b 
  applets/fifteenPuzzle/src/fifteen.cpp 
ebdcf2c0756a17ea174c0fc5fd106e157b223063 
  applets/fifteenPuzzle/src/fifteenPuzzle.h 
cf7885380f0e152d51cf2dc7557444e9b425b596 
  applets/fifteenPuzzle/src/fifteenPuzzle.cpp 
8a1528988f3e693d20179db4a209309b0aad87fd 
  applets/fifteenPuzzle/src/fifteenPuzzleConfig.ui 
ff82f331db4cee2d66f526954be63f0f5d81d250 
  applets/fifteenPuzzle/src/piece.h d0e58d0f9d38d4a1ef2110b974b3f4f6938293e1 
  applets/fifteenPuzzle/src/piece.cpp 2efb72ecf69d9beaa53367bc2f3c9cee88238f28 
  applets/systemloadviewer/package/contents/ui/ColorPicker.qml 
92062db546dcff67f930d4888180f4e753798c27 

Diff: https://git.reviewboard.kde.org/r/120806/diff/


Testing
---

I've tested it with plasmoidviewer -a org.kde.plasma.fifteenpuzzle. 

The icon is not working in the widget adder, not sure where to install that to 
for it to work.
Images not supported yet, though they are in the config, maybe should remove 
from config until they are supported?


Thanks,

Jeremy Whiting

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 120806: Port fifteenPuzzle applet to qml and plasma 5.

[Jeremy Whiting]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120806/
---

(Updated Oct. 27, 2014, 2:38 p.m.)


Review request for Plasma and David Edmundson.


Changes
---

Put i18n comment back in and used %1 instead of appending the time.


Repository: kdeplasma-addons


Description
---

Config options from previous c++ version kept though names are a bit diferent.
Images not yet supported.
Puzzle starts at 0 in the top left corner, maybe should start with 1 in the 
corner though.

This is my first port to plasma qml, so I may have used some of the non 
suggested/recommended components, if so let me know and I'll fix it.


Diffs (updated)
-

  applets/CMakeLists.txt 63e6e25628d18ee474231acd2a21711841dee592 
  applets/fifteenPuzzle/CMakeLists.txt 04d5e55fd246684855d49484f1233dac054a0124 
  applets/fifteenPuzzle/Messages.sh PRE-CREATION 
  applets/fifteenPuzzle/icons/CMakeLists.txt 
106884f432c1d1e0b0584959af854c79ede4ea6d 
  applets/fifteenPuzzle/icons/hisc-app-fifteenpuzzle.svgz  
  applets/fifteenPuzzle/images/blanksquare.svg  
  applets/fifteenPuzzle/package/contents/config/config.qml PRE-CREATION 
  applets/fifteenPuzzle/package/contents/config/main.xml PRE-CREATION 
  applets/fifteenPuzzle/package/contents/ui/ColorPicker.qml PRE-CREATION 
  applets/fifteenPuzzle/package/contents/ui/FifteenPuzzle.qml PRE-CREATION 
  applets/fifteenPuzzle/package/contents/ui/Piece.qml PRE-CREATION 
  applets/fifteenPuzzle/package/contents/ui/configAppearance.qml PRE-CREATION 
  applets/fifteenPuzzle/package/contents/ui/main.qml PRE-CREATION 
  applets/fifteenPuzzle/plasma-applet-fifteenPuzzle.desktop 
513cc0084df7247a520807620361b0426623727e 
  applets/fifteenPuzzle/src/Messages.sh 
bab24ae73049f37d9693cf062eaaa98ca1e6bab0 
  applets/fifteenPuzzle/src/fifteen.h 2a27f5b109988003de45fb64c457484ebdfdbc8b 
  applets/fifteenPuzzle/src/fifteen.cpp 
ebdcf2c0756a17ea174c0fc5fd106e157b223063 
  applets/fifteenPuzzle/src/fifteenPuzzle.h 
cf7885380f0e152d51cf2dc7557444e9b425b596 
  applets/fifteenPuzzle/src/fifteenPuzzle.cpp 
8a1528988f3e693d20179db4a209309b0aad87fd 
  applets/fifteenPuzzle/src/fifteenPuzzleConfig.ui 
ff82f331db4cee2d66f526954be63f0f5d81d250 
  applets/fifteenPuzzle/src/piece.h d0e58d0f9d38d4a1ef2110b974b3f4f6938293e1 
  applets/fifteenPuzzle/src/piece.cpp 2efb72ecf69d9beaa53367bc2f3c9cee88238f28 
  applets/systemloadviewer/package/contents/ui/ColorPicker.qml 
92062db546dcff67f930d4888180f4e753798c27 

Diff: https://git.reviewboard.kde.org/r/120806/diff/


Testing
---

I've tested it with plasmoidviewer -a org.kde.plasma.fifteenpuzzle. 

The icon is not working in the widget adder, not sure where to install that to 
for it to work.
Images not supported yet, though they are in the config, maybe should remove 
from config until they are supported?


Thanks,

Jeremy Whiting

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request 120806: Port fifteenPuzzle applet to qml and plasma 5.

[Jeremy Whiting]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120806/
---

Review request for Plasma and David Edmundson.


Repository: kdeplasma-addons


Description
---

Config options from previous c++ version kept though names are a bit diferent.
Images not yet supported.
Puzzle starts at 0 in the top left corner, maybe should start with 1 in the 
corner though.

This is my first port to plasma qml, so I may have used some of the non 
suggested/recommended components, if so let me know and I'll fix it.


Diffs
-

  applets/fifteenPuzzle/src/Messages.sh 
bab24ae73049f37d9693cf062eaaa98ca1e6bab0 
  applets/fifteenPuzzle/src/fifteen.h 2a27f5b109988003de45fb64c457484ebdfdbc8b 
  applets/fifteenPuzzle/src/fifteen.cpp 
ebdcf2c0756a17ea174c0fc5fd106e157b223063 
  applets/fifteenPuzzle/src/fifteenPuzzle.h 
cf7885380f0e152d51cf2dc7557444e9b425b596 
  applets/fifteenPuzzle/src/fifteenPuzzle.cpp 
8a1528988f3e693d20179db4a209309b0aad87fd 
  applets/fifteenPuzzle/src/fifteenPuzzleConfig.ui 
ff82f331db4cee2d66f526954be63f0f5d81d250 
  applets/fifteenPuzzle/src/piece.h d0e58d0f9d38d4a1ef2110b974b3f4f6938293e1 
  applets/fifteenPuzzle/src/piece.cpp 2efb72ecf69d9beaa53367bc2f3c9cee88238f28 
  applets/fifteenPuzzle/package/contents/config/main.xml PRE-CREATION 
  applets/fifteenPuzzle/package/contents/ui/ColorPicker.qml PRE-CREATION 
  applets/fifteenPuzzle/package/contents/ui/FifteenPuzzle.qml PRE-CREATION 
  applets/fifteenPuzzle/package/contents/ui/Piece.qml PRE-CREATION 
  applets/fifteenPuzzle/package/contents/ui/configAppearance.qml PRE-CREATION 
  applets/fifteenPuzzle/package/contents/ui/main.qml PRE-CREATION 
  applets/fifteenPuzzle/plasma-applet-fifteenPuzzle.desktop 
513cc0084df7247a520807620361b0426623727e 
  applets/fifteenPuzzle/icons/CMakeLists.txt 
106884f432c1d1e0b0584959af854c79ede4ea6d 
  applets/fifteenPuzzle/icons/hisc-app-fifteenpuzzle.svgz  
  applets/fifteenPuzzle/images/blanksquare.svg  
  applets/fifteenPuzzle/package/contents/config/config.qml PRE-CREATION 
  applets/CMakeLists.txt 63e6e25628d18ee474231acd2a21711841dee592 
  applets/fifteenPuzzle/CMakeLists.txt 04d5e55fd246684855d49484f1233dac054a0124 
  applets/fifteenPuzzle/Messages.sh PRE-CREATION 

Diff: https://git.reviewboard.kde.org/r/120806/diff/


Testing
---

I've tested it with plasmoidviewer -a org.kde.plasma.fifteenpuzzle. 

The icon is not working in the widget adder, not sure where to install that to 
for it to work.
Images not supported yet, though they are in the config, maybe should remove 
from config until they are supported?


Thanks,

Jeremy Whiting

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 120584: Don't position the panel until it's about to be displayed

[Jeremy Whiting]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120584/#review68401
---


That seems to fix the panel showing on the wrong screen I was experiencing 
before. Nice.

- Jeremy Whiting


On Oct. 14, 2014, 10:15 a.m., Aleix Pol Gonzalez wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://git.reviewboard.kde.org/r/120584/
 ---
 
 (Updated Oct. 14, 2014, 10:15 a.m.)
 
 
 Review request for Plasma.
 
 
 Repository: plasma-workspace
 
 
 Description
 ---
 
 I was getting the Panels wrongly positioned because Qt would reset the 
 position at some point while initializing the class. This patch disables any 
 position while the panel is not shown and makes sure it's placed when it's 
 set to be shown.
 
 
 Diffs
 -
 
   shell/panelview.cpp 9260c18 
 
 Diff: https://git.reviewboard.kde.org/r/120584/diff/
 
 
 Testing
 ---
 
 Both my installations initialize properly now.
 
 
 Thanks,
 
 Aleix Pol Gonzalez
 


___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 120584: Don't position the panel until it's about to be displayed

[Jeremy Whiting]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120584/#review68402
---

Ship it!


Ship It!

- Jeremy Whiting


On Oct. 14, 2014, 10:15 a.m., Aleix Pol Gonzalez wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://git.reviewboard.kde.org/r/120584/
 ---
 
 (Updated Oct. 14, 2014, 10:15 a.m.)
 
 
 Review request for Plasma.
 
 
 Repository: plasma-workspace
 
 
 Description
 ---
 
 I was getting the Panels wrongly positioned because Qt would reset the 
 position at some point while initializing the class. This patch disables any 
 position while the panel is not shown and makes sure it's placed when it's 
 set to be shown.
 
 
 Diffs
 -
 
   shell/panelview.cpp 9260c18 
 
 Diff: https://git.reviewboard.kde.org/r/120584/diff/
 
 
 Testing
 ---
 
 Both my installations initialize properly now.
 
 
 Thanks,
 
 Aleix Pol Gonzalez
 


___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Muon and kde-gtk-config moved to kde/workspace - was - Re: Moving repositories in the module structure

[Jeremy Whiting]

On Sun, Oct 5, 2014 at 12:30 PM, Albert Astals Cid aa...@kde.org wrote:
 El Divendres, 3 d'octubre de 2014, a les 03:28:44, Aleix Pol va escriure:
 On Fri, Oct 3, 2014 at 1:52 AM, Albert Astals Cid aa...@kde.org wrote:
  El Divendres, 3 d'octubre de 2014, a les 00:04:42, Aleix Pol va escriure:
   On Thu, Oct 2, 2014 at 11:34 PM, Ben Cooksley bcooks...@kde.org wrote:
Hi all,
   
It seems there has been a recent outbreak of repository moves which
have been extremely poorly co-ordinated by those doing the requests.
   
In addition, it is actually a requirement that modules moving from
Extragear into (what was at least) the SC need to re-transit through
KDE Review.It is also considered proper practice to at least inform
the translation, documentation and release  teams in advance you
intend to make these moves - something which has also been neglected.
   
For all further repository structure moves - please ensure you have
received the appropriate consent from the above mentioned teams, and
have announced them on the appropriate mailing lists in advance.
   
@Plasma team: plasma-devel@kde.org does not constitute an appropriate
mailing list, as it is not a community wide development mailing list.
Only kde-devel and kde-core-devel qualify for this.
   
Thanks,
Ben Cooksley
KDE Sysadmin
  
   My apologies, I shouldn't have rushed into doing such moves and send
   e-mails to all the interested parties.
  
   If someone considers it appropriate, I can roll some of the changes
   back.
 
  Maybe you should explain the changes so people is aware of them :)
 
  Cheers,
 
Albert
 
   Aleix

 Changes:
 - kde-gtk-config was moved from extragear/base to kde/workspace.
 - muon was moved from extragear/sysadmin to kde/workspace.

 That is, only projects.kde.org structure change.

 That's a total understament, it changes them from being something extra to
 be something totally core. So it's not only at all.

 The reasoning is that this way they will be released together with Plasma
 Workspace.

 I don't see that anyone can have a problem with kde-gtk-config.

 The muon move i see as much less clear, there are other installers provided
 by KDE (kpackagekit comes to mind) and muon is not widely used (AFAIK) outside
 KUbuntu, thus putting all the weight of making it a core thing is something I
 think we should not be doing without a bigger discussion with the community,
 and not just in Plasma.

 As they've been used they don't really make sense outside Plasma
 (especially the first) and we want to make sure that distros know these
 components are designed to work together with Plasma.

 you're saying muon doesn't make sense outside plasma? how come? How does it
 stop working?

I'm pretty sure he's talking about kde-gtk-config here. his list was
kde-gtk-config then muon. kde-gtk-config isn't useful outside of
plasma, muon probably is though I would think...


 I didn't notify kde-core-devel because it didn't occur to me that the
 community would have an opinion regarding whether it's me who releases the
 packages or Jonathan (who has been doing the Plasma packages).

 Again, that's a total understament, i feel very sad you think that
 extragear/base vs kde/workspace is just who releases the packages.

 Can you also please clarify to which release of plasma do you want to add this
 packages? I hope Plasma 5.2 since we're less than two weeks away from 5.1
 release and Beta has been released already, right?

 Cheers,
   Albert


 Cheers!
 Aleix

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 120358: DigitalClock: Add timezone information to digital clock tooltip.

[Jeremy Whiting]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120358/
---

(Updated Sept. 29, 2014, 4:34 p.m.)


Status
--

This change has been marked as submitted.


Review request for Plasma, Kai Uwe Broulik and Martin Klapetek.


Repository: plasma-workspace


Description
---

DigitalClock: Add timezone information to digital clock tooltip.

note: My editor is dumb and removed the umlaut from Sebas' name, I'll fix that 
before committing.


Diffs
-

  applets/digital-clock/package/contents/ui/DigitalClock.qml 
2beae00d090dfe03e94c4223ba36546ffeda45f2 

Diff: https://git.reviewboard.kde.org/r/120358/diff/


Testing
---

I ran it here with two timezones selected (Local and London). The date is local 
date, but it was that way before anyway. The date next to each timezone is the 
date for that timezone if dates are shown.


Thanks,

Jeremy Whiting

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: SDDM KCM In Plasma

[Jeremy Whiting]

David,

Is the plan to release it for every plasma release? if not I'd say
extragear is fine, no ?

BR,
Jeremy

On Mon, Sep 29, 2014 at 6:45 PM, David Edmundson
da...@davidedmundson.co.uk wrote:
  - SDDM KCM's is in github
  - Translations won't work whilst it's in github
  - I asked if I could move it to plasma
  - 3/4 main developers have said yes (one not replied). Seems good enough
 for me.

 It's probably easier (for the other DEs using SDDM) if I keep it a separate
 repo rather than putting into plasma-desktop with the others. Will this be
 OK?

 We're way past feature freeze, plus I probably need to go via review. Should
 I ignore 5.1?

 David



 ___
 Plasma-devel mailing list
 Plasma-devel@kde.org
 https://mail.kde.org/mailman/listinfo/plasma-devel

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request 120411: Set title on wallpaper kns dialog. BUG:336737

[Jeremy Whiting]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120411/
---

Review request for Plasma.


Bugs: 336737
https://bugs.kde.org/show_bug.cgi?id=336737


Repository: plasma-workspace


Description
---

Set title on wallpaper kns dialog. BUG:336737


Diffs
-

  wallpapers/image/image.cpp 373d8242083db70ed6af10e0861a61e6e8522bf1 

Diff: https://git.reviewboard.kde.org/r/120411/diff/


Testing
---

The wallpaper kns dialog shows Download Wallpapers instead of Plasma Add-On 
Installer


Thanks,

Jeremy Whiting

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 120411: Set title on wallpaper kns dialog. BUG:336737

[Jeremy Whiting]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120411/
---

(Updated Sept. 28, 2014, 10:03 p.m.)


Status
--

This change has been marked as submitted.


Review request for Plasma.


Bugs: 336737
https://bugs.kde.org/show_bug.cgi?id=336737


Repository: plasma-workspace


Description
---

Set title on wallpaper kns dialog. BUG:336737


Diffs
-

  wallpapers/image/image.cpp 373d8242083db70ed6af10e0861a61e6e8522bf1 

Diff: https://git.reviewboard.kde.org/r/120411/diff/


Testing
---

The wallpaper kns dialog shows Download Wallpapers instead of Plasma Add-On 
Installer


Thanks,

Jeremy Whiting

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 120358: DigitalClock: Add timezone information to digital clock tooltip.

[Jeremy Whiting]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120358/
---

(Updated Sept. 27, 2014, 1:51 p.m.)


Review request for Plasma, Kai Uwe Broulik and Martin Klapetek.


Changes
---

Added another newline between date and timezone strings.


Repository: plasma-workspace


Description
---

DigitalClock: Add timezone information to digital clock tooltip.

note: My editor is dumb and removed the umlaut from Sebas' name, I'll fix that 
before committing.


Diffs (updated)
-

  applets/digital-clock/package/contents/ui/DigitalClock.qml 
2beae00d090dfe03e94c4223ba36546ffeda45f2 

Diff: https://git.reviewboard.kde.org/r/120358/diff/


Testing
---

I ran it here with two timezones selected (Local and London). The date is local 
date, but it was that way before anyway. The date next to each timezone is the 
date for that timezone if dates are shown.


Thanks,

Jeremy Whiting

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 120358: DigitalClock: Add timezone information to digital clock tooltip.

[Jeremy Whiting]

 On Sept. 27, 2014, 2:05 p.m., Martin Klapetek wrote:
  applets/digital-clock/package/contents/ui/DigitalClock.qml, lines 257-263
  https://git.reviewboard.kde.org/r/120358/diff/3/?file=315594#file315594line257
 
  The result of both of these i18ncs is exactly the same; plus both 
  comments are not true if it's used for the tooltip.
  
  However, changing the comments would violate string freeze. I'd suggest 
  to possibly remove the i18nc altogether here as there are no localizable 
  things (besides the order, but I guess we could live with that for a while).

I'm not sure what you are suggesting here? Remove the i18nc from the new string 
altogether?


- Jeremy


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120358/#review67538
---


On Sept. 27, 2014, 1:51 p.m., Jeremy Whiting wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://git.reviewboard.kde.org/r/120358/
 ---
 
 (Updated Sept. 27, 2014, 1:51 p.m.)
 
 
 Review request for Plasma, Kai Uwe Broulik and Martin Klapetek.
 
 
 Repository: plasma-workspace
 
 
 Description
 ---
 
 DigitalClock: Add timezone information to digital clock tooltip.
 
 note: My editor is dumb and removed the umlaut from Sebas' name, I'll fix 
 that before committing.
 
 
 Diffs
 -
 
   applets/digital-clock/package/contents/ui/DigitalClock.qml 
 2beae00d090dfe03e94c4223ba36546ffeda45f2 
 
 Diff: https://git.reviewboard.kde.org/r/120358/diff/
 
 
 Testing
 ---
 
 I ran it here with two timezones selected (Local and London). The date is 
 local date, but it was that way before anyway. The date next to each timezone 
 is the date for that timezone if dates are shown.
 
 
 Thanks,
 
 Jeremy Whiting
 


___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 120358: DigitalClock: Add timezone information to digital clock tooltip.

[Jeremy Whiting]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120358/
---

(Updated Sept. 27, 2014, 2:38 p.m.)


Review request for Plasma, Kai Uwe Broulik and Martin Klapetek.


Changes
---

Moved tooltip code into a separate method to always call when datasource 
changes. Also call it initially to get the tooltip right at first launch.


Repository: plasma-workspace


Description
---

DigitalClock: Add timezone information to digital clock tooltip.

note: My editor is dumb and removed the umlaut from Sebas' name, I'll fix that 
before committing.


Diffs (updated)
-

  applets/digital-clock/package/contents/ui/DigitalClock.qml 
2beae00d090dfe03e94c4223ba36546ffeda45f2 

Diff: https://git.reviewboard.kde.org/r/120358/diff/


Testing
---

I ran it here with two timezones selected (Local and London). The date is local 
date, but it was that way before anyway. The date next to each timezone is the 
date for that timezone if dates are shown.


Thanks,

Jeremy Whiting

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 120358: DigitalClock: Add timezone information to digital clock tooltip.

[Jeremy Whiting]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120358/
---

(Updated Sept. 27, 2014, 2:53 p.m.)


Review request for Plasma, Kai Uwe Broulik and Martin Klapetek.


Changes
---

Removed unneeded extra i18nc call that was the same as another one. Updated 
context string for translators.


Repository: plasma-workspace


Description
---

DigitalClock: Add timezone information to digital clock tooltip.

note: My editor is dumb and removed the umlaut from Sebas' name, I'll fix that 
before committing.


Diffs (updated)
-

  applets/digital-clock/package/contents/ui/DigitalClock.qml 
2beae00d090dfe03e94c4223ba36546ffeda45f2 

Diff: https://git.reviewboard.kde.org/r/120358/diff/


Testing
---

I ran it here with two timezones selected (Local and London). The date is local 
date, but it was that way before anyway. The date next to each timezone is the 
date for that timezone if dates are shown.


Thanks,

Jeremy Whiting

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 120358: DigitalClock: Add timezone information to digital clock tooltip.

[Jeremy Whiting]

 On Sept. 27, 2014, 2:05 p.m., Martin Klapetek wrote:
  applets/digital-clock/package/contents/ui/DigitalClock.qml, lines 257-263
  https://git.reviewboard.kde.org/r/120358/diff/3/?file=315594#file315594line257
 
  The result of both of these i18ncs is exactly the same; plus both 
  comments are not true if it's used for the tooltip.
  
  However, changing the comments would violate string freeze. I'd suggest 
  to possibly remove the i18nc altogether here as there are no localizable 
  things (besides the order, but I guess we could live with that for a while).
 
 Jeremy Whiting wrote:
 I'm not sure what you are suggesting here? Remove the i18nc from the new 
 string altogether?

String freeze exception requested here: 
http://lists.kde.org/?l=kde-i18n-docm=141185139919104w=2


- Jeremy


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120358/#review67538
---


On Sept. 27, 2014, 2:53 p.m., Jeremy Whiting wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://git.reviewboard.kde.org/r/120358/
 ---
 
 (Updated Sept. 27, 2014, 2:53 p.m.)
 
 
 Review request for Plasma, Kai Uwe Broulik and Martin Klapetek.
 
 
 Repository: plasma-workspace
 
 
 Description
 ---
 
 DigitalClock: Add timezone information to digital clock tooltip.
 
 note: My editor is dumb and removed the umlaut from Sebas' name, I'll fix 
 that before committing.
 
 
 Diffs
 -
 
   applets/digital-clock/package/contents/ui/DigitalClock.qml 
 2beae00d090dfe03e94c4223ba36546ffeda45f2 
 
 Diff: https://git.reviewboard.kde.org/r/120358/diff/
 
 
 Testing
 ---
 
 I ran it here with two timezones selected (Local and London). The date is 
 local date, but it was that way before anyway. The date next to each timezone 
 is the date for that timezone if dates are shown.
 
 
 Thanks,
 
 Jeremy Whiting
 


___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 120358: DigitalClock: Add timezone information to digital clock tooltip.

[Jeremy Whiting]

 On Sept. 25, 2014, 3:33 a.m., Kai Uwe Broulik wrote:
  Can you provide a screenshot of the tooltip?

I'm using the same function to create the time format. but with a different 
argument. I guess I could make two separate functions instead, but why not just 
use the same one, when 90% of the code is the same?
Anyway, I've added a couple screenshots http://imgur.com/biI6prN,lbxJS4k and 
http://imgur.com/biI6prN,lbxJS4k#1 though when I look at it admittedly the 
withDate one looks funny, and should have the timezone first like the other one 
and outside of () also. I'll fix that and post an update to this review.


- Jeremy


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120358/#review67406
---


On Sept. 24, 2014, 8:12 p.m., Jeremy Whiting wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://git.reviewboard.kde.org/r/120358/
 ---
 
 (Updated Sept. 24, 2014, 8:12 p.m.)
 
 
 Review request for Plasma, Kai Uwe Broulik and Martin Klapetek.
 
 
 Repository: plasma-workspace
 
 
 Description
 ---
 
 DigitalClock: Add timezone information to digital clock tooltip.
 
 note: My editor is dumb and removed the umlaut from Sebas' name, I'll fix 
 that before committing.
 
 
 Diffs
 -
 
   applets/digital-clock/package/contents/ui/DigitalClock.qml 
 00c9def8dffe1cdc24d377acab029b47bd57e602 
 
 Diff: https://git.reviewboard.kde.org/r/120358/diff/
 
 
 Testing
 ---
 
 I ran it here with two timezones selected (Local and London). The date is 
 local date, but it was that way before anyway. The date next to each timezone 
 is the date for that timezone if dates are shown.
 
 
 Thanks,
 
 Jeremy Whiting
 


___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel