Re: New maintainers wanted: KDE Telepathy, KAccounts, Plasma Notifications and others

[Martin Klapetek]

On Mon, Mar 4, 2019 at 9:32 AM Alexander Akulich 
wrote:

> Hi Martin and everyone.
>
> I would like to take over the KDE Telepathy maintainership.
>
> I understand that Telepathy is a huge and complex project that needs a
> lot of manpower to actually come back, but there is no other project
> with the same goals and capabilities. For me, Telepathy is not the
> exact specification, but an idea of IM system with replaceable
> components that give you a freedom to combine whatever you want across
> operation systems, desktop environments, and programming languages
> with the best rate of shared code and system integration.
>
> I can spend two hours and write a long list of reasons why Telepathy
> is the right thing to do, but please let me spend this time on the
> development to prove my arguments by deed and not by words.
> On the other hand, I don't want to fail someone's expectations, so
> please continue to not expect much. :)
>
> I think that in the current era of proprietary IM services, such
> integrated and yet distributed solution has a chance to prove itself
> with open protocols such as Matrix, Telegram (MTProto), XMPP, Tox,
> Slack, IRC, SIP (reSIProcate), Gitter, Rocket.Chat, Signal, Discord
> and so on. For sure the list can meet the demands of some users.
>
> I have interest, ideas, experience, and prototypes. Now I have some
> time to start checking out features one by one. I'm already a
> maintainer of TelepathyQt (I released the last three versions), but
> the library and services mean nothing without a client. I have some
> pending reviews for 10 months [1] and if nobody reviews them then
> maybe it will be right to become a maintainer and start to land them.
>
> As a maintainer, I'll also take responsibility for bug fixing (as a
> start I committed three bug fixes at the last three days).
>
> P.S.: If you're going to support Matrix then please, please! develop a
> good library. I don't want to offend anyone, but QMatrixClient needs a
> lot of improvements and maybe you can help. With a good library (such
> as QXmpp) a Telepathy service implementation would consist of about 2k
> lines of code.
>
> [1] https://phabricator.kde.org/D12751


Yes please! You've already proven yourself throughout the years
with all your contributions, so you have my blessing :)

Thanks for stepping up!

Cheers
--
Martin Klapetek

Re: Relicensing of file in plasma-phone-components

[Martin Klapetek]

Hi,

I'm fine with relicensing my contributions
to plasma-phone-components/dialer/src/dialerutils.*
code from GPL2 to either GPL2+ or LGPL.

Cheers
--
Martin Klapetek


On Sun, Nov 18, 2018 at 7:47 AM Bhushan Shah  wrote:

> Hello everyone,
>
> I am writing to you since you have commited to the
> plasma-phone-components/dialer/src/dialerutils.* code.
>
> (Volker in CC list because he raised the current issue, Volker is not
> committer to files.)
>
> Current code is GPL2, which is incompatible with the Apache2 license of
> libphonenumber we want to use.
>
> Do you grant permission to relicense this code to either GPL2+ or LGPL?
>
> Thanks.
>
> --
> Bhushan Shah
> http://blog.bshah.in
> IRC Nick : bshah on Freenode
> GPG key fingerprint : 0AAC 775B B643 7A8D 9AF7 A3AC FE07 8411 7FBC E11D
>

D7633: [Digital Clock] Compact and move to the end font setup

[Martin Klapetek]

mck182 added a comment.


  The horizontal alignment of the label is off compared to the rest of the 
labels, I guess it's because it's not in a groupbox.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D7633

To: broulik, #plasma, #vdg, mart
Cc: mck182, mart, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, lukas

D6059: Add a test that adds a notification and closes it

[Martin Klapetek]

mck182 added a comment.


  That's up to Kai/VDG, I guess. I was just wondering what changed
  from the previous patch where everyone agreed to not do it because
  it would be confusing.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D6059

To: apol, #plasma, broulik
Cc: mart, mck182, plasma-devel, ZrenBot, spstarr, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, lukas

D6059: Close notifications that don't have a default action by clicking

[Martin Klapetek]

mck182 added a comment.


  This was discussed at length in https://phabricator.kde.org/D4215
  
  What's the reasoning behind this change?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D6059

To: apol, #plasma, broulik, #vdg
Cc: mck182, plasma-devel, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart, lukas

D5424: [Notifications] Introduce "settings" action

[Martin Klapetek]

mck182 accepted this revision.
mck182 added a comment.


  Ah, I see. Good to go then, unless you want to wait for VDG input.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D5424

To: broulik, #vdg, #plasma, markg, mck182
Cc: mck182, markg, plasma-devel, spstarr, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol

D5424: [Notifications] Introduce "settings" action

[Martin Klapetek]

mck182 added a comment.


  While I like this, I wonder - for apps that will send "settings"
  action there will now be no way to access the KNotification
  settings, right (from the notification itself)? As in, the app can
  use the "settings" action for an entirely different thing, thus
  blocking the standard config UI, maybe?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D5424

To: broulik, #vdg, #plasma, markg
Cc: mck182, markg, plasma-devel, spstarr, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol

D5346: DigitalClock: Use correct language for month and day names

[Martin Klapetek]

mck182 accepted this revision.
mck182 added a comment.
This revision is now accepted and ready to land.


  Same as the other diff, if safe, good to go.
  
  EDIT: I feel like we could wrap the `Qt.locale(Qt.locale().uiLanguages[0])` 
into something shorter, maybe.
  Possibly also keep it instantiated around.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D5346

To: drosca, #plasma, mck182
Cc: plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol

D5345: Calendar: Use correct language for month and day names

[Martin Klapetek]

mck182 accepted this revision.
mck182 added a comment.
This revision is now accepted and ready to land.


  ...provided the usage of `uiLanguages[0]` is safe like this.

INLINE COMMENTS

> DaysCalendar.qml:315
>  height: daysCalendar.cellHeight
> -text: Qt.locale().dayName(calendarBackend.firstDayOfWeek + 
> index, Locale.ShortFormat)
> +text: 
> Qt.locale(Qt.locale().uiLanguages[0]).dayName(calendarBackend.firstDayOfWeek 
> + index, Locale.ShortFormat)
>  font.pixelSize: Math.max(theme.smallestFont.pixelSize, 
> daysCalendar.cellHeight / 3)

Now I'm not entirely sure but can the `uiLanguages[0]`
possibly return null?

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D5345

To: drosca, #plasma, mck182
Cc: plasma-devel, #frameworks, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol

Re: Default touch screen edge gestures

[Martin Klapetek]

On Sat, Apr 8, 2017 at 1:40 PM, Ivan Čukić <ivan.cu...@kde.org> wrote:

> Hi Martin,
>
> I think this needs more in-depth investigation. We've had a couple of,
> I'd say, knee jerk shortcuts pushed to master without much thought
> about them (Alt+Space for KRunner, Meta+number for tasks).
>

Whoa, Alt+Space was discussed at length during a sprint (in Pineda iirc) and
couple other Plasma meetings and a clear improvement over then-current
Alt+F2 was observed. This was anything but "without much thought".

Cheers
--
Martin Klapetek

D5324: Revert "[calendar] Use ui language for getting the month name"

[Martin Klapetek]

mck182 added a comment.


  I disagree with this because we currently don't have any
  easy and/or sensible way to change date formats and so
  we simply suggest using different locales for the different
  formats. However, if your UI language is all Spanish and
  you want to use the US date formatting, the month name
  labels would suddenly be in English while they should
  remain Spanish (and this is what the code you're removing
  does).
  
  This should probably be fixed in the QML side to use the
  same approach so that all month and day names are using
  the same language, which should follow LANG, not LC_DATE.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D5324

To: drosca, #plasma, mck182
Cc: plasma-devel, #frameworks, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol

[Powerdevil] [Bug 378404] Turn off screen when PM-inhibiting app is not the active app

[Martin Klapetek]

https://bugs.kde.org/show_bug.cgi?id=378404

Martin Klapetek <mklape...@kde.org> changed:

   What|Removed |Added

   Severity|normal  |wishlist

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Powerdevil] [Bug 378404] New: Turn off screen when PM-inhibiting app is not the active app

[Martin Klapetek]

https://bugs.kde.org/show_bug.cgi?id=378404

Bug ID: 378404
   Summary: Turn off screen when PM-inhibiting app is not the
active app
   Product: Powerdevil
   Version: unspecified
  Platform: Other
OS: Linux
Status: UNCONFIRMED
  Severity: normal
  Priority: NOR
 Component: general
  Assignee: plasma-devel@kde.org
  Reporter: mklape...@kde.org
  Target Milestone: ---

A scenario: I'm listening to music from YouTube
playing in Chromium while writing some code on
my battery-only laptop. I leave my laptop for a
little while and when I come back, the backlight
is still full on and the music is still playing.

It made me realize that while I was gone, the screen
could have turned itself off while the music could
keep playing like normal.

In other words, if an application is inhibiting
the power management and thus preventing the laptop
to go to sleep, it could at least let the screen
turn itself off when the inhibiting app isn't the
current active app. If I'm listening to music and
the app is not in the foreground (ie. I am not
watching it on the screen), then it should be ok
to turn the screen off in the predefined timeout
during inactivity but still prevent going to sleep.

This would allow for a nice battery-saving media
playback with Plasma.

TL;DR - if the PM-inhibiting app is not the current
active app on screen (ie. it's in the background
and/or minimized), let the screen be turned off like
normal during inactivity, but still prevent sleep.

-- 
You are receiving this mail because:
You are the assignee for the bug.

Re: Scrap Baloo Thread Feedback

[Martin Klapetek]

On Tue, Mar 28, 2017 at 5:21 AM, Matthieu Gallien <
gallien.matth...@gmail.com> wrote:

> Hello all,
>
> Sorry to exhume this old thread, but
>
> Is there a common agreement on the best path forward for Baloo versus
> the current situation ?
>
> I have an interest in having a global KDE solution where I would help
> (as time allows). Still, I will only work after an agreement has been
> reached.
>

Hey,

thanks for stepping up! I'd say that if nobody gives you
any sort of approval, just go ahead and figure out the
best plan for Baloo and then present it here, saying that
you would like Baloo to move in this direction, detail out
your proposal and if nobody objects, go ahead and do it.
KDE is about doers, after all :) Also, if you're still a student,
you may want to consider doing this as a GSoC.

Cheers
--
Martin Klapetek

Re: Listening to a notification button's "onClick" in the notifications DataEngine

[Martin Klapetek]

Hey,


On Thu, Mar 9, 2017 at 10:56 PM, Chris Holland <zrenf...@gmail.com> wrote:

> It seems the ActionInvoked and NotificationClosed signal isn't exposed
> anywhere.
>
> The signals are defined here:
> https://github.com/KDE/plasma-workspace/blob/master/
> dataengines/notifications/notificationsengine.h#L84
>
> And the signals are called here:
> https://github.com/KDE/plasma-workspace/blob/master/
> dataengines/notifications/notificationaction.cpp#L54
>
> Would it be possible to expose that signal somewhere?
>

Those signals are relied back to you into your
client side code, eg. if you use KNotification,
then you can listen to those signals there.
This obviously only works for notifications that
you yourself have created, you cannot listen
to those signals of all notifications, that's only
for the client and the shell to know.

Cheers
--
Martin Klapetek

Re: Review Request 123300: Make the dataengine alignment timer more precise

[Martin Klapetek]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123300/
---

(Updated Feb. 25, 2017, 11:59 p.m.)


Status
--

This change has been marked as submitted.


Review request for Plasma.


Changes
---

Submitted with commit 2fea7077c84b97028a424d3e1d66f9838ccf9201 by Albert Astals 
Cid on behalf of Martin Klapetek to branch master.


Repository: plasma-framework


Description
---

It can and does happen that in case of two clocks, one with seconds and one 
without, the one without gets 1s behind. That's because the alignment is not 
corrected when the difference is 1s, however in case of the clock this 1s is 
cruicial.


Diffs
-

  src/plasma/private/datacontainer_p.cpp d9d33d7 

Diff: https://git.reviewboard.kde.org/r/123300/diff/


Testing
---

Been running it for a bit of time (heh), so far no 1s delay.


Thanks,

Martin Klapetek

[Differential] [Commented On] D4632: [Notifications] Never manually hide() the NotificationPopup

[Martin Klapetek]

mck182 added a comment.


  > it's quite a mess
  
  No it's not :P It's a delicate complex code with lots of comments. But let me 
know if you need some help with that.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D4632

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma, ivan
Cc: mck182, ivan, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol

[Differential] [Commented On] D4545: Centralize interaction with notifications

[Martin Klapetek]

mck182 added a comment.


  Can we please fix and ship this quickly? https://phabricator.kde.org/D4142 
shouldn't really have been shipped in that state.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D4545

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: apol, #plasma, mart, davidedmundson, albertvaka
Cc: mck182, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol

[Differential] [Commented On] D4416: Send desktopfilename as part of notifyByPopup hints

[Martin Klapetek]

mck182 added a comment.


  In https://phabricator.kde.org/D4416#82951, @hein wrote:
  
  > Gnome-only spec? Why aren't they contributing to fd.o?
  
  
  "Galago is dead, we took over, deal with it."
  
  https://bugzilla.gnome.org/show_bug.cgi?id=745634#c25

REPOSITORY
  R289 KNotifications

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D4416

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: davidedmundson, #plasma, apol
Cc: mck182, hein, plasma-devel, #frameworks, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas

[Differential] [Commented On] D4215: Make notifications execute the "default" action on click.

[Martin Klapetek]

mck182 added a comment.


  Thanks, that's a nice list. I think real examples using actual native apps 
would provide better insight (like calendar, low battery or music player 
notification), but that'd be like a weekend project, so it's ok.
  
  **macOS**: Clicking a notification popup will in most cases bring up the app 
with the details - eg. calendar reminder will bring up calendar with the event 
details opened, f.lux "You're waking up in 8 hours" will bring the settings 
dialog and low battery notification will do nothing on click.
  
  I'm fine with the proposed behavior then, just that clicking the popup with 
no action should **not** do anything. This is however a 180 degrees turn in the 
behavior, so it should be at least noted in the release notes.
  
  Final +2 decision should be up to Kai and/or Thomas though.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D4215

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: albertvaka, #plasma, colomar
Cc: broulik, apol, mck182, plasma-devel, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas

[Differential] [Commented On] D4215: Make notifications execute the "default" action on click.

[Martin Klapetek]

mck182 added a comment.


  Fair enough.
  
  Let's make a step back then. Since you've mentioned "Plasma is the only 
notification system that does close-on-activate instead of executing some 
action", can you actually list what happens elsewhere? How is default action 
implemented in Gnome? What happens when there are regular and a default action? 
Can you give at least 3 actual examples? Ubuntu's Unity? I think it'd be great 
if everyone could get better idea and understanding of how others handle this 
and perhaps then come up with something fitting for Plasma. I'll test how does 
macOS behave.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D4215

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: albertvaka, #plasma, colomar
Cc: broulik, apol, mck182, plasma-devel, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas

[Differential] [Commented On] D4215: Make notifications execute the "default" action on click.

[Martin Klapetek]

mck182 added a comment.


  Well there you go then. Just implement the default action to be always the 
top-most button in our actions list and make clicking the popup always execute 
the first action in the list. That way, if there are buttons, the user will 
know that clicking the popup will trigger the first action. No buttons means 
clicking won't do anything.
  
  This is then clearly marked/distinguished, well defined and always 
predictable behavior, no guess work needed.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D4215

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: albertvaka, #plasma, colomar
Cc: broulik, apol, mck182, plasma-devel, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas

[Differential] [Commented On] D4215: Make notifications execute the "default" action on click.

[Martin Klapetek]

mck182 added a comment.


  > I think Plasma is the only notification system that does close-on-activate 
instead of executing some action
  
  Plasma might also be the only system that uses buttons for actions and I see 
nothing wrong with that; it's what we've had forever and it works well, there's 
no reason to copy others when we have a good differentiating factor imho.
  
  Thinking about it a bit more, not doing anything when you click the 
notification without default action is again a guess game - "will clicking this 
popup do anything? how do I know?". So I'd say either clearly indicate that 
clicking the popup will execute an action (maybe different color or some icon 
somewhere or maybe a whole different popup) or have the click always do 
something, perhaps just open the app when no action is set. This would however 
be quite a behavioural change and will most definitely confuse users that are 
used to close the popup by clicking it. Anyhow, let's make it really clear and 
unambiguous when will what action do what; users don't like UIs they can't 
trust.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D4215

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: albertvaka, #plasma, colomar
Cc: broulik, apol, mck182, plasma-devel, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas

[Differential] [Commented On] D4215: Make notifications execute the "default" action on click.

[Martin Klapetek]

mck182 added a comment.


  > I have never considered unpredictable on Android that when I press the "new 
e-mail" notification I get the e-mail client with the new e-mail.
  
  On Android, you close the notification by swiping to a side. On Plasma, you 
close the notification by clicking it. On Android, you execute action by 
tapping the notification. Now with this, on Plasma, you execute the action by 
also clicking it. In other words, the same mouse gesture is used to either 
close the notification OR execute an action and you have no way of knowing 
which one will happen. See the problem now? You cannot really compare these two 
because Android has clearly defined behavior with unambiguous gestures.
  
  > With the addition of the default action, notifications can do something 
more than "being acknowledged": they can execute some code. But after doing so, 
they also close. The behaviour is consistent: notifications that the users has 
noticed and reacted to go away, as they already accomplished their goal.
  
  That's what I'm against - clicking the popup currently only closes the 
notification. I want to be sure it _only_ closes the notification. I don't want 
to play a guess game every time a popup shows up - "will my click _only_ close 
it or will this now open the mail window (which I don't want)"? Therefore the 
behavior is _not_ consistent. It is closing vs executing action AND closing. 
And the user has no idea when will happen what.
  
  So as Thomas says, the closing-on-click either needs to go away or just make 
the default action a button. We've always had buttons in the notifications for 
actions, this would only be consistent with what the users have learnt in our 
DE and what they expect. I don't see a reason to change that, especially 
because the button is labeled and it's always clear which action is going to 
happen.
  
  Think of Spectacle - you take a screenshot, you see a notification that it 
was saved. You click the notification with default action - what do you think 
it's going to happen? Is the image going to be opened? Is the file going to be 
opened in file browser? Will this show a dialog allowing to share the 
screenshot? This kind of ambiguity makes me think that having a clearly labeled 
button would be a better option. Even a combo - have a highlighted button which 
is always on top of the actions list and when you click the popup, you will 
know it will execute the first/highlighted action. This could work even without 
a default being set, simply highlight the first action button and clicking the 
popup could then always execute the first action. So this patch would just 
ensure that the default action is put on top.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D4215

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: albertvaka, #plasma, colomar
Cc: apol, mck182, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas

[Differential] [Commented On] D4215: Make notifications execute the "default" action on click.

[Martin Klapetek]

mck182 added a comment.


  > If you just want to close then you have the big X, no?
  
  That doesn't change the fact that the behavior of clicking the popup itself 
would change in an unpredictable way. One time it's close and other times it's 
execute and there's no visual way of telling when it will do what. That's the 
actual problem.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D4215

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: albertvaka, #plasma, colomar
Cc: apol, mck182, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas

[Differential] [Commented On] D4215: Make notifications execute the "default" action on click.

[Martin Klapetek]

mck182 added a comment.


  -1, I don't want to keep thinking "am I now going to close the notification 
or execute an action" everytime I'm about to click the notification popup.
  
  I want my workspace to have predictable behavior that doesn't get in my way.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D4215

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: albertvaka, #plasma
Cc: mck182, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

Re: Plasma 5.9 Beta announce

[Martin Klapetek]

On Tue, Jan 10, 2017 at 5:00 PM, Łukasz Sawicki <kde...@gmail.com> wrote:

> Heh correct link
>
> https://youtu.be/RX5HwumKPP8
>
> Cheers
> Łukasz
>

Looks nice! Do you have a link to the background music?

Cheers
--
Martin Klapetek

[Differential] [Commented On] D4050: add a "by KDE" sign in the splash

[Martin Klapetek]

mck182 added a comment.


  If I may add a slightly unrelated comment - the circly parts of the new logo 
seem to throw the spinner a bit off visually, I think it could use some larger 
spacing in between those two.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D4050

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: mart, #plasma
Cc: mck182, subdiff, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, andreaska, sebas

[Powerdevil] [Bug 343962] Add option to disable Backlight OSD

[Martin Klapetek]

https://bugs.kde.org/show_bug.cgi?id=343962

--- Comment #15 from Martin Klapetek <mklape...@kde.org> ---
> I will call that redundant information.

For every one calling that a redundant information there will be someone
calling that a missing information if it was removed. Sometimes redundant is
better than missing.

-- 
You are receiving this mail because:
You are the assignee for the bug.

Re: Review Request 129691: digital-clock: Update iso-3166 codes in timezones

[Martin Klapetek]

> On Dec. 27, 2016, 4:54 p.m., Sebastian Kügler wrote:
> > applets/digital-clock/plugin/timezonesi18n.cpp, line 682
> > 
> >
> > This should stay Cape Verde, the English name is used here, not the 
> > Portuguese (?) one.
> 
> Jiri Bohac wrote:
> Frankly, I don't understand what all the discussion here is about.
> I noticed the list of countries, obviously taken from iso-codes some day 
> in the past, was out of date.
> The comment above the hash table clearly says "Make sure the country 
> names match their versions in iso-codes". 
> So I went and fixed everything to the current version of the ISO 
> standard. 
> 
> Suddenly, people start disputing the changes with reasoning like:
> "This should stay Cape Verde, the English name is used here, not the 
> Portuguese"
> "Czech Republic" is correct as well, since it's the official name"
> "Congo" is IMHO way too ambiguous
> 
> I am no expert on naming countries. There are whole commities doing that 
> at UN and ISO. They decided that
> "Czechia", "Congo" and "Cabo Verde" are the correct short names and 
> updated their databases/standards.
> 
> I would have loved [not] to see such a discussion when populating this 
> hash table from scratch :))
> 
> I find it totally unsystematic to maitain a few records out of sync with 
> iso-codes. Either by using an old version (Cabo Verde) or not using a newly 
> standardized short version. Why would anyone think the snapshot of iso_3116 
> from ~1 year ago was good and suddenly new ammendment to the standard are 
> controversial?
> 
> If someone, who is a better expert on international politics and 
> territory naming than the UN, feels they want to use any subset of my 
> changes, feel free to do that. I totally don't understand any reasoning 
> behind that, though.
> 
> Sebastian Kügler wrote:
> I can't comment on the other changes (In fact, I ACK'ed them, so I 
> explicitely didn't), but when I looked up Cabo Verde, all I could find is the 
> English version, so Cape Verde. If you have a more recent version, I'm all 
> open for it. If you're posting reviews just to have them rubber-stamped by a 
> robot who doesn't actually review and think the changes through, that's not 
> what our code reviews is about.
> 
> I agree that it's a PITA to maintain the list in several places.

> people start disputing the changes with reasoning like:
> "Czech Republic" is correct as well, since it's the official name"

I never disputed anything, I merely stated that personally, as a Czech, I 
prefer "Czech Republic" over "Czechia" and even explicitly said that my comment 
is not to block your change. Please don't take my words out of context.


- Martin


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129691/#review101595
---


On Dec. 20, 2016, 10:57 p.m., Jiri Bohac wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129691/
> ---
> 
> (Updated Dec. 20, 2016, 10:57 p.m.)
> 
> 
> Review request for Plasma and Albert Astals Cid.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> Update the list of country names to the current names in iso-codes
> (as output by isoquery -c).
> 
> The motivation is updating the name of Czechia as a followup to
> https://git.reviewboard.kde.org/r/129644/
> As suggested by Albert Astals Cid, fixing the name in i10n is not enough: 
> country names are hardcoded in many places and they need to be fixed 
> separately.
> 
> 
> Diffs
> -
> 
>   applets/digital-clock/plugin/timezonesi18n.cpp 10650f8 
> 
> Diff: https://git.reviewboard.kde.org/r/129691/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Jiri Bohac
> 
>

Re: Review Request 129691: digital-clock: Update iso-3166 codes in timezones

[Martin Klapetek]

> On Dec. 21, 2016, 12:25 a.m., Aleix Pol Gonzalez wrote:
> > +0
> > 
> > Note the correct patch would possibly be to port it to 
> > http://doc.qt.io/qt-5/qtimezone.html and drop that list...

Btw. this list exists because there is(/was) no way to get localized list of 
all countries from QTimeZone/QLocale.


- Martin


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129691/#review101524
---


On Dec. 20, 2016, 10:57 p.m., Jiri Bohac wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129691/
> ---
> 
> (Updated Dec. 20, 2016, 10:57 p.m.)
> 
> 
> Review request for Plasma and Albert Astals Cid.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> Update the list of country names to the current names in iso-codes
> (as output by isoquery -c).
> 
> The motivation is updating the name of Czechia as a followup to
> https://git.reviewboard.kde.org/r/129644/
> As suggested by Albert Astals Cid, fixing the name in i10n is not enough: 
> country names are hardcoded in many places and they need to be fixed 
> separately.
> 
> 
> Diffs
> -
> 
>   applets/digital-clock/plugin/timezonesi18n.cpp 10650f8 
> 
> Diff: https://git.reviewboard.kde.org/r/129691/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Jiri Bohac
> 
>

Re: DrKonqi and BKO

[Martin Klapetek]

On Wed, Nov 2, 2016 at 6:32 AM, Harald Sitter <sitter.har...@gmail.com>
wrote:

> On Wed, Nov 2, 2016 at 11:04 AM, René J. V.  Bertin <rjvber...@gmail.com>
> wrote:
> > Martin Klapetek wrote:
> >
> >
> >> For improving readability, there is bugzilla-traceparser plugin, that
> can
> >> dynamically
> >> hide long backtraces with a bit of JS magic to expand them and
> much
> >> more
> >> like finding duplicates and also auto-dupe. I still think this would
> help
> >> tremendously to
> >> all our bugzilla users.
> >
> > Yes, long inline backtraces do not make it easier to navigate a bug
> report.
> >
> > Still, the best thing would be a formal way to attach a backtrace, e.g.
> as an
> > attachment with a standardised name. I'm thinking of a dedicated entry
> field on
> > the bug entry webpage and programmatic hooks to upload and query these
> > attachments.
>
> Bug trackers are not trace trackers. Spending time on solving the
> actual problem is the best thing https://retrace.fedoraproject.org/
> https://errors.ubuntu.com/


They're not, yet we're using it as one. So might as well improve
the experience at least a bit.

Cheers
-- 
Martin Klapetek

Re: DrKonqi and BKO

[Martin Klapetek]

On Tue, Nov 1, 2016 at 6:24 AM, David Edmundson <da...@davidedmundson.co.uk>
wrote:

> On Tue, Nov 1, 2016 at 9:28 AM, René J.V. Bertin <rjvber...@gmail.com>
> wrote:
>
>> Hi,
>>
>> Sorry if this has already been answered somewhere where I've missed it:
>>
>> DrKonqi has lost much of its interest (in v5.8.2) due to recent changes
>> in BKO. Most of the crashes I've been trying to report via the tool have
>> led to rejection because of an overzealous spam filter, and now because
>> there's a (new? lowered?) max. limit of 64k characters per comment.
>> Evidently an inline backtrace can be much longer than that.
>>
>> I do agree that it'd be better for readability to put backtraces in an
>> attachment;
>>
>
> As attachments is awful. You cannot search if it's in an attachment.
> Searching is ridiculously important.
>

For improving readability, there is bugzilla-traceparser plugin, that can
dynamically
hide long backtraces with a bit of JS magic to expand them and much
more
like finding duplicates and also auto-dupe. I still think this would help
tremendously to
all our bugzilla users.

See https://bugs.kde.org/show_bug.cgi?id=354217

Cheers
-- 
Martin Klapetek

Re: Breakout: UI and user vision for cloud services

[Martin Klapetek]

On Wed, Oct 19, 2016 at 4:54 AM, Elvis Angelaccio <elvis.angelac...@kde.org>
wrote:

>
> Hi Martin,
> I'm planning to integrate KAccounts with kio-gdrive, so your email is
> very much appreciated.
> What exactly is "Kaccounts" in the first place? Are we talking about
> the kaccounts-integration repo?
>

KAccounts is basically just the KDE UI for the Accounts-SSO system.
It's a collection of KCM, which allows you to manage those accounts
and also KDED daemon which allows to load custom plugins that
react on those account changes and/or service changes (each account
has a set of services).

So for example, in the KCM you add a Google account and then the
KDED module is notified of this and it will pass this info to all its loaded
plugins. The plugins would then check if the account is of interest and if
yes, then do something, like set up the calendar integration, for example.

The KDED module also watches for services change, so eg. if in the
KCM you disable the calendar service, the Google plugin would disable
the calendar (but not remove). At least that's the idea.

In the case of the kio-gdrive, I'm not sure if you'd need such plugin at
all.
I mean, if you don't need to configure anything, then you won't. You can
just query the credentials data from KAccounts directly from the kio.


> A tutorial would be great, but maybe is enough to look at the KDE
> Telepathy usage. Could you share more details about this?
>

KDE Telepathy is a bit special case. It builds a lot on the existing
upstream
code, which is basically a Mission Control plugin that does exactly what the
KDED is doing. Ie. there is no KTp KDED plugin, this is all handled by
Telepathy
itself.

I'd recommend looking at the kaccounts-mobile repo, which has some code
for ownCloud stuff, like importing CardDAV contacts iirc.

Cheers
-- 
Martin Klapetek

Re: Breakout: UI and user vision for cloud services

[Martin Klapetek]

On Mon, Oct 17, 2016 at 12:54 PM, Jonathan Riddell <j...@jriddell.org> wrote:

>  * Services integration - I see more and more users who have
> data locked up in clouds (GDrive, etc.) and rely on accessing it
>  Gnome has GDrive integration, we need to do more on getting
> cloud filesystems into our software too, but we dropped the ball on
> KAccounts etc. for now
>

As the former KAccounts maintainer, I'd like to share some insights on this.

The tech is there. It's proven by real world usage in Ubuntu (incl. Phone),
Meego before that (iirc) and to some extent also Gnome, which has its own
fork of the same thing (I guess they just really don't like Qt anywhere).
Also
Elementary is using one of these, but I don't remember which. And if I'm
not mistaken, also Jolla in their phones.

So we have the tech, but what we're missing are two things, really.

1) Things actually using it. We've had KAccounts for a while but there was
nothing taking advantage of it, except KDE Telepathy, which migrated fully
to it. So it sort of became a synonym for KTp accounts config. On the other
hand, there was nothing much else that would actually need it. There was
an OwnCloud lib or Plasma thingy at some point where I pleaded to have the
account setup done through (K)Accounts to boost the adoption, but it never
happened. Related to that is...

2) Buy in from PIM. I mean, let's face it, the real accounts user in the
system
is PIM, with all the emails and calendars and contacts and what not. This
obviously requires quite some large effort to actually migrate everything to
it and sadly the PIM team is long time understaffed. Now with the new Sink
thing, this could have been a chance, but, again, after asking couple times
about the accounts plan, (K)Accounts was never in the picture. And that's
a problem.

And so now we have this system that nobody in/around KDE wants to use.
My take on it is that people (devs) don't really understand how that system
works and how to take advantage of it, which is partly my fault. It is
fairly
complex system on the inside with lots of points of possible breakages, but
also allows for great flexibility all around.

So, imho, in order to successfully follow literally every other desktop
these
days, it needs a proper full integration in all things using accounts. And
it really
shouldn't be just an afterthought. It needs to be put right at the core of
those
things and workflows should be redesigned to take that into account (heh).
It
needs to be a conscious community-wide effort, like Frameworks was.
Otherwise
KAccounts will stay exactly where it is now - a promising (egg-)shell that
has no
real use.

Unfortunately if the past two years are any indication, especially with
Sink,
the road ahead is not very bright.

I'm happy to try my best to answer any possible future questions about the
system
you might have. Friedrich Kossebau was also writing a tutorial about it at
some
point, but I'm not sure where it ended up (if at all; I also failed to
follow up on that).

Cheers
-- 
Martin Klapetek

Re: Breakout: * multiscreen behaviour: how should Plasma exactly behave in different scenarios?

[Martin Klapetek]

On Mon, Oct 17, 2016 at 12:59 PM, Jonathan Riddell <j...@jriddell.org> wrote:

>  biggest pain point from bugzilla is mostly still
> multiscreen. I'm not sure we have a solid plan of what /should/ happen
> in each situation.
>  panel gets added to screen 1 and 2, you disconnect screen
> 2. How many panels do you have on screen 1
>

(speaking from being in a work environment where I regularly switch
between various screens/tvs and screen setups multiple times a day)

Ideally containments are tied to screens as a whole and no "merge"
of panels is happening. So in the case above, one panel. (I don't
remember if panels are part of the containments, but I'll assume it is)

Thinking about it a bit more, I think the concept of primary screen
is important here. When I have only my laptop, its screen is obviously
the primary one. Now if I plug in a screen(s) and I set any other screen
as primary, I'd expect the containment from my laptop to go to that
primary screen, creating new one/restoring old one for the laptop screen.

Now at this point this is the setup (where * is primary):
[laptop] [*screen1]

If I add another panel to [laptop] (both screens now have bottom panel),
I would want that panel (and containment) to appear again only in this same
setup.
Ie. unplugging [screen1] makes [laptop] primary again and thus moving
the containment from [screen1] back to [laptop], unloading the other
containment completely.

Ie: [laptop] [*screen1] --unplug screen--> [*laptop]

That primary setting should also be remembered by a screen I think,
because if I'm plugging to a projector or big room TV, I don't think I want
all my laptop screen suddenly jumping to the other screen for everyone
to see. In other words, I never set that TV or projector as primary and
therefore plasma shouldn't automatically assume "any external screen
equals move primary screen".

Ie: [*laptop] --plug TV--> [*laptop] [TV]

If I explicitly set the TV as primary, then it should again be remembered.

Ie: [*laptop] --plug TV--> [laptop] [*TV]

The reasoning for this^ is that, presumably, for privacy and/or comfort
I'd be moving the primary screen from the TV back to my laptop.
But then when I come back to my desk and plug in my screen,
I'd need to again set the primary screen to the external screen, which
is just annoying.

So...my CA$ 0.02 :)

Cheers
-- 
Martin Klapetek

Re: Review Request 125743: Keep aspect ratio in default KSplash background

[Martin Klapetek]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125743/
---

(Updated Sept. 15, 2016, 11:33 a.m.)


Status
--

This change has been discarded.


Review request for Plasma.


Repository: plasma-workspace


Description
---

I'm just not sure if it's better to do Fit or Crop. I went with Fit as that 
simply fits the whole artwork, but let me know if you think differently.

Ideally this should use a wallpaper package for the background, but I don't 
know how to use it from QML (if possible at all).

Issues with Fit:
* If the image is different aspect ratio than the screen, it would add black 
borders either above/below or left/right

Issues with Crop:
* if the image has bigger resolution than the screen, it will get cropped to be 
the screen resolution, so eg. the distro ships 1920x1200 wallpaper and on 
1024x768 the crop would be quite big (the image would still be centered so 
cropped on the sides)


Diffs
-

  lookandfeel/contents/splash/Splash.qml fdeb1ea 

Diff: https://git.reviewboard.kde.org/r/125743/diff/


Testing
---


Thanks,

Martin Klapetek

[Powerdevil] [Bug 366608] Brightness keyboard action does not repeat while key is pressed under Wayland

[Martin Klapetek via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=366608

Martin Klapetek <mklape...@kde.org> changed:

   What|Removed |Added

 CC||mklape...@kde.org

--- Comment #7 from Martin Klapetek <mklape...@kde.org> ---
I think better use-case is volume controls - if you play a music
and your volume is too high and you don't realize, the panicky
solution is always hit the volume down key. Now pressing that
down and holding it down should imho continuously lower the
volume rather than having the finger pressed down, realizing
this doesn't do much and you need to press it repeatedly. That
is, imho, subpar.

Also all other DEs work with single press-down, we probably
shouldn't be the weird kid.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Plasma Workspace Wallpapers] [Bug 366470] Add unsplash wallpapers to KDE

[Martin Klapetek via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=366470

Martin Klapetek <mklape...@kde.org> changed:

   What|Removed |Added

 CC||mklape...@kde.org

--- Comment #2 from Martin Klapetek <mklape...@kde.org> ---
I believe the purpose of this report was to write a Wallpaper plugin that would
fetch those images through the linked API, slideshow style even.

-- 
You are receiving this mail because:
You are the assignee for the bug.

Re: task manager lines instead of blocks

[Martin Klapetek]

On Sat, Jul 30, 2016 at 4:20 AM, kainz.a <kain...@gmail.com> wrote:

> Hi,
>
> in plasma 5.4 we had the lines for the task manager. Uri changed it in
> blocks. Since the last year with blocks I think lines would fit better the
> breeze theme.
>
> http://linux.sothorn.org/wp-content/uploads/2015/08/plasma1.png
>
> Can I change the tasks.svgz file to use lines instead of blocks. I would
> suggest to have the lines outside instead of inside. In addition I would
> remove the colored icons for kick(er) and the system ones.
>
> thanks for your comment.
>

I prefer blocks.

Also, we started with lines, people got used to lines,
we changed it to blocks. Now people got used to blocks
and we want to change it back to lines. I don't feel like
the theme should be constantly changing back and forth.

Cheers
-- 
Martin Klapetek
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: multiscreen logging

[Martin Klapetek]

On Wed, Jul 27, 2016 at 7:35 AM, Sebastian Kügler <se...@kde.org> wrote:

> On dinsdag 26 juli 2016 19:44:11 CEST Martin Klapetek wrote:
> > On Tue, Jul 26, 2016 at 8:03 AM, Sebastian Kügler <se...@kde.org> wrote:
> >
> > What do you think? If you like the idea, I'll polish up my branch and
> will
> > post it for review, so we can discuss the actual implementation.
> >
> > I think a possible better way could be to log each component into each
> own
> > file (in the same dir) with timestamps and function stamps and process
> > stamps and everything and then merge those files using some automation
> and
> > sort by timestamp. Unless Qt on Linux actually handles concurrent write
> > access just fine and in the correct order (I know it didn't on Windows
> last
> > time I looked).
>
> Potentially, yes. Is it a problem? No.
>
> The log file isn't critical, and *usually* components are able to write in
> order (appending to a file doesn't take long). If the log ends up being
> slightly corrupted, that's bad luck. Instead of implementing complex
> merging
> tools


for i in "file1" "file2" "file3"; do cat $i >> output.file; done; cat
output.file | sort > final.log

...not that complex :) Just the sort needs proper params depending on the
timestamp.


> or file-locking mechanism, having just these processes write to the same
> file and cross fingers works well enough. It's a debugging tool, file
> integrity is just not that important.
>

Dunno, doesn't seem all that useful to have a debugging tool that may
or may not work, especially if it is ever going to be used by users to post
in bugreports. What use would be corrupted logs to us? Might as well do
it properly, especially when the added complexity can be just oneliner
bash script.

Cheers
-- 
Martin Klapetek
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: multiscreen logging

[Martin Klapetek]

On Tue, Jul 26, 2016 at 8:03 AM, Sebastian Kügler <se...@kde.org> wrote:

> Hey,
>
> [Please keep both lists addressed.]
>
> Debugging multiscreen issues is a nightmare:
>
> - there are at least 4 different processes involved (kded, kcmshell /
>   systemsettings, kscreen_backend_launcher and plasmashell)
> - some are critical during log in
> - they IPC with each other
> - especially the backend launcher's debug is really hard to get at
>
> This means that:
> - it's hard (almost impossible) for users to get us good and useful logs
> - it's hard for ourselves to debug and find out what's exactly going on,
> especially when multiple components need to play in tune
>
> Yesternight, after debugging the so-many-th issue, it occurred to me that
> we
> need to make this way easier to debug. Q(C)Debug falls short in that we get
> logs of individual components, if we're lucky. If we're really lucky, we
> get
> timestamps, so we can get a rough idea of what is going down when.
>
> All of these problems can be solved with a relatively simple, shared log
> file.
>
> So I'd like to switch most of (lib)kscreen's debug output to logging to a
> file. The files has then logs from multiple processes and will be much
> easier
> to go through.
>

Wouldn't this create a possible concurrency issues when multiple processes
write to the same file?


> What do you think? If you like the idea, I'll polish up my branch and will
> post it for review, so we can discuss the actual implementation.
>

I think a possible better way could be to log each component into each own
file (in the same dir) with timestamps and function stamps and process
stamps
and everything and then merge those files using some automation and sort by
timestamp. Unless Qt on Linux actually handles concurrent write access just
fine
and in the correct order (I know it didn't on Windows last time I looked).

Cheers
-- 
Martin Klapetek
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Commented On] D2212: Reduce Calendar size in Digital clock

[mck182 (Martin Klapetek)]

mck182 added a comment.


  In https://phabricator.kde.org/D2212#41055, @drosca wrote:
  
  > The calendar popup size is fine for me (with patched plasma-framework), 
what I *still* think is broken is the gridSize scaling - see 
https://git.reviewboard.kde.org/r/125773/
  >
  > You can also test it simply by switching font to DejaVu Sans.
  
  
  Olivier, have you tried David's suggestion^? Does it make any difference? I 
also think the patch mentioned above should be in.

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D2212

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: ochurlaud, #plasma:_design, #plasma, davidedmundson
Cc: mart, broulik, drosca, andreaska, mck182, plasma-devel, jensreuterberg, 
abetts, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Commented On] D2212: Reduce Calendar size in Digital clock

[mck182 (Martin Klapetek)]

mck182 added a comment.


  Can you post a screenshot of before/after?
  
  For future reference - any review request that touches the UI should always 
be accompanied by a screenshot ;)

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D2212

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: ochurlaud, #plasma:_design, #plasma, davidedmundson
Cc: mck182, plasma-devel, jensreuterberg, abetts, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Minutes Monday Plasma Meeting

[Martin Klapetek]

On Mon, Jul 18, 2016 at 7:03 AM, Sebastian Kügler <se...@kde.org> wrote:

>
> kbroulik:
> * wrote a few ideas for plasma notifications
> https://community.kde.org/Plasma/Notifications


Yes!! Just a note however - the standard you're talking about
is not the actual standard, it's Gnome's own extension of the
standard, which they now consider _the_ standard.

That said, there's nothing wrong with supporting that extended
spec, it's just that Gnome can decide any day to change anything
and we won't know or have any say in it. Finally, those features
would also need to be added in KNotification.

Cheers
-- 
Martin Klapetek
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Which applications does the Plasma team recommend to use with Plasma?

[Martin Klapetek]

On Mon, Jul 11, 2016 at 4:31 PM, Thomas Pfeiffer <thomas.pfeif...@kde.org>
wrote:

> So this is the input I've taken from this thread so far:
>
> File manager: Dolphin
> Music player: VLC (I've taken form the thread that people feel Cantata's
> benefits over VLC do not outweigh its downsides)
>

I feel that VLC fits into Plasma just as Clementine does.
Given that, Clementine is an actual music player, with
collections manager and music specific plugins and nice
systray icon and works with our mpris2 controller and
fetches lyrics and artist info and offers internet streaming
by default and Spotify integration and is a music player,
above all.

VLC is primarily a video player, using it for playing music
works, but it's not its primary use case, making it lesser
app when compared to Clementine (or Cantata, even).

Cheers
-- 
Martin Klapetek
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

New maintainers wanted: KDE Telepathy, KAccounts, Plasma Notifications and others

[Martin Klapetek]

Hi,

as I got a new job unrelated to KDE couple months ago, I'm finding myself
having less and less time and motivation to keep up with my maintainer's
duties. Therefore I think it's time to pass on some of the KDE things that
have my name in the "maintainer" field.

First off, there's the whole notifications stack, which includes
KNotifications framework, the fdo notifications server and finally Plasma's
popup notifications. The whole stack is relatively simple and does not
require much attention, but it could use some forward pushing to not be
stuck in 2009 anymore.

Staying in the Plasma land, I'd really like to hand the whole clock +
calendar stack to a dedicated maintainer. This is the bottom-right part of
the default Plasma panel - the clock applet, the calendar applet, the
backend for these applets, calendar events, proper timezones support and
all the pieces around. These things can get quite complex to grasp and
improve, yet are a crucial part of the desktop experience and deserve much
more attention than they get now.

KAccounts, the system to set up your online accounts, could use some much
needed improvements and expansions as well as integrating with the new
Akonadi/Sink/Kube-thing. If the last part will not happen, and it certainly
doesn't look like it will, I'm afraid that KAccounts in Plasma would no
longer serve its purpose and would become a burden rather than a useful
system component.

The last one and the biggest one - the 12 repos of KDE Telepathy. Now this
project is effectively dead. It hasn't seen any real development for more
than a year and basically is just on life support ever since the core team
had to leave the project because of job and life constraints. The other
factor is also the wide spread of mobile phones and mobile IM clients;
chatting on the desktop in not entirely modern interfaces with limited
protocol support is not as popular these days. But it would still be nice
to have someone at least oversee the couple of incoming patches every now
and then.

I think that at least the first two stacks are totally vital for Plasma
desktop and really need some attention. If you'd like to put your name on
any of the things above, please let me know. I'll make sure to do a proper
hand-off with explaining everything :)

Cheers
-- 
Martin Klapetek
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Powerdevil] [Bug 364275] sleep and hibernate gone after update

[Martin Klapetek via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=364275

Martin Klapetek <mklape...@kde.org> changed:

   What|Removed |Added

 CC||mklape...@kde.org
Summary|sleep and hybernate gone|sleep and hibernate gone
   |after update|after update

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: plasma-desktop on other environments (bis)

[Martin Klapetek]

On Sat, May 28, 2016 at 2:22 PM, René J. V. <rjvber...@gmail.com> wrote:

> Quick related question: has knotify4 been replaced by a KF5 equivalent, or
> rather made obsolete?
>

It's gone completely, everything happens in KNotification
at runtime.

Cheers
-- 
Martin Klapetek | KDE Developer
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: plasma-desktop on other environments (bis)

[Martin Klapetek]

On Sat, May 28, 2016 at 11:14 AM, René J. V. <rjvber...@gmail.com> wrote:

>
> > Please don't make our apps aliens in other environments.
>
> Please don't tell users of other environments what they're allowed to do
> with
> their apps either.
>

That's not what I'm telling anyone at all.

I'm saying that if error dialog on OS X makes an "alert" sound,
our error dialogs should make the same "alert" sound in OS X
*by default*. If it does no sound, our dialogs should make no
sounds *by default*. Simple as that.

Providing the users a way to configure whatever last century
sounds they want to use is perfectly fine and should be done.

But if you're going to split events out from plasma_workspace.notifyrc,
split them to per-platform files and modify those dialog events
to use the sound the platform uses *by default*.

Cheers
-- 
Martin Klapetek | KDE Developer
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: plasma-desktop on other environments (bis)

[Martin Klapetek]

On Sat, May 28, 2016 at 10:27 AM, David Edmundson <
da...@davidedmundson.co.uk> wrote:

> On Sat, May 28, 2016 at 3:11 PM, Martin Klapetek <
> martin.klape...@gmail.com> wrote:
>
>> On Sat, May 28, 2016 at 9:10 AM, Kai Uwe Broulik <k...@privat.broulik.de>
>> wrote:
>>
>>>
>>> > Even more so than with look and feel that will be beneficial for
>>> cross-platform users. After all alert sound specificity is supposed to aid
>>> in determining what's going on and how to react.
>>>
>>> If I hear the generic Windows drum sound I know that an error happened.
>>> If I hear the Oxgen sound on Windows I might not do that.
>>>
>>> While I am one of those negligible "I use Kate and Dolphin on Windows
>>> because Notepad and Explorer suck" users, I still want native integration
>>> and not a "familiar KDE interface". I bet the average one-platform user
>>> group we imho should be targeting does the same.
>>>
>>
>> This^. Very much this.
>>
>> Please don't make our apps aliens in other environments.
>>
>
> Renè isn't doing the individual standalone OS X packages, which should
> have the tight host integration. Other people are doing that.
>
> He's doing macports which is *very* different. Macports even has X11 and
> Fluxbox.
> If you're running kate on X with a fluxbox WM, having native OS X
> integration just because of your kernel doesn't make too much sense.
>

However, the discussion started with "an initial approach at evaluating
what builds and what makes sense on a ~Plasma desktop, X11 or OS X
(or MS Windows, presumably)."

In that context, it doesn't make sense to use KDE's notification sounds for
apps running on OS X or MS Windows, presumably, if they can be replaced
with native counterparts *by default*. By all means give the user tools to
break
his system, but defaults should be sensible in a way that the application
does
not look and behave like an alien app.

On a side note, KNotification doesn't really have much other use on ~X11
than playing sounds.

Cheers
-- 
Martin Klapetek | KDE Developer
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: plasma-desktop on other environments (bis)

[Martin Klapetek]

On Sat, May 28, 2016 at 9:10 AM, Kai Uwe Broulik <k...@privat.broulik.de>
wrote:

>
> > Even more so than with look and feel that will be beneficial for
> cross-platform users. After all alert sound specificity is supposed to aid
> in determining what's going on and how to react.
>
> If I hear the generic Windows drum sound I know that an error happened. If
> I hear the Oxgen sound on Windows I might not do that.
>
> While I am one of those negligible "I use Kate and Dolphin on Windows
> because Notepad and Explorer suck" users, I still want native integration
> and not a "familiar KDE interface". I bet the average one-platform user
> group we imho should be targeting does the same.
>

This^. Very much this.

Please don't make our apps aliens in other environments.

Cheers
-- 
Martin Klapetek | KDE Developer
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Breeze] [Bug 363602] Symlinked SVG files fails to load under Windows

[Martin Klapetek via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=363602

Martin Klapetek <mklape...@kde.org> changed:

   What|Removed |Added

Summary|Aliased SVG files fails to  |Symlinked SVG files fails
   |load under Windows  |to load under Windows
 CC||mklape...@kde.org

--- Comment #1 from Martin Klapetek <mklape...@kde.org> ---
(changing the title cause "aliased" in graphics means something very very
different :)

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: plasma-desktop on other environments (bis)

[Martin Klapetek]

On Fri, May 27, 2016 at 4:54 PM, David Edmundson <da...@davidedmundson.co.uk
> wrote:

>
> >And then there is the "Plasma Workspace" source, which also contains
> events that IMHO are not specific to Plasma at all but simply correspond to
> notifications posted through certain KF5 frameworks. In  fact, the only
> notifications that appear Plasma-specific (out of 20) are:
>
> 0 of them respond to notifications posted directly through certain KF5
> frameworks.
>
> The message box events are handled by Plasma QPT.
>

That's not entirely correct - KMessageBox sounds (through KNotification)
are handled by frameworkintegration still and some events are in fact
used by other frameworks directly, that's namely Trash, Textcompletion*
and beep (indirectly through KNotification::beep()).

That said, I believe that on OS X it should use OS X sounds instead of
these outdated sounds we still use. In other words, ship custom .notifyrc
for message box events on OS X. It really really really really *really*
shouldn't
use the Oxygen sounds by default.

Cheers
-- 
Martin Klapetek | KDE Developer
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Kirigami popup

[Martin Klapetek]

On Thu, May 12, 2016 at 7:34 AM, Marco Martin <notm...@gmail.com> wrote:

> On Wednesday 11 May 2016 22:36:37 Martin Klapetek wrote:
> > >
> > > I would say OverlaySheet
> >
> > Is ScrollabePage a requirement for that? I can see that the Gallery
> > uses it but if I switch it to Page, the OverlaySheet just breaks.
>
> in the current master it should be usable everywhere as any other item
> just have to pay attention that is something anchored to a root item enough
> that it takes the full visible area, so shouldn't be inside row/column
> layouts
>

Perhaps it's something in the Page then, this is how the
ButtonGallery looks like when changed from ScrollablePage
to simple Page and opening the OverlayDrawer

http://paste.opensuse.org/a0c63072

Cheers
-- 
Martin Klapetek | KDE Developer
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Proposal: kde-libs.org, a repository of contributed libraries

[Martin Klapetek]

On Sat, May 14, 2016 at 9:14 AM, kdea <k@mail.com> wrote:

> I have uploaded the component to the "Qt Components" section of
> http://qt-apps.org , as you propose. It is available here:
>
> http://qt-apps.org/content/show.php?content=176013
>
> I think it is better than nothing. But I would prefer a dedicated web, a
> repository of contributed libraries, classified by cathegories:
>
> Qt 5 C++ libs
> Qt 5 QML libs
> Qt 5 C++/QML libs
> Plasma 5 C++ libs
> Plasma 5 QML libs
> etc.
>
> instead of having everything in one or two cathegories and mixed with app
> cathegories.
>

Then make it happen :)

The reality of the matter is that in KDE we wouldn't have
no use for such server as we put all we need into our own
libraries. Plus we all have our hands in more than a handful
of projects.

If you think such server would be a good thing, then go ahead
and create it. Things don't just magically happen, they need
people behind it. And if your idea will appeal to wider audience,
you will attract more people.

That's how great things in open source world get created.

Cheers
-- 
Martin Klapetek | KDE Developer
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Kirigami popup

[Martin Klapetek]

On Tue, May 10, 2016 at 10:43 AM, Marco Martin <notm...@gmail.com> wrote:

> On Tuesday 10 May 2016 10:23:28 Martin Klapetek wrote:
> > Hey,
> >
> > so in SpaceBar, there's a button that opens a 1/3-screen-height
> > popup with emojis for the user to select. How should that be
> > styled? I found no Kirigami component for this kind of thing,
> > any suggestions?
> >
> > Currently it's just a white Rectangle but does not really fit.
> >
> > Ultimately the best thing would be to have the keyboard window
> > replaced by the popup and/or implement it as a maliit input plugin.
> > Would one of these things be possible?
> >
> > Cheers
>
> I would say OverlaySheet
>

Is ScrollabePage a requirement for that? I can see that the Gallery
uses it but if I switch it to Page, the OverlaySheet just breaks.

Cheers
-- 
Martin Klapetek | KDE Developer
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Kirigami popup

[Martin Klapetek]

Hey,

so in SpaceBar, there's a button that opens a 1/3-screen-height
popup with emojis for the user to select. How should that be
styled? I found no Kirigami component for this kind of thing,
any suggestions?

Currently it's just a white Rectangle but does not really fit.

Ultimately the best thing would be to have the keyboard window
replaced by the popup and/or implement it as a maliit input plugin.
Would one of these things be possible?

Cheers
-- 
Martin Klapetek | KDE Developer
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 127818: [calendar] Add "No events for today" in the agenda when no events are available

[Martin Klapetek]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127818/
---

(Updated May 8, 2016, 4:15 a.m.)


Status
--

This change has been marked as submitted.


Review request for Plasma.


Changes
---

Submitted with commit 95e7f32597a77e3e0928f9f5645f53e921ad5ebd by Martin 
Klapetek to branch master.


Repository: plasma-workspace


Description
---

Fills the big block of empty space with some nice string.

"No events for today" when today is selected and "No events for this day"
when other day is selected.


Diffs
-

  applets/digital-clock/package/contents/ui/CalendarView.qml fcafe5a 

Diff: https://git.reviewboard.kde.org/r/127818/diff/


Testing
---

See screenshot


File Attachments


Screenshot
  
https://git.reviewboard.kde.org/media/uploaded/files/2016/05/03/ea42a866-f390-489a-bac4-f20e2ae8ee56__snapshot114.png


Thanks,

Martin Klapetek

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request 127818: [calendar] Add "No events for today" in the agenda when no events are available

[Martin Klapetek]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127818/
---

Review request for Plasma.


Repository: plasma-workspace


Description
---

Fills the big block of empty space with some nice string.

"No events for today" when today is selected and "No events for this day"
when other day is selected.


Diffs
-

  applets/digital-clock/package/contents/ui/CalendarView.qml fcafe5a 

Diff: https://git.reviewboard.kde.org/r/127818/diff/


Testing
---

See screenshot


File Attachments


Screenshot
  
https://git.reviewboard.kde.org/media/uploaded/files/2016/05/03/ea42a866-f390-489a-bac4-f20e2ae8ee56__snapshot114.png


Thanks,

Martin Klapetek

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Proposal: kde-libs.org, a repository of contributed libraries

[Martin Klapetek]

On Sun, May 1, 2016 at 7:51 AM, kdea <k@mail.com> wrote:

> Excuse me, I sent the message in html format. Sending now in text format...
>
> Hi, yesterday I published a new version of my "Take a break" plasmoid (
> http://kde-apps.org/content/show.php/Take+a+break?content=174127 ). It
> now includes a little-but-useful library, "TextSize.qml", that contains a
> description and an example of use.
>

What does it actually do? There is a similar thing in QML
called TextMetrics and FontMetrics btw, maybe they could
be of use to you.


> Is there any repository of contributed libraries, where I can upload the
> library to, and where other developers can easily browse/find libraries to
> (re)use in their plasmoids?
>

You could in theory put it in Plasma extra/components, more
on that below.


> If not, I would like to propose to create such repository. For example, it
> could be similar to "http://kde-apps.org/; page, but only for libraries
> (let's say "http://kde-libs.org/;). The users of the page would be
> developers, and the "things" uploaded/downloaded/browsed/searched would be
> libraries, instead of programs.
>
> In this way, before developing a new plasmoid, the developer would search
> for reusable libraries, contributed by other developers. I think it would
> promote the creation of modular plasmoids, with more reusable parts, and
> the sharing of solutions to common problems.
>
> What do you think?
>

For developing a Plasmoid, you should ideally use what Plasma
offers, ie. the components that are parts of it. So when you're
developing a Plasmoid, you should search its components found
in our apidocs [1]. If you think your addition would be a good addition
for other Plasma developers, it is of course welcome to join the
Plasma framework. Just note that Plasma tries to not become
a collection of everything, so maybe there won't be a place for
your little stuff.

Alternatively, QtQuick should have most of other generic things
you might need.

In any case, we could really use a quick overview of what your
TextSize.qml does and why do you think it's useful for other
Plasmoid developers, then we'll advise you on next steps :)

[1]
http://api.kde.org/frameworks-api/frameworks5-apidocs/plasma-framework/html/

Cheers
-- 
Martin Klapetek | KDE Developer
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 125862: Add simple calendar events plugin based on KHolidays

[Martin Klapetek]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125862/
---

(Updated May 3, 2016, 12:20 a.m.)


Status
--

This change has been marked as submitted.


Review request for Plasma.


Changes
---

Submitted with commit eb7544704751dc1a9c2997da56d386811b00454f by Martin 
Klapetek to branch master.


Repository: plasma-workspace


Description
---

This is very simple for now as there is no configuration
yet, so it just takes the default region (your locale)
and shows holidays from that.

Obviously this needs a config to set up which regions
you want to show in there, but this is a start.


Diffs
-

  CMakeLists.txt 4783a78 
  plasmacalendarintegration/CMakeLists.txt PRE-CREATION 
  plasmacalendarintegration/HolidaysConfig.qml PRE-CREATION 
  plasmacalendarintegration/holidayeventsplugin.json PRE-CREATION 
  plasmacalendarintegration/holidaysevents.h PRE-CREATION 
  plasmacalendarintegration/holidaysevents.cpp PRE-CREATION 
  plasmacalendarintegration/qmlhelper/CMakeLists.txt PRE-CREATION 
  plasmacalendarintegration/qmlhelper/holidayeventshelperplugin.h PRE-CREATION 
  plasmacalendarintegration/qmlhelper/holidayeventshelperplugin.cpp 
PRE-CREATION 
  plasmacalendarintegration/qmlhelper/qmldir PRE-CREATION 

Diff: https://git.reviewboard.kde.org/r/125862/diff/


Testing
---

Holidays are properly listed in calendar applet.


Thanks,

Martin Klapetek

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 127734: Revert the revert of the revert that removed the agenda from calendar

[Martin Klapetek]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127734/
---

(Updated May 3, 2016, 12:20 a.m.)


Status
--

This change has been marked as submitted.


Review request for Plasma.


Changes
---

Submitted with commit e8c5a28df28d2d66e8eaee47550425941e3e7ade by Martin 
Klapetek to branch master.


Repository: plasma-workspace


Description
---

Brings back the agenda to the calendar that was
redone in September.

Once this is in, I'll push the review 125862 and
that should be all to get holidays back to the 
calendar.


Diffs
-

  applets/digital-clock/package/contents/config/config.qml 877e40c 
  applets/digital-clock/package/contents/config/main.xml aacbe27 
  applets/digital-clock/package/contents/ui/CalendarView.qml 381bddb 
  applets/digital-clock/package/contents/ui/configAppearance.qml fc9a09e 
  applets/digital-clock/package/contents/ui/configCalendar.qml PRE-CREATION 

Diff: https://git.reviewboard.kde.org/r/127734/diff/


Testing
---

See the screenshot with kholidays plugin backend.


File Attachments


Screenshot
  
https://git.reviewboard.kde.org/media/uploaded/files/2016/04/24/67ed5b51-acb2-46b8-8e1e-db87f0692903__snapshot113.png


Thanks,

Martin Klapetek

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 127586: [calendar] Add a mark to days containing events

[Martin Klapetek]

> On April 28, 2016, 8:44 p.m., Kai Uwe Broulik wrote:
> > You broke the zoomed out view, ie. in the year/decade overview you now get 
> > a tick at *every* cell...
> 
> Martin Klapetek wrote:
> Oops, I'll fix, thanks.

This is now fixed.


- Martin


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127586/#review94987
---


On April 21, 2016, 5:41 a.m., Martin Klapetek wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127586/
> ---
> 
> (Updated April 21, 2016, 5:41 a.m.)
> 
> 
> Review request for KDE Frameworks and Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> Simple triangle at the bottom right corner, see screenshot.
> 
> 
> Diffs
> -
> 
>   src/declarativeimports/calendar/calendar.h 1849ada 
>   src/declarativeimports/calendar/calendar.cpp 0c525b7 
>   src/declarativeimports/calendar/daysmodel.h 8ab232e 
>   src/declarativeimports/calendar/daysmodel.cpp bf99874 
>   src/declarativeimports/calendar/qml/DayDelegate.qml 6353827 
>   src/declarativeimports/calendar/qml/DaysCalendar.qml d4b8fe4 
> 
> Diff: https://git.reviewboard.kde.org/r/127586/diff/
> 
> 
> Testing
> ---
> 
> 
> File Attachments
> 
> 
> Screenshot
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/04/06/afefe7ce-7757-4505-9f17-63fca2ec26cb__snapshot109.png
> 
> 
> Thanks,
> 
> Martin Klapetek
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 127586: [calendar] Add a mark to days containing events

[Martin Klapetek]

> On April 28, 2016, 8:44 p.m., Kai Uwe Broulik wrote:
> > You broke the zoomed out view, ie. in the year/decade overview you now get 
> > a tick at *every* cell...

Oops, I'll fix, thanks.


- Martin


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127586/#review94987
---


On April 21, 2016, 5:41 a.m., Martin Klapetek wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127586/
> ---
> 
> (Updated April 21, 2016, 5:41 a.m.)
> 
> 
> Review request for KDE Frameworks and Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> Simple triangle at the bottom right corner, see screenshot.
> 
> 
> Diffs
> -
> 
>   src/declarativeimports/calendar/calendar.h 1849ada 
>   src/declarativeimports/calendar/calendar.cpp 0c525b7 
>   src/declarativeimports/calendar/daysmodel.h 8ab232e 
>   src/declarativeimports/calendar/daysmodel.cpp bf99874 
>   src/declarativeimports/calendar/qml/DayDelegate.qml 6353827 
>   src/declarativeimports/calendar/qml/DaysCalendar.qml d4b8fe4 
> 
> Diff: https://git.reviewboard.kde.org/r/127586/diff/
> 
> 
> Testing
> ---
> 
> 
> File Attachments
> 
> 
> Screenshot
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/04/06/afefe7ce-7757-4505-9f17-63fca2ec26cb__snapshot109.png
> 
> 
> Thanks,
> 
> Martin Klapetek
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Updated] D1478: [Notifications] Don't group job finished notifications

[mck182 (Martin Klapetek)]

mck182 added a comment.


  In https://phabricator.kde.org/D1478#27445, @colomar wrote:
  
  > Why are those notification even persistent in the first place? If a user 
misses the notification, they should notice that the job was finished by the 
fact that it's not running anymore.
  >  Only errors should be persistent.
  
  
  So that users may leave long-taking jobs unattended and then click "Open 
folder" on the notification or something once they're back and/or the job is 
done.

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D1478

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, Plasma, Plasma: Design, mck182
Cc: colomar, plasma-devel, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 127734: Revert the revert of the revert that removed the agenda from calendar

[Martin Klapetek]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127734/
---

(Updated April 24, 2016, 10:22 p.m.)


Review request for Plasma.


Repository: plasma-workspace


Description
---

Brings back the agenda to the calendar that was
redone in September.

Once this is in, I'll push the review 125862 and
that should be all to get holidays back to the 
calendar.


Diffs
-

  applets/digital-clock/package/contents/config/config.qml 877e40c 
  applets/digital-clock/package/contents/config/main.xml aacbe27 
  applets/digital-clock/package/contents/ui/CalendarView.qml 381bddb 
  applets/digital-clock/package/contents/ui/configAppearance.qml fc9a09e 
  applets/digital-clock/package/contents/ui/configCalendar.qml PRE-CREATION 

Diff: https://git.reviewboard.kde.org/r/127734/diff/


Testing
---

See the screenshot with kholidays plugin backend.


File Attachments (updated)


Screenshot
  
https://git.reviewboard.kde.org/media/uploaded/files/2016/04/24/67ed5b51-acb2-46b8-8e1e-db87f0692903__snapshot113.png


Thanks,

Martin Klapetek

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request 127734: Revert the revert of the revert that removed the agenda from calendar

[Martin Klapetek]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127734/
---

Review request for Plasma.


Repository: plasma-workspace


Description
---

Brings back the agenda to the calendar that was
redone in September.

Once this is in, I'll push the review 125862 and
that should be all to get holidays back to the 
calendar.


Diffs
-

  applets/digital-clock/package/contents/config/config.qml 877e40c 
  applets/digital-clock/package/contents/config/main.xml aacbe27 
  applets/digital-clock/package/contents/ui/CalendarView.qml 381bddb 
  applets/digital-clock/package/contents/ui/configAppearance.qml fc9a09e 
  applets/digital-clock/package/contents/ui/configCalendar.qml PRE-CREATION 

Diff: https://git.reviewboard.kde.org/r/127734/diff/


Testing
---

See the screenshot with kholidays plugin backend.


File Attachments


Screenshot
  
https://git.reviewboard.kde.org/media/uploaded/files/2016/04/24/64ce9060-a12d-49ca-bd21-469af396fbb5__snapshot112.png


Thanks,

Martin Klapetek

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Kirigami: a feature needed for subsurface and api change feedback

[Martin Klapetek]

On Thu, Apr 21, 2016 at 12:59 PM, Dirk Hohndel <d...@hohndel.org> wrote:

> On Thu, Apr 21, 2016 at 06:42:59PM +0200, Marco Martin wrote:
> >
> > that's subsurface next to the gallery example app how they look on my
> laptop:
> > http://imgur.com/Ni9fhkD
> >
> > note the size of the bottom action button and drawer handle.. that
> > looks pretty weird
>
> That's weird indeed. Any idea why that is? So there's something that we
> are doing wrong...
> what's the font size it reports under Devloper->Theme information?
>
> I tried to build the example gallery locally but CMake complains about
> missing ECM 0.0.8 - where do I find that?
>

In case you still haven't - git://anongit.kde.org/extra-cmake-modules.git

Cheers
-- 
Martin Klapetek | KDE Developer
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 127586: [calendar] Add a mark to days containing events

[Martin Klapetek]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127586/
---

(Updated April 21, 2016, 3:41 a.m.)


Status
--

This change has been marked as submitted.


Review request for KDE Frameworks and Plasma.


Changes
---

Submitted with commit 08312b2e340e10d640131c0186e81a0b9f0f2505 by Martin 
Klapetek to branch master.


Repository: plasma-framework


Description
---

Simple triangle at the bottom right corner, see screenshot.


Diffs
-

  src/declarativeimports/calendar/calendar.h 1849ada 
  src/declarativeimports/calendar/calendar.cpp 0c525b7 
  src/declarativeimports/calendar/daysmodel.h 8ab232e 
  src/declarativeimports/calendar/daysmodel.cpp bf99874 
  src/declarativeimports/calendar/qml/DayDelegate.qml 6353827 
  src/declarativeimports/calendar/qml/DaysCalendar.qml d4b8fe4 

Diff: https://git.reviewboard.kde.org/r/127586/diff/


Testing
---


File Attachments


Screenshot
  
https://git.reviewboard.kde.org/media/uploaded/files/2016/04/06/afefe7ce-7757-4505-9f17-63fca2ec26cb__snapshot109.png


Thanks,

Martin Klapetek

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Kirigami Page.title

[Martin Klapetek]

Is it possible to either hide the blue titlebar when empty
or add things like buttons and icons in there?

In SpaceBar, the active conversation has this layout at
the top of the Page:

[Presence Icon] Username [Close Conversation Button]

So in this case it doesn't make sense that this Page would
have the standard blue titlebar too. Unless more things could
go in there.

I can perhaps write a patch to hide it if empty, if you agree.

Cheers
-- 
Martin Klapetek | KDE Developer
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 127586: [calendar] Add a mark to days containing events

[Martin Klapetek]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127586/
---

(Updated April 19, 2016, 5:23 a.m.)


Review request for KDE Frameworks and Plasma.


Changes
---

Avoid reordering issue


Repository: plasma-framework


Description
---

Simple triangle at the bottom right corner, see screenshot.


Diffs (updated)
-

  src/declarativeimports/calendar/calendar.h 1849ada 
  src/declarativeimports/calendar/calendar.cpp 0c525b7 
  src/declarativeimports/calendar/daysmodel.h 8ab232e 
  src/declarativeimports/calendar/daysmodel.cpp bf99874 
  src/declarativeimports/calendar/qml/DayDelegate.qml 6353827 
  src/declarativeimports/calendar/qml/DaysCalendar.qml d4b8fe4 

Diff: https://git.reviewboard.kde.org/r/127586/diff/


Testing
---


File Attachments


Screenshot
  
https://git.reviewboard.kde.org/media/uploaded/files/2016/04/06/afefe7ce-7757-4505-9f17-63fca2ec26cb__snapshot109.png


Thanks,

Martin Klapetek

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 127586: [calendar] Add a mark to days containing events

[Martin Klapetek]

> On April 13, 2016, 10:28 a.m., Marco Martin wrote:
> > what's the status of this?
> 
> Martin Klapetek wrote:
> Working on it.
> 
> Martin Klapetek wrote:
> Ok so I'm unable to render that svg, it is properly installed
> and everything, but this doesn't show anything (not even error):
> 
> ```
> PlasmaCore.Svg {
> id: calendarSvg
> imagePath: "widgets/calendar"
> }
> 
> PlasmaCore.SvgItem {
> id: eventsMarker
> width: parent.width / 3
> height: parent.height / 3
> svg: calendarSvg
> elementId: "event"
> }
> ```
> 
> ...is it missing anything? If I use say "widgets/clock" and "ClockFace", 
> it works fine.
> 
> Marco Martin wrote:
> tried to delete the cache?
> 
> Martin Klapetek wrote:
> Yes, in fact, after deleting the cache, I see this:
> 
> QtQmlViewer(9862) unknown: Couldn't find node event. Skipping rendering.
> 
> On a second run, it doesn't show anymore.
> 
> Is the code above working for you?

*insert double-facepalm image here*

So after some more investigation, I found out why it won't
work - I'm running the "Breeze 5.4" theme, which, obviously,
does not have that element. Sigh.


- Martin


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127586/#review94567
---


On April 6, 2016, 5:53 a.m., Martin Klapetek wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127586/
> ---
> 
> (Updated April 6, 2016, 5:53 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> Simple triangle at the bottom right corner, see screenshot.
> 
> 
> Diffs
> -
> 
>   src/declarativeimports/calendar/daysmodel.h 8ab232e 
>   src/declarativeimports/calendar/daysmodel.cpp bf99874 
>   src/declarativeimports/calendar/qml/DayDelegate.qml 6353827 
>   src/declarativeimports/calendar/qml/DaysCalendar.qml d4b8fe4 
> 
> Diff: https://git.reviewboard.kde.org/r/127586/diff/
> 
> 
> Testing
> ---
> 
> 
> File Attachments
> 
> 
> Screenshot
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/04/06/afefe7ce-7757-4505-9f17-63fca2ec26cb__snapshot109.png
> 
> 
> Thanks,
> 
> Martin Klapetek
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 127586: [calendar] Add a mark to days containing events

[Martin Klapetek]

> On April 13, 2016, 10:28 a.m., Marco Martin wrote:
> > what's the status of this?
> 
> Martin Klapetek wrote:
> Working on it.
> 
> Martin Klapetek wrote:
> Ok so I'm unable to render that svg, it is properly installed
> and everything, but this doesn't show anything (not even error):
> 
> ```
> PlasmaCore.Svg {
> id: calendarSvg
> imagePath: "widgets/calendar"
> }
> 
> PlasmaCore.SvgItem {
> id: eventsMarker
> width: parent.width / 3
> height: parent.height / 3
> svg: calendarSvg
> elementId: "event"
> }
> ```
> 
> ...is it missing anything? If I use say "widgets/clock" and "ClockFace", 
> it works fine.
> 
> Marco Martin wrote:
> tried to delete the cache?

Yes, in fact, after deleting the cache, I see this:

QtQmlViewer(9862) unknown: Couldn't find node event. Skipping rendering.

On a second run, it doesn't show anymore.

Is the code above working for you?


- Martin


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127586/#review94567
---


On April 6, 2016, 5:53 a.m., Martin Klapetek wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127586/
> ---
> 
> (Updated April 6, 2016, 5:53 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> Simple triangle at the bottom right corner, see screenshot.
> 
> 
> Diffs
> -
> 
>   src/declarativeimports/calendar/daysmodel.h 8ab232e 
>   src/declarativeimports/calendar/daysmodel.cpp bf99874 
>   src/declarativeimports/calendar/qml/DayDelegate.qml 6353827 
>   src/declarativeimports/calendar/qml/DaysCalendar.qml d4b8fe4 
> 
> Diff: https://git.reviewboard.kde.org/r/127586/diff/
> 
> 
> Testing
> ---
> 
> 
> File Attachments
> 
> 
> Screenshot
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/04/06/afefe7ce-7757-4505-9f17-63fca2ec26cb__snapshot109.png
> 
> 
> Thanks,
> 
> Martin Klapetek
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 127586: [calendar] Add a mark to days containing events

[Martin Klapetek]

> On April 13, 2016, 10:28 a.m., Marco Martin wrote:
> > what's the status of this?
> 
> Martin Klapetek wrote:
> Working on it.

Ok so I'm unable to render that svg, it is properly installed
and everything, but this doesn't show anything (not even error):

```
PlasmaCore.Svg {
id: calendarSvg
imagePath: "widgets/calendar"
}

PlasmaCore.SvgItem {
id: eventsMarker
width: parent.width / 3
height: parent.height / 3
svg: calendarSvg
elementId: "event"
}
```

...is it missing anything? If I use say "widgets/clock" and "ClockFace", it 
works fine.


- Martin


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127586/#review94567
-------


On April 6, 2016, 5:53 a.m., Martin Klapetek wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127586/
> ---
> 
> (Updated April 6, 2016, 5:53 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> Simple triangle at the bottom right corner, see screenshot.
> 
> 
> Diffs
> -
> 
>   src/declarativeimports/calendar/daysmodel.h 8ab232e 
>   src/declarativeimports/calendar/daysmodel.cpp bf99874 
>   src/declarativeimports/calendar/qml/DayDelegate.qml 6353827 
>   src/declarativeimports/calendar/qml/DaysCalendar.qml d4b8fe4 
> 
> Diff: https://git.reviewboard.kde.org/r/127586/diff/
> 
> 
> Testing
> ---
> 
> 
> File Attachments
> --------
> 
> Screenshot
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/04/06/afefe7ce-7757-4505-9f17-63fca2ec26cb__snapshot109.png
> 
> 
> Thanks,
> 
> Martin Klapetek
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 127586: [calendar] Add a mark to days containing events

[Martin Klapetek]

> On April 13, 2016, 10:28 a.m., Marco Martin wrote:
> > what's the status of this?

Working on it.


- Martin


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127586/#review94567
---


On April 6, 2016, 5:53 a.m., Martin Klapetek wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127586/
> ---
> 
> (Updated April 6, 2016, 5:53 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> Simple triangle at the bottom right corner, see screenshot.
> 
> 
> Diffs
> -
> 
>   src/declarativeimports/calendar/daysmodel.h 8ab232e 
>   src/declarativeimports/calendar/daysmodel.cpp bf99874 
>   src/declarativeimports/calendar/qml/DayDelegate.qml 6353827 
>   src/declarativeimports/calendar/qml/DaysCalendar.qml d4b8fe4 
> 
> Diff: https://git.reviewboard.kde.org/r/127586/diff/
> 
> 
> Testing
> ---
> 
> 
> File Attachments
> 
> 
> Screenshot
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/04/06/afefe7ce-7757-4505-9f17-63fca2ec26cb__snapshot109.png
> 
> 
> Thanks,
> 
> Martin Klapetek
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Kirigami.Page breaks with Loader+Component inside

[Martin Klapetek]

On Mon, Apr 11, 2016 at 6:07 AM, Aleix Pol <aleix...@kde.org> wrote:

> On Mon, Apr 11, 2016 at 10:44 AM, Marco Martin <notm...@gmail.com> wrote:
> > On Monday 11 April 2016, Martin Klapetek wrote:
> >> Hey,
> >>
> >> so I've ported SpaceBar to Kirigami and got stuck with Page
> >> not rendering anything when it contains a Loader.
> >>
> >> I've reduced it to a minimal example, attached, where it is
> >> easily reproducible.
> >>
> >> Running the attached qml file will show an empty page, removing
> >> the Loader _and_ Component will show the green rectangle.
> >> Changing the Page to say, an Item, shows both Rects.
> >>
> >> This was working before and I have tried to look into it, but couldn't
> >> figure out what's up with that.
> >>
> >> Can somebody have a look?
> >
> > i think i know why this happens (actually the problam at the moment is
> that
> > page can only have 1 child)
> > it should be changed to allow a list of children as any other item
> >
> > this patch on page should fix stuff
> > https://paste.kde.org/prkp1my8o
>
> Or this patch, please review:
> https://phabricator.kde.org/D1363


Ok, latest master now works, thank you!

Cheers
-- 
Martin Klapetek | KDE Developer
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Kirigami.Page breaks with Loader+Component inside

[Martin Klapetek]

Hey,

so I've ported SpaceBar to Kirigami and got stuck with Page
not rendering anything when it contains a Loader.

I've reduced it to a minimal example, attached, where it is
easily reproducible.

Running the attached qml file will show an empty page, removing
the Loader _and_ Component will show the green rectangle.
Changing the Page to say, an Item, shows both Rects.

This was working before and I have tried to look into it, but couldn't
figure out what's up with that.

Can somebody have a look?

Cheers
-- 
Martin Klapetek | KDE Developer
import QtQuick 2.1
import QtQuick.Controls 1.4 as Controls
import QtQuick.Layouts 1.2
import org.kde.kirigami 1.0 as Kirigami

Kirigami.ApplicationWindow {
id: root
width: 500
height: 800
visible: true

pageStack.initialPage: mainPageComponent

Component {
id: mainPageComponent

Kirigami.Page {
title: "Hello"

Rectangle {
color: "green"
width: 150
height: 150
}

// Comment the Loader and Component and the Rectangle
// above will appear
Loader {
active: true
sourceComponent: innerComponent
}

Component {
id: innerComponent

Rectangle {
color: "red"
width: 50
height: 50
}
}
}
}
}
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 127586: [calendar] Add a mark to days containing events

[Martin Klapetek]

> On April 6, 2016, 9:03 a.m., Kai Uwe Broulik wrote:
> > You really don't want to create more Canvas elements than neccessary, they 
> > all have their own FBO.
> > 
> > Can't you make the grid canvas draw the triangles, too? Or make a simple 
> > item with a triangle shaped QSGGeometryNode?
> 
> Kai Uwe Broulik wrote:
> There's even exactly that on WikiBooks :D 
> https://en.wikibooks.org/wiki/Qt/Qt_Quick_Overview#Triangle_implementation
> 
> Martin Klapetek wrote:
> Ah, that's handy. Now I wonder though - it's under CC-BY-SA licence, can 
> I just copy that directly and put that licence in the header and ship this in 
> frameworks?
> 
> Martin Gräßlin wrote:
> I would say that is not copyrightable, it's too trivial.
> 
> Marco Martin wrote:
> I would prefer adding it to the svg theme.
> there used to be elements for the calendar in the theme, they could get 
> back
> 
> Martin Klapetek wrote:
> Oooh that would be nice. Who's in charge of the theme these days?
> 
> Marco Martin wrote:
> I can add the needed item, is just needed a single item as that triangle?
> 
> Martin Klapetek wrote:
> Yes. Make it the highlight color of the theme (or I guess I'll be able to 
> color it from the code right?)
> 
> Marco Martin wrote:
> the svg would be always "highlight color" whatever is the theme. 
> you would need other colors?
> i'll sooner or later add some api to manipulate the stylesheet from the 
> code, but that's not available yet

I considered having different colors by event type (holiday vs calendar event), 
but I guess a single color will do for now.


- Martin


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127586/#review94325
---


On April 6, 2016, 5:53 a.m., Martin Klapetek wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127586/
> ---
> 
> (Updated April 6, 2016, 5:53 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> Simple triangle at the bottom right corner, see screenshot.
> 
> 
> Diffs
> -
> 
>   src/declarativeimports/calendar/daysmodel.h 8ab232e 
>   src/declarativeimports/calendar/daysmodel.cpp bf99874 
>   src/declarativeimports/calendar/qml/DayDelegate.qml 6353827 
>   src/declarativeimports/calendar/qml/DaysCalendar.qml d4b8fe4 
> 
> Diff: https://git.reviewboard.kde.org/r/127586/diff/
> 
> 
> Testing
> ---
> 
> 
> File Attachments
> 
> 
> Screenshot
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/04/06/afefe7ce-7757-4505-9f17-63fca2ec26cb__snapshot109.png
> 
> 
> Thanks,
> 
> Martin Klapetek
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 127586: [calendar] Add a mark to days containing events

[Martin Klapetek]

> On April 6, 2016, 9:03 a.m., Kai Uwe Broulik wrote:
> > You really don't want to create more Canvas elements than neccessary, they 
> > all have their own FBO.
> > 
> > Can't you make the grid canvas draw the triangles, too? Or make a simple 
> > item with a triangle shaped QSGGeometryNode?
> 
> Kai Uwe Broulik wrote:
> There's even exactly that on WikiBooks :D 
> https://en.wikibooks.org/wiki/Qt/Qt_Quick_Overview#Triangle_implementation
> 
> Martin Klapetek wrote:
> Ah, that's handy. Now I wonder though - it's under CC-BY-SA licence, can 
> I just copy that directly and put that licence in the header and ship this in 
> frameworks?
> 
> Martin Gräßlin wrote:
> I would say that is not copyrightable, it's too trivial.
> 
> Marco Martin wrote:
> I would prefer adding it to the svg theme.
> there used to be elements for the calendar in the theme, they could get 
> back
> 
> Martin Klapetek wrote:
> Oooh that would be nice. Who's in charge of the theme these days?
> 
> Marco Martin wrote:
> I can add the needed item, is just needed a single item as that triangle?

Yes. Make it the highlight color of the theme (or I guess I'll be able to color 
it from the code right?)


- Martin


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127586/#review94325
---


On April 6, 2016, 5:53 a.m., Martin Klapetek wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127586/
> ---
> 
> (Updated April 6, 2016, 5:53 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> Simple triangle at the bottom right corner, see screenshot.
> 
> 
> Diffs
> -
> 
>   src/declarativeimports/calendar/daysmodel.h 8ab232e 
>   src/declarativeimports/calendar/daysmodel.cpp bf99874 
>   src/declarativeimports/calendar/qml/DayDelegate.qml 6353827 
>   src/declarativeimports/calendar/qml/DaysCalendar.qml d4b8fe4 
> 
> Diff: https://git.reviewboard.kde.org/r/127586/diff/
> 
> 
> Testing
> ---
> 
> 
> File Attachments
> 
> 
> Screenshot
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/04/06/afefe7ce-7757-4505-9f17-63fca2ec26cb__snapshot109.png
> 
> 
> Thanks,
> 
> Martin Klapetek
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 127586: [calendar] Add a mark to days containing events

[Martin Klapetek]

> On April 6, 2016, 9:03 a.m., Kai Uwe Broulik wrote:
> > You really don't want to create more Canvas elements than neccessary, they 
> > all have their own FBO.
> > 
> > Can't you make the grid canvas draw the triangles, too? Or make a simple 
> > item with a triangle shaped QSGGeometryNode?
> 
> Kai Uwe Broulik wrote:
> There's even exactly that on WikiBooks :D 
> https://en.wikibooks.org/wiki/Qt/Qt_Quick_Overview#Triangle_implementation
> 
> Martin Klapetek wrote:
> Ah, that's handy. Now I wonder though - it's under CC-BY-SA licence, can 
> I just copy that directly and put that licence in the header and ship this in 
> frameworks?
> 
> Martin Gräßlin wrote:
> I would say that is not copyrightable, it's too trivial.
> 
> Marco Martin wrote:
> I would prefer adding it to the svg theme.
> there used to be elements for the calendar in the theme, they could get 
> back

Oooh that would be nice. Who's in charge of the theme these days?


- Martin


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127586/#review94325
-------


On April 6, 2016, 5:53 a.m., Martin Klapetek wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127586/
> ---
> 
> (Updated April 6, 2016, 5:53 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> Simple triangle at the bottom right corner, see screenshot.
> 
> 
> Diffs
> -
> 
>   src/declarativeimports/calendar/daysmodel.h 8ab232e 
>   src/declarativeimports/calendar/daysmodel.cpp bf99874 
>   src/declarativeimports/calendar/qml/DayDelegate.qml 6353827 
>   src/declarativeimports/calendar/qml/DaysCalendar.qml d4b8fe4 
> 
> Diff: https://git.reviewboard.kde.org/r/127586/diff/
> 
> 
> Testing
> ---
> 
> 
> File Attachments
> 
> 
> Screenshot
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/04/06/afefe7ce-7757-4505-9f17-63fca2ec26cb__snapshot109.png
> 
> 
> Thanks,
> 
> Martin Klapetek
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 127586: [calendar] Add a mark to days containing events

[Martin Klapetek]

> On April 6, 2016, 9:03 a.m., Kai Uwe Broulik wrote:
> > You really don't want to create more Canvas elements than neccessary, they 
> > all have their own FBO.
> > 
> > Can't you make the grid canvas draw the triangles, too? Or make a simple 
> > item with a triangle shaped QSGGeometryNode?
> 
> Kai Uwe Broulik wrote:
> There's even exactly that on WikiBooks :D 
> https://en.wikibooks.org/wiki/Qt/Qt_Quick_Overview#Triangle_implementation

Ah, that's handy. Now I wonder though - it's under CC-BY-SA licence, can I just 
copy that directly and put that licence in the header and ship this in 
frameworks?


- Martin


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127586/#review94325
-------


On April 6, 2016, 5:53 a.m., Martin Klapetek wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127586/
> ---
> 
> (Updated April 6, 2016, 5:53 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> Simple triangle at the bottom right corner, see screenshot.
> 
> 
> Diffs
> -
> 
>   src/declarativeimports/calendar/daysmodel.h 8ab232e 
>   src/declarativeimports/calendar/daysmodel.cpp bf99874 
>   src/declarativeimports/calendar/qml/DayDelegate.qml 6353827 
>   src/declarativeimports/calendar/qml/DaysCalendar.qml d4b8fe4 
> 
> Diff: https://git.reviewboard.kde.org/r/127586/diff/
> 
> 
> Testing
> ---
> 
> 
> File Attachments
> 
> 
> Screenshot
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/04/06/afefe7ce-7757-4505-9f17-63fca2ec26cb__snapshot109.png
> 
> 
> Thanks,
> 
> Martin Klapetek
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request 127586: [calendar] Add a mark to days containing events

[Martin Klapetek]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127586/
---

Review request for Plasma.


Repository: plasma-framework


Description
---

Simple triangle at the bottom right corner, see screenshot.


Diffs
-

  src/declarativeimports/calendar/daysmodel.h 8ab232e 
  src/declarativeimports/calendar/daysmodel.cpp bf99874 
  src/declarativeimports/calendar/qml/DayDelegate.qml 6353827 
  src/declarativeimports/calendar/qml/DaysCalendar.qml d4b8fe4 

Diff: https://git.reviewboard.kde.org/r/127586/diff/


Testing
---


File Attachments


Screenshot
  
https://git.reviewboard.kde.org/media/uploaded/files/2016/04/06/afefe7ce-7757-4505-9f17-63fca2ec26cb__snapshot109.png


Thanks,

Martin Klapetek

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 127456: [2/2] Fix calendar applet not clearing selection when hiding

[Martin Klapetek]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127456/
---

(Updated March 30, 2016, 7:57 p.m.)


Status
--

This change has been marked as submitted.


Review request for Plasma.


Changes
---

Submitted with commit d3beb0b647a543436d3d23ab82b39a2f98a384be by Martin 
Klapetek to branch Plasma/5.6.


Bugs: 360683
https://bugs.kde.org/show_bug.cgi?id=360683


Repository: plasma-workspace


Description
---

The workspace part of the fix.


Diffs
-

  applets/digital-clock/package/contents/ui/CalendarView.qml 09dbe5e 

Diff: https://git.reviewboard.kde.org/r/127456/diff/


Testing
---


Thanks,

Martin Klapetek

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 127455: [1/2] Fix calendar applet not clearing selection when hiding

[Martin Klapetek]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127455/
---

(Updated March 30, 2016, 7:54 p.m.)


Status
--

This change has been marked as submitted.


Review request for Plasma.


Changes
---

Submitted with commit cff18c2cd28e8676cbcc0713ba45efde6cf09db0 by Martin 
Klapetek to branch master.


Bugs: 360683
http://bugs.kde.org/show_bug.cgi?id=360683


Repository: plasma-framework


Description
---

This removes some old cruft that is not really used and serves
basically only as a bool property for checking if it's null and
wheter it equals the last activated date.

This can be done without it by simply resetting the current selected
date (another property) to "today".

I decided to leave the useless property in for the time being
to allow for some buffer time between the -workspace and -framework
release so that it does not throw errors (ie. if distros will
ship 5.6 + p-f 5.21).


Diffs
-

  src/declarativeimports/calendar/qml/DayDelegate.qml 6877150 
  src/declarativeimports/calendar/qml/DaysCalendar.qml 8248a8f 
  src/declarativeimports/calendar/qml/MonthView.qml 76c605a 

Diff: https://git.reviewboard.kde.org/r/127455/diff/


Testing
---

Selection is properly cleared.


Thanks,

Martin Klapetek

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 125862: Add simple calendar events plugin based on KHolidays

[Martin Klapetek]

> On Feb. 23, 2016, 2:09 p.m., David Edmundson wrote:
> > Martin, what is the state of this?
> > 
> > You're in danger of missing Plasma 5.6.
> 
> Martin Klapetek wrote:
> I very likely won't be able to finish it in this cycle.
> 
> David Edmundson wrote:
> well, what's missing?
> I don't want to miss 5.7 too.

It’s on my todo once I'm back from vacation.


- Martin


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125862/#review92660
-------


On Nov. 18, 2015, 1:33 a.m., Martin Klapetek wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125862/
> ---
> 
> (Updated Nov. 18, 2015, 1:33 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> This is very simple for now as there is no configuration
> yet, so it just takes the default region (your locale)
> and shows holidays from that.
> 
> Obviously this needs a config to set up which regions
> you want to show in there, but this is a start.
> 
> 
> Diffs
> -
> 
>   CMakeLists.txt 4783a78 
>   plasmacalendarintegration/CMakeLists.txt PRE-CREATION 
>   plasmacalendarintegration/HolidaysConfig.qml PRE-CREATION 
>   plasmacalendarintegration/holidayeventsplugin.json PRE-CREATION 
>   plasmacalendarintegration/holidaysevents.h PRE-CREATION 
>   plasmacalendarintegration/holidaysevents.cpp PRE-CREATION 
>   plasmacalendarintegration/qmlhelper/CMakeLists.txt PRE-CREATION 
>   plasmacalendarintegration/qmlhelper/holidayeventshelperplugin.h 
> PRE-CREATION 
>   plasmacalendarintegration/qmlhelper/holidayeventshelperplugin.cpp 
> PRE-CREATION 
>   plasmacalendarintegration/qmlhelper/qmldir PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/125862/diff/
> 
> 
> Testing
> ---
> 
> Holidays are properly listed in calendar applet.
> 
> 
> Thanks,
> 
> Martin Klapetek
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126949: Remove Air and Oxygen themes

[Martin Klapetek]

/slider.svgz 107e627 
  src/desktoptheme/air/widgets/systemtray.svgz 6e15351 
  src/desktoptheme/air/widgets/tabbar.svgz 8e6684e 
  src/desktoptheme/air/widgets/tasks.svgz f6ed0a9 
  src/desktoptheme/air/widgets/toolbar.svgz 09ce09f 
  src/desktoptheme/air/widgets/toolbox.svgz 138df24 
  src/desktoptheme/air/widgets/tooltip.svgz 080a65d 
  src/desktoptheme/air/widgets/translucentbackground.svgz 2aea33b 
  src/desktoptheme/air/widgets/viewitem.svgz 82f9662 
  src/desktoptheme/oxygen/CMakeLists.txt 7854234 
  src/desktoptheme/oxygen/colors 760c109 
  src/desktoptheme/oxygen/dialogs/background.svgz 50589c5 
  src/desktoptheme/oxygen/dialogs/kickoff.svgz 994306e 
  src/desktoptheme/oxygen/dialogs/krunner.svgz eb4e196 
  src/desktoptheme/oxygen/metadata.desktop cb037d1 
  src/desktoptheme/oxygen/opaque/dialogs/background.svgz 6696739 
  src/desktoptheme/oxygen/opaque/dialogs/krunner.svgz a703868 
  src/desktoptheme/oxygen/opaque/widgets/extender-background.svgz cfcdc61 
  src/desktoptheme/oxygen/opaque/widgets/panel-background.svgz 77d20a7 
  src/desktoptheme/oxygen/opaque/widgets/tooltip.svgz 0c62a03 
  src/desktoptheme/oxygen/widgets/action-overlays.svgz 3020bff 
  src/desktoptheme/oxygen/widgets/actionbutton.svgz 8c31c2d 
  src/desktoptheme/oxygen/widgets/analog_meter.svgz ddf1acc 
  src/desktoptheme/oxygen/widgets/arrows.svgz 09f274c 
  src/desktoptheme/oxygen/widgets/background.svgz f9e4b1d 
  src/desktoptheme/oxygen/widgets/bar_meter_horizontal.svgz 6b2eeac 
  src/desktoptheme/oxygen/widgets/bar_meter_vertical.svgz 6d4c3c9 
  src/desktoptheme/oxygen/widgets/branding.svgz 70ba236 
  src/desktoptheme/oxygen/widgets/busywidget.svgz bcdfc59 
  src/desktoptheme/oxygen/widgets/button.svgz 4ac759d 
  src/desktoptheme/oxygen/widgets/calendar.svgz e784207 
  src/desktoptheme/oxygen/widgets/clock.svgz d2ec85e 
  src/desktoptheme/oxygen/widgets/configuration-icons.svgz ea73e6a 
  src/desktoptheme/oxygen/widgets/containment-controls.svgz 675cba4 
  src/desktoptheme/oxygen/widgets/dragger.svgz c4f8ce9 
  src/desktoptheme/oxygen/widgets/extender-background.svgz 7e5afab 
  src/desktoptheme/oxygen/widgets/extender-dragger.svgz 37c92ec 
  src/desktoptheme/oxygen/widgets/frame.svgz 7f5ce59 
  src/desktoptheme/oxygen/widgets/glowbar.svgz 557ff18 
  src/desktoptheme/oxygen/widgets/line.svgz f8f3d0e 
  src/desktoptheme/oxygen/widgets/lineedit.svgz 44b4ab6 
  src/desktoptheme/oxygen/widgets/media-delegate.svgz e28b313 
  src/desktoptheme/oxygen/widgets/monitor.svgz f005a57 
  src/desktoptheme/oxygen/widgets/pager.svgz 967015b 
  src/desktoptheme/oxygen/widgets/panel-background.svgz 13f2f69 
  src/desktoptheme/oxygen/widgets/plot-background.svgz 439b288 
  src/desktoptheme/oxygen/widgets/scrollbar.svgz d8a0557 
  src/desktoptheme/oxygen/widgets/scrollwidget.svgz 5e38523 
  src/desktoptheme/oxygen/widgets/slider.svgz f13f699 
  src/desktoptheme/oxygen/widgets/systemtray.svgz ad4e1a2 
  src/desktoptheme/oxygen/widgets/tasks.svgz 1ffa9d7 
  src/desktoptheme/oxygen/widgets/timer.svgz 43c 
  src/desktoptheme/oxygen/widgets/toolbox.svgz 0f92dde 
  src/desktoptheme/oxygen/widgets/tooltip.svgz 33d0bb5 
  src/desktoptheme/oxygen/widgets/translucentbackground.svgz 47b418d 
  src/desktoptheme/oxygen/widgets/viewitem.svgz cec433e 

Diff: https://git.reviewboard.kde.org/r/126949/diff/


Testing
---


Thanks,

Martin Klapetek

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Plasma 5.6 video

[Martin Klapetek]

On Mon, Mar 21, 2016 at 6:04 PM, Łukasz Sawicki <kde...@gmail.com> wrote:

>
> Replaced
> "https://www.kde.org/donate;
>
> with simple kde.org/donate as suggested.
>
> Here is an updated version, uploaded to KDE YouTube official channel
> this time ;)
>
> https://youtu.be/eePUT4k1oac


The falling money does send a very strange message.

Making it look like we're so rich we can rain money (illuminati confirmed!!)
or something (especially if you're not paying 100% attention to the
voiceover).
I don't understand what it is trying to say or what its relation is to
Plasma
or KDE (plus, we accept euros only, no dollars :P)

One other thing - try to stay consistent with the appearing/disappearing
animations; there are fades and zoom-sortofs throughout the whole video
and then the donate link has that squishy-powerpointy-2000y animation.
Consistency is key.

Otherwise - really really really well done. Kudos.

Cheers
-- 
Martin Klapetek | KDE Developer
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 127455: [1/2] Fix calendar applet not clearing selection when hiding

[Martin Klapetek]

> On March 21, 2016, 10:25 p.m., Kai Uwe Broulik wrote:
> > src/declarativeimports/calendar/qml/MonthView.qml, lines 36-37
> > <https://git.reviewboard.kde.org/r/127455/diff/1/?file=453733#file453733line36>
> >
> > While I agree, this property is stupid, it would break our 
> > API-compatibility promise.

Which is why I kept it in ;) I can replace the comment though that this is 
useless.


- Martin


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127455/#review93841
---


On March 21, 2016, 10:11 p.m., Martin Klapetek wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127455/
> ---
> 
> (Updated March 21, 2016, 10:11 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Bugs: 360683
> http://bugs.kde.org/show_bug.cgi?id=360683
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> This removes some old cruft that is not really used and serves
> basically only as a bool property for checking if it's null and
> wheter it equals the last activated date.
> 
> This can be done without it by simply resetting the current selected
> date (another property) to "today".
> 
> I decided to leave the useless property in for the time being
> to allow for some buffer time between the -workspace and -framework
> release so that it does not throw errors (ie. if distros will
> ship 5.6 + p-f 5.21).
> 
> 
> Diffs
> -
> 
>   src/declarativeimports/calendar/qml/DayDelegate.qml 6877150 
>   src/declarativeimports/calendar/qml/DaysCalendar.qml 8248a8f 
>   src/declarativeimports/calendar/qml/MonthView.qml 76c605a 
> 
> Diff: https://git.reviewboard.kde.org/r/127455/diff/
> 
> 
> Testing
> ---
> 
> Selection is properly cleared.
> 
> 
> Thanks,
> 
> Martin Klapetek
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request 127456: [2/2] Fix calendar applet not clearing selection when hiding

[Martin Klapetek]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127456/
---

Review request for Plasma.


Bugs: 360683
https://bugs.kde.org/show_bug.cgi?id=360683


Repository: plasma-workspace


Description
---

The workspace part of the fix.


Diffs
-

  applets/digital-clock/package/contents/ui/CalendarView.qml 09dbe5e 

Diff: https://git.reviewboard.kde.org/r/127456/diff/


Testing
---


Thanks,

Martin Klapetek

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request 127455: [1/2] Fix calendar applet not clearing selection when hiding

[Martin Klapetek]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127455/
---

Review request for Plasma.


Bugs: 360683
http://bugs.kde.org/show_bug.cgi?id=360683


Repository: plasma-framework


Description
---

This removes some old cruft that is not really used and serves
basically only as a bool property for checking if it's null and
wheter it equals the last activated date.

This can be done without it by simply resetting the current selected
date (another property) to "today".

I decided to leave the useless property in for the time being
to allow for some buffer time between the -workspace and -framework
release so that it does not throw errors (ie. if distros will
ship 5.6 + p-f 5.21).


Diffs
-

  src/declarativeimports/calendar/qml/DayDelegate.qml 6877150 
  src/declarativeimports/calendar/qml/DaysCalendar.qml 8248a8f 
  src/declarativeimports/calendar/qml/MonthView.qml 76c605a 

Diff: https://git.reviewboard.kde.org/r/127455/diff/


Testing
---

Selection is properly cleared.


Thanks,

Martin Klapetek

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Plasma 5.6 video

[Martin Klapetek]

On Mon, Mar 21, 2016 at 3:12 PM, Ivan Čukić <ivan.cu...@kde.org> wrote:

> Hi,
>
> While the video is beyond fantastic (this is an objective statement,
> not only my opinion), the money-falling part is a bit tacky :)
>

Besides that, the donation link should be as short and
memorable as possible. Loose the whole https://www.
part, it's not a clickable link ;)

"kde.org/donate" is all you need to type into your browser.

Cheers
-- 
Martin Klapetek | KDE Developer
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: left-click on libappindicator indicators

[Martin Klapetek]

On Mon, Mar 21, 2016 at 3:10 PM, Raman Gupta <rocketra...@gmail.com> wrote:

> Currently (or at least as of Plasma 5.5.5 on my Fedora 23 machine),
> left-click on libappindicator-based indicator's in the plasma system
> tray does absolutely nothing.
>
> An example of this indicator is pidgin with the pidgin-indicator
> plugin (https://github.com/philipl/pidgin-indicator).
>
> On Ubuntu Unity, both left and right-click apparently open the
> indicator menu. Personally I am not fond of this behaviour, but it is
> better than doing nothing.
>
> I would prefer if Plasma could detect whether a tray icon provides a
> window, and if so, Plasma did application show/hide when tray icons
> are left-clicked. Essentially a minimize to tray/restore from tray
> function. Thoughts?
>

This is presumably the same as https://bugs.kde.org/show_bug.cgi?id=358589

Can you try that patch?

In any case, I'll post it for review.

Cheers
-- 
Martin Klapetek | KDE Developer
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 127102: Use fixed width for digital clock applet

[Martin Klapetek]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127102/#review93603
---


Ship it!




Ship It!

- Martin Klapetek


On March 16, 2016, 4:35 p.m., Daniel Faust wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127102/
> ---
> 
> (Updated March 16, 2016, 4:35 p.m.)
> 
> 
> Review request for kde-workspace and Plasma.
> 
> 
> Bugs: 347724
> https://bugs.kde.org/show_bug.cgi?id=347724
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> Currently the width of the date label is not fixed but changes depending on 
> the text. This causes the entire applet to change its width (if the time is 
> the widest displayed item). This in turn can cause all other applets in the 
> same panel to move whenever the displayed time changes.
> 
> This patch uses FontMetrics to iterate over all possible time strings (with 
> different width) and chooses the widest of them as reference for the fixed 
> width of the time label.
> 
> This way the width of the applet stays the same (unless the date is displayed 
> and changes). The text remains centered though, which means that it can still 
> move within the applet when the time changes.
> 
> 
> Diffs
> -
> 
>   applets/digital-clock/package/contents/ui/DigitalClock.qml 95bb071 
> 
> Diff: https://git.reviewboard.kde.org/r/127102/diff/
> 
> 
> Testing
> ---
> 
> Works with horizontal and vertical panel.
> Also displaying different combinations of "seconds", "date" and "timezone" 
> works.
> 
> 
> File Attachments
> 
> 
> 0001-Use-fixed-width-for-digital-clock-applet.patch
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/03/16/81b4a902-1454-4155-9fda-552b8acba1a8__0001-Use-fixed-width-for-digital-clock-applet.patch
> 
> 
> Thanks,
> 
> Daniel Faust
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 127102: Use fixed width for digital clock applet

[Martin Klapetek]

> On March 15, 2016, 5:48 p.m., Martin Klapetek wrote:
> > applets/digital-clock/package/contents/ui/DigitalClock.qml, lines 565-568
> > <https://git.reviewboard.kde.org/r/127102/diff/3/?file=448492#file448492line565>
> >
> > Can't we just compare "A" and "P" width's and use that? Would spare 
> > creating two Date objects and two calls to Qt.formatTime
> 
> Daniel Faust wrote:
> No, because eg. in german the strings for am and pm are "vorm." and 
> "nachm.".
> 
> Martin Klapetek wrote:
> Ah, good. Haven't thought of that. Those germans...
> 
> (on the other hand, I wouldn't expect anyone in Germany to actually not 
> use 24h clock format, but oh well)
> 
> One other thing - create just a single Date object and then call 
> setHours(13) on it for the second format.
> 
> Daniel Faust wrote:
> As you wish. But keep in mind that this is not a performance bottleneck.
> I added some debug outputs to see where setupLabels is called from and it 
> gets called 10 times when initializing the applet, including 3 times in the 
> onCompleted method.
> Even if it is a little bit off topic, here is the log (indentation was 
> done manually and is somewhat guessed):
> 
> ```
> onShowDateChanged
>   timeFormatCorrection
> onShowSecondsChanged
>   timeFormatCorrection
> setupLabels
>   00:00:00 NACHM.
> setupLabels
>   00:00:00 NACHM.
> 
> onDateFormatChanged
>   setupLabels
> 00:00:00 NACHM.
> 
> onLastSelectedTimezoneChanged
>   timeFormatCorrection
> setupLabels
>   00:00:00 NACHM.
> 
> onDisplayTimezoneAsCodeChanged
>   setupLabels
> 00:00:00 NACHM.
> 
> onUse24hFormatChanged
>   timeFormatCorrection
> setupLabels
>   00:00:00
> 
> onStateChanged
>   setupLabels
> 00:00:00
> 
> onCompleted
>   onSelectedTimeZonesChanged
> setupLabels
>   00:00:00
>   dateTimeChanged
> timeFormatCorrection
>   setupLabels
> 00:00:00
>   timeFormatCorrection
> setupLabels
>   00:00:00
> ```

> But keep in mind that this is not a performance bottleneck

I didn't claim it is. But there's no reason to not write
new code in an efficient way ;)

About the call numbers, yes, I'm aware of that. I wanted
to go over the whole applet and fix it, but then I was
assigned a different project and time was lacking.

Patches welcome for that too, of course :)


- Martin


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127102/#review93561
---


On March 16, 2016, 4:35 p.m., Daniel Faust wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127102/
> ---
> 
> (Updated March 16, 2016, 4:35 p.m.)
> 
> 
> Review request for kde-workspace and Plasma.
> 
> 
> Bugs: 347724
> https://bugs.kde.org/show_bug.cgi?id=347724
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> Currently the width of the date label is not fixed but changes depending on 
> the text. This causes the entire applet to change its width (if the time is 
> the widest displayed item). This in turn can cause all other applets in the 
> same panel to move whenever the displayed time changes.
> 
> This patch uses FontMetrics to iterate over all possible time strings (with 
> different width) and chooses the widest of them as reference for the fixed 
> width of the time label.
> 
> This way the width of the applet stays the same (unless the date is displayed 
> and changes). The text remains centered though, which means that it can still 
> move within the applet when the time changes.
> 
> 
> Diffs
> -
> 
>   applets/digital-clock/package/contents/ui/DigitalClock.qml 95bb071 
> 
> Diff: https://git.reviewboard.kde.org/r/127102/diff/
> 
> 
> Testing
> ---
> 
> Works with horizontal and vertical panel.
> Also displaying different combinations of "seconds", "date" and "timezone" 
> works.
> 
> 
> File Attachments
> 
> 
> 0001-Use-fixed-width-for-digital-clock-applet.patch
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/03/16/81b4a902-1454-4155-9fda-552b8acba1a8__0001-Use-fixed-width-for-digital-clock-applet.patch
> 
> 
> Thanks,
> 
> Daniel Faust
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 127102: Use fixed width for digital clock applet

[Martin Klapetek]

> On March 15, 2016, 5:48 p.m., Martin Klapetek wrote:
> > I've tested it extensively and it works great. Thanks a lot!
> > 
> > There's one more issue - http://paste.opensuse.org/view/raw/f8ba5d0d - the 
> > same font size should also be applied to the left date label (there are; 
> > the bottom should stay as is). Do you think you could include it as part of 
> > this patch?
> 
> Daniel Faust wrote:
> I changed it, but now I'm not so sure anymore if the fixed font size 
> wasn't intentional.
> It would be a separate issue anyway and not connected to this one, so if 
> you want, I can upload the patch to a new review request.

Yeah, that'd be great. Thanks!


> On March 15, 2016, 5:48 p.m., Martin Klapetek wrote:
> > applets/digital-clock/package/contents/ui/DigitalClock.qml, lines 565-568
> > <https://git.reviewboard.kde.org/r/127102/diff/3/?file=448492#file448492line565>
> >
> > Can't we just compare "A" and "P" width's and use that? Would spare 
> > creating two Date objects and two calls to Qt.formatTime
> 
> Daniel Faust wrote:
> No, because eg. in german the strings for am and pm are "vorm." and 
> "nachm.".

Ah, good. Haven't thought of that. Those germans...

(on the other hand, I wouldn't expect anyone in Germany to actually not use 24h 
clock format, but oh well)

One other thing - create just a single Date object and then call setHours(13) 
on it for the second format.


- Martin


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127102/#review93561
---


On March 8, 2016, 6:53 p.m., Daniel Faust wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127102/
> ---
> 
> (Updated March 8, 2016, 6:53 p.m.)
> 
> 
> Review request for kde-workspace and Plasma.
> 
> 
> Bugs: 347724
> https://bugs.kde.org/show_bug.cgi?id=347724
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> Currently the width of the date label is not fixed but changes depending on 
> the text. This causes the entire applet to change its width (if the time is 
> the widest displayed item). This in turn can cause all other applets in the 
> same panel to move whenever the displayed time changes.
> 
> This patch uses FontMetrics to iterate over all possible time strings (with 
> different width) and chooses the widest of them as reference for the fixed 
> width of the time label.
> 
> This way the width of the applet stays the same (unless the date is displayed 
> and changes). The text remains centered though, which means that it can still 
> move within the applet when the time changes.
> 
> 
> Diffs
> -
> 
>   applets/digital-clock/package/contents/ui/DigitalClock.qml 95bb071 
> 
> Diff: https://git.reviewboard.kde.org/r/127102/diff/
> 
> 
> Testing
> ---
> 
> Works with horizontal and vertical panel.
> Also displaying different combinations of "seconds", "date" and "timezone" 
> works.
> 
> 
> Thanks,
> 
> Daniel Faust
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Plasma 5.6 video

[Martin Klapetek]

I want to say that this video is amazing. Really really well done.

One thing that I found little bit off is the animation transition at 1:20.
It's kinda hasty/fast zoom-out-zoom-in. Maybe zoom directly to the
next scene without the zooming out?

Also sometimes it shows things within a screen and sometimes
not (it's most notable at 1:46 when it suddenly zooms out for no
apparent reason). This is really a minor issue, just for the sake
of consistency.

Yeah the ending is a bit cut off. Maybe say something like "All this
in the new Plasma 5.6 release, out now. KDE - Experience Freedom".

Other than that, outstanding work, thanks a lot for that.

And kudos for Darude - Sandstorm :D

Cheers
-- 
Martin Klapetek | KDE Developer
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 127102: Use fixed width for digital clock applet

[Martin Klapetek]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127102/#review93561
---



I've tested it extensively and it works great. Thanks a lot!

There's one more issue - http://paste.opensuse.org/view/raw/f8ba5d0d - the same 
font size should also be applied to the left date label (there are; the bottom 
should stay as is). Do you think you could include it as part of this patch?


applets/digital-clock/package/contents/ui/DigitalClock.qml (line 554)
<https://git.reviewboard.kde.org/r/127102/#comment63784>

spaces around operators



applets/digital-clock/package/contents/ui/DigitalClock.qml (lines 564 - 567)
<https://git.reviewboard.kde.org/r/127102/#comment63785>

Can't we just compare "A" and "P" width's and use that? Would spare 
creating two Date objects and two calls to Qt.formatTime


- Martin Klapetek


On March 8, 2016, 6:53 p.m., Daniel Faust wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127102/
> ---
> 
> (Updated March 8, 2016, 6:53 p.m.)
> 
> 
> Review request for kde-workspace and Plasma.
> 
> 
> Bugs: 347724
> https://bugs.kde.org/show_bug.cgi?id=347724
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> Currently the width of the date label is not fixed but changes depending on 
> the text. This causes the entire applet to change its width (if the time is 
> the widest displayed item). This in turn can cause all other applets in the 
> same panel to move whenever the displayed time changes.
> 
> This patch uses FontMetrics to iterate over all possible time strings (with 
> different width) and chooses the widest of them as reference for the fixed 
> width of the time label.
> 
> This way the width of the applet stays the same (unless the date is displayed 
> and changes). The text remains centered though, which means that it can still 
> move within the applet when the time changes.
> 
> 
> Diffs
> -
> 
>   applets/digital-clock/package/contents/ui/DigitalClock.qml 95bb071 
> 
> Diff: https://git.reviewboard.kde.org/r/127102/diff/
> 
> 
> Testing
> ---
> 
> Works with horizontal and vertical panel.
> Also displaying different combinations of "seconds", "date" and "timezone" 
> works.
> 
> 
> Thanks,
> 
> Daniel Faust
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[plasmashell] [Bug 360309] [Window List applet] add text field to widget for the panel

[Martin Klapetek via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=360309

Martin Klapetek <mklape...@kde.org> changed:

   What|Removed |Added

  Component|general |Window List
 CC||mklape...@kde.org
   Assignee|k...@davidedmundson.co.uk|plasma-devel@kde.org

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 127285: use QDBusConnectionInterface::serviceOwnerChanged to watch mpris2 service

[Martin Klapetek]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127285/#review93360
---


Ship it!




Ship It!

- Martin Klapetek


On March 5, 2016, 6:48 a.m., Xuetian Weng wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127285/
> ---
> 
> (Updated March 5, 2016, 6:48 a.m.)
> 
> 
> Review request for Plasma and Aleix Pol Gonzalez.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> Not sure if this is an intented upstream change (I reported it anyway 
> https://bugreports.qt.io/browse/QTBUG-51683 ), but QDBusServiceWatcher can't 
> watch all service anymore in Qt 5.6 RC with empty service name string.
> 
> Let's simple use the "deprecated" 
> QDBusConnectionInterface::serviceOwnerChanged signal to do this work, which 
> is also used by qdbusviewer.
> 
> Change mpris2 dataengine and systemtray to use 
> QDBusConnectionInterface::serviceOwnerChanged.
> 
> 
> Diffs
> -
> 
>   applets/systemtray/plugin/protocols/plasmoid/plasmoidprotocol.h 9e59501 
>   applets/systemtray/plugin/protocols/plasmoid/plasmoidprotocol.cpp 94c3efc 
>   dataengines/mpris2/mpris2engine.cpp 064ca60 
> 
> Diff: https://git.reviewboard.kde.org/r/127285/diff/
> 
> 
> Testing
> ---
> 
> mpris2 dataengine and mediacontroller now back to work with qt 5.6.
> 
> 
> Thanks,
> 
> Xuetian Weng
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel