Re: Freeze break request for polari

[Florian Müllner]

On Sat, Mar 7, 2020 at 21:14, Abderrahim Kitouni  
wrote:


Approval 2/2


Thanks!


___
release-team@gnome.org
https://mail.gnome.org/mailman/listinfo/release-team
Release-team lurker? Do NOT participate in discussions.

Re: Freeze break request for polari

[Abderrahim Kitouni]

Hi

Le sam. 7 mars 2020 à 20:20, Florian Müllner  a écrit :
>
> Hey again!
>
> I would like to include
> https://gitlab.gnome.org/GNOME/polari/-/merge_requests/147 in 3.36.0.

Approval 2/2
___
release-team@gnome.org
https://mail.gnome.org/mailman/listinfo/release-team
Release-team lurker? Do NOT participate in discussions.

Re: Freeze break request for polari

[Florian Müllner]

I got a private +1 from Michael.


On Sat, Mar 7, 2020 at 20:20, Florian Müllner  
wrote:

Hey again!

I would like to include 
https://gitlab.gnome.org/GNOME/polari/-/merge_requests/147 in 3.36.0.


The reason is that WebKit as shipped in the gnome-nightly runtime 
will fail if hardware acceleration isn't available, and the app 
hasn't explicitly disabled it.


That means that URL previews are no longer working in the nightly 
flatpak, and that's not what I'd like to ship in 3.36.0(*).


(I regret not pushing that MR earlier now, but as it didn't get rid 
of the "libEGL warning: wayland-egl: could not open /dev/dri/card0" 
warning, I assumed it had now effect)


Thanks, and enjoy the rest of your weekend
Florian

(*) to be fair though, there is a plan B: Release 3.36.0 as-is and 
include the patch in question in the flatpak. It's just more 
cumbersome than having it in the release :-)







___
release-team@gnome.org
https://mail.gnome.org/mailman/listinfo/release-team
Release-team lurker? Do NOT participate in discussions.

Re: Freeze break request for Epiphany

[Andre Klapper]

On Fri, 2020-03-06 at 18:31 -0600, Michael Catanzaro wrote:
> On Fri, Mar 6, 2020 at 5:24 pm, Javier Jardón wrote:
> > 1/2 for release team
>
> Thanks. Anybody else?

2/2 from release-team.

andre
--
Andre Klapper  |  ak...@gmx.net
https://blogs.gnome.org/aklapper/


___
release-team@gnome.org
https://mail.gnome.org/mailman/listinfo/release-team
Release-team lurker? Do NOT participate in discussions.

Re: Freeze break request for Epiphany

[Michael Catanzaro]

On Fri, Mar 6, 2020 at 5:24 pm, Javier Jardón  
wrote:

1/2 for release team


Thanks. Anybody else?


___
release-team@gnome.org
https://mail.gnome.org/mailman/listinfo/release-team
Release-team lurker? Do NOT participate in discussions.

Re: Freeze break request for glib-networking

[Javier Jardón]

2/2 for release team

On Fri, 6 Mar 2020 at 11:17, Andre Klapper  wrote:
>
> On Thu, 2020-03-05 at 15:43 -0600, Michael Catanzaro wrote:
> > I'd like to request a freeze break for:
> >
> > https://gitlab.gnome.org/GNOME/glib-networking/-/merge_requests/116
> >
> > which got committed during the freeze period. This just fixes a
> > non-void function that lacked a return value in an old fallback path
> > when compiling with the OpenSSL backend -- which should be disabled at
> > build time almost everywhere -- when using the ancient version of
> > OpenSSL in RHEL 6 era.
> >
> > This surely won't have any impact on anyone using GNOME 3.36, so say
> > yes please. :)
>
> Heh. +1 / yes please.
>
> andre
> --
> Andre Klapper  |  ak...@gmx.net
> https://blogs.gnome.org/aklapper/
>
>
> ___
> release-team@gnome.org
> https://mail.gnome.org/mailman/listinfo/release-team
> Release-team lurker? Do NOT participate in discussions.



-- 
Javier Jardón Cabezas
___
release-team@gnome.org
https://mail.gnome.org/mailman/listinfo/release-team
Release-team lurker? Do NOT participate in discussions.

Re: Freeze break request for glib-networking

[Andre Klapper]

On Thu, 2020-03-05 at 15:43 -0600, Michael Catanzaro wrote:
> I'd like to request a freeze break for:
>
> https://gitlab.gnome.org/GNOME/glib-networking/-/merge_requests/116
>
> which got committed during the freeze period. This just fixes a
> non-void function that lacked a return value in an old fallback path
> when compiling with the OpenSSL backend -- which should be disabled at
> build time almost everywhere -- when using the ancient version of
> OpenSSL in RHEL 6 era.
>
> This surely won't have any impact on anyone using GNOME 3.36, so say
> yes please. :)

Heh. +1 / yes please.

andre
--
Andre Klapper  |  ak...@gmx.net
https://blogs.gnome.org/aklapper/


___
release-team@gnome.org
https://mail.gnome.org/mailman/listinfo/release-team
Release-team lurker? Do NOT participate in discussions.

Re: Freeze break request for gnome-shell

[Emmanuele Bassi]

And approval 2/2.

Ciao,
Emmanuele.

On Mon, 2 Mar, 2020 at 09:11, Michael Catanzaro  
wrote:


Approval 1


___
release-team@gnome.org 

Release-team lurker? Do NOT participate in discussions.


___
release-team@gnome.org
https://mail.gnome.org/mailman/listinfo/release-team
Release-team lurker? Do NOT participate in discussions.

Re: Freeze break request for gnome-shell

[Michael Catanzaro]

Approval 1


___
release-team@gnome.org
https://mail.gnome.org/mailman/listinfo/release-team
Release-team lurker? Do NOT participate in discussions.

Re: freeze break request: clean up X property in at-spi2-core

[Emmanuele Bassi]

On , mcatanz...@gnome.org wrote:

On Sun, Sep 8, 2019 at 10:57 AM, Mike Gorse  wrote:

I don't
think that it would be the end of the world if this fix has to wait 
for
3.34.1, but, on the other hand, it fixes a regression introduced in 
the

3.34 cycle, so I'd lean towards committing it if people approve.


Well the purpose of the code freeze is to avoid introducing unexpected
regressions. Here we have a known regression, so it doesn't make sense
to not fix it IMO. Approval +1/2.


The fix is small, so approval 2/2.

Ciao,
 Emmanuele.
___
release-team@gnome.org
https://mail.gnome.org/mailman/listinfo/release-team
Release-team lurker? Do NOT participate in discussions.

Re: freeze break request: clean up X property in at-spi2-core

[mcatanzaro]

On Sun, Sep 8, 2019 at 10:57 AM, Mike Gorse  wrote:

I don't
think that it would be the end of the world if this fix has to wait 
for
3.34.1, but, on the other hand, it fixes a regression introduced in 
the

3.34 cycle, so I'd lean towards committing it if people approve.


Well the purpose of the code freeze is to avoid introducing unexpected 
regressions. Here we have a known regression, so it doesn't make sense 
to not fix it IMO. Approval +1/2.


Michael


___
release-team@gnome.org
https://mail.gnome.org/mailman/listinfo/release-team
Release-team lurker? Do NOT participate in discussions.

Re: Freeze break request: Tracker and Tracker-miners

[Matthias Clasen via release-team]

Approval 2/2

On Thu, Sep 5, 2019 at 1:03 PM  wrote:

>
> Looks fine, approval 1/2
>
>
> ___
> release-team@gnome.org
> https://mail.gnome.org/mailman/listinfo/release-team
> Release-team lurker? Do NOT participate in discussions.
>
___
release-team@gnome.org
https://mail.gnome.org/mailman/listinfo/release-team
Release-team lurker? Do NOT participate in discussions.

Re: Freeze break request: Tracker and Tracker-miners

[mcatanzaro]

Looks fine, approval 1/2


___
release-team@gnome.org
https://mail.gnome.org/mailman/listinfo/release-team
Release-team lurker? Do NOT participate in discussions.

Re: Freeze break request to fix gnome-initial-setup

[Matthias Clasen via release-team]

Approval 2/2

On Wed, Sep 4, 2019 at 11:14 AM  wrote:

>
> Approval +1 / 2 for both changes
>
>
> ___
> release-team@gnome.org
> https://mail.gnome.org/mailman/listinfo/release-team
> Release-team lurker? Do NOT participate in discussions.
>
___
release-team@gnome.org
https://mail.gnome.org/mailman/listinfo/release-team
Release-team lurker? Do NOT participate in discussions.

Re: Freeze break request to fix gnome-initial-setup

[mcatanzaro]

Approval +1 / 2 for both changes


___
release-team@gnome.org
https://mail.gnome.org/mailman/listinfo/release-team
Release-team lurker? Do NOT participate in discussions.

Re: freeze break request: use after free in at-spi2-core

[Emmanuele Bassi]

On , mcatanz...@gnome.org wrote:

On Tue, Sep 3, 2019 at 4:04 PM, Mike Gorse  wrote:

I need to fix a use after free in at-spi2-core. Patch attached. Sorry
everyone. Carelessness on my part.


It happens, here's approval 1 / 2


And here's the 2 / 2

Ciao,
 Emmanuele.
___
release-team@gnome.org
https://mail.gnome.org/mailman/listinfo/release-team
Release-team lurker? Do NOT participate in discussions.

Re: freeze break request: use after free in at-spi2-core

[mcatanzaro]

On Tue, Sep 3, 2019 at 4:04 PM, Mike Gorse  wrote:

I need to fix a use after free in at-spi2-core. Patch attached. Sorry
everyone. Carelessness on my part.


It happens, here's approval 1 / 2


___
release-team@gnome.org
https://mail.gnome.org/mailman/listinfo/release-team
Release-team lurker? Do NOT participate in discussions.

Re: Freeze break request for atk MR!14

[apinheiro]

Including Samuel and Joanmarie on the CC, as probably they are 
interested too on this change.


On 10/3/19 19:27, mcatanz...@gnome.org wrote:

On Sat, Mar 9, 2019 at 8:32 AM, apinheiro  wrote:

So although technically this is an API change, I think that it is
  really small, and the effect would be small, and I would like to
  include this on release .32.0


Hm, did GTK get fixed too? It looks like the answer is no? (I don't 
see any recent commits, nor even a merge request.)



Good point, I didn't check it. As the thread mentioned that LibreOffice 
was already returning -1, I assumed that GTK too. I just skimmed GTK 
implementation, and it relies on the internal GtkEditable, and return 0 
in some error case (like the original widget not being available anymore 
for such accessible object).


So being conservative, I withdraw this proposal, and lets try to fix it 
on the next cycle.


BR


___
release-team@gnome.org
https://mail.gnome.org/mailman/listinfo/release-team
Release-team lurker? Do NOT participate in discussions.

Re: Freeze break request for atk MR!14

[mcatanzaro]

On Sat, Mar 9, 2019 at 8:32 AM, apinheiro  wrote:

So although technically this is an API change, I think that it is
  really small, and the effect would be small, and I would like to
  include this on release .32.0


Hm, did GTK get fixed too? It looks like the answer is no? (I don't see 
any recent commits, nor even a merge request.)


Michael

___
release-team@gnome.org
https://mail.gnome.org/mailman/listinfo/release-team
Release-team lurker? Do NOT participate in discussions.

Re: Freeze break request for GNOME Shell

[Andre Klapper]

On Fri, 2019-03-08 at 13:53 -0600, mcatanz...@gnome.org wrote:
> +1 / 2

r-t approval 2 of 2

andre
-- 
Andre Klapper  |  ak...@gmx.net
https://blogs.gnome.org/aklapper/


___
release-team@gnome.org
https://mail.gnome.org/mailman/listinfo/release-team
Release-team lurker? Do NOT participate in discussions.

Re: Freeze break request for GNOME Shell

[mcatanzaro]

+1 / 2

___
release-team@gnome.org
https://mail.gnome.org/mailman/listinfo/release-team
Release-team lurker? Do NOT participate in discussions.

Re: Freeze break request for mutter!486

[Carlos Garnacho]

Hey,

On Fri, Mar 8, 2019 at 5:22 PM  wrote:
>
>
> +1 / 2
>
> This new fix is more code, which triggers my "risky last-minute commit"
> instincts, but I trust you're proposing it because you think it's safer
> than the originally-accepted solution, in light of the "other reported
> issues."

Thanks! that makes 2/2 with Emmanuele's :). The fix itself could have
been more self contained, cleaning up the then pointless
vfunc/argument added up a bit.

The previous fix solved animations/screenshots, but didn't help for
these later problems (running "XWAYLAND_NO_GLAMOR=1 mutter --wayland
--nested" and running a x11 app there should reproduce), this one
fixes both.

Cheers,
  Carlos

>
> Michael
>
___
release-team@gnome.org
https://mail.gnome.org/mailman/listinfo/release-team
Release-team lurker? Do NOT participate in discussions.

Re: Freeze break request for mutter!486

[mcatanzaro]

+1 / 2

This new fix is more code, which triggers my "risky last-minute commit" 
instincts, but I trust you're proposing it because you think it's safer 
than the originally-accepted solution, in light of the "other reported 
issues."


Michael

___
release-team@gnome.org
https://mail.gnome.org/mailman/listinfo/release-team
Release-team lurker? Do NOT participate in discussions.

Re: Freeze break request for Epiphany

[Tristan Van Berkom via release-team]

On Thu, 2019-03-07 at 06:16 +0100, Andre Klapper wrote:
> On Wed, 2019-03-06 at 21:48 -0600, mcatanz...@gnome.org wrote:
> > Hi,
> > 
> > I'd like to request a freeze break to fix a crash in Epiphany when 
> > opening the preferences dialog with certain languages configured:
> > 
> > https://gitlab.gnome.org/GNOME/epiphany/merge_requests/219/diffs
> 
> r-t approval 1 of 2.
> 

r-t approval 2 of 2.

___
release-team@gnome.org
https://mail.gnome.org/mailman/listinfo/release-team
Release-team lurker? Do NOT participate in discussions.

Re: Freeze break request for Epiphany

[Andre Klapper]

On Wed, 2019-03-06 at 21:48 -0600, mcatanz...@gnome.org wrote:
> Hi,
> 
> I'd like to request a freeze break to fix a crash in Epiphany when 
> opening the preferences dialog with certain languages configured:
> 
> https://gitlab.gnome.org/GNOME/epiphany/merge_requests/219/diffs

r-t approval 1 of 2.

andre
-- 
Andre Klapper  |  ak...@gmx.net
https://blogs.gnome.org/aklapper/


___
release-team@gnome.org
https://mail.gnome.org/mailman/listinfo/release-team
Release-team lurker? Do NOT participate in discussions.

Re: Freeze break request for gnome-shell

[verdre]

This is the appropriate fix, it's not going to get any better. But I understand 
if you don't want to ship it so close to the deadline.

Thanks,
verdre

> With 24 hours to go from the cut off deadline for 3.30, I don’t think this is 
> a good idea; this can wait for 3.30.1, and might as well use the appropriate 
> fix. Most distros will ship that version anyway.
> 
>  
> Ciao,
>  Emmanuele.
> 
> 
> On Sun, 2 Sep 2018 at 17:13, verdre < ver...@v0yd.nl> wrote: 
> > I have an alternative solution which would be more compatible with 
> >  changes we'll make in the future, could this one also get an approval? 
> >  
> >  It's even less intrusive than the other one since there's no need to 
> >  stop initially hiding the label. 
> >  
> >  https://gitlab.gnome.org/GNOME/gnome-shell/merge_requests/215 
> >  
> >  Thank you, 
> >  verdre 
> >  
> >  On 02.09.2018 02:37, mcatanz...@gnome.org wrote: 
> > > 
> > > I'll give a hesitant +1 to this one, since the change is small. 
> > > 
> > > If you consider it important enough for a 3.30.0 freeze break, rather 
> > > than waiting three weeks for 3.30.1, then it should also important 
> > > enough to backport to 3.28. It would be nice to see this fixed there too. 
> > > 
> > > Thanks for solving it, 
> > > 
> > > Michael 
> > > 
> >  ___ 
> >  release-team@gnome.org 
> >  https://mail.gnome.org/mailman/listinfo/release-team 
> >  Release-team lurker? Do NOT participate in discussions.
> 
> 
> -- 
> 
> https://www.bassi.io 
> [@] ebassi [@ [gmail.com](http://gmail.com)]
___
release-team@gnome.org
https://mail.gnome.org/mailman/listinfo/release-team
Release-team lurker? Do NOT participate in discussions.

Re: Freeze break request for gnome-shell

[Emmanuele Bassi via release-team]

With 24 hours to go from the cut off deadline for 3.30, I don’t think this
is a good idea; this can wait for 3.30.1, and might as well use the
appropriate fix. Most distros will ship that version anyway.

Ciao,
 Emmanuele.

On Sun, 2 Sep 2018 at 17:13, verdre  wrote:

> I have an alternative solution which would be more compatible with
> changes we'll make in the future, could this one also get an approval?
>
> It's even less intrusive than the other one since there's no need to
> stop initially hiding the label.
>
> https://gitlab.gnome.org/GNOME/gnome-shell/merge_requests/215
>
> Thank you,
> verdre
>
> On 02.09.2018 02:37, mcatanz...@gnome.org wrote:
> >
> > I'll give a hesitant +1 to this one, since the change is small.
> >
> > If you consider it important enough for a 3.30.0 freeze break, rather
> > than waiting three weeks for 3.30.1, then it should also important
> > enough to backport to 3.28. It would be nice to see this fixed there too.
> >
> > Thanks for solving it,
> >
> > Michael
> >
> ___
> release-team@gnome.org
> https://mail.gnome.org/mailman/listinfo/release-team
> Release-team lurker? Do NOT participate in discussions.
>
-- 
https://www.bassi.io
[@] ebassi [@gmail.com]
___
release-team@gnome.org
https://mail.gnome.org/mailman/listinfo/release-team
Release-team lurker? Do NOT participate in discussions.

Re: Freeze break request for gnome-shell

[verdre]

I have an alternative solution which would be more compatible with 
changes we'll make in the future, could this one also get an approval?


It's even less intrusive than the other one since there's no need to 
stop initially hiding the label.


https://gitlab.gnome.org/GNOME/gnome-shell/merge_requests/215

Thank you,
verdre

On 02.09.2018 02:37, mcatanz...@gnome.org wrote:


I'll give a hesitant +1 to this one, since the change is small.

If you consider it important enough for a 3.30.0 freeze break, rather 
than waiting three weeks for 3.30.1, then it should also important 
enough to backport to 3.28. It would be nice to see this fixed there too.


Thanks for solving it,

Michael


___
release-team@gnome.org
https://mail.gnome.org/mailman/listinfo/release-team
Release-team lurker? Do NOT participate in discussions.

Re: Freeze break request for gnome-shell

[Andre Klapper]

On Sat, 2018-09-01 at 08:43 -0500, mcatanz...@gnome.org wrote:
> I'm nervous about this one for three reasons:

Similar feelings here. Extremely happy to see progress but let's give
testing three weeks (3.30.0 to 3.30.1) instead of three days.

andre
-- 
Andre Klapper  |  ak...@gmx.net
https://blogs.gnome.org/aklapper/


___
release-team@gnome.org
https://mail.gnome.org/mailman/listinfo/release-team
Release-team lurker? Do NOT participate in discussions.

Re: Freeze break request for gnome-shell

[mcatanzaro]

I'm nervous about this one for three reasons:

* It's gjs, so any subtle flaw in this changeset could cause entire 
functions to be skipped over
* We're two days before the tarball deadline, so there's really no 
time left to notice if any such flaws were to sneak in

* It's also drag-and-drop code, which is tricky to get right

I would have given +1 to this if requested earlier this week, but at 
this point I'll be quite cautious and suggest committing immediately 
after 3.30.0, so that it has a couple weeks to bake it git before 
3.30.1, just in case.


I'm happy to see the invalid access warnings will be fixed. Almost as 
happy as I would be to see tweener fixes. :P


Michael

___
release-team@gnome.org
https://mail.gnome.org/mailman/listinfo/release-team
Release-team lurker? Do NOT participate in discussions.

Re: Freeze break request for GLib

[Philip Withnall]

On Thu, 2018-08-30 at 14:24 +0200, Andre Klapper wrote:
> On Thu, 2018-08-30 at 17:49 +0530, Nirbheek Chauhan wrote:
> > On Thu, Aug 30, 2018 at 5:44 PM Philip Withnall wrote:
> > > Impact: without this fix, any program using g_module_build_path()
> > > on
> > > macOS, with a GLib built using Meson, is going to fail to load
> > > its
> > > dynamically loaded modules. This may affect GStreamer and glib-
> > > networking.
> > 
> > This may also affect all projects that use libpeas (on macOS).
> > 
> > > The patch is safe because it makes the Meson behaviour identical
> > > to the
> > > long-established autotools behaviour.
> > 
> > I can vouch for this as well. We've been using this patch locally
> > for
> > GStreamer (in Cerbero) and it works well.
> 
> release-team approval 1 of 2.

Thanks ♥. Matthias gave release-team approval 2 of 2 on IRC, so I’ll go
ahead and merge the MR and start spinning a 2.58.0 release.

Philip

signature.asc
Description: This is a digitally signed message part
___
release-team@gnome.org
https://mail.gnome.org/mailman/listinfo/release-team
Release-team lurker? Do NOT participate in discussions.

Re: Freeze break request for GLib

[Andre Klapper]

On Thu, 2018-08-30 at 17:49 +0530, Nirbheek Chauhan wrote:
> On Thu, Aug 30, 2018 at 5:44 PM Philip Withnall wrote:
> > Impact: without this fix, any program using g_module_build_path() on
> > macOS, with a GLib built using Meson, is going to fail to load its
> > dynamically loaded modules. This may affect GStreamer and glib-
> > networking.
> 
> This may also affect all projects that use libpeas (on macOS).
> 
> > The patch is safe because it makes the Meson behaviour identical to the
> > long-established autotools behaviour.
> 
> I can vouch for this as well. We've been using this patch locally for
> GStreamer (in Cerbero) and it works well.

release-team approval 1 of 2.

andre
-- 
Andre Klapper  |  ak...@gmx.net
https://blogs.gnome.org/aklapper/


___
release-team@gnome.org
https://mail.gnome.org/mailman/listinfo/release-team
Release-team lurker? Do NOT participate in discussions.

Re: Freeze break request for GLib

[Nirbheek Chauhan via release-team]

On Thu, Aug 30, 2018 at 5:44 PM Philip Withnall  wrote:
> Impact: without this fix, any program using g_module_build_path() on
> macOS, with a GLib built using Meson, is going to fail to load its
> dynamically loaded modules. This may affect GStreamer and glib-
> networking.

This may also affect all projects that use libpeas (on macOS).

> The patch is safe because it makes the Meson behaviour identical to the
> long-established autotools behaviour.
>

I can vouch for this as well. We've been using this patch locally for
GStreamer (in Cerbero) and it works well.

Cheers,
Nirbheek
___
release-team@gnome.org
https://mail.gnome.org/mailman/listinfo/release-team
Release-team lurker? Do NOT participate in discussions.

Re: Freeze break request for libsoup

[mcatanzaro]

On Mon, Mar 12, 2018 at 5:32 AM, Matthias Clasen 
 wrote:

How about landing it right after the release, aiming for .1 ?


Sure, that seems fine at this point.

___
release-team@gnome.org
https://mail.gnome.org/mailman/listinfo/release-team
Release-team lurker? Do NOT participate in discussions.

Re: Freeze break request for libsoup

[Matthias Clasen]

On Mon, Mar 12, 2018 at 4:15 AM, Claudio Saavedra 
wrote:

> On Sun, 2018-03-11 at 12:26 -0400, Matthias Clasen wrote:
> > but nobody ever wants notifications from websites.
>
> Is that really a r-t worthy answer to a freeze break request?
>

This was a whimsical way to request clarification on what is actually
affected by this. Sorry

Wrt to the patch itself, I am a bit hesitant to say yes on the day of the
.0 release
to a patch that has caused problems before, is not a 1-liner, and applies
to a library
that is used quite widely deep inside our stack.

How about landing it right after the release, aiming for .1 ?
___
release-team@gnome.org
https://mail.gnome.org/mailman/listinfo/release-team
Release-team lurker? Do NOT participate in discussions.

Re: Freeze break request for libsoup

[Claudio Saavedra]

On Sun, 2018-03-11 at 12:26 -0400, Matthias Clasen wrote:
> but nobody ever wants notifications from websites.

Is that really a r-t worthy answer to a freeze break request?

If you have a concern with Ephy's policy regarding notifications, you
are free to bring it up in the context of epiphany. This one is a wider
issue in libsoup that happens to break Google's notifications, but it
surely affects other websites as well.

Claudio



___
release-team@gnome.org
https://mail.gnome.org/mailman/listinfo/release-team
Release-team lurker? Do NOT participate in discussions.

Re: Freeze break request for libsoup

[mcatanzaro]

On Sun, Mar 11, 2018 at 11:26 AM, Matthias Clasen 
 wrote:

but nobody ever wants notifications from websites.


Currently, if are signed in with a Google account and click the 
notification bubble on google.com, it takes ages to load, and 
eventually gives up with an error. Please test it. The problem is 
caused because our third-party cookie policy is too strict. Since we 
block third-party cookies by default, we need to follow the lead of the 
only other browser that does so, Safari, and consider only the 
website's base domain and not the full domain when deciding whether a 
cookie is third-party.


This has nothing to do with desktop notifications, which have separate 
permissions to prevent users from becoming annoyed. Google doesn't 
create desktop notifications anyway.


___
release-team@gnome.org
https://mail.gnome.org/mailman/listinfo/release-team
Release-team lurker? Do NOT participate in discussions.

Re: Freeze break request for libsoup

[Matthias Clasen]

but nobody ever wants notifications from websites.

On Sun, Mar 11, 2018 at 12:04 PM,  wrote:

>
> Hi,
>
> This one would be really nice to land, if we could get a second approval.
> I don't see much point in waiting until the .1 to loosen up our cookie
> policy. Thanks!
>
> Michael
>
>
> ___
> release-team@gnome.org
> https://mail.gnome.org/mailman/listinfo/release-team
> Release-team lurker? Do NOT participate in discussions.
>
___
release-team@gnome.org
https://mail.gnome.org/mailman/listinfo/release-team
Release-team lurker? Do NOT participate in discussions.

Re: Freeze break request for libsoup

[mcatanzaro]

Hi,

This one would be really nice to land, if we could get a second 
approval. I don't see much point in waiting until the .1 to loosen up 
our cookie policy. Thanks!


Michael

___
release-team@gnome.org
https://mail.gnome.org/mailman/listinfo/release-team
Release-team lurker? Do NOT participate in discussions.

Re: Freeze break request for mutter

[Florian Müllner]

On Fri, Mar 9, 2018 at 8:05 PM, Michael Catanzaro  wrote:
> Approval 2 of 2, but I recommend reverting this on master as well to make
> sure it doesn't slip into 3.30 by mistake.

Good point, but no worries - we haven't branched yet and I'll release
3.28.0 from master :-)

Thanks everyone,
Florian
___
release-team@gnome.org
https://mail.gnome.org/mailman/listinfo/release-team
Release-team lurker? Do NOT participate in discussions.

Re: Freeze break request for mutter

[Michael Catanzaro]

On Fri, Mar 9, 2018 at 7:05 AM, Andre Klapper  wrote:

r-t approval 1 of 2.


Approval 2 of 2, but I recommend reverting this on master as well to 
make sure it doesn't slip into 3.30 by mistake. Branches are cheap. :)


Michael

___
release-team@gnome.org
https://mail.gnome.org/mailman/listinfo/release-team
Release-team lurker? Do NOT participate in discussions.

Re: Freeze break request for mutter

[Andre Klapper]

On Fri, 2018-03-09 at 12:24 +0100, Florian Müllner wrote:
> Hey everyone!
> 
> As you may know, the tiling improvements in 3.26 involved a grouping
> behavior that turned out rather unpopular, and after some discussion
> we decided that the feature needed more work to be actually useful
> and
> reverted the change on the stable branch:
> 
> https://gitlab.gnome.org/GNOME/mutter/commit/415584344a5d4b5
> 
> Our idea was to refine the grouping behavior this cycle, but in the
> end it didn't happen. So I would like to apply that revert to the
> upcoming 3.28.0 release as well.
> 
> I'm sorry this slipped into the hard code freeze period, I should
> have remembered this before :-(

r-t approval 1 of 2.

andre
-- 
Andre Klapper  |  ak...@gmx.net
http://blogs.gnome.org/aklapper/
___
release-team@gnome.org
https://mail.gnome.org/mailman/listinfo/release-team
Release-team lurker? Do NOT participate in discussions.

Re: Freeze break request

[Andre Klapper]

On Tue, 2018-03-06 at 15:26 +0900, Tristan Van Berkom wrote:
> On Mon, 2018-03-05 at 12:51 -0600, mcatanz...@gnome.org wrote:
> > The following commit fixes a buffer overflow in epiphany's tests:
> > 
> > https://git.gnome.org/browse/epiphany/commit/?id=0ad97baa47cd13c955e0873e52cf03b84ad4a620
> > 
> > May I backport it to the gnome-3-28 branch?
> 
> +1
> -Tristan

And another +1.

andre
-- 
Andre Klapper  |  ak...@gmx.net
http://blogs.gnome.org/aklapper/
___
release-team@gnome.org
https://mail.gnome.org/mailman/listinfo/release-team
Release-team lurker? Do NOT participate in discussions.

Re: Freeze break request

[Tristan Van Berkom]

On Mon, 2018-03-05 at 12:51 -0600, mcatanz...@gnome.org wrote:
> Hi,
> 
> The following commit fixes a buffer overflow in epiphany's tests:
> 
> https://git.gnome.org/browse/epiphany/commit/?id=0ad97baa47cd13c955e0
> 873e52cf03b84ad4a620
> 
> May I backport it to the gnome-3-28 branch?

+1

Cheers,
-Tristan

___
release-team@gnome.org
https://mail.gnome.org/mailman/listinfo/release-team
Release-team lurker? Do NOT participate in discussions.

Re: Freeze break request for gnome-shell

[Michael Catanzaro]

This looks pretty self-contained, and I presume you originally sent the 
request a week and a half ago when we were earlier in the cycle. So +1 
of 2 from me.


Michael

___
release-team@gnome.org
https://mail.gnome.org/mailman/listinfo/release-team
Release-team lurker? Do NOT participate in discussions.

Re: Freeze break request for gnome-shell

[Rui Tiago Cação Matos]

[ Re-sending since it seems this didn't make it to the release team list ]

> Hi,
>
> I'd like to request a freeze break request for this gnome-shell UI addition:
>
> https://bugzilla.gnome.org/show_bug.cgi?id=783550 - it's basically an
> Alt+Tab style switcher to cycle through multi-monitor configurations
> on laptops.
>
> Thanks,
> Rui
___
release-team@gnome.org
https://mail.gnome.org/mailman/listinfo/release-team
Release-team lurker? Do NOT participate in discussions.

Re: Freeze break request: GJS memory leak fix

[philip . chimento]

OK, thank you for the responses. It's pushed now.

On Sat, Mar 18, 2017, 15:47 Michael Catanzaro  wrote:

> On Sat, 2017-03-18 at 01:17 +, Javier Jardón wrote:
> > A bit late in the cycle but the issue seems important enough and the
> > patch seems simple enough
> >
> > 1/2 for release team
>
> 2/2
>
___
release-team@gnome.org
https://mail.gnome.org/mailman/listinfo/release-team
Release-team lurker? Do NOT participate in discussions.

Re: Freeze break request: GJS memory leak fix

[Michael Catanzaro]

On Sat, 2017-03-18 at 01:17 +, Javier Jardón wrote:
> A bit late in the cycle but the issue seems important enough and the
> patch seems simple enough
> 
> 1/2 for release team

2/2
___
release-team@gnome.org
https://mail.gnome.org/mailman/listinfo/release-team
Release-team lurker? Do NOT participate in discussions.

Re: Freeze break request: GJS memory leak fix

[Javier Jardón]

On 17 Mar 2017 19:41,  wrote:

Hi release team,

I'd like to request a break of the hard code freeze for
https://bugzilla.gnome.org/show_bug.cgi?id=780171. This is a fix for a
memory leak in GJS which has been present in the code since February 15.

I'm the maintainer of GJS, and I am comfortable committing it. It does not
break API, change any features, or change any strings.

The memory leak was spotted by Luke Jones yesterday and brought to my
attention with a Valgrind log. Both Luke and Hussam Al-Tayeb have confirmed
that the fix prevents GNOME Shell from leaking hundreds of megabytes of
memory per hour. Therefore, I believe this fix is necessary to improve the
stability of the GNOME 3.24 release.

Cosimo Cecchi has reviewed the patch and Florian Müllner already reviewed a
previous version. Due to the short time, it has not undergone extensive
testing, but I have been running GJS with the patch since yesterday. In
addition, the fix is in a function that is called thousands of times during
a run of GJS's test suite. I have determined this using code coverage
tools. So if it were going to cause crashes, it would be apparent, and by
this method I did already discover and fix a mistake in an earlier version
of the patch. (The tests don't yet cover all the function's exits, but the
uncovered paths are exceptional and unlikely to come up in normal usage.)

Best,
Philip C

Patch follows:
>From 9050118c9e77849a29d0193aea8f710038bfd5fa Mon Sep 17 00:00:00 2001
From: Philip Chimento 
Date: Thu, 16 Mar 2017 15:43:09 -0700
Subject: [PATCH] object: Fix memory leak in resolve

The "name" string, allocated in gjs_get_string_id(), wasn't getting freed
at every exit point of the function. (It will be nice to clean this up in
1.49.x with our autoptr classes...)

After a certain point in the function it's not needed, so we just free
the string there.

https://bugzilla.gnome.org/show_bug.cgi?id=780171
---
 gi/object.cpp | 15 +++
 1 file changed, 11 insertions(+), 4 deletions(-)

diff --git a/gi/object.cpp b/gi/object.cpp
index c68ad4c6..63731df5 100644
--- a/gi/object.cpp
+++ b/gi/object.cpp
@@ -607,7 +607,7 @@ is_vfunc_unchanged(GIVFuncInfo *info,

 static GIVFuncInfo *
 find_vfunc_on_parents(GIObjectInfo *info,
-  gchar*name,
+  const char   *name,
   bool *out_defined_by_parent)
 {
 GIVFuncInfo *vfunc = NULL;
@@ -774,12 +774,14 @@ object_instance_resolve(JSContext   *context,
  * rest.
  */

-gchar *name_without_vfunc_ = [6];
+const char *name_without_vfunc_ = [6];  /* lifetime tied to
name */
 GIVFuncInfo *vfunc;
 bool defined_by_parent;

 vfunc = find_vfunc_on_parents(priv->info, name_without_vfunc_,
_by_parent);
 if (vfunc != NULL) {
+g_free(name);
+
 /* In the event that the vfunc is unchanged, let regular
  * prototypal inheritance take over. */
 if (defined_by_parent && is_vfunc_unchanged(vfunc,
priv->gtype)) {
@@ -818,8 +820,13 @@ object_instance_resolve(JSContext   *context,
  * this could be done better.  See
  * https://bugzilla.gnome.org/show_bug.cgi?id=632922
  */
-if (method_info == NULL)
-return object_instance_resolve_no_info(context, obj, resolved,
priv, name);
+if (method_info == NULL) {
+bool retval = object_instance_resolve_no_info(context, obj,
resolved, priv, name);
+g_free(name);
+return retval;
+}
+
+g_free(name);

 #if GJS_VERBOSE_ENABLE_GI_USAGE
 _gjs_log_info_usage((GIBaseInfo*) method_info);


A bit late in the cycle but the issue seems important enough and the patch
seems simple enough

1/2 for release team

Cheers,
Javier
___
release-team@gnome.org
https://mail.gnome.org/mailman/listinfo/release-team
Release-team lurker? Do NOT participate in discussions.

Re: Freeze break request for polari

[Michael Catanzaro]

On Fri, 2017-03-17 at 01:20 +0100, Andre Klapper wrote:
> r-t approval 1 of 2.

2/2

I was suspicious that the gjs upgrades seemed to have gone a little too
smoothly. ;)

Michael
___
release-team@gnome.org
https://mail.gnome.org/mailman/listinfo/release-team
Release-team lurker? Do NOT participate in discussions.

Re: Freeze break request for polari

[Andre Klapper]

On Thu, 2017-03-16 at 22:17 +, Florian Müllner wrote:
> I would like to request a freeze break for https://bugzilla.gnome.org
> /show_bug.cgi?id=780166. It is unfortunate that I only uncovered the
> bug after code freeze, but then the issue is quite sneaky:
> Gjs was updated to a more recent version of the mozjs library which
> dropped some functions that were proposed-but-rejected for the Ecma
> standard. It turns out we are using one of those in Polari, and as a
> result the '/help' command no longer works. The attached patch fixes
> the issue by replacing the removed function with a standardized
> replacement - it is a one-line change that fixes the command, so I
> would like to get it in for the release.

r-t approval 1 of 2.

andre
-- 
Andre Klapper  |  ak...@gmx.net
http://blogs.gnome.org/aklapper/
___
release-team@gnome.org
https://mail.gnome.org/mailman/listinfo/release-team
Release-team lurker? Do NOT participate in discussions.

Re: freeze break request: invalid escape sequence in pyatspi

[Mike Gorse]

THanks all. I'll commit and close the bug.

On Tue, 14 Mar 2017, Matthias Clasen wrote:


+1 from me as well

On Tue, Mar 14, 2017 at 12:31 PM, Michael Catanzaro  
wrote:
  On Tue, 2017-03-14 at 10:13 -0500, Mike Gorse wrote:
  > This is trivial: pyatspi has an invalid escape sequence, which
  > generates a 
  > deprecation warning in Python 3.6. I've tested the change on my
  > system 
  > (which has python 3.4) and didn't see any obvious regressions.

  +1

  Michael
  ___
  release-team@gnome.org
  https://mail.gnome.org/mailman/listinfo/release-team
  Release-team lurker? Do NOT participate in discussions.



___
release-team@gnome.org
https://mail.gnome.org/mailman/listinfo/release-team
Release-team lurker? Do NOT participate in discussions.

Re: freeze break request: invalid escape sequence in pyatspi

[Michael Catanzaro]

On Tue, 2017-03-14 at 10:13 -0500, Mike Gorse wrote:
> This is trivial: pyatspi has an invalid escape sequence, which
> generates a 
> deprecation warning in Python 3.6. I've tested the change on my
> system 
> (which has python 3.4) and didn't see any obvious regressions.

+1

Michael
___
release-team@gnome.org
https://mail.gnome.org/mailman/listinfo/release-team
Release-team lurker? Do NOT participate in discussions.

Re: Freeze break request - printer panel layout

[Michael Catanzaro]

On Thu, 2017-03-09 at 08:59 -0500, Matthias Clasen wrote:
> I must say I had a hard time spotting the differences at first, so
> this seems subtle enough to not cause any problems.
> 
> +1

Indeed, this is your second +1.

Michael
___
release-team@gnome.org
https://mail.gnome.org/mailman/listinfo/release-team
Release-team lurker? Do NOT participate in discussions.

Re: Freeze break request - printer panel layout

[Matthias Clasen]

I must say I had a hard time spotting the differences at first, so this
seems subtle enough to not cause any problems.

+1

On Thu, Mar 9, 2017 at 7:33 AM, Allan Day  wrote:

> Hi all,
>
> I'd like to request a freeze break for bug 779700 [1]. It's a small set of
> layout tweaks, which doesn't affect functionality and doesn't' include any
> string changes. You can see the difference in the attached screenshots.
>
> Thanks,
>
> Allan
>
> [1] https://bugzilla.gnome.org/show_bug.cgi?id=779700
>
> ___
> release-team@gnome.org
> https://mail.gnome.org/mailman/listinfo/release-team
> Release-team lurker? Do NOT participate in discussions.
>
___
release-team@gnome.org
https://mail.gnome.org/mailman/listinfo/release-team
Release-team lurker? Do NOT participate in discussions.

Re: Freeze break request for gnome-shell

[Javier Jardón]

On 28 Feb 2017 19:02, "Florian Müllner"  wrote:

On Tue, Feb 28, 2017 at 7:52 PM Matthias Clasen 
wrote:

> we don't have much else to show in that area, this cycle...maybe thats me
> wearing a marketing rather than rel-eng hat
>

I was afraid of mentioning the 'm' word, but that was indeed a main
motivator behind the push for finishing up those branches

___
gnome-doc-list mailing list
gnome-doc-l...@gnome.org
https://mail.gnome.org/mailman/listinfo/gnome-doc-list


2/2 for release team
___
release-team@gnome.org
https://mail.gnome.org/mailman/listinfo/release-team
Release-team lurker? Do NOT participate in discussions.

Re: Freeze break request for gnome-shell

[Florian Müllner]

On Tue, Feb 28, 2017 at 7:52 PM Matthias Clasen 
wrote:

> we don't have much else to show in that area, this cycle...maybe thats me
> wearing a marketing rather than rel-eng hat
>

I was afraid of mentioning the 'm' word, but that was indeed a main
motivator behind the push for finishing up those branches
___
release-team@gnome.org
https://mail.gnome.org/mailman/listinfo/release-team
Release-team lurker? Do NOT participate in discussions.

Re: Freeze break request for gnome-shell

[Michael Catanzaro]

On Tue, 2017-02-28 at 13:06 -0500, Matthias Clasen wrote:
> On Tue, Feb 28, 2017 at 12:49 PM, Florian Müllner  g> wrote:
> > 
> > In my opinion, both items make for some nice polish improvements in
> > that area with low risk (the weather section is very isolated, and
> > the
> > visual refresh is mostly a style update), so they would make for a
> > good (while late) 3.24 addition.
> 
> I concur. +1 for the release team from me. 

I'm torn. I like the changes too: it looks like a good improvement. But
it's a pretty major UI change in a significant component of the desktop
shell, and going in very late in the release cycle. I'd prefer to save
it for 3.26 to give users more time to comment on the change. So I
won't give +1 myself, but I also won't block it if someone else wants
to give the second +1.

Michael
___
release-team@gnome.org
https://mail.gnome.org/mailman/listinfo/release-team
Release-team lurker? Do NOT participate in discussions.

Re: Freeze break request for gnome-shell

[Matthias Clasen]

On Tue, Feb 28, 2017 at 12:49 PM, Florian Müllner 
wrote:

>
>
> In my opinion, both items make for some nice polish improvements in
> that area with low risk (the weather section is very isolated, and the
> visual refresh is mostly a style update), so they would make for a
> good (while late) 3.24 addition.
>

I concur. +1 for the release team from me.
___
release-team@gnome.org
https://mail.gnome.org/mailman/listinfo/release-team
Release-team lurker? Do NOT participate in discussions.

Re: Freeze break request for mutter

[Matthias Clasen]

I just remembered that I actually added api for this a while ago, for anaconda:

gtk_get_locale_direction
___
release-team@gnome.org
https://mail.gnome.org/mailman/listinfo/release-team
Release-team lurker? Do NOT participate in discussions.

Re: Freeze break request for mutter

[Michael Catanzaro]

On Mon, 2016-09-19 at 17:27 +, Florian Müllner wrote:
> (*) besides bringing back the entire translation infrastructure for a
> single string - though I'm not sure multiple translation domains per
> module
> are even supported

You could just have a list of which locales should use RTL?
___
release-team@gnome.org
https://mail.gnome.org/mailman/listinfo/release-team
Release-team lurker? Do NOT participate in discussions.

Re: Freeze break request for mutter

[Florian Müllner]

On Mon, Sep 19, 2016 at 4:39 PM Matthias Clasen 
wrote:

> On Mon, Sep 19, 2016 at 7:14 AM, Andre Klapper  wrote:
>
> > After applying the patch, correct gnome-shell behavior in RTL languages
> > depends on the proper translation of one string in GTK+ for those
> > languages?
>
> Well, gtk uses this approach for its own rtl support. And it has been
> working ok for many years. I guess the only slightly objectionable
> thing here is to use this implementation detail of GTK+ in another
> module.
>

Right, The only alternative I can think of(*) is linking with GTK+ and
making the mutter-clutter API a wrapper around
gtk_widget_get_default_direction(). Not great either, though I guess it
doesn't really matter, given that gtk+ is already a dependency of mutter ...


(*) besides bringing back the entire translation infrastructure for a
single string - though I'm not sure multiple translation domains per module
are even supported
___
release-team@gnome.org
https://mail.gnome.org/mailman/listinfo/release-team
Release-team lurker? Do NOT participate in discussions.

Re: Freeze break request for mutter and gnome-shell

[Matthias Clasen]

On Mon, Sep 19, 2016 at 9:59 AM, Andre Klapper  wrote:
> On Mon, 2016-09-19 at 18:32 +0200, Rui Tiago Cação Matos wrote:
>> I'd like to request a freeze break request for these 2 simple fixes:
>>
>> gnome-shell crash when taking screenshots in wayland sessions:
>> https://bugzilla.gnome.org/show_bug.cgi?id=771656
>>
>> mutter wrongly offsetting area screenshots:
>> https://bugzilla.gnome.org/show_bug.cgi?id=771502
>
> r-t approval 1 of 2.

second approval.
___
release-team@gnome.org
https://mail.gnome.org/mailman/listinfo/release-team
Release-team lurker? Do NOT participate in discussions.

Re: Freeze break request for mutter and gnome-shell

[Andre Klapper]

On Mon, 2016-09-19 at 18:32 +0200, Rui Tiago Cação Matos wrote:
> I'd like to request a freeze break request for these 2 simple fixes:
> 
> gnome-shell crash when taking screenshots in wayland sessions:
> https://bugzilla.gnome.org/show_bug.cgi?id=771656
> 
> mutter wrongly offsetting area screenshots:
> https://bugzilla.gnome.org/show_bug.cgi?id=771502

r-t approval 1 of 2.

andre
-- 
Andre Klapper  |  ak...@gmx.net
http://blogs.gnome.org/aklapper/
___
release-team@gnome.org
https://mail.gnome.org/mailman/listinfo/release-team
Release-team lurker? Do NOT participate in discussions.

Re: Freeze break request: Network panel "default gateway" fixes

[Raphael Hertzog]

Hi Bastien,

On Fri, 16 Sep 2016, Bastien Nocera wrote:
> Scattered in a couple of bugs:
> https://bugzilla.gnome.org/show_bug.cgi?id=771515
> https://bugzilla.gnome.org/show_bug.cgi?id=765969
> https://bugzilla.gnome.org/show_bug.cgi?id=771538
> 
> I did some testing, and it seemed to work as expected. Rafael, could
> you test it as well?

I did not realize at first that "Rafael" was me (since my name is Raphaël)
:-)

I just tested the two for patches for
https://bugzilla.gnome.org/show_bug.cgi?id=771515 and they work fine here.

Cheers,
-- 
Raphaël Hertzog ◈ Debian Developer

Support Debian LTS: http://www.freexian.com/services/debian-lts.html
Learn to master Debian: http://debian-handbook.info/get/
___
release-team@gnome.org
https://mail.gnome.org/mailman/listinfo/release-team
Release-team lurker? Do NOT participate in discussions.

Re: Freeze break request for mutter

[Matthias Clasen]

On Mon, Sep 19, 2016 at 7:14 AM, Andre Klapper  wrote:
> On Mon, 2016-09-19 at 14:12 +0200, Frederic Peters wrote:
>> Florian Müllner wrote:
>> I'd like to request (yet another) freeze break for mutter, namely
>> > the patch in
>> > https://bugzilla.gnome.org/show_bug.cgi?id=771549.
>>
>> Ok, first approval. Fred
>

Approval 2/2

> After applying the patch, correct gnome-shell behavior in RTL languages
> depends on the proper translation of one string in GTK+ for those
> languages?

Well, gtk uses this approach for its own rtl support. And it has been
working ok for many years. I guess the only slightly objectionable
thing here is to use this implementation detail of GTK+ in another
module.
___
release-team@gnome.org
https://mail.gnome.org/mailman/listinfo/release-team
Release-team lurker? Do NOT participate in discussions.

Re: Freeze break request for mutter

[Andre Klapper]

On Mon, 2016-09-19 at 14:12 +0200, Frederic Peters wrote:
> Florian Müllner wrote:
> I'd like to request (yet another) freeze break for mutter, namely
> > the patch in
> > https://bugzilla.gnome.org/show_bug.cgi?id=771549.
> 
> Ok, first approval. Fred

After applying the patch, correct gnome-shell behavior in RTL languages
depends on the proper translation of one string in GTK+ for those
languages?

Probably good as a workaround, hence r-t approval 2 of 2. 

I hope there are plans to fix this properly?

andre
-- 
Andre Klapper  |  ak...@gmx.net
http://blogs.gnome.org/aklapper/
___
release-team@gnome.org
https://mail.gnome.org/mailman/listinfo/release-team
Release-team lurker? Do NOT participate in discussions.

Re: Freeze break request for mutter

[Frederic Peters]

Hi Florian,

Florian Müllner wrote:

> I'd like to request (yet another) freeze break for mutter, namely the patch
> in
> https://bugzilla.gnome.org/show_bug.cgi?id=771549.

Ok, first approval.


Fred
___
release-team@gnome.org
https://mail.gnome.org/mailman/listinfo/release-team
Release-team lurker? Do NOT participate in discussions.

Re: Freeze break request for gnome-shell

[Frederic Peters]

Hi Florian,

Michael Catanzaro wrote:
> On Fri, 2016-09-16 at 17:01 +, Florian Müllner wrote:
> > The two remaining patches fix glitches when selecting a hidden window
> > - it
> > is odd to switch to a window and have it disappear briefly before
> > animating
> > back in, so I would still like to see an exception for them as well.
> > Those
> > glitches only show up temporarily during the finishing animation
> > though, so
> > fixing them isn't quite as urgent as the first issue (in case you'd
> > rather
> > keep that part for .1)
> 
> r-t 1/2 for all of them

2 of 2, let's get those in for 3.22.0.



Fred
___
release-team@gnome.org
https://mail.gnome.org/mailman/listinfo/release-team
Release-team lurker? Do NOT participate in discussions.

Re: Freeze break request: Network panel "default gateway" fixes

[Frederic Peters]

Hi Bastien,

Michael Catanzaro wrote:
> On Fri, 2016-09-16 at 17:24 +0200, Bastien Nocera wrote:
> > Hey,
> > 
> > Scattered in a couple of bugs:
> > https://bugzilla.gnome.org/show_bug.cgi?id=771515
> > https://bugzilla.gnome.org/show_bug.cgi?id=765969
> > https://bugzilla.gnome.org/show_bug.cgi?id=771538
> > 
> > I did some testing, and it seemed to work as expected. Rafael, could
> > you test it as well?
> 
> r-t 1/2, [...]

2 of 2.


Fred
___
release-team@gnome.org
https://mail.gnome.org/mailman/listinfo/release-team
Release-team lurker? Do NOT participate in discussions.

Re: Freeze break request #2 for mutter

[Andre Klapper]

On Fri, 2016-09-16 at 11:35 -0500, Michael Catanzaro wrote:
> On Fri, 2016-09-16 at 23:35 +0800, Jonas Ådahl wrote:
> > I have another freeze break request for mutter. This time it's a crash
> > fix for a race with a very safe patch fixing it (just a NULL check).
> 
> r-t 1/2
> Michael

r-t approval 2 of 2.
andre
-- 
Andre Klapper  |  ak...@gmx.net
http://blogs.gnome.org/aklapper/
___
release-team@gnome.org
https://mail.gnome.org/mailman/listinfo/release-team
Release-team lurker? Do NOT participate in discussions.

Re: Freeze break request for gnome-shell

[Michael Catanzaro]

On Fri, 2016-09-16 at 17:01 +, Florian Müllner wrote:
> The two remaining patches fix glitches when selecting a hidden window
> - it
> is odd to switch to a window and have it disappear briefly before
> animating
> back in, so I would still like to see an exception for them as well.
> Those
> glitches only show up temporarily during the finishing animation
> though, so
> fixing them isn't quite as urgent as the first issue (in case you'd
> rather
> keep that part for .1)

r-t 1/2 for all of them

IMO it's safer to throw these all into .0 and fix in .1 if there is an
unexpected regression, rather than introduce a regression in .1 and
have it broken until .2. But let's hope for no regression. ;)

Michael
___
release-team@gnome.org
https://mail.gnome.org/mailman/listinfo/release-team
Release-team lurker? Do NOT participate in discussions.

Re: Freeze break request: Network panel "default gateway" fixes

[Michael Catanzaro]

On Fri, 2016-09-16 at 17:24 +0200, Bastien Nocera wrote:
> Hey,
> 
> Scattered in a couple of bugs:
> https://bugzilla.gnome.org/show_bug.cgi?id=771515
> https://bugzilla.gnome.org/show_bug.cgi?id=765969
> https://bugzilla.gnome.org/show_bug.cgi?id=771538
> 
> I did some testing, and it seemed to work as expected. Rafael, could
> you test it as well?

r-t 1/2, but please investigate whether these should be backported to
3.20 and plan to do a new release on that branch next week as well; I
see a lot of fixes piling up there. I guess these network fixes are
probably only desired for 3.22, but the power fixes in your other
thread look like 3.20 material.

Michael
___
release-team@gnome.org
https://mail.gnome.org/mailman/listinfo/release-team
Release-team lurker? Do NOT participate in discussions.

Re: Freeze break request: Power panel" fixes

[Michael Catanzaro]

On Fri, 2016-09-16 at 17:48 +0200, Bastien Nocera wrote:
> Hey,
> 
> Scattered in a couple of bugs:
> https://bugzilla.gnome.org/show_bug.cgi?id=771543
> https://bugzilla.gnome.org/show_bug.cgi?id=771542
> https://bugzilla.gnome.org/show_bug.cgi?id=771532
> 
> Cheers

r-t 1/2, though I left a couple nits in Bugzilla
___
release-team@gnome.org
https://mail.gnome.org/mailman/listinfo/release-team
Release-team lurker? Do NOT participate in discussions.

Re: Freeze break request #2 for mutter

[Michael Catanzaro]

On Fri, 2016-09-16 at 23:35 +0800, Jonas Ådahl wrote:
> I have another freeze break request for mutter. This time it's a
> crash
> fix for a race with a very safe patch fixing it (just a NULL check).

r-t 1/2

Michael
___
release-team@gnome.org
https://mail.gnome.org/mailman/listinfo/release-team
Release-team lurker? Do NOT participate in discussions.

Re: Freeze break request for libgnomekbd

[Rui Tiago Cação Matos]

On Wed, Sep 14, 2016 at 7:13 PM, Michael Catanzaro  wrote:
> Who wants to make a new release? Can you take it Rui?

Yes, incoming.

Thanks for the acks!

Rui
___
release-team@gnome.org
https://mail.gnome.org/mailman/listinfo/release-team
Release-team lurker? Do NOT participate in discussions.

Re: Freeze break request for libgnomekbd

[Michael Catanzaro]

On Wed, 2016-09-14 at 15:39 +0200, Rui Tiago Cação Matos wrote:
> I'm including all the other cleanups in this request since they're
> trivial enough and libgnomekbd hasn't had a release since 3.6.0 .

Who wants to make a new release? Can you take it Rui?

Michael
___
release-team@gnome.org
https://mail.gnome.org/mailman/listinfo/release-team
Release-team lurker? Do NOT participate in discussions.

Re: Freeze break request for mutter

[Michael Catanzaro]

On Wed, 2016-09-14 at 09:21 -0400, Matthias Clasen wrote:
> Those patches all look good to me. In particular the rotation fix is
> important to claim Wayland feature-completeness, so +1 from me for
> the
> release team.

+2
___
release-team@gnome.org
https://mail.gnome.org/mailman/listinfo/release-team
Release-team lurker? Do NOT participate in discussions.

Re: Freeze break request for libgnomekbd

[Andre Klapper]

On Wed, 2016-09-14 at 09:49 -0400, Matthias Clasen wrote:
> +1 from me.

r-t approval 2 of 2.

And likely irrelevant; just pointing out:
https://git.gnome.org/browse/libgnomekbd/commit/?h=wip/rtcm/cleanups=3f4de28962fa73fdc784c8b4057128b195b5c06c
states "It's not needed with modern gtk+" (to be exact, it's deprecated
since GTK+ 3.14), however configure.ac still keeps "GTK_REQUIRED=2.90".
But I guess noone's going to try a brand new libgnomekbd with an
ancient GTK (& not even sure /if/ that'd actually create any issue).

andre
-- 
Andre Klapper  |  ak...@gmx.net
http://blogs.gnome.org/aklapper/
___
release-team@gnome.org
https://mail.gnome.org/mailman/listinfo/release-team
Release-team lurker? Do NOT participate in discussions.

Re: Freeze break request for libgnomekbd

[Matthias Clasen]

+1 from me.
___
release-team@gnome.org
https://mail.gnome.org/mailman/listinfo/release-team
Release-team lurker? Do NOT participate in discussions.

Re: Freeze break request for mutter

[Matthias Clasen]

On Wed, Sep 14, 2016 at 8:04 AM, Jonas Ådahl  wrote:
> Hi,
>
> I'd like to request freeze breaks for 5 (five) Wayland related bugs.
>
> One is a feature bug fix, one avoids possibly aborting valid (GTK+)
> clients, and three are crash fixes. I'm listing them below:
>
> Fix output rotation of not-left-most monitors on Wayland:
> https://bugzilla.gnome.org/show_bug.cgi?id=770672
>
> Fix crash happening with pointer warp emulated Xwayland (needs the
> xserver patches on xorg-devel to reproduce):
> https://bugzilla.gnome.org/show_bug.cgi?id=771345
>
> Crash fix for Xdnd interoperability race condition:
> https://bugzilla.gnome.org/show_bug.cgi?id=770940
>
> Don't disconnect (i.e. effectively abort) valid dnd clients when hitting
> race condition:
> https://bugzilla.gnome.org/show_bug.cgi?id=770937
>
> Crash fix for mapping popups on systems without pointer device:
> https://bugzilla.gnome.org/show_bug.cgi?id=771305
>

Those patches all look good to me. In particular the rotation fix is
important to claim Wayland feature-completeness, so +1 from me for the
release team.
___
release-team@gnome.org
https://mail.gnome.org/mailman/listinfo/release-team
Release-team lurker? Do NOT participate in discussions.

Re: Freeze break request for gnome-shell

[Matthias Clasen]

Approval 2/2

On Tue, Sep 13, 2016 at 6:26 PM, Michael Catanzaro  wrote:
> On Tue, 2016-09-13 at 21:27 +, Florian Müllner wrote:
>> I'm sorry I didn't catch this before the freeze. It turns out gnome-
>> shell's
>> extension-prefs tool is another victim of GTK+'s ScrolledWindow
>> changes
>> this cycle:
>
> Approval 1/2
> ___
> release-team@gnome.org
> https://mail.gnome.org/mailman/listinfo/release-team
> Release-team lurker? Do NOT participate in discussions.
___
release-team@gnome.org
https://mail.gnome.org/mailman/listinfo/release-team
Release-team lurker? Do NOT participate in discussions.

Re: Freeze break request for gnome-shell

[Michael Catanzaro]

On Tue, 2016-09-13 at 21:27 +, Florian Müllner wrote:
> I'm sorry I didn't catch this before the freeze. It turns out gnome-
> shell's
> extension-prefs tool is another victim of GTK+'s ScrolledWindow
> changes
> this cycle:

Approval 1/2
___
release-team@gnome.org
https://mail.gnome.org/mailman/listinfo/release-team
Release-team lurker? Do NOT participate in discussions.

Re: Freeze break request for polari

[Florian Müllner]

On Mon, Aug 29, 2016 at 3:49 PM Alexandre Franke  wrote:

> On Mon, Aug 29, 2016 at 3:33 PM, Florian Müllner 
> > There are a couple of string additions though:
>
> We're in string change announcement period, so we'll take this as such
> an announcement. Thanks!
>

Yeah, sorry for not being clearer about this - I was lazy about sending out
two separate mails, so I included the string changes to make the
announcement to i18n.
___
release-team@gnome.org
https://mail.gnome.org/mailman/listinfo/release-team
Release-team lurker? Do NOT participate in discussions.

Re: Freeze break request for polari

[Alexandre Franke]

On Mon, Aug 29, 2016 at 3:33 PM, Florian Müllner  wrote:
> Hey folks,

Hi Florian!

> Both cases are strict additions that are displayed in response to user
> action, not modification of existing elements, so the change has no effect
> on screenshots/documentation.
>
> There are a couple of string additions though:

String freeze only starts from the 3.21.91 release, coming this week,
so you don't need a string freeze exception for this. You only need 2
approvals from release team.

We're in string change announcement period, so we'll take this as such
an announcement. Thanks!

>  - a description to identify the saved password in gnome-keyring
>("Polari NickServ password for FreeNode")
>  - the infobar title ("Should the password be saved?"), subtitle
>   ("Identification will happen automatically the next time you connect to
> GNOME")
>   and button ("_Save Password")
>  - the notification title ("Save NickServ password for GNOME?") and body
>(same as infobar subtitle) and button ("Save")


-- 
Alexandre Franke
GNOME Hacker & Foundation Director
___
release-team@gnome.org
https://mail.gnome.org/mailman/listinfo/release-team
Release-team lurker? Do NOT participate in discussions.

Re: Freeze break request: Session crashing when triggering visual bell: bug 763858

[Frederic Peters]

Hi Jonas,

Michael Catanzaro wrote:
> On Mon, 2016-03-21 at 09:47 +0800, Jonas Ådahl wrote:
> > I'd like to merge the patch in
> > https://bugzilla.gnome.org/show_bug.cgi?id=763858 . The fix itself I
> > consider completely safe, and the symptom of not merging it I
> > consider
> > severe. Therefore I'd like to have this fix in before 3.20.
> 
> +1 from release team

seconded.


Fred
___
release-team@gnome.org
https://mail.gnome.org/mailman/listinfo/release-team
Release-team lurker? Do NOT participate in discussions.

Re: Freeze break request: Session crashing when triggering visual bell: bug 763858

[Michael Catanzaro]

On Mon, 2016-03-21 at 09:47 +0800, Jonas Ådahl wrote:
> I'd like to merge the patch in
> https://bugzilla.gnome.org/show_bug.cgi?id=763858 . The fix itself I
> consider completely safe, and the symptom of not merging it I
> consider
> severe. Therefore I'd like to have this fix in before 3.20.

+1 from release team
___
release-team@gnome.org
https://mail.gnome.org/mailman/listinfo/release-team
Release-team lurker? Do NOT participate in discussions.

Re: Freeze break request for gvfs (iOS support)

[Matthias Clasen]

On Sat, Mar 19, 2016 at 8:31 AM, Bastien Nocera  wrote:

> I didn't receive any feedback on this, so I guess people don't care
> that much for this niche feature.

Sorry, I was travelling. Here's a retroactive +1

> Patches are pushed so that we can start moving forward from the status
> quo.

Thanks for taking care of this code.
___
release-team@gnome.org
https://mail.gnome.org/mailman/listinfo/release-team
Release-team lurker? Do NOT participate in discussions.

Re: Freeze break request for Videos (totem)

[Michael Catanzaro]

On Wed, 2016-03-16 at 13:07 -0400, Matthias Clasen wrote:
> I see it ! I'm afraid there will be quite a bit of this minor level
> theme fallout in applications - the theme has been essentially
> rewritten.
> 
> Patch looks harmless, +1 for the release team.

2/2
___
release-team@gnome.org
https://mail.gnome.org/mailman/listinfo/release-team
Release-team lurker? Do NOT participate in discussions.

Re: Freeze break request for gnome-control-center and gnome-desktop

[Alexandre Franke]

Hi,

On Thu, Mar 17, 2016 at 12:57 PM, Bastien Nocera  wrote:
> One that adds a simple new function to gnome-desktop, one to add the
> "Refresh Rate" drop-down to the display dialogue (which adds a new
> string), and one to reduce the number of confusing frequencies from the
> list (which adds 2 new strings that are unlikely to be translated for
> most languages).

Here's 1/2 from i18n.

-- 
Alexandre Franke
GNOME Hacker & Foundation Director
___
release-team@gnome.org
https://mail.gnome.org/mailman/listinfo/release-team
Release-team lurker? Do NOT participate in discussions.

Re: Freeze break request for GNOME Nibbles

[Frederic Peters]

Michael Catanzaro wrote:

> I'd like to push the Nibbles patches in these i18n bugs:
> 
> https://bugzilla.gnome.org/show_bug.cgi?id=763905
> https://bugzilla.gnome.org/show_bug.cgi?id=763906
> 
> The first patch adds a few colors ("red" "green" "blue" "yellow" "cyan"
> "purple") as new translatable strings. Apologies for the very late
> string additions; the strings are already displayed in the UI, but not
> currently marked for translation.

Marking existing strings as translatable is not a freeze break.


Fred
___
release-team@gnome.org
https://mail.gnome.org/mailman/listinfo/release-team
Release-team lurker? Do NOT participate in discussions.

Re: Freeze break request for gnome-control-center and gnome-desktop

[Daniel Mustieles García]

2/2 from i18n

2016-03-17 13:01 GMT+01:00 Alexandre Franke :

> Hi,
>
> On Thu, Mar 17, 2016 at 12:57 PM, Bastien Nocera 
> wrote:
> > One that adds a simple new function to gnome-desktop, one to add the
> > "Refresh Rate" drop-down to the display dialogue (which adds a new
> > string), and one to reduce the number of confusing frequencies from the
> > list (which adds 2 new strings that are unlikely to be translated for
> > most languages).
>
> Here's 1/2 from i18n.
>
> --
> Alexandre Franke
> GNOME Hacker & Foundation Director
> ___
> gnome-i18n mailing list
> gnome-i...@gnome.org
> https://mail.gnome.org/mailman/listinfo/gnome-i18n
>
___
release-team@gnome.org
https://mail.gnome.org/mailman/listinfo/release-team
Release-team lurker? Do NOT participate in discussions.

Re: Freeze break request for gvfs (iOS support)

[Bastien Nocera]

On Fri, 2016-03-18 at 16:34 +0100, Bastien Nocera wrote:
> These patches:
> https://bugzilla.gnome.org/show_bug.cgi?id=763606
> fix regressions accessing files on recent iOS versions.
> 
> I tested the fixes, and will cherry pick them to older versions of
> gvfs
> as well.
> 
> I should note though, that I seem to be the only person using this
> functionality[1], at least recently, so if I have free reign for this
> piece of code, I'd like to also commit some other fixes[2] I have for
> the iOS support. Ondrej seems to be happy letting me handle this, as
> he
> doesn't have hardware to test it.

I didn't receive any feedback on this, so I guess people don't care
that much for this niche feature.

Patches are pushed so that we can start moving forward from the status
quo.

Cheers
___
release-team@gnome.org
https://mail.gnome.org/mailman/listinfo/release-team
Release-team lurker? Do NOT participate in discussions.

Re: Freeze break request for polari

[Matthias Clasen]

I've commented on the patch in the first bug, with a request for clarification

On Fri, Mar 18, 2016 at 11:27 AM, Florian Müllner  wrote:
> Hey,
>
> I'd like to push the fix in
> https://bugzilla.gnome.org/show_bug.cgi?id=763872. It's a minor and
> straight-forward code change that fixes a fairly confusing issue:
>
>  (1) we don't remove accounts immediately, but hide them from the UI
>   and show an undo notification for some time; currently the account
>   stays around hidden when the window is closed while the notification
>   is still showing
>
>  (2) the network list ( [+] -> Add Network ) doesn't allow to add networks
>  that have already been added, they are insensitive and marked as
>  "Already added"
>
> The bug in (1) means that we can end up with "zombie" accounts, which is
> already bad enough. However in combination with (2), those hidden accounts
> prevent the user from re-adding the network in question.
>
>
> Now that I'm already requesting a freeze break, I'll throw in
> https://bugzilla.gnome.org/show_bug.cgi?id=763873 as well. This is purely a
> polish issue on non-GNOME systems (or when gnome-settings-daemon crashes):
> GtkApplicationWindow:show-menubar cannot be set from .ui files when using
> templates, so we end up with two fallback app menus (in both the headerbar
> and the menubar) in those cases. I'd include the fix because it is trivial,
> but considering that it usually doesn't affect GNOME, I wouldn't mind either
> to wait for 3.20.1 ...
>
>
> --- Florian
>
> ___
> release-team@gnome.org
> https://mail.gnome.org/mailman/listinfo/release-team
> Release-team lurker? Do NOT participate in discussions.
___
release-team@gnome.org
https://mail.gnome.org/mailman/listinfo/release-team
Release-team lurker? Do NOT participate in discussions.

Re: Freeze break request for Videos (totem)

[Matthias Clasen]

On Wed, Mar 16, 2016 at 11:32 AM, Bastien Nocera  wrote:
> This patch:
> https://bugzilla.gnome.org/show_bug.cgi?id=763264
> fixes a regression in the appearance of the play/pause/previous/next
> buttons in totem to match what it was in GNOME 3.18.
>
> Get your magnifying glasses out:
> https://bug763264.bugzilla-attachments.gnome.org/attachment.cgi?id=324114

I see it ! I'm afraid there will be quite a bit of this minor level
theme fallout in applications - the theme has been essentially
rewritten.

Patch looks harmless, +1 for the release team.
___
release-team@gnome.org
https://mail.gnome.org/mailman/listinfo/release-team
Release-team lurker? Do NOT participate in discussions.

Re: Freeze break request for gnome-control-center and gnome-desktop

[Matthias Clasen]

Since the translators are ok with it, here is +1 of 2 for the release team

On Thu, Mar 17, 2016 at 8:28 AM, Daniel Mustieles García
 wrote:
> 2/2 from i18n
>
> 2016-03-17 13:01 GMT+01:00 Alexandre Franke :
>>
>> Hi,
>>
>> On Thu, Mar 17, 2016 at 12:57 PM, Bastien Nocera 
>> wrote:
>> > One that adds a simple new function to gnome-desktop, one to add the
>> > "Refresh Rate" drop-down to the display dialogue (which adds a new
>> > string), and one to reduce the number of confusing frequencies from the
>> > list (which adds 2 new strings that are unlikely to be translated for
>> > most languages).
>>
>> Here's 1/2 from i18n.
>>
>> --
>> Alexandre Franke
>> GNOME Hacker & Foundation Director
>> ___
>> gnome-i18n mailing list
>> gnome-i...@gnome.org
>> https://mail.gnome.org/mailman/listinfo/gnome-i18n
>
>
>
> ___
> gnome-doc-list mailing list
> gnome-doc-l...@gnome.org
> https://mail.gnome.org/mailman/listinfo/gnome-doc-list
>
___
release-team@gnome.org
https://mail.gnome.org/mailman/listinfo/release-team
Release-team lurker? Do NOT participate in discussions.

Re: Freeze break request for gnome-control-center and gnome-desktop

[Frederic Peters]

Matthias Clasen wrote:
> Since the translators are ok with it, here is +1 of 2 for the release team

ditto.


Fred
___
release-team@gnome.org
https://mail.gnome.org/mailman/listinfo/release-team
Release-team lurker? Do NOT participate in discussions.

Re: Freeze break request for polari

[Florian Müllner]

On Fri, Mar 18, 2016 at 7:16 PM Matthias Clasen 
wrote:

> I notice that this category of bug (undo notification + quit) has
> shown up more than once recently (I've seen it in boxes too)
>

Right, seeing the gnome-boxes discussion on IRC was what made me test and
fix the issue in Polari.
___
release-team@gnome.org
https://mail.gnome.org/mailman/listinfo/release-team
Release-team lurker? Do NOT participate in discussions.

Re: Freeze break request for polari

[Matthias Clasen]

+1 from the release team for the revised patch.

I notice that this category of bug (undo notification + quit) has
shown up more than once recently (I've seen it in boxes too)

On Fri, Mar 18, 2016 at 11:40 AM, Matthias Clasen
 wrote:
> I've commented on the patch in the first bug, with a request for clarification
>
> On Fri, Mar 18, 2016 at 11:27 AM, Florian Müllner  wrote:
>> Hey,
>>
>> I'd like to push the fix in
>> https://bugzilla.gnome.org/show_bug.cgi?id=763872. It's a minor and
>> straight-forward code change that fixes a fairly confusing issue:
>>
>>  (1) we don't remove accounts immediately, but hide them from the UI
>>   and show an undo notification for some time; currently the account
>>   stays around hidden when the window is closed while the notification
>>   is still showing
>>
>>  (2) the network list ( [+] -> Add Network ) doesn't allow to add networks
>>  that have already been added, they are insensitive and marked as
>>  "Already added"
>>
>> The bug in (1) means that we can end up with "zombie" accounts, which is
>> already bad enough. However in combination with (2), those hidden accounts
>> prevent the user from re-adding the network in question.
>>
>>
>> Now that I'm already requesting a freeze break, I'll throw in
>> https://bugzilla.gnome.org/show_bug.cgi?id=763873 as well. This is purely a
>> polish issue on non-GNOME systems (or when gnome-settings-daemon crashes):
>> GtkApplicationWindow:show-menubar cannot be set from .ui files when using
>> templates, so we end up with two fallback app menus (in both the headerbar
>> and the menubar) in those cases. I'd include the fix because it is trivial,
>> but considering that it usually doesn't affect GNOME, I wouldn't mind either
>> to wait for 3.20.1 ...
>>
>>
>> --- Florian
>>
>> ___
>> release-team@gnome.org
>> https://mail.gnome.org/mailman/listinfo/release-team
>> Release-team lurker? Do NOT participate in discussions.
___
release-team@gnome.org
https://mail.gnome.org/mailman/listinfo/release-team
Release-team lurker? Do NOT participate in discussions.

Re: freeze break request for gsettings-desktop-schemas and gnome-settings-daemon

[Michael Catanzaro]

On Mon, 2016-03-07 at 12:02 -0500, Shaun McCance wrote:
> Will WebKit pick this up automatically, or should I teach Yelp to
> honor
> this setting?

We can teach WebKit to honor the setting, it's not something that Yelp
should have to worry about.
___
release-team@gnome.org
https://mail.gnome.org/mailman/listinfo/release-team
Release-team lurker? Do NOT participate in discussions.