Re: Create new review remote API
On Fri June 12 2009 19:11:15 Christopher wrote: hg requestreview -m Made some great new changes to component Foo For Mercurial, you can evaluate this HG extension: http://freehg.org/u/roccoblues/mercurial-reviewboard/ Regards. Gilles. --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard group. To post to this group, send email to reviewboard@googlegroups.com To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -~--~~~~--~~--~--~---
Re: (A solution) 404 error when using reviewboard with lighttpd
On Wed, Jun 10, 2009 at 11:57 PM, joseph.pnc joseph@gmail.com wrote: And this line: ^(/.*)$ = /reviewboard.fcgi/$1, to this: ^(/.*)$ = /reviewboard.fcgi/$1, Hmm, I don't see a difference between these two lines. Am I missing it? Christian -- Christian Hammond - chip...@chipx86.com Review Board - http://www.review-board.org VMware, Inc. - http://www.vmware.com --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard group. To post to this group, send email to reviewboard@googlegroups.com To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -~--~~~~--~~--~--~---
Re: post-review under clearcase / HOW TO ?
Can you submit this to http://reviews.review-board.org/? All patches should go through there for review. Christian -- Christian Hammond - chip...@chipx86.com Review Board - http://www.review-board.org VMware, Inc. - http://www.vmware.com On Mon, May 25, 2009 at 3:54 AM, Bartlomiej Celary bartlomiej.cel...@gmail.com wrote: I had this problem as well few months ago. Following patch to post-review should resolve it (attached). I had to fix some permissions in order to get rid of temp files + the '\n' (or \r?) was not stripped from the argument and also split_lines option was needed in a execute call. I don't remember if I reached the point of actually posting a review though as I had not much time to play with clearcase+reviewboard :) Regards, Bartek Celary 2009/5/25 mahesh forvai...@gmail.com: post-review under clearcase / HOW TO ? Hi, I have set up a django based review-board (i.e. without apache / mod_python) and it came up well. I would like to post-review from another client where I've installed RBTools (latest version_ I am in clearcase dynamic view and in vob path .. example /vobs/src/tmp_vob/tools and checked out build.ksh and I am issuing following command to make it diff from predecessor version and CHECKEDOUT version to RB as if posted by an admin user. Command - post-review --server=http://mvaidya-inl:8000 --username=admin -- password=admin build.ksh Please advise me if command usage is correct and I am getting this errors for now File /home/mvaidya/EGG-INFO/scripts/post-review, line 938, in diff return self.do_diff(self.get_extended_namespace(files)) File /home/mvaidya/EGG-INFO/scripts/post-review, line 802, in get_extended_namespace versions = self.get_previous_version(files) File /home/mvaidya/EGG-INFO/scripts/post-review, line 781, in get_previous_version [cleartool, desc, -pre, elem_path]) ValueError: too many values to unpack --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard group. To post to this group, send email to reviewboard@googlegroups.com To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -~--~~~~--~~--~--~---
Re: django.core.exceptions.ImproperlyConfigured: MySQLdb-1.2.1p2 or newer is required; you have 1.2.1
Sometimes a distro will have Apache configured with one version of Python (say, 2.4) while /usr/bin/python is 2.5. I've seen this on a RHEL5 machine, though it's possible that's because someone installed a newer Python. What's the site-packages path containing the new MySQLdb? Also, do you see the old one installed in that site-packages? And did you restart the web server after upgrading this? Christian -- Christian Hammond - chip...@chipx86.com Review Board - http://www.review-board.org VMware, Inc. - http://www.vmware.com On Tue, Jun 2, 2009 at 5:54 AM, Josh Joy joshjd...@gmail.com wrote: I'm not entirely sure what that means? How do I now which Python is running Review Board? I'm just using the one under bin...I have a fresh install of CentOS...so I'm not seeing multiple versions of Python... Thanks, Josh On Tue, Jun 2, 2009 at 12:08 AM, Christian Hammond chip...@chipx86.com wrote: Make sure you installed the new MySQLdb using the same version of Python that's running Review Board. Christian -- Christian Hammond - chip...@chipx86.com Review Board - http://www.review-board.org VMware, Inc. - http://www.vmware.com On Mon, Jun 1, 2009 at 7:26 PM, joshjdevl joshjd...@gmail.com wrote: Hi, What exactly did you install for drivers that reoslved the issue? I'm still receiving ImproperlyConfigured: MySQLdb-1.2.1p2 or newer is required; you have 1.2.1, though I have 1.2.2 installed and in my site-package Thanks, Josh On Apr 7, 1:40 pm, Mohamed Mansour m0.interact...@gmail.com wrote: I had to install new drivers for python. Thanks! On Apr 7, 1:36 pm, Mohamed Mansour m0.interact...@gmail.com wrote: Sorry, I forgot to say that I am using Red Hat Enterprise 5, on a new server. + On Apr 7, 1:35 pm, Mohamed Mansour m0.interact...@gmail.com wrote: Hello, I am getting errors while running the tool: rb-site install /var/www/reviews.example.com I have created the database, but have the following issues, any help is appreciated: * Installing the site... Building site directories ... OK Building site configuration files ... OK Creating database ... Traceback (most recent call last): File /usr/bin/rb-site, line 5, in ? pkg_resources.run_script('ReviewBoard==1.0beta2', 'rb-site') File /usr/lib/python2.4/site-packages/pkg_resources.py, line 448, in run_script self.require(requires)[0].run_script(script_name, ns) File /usr/lib/python2.4/site-packages/pkg_resources.py, line 1166, in run_script execfile(script_filename, namespace, namespace) File /usr/lib/python2.4/site-packages/ReviewBoard-1.0beta2- py2.4.egg/EGG-INFO/scripts/rb-site, line 1280, in ? main(sys.argv[1:]) File /usr/lib/python2.4/site-packages/ReviewBoard-1.0beta2- py2.4.egg/EGG-INFO/scripts/rb-site, line 1275, in main command.run() File /usr/lib/python2.4/site-packages/ReviewBoard-1.0beta2- py2.4.egg/EGG-INFO/scripts/rb-site, line 912, in run self.show_install_status() File /usr/lib/python2.4/site-packages/ReviewBoard-1.0beta2- py2.4.egg/EGG-INFO/scripts/rb-site, line 1134, in show_install_status site.sync_database) File /usr/lib/python2.4/site-packages/ReviewBoard-1.0beta2- py2.4.egg/EGG-INFO/scripts/rb-site, line 519, in step func() File /usr/lib/python2.4/site-packages/ReviewBoard-1.0beta2- py2.4.egg/EGG-INFO/scripts/rb-site, line 224, in sync_database self.run_manage_command(syncdb, [--noinput]) File /usr/lib/python2.4/site-packages/ReviewBoard-1.0beta2- py2.4.egg/EGG-INFO/scripts/rb-site, line 261, in run_manage_command fix_django_evolution_issues(reviewboard.settings) File /usr/lib/python2.4/site-packages/ReviewBoard-1.0beta2- py2.4.egg/reviewboard/admin/migration.py, line 13, in fix_django_evolution_issues import django.db.models.fields as model_fields File /usr/lib/python2.4/site-packages/Django-1.0.2_final-py2.4.egg/ django/db/__init__.py, line 16, in ? backend = __import__('%s%s.base' % (_import_path, settings.DATABASE_ENGINE), {}, {}, ['']) File /usr/lib/python2.4/site-packages/Django-1.0.2_final-py2.4.egg/ django/db/backends/mysql/base.py, line 22, in ? raiseImproperlyConfigured(MySQLdb-1.2.1p2 or newer is required; you have %s % Database.__version__) django.core.exceptions.ImproperlyConfigured:MySQLdb-1.2.1p2 or newer is required; you have 1.2.1 --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard group. To post to this group, send email to reviewboard@googlegroups.com To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this
Re: Report application name to Perforce using -zprog?
So this would allow for reporting progress on, say, file fetches from Perforce? Something like that would be interesting for displaying progresses on rendering diffs, but would be a lot of work. We'd need to find a good use case for it and implement things in a way where our code could take advantage of this information without requiring (for all the other SCMs). Christian -- Christian Hammond - chip...@chipx86.com Review Board - http://www.review-board.org VMware, Inc. - http://www.vmware.com On Thu, Apr 9, 2009 at 4:35 PM, Paul Scott psc...@vmware.com wrote: Hey Review Boarders, My team uses the -zprog global option with a few major internal scripts/applications to help better track usage patterns. (If you're unfamiliar with -zprog, you can read about it here: http://kb.perforce.com/AdminTasks/SuperuserTasks/UsingTheZpro..erProcesses). I was thinking about adding this to our Review Board and post-review. How/where I implement this will be a little bit different based on whether this is a customization or something I intend to submit as a patch, so I wanted to see if this is something folks would like Review Board to do, or not like Review Board to do, or what. Thanks, Paul Scott --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard group. To post to this group, send email to reviewboard@googlegroups.com To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -~--~~~~--~~--~--~---
Review Board 1.0 RC3 released
Hi everyone, I've just put out a release of 1.0 RC3, which should actually be the final RC as long as nothing else blows up. I plan to release 1.0 next weekend. If people would test this release this week and make sure nothing is newly broken in your installs, it would REALLY help us out! Details on the release can be found at http://www.review-board.org/news/2009/06/13/review-board-10-rc3-released/ Christian -- Christian Hammond - chip...@chipx86.com Review Board - http://www.review-board.org VMware, Inc. - http://www.vmware.com --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard group. To post to this group, send email to reviewboard@googlegroups.com To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -~--~~~~--~~--~--~---
RE: Report application name to Perforce using -zprog?
Hmm... I don't know about that. I mean, if you really wanted to try and stick unique identifiers in your p4 commands so you could track which ones were currently pending, I guess you could, but I assume your Perforce administrators would get cranky at you. ;) Also, I don't really know how feasible that would be for showing progress... I mean, all you get from monitor is what processes are still alive, and how long they've been running. Maybe I misunderstood where you were going with that. The main purpose of throwing in a -zprog is just to make things a little prettier on the Perforce side. It lets you identify your application to the server, so logs and monitor output will display that instead of a generic p4 (for post-review) or whatever the p4 python api reports (for Review Board). Mostly this is just a way of playing nice in the general Perforce environment. Though this might also allow RB admins who also have access to Perforce server logs to get a better sense of how they are affecting or being affected by Perforce performance. (There may be other ways of identifying Review Board in logs depending on your configuration--user, RB server IP--though probably not for post-review). This wouldn't be a huge change (just tack that on to p4 commands, and set something in the p4python connection object) and I would think the only major reason not to do it is if people didn't really want Review Board reported as reviewboard or similar in their Perforce logs. -- Paul From: reviewboard@googlegroups.com [reviewbo...@googlegroups.com] On Behalf Of Christian Hammond [chip...@chipx86.com] Sent: Saturday, June 13, 2009 4:32 PM To: reviewboard@googlegroups.com Subject: Re: Report application name to Perforce using -zprog? So this would allow for reporting progress on, say, file fetches from Perforce? Something like that would be interesting for displaying progresses on rendering diffs, but would be a lot of work. We'd need to find a good use case for it and implement things in a way where our code could take advantage of this information without requiring (for all the other SCMs). Christian -- Christian Hammond - chip...@chipx86.commailto:chip...@chipx86.com Review Board - http://www.review-board.org VMware, Inc. - http://www.vmware.com On Thu, Apr 9, 2009 at 4:35 PM, Paul Scott psc...@vmware.commailto:psc...@vmware.com wrote: Hey Review Boarders, My team uses the -zprog global option with a few major internal scripts/applications to help better track usage patterns. (If you're unfamiliar with -zprog, you can read about it here: http://kb.perforce.com/AdminTasks/SuperuserTasks/UsingTheZpro..erProcesses). I was thinking about adding this to our Review Board and post-review. How/where I implement this will be a little bit different based on whether this is a customization or something I intend to submit as a patch, so I wanted to see if this is something folks would like Review Board to do, or not like Review Board to do, or what. Thanks, Paul Scott --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard group. To post to this group, send email to reviewboard@googlegroups.com To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -~--~~~~--~~--~--~---
Re: Report application name to Perforce using -zprog?
I don't see any reason why we shouldn't do this. Accountability is a good thing. -David On Sat, Jun 13, 2009 at 8:41 PM, Paul Scottpsc...@vmware.com wrote: Hmm... I don't know about that. I mean, if you really wanted to try and stick unique identifiers in your p4 commands so you could track which ones were currently pending, I guess you could, but I assume your Perforce administrators would get cranky at you. ;) Also, I don't really know how feasible that would be for showing progress... I mean, all you get from monitor is what processes are still alive, and how long they've been running. Maybe I misunderstood where you were going with that. The main purpose of throwing in a -zprog is just to make things a little prettier on the Perforce side. It lets you identify your application to the server, so logs and monitor output will display that instead of a generic p4 (for post-review) or whatever the p4 python api reports (for Review Board). Mostly this is just a way of playing nice in the general Perforce environment. Though this might also allow RB admins who also have access to Perforce server logs to get a better sense of how they are affecting or being affected by Perforce performance. (There may be other ways of identifying Review Board in logs depending on your configuration--user, RB server IP--though probably not for post-review). This wouldn't be a huge change (just tack that on to p4 commands, and set something in the p4python connection object) and I would think the only major reason not to do it is if people didn't really want Review Board reported as reviewboard or similar in their Perforce logs. -- Paul From: reviewboard@googlegroups.com [reviewbo...@googlegroups.com] On Behalf Of Christian Hammond [chip...@chipx86.com] Sent: Saturday, June 13, 2009 4:32 PM To: reviewboard@googlegroups.com Subject: Re: Report application name to Perforce using -zprog? So this would allow for reporting progress on, say, file fetches from Perforce? Something like that would be interesting for displaying progresses on rendering diffs, but would be a lot of work. We'd need to find a good use case for it and implement things in a way where our code could take advantage of this information without requiring (for all the other SCMs). Christian -- Christian Hammond - chip...@chipx86.commailto:chip...@chipx86.com Review Board - http://www.review-board.org VMware, Inc. - http://www.vmware.com On Thu, Apr 9, 2009 at 4:35 PM, Paul Scott psc...@vmware.commailto:psc...@vmware.com wrote: Hey Review Boarders, My team uses the -zprog global option with a few major internal scripts/applications to help better track usage patterns. (If you're unfamiliar with -zprog, you can read about it here: http://kb.perforce.com/AdminTasks/SuperuserTasks/UsingTheZpro..erProcesses). I was thinking about adding this to our Review Board and post-review. How/where I implement this will be a little bit different based on whether this is a customization or something I intend to submit as a patch, so I wanted to see if this is something folks would like Review Board to do, or not like Review Board to do, or what. Thanks, Paul Scott --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard group. To post to this group, send email to reviewboard@googlegroups.com To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -~--~~~~--~~--~--~---
Issue 1166 in reviewboard: view diff failed for files contain Mac newline char (i.e. CR \r) -- use SVN client
Updates: Status: NeedInfo Comment #2 on issue 1166 by chipx86: view diff failed for files contain Mac newline char (i.e. CR \r) -- use SVN client http://code.google.com/p/reviewboard/issues/detail?id=1166 Would you mind upgrading to the nightly of RBTools? This should be fixed. There will be a release in a few days, if you want to wait until then. -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en -~--~~~~--~~--~--~---