Re: Question: How to change tab size in diff viewer?
I have the same problem. Is there any way to configure the tab size in the diff viewer? Thanks, David On Wed, Sep 16, 2009 at 1:39 PM, surk s...@planet.nl wrote: We're using Review Board 1.0.1, and Firefox 3.5.3. When looking at the diffs using View Diff, all 'tab' chars in the diff-file are displayed with size 8. In the code we're using tab size 4. This makes the code looked misaligned sometimes. Is it possible to change the tab size, of the tab-chars it shows, of the 'diff viewer'? Thanx in advance! Best regards, Chris van Surksum The Netherlands --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard group. To post to this group, send email to reviewboard@googlegroups.com To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.comreviewboard%2bunsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -~--~~~~--~~--~--~--- -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: Question: How to change tab size in diff viewer?
There is not. If someone is willing to work on a good design and patch for this, we can possibly get it in for the next release. See http://code.google.com/p/reviewboard/issues/detail?id=839 Christian -- Christian Hammond - chip...@chipx86.com Review Board - http://www.reviewboard.org VMware, Inc. - http://www.vmware.com On Mon, Jan 25, 2010 at 1:58 AM, David Resnick abune...@gmail.com wrote: I have the same problem. Is there any way to configure the tab size in the diff viewer? Thanks, David On Wed, Sep 16, 2009 at 1:39 PM, surk s...@planet.nl wrote: We're using Review Board 1.0.1, and Firefox 3.5.3. When looking at the diffs using View Diff, all 'tab' chars in the diff-file are displayed with size 8. In the code we're using tab size 4. This makes the code looked misaligned sometimes. Is it possible to change the tab size, of the tab-chars it shows, of the 'diff viewer'? Thanx in advance! Best regards, Chris van Surksum The Netherlands --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard group. To post to this group, send email to reviewboard@googlegroups.com To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.comreviewboard%2bunsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -~--~~~~--~~--~--~--- -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.comreviewboard%2bunsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: What is the status of ClearCase integration on Windows?
OK, I am beginning to see Dan's point of view. think I am going to put off the idea of getting RB to work with ClearCase at this point. I have discovered a reference to /vobs substring as part of the file path in postreview. # Removing anything before the last /vobs # because it may be repeated. elem_path_idx = elem_path.rfind(/vobs) if elem_path_idx != -1: elem_path = elem_path[elem_path_idx:len(elem_path)].strip(\) This apparently assumes that the vob server is running Linux/Unix which is not the case here. I could try to fix this but I am not sure where else this assumption has been made. However I do like the uploading of an abstract diff file on the client side as implemented in: http://reviews.reviewboard.org/r/1197/ Also in our software change process, code reviews are not always the final step before changes become part of the core. So technically speaking we would not even want approved changes to be checked automatically after a code review approval !! I was wondering how difficult would it be to have an entirely SCM free, partial implementation of RB in which the abstract diffs only live in RB where they go through the review/modify/approve cycle without ever having to come back to an SCM. Or if we must have one, to setup some sort of mock SCM object (Using svn, git or anything else) only to interface with RB, to receive the diff's and dumping them. Sassan On Jan 16, 4:36 pm, Christian Hammond chip...@chipx86.com wrote: Indeed.. Shame IBM isn't using Review Board (at least, I don't know if they are). Maybe they could give us a license or some code or something. Little by little, I'm setting up some build/test VMs, and I'm hoping to get to a point where we can have better post-review and Review Board tests against installed servers of various types. But it's a long, time-consuming project. Christian -- Christian Hammond - chip...@chipx86.com Review Board -http://www.reviewboard.org VMware, Inc. -http://www.vmware.com On Sat, Jan 16, 2010 at 1:26 PM, Dan Savilonis d...@n-cube.org wrote: I don't know how similarly people use Clearcase, but I am fairly certain that the way my organization uses it is very non-standard. The typical review scenario would be to review modified code in a view, not checked in code. Fitting Clearcase's model into Reviewboard is a bit of square in round hole problem, though at the most basic level you can do the same thing that's done for other SCM systems: provide a base revision set and diff against it. Some of the stuff you mentioned is all possible, though it doesn't fit nicely into the ReviewBoard model as-is. Feel free to start up a thread in the dev mailing list and I'll help with whatever I can. However, I personally think your time might be better spent getting rid of Clearcase from your organization :) Christian, you'd likely need a mighty generous donor to get a Clearcase license. You'll also probably regret it once you try to set the beast up... On Jan 15, 8:02 pm, Sassan sassan...@verifone.com wrote: At least for ClearCase, most places have a standard naming convention for their views and/or config specs. Either way all it takes is for the client to prompt for and pass two view tags (strings) or config specs (small ascii files) in order for the web server to start the before and after views of the change locally on the server host and generate the diff... no file copy will be needed. This might be easier than dealing with verson extended pathnames. Dealing with directory changes (moving files from one place to another / renaming the files) is more difficult and we will need to use the ClearCase Object ID strings instead of file path names. On Jan 15, 5:51 pm, Chris Clark chris.cl...@ingres.com wrote: Thilo-Alexander Ginkel wrote: On Friday 15 January 2010 23:20:32 Sassan wrote: I am also thinking it might be a good idea to add a repository independent base functionality to the post-review script where it is handed the root directory of two source trees, before and after the change and it will then just compare the files and post a review. This way anyone with any source repository can just create the before and after soure trees outside RB and pass the roots of the source trees to the post-review script for posting. This won't work as Review Board needs to be able to access the respective SCM repository from the server-side to apply the posted diff to the base revision. For the server this is true. RE the client, http://reviews.reviewboard.org/r/1197/sortofdoes this. It allows any diff to be sent to reviewboard but it had better be a valid diff :-) Chris- Hide quoted text - - Show quoted text - -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know athttp://www.reviewboard.org/users/
Re: ReviewBoard Error while posting review for GIT
Hmm, that doesn't look good. What does the Git config look like? Christian -- Christian Hammond - chip...@chipx86.com Review Board - http://www.reviewboard.org VMware, Inc. - http://www.vmware.com On Mon, Jan 25, 2010 at 11:07 AM, Kunjal kunjal.par...@gmail.com wrote: Hello, When I post-review for GIT, I am getting below error. somehow the host path is listing ReviewBoard URL two times as you can see below. How to fix this? Unable to access http://mob-rb-test.sj.broadcom.com/mob-rb-test.sj.broadcom.com/api/json/accounts/login/ . The host path may be invalid HTTP Error 404: Not Found -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.comreviewboard%2bunsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
About the view diff page of reviewboard
Hi, all. I am using Reviewboard 1.0.5.1 and my code repository is CVS. I had previously thought the post-review tool had only passed a unified cvs diff file to Reviewboard server, So on the view diff page, users can only see part of the file (where change take place). And I found now, I can click the Expand changes link to see the whole file. But I don't know how did the basic code file was provided to Reviewboard server. I don't think the file was posted by post-review tool, because I can create ReviewRequest through WebUI, And there I can only upload an cvs diff' file. So, can any body told me how did Reviewboard get the basic file of the review reqeust? and where can I read the source code about it? Best Regards! -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: About the view diff page of reviewboard
This is where the repository information you provide in the administration UI comes into play. Review Board downloads each file from the diff from the repository. It then makes a copy of the file, applies the patch, and generates its own diff (which contains information beyond what a standard diff can provide). The result of that is what gets sent to the user's browser. That code all lives in reviewboard/scmtools/* and reviewboard/diffviewer/*. Christian -- Christian Hammond - chip...@chipx86.com Review Board - http://www.reviewboard.org VMware, Inc. - http://www.vmware.com 2010/1/25 qhlonline qhlonl...@163.com Hi, all. I am using Reviewboard 1.0.5.1 and my code repository is CVS. I had previously thought the post-review tool had only passed a unified cvs diff file to Reviewboard server, So on the view diff page, users can only see part of the file (where change take place). And I found now, I can click the *Expand changes* link to see the whole file. But I don't know how did the basic code file was provided to Reviewboard server. I don't think the file was posted by post-review tool, because I can create ReviewRequest through WebUI, And there I can only upload an cvs diff' file. So, can any body told me how did Reviewboard get the basic file of the review reqeust? and where can I read the source code about it? Best Regards! -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.comreviewboard%2bunsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
[Django] Error (EXTERNAL IP): /reviews/api/json/reviewrequests/79/draft/set/testing_done/
Hi all,
We are using reviewboard 1.0.5.1, and I receive this email form the
server. Can anyone tell me what's meaning? Thanks a lot!
From: r...@localhost [mailto:r...@localhost]
Sent: Tuesday, January 26, 2010 3:12 PM
To: Vincent Zhang
Subject: [Django] Error (EXTERNAL IP):
/reviews/api/json/reviewrequests/79/draft/set/testing_done/
Traceback (most recent call last):
File
c:\python25\lib\site-packages\django-1.1.1-py2.5.egg\django\core\handlers\base.py,
line 92, in get_response
response = callback(request, *callback_args, **callback_kwargs)
File
c:\python25\lib\site-packages\django-1.1.1-py2.5.egg\django\views\decorators\cache.py,
line 44, in _wrapped_view_func
response = view_func(request, *args, **kwargs)
File
c:\python25\lib\site-packages\Djblets-0.5.6-py2.5.egg\djblets\webapi\decorators.py,
line 59, in _checklogin
response = view_func(request, *args, **kwargs)
File
c:\python25\lib\site-packages\django-1.1.1-py2.5.egg\django\views\decorators\http.py,
line 37, in inner
return func(request, *args, **kwargs)
File
c:\python25\lib\site-packages\ReviewBoard-1.0.5.1-py2.5.egg\reviewboard\webapi\json.py,
line 863, in review_request_draft_set_field
_set_draft_field_data(draft, field_name, request.POST['value'])
File
c:\python25\lib\site-packages\django-1.1.1-py2.5.egg\django\core\handlers\modpython.py,
line 113, in _get_post
self._load_post_and_files()
File
c:\python25\lib\site-packages\django-1.1.1-py2.5.egg\django\core\handlers\modpython.py,
line 96, in _load_post_and_files
self._post, self._files = http.QueryDict(self.raw_post_data,
encoding=self._encoding), datastructures.MultiValueDict()
File
c:\python25\lib\site-packages\django-1.1.1-py2.5.egg\django\core\handlers\modpython.py,
line 163, in _get_raw_post_data
self._raw_post_data = self._req.read()
IOError: Client read error (Timeout?)
ModPythonRequest
path:/reviews/api/json/reviewrequests/79/draft/set/testing_done/,
GET:QueryDict: {},
POST:could not parse,
COOKIES:{'collapsediffs': 'True', 'rbsessionid':
'b6245e4130de43ab85c1c934b3341f25'},
META:{'AUTH_TYPE': None,
'CONTENT_LENGTH': '15',
'CONTENT_TYPE': 'application/x-www-form-urlencoded',
'GATEWAY_INTERFACE': 'CGI/1.1',
'HTTP_ACCEPT': 'application/json, text/javascript, */*',
'HTTP_ACCEPT_ENCODING': 'gzip, deflate',
'HTTP_ACCEPT_LANGUAGE': 'zh-cn',
'HTTP_CACHE_CONTROL': 'no-cache',
'HTTP_CONNECTION': 'Keep-Alive',
'HTTP_CONTENT_LENGTH': '15',
'HTTP_CONTENT_TYPE': 'application/x-www-form-urlencoded',
'HTTP_COOKIE': 'rbsessionid=b6245e4130de43ab85c1c934b3341f25;
collapsediffs=True',
'HTTP_HOST': '10.200.122.86',
'HTTP_REFERER': 'http://10.200.122.86/reviews/r/79/',
'HTTP_USER_AGENT': 'Mozilla/4.0 (compatible; MSIE 8.0; Windows NT 5.2;
Trident/4.0; .NET CLR 1.1.4322; .NET CLR 2.0.50727; .NET CLR 3.0.4506.2152;
.NET CLR 3.5.30729; InfoPath.1)',
'HTTP_X_REQUESTED_WITH': 'XMLHttpRequest',
'PATH_INFO':
u'/reviews/api/json/reviewrequests/79/draft/set/testing_done/',
'PATH_TRANSLATED': None,
'QUERY_STRING': None,
'REMOTE_ADDR': '10.200.46.128',
'REMOTE_HOST': None,
'REMOTE_IDENT': None,
'REMOTE_USER': None,
'REQUEST_METHOD': 'POST',
'SCRIPT_NAME': '',
'SERVER_NAME': 'localhost',
'SERVER_PORT': 80,
'SERVER_PROTOCOL': 'HTTP/1.1',
'SERVER_SOFTWARE': 'mod_python'}
--
Thanks Regards
Vincent Zhang
--
Want to help the Review Board project? Donate today at
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at
http://groups.google.com/group/reviewboard?hl=en
Re: [Django] Error (EXTERNAL IP): /reviews/api/json/reviewrequests/79/draft/set/testing_done/
This is something outside of Review Board. It looks like some sort of
communication problem between the client and the server. I could only
speculate, but perhaps some issue with a proxy server inbetween the client
and server, or some issue with the network, or super-high latency due to
some reason on the server itself.
Christian
--
Christian Hammond - chip...@chipx86.com
Review Board - http://www.reviewboard.org
VMware, Inc. - http://www.vmware.com
On Mon, Jan 25, 2010 at 11:34 PM, 张鸥 seagle0...@gmail.com wrote:
Hi all,
We are using reviewboard 1.0.5.1, and I receive this email form the
server. Can anyone tell me what's meaning? Thanks a lot!
From: r...@localhost [mailto:r...@localhost]
Sent: Tuesday, January 26, 2010 3:12 PM
To: Vincent Zhang
Subject: [Django] Error (EXTERNAL IP):
/reviews/api/json/reviewrequests/79/draft/set/testing_done/
Traceback (most recent call last):
File
c:\python25\lib\site-packages\django-1.1.1-py2.5.egg\django\core\handlers\base.py,
line 92, in get_response
response = callback(request, *callback_args, **callback_kwargs)
File
c:\python25\lib\site-packages\django-1.1.1-py2.5.egg\django\views\decorators\cache.py,
line 44, in _wrapped_view_func
response = view_func(request, *args, **kwargs)
File
c:\python25\lib\site-packages\Djblets-0.5.6-py2.5.egg\djblets\webapi\decorators.py,
line 59, in _checklogin
response = view_func(request, *args, **kwargs)
File
c:\python25\lib\site-packages\django-1.1.1-py2.5.egg\django\views\decorators\http.py,
line 37, in inner
return func(request, *args, **kwargs)
File
c:\python25\lib\site-packages\ReviewBoard-1.0.5.1-py2.5.egg\reviewboard\webapi\json.py,
line 863, in review_request_draft_set_field
_set_draft_field_data(draft, field_name, request.POST['value'])
File
c:\python25\lib\site-packages\django-1.1.1-py2.5.egg\django\core\handlers\modpython.py,
line 113, in _get_post
self._load_post_and_files()
File
c:\python25\lib\site-packages\django-1.1.1-py2.5.egg\django\core\handlers\modpython.py,
line 96, in _load_post_and_files
self._post, self._files = http.QueryDict(self.raw_post_data,
encoding=self._encoding), datastructures.MultiValueDict()
File
c:\python25\lib\site-packages\django-1.1.1-py2.5.egg\django\core\handlers\modpython.py,
line 163, in _get_raw_post_data
self._raw_post_data = self._req.read()
IOError: Client read error (Timeout?)
ModPythonRequest
path:/reviews/api/json/reviewrequests/79/draft/set/testing_done/,
GET:QueryDict: {},
POST:could not parse,
COOKIES:{'collapsediffs': 'True', 'rbsessionid':
'b6245e4130de43ab85c1c934b3341f25'},
META:{'AUTH_TYPE': None,
'CONTENT_LENGTH': '15',
'CONTENT_TYPE': 'application/x-www-form-urlencoded',
'GATEWAY_INTERFACE': 'CGI/1.1',
'HTTP_ACCEPT': 'application/json, text/javascript, */*',
'HTTP_ACCEPT_ENCODING': 'gzip, deflate',
'HTTP_ACCEPT_LANGUAGE': 'zh-cn',
'HTTP_CACHE_CONTROL': 'no-cache',
'HTTP_CONNECTION': 'Keep-Alive',
'HTTP_CONTENT_LENGTH': '15',
'HTTP_CONTENT_TYPE': 'application/x-www-form-urlencoded',
'HTTP_COOKIE': 'rbsessionid=b6245e4130de43ab85c1c934b3341f25;
collapsediffs=True',
'HTTP_HOST': '10.200.122.86',
'HTTP_REFERER': 'http://10.200.122.86/reviews/r/79/',
'HTTP_USER_AGENT': 'Mozilla/4.0 (compatible; MSIE 8.0; Windows NT 5.2;
Trident/4.0; .NET CLR 1.1.4322; .NET CLR 2.0.50727; .NET CLR 3.0.4506.2152;
.NET CLR 3.5.30729; InfoPath.1)',
'HTTP_X_REQUESTED_WITH': 'XMLHttpRequest',
'PATH_INFO':
u'/reviews/api/json/reviewrequests/79/draft/set/testing_done/',
'PATH_TRANSLATED': None,
'QUERY_STRING': None,
'REMOTE_ADDR': '10.200.46.128',
'REMOTE_HOST': None,
'REMOTE_IDENT': None,
'REMOTE_USER': None,
'REQUEST_METHOD': 'POST',
'SCRIPT_NAME': '',
'SERVER_NAME': 'localhost',
'SERVER_PORT': 80,
'SERVER_PROTOCOL': 'HTTP/1.1',
'SERVER_SOFTWARE': 'mod_python'}
--
Thanks Regards
Vincent Zhang
--
Want to help the Review Board project? Donate today at
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to
reviewboard+unsubscr...@googlegroups.comreviewboard%2bunsubscr...@googlegroups.com
For more options, visit this group at
http://groups.google.com/group/reviewboard?hl=en
--
Want to help the Review Board project? Donate today at
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at
http://groups.google.com/group/reviewboard?hl=en
Re:Re: About the view diff page of reviewboard
Thanks Christian, I will have a look at the source. Regards! 在2010-01-26 15:35:07，Christian Hammond chip...@chipx86.com 写道： This is where the repository information you provide in the administration UI comes into play. Review Board downloads each file from the diff from the repository. It then makes a copy of the file, applies the patch, and generates its own diff (which contains information beyond what a standard diff can provide). The result of that is what gets sent to the user's browser. That code all lives in reviewboard/scmtools/* and reviewboard/diffviewer/*. Christian -- Christian Hammond - chip...@chipx86.com Review Board - http://www.reviewboard.org VMware, Inc. - http://www.vmware.com 2010/1/25 qhlonline qhlonl...@163.com Hi, all. I am using Reviewboard 1.0.5.1 and my code repository is CVS. I had previously thought the post-review tool had only passed a unified cvs diff file to Reviewboard server, So on the view diff page, users can only see part of the file (where change take place). And I found now, I can click the Expand changes link to see the whole file. But I don't know how did the basic code file was provided to Reviewboard server. I don't think the file was posted by post-review tool, because I can create ReviewRequest through WebUI, And there I can only upload an cvs diff' file. So, can any body told me how did Reviewboard get the basic file of the review reqeust? and where can I read the source code about it? Best Regards! -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
