Every patch failing on new RB install w/Mercurial
Hello all, I'm working to set up a new RB install, and I've gotten to the point where I can post reviews with the 'post-review' command. However, when I view the diffs in RB, I get an error because the 'patch' command has failed. I've tried several post-commit reviews with commands like the following, all with the broken patch result: $ post-review -p -d --server=http://192.168.1.189/rb/ --revision- range=20164:20165 --guess-summary --guess-description The patches are being generated by 'post-review' with commands like the following, correlated to the above example: hg diff -r 20164 -r 20165 And, they look to my eye to be pretty run-of-the-mill. I've purposely chosen revision ranges with minimal changes. I've also used the Mercurial hex blob IDs instead of numeric revision IDs, to no effect. I'm wondering if this recent bug may be related: http://code.google.com/p/reviewboard/issues/detail?id=1668 I thought I would ask here first though before making noise on that bug, to see if I'm missing anything obvious. -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: Every patch failing on new RB install w/Mercurial
Hi Gordon, At what point are things failing? On upload, or on view? Can you show the debug output from post-review? Christian -- Christian Hammond - chip...@chipx86.com Review Board - http://www.reviewboard.org VMware, Inc. - http://www.vmware.com On Wed, Jun 2, 2010 at 5:19 PM, Gordon Morehouse gordon.moreho...@gmail.com wrote: Hello all, I'm working to set up a new RB install, and I've gotten to the point where I can post reviews with the 'post-review' command. However, when I view the diffs in RB, I get an error because the 'patch' command has failed. I've tried several post-commit reviews with commands like the following, all with the broken patch result: $ post-review -p -d --server=http://192.168.1.189/rb/ --revision- range=20164:20165 --guess-summary --guess-description The patches are being generated by 'post-review' with commands like the following, correlated to the above example: hg diff -r 20164 -r 20165 And, they look to my eye to be pretty run-of-the-mill. I've purposely chosen revision ranges with minimal changes. I've also used the Mercurial hex blob IDs instead of numeric revision IDs, to no effect. I'm wondering if this recent bug may be related: http://code.google.com/p/reviewboard/issues/detail?id=1668 I thought I would ask here first though before making noise on that bug, to see if I'm missing anything obvious. -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.comreviewboard%2bunsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: Every patch failing on new RB install w/Mercurial
On Jun 2, 5:24 pm, Christian Hammond chip...@chipx86.com wrote: Hi Gordon, At what point are things failing? On upload, or on view? Can you show the debug output from post-review? Hi Christian, They're failing on view (Diff Viewer). Some output follows. The diff in this case is a one-line change: The patch to 'share/cgi-lib/php/base/workgroup/common/dbclasses/ o_wg_reference.inc' didn't apply cleanly. The temporary files have been left in '/tmp/reviewboard.uYLcTm' for debugging purposes. `patch` returned: patching file /tmp/reviewboard.uYLcTm/tmpjzLA9Y Hunk #1 FAILED at 965. 1 out of 1 hunk FAILED -- saving rejects to file /tmp/ reviewboard.uYLcTm/tmpjzLA9Y-new.rej Traceback (most recent call last): File /usr/local/lib/python2.6/dist-packages/reviewboard/diffviewer/ views.py, line 153, in view_diff interdiffset, highlighting, True) File /usr/local/lib/python2.6/dist-packages/reviewboard/diffviewer/ diffutils.py, line 623, in get_diff_files large_data=True) File /usr/local/lib/python2.6/dist-packages/djblets/util/misc.py, line 166, in cache_memoize data = lookup_callable() File /usr/local/lib/python2.6/dist-packages/reviewboard/diffviewer/ diffutils.py, line 622, in lambda enable_syntax_highlighting), File /usr/local/lib/python2.6/dist-packages/reviewboard/diffviewer/ diffutils.py, line 345, in get_chunks new = get_patched_file(old, filediff) File /usr/local/lib/python2.6/dist-packages/reviewboard/diffviewer/ diffutils.py, line 261, in get_patched_file return patch(filediff.diff, buffer, filediff.dest_file) File /usr/local/lib/python2.6/dist-packages/reviewboard/diffviewer/ diffutils.py, line 129, in patch (filename, tempdir, patch_output)) Exception: The patch to 'share/cgi-lib/php/base/workgroup/common/ dbclasses/o_wg_reference.inc' didn't apply cleanly. The temporary files have been left in '/tmp/reviewboard.uYLcTm' for debugging purposes. `patch` returned: patching file /tmp/reviewboard.uYLcTm/tmpjzLA9Y Hunk #1 FAILED at 965. 1 out of 1 hunk FAILED -- saving rejects to file /tmp/ reviewboard.uYLcTm/tmpjzLA9Y-new.rej -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: Review Board 1.5 Beta 2 Released
Hi, Sorry, I missed this e-mail entirely. It's most likely that the origin of the central server is different between what Review Board has recorded and what your Git clone is using. The remote origin on your clone must match exactly the Path or Mirror Path of your Repository entry in Review Board. Christian -- Christian Hammond - chip...@chipx86.com Review Board - http://www.reviewboard.org VMware, Inc. - http://www.vmware.com On Thu, May 20, 2010 at 5:58 PM, Sapna Vempati sapnavemp...@gmail.comwrote: Hi Christian, We could successfully install RB 1.0.5 Beta2 version RBTools onto our RB test server. Now I am trying to confgure GIT for the first time. This is what I am doing, Login to RB test server location. 1. Copying post-review from RBTools to my . 2. Configuring my web test server, git config reviewboard.url http://mob-rb-test.sj.broadcom.com/ 3. sync a repo and commit a sample change. 4. Run post-review command. But I am getting this error, Unable to find a Review Board server for this source code tree. Am I missing something else ? Thanks for your time ! Sapna On Thu, May 13, 2010 at 12:41 AM, Christian Hammond chip...@chipx86.comwrote: Hi everyone, We've released Review Board 1.5 beta 2, which fixes many of the bugs reported in 1.5 beta 1, and introduces several nice usability improvements. If you're running 1.5 beta 1 or the nightlies, please upgrade and let us know if you hit any problems. The sooner we can identify and fix the remaining bugs, the sooner we'll be able to release the final 1.5. For more information, see http://www.reviewboard.org/news/2010/05/13/review-board-15-beta-2-released/ Christian -- Christian Hammond - chip...@chipx86.com Review Board - http://www.reviewboard.org VMware, Inc. - http://www.vmware.com -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.comreviewboard%2bunsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.comreviewboard%2bunsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: Reviewing code using a tablet PC
Hi Andrew, This sounds like a very interesting project, and I'd love to hear more about it. Being a new tablet user myself (iPad) I'm also interested in improving code review on tablets. I'm not familiar with Slice. What does it do? Is it something you'd use on top of Review Board, or in place of it? Basically, all I've done with the iPad and Review Board so far is make the UI easier to use on the iPad. Improving input handling and such. There isn't anything really new in my changes that dramatically change how you review code on a tablet. Christian -- Christian Hammond - chip...@chipx86.com Review Board - http://www.reviewboard.org VMware, Inc. - http://www.vmware.com On Sat, May 29, 2010 at 11:00 AM, Andrew Smith asmit...@littlesvr.cawrote: Hi guys Sorry, I don't know if this is the right place to post this or whether anyone is interested in the project, but I figured maybe you would be. My Master's in IT project is to compare the usability of different tools/techniques for code review: traditional form input (not like ReviewBoard, more like Bugzilla), paper printouts, and special software on a tablet PC. I have no idea which will turn out to be better, but I am sort of hoping that the tablet PC will come up on top, since the software will allow for freeform annotations but without the limitation of paper printouts. I've just about commited to developing my software on top of ReviewBoard, and later that day found that someone made software almost exactly like what I need - Slice, a Windows App. I don't like reinventing wheels so I'll use that for my dissertation. Still, I wanted to let you guys know about this project because you may be interested. I try to keep my blog updated as the project progresses: http://littlesvr.ca/masters/ I've heard that you're considering doing something with the iPad. If you are - it will probably be very different from what I'm planning (given the absense of a stylus) but still we are likely to run into some similar problems and might be able to share solutions, which would be great. Could you tell me more about what you're planning? Also - I will be looking for participants in the summer - will ask them to review code using all 3 methods. If you're in the GTA or not too far north of it and are interested - let me know! On top of the fun of participating in a scientific experiment you'll get a 10$ Tim Horton's gift card :) Cheers, Andrew -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.comreviewboard%2bunsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: Three questions for using Review Board 1.0.6
Hi James, Today, each logical change is meant to have its own review request. If you have three things that are related but are separately worked on, each should be put up for review separately. There's no notion of a review request that encompasses several different changes. I personally think this is good, as it keeps it organized and keeps things smaller. Where things may change over the next several months is how diffs are handled when used with a DVCS like Git. In those cases, it makes sense to be able to have a review request for one change but with several iterative diffs leading up to that one change. It would still be one logical change, but with multiple diffs instead of one big diff. I don't know how well this concept would really apply in the SVN guess. I suspect it wouldn't. Now, I'm not fully sure I understand how your project is organized. Is each Java component in a different repository? If not, can't one diff be generated that has all the changes to all the components, and then put that up as one review request? If they are indeed in different repositories, then what you'd need is a way to have one review request that spans repositories. This is something that, for many reasons, we wouldn't be doing, so you'd have to have one review request per repository. I don't really understand your second request. It sounds like something that could be solved by a DVCS solution, or multiple checkouts of your repository. For the third request, this is something that's not really on the radar for a release right now. In order to do it right, I think we need to do more than revision ranges (especially for DVCS systems where it's not actually a numeric range). I'd like to do it correctly if we do it, and that will take some time and planning. Christian -- Christian Hammond - chip...@chipx86.com Review Board - http://www.reviewboard.org VMware, Inc. - http://www.vmware.com On Thu, May 20, 2010 at 12:41 AM, james tong james_tong...@yahoo.com.cnwrote: Hi, all, My team now is using the ReviewBoard-1.0.6 which is running on the Cent-OS server. And this is really fantastic software which help us a lot for code review. However, we also found some troubles when doing review. First, In our project, we need to update the code in more than one components (java project), so we may generate several diff files for one main function. And we find that it is impossible (or it is possible but we did not find that?) to upload these diff files in the same review request. Then we have to create several review requests for the same main function. So, I send this email and hope to know what is others' way for this problem? I think this may be a common case. Second, for some case, we may need to change the same class for two main functions at the same period (during the week by different team members), so how to generate diff file and create the review request for this case? (Our review request is created base on main function changes, and for this case, one review request will contain the changes for other main function, there may be some confusing). I know this might not be in the scope of this mail list, but still hope to get some useful suggestion. Third, we are using svn as the repository. And we want to know that when we can simply input the revision numbers in the web GUI for creating a review request without uploading the diff file. :-) Many Thanks BR// -- Best Regards! James.Tong 童熙 -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.comreviewboard%2bunsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Issue 1672 in reviewboard: ReviewBoard hide existing revisions
Status: New Owner: Labels: Type-Defect Priority-Medium New issue 1672 by Jan.Koprowski: ReviewBoard hide existing revisions http://code.google.com/p/reviewboard/issues/detail?id=1672 *NOTE: Do not post confidential information in this bug report.* What version are you running? 1.5 beta 3 What's the URL of the page containing the problem? http://SERVER/r/NUMBER/diff/#index_header What steps will reproduce the problem? 1. Turn on view diff 2. 3. What is the expected output? What do you see instead? Diffviewer should show all files. I see only last one. Strange because in HTML source of file I see all files and downloading raw diff show all three files. Also turning off JavaScript work. But when JS is turn on only last file is show. What operating system are you using? What browser? Linux Please provide any additional information below. This doesn't work on 1.5 beta 2 also. -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-iss...@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Issue 1673 in reviewboard: post-review revision-range doesn't handle single revision as advertised
Status: New
Owner:
Labels: Type-Defect Priority-Medium
New issue 1673 by gordon.morehouse: post-review revision-range doesn't
handle single revision as advertised
http://code.google.com/p/reviewboard/issues/detail?id=1673
What version are you running?
RBTools 0.2
What steps will reproduce the problem?
1. Enter a command line with a single revision: 'post-review --revision-
range=20397'
What is the expected output? What do you see instead?
The docs at http://www.reviewboard.org/docs/manual/dev/users/tools/post-
review/#posting-committed-code state that this should work. Instead, I
get:
Traceback (most recent call last):
File /usr/local/bin/post-review, line 9, in module
load_entry_point('RBTools==0.2', 'console_scripts', 'post-review')()
File /usr/local/lib/python2.6/dist-packages/rbtools/postreview.py, line
2830, in main
repository_info)
File /usr/local/lib/python2.6/dist-packages/rbtools/postreview.py, line
2034, in diff_between_revisions
r1, r2 = revision_range.split(':')
ValueError: need more than 1 value to unpack
What operating system are you using? What browser?
Ubuntu 10.04 LTS.
--
You received this message because you are subscribed to the Google Groups
reviewboard-issues group.
To post to this group, send email to reviewboard-iss...@googlegroups.com.
To unsubscribe from this group, send email to
reviewboard-issues+unsubscr...@googlegroups.com.
For more options, visit this group at
http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 1672 in reviewboard: ReviewBoard hide existing revisions
Updates: Status: NeedInfo Labels: Component-DiffViewer Comment #1 on issue 1672 by chipx86: ReviewBoard hide existing revisions http://code.google.com/p/reviewboard/issues/detail?id=1672 Nothing has changed in the logic anywhere regarding the diff file display. It always shows the first file it will display (generated during the initial page render) and then asynchronously downloads the other files. What do you mean when you say turning off JavaScript works? You see all three files? Can you check your JavaScript debug output to see what errors are being displayed? It's most likely that something is erroring out and preventing further operations for the file display. -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-iss...@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
