Public github branch for each review

2010-09-28 Thread Jan Koprowski
Hi,

  I'm wondering is it possible to make public branch on github for
each review. This could be very helpful to work on code made by
someone and share ideas in code, improving reviewing elements of
someone else. This could be good idea. I don't know how add access to
this branches yet but :) What do You think about this?

Greetings from Poland!
--
Jan Koprowski

-- 
Want to help the Review Board project? Donate today at 
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en


RB and GIT configuration

2010-09-28 Thread Chetan
Hello,
 Can anyone share me the steps to configure RB with GIT version
control system.

I access my git repo from ubuntu by executing git clone
ssh://user_id@ip_address:port_no/tst_prj.git

Now when i try to give ssh://user_id@ip_address:port_no/tst_prj.git
as the PATH value under new repository tab i get below error. (New
repository-repository Hosting- Path)

(-2, 'Name or service not known')


The git project is on a seperate GIT server inside the organisation.
It is a private git setup. RB and GIT are on 2 different servers. I
have not cloned the git repository on RB server.


Request your assistance on setting up GIT with RB

-- 
Want to help the Review Board project? Donate today at 
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en


Re: RB and GIT configuration

2010-09-28 Thread Christian Hammond
Hi Chetan,

You need to upgrade to Review Board 1.5 RC2, and then follow the
instructions in the manual here:

http://www.reviewboard.org/docs/manual/dev/admin/management/repositories/#git

You will basically need something like cgit or gitweb installed on the
server running Git and then tell Review Board to use that.

Christian

-- 
Christian Hammond - chip...@chipx86.com
Review Board - http://www.reviewboard.org
VMware, Inc. - http://www.vmware.com


On Mon, Sep 27, 2010 at 11:09 PM, Chetan chetan@gmail.com wrote:

 Hello,
 Can anyone share me the steps to configure RB with GIT version
 control system.

 I access my git repo from ubuntu by executing git clone
 ssh://user_id@ip_address:port_no/tst_prj.git

 Now when i try to give ssh://user_id@ip_address:port_no/tst_prj.git
 as the PATH value under new repository tab i get below error. (New
 repository-repository Hosting- Path)

 (-2, 'Name or service not known')


 The git project is on a seperate GIT server inside the organisation.
 It is a private git setup. RB and GIT are on 2 different servers. I
 have not cloned the git repository on RB server.


 Request your assistance on setting up GIT with RB

 --
 Want to help the Review Board project? Donate today at
 http://www.reviewboard.org/donate/
 Happy user? Let us know at http://www.reviewboard.org/users/
 -~--~~~~--~~--~--~---
 To unsubscribe from this group, send email to
 reviewboard+unsubscr...@googlegroups.comreviewboard%2bunsubscr...@googlegroups.com
 For more options, visit this group at
 http://groups.google.com/group/reviewboard?hl=en

-- 
Want to help the Review Board project? Donate today at 
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en

RB and GIT configuration

2010-09-28 Thread Chetan
Hello,
 Can anyone share me the steps to configure RB with GIT version
control system.

I access my git repo from ubuntu by executing git clone
ssh://user_id@ip_address:port_no/tst_prj.git

Now when i try to give ssh://user_id@ip_address:port_no/tst_prj.git
as the PATH value under new repository tab i get below error. (New
repository-repository Hosting- Path)

(-2, 'Name or service not known')


The git project is on a seperate GIT server inside the organisation.
It is a private git setup. RB and GIT are on 2 different servers. I
have not cloned the git repository on RB server.


Request your assistance on setting up GIT with RB

-- 
Want to help the Review Board project? Donate today at 
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en


How to use post-review with a private GitHub repository?

2010-09-28 Thread Gustavo Narea
Hello,

I cannot find the way to get post-review to work with a private GitHub
repository. Can you please give me a hand? This is driving me crazy,
specially after spending days migrating to Git pretty much to use
Review Board. :)

I have successfully configured the repository on the Web interface and
I have a local mirror of that repository, which I had to create just
to be able to run post-review (it errors out if I call it from another
directory); both repositories are registered in Review Board (i.e.,
g...@github.com:us/project.git and /srv/mirror/project).

I'm trying to generate a review for all the changes that happened in a
feature branch, which was started from master. This is how I run it:
$ cd /srv/mirror/project
$ post-review --server=http://example.org/reviews/ --guess-summary --
guess-description --username=foo --password=bar --submit-as=baz --
tracking-branch=origin/master

But I get the following:

(...)
 Uploading diff, size: 648218
 HTTP POSTing to 
 http://example.org/reviews/api/json/reviewrequests/57/diff/new/: {}
 Got API Error 207 (HTTP code 200): The file was not found in the repository
 Error data: {'deprecated': {'in_version': '1.5'}, 'stat': 'fail', 'file': 
 '.bzrignore', 'err': {'msg': 'The file was not found in the repository', 
 'code': 207}, 'revision': 'e4537c290c47cd2946318c6e02f2edb6d7a732b7'}

Error uploading diff

Your review request still exists, but the diff is not attached.


If I add the --output-diff, I get the diff and seems OK.

I think the fact that it fails with the file .bzrignore is a
coincidence and is nothing to do with the migration from our previous
VCS. I get the same error even after removing it from master and the
feature branch.

I'm using Review Board 1.5 RC2 and RBTools 0.2.

Can you please help me out?

Thanks in advance,

 - Gustavo.

-- 
Want to help the Review Board project? Donate today at 
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en


Cannot see the SVN repositories in the combo when c reating a request.

2010-09-28 Thread dtrosset
Bonjour,

I installed reviewboard successfully, using apache, mod_python and
mysql on a Debian system. I created some users, and two SVN
repositories. But when I want to create a Review Request, the
Repositories combo box is empty. No way to create a request.

What did I do wrong?

Thanks
Didier

-- 
Want to help the Review Board project? Donate today at 
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en


Re: How to use post-review with a private GitHub repository?

2010-09-28 Thread Christian Hammond
When adding the repository entries, did you type the paths by hand?

You should make sure to configure the repository with a Hosting Service of
GitHub (Private) and then fill in the requested fields from there. You
will need your API Token from your GitHub account (the one owning the
project in question).

Christian

-- 
Christian Hammond - chip...@chipx86.com
Review Board - http://www.reviewboard.org
VMware, Inc. - http://www.vmware.com


On Tue, Sep 28, 2010 at 9:57 AM, Gustavo Narea 
gna...@tech.2degreesnetwork.com wrote:

 Hello,

 I cannot find the way to get post-review to work with a private GitHub
 repository. Can you please give me a hand? This is driving me crazy,
 specially after spending days migrating to Git pretty much to use
 Review Board. :)

 I have successfully configured the repository on the Web interface and
 I have a local mirror of that repository, which I had to create just
 to be able to run post-review (it errors out if I call it from another
 directory); both repositories are registered in Review Board (i.e.,
 g...@github.com:us/project.git and /srv/mirror/project).

 I'm trying to generate a review for all the changes that happened in a
 feature branch, which was started from master. This is how I run it:
 $ cd /srv/mirror/project
 $ post-review --server=http://example.org/reviews/ --guess-summary --
 guess-description --username=foo --password=bar --submit-as=baz --
 tracking-branch=origin/master

 But I get the following:
 
 (...)
  Uploading diff, size: 648218
  HTTP POSTing to
 http://example.org/reviews/api/json/reviewrequests/57/diff/new/: {}
  Got API Error 207 (HTTP code 200): The file was not found in the
 repository
  Error data: {'deprecated': {'in_version': '1.5'}, 'stat': 'fail',
 'file': '.bzrignore', 'err': {'msg': 'The file was not found in the
 repository', 'code': 207}, 'revision':
 'e4537c290c47cd2946318c6e02f2edb6d7a732b7'}

 Error uploading diff

 Your review request still exists, but the diff is not attached.
 

 If I add the --output-diff, I get the diff and seems OK.

 I think the fact that it fails with the file .bzrignore is a
 coincidence and is nothing to do with the migration from our previous
 VCS. I get the same error even after removing it from master and the
 feature branch.

 I'm using Review Board 1.5 RC2 and RBTools 0.2.

 Can you please help me out?

 Thanks in advance,

  - Gustavo.

 --
 Want to help the Review Board project? Donate today at
 http://www.reviewboard.org/donate/
 Happy user? Let us know at http://www.reviewboard.org/users/
 -~--~~~~--~~--~--~---
 To unsubscribe from this group, send email to
 reviewboard+unsubscr...@googlegroups.comreviewboard%2bunsubscr...@googlegroups.com
 For more options, visit this group at
 http://groups.google.com/group/reviewboard?hl=en

-- 
Want to help the Review Board project? Donate today at 
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en

Re: Cannot see the SVN repositories in the combo when creating a request.

2010-09-28 Thread Christian Hammond
What version of Review Board are you using?

Most likely, you don't have the proper pysvn package installed. Make sure
the 'python-svn' Debian package is installed.

Christian

-- 
Christian Hammond - chip...@chipx86.com
Review Board - http://www.reviewboard.org
VMware, Inc. - http://www.vmware.com


On Tue, Sep 28, 2010 at 7:07 AM, dtrosset did...@trosset.fr wrote:

 Bonjour,

 I installed reviewboard successfully, using apache, mod_python and
 mysql on a Debian system. I created some users, and two SVN
 repositories. But when I want to create a Review Request, the
 Repositories combo box is empty. No way to create a request.

 What did I do wrong?

 Thanks
 Didier

 --
 Want to help the Review Board project? Donate today at
 http://www.reviewboard.org/donate/
 Happy user? Let us know at http://www.reviewboard.org/users/
 -~--~~~~--~~--~--~---
 To unsubscribe from this group, send email to
 reviewboard+unsubscr...@googlegroups.comreviewboard%2bunsubscr...@googlegroups.com
 For more options, visit this group at
 http://groups.google.com/group/reviewboard?hl=en

-- 
Want to help the Review Board project? Donate today at 
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en

Re: Triggers

2010-09-28 Thread Brendan Almonte
Scott,

Would it be possible to share this code?


Thanks,
Brendan

On Aug 20, 9:55 am, Scott Quesnelle scott.quesne...@gmail.com wrote:
 I modified the base code for reviewboard. Its one small change in the webapi
 code to trigger a generate_summary call when the close-submitted action is
 done.

 Then a new file which contains the generate_summary code and its appropriate
 template. The email code was used as the inspiration, and subtle
 modifications were made to suit the layout I thought best for the summary.
 This file is then written to the local disk and I have separate automation
 which pushes it into our bugtracking system.

 Scott







 On Fri, Aug 20, 2010 at 12:48 AM, J Arrizza cppge...@gmail.com wrote:
  Scott,
  Sorry for taking so long to back to you, got tied up on other stuff.

  Very nice. You modified the base code in some spot or is the review summary
  generation already a part of RB 1.07?

  John

  On Wed, Aug 18, 2010 at 2:22 PM, Scott Quesnelle 
  scott.quesne...@gmail.com wrote:

  John,

  I have an implementation in my deployment which generates a review summary
  when the review is closed, and it writes the summary to a file that is 
  named
  based on the bugid(s) provided. A separate script runs and talks to the bug
  tracking system and updates the appropriate bug(s) with the review summary
  in a standardized enclosure.

  This is currently running on RB 1.0.

  Scott

  --
  John
  blog:http://arrizza.blogspot.com/
  web:http://www.arrizza.com/

  --
  Want to help the Review Board project? Donate today at
 http://www.reviewboard.org/donate/
  Happy user? Let us know athttp://www.reviewboard.org/users/
  -~--~~~~--~~--~--~---
  To unsubscribe from this group, send email to
  reviewboard+unsubscr...@googlegroups.comreviewboard%2bunsubscr...@googlegr 
  oups.com
  For more options, visit this group at
 http://groups.google.com/group/reviewboard?hl=en

-- 
Want to help the Review Board project? Donate today at 
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en


RB usage

2010-09-28 Thread J Arrizza
Just looking for some tips on how you use RB. I'm still a newbie at RB so
here's my understanding (v1.0.7):


   - There are two places where you can put Comments and Replys. The first
   is in the View Diff area. The second is in the View Reviews area.
   - If you put a Comment in the View Diff area, the Comment also shows up
   in the View Reviews area.
   - If you put a Reply in the View Diff area for a particular Comment, it
   doesn't show next to the original Comment in the View Reviews area, it is in
   a separate pane at the end of that page.
   - If you put a Reply in the View Reviews area, it doesn't show up in the
   View Diff area.

So how do you keep track that each comment has been addressed/resolved? We
have a rule that says that all changes and comments have to have a final
OK by all reviewers but the differences in the View Diff and View Reviews
areas make that difficult.

John

-- 
Want to help the Review Board project? Donate today at 
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en

[ReviewBoard 1.5] RC1 to RC3 upgrade communication explenation

2010-09-28 Thread Jan Koprowski
Hi,

  While upgrading I get something like this:

Rebuilding directory structure
Updating database. This may take a while.
Upgrading Review Board from 1.5 RC1 to 1.5 RC3 (dev)

red There are unapplied evolutions for reviews. /red
red Project signature has changed - an evolution is required /red

No fixtures found.

how fix this /user/gkblditp/system/lib/python2.6/site-packages/
pycrypto-2.3-py2.6-linux-x86_64.egg/Crypto/Util/randpool.py:40:
RandomPool_DeprecationWarning: This application uses RandomPool, which
is BROKEN in older releases.  See http://www.pycrypto.org/randpool-broken
/how fix this

Evolution successful.
Upgrade complete.

What is it mean?

Regards,

Jan Koprowski

-- 
Want to help the Review Board project? Donate today at 
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en


Re: Issue 1275 in reviewboard: Add capabilites for tracking reviews in progress, and for marking that a review has been read and reacted to

2010-09-28 Thread reviewboard


Comment #1 on issue 1275 by olivier.delalleau: Add capabilites for tracking  
reviews in progress, and for marking that a review has been read and  
reacted to

http://code.google.com/p/reviewboard/issues/detail?id=1275

I strongly agree there is a need for an in progress feature.

--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To post to this group, send email to reviewboard-iss...@googlegroups.com.
To unsubscribe from this group, send email to 
reviewboard-issues+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/reviewboard-issues?hl=en.



Re: Issue 1183 in reviewboard: Viewing diff in review request causes traceback involving memcache

2010-09-28 Thread reviewboard


Comment #5 on issue 1183 by eero.temp: Viewing diff in review request  
causes traceback involving memcache

http://code.google.com/p/reviewboard/issues/detail?id=1183

Got this problem with a fresh install of version 1.0.9. Did anyone ever  
find a solution for this?


--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To post to this group, send email to reviewboard-iss...@googlegroups.com.
To unsubscribe from this group, send email to 
reviewboard-issues+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/reviewboard-issues?hl=en.



Re: Issue 1183 in reviewboard: Viewing diff in review request causes traceback involving memcache

2010-09-28 Thread reviewboard

Updates:
Status: NeedInfo

Comment #6 on issue 1183 by chipx86: Viewing diff in review request causes  
traceback involving memcache

http://code.google.com/p/reviewboard/issues/detail?id=1183

Can you give me the names of the files in the diff? Or at least, let me  
know if there's any non-alphanumeric characters in there (spaces, colons,  
non-English letters, etc.)


--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To post to this group, send email to reviewboard-iss...@googlegroups.com.
To unsubscribe from this group, send email to 
reviewboard-issues+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/reviewboard-issues?hl=en.



Re: Issue 1183 in reviewboard: Viewing diff in review request causes traceback involving memcache

2010-09-28 Thread reviewboard


Comment #7 on issue 1183 by eero.temp: Viewing diff in review request  
causes traceback involving memcache

http://code.google.com/p/reviewboard/issues/detail?id=1183

Here's the original diff...

Attachments:
test.diff  288 bytes

--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To post to this group, send email to reviewboard-iss...@googlegroups.com.
To unsubscribe from this group, send email to 
reviewboard-issues+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/reviewboard-issues?hl=en.



Re: Issue 1136 in reviewboard: Support for apache/mod_wsgi

2010-09-28 Thread reviewboard


Comment #6 on issue 1136 by julian.mehnle: Support for apache/mod_wsgi
http://code.google.com/p/reviewboard/issues/detail?id=1136

For the record, I think the revisions this was fixed in really were

http://github.com/reviewboard/reviewboard/commit/e4aa4ff94fef7745fc1e137575e9ebe6b61fa88d
http://github.com/reviewboard/reviewboard/commit/c4355f102f7a5766f45c54245670a0009df8f660

--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To post to this group, send email to reviewboard-iss...@googlegroups.com.
To unsubscribe from this group, send email to 
reviewboard-issues+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/reviewboard-issues?hl=en.