Re: How to use post-review with a private GitHub repository?
Anyone?
On Sep 29, 10:43 am, Gustavo Narea gna...@tech.2degreesnetwork.com
wrote:
I forgot to mention how I'm running post-review:
$ cd /srv/mirrors/project
$ post-review --server=http://example.org/reviews/--guess-summary
--guess-description --username=foo --password=baz --submit-as=bar --
tracking-branch=origin/master -d
Cheers.
On Sep 29, 10:40 am, Gustavo Narea gna...@tech.2degreesnetwork.com
wrote:
Hello, Christian.
Thank you very much for your response.
Yes, I configured the repository the way you said. But I just noticed
that the problem was that Review Board wasn't generating the right
raw file URL mask for organization accounts. I had to change it
from:
http://github.com/api/v2/yaml/blob/show/ORGANIZATION/PROJECT/revision?login=ORGANIZATIONtoken=MY_API_TOKEN
to:
http://github.com/api/v2/yaml/blob/show/ORGANIZATION/PROJECT/revision?login=MEtoken=MY_API_TOKEN
Even though I had set the username to ME in the form.
However, it's still not working and I think this time it's a bug:
=
Uploading diff, size: 648218
HTTP POSTing
tohttps://example.org/reviews/api/json/reviewrequests/62/diff/new/:{}
Got API Error 105 (HTTP code 200): One or more fields had errors
Error data: {'fields': {'path': [object of type 'Revision' has no
len()]}, 'stat': 'fail', 'err': {'msg': 'One or more fields had
errors', 'code': 105}, 'deprecated': {'in_version': '1.5'}}
Error uploading diff
The generated diff file was empty. This usually means no files were
modified in this change.
Try running with --output-diff and --debug for more information.
Your review request still exists, but the diff is not attached.
=
I can see the following traceback in the Apache logs:
=
ERROR:root:Error uploading new diff: object of type 'Revision' has no
len()
Traceback (most recent call last):
File /srv/dev/review-board/virtualenv/lib/python2.5/site-packages/
ReviewBoard-1.5rc2-py2.5.egg/reviewboard/webapi/json.py, line 1169,
in new_diff
request.FILES.get('parent_diff_path'))
File /srv/dev/review-board/virtualenv/lib/python2.5/site-packages/
ReviewBoard-1.5rc2-py2.5.egg/reviewboard/reviews/forms.py, line 249,
in create
history)
File /srv/dev/review-board/virtualenv/lib/python2.5/site-packages/
ReviewBoard-1.5rc2-py2.5.egg/reviewboard/diffviewer/forms.py, line
63, in create
diff_file, basedir, check_existance=(not parent_diff_file)))
File /srv/dev/review-board/virtualenv/lib/python2.5/site-packages/
ReviewBoard-1.5rc2-py2.5.egg/reviewboard/diffviewer/forms.py, line
137, in _process_files
f2, revision = tool.parse_diff_revision(f.origFile, f.origInfo)
File /srv/dev/review-board/virtualenv/lib/python2.5/site-packages/
ReviewBoard-1.5rc2-py2.5.egg/reviewboard/scmtools/git.py, line 82, in
parse_diff_revision
self.client.validate_sha1_format(file_str, revision)
File /srv/dev/review-board/virtualenv/lib/python2.5/site-packages/
ReviewBoard-1.5rc2-py2.5.egg/reviewboard/scmtools/git.py, line 348,
in validate_sha1_format
if self.raw_file_url and len(sha1) != self.FULL_SHA1_LENGTH:
TypeError: object of type 'Revision' has no len()
=
Cheers,
- Gustavo.
On Sep 28, 6:49 pm, Christian Hammond chip...@chipx86.com wrote:
When adding the repository entries, did you type the paths by hand?
You should make sure to configure the repository with a Hosting Service
of
GitHub (Private) and then fill in the requested fields from there. You
will need your API Token from your GitHub account (the one owning the
project in question).
Christian
--
Christian Hammond - chip...@chipx86.com
Review Board -http://www.reviewboard.org
VMware, Inc. -http://www.vmware.com
On Tue, Sep 28, 2010 at 9:57 AM, Gustavo Narea
gna...@tech.2degreesnetwork.com wrote:
Hello,
I cannot find the way to get post-review to work with a private GitHub
repository. Can you please give me a hand? This is driving me crazy,
specially after spending days migrating to Git pretty much to use
Review Board. :)
I have successfully configured the repository on the Web interface and
I have a local mirror of that repository, which I had to create just
to be able to run post-review (it errors out if I call it from another
directory); both repositories are registered in Review Board (i.e.,
g...@github.com:us/project.git and /srv/mirror/project).
I'm trying to generate a review for all the changes that happened in a
feature branch, which was started from master. This is how I run it:
$ cd /srv/mirror/project
$ post-review --server=http://example.org/reviews/--guess-summary--
guess-description --username=foo --password=bar --submit-as=baz --
tracking-branch=origin/master
But I get the following:
(...)
Uploading diff, size: 648218
HTTP POSTing to
Re: Active Directory
Does no one use active directory integration then? Thanks, Al On 5 October 2010 18:05, albal a...@tsew.net wrote: Hi, I'm trying to get Active Directory Authentication working with ReviewBoard 1.5. I am running on Debian-Lenny and I have a successful install of ReviewBoard but I would like to have our users authenticate against our domain servers. If I put the domain controller IP or name in the field and hit save, then logout and back in I get the following log entries: 2010-10-05 16:58:18,943 - WARNING - Active Directory: Domain controller is down 2010-10-05 16:58:18,943 - ERROR - Active Directory error: Could not contact any domain controller servers The linux machine is not part of the domain, DNS is setup correctly and the hostnames resolve fine. Is there something else that needs to be in place? Thanks, Al -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: How to use post-review with a private GitHub repository?
Hi,
Sorry, I missed the updates to this.
Okay, so two things:
1) The TypeError: object of type 'Revision' has no len() should be fixed
in the final 1.5 release.
2) Organizations aren't supported yet, but it's high on my priority list. I
want to get it in for 1.5.1, or 1.5.2 at the latest. There's a bug tracking
this: http://code.google.com/p/reviewboard/issues/detail?id=1834
Are you running 1.5, or an RC?
Christian
--
Christian Hammond - chip...@chipx86.com
Review Board - http://www.reviewboard.org
VMware, Inc. - http://www.vmware.com
On Mon, Oct 11, 2010 at 2:24 AM, Gustavo Narea
gna...@tech.2degreesnetwork.com wrote:
Anyone?
On Sep 29, 10:43 am, Gustavo Narea gna...@tech.2degreesnetwork.com
wrote:
I forgot to mention how I'm running post-review:
$ cd /srv/mirrors/project
$ post-review --server=http://example.org/reviews/--guess-summary
--guess-description --username=foo --password=baz --submit-as=bar --
tracking-branch=origin/master -d
Cheers.
On Sep 29, 10:40 am, Gustavo Narea gna...@tech.2degreesnetwork.com
wrote:
Hello, Christian.
Thank you very much for your response.
Yes, I configured the repository the way you said. But I just noticed
that the problem was that Review Board wasn't generating the right
raw file URL mask for organization accounts. I had to change it
from:
http://github.com/api/v2/yaml/blob/show/ORGANIZATION/PROJECT/
revision?login=ORGANIZATIONtoken=MY_API_TOKEN
to:
http://github.com/api/v2/yaml/blob/show/ORGANIZATION/PROJECT/
revision?login=MEtoken=MY_API_TOKEN
Even though I had set the username to ME in the form.
However, it's still not working and I think this time it's a bug:
=
Uploading diff, size: 648218
HTTP POSTing tohttps://
example.org/reviews/api/json/reviewrequests/62/diff/new/:{}http://example.org/reviews/api/json/reviewrequests/62/diff/new/:%7B%7D
Got API Error 105 (HTTP code 200): One or more fields had errors
Error data: {'fields': {'path': [object of type 'Revision' has no
len()]}, 'stat': 'fail', 'err': {'msg': 'One or more fields had errors',
'code': 105}, 'deprecated': {'in_version': '1.5'}}
Error uploading diff
The generated diff file was empty. This usually means no files were
modified in this change.
Try running with --output-diff and --debug for more information.
Your review request still exists, but the diff is not attached.
=
I can see the following traceback in the Apache logs:
=
ERROR:root:Error uploading new diff: object of type 'Revision' has no
len()
Traceback (most recent call last):
File /srv/dev/review-board/virtualenv/lib/python2.5/site-packages/
ReviewBoard-1.5rc2-py2.5.egg/reviewboard/webapi/json.py, line 1169,
in new_diff
request.FILES.get('parent_diff_path'))
File /srv/dev/review-board/virtualenv/lib/python2.5/site-packages/
ReviewBoard-1.5rc2-py2.5.egg/reviewboard/reviews/forms.py, line 249,
in create
history)
File /srv/dev/review-board/virtualenv/lib/python2.5/site-packages/
ReviewBoard-1.5rc2-py2.5.egg/reviewboard/diffviewer/forms.py, line
63, in create
diff_file, basedir, check_existance=(not parent_diff_file)))
File /srv/dev/review-board/virtualenv/lib/python2.5/site-packages/
ReviewBoard-1.5rc2-py2.5.egg/reviewboard/diffviewer/forms.py, line
137, in _process_files
f2, revision = tool.parse_diff_revision(f.origFile, f.origInfo)
File /srv/dev/review-board/virtualenv/lib/python2.5/site-packages/
ReviewBoard-1.5rc2-py2.5.egg/reviewboard/scmtools/git.py, line 82, in
parse_diff_revision
self.client.validate_sha1_format(file_str, revision)
File /srv/dev/review-board/virtualenv/lib/python2.5/site-packages/
ReviewBoard-1.5rc2-py2.5.egg/reviewboard/scmtools/git.py, line 348,
in validate_sha1_format
if self.raw_file_url and len(sha1) != self.FULL_SHA1_LENGTH:
TypeError: object of type 'Revision' has no len()
=
Cheers,
- Gustavo.
On Sep 28, 6:49 pm, Christian Hammond chip...@chipx86.com wrote:
When adding the repository entries, did you type the paths by hand?
You should make sure to configure the repository with a Hosting
Service of
GitHub (Private) and then fill in the requested fields from there.
You
will need your API Token from your GitHub account (the one owning the
project in question).
Christian
--
Christian Hammond - chip...@chipx86.com
Review Board -http://www.reviewboard.org
VMware, Inc. -http://www.vmware.com
On Tue, Sep 28, 2010 at 9:57 AM, Gustavo Narea
gna...@tech.2degreesnetwork.com wrote:
Hello,
I cannot find the way to get post-review to work with a private
GitHub
repository. Can you please give me a hand? This is driving me
crazy,
specially after spending days migrating to Git pretty much to use
Review Board. :)
I have
Re: Active Directory
Hi, People do use it, but I guess nobody who uses it has had anything useful to contribute to this. The error you're getting is what we get from the Python ldap library when it determines that the server name you provided is down. This would indicate that either the machine is unreachable or that the port on it can't be reached. Are you able to ping the AD server as specified in Review Board's AD configuration from the Review Board server? Christian -- Christian Hammond - chip...@chipx86.com Review Board - http://www.reviewboard.org VMware, Inc. - http://www.vmware.com On Mon, Oct 11, 2010 at 2:30 AM, Al West a...@tsew.net wrote: Does no one use active directory integration then? Thanks, Al On 5 October 2010 18:05, albal a...@tsew.net wrote: Hi, I'm trying to get Active Directory Authentication working with ReviewBoard 1.5. I am running on Debian-Lenny and I have a successful install of ReviewBoard but I would like to have our users authenticate against our domain servers. If I put the domain controller IP or name in the field and hit save, then logout and back in I get the following log entries: 2010-10-05 16:58:18,943 - WARNING - Active Directory: Domain controller is down 2010-10-05 16:58:18,943 - ERROR - Active Directory error: Could not contact any domain controller servers The linux machine is not part of the domain, DNS is setup correctly and the hostnames resolve fine. Is there something else that needs to be in place? Thanks, Al -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.comreviewboard%2bunsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: How to use post-review with a private GitHub repository?
Hello, Christian.
On Oct 11, 10:46 am, Christian Hammond chip...@chipx86.com wrote:
Sorry, I missed the updates to this.
It's alright ;-)
Okay, so two things:
1) The TypeError: object of type 'Revision' has no len() should be fixed
in the final 1.5 release.
OK, I'm using the second RC.
2) Organizations aren't supported yet, but it's high on my priority list. I
want to get it in for 1.5.1, or 1.5.2 at the latest. There's a bug tracking
this:http://code.google.com/p/reviewboard/issues/detail?id=1834
I think a workaround would be to alter the configuration after adding
the repository on RB, as I did above. With those changes, there
doesn't seem to be any problem connecting to GitHub. Do you think I
still need that fix to be able to use GitHub with our organization
account?
Cheers.
On Mon, Oct 11, 2010 at 2:24 AM, Gustavo Narea
gna...@tech.2degreesnetwork.com wrote:
Anyone?
On Sep 29, 10:43 am, Gustavo Narea gna...@tech.2degreesnetwork.com
wrote:
I forgot to mention how I'm running post-review:
$ cd /srv/mirrors/project
$ post-review --server=http://example.org/reviews/--guess-summary
--guess-description --username=foo --password=baz --submit-as=bar --
tracking-branch=origin/master -d
Cheers.
On Sep 29, 10:40 am, Gustavo Narea gna...@tech.2degreesnetwork.com
wrote:
Hello, Christian.
Thank you very much for your response.
Yes, I configured the repository the way you said. But I just noticed
that the problem was that Review Board wasn't generating the right
raw file URL mask for organization accounts. I had to change it
from:
http://github.com/api/v2/yaml/blob/show/ORGANIZATION/PROJECT/
revision?login=ORGANIZATIONtoken=MY_API_TOKEN
to:
http://github.com/api/v2/yaml/blob/show/ORGANIZATION/PROJECT/
revision?login=MEtoken=MY_API_TOKEN
Even though I had set the username to ME in the form.
However, it's still not working and I think this time it's a bug:
=
Uploading diff, size: 648218
HTTP POSTing tohttps://
example.org/reviews/api/json/reviewrequests/62/diff/new/:{}http://example.org/reviews/api/json/reviewrequests/62/diff/new/:%7B%7D
Got API Error 105 (HTTP code 200): One or more fields had errors
Error data: {'fields': {'path': [object of type 'Revision' has no
len()]}, 'stat': 'fail', 'err': {'msg': 'One or more fields had errors',
'code': 105}, 'deprecated': {'in_version': '1.5'}}
Error uploading diff
The generated diff file was empty. This usually means no files were
modified in this change.
Try running with --output-diff and --debug for more information.
Your review request still exists, but the diff is not attached.
=
I can see the following traceback in the Apache logs:
=
ERROR:root:Error uploading new diff: object of type 'Revision' has no
len()
Traceback (most recent call last):
File /srv/dev/review-board/virtualenv/lib/python2.5/site-packages/
ReviewBoard-1.5rc2-py2.5.egg/reviewboard/webapi/json.py, line 1169,
in new_diff
request.FILES.get('parent_diff_path'))
File /srv/dev/review-board/virtualenv/lib/python2.5/site-packages/
ReviewBoard-1.5rc2-py2.5.egg/reviewboard/reviews/forms.py, line 249,
in create
history)
File /srv/dev/review-board/virtualenv/lib/python2.5/site-packages/
ReviewBoard-1.5rc2-py2.5.egg/reviewboard/diffviewer/forms.py, line
63, in create
diff_file, basedir, check_existance=(not parent_diff_file)))
File /srv/dev/review-board/virtualenv/lib/python2.5/site-packages/
ReviewBoard-1.5rc2-py2.5.egg/reviewboard/diffviewer/forms.py, line
137, in _process_files
f2, revision = tool.parse_diff_revision(f.origFile, f.origInfo)
File /srv/dev/review-board/virtualenv/lib/python2.5/site-packages/
ReviewBoard-1.5rc2-py2.5.egg/reviewboard/scmtools/git.py, line 82, in
parse_diff_revision
self.client.validate_sha1_format(file_str, revision)
File /srv/dev/review-board/virtualenv/lib/python2.5/site-packages/
ReviewBoard-1.5rc2-py2.5.egg/reviewboard/scmtools/git.py, line 348,
in validate_sha1_format
if self.raw_file_url and len(sha1) != self.FULL_SHA1_LENGTH:
TypeError: object of type 'Revision' has no len()
=
Cheers,
- Gustavo.
On Sep 28, 6:49 pm, Christian Hammond chip...@chipx86.com wrote:
When adding the repository entries, did you type the paths by hand?
You should make sure to configure the repository with a Hosting
Service of
GitHub (Private) and then fill in the requested fields from there.
You
will need your API Token from your GitHub account (the one owning the
project in question).
Christian
--
Christian Hammond - chip...@chipx86.com
Review Board -http://www.reviewboard.org
VMware, Inc. -http://www.vmware.com
On Tue, Sep 28, 2010 at 9:57 AM, Gustavo Narea
Re: How to use post-review with a private GitHub repository?
BTW, if I install the development code, would I be able to use RB with
GitHub?
Cheers.
On Oct 11, 10:52 am, Gustavo Narea gna...@tech.2degreesnetwork.com
wrote:
Hello, Christian.
On Oct 11, 10:46 am, Christian Hammond chip...@chipx86.com wrote:
Sorry, I missed the updates to this.
It's alright ;-)
Okay, so two things:
1) The TypeError: object of type 'Revision' has no len() should be fixed
in the final 1.5 release.
OK, I'm using the second RC.
2) Organizations aren't supported yet, but it's high on my priority list. I
want to get it in for 1.5.1, or 1.5.2 at the latest. There's a bug tracking
this:http://code.google.com/p/reviewboard/issues/detail?id=1834
I think a workaround would be to alter the configuration after adding
the repository on RB, as I did above. With those changes, there
doesn't seem to be any problem connecting to GitHub. Do you think I
still need that fix to be able to use GitHub with our organization
account?
Cheers.
On Mon, Oct 11, 2010 at 2:24 AM, Gustavo Narea
gna...@tech.2degreesnetwork.com wrote:
Anyone?
On Sep 29, 10:43 am, Gustavo Narea gna...@tech.2degreesnetwork.com
wrote:
I forgot to mention how I'm running post-review:
$ cd /srv/mirrors/project
$ post-review --server=http://example.org/reviews/--guess-summary
--guess-description --username=foo --password=baz --submit-as=bar --
tracking-branch=origin/master -d
Cheers.
On Sep 29, 10:40 am, Gustavo Narea gna...@tech.2degreesnetwork.com
wrote:
Hello, Christian.
Thank you very much for your response.
Yes, I configured the repository the way you said. But I just noticed
that the problem was that Review Board wasn't generating the right
raw file URL mask for organization accounts. I had to change it
from:
http://github.com/api/v2/yaml/blob/show/ORGANIZATION/PROJECT/
revision?login=ORGANIZATIONtoken=MY_API_TOKEN
to:
http://github.com/api/v2/yaml/blob/show/ORGANIZATION/PROJECT/
revision?login=MEtoken=MY_API_TOKEN
Even though I had set the username to ME in the form.
However, it's still not working and I think this time it's a bug:
=
Uploading diff, size: 648218
HTTP POSTing tohttps://
example.org/reviews/api/json/reviewrequests/62/diff/new/:{}http://example.org/reviews/api/json/reviewrequests/62/diff/new/:%7B%7D
Got API Error 105 (HTTP code 200): One or more fields had errors
Error data: {'fields': {'path': [object of type 'Revision' has no
len()]}, 'stat': 'fail', 'err': {'msg': 'One or more fields had errors',
'code': 105}, 'deprecated': {'in_version': '1.5'}}
Error uploading diff
The generated diff file was empty. This usually means no files were
modified in this change.
Try running with --output-diff and --debug for more information.
Your review request still exists, but the diff is not attached.
=
I can see the following traceback in the Apache logs:
=
ERROR:root:Error uploading new diff: object of type 'Revision' has no
len()
Traceback (most recent call last):
File /srv/dev/review-board/virtualenv/lib/python2.5/site-packages/
ReviewBoard-1.5rc2-py2.5.egg/reviewboard/webapi/json.py, line 1169,
in new_diff
request.FILES.get('parent_diff_path'))
File /srv/dev/review-board/virtualenv/lib/python2.5/site-packages/
ReviewBoard-1.5rc2-py2.5.egg/reviewboard/reviews/forms.py, line 249,
in create
history)
File /srv/dev/review-board/virtualenv/lib/python2.5/site-packages/
ReviewBoard-1.5rc2-py2.5.egg/reviewboard/diffviewer/forms.py, line
63, in create
diff_file, basedir, check_existance=(not parent_diff_file)))
File /srv/dev/review-board/virtualenv/lib/python2.5/site-packages/
ReviewBoard-1.5rc2-py2.5.egg/reviewboard/diffviewer/forms.py, line
137, in _process_files
f2, revision = tool.parse_diff_revision(f.origFile, f.origInfo)
File /srv/dev/review-board/virtualenv/lib/python2.5/site-packages/
ReviewBoard-1.5rc2-py2.5.egg/reviewboard/scmtools/git.py, line 82, in
parse_diff_revision
self.client.validate_sha1_format(file_str, revision)
File /srv/dev/review-board/virtualenv/lib/python2.5/site-packages/
ReviewBoard-1.5rc2-py2.5.egg/reviewboard/scmtools/git.py, line 348,
in validate_sha1_format
if self.raw_file_url and len(sha1) != self.FULL_SHA1_LENGTH:
TypeError: object of type 'Revision' has no len()
=
Cheers,
- Gustavo.
On Sep 28, 6:49 pm, Christian Hammond chip...@chipx86.com wrote:
When adding the repository entries, did you type the paths by hand?
You should make sure to configure the repository with a Hosting
Service of
GitHub (Private) and then fill in the requested fields from there.
You
will need your API Token from your GitHub account
RE: Active Directory
We use AD auth on our Windows server and it works great. If you would like help with the settings then please email me personally (I don't want to post our params). Tim From: reviewboard@googlegroups.com [mailto:reviewbo...@googlegroups.com] On Behalf Of Christian Hammond Sent: October-11-10 5:50 AM To: reviewboard@googlegroups.com Subject: Re: Active Directory Hi, People do use it, but I guess nobody who uses it has had anything useful to contribute to this. The error you're getting is what we get from the Python ldap library when it determines that the server name you provided is down. This would indicate that either the machine is unreachable or that the port on it can't be reached. Are you able to ping the AD server as specified in Review Board's AD configuration from the Review Board server? Christian -- Christian Hammond - chip...@chipx86.com Review Board - http://www.reviewboard.org VMware, Inc. - http://www.vmware.com On Mon, Oct 11, 2010 at 2:30 AM, Al West a...@tsew.net wrote: Does no one use active directory integration then? Thanks, Al On 5 October 2010 18:05, albal a...@tsew.net wrote: Hi, I'm trying to get Active Directory Authentication working with ReviewBoard 1.5. I am running on Debian-Lenny and I have a successful install of ReviewBoard but I would like to have our users authenticate against our domain servers. If I put the domain controller IP or name in the field and hit save, then logout and back in I get the following log entries: 2010-10-05 16:58:18,943 - WARNING - Active Directory: Domain controller is down 2010-10-05 16:58:18,943 - ERROR - Active Directory error: Could not contact any domain controller servers The linux machine is not part of the domain, DNS is setup correctly and the hostnames resolve fine. Is there something else that needs to be in place? Thanks, Al -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com mailto:reviewboard%2bunsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: Active Directory
Okay so at least I know it works! I did try using LDAP settings but it's only my second time using LDAP on Linux so I was getting the parameters wrong and locked myself out a few times. How does one reset the authentication settings if this happens. Though I don't have anything uploaded to review board it would save me doing a reinstall each time I lock myself out. The error I came across with LDAP was that it had failed to bind to the server and from reading other similar problems it seemed as though the intial connection had to have login credentials to perform the bind. On a previous system I did not have to do this, anonymous bind should work fine. Cheers, Al On 11 October 2010 14:05, Jan Koprowski jan.koprow...@gmail.com wrote: We also use ReviewBoard with AD authentication but in our situation we use LDAP option which have some additional fields which allow restrict access to users selected by filter. This work really good - without problems with AD. On Mon, Oct 11, 2010 at 2:44 PM, Tim Pinet tim.pi...@gmail.com wrote: We use AD auth on our Windows server and it works great. If you would like help with the settings then please email me personally (I don’t want to post our params). Tim From: reviewboard@googlegroups.com [mailto:reviewbo...@googlegroups.com] On Behalf Of Christian Hammond Sent: October-11-10 5:50 AM To: reviewboard@googlegroups.com Subject: Re: Active Directory Hi, People do use it, but I guess nobody who uses it has had anything useful to contribute to this. The error you're getting is what we get from the Python ldap library when it determines that the server name you provided is down. This would indicate that either the machine is unreachable or that the port on it can't be reached. Are you able to ping the AD server as specified in Review Board's AD configuration from the Review Board server? Christian -- Christian Hammond - chip...@chipx86.com Review Board - http://www.reviewboard.org VMware, Inc. - http://www.vmware.com On Mon, Oct 11, 2010 at 2:30 AM, Al West a...@tsew.net wrote: Does no one use active directory integration then? Thanks, Al On 5 October 2010 18:05, albal a...@tsew.net wrote: Hi, I'm trying to get Active Directory Authentication working with ReviewBoard 1.5. I am running on Debian-Lenny and I have a successful install of ReviewBoard but I would like to have our users authenticate against our domain servers. If I put the domain controller IP or name in the field and hit save, then logout and back in I get the following log entries: 2010-10-05 16:58:18,943 - WARNING - Active Directory: Domain controller is down 2010-10-05 16:58:18,943 - ERROR - Active Directory error: Could not contact any domain controller servers The linux machine is not part of the domain, DNS is setup correctly and the hostnames resolve fine. Is there something else that needs to be in place? Thanks, Al -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -- Jan Koprowski -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: Active Directory
On Mon, Oct 11, 2010 at 15:18, Al West a...@tsew.net wrote: Okay so at least I know it works! I did try using LDAP settings but it's only my second time using LDAP on Linux so I was getting the parameters wrong and locked myself out a few times. How does one reset the authentication settings if this happens. Though I don't have anything uploaded to review board it would save me doing a reinstall each time I lock myself out. Reinstalling is not strictly necessary as you can tweak the site configuration (and reset it to safe defaults) on the database. Apart from that you may want to look into tcpdump to figure out whether any communication is happening at all and where it starts failing (does it talk to the LDAP server, does the DNS lookup fail, etc.). Regards, Thilo -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: RB 1.0.9 - 1.5 upgrade woes
Hi Christian, On Sat, Oct 9, 2010 at 08:15, Christian Hammond chip...@chipx86.com wrote: We don't have any permission enforcement for submitting review requests, so I can't imagine what would be causing that problem. Nor can I imagine why everything would be using your admin user. These are base things that haven't really changed in 1.5, and we certainly haven't seen these issues yet. Do you happen to have a diff of your changes to post-review? This one may be a little tricky. ;-) While I have a full history of my changes to post-review in SVN, the initial official post-review codebase is most likely not amongst them. So, if I figure out the upstream release I may be able to create a full diff. And do you have any changes to Review Board itself? Yep. Custom SCMTool for our proprietary SCM + X.509+ActiveDirectory integration. So, yes, the authentication part is custom and I cannot completely rule out that I messed it up when porting it to RB 1.5. What happens if you upload a diff through the web UI instead, or through standard post-review? Didn't try this yet, as our SCMs (Perforce + Proprietary) require some post-processing of the diffs to be usable for RB. My gut feeling is that this is something specific to your customizations, but I'd like to know for sure. ACK. I have set up a test installation based on production data and will play around with it a little over the next days to pinpoint what exactly went wrong. Regards, Thilo -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: starting review #
I ended up just mothballing the old installation on the original server and setting up a new 1.5 on a virtual machine. We now primarily just use the new installation and every once and a while, I hear of people looking back at old reviews on the old server. I forget now, but I had to alter a couple things to get the right autoincrement, but it has been working great. jon On Mon, Oct 11, 2010 at 8:42 PM, mxbraun matthew.br...@intel.com wrote: Jon, Did this really do what you wanted? I find myself in much the same situation, of having an ancient RB implementation in use, setting up a more modern one, and the prospect of either keeping the old one around for some indeterminite amount of time. The question I have is: isn't reviews_review a table of completed reviews? The 'id' field in reviews_review seems to have the auto_increment attribute. Isn't the thing you want to adjust reviews_reviewrequest table, so that the review *request* numbers don't collide with the old ones, rather than the completed review records? . Once I executed ALTER TABLE reviews_reviewrequest 2; I got review requests numbered up that high. (Of course, I changed reviews_reviewrequest *after* changing reviews_review. So now my IDs in the reviews_review table are starting at around 2. Gulp!) Thanks, m@ On Aug 21, 6:48 pm, Jon Stevens latch...@gmail.com wrote: Lol. That confirms my suspicions. No worries, we are fine just mothballing the old release and I'll set the review number to be n+1. Thanks for the help! Jon On Aug 21, 2010, at 11:40 AM, Christian Hammond chip...@chipx86.com wrote: In that case, an upgrade could potentially be tricky... Yeah, might want to just start off with a new install. Christian -- Christian Hammond - chip...@chipx86.com Review Board -http://www.reviewboard.org VMware, Inc. -http://www.vmware.com On Sat, Aug 21, 2010 at 7:22 AM, Jon Stevens latch...@gmail.com wrote: I'm inheriting this installation so I'm not entirely sure of it's history. I believe that it was essentially a checkout of the source code at some point at least a couple years ago and has never been upgraded. jon On Sat, Aug 21, 2010 at 12:11 AM, Christian Hammond chip...@chipx86.com wrote: Hi Jon, It really depends on how old the version is. Unfortunately, at that time, we didn't really have version numbers that meant anything. Can you tell me how you performed database upgrades on the old install? Was it using the old load-db.py and dump-db.py scripts, or was it using ./manage.py evolve? Also, were you using rb-site? Christian -- Christian Hammond - chip...@chipx86.com Review Board -http://www.reviewboard.org VMware, Inc. -http://www.vmware.com On Fri, Aug 20, 2010 at 9:05 PM, Jon Stevens latch...@gmail.com wrote: Hi Christian, Thanks for the fast response. I haven't tried upgrading things. I guess I could try that, but I got the impression from somewhere that it would be difficult to do so from the early version that we are currently running. If you think it is worth trying, then that is probably the ideal route. cheers, jon On Fri, Aug 20, 2010 at 8:16 PM, Christian Hammond chip...@chipx86.com wrote: Hi Jon, Your plan to use ALTER TABLE should work. review_request_id just holds the current ID. That's what should be auto_increment. I think so long as you do that, you'll see the review request ID number you expect. By the way, what problems did you hit with upgrading? Christian -- Christian Hammond - chip...@chipx86.com Review Board -http://www.reviewboard.org VMware, Inc. -http://www.vmware.com On Fri, Aug 20, 2010 at 5:47 PM, jon latch...@gmail.com wrote: Apologies if this has been covered before, google didn't seem to have an obvious answer. Is it possible to set a starting review # for a clean install? The issue is that we have a pre-1.0 installation that has been in use for awhile now. Instead of trying to figure out how to upgrade the database, I've just created a fresh new installation (of 1.5rc1) on a fresh new server and we are just going to consider the previous version effectively read-only. But, on the new server, I'd like to start the review number +1 higher than the old server so that we don't have conflicting numbers in svn commit messages. I see that reviews_review.id is auto_increment. I know that I can do: ALTER TABLE reviews_review AUTO_INCREMENT = 100;, but I also see a 'review_request_id' column. What is that used for? Do you see any other issues with this approach? thanks, jon -- Want to help the Review Board project? Donate today athttp:// www.reviewboard.org/donate/ Happy user? Let us know athttp://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to
Re: Issue 1823 in reviewboard: reports an XML file as binary when it is text.
Comment #2 on issue 1823 by cppgent0: reports an XML file as binary when it is text. http://code.google.com/p/reviewboard/issues/detail?id=1823 It's mercurial. Looks like mercurial calls it binary to prevent merging from occurring. Any way to get reviewboard to override this and treat it as text anyway? -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-iss...@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 1823 in reviewboard: reports an XML file as binary when it is text.
Comment #3 on issue 1823 by chipx86: reports an XML file as binary when it is text. http://code.google.com/p/reviewboard/issues/detail?id=1823 If it's part of the diff, we're out of luck. We're doing what we're told to do from the diff. -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-iss...@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 1823 in reviewboard: reports an XML file as binary when it is text.
Comment #4 on issue 1823 by cppgent0: reports an XML file as binary when it is text. http://code.google.com/p/reviewboard/issues/detail?id=1823 Understood. Well there's luck for you :) Thanks anyway. -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-iss...@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 1823 in reviewboard: reports an XML file as binary when it is text.
Updates: Status: ThirdParty Comment #5 on issue 1823 by trowbrds: reports an XML file as binary when it is text. http://code.google.com/p/reviewboard/issues/detail?id=1823 (No comment was entered for this change.) -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-iss...@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
