ReviewBoard not displaying content of diff file
I have just started trying out reviewboard and I have some issues with some diffs not beeing displayed when I click View diff in the review request. When i download the diff I can see the content: Index: //trunk/library/extras/global-post-commit-hook.php === --- //trunk/library/extras/global-post-commit-hook.php (revision 1901) +++ //trunk/library/extras/global-post-commit-hook.php (revision 1902) @@ -64,4 +64,4 @@ $revision)); } -// Test \ No newline at end of file +// Test Why does this not get displayed? -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: 1.0.8 - 1.5 upgrade issues with repository management
Thanks a lot! Removing this tool solved the issues. I've added it a
year ago trying to setup demo and forgot about that.
-- Sergey
On Oct 13, 8:41 am, Christian Hammond chip...@chipx86.com wrote:
It sounds like you have the localfile scmtool installed in your database,
which is really only for testing and hasn't been maintained in forever. You
need to remove the database entry for that in scmtools_tool.
Were you using this SCMTool for anything?
Christian
--
Christian Hammond - chip...@chipx86.com
Review Board -http://www.reviewboard.org
VMware, Inc. -http://www.vmware.com
On Tue, Oct 12, 2010 at 3:48 AM, sergius sergey.serg...@googlemail.comwrote:
I've got next issue after upgrade. Any operation with repositories
(edit/add) leads to next error:
TemplateSyntaxError at /admin/db/scmtools/repository/59/
Caught ImproperlyConfigured while rendering: Error importing SCM Tool
reviewboard.scmtools.localfile: No module named scmtools.core
Any help would be greatly appreciated :)
Traceback:
Environment:
Request Method: GET
Request URL:http://reviewboard-server/admin/db/scmtools/repository/59/
Django Version: 1.2.1
Python Version: 2.6.2
Installed Applications:
['django.contrib.admin',
'django.contrib.auth',
'django.contrib.contenttypes',
'django.contrib.markup',
'django.contrib.sites',
'django.contrib.sessions',
'djblets.datagrid',
'djblets.feedview',
'djblets.log',
'djblets.siteconfig',
'djblets.util',
'djblets.webapi',
'reviewboard.accounts',
'reviewboard.admin',
'reviewboard.changedescs',
'reviewboard.diffviewer',
'reviewboard.iphone',
'reviewboard.notifications',
'reviewboard.reports',
'reviewboard.reviews',
'reviewboard.scmtools',
'reviewboard.webapi',
'django_evolution']
Installed Middleware:
('django.middleware.gzip.GZipMiddleware',
'django.middleware.common.CommonMiddleware',
'django.middleware.doc.XViewMiddleware',
'django.middleware.http.ConditionalGetMiddleware',
'django.middleware.locale.LocaleMiddleware',
'django.contrib.sessions.middleware.SessionMiddleware',
'django.contrib.auth.middleware.AuthenticationMiddleware',
'djblets.siteconfig.middleware.SettingsMiddleware',
'reviewboard.admin.middleware.LoadSettingsMiddleware',
'djblets.log.middleware.LoggingMiddleware',
'reviewboard.admin.middleware.CheckUpdatesRequiredMiddleware',
'reviewboard.admin.middleware.X509AuthMiddleware')
Template error:
In template /usr/local/lib/python2.6/dist-packages/ReviewBoard-1.5-
py2.6.egg/reviewboard/templates/admin/scmtools/repository/
change_form.html, error at line 46
Caught ImproperlyConfigured while rendering: Error importing SCM
Tool reviewboard.scmtools.localfile: No module named scmtools.core
36 : {{field}}{% if not forloop.last %},{% endif %}
37 : {% endfor %}
38 : {% endspaceless %} ]{% if not forloop.last %},{% endif
%}
39 : {% endfor %}
40 : }{% endspaceless %}
41 :
42 : var TOOLS_FIELDS = { {% spaceless %}
43 : none: [ raw_file_url, username, password ],
44 : {% for tool in adminform.form.tool.field.queryset %}
45 : {{tool.id}}: [ {% spaceless %}
46 : {% if tool.supports_raw_file_urls %}
47 : raw_file_url,
48 : {% endif %}
49 : username, password
50 : {% endspaceless %} ]{% if not forloop.last %},{% endif
%}
51 : {% endfor %}
52 : }{% endspaceless %}
53 :
54 : var HOSTING_SERVICE_TOOLS = { {% spaceless %}
55 : {% for id, info in adminform.form.HOSTING_SERVICE_INFO.items
%}
56 : {{id}}: [ {% spaceless %}
Traceback:
File /usr/local/lib/python2.6/dist-packages/Django-1.2.1-py2.6.egg/
django/core/handlers/base.py in get_response
100. response = callback(request,
*callback_args, **callback_kwargs)
File /usr/local/lib/python2.6/dist-packages/Django-1.2.1-py2.6.egg/
django/contrib/admin/sites.py in root
512. return self.model_page(request, *url.split('/',
2))
File /usr/local/lib/python2.6/dist-packages/Django-1.2.1-py2.6.egg/
django/views/decorators/cache.py in _wrapped_view_func
69. response = view_func(request, *args, **kwargs)
File /usr/local/lib/python2.6/dist-packages/Django-1.2.1-py2.6.egg/
django/contrib/admin/sites.py in model_page
531. return admin_obj(request, rest_of_url)
File /usr/local/lib/python2.6/dist-packages/Django-1.2.1-py2.6.egg/
django/contrib/admin/options.py in __call__
1196. return self.change_view(request, unquote(url))
File /usr/local/lib/python2.6/dist-packages/Django-1.2.1-py2.6.egg/
django/utils/decorators.py in _wrapper
21. return decorator(bound_func)(*args, **kwargs)
File /usr/local/lib/python2.6/dist-packages/Django-1.2.1-py2.6.egg/
django/utils/decorators.py in _wrapped_view
76. response
Re: starting review #
Just to clarify: yes, this is on creating a rreview draft, so there should be no email involved. The user's browser is shown the Server Error (code 500) page, and the following entry is made in the Transfer/ Apache log: 10.xx.yy.29 - - [11/Oct/2010:20:03:22 -0700] POST /r/new/ HTTP/1.1 500 1622 500 == Server Error, 1622 is the size of locally-reworded ReviewBoard is Unavailable message/screen. This happens on the New Review Request screen, after I've selected an (SVN) Repository, set the component/base path, and browsed to/ supplied a small diff file. When I click Create Review, I get a timeout. As the log above showed, the DiffParser parses the diff, but after that: nada. m@ On Oct 13, 12:51 am, Christian Hammond chip...@chipx86.com wrote: It sounded like this was during the initial creation and not the publishing, in which case there shouldn't be an e-mail yet. But yes, definitely, a local SMTP server is beneficial for performance. I really should write a section of the manual for performance tips such as this. Christian -- Christian Hammond - chip...@chipx86.com Review Board -http://www.reviewboard.org VMware, Inc. -http://www.vmware.com On Tue, Oct 12, 2010 at 10:41 PM, Thilo-Alexander Ginkel th...@ginkel.comwrote: On Tue, Oct 12, 2010 at 23:00, Christian Hammond chip...@chipx86.com wrote: Another possibility is that it's your repository. If that's being slow to reach, things will time out in Review Board. During the creation of a new review request, it tries to access files from there, and can time out if it can't access it. Yet another possibility: The SMTP server. Mails are sent synchronously on review request creation, so if the SMTP server is slow, this will slow down review request creation. Solution: Operate a local SMTP server that relays to the corporate SMTP. Regards, Thilo -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know athttp://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.comreviewboard%2bunsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: ReviewBoard not displaying content of diff file
cogo wrote: I have just started trying out reviewboard and I have some issues with some diffs not beeing displayed when I click View diff in the review request. When i download the diff I can see the content: Index: //trunk/library/extras/global-post-commit-hook.php === --- //trunk/library/extras/global-post-commit-hook.php (revision 1901) +++ //trunk/library/extras/global-post-commit-hook.php (revision 1902) @@ -64,4 +64,4 @@ $revision)); } -// Test \ No newline at end of file +// Test Why does this not get displayed? This looks like a white-space-only-diff issue. There is a config option that _may_ help here (and there is a bug too), see : http://code.google.com/p/reviewboard/issues/detail?id=1780http://code.google.com/p/reviewboard/issues/detail?id=1780 http://code.google.com/p/reviewboard/issues/detail?id=1511 Chris -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
ReviewBoard 1.5 under Apache: IOError when posting review from command line post-review tool
Starting in ReviewBoard 1.5 (Python 2.5.1 linux64 compiled
mod_python.so) the changes to use Paramiko result in this exception
when posting a review changelist (from Perforce) via the commandline
post-review tool.
HTTP POSTing to http://sw-web3.altera.com/review/api/json/accounts/login/:
{'username': 'rromano', 'password': '**'}
Traceback (most recent call last):
File /tools/python/2.5.1/linux64/lib/python2.5/site-packages/
mod_python/importer.py, line 1537, in HandlerDispatch
default=default_handler, arg=req, silent=hlist.silent)
File /tools/python/2.5.1/linux64/lib/python2.5/site-packages/
mod_python/importer.py, line 1229, in _process_target
result = _execute_target(config, req, object, arg)
File /tools/python/2.5.1/linux64/lib/python2.5/site-packages/
mod_python/importer.py, line 1128, in _execute_target
result = object(arg)
File /tools/django/trunk/1.2.3/django/core/handlers/modpython.py,
line 228, in handler
return ModPythonHandler()(req)
File /tools/django/trunk/1.2.3/django/core/handlers/modpython.py,
line 191, in __call__
self.load_middleware()
File /tools/django/trunk/1.2.3/django/core/handlers/base.py, line
40, in load_middleware
mod = import_module(mw_module)
File /tools/django/trunk/1.2.3/django/utils/importlib.py, line 35,
in import_module
__import__(name)
File /usr/local/altera/django/reviewboard/admin/middleware.py,
line 13, in lt;modulegt;
from reviewboard.webapi.json import service_not_configured
File /usr/local/altera/django/reviewboard/webapi/json.py, line 29,
in lt;modulegt;
from reviewboard.diffviewer.forms import EmptyDiffError
File /usr/local/altera/django/reviewboard/diffviewer/forms.py,
line 7, in lt;modulegt;
from reviewboard.diffviewer.diffutils import
DEFAULT_DIFF_COMPAT_VERSION
File /usr/local/altera/django/reviewboard/diffviewer/diffutils.py,
line 29, in lt;modulegt;
from reviewboard.scmtools.core import PRE_CREATION, HEAD
File /usr/local/altera/django/reviewboard/scmtools/core.py, line
5, in lt;modulegt;
from reviewboard.scmtools import sshutils
File /usr/local/altera/django/reviewboard/scmtools/sshutils.py,
line 5, in lt;modulegt;
import paramiko
File /usr/local/altera/django/reviewboard/paramiko/__init__.py,
line 69, in lt;modulegt;
from transport import randpool, SecurityOptions, Transport
File /usr/local/altera/django/reviewboard/paramiko/transport.py,
line 32, in lt;modulegt;
from paramiko import util
File /usr/local/altera/django/reviewboard/paramiko/util.py, line
32, in lt;modulegt;
from paramiko.common import *
File /usr/local/altera/django/reviewboard/paramiko/common.py, line
98, in lt;modulegt;
from rng import StrongLockingRandomPool
File /usr/local/altera/django/reviewboard/paramiko/rng.py, line
44, in lt;modulegt;
if ((platform is not None and platform.system().lower() ==
'windows') or
File /tools/python/2.5.1/linux64/lib/python2.5/platform.py, line
1042, in system
return uname()[0]
File /tools/python/2.5.1/linux64/lib/python2.5/platform.py, line
1014, in uname
processor = _syscmd_uname('-p','')
File /tools/python/2.5.1/linux64/lib/python2.5/platform.py, line
801, in _syscmd_uname
rc = f.close()
IOError: [Errno 10] No child processes
This looks very fundamental. Python's platform.uname() fn does a
subprocess call to `uname` and it's not liked.
Incidentally, under ReviewBoard 1.0.x, I had similar issues in
ReviewBoard's own code using subprocess.POpen to extract diffs from
`p4`. I simply changed the code to use os.system() and it worked fine
thereafter.
Are there known issues with the subprocess.POpen module when running
under Apache?
--
Want to help the Review Board project? Donate today at
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at
http://groups.google.com/group/reviewboard?hl=en
Re: determine git commit sha1 id of last diff revision
Thanks for the feedback but I'm sorry I think I wasn't clear enough here. Here's the workflow post-review mybranch. --publish --revision-range a:b # review #455 diff revision 1 posted Then after getting feedback and making the appropriate changes (and you no longer remember commit revision 'b' sha1 id) posting a new diff for review again: post-review mybranch -r 455 --publish --revision-range ?:c # review ~455 diff revision 2 posted The idea is that someone has posted a diff revision 1 for changes in a branch and then after responding to feedback they want to post diff revision 2 to get further feedback. This is repeated until they get 'ship it' and only then do they merge changes from the branch. Right now they have to go back and determine the sha1 id for the old right hand side to make it the new left hand side. If I could get at the revision 'b' sha1 id from the REST api I could automate determining the revision-range so you only have to do: post-review mybranch -r 455 Cheers, Pete On Oct 12, 6:39 pm, Stephen Gallagher karrde...@gmail.com wrote: On Oct 12, 1:17 pm, Pete C peteraylon...@googlemail.com wrote: After posting a review #455 for a particular branch in git using: post-review --revision-range a:b For a subsequent diff revision I'd like to automatically determine what revision 'b' was in order to do post-review -r 455 --revision-range b:c Unfortunately it looks like I can't query Review Board for revision 'b'. Through the REST api it appears that I can only access the blob ids for each file which makes it difficult to determine the commit id. Am I missing something there? If Review Board could just store the sha1 ids when a diff is generated with post-review it would make it much easier. I can always stick revision 'b' into the description and then parse it out of the description for subsequent diff revisions but then it will only work for reviews posted with my tool and not for reviews posted directly with post-review. You probably want to look into the parent diff functionality. Essentially, you send two diffs, one is the diff you want reviewed, and the other is the diff from something that's already in the repository until just before your patch. It's useful for submitting a series of patches, for example. I submitted a patch for post-review some time ago that does this automatically, but it's been refused.http://reviews.reviewboard.org/r/1472/ -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
AD authentication w/SSPI NTLM integration
Hi all, We're running ReviewBoard 1.5 and have AD authentication working via the Python ldap module but wondered if there might be a way to authenticate the user via NTLM and Apache so they don't have to log in at all? I've installed the SSPI module for Apache 2.2 and added the relevant lines to httpd.conf but it doesn't appear that ReviewBoard is picking this up and carrying it through login. Is this not yet support or have I missed something? If anyone else has this working I'd be grateful to know what SSPI settings you have in httpd.conf. Many thanks :) Ian -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: starting review #
I would expect the Review Board log file to indicate that it's trying to fetch from the repository. That usually comes immediately after the diff parsing. Christian -- Christian Hammond - chip...@chipx86.com Review Board - http://www.reviewboard.org VMware, Inc. - http://www.vmware.com On Wed, Oct 13, 2010 at 7:01 AM, mxbraun matthew.br...@intel.com wrote: Just to clarify: yes, this is on creating a rreview draft, so there should be no email involved. The user's browser is shown the Server Error (code 500) page, and the following entry is made in the Transfer/ Apache log: 10.xx.yy.29 - - [11/Oct/2010:20:03:22 -0700] POST /r/new/ HTTP/1.1 500 1622 500 == Server Error, 1622 is the size of locally-reworded ReviewBoard is Unavailable message/screen. This happens on the New Review Request screen, after I've selected an (SVN) Repository, set the component/base path, and browsed to/ supplied a small diff file. When I click Create Review, I get a timeout. As the log above showed, the DiffParser parses the diff, but after that: nada. m@ On Oct 13, 12:51 am, Christian Hammond chip...@chipx86.com wrote: It sounded like this was during the initial creation and not the publishing, in which case there shouldn't be an e-mail yet. But yes, definitely, a local SMTP server is beneficial for performance. I really should write a section of the manual for performance tips such as this. Christian -- Christian Hammond - chip...@chipx86.com Review Board -http://www.reviewboard.org VMware, Inc. -http://www.vmware.com On Tue, Oct 12, 2010 at 10:41 PM, Thilo-Alexander Ginkel th...@ginkel.comwrote: On Tue, Oct 12, 2010 at 23:00, Christian Hammond chip...@chipx86.com wrote: Another possibility is that it's your repository. If that's being slow to reach, things will time out in Review Board. During the creation of a new review request, it tries to access files from there, and can time out if it can't access it. Yet another possibility: The SMTP server. Mails are sent synchronously on review request creation, so if the SMTP server is slow, this will slow down review request creation. Solution: Operate a local SMTP server that relays to the corporate SMTP. Regards, Thilo -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know athttp://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.comreviewboard%2bunsubscr...@googlegroups.com reviewboard%2bunsubscr...@googlegroups.comreviewboard%252bunsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.comreviewboard%2bunsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: ReviewBoard 1.5 under Apache: IOError when posting review from command line post-review tool
I'm not really sure. This is the first I've heard of this issue. The
call actually comes from paramiko, a Python module we use for the SSH
support. Might be worth seeing if other people outside Review Board
have hit that issue.
Christian
On Wednesday, October 13, 2010, Rob rrom...@gmail.com wrote:
Starting in ReviewBoard 1.5 (Python 2.5.1 linux64 compiled
mod_python.so) the changes to use Paramiko result in this exception
when posting a review changelist (from Perforce) via the commandline
post-review tool.
HTTP POSTing to http://sw-web3.altera.com/review/api/json/accounts/login/:
{'username': 'rromano', 'password': '**'}
Traceback (most recent call last):
File /tools/python/2.5.1/linux64/lib/python2.5/site-packages/
mod_python/importer.py, line 1537, in HandlerDispatch
default=default_handler, arg=req, silent=hlist.silent)
File /tools/python/2.5.1/linux64/lib/python2.5/site-packages/
mod_python/importer.py, line 1229, in _process_target
result = _execute_target(config, req, object, arg)
File /tools/python/2.5.1/linux64/lib/python2.5/site-packages/
mod_python/importer.py, line 1128, in _execute_target
result = object(arg)
File /tools/django/trunk/1.2.3/django/core/handlers/modpython.py,
line 228, in handler
return ModPythonHandler()(req)
File /tools/django/trunk/1.2.3/django/core/handlers/modpython.py,
line 191, in __call__
self.load_middleware()
File /tools/django/trunk/1.2.3/django/core/handlers/base.py, line
40, in load_middleware
mod = import_module(mw_module)
File /tools/django/trunk/1.2.3/django/utils/importlib.py, line 35,
in import_module
__import__(name)
File /usr/local/altera/django/reviewboard/admin/middleware.py,
line 13, in lt;modulegt;
from reviewboard.webapi.json import service_not_configured
File /usr/local/altera/django/reviewboard/webapi/json.py, line 29,
in lt;modulegt;
from reviewboard.diffviewer.forms import EmptyDiffError
File /usr/local/altera/django/reviewboard/diffviewer/forms.py,
line 7, in lt;modulegt;
from reviewboard.diffviewer.diffutils import
DEFAULT_DIFF_COMPAT_VERSION
File /usr/local/altera/django/reviewboard/diffviewer/diffutils.py,
line 29, in lt;modulegt;
from reviewboard.scmtools.core import PRE_CREATION, HEAD
File /usr/local/altera/django/reviewboard/scmtools/core.py, line
5, in lt;modulegt;
from reviewboard.scmtools import sshutils
File /usr/local/altera/django/reviewboard/scmtools/sshutils.py,
line 5, in lt;modulegt;
import paramiko
File /usr/local/altera/django/reviewboard/paramiko/__init__.py,
line 69, in lt;modulegt;
from transport import randpool, SecurityOptions, Transport
File /usr/local/altera/django/reviewboard/paramiko/transport.py,
line 32, in lt;modulegt;
from paramiko import util
File /usr/local/altera/django/reviewboard/paramiko/util.py, line
32, in lt;modulegt;
from paramiko.common import *
File /usr/local/altera/django/reviewboard/paramiko/common.py, line
98, in lt;modulegt;
from rng import StrongLockingRandomPool
File /usr/local/altera/django/reviewboard/paramiko/rng.py, line
44, in lt;modulegt;
if ((platform is not None and platform.system().lower() ==
'windows') or
File /tools/python/2.5.1/linux64/lib/python2.5/platform.py, line
1042, in system
return uname()[0]
File /tools/python/2.5.1/linux64/lib/python2.5/platform.py, line
1014, in uname
processor = _syscmd_uname('-p','')
File /tools/python/2.5.1/linux64/lib/python2.5/platform.py, line
801, in _syscmd_uname
rc = f.close()
IOError: [Errno 10] No child processes
This looks very fundamental. Python's platform.uname() fn does a
subprocess call to `uname` and it's not liked.
Incidentally, under ReviewBoard 1.0.x, I had similar issues in
ReviewBoard's own code using subprocess.POpen to extract diffs from
`p4`. I simply changed the code to use os.system() and it worked fine
thereafter.
Are there known issues with the subprocess.POpen module when running
under Apache?
--
Want to help the Review Board project? Donate today at
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at
http://groups.google.com/group/reviewboard?hl=en
--
--
Christian Hammond - chip...@chipx86.com
Review Board - http://www.reviewboard.org
VMware, Inc. - http://www.vmware.com
--
Want to help the Review Board project? Donate today at
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at
Issue 1850 in reviewboard: Add Show/Hide action to /admin/db/scmtools/repository/ page
Status: New Owner: Labels: Type-Enhancement Priority-Medium New issue 1850 by sergey.sergius: Add Show/Hide action to /admin/db/scmtools/repository/ page http://code.google.com/p/reviewboard/issues/detail?id=1850 *NOTE: If you have a patch, please submit it to http://reviews.reviewboard.org/ What version are you running? 1.5 What's the URL of the page this enhancement relates to, if any? http://reviewboard.server/admin/db/scmtools/repository/ Describe the enhancement and the motivation for it. There is convenient Action combobox on Admin - Repositories page. Currently it has only 1 action: Delete selected repositories. I suggest to add Show selected repositories and Hide. Motivation: currently there are about 200 repositories in our RB instance. They become not used from time to time in groups (e.g. one team can have ~10 forested repositories for release). It would be very convenient to hide them in batch. What operating system are you using? What browser? doesn't matter Please provide any additional information below. thanks a lot for hide feature! -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-iss...@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 1571 in reviewboard: Diff-Upload UI: Base Path field too narrow
Comment #6 on issue 1571 by gorf4673: Diff-Upload UI: Base Path field too narrow http://code.google.com/p/reviewboard/issues/detail?id=1571 Followed to this defect from Issue 1635 We have just upgraded to 1.5 the text width of the base directory and diff fields remains the same. Please see attached image. Attachments: AnnoyinglyShortFields.jpg 161 KB -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-iss...@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 1571 in reviewboard: Diff-Upload UI: Base Path field too narrow
Updates: Status: Confirmed Comment #7 on issue 1571 by trowbrds: Diff-Upload UI: Base Path field too narrow http://code.google.com/p/reviewboard/issues/detail?id=1571 (No comment was entered for this change.) -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-iss...@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
