Re: Trying to upload an id_rsa gives Uploading SSH key failed: This SSH key is not a valid RSA or DSS key error.
Yes, I totally agree. There is no security advantage to be gained. For our case, any user (and reviewboard has its own user) on our network has a password protected rsa key pair so to set up reviewboard required some hoops to be jumped through. Allowing a password just makes setup simpler :) Back to the OT I definitely think a more informative key error message would be good, i.e. why is the rsa key i provided bad? Tim On Tuesday, April 30, 2013 9:19:11 PM UTC+1, mamta.n...@gmail.com wrote: Hi, I'm trying to upload an id_rsa private key to reviewboard to authenticate with Git repo, but it fails with the error Uploading SSH key failed: This SSH key is not a valid RSA or DSS key Permissions on id_rsa were set using chmod 600 Thanks, M -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
Outgoing reviews is showing minus number
Hi, Somehow the dashboard is showing -1 for outgoing reviews. Could someone help on this? https://lh3.googleusercontent.com/-RC8114_3mwM/UYPyK2O05AI/E0c/Sq_vsXI_aN4/s1600/Screen+Shot+2013-05-03+at+10.12.31+AM.png Thanks, Miller -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
Gatekeeping mechanism in Reviewboard?
Hi, My company is currently evaluating between Gerrit and Reviewboard and one of the points that we are debating on is Gatekeeping. Gerrit automatically runs tests after a review is approved and ready to be merged into jenkis. Is there any mechanism in reviewboard to do the same- : eg: Worflow to submit code , review it, run test as ultimately merge it into the desired repository? Thanks, M -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
Re: Automated merge after review continuous integration
Hey David, This is an older post but im actually looking for exactly these things currently and was wondering if these features have been built into reviewboard now / via plugins or are they still in pipeline? Thanks, M On Wednesday, April 20, 2011 3:34:59 PM UTC-7, David Trowbridge wrote: #2 would be great; I know a lot of people have requested the ability to have some indication that the patch submitted will (a) apply cleanly and (b) build (maybe even including automated testing). #1 is often requested, but it's something which we've been wary of because of the complexities of user authentication, audit chains, and the abilities it would introduce to break things. It would be a cool feature, but I think we'd need to approach it carefully. -David On Thu, Apr 14, 2011 at 10:19 AM, Jan Koprowski jan.ko...@gmail.comjavascript: wrote: Hi, Recently i look at Gerrit - review tool dedicated for git guys. Two things bring my attention: 1) Gerrit try to merge code automatically after review. This is great ability. As far I'm aware when merge won't end with success developer get message to rebase their code and send to review again. It will be cool to get something similar at reviewboard. I think this approach will for for Git and probably for Mercurial too. 2) Build system integration. I saw Hudson Gerrit integration which assume additional field for build system which check is project build with new versions or not. It is well exposed at http://source.android.com/source/life-of-a-patch.html. Will be something nice to make accessible some by API checkbox field for build system and approach such workflow in reviewboard - optional ofcourse. What do You think? Regards, Jan -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard...@googlegroups.com javascript: For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
Re: Gatekeeping mechanism in Reviewboard?
On 2013-05-03 16:58, mamta.nanav...@gmail.com wrote: My company is currently evaluating between Gerrit and Reviewboard and one of the points that we are debating on is Gatekeeping. Gerrit automatically runs tests after a review is approved and ready to be merged into jenkis. Is there any mechanism in reviewboard to do the same- : eg: Worflow to submit code , review it, run test as ultimately merge it into the desired repository? Gerrit's UI is rubbish; do your users a favor and go with RB ;-). More seriously, I'm not sure if such functionality exists right this moment, but if not it is (AFAICT) solely from a lack of glue. Between RB's extensions and event system, you should be able - without much difficulty - to write an RB extension to either publish events and/or fire off automated regression tests and such. -- Matthew -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
Re: Gatekeeping mechanism in Reviewboard?
On Fri, May 3, 2013 at 4:02 PM, Matthew Woehlke mwoehlke.fl...@gmail.comwrote: On 2013-05-03 16:58, mamta.nanav...@gmail.com wrote: My company is currently evaluating between Gerrit and Reviewboard and one of the points that we are debating on is Gatekeeping. Gerrit automatically runs tests after a review is approved and ready to be merged into jenkis. Is there any mechanism in reviewboard to do the same- : eg: Worflow to submit code , review it, run test as ultimately merge it into the desired repository? Gerrit's UI is rubbish; do your users a favor and go with RB ;-). More seriously, I'm not sure if such functionality exists right this moment, but if not it is (AFAICT) solely from a lack of glue. Between RB's extensions and event system, you should be able - without much difficulty - to write an RB extension to either publish events and/or fire off automated regression tests and such. Right, it should be doable with an extension. There's no built-in support today. However, something you may want to look into is Review Bot, which is a service that can perform automated code review with Review Board. You could conceivably write a plugin for this. Basically, it would probably just need to invoke a script to perform the build, take the results of that, and return it to the plugin, which would post a review and say whether or not it was successful. If you wanted something deeper than something that posts reviews, you'd write a custom extension. That could even add some UI. Now, Review Board does *not* commit code, so that's important. For a lot of reasons, we leave that up to the user. It's impossible for us to provide a clean, consistent experience across the variety of servers and repository types. Gerrit can do it because it basically just wraps a git repository. It's possible down the road that we'll be able to offer it for services like GitHub that specific APIs for it, but to do it on Git, Review Board would have to do a full clone, merge, resolve conflicts, push, and you know how hard and time-consuming that can be even as a human. Christian -- Christian Hammond - chip...@chipx86.com Review Board - http://www.reviewboard.org Beanbag, Inc. - http://www.beanbaginc.com -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
Re: Issue 2875 in reviewboard: Something broke! (Error 500)It appears something broke when you tried to go to here. This is either a bug in Review Board or a server configuration error. Please report
Comment #3 on issue 2875 by trowb...@gmail.com: Something broke! (Error 500)It appears something broke when you tried to go to here. This is either a bug in Review Board or a server configuration error. Please report this to your administrator. http://code.google.com/p/reviewboard/issues/detail?id=2875 We still need the contents of the logs in order to do anything. -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues?hl=en. For more options, visit https://groups.google.com/groups/opt_out.
