Re: Unable to upgrade reviewboard site

2015-07-02 Thread Noopur Sankhere
Hi Stephen,

I reboot the my machine and then reviewboard started working. My problem is 
resolved now. But I am confused which thing worked. I rebooted my machine 2 
times before also, but didn't work at that time.
 
Thanks for your support :)

On Thursday, 2 July 2015 11:24:34 UTC+5:30, Noopur Sankhere wrote:

 Also, I have exceuted following commands:

 1) setsebool -P httpd_can_sendmail 1 
 2) setsebool -P httpd_can_network_memcache 1
 3) disabled selinux in /etc/selinux/config file
 4) restart mysqld and httpd service


 On Thursday, 2 July 2015 10:49:16 UTC+5:30, Noopur Sankhere wrote:

 Yes. I added reviewboard.niit-mts.com.conf ([sitename].conf ) 
 to  /etc/httpd/conf.d. Also disabled firewall service.

 I am getting this page:

 Manual server updates required

 A recent upgrade requires manual updates to be made on this server. After 
 these changes are made, you should restart your web server.

 If you have any questions or problems, please contact us on our mailing 
 list http://groups.google.com/group/reviewboard.
 Data directory changes

 Your site's data directory isn't properly set up. This directory is where 
 Review Board will store various state and configuration needed to access 
 repositories.

 Your data directory is currently at: /var/www/
 reviewboard.niit-mts.com/data
 Permission problems

 The data directory must be writable by the web server. On Linux/Unix/Mac, 
 you can fix this by typing:

 $ sudo chown -R apache /var/www/reviewboard.niit-mts.com/data

 On Windows, right-click the data directory and change the ownership to 
 apache and restart the server.
 Extensions static media directory changes

 Your site's extensions static media directory isn't properly set up. This 
 directory is where Review Board will store various extension media files.

 Your extensions static media directory is currently at: /var/www/
 reviewboard.niit-mts.com/htdocs/media/ext
 Permission problems

 The directory must be writable by the web server. On Linux/Unix/Mac, you 
 can fix this by typing:

 $ sudo chown -R apache 
 /var/www/reviewboard.niit-mts.com/htdocs/media/ext 



 I have given above permissions already.

  


-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
reviewboard group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


Re: Unable to upgrade reviewboard site

2015-07-02 Thread Stephen Gallagher
If I was to guess, I'd say that the issue
was resolved by rebooting after editing /etc/selinux/config, which doesn't
take effect until reboot. (You can change it within a single live runtime
with setenforce 0. I'd like for you to do audit2why -a as root and
attach the output so I can try to figure out why SELinux was in the way.

I suspect it may be because you installed into /var/www rather than the
default (Fedora) location of /var/lib/reviewboard/sites .

All of the SELinux rules are based on things being installed into that
location. On recent versions of RB, if you don't specify a path, just a
name of the site, this is where it will go (e.g. rb-site install mysitename)
On Thu, Jul 2, 2015 at 2:13 AM Noopur Sankhere noopur.sankher...@gmail.com
wrote:

 Hi Stephen,

 I reboot the my machine and then reviewboard started working. My problem
 is resolved now. But I am confused which thing worked. I rebooted my
 machine 2 times before also, but didn't work at that time.

 Thanks for your support :)

 On Thursday, 2 July 2015 11:24:34 UTC+5:30, Noopur Sankhere wrote:

 Also, I have exceuted following commands:

 1) setsebool -P httpd_can_sendmail 1
 2) setsebool -P httpd_can_network_memcache 1
 3) disabled selinux in /etc/selinux/config file
 4) restart mysqld and httpd service


 On Thursday, 2 July 2015 10:49:16 UTC+5:30, Noopur Sankhere wrote:

 Yes. I added reviewboard.niit-mts.com.conf ([sitename].conf )
 to  /etc/httpd/conf.d. Also disabled firewall service.

 I am getting this page:

 Manual server updates required

 A recent upgrade requires manual updates to be made on this server.
 After these changes are made, you should restart your web server.

 If you have any questions or problems, please contact us on our mailing
 list http://groups.google.com/group/reviewboard.
 Data directory changes

 Your site's data directory isn't properly set up. This directory is
 where Review Board will store various state and configuration needed to
 access repositories.

 Your data directory is currently at: /var/www/
 reviewboard.niit-mts.com/data
 Permission problems

 The data directory must be writable by the web server. On
 Linux/Unix/Mac, you can fix this by typing:

 $ sudo chown -R apache /var/www/reviewboard.niit-mts.com/data

 On Windows, right-click the data directory and change the ownership to
 apache and restart the server.
 Extensions static media directory changes

 Your site's extensions static media directory isn't properly set up.
 This directory is where Review Board will store various extension media
 files.

 Your extensions static media directory is currently at: /var/www/
 reviewboard.niit-mts.com/htdocs/media/ext
 Permission problems

 The directory must be writable by the web server. On Linux/Unix/Mac, you
 can fix this by typing:

 $ sudo chown -R apache 
 /var/www/reviewboard.niit-mts.com/htdocs/media/ext



 I have given above permissions already.



  --
 Supercharge your Review Board with Power Pack:
 https://www.reviewboard.org/powerpack/
 Want us to host Review Board for you? Check out RBCommons:
 https://rbcommons.com/
 Happy user? Let us know! https://www.reviewboard.org/users/
 ---
 You received this message because you are subscribed to the Google Groups
 reviewboard group.
 To unsubscribe from this group and stop receiving emails from it, send an
 email to reviewboard+unsubscr...@googlegroups.com.
 For more options, visit https://groups.google.com/d/optout.


-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
reviewboard group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


Depends-On, Blocks and Circular Reference

2015-07-02 Thread Daniel Laird
WE are running 2.0.17 and have managed to create a situation and dont know 
how to resolve it - or whether its a defect

Someone created 2 reviews with code changes that were dependent.
They marked Review 2 as Depends On Review 1 -  this then updated the 
'Blocks' field.
They then marked Review 1 as Depends On Review 2 - as they felt that both 
reviews had to be committed together.

However the server then starts to give us lots of errors:
Traceback (most recent call last):

  File 
/usr/local/lib/python2.7/dist-packages/Django-1.6.11-py2.7.egg/django/core/handlers/base.py,
 
line 199, in get_response
response = middleware_method(request, response)

  File 
/usr/local/lib/python2.7/dist-packages/Django-1.6.11-py2.7.egg/django/middleware/http.py,
 
line 14, in process_response
response['Content-Length'] = str(len(response.content))

  File 
/usr/local/lib/python2.7/dist-packages/Djblets-0.8.20-py2.7.egg/djblets/webapi/responses.py,
 
line 109, in _get_content
**self.encoder_kwargs)

  File 
/usr/local/lib/python2.7/dist-packages/Djblets-0.8.20-py2.7.egg/djblets/webapi/encoders.py,
 
line 110, in encode
return super(JSONEncoderAdapter, self).encode(o)

  File /usr/lib/python2.7/json/encoder.py, line 201, in encode
chunks = self.iterencode(o, _one_shot=True)

  File /usr/lib/python2.7/json/encoder.py, line 264, in iterencode
return _iterencode(o, 0)

ValueError: Circular reference detected

It maybe that the double linking is incorrect usage - however having been 
able to get into that situation.  If we try to remove one of the 'Blocks' 
fields we just get a spinning 'Loading' icon and are unable to move past 
this to remove the Circular Reference.

Not sure if you think this is user error, a defect or a combination of both 
- but thought I would share it.

Cheers
Dan

-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
reviewboard group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


Re: Issue 3905 in reviewboard: ValueError: Unable to parse connection string: localhost

2015-07-02 Thread reviewboard


Comment #1 on issue 3905 by naraya...@techaspect.com: ValueError: Unable to  
parse connection string: localhost

https://code.google.com/p/reviewboard/issues/detail?id=3905

Modified the site settings in Database took care of the issue.

--
You received this message because this project is configured to send all  
issue notifications to this address.

You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at http://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.


Re: Error: The specified diff file could not be parsed

2015-07-02 Thread David Trowbridge
The actual error is buried in there: Authentication failed when talking to
the Subversion repository

What this means is that the SVN repository configured in the Review Board
admin page doesn't have the correct credentials.

-David

-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
reviewboard group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


Issue 3908 in reviewboard: rbt post --diff-filename is broken in RBTools 0.6.3 and 0.7.3

2015-07-02 Thread reviewboard

Status: New
Owner: 
Labels: Type-Defect Priority-Medium

New issue 3908 by seide.al...@gmail.com: rbt post --diff-filename is broken  
in RBTools 0.6.3 and 0.7.3

https://code.google.com/p/reviewboard/issues/detail?id=3908

*** READ THIS BEFORE POSTING!
***
*** You must complete this form in its entirety, or your bug report will be
*** rejected.
***
*** If you have a security issue to report, please send it confidentially
to
*** secur...@reviewboard.org. Posting security-related issues to this bug
*** tracker causes us to have to do an emergency release.
***
*** For customer support, please post to reviewbo...@googlegroups.com
***
*** If you have a patch, please submit it to
http://reviews.reviewboard.org/
***
*** This bug tracker is public. Please check that any logs or other
information
*** that you include has been stripped of confidential information.


What version are you running?

RBTools 0.6.3, 0.7.3


What's the URL of the page containing the problem?

NA

What steps will reproduce the problem?
1.  Use 'rbt diff'  mydiff to create a proper diff file
2.  rbt post --diff-filename mydiff CL


What is the expected output? What do you see instead?

I expect a review with diff uploaded. Instead I get this:

Traceback (most recent call last):
  File /home/sallan/envs/rbtools-0.7.3/bin/rbt, line 9, in module
load_entry_point('RBTools==0.7.3', 'console_scripts', 'rbt')()
   
File /home/sallan/envs/rbtools-0.7.3/lib/python2.6/site-packages/RBTools-0.7.3-py2.6.egg/rbtools/commands/main.py,  
line 133, in main

command.run_from_argv([RB_MAIN, command_name] + args)
   
File /home/sallan/envs/rbtools-0.7.3/lib/python2.6/site-packages/RBTools-0.7.3-py2.6.egg/rbtools/commands/__init__.py,  
line 612, in run_from_argv

exit_code = self.main(*args) or 0
   
File /home/sallan/envs/rbtools-0.7.3/lib/python2.6/site-packages/RBTools-0.7.3-py2.6.egg/rbtools/commands/post.py,  
line 751, in main

if repository_info.supports_changesets and 'changenum' in diff_info:
UnboundLocalError: local variable 'diff_info' referenced before assignment


Same problem with RBTools 0.6.3.
Works correctly in 0.5.2.

What operating system are you using? What browser?

Mac OS-X, CentOS 6.6
Python 2.6.6
RB 1.7.28
Firefox, Safari, Chrome

Please provide any additional information below.

RBTools 0.5.2  :  works
RBTools 0.6.3  :  error
RBTools 0.7.3  :  error



--
You received this message because this project is configured to send all  
issue notifications to this address.

You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at http://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.


Error: The specified diff file could not be parsed

2015-07-02 Thread dongxiang luo
Below is my command:

rbt post --debug --description test desc --summary test summary 
 --target-groups=gameDesign   47515


If the revision contains a added file , the command can work.

If the revision contains a updated file , it reports error:




 RBTools 0.7.4
 Python 2.6.6 (r266:84292, Feb 22 2013, 00:00:18) 
[GCC 4.4.7 20120313 (Red Hat 4.4.7-3)]
 Running on Linux-2.6.32-358.el6.x86_64-x86_64-with-centos-6.4-Final
 Home = /root
 Current directory = /var/www/html/repo/data
 Running: git version
 Checking for a Subversion repository...
 Running: svn --non-interactive info
 Running: diff --version
 Running: svn --non-interactive --version -q
 repository info: Path: http://mydevsvn.net/M9, Base path: 
/server/trunk/data, Supports changesets: False
 Making HTTP GET request to http://192.168.180.33/api/
 Making HTTP GET request to http://192.168.180.33/api/repositories/
 Cached response for HTTP GET http://192.168.180.33/api/repositories/ 
expired and was modified
 Running: svn --non-interactive log --xml -r 47515 -l 1
 Running: svn --non-interactive info
 Running: diff --version
 Running: svn --non-interactive --version -q
 repository info: Path: http://mydevsvn.net/M9, Base path: 
/server/trunk/data, Supports changesets: False
 Running: svn --non-interactive diff --diff-cmd=diff --notice-ancestry 
-r 47514:47515
 Running: svn --non-interactive info function_level_info.xml
 Running: svn --non-interactive diff --diff-cmd=diff --notice-ancestry 
-r 47514:47515 --no-diff-deleted
 Running: svn --non-interactive info function_level_info.xml
 Running: svn --non-interactive info function_level_info.xml
 Running: svn --non-interactive info function_level_info.xml
 Making HTTP GET request to http://192.168.180.33/api/validation/diffs/
 Cached response for HTTP GET 
http://192.168.180.33/api/validation/diffs/ expired and was modified
 Making HTTP POST request to http://192.168.180.33/api/validation/diffs/
 Got API Error 224 (HTTP code 400): The specified diff file could not be 
parsed.
 Error data: {u'stat': u'fail', u'reason': u'Authentication failed when 
talking to the Subversion repository', u'err': {u'msg': u'The specified 
diff file could not be parsed.', u'code': 224}}
Traceback (most recent call last):
  File /usr/bin/rbt, line 9, in module
load_entry_point('RBTools==0.7.4', 'console_scripts', 'rbt')()
  File 
/usr/lib/python2.6/site-packages/RBTools-0.7.4-py2.6.egg/rbtools/commands/main.py,
 
line 133, in main
command.run_from_argv([RB_MAIN, command_name] + args)
  File 
/usr/lib/python2.6/site-packages/RBTools-0.7.4-py2.6.egg/rbtools/commands/__init__.py,
 
line 612, in run_from_argv
exit_code = self.main(*args) or 0
  File 
/usr/lib/python2.6/site-packages/RBTools-0.7.4-py2.6.egg/rbtools/commands/post.py,
 
line 754, in main
(msg_prefix, e))
rbtools.commands.CommandError: Error validating diff

The specified diff file could not be parsed. (HTTP 400, API Error 224)



-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
reviewboard group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


RBTools: rbt post --diff-filename broken in 0.6.3 and 0.7.x

2015-07-02 Thread Steve
We recently upgraded from RBTools 0.5.2 to 0.6.3 (Certain bugs in 0.7.x 
prevent us from upgrading to that version).  One of my users found the 
--diff-filename option no longer works:

$ rbt post --diff-filename mydiff 823

Traceback (most recent call last):
  File /home/sallan/envs/rbtools-0.7.3/bin/rbt, line 9, in module
load_entry_point('RBTools==0.7.3', 'console_scripts', 'rbt')()
  File 
/home/sallan/envs/rbtools-0.7.3/lib/python2.6/site-packages/RBTools-0.7.3-py2.6.egg/rbtools/commands/main.py,
 line 133, in main
command.run_from_argv([RB_MAIN, command_name] + args)
  File 
/home/sallan/envs/rbtools-0.7.3/lib/python2.6/site-packages/RBTools-0.7.3-py2.6.egg/rbtools/commands/__init__.py,
 line 612, in run_from_argv
exit_code = self.main(*args) or 0
  File 
/home/sallan/envs/rbtools-0.7.3/lib/python2.6/site-packages/RBTools-0.7.3-py2.6.egg/rbtools/commands/post.py,
 line 751, in main
if repository_info.supports_changesets and 'changenum' in diff_info:
UnboundLocalError: local variable 'diff_info' referenced before assignment



Same error with 0.6.3.  The same command works properly with RBTools 0.5.2.  I 
opened issue 3908, but I wanted to post here as well for greater visibility.


Thanks


--Steve 


-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
reviewboard group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


Issue 3909 in reviewboard: Change Description diff highlighting for changed part of line is incorrect

2015-07-02 Thread reviewboard

Status: Accepted
Owner: 
Labels: Type-Defect Priority-Medium Component-ChangeDescriptions

New issue 3909 by ste...@smacleod.ca: Change Description diff highlighting  
for changed part of line is incorrect

https://code.google.com/p/reviewboard/issues/detail?id=3909

What version are you running?
2.0.17

What's the URL of the page containing the problem?
/r/rr-id/

It appears the highlighting for which part of a line changed in change  
description diffs can be incorrect. A screenshot of the issue can be found  
at

https://bug1179930.bugzilla.mozilla.org/attachment.cgi?id=8629020

This was filed against MozReview as  
https://bugzilla.mozilla.org/show_bug.cgi?id=1179930 with the relavant  
review request being https://reviewboard.mozilla.org/r/12289/



The problematic changedescription contains the following:

{u'diff': {u'added': [[u'Diff r2', u'/r/12289/diff/2/', 25957]]},  
u'description': {u'new': [u'Bug 1178892 - Split the profiler into Core   
Gecko files and break apart monolithic headers. r=mstange'], u'old': [u'Bug  
1178892 - Split the profiler into Core  Gecko files and break apart  
monolithic headers. r?mstange']}, u'summary': {u'new': [u'Bug 1178892 -  
Split the profiler into Core  Gecko files and break apart monolithic  
headers. r=mstange'], u'old': [u'Bug 1178892 - Split the profiler into Core  
 Gecko files and break apart monolithic headers. r?mstange']}}



--
You received this message because this project is configured to send all  
issue notifications to this address.

You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at http://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.


Re: Can't review PDF using Power Pack

2015-07-02 Thread Melroy van den Berg
Hi Christian,

After some debugging, try  error. I found out the following:

   - Uploading PDF works under Windows using Firefox webbrowser, after it 
   is uploaded will render a thumbnail, so you can use the Document Review 
   tool of this Power Pack.
   - Uploading  review also works under Linux using Chrome, again a 
   thumbnail appears
   - However, uploading does work, but it won't start generating a 
   thumbnail at all under *Firefox* under Linux (*Linux Mint*). I'm using 
   Firefox 38, I guess one of the latest versions. 
   I also restarted Firefox with the 'All add-ons disabled' feature, still 
   without luck.

Conclusion: Firefox under Linux + Power Pack doesn't work as expected. I 
can't use upload feature to upload a PDF for review under Firefox Linux.


I also tried to debug using the build-in console, there is no Javascript 
error so far. It just seems the javascript just stops, instead of reading 
the PDF file and try to create a TOC and thumbnail for the review.


I hope you can help me further.


Kind regards,

Melroy van den Berg




Op maandag 29 juni 2015 21:54:52 UTC+2 schreef Christian Hammond:

 Allow code profiling doesn't by itself log any additional information. 
 It's used to help diagnose things along with other arguments.

 Can you try reloading your web server, then shift-reload the review 
 request page again?

 Christian

 -- 
 Christian Hammond - chri...@beanbaginc.com javascript:
 Review Board - http://www.reviewboard.org
 Beanbag, Inc. - http://www.beanbaginc.com

 On Mon, Jun 29, 2015 at 12:36 PM, Melroy van den Berg webmas...@gmail.com 
 javascript: wrote:

 Futhermore, Allow code profiling doesn't help me either.

 Op maandag 29 juni 2015 21:31:23 UTC+2 schreef Melroy van den Berg:

  The only line I got after enabling logging in debug is:

 2015-06-29 19:25:53,085 - INFO -  - Reloading logging settings


 That is strange right? After uploading a new document (PDF)? I would 
 like to see more debug info... Well, no errors at this for sure. 

  -- 
 Supercharge your Review Board with Power Pack: 
 https://www.reviewboard.org/powerpack/
 Want us to host Review Board for you? Check out RBCommons: 
 https://rbcommons.com/
 Happy user? Let us know! https://www.reviewboard.org/users/
 --- 
 You received this message because you are subscribed to the Google Groups 
 reviewboard group.
 To unsubscribe from this group and stop receiving emails from it, send an 
 email to reviewboard...@googlegroups.com javascript:.
 For more options, visit https://groups.google.com/d/optout.




-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
reviewboard group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.